Clean up creating handles from `this`.
Make these member functions static and take an additional
parameter `Handle<.> h_this`. Callers mostly already have
a Handle<> to pass, so we avoid an extra StackHandleScope.
This pattern was already used for some functions.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing --interpreter
Change-Id: I4f4478b0526bcb2f3c23305d3b3cc4a65fff9ff5
diff --git a/runtime/native/java_lang_String.cc b/runtime/native/java_lang_String.cc
index 2d9e7dc..7c7c553 100644
--- a/runtime/native/java_lang_String.cc
+++ b/runtime/native/java_lang_String.cc
@@ -105,8 +105,9 @@
static jcharArray String_toCharArray(JNIEnv* env, jobject java_this) {
ScopedFastNativeObjectAccess soa(env);
- ObjPtr<mirror::String> s = soa.Decode<mirror::String>(java_this);
- return soa.AddLocalReference<jcharArray>(s->ToCharArray(soa.Self()));
+ StackHandleScope<1u> hs(soa.Self());
+ Handle<mirror::String> s = hs.NewHandle(soa.Decode<mirror::String>(java_this));
+ return soa.AddLocalReference<jcharArray>(mirror::String::ToCharArray(s, soa.Self()));
}
static JNINativeMethod gMethods[] = {