)]}' { "log": [ { "commit": "085f3805cdfde5fdb130e31a2cf83071598ef082", "tree": "1d810eafd26920874e9a9ad686c66a3b6fdceda3", "parents": [ "1926f2e0fb30df3eb95868da07d09bd100af661c" ], "author": { "name": "Andreas Gampe", "email": "agampe@fb.com", "time": "Fri Mar 06 17:06:49 2020 +0000" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Mar 11 14:58:49 2020 +0000" }, "message": "Revert^4 \"[art] Enable compilation of secondary dexes by default i...\"\n\nThis reverts commit f5d83b3a550496f6ef120606de9920b3fb85baf1.\n\nReason for revert: Blacklist more tests expected to fail. Fix up\n run script.\n\nBug: 149098478\nTest: art/test/testrunner/testrunner.py -b --host\nTest: art/test/testrunner/testrunner.py -b --host -t 596-app-images -t 660-clinit\nTest: art/test/testrunner/testrunner.py -b --host -t 597-app-images-same-classloader\nTest: art/test/testrunner/testrunner.py -b --host --debuggable\nTest: art/test/testrunner/testrunner.py -b --host --all-jvmti -t 596 -t 597-app-images-same-classloader\nTest: art/test/testrunner/testrunner.py -b --target -t 596 -t 597-app-images-same-classloader\nChange-Id: If84e1cb941e64be9907cd7e9ce1ec30ce32f46c7\n" }, { "commit": "f5d83b3a550496f6ef120606de9920b3fb85baf1", "tree": "ee844789b7f86c66e6877c6110c6376cb6fdd7a7", "parents": [ "9a01d30bd78d90491a829ce1b06ede01f21fbf67" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Mar 06 09:03:40 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Mar 06 09:03:40 2020 +0000" }, "message": "Revert \"Revert^2 \"[art] Enable compilation of secondary dexes by default i...\"\"\n\nThis reverts commit 9a01d30bd78d90491a829ce1b06ede01f21fbf67.\n\nReason for revert: https://ci.chromium.org/p/art/builders/ci/host-x86_64-cdex-fast/3169?\n\nChange-Id: Ia8ca15f9e3e956ad241851d8d722e70480e923d4\n" }, { "commit": "9a01d30bd78d90491a829ce1b06ede01f21fbf67", "tree": "e5e897311284c6541382fcac534e0302930a8d46", "parents": [ "310432e7c8b36a2d112376fb76369d4c2487763d" ], "author": { "name": "Dan Zimmerman", "email": "danzimm@fb.com", "time": "Mon Feb 10 07:08:48 2020 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 05 18:28:31 2020 +0000" }, "message": "Revert^2 \"[art] Enable compilation of secondary dexes by default i...\"\n\nReason for revert: blacklist unsupported cases. Underlying issues have been\n fixed in other CLs.\n\nMerges the three separate original CLs.\n\nBug: 149098478\nTest: art/test/testrunner/testrunner.py -b --host\nTest: art/test/testrunner/testrunner.py -b --host -t 596-app-images -t 660-clinit\nTest: art/test/testrunner/testrunner.py -b --host -t 597-app-images-same-classloader\nTest: art/test/testrunner/testrunner.py -b --host --debuggable\nChange-Id: I0ffdfcc7788b76c16cbbde73e0b377062b18a905\n" }, { "commit": "f7e99d5ba0d55effc03986815a41f5d3ea703537", "tree": "dd7795f5fba033ff90c95a780be4757b3f722419", "parents": [ "439c752186f5d5d21837f105e6ac86d68030a6b2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Feb 09 22:21:26 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Feb 09 22:24:50 2020 +0000" }, "message": "Revert \"[art] Fix, re-enable and expand 596-app-images\"\n\nRevert \"[dexopt] Allow secondary dex files to generate app images\"\n\nRevert submission 1210624-secimg\n\nBug: 149098478\nBug: 149168708\n\nReason for revert: Tests fail on device\nReverted Changes:\nI87a0c2698: [art] Fix, re-enable and expand 596-app-images\nI73592c597: [art] Enable compilation of secondary dexes by def...\nI6cff0c8f2: [art] Expand test coverage of secondary app images...\nIaa04175ee: [dexopt] Allow secondary dex files to generate app...\n\nChange-Id: Ibfcf6e050346f525585fc9678c49abbb753538a8\n" }, { "commit": "7c918ee21f9d7c191e1e080265706847a55b00e9", "tree": "1fb5a84e032d11e096deb09da5f9409219c5883e", "parents": [ "73b6aa9fd182603cee4baad16adab66d2f63ef78" ], "author": { "name": "Dan Zimmerman", "email": "danzimm@fb.com", "time": "Thu Jan 02 06:18:17 2020 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 07 22:37:33 2020 +0000" }, "message": "[art] Fix, re-enable and expand 596-app-images\n\nPreviously the test was failing because the app image didn\u0027t contain any\npreloaded classes. This CL introduces a profile which includes all the\nclasses we need pre-optimized for the test. Beyond fixing the test I\nexpanded the test coverage to include:\n\n- Verifying classes that aren\u0027t in the profile aren\u0027t in the app image\n (i.e. this verifies that if a class isn\u0027t used during startup it won\u0027t\n be included in the app image)\n- Verifying loading second app images works\n\nAdditionally I broke out each block of tests into individual test functions\nand reformatted the Main.java file so that navigating it is a bit\neasier.\n\nIt looks like 660-clinit depends on the same JNI code, so I made a\nchange there too.\n\nTest: test/testrunner/testrunner.py -b --host -t 596-app-images -t 660-clinit\nBug: 149098478\nChange-Id: I87a0c26989f045f8086df0a179ed0ddeeb11a471\n" }, { "commit": "0c2c222733f3bb1dc9848f4f127a47046fda6221", "tree": "bf46d1a9d1bf38dcbd01947b5ffcc28e659fbdef", "parents": [ "1a225a76ee6bc29833aee048b6cfae20242bdc8b" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Fri Aug 04 14:36:17 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 18 17:13:59 2019 +0000" }, "message": "Revert^2 \"Support clinit for app image during compilation\"\n\nAdd some spot fixes for app image class initialization and re-enable\ntest 660 features.\n\nBug: 70735003\nTest: test-art-host\n\nThis reverts commit abadf024efdc632f663d7fb503cd277b3f65fca2.\n\nChange-Id: Id16fd3ada3eb1bd57ea60c3cdc4a0cf9835950d7\n" }, { "commit": "abadf024efdc632f663d7fb503cd277b3f65fca2", "tree": "6bfe3372b598db23ef29da29436b3e86a75d9f78", "parents": [ "19b59155991b16755c4d5c012aa222f67a2817aa" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Aug 03 08:25:41 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Aug 03 08:27:20 2017 +0000" }, "message": "Revert \"Support clinit for app image during compilation\"\n\nBreaks on bots.\n\nThis reverts commit 50ce4414a6154ee2d9eeaa27237d80b685e5acf1.\n\nChange-Id: I39d856dc76b55788b6775ff2269eb8570742c6ff\n" }, { "commit": "50ce4414a6154ee2d9eeaa27237d80b685e5acf1", "tree": "85805e0dc0f97d4fd60726151b8d197a33f0ee9b", "parents": [ "42e88a0e5ffaba52fcf0888b5cab0eff3e2ec351" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Fri Jul 21 12:21:26 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Wed Aug 02 13:16:39 2017 -0700" }, "message": "Support clinit for app image during compilation\n\nEnabled compiler driver to start initialization process for classes with\nstatic class initializers if debuggable flag is not setted because this\nmight change the behaviour of interpreter (although invisible to user),\ne.g. the memory heap at startup will contains initialization results.\n\nUpdated two testcases to reflect the change of heap memory before\nclasses are initialized.\n\nEnabled testcase 660-clinit to test whether class initializers are\nexecuted.\n\nThis CL have to be submitted after /c/432328, /c/432154, /c/433242 and\n/c/433342 because without that four this will break the build. Besides,\nthe other four CL will be tested in this CL.\n\nTest: make test-art-host -j64\nChange-Id: Ia25b9e18bdcd0fa3619be0058d459651f3b9a492\n" }, { "commit": "ec37325750ea4ab99c5a4db45b3431206af84dba", "tree": "e8388e5cb3d5a62a36eb8ac191b5ccd2e3ebc3b5", "parents": [ "adbb91c9c685a0a8d92c81dc5a897a520712c7dd" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Thu Jul 13 17:51:52 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Sat Jul 29 17:15:24 2017 -0700" }, "message": "Fix unexpected circular dependency check\n\nThe PruneObjectReferenceVisitor, responsible for traversal instances of\na class, to avoid circular dependenceis which makes infinite recursion,\nshould only record an object received if it\u0027s not a ClassClass, because\nthe processing of ClassClass objects will be forwarded to\nPruneAppImageClassInternal, which will first check circular\ndependencies.\n\nTest: make test-art-host -j64\nChange-Id: Ib056d3fcd02135992b09f7d28176da3a1173d42e\n" }, { "commit": "adbb91c9c685a0a8d92c81dc5a897a520712c7dd", "tree": "1ccdf5224347c7cc0e1d551e2df74128a6c0a6be", "parents": [ "bd208d8e73084b691d9cfbe870120fe53863ce07" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Mon Jul 17 11:23:55 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Sat Jul 29 17:15:24 2017 -0700" }, "message": "Fix recursive initialization on app image.\n\nAssume class B extends class A and class A\u0027s clinit tries to instantiate\nclass B as a field. In this case, class A is under initializing but\nClassLinker allows initialize B as class A is initialized. If class B is\ninitialized successfully and transaction is commited then class A abort\nthe transaction, status of class B will not be reverted.\n\nFixed by a simple approach, when compiling images, AotClassLinker does\nnot allow initialize a subclass when it\u0027s superclass is not fully\ninitialized.\n\nA testcase produce this error is added in /c/433381\n\nTest: make test-art-host -j64\n\nChange-Id: Ic6bcbf1a5162d0e6ec26979b336c0f644a1c39bc\n" }, { "commit": "bd208d8e73084b691d9cfbe870120fe53863ce07", "tree": "9b2b20a1aeae2cba97a394f7b106ba31dbaf565a", "parents": [ "83ee165fd4fde2d7939449881159e2e4b5d3b79d" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Wed Jul 12 14:53:17 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Sat Jul 29 17:15:24 2017 -0700" }, "message": "Read and write constraints for clinit\n\nFor clinits executed during pre-compile within a transaction, they are\nconstrained to only be able to access their own static fields because\nthe results of iniitialization relying on static fields, either read or\nwrite, of other classes are runtiime determined.\n\nFurther discussion can be found at b/62887449.\n\nWhen SGET and SPUT series instructions are executed, interpreter will\ncheck whether fields are static and does the target match with the\ntransaction owner, if not, abort transaction and throw an exception.\n\nTest: make test-art-host -j64\nBug: 62887449\nChange-Id: I3e655269c8af5f0b3f2c1841fdd2602c827c2757\n" }, { "commit": "3a3abd08ca92636a706c0efa777c0410258ebd5f", "tree": "dd2be6fb1cd5e70283c44017cdb4d6e0aa723e9b", "parents": [ "84b65e977302e1cf16d188636c22c164c7793554" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Tue Jul 18 16:04:52 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Fri Jul 21 15:24:32 2017 -0700" }, "message": "Test case for clinit support in app image\n\nAdd a new test case to test how class initializers are executed in\ndifferent situations. Currently clinit for app image is not supported.\n\nTest: make test-art-host -j64\nChange-Id: I5218a57c14eae29299762da3f610d163a16b0b68\n" } ] }