)]}' { "log": [ { "commit": "095dc4611b8001861f8d0e621f9df704a933754a", "tree": "edbbd5b116d8caaceb4ce4605343f3e0d59c11c1", "parents": [ "ed29dcee8b5d7e62bb119d2366f3b95dd5f96163" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 17 16:40:28 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 24 09:06:03 2020 +0000" }, "message": "Move the profiling info out of ArtMethod.\n\nInstead, keep a map in JitCodeCache.\n\nBug: 112676029\nTest: test.py\nChange-Id: I5ab769a9b7b3214af7832478d1b06c9e9adbf8b8\n" }, { "commit": "60ef3997cbcd866c505e51ecde7f06a0535110a0", "tree": "9c9054afcb9debf6edffc1f40987a4540c83561f", "parents": [ "d9af38a3b76fc54909148456da2701666bade6e0" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Aug 07 07:49:57 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 10 08:01:52 2020 +0000" }, "message": "Reland \"Cleanups around the creation of ProfilingInfo.\"\n\nThis reverts commit a996425197a7946eae02d218f70610a853f2fe9a.\n\nBug: 112676029\n\nReason for revert: Fixed JitCodeCache::InvalidateAllCompiledCode and\n ForceJitCompiled.\n\nChange-Id: Ia87fda1bb40c504d9294e447f899ac1797ae98fc\n" }, { "commit": "a996425197a7946eae02d218f70610a853f2fe9a", "tree": "402596c3af0e7928d7c19c3773ea02cb507998b1", "parents": [ "193b696b1c35a49d4173c8b669a4ed79cb24748a" ], "author": { "name": "Lokesh Gidra", "email": "lokeshgidra@google.com", "time": "Thu Aug 06 21:20:55 2020 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 06 22:51:54 2020 +0000" }, "message": "Revert \"Cleanups around the creation of ProfilingInfo.\"\n\nThis reverts commit 0fa304ee0fa63149222bfc6756f56cd285c56bd1.\n\nReason for revert: 685-deoptimizeable test is failing on\nhost debuggable (and cdex-redefine-stress-jit once) targets\n\nBug: 112676029\nTest: ./test.py --host --debuggable\nChange-Id: I88cf51ec48d704f966066ea9f2dbb17d32648f5a\n" }, { "commit": "0fa304ee0fa63149222bfc6756f56cd285c56bd1", "tree": "c77efb7ddb945b38c5eb322b464b89545822af6e", "parents": [ "84eb3c927c5a90aaa63b8e82420689b4ac978730" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Aug 05 15:29:46 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Aug 06 15:25:24 2020 +0000" }, "message": "Cleanups around the creation of ProfilingInfo.\n\nCreate a ProfilingInfo only when we are going to compile baseline.\n\nTest: test.py\nBug: 112676029\n\nChange-Id: I3fa0ef0f29fc955774d4960fef8274b99a9e3432\n" }, { "commit": "9c7b4f1f50cfecc8ac8a8db27ab3434384ec5fab", "tree": "7b7091cc6705fec1cafeb93f551b2fb9d8936c14", "parents": [ "55cc5868ec31b2b71f3d69ed6283e5f75c065d99" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 03 15:22:59 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Aug 05 12:36:48 2020 +0000" }, "message": "Remove obsolete saved_entry_point field in ProfilingInfo.\n\nIt was used for doing GC of jit code, but we are now relying on baseline\nfor giving that information.\n\nBug: 112676029\nTest: test.py\nChange-Id: Icb7c7b6adfe77a30500d53505b391b9d3aad19e6\n" }, { "commit": "853fc2ea8c4fb30d71adb1dbba6ebf0e8493ba51", "tree": "e8fc4a05fc29d19ca47547b8aeb7a4a26a3e0f6a", "parents": [ "b8552725fda0bb65fc2100df12d10821f178dc4d" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jul 27 17:01:44 2020 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jul 27 19:05:42 2020 +0000" }, "message": "runtime/jit: inclusive language fixes\n\nBased on:\n https://source.android.com/setup/contribute/respectful-code\n\nBug: 161896447\nBug: 161850439\nBug: 161336379\nTest: m (comment updates only).\nChange-Id: Ibfb4b0c71ef2fae076a6b11dfabe07137f00a7a5\n" }, { "commit": "c473dc7ae830ff6db4c9cead2be679af41da80e3", "tree": "b5b02261fdd2822f6478e0b83698bf35ee7c5e9a", "parents": [ "01e5698d5440c2665b7ab6dd924985843be161a2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jul 03 15:04:21 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jul 03 19:31:43 2020 +0000" }, "message": "Create individual counters and timers for compilation kinds.\n\nBug: 112676029\nTest: m\nChange-Id: I6f500d1253288e89ab83cd5d77f6ce0360bff340\n" }, { "commit": "0d60a2b1eaa2cd2ec3481e49578b77405353efa1", "tree": "91f16b9321ef7631aff731b10da2024c6c9d2029", "parents": [ "289bd1cccdb3aa37e2d129980f5c151f52f84897" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 17 14:31:56 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 18 08:37:10 2020 +0000" }, "message": "Introduce an enum for the compilation kind.\n\nTest: test.py\nChange-Id: I5329e50a6b4521933b6b171c8c0fbc618c3f67cd\n" }, { "commit": "f8cc26e53fecf48124789d23e233d5ab7025728e", "tree": "4ff361333e8d8916fd57d2e32b2a4d1b27df8518", "parents": [ "ce0d0079e89e0238a334fdadba09c43940e3adcb" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 10 15:37:37 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jun 16 07:51:29 2020 +0000" }, "message": "Fix a braino when marking a method as being compiled.\n\nWe now compile without having ProfilingInfos. Move the flag of being\ncompiled from the ProfilingInfo to sets in the JitCodeCache.\n\nTest: test.py jit-at-first-use\nBug: 147207937\nChange-Id: I1a372bb5534764278f5e9df674783cf918c690b3\n" }, { "commit": "62dd4e83ba8cdf519168de32c5eff138efdda134", "tree": "8999875422725bcee5d6734dc702015d7aa4d90d", "parents": [ "12b7ea1bdc97b35822aa939e19a6211d60eaaee7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun May 10 15:00:56 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon May 11 12:21:15 2020 +0000" }, "message": "Continue try allocating until we\u0027ve reached max capacity.\n\n004-StackWalk currently fails because we start with a too low code cache\nto allocate code for a method the test expects to be JITted. To de-flake\nthe test, just keep on trying to allocate.\n\nTest: test.py\nChange-Id: Ie33e13bcc8825058259e12b0d4d552e89c9816e3\n" }, { "commit": "41617b18f1c09e3031710d58fdb93c5aa43399ac", "tree": "36a0f3e3dc27e97980b96e1150ede718aee775fa", "parents": [ "842555d72ee7511c193a65f34841cc92170a1850" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Mar 18 21:19:06 2020 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Mar 25 14:10:23 2020 +0000" }, "message": "Add more logging and sanity checks for JIT mini-debug-info.\n\nUsed when diagnosing b/151137723. Keep it around.\n\nBug: 151137723\nTest: test.py -r --jit\nChange-Id: I10cc613c7396607e221fdc1f5972d26c1ac03fa8\n" }, { "commit": "521644beb8f0a100b08a4cfb91c6aafb469925aa", "tree": "b316373d4708d8653e6749d5b3a70f4263cf6f94", "parents": [ "7bbbe25f37ae70bebd121e0b4ea9bd53842281fe" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sat Mar 21 13:17:52 2020 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Mar 23 15:19:32 2020 +0000" }, "message": "Call JitCodeCache::FreeAllMethodHeaders under JIT lock.\n\nThis ensures that both ArtMethods and the code are removed\nfrom the JIT atomically (otherwise other thread can interfere).\n\nI am not sure if this is partial issue, but keeping the\nallocated code and methods in sync makes sanity check happier.\n\nBug: 151137723\nTest: test.py -b -r --host --jit --64\nChange-Id: I8580a9112c86b277631c0b2f9dd245fd55a73559\n" }, { "commit": "c76232ef401a036a9828fd27f22163619d9c1944", "tree": "2abf2af17f530d0328ac5326834647d29c8fe6f1", "parents": [ "80495fdb62d96d68c8648db3236f614d94ac1e6e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Mar 18 11:23:33 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Mar 20 09:45:42 2020 +0000" }, "message": "Fix relation between debuggable / JIT zygote.\n\n- Move the logic to clear precompiled in ClassLinker.\n- Add a null check on entries in ZygoteMap\n- Avoid doing JIT zygote actions (precompile, remapping boot images)\nwhen debuggable.\n\nTest: android.jdwptunnel.cts.JdwpTunnelTest#testAttachDebuggerToProfileableApp\nChange-Id: I9b5e391bb35aa04bbeba01b9b563b33f96395d2e\n" }, { "commit": "30fd85157260c91327c6b5a0816d312dd505c0e0", "tree": "355823ab233177d529baa873911cf08bb5b5deec", "parents": [ "80dc7dc20855bf680fa598127f26e6047821bdd0" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 20 20:27:58 2020 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Mar 12 12:10:49 2020 +0000" }, "message": "Refactor RemoveNativeDebugInfoForJit.\n\nThis is partial revert of CL/1099280 (Remove global maps).\n\nIt somewhat resurrects the lazy method removal.\n\nThe original goal was to only remove methods from the GC,\nand do all of them in bulk for simplicity and efficiency.\n\nHowever, this is proving infeasible since we have several\ncorner cases which remove methods outside the GC code path.\n\nThe behaviour for the GC code path is preserved by this CL.\nInstead of passing method array, the methods are individually\nmarked for removal and then repacking is immediately forced.\nThe only difference is that coroner cases are done lazily.\n\nTest: ./art/test.py -b -r --host --jit --64\nChange-Id: I42729545d6b51df788d92f9cf149a6e065b90c68\n" }, { "commit": "280e6c323419ad08860514ff8c09eefb8fc8e969", "tree": "db1d3d73a8c00c5df9cb8809dc3ab53e5ed09af6", "parents": [ "b28e3042b1dcab32c328b356a31f6ea8b50a9f9c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Mar 03 13:52:07 2020 -0800" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Mar 10 18:46:53 2020 +0000" }, "message": "Jit-zygote compiled code isn\u0027t debuggable\n\nWe check the debuggablity of compiled code by checking to see if it\nwas compiled by the JIT. This works since we throw all precompiled\ncode out when transitioning to debuggable. Unfortunately with\njit-zygote the non-debuggable zygote methods can be incorrectly seen\nas debuggable when encountered on the stack. This can lead to\nincorrect deoptimization and other issues. To fix this we explicitly\nexclude jit-zygote code from the check.\n\nBug: 144947842\nTest: ./test.py --host\nChange-Id: I4e953f64f8261b7a16d7c3199cec89998af0c1cf\n" }, { "commit": "b28e3042b1dcab32c328b356a31f6ea8b50a9f9c", "tree": "4cfe4e2e6800db4ca843dd94a80e54fe97b8cfd7", "parents": [ "b1fe5e18318c3af8d0cedc3f19cb6bc51817b859" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Mar 06 13:02:46 2020 -0800" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Mar 10 18:46:53 2020 +0000" }, "message": "Clear PreCompiled when we transition to debuggable after zygote fork\n\nWe were leaving the PreCompiled bits set on method objects. This meant\nthat in some circumstances non-debuggable compiled code could be\nreattached to methods after the switch to debuggable with the zygote\nfork.\n\nBug: 144947842\nTest: atest CtsJvmtiRunTest1982HostTestCases\nChange-Id: I1f642f6da441c4f023ec1cbd873c05914c73dd7e\n" }, { "commit": "a59af8aeaad8fe7d68d8f8de63eab9cf85b6ab31", "tree": "83195c74b135731cc4555254763a8f449691c1b0", "parents": [ "5c8cc64b5f1580faf510f27527e7e22987174963" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 27 17:42:32 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 03 14:32:09 2019 +0000" }, "message": "JIT baseline: trigger optimized compilation on hotness threshold.\n\n- Add a new hotness count in the ProfilingInfo to not conflict with\ninterpreter hotness which may use it for OSR.\n- Add a baseline flag in the OatQuickMethodHeader to identify baseline\ncompiled methods.\n- Add a -Xusetieredjit flag to experiment and test.\n\nBug: 119800099\nTest: test.py with Xusetieredjit to true\n\nChange-Id: I8512853f869f1312e3edc60bf64413dee9143c52\n" }, { "commit": "8852e5309a47c99d098aa85e8934cc06e8104807", "tree": "8316f4b25034531bacaab06aa235d64dd1f41e63", "parents": [ "7cf5607f472020711e36eedbbfebb25b40d3f90e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 30 09:43:35 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Oct 31 09:39:12 2019 +0000" }, "message": "[jitzygote] Remap boot boot image methods in zygote when single-threaded.\n\nThis avoids concurrent updates made by other threads while copying the\ndata.\n\nBug: 143569713\nBug: 119800099\nTest: boots\nChange-Id: Ife0141a45b8d8671ab0c5868ccf90b4799a9f5db\n" }, { "commit": "e3884e357566d739a33f22a0bdc4b76173cd6093", "tree": "d6169d034cb5a5d1c7e7a3cd0e9e6c18dd161f0b", "parents": [ "45217376b527cd17d758152c54960e6786288e31" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Oct 28 17:04:49 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Oct 29 15:45:01 2019 +0000" }, "message": "[jitzygote] Map the boot image fd after the contents have been written.\n\nIn order to not rely on undefined behavior from the kernel, map\nthe boot image methods fd after the shared mapping got updated with\nthe contents.\n\nBug: 119800099\nTest: BusinessCard\nChange-Id: I501b8994f2b0f2b27c4693443827ae1583f9fae4\n" }, { "commit": "adb66f967432ff1f0d51726923a64943c9f1d35b", "tree": "1444900ef83edb837c446361ef38bbf17c17f50c", "parents": [ "ff258063f2748aadf0ea83d0d284b1bedaf792d9" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Oct 10 12:59:43 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Oct 10 17:34:37 2019 +0000" }, "message": "Revert^2 \"JIT: Separate code allocation and initialization.\"\n\nThis reverts commit 63b0c26aae3e7237166dd781eb7a15fbc7c091c2.\n\nTest: ./art/test.py -b -r --host --all-gc -t 708\nReason for revert: Reland after bug fix.\nChange-Id: Ic13e2799bf4bdd8ca468f72cc0f3b72f224f2b08\n" }, { "commit": "63b0c26aae3e7237166dd781eb7a15fbc7c091c2", "tree": "5713f52331c0cd3b881df80f4314f9ea2a0f09db", "parents": [ "e1b36f09cb478a39ba443f6acb11cd1901c01c1d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 09 20:12:15 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 09 20:12:15 2019 +0000" }, "message": "Revert \"JIT: Separate code allocation and initialization.\"\n\nThis reverts commit e1b36f09cb478a39ba443f6acb11cd1901c01c1d.\n\nReason for revert: Crashes in art::jit::JitMemoryRegion::FreeCode\nhttps://logs.chromium.org/logs/art/buildbucket/cr-buildbucket.appspot.com/8900060997388741808/+/steps/test_libcore/0/stdout\n\nChange-Id: I40259baec9acbb7889732548f8b31e0a48651cd9\n" }, { "commit": "e1b36f09cb478a39ba443f6acb11cd1901c01c1d", "tree": "75642c703fee9fce7cd09af344dd26d485379b13", "parents": [ "449011217844401ed491ad0f89dcba21cc26bfc4" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Oct 04 17:44:33 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Oct 09 15:51:56 2019 +0000" }, "message": "JIT: Separate code allocation and initialization.\n\nAllocate(reserve) both code and data first,\nand then initialise(commit) both of them.\n\nThis is useful since we know the address sooner\nfor the purpose of debug info generation.\n\nTest: ./art/test.py -b -r --jit --host --64\nChange-Id: I4971a8801004efbc6c2b27884834dda775b72664\n" }, { "commit": "444e998f5987007bd2783b4d88a9970d1a17736f", "tree": "ef8a93058e973c2c0cf022ea2265679cbb783580", "parents": [ "44ab2cd97c7f4086013a766f442d2f9f619efcc8" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Oct 02 17:59:23 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Oct 08 13:43:16 2019 +0000" }, "message": "JIT mini-debug-info: Generate the debug info sooner.\n\nWe need to add the debug info before the entry-point is set,\notherwise there is window of time when we are missing it.\n\nTest: test.py -b -r --optimizing --jit --host --64\nChange-Id: I3bbad0c96d68e9603bac131faee498b8b9f62699\n" }, { "commit": "623d4f1ba4f4218c5472e3d9e1e9bf707795878d", "tree": "44a01387b2fcdda602019cefa3bf78b6535b2caa", "parents": [ "94af5824acb28f9756fb8246f95f78c4026228e2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 30 13:45:51 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Oct 06 13:09:09 2019 +0000" }, "message": "Share boot image methods memory in JIT zygote.\n\nOnce the zygote is done compiling, copy the ArtMethods to\nshared memory that will be in-place remapped. This is\na memory optimization that enables memory sharing between\nzygote and early forked processes.\n\nCurrently relies on undefined behavior of the kernel, but will\nfollow-up with a CL that uses file sealing that will address this.\n\nSaves around 2MB of memory for processes forked before zygote is\ndone compiling - there are around a dozen of processes.\n\nBug: 119800099\nTest: boots, PostLaunchMemoryUsage\nChange-Id: Ia1bdbd1abd27f28b087d9f33aca4cd901d55082f\n" }, { "commit": "4ac0e1571e015a01d75091c3daef065f9624ad77", "tree": "4d13edeab88bd6fd724388c48385b0c3cca4f3a8", "parents": [ "5a2301d897294ff4ee6de71f459dc2566dc3fa1a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:14:50 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:14:50 2019 +0000" }, "message": "Revert \"Revert \"Basic structural redefinition support\"\"\n\nThis reverts commit 5a2301d897294ff4ee6de71f459dc2566dc3fa1a.\n\nBug: 134162467\n\nReason for revert: Relanding as unclear if issue is due to topic.\n\nChange-Id: Ib1d1cf2e9132e30c9649b760ae9ae2d8ceacf843\n" }, { "commit": "5a2301d897294ff4ee6de71f459dc2566dc3fa1a", "tree": "2bd06ab3f463734994b3d251f6115514520dbb3f", "parents": [ "4eb6eb40e88214fcc874d93e75660cb580cb4d58" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:11:22 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:12:13 2019 +0000" }, "message": "Revert \"Basic structural redefinition support\"\n\nThis reverts commit c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c.\n\nBug: 134162467\n\nReason for revert: Breaks on redefine-stress\n\nChange-Id: I4e38da23d65b5b34b26b5ab537a3583328e078a4\n" }, { "commit": "c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c", "tree": "f8647487e7465712fd73118ceb89e13167a12648", "parents": [ "1ba7e8c10af4e270864a417044244d63db53ccf5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 13 10:50:38 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Sep 17 23:52:12 2019 +0000" }, "message": "Basic structural redefinition support\n\nThis adds basic support for adding methods and fields to already\nloaded classes using redefinition. This \u0027structural class\nredefinition\u0027 is currently limited to classes without any virtual\nmethods or instance fields. One cannot currently structurally redefine\nmultiple classes at once nor will structural redefinition trigger the\nstandard redefinition events.\n\nAfter structural redefinition all references to the old class, and its\nfields and methods are atomically updated. Any memory associated with\nthe static fields of the old class is zeroed. Offsets for field access\nmight change. If there are any active stack frames for methods from\nthe redefined class the original (obsolete method) code will continue\nto execute. The identity hash code of the redefined class will not\nchange. Any locks being held, waited or blocked on by the old class\nwill be transferred to the new class.\n\nTo use this feature the process must be debuggable and running with\n-Xopaque-jni-ids:true.\n\nFor device testing use a wrap.sh that adds the following flags:\n\n \u0027-Xopaque-jni-ids:true -Xcompiler-option --debuggable -XjdwpProvider:adbconnection\u0027\n\nStructural redefinition only available using the\n\"com.android.art.UNSAFE.class.structurally_redefine_class_direct\"\nextension. This will not trigger the normal class-redefinition events.\nOnly one class may be redefined at a time.\n\nNB There are still some holes in this potentially allowing obsolete\nmethods/fields to be visible. Most notably during jni-id, MethodHandle\nand VarHandle creation as well as potentially other places in the\nruntime. These holes will be closed by later CLs. Until then the\nextension to access structural class redefinition will remain tagged\nas UNSAFE.\n\nTest: ./test.py --host --all-compiler\nBug: 134162467\n\nChange-Id: I825d3a4bdb9594c0147223ae69f433ce9bbfc307\n" }, { "commit": "87fb032ee1e7ae98df26c646c450ef44e23fc805", "tree": "6754b2d2a0e38277885a691d1be6f0d796478cc7", "parents": [ "a86a5d162e6b59a32e8ea7991e6c8a157aca5a0a" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Aug 20 10:34:02 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Sep 01 21:08:43 2019 +0000" }, "message": "Fix JIT data dual mapping for apps.\n\nWe don\u0027t use it now, but it would be nice to make it functional.\n\nMark the read-only memory as const, and fix the compile errors.\n\nTest: test.py -b --host --jit\nBug: 119800099\nChange-Id: Ic1c45072f3c97f560e843f95fb87b95f754c6e03\n" }, { "commit": "8fc2f95291206806599d4f2a50da529da85155b6", "tree": "c3c9de9a9a925d6ab790f6db466d1f9c17ed1010", "parents": [ "9ce340f829f836560278ecd078fbefcf19c9d629" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 31 18:40:09 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 16 09:10:55 2019 +0000" }, "message": "JIT mini-debug-info: Remove global maps.\n\nKeep the extra bookkeeping information in JITCodeEntry.\n\nAlso do the compression eagerly during GC rather then lazily.\n\nTest: test.py -b --host --jit\nBug: 119800099\nChange-Id: Ie6cc682033a32c01d4c2cac242d8a4201116f940\n" }, { "commit": "323844002e54243e295497e7f829e46a533da621", "tree": "e6219f651332ee140042e4e0d4c975919f4fe9bf", "parents": [ "297a0533d2e3f1d49f0b73c5d1e3b09ce0418de2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jul 17 20:06:44 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 18 13:12:57 2019 +0000" }, "message": "jitzygote: Handle case of methods having the resolution stub.\n\nWe need to cache the compiled code until the class is initialized.\n\nTest: test.py\nTest: jitzygote config boots\nBug: 119800099\nChange-Id: Ib7a1efc3e101d9dabfad963621a1fe4a142e9b29\n" }, { "commit": "e32d24c75bf62e3cb9bff266ad4be859634320a9", "tree": "73a9c51958a77b3040b0ce04041424930b709873", "parents": [ "d17eac6b037f67494e31671d1a1d9d233ba3f237" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jul 05 10:28:59 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jul 05 15:36:58 2019 +0000" }, "message": "Store zygote compiled code in a shared map.\n\n- Store flags in the ArtMethod to know that it is compiled by the zygote\n- Query the map when entering a zygote compiled method from the\ninterpreter.\n\nBug: 119800099\nTest: boots\nChange-Id: Ib1a38266573e28d371034d02d6bb83f9b8b2e317\n" }, { "commit": "a48c3dfcebece7ee4b893757b715319f0b5b1fa7", "tree": "eb846bcf242f7e9f4243196b5f4546b0a222cfa0", "parents": [ "1459929a7e9ea96932b6c24597e1692b9b05606c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 27 13:11:12 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jun 28 06:37:34 2019 +0000" }, "message": "Revert \"Revert \"Make the JIT zygote memory shared.\"\"\n\nThis reverts commit 2fef66b294417d447630f9d98de68227eef476d3.\n\nBug: 119800099\nBug: 136110523\n\nReason for revert: Fixed webview_zygote case.\n\nChange-Id: Iaae8c999463d77b7b1e62b55458493bdbc97a104\n" }, { "commit": "2fef66b294417d447630f9d98de68227eef476d3", "tree": "59fc4ea6cf13217eb92fbdd4e39561b5ad518cf0", "parents": [ "21d5994583c679cd5d8573b5d35dbd659bdca2c7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 26 22:00:02 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 26 22:00:38 2019 +0000" }, "message": "Revert \"Make the JIT zygote memory shared.\"\n\nThis reverts commit 05f87217ddc9b4b9186710c0135b918f456c5aef.\n\nBug: 119800099\nBug: 136110523\n\nReason for revert: testWebview flaking\n\nChange-Id: I96afa6bc9c56c4aaf5ed72ae370f6f69c096c559\n" }, { "commit": "05f87217ddc9b4b9186710c0135b918f456c5aef", "tree": "6e7bc0d2a3d8faa94c303d7d753319f3850fadcd", "parents": [ "8d335b61d637fa9b040eb9d559dbac98067467f1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 19 10:00:00 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 26 12:24:15 2019 +0000" }, "message": "Make the JIT zygote memory shared.\n\nTest: boots\nBug: 119800099\nChange-Id: I75ff8a58eea4de5cb833139641b4e15b8394d9b1\n" }, { "commit": "00a37fff76278cd19cf59568df87495f6663c4b6", "tree": "8dc0f95daf800d36ac5da12faa658416b0dcc6a0", "parents": [ "6c0c7c8226a80d0e56f071118f46e4491cfa7754" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 20 14:27:22 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jun 24 15:40:45 2019 +0000" }, "message": "Move code writing to data portion of the JIT cache in JitMemoryRegion.\n\nSo there is only one method that needs to write to the data portion\nof the region.\n\nTest: test.py --jit\nChange-Id: I5b7dc442526da54f83a208cb70c8cf86fad6ebcd\n" }, { "commit": "521ff988097af7c79a0b94368d33d21f7c7dfb7d", "tree": "61e7b0377f02596acdb0520ad5faf1cc6505cb8a", "parents": [ "3149252c4b2a27b137b40a0d379e09ada9bb2d05" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jun 18 13:56:28 2019 +0100" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Jun 18 17:36:44 2019 +0000" }, "message": "For 32-bit ARM devices align method headers and code to 64-byte\nboundaries.\n\nFor other architectures, move back to instruction set alignment.\n\nRename kJitCodeCacheAlignment to kJitCodeAccountingBytes since it\u0027s\nnow only used for accounting rather than alignment.\n\nBug: 132205399\nTest: art/test.py --host --jit\nTest: manual (described in bug)\nChange-Id: I88f5f39381bf0331ce8540a929c6a68b3b5e0c75\n" }, { "commit": "7f7539b8ed0a31de1d1b6e1f0b730d55e37666a6", "tree": "d1611f06e3e468ff61c4d4bc349777b85b3a2e16", "parents": [ "93adcb53c77f4f04dfebd30b94e8ea9936aa8abb" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 06 16:20:54 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jun 10 07:32:49 2019 +0000" }, "message": "Pass the memory region to allocate into to the compiler / allocation.\n\nTest: test.py\nBug: 119800099\nChange-Id: Ie3cba5abe3dd4f8756af5ecfd6c26320de314fe8\n" }, { "commit": "2a905b2b50fb77723f6627e2d6a5df218d21081f", "tree": "4fa5d59381ed16073bc5f57cf9c9522e6f81acdd", "parents": [ "29bb803f2d41ea48e9f255dadd22b4c291e0a036" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 06 09:04:07 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 06 12:53:49 2019 +0000" }, "message": "Move memory related regions of the JIT cache in its own class.\n\n- Moves the JIT lock into the global locks list\n- Jit cache has two regions: one inherited from zygote, and its own.\n\nBug: 119800099\nTest: boot, test.py\nChange-Id: I833ba2b5a3d3c10fa01286cdf52603fa174a2cc7\n" }, { "commit": "d2f13ba7153aa7b77e4662844233c848535f8aac", "tree": "9a0f9bda0e886b1652cc306dba4a05648385beb0", "parents": [ "e7d7e9dd01b6ce5a079ebc7e369f4a8d4e42f7d8" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jun 04 16:48:58 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 06 08:02:04 2019 +0000" }, "message": "Remove requirement of a ProfilingInfo for jitted code.\n\nWhen pre-jitting (zygote or system server in jit zygote mode),\nthe profiling info is just memory overhead. Remove the need to have\none.\n\nBug: 119800099\nTest: boot, testrunner.py --jit\nChange-Id: Ie74d870eebef72c903225542e9b41dfe98132419\n" }, { "commit": "df1ab205c78fbfae152947e9618d8871a42a744b", "tree": "d7c461bba27009dd8304a2da1b0cea5b031a1a7b", "parents": [ "743600d5ae654817a5d81179fb480816e0cd139d" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Sun Jun 02 16:45:03 2019 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jun 04 15:34:07 2019 +0000" }, "message": "ART: Avoid shared cache lines for JIT code allocations\n\nDual view JIT exhibits some hygiene issues that causes crashes on\ndevices with 32-bit kernels.\n\nThis change makes JIT code allocations cache aligned. This is based on\nguidance in the v7_coherent_user_range() that says \"it is assumed that\nthe Icache does not read data from the write buffer\".\n\nBug: 132205399\n\nTest: \u003e2000 boot tests on affected device with no zygote crashes.\nTest: No crashes running ART JIT benchmarks on go/lem\nTest: No failures with Treehugger\n\nChange-Id: I901e2e5c07b9502876b33f572be63ec1dca19cbe\n" }, { "commit": "7989ac9ef0f50db26ce5844e7e6f9a659994c244", "tree": "a71974b358b1b06cdd9d740b83cbab41493db4b3", "parents": [ "6dfdfef85b210dc104a7cd221c6717e1a2123a13" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Apr 10 12:42:30 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 12 16:10:51 2019 +0000" }, "message": "Save the JIT compiled code when the class isn\u0027t initialized yet.\n\nWhen a class isn\u0027t initialized, we put resolution stubs to its\nstatic methods. In order to fetch the compiled code at the point of\ninitialization, save it in the profiling info.\n\nBug: 119800099\nTest: start an app, no JIT compilation of boot classpath methods\nChange-Id: I32b947318dbcb1010c94a11b51ea39d992d247e3\n" }, { "commit": "226805d9b81ba442251d0e2c4baedc36fcda6592", "tree": "3a256b1d36894d8d43ec9650f2a3f55c90c4730c", "parents": [ "96453b7d6aa445c6609aa465df5d66ae0beb7956" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Dec 14 10:59:02 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 19 09:22:01 2018 +0000" }, "message": "Deoptimize zygote compiled methods in DeoptimizeBootImage.\n\nThose methods don\u0027t get compiled with the \"debuggable\" flag,\nso we need to deoptimize them.\n\nAlso fix a bug revealed by the new test where a concurrent\nJIT collection happens when trying to disable it.\n\nAlso make DeoptimizeBootImage truly mutator lock exclusive.\n\nTest: 689-zygote-jit-deopt\nChange-Id: I00607dbe100350c5328293c35c87946fa97924b8\n" }, { "commit": "ce9ed3669d041d9eb2f5489596f133248d90f497", "tree": "f95fc9d6fc78119686fe91db5c2aaabd31b6abb1", "parents": [ "69431d3ba1c560f0b23bd2ad6257949deb679aa7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 29 03:19:28 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Dec 06 14:12:34 2018 +0000" }, "message": "Enable JIT in zygote.\n\nbug: 119800099\nTest: boot test\nChange-Id: I92dc59adeaf1202a984d363b1420ef26e53ebe84\n" }, { "commit": "c9de61cf9477e221e0dcc6470de9bf73c0559cf0", "tree": "db42f9c3b26d7543b7c378397debfc0595925ba6", "parents": [ "763cd98161424cf19af2f113a6802f04860dcd6e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 27 17:34:31 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 27 18:01:19 2018 +0000" }, "message": "Revert^2 \"Refactor code around JIT creation.\"\n\nThis reverts commit 763cd98161424cf19af2f113a6802f04860dcd6e.\n\nBug: 119800099\n\nReason for revert: Updated the DCHECKo take into account current state\nof zygote not having a thread pool.\n\nChange-Id: I1181ff85e7aebd062ee892548b80ab3de06a5ac7\n" }, { "commit": "763cd98161424cf19af2f113a6802f04860dcd6e", "tree": "bfb50d986ad25030ecfde9b3a4e1ffd8983e30f6", "parents": [ "7a2c7c2f7062d9fef21b72ff9c10ca8ef863eb8b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 26 18:21:45 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 26 18:21:45 2018 +0000" }, "message": "Revert \"Refactor code around JIT creation.\"\n\nThis reverts commit 7a2c7c2f7062d9fef21b72ff9c10ca8ef863eb8b.\n\nReason for revert: Breaks boot in debug mode\n\nBug: 119800099\nChange-Id: I6d015b04c480f76824ead936238cbf49b164b7e3\nTest: N/A\n" }, { "commit": "7a2c7c2f7062d9fef21b72ff9c10ca8ef863eb8b", "tree": "909d18e31d319313a0729019258418980c810d79", "parents": [ "c754cc8e1c2dbcb1331ec2bed3ea0787bdd2b5c3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 20 10:03:13 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 21 11:09:49 2018 +0000" }, "message": "Refactor code around JIT creation.\n\n- Create the JIT early on.\n- Have dedicated zygote spaces, that get assign after the fork.\n- Re-parse compiler options after fork to take into account customization\n of debug flags by the child.\n\nCurrently, we only create the thread pool in the child, so the zygote\nisn\u0027t jitting yet.\n\nBug: 119800099\nTest: test.py, device boots\nChange-Id: I591ce933ebf54a67937ab1d05206534f55ef2f65\n" }, { "commit": "b9f1af59681a73a33c86dd5919cc11874623d9d8", "tree": "d31e900f951201e406c524efd75318ebdbe4d649", "parents": [ "b321ac28f726a7ed41f277382d85702ffdfbe00f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 16 10:30:29 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 16 10:30:29 2018 +0000" }, "message": "Small cleanups in jit_code_cache.\n\nMake methods private, remove dead code.\n\nTest: test.py\nChange-Id: I4554d35c64115c6dd5308b6d509659e5c60346b1\n" }, { "commit": "ad28f5e02b3adc8ee7fec2f323eeb42bc96d596a", "tree": "53722e481afd203846ec45bf3d65ef3e32b5d419", "parents": [ "fe79b5939696c87f66d9d39540fe0f38369c5158" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Oct 17 09:08:17 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Oct 31 06:32:12 2018 +0000" }, "message": "ART: add hook for framework to set SELinux context\n\nAdds a new zygote hook for system server, nativePostForkSystemServer,\nso the process can transition between the system_server_startup and\nsystem_server SELinux domains.\n\nMemory resources for the JIT are allocated in the hook as setting the\nSELinux domain with setcon() requires that the process is still single\nthreaded.\n\nBug: 66095511\nTest: device boots\nTest: art/test.py --host --64\nChange-Id: Ic840634c5c59906b8d344c2edffafeb9b13a409f\n" }, { "commit": "1d3fd0803db51012e4d85b72b0f8096879c77af4", "tree": "0029858bb34c244282f91bd64705226d5dee28fb", "parents": [ "cac3267b3516571ef64bd28f916f52659796253f" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Sep 28 09:38:35 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Sun Sep 30 19:37:35 2018 +0100" }, "message": "Revert^4 \"ART: Dual mapping of JIT code pages\"\n\nThis reverts commit 1bfce389e8aba4ca7276918f2f86e5b13c5b5840.\n\nThis change adds a fix for stale data in the JIT code cache when dual\nmappings of the code cache are employed. With dual mappings, newly\ncompiled code is written into the non-executable mapping of the code\ncache. An additional data cache flush is needed to ensure the new\ncode is written out to the point of unification in the memory\nhierarchy.\n\nTest: manual\nBug: 66095511\nBug: 116761923\n\nChange-Id: Ib5fa83f22ee4fee1d0f80e16b974e1677c20af9b\n" }, { "commit": "1bfce389e8aba4ca7276918f2f86e5b13c5b5840", "tree": "e00d19a342ff429fc514bf70bf52ff005a00911c", "parents": [ "0e904ffc3376fe6fd272fee809752463f10e27f5" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 28 01:41:04 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 28 01:41:04 2018 +0000" }, "message": "Revert^3 \"ART: Dual mapping of JIT code pages\"\n\nThis reverts commit 0e904ffc3376fe6fd272fee809752463f10e27f5.\n\nReason for revert: Seems to break for 32-bit arm\n\nBug: 66095511\nBug: 111199492\nBug: 116761923\nChange-Id: I7d4bc78a1d5748a85ce63e2c57f32a8bdb768354\n" }, { "commit": "0e904ffc3376fe6fd272fee809752463f10e27f5", "tree": "2cc5b4abdd378b6448d9d84e0034b23dc2430da8", "parents": [ "5d7015cd64085068b1685d44339b4b705ef3f065" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Sep 24 08:40:54 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Sep 24 11:30:18 2018 +0100" }, "message": "Revert^2 \"ART: Dual mapping of JIT code pages\"\"\n\nAvoid setting footprint on code heap mspace when the heap size is zero.\n\nBug: 66095511\nBug: 111199492\nTest: art/test.py --host --64 --interpreter --no-image -r -t 595-profile-saving\n\nChange-Id: I8c475e135f7558915f799d3cb451595833e832a6\n" }, { "commit": "604e234e7a98d793d1a9591a477d64f30849f709", "tree": "b5f824c5bc0aa1621a59bc1d53dea46e172607ad", "parents": [ "6fa1729be6d2e38a31fc804025ed44cd08a4eb04", "60eaabebac20034571ed37f5096158a6623461ea" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Sep 21 16:48:45 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Sep 21 16:48:45 2018 +0000" }, "message": "Merge \"Revert \"ART: Dual mapping of JIT code pages\"\"" }, { "commit": "60eaabebac20034571ed37f5096158a6623461ea", "tree": "50f77c45386702a8e2248d44ed4a2bf9954f402c", "parents": [ "0e314f08cb0080799e86f639e3bc0306c5e74344" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 21 16:41:27 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 21 16:41:27 2018 +0000" }, "message": "Revert \"ART: Dual mapping of JIT code pages\"\n\nThis reverts commit 0e314f08cb0080799e86f639e3bc0306c5e74344.\n\nReason for revert: Breaks test-art-host-run-test-debug-prebuild-interpreter-no-relocate-ntrace-cms-checkjni-no-image-pictest-ndebuggable-no-jvmti-cdex-fast-595-profile-saving64.\n\nBug: 66095511\nBug: 111199492\nChange-Id: I6ca09e6c60e49647dfe6cc52708b1843c8acc89a\n" }, { "commit": "d75a268d2efdcc063d483c965c4899875aaf42b1", "tree": "b02acaa8b6443db2aed026a3529761773f68afba", "parents": [ "8f676995c00154f48d6b68b1656b654d0cd4593c", "0e314f08cb0080799e86f639e3bc0306c5e74344" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Sep 21 14:29:38 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Sep 21 14:29:38 2018 +0000" }, "message": "Merge \"ART: Dual mapping of JIT code pages\"" }, { "commit": "0e314f08cb0080799e86f639e3bc0306c5e74344", "tree": "ab4cf915ea5399b42c8dbf304d752e110f905ea0", "parents": [ "9b1e90ef5c8c026253099066e8414803a9880bf9" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Sep 04 11:28:31 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Sep 21 10:35:43 2018 +0100" }, "message": "ART: Dual mapping of JIT code pages\n\nAdd support for a two mappings of JIT code pages. One mapping is used\nfor executing code, the other for updating it. The latter mapping is\nnever executable.\n\nFallback to the existing regime when the required support is missing.\n\nNo longer allocate mappings for JIT code when cache exists only for\nprofiling purposes.\n\nBug: 66095511\nBug: 111199492\nTest: art/test.py --host\nTest: art/test.py --64 (angler - single view)\nTest: art/test.py --64 (other - dual view)\nTest: walleye boots\n\nChange-Id: I9920534c81cbf16f375f1dd554d5952716bf3253\n" }, { "commit": "ac3ac681a1d1d5d5d4662b7e4d3cf8e0b4d53d27", "tree": "803b02eabfb6af718561d0dfd83d61e4bccbfa28", "parents": [ "8402166d0e3b5d91ab867a7dcd7218f824afe3ff" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 20 11:01:43 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 20 15:48:38 2018 +0100" }, "message": "Pass JIT roots as a vector\u003cHandle\u003c\u003e\u003e to JIT cache.\n\nThis avoids creating an object on the heap and thus\nprevents issues for the 904-object-allocation in the\nJIT-at-first-use configuration.\n\nTest: run_build_test_target.py -j48 art-jit-on-first-use\n (test 904 passes; test 1935 still failing).\nBug: 116189667\nChange-Id: I58c0c8cb2d78edc63dab7d72e69b882abbfb79fd\n" }, { "commit": "c34bebf39410f5571d3d5813157b61f274d435c3", "tree": "73909d3b34a2908e9de44cc60c4a2ff74eabefd7", "parents": [ "f345404c725330914b8313d2c1af17226c5b92ca" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 16 16:12:49 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Aug 21 13:51:00 2018 +0100" }, "message": "Remove unnecessary indirection from MemMap.\n\nAvoid plain MemMap pointers being passed around by changing\nthe MemMap to moveable and return MemMap objects by value.\nPreviously we could have a valid zero-size MemMap but this\nis now forbidden.\n\nMemMap::RemapAtEnd() is changed to avoid the explicit call\nto munmap(); mmap() with MAP_FIXED automatically removes\nold mappings for overlapping regions.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nChange-Id: I12bd453c26a396edc20eb141bfd4dad20923f170\n" }, { "commit": "33b7b5da331e0a10fc615c8df72ba2aefad4e3fb", "tree": "4894623ad71bf957c25009e35e1b57ba501bb9c3", "parents": [ "134380d7c70d95962ed818458185e608ad17ff08" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:13:51 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Aug 17 14:40:51 2018 -0700" }, "message": "Revert^2 \"Fix race in CommitCodeInternal and cleanup\"\n\nThis reverts commit 8dde74eb7bec8e989f34d86a01c26b0f5c7e6443.\n\nWe were failing to do a null check in cha.cc. Due to compiler\noptimizations this would actually run without error on non-asan\nbuilds, causing the error to pass testing.\n\nReason for revert: Fixed issue causing asan issue.\nTest: run asan tests\n\nChange-Id: Ic5492c69b7735555108d8b18c8e687ce510c4549\n" }, { "commit": "8dde74eb7bec8e989f34d86a01c26b0f5c7e6443", "tree": "e94f5e620f27b3d6dcb3b634bc25bf0274b1143b", "parents": [ "a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:11:05 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:11:05 2018 +0000" }, "message": "Revert \"Fix race in CommitCodeInternal and cleanup\"\n\nThis reverts commit a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c.\n\nReason for revert: Seems to cause the asan gtests to fail.\n\nChange-Id: I0c7b4720de16f9b2b4e1e27c3c4e57a018c59a0c\nTest: none\n" }, { "commit": "a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c", "tree": "6c84decdf15db52cf8c20074f55b6f4fc89f9520", "parents": [ "d0c6ec392756fd038ebb8aeaad19aed94c5fd1a5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jul 19 14:39:24 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 01 09:15:23 2018 -0700" }, "message": "Fix race in CommitCodeInternal and cleanup\n\nJitCodeCache::CommitCodeInternal had a race where it gained the\ncode-cache lock to allocate memory, then drops it and potentially\nsuspends. It relied on the time for a code-collect being strictly more\nthan the time this function took, creating a race. This CL Changes the\nlock ordering of CHA to allow us to cleanup the CommitCodeInternal\nfunction and remove the race.\n\nTest: ./test.py --host --jit\nChange-Id: I13c7ec6c56f07660778009ad8ce9c8c10bc2d57d\n" }, { "commit": "8cd54547cec8a4537db5682c2da8be22843b1310", "tree": "fb1158993bab2e027984cedab59b402c051a45a7", "parents": [ "91f0fdb4372d3f2bcfcd9db67afcbe7ee1901048" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jul 15 23:58:44 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 14:49:40 2018 +0100" }, "message": "Move MethodInfo to CodeInfo.\n\nThere is no need to treat it specially any more,\nbecause of the de-duplication at BitTable level.\n\nThis saves 0.6% of oat file size.\n\nTest: test-art-host-gtest\nChange-Id: Ife7927d736243879a41d6f325d49ebf6930a63f6\n" }, { "commit": "8808756b8fba036a9c73a45c800a56be09872364", "tree": "9b28f314ff516d1d9b85d07f71bdc77fad465e48", "parents": [ "dda4e8b5f2ffed24a2dcdb99d2301d9fc0eb91e2" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sat Jun 23 22:05:56 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jul 27 15:03:06 2018 +0100" }, "message": "Remove frame info from OatQuickMethodHeader.\n\nThe information has been moved to CodeInfo,\nwhere it is stored in much more compact way.\n\nThe old CL which added the data to CodeInfo cost 0.7%.\nThis CL saves 2.5% of .oat file size so a win overall.\n\nTest: test-art-host-gtest\nChange-Id: I07fcf6f2776c96218f995ba3b57a1e6ccbf5e317\n" }, { "commit": "d25eb2cf85d04ae8565dcefb347afb108268b374", "tree": "db3d326e3ba40af8e7fd3e3aeea5e3752b07c700", "parents": [ "d7da3147fea647ade418337aed6a8f9402412611" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 19 12:17:04 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 19 12:17:04 2018 +0000" }, "message": "Revert^5 \"Rewrite JVMTI method tracing to use trampolines\"\n\nThis reverts commit d7da3147fea647ade418337aed6a8f9402412611.\n\nReason for revert: Tests are still failing on the buildbot.\n\nChange-Id: Iaaac38137b1c4bed8e3a15b0c0c14730654025f6\n" }, { "commit": "d7da3147fea647ade418337aed6a8f9402412611", "tree": "74907194b84807ae327ba9aff876e1f9d4bbf7a4", "parents": [ "eee2ee8e17aa65656e9946c5beb4a0a49fee7509" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 18 15:39:16 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 18 16:10:50 2018 -0700" }, "message": "Revert^4 \"Rewrite JVMTI method tracing to use trampolines\"\n\nSince we are unable to change the semantics of ClassLoaded and\nClassPrepared due to b/111394423 for the moment changes were made in\nlibjdwp to remove the deadlock between the jit being stopped and\njit-threads trying to lock JVMTI monitors in libjdwp.\n\nUntil some resolution for b/111394423 is implemented agents should be\nvery careful about gaining locks in the ClassLoaded, ClassPrepared or\nVMObjectAlloc events if said lock is held over a call to\nSetEventNotificationMode, SetExtensionEventCallback,\nRetransformClasses, or RedefineClasses. These locks can only be\nsafely held if the object argument to the event is not an array-class\nobject or the thread is known not to be a jit thread.\n\nThis reverts commit bf2ca05ccf658a9f626d1cb3f1adca6087ece7b8.\n\nBug: 111394423\nTest: ./art/tools/run-libjdwp-tests.sh --mode\u003dhost --debug\n\nReason for revert: Fixed issue with libjdwp deadlocking on jit threads\n\nChange-Id: I8baeb8311f67062cbc26286eb221da34e1972f27\n" }, { "commit": "bf2ca05ccf658a9f626d1cb3f1adca6087ece7b8", "tree": "8de1c48dd0a83091ffef6bf321ffc4ffc05b1147", "parents": [ "460c6ce61766196fc47ec5744417254fa2d6e364" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 18 13:26:11 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 18 13:26:11 2018 +0000" }, "message": "Revert^3 \"Rewrite JVMTI method tracing to use trampolines\"\n\nThis reverts commit 460c6ce61766196fc47ec5744417254fa2d6e364.\n\nReason for revert: I believe this is breaking libjdwp jit tests.\n\nChange-Id: I51297763c1d12555b32f3d37c0ceaa3b5720fff5\nTest: ./art/tools/run-libjdwp-tests.sh --mode\u003dhost --variant\u003dX64 --debug\n" }, { "commit": "460c6ce61766196fc47ec5744417254fa2d6e364", "tree": "70831d1dd48b3e65e1266da179d01c7d27cc1e47", "parents": [ "53570676750d74416cecdf5a8e01f3cf9a8d4169" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 11 16:13:24 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 17 11:03:27 2018 -0700" }, "message": "Revert^2 \"Rewrite JVMTI method tracing to use trampolines\"\n\nThis reverts commit 8772eb7ced96101e6202d8884edc84224ee1f1fd.\n\nWe had issues with trampolines confusing the libgcc _Unwind_Backtrace\nfunction and jit suspension deadlocking with user-code suspension.\n\nReason for revert: Fixed issue causing test 989 to fail in some\n configurations.\nTest: ./test.py --host --gcstress --cms\nTest: ./art/tools/run-libjdwp-tests.sh --mode\u003dhost\n\nChange-Id: Id83aa0d71f4523fe1b5e448d49887779f911a1a2\n" }, { "commit": "dca6840055c5255ad05f7516b0227e44ef6310a2", "tree": "1ec755d20b31dbe4c57a4e29afcd468eb3751568", "parents": [ "f3c3e83d3a98bd3ca388fca32f1c277a7945e1e3", "8772eb7ced96101e6202d8884edc84224ee1f1fd" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 11 16:11:29 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jul 11 16:11:29 2018 +0000" }, "message": "Merge \"Revert \"Rewrite JVMTI method tracing to use trampolines\"\"" }, { "commit": "8772eb7ced96101e6202d8884edc84224ee1f1fd", "tree": "24df91603efe9ce8c4a2efd09ac402aceb10df4e", "parents": [ "25bf44622d6359c1d49c2a8a8b45938ff099f811" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 11 16:10:48 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 11 16:10:48 2018 +0000" }, "message": "Revert \"Rewrite JVMTI method tracing to use trampolines\"\n\nThis reverts commit 25bf44622d6359c1d49c2a8a8b45938ff099f811.\n\nReason for revert: Seems to break jit-gcstress test 989\n\nChange-Id: Ia59833a2b80c6ab5a67483bf076bf08ba6769a40\nTest: None\n" }, { "commit": "25bf44622d6359c1d49c2a8a8b45938ff099f811", "tree": "d1a0e1f8069001d6880723f77e95efb01385ca71", "parents": [ "d109e30eab8ba25f8d89be2a83d9036e2d541af2" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Jun 11 10:28:06 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 10 08:44:52 2018 -0700" }, "message": "Rewrite JVMTI method tracing to use trampolines\n\nNow that we have working instrumentation trampolines we can rewrite\nthe MethodEntry and MethodExit events to use these instead of the\ninterpreter. This will improve performance of code being traced in\nthis way by allowing the actual code to still use optimized jit code.\n\nTest: ./test/testrunner/testrunner.py --host --runtime-option\u003d-Xjitthreshold:0 --jit\nTest: ./test/testrunner/testrunner.py --host --jit --debug --runtime-option\u003d-Xplugin:libtracefast-trampolined.so\nTest: ./test/testrunner/testrunner.py --host --jit --debug --runtime-option\u003d-Xjitthreshold:0 --runtime-option\u003d-Xplugin:libtracefast-trampolined.so\nTest: ./test/testrunner/testrunner.py --host --debuggable --run-test-option\u003d\u0027--with-agent libtifast.so\u003dMethodEntry,MethodExit\u0027\nTest: ./test/testrunner/testrunner.py --host --debuggable --jit --runtime-option\u003d-Xjitthreshold:0 --run-test-option\u003d\u0027--with-agent libtifast.so\u003dMethodEntry,MethodExit\u0027\nTest: adb shell am start-activity -S --attach-agent /data/local/tmp/libtifast.so\u003dMethodEntry,MethodExit \u003csome app\u003e\n\nChange-Id: I37c2ece14b1b12a79390da7d668ebbefa2966f87\n" }, { "commit": "3e36a9c24f591097b4403fe77b1d426c03aeb56a", "tree": "64f9c8896038ada2f7a17bd7cc62c488027dd548", "parents": [ "25bf44622d6359c1d49c2a8a8b45938ff099f811" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jun 19 09:45:05 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 10 08:44:52 2018 -0700" }, "message": "Move back to jit code on trace removal\n\nThis changes the lock hierarchy so the lock checker is able to\ncorrectly determine that we will not deadlock. This lets us replace\nthe jit code in the method when tracing is removed.\n\nTest: ./test.py --host\n\nChange-Id: I14dd4eb9814c73fa3639239bb56d91c8303cec60\n" }, { "commit": "2d441b1253cca39bf3078422e8f0b2f4ec1bb408", "tree": "3db740023b1322749856f943c4b25b8158da8a44", "parents": [ "e824cfdcfd41d400237a806ff93caca7f2e51878" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Jun 08 15:33:21 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 10 08:44:17 2018 -0700" }, "message": "Make instrumentation trampoline able to jump to jit code\n\nIn order to get the benefit of the instrumentation trampoline it must\nbe able to jump to jit code. This patch adds support for doing that\nand adds code to ensure that we will not be jumping back and forth\nbetween the trampoline and the interpreter all the time if the jit has\nnot yet compiled the current method.\n\nNote we also disable the jit-gc when turning on these trampolines\nsince otherwise we could end up either sending instrumentation events\nmultiple times or running uninitialized memory.\n\nBug: 110263880\nTest: ./test/testrunner/testrunner.py --host --runtime-option\u003d-Xplugin:libtracefast-trampolined.so\nTest: ./test/testrunner/testrunner.py --host --runtime-option\u003d-Xplugin:libtracefast-trampolined.so --runtime-option\u003d-Xjitthreshhold:0\nTest: ./test.py --host\n\nChange-Id: Ie6e92ec6367452fe4fde24d520d808b7af91d1b5\n" }, { "commit": "f0f3c594404aeb3d758e31ba748be400dc5b78a9", "tree": "e5c247c1aedfbf4de832d2fc3ccf415aca8366c6", "parents": [ "a98d9e76ed2486db9a7490a6e421a509ab2f6e2d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 26 13:28:00 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 27 08:37:43 2018 -0700" }, "message": "ART: Clean up jit_code_cache.h\n\nRefactor to reduce transitive includes.\n\nTest: mmma art\nChange-Id: I32caf422dc9a59b8e3d495b88b182f072ef4de84\n" }, { "commit": "607624f043af1de59f0069cfe6a68a00f950510e", "tree": "8cd8d113838b4a6d14db992db11ca62c156137da", "parents": [ "bae5e4e8e1cc93edd938ee0ee2303b7f5ad6b4dc" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri May 11 10:10:46 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri May 11 10:18:17 2018 +0100" }, "message": "ART: Rename JitCodeCache::FreeCode(const void*)\n\nRename FreeCode(const void*) to FreeCodeAndData(const void*). Leaves\nremaining FreeCode(uint8_t*) as responsible for freeing code.\n\nBug: b/66095511\nTest: art/test.py --host --64 --jit -r\nChange-Id: I87eb21a2f0c82c92f5bac3add8f9fc25c294dfc5\n" }, { "commit": "016fcbe2d24a99b688ae2b5c03ce13d270a97886", "tree": "96ec3e56325a6ea7618613ef96b04022612f7907", "parents": [ "d10995609f9fd8b85db1a5143b124195805ca5bb" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Thu May 03 19:47:35 2018 -0700" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed May 09 22:11:54 2018 +0000" }, "message": "Support system server ART-profiling\n\nWe don\u0027t have to map the code cache as executable if we only want to save\nprofiles. This enables system server profiling without disabling SElinux\nto bypass the jit code cache exec-mapping.\n\nTest: m test-art-host\n boot a device with system server profiling enabled.\nBug: 73313191\n\nChange-Id: I7f25a905e0b23456183e39e58ad8f4b829ddf0c5\n" }, { "commit": "0117908dab58511fd64da161369f538fc587a51b", "tree": "395dc2d9fd5f66d030e24e2253ff0c7262a0b7c3", "parents": [ "7075583146f52a754c6d7c91757a6333bf1b95da" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Mar 26 13:53:21 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Mar 26 13:53:21 2018 +0100" }, "message": "ART: Remove unused atomic field from JitCodeCache\n\nBug: 31023171\nTest: art/test.py --host -j32\nChange-Id: If72ecbe4ddeaa6b404226579c92cac1e24dbdd98\n" }, { "commit": "312f3b2fd0094c028a7d243b116947a35a745806", "tree": "3d7ec049ded98c489098c87250c75e3f711f8290", "parents": [ "0a3d5eb2ff9e70fa5785638da938439835d0337e" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 08:39:26 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 11:02:48 2018 -0700" }, "message": "Move some remaining dex utilities\n\nThere were several utilities related to building/walking/testing dex\nfiles that were not in libdexfile. This change consolidates these.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Id76e9179d03b8ec7d67f7e0f267121f54f0ec2e0\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "67bf42e89592c3a1c648f927f2ce3ccb189a1161", "tree": "054d5b7adf7cc62d4d2a2118a70c0fbdd1751610", "parents": [ "d961043ff1dd6fddb68aa90c1f939cfafec24219" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 26 16:43:04 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 28 15:08:21 2018 -0800" }, "message": "Header library to remove dependence on runtime/\n\nAdd a new header library to remove libdexfile and others\u0027 dependence on\nruntime (typically runtime/base) includes in libdexfile. Also a small step\nto tease dexlayout and profman away from relying on these as well.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n\nChange-Id: I38e2fe399a75f4bc6318c77a71954c00ea73ec2b\n" }, { "commit": "2196c651ecc77e49992c6c329dfce45f78ff46cb", "tree": "4eb151632fc7b851101b4264286ce5e900fa06b5", "parents": [ "dc93cac66f1db225474cec5bf0350fd7a148085e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 30 16:16:07 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 30 16:20:39 2017 +0000" }, "message": "Revert^4 \"JIT JNI stubs.\"\n\nThe original CL,\n https://android-review.googlesource.com/513417 ,\nhas a bug fixed in the Revert^2,\n https://android-review.googlesource.com/550579 ,\nand this Revert^4 adds two more fixes:\n - fix obsolete native method getting interpreter\n entrypoint in 980-redefine-object,\n - fix random JIT GC flakiness in 667-jit-jni-stub.\n\nTest: testrunner.py --host --prebuild --no-relocate \\\n --no-image --jit -t 980-redefine-object\nBug: 65574695\nBug: 69843562\n\nThis reverts commit 056d7756152bb3ced81dd57781be5028428ce2bd.\n\nChange-Id: Ic778686168b90e29816fd526e23141dcbe5ea880\n" }, { "commit": "056d7756152bb3ced81dd57781be5028428ce2bd", "tree": "154ae8968a450a2e02d88207fa09e380fd380553", "parents": [ "e7441631a11e2e07ce863255a59ee4de29c6a56f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 30 09:12:13 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 30 09:12:13 2017 +0000" }, "message": "Revert \"Revert \"Revert \"JIT JNI stubs.\"\"\"\n\nStill seeing occasional failures on 667-jit-jni-stub\n\nBug: 65574695\nBug: 69843562\n\nThis reverts commit e7441631a11e2e07ce863255a59ee4de29c6a56f.\n\nChange-Id: I3db751679ef7bdf31c933208aaffe4fac749a14b\n" }, { "commit": "e7441631a11e2e07ce863255a59ee4de29c6a56f", "tree": "a0488fac018ea391d01b751b7254719937bdee8f", "parents": [ "aa25db7d2a6f7f507c27ce49c99a33daf3059f8f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 29 13:00:56 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 29 14:04:26 2017 +0000" }, "message": "Revert \"Revert \"JIT JNI stubs.\"\"\n\nThe original CL,\n https://android-review.googlesource.com/513417 ,\nhad a bug for class unloading where a read barrier was\nexecuted at the wrong time from\n ConcurrentCopying::MarkingPhase() -\u003e\n ClassLinker::CleanupClassLoaders() -\u003e\n ClassLinker::DeleteClassLoader() -\u003e\n JitCodeCache::RemoveMethodsIn() -\u003e\n JitCodeCache::JniStubKey::UpdateShorty() -\u003e\n ArtMethod::GetShorty().\nThis has been fixed by removing sources of the read barrier\nfrom ArtMethod::GetShorty().\n\nTest: testrunner.py --host --prebuild --jit --no-relocate \\\n --no-image -t 998-redefine-use-after-free\nBug: 65574695\nBug: 69843562\n\nThis reverts commit 47d31853e16a95393d760e6be2ffeeb0193f94a1.\n\nChange-Id: I06e7a15b09d9ff11cde15a7d1529644bfeca15e0\n" }, { "commit": "47d31853e16a95393d760e6be2ffeeb0193f94a1", "tree": "344b0fddbbcc9a64bed2ba20dbe73fb227c2bdf4", "parents": [ "3417eaefe4e714c489a6fb0cb89b4810d81bdf4d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 28 18:36:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 28 18:36:12 2017 +0000" }, "message": "Revert \"JIT JNI stubs.\"\n\nSeems to break 998-redefine-use-after-free in\nsome --no-image configuration.\n\nBug: 65574695\nBug: 69843562\n\nThis reverts commit 3417eaefe4e714c489a6fb0cb89b4810d81bdf4d.\n\nChange-Id: I2dd157b931c17c791522ea2544c1982ed3519b86\n" }, { "commit": "3417eaefe4e714c489a6fb0cb89b4810d81bdf4d", "tree": "fe97f5191d25d26ef4250280f4c599b3a50f2059", "parents": [ "7bdc6e73fd97eb75f30b77f183e4fe6c2c599a09" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 21 18:14:28 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 28 13:00:09 2017 +0000" }, "message": "JIT JNI stubs.\n\nAllow the JIT compiler to compile JNI stubs and make sure\nthey can be collected once they are not in use anymore.\n\nTest: 667-jit-jni-stub\nTest: Pixel 2 XL boots.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --jit\nTest: testrunner.py --target --jit\nBug: 65574695\nChange-Id: Idf81f50bcfa68c0c403ad2b49058be62b21b7b1f\n" }, { "commit": "b0b68cfc0d2444e2333adcc5a6bc6f670b89fe83", "tree": "2cd71b6d221470f3c26fd089e68c6349009bdd80", "parents": [ "f4580f43bcb74061ba8b7847ec65f2fe160f1751" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 14 18:11:50 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 14 18:29:20 2017 +0000" }, "message": "ART: Clean up #includes in jit_code_cache.h .\n\nAnd fix code that relied on those indirect #includes.\n\nAlso remove forward declaration of art::LinkerPatch because\nwe actually use art::linker::LinkerPatch.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 65574695\nChange-Id: I102affed9a3eacbd21b79c370fbc72b5fc762c96\n" }, { "commit": "d1ee20fed62cd8db8fd496c4e5760dc554136020", "tree": "3252b0983fc23118846b68e0fc9b65b86af030eb", "parents": [ "2ade881db8642f10007c1c46b5e7f073d463c2d3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 17 09:21:16 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 17 10:38:57 2017 +0100" }, "message": "Revert^4 \"ART: Use proxy ArtMethod\u0027s data_ to store the interface method.\"\n\nFix a DCHECK() failure while visiting references for non-CC\nmoving GC by avoiding the DCHECK(); reference equality may\ngive false negatives at that stage as we may compare the new\nreference against an old one for the same object.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --jit\nTest: testrunner.py --host --gcstress\nTest: ART_DEFAULT_GC_TYPE\u003dSS ART_USE_READ_BARRIER\u003dfalse \\\n testrunner.py --host --gcstress -t 048-reflect-v8\n\nThis reverts commit 76ccd09c3d98317dfbd179c6f5c231dcfc5d6996.\n\nChange-Id: I13cc339d5b31fceedf39ea9a77f27369ba72279f\n" }, { "commit": "76ccd09c3d98317dfbd179c6f5c231dcfc5d6996", "tree": "07f1546ce7a090af8c88110598920769bfb5e669", "parents": [ "c42fab35f18539957debb8703195eeb76c9718f7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Aug 15 19:11:54 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Aug 15 19:11:54 2017 +0000" }, "message": "Revert^3 \"ART: Use proxy ArtMethod\u0027s data_ to store the interface method.\"\"\n\nStill failling:\n\n+dalvikvm64 F 08-15 18:54:16 218912 218912 art_method-inl.h:395] Check failed: !GetDeclaringClass()-\u003eIsResolved() || interface_method-\u003eGetDeclaringClass()-\u003eIsAssignableFrom(GetDeclaringClass()) \n\n\nThis reverts commit c42fab35f18539957debb8703195eeb76c9718f7.\n\nChange-Id: I91b51f8c1e7f6e0ae876b751d8e9cd3b8acb62f6\n" }, { "commit": "c42fab35f18539957debb8703195eeb76c9718f7", "tree": "65bcf5256213282a315a34621b3fbc73786c1585", "parents": [ "f0c66eb04db3c9fc513f50dfaad1385cf703820e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Aug 15 14:11:49 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Aug 15 15:18:07 2017 +0100" }, "message": "Revert^2 \"ART: Use proxy ArtMethod\u0027s data_ to store the interface method.\"\n\nFix a DCHECK() to ignore unresolved proxy classes.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --jit\nTest: testrunner.py --host --gcstress\n\nThis reverts commit 7ef52f75dd6e981e1e8c7567f593c197e8a94dcc.\n\nChange-Id: Idccdb04958a8bdb1c58b529dfb92885993ac62ea\n" }, { "commit": "7ef52f75dd6e981e1e8c7567f593c197e8a94dcc", "tree": "9685b783f628e290c6307d6ead024aac749a11ab", "parents": [ "0888cf1821d6622fd623db31000be19b9365f81c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 14 18:52:32 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 14 18:52:32 2017 +0000" }, "message": "Revert \"ART: Use proxy ArtMethod\u0027s data_ to store the interface method.\"\n\nBroke a few tests with:\n+dalvikvm64 F 08-14 18:36:32 136697 136697 art_method-inl.h:392] Check failed: interface_method-\u003eGetDeclaringClass()-\u003eIsAssignableFrom(GetDeclaringClass()) \n\n\nThis reverts commit 0888cf1821d6622fd623db31000be19b9365f81c.\n\nChange-Id: Idc93b6686392f9dfeca3bc11bd22104948fd9fd3\n" }, { "commit": "0888cf1821d6622fd623db31000be19b9365f81c", "tree": "fc1e251066fa30ffd475b8a51c15f17bc976b13f", "parents": [ "f9fd236b047a4851f24a3829acfd7e3340676305" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 28 12:55:17 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Aug 14 14:06:49 2017 +0100" }, "message": "ART: Use proxy ArtMethod\u0027s data_ to store the interface method.\n\nThis immensely simplifies the interface method retrieval\nand removes one dependency on dex_cache_resolved_methods_.\nWe may later consider removing that member if we deem the\nmemory savings worth the performance impact.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --jit\nChange-Id: Id76349c69e4c4dea4e3b297bd504db8f98f1b7cc\n" }, { "commit": "dbd05fe1a6ed2c3e23c9f6b372dd439ad59e777b", "tree": "81968f4f0a16cb37b57933be5cea6542795488a1", "parents": [ "1d2d8b1b6b359f5f476ef78662baa4b8782be530" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Aug 10 11:41:35 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Aug 10 11:57:53 2017 +0100" }, "message": "Revert recent JIT code cache changes\n\nFlakiness observed on the bots.\n\nRevert \"Jit Code Cache instruction pipeline flushing\"\nThis reverts commit 56fe32eecd4f25237e66811fd766355a07908d22.\n\nRevert \"ARM64: More JIT Code Cache maintenace\"\nThis reverts commit 17272ab679c9b5f5dac8754ac070b78b15271c27.\n\nRevert \"ARM64: JIT Code Cache maintenance\"\nThis reverts commit 3ecac070ad55d433bbcbe11e21f4b44ab178effe.\n\nRevert \"Change flush order in JIT code cache\"\nThis reverts commit 43ce5f82dae4dc5eebcf40e54b81ccd96eb5fba3.\n\nRevert \"Separate rw from rx views of jit code cache\"\nThis reverts commit d1dbb74e5946fe6c6098a541012932e1e9dd3115.\n\nTest: art/test.py --target --64\nBug: 64527643\nBug: 62356545\nChange-Id: Ifa10ac77a60ee96e8cb68881bade4d6b4f828714\n" }, { "commit": "56fe32eecd4f25237e66811fd766355a07908d22", "tree": "7c2c75d54edf0865598c106cb013f8c3794bd767", "parents": [ "84b65e977302e1cf16d188636c22c164c7793554" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Jul 21 11:42:10 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jul 24 17:29:40 2017 +0100" }, "message": "Jit Code Cache instruction pipeline flushing\n\nRestores instruction pipeline flushing on all cores following crashes\non ARMv7 with dual JIT code page mappings. We were inadvertantly\ntoggling permission on a non-executable page rather than executable.\n\nRemoves the data cache flush for roots data and replaces it with a\nsequentially consistent barrier.\n\nFix MemMap::RemapAtEnd() when all pages are given out. To meet\ninvariants checked in the destructor, the base pointer needs to be\nassigned as nullptr when this happens.\n\nBug: 63833411\nBug: 62332932\nTest: art/test.py --target\nChange-Id: I705cf5a3c80e78c4e912ea3d2c3c4aa89dee26bb\n" }, { "commit": "d1dbb74e5946fe6c6098a541012932e1e9dd3115", "tree": "7c3ad5ffd888ea97ee24e255bccb7c1a7acf4466", "parents": [ "2f0ac4fb4486e7d9e5c1545d45a2b9b818a80dc3" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Jul 17 11:20:38 2017 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jul 18 11:38:13 2017 -0700" }, "message": "Separate rw from rx views of jit code cache\n\nCreate two separate mappings of the ashmem region used for the JIT code\ncache. These two mappings have unrelated addresses.\n\nBug: 62356545\nTest: make -j test-art-target\nChange-Id: If176552e6d72ef71e17c96994901f3f3baac44f6\n" }, { "commit": "d38b67c9892b603f57a6b51a1b9d7f4e610158aa", "tree": "4bb95ce9f7733f8b9e54b6e80eaeb3751b4e78a8", "parents": [ "af14a86fb40f83b3d76185dd8bd09c1e7c409d2f", "eced692a34d2cf63d584c703704592984cc50394" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Jun 14 05:50:39 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jun 14 05:50:42 2017 +0000" }, "message": "Merge \"ART: Add JIT cache race test\"" }, { "commit": "eced692a34d2cf63d584c703704592984cc50394", "tree": "97240d0eae41b0b3596d92c17419f2dc3ae7b674", "parents": [ "cff1b21b3e19c5d3a2d726fdb60dacd7de2a6f0d" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jun 01 10:54:28 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jun 08 13:08:34 2017 +0100" }, "message": "ART: Add JIT cache race test\n\nAdds a test for the JIT code cache that attempts to trap races between\nthreads generating code and executing it.\n\nBug: 38417984\nTest: run-test --jit 707\nChange-Id: I408b2680b1d266ebe624d6e39113f0261d538e8a\n" }, { "commit": "5d08fcc21a14190c4dba3028a3e35d281afdd016", "tree": "c42de65ced190778342d9b022e400f4a7f9d346b", "parents": [ "57cf00bde719ddc84a6015b107b90a20169e3099" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 05 17:56:46 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 05 20:28:16 2017 -0700" }, "message": "ART: More header cleanups\n\nPull out more dependencies through forward declarations.\n\nTest: m test-art-host\nChange-Id: I7d86726928937f788b956ec9eac91532d66d57ae\n" }, { "commit": "513061a792b22c417c938d31c19581390709561c", "tree": "80b4fdce03711170626aa5640d07b07de4a326a1", "parents": [ "38c4ae5f4c5a033b7a7441032f39ea58f5772d4c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 09:17:34 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 12:59:13 2017 -0700" }, "message": "ART: Clean up thread.h and thread_list.h\n\nRemove dependency on stack.h and gc_root.h. Remove unused object\ncallbacks include. Factor out ManagedStack into its own set of files.\nFix up users of transitive includes.\n\nTest: m test-art-host\nChange-Id: I01286c43d8c7710948c161b1348faabb05922e59\n" }, { "commit": "4e92c3ce7ef354620a785553bbada554fca83a67", "tree": "42029deff4d3ba7f89b5fdbf79ff410da575f431", "parents": [ "549844e9ccf432d1396b19af890eedb602b8ba04" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon May 08 09:34:26 2017 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed May 10 09:27:33 2017 +0100" }, "message": "Add runtime reasons for deopt.\n\nCurrently to help investigate. Also:\n1) Log when deoptimization happens (which method and what reason)\n2) Trace when deoptimization happens (to make it visible in systrace)\n\nbug:37655083\nTest: test-art-host test-art-target\nChange-Id: I0c2d87b40db09e8e475cf97a7c784a034c585e97\n" }, { "commit": "cbcedbf9382bc773713cd3552ed96f417bf1daeb", "tree": "58eed766a69ddddbc41d21624244e14547fa1dff", "parents": [ "ef62210a1466c133056c4bfdae9f8f5417065eff" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Mar 12 22:24:50 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 16 10:20:34 2017 -0700" }, "message": "Add method info to oat files\n\nThe method info data is stored separately from the code info to\nreduce oat size by improving deduplication of stack maps.\n\nTo reduce code size, this moves the invoke info and inline info\nmethod indices to this table.\n\nOat size for a large app (arm64): 77746816 -\u003e 74023552 (-4.8%)\nAverage oat size reduction for golem (arm64): 2%\n\nRepurposed unused SrcMapElem deduping to be for MethodInfo.\nTODO: Delete SrcMapElem in a follow up CL.\n\nBug: 36124906\n\nTest: clean-oat-host \u0026\u0026 test-art-host-run-test\n\nChange-Id: I2241362e728389030b959f42161ce817cf6e2009\n" }, { "commit": "169722b0d6c680db33a6a2d602735a09db83e71d", "tree": "a616720d9e00f7e078d0689b616b29b39ac751a9", "parents": [ "43e07b6b16d3a84014bb4747211635b9ef3d1801" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 27 14:01:59 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 27 22:03:36 2017 +0000" }, "message": "Add hooks to avoid collecting code for run-tests.\n\nensureJitCompiled ensures a method gets compiled, but does\nnot prevent it from being GC\u0027ed. Add a hammer hook to avoid\ndoing any JIT code cache GC.\n\ntest: test-art-host with gcstress and jit.\nChange-Id: I3881f10f454ded9c7a3b385d326c2e08932d39bf\n" }, { "commit": "940eb0c00ef531dd9a0a68dbd61e377832e81eb4", "tree": "c65e43a702bb781b7a2f4ebedfb6b3d131fd8312", "parents": [ "9fb10fb39bcb3d9a4dc7e16f8c1d38dcc112639c" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Mon Jan 30 19:30:44 2017 -0800" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Thu Feb 16 13:52:56 2017 -0800" }, "message": "Add inline caches to offline profiles\n\nAdd support for inline caches in profiles:\n- extract inline caches from the jit cache when the profile saver\nqueries the hot methods\n- bump profile version to support the new data\n- add new tests\n- inline caches are only supported for same-apk calls (including\nmultidex)\n\nTest: m art-test-host-gtest-profile_compilation_info_test\nBug: 32434870\nChange-Id: I38b4ca0a54568d2224765ff76023baef1b8fd1a2\n" } ], "next": "dba61481035b7944173181ec9ee02aea41dd0e29" }