)]}' { "log": [ { "commit": "2ca0900e98d826644960eefeb8a21c84850c9e04", "tree": "ba8a25622f6bee25817be41880ea01c345d9a2b1", "parents": [ "44101a388089b4e23b284e1794eb475938a2f7ed" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 19 16:19:34 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 19 16:23:58 2021 +0000" }, "message": "Revert \"JNI: Remove `JniMethodFast{Start,End}()`.\"\n\nThis reverts commit 64d6e187f19ed670429652020561887e6b220216.\n\nReason for revert: Breaks no-image JIT run tests (flaky).\n\nBug: 172332525\nChange-Id: I7813d89283eff0f6266318d3fb02d1257471798d\n" }, { "commit": "64d6e187f19ed670429652020561887e6b220216", "tree": "0b7d39fd7d0a155786d84f23364313a7f63542a7", "parents": [ "b37da9d4ffbc5ab42c41fcd60dc0dac6357ea13b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Oct 14 09:32:01 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 19 13:25:55 2021 +0000" }, "message": "JNI: Remove `JniMethodFast{Start,End}()`.\n\nInline suspend check from `GoToRunnableFast()` to JNI stubs.\nThe only remaining code in `JniMethodFast{Start,End}()` is a\ndebug mode check that the method is @FastNative, so remove\nthe call altogether as we prefer better performance over the\ndebug mode check. Replace `JniMethodFastEndWithReference()`\nwith a simple `JniDecodeReferenceResult()`.\n\nGolem results for art-opt-cc (higher is better):\nlinux-ia32 before after\nNativeDowncallStaticFast 149.00 226.77 (+52.20%)\nNativeDowncallStaticFast6 107.39 140.29 (+30.63%)\nNativeDowncallStaticFastRefs6 104.50 130.54 (+24.92%)\nNativeDowncallVirtualFast 147.28 207.09 (+40.61%)\nNativeDowncallVirtualFast6 106.39 136.93 (+28.70%)\nNativeDowncallVirtualFastRefs6 104.50 130.54 (+24.92%)\nlinux-x64 before after\nNativeDowncallStaticFast 133.10 173.50 (+30.35%)\nNativeDowncallStaticFast6 109.12 135.73 (+24.39%)\nNativeDowncallStaticFastRefs6 105.29 127.18 (+20.79%)\nNativeDowncallVirtualFast 127.74 167.66 (+31.25%)\nNativeDowncallVirtualFast6 106.39 128.12 (+20.42%)\nNativeDowncallVirtualFastRefs6 105.29 127.18 (+20.79%)\nlinux-armv7 before after\nNativeDowncallStaticFast 18.058 21.622 (+19.74%)\nNativeDowncallStaticFast6 14.903 17.057 (+14.45%)\nNativeDowncallStaticFastRefs6 13.006 14.620 (+12.41%)\nNativeDowncallVirtualFast 17.848 21.027 (+17.81%)\nNativeDowncallVirtualFast6 15.196 17.439 (+14.76%)\nNativeDowncallVirtualFastRefs6 12.897 14.764 (+14.48%)\nlinux-armv8 before after\nNativeDowncallStaticFast 19.183 23.610 (+23.08%)\nNativeDowncallStaticFast6 16.161 19.183 (+18.71%)\nNativeDowncallStaticFastRefs6 13.235 15.041 (+13.64%)\nNativeDowncallVirtualFast 17.839 20.741 (+16.26%)\nNativeDowncallVirtualFast6 15.500 18.272 (+17.88%)\nNativeDowncallVirtualFastRefs6 12.481 14.209 (+13.84%)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 172332525\nChange-Id: I680aaeaa0c1a55796271328180e9d4ed7d89c0b8\n" }, { "commit": "d95a1f2ecf322d21ae98bfb7affe0070ddb9bc08", "tree": "8fc5fe8370ec051289a34cde7bf3dc5fc7a1ca7f", "parents": [ "507a729e51588f7fa4eac7579d54ce7c96804349" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 23 16:32:52 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 11 11:56:59 2021 +0000" }, "message": "Inline IRT frame push/pop into JNI stubs.\n\nGolem results for art-opt-cc (higher is better):\nlinux-ia32 before after\nNativeDowncallStaticNormal 25.704 26.839 (+4.414%)\nNativeDowncallStaticNormal6 23.857 25.086 (+5.152%)\nNativeDowncallStaticNormalRefs6 23.704 25.248 (+6.513%)\nNativeDowncallVirtualNormal 25.578 27.000 (+5.560%)\nNativeDowncallVirtualNormal6 23.704 24.925 (+5.153%)\nNativeDowncallVirtualNormalRefs6 23.704 25.074 (+5.870%)\nNativeDowncallStaticFast 100.65 149.13 (+48.17%)\nNativeDowncallStaticFast6 78.304 107.39 (+37.71%)\nNativeDowncallStaticFastRefs6 76.962 104.45 (+35.71%)\nNativeDowncallVirtualFast 100.40 147.28 (+46.69%)\nNativeDowncallVirtualFast6 79.302 106.34 (+34.10%)\nNativeDowncallVirtualFastRef26 76.617 103.29 (+34.82%)\nlinux-x64 before after\nNativeDowncallStaticNormal 26.083 26.987 (+3.465%)\nNativeDowncallStaticNormal6 24.606 25.411 (+3.271%)\nNativeDowncallStaticNormalRefs6 24.150 25.086 (+3.877%)\nNativeDowncallVirtualNormal 25.743 26.812 (+4.156%)\nNativeDowncallVirtualNormal6 24.294 25.248 (+3.927%)\nNativeDowncallVirtualNormalRefs6 23.857 25.086 (+5.152%)\nNativeDowncallStaticFast 109.95 133.10 (+21.06%)\nNativeDowncallStaticFast6 90.274 109.12 (+20.87%)\nNativeDowncallStaticFastRefs6 87.282 105.29 (+20.63%)\nNativeDowncallVirtualFast 104.00 127.55 (+22.65%)\nNativeDowncallVirtualFast6 88.191 106.73 (+21.02%)\nNativeDowncallVirtualFastRef26 85.530 102.09 (+19.36%)\nlinux-armv7 before after\nNativeDowncallStaticNormal 6.1148 6.3694 (+4.316%)\nNativeDowncallStaticNormal6 5.6845 5.9026 (+3.837%)\nNativeDowncallStaticNormalRefs6 5.4054 5.6022 (+3.641%)\nNativeDowncallVirtualNormal 5.4726 5.7088 (+4.316%)\nNativeDowncallVirtualNormal6 5.1789 5.3685 (+3.660%)\nNativeDowncallVirtualNormalRefs6 4.9140 5.0902 (+3.586%)\nNativeDowncallStaticFast 16.683 18.058 (+8.239%)\nNativeDowncallStaticFast6 13.951 14.896 (+6.770%)\nNativeDowncallStaticFastRefs6 12.279 13.006 (+5.919%)\nNativeDowncallVirtualFast 16.161 17.848 (+10.44%)\nNativeDowncallVirtualFast6 14.085 15.196 (+7.892%)\nNativeDowncallVirtualFastRef26 12.089 12.897 (+6.683%)\nlinux-armv8 before after\nNativeDowncallStaticNormal 6.0663 6.4229 (+5.879%)\nNativeDowncallStaticNormal6 5.7252 6.0437 (+5.563%)\nNativeDowncallStaticNormalRefs6 5.3114 5.5814 (+5.082%)\nNativeDowncallVirtualNormal 5.8795 6.2651 (+6.558%)\nNativeDowncallVirtualNormal6 5.6232 5.9494 (+5.801%)\nNativeDowncallVirtualNormalRefs6 5.1862 5.4429 (+4.948%)\nNativeDowncallStaticFast 17.638 19.183 (+8.760%)\nNativeDowncallStaticFast6 14.903 16.161 (+8.438%)\nNativeDowncallStaticFastRefs6 12.475 13.235 (+6.094%)\nNativeDowncallVirtualFast 15.826 17.848 (+12.78%)\nNativeDowncallVirtualFast6 14.064 15.504 (+10.24%)\nNativeDowncallVirtualFastRef26 11.628 12.475 (+7.285%)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 172332525\nChange-Id: I5ecfa7a661f08ab63dd2a75d666e1c1b9121935f\n" }, { "commit": "4f6bb446f8fbaa192f4e5b69734414c66d5e1bae", "tree": "c07c8cf278137c14fda476ed682968ee3c01c65f", "parents": [ "beb9f2012587035a5c30d0eca8af458b2ad659b7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 02 18:05:51 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 09 11:03:12 2021 +0000" }, "message": "Remove palette hooks.\n\nMake the method be part of the official palette API.\n\nBug: 186016399\nBug: 185778652\nChange-Id: I3dc9e879c647fd63f5826091813613fd97e25c0d\n" }, { "commit": "c3db254375df1f1459ac83cbf54b3eee92b138bd", "tree": "e6262127c6f4215ac0fffb98690b33f05daa7f9b", "parents": [ "0349b152f29a286d7365f17d0b21d735c71c39e3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 20 15:50:04 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 27 13:04:54 2021 +0000" }, "message": "Revert^2 \"Add hooks in palette for reporting JNI invocations.\"\n\nTest: test.py\nBug: 140968481\n\nChange-Id: I3ebbec153040b9bcfe4fb86618c15d2f9c93abb6\n" }, { "commit": "4501517c28357189f60f05494facc7e6ba2a8513", "tree": "2c12fb101942d86dd70262948dce31d7d8580bf3", "parents": [ "a9fed15c697d67bfbd2131d090a876145ad33910" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 20 13:41:09 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 20 15:49:27 2021 +0000" }, "message": "Revert \"Add hooks in palette for reporting JNI invocations.\"\n\nRevert \"Add JNI headers to palette dependencies.\"\n\nRevert submission 1678069-palette-jni\n\nReason for revert: Overhead of GetHooks call.\nReverted Changes:\nI909fc720f:Add hooks in palette for reporting JNI invocations...\nI5f036e5c0:Add JNI headers to palette dependencies.\n\nChange-Id: I327ae5f0e6e63f618d2e4cf08b7c4926071cb8ce\n" }, { "commit": "511392f151143f7d8bf2f82d5201ffa6d5d051de", "tree": "90b099b337432e8671f47c8eac6b1d5021db3293", "parents": [ "ae3aa6ca3e1bb29845da8844ab72ae2dc76d7793" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 16 13:27:20 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Apr 19 16:04:21 2021 +0000" }, "message": "Add hooks in palette for reporting JNI invocations.\n\nTest: test.py\nChange-Id: I909fc720fe5b891da6919fe20ad162ec12524f02\n" }, { "commit": "34ce1b8a86f1be2142f019ab291b7445db5c4305", "tree": "9dada63c4a13a8421ad0199118930fe60fea9047", "parents": [ "a718d6450feae9ee6b5de96407c8e44afbf173e7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 11 12:11:31 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 11 15:01:39 2021 +0000" }, "message": "Clean up transitions in JniMethodEnd.\n\nGoToRunnable() is never called for @FastNative, so\nwe can remove the path that calls GoToRunnableFast().\n\nAdd a call to GoToRunnableFast() for @FastNative in\nGenericJniMethodEnd().\n\nThis is a follow-up to\n https://android-review.googlesource.com/1620969\nthat cleaned up JniMethodStart but missed similar\nopportunity for the transition back to Runnable from\nvarious JniMethodEnd methods.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 172332525\nChange-Id: Ia519bfc6ea50c1b65241041a3af8b7d4b1027f77\n" }, { "commit": "68e8a7c0a96d941bf08956dd0d8d83c282d0af9f", "tree": "39483f0575738b39ef7cad3efa267da8efd3ead9", "parents": [ "c2f46939d8c046dfc8e954ac1bec6d61b0f061ae" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 05 08:40:22 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 08 09:15:07 2021 +0000" }, "message": "Clean up JniMethodStart().\n\nAfter we have clarified that @FastNative methods cannot be\nsynchronized and starting enforcing it in\n https://android-review.googlesource.com/1518545\nwe can clean up JniMethodStart() and remove the check for\n@FastNative (though we keep a CHECK in debug builds).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 172332525\nChange-Id: I1466dbca3b22524b8cc72db79bf583d64d32c7bf\n" }, { "commit": "cedec9db0a9accfdcf5eb695879e0b2caf2c34cb", "tree": "99fd71a3ef398a471507ed815c4a175805ad51f3", "parents": [ "0ccc970b3c00b172e3cff8e10da13dd6323ccd52" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 08 16:16:13 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 23 14:34:43 2021 +0000" }, "message": "Do not create HandleScope for JNI transitions.\n\nWe previously crated a HandleScope in the JNI transition\nframe to hold references passed as jobject (jclass, etc.)\nto the native function and these references were actually\nspilled twice during the transition.\n\nWe now construct the jobject as a pointer to the reference\nspilled in the reserved out vreg area in the caller\u0027s frame.\nAnd the jclass for static methods is just a pointer to the\nmethod\u0027s declaring class. This reduces the amount of work\nrequired in the JNI transition, both on entry (in compiled\nstubs) and exit (in JniMethodEnd*).\n\nSome additional work is required when GC visits references\nof a native method as we need to walk over the method\u0027s\nshorty which was unnecessary for a HandleScope.\n\nAlso fix Thread::InitStackHwm() to calculate correct stack\nsize needed by the new Thread::IsJniTransitionReference().\n\nThe results for StringToBytesBenchmark on blueline little\ncores running at fixed frequency 1420800 are approximately\narm64 (medians from 3 runs) before after\ntimeGetBytesAscii EMPTY 447.33 436.86\ntimeGetBytesIso88591 EMPTY 440.52 431.13\ntimeGetBytesUtf8 EMPTY 432.31 409.82\narm (medians from 3 runs) before after\ntimeGetBytesAscii EMPTY 500.53 490.87\ntimeGetBytesIso88591 EMPTY 496.45 495.30\ntimeGetBytesUtf8 EMPTY 488.84 472.68\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --gcstress\nTest: testrunner.py --host --jit-on-first-use\nTest: testrunner.py --host --jit-on-first-use --gcstress\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nTest: boots.\nBug: 172332525\nChange-Id: I658f9d87071587b3e89f31c65feca976a11e9cc2\n" }, { "commit": "6e043bbc1d9abd1d1d3247040f6cdc82a79f47be", "tree": "02470465a0426e02d15525e171c6b3bbef3d60a6", "parents": [ "ac5ae3cf5dc4c5f87293c45a1d6999f8d1515b39" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 10 16:56:54 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 12 13:21:28 2020 +0000" }, "message": "Rewrite GenericJNI frame setup.\n\nMove the handle scope out of the managed frame, move the\nregister values to load to the bottom of the reserved area\nand pass the hidden argument to @CriticalNative methods to\nprepare for implementing late lookup.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --interp-ac\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing --interp-ac\nBug: 112189621\nChange-Id: I4672176f9627bcbebafebb3dda0d02b8108e1329\n" }, { "commit": "5c33d35bf3bd0d824e94784312fe3ddb823028d1", "tree": "a6056e5f6a9009da93355dd00fd73caf66f1f6fc", "parents": [ "b5a78564d66c903c0073e429d71241be60f51bdf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 10 12:29:13 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 10 15:48:15 2020 +0000" }, "message": "Reinstate exception check in GenericJni stubs.\n\nThe error check was erroneously removed in\n https://android-review.googlesource.com/1178884\nwhere we removed the native method lookup from the\nartQuickGenericJniTrampoline(). As the locking is now the\nonly remaining operation that can fail, update the comment\nfor the check. Regression test would be rather difficult to\nadd as we would need to force OOME during lock inflation.\n\nAlso clean up unlocking code in GenericJniMethodEnd().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nBug: 112189621\nChange-Id: I598d5f86a58c0b6171f0b2528504aba495f1b6d8\n" }, { "commit": "c1896c9a0e15df3a1b9a3a19bcd2a933b654fe06", "tree": "b68a5f5163f8da0da87d671a225addaa2a13095f", "parents": [ "f2970cd870948a6ee1c8ecd30c9c3147d05aa0be" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 29 11:33:18 2018 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 29 11:33:18 2018 -0800" }, "message": "C++17 compatibility: make WITH_TIDY\u003d1 happy again.\n\nBug: http://b/111067277\nTest: builds\nChange-Id: I8b69ea3815e14bb6eb27f40c0dd01a85b340a355\n" }, { "commit": "55256cb60e11d4fac71affb4b9760a2931a3598d", "tree": "fc1ed6885b013e0aa2bcfd9ef4dd94fec29bd382", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Dec 21 17:07:11 2017 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Dec 22 10:11:39 2017 -0800" }, "message": "Extensions to check JNI.\n\nEnsure critical lock isn\u0027t held when returning from a down-call.\nLog a warning if the critical lock is held for a significant period of\ntime.\nRefactor JNIEnvExt to be a class rather than a struct.\n\nTest: mma test-art-host\n\nChange-Id: I4d149cb04d3a7308a22b92b196e51e2f1ae17ede\n" }, { "commit": "57943810cfc789da890d73621741729da5feaaf8", "tree": "367677a982a45af98ffe3e79543615875e8550b4", "parents": [ "d5153627778e71ef68b510ce03c77467fa4d85bd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 21:39:13 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 16:26:11 2017 -0800" }, "message": "ART: Replace base/logging with android-base/logging\n\nReplace wherever possible. ART\u0027s base/logging is now mainly VLOG\nand initialization code that is unnecessary to pull in and makes\nchanges to verbose logging more painful than they have to be.\n\nTest: m test-art-host\nChange-Id: I3e3a4672ba5b621e57590a526c7d1c8b749e4f6e\n" }, { "commit": "b0a6aeee250945b1d156ebab94053380f2e5a3c5", "tree": "7ddb52bb20997b8f1c81be3df2250949a088e697", "parents": [ "0db16e00e3927445585a588499731c58c1ae1bef" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 27 10:34:04 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Nov 10 08:30:36 2017 +0000" }, "message": "Record @{Fast,Critical}Native in method\u0027s access flags.\n\nRepurpose the old kAccFastNative flag (which wasn\u0027t actually\nused for some time) and define a new kAccCriticalNative flag\nto record the native method\u0027s annotation-based kind. This\navoids repeated determination of the kind from GenericJNI.\nAnd making two transitions to runnable and back (using the\nScopedObjectAccess) from GenericJniMethodEnd() for normal\nnative methods just to determine that we need to transition\nto runnable was really weird.\n\nSince the IsFastNative() function now records the presence\nof the @FastNative annotation, synchronized @FastNative\nmethod calls now avoid thread state transitions.\n\nWhen initializing the Runtime without a boot image, the\nWellKnowClasses may not yet be initialized, so relax the\nDCheckNativeAnnotation() to take that into account.\n\nAlso revert\n https://android-review.googlesource.com/509715\nas the annotation checks are now much faster.\n\nBug: 65574695\nBug: 35644369\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: I2fc5ba192b9ce710a0e9202977b4f9543e387efe\n" }, { "commit": "33bff25bcd7a02d35c54f63740eadb1a4833fc92", "tree": "553db4f60878acf2a0fa7036a739d406df9a29b7", "parents": [ "321b3ca9a36d769283c64d4bdee0798db80af524" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 01 14:35:42 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 02 10:11:02 2017 +0000" }, "message": "ART: Make InstructionSet an enum class and add kLast.\n\nAdding InstructionSet::kLast shall make it easier to encode\nthe InstructionSet in fewer bits using BitField\u003c\u003e. However,\nintroducing `kLast` into the `art` namespace is not a good\nidea, so we change the InstructionSet to an enum class.\nThis also uncovered a case of InstructionSet::kNone being\nerroneously used instead of vixl32::Condition::None(), so\nit\u0027s good to remove `kNone` from the `art` namespace.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I6fa6168dfba4ed6da86d021a69c80224f09997a6\n" }, { "commit": "a682247fda8817be8c5ee70b3b3dbf5f3a76ad70", "tree": "635f1904e392492e53e72b3649bfa7e28156519d", "parents": [ "128acd4b5b34cdd51328de03df085deaa040b864" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Oct 11 22:58:53 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Oct 11 22:58:53 2017 -0700" }, "message": "ART: Make FastJNI annotation checks slow-debug\n\nAvoid annotation checks in fast-debug builds to lower overhead.\n\nBug: 35644369\nTest: m test-art-host\nChange-Id: I7faafa5f6919420f75800fb59bf650f277957f98\n" }, { "commit": "90b936ddda63139ff46a6755c3b83ad6e4ab4ac5", "tree": "c7ce2c3004eecc16ab41ed7cde105c3019638d4b", "parents": [ "b78a8af993e877d74c5938f65f95feaf2fa01321" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jan 31 08:58:55 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Feb 03 10:03:52 2017 -0800" }, "message": "ART: Refactor verify_object.h\n\nMove the actual VerifyObject check into a new cc file, as we\ncommonly don\u0027t enable the check at all. This allows to cut the\n-inl include from almost all current users.\n\nThis also exposes missing -inl includes. Also fix up some of our old\nmess where .h defined functions require -inl.h defined functions.\n\nTest: m\n\nChange-Id: I3dd821bbe2015564a29bf1ed9be00f7a7276ad61\n" }, { "commit": "e03662b71bbb4d262af0840bf90ce4fc84750b43", "tree": "0d89f7d90a46a7a2f8d120e3b0aabf3e1d277004", "parents": [ "dc061d038e4e48fe2a967fd4a9c200d112df5698" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 13 17:12:56 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 24 19:16:54 2016 -0700" }, "message": "ART: Change IndirectReferenceTable\n\nChange cookie structure to allow for more entries. Use a local\nhole-count caching scheme. The design is driven by two\nconsiderations. For one, the change is small and mostly local.\nThe other point is to still allow inlining of functions involved\nwith JNI transitions.\n\nThis change is in preparation for a resizable backing table for\n\"unlimite\" local references.\n\nmicro_native tests show changes are in the noise.\n\nBug: 32125344\nTest: m test-art-host\nChange-Id: I08ff5d6eaed75d13ec88f469fb0d18328a0eeb70\n" }, { "commit": "af1e2990cd1406a0fb7cba1d2e208208e950e413", "tree": "07e80e4dcc31931003a87be7884134ea42ceec07", "parents": [ "3f699ae23266b2c4adc98958dcbd80c71c2c3284" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Oct 12 17:44:50 2016 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Oct 19 11:38:54 2016 -0700" }, "message": "jni: Support @FastNative methods that return objects\n\nBug: 32088975\nChange-Id: I16f8b7ec6b251812af60ab25f2153d9b72f37044\n" }, { "commit": "709b070044354d9f47641f273edacaeeb0240ab7", "tree": "3a8ac051d7c35076303984d0d892cdd396b60427", "parents": [ "1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 13 09:12:37 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Oct 18 14:10:04 2016 -0700" }, "message": "Remove mirror:: and ArtMethod deps in utils.{h,cc}\n\nThe latest chapter in the ongoing saga of attempting to dump a DEX\nfile without having to start a whole runtime instance. This episode\nfinds us removing references to ArtMethod/ArtField/mirror.\n\nOne aspect of this change that I would like to call out specfically\nis that the utils versions of the \"Pretty*\" functions all were written\nto accept nullptr as an argument. I have split these functions up as\nfollows:\n1) an instance method, such as PrettyClass that obviously requires\nthis !\u003d nullptr.\n2) a static method, that behaves the same way as the util method, but\ncalls the instance method if p !\u003d nullptr.\nThis requires using a full class qualifier for the static methods,\nwhich isn\u0027t exactly beautiful. I have tried to remove as many cases\nas possible where it was clear p !\u003d nullptr.\n\nBug: 22322814\nTest: test-art-host\nChange-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24\n" }, { "commit": "043eb9a4496cacaffe60f381c5686c989cb5d701", "tree": "42f89fbff75828cc962992000fa6f018fb46caa4", "parents": [ "cfdff144f154df876987fefb340058a975c43381" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Oct 14 11:21:38 2016 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Oct 14 13:04:25 2016 -0700" }, "message": "Add a mark bit check in the read barrier jni entrypoint.\n\nBug: 30437917\nBug: 12687968\nTest: test-art host/N9, N9 libartd boot, Ritz EAAC.\nChange-Id: Ic5f8080959f243e80f00da73ba5f4b91a8d8b617\n" }, { "commit": "9d156d500801accee919b6d51e22d6ddcdcd4a05", "tree": "92129562c0ba1673c660297f26444a4a2ad31459", "parents": [ "078483d4dfd049d5b3f192a99e2dfdc355e4754f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 06 17:44:26 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 12 09:49:49 2016 -0700" }, "message": "Move Heap parameters to ObjPtr\n\nDeleted some unused object dumping code.\n\nTest: test-art-host\n\nBug: 31113334\n\nChange-Id: I747220caafe6679591fd4b361d7f50383a046164\n" }, { "commit": "c4f3925490a73da8dc74884a1deb965d4ecaf14e", "tree": "7fe566827f8ab903af1acb5697c86a6efe3187b3", "parents": [ "18f7de841fee3ca6f0c04e7caa57c3ce76b36231" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 05 18:32:08 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 06 13:55:58 2016 -0700" }, "message": "Move remaining jobject related functions to use ObjPtr\n\nAlso added ObjPtr::DownCast.\n\nBug: 31113334\n\nTest: test-art-host\n\nChange-Id: I59c253211dc435579ffdfd49f856861ab13d262c\n" }, { "commit": "06a04e0e776875303577c2d871b53a53c78da1b5", "tree": "6f8b38fa918f49cc502b573c96d9a6338ad343df", "parents": [ "48d10ee126838f060aa6dcd304fc161b57bc14af" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Sep 13 15:57:37 2016 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Sep 21 13:32:00 2016 -0700" }, "message": "jni: Implement generic JNI support for @CriticalNative/@FastNative\n\nAlso:\n* Extend existing test cases to check generic JNI for the above.\n* Re-enable previously blacklisted @CriticalNative JNI run-tests.\n\nBug: 31400248\nChange-Id: I436ed00c8b8880e936a0c3483bc0dc251f0c0ce2\n" }, { "commit": "be08cf5782c04d876d38be8b8d1caf1b4c3fbe55", "tree": "3efb73eb12ccb967003157d30670c5a283ddc8b4", "parents": [ "32772cbdbcb35f5475b01f31314a3c7289bdb589" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 13 13:41:24 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 14 16:53:11 2016 -0700" }, "message": "Fix moving GC bugs in entrypoints\n\nIn FindMethodFromCode, there was missing handles for objects used\nafter a suspend point (ResolveType).\n\nFor check_jni, JniMethodEndWithReferenceHandleResult did not\nhandlarize the return value when calling CheckReferenceResult.\n\nFor CheckReferenceResult, the argument was not in a handle.\n\nBug: 31458474\nChange-Id: I06617fc63f1fb63d7c13ad4245223a8c54fa4b98\n" }, { "commit": "bdf7f1c3ab65ccb70f62db5ab31dba060632d458", "tree": "25cc77adfeb05232d0ab00aa561a693f1d71745c", "parents": [ "d7eabc2cc1a88c1f7f927da61246ae65aab0626c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 16:38:47 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 17:02:53 2016 -0700" }, "message": "ART: SHARED_REQUIRES to REQUIRES_SHARED\n\nThis coincides with the actual attribute name and upstream usage.\nPreparation for deferring to libbase.\n\nTest: m\nTest: m test-art-host\nChange-Id: Ia8986b5dfd926ba772bf00b0a35eaf83596d8518\n" }, { "commit": "9d4b6da934934c322536ee3309b63ce402740f49", "tree": "9e7ee5023d6036b98e0560411bb0527efdedca01", "parents": [ "2af1aa066e3d20edd8fea5d5b6dbbbad73102d52" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Jul 29 09:51:58 2016 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Aug 16 20:19:36 2016 +0000" }, "message": "jni: Fast path for @FastNative annotated java methods\n\nAdds a faster path for java methods annotated with\ndalvik.annotation.optimization.FastNative .\n\nIntended to replace usage of fast JNI (registering with \"!(FOO)BAR\" descriptors).\n\nPerformance Microbenchmark Results (Angler):\n* Regular JNI cost in nanoseconds: 115\n* Fast JNI cost in nanoseconds: 60\n* @FastNative cost in nanoseconds: 36\n\nSummary: Up to 67% faster (vs fast jni) JNI transition cost\n\nChange-Id: Ic23823ae0f232270c068ec999fd89aa993894b0e\n" }, { "commit": "5f4a09a54eed55de89e194780214a2acfd2cb431", "tree": "20194da9f2963a98f0265a25172aa9a61b52c2c8", "parents": [ "1aba494df441c31836e5b7d4d8e408420a93cb8d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 28 13:16:33 2015 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 05 08:57:32 2015 -0700" }, "message": "ART: Add CheckJNI lock checking\n\nJNI MonitorEnter and MonitorExit have similar rules to structured\nlocking. Count locks in CheckJNI mode.\n\nBug: 23502994\nChange-Id: Ie3f53d3aa669a6bd0c7153c50c168116b43764d9\n" }, { "commit": "a23b4680a8565f28e8aa958febf8949db74a3064", "tree": "bc86ebbdf93e4318ab89835626996f91bbf94c18", "parents": [ "8a0014dd3ad1562d93695fa0d3033856ec7da133" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Mon Sep 28 17:47:32 2015 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Sep 29 11:33:13 2015 -0700" }, "message": "Fix a mutator lock violation in the generic JNI end sequence.\n\nartQuickGenericJniEndTrampoline() was accessing objects without a shared\nmutator lock right after returning from a JNI call but before switching\nto the runnable state.\n\nThis fixes crashes with table lookup read barriers enabled.\n\nBug: 12687968\nChange-Id: I94ad9ca276750f58cb68b2fa9eb8cdeb371f021b\n" }, { "commit": "90443477f9a0061581c420775ce3b7eeae7468bc", "tree": "8c74b81dfae162e0fd0ccf8d5ac50827ba815174", "parents": [ "6078aec213dfaf111c29969706e8e5967cfc9bea" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 16 20:32:27 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 22 15:13:56 2015 -0700" }, "message": "Move to newer clang annotations\n\nAlso enable -Wthread-safety-negative.\n\nChanges:\nSwitch to capabilities and negative capabilities.\n\nFuture work:\nUse capabilities to implement uninterruptible annotations to work\nwith AssertNoThreadSuspension.\n\nBug: 20072211\n\nChange-Id: I42fcbe0300d98a831c89d1eff3ecd5a7e99ebf33\n" }, { "commit": "e401d146407d61eeb99f8d6176b2ac13c4df1e33", "tree": "17927f9bfe7d2041b5942c89832d55f9dedb24c5", "parents": [ "2006b7b9b8e32722bd0d640c62549d8a0ac624b6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 13:56:20 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 29 18:45:49 2015 -0700" }, "message": "Move mirror::ArtMethod to native\n\nOptimizing + quick tests are passing, devices boot.\n\nTODO: Test and fix bugs in mips64.\n\nSaves 16 bytes per most ArtMethod, 7.5MB reduction in system PSS.\nSome of the savings are from removal of virtual methods and direct\nmethods object arrays.\n\nBug: 19264997\nChange-Id: I622469a0cfa0e7082a2119f3d6a9491eb61e3f3d\n" }, { "commit": "1cc71ebf333ca323ae0e130fefbce4593e385c10", "tree": "e94897ebb36a21f1c276fc69c44f6a3522cbe093", "parents": [ "35b6625c21e9304dd79700f4ff1c26a7e30d2b2d" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu May 07 10:47:27 2015 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu May 07 11:28:08 2015 -0700" }, "message": "Insert a read barrier in the JNI bridge.\n\nBug: 20720510\nBug: 12687968\nChange-Id: Ia9edb614853bad45ec25d6e2142361a8bda1eccf\n" }, { "commit": "48ee356484225ef0d7cfa197b1699524b866c802", "tree": "ea33754d124d5e15b02e1a7c09c81d27fd625ba3", "parents": [ "58565098b2298041ccc97371a3cc486df88d51b3" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 10 19:57:29 2015 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 10 20:42:14 2015 -0700" }, "message": "ART: Ignore result for exception-case JNIEndWithReference\n\nThe value may not contain a valid jobject, so ignore and use null\ndirectly.\n\nRefactor a bit to have one common function for both synchronized\nand non-synchronized case.\n\nAdd a test to the JNI compiler tests.\n\nBug: 18135031\nChange-Id: If2f004a112f36f4ff68172a946dec67ce561ae4d\n" }, { "commit": "c7dd295a4e0cc1d15c0c96088e55a85389bade74", "tree": "0c08a2236bc9ba5d9a4dc75d4dd0ed2d76f8f1c6", "parents": [ "94e5af8602150efa95bde35cc9be9891ddf30135" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 21 23:31:19 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 22 12:06:23 2014 -0700" }, "message": "Tidy up logging.\n\nMove gVerboseMethods to CompilerOptions. Now \"--verbose-methods\u003d\" option to\ndex2oat rather than runtime argument \"-verbose-methods:\".\nMove ToStr and Dumpable out of logging.h, move LogMessageData into logging.cc\nexcept for a forward declaration.\nRemove ConstDumpable as Dump methods are all const (and make this so if not\ncurrently true).\nMake LogSeverity an enum and improve compile time assertions and type checking.\nRemove log_severity.h that\u0027s only used in logging.h.\nWith system headers gone from logging.h, go add to .cc files missing system\nheader includes.\nAlso, make operator new in ValueObject private for compile time instantiation\nchecking.\n\nChange-Id: I3228f614500ccc9b14b49c72b9821c8b0db3d641\n" }, { "commit": "76433275dbe39e5ced1c223b006d1b900b1937f6", "tree": "a72c101defa86ceff8b633cf2eaa606c87f783eb", "parents": [ "88adf36315237947d3a5d10b28fdf8b9da7794a4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 26 14:32:37 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 26 19:54:39 2014 -0700" }, "message": "Optimize get/set reflection performance\n\nSpeedups mostly from reducing how often access checks are needed,\nand adding more inlining, and adding templates.\n\nField_getInt from ~850ns -\u003e 350ns.\nField_setInt from ~900ns -\u003e 370ns.\n\nBug: 14063288\n\n(cherry picked from commit ffc788cb7b5b9f53734d7bb8af2d5e45d885546b)\n\nChange-Id: I2441581ff3478c6ae43b6aa49939ff3f07555ec8\n" }, { "commit": "7b078e8c04f3e1451dbdd18543c8b9692b5b067e", "tree": "414229c6b87eb20ea24c40780752da5a3999a49a", "parents": [ "f79ba17defbd9342e44ab9f3de0807054673d3c9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 10 14:44:24 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 12 14:57:53 2014 -0700" }, "message": "Compile time performance improvements focusing on interpret-only.\n\nReduce virtual method dispatch in the method verifier and make more code\ninline-able.\nAdd a StringPiece with const char* equality operator to avoid redundant\nStringPieces and strlens.\nRemove back link from register line to verifier and pass as argument to reduce\nsize of RegisterLine.\nRemove instruction length from instruction flags and compute from the\ninstruction, again to reduce size.\nAdd suspend checks to resolve and verify to allow for more easy monitor\ninflation and reduce contention on Locks::thread_list_suspend_thread_lock_.\nChange ThrowEarlierClassFailure to throw pre-allocated exception.\nAvoid calls to Thread::Current() by passing self.\nTemplate specialize IsValidClassName.\nMake ANR reporting with SIGQUIT run using checkpoints rather than suspending\nall threads. This makes the stack/lock analysis less lock error prone.\nExtra Barrier assertions and condition variable time out is now returned as a\nboolean both from Barrier and ConditionVariable::Wait.\n\n2 threaded host x86-64 interpret-only numbers from 341 samples:\nBefore change: Avg 176.137ms 99% CI 3.468ms to 1060.770ms\nAfter change: Avg 139.163% 99% CI 3.027ms to 838.257ms\nReduction in average compile time after change is 20.9%.\nSlow-down without change is 26.5%.\n\nBug: 17471626 - Fix bug where RegTypeCache::JavaLangObject/String/Class/Throwable\ncould return unresolved type when class loading is disabled.\nBug: 17398101\n\nChange-Id: Id59ce3cc520701c6ecf612f7152498107bc40684\n" }, { "commit": "22d5e735f403c57525fe868304c7123f0ce66399", "tree": "2458684efa56f0b800dd75a9dedd0449f76f581f", "parents": [ "fbde4dd1cb6db729e3f3ee5bdae0cdd824d73054" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Jul 15 22:23:51 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jul 16 06:13:46 2014 -0700" }, "message": "Remove object_utils.h.\n\nBreak into object_lock, field_helper and method_helper.\nClean up header files following this.\nAlso tidy some of the Handle code in response to compiler errors when resolving\nthe changes in this CL.\n\nChange-Id: I73e63015a0f02a754d0866bfaf58208aebcaa295\n" }, { "commit": "98d1cc8033251c93786e2fa8c59a2e555a9493be", "tree": "f0a76b8fff060ee484af09028da65a8339d57057", "parents": [ "aebf3cda094f34cf846d19a7724bdc8005267c95" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Thu May 15 17:02:16 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Jul 11 17:17:10 2014 -0700" }, "message": "Improve performance of invokevirtual/invokeinterface with embedded imt/vtable\n\nAdd an embedded version of imt/vtable into class object. Both tables start at\nfixed offset within class object so method/entry point can be loaded directly\nfrom class object for invokeinterface/invokevirtual.\n\nBug: 8142917\nChange-Id: I4240d58cfbe9250107c95c0708c036854c455968\n" }, { "commit": "cf4035a4c41ccfcc3e89a0cee25f5218a11b0705", "tree": "323d9e98e6129c67e464a3e6857ee02593a2f2c2", "parents": [ "29b53d3d715b1ec19349e8cbf7c5e4ff529bd5fe" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed May 28 22:43:01 2014 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu May 29 20:50:49 2014 -0700" }, "message": "ART: Use StackReference in Quick Stack Frame\n\nThe method reference at the bottom of a quick frame is a stack\nreference and not a native pointer. This is important for 64b\narchitectures, where the notions do not coincide.\n\nChange key methods to have StackReference\u003cmirror::ArtMethod\u003e*\nparameter instead of mirror::ArtMethod**. Make changes to\ninvoke stubs for 64b archs, change the frame setup for JNI code\n(both generic JNI and compilers), tie up loose ends.\n\nTested on x86 and x86-64 with host tests. On x86-64, tests succeed\nwith jni compiler activated. x86-64 QCG was not tested.\n\nTested on ARM32 with device tests.\n\nFix ARM64 not saving x19 (used for wSUSPEND) on upcalls.\n\nTested on ARM64 in interpreter-only + generic-jni mode.\n\nFix ARM64 JNI Compiler to work with the CL.\n\nTested on ARM64 in interpreter-only + jni compiler.\n\nChange-Id: I77931a0cbadd04d163b3eb8d6f6a6f8740578f13\n" }, { "commit": "35aef2ce9d9cbfb37e9b2f6776afce3caed37063", "tree": "db1ce2f734a7ff0ad8cd4107a1aef85e7fdf8e0a", "parents": [ "27a2b70f612af9afc0fb5392fb10059f6a0a3569" ], "author": { "name": "Yevgeny Rouban", "email": "yevgeny.y.rouban@intel.com", "time": "Mon May 19 16:19:36 2014 +0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue May 20 10:44:00 2014 -0700" }, "message": "Fix race condition between GCDaemon and DeleteLocalReference\n\nThere is a race condition between the GCDaemon visiting\nthread local roots starting from the thread\u0027s indirect ref table (IRT)\nand another thread calling JNI::DeleteLocalReference, which is clearing\none of the indirect references.\n\nTo cope with the race condition the DeleteLocalReference used to transit\nfrom suspended to running state by creating a ScopedObjectReference(env).\nBut this transition was removed with the following patch:\nhttps://android.googlesource.com/platform/art/+/ef28b14268ed0f9db0c7bbd571aa514354a360bd%5E!/#F0\n\nIf so the GCDaemon must be careful to work with IRT entries.\n\nThis new patch:\n1. calls the visitor only if the reference is not null. This if-null\n behavior of ART GC is consistent with what Dalvik GC does.\n2. But this might be not enough for some future sophisticated GC algorithms.\n For example, if GC moves an object, then the IRT entry must be changed\n with CAS only if it has not been cleared. So, for the safety reasons\n the patch put backs the ScopedObjectReference soa(env) to\n DeleteLocalReference.\n\nOnly one of those two changes would be enough.\n\nmathieuc note: I decided to delete the root null check but kept the\nScopedObjectAccess in DeleteLocalRef and added missing annotations as\nwell as more ScopedObjectAccess in jni internals.\n\nBug: 14626564\n\nChange-Id: I90d4b8494f61404579ecdd2918d1482093d99387\nSigned-off-by: Yevgeny Rouban \u003cyevgeny.y.rouban@intel.com\u003e\nSigned-off-by: Yang Chang \u003cyang.chang@intel.com\u003e\n" }, { "commit": "eb8167a4f4d27fce0530f6724ab8032610cd146b", "tree": "bcfeaf13ad78f2dd68466bbd0e20c71944f7e854", "parents": [ "6fb66a2bc4e1c0b7931101153e58714991237af7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed May 07 15:43:14 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue May 13 14:45:54 2014 -0700" }, "message": "Add Handle/HandleScope and delete SirtRef.\n\nDelete SirtRef and replaced it with Handle. Handles are value types\nwhich wrap around StackReference*.\n\nRenamed StackIndirectReferenceTable to HandleScope.\n\nAdded a scoped handle wrapper which wraps around an Object** and\nrestores it in its destructor.\n\nRenamed Handle::get -\u003e Get.\n\nBug: 8473721\n\nChange-Id: Idbfebd4f35af629f0f43931b7c5184b334822c7a\n" }, { "commit": "c645f1ddb7c40bea6a38eda4b3f83f6b6dec405b", "tree": "de6141864c1c011216c19dd99a2c1e2bc442dd6d", "parents": [ "a9d7be62735e3356cef7e8ed797c519134a17061" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 06 18:11:53 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 07 12:09:04 2014 -0800" }, "message": "Add more VerifyObject calls.\n\nAdded verify object calls to SirtRef, IndirectReferenceTable,\nReferenceTable.\n\nRemoved un-needed verify object in ScopedObjectAccess / DecodeJObject\nsince object sources are handled.\n\nBug: 12934910\nChange-Id: I55a46a8ea61fed2a77526eda27fd2cce97a9b125\n" }, { "commit": "9e8b367100da968e0a2fd5e0db6330d108421203", "tree": "7ad0fd61116de65f91658817f4e8a93e204baf59", "parents": [ "5a40712f67341a8b919afbe6a6d462e8f9044767" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 28 17:06:40 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 28 17:06:40 2014 -0800" }, "message": "Add VerifyObject calls to JniMethodEndWithReference.\n\nBug: 12934910\nChange-Id: I9d0926100c5e08dfbaea8926e8ac7cdd4e7dfe1c\n" }, { "commit": "1eb512d33f94d1dd7ea38263307ba0f7a0dfa653", "tree": "b4d4d9b16013ab90fb4b40d23013d7ef44bb5852", "parents": [ "b917ea1a62aa0ab8eca3f689ef64b5be34e11abb" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 18 15:42:20 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sun Oct 20 14:55:26 2013 -0700" }, "message": "Fast JNI support.\n\nUse a modifier to signal a native method is a fast JNI method. If the\nmodifier is set then don\u0027t perform runnable transitions.\n\nChange-Id: I7835b4d837bfdd1cb8e2d54b919c0d5e6cf90499\n" }, { "commit": "ea46f950e7a51585db293cd7f047de190a482414", "tree": "9dddc8073547a2dcb58a19e1728932a89cb149c3", "parents": [ "5e3572709b5a5d59957f835db4f73760ecef08da" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Tue Jul 30 01:26:50 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 13 18:09:46 2013 -0700" }, "message": "Refactor java.lang.reflect implementation\n\nCherry-picked from commit ed41d5c44299ec5d44b8514f6e17f802f48094d1.\n\nMove to ArtMethod/Field instead of AbstractMethod/Field and have\njava.lang.reflect APIs delegate to ArtMethod/ArtField.\n\nBug: 10014286.\n\nChange-Id: Iafc1d8c5b62562c9af8fb9fd8c5e1d61270536e7\n" }, { "commit": "848871b4d8481229c32e0d048a9856e5a9a17ef9", "tree": "4be4602e3becc899f76a29a87618801458fe04b9", "parents": [ "423fb4d70f2ac36bf9f630146b4150771a8e7e76" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Aug 05 10:56:33 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Aug 07 22:17:00 2013 -0700" }, "message": "Entry point clean up.\n\nCreate set of entry points needed for image methods to avoid fix-up at load time:\n - interpreter - bridge to interpreter, bridge to compiled code\n - jni - dlsym lookup\n - quick - resolution and bridge to interpreter\n - portable - resolution and bridge to interpreter\n\nFix JNI work around to use JNI work around argument rewriting code that\u0027d been\naccidentally disabled.\nRemove abstact method error stub, use interpreter bridge instead.\nConsolidate trampoline (previously stub) generation in generic helper.\nSimplify trampolines to jump directly into assembly code, keeps stack crawlable.\nDex: replace use of int with ThreadOffset for values that are thread offsets.\nTidy entry point routines between interpreter, jni, quick and portable.\n\nChange-Id: I52a7c2bbb1b7e0ff8a3c3100b774212309d0828e\n" }, { "commit": "7655f29fabc0a12765de828914a18314382e5a35", "tree": "219f2df20cf7f053a73a345ae20e131a73759c79", "parents": [ "1a8080d4c2e1772cfcc5e9d6587bc63bba3945d9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jul 29 11:07:13 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Jul 30 16:00:24 2013 -0700" }, "message": "Portable refactorings.\n\nSeparate quick from portable entrypoints.\nMove architectural dependencies into arch.\n\nChange-Id: I9adbc0a9782e2959fdc3308215f01e3107632b7c\n" }, { "commit": "166db04e259ca51838c311891598664deeed85ad", "tree": "5ffa63c1b3bf58e92be2890c54f0ba6fdec2059e", "parents": [ "d41119e863a9f9c5809b7732d30870ffd237b60c" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Jul 26 12:05:57 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jul 29 09:52:11 2013 -0700" }, "message": "Move assembler out of runtime into compiler/utils.\n\nOther directory layout bits of clean up. There is still work to separate quick\nand portable in some files (e.g. argument visitor, proxy..).\n\nChange-Id: If8fecffda8ba5c4c47a035f0c622c538c6b58351\n" }, { "commit": "7934ac288acfb2552bb0b06ec1f61e5820d924a4", "tree": "43f3acd8af7fd34d4ae7b64f6e06bb8429d74bb8", "parents": [ "fb331d7ca004f39608fcfdae49d38df90c702ea9" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 10:54:15 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 11:55:10 2013 -0700" }, "message": "Fix cpplint whitespace/comments issues\n\nChange-Id: Iae286862c85fb8fd8901eae1204cd6d271d69496\n" }, { "commit": "2ce745c06271d5223d57dbf08117b20d5b60694a", "tree": "08ca327d1f1c8266fafb11422cfad6982f21e0bb", "parents": [ "fc0e3219edc9a5bf81b166e82fd5db2796eb6a0d" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 17:44:30 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 21:46:11 2013 -0700" }, "message": "Fix cpplint whitespace/braces issues\n\nChange-Id: Ide80939faf8e8690d8842dde8133902ac725ed1a\n" }, { "commit": "7940e44f4517de5e2634a7e07d58d0fb26160513", "tree": "ac90242d96229a6942f6e24ab137bc1f8f2e0025", "parents": [ "5cd9e3b122f276f610980cbaf0d2ad6ed4cd9088" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 13:46:57 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 17:49:01 2013 -0700" }, "message": "Create separate Android.mk for main build targets\n\nThe runtime, compiler, dex2oat, and oatdump now are in seperate trees\nto prevent dependency creep. They can now be individually built\nwithout rebuilding the rest of the art projects. dalvikvm and jdwpspy\nwere already this way. Builds in the art directory should behave as\nbefore, building everything including tests.\n\nChange-Id: Ic6b1151e5ed0f823c3dd301afd2b13eb2d8feb81\n" }, { "commit": "79fe539587d4c09244172d0168eeed0ec9770466", "tree": "4fb8fbd03727a74acb4dfde7e969adf32ee32750", "parents": [ "09b55e1df3b0bcecee25882e45e882887cc8654f" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Wed Apr 24 18:41:58 2013 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Fri Apr 26 14:50:52 2013 -0700" }, "message": "Removing remaining compiled stubs from image.\n\nAbstract method error stub and jni dlsym lookup stubs are gone.\nAfter this change, the image no longer needs to be executable.\n\nChange-Id: Ic75d72bf7e76e3b8ecc596e82af68ab592dde15e\n" }, { "commit": "62d6c772205b8859f0ebf7ad105402ec4c3e2e01", "tree": "e2f2ba6d71ed5a39c9f6909e3f7c08e998053315", "parents": [ "c9b17c7ee96cd04fac9048aab624ed554fe260bf" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Feb 27 08:32:07 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Apr 08 14:24:13 2013 -0700" }, "message": "Interpreter entries and instrumentation as a listener.\n\nMake the instrumentation responsible for whether we want method entry/exit\nstubs, and allow it to use interpreter entry stubs when instruction by\ninstruction instrumentation is required. Improve deoptimization so more JDWP\ntest cases are passing.\n\nRefactor exception debug posting, in particular improve reporting in the\ninterpreter. Improve class linker exception throwing so that broken dex files\nare more likely to be reported. Fixes the performance issue Bug: 8410519.\n\nFix some error reporting lock level errors for the large object space. Make\nfast object verification faster.\n\nAdd some debug mode robustness to finding dex PCs in GC maps.\n\nAdd printf attributes to JniAbortF and fix errors.\n\nExpand run-test 044 to test return behaviors and fix issues with not throwing\nappropriate exceptions for proxies.\n\nEnsure causes are reported with a class linker NoClassDefFoundError and JNI\nNoSuchFieldError.\n\nRemove unused debugMe and updateDebuggerFromCode.\n\nThere\u0027s a minor sizing tweak to the arg array builder, and an extra reference\narray check in the interpreter.\n\nSome clean-up of trace code.\n\nFix reg type cache destructor if it is called after the reg type cache is\nshutdown (as is the case in oatdump).\n\nChange-Id: I6519c7b35df77f978d011999354c864f4918e8ce\n" }, { "commit": "4f6ad8ab428038129b2d0d6c40b7fd625cca15e1", "tree": "d1025ed9203d0cdf7aa959d9cecd8dc1f0c0bfeb", "parents": [ "aabe8adacc7bf3a8ab6f6f3dd37fc839b6fd762f" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Mar 18 15:27:28 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Mar 18 15:29:59 2013 -0700" }, "message": "Various performance improvements.\n\nPerformance had regressed due to verify object and method invocation changes.\nAvoid trampolines for static calls in same class.\nVarious inlining changes.\nMake verify object something that\u0027s only compiled-in in debug builds.\n\nChange-Id: Ia261a52232c3b10667c668f8adfadc0da3048bc5\n" }, { "commit": "693ff61274cd2c9b8eb7e68c370f84a911b8ca52", "tree": "11f1f6b3e5302b8a58c5ca44c3a1bec1b16d90a4", "parents": [ "12a2bdd245ea866b665d4800b493397ec412892a" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Feb 01 10:56:12 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Feb 01 21:29:49 2013 -0800" }, "message": "Performance improvements by removing a DMB and inlining.\n\nCorrect the version of CAS used by Mutex::Lock to be acquire and not release.\nDon\u0027t do a memory barrier in thread transitions when there is already a\nbarrier associated with the mutator lock.\nForce inlining of the hot thread and shared lock code, heavily used by down\ncalls and JNI.\nForce inlining of mirror routines that are used by runtime support and hot.\n\nPerformance was measured and improved using perf and maps.\n\nChange-Id: I012580e337143236d8b6d06c1e270183ae51083c\n" }, { "commit": "2dd0e2cea360bc9206eb88ecc40d259e796c239d", "tree": "9d619dc9508cbe73e4793bf6f08cbc761abfb48a", "parents": [ "ac21b797b3a425975d656d6b84a7b24401d35f42" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jan 24 12:42:14 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jan 30 16:48:31 2013 -0800" }, "message": "Directory restructuring of object.h\n\nBreak object.h into constituent files.\nReduce number of #includes in other GC header files.\nIntroduce -inl.h files to avoid mirror files #include-ing each other.\nCheck invariants of verifier RegTypes for all constructors.\n\nChange-Id: Iecf1171c02910ac152d52947330ef456df4043bc\n" }, { "commit": "120f1c74a9768e958377b6c97897511b27ae58c8", "tree": "fa1f90d88ea34d8ef9eec729d27c7a70956a6a09", "parents": [ "cabc60e71a65fa17e5a99fba94fc61523fbeb478" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 17:17:10 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 03 17:29:26 2012 -0700" }, "message": "Fail threads attaching during runtime shutdown.\n\nIntroduce counters to indicate that threads are being born. Don\u0027t allow\nthread birth to occur during runtime shutdown.\n\nBug: 7000936\n\nChange-Id: Ib0d78f78c0ff126a4b5d3b5a6f1a2ff8f5061ae9\n" }, { "commit": "81d425b0b232962441616f8b14f73620bffef5e5", "tree": "cd1e46656269acf20e78817d675e56d9b9133e6c", "parents": [ "bfaf917edbb1de8d158c3615e0da8ac3143d10c8" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Sep 27 16:03:43 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Sep 27 17:19:25 2012 -0700" }, "message": "Pass self to lock methods.\n\nThis avoids frequent recomputation of\nThread::Current/pthread_getspecific.\n\nAlso add a futex based reader/writer mutex that is disabled.\n\nChange-Id: I118fdb99ef1d1c4bfda6446ba3a0d8b6ab31eaee\n" }, { "commit": "66f19258f9728d4ffe026074d8fd429d639802fa", "tree": "fd94009774c6cbbb1528ea096e606133bd35f104", "parents": [ "a5e1e3d153990845d80cb8d013157210f11a473c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 18 08:57:04 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 21 17:32:56 2012 -0700" }, "message": "Change dex cache to be java object instead of array, add pointer to dex file in dex cache.\n\nGeneric clean up to facilitate having GDB macros for Pretty* helper functions.\n\nImproved cleanliness of DexCache since having it as an object array was not the best solution.\n\nFixed a bug in InOrderWalk caused by ResolveType sometimes allocating classes.\n\nRename C++ Method to AbstractMethod and add two new classes Constructor, Method which both inherit from AbstractMethod.\n\nRename done to have the C++ code be closer to the java code.\n\nChange-Id: I4995b4c5e47a3822192b08afa24a639d3b1f4da9\n" }, { "commit": "0c7abda482f53db3d153c073d1c7a145f84e0626", "tree": "837b89c75f0047cbcd16c9121739069a36b4f22a", "parents": [ "ba0b9c55adce3f533845ab1b25c552589e5b4118" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 19 13:33:42 2012 -0700" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Sep 20 15:26:35 2012 -0700" }, "message": "NativePcOffsetToReferenceMap\n\nRather than translate a native PC to a Dex PC and then to the reference\nbitmap, just go straight from the native PC to the reference bitmap.\nEncode the native PC offsets using a hash rather than linearly\nsearching.\n\nChange-Id: Iee1073d93c941c0a31f639e5f23cea9e9f747bee\n" }, { "commit": "b726dcb581bf72da46527378ccb6889020f0e6e9", "tree": "c0383ed788652926e93147e50d659ed226519548", "parents": [ "fd678beb171a4686a4f2d53ca4188a4ade8fa54e" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 08:57:23 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 09:06:19 2012 -0700" }, "message": "Rename GlobalSynchronization to Locks\n\nAlso address some review comments in common_throws relating to\nToStr\u003cInvokeType\u003e and exception detail messages.\n\nChange-Id: Ibf2c0f147689fa236d349bd7f01eed3c2522552b\n" }, { "commit": "3d71d80626fdc0fe1f61c84bb52e9f7d96c95060", "tree": "b65d908c11f270e6f54e241f332b01aa27134d68", "parents": [ "cd05a6274782c50a2b990c18b5f8d5ae5e44d509" ], "author": { "name": "TDYa127", "email": "tdy@google.com", "time": "Wed Aug 15 03:47:03 2012 -0700" }, "committer": { "name": "TDYa127", "email": "tdy@google.com", "time": "Wed Aug 15 04:01:19 2012 -0700" }, "message": "Fix JNI compiler for portable path.\n\nChange-Id: Ic2cbfcf126137b1b72f3b51e7af5a9be87987737\n" }, { "commit": "00f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abac", "tree": "6a2172ece15c4699e6c2a67ce76f019db0a9a21d", "parents": [ "634ea28f78c4a138e6a1de54eae8696095422415" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 19 15:28:27 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 14 10:45:52 2012 -0700" }, "message": "Global lock levels.\n\nIntroduce the notion of the mutators/GC being a shared-exclusive (aka\nreader-writer) lock. Introduce globally ordered locks, analysable by\nannotalysis, statically at compile time. Add locking attributes to\nmethods.\n\nMore subtly, remove the heap_lock_ and split between various locks that\nare held for smaller periods (where work doesn\u0027t get blocked). Remove\nbuggy Dalvik style thread transitions. Make GC use CMS in all cases when\nconcurrent is enabled. Fix bug where suspend counts rather than debug\nsuspend counts were sent to JDWP. Move the PathClassLoader to\nWellKnownClasses. In debugger refactor calls to send request and\npossibly suspend. Break apart different VmWait thread states. Move\nidentity hash code to a shared method.\n\nChange-Id: Icdbfc3ce3fcccd14341860ac7305d8e97b51f5c6\n" }, { "commit": "0399dde18753aa9bd2bd0d7cf60beef154d164a4", "tree": "ea88327c01ca321074aaa59b97e4c54348802937", "parents": [ "de5705dcf4ab5f92d48e144bcd7b59f7bcd18e16" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jun 06 17:09:28 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jun 21 22:11:24 2012 -0700" }, "message": "Remove Frame, merge shadow and quick representations.\n\nChange-Id: I5ae03a5e52111792d2df7e83cbd89ab25777844b\n" }, { "commit": "748474146da0c6484fa3dca0a700f612d47550c3", "tree": "58837d0fa82d4099eb4b82b2fd3d2bbf4294e4aa", "parents": [ "92e3134cd84c134f167175288671a1e6838c908f" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 20 18:10:21 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 21 09:14:27 2012 -0700" }, "message": "Fix a bunch of lint.\n\nThere are still about 1800 lint warnings, so don\u0027t get too excited...\n\nChange-Id: I2394bd6e750b94060231378b3a7a88b87f70c757\n" }, { "commit": "3f6635a2c84d645002f651c312d53f8348646c1f", "tree": "e46caa5d1199aca6f6b3c1cbd5f0e706606682c3", "parents": [ "c553b95527b78c1fcf9b719a87d8875f71280f71" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jun 19 13:37:49 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jun 19 14:26:32 2012 -0700" }, "message": "Improve JniAbort (and JNI tests).\n\nThis has been on my to-do list for a while, but it actually bit people\nin the ass yesterday. This change enables us to write a lot more (and\nbetter) tests, but for now I\u0027ve just improved the tests that already\nexisted.\n\nChange-Id: I04a18656de60b47e5a6b5777204c144209d1448e\n" }, { "commit": "b264f081424642b06b0bbe7102781895d41faa9d", "tree": "5ee2b94e5905ff69d3f138ebbecb7abe2a44149f", "parents": [ "b77799df950bf486abe3780185bc4932a3b47bad" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Apr 06 17:10:10 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 09 09:55:00 2012 -0700" }, "message": "Implement native method return value and upcall argument type checking.\n\nAlso clean up the CheckJNI testing a bit. I still need to do some work so that\nJniAbort catches more of the detail, but this is a step forward.\n\nChange-Id: Ibf5e32867d56123cff902ebf602406b731f567d2\n" }, { "commit": "0f3c55331439970e01af67f80ac117c473bc04cf", "tree": "cfa28ad2a58af1ffddb0a2ce90443ad4606743c3", "parents": [ "273cf36d199cf73de3cf61a559ad27c9d23f9825" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Mar 30 14:51:51 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Mar 30 14:51:51 2012 -0700" }, "message": "Kill constants.h and fix some copyright headers.\n\nChange-Id: I51c04d731d6de035328781d8ac134ad6fcf49897\n" }, { "commit": "57b86d47b66322693a070185fadfb43cb9c12eab", "tree": "81d53304a63a660a683917a19f7dd83723a397ad", "parents": [ "68aefb06c449df0bd8a34f3491f7594ee3f9dd0b" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Mar 27 16:05:41 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 29 11:51:44 2012 -0700" }, "message": "Refactor runtime support.\n\nChange-Id: Id7470a4105838150d5ceb73ab2c8c83e739660df\n" } ] }