)]}' { "log": [ { "commit": "2d4feeb67912d64b9e980e6687794826a5c22f9d", "tree": "7ab2071bbf5d5907d205b8e2a092ea9869974ba1", "parents": [ "60abdd9c89525a277d75df19ff2792614651e1ff" ], "author": { "name": "Mythri Alle", "email": "mythria@google.com", "time": "Wed Oct 13 15:39:37 2021 +0000" }, "committer": { "name": "Mythri Alle", "email": "mythria@google.com", "time": "Mon Nov 01 08:31:54 2021 +0000" }, "message": "Add support for calling entry / exit hooks directly from JIT code\n\nThe idea of this CL is to avoid maintaining the instrumentation stack\nand manipulating the return addresses on the stack to call the entry /\nexit hooks. This Cl only addresses this for JITed code. In follow up\nCLs, we will extend this to others (native, nterp). Once we have\neverything in place we could remove the complexity of instrumentation\nstack.\n\nThis CL introduces new nodes (HMethodEntry / HMethodExit(Void)) that\ngenerate code to call the trace entry / exit hooks when\ninstrumentation_stubs are installed. Currently these are introduced for\nJITed code in debuggable mode. The entry / exit hooks roughly do the\nsame this as instrumentation entry / exit points.\nWe also extend the JITed frame slots by adding a ShouldDeoptimize slot.\nThis will be used to force deoptimization of frames when requested by\njvmti (for ex: structural re-definition).\n\nTest: art/testrunner.py\nChange-Id: Id4aa439731d214a8d2b820a67e75415ca1d5424e\n" }, { "commit": "2ca0900e98d826644960eefeb8a21c84850c9e04", "tree": "ba8a25622f6bee25817be41880ea01c345d9a2b1", "parents": [ "44101a388089b4e23b284e1794eb475938a2f7ed" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 19 16:19:34 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 19 16:23:58 2021 +0000" }, "message": "Revert \"JNI: Remove `JniMethodFast{Start,End}()`.\"\n\nThis reverts commit 64d6e187f19ed670429652020561887e6b220216.\n\nReason for revert: Breaks no-image JIT run tests (flaky).\n\nBug: 172332525\nChange-Id: I7813d89283eff0f6266318d3fb02d1257471798d\n" }, { "commit": "64d6e187f19ed670429652020561887e6b220216", "tree": "0b7d39fd7d0a155786d84f23364313a7f63542a7", "parents": [ "b37da9d4ffbc5ab42c41fcd60dc0dac6357ea13b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Oct 14 09:32:01 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 19 13:25:55 2021 +0000" }, "message": "JNI: Remove `JniMethodFast{Start,End}()`.\n\nInline suspend check from `GoToRunnableFast()` to JNI stubs.\nThe only remaining code in `JniMethodFast{Start,End}()` is a\ndebug mode check that the method is @FastNative, so remove\nthe call altogether as we prefer better performance over the\ndebug mode check. Replace `JniMethodFastEndWithReference()`\nwith a simple `JniDecodeReferenceResult()`.\n\nGolem results for art-opt-cc (higher is better):\nlinux-ia32 before after\nNativeDowncallStaticFast 149.00 226.77 (+52.20%)\nNativeDowncallStaticFast6 107.39 140.29 (+30.63%)\nNativeDowncallStaticFastRefs6 104.50 130.54 (+24.92%)\nNativeDowncallVirtualFast 147.28 207.09 (+40.61%)\nNativeDowncallVirtualFast6 106.39 136.93 (+28.70%)\nNativeDowncallVirtualFastRefs6 104.50 130.54 (+24.92%)\nlinux-x64 before after\nNativeDowncallStaticFast 133.10 173.50 (+30.35%)\nNativeDowncallStaticFast6 109.12 135.73 (+24.39%)\nNativeDowncallStaticFastRefs6 105.29 127.18 (+20.79%)\nNativeDowncallVirtualFast 127.74 167.66 (+31.25%)\nNativeDowncallVirtualFast6 106.39 128.12 (+20.42%)\nNativeDowncallVirtualFastRefs6 105.29 127.18 (+20.79%)\nlinux-armv7 before after\nNativeDowncallStaticFast 18.058 21.622 (+19.74%)\nNativeDowncallStaticFast6 14.903 17.057 (+14.45%)\nNativeDowncallStaticFastRefs6 13.006 14.620 (+12.41%)\nNativeDowncallVirtualFast 17.848 21.027 (+17.81%)\nNativeDowncallVirtualFast6 15.196 17.439 (+14.76%)\nNativeDowncallVirtualFastRefs6 12.897 14.764 (+14.48%)\nlinux-armv8 before after\nNativeDowncallStaticFast 19.183 23.610 (+23.08%)\nNativeDowncallStaticFast6 16.161 19.183 (+18.71%)\nNativeDowncallStaticFastRefs6 13.235 15.041 (+13.64%)\nNativeDowncallVirtualFast 17.839 20.741 (+16.26%)\nNativeDowncallVirtualFast6 15.500 18.272 (+17.88%)\nNativeDowncallVirtualFastRefs6 12.481 14.209 (+13.84%)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 172332525\nChange-Id: I680aaeaa0c1a55796271328180e9d4ed7d89c0b8\n" }, { "commit": "d95a1f2ecf322d21ae98bfb7affe0070ddb9bc08", "tree": "8fc5fe8370ec051289a34cde7bf3dc5fc7a1ca7f", "parents": [ "507a729e51588f7fa4eac7579d54ce7c96804349" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 23 16:32:52 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 11 11:56:59 2021 +0000" }, "message": "Inline IRT frame push/pop into JNI stubs.\n\nGolem results for art-opt-cc (higher is better):\nlinux-ia32 before after\nNativeDowncallStaticNormal 25.704 26.839 (+4.414%)\nNativeDowncallStaticNormal6 23.857 25.086 (+5.152%)\nNativeDowncallStaticNormalRefs6 23.704 25.248 (+6.513%)\nNativeDowncallVirtualNormal 25.578 27.000 (+5.560%)\nNativeDowncallVirtualNormal6 23.704 24.925 (+5.153%)\nNativeDowncallVirtualNormalRefs6 23.704 25.074 (+5.870%)\nNativeDowncallStaticFast 100.65 149.13 (+48.17%)\nNativeDowncallStaticFast6 78.304 107.39 (+37.71%)\nNativeDowncallStaticFastRefs6 76.962 104.45 (+35.71%)\nNativeDowncallVirtualFast 100.40 147.28 (+46.69%)\nNativeDowncallVirtualFast6 79.302 106.34 (+34.10%)\nNativeDowncallVirtualFastRef26 76.617 103.29 (+34.82%)\nlinux-x64 before after\nNativeDowncallStaticNormal 26.083 26.987 (+3.465%)\nNativeDowncallStaticNormal6 24.606 25.411 (+3.271%)\nNativeDowncallStaticNormalRefs6 24.150 25.086 (+3.877%)\nNativeDowncallVirtualNormal 25.743 26.812 (+4.156%)\nNativeDowncallVirtualNormal6 24.294 25.248 (+3.927%)\nNativeDowncallVirtualNormalRefs6 23.857 25.086 (+5.152%)\nNativeDowncallStaticFast 109.95 133.10 (+21.06%)\nNativeDowncallStaticFast6 90.274 109.12 (+20.87%)\nNativeDowncallStaticFastRefs6 87.282 105.29 (+20.63%)\nNativeDowncallVirtualFast 104.00 127.55 (+22.65%)\nNativeDowncallVirtualFast6 88.191 106.73 (+21.02%)\nNativeDowncallVirtualFastRef26 85.530 102.09 (+19.36%)\nlinux-armv7 before after\nNativeDowncallStaticNormal 6.1148 6.3694 (+4.316%)\nNativeDowncallStaticNormal6 5.6845 5.9026 (+3.837%)\nNativeDowncallStaticNormalRefs6 5.4054 5.6022 (+3.641%)\nNativeDowncallVirtualNormal 5.4726 5.7088 (+4.316%)\nNativeDowncallVirtualNormal6 5.1789 5.3685 (+3.660%)\nNativeDowncallVirtualNormalRefs6 4.9140 5.0902 (+3.586%)\nNativeDowncallStaticFast 16.683 18.058 (+8.239%)\nNativeDowncallStaticFast6 13.951 14.896 (+6.770%)\nNativeDowncallStaticFastRefs6 12.279 13.006 (+5.919%)\nNativeDowncallVirtualFast 16.161 17.848 (+10.44%)\nNativeDowncallVirtualFast6 14.085 15.196 (+7.892%)\nNativeDowncallVirtualFastRef26 12.089 12.897 (+6.683%)\nlinux-armv8 before after\nNativeDowncallStaticNormal 6.0663 6.4229 (+5.879%)\nNativeDowncallStaticNormal6 5.7252 6.0437 (+5.563%)\nNativeDowncallStaticNormalRefs6 5.3114 5.5814 (+5.082%)\nNativeDowncallVirtualNormal 5.8795 6.2651 (+6.558%)\nNativeDowncallVirtualNormal6 5.6232 5.9494 (+5.801%)\nNativeDowncallVirtualNormalRefs6 5.1862 5.4429 (+4.948%)\nNativeDowncallStaticFast 17.638 19.183 (+8.760%)\nNativeDowncallStaticFast6 14.903 16.161 (+8.438%)\nNativeDowncallStaticFastRefs6 12.475 13.235 (+6.094%)\nNativeDowncallVirtualFast 15.826 17.848 (+12.78%)\nNativeDowncallVirtualFast6 14.064 15.504 (+10.24%)\nNativeDowncallVirtualFastRef26 11.628 12.475 (+7.285%)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 172332525\nChange-Id: I5ecfa7a661f08ab63dd2a75d666e1c1b9121935f\n" }, { "commit": "9cc65df0146e05bda535991290f53b795a61a025", "tree": "b1ea41c26c54984a031c17abbc0c85e1195e4ca2", "parents": [ "08a37a09da7992dde879cabb6a8deb3c9e78115c" ], "author": { "name": "Mythri Alle", "email": "mythria@google.com", "time": "Tue Sep 21 15:09:58 2021 +0000" }, "committer": { "name": "Mythri Alle", "email": "mythria@google.com", "time": "Fri Sep 24 09:23:34 2021 +0000" }, "message": "Drop unused arguments for MethodEntered function\n\nthis_object and dex_pc aren\u0027t used in MethodEntered listener.\n\nTest: art/test/run-test\nChange-Id: I158f962befe1015d21d08c757d4c415fe7865d16\n" }, { "commit": "4f6bb446f8fbaa192f4e5b69734414c66d5e1bae", "tree": "c07c8cf278137c14fda476ed682968ee3c01c65f", "parents": [ "beb9f2012587035a5c30d0eca8af458b2ad659b7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 02 18:05:51 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 09 11:03:12 2021 +0000" }, "message": "Remove palette hooks.\n\nMake the method be part of the official palette API.\n\nBug: 186016399\nBug: 185778652\nChange-Id: I3dc9e879c647fd63f5826091813613fd97e25c0d\n" }, { "commit": "e8efdaa09b7ff36d5a986f0320f29ac4a7563896", "tree": "5066cecab43006a7bf23f793aa911f74559c8017", "parents": [ "ae553e0e1b26d95006aa27df4675104bfb55d49d" ], "author": { "name": "Christian Wailes", "email": "chriswailes@google.com", "time": "Wed May 26 17:33:54 2021 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu May 27 19:28:16 2021 +0000" }, "message": "Revert \"Remove stack protector from some interpreter functions\"\n\nA performance regression was noticed in go/lem banchmarks for ART. This\nis likely caused by the no_stack_protector attribute preventing inlining\ninto hot functions.\n\nReason for revert: performance regression\nReverted Changes:\nIe0c81f97f:Remove stack protector from some interpreter funct...\nIaf565a374:Reset stack guard after fork from Zygote\n\nBug: 168258494\nChange-Id: I018d58759c3a5bb624ea8e7fe09b6b49c9b19b6a\n" }, { "commit": "abe7c69edb5ff8f9a4b8019d475caa2f35085aa7", "tree": "d8d86bf8c2264897eb9f7cf35be7c523f611688e", "parents": [ "571a6bea24452e9b288106f379c7510c380a7f61" ], "author": { "name": "Chris Wailes", "email": "chriswailes@google.com", "time": "Wed May 12 17:16:50 2021 -0700" }, "committer": { "name": "Christian Wailes", "email": "chriswailes@google.com", "time": "Tue May 25 17:47:38 2021 +0000" }, "message": "Remove stack protector from some interpreter functions\n\nThis CL removes stack protection from several functions in the\ninterpreter to allow us to re-set the stack protector cookie when new\nprocesses fork from any of the zygotes.\n\nTest: boot\nTest: atest KeyboardVisibilityControlTest\nBug: 168258494\nChange-Id: Ie0c81f97fedfcdde7afc1b6b4befa65524724194\n" }, { "commit": "ec06809b9fb7d4a0d2c3e46066bd37034130e53b", "tree": "c3a69b142e38d249a01ed425cde23caa78c1d36c", "parents": [ "1651c6050d913fb38ebd293df9da6d189eb3851d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon May 10 17:28:32 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri May 14 07:38:39 2021 +0000" }, "message": "Reland \"Devirtualize to HInvokeStaticOrDirect.\"\n\nThis reverts commit 39d4df62d4e2606073d05cc363370db825ad7b9f.\n\nReason for revert: fix JIT-zygote issue.\n\nTest: JIT zygote boots.\n\nChange-Id: I895ad8e59e472fb662ca9bc5394c2fd9c6babc74\n" }, { "commit": "39d4df62d4e2606073d05cc363370db825ad7b9f", "tree": "8e4cf0ac432406081d11e9102981446498b3265b", "parents": [ "a28c827fdb58ec489931d6e70e27818619bc1b75" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri May 07 12:22:47 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri May 07 14:41:25 2021 +0000" }, "message": "Revert \"Devirtualize to HInvokeStaticOrDirect.\"\n\nThis reverts commit 5024ddfd125b5c3b59d7f359ae33cf7f0255b048.\n\nBug: 187408838\n\nReason for revert: b/187408838\n\nChange-Id: If74f5ddbacc73296f66c55762e2a8d1ec2cd1f19\n" }, { "commit": "5024ddfd125b5c3b59d7f359ae33cf7f0255b048", "tree": "b625ed5aa1c4976e4cd2de5732543d5d1eb34a0f", "parents": [ "5859b689d4fdd36711187715c04e2e095f7975c0" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Apr 28 14:42:09 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu May 06 10:37:17 2021 +0000" }, "message": "Devirtualize to HInvokeStaticOrDirect.\n\nWhen we statically know the target method, devirtualize an\nHInvokeInterface or an HInvokeVirtual to a HInvokeStaticOrDirect.\n\nTest: test.py\nBug: 182538502\nChange-Id: Ie3a58603cde300fca9ca4972d4dfbbd20918f5ba\n" }, { "commit": "c3db254375df1f1459ac83cbf54b3eee92b138bd", "tree": "e6262127c6f4215ac0fffb98690b33f05daa7f9b", "parents": [ "0349b152f29a286d7365f17d0b21d735c71c39e3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 20 15:50:04 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 27 13:04:54 2021 +0000" }, "message": "Revert^2 \"Add hooks in palette for reporting JNI invocations.\"\n\nTest: test.py\nBug: 140968481\n\nChange-Id: I3ebbec153040b9bcfe4fb86618c15d2f9c93abb6\n" }, { "commit": "4501517c28357189f60f05494facc7e6ba2a8513", "tree": "2c12fb101942d86dd70262948dce31d7d8580bf3", "parents": [ "a9fed15c697d67bfbd2131d090a876145ad33910" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 20 13:41:09 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 20 15:49:27 2021 +0000" }, "message": "Revert \"Add hooks in palette for reporting JNI invocations.\"\n\nRevert \"Add JNI headers to palette dependencies.\"\n\nRevert submission 1678069-palette-jni\n\nReason for revert: Overhead of GetHooks call.\nReverted Changes:\nI909fc720f:Add hooks in palette for reporting JNI invocations...\nI5f036e5c0:Add JNI headers to palette dependencies.\n\nChange-Id: I327ae5f0e6e63f618d2e4cf08b7c4926071cb8ce\n" }, { "commit": "511392f151143f7d8bf2f82d5201ffa6d5d051de", "tree": "90b099b337432e8671f47c8eac6b1d5021db3293", "parents": [ "ae3aa6ca3e1bb29845da8844ab72ae2dc76d7793" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 16 13:27:20 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Apr 19 16:04:21 2021 +0000" }, "message": "Add hooks in palette for reporting JNI invocations.\n\nTest: test.py\nChange-Id: I909fc720fe5b891da6919fe20ad162ec12524f02\n" }, { "commit": "34ce1b8a86f1be2142f019ab291b7445db5c4305", "tree": "9dada63c4a13a8421ad0199118930fe60fea9047", "parents": [ "a718d6450feae9ee6b5de96407c8e44afbf173e7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 11 12:11:31 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 11 15:01:39 2021 +0000" }, "message": "Clean up transitions in JniMethodEnd.\n\nGoToRunnable() is never called for @FastNative, so\nwe can remove the path that calls GoToRunnableFast().\n\nAdd a call to GoToRunnableFast() for @FastNative in\nGenericJniMethodEnd().\n\nThis is a follow-up to\n https://android-review.googlesource.com/1620969\nthat cleaned up JniMethodStart but missed similar\nopportunity for the transition back to Runnable from\nvarious JniMethodEnd methods.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 172332525\nChange-Id: Ia519bfc6ea50c1b65241041a3af8b7d4b1027f77\n" }, { "commit": "68e8a7c0a96d941bf08956dd0d8d83c282d0af9f", "tree": "39483f0575738b39ef7cad3efa267da8efd3ead9", "parents": [ "c2f46939d8c046dfc8e954ac1bec6d61b0f061ae" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 05 08:40:22 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 08 09:15:07 2021 +0000" }, "message": "Clean up JniMethodStart().\n\nAfter we have clarified that @FastNative methods cannot be\nsynchronized and starting enforcing it in\n https://android-review.googlesource.com/1518545\nwe can clean up JniMethodStart() and remove the check for\n@FastNative (though we keep a CHECK in debug builds).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 172332525\nChange-Id: I1466dbca3b22524b8cc72db79bf583d64d32c7bf\n" }, { "commit": "c714f40caec532522ecc5e611b15e857b3b65484", "tree": "598daf5db137ae9bceab4e676c72c724d180d251", "parents": [ "17b4d2b14fd26088bca195b5d7c48f26b8b545d8" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 04 14:24:38 2021 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Mar 05 12:07:49 2021 +0000" }, "message": "Fix crash on error paths from GenericJNI trampoline.\n\nTest: Added a regression test to 178-app-image-native-method\nTest: testrunner.py --host --optimizing -t 178-app-image-native-method\nBug: 181736463\nChange-Id: Ib98d6d58ce1fb8287c32f88fda0f83b7e21ef42d\n" }, { "commit": "0eebdcc511364a9ade5290507d446f41cf256fbe", "tree": "fde6e4e7ce9dd1b2e1028cd2aee63e428f05a902", "parents": [ "0a73762a454abc961a6fcf0e27df00586c5f13e1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Feb 26 09:34:13 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Feb 26 15:42:43 2021 +0000" }, "message": "Fix jclass read barrier in GenericJNI.\n\nThe GcRoot\u003c\u003e::Read\u003ckWithReadBarrier\u003e() does not update\nthe GcRoot\u003c\u003e::root_ which we need to do.\n\nTest: m\nBug: 172332525\nBug: 181249330\nChange-Id: I9886c6f23339e39588c885d7b1e2557abae8d027\n" }, { "commit": "cedec9db0a9accfdcf5eb695879e0b2caf2c34cb", "tree": "99fd71a3ef398a471507ed815c4a175805ad51f3", "parents": [ "0ccc970b3c00b172e3cff8e10da13dd6323ccd52" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 08 16:16:13 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 23 14:34:43 2021 +0000" }, "message": "Do not create HandleScope for JNI transitions.\n\nWe previously crated a HandleScope in the JNI transition\nframe to hold references passed as jobject (jclass, etc.)\nto the native function and these references were actually\nspilled twice during the transition.\n\nWe now construct the jobject as a pointer to the reference\nspilled in the reserved out vreg area in the caller\u0027s frame.\nAnd the jclass for static methods is just a pointer to the\nmethod\u0027s declaring class. This reduces the amount of work\nrequired in the JNI transition, both on entry (in compiled\nstubs) and exit (in JniMethodEnd*).\n\nSome additional work is required when GC visits references\nof a native method as we need to walk over the method\u0027s\nshorty which was unnecessary for a HandleScope.\n\nAlso fix Thread::InitStackHwm() to calculate correct stack\nsize needed by the new Thread::IsJniTransitionReference().\n\nThe results for StringToBytesBenchmark on blueline little\ncores running at fixed frequency 1420800 are approximately\narm64 (medians from 3 runs) before after\ntimeGetBytesAscii EMPTY 447.33 436.86\ntimeGetBytesIso88591 EMPTY 440.52 431.13\ntimeGetBytesUtf8 EMPTY 432.31 409.82\narm (medians from 3 runs) before after\ntimeGetBytesAscii EMPTY 500.53 490.87\ntimeGetBytesIso88591 EMPTY 496.45 495.30\ntimeGetBytesUtf8 EMPTY 488.84 472.68\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --gcstress\nTest: testrunner.py --host --jit-on-first-use\nTest: testrunner.py --host --jit-on-first-use --gcstress\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nTest: boots.\nBug: 172332525\nChange-Id: I658f9d87071587b3e89f31c65feca976a11e9cc2\n" }, { "commit": "a746c63b5e68d94f807416d504a6249c3e044c82", "tree": "6c2a609a8ced583caaf9ff290628f07db5f827d6", "parents": [ "6df4511a2cf9ffae0294c1e5136c27ff84cfd1cb" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 12 15:19:38 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Feb 16 10:52:12 2021 +0000" }, "message": "Remove unsed artLookupResolvedMethod.\n\nTest: test.py\nChange-Id: I9485105760a4c3eab1e542a99ea617f3e0b4d0b1\n" }, { "commit": "d5a8695394f8f6e8f9a66752441623dc31b97660", "tree": "591ac4892304365282a57262c91e1945ac94c6a9", "parents": [ "2fb37411e42455a00fdad90f0e612c3214e5bd1a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 19 10:35:54 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 21 14:07:57 2021 +0000" }, "message": "Reland \"Improve invokeinterface for nterp.\"\n\nThis reverts commit f1d06474baa2f7c00761db39099b89ddab71bbe4.\n\nBug: 177554973\nBug: 112676029\n\nTest: test.py\nTest: 815-invokeinterface-default\nTest: enable text-to-speech on device, no crash\n\nReason for revert: Fixed issue with recursive default methods\n\nChange-Id: I2fb9336adb6c4fc920f39aa19bfe7f0a92ce059a\n" }, { "commit": "47213e4e3773bfca0348b011831eaaa678cd0791", "tree": "822391d79730b46edc76ffd80604ba3eba56aec0", "parents": [ "98873affc25ef6bc96f8c65f828f28530b8f3fcd" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 30 15:12:00 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 08 17:00:34 2021 +0000" }, "message": "Small cleanups in artInvokeInterfaceTrampoline\n\n- No need to do a conflict table lookup when the passed method is\n already the interface method.\n- Remove obsolete test that the IMT entry is indeed a conflict entry.\n- Only call QuickArgumentVisitor::GetCallingMethod when needed.\n\nTest: test.py\nBug: 112676029\nChange-Id: I2d5da474ba3e8e4ad559fc7c13a19b04f4c2a515\n" }, { "commit": "4ebb99c2ecdd64b2364a44c4925b76f4bfa5d293", "tree": "f3dafd590ba11ef7b08207341c7dead7c866fc67", "parents": [ "755b533082bb84a282f4a76ac3f6364a7c61e6cd" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 07 15:13:54 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 07 18:19:15 2021 +0000" }, "message": "Fully honor the \"WithChecks\" in the alloc entrypoints.\n\nTest: 800-smali\nTest: 600-verifier-fails\nChange-Id: I80b2c58c5cd9a2fe63475aba15b0645e0503b358\n" }, { "commit": "4b9f86bd04a905e6ee6eaf5363b0967315136096", "tree": "f3c15cd3ccefcc684541bb4bac0c889bff35420a", "parents": [ "30864176620fbfc58f93ea58bfbacdd28f75b2c8" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 13 16:37:19 2020 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Oct 14 04:39:31 2020 +0000" }, "message": "Cyclic-includes should be avoided\n\nA file including itself is generally not considered a good idea and\ncan confuse tools such as IWYU.\n\nChange-Id: I71b07fa1503588917ab62ea383833dacd53bf8f2\nTest: Treehugger\n" }, { "commit": "8d34a182fea1b24f7b8361b55e930cb953cf3fb2", "tree": "4f5ed9d9ac417dfd69fd18f64412b2272c448e05", "parents": [ "8ecbc4e844fc3b73e6a5c5151eda914d53297180" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 16 09:46:58 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 07 08:32:52 2020 +0000" }, "message": "Change interface conflict stub to take the interface method.\n\nTo avoid doing dex cache lookup, pass the interface method instead. This\ncosts a few hundred KBs on speed compiled APKs (\u003c 0.5% code size), but\nimproves performance when hitting a conflict (as seen on dogfood data).\n\nFor nterp, we currently pass the conflict method instead of the\ninterface method. We need to handle default methods before optimizing\nit.\n\nThis removes our last use of dex cache in compiled code. A follow-up CL\nwill remove the NeedsDexCacheOfDeclaringClass from HInvokeInterface.\n\nTest: test.py\n\nChange-Id: I3cdd4543ad7d904b3e81950af46a48a48af6991a\n" }, { "commit": "8f63f1084b013a129f66cf8a7ed8ab1cae9f02aa", "tree": "6e9bbf5ad71a55f701f740e2995e0b84e9b87307", "parents": [ "7aa2bfc09541ea5d2516738de84c24cd0269fed0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 28 12:10:28 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 30 13:58:32 2020 +0000" }, "message": "Faster access to unresolved classes from compiled code.\n\nAdd two new load kinds to LoadClass, similar to kBssEntry\nbut using the access-checking entrypoint on the slow-path.\nOne is used for classes that are in the literal package and\nthe other for classes outside the literal package of the\ncompiling class. Associate new .bss entries with these load\nkinds and update them from entrypoints based on the resolved\nclass properties. If the resolved class is public, both\ntypes of entries can be updated, otherwise only the package\nlocal entry can be updated and only if the defining class\nloader of the class is the same as the caller\u0027s defining\nclass loader (which is identical for all code in an oat\nfile) because the run time access check for same package\nrequires both class loader and literal package name match.\n\nTest: Additional tests in 727-checker-unresolved-class.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_blueline-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 161898207\nChange-Id: I281e06ac2825caf81c6d7ee3128af833abd39992\n" }, { "commit": "1de6f018f6601a11ab32ca05d7ac4f4547d31e53", "tree": "1d8e5bd665b7c1d46964c7305ef87a8f8193f8b5", "parents": [ "199f2ecd9e8c915d93d365e12405f7d6a1d5d924" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 23 13:28:00 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Sep 29 08:07:34 2020 +0000" }, "message": "Another fix for the resolution trampoline and invokesuper.\n\nWe need to fully resolve the target method before updating the BSS.\n\nTest: 811\nBug: 169047229\nChange-Id: I2f3a6d60e3e44b00daea4af15c02b55e1c9098d6\n" }, { "commit": "25b9c7da44cd4652aa2ba26aa105509a6d035632", "tree": "b11d09d13e3d3c29d9782ab9b7f8521bc58747e8", "parents": [ "6d69b52f331f788cbd1f21ffd5b87cb3b39965e4" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Sep 17 17:34:34 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Sep 24 08:26:53 2020 +0000" }, "message": "Don\u0027t store copied methods in BSS.\n\nOtherwise, we can end up in a state where the method on the stack is\nunrelated to the receiver.\n\nAlso fix a comment related to GetCanonicalMethod and\nStackVisitor::ValidateFrame.\n\nTest: 810-checker-invoke-super-default\nChange-Id: I3030e4af6059f7a4a7a1f046f2aabae8ce9057da\n" }, { "commit": "1fef877c66f066f01653ea98bfefe29304198193", "tree": "65561c8b15844cabe32728b61d1e5d586976acf3", "parents": [ "a41ea2708d143b5982f1969864513b62706d11d4" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 09 13:57:17 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Sep 11 13:20:58 2020 +0000" }, "message": "Handle more cases of super calls in the compiler.\n\nAdd support for calling super methods that are not referenced within the\ncompiling dex file.\n\nTest: 808-checker-invoke-super\nTest: 809-checker-invoke-super-bss\nChange-Id: Ib103f818ac8b612a79b6b18cc8eda81131bb3149\n" }, { "commit": "b839c49e524dd59bb0e0063ddfaa9185ad1b90d8", "tree": "0b69235a0c719058df466c0d071ffb7bf20bc18e", "parents": [ "43d57558bafccff3ec3c5aecb201d7a8a57b2435" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 07 14:08:43 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 07 16:02:11 2020 +0000" }, "message": "Use the resolved method of an invoke super when updating BSS.\n\nThe compiler uses the dex index of the resolved method and not of the\noriginal invoke-super instruction.\n\nIssue found by timmurray@.\n\nTest: 809-checker-invoke-super-bss\nTest: test.py\nChange-Id: Ia422d64a91bbb0db117b7296b4a551ae2ba92fbd\n" }, { "commit": "d5bcc7288a15cdb823c1226873f72291b281cdbb", "tree": "14333f8f6f1a9800550ee2a6533d042bfefbd02c", "parents": [ "43d7c65d8ff3097122acf9fcb4c45ae6ccd71f3a" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jul 28 19:53:41 2020 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jul 28 20:29:26 2020 +0100" }, "message": "More inclusive language updates\n\nBased on:\n https://source.android.com/setup/contribute/respectful-code\n\n#inclusivefixit\n\nBug: 161336379\nBug: 161896447\nTest: m (comment updates only)\nChange-Id: I0e31cebc961f9caf0aa7b48da4b1b86998e42cb5\n" }, { "commit": "6aaa49dd4a3467e8d05aee4a1de9753e896ee96b", "tree": "593e79da914087e991ad0a6d0421962806485e04", "parents": [ "72e27b0b29fd1bdea6747f62c5bd865d26a0bdcd" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jul 28 15:53:04 2020 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jul 28 16:40:36 2020 +0000" }, "message": "Inclusive language fixes\n\nBased on:\n https://source.android.com/setup/contribute/respectful-code\n\n#inclusivefixit\n\nBug: 161336379\nBug: 161896447\nTest: art/test.py --host --64\nChange-Id: I02c96aa477c4be6af8384222f1f111cc7ae1eeac\n" }, { "commit": "346fd964a826cfb5626582452b7519c04aee2f8a", "tree": "49fb6cf2ab865391ba4027389b0049474df38c7b", "parents": [ "d3ee902ed06b635eedebc796543a67299eb6cd05" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jul 27 16:51:00 2020 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jul 28 11:13:37 2020 +0000" }, "message": "More inclusive language in the runtime\n\nTest: m\nBug: 161896447\nBug: 161850439\nBug: 161336379\nChange-Id: Iabc29fa43b4b5a403699d6bca95e9a2cb8945d77\n" }, { "commit": "86c8752f64629325026945cd4eabd1dcea224acb", "tree": "9dc2be978f9e784a3ce16fa29d46941a94ac1c94", "parents": [ "f97a859e85f703644d897f0e3e1bc54315557aaa" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 11 16:55:55 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 19 08:26:46 2020 +0000" }, "message": "Direct calls to @CriticalNative methods.\n\nEmit direct calls from compiled managed code to the native\ncode registered with the method, avoiding the JNI stub.\n\nGolem results:\nart-opt-cc x86 x86-64 arm arm64\nNativeDowncallStaticCritical +12.5% +62.5% +75.9% +41.7%\nNativeDowncallStaticCritical6 +55.6% +87.5% +72.1% +35.3%\nart-opt x86 x86-64 arm arm64\nNativeDowncallStaticCritical +28.6% +85.6% +76.4% +38.4%\nNativeDowncallStaticCritical6 +44.6% +44.6% +74.6% +32.2%\n\nTest: Covered by 178-app-image-native-method.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --debuggable --ndebuggable \\\n --optimizing --jit --jit-on-first-use\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nTest: testrunner.py --target --debuggable --ndebuggable \\\n --optimizing --jit --jit-on-first-use -t 178\nTest: aosp_cf_x86_phone-userdebug boots.\nTest: aosp_cf_x86_phone-userdebug/jitzygote boots.\nBug: 112189621\nChange-Id: I8b37da51e8fe0b7bc513bb81b127fe0416068866\n" }, { "commit": "396198b6bd6635fff52091131ca5be94cfab1d74", "tree": "5f49cc86258bbde5913420c1cb0cc009a8eb456a", "parents": [ "0d60a2b1eaa2cd2ec3481e49578b77405353efa1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jun 16 12:02:45 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 18 15:07:22 2020 +0000" }, "message": "Handle unresolved field type in compiler.\n\nMake behavior consistent with interpreter, by only resolving field types\nwhen the stored value is not null.\n\nNote that this differs from RI behavior which throws a\nNoClassDefFoundError when loading the BadField class.\n\nBug: 79751666\n\nTest: 173-missing-field-type\nChange-Id: I1e584f3129fd651bee1c9635c90bc30e13190a90\n" }, { "commit": "50df0c4c892b9afff626605fff36c9e476eb5bfd", "tree": "cd53db9dea1bbbf696a41aec59ab5195ce5397f2", "parents": [ "4c0451428cfb4d54497e425a777b7b4c5ad3bbaa" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue May 26 10:14:35 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed May 27 08:35:04 2020 +0000" }, "message": "Adjust code lookup logic in artQuickResolutionTrampoline.\n\nCheck whether the method needs to be run through the interpreter after\nfetching the code we want to run.\n\nTest: test.py\nBug: 156236098\n\nChange-Id: I95c774b1955261a812a93c4c0e3915275c5014a8\n" }, { "commit": "6217fc20d342b62ae5d2f88896984339d1bddb34", "tree": "51f1a57c9ab69fe07c00152cf2686b249e5325be", "parents": [ "b708fc1f100c7c238970ded7f1d5cb7c4da987b1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 21 11:59:11 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 21 15:13:58 2020 +0000" }, "message": "Fix calling instance methods of erroneous classes.\n\nFix the resolution trampoline to correctly handle the edge\ncase of calling instance methods on instances of erroneous\nclasses. The new test case would have previously failed the\n`CHECK_EQ(code \u003d\u003d nullptr, self-\u003eIsExceptionPending())`\nbecause the trampoline would not retrieve the code pointer\nfor the direct method of an erroneous class.\n\nTest: Added test to 174-escaping-instance-of-bad-class.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nBug: 62478025\nChange-Id: Idf54a010f362c6f581a4c4aa27c33b6dc3ce6f69\n" }, { "commit": "c4b83106ccc80074045588a6e94700f42e377fb5", "tree": "555f4ce0d9784617ad3cc346203a88588e0cdfd1", "parents": [ "4fc75697d88550df7dd2e3799ced2f01df60772b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 21 10:07:31 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 21 12:00:27 2020 +0000" }, "message": "Do not update method\u0027s entrypoint in resolution trampoline.\n\nFor correctness, the entrypoint cannot be updated until the\nclass is visibly initialized and this is already handled by\nClassLinker::EnsureInitialized(), both ensuring that the\nclass eventually becomes visibly initialized and updating\nstatic method entrypoints when it does.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nBug: 18161648\nChange-Id: Iee574b0f736e79620456f9e6ef31b50b5cfc58c8\n" }, { "commit": "5868adaefe72cc8bcdcd8325c40f712375a506d1", "tree": "a1d4328902c4e860fe69c4e4bb34052de2530df3", "parents": [ "5a62af5dc9e9bafeffcac7820e1a5b7586e58477" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 12 11:50:34 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 13 08:00:22 2020 +0000" }, "message": "Move implementations from class_root.h to -inl.h .\n\nMake it possible to include the definition of enum ClassRoot\nwithout pulling in a lot of other headers.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nChange-Id: Ic90fdd70bfe0c5428a5c9a0d7901ea7e15b03488\n" }, { "commit": "b6f4c79b06bb97651a7be1ac828d18ed18356603", "tree": "ef0bbb1281f6d4785e60f26cb420646c83eb6f6d", "parents": [ "3971661c74a9b4635d9744f72f3b053c820067c9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 04 15:37:29 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 05 08:05:24 2020 +0000" }, "message": "Clean up Constructor/Method/Field construction.\n\nSimplify the code by ignoring active transactions. Writing\nto fields of a newly allocated object does not need to be\nrecorded as aborting the transaction removes all references\nto the new object and it\u0027s unnecessary to roll back writes\nto unreachable object\u0027s fields.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nChange-Id: Ib5cd60c003d2ad3e6a246ff86d6b9288428c60ee\n" }, { "commit": "7e678d3c0f564e44638e27c411b2cc0ef8ee145a", "tree": "82789a1653ecfaabea517a56c2cba4fd59ca9203", "parents": [ "bb3560d58538d7172b058853d471a876ddd86467" ], "author": { "name": "Lokesh Gidra", "email": "lokeshgidra@google.com", "time": "Tue Apr 28 16:17:49 2020 -0700" }, "committer": { "name": "Lokesh Gidra", "email": "lokeshgidra@google.com", "time": "Thu Apr 30 20:22:39 2020 +0000" }, "message": "Assert allocator-type is known on OOME\n\nWe should always be using a known allocator-type. So instead of being\nconditional about this, assert it.\n\nThis change also simplifies updation of alloc entrypoints for CC\ncollector. Earlier we used to choose TLAB allocator on x86_64 targets\nto avoid a read-barrier in allocation path. Now that it\u0027s not there, we\ncan simplify to always use RegionTLAB allocator for CC.\n\nTest: art/test/testrunner/testrunner.py -t 004-ThreadStress\nBug: 154100060\nChange-Id: Ic692794c3dab80a67c2c4b3274adf00f879ad21b\n" }, { "commit": "d8fd59974472bcf0bb0ed86778e555bdb09d0b1e", "tree": "eee92a307fa0a0405eb5f9302ff4a748e5342544", "parents": [ "e1ee6f97e35c4798e532171213f4e2b50260e525" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Feb 19 22:25:19 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Mar 13 17:03:24 2020 +0000" }, "message": "Reland^2 \"Add consistency CHECKs around ArtMethod fields.\"\n\nThis reverts commit 5945de03b6f6b35bcf6a575b2291e29ae7a2b1ee.\n\nReason for revert: CL can land now after\nhttps://android-review.googlesource.com/c/platform/art/+/1246288\n\nBug: 146765723\nChange-Id: I237b1e171d94d47a39b21ec8b33cffa0b087b285\n" }, { "commit": "5945de03b6f6b35bcf6a575b2291e29ae7a2b1ee", "tree": "41b6e3ec202b198a2d55aedfd8181b9aa6b0555d", "parents": [ "761ee217562c6c9615af0b73df137ecadcaca303" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Feb 19 16:23:01 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Feb 19 22:06:09 2020 +0000" }, "message": "Revert \"Revert \"Revert \"Add consistency CHECKs around ArtMethod fields.\"\"\"\n\nThis reverts commit f994025d8ebc8ef63d2083436daffc7f94363c80.\n\nReason for revert: Still hitting the failure.\n\nBug: 146765723\nChange-Id: Ie07300e9d2e605cd0281fb313d017680e77e8740\n" }, { "commit": "fa458ac21af98b3bdde2c62ed86b9c192b994372", "tree": "5fa7543c9fd5edd0e950b19a70412002e10bba47", "parents": [ "99d91d18f9f73427eced2f22642520d50c3c3b83" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 12 14:08:07 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 19 16:08:34 2020 +0000" }, "message": "Allow late lookup for @CriticalNative methods.\n\nTest: Add and enable tests in 178-app-image-native-method\nTest: Add and enable tests in jni_compiler_test\nTest: Manually step through the new stub in GDB and check\n that backtrace works at various points.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 112189621\nChange-Id: If094e5062acbb99eefa88f2afb4815f93730cb82\n" }, { "commit": "f994025d8ebc8ef63d2083436daffc7f94363c80", "tree": "e91c8b1beb52459d933bef97a2bef76587dcd3f8", "parents": [ "2925311f957f50bbec2b034c98877d22f702ee76" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 06 16:23:15 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 17 15:31:37 2020 +0000" }, "message": "Revert \"Revert \"Add consistency CHECKs around ArtMethod fields.\"\"\n\nThis reverts commit eeae32ba02c7d3785a8d195e967febfaa0b1113b.\n\nBug: 146765723\n\nReason for revert: Change can now land after:\nhttps://android-review.googlesource.com/c/platform/art/+/1236946\n\nChange-Id: I082c1cd20b8af4f83a5c7bb7853badcbe2ecb38b\n" }, { "commit": "2925311f957f50bbec2b034c98877d22f702ee76", "tree": "31c6bd25134b287622c9998e016606ab2d84607b", "parents": [ "f8f51c9697b1f2a41ea750703087e98c46402f08" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 17 09:40:14 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 17 14:09:02 2020 +0000" }, "message": "Prevent entering IMT conflict trampoline with j.l.Object methods.\n\nThis ensures that only interface methods enter the trampoline.\n\nTest: 725-imt-conflict-object\nChange-Id: Id730d921f213ee0f6d927dea5df69d57be431df0\n" }, { "commit": "41b605c5ad4b06ea127ac56c6e3a4c92e8913efd", "tree": "f7b28eb11051f3faada99c11dc594cccd34a5786", "parents": [ "30b38f8d01cdb4c80092638f23c61d73e0d287f4" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 12 10:52:22 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Feb 14 12:01:58 2020 +0000" }, "message": "Remove MIPS support from runtime/.\n\nTest: aosp_taimen-userdebug boots.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 147346243\nChange-Id: If1fc8be94caa69f734438d7a1f4c715addfd8876\n" }, { "commit": "6e043bbc1d9abd1d1d3247040f6cdc82a79f47be", "tree": "02470465a0426e02d15525e171c6b3bbef3d60a6", "parents": [ "ac5ae3cf5dc4c5f87293c45a1d6999f8d1515b39" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 10 16:56:54 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 12 13:21:28 2020 +0000" }, "message": "Rewrite GenericJNI frame setup.\n\nMove the handle scope out of the managed frame, move the\nregister values to load to the bottom of the reserved area\nand pass the hidden argument to @CriticalNative methods to\nprepare for implementing late lookup.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --interp-ac\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing --interp-ac\nBug: 112189621\nChange-Id: I4672176f9627bcbebafebb3dda0d02b8108e1329\n" }, { "commit": "5c33d35bf3bd0d824e94784312fe3ddb823028d1", "tree": "a6056e5f6a9009da93355dd00fd73caf66f1f6fc", "parents": [ "b5a78564d66c903c0073e429d71241be60f51bdf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 10 12:29:13 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 10 15:48:15 2020 +0000" }, "message": "Reinstate exception check in GenericJni stubs.\n\nThe error check was erroneously removed in\n https://android-review.googlesource.com/1178884\nwhere we removed the native method lookup from the\nartQuickGenericJniTrampoline(). As the locking is now the\nonly remaining operation that can fail, update the comment\nfor the check. Regression test would be rather difficult to\nadd as we would need to force OOME during lock inflation.\n\nAlso clean up unlocking code in GenericJniMethodEnd().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nBug: 112189621\nChange-Id: I598d5f86a58c0b6171f0b2528504aba495f1b6d8\n" }, { "commit": "e91e795a77b96d58276f75b1b244a5509ef8c215", "tree": "d34f8164bb7adb8ed46e3c989877012555e194c3", "parents": [ "aa6f6f1c86705fe3cedf929bd30d1e6f51524594" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 23 10:15:56 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 31 08:20:57 2020 +0000" }, "message": "Replace instrumention id with stack pointers.\n\nReplace instrumentation ids for instrumentation frames, which are\ninherently broken (see b/72608560), and use stack addresses instead\nto properly identify which frames to pop / unwind.\n\nBug: 72608560\nBug: 148166031\n\nTest: ./art/test/testrunner/testrunner.py --trace --debuggable --ndebuggable --optimizing --interpreter --jit --debug --ndebug -j32\nTest: run-libjdwp-tests.sh\nTest: 2011-stack-walk-concurrent-instrument\nTest: ./art/test/run-test --host --dev --runtime-option -verbose:deopt,plugin --prebuild --compact-dex-level fast --jit --no-relocate --create-runner --runtime-option -Xcheck:jni 1965-get-set-local-primitive-no-tables\n art/tools/parallel_run.py -j80 /tmp/path/to/runit.sh --out failure.txt\n\nChange-Id: I71f6e55b9da608796cd3142b147f7b50bbd292ec\n" }, { "commit": "fc58809f7b932d86234130be15487017dc37b0cf", "tree": "d003dedec73d77473aff6b2039860bc76a69d898", "parents": [ "d00f129f1b7148f01efe6e9283a72d6ec8f0edd3" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jan 23 15:39:08 2020 -0800" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Jan 29 23:31:10 2020 +0000" }, "message": "Remove old JDWP implementation from ART\n\nThe old \u0027internal\u0027 JDWP implementation hasn\u0027t been used for a few\nreleases and it\u0027s a lot of code that\u0027s barely being tested and is at\nrisk of bit-rot. To simplify the runtime and remove potentially buggy\ncode this removes it.\n\nWe also needed to rewrite the DdmThreadNotification code since it\nrelied on the suspension functionality from the old debugger and was\ngenerally unsafe.\n\nTest: ./test.py --host\nTest: atest --test-mapping cts/tests/jdwp/TEST_MAPPING\nTest: atest --test-mapping cts/hostsidetests/jdwptunnel/TEST_MAPPING\nTest: Manual ddms\n\nBug: 119034743\n\nChange-Id: I775f310a009141296b730e4a6c2503506a329481\n" }, { "commit": "eeae32ba02c7d3785a8d195e967febfaa0b1113b", "tree": "d7e7a1b09460db0f9b359d582602300a25570a26", "parents": [ "066dd902930582873e7d9372ac0c8483ac700cb9" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Dec 28 00:53:50 2019 +0000" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Dec 28 02:25:26 2019 +0000" }, "message": "Revert \"Add consistency CHECKs around ArtMethod fields.\"\n\nThis reverts commit 382df393c684c6a5f3856365177da715880d7f08.\n\nReason for revert: Fails for test BuzzBeepBlinkTest on x86\n\nBug: 146765723\nChange-Id: If86c07959969a831ab5b24681e70c85d3c59c1fd\nTest: TH\n" }, { "commit": "a00b54b74bee06c006b8bebfbef85e2801de293c", "tree": "6edb2a96c1f89ae913e6b5f190b117cb290239e8", "parents": [ "e571a283b73fb4621c401811f523503b3266564b" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 03 14:36:42 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 04 12:04:36 2019 +0000" }, "message": "Helpers and refactorings to prepare for interpreter optimizations (x64)\n\n- Add data structure offsets that will be used in assembly code.\n- Be explicit about a stack overflow in a fault handler.\n- Move assembly helper code in asm_support so interpreter can use it.\n- Support putting literals in InterpreterCache.\n- Fix artHandleFillArrayDataFromCode for x64.\n\nBug: 119800099\nTest: test.py\nChange-Id: I2729f87fe5d09c04ae2e7081636f0cd89ac14c21\n" }, { "commit": "a59af8aeaad8fe7d68d8f8de63eab9cf85b6ab31", "tree": "83195c74b135731cc4555254763a8f449691c1b0", "parents": [ "5c8cc64b5f1580faf510f27527e7e22987174963" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 27 17:42:32 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 03 14:32:09 2019 +0000" }, "message": "JIT baseline: trigger optimized compilation on hotness threshold.\n\n- Add a new hotness count in the ProfilingInfo to not conflict with\ninterpreter hotness which may use it for OSR.\n- Add a baseline flag in the OatQuickMethodHeader to identify baseline\ncompiled methods.\n- Add a -Xusetieredjit flag to experiment and test.\n\nBug: 119800099\nTest: test.py with Xusetieredjit to true\n\nChange-Id: I8512853f869f1312e3edc60bf64413dee9143c52\n" }, { "commit": "08d0984bfeaff1a1bc2db2d51ecf45f2867b3bc4", "tree": "3c8c47aae746f4057d541448f873d6e287a092d6", "parents": [ "2d8b7f4ef7a305b98dd54d259e0c2b9f6aed4fd7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 02 12:38:49 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 02 15:44:20 2019 +0000" }, "message": "Allow late lookup for @FastNative methods.\n\nAvoid failing a runtime state assertion.\n\nTest: Enable tests in 178-app-image-native-method\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 112189621\nChange-Id: I3eb5c9fd239743732866e8ea0863a84bf85f7b20\n" }, { "commit": "e2a3aa988630b3c2952ac44943f03dde60454195", "tree": "acee7012af6e2b161c91e6cd8b7b4d12eb5aa927", "parents": [ "a2c4d61e482a15974e3e220bcd62a64043ee536f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 25 17:52:58 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 27 14:04:43 2019 +0000" }, "message": "Baseline JIT: update inline caches in compiled code.\n\nIn trying to remove profiling from interpreter, to speed up\ninterpreter performance.\n\nBug: 119800099\nTest: test.py --baseline\nChange-Id: Ica1fa41a889b31262d9f5691b30a31fbcec01b34\n" }, { "commit": "7dac864d7eae3d731eeacf55cfc7f71b4df6cee3", "tree": "9f27bb1c0b6f076c2dd1b721441200f9f7a78022", "parents": [ "047081a1509762879a9eb51981982af65f419bac" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 06 17:09:30 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 27 10:02:22 2019 +0000" }, "message": "Clean up JNI dlsym lookup trampoline.\n\nMake sure the GenericJniTrampoline recognizes the trampoline\nin primary boot image oat file. Rename that trampoline, add\na test and flag some issues in the code.\n\nTest: New test 178-app-image-native-method.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: testrunner.py --host -t 178-app-image-native-method\nBug: 112189621\nChange-Id: I8f8cd11998af536fd3842dd4183a25f0367655a6\n" }, { "commit": "d3d00c06a439f5204b290505a3333f780dd00bce", "tree": "7fb793aa293908b9218267acbf8e10da14e95031", "parents": [ "0f7c792f12905558836cc01f3406d6ba364cefd7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 07 15:09:07 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 07 16:46:05 2019 +0000" }, "message": "Refactor oat.h.\n\nMove OatClassType and OatMethodOffsets to oat_file.h and\nmake all dependencies on oat.h explicit instead of relying\non transitive #includes. This reduces the number of files\nthat need to be rebuilt for oat version changes.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I89c8e397a4f423043d7a036a995cc33548b25051\n" }, { "commit": "382df393c684c6a5f3856365177da715880d7f08", "tree": "ef0923a3f0b2ab354e4be077798777533fc8f9e2", "parents": [ "9f459c4ef60d771fc4eb8da1f709f479ca23a6ab" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Oct 31 11:57:15 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 04 08:24:20 2019 +0000" }, "message": "Add consistency CHECKs around ArtMethod fields.\n\nThe jitzygote approach relies on those CHECKs which are currently\nguaranteed.\n\nBug: 119800099\nTest: builds\nChange-Id: Ie5bb57bdd9b3c28a2d9cab607db2cf858e1ec131\n" }, { "commit": "5115a4dffb95637efe1df92d6f6eb70a8724c9ae", "tree": "605f5ca51dde13b1ec93fb0348d52969367b126e", "parents": [ "15ffafd026962a16ee1abdea630542dc46f67482" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Oct 17 14:56:47 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 18 12:49:45 2019 +0000" }, "message": "Clean up initialization checks for entrypoints.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing --jit\nBug: 18161648\nChange-Id: Ia3c2fdb616a5bb289e5afeccd4e6fe3eaf7ed697\n" }, { "commit": "623d4f1ba4f4218c5472e3d9e1e9bf707795878d", "tree": "44a01387b2fcdda602019cefa3bf78b6535b2caa", "parents": [ "94af5824acb28f9756fb8246f95f78c4026228e2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 30 13:45:51 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Oct 06 13:09:09 2019 +0000" }, "message": "Share boot image methods memory in JIT zygote.\n\nOnce the zygote is done compiling, copy the ArtMethods to\nshared memory that will be in-place remapped. This is\na memory optimization that enables memory sharing between\nzygote and early forked processes.\n\nCurrently relies on undefined behavior of the kernel, but will\nfollow-up with a CL that uses file sealing that will address this.\n\nSaves around 2MB of memory for processes forked before zygote is\ndone compiling - there are around a dozen of processes.\n\nBug: 119800099\nTest: boots, PostLaunchMemoryUsage\nChange-Id: Ia1bdbd1abd27f28b087d9f33aca4cd901d55082f\n" }, { "commit": "5a0b6726562948421fbbeb38d20ffd66ef688ff8", "tree": "9507db95b78ba55228fc24dc43f485a9755b9773", "parents": [ "a6c9b78a3f2c7a7f39761427dcd32e0bf6c546f3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Sep 24 15:09:40 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 25 16:02:56 2019 +0000" }, "message": "Boot image: only use the resolution stub when there is AOT code.\n\nThis avoids dirtying the page when the class becomes initialized.\n\nTest: test.py\nBug: 119800099\nChange-Id: I5cd7ae56b6637583179dbb766da251977b7ac961\n" }, { "commit": "635967b5d16e25630276c23aa47daf52ec493ea1", "tree": "4f9cba20e58ae2997b4d693d4e1e76ccd684637f", "parents": [ "8d5a215a7e879d8aa9c7d9d2791ed107ecc41f59" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Aug 07 10:15:39 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Aug 07 14:11:21 2019 +0000" }, "message": "Remove \tmessage ART creates for \"throw null\".\n\nThe new version of R8 transforms:\n throw new NullPointerException()\n\nInto:\n throw null\n\nART used to create a message for the pattern \"throw null\", which is\nsomething that now breaks ObjectsTest.requireNonNull.\n\nTest: libcore.java.util.ObjectsTest#test_requireNonNull_T\nChange-Id: I142ddc74a9c0cfc76d2479eb92078b7a7d077b27\n" }, { "commit": "8e1106587f0273116302afe06956129b5d82784a", "tree": "e1869e8da9ab9a6bfdf89a34f4e8cedd44045005", "parents": [ "5a11036542fbd2c00de1896c0ae2477f655e8ed3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 30 10:14:41 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 01 08:35:08 2019 +0000" }, "message": "Use ClassStatus::kVisiblyInitialized for allocations.\n\nAnd move the \"intialized but not visibly initialized\" check\nto ClassLinker::EnsureIntialized().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 36692143\nChange-Id: Ib5e19326b1149b2aef586b905ce89470c3a8e405\n" }, { "commit": "bf12191214c0d6215a98dfe846a51230d995dad9", "tree": "085c1059014ce66fdb7eceb6e8502d906f0eacbd", "parents": [ "78342419743cb6d0f17dc2d4c0cd99d18d9c83d6" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 04 13:49:05 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 26 11:10:26 2019 +0000" }, "message": "Implement ClassStatus::kVisiblyInitialized.\n\nPreviously all class initialization checks involved a memory\nbarrier to ensure appropriate memory visibility. We change\nthat by introducing the kVisiblyInitialized status which can\nbe checked without a memory barrier. Before we mark a class\nas visibly initialized, we run a checkpoint on all threads\nto ensure memory visibility. This is done in batches for up\nto 32 classes to reduce the overhead.\n\nAvoiding memory barriers in the compiled code reduces code\nsize and improves performance. This is also the first step\ntoward fixing a long-standing synchronization bug 18161648.\n\nPrebuilt sizes for aosp_taimen-userdebug:\n - before:\n arm/boot*.oat: 19150696\n arm64/boot*.oat: 22574336\n oat/arm64/services.odex: 21929800\n - after:\n arm/boot*.oat: 19134508 (-16KiB)\n arm64/boot*.oat: 22553664 (-20KiB)\n oat/arm64/services.odex: 21888760 (-40KiB)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots\nTest: run-gtests.sh -j4\nTest: testrunner.py --target --optimizing\nTest: Manually diff `m dump-oat-boot` output from before\n with output after this CL without codegen changes,\n with `sed` replacements for class status. Check that\n only checksums and the oatdump runtime values of\n DexCache.dexFile differ.\nBug: 18161648\nBug: 36692143\nChange-Id: Ida10439d347e680a0abf4674546923374ffaa957\n" }, { "commit": "323844002e54243e295497e7f829e46a533da621", "tree": "e6219f651332ee140042e4e0d4c975919f4fe9bf", "parents": [ "297a0533d2e3f1d49f0b73c5d1e3b09ce0418de2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jul 17 20:06:44 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 18 13:12:57 2019 +0000" }, "message": "jitzygote: Handle case of methods having the resolution stub.\n\nWe need to cache the compiled code until the class is initialized.\n\nTest: test.py\nTest: jitzygote config boots\nBug: 119800099\nChange-Id: Ib7a1efc3e101d9dabfad963621a1fe4a142e9b29\n" }, { "commit": "d5fd5c3bbb44880e440c6920ce5ed56b5383c788", "tree": "2cf8a6354e5509c5a5e0bc2937c24fe7e03a12b1", "parents": [ "1a6f9fcce199f437a5945dfe0163188b923adb28" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 02 14:46:32 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 04 08:17:30 2019 +0000" }, "message": "Make .bss stores atomic release operations.\n\nAnd rely on architecture-dependent behavior for the .bss\nentry loads.\n\nThis fixes theoretical races when one thread updates the\n.bss entry and another uses it immediately thereafter;\npreviously we did not ensure correct memory visibility.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nChange-Id: Ie7b7969eb355025b9c9205f8c936e702861943f4\n" }, { "commit": "0d4567f26701abae84b02389c379843c1dc851a8", "tree": "f665e6d5db5af79a4afa3b97cd7cdb7a2069da3f", "parents": [ "cc08c50948d8b2a93b53a327717c7b2a146ac754" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu May 30 22:45:40 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 30 18:04:44 2019 +0000" }, "message": "Stack maps: Refactor constructors.\n\nCreate dedicated static methods instead of passing flags.\nThis creates dedicated methods for the purpose and merges\nconstructor and decoding into single optimized method.\n\nThis speeds up CodeInfo by 10%, and maps startup by 0.1%.\n\nTest: ./art/test.py -b --host\nChange-Id: Ic7d43e22bca0be9fb13bc2c7544ebfdf46798cfe\n" }, { "commit": "b7c640d364d32b79cb52d04750b063667a9a0c86", "tree": "9caafc96879f83f8e5dd3cd45b9005be6e2b7deb", "parents": [ "3ffb5b1576f8af0c361284ebd8d2d54c70ede3ff" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Mar 20 15:52:13 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jun 10 18:33:25 2019 +0000" }, "message": "JVMTI Force early return\n\nAdd support for can_force_early_return jvmti capability. This allows\none to force java frames to exit early. Exited frames have all of\ntheir normal locks released.\n\nWe implement this by modifying the existing method exit events to\nallow one to modify the exit value during the callback. This is used\nto implement ForceEarlyReturn by adding internal-only events that will\nchange the return value of methods once they return (using\nkForcePopFrame) avoiding the need to modify the actual interpreter\nvery deeply. This also makes it simple to continue to use the standard\ndeoptimization functions to force the actual return.\n\nIn order to simplify book-keeping the internal event is refcounted,\nnot associated with any specific jvmtiEnv, and only settable on\nspecific threads. The internal event is added by the ForceEarlyReturn\nfunction and then removed by the MethodExit event when we update the\nreturn value.\n\nBug: 130028055\nTest: ./test.py --host\nChange-Id: Ifa44605b4e8032605f503a654ddf4bd2fc6b60bf\n" }, { "commit": "743600d5ae654817a5d81179fb480816e0cd139d", "tree": "b7d32337b7edda269d9ebc72b73551eff1b791f7", "parents": [ "bd613eced14bc56ece6beb276addab0f40337163" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 04 10:49:52 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 04 14:58:29 2019 +0000" }, "message": "ARM/ARM64: Clean up artFindNativeMethod().\n\nPass the Thread::Current() as an argument just like we\ndo for other architectures.\n\nTest: aosp_taimen-userdebug boots.\nTest: testrunner.py --target --optimizing\nChange-Id: I1dfb019da1018f493ee55ff28bd20e2db2258eb9\n" }, { "commit": "552a13415573da19eafa46e1ac00fb0eb68f2b23", "tree": "8cae5f3602d8f8e65cd3cbc349af17d785128605", "parents": [ "0dda8c84938d6bb4ce5a1707e5e109ea187fc33d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 31 10:56:47 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 16 14:44:09 2019 +0000" }, "message": "ART: Optimize StringBuilder append pattern.\n\nRecognize appending with StringBuilder and replace the\nentire expression with a runtime call that perfoms the\nappend in a more efficient manner.\n\nFor now, require the entire pattern to be in a single block\nand be very strict about the StringBuilder environment uses.\nAlso, do not accept StringBuilder/char[]/Object/float/double\narguments as they throw non-OOME exceptions and/or require a\ncall from the entrypoint back to a helper function in Java;\nthese shall be implemented later.\n\nBoot image size for aosp_taimen-userdebug:\n - before:\n arm/boot*.oat: 19653872\n arm64/boot*.oat: 23292784\n oat/arm64/services.odex: 22408664\n - after:\n arm/boot*.oat: 19432184 (-216KiB)\n arm64/boot*.oat: 22992488 (-293KiB)\n oat/arm64/services.odex: 22376776 (-31KiB)\nNote that const-string in compiled boot image methods cannot\nthrow, but for apps it can and therefore its environment can\nprevent the optimization for apps. We could implement either\na simple carve-out for const-string or generic environment\npruning to allow this pattern to be applied more often.\n\nResults for the new StringBuilderAppendBenchmark on taimen:\n timeAppendLongStrings: ~700ns -\u003e ~200ns\n timeAppendStringAndInt: ~220ns -\u003e ~140ns\n timeAppendStrings: ~200ns -\u003e 130ns\n\nBug: 19575890\nTest: 697-checker-string-append\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nTest: vogar --benchmark art/benchmark/stringbuilder-append/src/StringBuilderAppendBenchmark.java\nChange-Id: I51789bf299f5219f68ada4c077b6a1d3fe083964\n" }, { "commit": "19711d479cd4bc4c2d02edf37526cd4e2a6235f7", "tree": "53851b37097ffe2b11e42fd271eb27869956f2c0", "parents": [ "8311489bcaa94a4527d8e010df6a78d457273b53" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Apr 12 14:05:34 2019 +0100" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed May 08 10:18:50 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify instrumentation.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --interpreter\nBug: 31113334\nChange-Id: I95d9e1c9c9a0c9e460048c686c229618126b66d5\n" }, { "commit": "7989ac9ef0f50db26ce5844e7e6f9a659994c244", "tree": "a71974b358b1b06cdd9d740b83cbab41493db4b3", "parents": [ "6dfdfef85b210dc104a7cd221c6717e1a2123a13" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Apr 10 12:42:30 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 12 16:10:51 2019 +0000" }, "message": "Save the JIT compiled code when the class isn\u0027t initialized yet.\n\nWhen a class isn\u0027t initialized, we put resolution stubs to its\nstatic methods. In order to fetch the compiled code at the point of\ninitialization, save it in the profiling info.\n\nBug: 119800099\nTest: start an app, no JIT compilation of boot classpath methods\nChange-Id: I32b947318dbcb1010c94a11b51ea39d992d247e3\n" }, { "commit": "21a6ec5a5e9d392e33e4febffaa581da4d4855f2", "tree": "f15a490e54d1076765c558583dc0447ce4e60952", "parents": [ "9298875403a470320c7e6a7731522f78583ca124" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Mar 28 10:55:50 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Apr 02 16:39:07 2019 +0000" }, "message": "ART: Add VLOG to GenericJNI\n\nAdd a VLOG(third_party_jni) that details the call, that is, print\nthe Java method and the target\u0027s address.\n\nBug: 128869974\nTest: m test-art-host\nChange-Id: I335115924c0f040d939f3bb55237f7e253b7a549\n" }, { "commit": "f52d92fce224c86491d9b0fd6fca805564119426", "tree": "fbf38f272a980e965627918d9dc6bbb536395c00", "parents": [ "e660f7232a19a2c173f562b8e0987755a78ee298" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 29 12:33:02 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Apr 01 09:37:59 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify Monitor/-Pool.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 31113334\nChange-Id: I2d2ebc5ef56e73e5678e0cfcd84c479611dfcca8\n" }, { "commit": "d7e9bbf092b5a61048358fd54183526ef12284af", "tree": "620cee17c499bdb23217224b0b1332408d725a6e", "parents": [ "bb206de72135271e66e58576b1196f3e08d5b6fd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 28 13:18:57 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 29 09:50:00 2019 +0000" }, "message": "Clean up explicit conversions to ObjPtr\u003c\u003e.\n\nAdd an ObjPtr\u003c\u003e::DownCast() overload that takes a plain\npointer and remove unnecessary calls to MakeObjPtr(),\nusually preceding DownCast(). Move the MakeObjPtr() to\ncommon_art_test.h .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I2a243b6d8f3b2e773396dfc53b659c5f7d9ea44a\n" }, { "commit": "179b7c61ea6769b99f70c80a7a89cbb212423ec2", "tree": "06130898bfb2d8c3f71f4fe181277f20e1942726", "parents": [ "c8b7d445e02b752a68d824e2bc69658dfb76288a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 22 13:38:57 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 25 16:54:37 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify String allocations, fix stale refs.\n\nObjPtr\u003c\u003e-ify String allocation functions and related code\nand remove some unnecessary calls to ObjPtr\u003c\u003e::Ptr(). Fix\nstale reference uses in reference_table_test and stub_test.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I42927fb8b7240e5132188f73318b2ccb218748fd\n" }, { "commit": "4bb2af5e6163cf68ec65c5497983303302a15a09", "tree": "6cc72eae79472645b2c4833acb69f74849e43b0a", "parents": [ "975b77427413977665f3be66d02e1d164df1efbc" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 22 11:09:19 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 22 13:08:16 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify entrypoint utils.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --interpreter\nBug: 31113334\nChange-Id: Id05ce5b827b5c11a0fa796bca0b939e29ecf3c5f\n" }, { "commit": "3dacdd6343ea9a6471692914c7a9dff66d6453c7", "tree": "5e0a3b8f99e914a7fbd49822e5c8fb1bd4709f5c", "parents": [ "939798e6a565a92e597136c589428e89c28bffd5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Mar 12 15:45:47 2019 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Mar 12 09:52:59 2019 -0700" }, "message": "Revert^4 \"Remove Global deopt requirement for several jvmti events\"\n\nIt was possible for the top frame of a thread to enter the\nartQuickToInterpreterBridge during runtime shutdown. This could be\ncaused by the libjdwp agent. If this happens the caller of the frame\nwill be \u0027null\u0027, which could cause a segv if not detected correctly.\n\nThis reverts commit 939798e6a565a92e597136c589428e89c28bffd5.\n\nReason for revert: Fixed issue that could cause crash during process\n shutdown.\nTest: ./art/tools/run-libjdwp-tests.sh --mode\u003dhost\nTest: ./test.py --host\n\nChange-Id: I2aad1705c761edb4ed788cec4fc8a3068d67aee5\n" }, { "commit": "939798e6a565a92e597136c589428e89c28bffd5", "tree": "3274ff355163df18cd2d7343ce0d34214f9d09c9", "parents": [ "a55e8b5c9827cc4dc4e7f7c7ee07ef1fdafc35e0" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 12 14:26:22 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 12 14:26:42 2019 +0000" }, "message": "Revert \"Revert^2 \"Remove Global deopt requirement for several jvmti events\"\"\n\nThis reverts commit a75e5892fba6d0208f33e9ab8e19e732daf94996.\n\nReason for revert: Fails jdwp tests.\n\nChange-Id: Ic883f4f0108b07f1609c6c6a9565eae5903bfd2c\n" }, { "commit": "a75e5892fba6d0208f33e9ab8e19e732daf94996", "tree": "3daff8c3ce1608bacba7358711ccf9bd61c0bb05", "parents": [ "dd83a40a3c4fea0d917577de96742900a61ab548" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Mar 11 15:49:40 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Mar 11 21:59:44 2019 +0000" }, "message": "Revert^2 \"Remove Global deopt requirement for several jvmti events\"\n\nThis reverts commit ad344b6a14feba90a06a205760e9bc766c56cab0.\n\nJit-on-first-use would cause the runtime to skip sending FramePop\nevents for exceptions in some circumstances due to longjmp-ing over\nthe frames. This requires forcing jit off from the first instant a\nthread can get frame popped events, which is unfortunate.\n\nReason for revert: Fixed issue causing 1925 to fail on\n jit-on-first-use and redefine-stress\nTest: ./test.py --host\nTest: ./art/test/testrunner/run_build_test_target.py -j50 art-jit-on-first-use\n\nChange-Id: I6ec2a799db1041262a055be10e1af1faece6f2fc\n" }, { "commit": "ad344b6a14feba90a06a205760e9bc766c56cab0", "tree": "47801fc5b432b0baf544bb8fd522a9fd3b567a7e", "parents": [ "739383c80684eeb41d380ca5d18e1e9a1fe9fd7f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sat Mar 09 17:49:52 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sat Mar 09 21:13:15 2019 +0000" }, "message": "Revert \"Remove Global deopt requirement for several jvmti events\"\n\nThis reverts commit 334630ee9dffdd1932c1ee641d938f25362a4c1a.\n\nReason for revert: 1924-frame-pop-toggle fails on some configs.\n\nChange-Id: I5ed3846e0dfff09c67a468f319ff516e14c44e61\n" }, { "commit": "334630ee9dffdd1932c1ee641d938f25362a4c1a", "tree": "81957d634aa76967d97c89014eb69158682b0128", "parents": [ "5b76c16cca1984209e838ada4d79e370d7fda431" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Mar 04 15:08:04 2019 -0800" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Mar 08 04:07:45 2019 +0000" }, "message": "Remove Global deopt requirement for several jvmti events\n\nThe JVMTI_EVENT_SINGLE_STEP, JVMTI_EVENT_FIELD_MODIFICATION,\nJVMTI_EVENT_METHOD_EXIT, JVMTI_EVENT_SINGLE_FIELD_ACCESS, and\nJVMTI_EVENT_FRAME_POP events would all deoptimize all threads in all\ncases when enabled. This changes the behavior to instead only\ndeoptimize individual threads when possible. This should make some\ndebugger interactions faster.\n\nTest: ./test.py --host -j72\nTest: ./art/tools/run-libjdwp-tests.sh --mode\u003dhost\n\nChange-Id: I42513cb17fd1144aeb03ca11afd3e3b05e918ce2\n" }, { "commit": "62e7c097988a52add5f51640ff8cfd79229a9dbb", "tree": "bbdc0ab64f8f6dffd8fb38029b8fab7becd72144", "parents": [ "e7bd7aa01c05ed8ed7d2227f5fc7c4e8ea0861cf" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 08 09:43:01 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 08 14:15:24 2019 +0000" }, "message": "Put the deoptimized method in the trace tag.\n\nUseful when debugging with a trace.\n\nTest: m\nChange-Id: I59cb5d6810acdeb7cdd40604f8b123cb42aa8be7\n" }, { "commit": "7fbc4a59ba2e60d869313d7961662430df83b2cb", "tree": "59520285df8d2075412ddc566a0d4d96d4c7e109", "parents": [ "7cc45fd1dbcf5704e442d0443e437aa2ae3fe21b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 28 08:26:47 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 06 11:37:19 2018 -0800" }, "message": "ART: Move to using locks.h instead of mutex.h\n\nWhen only annotating lock requirements, use locks.h.\n\nBug: 119869270\nTest: mmma art\nChange-Id: I1608b03254712feff0072ebad012c3af0cc3dda4\n" }, { "commit": "c1896c9a0e15df3a1b9a3a19bcd2a933b654fe06", "tree": "b68a5f5163f8da0da87d671a225addaa2a13095f", "parents": [ "f2970cd870948a6ee1c8ecd30c9c3147d05aa0be" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 29 11:33:18 2018 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 29 11:33:18 2018 -0800" }, "message": "C++17 compatibility: make WITH_TIDY\u003d1 happy again.\n\nBug: http://b/111067277\nTest: builds\nChange-Id: I8b69ea3815e14bb6eb27f40c0dd01a85b340a355\n" }, { "commit": "076c9da66b606057109e5fb2902d28129d120b96", "tree": "fb0705380c3d1600a08c0e95ed581a967bdf0da0", "parents": [ "1ad1254db5a7d44775840339240a10deb148034b", "7e09737125ddb8c6f243ac1882d2a23da3f109c4" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 29 07:14:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Nov 29 07:14:40 2018 +0000" }, "message": "Merge \"Use ArtMethod::GetDexFile() instead of using declaring class.\"" }, { "commit": "7e09737125ddb8c6f243ac1882d2a23da3f109c4", "tree": "1105bc475dec6b923c205cde3d90ca32cd3a803b", "parents": [ "201330ccfb11989f7449486865c6f74b54f1a914" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 28 16:40:59 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 28 16:43:06 2018 +0000" }, "message": "Use ArtMethod::GetDexFile() instead of using declaring class.\n\nThis is a follow-up to\n https://android-review.googlesource.com/834082 .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 119830111\nChange-Id: I5bd55b0293ef176385a7e9d8b296be6b470cfcc4\n" }, { "commit": "e36e7f2226e4e08b7a7094f78cb80bbe0e729c2b", "tree": "0787ae19a232728121a60791f3a18094529120f1", "parents": [ "244470afafdb1c5aba17507ef793d316b9c4d038" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Nov 14 14:21:23 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Nov 27 17:31:01 2018 +0000" }, "message": "Store ImtIndex in ArtMethod.\n\nThis avoids recalculation and reduces pressure on the thread local cache.\n\nThis halves the time we spend hashing from 2% to 1% (maps on device).\n\nTest: ./art/test.py -b --host --64\nChange-Id: I2407bd9c222de4ddc6eea938908a1ac6d7abc35b\n" }, { "commit": "fd63bbf88147e19c32c21678b90d8cc450496fc3", "tree": "d78f12fbfd72bf29b16e13a7f3fabfca5f1d3f88", "parents": [ "0ee508253edcdee41a80fcbf1511234ca176233d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 29 12:55:35 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 30 10:57:42 2018 -0700" }, "message": "ART: Add string-alloc-inl.h\n\nIn an effort to reduce the (transitive) proliferation of heap-inl\nadd a specific inline header for string allocation.\n\nBug: 118385392\nTest: mmma art\nTest: m test-art-host\nChange-Id: I68d3bcf2b3615d12231010940d0a24a1dbc03826\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "0aa7a5a6a7bc350b79351f52e26c97747e927acf", "tree": "a583889668d9703d16d37586d56421bd27c62661", "parents": [ "e12575640dca5118bf96245f373acda276c22178" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Oct 10 15:58:14 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Oct 11 16:41:54 2018 -0700" }, "message": "Revert^4 \"JVMTI PopFrame support\"\n\nThis reverts commit 202b617acf477e8e8e11915f467120a0bd518e74.\nThis unreverts commit 202b617acf.\nThis unreverts commit 88a2a9d7a1.\n\nThere were several bugs with the implementation of pop-frame related\nto interactions between the jit, exception handling, class-loading,\nand deoptimization.\n\n- We were instrumenting the target thread stack in cases where it was\n unnecessary which caused the exception handler to incorrectly\n determine that a method was not deoptimizable. This caused the\n pop-frame to be ignored.\n\n- We were incorrectly sending ExceptionCatch events if an exception\n suppressed by pop-frame would have been caught in the current frame.\n\n- We were allowing pop-frame to be used on threads suspended in the\n ClassLoad or ClassPrepare events despite having surprising semantics\n in that situation (see b/117615146).\n\nNeeded to modify test 1953 slightly for inclusion in CTS. I needed to\nmake the CTS entrypoint not run the class-load tests (since the cts\nconfiguration means the classes are loaded by the verifier and not the\ninterpreter). I updated the expected.txt and check script to reflect\nthis.\n\nReason for revert: Fixed issue causing Exception events to sometimes\n eat PopFrame and other issues.\n\nTest: ./test.py --host\nTest: ./art/tools/run-libjdwp-tests.sh --mode\u003dhost\n\nBug: 73255278\nBug: 111357976\nBug: 117533193\nBug: 117615146\n\nChange-Id: I655c4fe769938cf41d7589f931d6710cf2001506\n" }, { "commit": "ce32c1045ef2765fd02cb579245eee8b21476688", "tree": "dd2b807355a8778b14f1337209b7980e8da6be9a", "parents": [ "c677cc2911258e077a65abddbbc82c47a68c4172" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 31 07:21:07 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Sep 05 10:28:49 2018 +0100" }, "message": "Rewrite mterp field access helpers\n\nSimplify the code to make further optimizations easier.\n\nTest: ./art/test.py -b -g\nTest: ./art/test.py -b -r --interpreter\nChange-Id: I54fc29a27a982bc007b600e044660ef04b6d9f29\n" }, { "commit": "bbc6e7edb5fca4a61ac53dd9bce79cb4f0bb3403", "tree": "0fbce767bc383358cf4cd65aafc74140e1850982", "parents": [ "19379b58bd433da91230e4fe6cd96e7416d16adc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 24 16:58:47 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Aug 28 11:06:07 2018 +0100" }, "message": "Use \u0027final\u0027 and \u0027override\u0027 specifiers directly in ART.\n\nRemove all uses of macros \u0027FINAL\u0027 and \u0027OVERRIDE\u0027 and replace them with\n\u0027final\u0027 and \u0027override\u0027 specifiers. Remove all definitions of these\nmacros as well, which were located in these files:\n- libartbase/base/macros.h\n- test/913-heaps/heaps.cc\n- test/ti-agent/ti_macros.h\n\nART is now using C++14; the \u0027final\u0027 and \u0027override\u0027 specifiers have\nbeen introduced in C++11.\n\nTest: mmma art\nChange-Id: I256c7758155a71a2940ef2574925a44076feeebf\n" }, { "commit": "9d479254d0dc4043a15ab26205f40439eca15493", "tree": "af8a9c9c6f2c28e723a971c9d39c9d1cebd1f814", "parents": [ "ca20fb6cc4dda392e63bdc8ec9de54d89793373e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 24 11:35:20 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Aug 03 11:43:30 2018 +0000" }, "message": "Rename type resolution entrypoints.\n\nRename the InitializeType and InitializeTypeAndVerifyAccess\nentrypoints to Resolve* to better match their semantics.\nKeep the InitializeStaticStorage name for now as the most\nappropriate name InitializeType would clash with the old\nname of the ResolveType entrypoint.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Ide55b58c490d085ab37d8536f90699f7ed571d59\n" }, { "commit": "a9f303c089aa2b2fc82d97201352945678ef54ae", "tree": "0df0eb5294a3ee72aea8ca670762c02ca9ffa8dd", "parents": [ "1bfd891d06e276d602b4a6ccf1a9f70967195218" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 20 16:43:56 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 02 17:41:21 2018 +0100" }, "message": "Rewrite Class init entrypoint to take a Class arg.\n\nFixes invalid type index being passed to the entrypoint for\nclass init check across dex files when the target type does\nnot have a TypeId in the compilation unit\u0027s DexFile.\n\nThe size of the aosp_taimen-userdebug prebuilts:\n - before:\n arm/boot*.oat: 16782748\n arm64/boot*.oat: 19764400\n oat/arm64/services.odex: 20162432\n - after:\n arm/boot*.oat: 16811692 (+28.3KiB, +0.17%)\n arm64/boot*.oat: 19801032 (+35.8KiB, +0.19%)\n oat/arm64/services.odex: 20232208 (+68.1KiB, +0.35%)\nThis increase comes from doing two runtime calls instead of\none for HLoadClass/kBssEntry that MustGenerateClinitCheck().\n\nTest: Additional test in 476-clinit-inline-static-invoke\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --jvm\nBug: 111433619\nChange-Id: I2fccd6944480ab4dac514f60d38e72c1014ae7b2\n" }, { "commit": "8cd54547cec8a4537db5682c2da8be22843b1310", "tree": "fb1158993bab2e027984cedab59b402c051a45a7", "parents": [ "91f0fdb4372d3f2bcfcd9db67afcbe7ee1901048" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jul 15 23:58:44 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 14:49:40 2018 +0100" }, "message": "Move MethodInfo to CodeInfo.\n\nThere is no need to treat it specially any more,\nbecause of the de-duplication at BitTable level.\n\nThis saves 0.6% of oat file size.\n\nTest: test-art-host-gtest\nChange-Id: Ife7927d736243879a41d6f325d49ebf6930a63f6\n" }, { "commit": "6ee06e97cef5ee92944deaeba0da4d10c4c33a2a", "tree": "77d69c85d37864b4d3ee970be4b7fd1246adee7b", "parents": [ "f5dcd31d89282b6c9324fdc960e6e7e2281c16f1" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 25 21:45:54 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 26 11:45:54 2018 +0100" }, "message": "Decode only the needed tables from CodeInfo.\n\nMost use cases need only the first two bit tables from CodeInfo.\nAdd flag to the decode method so that only those two are loaded.\nWe only touched the table header but that still made difference.\n\nThis speeds up pmd by over 10%.\n\nTest: test-art-host-gtest\nChange-Id: I7740081bf18205dd69864503b5bcec7de5e1a901\n" }, { "commit": "d93e374e273dd45f5d829399da1d4201bf46057e", "tree": "280dc72b2aec4696bbc35ad39ca8d3479107380e", "parents": [ "7f7f9d3991f3a55da8934a3b72890d4776373598" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jul 18 10:58:13 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 19 16:04:38 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify ArtMethod and mirror::Method.\n\nAnd clean up some forgotten things after old CLs.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I8af0e845c24d674d0efab21d80c29949b1cc0593\n" }, { "commit": "2c76257e4bfcd6f522b0cd3487ba7d9900043243", "tree": "ab1098cffcb3e13087e770d26fef9f4d6f06a550", "parents": [ "0b4a439f808f4602c7b97364e49c5546f5100d51" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 27 10:09:11 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jul 13 16:32:11 2018 +0100" }, "message": "Remove unused InvokeInfo from stack maps and the runtime.\n\nTest: test-art-host-gtest\nChange-Id: I5ce28973042f9241e72ceb52fc5db472ca571563\n" } ], "next": "d109e30eab8ba25f8d89be2a83d9036e2d541af2" }