)]}' { "log": [ { "commit": "3f1dcd39e134d994ac88dcc4f30ec8cabcd8decf", "tree": "365d20ad6b68ff1dbd4903764b63880324136e4d", "parents": [ "0f0a4e40667c87fbd4ae5480eddbfd701bfabfa2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 28 09:39:56 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 02 10:32:25 2019 -0800" }, "message": "ART: Move dex structs into own header\n\nSeparating out the structs from DexFile allows them to be forward-\ndeclared, which reduces the need to include the dex_file header.\n\nBug: 119869270\nTest: m\nChange-Id: I32dde5a632884bca7435cd584b4a81883de2e7b4\n" }, { "commit": "5b20b358edb0c586ae2106a82be365717da82507", "tree": "3cda8d9774087f3f6b80681f18d03c271d113fbf", "parents": [ "62f6e9055363df6b6372d86960e8d987d6c439a1" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 11 19:03:20 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 13 10:52:08 2018 -0800" }, "message": "ART: Rewrite EnsureInitialized hit case\n\nWhen an initialized class is found during EnsureInitialized, do\nnot check whether verification was attempted and fix up bits.\nInstead, ensure that all class-loading paths have that done\nwhen eventually getting here.\n\nSpecial runtime-constructed classes (primitives, arrays, proxies)\nneed code to do this work. \"Normal\" classes have the work done\nduring VerifyClass.\n\nLeave a DCHECK in as a state check. Protect state transfers with\nadditional checks.\n\nThis reduces the overhead of the interpreter which cannot elide\ninitialization checks for static accesses.\n\nBug: 115834172\nTest: m test-art-host\nChange-Id: Iacd6652583364509c37eafe81fed1198abb1b71a\n" }, { "commit": "62f6e9055363df6b6372d86960e8d987d6c439a1", "tree": "189957252780e2d61aa0d5ef874db5794805d39b", "parents": [ "81c61bf0ef90c1fd79694aab49758e16cd0dd044" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 11 18:58:50 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 13 10:52:08 2018 -0800" }, "message": "ART: Add integrity check\n\nAdd access-flags setter DCHECK code similar to the getter. For now,\ncheck that the verification-attempted flag is not removed.\n\nBug: 115834172\nTest: m test-art-host\nChange-Id: Ia1027126b2ff1a2a2e3c26f674a5f8dc8d2f0c0a\n" }, { "commit": "bc1e0fab934b7fb03545f08085b109d6508b17d0", "tree": "87048ec7cccd78f9819ba16d95539a8deae51659", "parents": [ "0bcbe9399dfc546db5c81b13979afc85da19d025" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 14 16:18:18 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 14 16:40:48 2018 -0800" }, "message": "Reduce class loader updating overhead.\n\nAvoid unnecessary read barrier for comparing class loader agianst\nnull. Avoid transaction check.\n\nDeleted the helper class to simplify the code.\n\nThe time goes from ~3.8ms to ~2.9ms on Maps.\n\nTest: test-art-host\nBug: 116052292\n\nChange-Id: I4a966a9bb39400ba58d7cf3e0b2c8ab4747d65ed\n" }, { "commit": "39d8c873645df7c956bf306693d95212d1d51906", "tree": "84bdfb98c931343b507c19a8149c84ba48a0c7b1", "parents": [ "1e152a6090c546f4a6184a5610c85cae7ac77068" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Nov 01 16:44:20 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Nov 01 19:28:17 2018 +0000" }, "message": "Optimize string comparisons in Class::FindClassMethod.\n\nThe method is relatively hot in non-quickend code.\n\nAvoid full string comparisons by comparing the unicode lengths first.\n\nTest: ./art/test.py -b -r --interpreter --host --64\nChange-Id: Ib0aa7008ca36e3916967fe082948d16823b93e02\n" }, { "commit": "e15b9b189a0898b5554002d9c86da7c17f2eb7ae", "tree": "b9d484bb6aed03f8d1435d52c6ae1cfbf3702368", "parents": [ "72d3493a6b9fde2fc3c1abb9ee6afff4451ec291" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 29 12:54:27 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 29 13:05:18 2018 -0700" }, "message": "ART: Do some include-what-you-use\n\nHelp with transitive includes. In preparation for new\nspecialized headers reducing transitivity.\n\nBug: 118385392\nTest: mmma art\nChange-Id: Ie79afda4e09191428c2b4c2f20a7e3352c01c1e9\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "a9746b90635f26ebc2340f01e6d3da7700593dbc", "tree": "4d391782c8805a22500bd8306fe8a90d16d6702f", "parents": [ "cca7cb9ffa56d8ab8fd0c5997c8bfd965d7426c1" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jun 22 10:25:40 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 25 08:34:54 2018 -0700" }, "message": "Refactor Object CAS with and without write barrier\n\nRemoves duplicated logic.\n\nTest: test-art-host\n\nChange-Id: I1f5df417c59312f224e0a448c7bd6358912bba07\n" }, { "commit": "c13fbd8596988f1daf71197008007c2eaa380585", "tree": "4c02277989abc7ac1081698269504ab329ddab8f", "parents": [ "026105570d8fcd4b3cb60c3d6b7bb7141cd8146c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 04 16:16:28 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 04 18:33:38 2018 +0100" }, "message": "Use pre-allocated Throwables from the boot image.\n\nThe pre-allocated OOMEs and NoClassDefFoundError were stored\nin the boot image but they were not used, we instead used to\nallocate and use new objects. This change adds references to\nthe image roots, so that these Throwables can be used when\nstarting the runtime using the boot image.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 77947463\nChange-Id: I2079344dee61242bf0bef5c32770c33ac8a6b7a4\n" }, { "commit": "18090d118bfb04620aeef719e2d7780c26298bf8", "tree": "040e5195f0278c9bc846d5543c0e36771ffc5b48", "parents": [ "9ddef18ae95859a985e7a0de7e22999fcbc28e07" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 01 16:53:12 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 04 17:52:35 2018 +0100" }, "message": "Refactor String resolution.\n\nUse the same pattern as type resolution and avoid some\nunnecessary read barriers in the fast path. Consolidate\nnaming between ArtField and ArtMethod.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: Iea69129085f61f04a4add09edd0eadbb7ac9ecb2\n" }, { "commit": "a5359a3bf47c4b086fe717ae35dfa6be779824bd", "tree": "08e786e30b2d1fbe886c688b5545cff9906b057f", "parents": [ "22bd3c969533986640e17e20f38975b22f30af1c", "317892b756cd2a87c01928b09e99e020c86dea10" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jun 01 09:55:34 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 01 09:55:34 2018 +0000" }, "message": "Merge \"Remove static GcRoot\u003c\u003es from Class and ClassExt.\"" }, { "commit": "ed7f95d6e9d3286c2a7691102732504ffb19c51e", "tree": "ee46343b9a11c50d669f7120865dcf6848c43fda", "parents": [ "1539a11150ca9c28fec353b38508267c41d7814b", "d32ead213f01c16c3ddd7c7a33c0f0d259e4c4dc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 31 13:47:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu May 31 13:47:48 2018 +0000" }, "message": "Merge \"Aesthetic changes in art::mirror::Object and art::mirror::Class.\"" }, { "commit": "317892b756cd2a87c01928b09e99e020c86dea10", "tree": "bb337ff8cd81c049e781afbd8c68b72ca30907fc", "parents": [ "1539a11150ca9c28fec353b38508267c41d7814b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 11:11:32 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 13:56:49 2018 +0100" }, "message": "Remove static GcRoot\u003c\u003es from Class and ClassExt.\n\nAnd clean up gc_root includes in runtime/mirror/.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ib5c42a3a892ced4440720350a63a94bcf3a1ca75\n" }, { "commit": "d32ead213f01c16c3ddd7c7a33c0f0d259e4c4dc", "tree": "bb68a6355872dadaa1e7f56a224cda40d77f0738", "parents": [ "08231f6cb3095a7dbde29299a7da5413a5f992e4" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed May 30 17:38:21 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 31 12:46:40 2018 +0100" }, "message": "Aesthetic changes in art::mirror::Object and art::mirror::Class.\n\nTest: mmma art\nChange-Id: I1c7bf2e3b0420238ee2ae249aca9b7fce492a3e6\n" }, { "commit": "acb906d7f907b79ef1e6038d7104a5569e81a1ac", "tree": "5004be84fa88b8829881efed9ebf2d578b21086f", "parents": [ "5924a4a73f1a2dcf83877062d67c297a9496b326" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 10:23:49 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 14:48:02 2018 +0100" }, "message": "Remove mirror::String::java_lang_String_.\n\nAnd simplify ClassLinker::InitWithoutImage().\nAnd finish ObjPtr\u003c\u003e-ification of annotation processing.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 31113334\nChange-Id: I882a6c2f2b2a88d6ba34e4759bac4a6caa54cafa\n" }, { "commit": "5924a4a73f1a2dcf83877062d67c297a9496b326", "tree": "3517a1809ecbdc85533e1a8c5a0a9610cdc36005", "parents": [ "2cffc5d2807096c0b7a07b89f5dda6920c6429f5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 17:40:41 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 12:50:37 2018 +0100" }, "message": "Move String::SizeOf\u003c\u003e to string.h .\n\nstring.h was already indirectly (through class.h) including\neverything needed for String::SizeOf\u003c\u003e, so move it to the\nstring.h and make those includes direct. Then we can change\nthe object-inl.h to include only string.h, reducing the\nnumber of indirectly included files.\n\nTest: m test-art-host-gtest\nTest: m testrunner.py --host --optimizing\nChange-Id: I51c462c034f205498c539abe6d888be9738d4a6e\n" }, { "commit": "b4eb1b19e1dd35d12a408358656c1421f507d231", "tree": "03ba65d206b5e6222dcca0f62a973bcbb1bf8a50", "parents": [ "ff7ff426e136aa8fd6e33d873f6259311982f6bb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 24 11:09:38 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 25 11:32:31 2018 +0100" }, "message": "Refactor ClassRoot/GetClassRoot().\n\nMove it outside the ClassLinker, into its own header file,\nand add retrieval based on a mirror class template argument.\nKeep the SetClassRoot() as a private member of ClassLinker.\n\nMake the new GetClassRoot()s return ObjPtr\u003c\u003e.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Icbc6b62b41f6ffd65b437297a21eadbb0454e2b7\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "b2ec9f5c128673c43f776cbe12c8eeb0a6884ebb", "tree": "724022162a4f3de021cebab32ee5ac67ec860f32", "parents": [ "f13343eb8b2738e2812fd7bd9d5592f529e93c21" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:20:31 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:51:15 2018 -0800" }, "message": "Remove duplication, split tests\n\nThe code move to libdexfile/dex/descriptors_names.cc apparently did not\nremove the original code from runtime/utils.cc. Fix that duplication\nand all the header mentions needed. Also, split the test files to go\nalong with the new locations for the code to be tested.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n flash \u0026 boot marlin\n\nChange-Id: Ie734672c4bca2c647d8016291f910b5608674545\n" }, { "commit": "7287c4d75e38e7a01c7ea3fdebb47d9cfe128a56", "tree": "2b43d1b334e05e1c5719fee3f2a16bebaff059d9", "parents": [ "1efa7cb8c415f4df8a248242cd773a1fc671878e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 15 10:41:07 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 15 15:36:21 2018 +0000" }, "message": "Add Class.getPrimitiveClass().\n\nImplement the native part in ART and remove the native parts\nof the previously needed workaround for java.lang.Void.TYPE.\n\nCompanion libcore/ change:\n https://android-review.googlesource.com/619326\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nBug: 73346078\nChange-Id: Icfb201a1f08d8ff2a65c58f7c0ec25aa2296db29\n" }, { "commit": "305c38b395eddff7ca001fa7bdb621397033184d", "tree": "809965b36e35d8b5a06229a4904c7943525ea54c", "parents": [ "3bffbe8a8288cf01b7248fffdd320bf688529bcb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 14 11:50:07 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 14 16:16:05 2018 +0000" }, "message": "Disable bitstring type check runtime hooks.\n\nIntroduce a build flag for the bitstring type check, put\nruntime hooks behind the flag and set the flag to false.\n\nAlso add bitstring initialization for proxy classes, a test\nand a benchmark for the type checks.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --interpreter\nTest: Repeat with kBitstringSubtypeCheckEnabled \u003d true.\nBug: 73299705\nChange-Id: Ibcd88a828c7addc0473d8c428818734f80226b19\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "2c64a837e62c2839521c89060b5bb0dcb237ddda", "tree": "65475ed2e313ff17354e741bac7e9c85739b8b95", "parents": [ "6cd0005698181e4cef2247b632d396e605d58fa3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jan 04 11:31:56 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 05 11:27:50 2018 +0000" }, "message": "Change ClassStatus to fit into 4 bits.\n\nIn preparation for extending the type check bit string from\n24 to 28 bits, rewrite ClassStatus to fit into 4 bits. Also\nperform a proper cleanup of the ClassStatus, i.e. change it\nto an enum class, remove the \"Status\" word from enumerator\nnames, replace \"Max\" with \"Last\" in line with other\nenumerations and remove aliases from mirror::Class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 64692057\nBug: 65318848\nChange-Id: Iec1610ba5dac2c527b36c12819f132e1a77f2d45\n" }, { "commit": "4557b3858a66aa20e42bce937e1f0620aad880a2", "tree": "8f34d8f014b11f17c6351bb955fcc74c940b8d16", "parents": [ "90f20973356900e340998e8e2b34230e5c4c8fb0" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 11:47:54 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 12:45:40 2018 +0000" }, "message": "ART: Rename Atomic::CompareExchange methods\n\nRenames Atomic::CompareExchange methods to Atomic::CompareAndSet\nequivalents. These methods return a boolean and do not get the witness\nvalue. This makes space for Atomic::CompareAndExchange methods in a\nlater commit that will return a boolean and get the witness value.\n\nThis is pre-work for VarHandle accessors which require both forms.\n\nBug: 65872996\nTest: art/test.py --host -j32\nChange-Id: I9c691250e5556cbfde7811381b06d2920247f1a1\n" }, { "commit": "666ee3d7c6039c80e75287e311895bd6a9b01e9f", "tree": "5e65f39ff7cc83af4be3b691c247d7348052f854", "parents": [ "890111968fbd3f5ae528d97e42984c12a3dd27bd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 18:37:36 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 12 13:48:02 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveType().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nAlso refactor the code to avoid doing the DexCache lookup\ntwice and avoid unnecessary read barriers in the initial\nDexCache lookup (also for Lookup/ResolveField()).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Idea9aa42b6a5bade947e93e330b1abdb9d11b2da\n" }, { "commit": "170331f0e44a0e07fcfe0b5932517e0500f5cd1f", "tree": "4bb837aa3b6e19c898df23894beb61957885e985", "parents": [ "39b378ca3b4b6dc6da1651b84ee4289cd9bff0f8" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 18:41:03 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 18:41:03 2017 -0800" }, "message": "ART: Remove base/logging from heap-inl.h\n\nHide the single uncommon VLOG and remove the include. Fix up\ntransitive includes.\n\nTest: m\nChange-Id: I917df597cb62c57040c1fb0e0079df4d95e5a658\n" }, { "commit": "b0a6aeee250945b1d156ebab94053380f2e5a3c5", "tree": "7ddb52bb20997b8f1c81be3df2250949a088e697", "parents": [ "0db16e00e3927445585a588499731c58c1ae1bef" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 27 10:34:04 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Nov 10 08:30:36 2017 +0000" }, "message": "Record @{Fast,Critical}Native in method\u0027s access flags.\n\nRepurpose the old kAccFastNative flag (which wasn\u0027t actually\nused for some time) and define a new kAccCriticalNative flag\nto record the native method\u0027s annotation-based kind. This\navoids repeated determination of the kind from GenericJNI.\nAnd making two transitions to runnable and back (using the\nScopedObjectAccess) from GenericJniMethodEnd() for normal\nnative methods just to determine that we need to transition\nto runnable was really weird.\n\nSince the IsFastNative() function now records the presence\nof the @FastNative annotation, synchronized @FastNative\nmethod calls now avoid thread state transitions.\n\nWhen initializing the Runtime without a boot image, the\nWellKnowClasses may not yet be initialized, so relax the\nDCheckNativeAnnotation() to take that into account.\n\nAlso revert\n https://android-review.googlesource.com/509715\nas the annotation checks are now much faster.\n\nBug: 65574695\nBug: 35644369\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: I2fc5ba192b9ce710a0e9202977b4f9543e387efe\n" }, { "commit": "86083f7cd118f3d6c757191e83b4e4abaabdc5d7", "tree": "8e5b81ae0d09d41bfd90284a1b6b16b2332435e5", "parents": [ "495e783c9180c3fc033ce459ee0a783e633f7754" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Oct 27 10:59:04 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Nov 07 14:47:51 2017 -0800" }, "message": "runtime: Bitstring implementation for subtype checking (4/4).\n\nIntegrate the previous CLs into ART Runtime. Subsequent CLs to add\noptimizing compiler support.\n\nUse spare 24-bits from \"Class#status_\" field to\nimplement faster subtype checking in the runtime. Does not incur any extra memory overhead,\nand (when in compiled code) this is always as fast or faster than the original check.\n\nThe new subtype checking is O(1) of the form:\n\n src \u003c: target :\u003d\n (*src).status \u003e\u003e #imm_target_mask \u003d\u003d #imm_target_shifted\n\nBased on the original prototype CL by Zhengkai Wu:\nhttps://android-review.googlesource.com/#/c/platform/art/+/440996/\n\nTest: art/test.py -b -j32 --host\nBug: 64692057\nChange-Id: Iec3c54af529055a7f6147eebe5611d9ecd46942b\n" }, { "commit": "ee5303f76ef167714a6a04d3abc502584ac5e103", "tree": "7f414df9d48dda94872421de4192daf6ec731681", "parents": [ "c101222c854a0c476f5b6ae64e20adbd38126a3c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 31 15:34:42 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 05 10:46:07 2017 -0700" }, "message": "ART: Move Class::Status to ClassStatus\n\nMove the enum to its own file to lower include burden on others.\nThis is an intentionally small and localized change. Users will\nbe cleaned up in a follow-up.\n\nBug: 63467744\nBug: 65318848\nTest: m test-art-host\nChange-Id: If3bfe6953973e24623e78a2a8dcc69b50117aa3c\n" }, { "commit": "afb664701734c6edbea07431382ee33f1677d42b", "tree": "bd67954a08efb59e7bee75dfe46d1230abe4443b", "parents": [ "7f14c2ec37c70010d99cab6806d85018df56c555" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 01 09:54:49 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 02 14:58:10 2017 -0700" }, "message": "Fix verifier checks on interface methods.\n\nWe were disallowing interfaces in the IsInheritedMethod even though\nthe function can be called with them. This could cause some failing\nDCHECKS if the verifier cannot find methods in some situations.\n\nWe also fixed a small issue in the verifier where we allowed\nnon-public java.lang.Object methods to be considered valid for\ninterface dispatch.\n\nTest: ./test.py --host -j50\nTest: Compile an app with bad bytecodes (See bug)\nBug: 64158483\nBug: 64274113\nChange-Id: Ia79f25be0001efc4069a411a0b34476bd0871803\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "ba118827465d12177f3996e50133960087b1c916", "tree": "f39728cdafc7810004d51c0bef2728b98993daa9", "parents": [ "64a102dde8c5daad83b991710decb418ce43aac5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 12 15:41:56 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 20 13:35:06 2017 +0100" }, "message": "ART: Change method lookup to be more consistent to JLS and the RI.\n\nThe method lookup for different invoke types was previously\nwidely different and didn\u0027t work well with the dex cache\nmethod array where we have only a single slot for each\nMethodId. The new behavior is to perform the same lookup for\nall cases, distinguishing only between interface and\nnon-interface referencing class, and to further align the\nbehavior with the JLS and the RI. Where the JLS conflicts\nwith the RI, we follow the JLS semantics.\n\nThe new lookup for class methods first searches the methods\ndeclared in the superclass chain (ignoring \"copied\" methods)\nand only then looks in the \"copied\" methods. If the search\nin the superclass chain finds a method that has not been\ninherited (i.e. either a private method or a package-access\nmethod where one of the classes in the chain does not belong\nto the same package, see JLS 8.4.8), we still search the\n\"copied\" methods as there may actually be a method inherited\nfrom an interface. This follows the JLS semantics where\ninherited methods are included in the search (JLS 15.12.2.1)\nbut conflicts with the RI where the private or\npackage-access method takes precedence over methods\ninherited from interfaces.\n\nNote that this search can find an accessible method that is\nnot inherited by the qualifying type, either for a package\naccess method when the referrer is in the same package but\nthe qualifying type is in another package, or for a private\nmethod where the referrer is in the same class but the\nqualifying type is actually a subclass. For the moment we\nallow such calls and we shall consider whether to throw\nan IncompatibleClassChangeError in this situation in future\nto comply with JLS 15.12.4.3.\n\nThe new lookup for interface methods searches the interface\nclass, then all the superinterfaces and then the\njava.lang.Object class, see implicitly declared methods in\ninterfaces, JLS 9.2. The search for the maximally-specific\nnon-abstract superinterface method is not yet implemented,\nbut the difference should be difficult to observe as the\nusual subsequent call to FindVirtualMethodForInterface()\nshould yield the same result for any matching method.\n\nThe new test 162-method-idx-clash exposes several cases\nwhere we previously completely messed up due to the effects\nof the DexCache, or where we were out of line with the RI.\nIt also tests a case where the JLS and the RI disagree and\nwe follow the JLS.\n\nTest: art/test/run-test --host --jvm 162-method-resolution\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --interp-ac\nTest: Nexus 6P boots.\nTest: testrunner.py --target\nBug: 62855082\nBug: 30627598\nChange-Id: If450c8cff2751369011d649c25d28a482a2c61a3\n" }, { "commit": "6d3e76884710e639e79a46d505395bc83ad5ec7d", "tree": "3b51520701c740ccb69ce38483c47c25105dd40b", "parents": [ "00cca3a275562d110a8b35094b9b12fac37f67ab" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Tue Jul 11 10:31:29 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Tue Jul 11 17:05:12 2017 -0700" }, "message": "Abstract SetField functions with Transaction check\n\nAbstracted several functions which set objects\u0027 fields with a check to\ntest whether transaction is active to determine one template argument,\nthis make more object modification operations support transaction.\n\nReplaced some function calls with transaction checking version to\nsupport clinit for app image to run under transaction.\n\nTests shows not breaking anything, testcase cover this situation will be\nadded shortly.\n\nTest: make test-art-host -j64\nChange-Id: Ic15a4428a7c7cce6832651e1894eb760354de009\n" }, { "commit": "2722f380d6430be83a1c899a94999690a8ab26df", "tree": "1ce8a54c47aefbb35a4cb18c3d3bbedcbfac9734", "parents": [ "d632b8b8a031cda163c6f9a6b4e33a192f123a0b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 18:03:25 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jun 09 08:45:13 2017 -0700" }, "message": "ART: Fix old warnings\n\nFix Wundefined-var-template warnings.\n\nPartially reverts commit df53be273509dd43725870fb20a2c7d71f7fbfd3.\n\nBug: 28149048\nBug: 29823425\nTest: m\nTest: m test-art-host\nChange-Id: Ib077312558f9e2f784859861c000fbac8375b3f5\n" }, { "commit": "c6ea7d00ad069a2736f603daa3d8eaa9a1f8ea11", "tree": "a6d3332a8592fb806841314d55b206b573d37d86", "parents": [ "d68677c5fde1ace16ea58d65733776c954e7acb4" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Feb 01 16:46:28 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 21 08:40:33 2017 -0700" }, "message": "ART: Clean up art_method.h\n\nClean up the header. Fix up other headers including the -inl file,\nin an effort to prune the include graph. Fix broken transitive\nincludes by making includes explicit. Introduce new -inl files\nfor method handles and reference visiting.\n\nTest: source build/envsetup.sh \u0026\u0026 lunch aosp_angler-userdebug \u0026\u0026 mmma art\nTest: source build/envsetup.sh \u0026\u0026 lunch aosp_mips64-userdebug \u0026\u0026 mmma art\nChange-Id: I8f60f1160c2a702fdf3598149dae38f6fa6bc851\n" }, { "commit": "8f2b925473cfdc7650cef407102957befe0c6bb5", "tree": "4af3395adaf03cb4a60cd40e7b3ee4196645eb9e", "parents": [ "de9b8d63ef548d56de9c9d4657a7b916050d81ad", "6b2dc3156a2140a5bfd9cbbf5d7dad332ab5f5bd" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Fri Mar 17 09:05:55 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Mar 17 09:05:56 2017 +0000" }, "message": "Merge \"ART: Get rid of most of java.lang.DexCache.\"" }, { "commit": "4f2e957b07c8b6e48bbd7593bb64f3c5214fa489", "tree": "efcfcaaa1efdc567449c406e7107da2e94c127c2", "parents": [ "ed883a11b8cd7f3712bd30fca1e2b0fb641bff63" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Mar 16 13:13:31 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Mar 16 14:23:46 2017 -0700" }, "message": "Ensure the GC visits Obsolete Methods\n\nWe were previously not visiting obsolete methods during GCs. This\ncould lead to the use of stale pointers.\n\nBug: 36335999\nTest: ./test/testrunner/testrunner.py --host --interp-ac --gcstress -j40\n\nChange-Id: I2b5c7c75b29f9037204a860501fcdb78104b5e7a\n" }, { "commit": "6b2dc3156a2140a5bfd9cbbf5d7dad332ab5f5bd", "tree": "a335cae93c0eabae63e39b8bc13ef3e15f4f7e50", "parents": [ "f83f3f6ecb1153d96cc8007e8a0d1e35af4d3f38" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Mar 14 13:26:12 2017 +0000" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Thu Mar 16 17:56:04 2017 +0000" }, "message": "ART: Get rid of most of java.lang.DexCache.\n\nAll remaining functionality is moved over to native. The DexCache\nobject itself is allocated in the Java heap, even though there\u0027s no\nlonger much of a reason to do so. It can be changed in a future change\nif needed.\n\nThis also renames mirror::Class:GetInterfaces to GetProxyInterfaces\nsince it\u0027s supposed to be called only for proxies.\n\nTest: test-art-host, cts -m CtsLibcoreTestCases\n\nChange-Id: Ie261f22a9f80c929f01d2b456f170c7a464ba21c\n" }, { "commit": "8d6768d47b66a688d35399d524ad5a5450e9d9d4", "tree": "0b8733baef378d9e060c8e74319a3846489590b2", "parents": [ "fbe1516b91f2117bb9c7282aaea5537572f62dd7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 10:13:21 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 13:55:13 2017 +0000" }, "message": "Revert^6 \"Hash-based dex cache type array.\"\n\nFixed ImageWriter to write class table also if it contains\nonly boot class loader classes. Added a regression test and\nadded extra checks for debug-build to verify that dex cache\ntypes from app image are also in the class table. Removed\nsome unnecessary debug output.\n\nTest: 158-app-image-class-table\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 0b66d6174bf1f6023f9d36dda8538490b79c2e9f.\n\nChange-Id: I6a747904940c6ebc297f4946feef99dc0adf930c\n" }, { "commit": "0b66d6174bf1f6023f9d36dda8538490b79c2e9f", "tree": "1cc4d2ae868745a65fd0489a6fb2f5f2fc9e880f", "parents": [ "6374c58f2ea403b3a05fb27376110fe4d0fc8e3f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 14:50:04 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 16:08:01 2017 +0000" }, "message": "Revert^5 \"Hash-based dex cache type array.\"\n\nFor app images, ImageWriter does not add boot image\nclasses to the app image class table even though it\nkeeps them in the dex caches. The reason for that is\nunknown, the code looks OK.\n\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nAlso reverts \"Improve debugging output for a crash.\"\n\nThis reverts commits\n bfb80d25eaeb7a604d5dd25a370e3869e96a33ab,\n 8dd56fcb3196f466ecaffd445397cb11ef85f89f.\n\nTest: testrunner.py --host\nChange-Id: Ic8db128207c07588c7f11563208ae1e85c8b0e84\n" }, { "commit": "bfb80d25eaeb7a604d5dd25a370e3869e96a33ab", "tree": "96068dd9b9b3bc2e1bcc25d38bbd2420d5b0f1bb", "parents": [ "7a49d93ee265b978ab29cae659e46d41da78459a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 14 14:08:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 20 14:13:14 2017 +0000" }, "message": "Revert^4 \"Hash-based dex cache type array.\"\n\nAdded extra output to the abort message to collect more data\nwhen we hit the crash. Added extra check when loading an app\nimage to verify that the class table isn\u0027t already broken.\n\nTest: testrunner.py --host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5.\n\nChange-Id: I9bb442a184c236dcb75b3e42a095f39cd6bee59d\n" }, { "commit": "fa4333dcb481e564f54726b4e6f8153612df835e", "tree": "ae597c7587dc214434a180962c4373d3748f51ab", "parents": [ "2d98ba68f13dc219c088a12f369c5778bf398f14" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:10:34 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:44:48 2017 -0800" }, "message": "ART: Add operator \u003d\u003d and !\u003d with nullptr to Handle\n\nGet it in line with ObjPtr and prettify our code.\n\nTest: m\nChange-Id: I1322e2a9bc7a85d7f2441034a19bf4d807b81a0e\n" }, { "commit": "5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5", "tree": "be0e9fdeb90bcbad76b17b3aae4e746d977d80ee", "parents": [ "518f373324f355f8e58440dfbc3f5a1f2244bde7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 18:32:04 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 19:34:54 2017 -0800" }, "message": "Revert^3 \"Hash-based dex cache type array.\"\n\nAssert failing for \"earchbox:search\":\nF zygote64: class_linker.cc:4612] Check failed: handle_scope_iface.Get() !\u003d nullptr\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 85c0f2ac03417f5125bc2ff1dab8109859c67d5c.\n\nChange-Id: I39846c20295af5875b0f945be7035c73ded23135\n" }, { "commit": "85c0f2ac03417f5125bc2ff1dab8109859c67d5c", "tree": "844952d237e35faa5c5a2357ab037366c8397115", "parents": [ "8d4b1189639f0d8982bde681ccbdd7c03fe6ddbf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 02 16:42:38 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Feb 10 11:23:11 2017 +0000" }, "message": "Revert^2 \"Hash-based dex cache type array.\"\n\nThe reason for the revert was fixed by\n https://android-review.googlesource.com/332666 .\nWe now enable clearing dex cache types in test 155 from that\nCL. Also avoid an unnecessary store in LookupResolvedTypes()\nand prevent verifier from messing up the dex cache types.\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit d16363a93053de0f32252c7897d839a46aff14ae.\n\nChange-Id: Ie8603cfa772e78e648d005b0b6eae59062ae729d\n" }, { "commit": "90b936ddda63139ff46a6755c3b83ad6e4ab4ac5", "tree": "c7ce2c3004eecc16ab41ed7cde105c3019638d4b", "parents": [ "b78a8af993e877d74c5938f65f95feaf2fa01321" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jan 31 08:58:55 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Feb 03 10:03:52 2017 -0800" }, "message": "ART: Refactor verify_object.h\n\nMove the actual VerifyObject check into a new cc file, as we\ncommonly don\u0027t enable the check at all. This allows to cut the\n-inl include from almost all current users.\n\nThis also exposes missing -inl includes. Also fix up some of our old\nmess where .h defined functions require -inl.h defined functions.\n\nTest: m\n\nChange-Id: I3dd821bbe2015564a29bf1ed9be00f7a7276ad61\n" }, { "commit": "d16363a93053de0f32252c7897d839a46aff14ae", "tree": "8823c6dd4641eae333aa7001203460757a515010", "parents": [ "ac240396125911b52437a460a400c8b38be43a96" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 01 14:09:13 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 01 15:27:37 2017 +0000" }, "message": "Revert \"Hash-based dex cache type array.\"\n\nReverting to work around some programs crashing with\n Check failed: handle_scope_iface.Get() !\u003d nullptr.\nthough the reason for the failure not yet understood.\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\nBug: 30419309\n\nThis reverts commit ec7862283dd49f5a58d0ac45960ce27c2f7671b8.\n\nChange-Id: Ifded663633082f1e59e5b6ff2e026dc559bd6b82\n" }, { "commit": "ec7862283dd49f5a58d0ac45960ce27c2f7671b8", "tree": "26d6dcc1d5ed4f0ba5ac15f17ef7377215684bf6", "parents": [ "c01d49091f4588777db5bf45345f388058caa99f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 20 16:24:13 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 30 10:21:16 2017 +0000" }, "message": "Hash-based dex cache type array.\n\nTest: m test-art-host (Interpreter, Optimizing, JIT)\nTest: m test-art-target on Nexus 6P (Interpreter, Optimizing, JIT)\nTest: Nexus 6P boots\nTest: m valgrind-test-art-host\nBug: 30627598\nBug: 34659969\nBug: 30419309\nChange-Id: Ic00eda89e58088a3573fc9ec0ad04c0e69e161d1\n" }, { "commit": "72ab684871f870aead76b23cb67deb046107b380", "tree": "d4bb40cab65df449246b35ae582234238676b7bb", "parents": [ "e36c51aee58e61e9fc89851b767379c587f050e3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 20 19:32:50 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jan 24 12:05:02 2017 +0000" }, "message": "Add class status for resolved erroneous classes.\n\nSplit the old ambiguous status mirror::Class::kStatusError\ninto kStatusErrorUnresolved and kStatusErrorResolved. Once\na class has been resolved, IsResolved() shall return true\neven if the class later becomes erroneous. Allow returning\nerroneous class from ClassLinker::EnsureResolved() if it has\nbeen previously resolved. This allows consistent behavior\nfor retrieving classes, immune to multi-threaded races and\nmulti-dex weirdness. It also allows JVMTI to properly report\n\"prepared\" (i.e. resolved) classes that are also erroneous.\n\nThe new behavior is consistent with the RI.\n\nAdd regression tests to 008-exceptions for inconsistent\nbehavior for multi-dex retrieval of erroneous resolved class\n(wrapping or not wrapping the old exception based on which\ndex file is used for lookup) and for a CHECK(IsResolved())\ncrash in ClassLinker::LoadSuperAndInterfaces() (without any\ntests for similar checks that could have previously failed\nonly due to extremely unlikely race conditions; these should\nnow also be fixed).\n\nInconsistency still remains for class verification as shown\nby the new exceptionsForSuperClassInitFailure() test in\n008-exceptions, where interpreter and Optimizing still\ncause different exceptions to be thrown.\n\nNote: This is partially changing behavior implemented for\nbug 28787733. Since we allow the class loader to retrieve an\nerroneous resolved class, the ExceptionInInitializerError is\nnot thrown at all from VMClassLoader_findLoadedClass(), so\nthere is nothing to wrap in ClassNotFoundException.\n\nTest: m test-art-host\nBug: 30627598\nBug: 28787733\nChange-Id: I86cdca00f35a0d6221d2559e3026ac0428a3613c\n" }, { "commit": "913e6e6f36f6feb1d11e7c095dbbc9cea7ab01be", "tree": "d1e74a07e3b801ff81eaefe5569a1262cc922976", "parents": [ "4c1667fd521f6e11367fd262f9bd6474f48fb3e7", "f9bf250cc642c4e3e0c6904550fe922d3359a737" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Dec 16 09:32:22 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 16 09:32:23 2016 +0000" }, "message": "Merge \"Remove dex cache string from mirror::Class.\"" }, { "commit": "46ee31b67d7ee1bd085fbc240502053caa3cf8fa", "tree": "83e870f293cd60d533207e389d7b094acd87b31f", "parents": [ "9538f9e2a5d03f1b1bc07ebfbd93b61dcf8ad604" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 14 10:11:49 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 15 09:50:39 2016 -0800" }, "message": "ART: Move to libbase StringPrintf\n\nRemove ART\u0027s StringPrintf implementation. Fix up clients. Add\nmissing includes where necessary.\n\nTest: m test-art-host\nChange-Id: I564038d5868595ac3bb88d641af1000cea940e5a\n" }, { "commit": "f9bf250cc642c4e3e0c6904550fe922d3359a737", "tree": "953351c7e13b45e9246625ad81bce708788d96f9", "parents": [ "b73e659be3fb6474ff3a993cd25ecbfa1cc4715c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 14 14:59:04 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Dec 15 14:52:22 2016 +0000" }, "message": "Remove dex cache string from mirror::Class.\n\nThe compiled code does not need it anymore.\n\nTest: test-art-host test-art-target\nChange-Id: I71c08ce12d450ab2b2cd018330d42a8b8c9e3da2\n" }, { "commit": "19a4d374738da4dc668a078f92dbe887ff9f00d9", "tree": "a210638e93d80cf0a297de07f4c9cdc60784ce50", "parents": [ "aea9ffece7eb32f3884a4ad0553e1df4d90fd9e4" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Dec 08 14:41:46 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 09 13:30:00 2016 +0000" }, "message": "Clean up Class::GetDirectInterface().\n\nOnce the `klass` has been resolved, this function should not\nneed to resolve interface types anymore. Drop the type\nresolution from this function and pass the Class as ObjPtr\u003c\u003e\ninstead of Handle\u003c\u003e. Make callers that expect non-null\nresult DCHECK() that assumption. For the callers that may\nactually need to resolve these interface classes, introduce\na new function ResolveDirectInterface().\n\nAlso improve ObjPtr\u003c\u003e constructors and assignment operator\nto improve overload resolution. For example, if we have\nfoo(ObjPtr\u003cT1\u003e) and foo(ObjPtr\u003cT2\u003e), calling foo(.) with\na T1* would have previously been ambiguous even if T1 is\nnot a base of T2.\n\nTest: m test-art-host\nChange-Id: Iff44a7285f68f0af4507fc9ba37343865422fe84\n" }, { "commit": "a5b09a67034e57a6e10231dd4bd92f4cb50b824c", "tree": "304be738f4fa528b7ad2676103eecc84c79eaeeb", "parents": [ "dac7ad17c78387d15d7aefae0f852dddf5f37e34" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Nov 17 15:21:22 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 21 10:57:00 2016 -0800" }, "message": "ART: Add dex::TypeIndex\n\nAdd abstraction for uint16_t type index.\n\nTest: m test-art-host\nChange-Id: I47708741c7c579cbbe59ab723c1e31c5fe71f83a\n" }, { "commit": "0273ad1f702d7094b90ebb62c21c50b6a9568ab0", "tree": "759ae8b9f5bad5ee62e9e04d7dd5b35d307f627f", "parents": [ "21b880ce80f63ddeeab7afaffe0de6934e602551" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Nov 02 11:19:31 2016 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Nov 03 09:17:50 2016 -0700" }, "message": "Remove lock from ClassExt installation procedure.\n\nWe were using a lock on the class to ensure that we avoid races in\nsetting the ext_data_ field of a class object. We replace this with a\nCAS of the field in order to prevent deadlocks.\n\nTest: mma test-art-host\nChange-Id: Ie436ff9526f2c3b38a9af49c5606a7cee6d718f1\n" }, { "commit": "d62515891b15e73bc8eebb55cc09cb4dec4fcf21", "tree": "20c485231c93fa83384312e428202d8140dfa09d", "parents": [ "77a0e4541a29c26dba21ed8c1ed1c29ef8d0ce4c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Oct 31 11:12:30 2016 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Nov 02 12:55:10 2016 -0700" }, "message": "Add ClassExt mirror.\n\nWe add the ClassExt type to hold values in Class that are not always\nneeded without making the Class type larger. For the initial change we\nmove the verifyError field into this type. It is expected to grow as\ntime goes on.\n\nTest: mma test-art-host\n\nChange-Id: I1d97df2e1267203841ad47b2effcb66dd76ac12a\n" }, { "commit": "709b070044354d9f47641f273edacaeeb0240ab7", "tree": "3a8ac051d7c35076303984d0d892cdd396b60427", "parents": [ "1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 13 09:12:37 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Oct 18 14:10:04 2016 -0700" }, "message": "Remove mirror:: and ArtMethod deps in utils.{h,cc}\n\nThe latest chapter in the ongoing saga of attempting to dump a DEX\nfile without having to start a whole runtime instance. This episode\nfinds us removing references to ArtMethod/ArtField/mirror.\n\nOne aspect of this change that I would like to call out specfically\nis that the utils versions of the \"Pretty*\" functions all were written\nto accept nullptr as an argument. I have split these functions up as\nfollows:\n1) an instance method, such as PrettyClass that obviously requires\nthis !\u003d nullptr.\n2) a static method, that behaves the same way as the util method, but\ncalls the instance method if p !\u003d nullptr.\nThis requires using a full class qualifier for the static methods,\nwhich isn\u0027t exactly beautiful. I have tried to remove as many cases\nas possible where it was clear p !\u003d nullptr.\n\nBug: 22322814\nTest: test-art-host\nChange-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24\n" }, { "commit": "28bd2e4f151267b34b8e1eb19c489d8d547bbf5c", "tree": "d99ae3fe74ea63b83091898d830d3efe68cd479d", "parents": [ "6e5fa09510c7280168e040382d27dd8b55760d9a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 04 13:54:57 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 13 10:59:28 2016 -0700" }, "message": "Move mirror::Class to use ObjPtr\n\nLeave the return types as non ObjPtr for now. Fixed moving GC bugs\nin tests.\n\nTest: test-art-host\n\nBug: 31113334\n\nChange-Id: I5da1b5ac55dfbc5cc97a64be2c870ba9f512d9b0\n" }, { "commit": "51eaa7f5547f9ddea92ce57c6c2df9534d5017b8", "tree": "43456ed702c2ee5fe6ca1cbf7e9e53b2a4088109", "parents": [ "c2f1fc70dba4db8751248c4ad15315946f6d13d0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 12 16:08:35 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 12 17:07:04 2016 -0700" }, "message": "Fix moving GC bug in cloning finalizable objects\n\nIt is not safe to have thread suspension in the PreFenceVisitor. The fix is\nto add the finalizer reference in the caller.\n\nTest: art/tools/run-libcore-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nBug: 31113334\n\nChange-Id: I1e4650f8b75408a3d07e2c51ac334ff98552cfb5\n" }, { "commit": "9d156d500801accee919b6d51e22d6ddcdcd4a05", "tree": "92129562c0ba1673c660297f26444a4a2ad31459", "parents": [ "078483d4dfd049d5b3f192a99e2dfdc355e4754f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 06 17:44:26 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 12 09:49:49 2016 -0700" }, "message": "Move Heap parameters to ObjPtr\n\nDeleted some unused object dumping code.\n\nTest: test-art-host\n\nBug: 31113334\n\nChange-Id: I747220caafe6679591fd4b361d7f50383a046164\n" }, { "commit": "3398c7874e002beaa6c2b2fadf183e7d1ddad23a", "tree": "7db754b5b0c3a6c68bc1f91d7cb2477f534d2ad3", "parents": [ "462e21cc8d28a4d48342cf0f634bd1ecc63647d7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 30 10:27:43 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 03 14:06:27 2016 -0700" }, "message": "Move ArtField to ObjPtr\n\nAdded EXPECT_OBJ_PTR_EQ and variants to gtests.\n\nFixed moving GC bugs in:\nClassLinker::CreatePathClassLoader\nClassLinkerTest: StaticFields\n\nObjPtr Decode call sites: 186 -\u003e 181.\n\nSome tests fail due to ResolvedFieldAccessTest, will fix in follow\nup CL.\n\nBug: 31113334\n\nTest: test-art-host CC baker\n\nChange-Id: I8b266ad00f3c20c8cbe7cfdf280d175083df0b88\n" }, { "commit": "3fec9ac0d5af1358d216eb2fdc2000ec0205f3f0", "tree": "f38d8d8aae51f53e7ee6b474f47597b784fc2316", "parents": [ "0cfe19af3b7395658210ea6044a65c9811962a7a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 13 10:47:28 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 26 10:59:22 2016 -0700" }, "message": "ART: Use libbase logging\n\nMove most of our logging infrastructure over to system/core/base.\nRetain VLOG.\n\nUsing unified Android infrastructure has two main advantages. First,\nit reduces the complexity/maintenance burden in ART. Second, it\nallows to detach logging for the cases where we do not want or need\na runtime, e.g., dexdump, the disassembler, etc. As a part of the\nlatter, libbase is also supported for all hosts (including Windows).\n\nFrom a developer viewpoint, there are minor behavior changes for the\nLOG statements (see above), but otherwise usage is the same. Explicit\nseverity enum items are in the android::base namespace now.\n\nBug: 31338270\nTest: m test-art-host\nChange-Id: I5abcb2f45f5b03d49951874c48544f72a283a91b\n" }, { "commit": "26ead4975e1752e8ae2f5ed6fda73876c4f9ff59", "tree": "2ce1b047f54bfb4287483de8eaf79cd12f6058b6", "parents": [ "79f6d706185714dccf80aca20d9f3261337473ae", "268764da8022cafa5661c5b514eaa343c5257e57" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 14 16:55:56 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Sep 14 16:55:56 2016 +0000" }, "message": "Merge \"Make ScopedAssertNoThreadSuspension no overhead for non-debug\"" }, { "commit": "9323e6e44060545d6c4f925139572868f65b7fe3", "tree": "65f3f380605d75f34d49aec49fca494bec26ef5b", "parents": [ "58735fbfbb2da0c0a19b3239da07c2353c40767d" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Sep 13 08:58:35 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Sep 14 08:01:39 2016 -0700" }, "message": "Separate annotations from dexfile reading.\n\nBug: 22322814\nChange-Id: I867d66da407dd80394a10d19903ebbc1ec3986ff\nTest: test-art\n" }, { "commit": "268764da8022cafa5661c5b514eaa343c5257e57", "tree": "7c4b46847a6dcfac7a1492edd79b434fb1a0d6ea", "parents": [ "f9decf915f6fa5b33fceba7c10c119e4cad481e5" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 13 12:09:38 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 13 15:18:29 2016 -0700" }, "message": "Make ScopedAssertNoThreadSuspension no overhead for non-debug\n\nPreviously it required Thread::Current() which may not be free.\nThe plan is to add a lot more ScopedAssertNoThreadSuspension in\nthe codebase.\n\nAlso cleaned up callers.\n\nBug: 31458474\nChange-Id: I5a1621a5435476504d22266cc01a9bf26aab7568\n" }, { "commit": "161db1dea4808d32db3623cc1a8e91b53df0fb02", "tree": "43b1481040788e63ced53518061714539e5e5406", "parents": [ "4fd93aebe856151f818cfca515a902f7a171c604" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 01 14:06:54 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 02 10:56:08 2016 -0700" }, "message": "Use the fast path object size for RosAlloc asm stubs\n\nAlso address comments. MemAllocTest perf on N5X speedup in the noise.\n\nBug: 9986565\n\nTest: test-art-host -j32, N5X booting\n\nChange-Id: Ic22ca92aab88b37fd66928949bf11264ee3476dc\n" }, { "commit": "93bbee0c1c97bd9a5336ed0c9e41cd17613df585", "tree": "7f2fe8d9ec240b34e7ee153b95e69b821554ab7e", "parents": [ "1c29876b303ab392e615b2294db009a971613bea" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 31 09:38:40 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 31 18:32:33 2016 -0700" }, "message": "Faster allocation fast path\n\nAdded a new object size field to class, this field contains the\naligned object size if the object is not finalizable and is\ninitialized. If the object is finalizable or uninitialized the field\nis set to some large value that forces the ASM allocators to go slow\npath.\n\nOnly implemented for region/normal TLAB for now, will add the to\nRosAlloc stubs soon.\n\nCC N6P MemAllocTest: 1067 -\u003e 1039 (25 samples)\nCC N6P EAAC: 1281 -\u003e 1260 (25 samples)\n\nRAM overhead technically 0 since mirror::Class was not 8 byte aligned\npreviously. Since the allocators require 8 byte allignment, there\nwould have been 1 word of padding at the end of the class. If there\nwas actually 4 extra bytes per class, the system overhead would be\n36000 * 4 \u003d 120KB based on old N6P numbers for the number of loaded\nclasses after boot.\n\nBug: 9986565\n\nTest: test-art-host CC baker, N6P phone boot and EAAC runs.\n\nChange-Id: I119a87b8cc6c980bff980a0c62f42610dab5e531\n" }, { "commit": "bdf7f1c3ab65ccb70f62db5ab31dba060632d458", "tree": "25cc77adfeb05232d0ab00aa561a693f1d71745c", "parents": [ "d7eabc2cc1a88c1f7f927da61246ae65aab0626c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 16:38:47 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 17:02:53 2016 -0700" }, "message": "ART: SHARED_REQUIRES to REQUIRES_SHARED\n\nThis coincides with the actual attribute name and upstream usage.\nPreparation for deferring to libbase.\n\nTest: m\nTest: m test-art-host\nChange-Id: Ia8986b5dfd926ba772bf00b0a35eaf83596d8518\n" }, { "commit": "5bb4b0b4fcf230d8e4e45cd3fdec820f0b44141a", "tree": "eba2ca0cc99b74bd909cfa9a35dcf83f086c9009", "parents": [ "d833525cfe3ac2086e3156a8b3193c05974d6316" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 17 22:43:52 2016 +0000" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 17 22:43:52 2016 +0000" }, "message": "Revert \"Logging improvements for C++ / Java structure issues\"\n\nBug: 30913672\n\nThis reverts commit d833525cfe3ac2086e3156a8b3193c05974d6316.\n\nChange-Id: I4e51591b49d54b8bb3e920fbc221c21aca0084fb\n" }, { "commit": "d833525cfe3ac2086e3156a8b3193c05974d6316", "tree": "aac45dd6a27a305f1c49cb8a74488be29eda747c", "parents": [ "95afcbcc25bb17c9c34e8b7708013b612a3bb581" ], "author": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Wed Aug 17 11:39:26 2016 +0100" }, "committer": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Wed Aug 17 11:39:26 2016 +0100" }, "message": "Logging improvements for C++ / Java structure issues\n\nWhen C++ and Java structures are different sizes or arranged\ndifferently some log statements are useful but are hard to\npick out because they merge with other log lines. Adding\n\"\\n\" to the end of them makes it easier to read.\n\nChange-Id: Ia6d78e0832c7814bf1fef42bb3d8c056f83766bd\nTest: make build-art-host\n" }, { "commit": "542451cc546779f5c67840e105c51205a1b0a8fd", "tree": "11e09bb5abaee12dddffefbe7e425291076dfa7a", "parents": [ "85c4a4b8c9eabfe16e4e49f9b4aa78c1bf4be023" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jul 26 09:02:02 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 01 18:54:48 2016 -0700" }, "message": "ART: Convert pointer size to enum\n\nMove away from size_t to dedicated enum (class).\n\nBug: 30373134\nBug: 30419309\nTest: m test-art-host\nChange-Id: Id453c330f1065012e7d4f9fc24ac477cc9bb9269\n" }, { "commit": "e01e3644205c3644546889237c20185391a0092e", "tree": "413fcf279b415a305605a601297e3856f13a2948", "parents": [ "de4cf16f467b531373560ca6eb785f0f36606aae" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 25 13:06:04 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 25 13:09:41 2016 -0700" }, "message": "ART: Add pointer-size template to some reflection functions\n\nThe unstarted runtime may run code for a different pointer size,\neven when no transaction is active (e.g., during startup). To\nretain performance when the runtime is up and executing under\nnormal conditions, add a template parameter and use sizeof(void*)\nin places where it is adequate.\n\nFor maintainability, it is necessary to drop the default for\nthe transaction template parameter. Implicit conversions from\nbool to size_t may lead to incorrect code and hard to diagnose\nproblems. So instead ensure that all callers must give all\ntemplate parameter values.\n\nTest: m test-art-host\nChange-Id: I3076883422c8553ede4de5642409c5684a5a9aa8\n" }, { "commit": "65ad9b3516c4f4bc4e7abf5c6e065a675cf024d8", "tree": "7650ae342ce201d498526609d506df7f52783d3a", "parents": [ "a92938a17b75eed3213030faaff9cfb321d47f37", "bb268b14da040c5df27a413426aa2baab602ed15" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 21 10:33:13 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jul 21 10:33:13 2016 +0000" }, "message": "Merge \"Clean up Class::FindStaticField().\"" }, { "commit": "a62cb9bb6cb2278cb41ab0664191623e178c6a4f", "tree": "62263dac644e2d80a34a04f2649e4741a1bed6f4", "parents": [ "bb8d501c9bb882a8927c6ceda07bf9577e06c3e1" ], "author": { "name": "Artem Udovichenko", "email": "artem.u@samsung.com", "time": "Thu Jun 30 09:18:25 2016 +0000" }, "committer": { "name": "Artem Udovichenko", "email": "artem.u@samsung.com", "time": "Thu Jul 07 10:01:04 2016 +0000" }, "message": "Revert \"Revert \"Optimize IMT\"\"\n\nThis reverts commit 88f288e3564d79d87c0cd8bb831ec5a791ba4861.\n\nChange-Id: I49605d53692cbec1e2622e23ff2893fc51ed4115\n" }, { "commit": "bb268b14da040c5df27a413426aa2baab602ed15", "tree": "04e2fbfa54bc278170d361f97781b066b4abe46a", "parents": [ "d80c5d2368b4455c452e8b4fe2d8511fe1c0430c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 30 15:52:56 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jul 04 17:44:17 2016 +0100" }, "message": "Clean up Class::FindStaticField().\n\nPreviously we have wrapped the class pointer in a Handle\nfor the GetDirectInterface() call but we didn\u0027t wrap the\nDexCache pointer. Since GetDirectInferface() call from\nthis function cannot cause thread suspension anyway, fix\nthe inconsistency by using raw pointers where possible\nand asserting that no thread suspension takes place.\n\nTest: Run standard ART test suite in gcstress mode.\nChange-Id: Ie4c6101aabd6fa68733e4920db277f835793d943\n" }, { "commit": "88f288e3564d79d87c0cd8bb831ec5a791ba4861", "tree": "dd051a7b2985d1af3fea91ad6000de4bdc701a19", "parents": [ "e36389f20c83083c0aaba2dcac0888951e55cae1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 29 08:17:52 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 29 08:41:25 2016 +0000" }, "message": "Revert \"Optimize IMT\"\n\nBug: 29188168 (for initial CL)\nBug: 29778499 (reason for revert)\n\nThis reverts commit badee9820fcf5dca5f8c46c3215ae1779ee7736e.\n\nChange-Id: I32b8463122c3521e233c34ca95c96a5078e88848\n" }, { "commit": "badee9820fcf5dca5f8c46c3215ae1779ee7736e", "tree": "982948a67a88a1f9a734c935f919f8d307969f48", "parents": [ "614968198625a6693666bdc1e5609e2f663f5638" ], "author": { "name": "Nelli Kim", "email": "nelli.kim@samsung.com", "time": "Fri May 13 13:08:53 2016 +0300" }, "committer": { "name": "Matthew Gharrity", "email": "gharrma@google.com", "time": "Tue Jun 14 10:05:47 2016 -0700" }, "message": "Optimize IMT\n\n* Remove IMT for classes which do not implement interfaces\n* Remove IMT for array classes\n* Share same IMT\n\nSaved memory (measured on hammerhead):\nboot.art:\nTotal number of classes: 3854\nNumber of affected classes: 1637\nSaved memory: 409kB\n\nChrome (excluding classes in boot.art):\nTotal number of classes: 2409\nNumber of affected classes: 1259\nSaved memory: 314kB\n\nGoogle Maps (excluding classes in boot.art):\nTotal number of classes: 6988\nNumber of affected classes: 2574\nSaved memory: 643kB\n\nPerformance regression on benchmarks/InvokeInterface.java benchmark\n(measured timeCall10Interface)\n1st launch: 9.6%\n2nd launch: 6.8%\n\nChange-Id: If07e45390014a6ee8f3c1c4ca095b43046f0871f\n" }, { "commit": "715fdc2c99f688f97c684978632f311a284ba43c", "tree": "a45838f4788a04ec18332bf386e8eaf2daa07632", "parents": [ "a584db5460a31198bf621cdacf5bc304a984efa4" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 18 17:07:30 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Apr 20 10:20:45 2016 -0700" }, "message": "ART: Add some reflection cutouts\n\nAdd Class.getInnerClassFlags and Method.invoke to unstarted runtime.\n\nAllows to compile-time initialize:\n* android.net.NetworkInfo\n* android.net.wifi.WifiInfo\n\nBug: 27265238\n\n(cherry picked from commit b3ffbe32b78c18739736fc998d65430b46c510e5)\n\nChange-Id: I3e267519acf14b08c687f1e831e2027d37158767\n" }, { "commit": "6039e5662507e42896084e561fa546b432698ee6", "tree": "d8a4b6260cc134fcdf7f4a24d89d062dae7f7a61", "parents": [ "dc148d24cc11845036063a2876c9bfef03d00ce5" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Apr 05 18:18:43 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Apr 06 13:43:54 2016 -0700" }, "message": "ART: Add getDeclaredConstructor cutout for unstarted runtime\n\nIn the vein of getDeclaredMethod and getDeclaredField. Refactor\ncode from java_lang_Class to share code.\n\nAllows to compile-time initialize:\n* sun.security.x509.AVAKeyword\n* sun.security.x509.X500Name\n\nBug: 27265238\n\n(cherry picked from commit f72f19fac0016499d33fd75b0463d0128a58a9f4)\n\nChange-Id: I075c1b11f3408f5b31e4f84140a24fd8d3eaa17e\n" }, { "commit": "22deed092ff53e4e11e09dd9bd24a220a566190f", "tree": "13354a8868ca70c5e12e032c7a0714de76ae6a03", "parents": [ "7d9a5b0fbceef5806f059060d47533b9e699ec28" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Mon Apr 04 14:19:01 2016 -0700" }, "committer": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Mon Apr 04 14:19:01 2016 -0700" }, "message": "Move DCHECK into loop.\n\nRationale:\nSince pointer is non-null on loop entry, moving the check\ninto the while loop (rather than after) gives a more friendly\nerror message in debug mode when something goes wrong.\n\nBUG\u003d27825731\nBUG\u003d27627004\n\nChange-Id: I2ea67b3ab6c4edc6815fea38a436e5c3c194e540\n" }, { "commit": "bc4d218ce2ceef0c4f308d4ff42f7ec1ec43c40e", "tree": "a583db9be377183508653607a724dcb8742f4ca2", "parents": [ "01c30e8dbc45bdc5d922cef6e5a404be7bed0e8c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Feb 22 10:03:12 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Feb 26 15:43:14 2016 -0800" }, "message": "ART: Add unstarted-runtime functions\n\nAdd more functions to allow compile-time initialization of\ncode.\n\nBug: 27248115\n\n(cherry picked from commit 0866f4ed6338faa4a193b7e819fc7cd72bd7b0ae)\n\nChange-Id: Iaf8d92deb73547ccd31c0d6dde68da3bc14c3985\n" }, { "commit": "e4084a5eb46dc6b99c0e0b74bcdecccaceb28fe7", "tree": "d47f5a4ff9faae1736fc065e82d39110b9261e61", "parents": [ "a1f65135cd2315159ac302f904ba0c5ba0d7fd0e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 18 14:43:42 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 18 15:14:30 2016 +0000" }, "message": "Small inlining improvements.\n\n- Use the type_index in the current dex file for classes not\n defined in the current dex file.\n- Make the loading of the vtable field of a class have no side effects\n to enable gvn\u0027ing it.\n\nNote that those improvements only affect the JIT, where we don\u0027t have\nchecker support.\n\nChange-Id: I519f52bd8270f2b828f0920a1214da33cf788f41\n" }, { "commit": "df707e406877e9c0426dd051c00933ebb331673e", "tree": "db9c96c96d373935a83dda2fafbf3c7e1aef3377", "parents": [ "e3d4ff566f9545114bf9ed72421e49eaf9d37953" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Feb 02 16:56:50 2016 -0800" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Feb 03 13:39:19 2016 -0800" }, "message": "runtime: Don\u0027t skip verification for -Xverify:soft-fail\n\nWhen forcing the interpreter into access checks mode,\nmake sure that the regular verification is still run,\ngiving the verifier an opportunity to throw a VerifyError.\n\nIf verification would\u0027ve succeeded (without -Xverify:soft-fail flag),\noverride this and soft-fail, to force the interpreter-with-access-checks to be run\ninstead of the normal faster interpreter.\n\nThis fixes the following run-tests under the interpeter-access-checks:\n* 135\n* 412\n* 471\n* 506\n* 800\n\nBug: 22414682\nChange-Id: I5cb86a8bba71c7af9361a63c0802786c852b857b\n" }, { "commit": "a42363f79832a6e14f348514664dc6dc3edf9da2", "tree": "bcd43acdf9903a704b566af00b5c740786284b7b", "parents": [ "9cea9139033a4d04437ebc5542e9466fd67137fe" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Dec 17 14:57:09 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 28 15:55:46 2016 +0000" }, "message": "Implement first kind of polymorphic inlining.\n\nAdd HClassTableGet to fetch an ArtMethod from the vtable or imt,\nand compare it to the only method the profiling saw.\n\nChange-Id: I76afd3689178f10e3be048aa3ac9a97c6f63295d\n" }, { "commit": "705ad49f353d3f90d8b63625aca2c2035bacdbef", "tree": "ac70af53158a80bc35c057aefae11428281df9ac", "parents": [ "fae1db92d8433d0f75258c190bcf2c940731f036" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Sep 21 11:36:30 2015 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jan 12 15:40:31 2016 -0800" }, "message": "Support directly invoking interface default methods\n\nWith the Java 8 Language one is allowed to directly call default\ninterface methods of interfaces one (directly) implements through the\nuse of the super keyword. We support this behavior through the\ninvoke-super opcode with the target being an interface.\n\nWe add 3 tests for this behavior.\n\nCurrently only supports slow-path interpreter.\n\nInvoke-super is currently extremely slow.\n\nBug: 24618811\n\nChange-Id: I7e06e17326f7dbae0116bd7dfefca151f0092bd2\n" }, { "commit": "e64300b8488716056775ecbfa2915dd1b4ce7e08", "tree": "be23a7086c1e369527dda5450a9868f2d29c5669", "parents": [ "bc90a0538e56f98b8e138cb622e6b9d834244ad9" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Dec 15 15:02:47 2015 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Dec 16 14:16:31 2015 -0800" }, "message": "Revert \"Revert \"Combine direct_methods_ and virtual_methods_ fields of mirror::Class\"\"\n\nThis reverts commit ae358c1d5cef227b44d6f4971b79e1ab91aa26eb.\n\nBug: 24618811\n\nChange-Id: I8becf9bae3258450b90cfef5e79589db7c535a4d\n" }, { "commit": "ae358c1d5cef227b44d6f4971b79e1ab91aa26eb", "tree": "95c22194af5ea38a4fa5fc8bbe07ba60b6d0a021", "parents": [ "6286a97bea0f584342803a215550038852b24776" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Dec 15 22:15:26 2015 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Dec 15 22:15:26 2015 +0000" }, "message": "Revert \"Combine direct_methods_ and virtual_methods_ fields of mirror::Class\"\n\nThis reverts commit 6286a97bea0f584342803a215550038852b24776.\n\nChange-Id: I5b00f6d1350e9c587acd4b185367dc815ea707de\n" }, { "commit": "6286a97bea0f584342803a215550038852b24776", "tree": "3571735bdc691bf30e33abb65a95ada8c71a18b7", "parents": [ "377cb3ba2e1cfe51967e5292268a9aae71ceca8c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Dec 03 17:38:56 2015 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Dec 14 14:27:32 2015 -0800" }, "message": "Combine direct_methods_ and virtual_methods_ fields of mirror::Class\n\nThis makes several parts of the overall runtime simpler and reduces\nthe size of a class object by 32-bits.\n\nBug: 24618811\n\nChange-Id: I36129b52189e26898ea56fa2b7b45652e06af236\n" }, { "commit": "3a0909248e04b22c3981cbf617bc2502ed5b6380", "tree": "b0b7013ea78b10f23fae75ef145e53a696ff797c", "parents": [ "457e874459ae638145cab6d572e34d48480e39d2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "message": "Revert \"lambda: Add support for invoke-interface for boxed innate lambdas\"\n\n955-lambda is flaky\n\nBug: 24618608\nBug: 25107649\n\nThis reverts commit 457e874459ae638145cab6d572e34d48480e39d2.\n\nChange-Id: I24884344d21d7a4262e53e3f5dba57032687ddb7\n" }, { "commit": "457e874459ae638145cab6d572e34d48480e39d2", "tree": "b192c4698c4889ae90db6abe2652199802213fe6", "parents": [ "3944f7175dcf60316ba58a42698ccf23c65ac57c" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Oct 22 17:37:50 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Nov 20 16:33:06 2015 -0800" }, "message": "lambda: Add support for invoke-interface for boxed innate lambdas\n\nLambda closures created with the \u0027create-lambda\u0027 instruction\n(termed \"innate lambdas\") can be turned into an object with \u0027box-lambda\u0027.\n\nThis CL enables support for those kinds of lambdas to work with\n\u0027invoke-interface\u0027 by generating a proxy class for the lambda.\n\nNote: MIPS32/64 support not included.\n\nBug: 24618608\nBug: 25107649\nChange-Id: Ic8f1bb66ebeaed4097e758a50becf1cff6ccaefb\n" }, { "commit": "a4d1b6438ffaa68307480e8bb40cd18842daa2f3", "tree": "01f1e2899b88f9c3848d45bce7aa144c360f2940", "parents": [ "a7a3ba792d608535e4d53ccc3b7a89d110609f12", "52503d83d057c66ea50eed491290e267b80e1fd3" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed Nov 18 10:41:41 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Nov 18 10:41:41 2015 +0000" }, "message": "Merge \"Implement common super type in reference type propagation.\"" }, { "commit": "52503d83d057c66ea50eed491290e267b80e1fd3", "tree": "c55872ee898f67c7982deeadfb2b2820dde4b1bb", "parents": [ "617bd9255bbdb9890e9d80462d293b94ba41c1f2" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed Nov 11 16:58:31 2015 +0000" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Tue Nov 17 18:47:43 2015 +0000" }, "message": "Implement common super type in reference type propagation.\n\nCurrently only if both types are classes.\n\nChange-Id: I06e98211ead56875a42bd17f099e319b107a50d4\n" }, { "commit": "9139e008abe30b7beaf4afd6533228a1dd9b202c", "tree": "506be89287507bd777bd132627ad963729434969", "parents": [ "d7c76bd7e867b151ac81ef41810614c7b4cc898e" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Oct 09 15:59:48 2015 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Nov 10 17:20:41 2015 -0800" }, "message": "Correct exception behavior for default methods\n\nDefault methods are defined to throw an IncompatibleClassChangeError\n(ICCE) when they are called and there is no \"best\" implementation.\nPreviously we would simply throw an ICCE during class loading as soon\nas we noticed that this would happen if called. This makes us wait\nuntil we actually attempt to execute the method. Furthermore, this\nallows us to use other, non-conflicting, methods on the object as\nnormal.\n\nFurthermore, this makes us correctly throw AbstractMethodErrors in\ncases where all default implementations of a method are overridden by\nabstract declarations.\n\nAdds 3 tests for this new behavior.\n\nBug: 24618811\n\nChange-Id: Id891958a81f9b3862b2ce5919636aabef7d3422e\n" }, { "commit": "cb086955c2a21270cd2f53a8bce71e577d776506", "tree": "be580e6a4050539b2785d6d92cb9e71507c075d2", "parents": [ "accc24985c08e98a27f43bc856fba4c3c48e79e9" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 02 16:20:00 2015 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 04 18:01:26 2015 -0800" }, "message": "ART: Change behavior for rethrowing init failures (2)\n\nAlways store the pending exception when making a class erroneous.\nInstead of filtering by ExceptionInInitializerError, add an option\nto the rethrow that enforces a NoClassDefFoundError, which is required\nby the specification.\n\nUse the libcore companion change to add the stored error (if any) as\na cause to the NoClassDefFoundError, which should significantly help\ntracking down issues.\n\nFix run-test 008 to expect spec-compliant behavior. Test that a cause\nhas been set.\n\nBug: 25445103\nChange-Id: I6a0dc54e78312283faf23415887eff387531407f\n" }, { "commit": "99babb6add7db19ce7605f6d5e4aee79d52e386f", "tree": "116f63fc2f96ad103a5dc121667d4b3df9e6e2ff", "parents": [ "3f922d1f3ccd7a1341f887ac3e8176b5208ecf6d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 02 16:20:00 2015 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 04 12:16:16 2015 -0800" }, "message": "ART: Change behavior for rethrowing init failures\n\nAllow to store a Throwable instance or a throwable class. Handle\nrethrow accordingly.\n\nBug: 25444180\nChange-Id: I703c2c6eaf34ad0e3bc0f5a104d65f2ff1b212ca\n" }, { "commit": "35831e8bfa1c0944d4c978d99c4c5b9577945170", "tree": "a347ecaf4265a1713c86d528392e162d5edfaebc", "parents": [ "171b12e8060f63cf900ffc43d6db35125f6b8c83" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Sep 11 11:59:18 2015 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 27 15:13:37 2015 +0000" }, "message": "Reduce memory used by CompiledMethods.\n\nUse LengthPrefixedArray\u003c\u003es instead of SwapVector\u003c\u003es to store\nCompiledMethod data and get rid of the unnecessary members\nof CompiledMethod to reduce dex2oat memory usage. Refactor\nthe deduplication from CompilerDriver to a new class.\n\nUse HashSet\u003c\u003e instead of std::set\u003c\u003e for the DedupeSet\u003c\u003e to\nfurther decrease the memory usage and improve performance.\n\nThis reduces the dex2oat memory usage when compiling boot\nimage on Nexus 5 (with Optimizing, -j1) by ~6.75MiB (5%).\nThis also reduces the compile time by ~2.2% (~1.6% dex2oat\ntime; with Optimizing, without -j).\n\nChange-Id: I974f1f5e58350de2bf487a2bca3907fa05fb80ea\n" }, { "commit": "e2aa3265594486b4b977453752645cdce3026e82", "tree": "9dbc25ecfea85fdbae2db380af3649a1a05941dc", "parents": [ "534a9b68ec5e8dda8f6e0a07bf0fdbaeb0cedbfe" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 20 18:30:03 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 21 08:38:11 2015 -0700" }, "message": "Use binary search for FindDeclaredInstance/StaticField\n\nBefore:\nreal 1m18.157s\nuser 1m8.167s\nsys 0m8.071s\n\nAfter:\nreal 1m12.943s\nuser 1m3.223s\nsys 0m7.881s\n\nPerf results:\nFindDeclaredStaticField: 1.78% -\u003e 0.11%\n__GI___strncmp_ssse3: 2.45% -\u003e 0.87%\n\nBug: 10921004\n\nChange-Id: Ice7d3ce2635d6cd2de5574055375d9e20712d241\n" }, { "commit": "4726941669584b30087ae7b4d142db4777d27015", "tree": "1955285beadada0050fd260e7fe4812c1f0b666a", "parents": [ "fb32aca04cc1b5f5e8325d79664882f25f253881", "66c2d2d64d7ea75602eb63de7ae9bd2eaeb0a3c2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 26 17:56:25 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Aug 26 17:56:25 2015 +0000" }, "message": "Merge \"Address some comments for class flags\"" }, { "commit": "66c2d2d64d7ea75602eb63de7ae9bd2eaeb0a3c2", "tree": "ade8f8e55ebba8ff8deaa6efc2be5af4f76e737f", "parents": [ "dda43e7e9680e6eead02876e67718d01837d89e0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Aug 25 14:32:32 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Aug 25 14:32:32 2015 -0700" }, "message": "Address some comments for class flags\n\nChange-Id: I354f48aefc37ce92c4d02cfce1723db0e28907bf\n" }, { "commit": "13e748b28c5f2bd1e83674d2ca899ff61ae5c0a1", "tree": "387724eebfe7cd0f7be368e64b22af3894eea4c7", "parents": [ "dda43e7e9680e6eead02876e67718d01837d89e0" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Aug 25 20:44:19 2015 +0000" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Aug 25 14:20:09 2015 -0700" }, "message": "Revert \"Revert \"Move annotations to native.\"\"\n\nThis reverts commit 7db6dd79a24570448ae737ee1946b00396696cac.\n\nAdds check if field\u0027s declaring class is proxy.\nBug: 23508574\n\nChange-Id: Ie829f1526e74427711e818b56d1588d92946cbf6\n" }, { "commit": "c97748381468485535b11bfc8664c26385f4b715", "tree": "32b50f85ae66aaffd67fa5d0ed2f91d91369bb96", "parents": [ "f0170ded84fbcd3d9152cdbcf9ffbf74c71b03ba", "7db6dd79a24570448ae737ee1946b00396696cac" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Aug 25 12:07:47 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Aug 25 12:07:47 2015 +0000" }, "message": "Merge \"Revert \"Move annotations to native.\"\"" } ], "next": "7db6dd79a24570448ae737ee1946b00396696cac" }