)]}' { "log": [ { "commit": "0d4567f26701abae84b02389c379843c1dc851a8", "tree": "f665e6d5db5af79a4afa3b97cd7cdb7a2069da3f", "parents": [ "cc08c50948d8b2a93b53a327717c7b2a146ac754" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu May 30 22:45:40 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 30 18:04:44 2019 +0000" }, "message": "Stack maps: Refactor constructors.\n\nCreate dedicated static methods instead of passing flags.\nThis creates dedicated methods for the purpose and merges\nconstructor and decoding into single optimized method.\n\nThis speeds up CodeInfo by 10%, and maps startup by 0.1%.\n\nTest: ./art/test.py -b --host\nChange-Id: Ic7d43e22bca0be9fb13bc2c7544ebfdf46798cfe\n" }, { "commit": "6c4ec5c1555aaeddd254750c15554a3c47bfc722", "tree": "d0ef0588f0e625bfeb0f9b86305f45b6fd37260a", "parents": [ "349845ae9c820484973959e1f3d366099d2fa0c2" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 20 07:23:19 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jun 20 11:16:38 2019 +0000" }, "message": "Revert^2 \"Stack maps: Interleave consecutive varints.\"\n\nReorder the layout of consecutive varints. Store all the \u0027headers\u0027\nwhich define the varint size first and then store any large values.\n\nThe size is unchanged, but it makes the reading from memory faster.\n\nThis speeds up CodeInfo by 10%, and maps startup by 0.1%.\nChange in size is negligible (the bits mostly just move).\n\nThis reverts commit 1b2a49b7aba39ed6663a69dfdf63d0df069f0d42.\n\nTest: test.py -b --host --64 --optimizing\nChange-Id: Ica7b42180ef2bae637445c0ce44fd3833ec0ecfc\n" }, { "commit": "1b2a49b7aba39ed6663a69dfdf63d0df069f0d42", "tree": "15a22f6390135758cb9eeaa1ef816f4634cc70f9", "parents": [ "a2b34561a7faca95d0a4f8194ad155798e238e37" ], "author": { "name": "Raylin Hsu", "email": "raylinhsu@google.com", "time": "Thu Jun 20 01:41:31 2019 +0000" }, "committer": { "name": "Raylin Hsu", "email": "raylinhsu@google.com", "time": "Thu Jun 20 01:43:54 2019 +0000" }, "message": "Revert \"Stack maps: Interleave consecutive varints.\"\n\nThis reverts commit a2b34561a7faca95d0a4f8194ad155798e238e37.\n\nReason for revert: \u003cINSERT REASONING HERE\u003e\n\nChange-Id: Ie5b220e429e101bb5fa2606665a9c8cb64308ad3\n\nBug: 135638469\n" }, { "commit": "a2b34561a7faca95d0a4f8194ad155798e238e37", "tree": "2da4501b3fdd20e3d227869a4ce44eab03b79434", "parents": [ "34087c1047b79b7ec83eb2f45cf4f70524e0f6f5" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 16 21:53:51 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 19 18:24:04 2019 +0000" }, "message": "Stack maps: Interleave consecutive varints.\n\nReorder the layout of consecutive varints. Store all the \u0027headers\u0027\nwhich define the varint size first and then store any large values.\nThe size is unchanged, but it makes the reading from memory faster.\n\nThis speeds up CodeInfo by 10%, and maps startup by 0.1%.\nChange in size is negligible (the bits mostly just move).\n\nTest: test.py -b --host --64 --optimizing\nChange-Id: I16f702389d4ba94a407b1586cae5f82b8ef60e7b\n" }, { "commit": "697c47a7ffd4489c4bc4edc229c8123309526286", "tree": "04cf832df533fd529cc598ecff9be8c2763d61b8", "parents": [ "8ac3dc5ec31569630a99caed2a69f64d84a6c0b6" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 16 21:53:07 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jun 18 11:35:05 2019 +0000" }, "message": "Stack maps: Handle special cases using flags.\n\nKeep the BitTable decoder simple (1+NumColumns varints).\nMove special case handling up to CodeInfo (empty/dedup).\n\nThis speeds up CodeInfo by 5%, and maps startup by 0.05%.\nChange in size is negligible (the bits mostly just move).\n\nTest: test.py -b --host --64 --optimizing\nChange-Id: Ib6abe52f04384de9ffd7cfba04a3124b62f713ff\n" }, { "commit": "e42a4b95eed312e6f7019645f4c66b2d77254433", "tree": "dd150dd4651180c5fbba3a4fd90f8ca8a3f14e9d", "parents": [ "67ba872df798271d2960be27c7f1e813259feabc" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun May 26 00:10:25 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun May 26 23:47:47 2019 +0000" }, "message": "Optimize stack maps: add fast path for no inline info.\n\nConsumers of CodeInfo can skip significant chunks of work\nif they can quickly determine that method has no inlining.\n\nStore this fact as a flag bit at the start of code info.\nThis changes binary format and adds \u003c0.1% to oat size.\n\nI added the extra flag field as the simplest solution for now,\nalthough I would like to use it for more things in the future.\n(e.g. store the special cases of empty/deduped tables in it)\n\nThis improves app startup by 0.4% (maps,speed).\nPMD on golem seems to gets around 15% faster.\n\nBug: 133257467\nTest: ./art/test.py -b --host --64\nChange-Id: Ia498a31bafc74b51cc95b8c70cf1da4b0e3d894e\n" }, { "commit": "67ba872df798271d2960be27c7f1e813259feabc", "tree": "93bb6a90a1e1810799faa0ab1e0d672ce041c0ed", "parents": [ "436f6c1e53b735ace36fbfe48c337ece07d76e62" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu May 23 15:32:18 2019 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sat May 25 10:30:57 2019 +0000" }, "message": "Optimize stack map decoding.\n\nWe usually read several consecutive varints.\nAdd helper method optimized for that use case\n(ideally reading 8 varints from single load).\n\nThis improves app startup by 0.4% (maps,speed).\nPMD on golem seems to get around 5% faster.\nCodeInfo::Decode on its own is 25% faster.\n\nBug: 133257467\nTest: ./art/test.py -b --host --64\nChange-Id: Iaf7e8469ed6397b1d1d4102e409b5731f7229557\n" }, { "commit": "bf5f0f3f1eea2e712e7269ff1e1f9b1bcc4cbaee", "tree": "030ef55b56ede3dbf42b6b5f19c59bfc0583636f", "parents": [ "7e057ec0e023910f6bc42bc552a8463343cf346f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 05 15:41:50 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Mar 06 14:21:51 2019 +0000" }, "message": "Revert \"Revert^2 \"Add code size to CodeInfo\"\"\n\nThis reverts commit e1412dacbf1d2a809bd1fca658cc8cb8f61f8ee6.\n\nBug: 123510633\nBug: 127305289\n\nReason for revert: b/127305289\n\nChange-Id: I54557b05a44777f1fa2c15bde4fa648980f42eed\n" }, { "commit": "b1b2ca97651b1993e0a00a4543209419afbc6e64", "tree": "64e58ebe9d4c77f1adf401bb4d9066c720a0c29c", "parents": [ "37678283d1be77007e61bb0e811008aa89a27d14" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 05 09:23:37 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 05 11:36:19 2019 +0000" }, "message": "Revert \"Don\u0027t pack code size in CodeInfo.\"\n\nThis reverts commit e35ac04a1a9a22b1c4386b27f3a30cd840aa17b1.\n\nBug: 123510633\nBug: 127305289\n\nReason for revert: b/127305289\n\nChange-Id: I18c2d9291411b31641333c14c47da8c4fdf317f7\n" }, { "commit": "e35ac04a1a9a22b1c4386b27f3a30cd840aa17b1", "tree": "951fc00e6ef2a8576c9f6c0a6d7601cd93283199", "parents": [ "8834699a05deb680a36dd3075afb85aee9208f37" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Feb 25 18:11:53 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Feb 27 23:20:07 2019 +0000" }, "message": "Don\u0027t pack code size in CodeInfo.\n\nThe unpacking is tricky for host tooling as we need to propagate ISA.\n\nThis adds 0.05% to oat file size.\n\nBug: 123510633\nChange-Id: I5618db5e5dbe83d8a2bb89aef61cb0b10e336f40\n" }, { "commit": "e1412dacbf1d2a809bd1fca658cc8cb8f61f8ee6", "tree": "bb3f56ecefe08b66f7a330a02caef0b089a0c2af", "parents": [ "8f20a23a35fa6fbe4dcb4ff70268a24dc7fb2a24" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Feb 13 17:27:17 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 14 09:43:00 2019 +0000" }, "message": "Revert^2 \"Add code size to CodeInfo\"\n\nThis temporarily adds 0.25% to oat file size.\nThe space will be reclaimed back in follow-up CL.\n\nThis reverts commit 8f20a23a35fa6fbe4dcb4ff70268a24dc7fb2a24.\n\nReason for revert: Reland as-is after CL/903819\n\nBug: 123510633\nTest: DCHECK compare the two stored code sizes.\nChange-Id: Ia3ab31c208948f4996188764fcdcba13d9977d19\n" }, { "commit": "8f20a23a35fa6fbe4dcb4ff70268a24dc7fb2a24", "tree": "84dc682b40f38d0377639befe6f3d43e5655a43c", "parents": [ "68efa7b1128486e08ae60cd27181645b27bbd2e4" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Feb 12 19:42:54 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Feb 12 19:42:54 2019 +0000" }, "message": "Revert \"Add code size to CodeInfo\"\n\nThis reverts commit 68efa7b1128486e08ae60cd27181645b27bbd2e4.\n\nReason for revert: Breaks tests\n\nChange-Id: I28fb143990f58e0d5f0b106bea9d9a159f19297e\n" }, { "commit": "68efa7b1128486e08ae60cd27181645b27bbd2e4", "tree": "bb3f56ecefe08b66f7a330a02caef0b089a0c2af", "parents": [ "794350fd0e21aa9e259b6c45394494871e7fdb13" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jan 28 18:59:23 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Feb 11 13:23:53 2019 +0000" }, "message": "Add code size to CodeInfo\n\nThis temporarily adds 0.25% to oat file size.\nThe space will be reclaimed back in follow-up CL.\n\nBug: 123510633\nTest: DCHECK compare the two stored code sizes.\nChange-Id: I15340824ca637fd075a4cef87771b06cb96bb9f4\n" }, { "commit": "2259f1c008bee88902057ecc2ca1b91fe4e74bd7", "tree": "376098e43ea9cacbfd4aa5360f7cfd7c3df96c84", "parents": [ "4706ff08bd26dc958d3f162894b92036b02cdeb7" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jan 16 23:18:30 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jan 17 16:26:14 2019 +0000" }, "message": "Extend lifetime of CodeInfo in StackVisitor.\n\nUsers of the visitor may use the API after WalkStack is finished.\n\nTest: test.py -b --host\nBug: 120844051\nChange-Id: Ia445d3b4c5c338402c92f1d29b522a33cd5baa14\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "42deda8a5ee207706df37d7cb56d2a48e94073f0", "tree": "fc1b40813e502c04241950eef5c8b27313fa9ed7", "parents": [ "dd667714e9504d447e752b0cffdf757a6133392b" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 10 11:23:27 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 10 16:41:33 2018 +0100" }, "message": "Add helper method to iterate over BitTable fields in CodeInfo.\n\nAvoid the repetitive code patterns and simplify code.\n\nTest: test-art-host-gtest-stack_map_test\nTest: checked output of oatdump\nChange-Id: I2354bc652837eb34efeecf4de56a027384544034\n" }, { "commit": "0c3aa31b7151c3b67aa0dff1ae2b8718eeb905c7", "tree": "b7153d8f452ba686cc88052079aafae3f838d34e", "parents": [ "971a80e5aa36955d9fee6b479a5cbd554f50ca08" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 03 14:52:32 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 10 12:40:01 2018 +0100" }, "message": "Move varint encoding/decoding to BitMemoryReader/Writer.\n\nTest: test-art-host-gtest-bit_memory_region_test\nChange-Id: I0f7d7dfc9efe9df0e3e746b1741c46f06a0bd3b4\n" }, { "commit": "d1606417eac35d4842f607b63eda48e868e8db1d", "tree": "90220460ac22f888d93dd46596d67f1dbdceaffc", "parents": [ "2382eaec6a9d661b541eae3ce9dbcd9edb7ad251" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jul 31 15:05:14 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 10 09:43:45 2018 +0100" }, "message": "Cleanup BitMemoryReader/Writer api.\n\nTest: test-art-host-gtest-stack_map_test\nTest: test-art-host-gtest-bit_table_test\nChange-Id: I15c624d2a70736aeb8422ce5babcef8e8fa82136\n" }, { "commit": "a2d29a3a772f17014197e829aa8cb41026f88f05", "tree": "5fea3c3e18db733655c55fdd91175f9870b4ad35", "parents": [ "8e7ddc234ecbde21b0e6755cf66bcad858a817d2" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 03 11:06:38 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 03 16:00:00 2018 +0100" }, "message": "Add stack map fast path for GC.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Ia04a07b560fcce2fb955d66d1924ee224dec420d\n" }, { "commit": "e7a9194558379ee24fde82fcaeaee29542df1520", "tree": "30f3c43f2d64f159503bb8c3442aa39cc6cb612e", "parents": [ "f50419eee7290542db07bff23c4f65e693ba037f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 17:23:53 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Aug 03 12:48:49 2018 +0100" }, "message": "Simplify StackMapStream encoding.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Ife021d03e4e486043ec609f9af8673ace7bde497\n" }, { "commit": "3aaaa21055ab73562b8da7968ac4fa5fe9d44695", "tree": "a3118eee8f5cc9c661e1480f2ce73691c3786f8a", "parents": [ "605339045d347074b9149c0185fe2ca7fafe470d" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jul 30 16:46:53 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Aug 02 11:31:44 2018 +0100" }, "message": "Encode frame info using varints.\n\nThis saves 0.3% of oat file size.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I85003946a9579f03cb1ed2b5e9b2c62b3efe6734\n" }, { "commit": "8cd54547cec8a4537db5682c2da8be22843b1310", "tree": "fb1158993bab2e027984cedab59b402c051a45a7", "parents": [ "91f0fdb4372d3f2bcfcd9db67afcbe7ee1901048" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jul 15 23:58:44 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 14:49:40 2018 +0100" }, "message": "Move MethodInfo to CodeInfo.\n\nThere is no need to treat it specially any more,\nbecause of the de-duplication at BitTable level.\n\nThis saves 0.6% of oat file size.\n\nTest: test-art-host-gtest\nChange-Id: Ife7927d736243879a41d6f325d49ebf6930a63f6\n" }, { "commit": "b73323c50d10d3850d2d8719a481f4f430fc51ce", "tree": "b5c2eb181dd398229fb7b7e852923efd247e5710", "parents": [ "ca182f2c81e7102d3ccd1c4ec5c96e602ad343fe" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jul 15 23:58:44 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 12:41:36 2018 +0100" }, "message": "Deduplicate stackmaps at BitTable level.\n\nMake it possible to share BitTables between CodeInfos.\n\nThis saves 1% of .oat file size.\n\nTest: test-art-host-gtest\nChange-Id: I14172cba6b65e734b94f8c232f24eeee1fc67113\n" }, { "commit": "6ee06e97cef5ee92944deaeba0da4d10c4c33a2a", "tree": "77d69c85d37864b4d3ee970be4b7fd1246adee7b", "parents": [ "f5dcd31d89282b6c9324fdc960e6e7e2281c16f1" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 25 21:45:54 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 26 11:45:54 2018 +0100" }, "message": "Decode only the needed tables from CodeInfo.\n\nMost use cases need only the first two bit tables from CodeInfo.\nAdd flag to the decode method so that only those two are loaded.\nWe only touched the table header but that still made difference.\n\nThis speeds up pmd by over 10%.\n\nTest: test-art-host-gtest\nChange-Id: I7740081bf18205dd69864503b5bcec7de5e1a901\n" }, { "commit": "2c76257e4bfcd6f522b0cd3487ba7d9900043243", "tree": "ab1098cffcb3e13087e770d26fef9f4d6f06a550", "parents": [ "0b4a439f808f4602c7b97364e49c5546f5100d51" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 27 10:09:11 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jul 13 16:32:11 2018 +0100" }, "message": "Remove unused InvokeInfo from stack maps and the runtime.\n\nTest: test-art-host-gtest\nChange-Id: I5ce28973042f9241e72ceb52fc5db472ca571563\n" }, { "commit": "93bd3619de4616040d672a4ed3825976bed4bfce", "tree": "2ab3424374ed3d316053ed8e9ec2d4b95ea2ef4d", "parents": [ "f07d5617770c37d87447c8bddf105eb0469ab093" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jul 02 19:30:18 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 04 14:23:12 2018 +0100" }, "message": "Use iterators to access stack map data.\n\nTry to simplify the code using the recently added iterators.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I0b9f54df01749ee6ec3a67cfb07ba636a2489c89\n" }, { "commit": "a38e6cf2aaf4fd3d92b05c0a7a146fb5525ea72d", "tree": "377c74c834776b9942bb7c2853e44447dac27f83", "parents": [ "f6ba5b316b51d0fb9f91cb51a42e51dfeee62ee4" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jun 26 18:13:49 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 27 10:15:32 2018 +0100" }, "message": "Remove explicit size from CodeInfo.\n\nIt was mostly there since it was necessary to create the\nbound-checked MemoryRegion for loading.\n\nThe new BitMemoryReader interface is much easier to\ntweak to avoid needing to know the size ahead of time.\n\nKeep the CHECK that the loader reads the expected number\nof bytes, but move it to FillInCodeInfo.\n\nThis saves 0.2% of .oat file size.\n\nTest: test-art-host-gtest-stack_map_test\nTest: test-art-host-gtest-bit_table_test\nChange-Id: I92ee936e9fd004da61b90841aff9c9f2029fcfbf\n" }, { "commit": "f6ba5b316b51d0fb9f91cb51a42e51dfeee62ee4", "tree": "ac3b776ae3c20fc957949d06dd878ef3ffa6ffb5", "parents": [ "cca7cb9ffa56d8ab8fd0c5997c8bfd965d7426c1" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sat Jun 23 22:05:49 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jun 26 16:51:15 2018 +0100" }, "message": "Add method frame info to CodeInfo.\n\nThe stored information will be used in follow-up CLs.\n\nThis temporarily increases .oat file size by 0.7%.\n\nTest: test-art-host-gtest\nChange-Id: Ie7d898b06398ae44287bb1e8153861ab112a216c\n" }, { "commit": "cca7cb9ffa56d8ab8fd0c5997c8bfd965d7426c1", "tree": "c577edade71c41eb35bd349d63fa1bc097a3f493", "parents": [ "accb14cc7dac2443020fd44c9391c94673d78a4b", "a45a85c61acbcc4ca4046619b7a98635b32e7622" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jun 22 23:59:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 22 23:59:24 2018 +0000" }, "message": "Merge \"Ensure that BitTableAccessor refers to non-null table.\"" }, { "commit": "a45a85c61acbcc4ca4046619b7a98635b32e7622", "tree": "cb9b1047be9730f2bec9ef73157fec4c7a53161a", "parents": [ "0b4e5a3a1275a4aa6955a0576ab9d57eedd5bdd2" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 21 16:03:12 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jun 22 14:26:05 2018 +0100" }, "message": "Ensure that BitTableAccessor refers to non-null table.\n\nHopefully this should make clang analyzer happy.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I19c9048302dd47dd262842e0b58ed139f83fa1f6\n" }, { "commit": "078d7ba2c20d7778f8988e89a70d47e07372cc5a", "tree": "5f9340183de479241e8c043a0996aadc41583b5a", "parents": [ "0b4e5a3a1275a4aa6955a0576ab9d57eedd5bdd2" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 21 15:36:48 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jun 22 13:24:28 2018 +0100" }, "message": "Implement BitMemory{Reader,Writer}\n\nTwo simple classes which replace the need to pass\nthe (BitMemoryRegion, bit_offset) tuple everywhere.\n\nThe slightly simplifies the code and it also makes\nit possible to optimize those classes in the future.\n\nTest: test-art-host-gtest-stack_map_test\nTest: test-art-host-gtest-bit_table_test\nChange-Id: I4806c805149a07e1a11b76405ca27960a0012c69\n" }, { "commit": "0b4e5a3a1275a4aa6955a0576ab9d57eedd5bdd2", "tree": "da1f910ee6c4d38a535c59eca934c394d6fc7363", "parents": [ "c046a45aabc2a244ea2595692feb97238b568701" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jun 11 16:25:29 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 21 13:45:25 2018 +0100" }, "message": "Binary search stack maps by native pc.\n\nTest: test.py --host -r -b -t 018 -t 510\nChange-Id: I07042e8dfd82adcd24fdfe1a1970a7ccdc09ce46\n" }, { "commit": "cf7833edafa2dbf31ec7d29b51874dba6a92ae36", "tree": "47b80e86d17768fe2ca0744fe4a5ebff9f1449a6", "parents": [ "45b12e704e158f29877c78bd9a8406db7e361537" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 14 16:45:22 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 14 17:14:45 2018 +0100" }, "message": "Template BitTable based on the accessors.\n\nTest: test-art-host-gtest-stack_map_test\nTest: test-art-host-gtest-bit_table_test\nChange-Id: I96c04e21864009b64cb3177a0e9f0f8782a9b10b\n" }, { "commit": "45b12e704e158f29877c78bd9a8406db7e361537", "tree": "1bfc21d88a173b4a751a37a223a39d7c12976f95", "parents": [ "c9633c80c2125814a8a7459079c1931a5c201011", "e1402125e8363b49e176c6072893d1c110a05d2f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 14 13:37:36 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jun 14 13:37:36 2018 +0000" }, "message": "Merge \"Move some helper methods to DexRegisterLocation.\"" }, { "commit": "e1402125e8363b49e176c6072893d1c110a05d2f", "tree": "44ec055be78cdcb8086a598cbf791f8c4627e157", "parents": [ "86decb6a3e3ebba8c3c67bfd25c12d9a85794f65" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 13 18:20:45 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 14 12:31:44 2018 +0100" }, "message": "Move some helper methods to DexRegisterLocation.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I0abab008159db023d531df69214cd3bb8c0639bd\n" }, { "commit": "50fac06c51864f293c61ff9d0983b82698cf6dac", "tree": "7f7d09fa8aeacf4b5a255085af02970347a54cd0", "parents": [ "86decb6a3e3ebba8c3c67bfd25c12d9a85794f65" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 13 18:55:35 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 13 19:03:09 2018 +0100" }, "message": "Add Kind column to stack maps.\n\nAdd \u0027Kind\u0027 column to stack maps which marks special stack map types,\nand use it at run-time to add extra sanity checks.\n\nIt will also allow us to binary search the stack maps.\n\nThe column increases .oat file by 0.2%.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I2a9143afa0e32bb06174604ca81a64c41fed232f\n" }, { "commit": "86decb6a3e3ebba8c3c67bfd25c12d9a85794f65", "tree": "be8ca8fb1c7274292b5d794d08ce47df566927f7", "parents": [ "1e739fa94947147953c53e92964e0e9e1eac0526" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jun 05 06:41:10 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 13 12:29:32 2018 +0100" }, "message": "Rewrite stack map statistics printing in outdump.\n\nThe code was repetitive and had a tendency to get out of sync.\n\nTest: Check the output of oatdump\nChange-Id: Ied68a6c9add7ac234ede68d4adbc097bb8b82d6f\n" }, { "commit": "fd89b0739d4000ea70f28bf53dea531027024f5a", "tree": "1c9f3e1b046d60df405fb63f04cf83d3be4ff0f5", "parents": [ "6de8833fb64e59301eada4005ed04da995796170" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:22 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 07 12:00:18 2018 +0100" }, "message": "Remove unused GetDexRegisterMap arguments.\n\nThey are no longer needed in the new encoding.\n\nI reuse the local variables in most places to DCHECK the size\nof the decoded register map. This has one catch though:\nWe sometimes omit all dex registers, so the DCHECK should be\ndone only after checking if the map is empty (if applicable).\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I94b67029842374bc8eb7c9e5eac76fc93a651f24\n" }, { "commit": "6de8833fb64e59301eada4005ed04da995796170", "tree": "9f5b731ae1c0428cf5dcae4105936a7a165a43c9", "parents": [ "d97e0828958fd14a962e37af2865bc2e628547ce" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:11 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 07 12:00:18 2018 +0100" }, "message": "Delta-compress register maps in stack maps.\n\nThe register maps tend to be similar from stack map to stack map,\nso instead of encoding them again, store only the modified ones.\n\nThe dex register bitmap stores the delta now - if register has\nbeen modified since the previous stack map, the bit will be set.\n\nThe decoding logic scans backwards through stack maps until it\neventfully finds the most recent value of each register.\n\nThis CL saves ~2.5% of .oat file size (~10% of stackmap size).\n\nDue to the scan, this makes dex register decoding slower by factor\nof 2.5, but that still beats the old algorithm before refactoring.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Id5217a329eb757954e0c9447f38b05ec34118f84\n" }, { "commit": "d97e0828958fd14a962e37af2865bc2e628547ce", "tree": "bcb4ef65fee75cd64c222a2e3bfb44da6b60ebd5", "parents": [ "6e69e52a12883386f91d014324bebee867ca7877" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:24 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 06 13:14:04 2018 +0100" }, "message": "Reduce code repetition in stack maps with macros.\n\nSimplifies the code somewhat. It also makes it possible\nto get column names as strings for the debugging code.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I1a2e146e7a4372c0752693313e1b881cb4a818bc\n" }, { "commit": "6e69e52a12883386f91d014324bebee867ca7877", "tree": "7d1850f0a59e4ea2d013d6d479cd616b66922970", "parents": [ "6eb4d5e4bc2ce068004c1d7c85dbfff0c5efd11d" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:14 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jun 05 16:50:38 2018 +0100" }, "message": "Remove depth argument from InlineInfo accessors in stack maps.\n\nThe InlineInfo class actually represented a list of inlining\ninformation for a given stack map, and the depth argument was\nused everywhere to select to desired element from the list.\nThis was verbose and inconsistent with the other classes.\n\nChange the InlineInfo class to represent a single inlining,\nand select the desired depth when getting it from CodeInfo.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I35b73e6704854f0203f51d4dbdbed5b1d1cd5a3b\n" }, { "commit": "71ec1cc0665cdb9d39f4fd284d68962020417a53", "tree": "8d19b11ab3e04213c46b1b12ae94dbf54b305bfb", "parents": [ "03f16e4de1e3289414888fe0a5104205a781bd2f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri May 18 15:57:25 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jun 01 13:26:46 2018 +0100" }, "message": "Rewrite dex register map encoding in stackmaps.\n\nSimplify code by encoding dex register maps using BitTables.\nThe overall design is unchanged (bitmask+indices+catalogue).\n\nThis CL saves ~0.4% of .oat file size.\n\nThe dex register map decoding is factor of 3 faster now\n(based on the time to verify the register maps on Arm).\nThis is not too surprising as the old version was O(n^2).\n\nIt also reduces compiler arena memory usage by 11% since the\nBitTableBuilder is more memory efficient, we store less\nintermediate data, and we deduplicate most data on the fly.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Ib703a5ddf7f581280522d589e4a2bfebe53c26a9\n" }, { "commit": "d775f96090a588efbc837961434b10c57bcf189c", "tree": "ff3817dabd3f00450643b13e6b87bdb363fed5d7", "parents": [ "f5fc6bcdd98f50807756347ac19e8565bce3b6b5" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 18:12:52 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 22:52:01 2018 +0000" }, "message": "Ensure all PCs in stack_map_test are aligned.\n\nIt is invalid to try to encode improperly aligned PC.\n\nTest: test-art-target-gtest-stack_map_test\nChange-Id: I73e7b6225bfee87b0d6161298e19648ee6e1d499\n" }, { "commit": "21d45b4f4ef3661ac33d622aaac5dd6d2ce7deb8", "tree": "121e046a949025bca4d766fdfdc5ea58e4ea4a10", "parents": [ "d02b23f7ee9664213216a82bfdcb0ee83824de04" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 06:35:05 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 17:59:24 2018 +0100" }, "message": "Simplify DexRegisterMap API.\n\nStore some of the needed decoding state explicitly to avoid passing it\naround all the time. The DexRegisterMap class is rewritten in next CL.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Ie268dff2a1c1da2e08f0e6799ae51c30e11f350b\n" }, { "commit": "d02b23f7ee9664213216a82bfdcb0ee83824de04", "tree": "254b794533a6821c2ed2df31fab807abf7d508a4", "parents": [ "08231f6cb3095a7dbde29299a7da5413a5f992e4" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue May 29 23:27:22 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 17:59:24 2018 +0100" }, "message": "Remove the CodeOffset helper class.\n\nI need to reduce the StackMapEntry to a POD type so that it\ncan be used in BitTableBuilder.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I5f9ad7fdc9c9405f22669a11aea14f925ef06ef7\n" }, { "commit": "4b59d107f91601c4e0095d7a9db40970d4ed6956", "tree": "b120add4870b86cefc308ec3a0100851cfc1a4c0", "parents": [ "da4ff8bfcf03d6186b7d21c7bd8b90248f7b2f96" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue May 29 21:46:10 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 14:32:44 2018 +0100" }, "message": "Revert^2 \"Optimize register mask and stack mask in stack maps.\"\n\nThis reverts commit 8b20b5c1f5b454b2f8b8bff492c88724b5002600.\n\nReason for revert: Retry submit unmodified after fixing the test.\n\nUse BitTable to store the masks as well and move the\ndeduplication responsibility to the BitTable builders.\n\nDon\u0027t generate entries for masks which are all zeros.\nThis saves 0.2% of .oat file size on both Arm64 and Arm.\n\nEncode registers as (value+shift) due to tailing zeros.\nThis saves 1.0% of .oat file size on Arm64 and 0.2% on Arm.\n\nTest: test-art-target-gtest-exception_test\nTest: test-art-host-gtest-bit_table_test\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Ib643776dbec3f051cc29cd13ff39e453fab5fae9\n" }, { "commit": "8b20b5c1f5b454b2f8b8bff492c88724b5002600", "tree": "51bea8ddfff23b1f6b0323eaeacf42e6f6199015", "parents": [ "ffaf87a429766ed80e6afee5bebea93db539620b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 15:32:55 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 15:32:55 2018 +0000" }, "message": "Revert \"Optimize register mask and stack mask in stack maps.\"\n\nThis reverts commit ffaf87a429766ed80e6afee5bebea93db539620b.\n\nReason for revert: Breaks exception_test32 on target\nfor CMS and heap poisoning configs.\n\nChange-Id: I127c17f693e28211a799f73a50e73105edee7e4c\n" }, { "commit": "ffaf87a429766ed80e6afee5bebea93db539620b", "tree": "d79637f4b6a564facf4b837c3ff125bb3755594e", "parents": [ "5513c2b68a08109a5bfd811c7b2c8bbc66244e8e" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 23 14:44:39 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 28 08:45:37 2018 +0100" }, "message": "Optimize register mask and stack mask in stack maps.\n\nUse BitTable to store the masks as well and move the\ndeduplication responsibility to the BitTable builders.\n\nDon\u0027t generate entries for masks which are all zeros.\nThis saves 0.2% of .oat file size on both Arm64 and Arm.\n\nEncode registers as (value+shift) due to tailing zeros.\nThis saves 1.0% of .oat file size on Arm64 and 0.2% on Arm.\n\nTest: test-art-host-gtest\nChange-Id: I636b7edd49e10e8afc9f2aa385b5980f7ee0e1f1\n" }, { "commit": "052f8ca1776ed7deb4f036498edd69eb6a1b942f", "tree": "ae993f1a634b258e124df12663a1d24859917b05", "parents": [ "1c515f0b9d621869a2e67ce5e0f5532d0f2f323a" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Apr 26 15:42:54 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 21 20:28:41 2018 +0100" }, "message": "Rewrite stackmap encoding code.\n\nRemove most of the code related to handling of bit encodings.\nThe design is still same; the encodings are just more implicit.\nMost of the complexity is replaced with a single BitTable class,\nwhich is a generic purpose table of tightly bit-packed integers.\nIt has its own header which stores the bit-encoding of columns,\nand that removes the need to handle the encodings explicitly.\n\nOther classes, like StackMap, are accessors into the BitTable,\nwith named getter methods for the individual columns.\n\nThis CL saves ~1% of .oat file size (~4% of stackmap size).\n\nTest: test-art-host-gtest\nChange-Id: I7e92683753b0cc376300e3b23d892feac3670890\n" }, { "commit": "518fcc50fa47532889f597aa8c9da85f3966c947", "tree": "c84f950ba22d1b9a7d0383628dc9fc249dcfecf3", "parents": [ "f6049755305a29bd3ef6dd40d70c2ab3da0670e6", "b674a1435c552e26dbd81aa77c22f4db454f0006" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon May 21 12:12:28 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon May 21 12:12:28 2018 +0000" }, "message": "Merge \"Revert^2 \"Move kVRegSize to globals.h to reduce include dependencies.\"\"" }, { "commit": "b674a1435c552e26dbd81aa77c22f4db454f0006", "tree": "09223362714ffd32c6de9ca3d761259217aed207", "parents": [ "a9d5ccdf887ef5c9f61481f036773bdfadd39fd7" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 21 10:27:06 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 21 10:45:58 2018 +0000" }, "message": "Revert^2 \"Move kVRegSize to globals.h to reduce include dependencies.\"\n\nThis crashed the linker before. I will try again.\n\nThis reverts commit a9d5ccdf887ef5c9f61481f036773bdfadd39fd7.\n\nChange-Id: Ic204f9564a1fba97fcbf29cb4dc5ade25a9ce864\n" }, { "commit": "68fefacc54b9d918a5b17b99ac7e72421d1b1f94", "tree": "39cccda109a63153ca363e592b5570b46e6dece9", "parents": [ "b2683cb0ae69c9a8a0ba654f50fa743a9117171c" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu May 10 17:49:33 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 21 09:28:22 2018 +0000" }, "message": "Move and rewrite bit loading/storing methods.\n\nMove bit loading/storing methods to BitMemoryRegion and rewrite them.\n\nEnforce natural alignment of the data pointer in BitMemoryRegion.\nThis probably would not be reasonable in MemoryRegion, but it is\nfine here since the BitMemoryRegion already has extra bit offset.\nThe alignment makes it possible to simplify and optimize the methods.\n\nThis makes the stackmap reading code 33% faster.\n(measured by the time needed to verify all stackmap fields on ARM).\n\nTest: m -j40 test-art-host-gtest\nChange-Id: I00be8052969a6056b262df4cd2066ffd86043196\n" }, { "commit": "a9d5ccdf887ef5c9f61481f036773bdfadd39fd7", "tree": "07fd0c81d1dfde82c2b3b476c2ccf3758b6cae4b", "parents": [ "5ae7cdfe5b8da645d1fec61c76176e6a37e78fb9" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 14 11:55:51 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 14 11:56:30 2018 +0000" }, "message": "Revert \"Move kVRegSize to globals.h to reduce include dependencies.\"\n\nThis reverts commit 5ae7cdfe5b8da645d1fec61c76176e6a37e78fb9.\n\nReason for revert: Unknown crash in linker\n\nChange-Id: Ib5646376e2e589a7a6c4d66e72caa1f208a15905\n" }, { "commit": "5ae7cdfe5b8da645d1fec61c76176e6a37e78fb9", "tree": "c9b1b0f3963e5cf2b370c45bed9ad448dd814fb0", "parents": [ "e1b445b112ec83fea9b1760cdfe6d0e185607b0d" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 09 18:42:12 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri May 11 16:00:08 2018 +0100" }, "message": "Move kVRegSize to globals.h to reduce include dependencies.\n\nTest: m test-art-host-gtest\nChange-Id: I26146535f2684ddab3554023f7df571d93a39f88\n" }, { "commit": "1ce2b3b76d121a765212d69399241843951973ae", "tree": "6f2bb0191c869e79891df3151d6faba3a297b9a8", "parents": [ "281c99864f635ef4fd005dba4ba0c750cb9a6143" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 05 11:02:03 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 05 11:07:59 2018 -0700" }, "message": "Move remaining runtime/base stuff to libartbase\n\nMove the remainder of the Arena stuff, plus dumpable and\nruntime/*memory_region* to libartbase. More preparation to build\nprofiling library.\n\nBug: 22322814\nTest: make -j 50 checkbuild\nChange-Id: Iaf26d310c89bc58846553281576c18102f5e4122\n" }, { "commit": "67bf42e89592c3a1c648f927f2ce3ccb189a1161", "tree": "054d5b7adf7cc62d4d2a2118a70c0fbdd1751610", "parents": [ "d961043ff1dd6fddb68aa90c1f939cfafec24219" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 26 16:43:04 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 28 15:08:21 2018 -0800" }, "message": "Header library to remove dependence on runtime/\n\nAdd a new header library to remove libdexfile and others\u0027 dependence on\nruntime (typically runtime/base) includes in libdexfile. Also a small step\nto tease dexlayout and profman away from relying on these as well.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n\nChange-Id: I38e2fe399a75f4bc6318c77a71954c00ea73ec2b\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "92f7f3ce3b01f7c7df1c15b81c900e087248093f", "tree": "37647ac824e450f80d752539cabbe631ba795c75", "parents": [ "5dcb0d2cabe9d67987a6a7477fb124cef92abefb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 31 11:38:30 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 15 14:29:52 2017 +0000" }, "message": "Use intrinsic codegen for compiling intrinsic methods.\n\nWhen compiling an intrinsic method, generate a graph that\ninvokes the same method and try to compile it. If the call\nis actually intrinsified (or simplified to other HIR) and\nyields a leaf method, use the result of this compilation\nattempt, otherwise compile the actual code or JNI stub.\n\nNote that CodeGenerator::CreateThrowingSlowPathLocations()\nactually marks the locations as kNoCall if the throw is not\nin a catch block, thus considering some throwing methods\n(for example, String.charAt()) as leaf methods.\n\nWe would ideally want to use the intrinsic codegen for all\nintrinsics that do not generate a slow-path call to the\ndefault implementation. Relying on the leaf method is\nsuboptimal as we\u0027re missing out on methods that do other\ntypes of calls, for example runtime calls. This shall be\nfixed in a subsequent CL.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 67717501\nChange-Id: I640fda7c22d4ff494b5ff77ebec3b7f5f75af652\n" }, { "commit": "04c6ab9266876137c9b46b69391aa2820cd56600", "tree": "1580e08b7a8e73197c64b499540ec613b755a6e1", "parents": [ "e2abbc604ce003c776c00ecf1293796bb4c4ac5a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 21:49:14 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 18 11:36:24 2017 -0700" }, "message": "ART: Forward declarations for InvokeType\n\nUse forward declarations in other header files.\n\nTest: m\nChange-Id: I8ef4492b6c48ff20d4d77d0516eacd362ed210bc\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "69489fad1e34c005fbe110bfae2a3c6bff879d4e", "tree": "23c50305c52cf076cedd3bfd496a2adf0d1e46b3", "parents": [ "8979f71079ec18fa8d3c0915549ec03ee1fbadf5" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 18:03:25 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 21 21:30:59 2017 -0700" }, "message": "ART: Fix old warnings\n\nFix Wconstant-conversion warnings.\n\nPartially reverts commit df53be273509dd43725870fb20a2c7d71f7fbfd3.\n\nBug: 28149048\nBug: 29823425\nTest: m\nTest: m test-art-host\nChange-Id: Ib377150690c0f2c2142e4b91f2144e2bcaa020ef\n" }, { "commit": "d9911eeca13f609c885e0f6a5ce81af9b6340bfa", "tree": "f850510643ee120dba140bf0bb3e1c1b9c9ce4db", "parents": [ "46bfb7c047a590ac5c24b658f31c170631556bb6" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 27 13:27:24 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 27 13:53:48 2017 -0700" }, "message": "ART: Clean up field initialization\n\nAdd explicit field initialization to default value where necessary.\nAlso clean up interpreter intrinsics header.\n\nTest: m\nChange-Id: I7a850ac30dcccfb523a5569fb8400b9ac892c8e5\n" }, { "commit": "cbcedbf9382bc773713cd3552ed96f417bf1daeb", "tree": "58eed766a69ddddbc41d21624244e14547fa1dff", "parents": [ "ef62210a1466c133056c4bfdae9f8f5417065eff" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Mar 12 22:24:50 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 16 10:20:34 2017 -0700" }, "message": "Add method info to oat files\n\nThe method info data is stored separately from the code info to\nreduce oat size by improving deduplication of stack maps.\n\nTo reduce code size, this moves the invoke info and inline info\nmethod indices to this table.\n\nOat size for a large app (arm64): 77746816 -\u003e 74023552 (-4.8%)\nAverage oat size reduction for golem (arm64): 2%\n\nRepurposed unused SrcMapElem deduping to be for MethodInfo.\nTODO: Delete SrcMapElem in a follow up CL.\n\nBug: 36124906\n\nTest: clean-oat-host \u0026\u0026 test-art-host-run-test\n\nChange-Id: I2241362e728389030b959f42161ce817cf6e2009\n" }, { "commit": "01b47b046b01ec68696f8ff61b5326cdd3af348e", "tree": "e526306fc89bf6fb04ff914e24343dde0369e98c", "parents": [ "dcab11d06860ae1e23d03926adb6c31f75404032" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Fri Feb 03 12:09:57 2017 -0800" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Wed Mar 08 10:15:06 2017 -0800" }, "message": "Inlining a few small methods based on profiling dex2oat with perf.\n\nTest: m test-art-host\nChange-Id: I6313158e59592d8d132154523be9c82dda3c7eb8\n" }, { "commit": "d776ff08e07494327716f0d2ea1a774b2ebfbca9", "tree": "cedf874dd494d881adc572a10a9d14bca852add6", "parents": [ "3fb852a88d2a8ffaa87089752f4b1d5f9d6ce3c1" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 17 09:32:18 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 15 14:46:15 2017 -0800" }, "message": "Add invoke infos to stack maps\n\nInvoke info records the invoke type and dex method index for invokes\nthat may reach artQuickResolutionTrampoline. Having this information\nrecorded allows the runtime to avoid reading the dex code and pulling\nin extra pages.\n\nCode size increase for a large app:\n93886360 -\u003e 95811480 (2.05% increase)\n\n1/2 of the code size increase is from making less stack maps deduped.\nI suspect there is less deduping because of the invoke info method\nindex.\n\nMerged disabled until we measure the RAM savings.\n\nTest: test-art-host, N6P boots\n\nBug: 34109702\n\nChange-Id: I6c5e4a60675a1d7c76dee0561a12909e4ab6d5d9\n" }, { "commit": "c420a805fbc0207888a2fa04b4e9a17490621cc3", "tree": "c2f2e1f7b574e3de0c5dc7d4d44bcffd0b96a4bb", "parents": [ "aff5505d85612621bd112d9af1ba4cc31a4619d1" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 14 15:16:19 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 14 15:36:39 2017 -0800" }, "message": "Address some comments for aog/333864\n\nMostly comment changes.\n\nBug: 34621054\n\nTest: test-art-host\n\nChange-Id: I95f77651d47a8d0c71d580778d1126ab4aa1d751\n" }, { "commit": "575d3e60c68b5cf481b615dde4a16283507b19ed", "tree": "4718f2747233e74268de21d804df9bfe0b7e4362", "parents": [ "857acf51fbc5a931939c20e9e299c69676baf654" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 06 11:00:40 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 08 09:51:27 2017 -0800" }, "message": "Clean up code info table layout\n\nPreviously:\nTable layout was computed multiple places like stack_map_stream,\nand getters. This made it difficult to add new stack map tables and\nmade the code hard to understand.\n\nThis change makes the table layout specified all inside of the code\ninfo. Updating the layout only requires changing ComputeTableOffsets.\n\nChanged the stack map inline info offset to be an index, so that it is\nnot require the inline infos are directly after the dex register table.\n\nOat file size for a large app: 94459576 -\u003e 93882040 (-0.61%)\n\nUpdated oatdump and fixed a bug that was incorrectly computing the\nregister mask bytes.\n\nBug: 34621054\n\nTest: test-art-host\n\nChange-Id: I3a7f141e09d5a18bce2bc6c9439835244a22016e\n" }, { "commit": "1a20b6801f2432a42b906f0de01e7e9586526aec", "tree": "ae3faaf42a2b560601fc024ae16898a5dfa42261", "parents": [ "357dcb73934356239292c46d6fbedba734da5e00" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 31 14:25:16 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 01 12:46:43 2017 -0800" }, "message": "Deduplicate register masks\n\nData is commonly shared between different stack maps. The register\nmasks are stored after the stack masks.\n\nOat size for a large app:\n96722288 -\u003e 94485872 (-2.31%)\n\nAverage oat size reduction according to golem -3.193%.\n\nBug: 34621054\n\nTest: test-art-host\n\nChange-Id: I5eacf668992e866d11ddba0c01675038a16cdfb4\n" }, { "commit": "45aa598cd1773f5eb1705dec13bea059238e054d", "tree": "f5a6fd7445a74218547cd6c4e28dc835821c355e", "parents": [ "f2042db1b41cc21cc540c5ad7d353cbe1e3a32df" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Mar 18 02:15:09 2016 +0000" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 31 10:15:26 2017 -0800" }, "message": "Deduplicate stack masks\n\nThe stack masks repeat often enough so that it is worth deduplicating\nthem.\n\nOat size for a large app:\n98143600 -\u003e 96722288 (-1.44%)\n\nBug: 34621054\n\nTest: test-art-host\nChange-Id: If73d51e46066357049d5be2e406ae9a32b7ff1f4\n" }, { "commit": "12f1b99775bbf7dd82d0a897587ab6ed0e75ee22", "tree": "f8cb3a7334652e59577b7ff97a1805d1bf4ddd94", "parents": [ "d8f6e6430b26bf199f4a52f0624becb7c29f3c19" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 19 18:00:45 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 27 10:04:05 2017 -0800" }, "message": "Remove alignment bits in between stack maps\n\nSaves 0.65% of boot.oat size, probably similar on apps. Added\nBitMemoryRegion to avoid requiring adding state to StackMap. Added\ntest to memory_region_test.\n\nTest: clean-oat-host \u0026\u0026 test-art-host\n\nBug: 34621054\n\nChange-Id: I40279c59e262bd5e3c6a9135f83e22b5b6900d68\n" }, { "commit": "3ceedc0c3e89e5a1bb44ac9bb0eb1ea2e8f4675a", "tree": "80cdb6ff5c1fe8370d4b6ca5bca4035350f3803b", "parents": [ "f34077c96af3389e8eae65252d4c5d51cf630039" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jan 25 11:11:02 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jan 25 11:37:27 2017 -0800" }, "message": "Refactor and optimize memory region bit functions\n\nMove optimized bit reading from FieldEncoding to MemoryRegion,\nadded optimized StoreBits to MemoryRegion.\n\nCompilation of a large app on host:\nBefore:\nTime -j1: 31.897s\n2.00% art::MemoryRegion::StoreBits(unsigned long, unsigned int, unsigned long)\n\nAfter:\nTime -j1: 29.620s\n0.39% art::MemoryRegion::StoreBits(unsigned long, unsigned int, unsigned long)\n\nBug: 34621054\n\nTest: test-art-host\n\nChange-Id: I0509613da83cc5741d5cfada3f8a8af503784e9e\n" }, { "commit": "5e7c6a9223ddd11f800ea9b26fa72bece5c7d26c", "tree": "3f34f313b7b7a97eddda4ebab1e2f8c38864c3ff", "parents": [ "c51842b8dd2ad57a1b05f31ab20ad01123443c50" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 17 16:38:30 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jan 23 15:13:10 2017 -0800" }, "message": "Add more code info size dumping to oatdump\n\nHelps break down where oat bytes are being used, example output on\na large app:\n\nOAT FILE STATS:\nDumping cumulative use of 95784720 accounted bytes\nCode \u003d 68894196 (72% of total)\nQuickMethodHeader \u003d 3071080 ( 3% of total)\nCodeInfoEncoding \u003d 1226080 ( 1% of total)\nCodeInfoLocationCatalog \u003d 1005716 ( 1% of total)\nCodeInfoDexRegisterMap \u003d 5813389 ( 6% of total)\nCodeInfoInlineInfo \u003d 2391251 ( 2% of total)\nCodeInfoStackMap \u003d 13383008 (14% of total)\n StackMapNativePc \u003d 1607888 (12% of stack map)\n StackMapDexPcEncoding \u003d 1116724 ( 8% of stack map)\n StackMapDexRegisterMap \u003d 1277680 (10% of stack map)\n StackMapInlineInfo \u003d 1082720 ( 8% of stack map)\n StackMapRegisterMaskEncoding \u003d 5104960 (38% of stack map)\n StackMapMask \u003d 3193034 (24% of stack map)\n StackMapOther \u003d 0 ( 0% of stack map)\n\nTest: test-art-host, oatdump\n\nBug: 34621054\n\nChange-Id: I5daf0f1308d126b6a30928f523c6051585f1491f\n" }, { "commit": "a2f526f889be06f96ea59624c9dfb1223b3839f3", "tree": "769f517e6664de0e89abeadf07a39d5410fcee42", "parents": [ "64e50021845b1ad9d8851596e8aaddf18be217c2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 19 14:48:48 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 20 15:47:06 2017 -0800" }, "message": "Compressed native PC for stack maps\n\nCompress native PC based on instruction alignment. This reduces the\nsize of stack maps, boot.oat is 0.4% smaller for arm64.\n\nTest: test-art-host, test-art-target, N6P booting\n\nChange-Id: I2b70eecabda88b06fa80a85688fd992070d54278\n" }, { "commit": "ccfa88550333980efd5991602c9557b363474a39", "tree": "993d9baa85c04fac5df8a252efe1c36d301e2fa5", "parents": [ "a7e64f00df89dfd984a8798548af46c7d0657511" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Wed Jan 18 14:51:59 2017 -0800" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Wed Jan 18 17:02:39 2017 -0800" }, "message": "Always inline some methods related to StackMap.\n\nThis significantly speeds up stack walking on Pmd in Dacapo (10-30%).\n\nTest: test-art-host\nChange-Id: I79513b0b3d611e591c44e252062abf6a4f902797\n" }, { "commit": "5d37c152f21a0807459c6f53bc25e2d84f56d259", "tree": "7d8cbce0a55f258150a047def70244f79afc866d", "parents": [ "aa89a4c6fca095904521842c018399f1e3501a45" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 12 13:25:19 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 16 22:56:56 2017 +0000" }, "message": "Put inlined ArtMethod pointer in stack maps.\n\nCurrently done for JIT. Can be extended for AOT and inlined boot\nimage methods.\n\nAlso refactor the lookup of a inlined method at runtime to not\nrely on the dex cache, but look at the class loader tables.\n\nbug: 30933338\ntest: test-art-host, test-art-target\nChange-Id: I58bd4d763b82ab8ca3023742835ac388671d1794\n" }, { "commit": "01c78147d3e2f6eedba8b13dbfc46dc4ed61cb5d", "tree": "be1050f692a7fccdbbcfc86dc28749fdb82e2bf2", "parents": [ "001cd47ddd81e5bdd6cc2051beced4799124315a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 05 10:17:55 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 05 14:08:18 2017 -0800" }, "message": "Add some code info checking in GetCalleeSaveMethodCaller\n\nWill print info if the memory region is too small for the stack maps.\n\nTest: test-art-host\n\nBug: 33924573\n\nChange-Id: I03e0151724d3a0933f3bef004e0d16ba1c6134c4\n" }, { "commit": "7cbd27fe778f2c348136540d52b5473e28f5769d", "tree": "80c0fa4ff2a223c061245c6799d992cd4d863fa0", "parents": [ "3d1d18d74dfac5039b6093ddf04f74eee4f157a3" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Aug 11 23:53:33 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 12 13:19:51 2016 +0100" }, "message": "Adjust spacing before NOLINT comments in ART.\n\nNote that neither clang-tidy nor cpplint.py complain about\nthese style \"issues\", precisely because of the NOLINT\ncomments.\n\nTest: WITH_TIDY\u003d1 WITH_TIDY_CHECKS\u003d\u0027-*,misc-macro-parentheses\u0027 mmma art\nChange-Id: Id692fd394ffbd4fe208cbbe4407b4d5e208462bb\n" }, { "commit": "87f3fcbd0db352157fc59148e94647ef21b73bce", "tree": "5bdeabb246f5de86704333b3fcbccc6e9146d246", "parents": [ "b94b5706f0b8e2e1c7e1db22274f9f4bae0c4b5a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Apr 28 15:52:11 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 21 15:17:38 2016 +0100" }, "message": "Replace String.charAt() with HIR.\n\nReplace String.charAt() with HArrayLength, HBoundsCheck and\nHArrayGet. This allows GVN on the HArrayLength and BCE on\nthe HBoundsCheck as well as using the infrastructure for\nHArrayGet, i.e. better handling of constant indexes than\nthe old intrinsic and using the HArm64IntermediateAddress.\n\nBug: 28330359\nChange-Id: I32bf1da7eeafe82537a60416abf6ac412baa80dc\n" }, { "commit": "61b28a17d9b6e8e998103646e98e4a9772e11927", "tree": "438c4a73f72423ddc71e6dca9f082d9e1d533996", "parents": [ "cf0f8560f41467331427418584687830932e66ed" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 25 21:55:03 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Apr 01 17:01:55 2016 +0100" }, "message": "Use bit-level packing for InlineInfo in stackmaps as well.\n\nUse the same approach as we do for stackmaps to reduce the size.\n\nIt saves 4.0 MB from non-debuggable boot.oat (AOSP).\nIt does not affect debuggable boot.oat.\n\nIt saves 3.6 MB (of 96.6 MB) from /system/framework/arm/ (GOOG).\nIt saves 0.6 MB (of 26.7 MB) from /system/framework/oat/arm/ (GOOG).\n\nField loads from inline-info get around 5% slower.\n(based on the time it takes to load all inline-infos from boot.oat)\n\nChange-Id: I67b0fa5eef74c1fdb013680d0231fd44ea696176\n" }, { "commit": "09ed09866da6d8c7448ef297c148bfa577a247c2", "tree": "dad6a5dae6ca6131f1eba201eaa371edc6d9929d", "parents": [ "e28ad4b91591c226ed404a2b01104bb99bfeb28f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Feb 12 21:58:43 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Mar 31 22:12:07 2016 +0100" }, "message": "Pack stack map entries on bit level to save space.\n\nUse only the minimum number of bits required to store stack map data.\nFor example, if native_pc needs 5 bits and dex_pc needs 3 bits, they\nwill share the first byte of the stack map entry.\n\nThe header is changed to store bit offsets of the fields rather than\nbyte sizes. Offsets also make it easier to access later fields without\ncalculating sum of all previous sizes.\n\nAll of the header fields are byte sized or encoded as ULEB128 instead\nof the previous fixed size encoding. This shrinks it by about half.\n\nIt saves 3.6 MB from non-debuggable boot.oat (AOSP).\nIt saves 3.1 MB from debuggable boot.oat (AOSP).\n\nIt saves 2.8 MB (of 99.4 MB) from /system/framework/arm/ (GOOG).\nIt saves 1.0 MB (of 27.8 MB) from /system/framework/oat/arm/ (GOOG).\n\nField loads from stackmaps seem to get around 10% faster.\n(based on the time it takes to load all stackmap entries from boot.oat)\n\nBug: 27640410\nChange-Id: I8bf0996b4eb24300c1b0dfc6e9d99fe85d04a1b7\n" }, { "commit": "7dc11782ff0a5dffcd8108f256f8975f0b3e8076", "tree": "c3f6463fb378775d9b348f8fcfccfcdb410cfcc2", "parents": [ "99da8cd8818e015b21d1c2af73ac40749698c930" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 25 13:23:56 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 25 14:07:27 2016 +0000" }, "message": "Implement \u003c\u003c operator for DexRegisterLocation::Kind.\n\nThis makes it comparable in DCHECK_EQ and similar methods.\n\nChange-Id: I6b5b237be89325850ae6860d011fd6741189ab01\n" }, { "commit": "b331febbab8e916680faba722cc84b66b84218a3", "tree": "35f985b021e476914bfe91492da23fee218014a7", "parents": [ "586996afc905518ed926e4680aab67bedabec9b7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 16:51:53 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 17:11:54 2016 +0000" }, "message": "Revert \"Revert \"Implement on-stack replacement for arm/arm64/x86/x86_64.\"\"\n\nThis reverts commit bd89a5c556324062b7d841843b039392e84cfaf4.\n\nChange-Id: I08d190431520baa7fcec8fbdb444519f25ac8d44\n" }, { "commit": "a83c6758b714e096a9de0851dc788757abbdab68", "tree": "17d02f87a6870b52cb1fab0eb2a277184955df01", "parents": [ "6d6d36823d940362e02cdd26a59c9d4b7a68ea2c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 14 13:08:12 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 14 13:08:12 2016 +0000" }, "message": "Fix lint error.\n\nChange-Id: I8584d243a1cf55170e1d7bc1570e4ad1218fde5f\n" }, { "commit": "012fc4e9d9b66b3ffb7838b0e29dadbb4863ee69", "tree": "abba308e56a3d81e5c3fceebc95fb37a0ffe9c7c", "parents": [ "5ee288c9dd99614e3a238f5efceeec6456e3499d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 08 15:58:19 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 08 17:14:17 2016 +0000" }, "message": "Don\u0027t encode a DexRegisterMap if there is no live register.\n\nChange-Id: I76a291e6a0ac37f0590d16c7f5b866115588bc55\n" }, { "commit": "77a48ae01bbc5b05ca009cf09e2fcb53e4c8ff23", "tree": "780c7d6bdee784c2f8248979de348491cfb63b34", "parents": [ "659562aaf133c41b8d90ec9216c07646f0f14362" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Sep 15 12:34:04 2015 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Sep 15 12:34:04 2015 +0000" }, "message": "Revert \"Revert \"ART: Register allocation and runtime support for try/catch\"\"\n\nThe original CL triggered b/24084144 which has been fixed\nby Ib72e12a018437c404e82f7ad414554c66a4c6f8c.\n\nThis reverts commit 659562aaf133c41b8d90ec9216c07646f0f14362.\n\nChange-Id: Id8980436172457d0fcb276349c4405f7c4110a55\n" }, { "commit": "659562aaf133c41b8d90ec9216c07646f0f14362", "tree": "be1beae390262bf2f5a17bfa44de93081a849d07", "parents": [ "b022fa1300e6d78639b3b910af0cf85c43df44bb" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Sep 14 21:26:33 2015 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Sep 14 21:26:33 2015 +0000" }, "message": "Revert \"ART: Register allocation and runtime support for try/catch\"\n\nBreaks libcore test org.apache.harmony.security.tests.java.security.KeyStorePrivateKeyEntryTest#testGetCertificateChain. Need to investigate.\n\nThis reverts commit b022fa1300e6d78639b3b910af0cf85c43df44bb.\n\nChange-Id: Ib24d3a80064d963d273e557a93469c95f37b1f6f\n" }, { "commit": "b022fa1300e6d78639b3b910af0cf85c43df44bb", "tree": "780c7d6bdee784c2f8248979de348491cfb63b34", "parents": [ "e481c006e8b055a31d9c7cff27f4145e57e3c113" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Aug 20 17:47:48 2015 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Sep 14 20:42:58 2015 +0100" }, "message": "ART: Register allocation and runtime support for try/catch\n\nThis patch completes a series of CLs that add support for try/catch\nin the Optimizing compiler. With it, Optimizing can compile all\nmethods containing try/catch, provided they don\u0027t contain catch loops.\nFuture work will focus on improving performance of the generated code.\n\nSsaLivenessAnalysis was updated to propagate liveness information of\ninstructions live at catch blocks, and to keep location information on\ninstructions which may be caught by catch phis.\n\nRegisterAllocator was extended to spill values used after catch, and\nto allocate spill slots for catch phis. Catch phis generated for the\nsame vreg share a spill slot as the raw value must be the same.\n\nLocation builders and slow paths were updated to reflect the fact that\nthrowing an exception may not lead to escaping the method.\n\nInstruction code generators are forbidden from using of implicit null\nchecks in try blocks as live registers need to be saved before handing\nover to the runtime.\n\nCodeGenerator emits a stack map for each catch block, storing locations\nof catch phis. CodeInfo and StackMapStream recognize this new type of\nstack map and store them separate from other stack maps to avoid dex_pc\nconflicts.\n\nAfter having found the target catch block to deliver an exception to,\nQuickExceptionHandler looks up the dex register maps at the throwing\ninstruction and the catch block and copies the values over to their\nrespective locations.\n\nThe runtime-support approach was selected because it allows for the\nbest performance in the normal control-flow path, since no propagation\nof catch phi values is necessary until the exception is thrown. In\naddition, it also greatly simplifies the register allocation phase.\n\nConstantHoisting was removed from LICMTest because it instantiated\n(now abstract) HConstant and was bogus anyway (constants are always in\nthe entry block).\n\nChange-Id: Ie31038ad8e3ee0c13a5bbbbaf5f0b3e532310e4e\n" }, { "commit": "d9cb68e3212d31d61445fb7e8446f68991720009", "tree": "8738656ba16c292c1f1fd022337817c58ded2136", "parents": [ "9dc601eb65da0cd5f53172699dacd6e5dd38ab44" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Aug 25 13:52:43 2015 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Aug 25 17:35:16 2015 +0100" }, "message": "ART: Add (Fpu)RegHigh stack map location kinds\n\nWhen running Optimized code on 64-bit, high value of vreg pair may be\nstored in the high 32 bits of a CPU register. This is not reflected in\nstack maps which would encode both the low and high vreg as\nkInRegister with the same register number, making it indistinguishable\nfrom two non-wide vregs with the same value in the lower 32 bits.\n\nDeoptimization deals with this by running the verifier and thus\nobtaining vreg pair information, but this would be too slow for try/\ncatch. This patch therefore adds two new stack map location kinds:\nkInRegisterHigh and kInFpuRegisterHigh to differentiate between the\ntwo cases.\n\nNote that this also applies to floating-point registers on x86.\n\nChange-Id: I15092323e56a661673e77bee1f0fca4261374732\n" }, { "commit": "1c1da4398cca9a828dea885ca1be12adf961d3a3", "tree": "130af3bb745bc74a9398c2ac482968bf734f9993", "parents": [ "d780c00e554c5b00fc1acf359e4b9c7e761ea0eb" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jul 16 11:54:44 2015 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jul 16 11:54:44 2015 +0100" }, "message": "Improve documentation of memory layouts in stack_map.h.\n\nAlso shorten NumberOfDexRegisterLocationCatalogEntries to\nNumberOfLocationCatalogEntries.\n\nChange-Id: I55f8ec2960ea67e2eb6871a417bd442d0e2810fb\n" }, { "commit": "d780c00e554c5b00fc1acf359e4b9c7e761ea0eb", "tree": "08d8e6fbdcdc5876481824777f640d4548758859", "parents": [ "5c03f3698f5e2e0d762e2e15ec00310b6cdab4fe" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Jul 15 14:30:26 2015 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Jul 15 17:48:57 2015 +0100" }, "message": "Use art::MemoryRegion::{Load,Store}Bits more in art::CodeInfo.\n\nChange-Id: Id50fc029e83bf2c16bd991ea82acd3b355c29127\n" }, { "commit": "8f1e08af6172781f91a17fce0a5a4183a9f70aa9", "tree": "1481075eefed359fcb675379197290b53159e28e", "parents": [ "404ea410c5c1566909ae741582046b7cae2bd681" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 26 12:06:30 2015 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jul 13 13:30:13 2015 +0100" }, "message": "ART: Don\u0027t nest indenters in oatdump.\n\nReduces the time taken by the oatdump_test by ~12s (15%)\non host and ~55s (9%) on N5.\n\nChange-Id: I99bb16ff5f3640389815f1fe54379ca64eac071b\n" }, { "commit": "f677ebfd832c9c614fea5e6735725fec2f7a3f2a", "tree": "051b3ba6343bdbca4929d728dd5c0341e4383a08", "parents": [ "c47908e8c32fd58bc4dc75998a80f706954db1dc" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Fri May 29 16:29:43 2015 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Jun 04 17:25:02 2015 +0100" }, "message": "Cache stack map encoding\n\nOperations on CodeInfo and StackMap objects repeatedly read encoding\ninformation from the MemoryRegion. Since these are 3-bit-loads of\nvalues that never change, caching them can measurably reduce compile\ntimes.\n\nAccording to benchmarks, this patch saves 1-3% on armv7, 2-4% on x86,\nand 0-1% on x64.\n\nChange-Id: I46b197513601325d8bab562cc80100c00ec28a3b\n" }, { "commit": "7922d0f2ef6a9fa7adc3b9417246aabea2474732", "tree": "c5c9e9106287694c80d7b262e1d2dbf176d59ae9", "parents": [ "99c2abcb085d254b17a870442ca188fa09ab58de", "f2650d1f957b158496de8016bc43fb575e81d6bc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Jun 03 11:00:37 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jun 03 11:00:37 2015 +0000" }, "message": "Merge \"Show stack maps and Dex register maps in oatdump\u0027s assembly code.\"" }, { "commit": "f10a25f961eb8029c01c84fe8eabd405055cca37", "tree": "a0fd9dfa459689fa2929a89310ebcd3a45607e5f", "parents": [ "1682e1aa3463c2e6a8e5f4a9d3f4d13a0e31e3da" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Jun 02 14:29:52 2015 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Jun 02 14:36:09 2015 +0100" }, "message": "ART: Fast copy stack mask\n\nStackMap::SetStackMask will currently copy a BitVector into a Memory-\nRegion bit by bit. This patch adds a new function for copying the data\nwith memcpy.\n\nThis is resubmission of CL I28d45a590b35a4a854cca2f57db864cf8a081487\nbut with a fix for a broken test which it revealed.\n\nChange-Id: Ib65aa614d3ab7b5c99c6719fdc8e436466a4213d\n" }, { "commit": "d84b4384bc14a6bc256ad85955eca0582e6b2364", "tree": "c6b4bb107841320abbaa1402484df67c3f4a0a3b", "parents": [ "6b10c9b2c0e62193ab9df4d63aedea1d0798e742" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Jun 02 12:42:40 2015 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Jun 02 12:42:40 2015 +0000" }, "message": "Revert \"ART: Fast copy stack mask\"\n\nDCHECK failure, need to investigate\n\nThis reverts commit 6b10c9b2c0e62193ab9df4d63aedea1d0798e742.\n\nChange-Id: Ie1d1cc6fb71367bc5ac5d6a260af8de316a758dd\n" }, { "commit": "6b10c9b2c0e62193ab9df4d63aedea1d0798e742", "tree": "9930b839777184008b38e5504f1274c4cbfd87e1", "parents": [ "f86808b55b550962c627b50511b98f4de8cd0e60" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Fri May 29 16:33:09 2015 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Jun 02 12:30:46 2015 +0100" }, "message": "ART: Fast copy stack mask\n\nStackMap::SetStackMask will currently copy a BitVector into a Memory-\nRegion bit by bit. This patch adds a new function for copying the data\nwith memcpy.\n\nChange-Id: I28d45a590b35a4a854cca2f57db864cf8a081487\n" }, { "commit": "f2650d1f957b158496de8016bc43fb575e81d6bc", "tree": "37bf1dff25dbd38f6cfdbaace07a50eb92f8c43d", "parents": [ "0028b9d3b7d73ba0a045d50a0fe2797e51a4e6b6" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 28 14:53:28 2015 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri May 29 16:39:18 2015 +0100" }, "message": "Show stack maps and Dex register maps in oatdump\u0027s assembly code.\n\nStack maps and Dex register maps are not longer displayed\nin CodeInfo sections, unless `--dump:code_info_stack_maps\u0027\nis passed to oatdump.\n\nChange-Id: Id82adb406d7e56cda27df8e5a8bd328a88b9ee11\n" }, { "commit": "0396ed7d3ad30778cb4af19e7086bea0deace9b9", "tree": "cab609c648e04f63bcd52dfa9510d4a88a761997", "parents": [ "6c70104dc3ecd66b46f56cae068a14e12021c9f2" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed May 27 15:12:19 2015 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed May 27 15:24:30 2015 +0100" }, "message": "Improve art::CodeInfo dumping.\n\n- Refactor existing dumping code into a set of new routines.\n- Use art::Indenter to properly indent in the output.\n- Add an additional argument to art::CodeInfo::Dump to\n enable or disable the dumping of stack maps and Dex\n register maps.\n\nChange-Id: I52814095ff465522302d5d69d416726369ca5258\n" }, { "commit": "dc31313c4577bb4c00d90774159c84e738ed348d", "tree": "5f850028ebc8843cdcaf56c5fc122bd660937603", "parents": [ "03b5a398a96ea29c39ddfe3d810245b868d2871f", "80afd02024d20e60b197d3adfbb43cc303cf29e0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 26 17:42:31 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 26 17:42:31 2015 +0000" }, "message": "Merge \"ART: Clean up arm64 kNumberOfXRegisters usage.\"" }, { "commit": "80afd02024d20e60b197d3adfbb43cc303cf29e0", "tree": "ef054c7b4f2a739f7cf063e0bc4c501c2c7e41b5", "parents": [ "559b178e34c5d92e7932f92e5d8a981ac334606f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 19 18:08:00 2015 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 26 15:59:02 2015 +0100" }, "message": "ART: Clean up arm64 kNumberOfXRegisters usage.\n\nAvoid undefined behavior for arm64 stemming from 1u \u003c\u003c 32 in\nloops with upper bound kNumberOfXRegisters.\n\nCreate iterators for enumerating bits in an integer either\nfrom high to low or from low to high and use them for\n\u003carch\u003eContext::FillCalleeSaves() on all architectures.\n\nRefactor runtime/utils.{h,cc} by moving all bit-fiddling\nfunctions to runtime/base/bit_utils.{h,cc} (together with\nthe new bit iterators) and all time-related functions to\nruntime/base/time_utils.{h,cc}. Improve test coverage and\nfix some corner cases for the bit-fiddling functions.\n\nBug: 13925192\nChange-Id: I704884dab15b41ecf7a1c47d397ab1c3fc7ee0f7\n" } ], "next": "6530baf76ef7a62f2d76a6735ad461d7d59cf0e4" }