)]}' { "log": [ { "commit": "93adcb53c77f4f04dfebd30b94e8ea9936aa8abb", "tree": "bdf638b78c045eed106ace99fbdc64506712d8ea", "parents": [ "01f2e3a488fa06d98e2efbaf3ea8066d8457f216" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 06 20:16:07 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jun 07 23:05:24 2019 +0000" }, "message": "ART: Remove some compile-time info points\n\nRemove no longer needed compile-time info points in the verifier. Only\ncheck-casts are still reliant on support for elision.\n\nThis reduces the number of pre-populated register lines in a large\napp by 70%, and the number of instructions executed during verification\nby about 2%.\n\nBug: 110852609\nTest: m test-art-host\nChange-Id: Iefa8253749b1a2750f57360e08ddfb502d0478b1\n" }, { "commit": "327497e303903f300b01f77f2259fd5b61238ee3", "tree": "3f714d2d2ee7d9b6c0ecf71a10c157d4952e5758", "parents": [ "ef764ad3e6d7f07ea9e32642dc3e163bb4eb44fb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 04 12:53:20 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 11 06:59:41 2019 +0000" }, "message": "Move CompilerDriver to dex2oat/.\n\nAlso DexToDexCompiler, QuickCompilerCallbacks and tests.\n\naosp_taimen-userdebug:\n - before:\n lib64/libart-compiler.so: 3112344\n lib/libart-compiler.so: 2312908\n bin/dex2oat: 563176\n - after:\n lib64/libart-compiler.so: 2986720 (-123KiB)\n lib/libart-compiler.so: 2219852 (-91KiB)\n bin/dex2oat: 635832 (+71KiB)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nChange-Id: I36e63b83dff1d5c731d05de27d3663cfc81de6ad\n" }, { "commit": "815d5e5304a5b57db64d6829813a14e464d5c55f", "tree": "7fac4adffcda366f4ee252e233828ebf2361f2b0", "parents": [ "b1b2ca97651b1993e0a00a4543209419afbc6e64" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 04 10:18:31 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 05 12:37:30 2019 +0000" }, "message": "Refactor compiler tests around CompilerDriver.\n\nIntroduce CommonCompilerDriverTest and inherit that in tests\nthat need to use CompilerDriver. This is in preparation for\nmoving the CompilerDriver to dex2oat/.\n\nTest: m test-art-host-gtest\nChange-Id: I46cf0bc1df4327569eef5526eeab0781473173a1\n" }, { "commit": "038924b75f06b91c2a7e944196ca11f118ce182f", "tree": "fb3073918686ec6f54dce65d2697c0e46f05a272", "parents": [ "03c6b174a4e412e9bb62935c4ee15b5445e517f2" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 19 15:09:35 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 20 10:40:05 2019 +0000" }, "message": "ART: Reduce dependencies on CompilerDriver.\n\nPreparation for moving CompilerDriver and other stuff\nfrom libart-compiler.so to dex2oat.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Ic221ebca4b8c79dd1549316921ace655f2e3f0fe\n" }, { "commit": "3f1dcd39e134d994ac88dcc4f30ec8cabcd8decf", "tree": "365d20ad6b68ff1dbd4903764b63880324136e4d", "parents": [ "0f0a4e40667c87fbd4ae5480eddbfd701bfabfa2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 28 09:39:56 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 02 10:32:25 2019 -0800" }, "message": "ART: Move dex structs into own header\n\nSeparating out the structs from DexFile allows them to be forward-\ndeclared, which reduces the need to include the dex_file header.\n\nBug: 119869270\nTest: m\nChange-Id: I32dde5a632884bca7435cd584b4a81883de2e7b4\n" }, { "commit": "3db70689e3e1c92344d436a8ea4265046bdef449", "tree": "3db08743e968062ed5bdc143233cdb3c4564696b", "parents": [ "1650dafad62578a1766bd617d78458a4cf1e2a9a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 26 15:12:03 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 27 12:56:39 2018 -0800" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles compiler.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: I5cdfe73c31ac39144838a2736146b71de037425e\n" }, { "commit": "ed8b4ac3d7a78cc4976fa24a34bac92f4fd47a27", "tree": "8292de7f2a4e8b9c0526d05a604668da11e1980e", "parents": [ "a9a0973ff03ce2c2d1ec65695ad0f4cd8ed170a7", "2afaff7e9171992b0e2e95d0f485782d28e1b9dc" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 07 08:11:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 07 08:11:24 2018 +0000" }, "message": "Merge \"Refactor CompilerDriver::CompileAll().\"" }, { "commit": "7fbc4a59ba2e60d869313d7961662430df83b2cb", "tree": "59520285df8d2075412ddc566a0d4d96d4c7e109", "parents": [ "7cc45fd1dbcf5704e442d0443e437aa2ae3fe21b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 28 08:26:47 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 06 11:37:19 2018 -0800" }, "message": "ART: Move to using locks.h instead of mutex.h\n\nWhen only annotating lock requirements, use locks.h.\n\nBug: 119869270\nTest: mmma art\nChange-Id: I1608b03254712feff0072ebad012c3af0cc3dda4\n" }, { "commit": "2afaff7e9171992b0e2e95d0f485782d28e1b9dc", "tree": "96c7ea4a13e8a9a191d58002de89fb005231980e", "parents": [ "6a98f89c4ad645b04d6c80d3d7e260c59bf6f193" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Nov 30 17:01:50 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Dec 06 16:26:43 2018 +0000" }, "message": "Refactor CompilerDriver::CompileAll().\n\nTreat verification results and image classes as mutable\nonly in CompilerDriver::PreCompile(), and treat them as\nimmutable during compilation, accessed through the\nCompilerOptions. This severs the dependency of the inliner\non the CompilerDriver.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I594a0213ca6a5003c19b4bd488af98db4358d51d\n" }, { "commit": "33f7c8aa87831945c567f57c8b860f216c4371ae", "tree": "9022cb2fe8bf889c0a32f4478b249145318a7a65", "parents": [ "54c7da9c50ee85ade636605cd6ea18b4c2bc69fa" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Nov 19 10:22:01 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Nov 19 10:45:13 2018 +0000" }, "message": "Remove CompiledMethod dependency on CompilerDriver.\n\nTest: m test-art-host-gtest\nChange-Id: Ibee78d5c54d3ff8162258963fde25065b579a000\n" }, { "commit": "9c4b970db31b234d6c0358802cd14ba4262e4ce6", "tree": "8a2f624b03fcf1fcfae3e42fe519e2900df3e52f", "parents": [ "3c92ff4afe372ab0850ce95321ba4112b7f3dfdd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 14 15:09:02 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 15 17:05:29 2018 +0000" }, "message": "Rewrite image type in CompilerOptions.\n\nPrepare for introduction of boot image extension.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nChange-Id: Id007c4aeb4ada84fe65c1148fdf67e8a412e5b74\n" }, { "commit": "c1c3452e465e473df499196b387330a793b89680", "tree": "1b144182126bfc73c5d82d1941e1673826d39343", "parents": [ "3b5062083d3e203d1c72b066150b4fe441588a25" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Oct 31 13:56:49 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 01 17:01:31 2018 +0000" }, "message": "Do not cache RequiresConstructorBarrier() results.\n\nAvoid caching the results. Caching was broken for JIT in the\npresence of class unloading; entries for unloaded dex files\nwere leaked and potentially used erroneously with a newly\nloaded dex file.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target\nBug: 118808764\nChange-Id: Ic1163601170364e060c2e3009752f543c9bb37b7\n" }, { "commit": "afaf7f8198fe5ffc054278da6800f81dd83f272c", "tree": "3ebdec9fca813351d178709743121fa66815a7a0", "parents": [ "6ca8ec7809f87ccac8d9d66d267f2379bdfdfe66" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 16 11:32:38 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 18 08:20:09 2018 -0700" }, "message": "ART: Enable bugprone-unused-return-value\n\nEnable bugprone-unused-return-value as an error. This is on top of\nthe compiler warning for attribute((warn_unused)).\n\nMark the current occurrences (all unique_ptr.release()) with NOLINT\nto signal that we know what we\u0027re doing.\n\nBug: 32619234\nBug: 117926937\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: I36659722335eef36acfa5845289104257a393874\n" }, { "commit": "4df2d8041f5dcc7af8c3b3b60b0ea87a1e0d3b94", "tree": "0273072a2b65d6c0cf692a3e7f8eab9814d9d23d", "parents": [ "233b572a940431a94a1790750afdceab2d6f4fde" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:42:44 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Sep 28 09:12:06 2018 +0100" }, "message": "Revert^2 \"Load boot image at a random address.\"\n\nThis reverts commit f3d077373536c54824e4449759dff2f18369eab3.\n\nFixed Heap constructor to reserve extra space for GSS.\n\nChange-Id: I6a65be35f4aa183304db5491da4a4810d8e3b266\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --relocate --no-relocate\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing --relocate --no-relocate\nTest: art/test/testrunner/run_build_test_target.py -j48 art-gtest-gss-gc-tlab\nBug: 77856493\n" }, { "commit": "233b572a940431a94a1790750afdceab2d6f4fde", "tree": "85360608b41023a895d1fe1a933edec6311054bf", "parents": [ "62741139ea636682568237417c3bda84dfd1606b", "f3d077373536c54824e4449759dff2f18369eab3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:40:03 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Sep 27 16:40:03 2018 +0000" }, "message": "Merge \"Revert \"Load boot image at a random address.\"\"" }, { "commit": "f3d077373536c54824e4449759dff2f18369eab3", "tree": "e00d19a342ff429fc514bf70bf52ff005a00911c", "parents": [ "5ad79d85d77a42456728897ac3e2e7d4530e618e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:24:17 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:24:17 2018 +0000" }, "message": "Revert \"Load boot image at a random address.\"\n\nThis reverts commit 5ad79d85d77a42456728897ac3e2e7d4530e618e.\n\nReason for revert: Breaks GSS garbage collection config.\n\nBug: 77856493\nChange-Id: Ifa39966ac2470154f8ba093de4804689d545219b\n" }, { "commit": "334c154f9b4ba288a1fec54fef98fcf71223bae6", "tree": "330d6fef01000062f0e1f3691edd2a7961ce1eca", "parents": [ "a59b1ecaf425bae23eed3224cf055b6172c8424f", "5ad79d85d77a42456728897ac3e2e7d4530e618e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 14:13:46 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Sep 27 14:13:46 2018 +0000" }, "message": "Merge \"Load boot image at a random address.\"" }, { "commit": "5ad79d85d77a42456728897ac3e2e7d4530e618e", "tree": "ff70d1f12904c718f2f3f721d3846f4305eae53d", "parents": [ "5d7015cd64085068b1685d44339b4b705ef3f065" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 03 09:54:09 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 26 13:08:36 2018 +0100" }, "message": "Load boot image at a random address.\n\nAnd perform in-place fixup of references and pointers. This\ndirties all the boot image memory loaded by zygote, so there\nshall be no \"shared clean\" boot image pages anymore, these\nshall change to \"shared dirty\". However, as we\u0027re using a\nprofile-based boot image, these pages are presumably used\noften enough and unlikely to be paged out anyway.\n\nThe in-place fixup takes around 60-120ms when starting the\nzygote on aosp_taimen-userdebug. However, an experiment with\nMAP_POPULATE pushes the raw fixup down to around 12-15ms.\nIf we used compressed images, this would be the actual time\nfor fixup as the data would be already present in memory.\nIf we keep using uncompressed images, we shall need to tune\nthe loading with MAP_POPULATE or MADV_WILLNEED.\n\nThe -Xrelocate/-Xno-relocate option is re-interpreted from\n\"use patchoat if needed\" to \"relocate the boot image in\nmemory if possible\". We do not allow relocation for the AOT\ncompilation to speed up dex2oat execution and help producing\ndeterministic output.\n\nThe patchoat tool shall be removed in a follow-up CL.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --relocate --no-relocate\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing --relocate --no-relocate\nBug: 77856493\nChange-Id: I2db1fabefb5d4b85c798cd51e04c78cb232bff4a\n" }, { "commit": "c55bb390d88b8eb62a50932f7f9b47c2a3733f16", "tree": "ec2e74f3f8404dffcb9bfde4e7ffa3416a35543d", "parents": [ "89468aeaa6a67ae4025b30d427391186306d6522" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 21 00:02:02 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 18:37:12 2018 -0700" }, "message": "Revert^2 \"ART: Refactor typedef to using\"\n\nThis reverts commit ee07743e03042c2ca36e0c9513847a9e7d2509f1.\n\nReason for revert: fixed attributes.\n\nBug: 32619234\nTest: m test-art-host\nTest: m test-art-target-gtest-unstarted_runtime_test\nChange-Id: I6f0a775adfdf6ecd132b470f7c5446e949872e20\n" }, { "commit": "ee07743e03042c2ca36e0c9513847a9e7d2509f1", "tree": "66867d7443a3798f6d882ef2715ddeb7baf3e771", "parents": [ "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "message": "Revert \"ART: Refactor typedef to using\"\n\nThis reverts commit 9a20ff06f7ccee08a742c315ec6d351ab56ba1cd.\n\nReason for revert: Attributes on the wrong side.\n\nBug: 32619234\nChange-Id: I8fd2abef619b22c02ccfbf5ae629339f1a60918b\n" }, { "commit": "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd", "tree": "7e55557e118eb5fffe03ad3456e00d8469a36232", "parents": [ "70dfb6983492aff1c52cc1b52044258aef51f47f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 10:58:18 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 21:56:32 2018 -0700" }, "message": "ART: Refactor typedef to using\n\nAdd clang-tidy\u0027s modernize-use-using.\n\nBug: 32619234\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: If50d37b5152af4270784e3cde7951292a9e19033\n" }, { "commit": "bbc6e7edb5fca4a61ac53dd9bce79cb4f0bb3403", "tree": "0fbce767bc383358cf4cd65aafc74140e1850982", "parents": [ "19379b58bd433da91230e4fe6cd96e7416d16adc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 24 16:58:47 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Aug 28 11:06:07 2018 +0100" }, "message": "Use \u0027final\u0027 and \u0027override\u0027 specifiers directly in ART.\n\nRemove all uses of macros \u0027FINAL\u0027 and \u0027OVERRIDE\u0027 and replace them with\n\u0027final\u0027 and \u0027override\u0027 specifiers. Remove all definitions of these\nmacros as well, which were located in these files:\n- libartbase/base/macros.h\n- test/913-heaps/heaps.cc\n- test/ti-agent/ti_macros.h\n\nART is now using C++14; the \u0027final\u0027 and \u0027override\u0027 specifiers have\nbeen introduced in C++11.\n\nTest: mmma art\nChange-Id: I256c7758155a71a2940ef2574925a44076feeebf\n" }, { "commit": "8cd54547cec8a4537db5682c2da8be22843b1310", "tree": "fb1158993bab2e027984cedab59b402c051a45a7", "parents": [ "91f0fdb4372d3f2bcfcd9db67afcbe7ee1901048" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jul 15 23:58:44 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 14:49:40 2018 +0100" }, "message": "Move MethodInfo to CodeInfo.\n\nThere is no need to treat it specially any more,\nbecause of the de-duplication at BitTable level.\n\nThis saves 0.6% of oat file size.\n\nTest: test-art-host-gtest\nChange-Id: Ife7927d736243879a41d6f325d49ebf6930a63f6\n" }, { "commit": "8808756b8fba036a9c73a45c800a56be09872364", "tree": "9b28f314ff516d1d9b85d07f71bdc77fad465e48", "parents": [ "dda4e8b5f2ffed24a2dcdb99d2301d9fc0eb91e2" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sat Jun 23 22:05:56 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jul 27 15:03:06 2018 +0100" }, "message": "Remove frame info from OatQuickMethodHeader.\n\nThe information has been moved to CodeInfo,\nwhere it is stored in much more compact way.\n\nThe old CL which added the data to CodeInfo cost 0.7%.\nThis CL saves 2.5% of .oat file size so a win overall.\n\nTest: test-art-host-gtest\nChange-Id: I07fcf6f2776c96218f995ba3b57a1e6ccbf5e317\n" }, { "commit": "a043111e3a2c09b549708a6227a1f54d91da76aa", "tree": "393fe11cfceccebf474e4bdf36ff79b70b97f589", "parents": [ "213ee2da6a1c58d0fc12c937bbd9c9974ca00aca" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 25 09:32:54 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 25 18:43:19 2018 +0100" }, "message": "Move instruction_set_ to CompilerOptions.\n\nRemoves CompilerDriver dependency from ImageWriter and\nseveral other classes.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nChange-Id: I3c5b8ff73732128b9c4fad9405231a216ea72465\n" }, { "commit": "213ee2da6a1c58d0fc12c937bbd9c9974ca00aca", "tree": "bfb5d5ed85473054d863bbaa91a7d9a69a803eec", "parents": [ "dc4bccef0ded1c261bf9838def2ef329765a8682" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 22 11:56:34 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 25 11:41:47 2018 +0100" }, "message": "Move dex_files_for_oat_file_ to CompilerOptions.\n\nA step toward removing the CompilerDriver dependency from\nseveral classes, including HSharpening and ImageWriter.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I364ef66511fdf855cb11b12c818a40572b037727\n" }, { "commit": "dbf540399a2aaddad00b1233b80808c80dc0d443", "tree": "b5a1933b5edd1b998a815b22695f2591e8db072c", "parents": [ "4f0e0b8a4161ec9217b0b3cbca5fa6d3a289cc6a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 18 14:47:01 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 19 17:09:45 2018 -0700" }, "message": "ART: Fix clang-analyzer leak/memory warnings\n\nFix warnings, or make code more obvious to the analyzer.\n\n(The analysis itself is too expensive to force it on for all\nlocal builds.)\n\nTest: mmma art (with clang-analyzer-cplusplus.NewDeleteLeaks)\nChange-Id: Id3687eb6f3af3a0b4f2df1422bc6d83650517623\n" }, { "commit": "74f2ccc9fad3cfd8e04d24aceba1c58ce08884dc", "tree": "ba0051646cb8e8192f690259475101b61101d5c3", "parents": [ "9fdd0125538fe63458aec68c4a40b025759bcf7c", "05e34f4cb8c9db165d1008721e874b9dd3db024b" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jun 11 15:02:44 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jun 11 15:02:44 2018 +0000" }, "message": "Merge \"Revert^2 \"Remove support for Valgrind in ART.\"\"" }, { "commit": "05e34f4cb8c9db165d1008721e874b9dd3db024b", "tree": "c41d397ef5cfb9d7918fceadcda3195a0d0d91de", "parents": [ "428d80e3a49f732b39bb0c71cfde26451e3fdf4d" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 24 13:19:05 2018 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jun 11 14:03:37 2018 +0100" }, "message": "Revert^2 \"Remove support for Valgrind in ART.\"\n\n- Disable test configuration art-gtest-valgrind64\n (art-gtest-valgrind32 was already disabled).\n- Remove Makefile logic regarding testing with Valgrind.\n- Remove occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_VALGRIND`.\n- Replace occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_ASAN` with\n `TEST_DISABLED_FOR_MEMORY_TOOL`.\n- Replace the potentially dynamically evaluated\n `RUNNING_ON_MEMORY_TOOL` expression with constant\n `kRunningOnMemoryTool`.\n- Simplify and fold the logic of\n `art::ArenaAllocatorMemoryToolCheckImpl` and\n `art::ArenaAllocatorMemoryToolCheck` into\n `art::ArenaAllocatorMemoryTool`.\n- Adjust comments regarding memory tools.\n- Remove Valgrind suppression files.\n- Remove `--callgrind` option from tools/art.\n\nThis reverts commit 8b362a87d52a6668ffd2283ef6ffc274315f41c8.\n\nChange-Id: I23c76845e6ccf766f19b22b58a0d5161f60842a9\nTest: art/test.py\nTest: art/test/testrunner/run_build_test_target.py art-asan\nBug: 77856586\nBug: 29282211\n" }, { "commit": "18e2687c4126d66870d61d6548abc2c7661a66cc", "tree": "06eff605df9259dde8170c8efb48b11df4108eb3", "parents": [ "2607d6c47114a18ccf4a532b20e1099d1dd8fcca" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 04 17:19:02 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jun 07 22:13:48 2018 -0700" }, "message": "Refactor ClassAccessor to use an index instead of ClassDef pointer\n\nRemoves a separate class_def_idx being required for getting the index\nof a ClassAccessor foreach loop.\n\nBug: 79758018\nTest: test-art-host-gtest\n\nChange-Id: Ie3010a17669f24cf492c678b55bdddba7ec62ea8\n" }, { "commit": "bcf175247272d0e321c8d988c3c01c123b56e36e", "tree": "9f65ece5ce9474aa4fcf16fbfca6278109dc9a67", "parents": [ "09c5ca40635faee00f40f6ca0581dd475efd545e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 01 13:14:32 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 01 16:31:30 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify array allocations.\n\nAnd remove some unnecessary calls to ObjPtr\u003c\u003e::Ptr().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ie313980f7f23b33b0ccea4fa8d5131d643c59080\n" }, { "commit": "0d896bd7da4f7b11559aa88aad82e9a9e170a4e4", "tree": "44a9278d98ace169e8296feba98038c173f29eaf", "parents": [ "267c83529850f51cd690b3e31882aaae98601afd" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 25 00:20:27 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue May 29 10:20:59 2018 -0700" }, "message": "Add Method/Field iterator to ClassAccessor\n\nEnables ranged based for loops on fields and methods.\n\nFor visiting both fields and methods, VisitFieldsAndMethods will\nbe faster because of not needing to decode the fields twice for\nseeking purposes.\n\nAdded test.\n\nBug: 79758018\nBug: 77709234\nTest: test-art-host-gtest\n\nChange-Id: I593e23ccd138b87a27d8bab6927ff2b685c057f3\n" }, { "commit": "c8c8d5f484b9e4660de288aa51ce3f831317ee53", "tree": "fa329a0787a0e302ff40c7deefa97d5b79b28550", "parents": [ "d804b76c0b8f9d2c94f3a8648aba26254742a1e2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue May 22 11:56:14 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu May 24 10:48:53 2018 -0700" }, "message": "Move compiler/ to ClassAccessor\n\nRemove usages of ClassDataItemIterator to reduces boiler plate code.\n\nBug: 79758018\nBug: 77709234\nTest: test-art-host\n\nChange-Id: Id41db3299bba3ea8debcbb0b9c721fa675adc064\n" }, { "commit": "197f1ef6f4f2411d011d7e8f696775c3fbcffd86", "tree": "eacc720024479e75b03d12ac6764f2cd2ba945b3", "parents": [ "04f0eaffa70e0384c07bb3680aa0724144358330", "8b362a87d52a6668ffd2283ef6ffc274315f41c8" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue May 22 23:00:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 22 23:00:40 2018 +0000" }, "message": "Merge \"Revert \"Remove support for Valgrind in ART.\"\"" }, { "commit": "8b362a87d52a6668ffd2283ef6ffc274315f41c8", "tree": "14b187cd0b4afde501b9cc7a9dc82c997362e888", "parents": [ "8268cb677bd92bfbcfec7e803775c29687494e53" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 22 20:54:14 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 22 20:54:14 2018 +0000" }, "message": "Revert \"Remove support for Valgrind in ART.\"\n\nThis reverts commit 8268cb677bd92bfbcfec7e803775c29687494e53.\n\nReason for revert: ASAN failures\n\nChange-Id: I7e66d3f3fb461ae4f6dea6ec7d506b7dface3402\nTest: SANITIZE_HOST\u003daddress m test-art-host\nBug: 77856586\nBug: 29282211\n" }, { "commit": "438918b2f37e11684fa1e80bbbfe3a8f657b79a9", "tree": "b77443efb26d5a18a5f5f7d853223dfb3c6ab919", "parents": [ "f31343f1eab771010b3f293366149d2524f30902", "c2b4db61e5d0d9ec40b87b9a051aa1ac15ed1294" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue May 22 16:49:41 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 22 16:49:41 2018 +0000" }, "message": "Merge \"Add ClassAccessor\"" }, { "commit": "c2b4db61e5d0d9ec40b87b9a051aa1ac15ed1294", "tree": "7d8ba5f2ab1c8ff66b17ce2352be3d7f0e12651c", "parents": [ "8926b780fd75f23e8685e108e2d3f4905f3809fd" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 18 13:58:12 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon May 21 12:59:22 2018 -0700" }, "message": "Add ClassAccessor\n\nAims to replace ClassDataItemIterator with a cleaner and simpler\nabstraction.\n\nBug: 77709234\nBug: 79758018\nTest: test-art-host\n\nChange-Id: I871a3e1cf213e0d81bfe4bb77790fbab2d13e44c\n" }, { "commit": "8268cb677bd92bfbcfec7e803775c29687494e53", "tree": "b63ca42dcd440117187e3c859b4b311b11b8137e", "parents": [ "004b8875b291af5001d384fb1eb76ae0660ff056" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri May 11 15:06:17 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon May 14 18:40:49 2018 +0100" }, "message": "Remove support for Valgrind in ART.\n\n- Disable test configuration art-gtest-valgrind64\n (art-gtest-valgrind32 was already disabled).\n- Remove Makefile logic regarding testing with Valgrind.\n- Remove occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_VALGRIND`.\n- Replace occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_ASAN` with\n `TEST_DISABLED_FOR_MEMORY_TOOL`.\n- Replace the potentially dynamically evaluated\n `RUNNING_ON_MEMORY_TOOL` expression with constant\n `kRunningOnMemoryTool`.\n- Simplify and fold the logic of\n `art::ArenaAllocatorMemoryToolCheckImpl` and\n `art::ArenaAllocatorMemoryToolCheck` into\n `art::ArenaAllocatorMemoryTool`.\n- Adjust comments regarding memory tools.\n- Remove Valgrind suppression files.\n- Remove `--callgrind` option from tools/art.\n\nTest: art/test.py\nBug: 77856586\nBug: 29282211\nChange-Id: Ifdcbfccc1830104c455760457df66ede4a4cd135\n" }, { "commit": "312f3b2fd0094c028a7d243b116947a35a745806", "tree": "3d7ec049ded98c489098c87250c75e3f711f8290", "parents": [ "0a3d5eb2ff9e70fa5785638da938439835d0337e" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 08:39:26 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 11:02:48 2018 -0700" }, "message": "Move some remaining dex utilities\n\nThere were several utilities related to building/walking/testing dex\nfiles that were not in libdexfile. This change consolidates these.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Id76e9179d03b8ec7d67f7e0f267121f54f0ec2e0\n" }, { "commit": "67bf42e89592c3a1c648f927f2ce3ccb189a1161", "tree": "054d5b7adf7cc62d4d2a2118a70c0fbdd1751610", "parents": [ "d961043ff1dd6fddb68aa90c1f939cfafec24219" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 26 16:43:04 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 28 15:08:21 2018 -0800" }, "message": "Header library to remove dependence on runtime/\n\nAdd a new header library to remove libdexfile and others\u0027 dependence on\nruntime (typically runtime/base) includes in libdexfile. Also a small step\nto tease dexlayout and profman away from relying on these as well.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n\nChange-Id: I38e2fe399a75f4bc6318c77a71954c00ea73ec2b\n" }, { "commit": "2daa13448d5caeb7eb4f7fd3981c0d430264c7c3", "tree": "547222519fc7627a99eae914fbaa39eb294a82c6", "parents": [ "b2f1edc3d1f162bd9007f10bc66009eac5b2daab" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 20 16:19:28 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Feb 22 10:37:31 2018 -0800" }, "message": "Fix unquickening logic for quickened input dexes\n\nIn the case where an input dex is already quickened (i.e.\nobfuscation), do not attempt to unquicken it. This is done by\nswitching the quicken info table to the compact offset table (used by\ncdex debug infos).\n\nAdded test.\n\nPosssible to get a bit of extra savings by deleting the quicken info\nnum entries field.\n\nQuicken filter size regression average on golem: -0.14%.\n\nBug: 72608794\nBug: 63756964\nTest: test-art-host-gtest-dex2oat_test -j64\nChange-Id: I5534a7509b4c718a9b959fa43b82bde857e0b59e\n" }, { "commit": "279e3a3499d208daf467a1690b111dfb06f3e96e", "tree": "74c7d6d860bea25aabae47dc0ca95bafb0571f8e", "parents": [ "ca6f1c0cb7655e90237583c1b6b771d3c8aae95d" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jan 24 18:17:55 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 05 13:38:20 2018 -0800" }, "message": "Enable code item deduping\n\nDedupe code items if they have the same contents, this is safe\nbecause of the fixed quickening logic.\n\nRemoved duplicate code items in ManyMethods that caused the startup\nmethods section to be empty in dex2oat_test.\n\nTo avoid errors related to quickening and compilation of shared code\nitems, quickening is currently disabled for shared code items.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I7c62eb746785d787c5269effd396f7be4859d3a6\n" }, { "commit": "0225f8e2939a9340cb7dcebfcfe7996a2bd9bce9", "tree": "fd32362dff4ecdc8ff8b0d800a1b46fb0d9d0104", "parents": [ "c7e546ff3963a1d51b1f100d308db735bd19f736" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 08:52:24 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 01:24:53 2018 -0800" }, "message": "Revert \"Revert \"Make libdexfile build independent of runtime dir\"\"\n\nThis reverts commit 787784f9effb126b5d0d3dc97d544c4a477b5daf.\n\nReason for revert: Bot configuration issue.\n\nChange-Id: I6a10bb4a9571f89c7e4dd095f9157e830a44e2de\nBug: 22322814\nTest: make -j 50 checkbuild\n" }, { "commit": "787784f9effb126b5d0d3dc97d544c4a477b5daf", "tree": "1ff6d9fd284a4dd2a337165dff20e71137997c9d", "parents": [ "b40b7e73469339a6b667b4a2e2b8690112a74dc9" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "message": "Revert \"Make libdexfile build independent of runtime dir\"\n\nThis reverts commit b40b7e73469339a6b667b4a2e2b8690112a74dc9.\n\nReason for revert: on device libdexfile.so missing\n\nChange-Id: I9bd61a98bef870400580e8c991cb061d3f57fa72\n" }, { "commit": "b40b7e73469339a6b667b4a2e2b8690112a74dc9", "tree": "7e8a34d9c7894c4c946f674f19f0a0a512b95184", "parents": [ "9690ad794b324ba54e936608881ac0f62538b97a" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 25 17:11:07 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 01:17:58 2018 -0800" }, "message": "Make libdexfile build independent of runtime dir\n\nRemove libdexfile\u0027s dependency on utils.cc and move utf.cc into\n/dex. Remove libdexfile\u0027s constituent sources from libart and\nuse libdexfile wherever libart is. Also remove some ART-specific\ninterfaces. Libdexfile\u0027s tests remain to be converted, plus\nmoving the files to a new directory peer to runtime/.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Ifaf695216e4a0e43d3aa377984d933f7a2a243c2\n" }, { "commit": "8c0961f9e061ee4b04c1c4ba8ad5cca13bcf884d", "tree": "f6e5a970a6bcc0935e150cb6c28a520bf31ba964", "parents": [ "2b1a21ed3581f77f34d582507177ebce33565534" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 23 16:11:38 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 24 09:24:29 2018 -0800" }, "message": "Move missed files to libdexfile\n\nReduce the dependencies on utf and utils in preparation for separate\ndirectory.\n\nBug: 22322814\nTest: make -j 50 test-art-host\n make -j 50 dexdump2 dexlist\n\nChange-Id: Icdecf895dafec63ef903514eef79d459abc14925\n" }, { "commit": "b3c0b5229d2e224e7c895660ed9ba258e4d7a51c", "tree": "9a43d80a1ee0fc6deb1363fc164f20fea4b7ff25", "parents": [ "7b4c09a39fd1b43995aa6d68958113463bc5b82b", "e993458e8192b24621cb88a6ebcdbfd66f01da45" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jan 22 23:02:45 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jan 22 23:02:45 2018 +0000" }, "message": "Merge \"ART: Allow oatstatus verification for app dependencies\"" }, { "commit": "a79efdb69350fa66e1beabed4499ef4d0e809785", "tree": "0a7491e10f646075b2d535cf69e13145224bb2ca", "parents": [ "ccc5401bf082e4292a2cb75eeeb216a441189aef" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 18 16:31:01 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jan 22 08:46:37 2018 -0800" }, "message": "Fix quickening logic\n\nFix varius bugs in the quickening logic where related to shared code\nitems for different methods.\n\nFixed the case where two methods quicken differently on the same code\nitem by checking that the quicken info is the same for all methods\nthat quicken the same code item. This is accomplished by requickening\nand reverifying the contents of the quicken info.\n\nFixed the case where the dex to dex compiler would abort from a\nDCHECK that there was no already quickened instructions.\n\nFeature is tested by enabling deduping (aog/594315).\n\nTest: test-art-host\nBug: 63756964\n\nChange-Id: I52c2b89518f4e808594b450a5fcc373ab5a5863b\n" }, { "commit": "e993458e8192b24621cb88a6ebcdbfd66f01da45", "tree": "4322c1b8b055cae814c28f326c07b301ca0f8b61", "parents": [ "ba94510917814f9e79233bc6de192e87078c6941" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jan 19 21:23:04 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jan 19 21:55:33 2018 -0800" }, "message": "ART: Allow oatstatus verification for app dependencies\n\nAllow taking verification state from the oat file durin compilation\nif the class is a dependency (thus not being compiled itself). This\nis necessary in case the dependency itself has been quickened and\nstripped, as quickened bytecodes are not supported during compile-\ntime verification.\n\nExpose this through the CompilerCallbacks.\n\nBug: 72237763\nTest: m test-art-host\nChange-Id: I9b7d3a353d81a6422c3b145fd5c5b71f36c6f257\n" }, { "commit": "210531f8775c89feb90d430cd5b6026b4cf8ef89", "tree": "3c23fffcc0d1d7876f15f64672e0de98b1f051ca", "parents": [ "3c9e0f69b04b614c44448e66e15c6f8a78da4b2c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 12 10:15:51 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Jan 13 01:40:03 2018 +0000" }, "message": "Revert \"Revert \"Move quickening info logic to its own table\"\"\n\nBug: 71605148\nBug: 63756964\n\nTest: test-art-target on angler\n\nThis reverts commit 6716941120ae9f47ba1b8ef8e79820c4b5640350.\n\nChange-Id: Ic01ea4e8bb2c1de761fab354c5bbe27290538631\n" }, { "commit": "6716941120ae9f47ba1b8ef8e79820c4b5640350", "tree": "76dd7d32703505d4ab44c0b55a7ecaf3ff66a94e", "parents": [ "7a26f948204377130be7b738d70d7365c86a804b" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 12 09:06:14 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 12 09:06:14 2018 +0000" }, "message": "Revert \"Move quickening info logic to its own table\"\n\nBug: 71605148\nBug: 63756964\n\nSeems to fail on armv7.\n\nThis reverts commit f5245188d9c61f6b90eb30cca0875fbdcc493b15.\n\nChange-Id: I37786c04a8260ae3ec4a2cd73710126783c3ae7e\n" }, { "commit": "7a26f948204377130be7b738d70d7365c86a804b", "tree": "dd3ab45b73127fdcbcdca64bbac484bfe2c0a8cd", "parents": [ "29504326da13831fa3060ac507927c4d76aa556a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 04 18:23:55 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 11 10:58:22 2018 -0800" }, "message": "Move quickening info logic to its own table\n\nAdded a table that is indexed by dex method index. To prevent size\noverhead, there is only one slot for each 16 method indices. This\nmeans there is up to 15 loop iterations to get the quickening info\nfor a method. The quickening infos are now prefixed by a leb\nencoded length. This allows methods that aren\u0027t quickened to only\nhave 1.25 bytes of space overhead.\n\nThe value was picked arbitrarily, there is little advantage to\nincreasing the value since the table only takes 1 byte per 4 method\nindices currently. JIT benchmarks do not regress with the change.\n\nThere is a net space saving from removing 8 bytes from each\nquickening info since most scenarios have more quickened methods than\ncompiled methods.\n\nFor getting quick access to the table, a 4 byte preheader was added\nto each dex in the vdex file\n\nRemoved logic that stored the quickening info in the CodeItem\ndebug_info_offset field.\n\nThe change adds a small quicken table for each method index, this\nmeans that filters that don\u0027t quicken will have a slight increase in\nsize. The worst case scenario is compiling all the methods, this\nresults in 0.3% larger vdex for this case. The change also disables\ndeduping since the quicken infos need to be in dex method index\norder.\n\nFor filters that don\u0027t compile most methods like quicken and\nspeed-profile, there is space savings. For quicken, the vdex is 2%\nsmaller.\n\nBug: 71605148\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I89cb679538811369c36b6ac8c40ea93135f813cd\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "daa27bcedade7ff2ee50fbdcbec11a4291b447ee", "tree": "9b99a0a2c20052ab253e81dd6270cf06eb142865", "parents": [ "70a58af9c733bc14c4573dddd282b3c02ccf4985", "6238c8331bf89ce35a377c6475034243a0791f28" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 05 17:36:37 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jan 05 17:36:37 2018 +0000" }, "message": "Merge \"Remove DexFile direct accesses to CodeItem\"" }, { "commit": "70a58af9c733bc14c4573dddd282b3c02ccf4985", "tree": "46fe53c06014ec4809f5f4c1dbd1e1c941349619", "parents": [ "9382c0d53f91f3788a5254495917898d8b61fe00", "2c64a837e62c2839521c89060b5bb0dcb237ddda" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jan 05 17:36:25 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jan 05 17:36:25 2018 +0000" }, "message": "Merge \"Change ClassStatus to fit into 4 bits.\"" }, { "commit": "2c64a837e62c2839521c89060b5bb0dcb237ddda", "tree": "65475ed2e313ff17354e741bac7e9c85739b8b95", "parents": [ "6cd0005698181e4cef2247b632d396e605d58fa3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jan 04 11:31:56 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 05 11:27:50 2018 +0000" }, "message": "Change ClassStatus to fit into 4 bits.\n\nIn preparation for extending the type check bit string from\n24 to 28 bits, rewrite ClassStatus to fit into 4 bits. Also\nperform a proper cleanup of the ClassStatus, i.e. change it\nto an enum class, remove the \"Status\" word from enumerator\nnames, replace \"Max\" with \"Last\" in line with other\nenumerations and remove aliases from mirror::Class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 64692057\nBug: 65318848\nChange-Id: Iec1610ba5dac2c527b36c12819f132e1a77f2d45\n" }, { "commit": "6238c8331bf89ce35a377c6475034243a0791f28", "tree": "7de5c1baa9bfe88100b73ca055e7fbf4895ba4d5", "parents": [ "a821bb1a71637dbd2e251795fce26f5f6f937299" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 04 09:55:13 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 04 15:25:47 2018 -0800" }, "message": "Remove DexFile direct accesses to CodeItem\n\nMotivation: StandardDexFile and CompactDexFile should be able to a\nhave different layout for code items.\n\nAlso addressed comments from a previous CL.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I5ea7a853b8095f68b4443ded0f599f2ac5efbd3a\n" }, { "commit": "73f21d45a41aaad1a02eecdf3bbdbf78ef599d5e", "tree": "88d52c615cd8ec5bd8d2fad44fddeef0911e2458", "parents": [ "d096b3a09f0e7129813fb663fec5b5f131565d71" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 02 14:26:50 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 02 17:53:21 2018 -0800" }, "message": "Remove CodeItem accessor functions\n\nThese are replaced by the accessor helpers.\n\nBug: 63756964\nTest: test-art-host\nTest: test/testrunner/testrunner.py --host -j30\n\nChange-Id: Ic93d60b68b684eeb5f69be286b4e15b8f8f97542\n" }, { "commit": "808c7a57bb913b13c22884f57cdacd59bf1fdb3f", "tree": "d7f0d7cabaac5a7646c25bae584a82a9aa279cc0", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 15 11:19:33 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 22 09:41:17 2017 -0800" }, "message": "Make CodeItem fields private\n\nMake code item fields private and use accessors. Added a hand full of\nfriend classes to reduce the size of the change.\n\nChanged default to be nullable and removed CreateNullable.\nCreateNullable was a bad API since it defaulted to the unsafe, may\nadd a CreateNonNullable if it\u0027s important for performance.\n\nMotivation:\nHave a different layout for code items in cdex.\n\nBug: 63756964\nTest: test-art-host-gtest\nTest: test/testrunner/testrunner.py --host\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nChange-Id: I42bc7435e20358682075cb6de52713b595f95bf9\n" }, { "commit": "890111968fbd3f5ae528d97e42984c12a3dd27bd", "tree": "edb4ed38332a817b7d3037ea260856cec839dca9", "parents": [ "0f13269734be07b5869005952a3cb91b0b34b73d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 13:45:05 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 15:43:45 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveMethod().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I2e47280e7cb8b84595130c4abfb5ece18d7f5c75\n" }, { "commit": "170331f0e44a0e07fcfe0b5932517e0500f5cd1f", "tree": "4bb837aa3b6e19c898df23894beb61957885e985", "parents": [ "39b378ca3b4b6dc6da1651b84ee4289cd9bff0f8" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 18:41:03 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 18:41:03 2017 -0800" }, "message": "ART: Remove base/logging from heap-inl.h\n\nHide the single uncommon VLOG and remove the include. Fix up\ntransitive includes.\n\nTest: m\nChange-Id: I917df597cb62c57040c1fb0e0079df4d95e5a658\n" }, { "commit": "57943810cfc789da890d73621741729da5feaaf8", "tree": "367677a982a45af98ffe3e79543615875e8550b4", "parents": [ "d5153627778e71ef68b510ce03c77467fa4d85bd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 21:39:13 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 16:26:11 2017 -0800" }, "message": "ART: Replace base/logging with android-base/logging\n\nReplace wherever possible. ART\u0027s base/logging is now mainly VLOG\nand initialization code that is unnecessary to pull in and makes\nchanges to verbose logging more painful than they have to be.\n\nTest: m test-art-host\nChange-Id: I3e3a4672ba5b621e57590a526c7d1c8b749e4f6e\n" }, { "commit": "3da1d0f0881e130ebab95e2d06abe7d2beff57f0", "tree": "00b655e97955b317e995e4884ac726a1146b489d", "parents": [ "5552e535951f2feb10bfd492b8abb54bd41a9f4b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 06 20:02:24 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 13 09:18:38 2017 -0800" }, "message": "Use CodeItemAccessor helpers for method verifier\n\nCreate a code_item_accessor_ in the verifier and replace the existing\ncode_item field. Added some handling in DexFile to deal with\ntry/catch items.\n\nBug: 63756964\nTest: test-art-host\nChange-Id: I4e073c9cb29f94518f0016fccbe1628185884df4\n" }, { "commit": "b7c273cb44fcbdab3c17ec69124fe4bbea2696b1", "tree": "11242e0bd24427183dd630780825214737ccbda1", "parents": [ "27f5fefeb4a7e87e9537fbdd0ed392d5c1de59df" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Nov 10 18:07:56 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Nov 10 18:07:56 2017 -0800" }, "message": "Add ClassDataItemIterator::HasNextMethod\n\nReturns true if there are either static of virtual methods remaining,\nchanged most places to use this where possible.\n\nSlight behavioral change for duplicate method checking, we not\npersist the method index across the static method / virtual method\nboundary.\n\nMotivation: Generic cleanup to remove copy paste.\n\nTest: test-art-host\nChange-Id: I7a1b507e681b2c40452f8a9913b53a96b181e171\n" }, { "commit": "69147f165efaa9da152bb37da3a16dd5d8c6cf3c", "tree": "25dbec549b8c06cf24729a577c76ef0b6d3d4c7f", "parents": [ "2202d56061941b4fecbdb018d84bcefb05b6c683" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 06 20:02:24 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Nov 09 19:06:10 2017 -0800" }, "message": "Add code item accessor helper classes\n\nAdd classes to abstract accesses to code item data. These classes\nhandle both standard dex and compact dex.\n\nAdded:\n- CodeItemInstructionsAccessor to handle code item instructions.\n- CodeItemDataAccessor to handle code item data excluding debug info.\n\nMoved inline_method_analyzer to use the new classes to test the new\nAPIs.\n\nBug: 63756964\nTest: test-art-host\nChange-Id: I9926acb77b81fa64ed4a3b49b7bed1aab30a0f33\n" }, { "commit": "0021feb36ca7021e2c255e6eaf16b967180290c6", "tree": "43f1ce8f6d91630a831d03b51a465d57c2a47119", "parents": [ "550c0aee52bf8981dfe1d22d3b661d61e80cc7ee" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 07 00:08:52 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 07 13:15:41 2017 -0800" }, "message": "Delete CodeItemIterator\n\nReplace uses with DexInstructionIterator.\n\nBug: 63756964\nTest: test-art-host-gtest\n\nChange-Id: I28c839c372edcb60583867355d46b14f8752d41b\n" }, { "commit": "5f317039d87d74f25d3b0a442072557086742d17", "tree": "6beae56f543d234b49a2f973dcbeb5f6f0bd2b90", "parents": [ "72627a5f675b1c664beb2ad33d60a1c8dca80826", "2b2bef245d5b2c6faa2d6f36da14866b2d8f5e4f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Nov 03 15:56:22 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Nov 03 15:56:22 2017 +0000" }, "message": "Merge \"Refactor DexInstructionIterator\"" }, { "commit": "33bff25bcd7a02d35c54f63740eadb1a4833fc92", "tree": "553db4f60878acf2a0fa7036a739d406df9a29b7", "parents": [ "321b3ca9a36d769283c64d4bdee0798db80af524" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 01 14:35:42 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 02 10:11:02 2017 +0000" }, "message": "ART: Make InstructionSet an enum class and add kLast.\n\nAdding InstructionSet::kLast shall make it easier to encode\nthe InstructionSet in fewer bits using BitField\u003c\u003e. However,\nintroducing `kLast` into the `art` namespace is not a good\nidea, so we change the InstructionSet to an enum class.\nThis also uncovered a case of InstructionSet::kNone being\nerroneously used instead of vixl32::Condition::None(), so\nit\u0027s good to remove `kNone` from the `art` namespace.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I6fa6168dfba4ed6da86d021a69c80224f09997a6\n" }, { "commit": "2b2bef245d5b2c6faa2d6f36da14866b2d8f5e4f", "tree": "7948ee1d32e211198a595bb7ed35558d22838da8", "parents": [ "f199f1d3a9816edf9282766a8874d894d7bf87c3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 26 17:10:19 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 01 15:36:21 2017 -0700" }, "message": "Refactor DexInstructionIterator\n\nAdd a way to get the dex PC for the \"for each\" use case.\n\nBug: 67104794\nTest: test-art-host\nChange-Id: I144c459c9a2a03ec8d56842280338d1f7ce1caf0\n" }, { "commit": "1d2d4ff8570bb88d9d2d4633706fd7f6fb18d75e", "tree": "cbe67e8e9214828656314117121e8ce906a762ab", "parents": [ "e5b35ed787fbfb388d162361310bae5b0e7682a7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Sep 23 16:11:06 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 27 11:51:53 2017 -0700" }, "message": "Add DexInstructionIterator and use it a few places\n\nMotivation:\nWant to start abstracting away dex specific functionality to enable\nCompactDex. Adding an iterator will enable CompactDex iteration to\nwork differently than normal dex iteration.\n\nWill eventually replace CodeItemIterator.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I90e67c1a994b7698aaac0523a82816b0a003fbdc\n" }, { "commit": "d8dbc8da0e5cc6b5c2176ce2d3877e6194d72c0c", "tree": "af6e9fb02471d75ebdea46190a0aa3e9dbdb892d", "parents": [ "93780a60090356921b844dbefdc13442c9f18b52" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 20 13:37:47 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 20 15:55:10 2017 +0100" }, "message": "Refactor compiled_method.h .\n\nMove LinkerPatch to compiler/linker/linker_patch.h .\nMove SrcMapElem to compiler/debug/src_map_elem.h .\nIntroduce compiled_method-inl.h to reduce the number\nof `#include`s in compiled_method.h .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: Id211cdf94a63ad265bf4709f1a5e06dffbe30f64\n" }, { "commit": "fc8b422c286501346b5b797420fb616aaa5e952a", "tree": "61c857a895cdad9ce387a899f92824701259df32", "parents": [ "7090dfe84f78b1928fcbdfd664d0dd9ea52633ff" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Sep 17 13:44:24 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Sep 18 10:57:06 2017 -0700" }, "message": "Clean up AtomicDexRefMap\n\nMake ClassReference, TypeReference, and MethodReference extend\nDexFileReference. This enables using all of these types as the key\nfor AtomicDexRefMap.\n\nTest: test-art-host\nBug: 63851220\nBug: 63756964\n\nChange-Id: Ida3c94cadb53272cb5057e5cebc5971c1ab4d366\n" }, { "commit": "486dda03900a215650f71a9068759978aa77c699", "tree": "1f2a1331d3ec474c979db5f9a35dd11f453abc25", "parents": [ "b072ec25f8a71420ee77b068a28a2669420f6150" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 11 14:15:52 2017 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Sep 15 12:45:28 2017 +0100" }, "message": "Add support for registering classpath classes status.\n\nBy doing class unloading after each dex file compilation, we are loosing\naway verification done on classpath classes.\n\nThis change introduces a new table for keeping around class status of\nclasspath classes.\n\nMultidex quickening compilation improved by ~5% by not re-verifying classpath\nclasses.\n\nBug: 63467744\n\ntest: test.py\ntest: golem successfully compiles FB\nChange-Id: I629c0a7d86519bbc516f5e59f7cd92ca6ca842eb\n" }, { "commit": "5d3b002b9a244b5dc25fe97fedcb92851d9073f7", "tree": "46203949455b1087fe36158da75af3af3db127aa", "parents": [ "ee5303f76ef167714a6a04d3abc502584ac5e103" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 31 10:36:31 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 05 10:57:39 2017 -0700" }, "message": "ART: Change CanAssumeVerified to GetPreviousClassState\n\nReturn any stored class state instead of a bool to allow more\nrecognized states in the future.\n\nBug: 63467744\nBug: 65318848\nTest: m test-art-host\nChange-Id: Id097273a41e09ee77c8d53377ad9beb09104a944\n" }, { "commit": "2c30e4a2a2bd73c3e9d327d4b5d059b75cc0f798", "tree": "698286ee61f457069b5a53ca6869319b8d9e5acb", "parents": [ "3157fc26d96951ff4acfb4feb4597e74a92da2a7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 23 11:31:32 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 23 16:06:00 2017 -0700" }, "message": "ART: Remove art and art/runtime include_dir directives\n\nRemove some overly broad or unnecessary include directives. Fix up\ncode.\n\nTest: mmma art\nChange-Id: Ic2da319f39102d59566e780f3e15fe007a3c36d6\n" }, { "commit": "9e050df94df5c6736e1e24705194f62fbc119114", "tree": "0fe2c2a7a9e01cba8abaf449938503e5b906ee78", "parents": [ "1bd8e5a1b2055e0ff7977ba7e149534d2ee0a696" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 09 10:05:47 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 09 11:16:52 2017 -0700" }, "message": "Revert \"Revert \"Support class unloading in dex2oat for quicken multidex\"\"\n\nBug: 63467744\nTest: test-art-host\n\nThis reverts commit 6921d90a241f0307ac25120f8f976744d4a57706.\n\nChange-Id: If70e31d3a15579dc75fd40bfef186e0124568c87\n" }, { "commit": "6921d90a241f0307ac25120f8f976744d4a57706", "tree": "04365479a12f9be9bfee324395284eb28391d965", "parents": [ "0b1c341d2d89a483142cd14bdeb4650ab00184f1" ], "author": { "name": "Richard Uhler", "email": "ruhler@google.com", "time": "Wed Aug 09 10:12:06 2017 +0000" }, "committer": { "name": "Richard Uhler", "email": "ruhler@google.com", "time": "Wed Aug 09 10:12:06 2017 +0000" }, "message": "Revert \"Support class unloading in dex2oat for quicken multidex\"\n\nThis reverts commit 0b1c341d2d89a483142cd14bdeb4650ab00184f1.\n\nNew test Dex2oatDeterminism.UnloadCompile fails on bots gtest-debug-gc and friends.\n\nChange-Id: Ib101fc4390d90f88fe017d8482775d5e975f2ccb\n" }, { "commit": "0b1c341d2d89a483142cd14bdeb4650ab00184f1", "tree": "1eb65853f4a9c53fda1a778911dd32979ef43e32", "parents": [ "5129d8ede52ea31c0304ecaa8013f833310772a2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jul 14 18:23:25 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Aug 08 12:44:39 2017 -0700" }, "message": "Support class unloading in dex2oat for quicken multidex\n\nSupport class unloading for the quicken compilation filter. This will\nbe enabled in a follow up CL.\n\nAdded a test that compares with and without unloading. The way that\nit tests this is by adding an output app image. Having an app image\ndisables the unloading. This test also covers that app images don\u0027t\nchange the odex (currently).\n\nAdded a test for the assumed verified logic.\n\nBug: 63467744\nTest: test-art-host\nTest: test/testrunner/testrunner.py --interpreter --host -j40\nChange-Id: I1e8a862c6f089c06c58aa0c846797e4c24bd072c\n" }, { "commit": "72041a0dcb5b7c133b79a1d6783a23039f2136bd", "tree": "8de4326eff202726c1ab893c536190aba87334be", "parents": [ "9ce960ab2b4c789ad364ad96ec5c660c60e4f90c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jul 14 18:23:25 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jul 28 17:09:39 2017 -0700" }, "message": "Use class unloading in dex2oat for verify and extract\n\nUnload the main classloader in between each dex file compilation to\nreduce RAM. This frees the whole java heap and associated linear\nallocs. This is only used for quickening since filters that do\ncompilation may require loaded classes in the compiler and oat\nwriter.\n\nThis reduces dex2oat peak PSS for compiling a large app from 196MB\nto 135MB.\n\nOnly works for verify and extract since the current approach is\nincompatible with oat writer patching. b/63911263\n\nAdded a verification override that reads the compiled class status\nto avoid ever verifying classes that were quickened (since this\nis not supported and causes failures).\n\nThere is still some duplicated verification for some class with\nsuperclasses in other dex files.\n\nSupport for quicken will be added in a follow up CL.\n\nBug: 63467744\nTest: test-art-host\nTest: test/testrunner/testrunner.py --interpreter --host -j40\nChange-Id: Id0e4f84eb5db91d6143f752b498f4832a5b25b6e\n" }, { "commit": "34ed868f9384ab37da1119b3d84bcd24fd3c91a7", "tree": "8ec833faeb58638c943d0815b4a2abd6b3a790ed", "parents": [ "acae6dbe80d07a26a973587b6f838198e13e66c3" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 21:41:13 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 23:06:53 2017 -0700" }, "message": "Revert \"Avoid creating verified methods for non quickening filters\"\n\nThis reverts commit 2848a5f8df6a82ff436c67f6b92c8f0d49ae6788.\n\nSuperseded by commit 0733dc87518d2c8fc1ba2196c9f5cc9729de7c20.\n\nBug: 63467744\nTest: Compile an app with compiler-filter\u003dverify\nTest: test-art-host\nChange-Id: Ieb894b6defed1a1ee14425baeda1f77ef138e2a4\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "c73753f70ab4fc9a166637bee514b292f0fa0109", "tree": "a464e300d44b5a3eca10cb00cc42be7c1ab9da96", "parents": [ "530a6b6902b50db43659757a6270b7d111d93a2c", "07bfbace6f835e6c748fd68ec7624992478b16c1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 21 09:41:58 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jul 21 09:41:58 2017 +0000" }, "message": "Merge \"Hash-based DexCache methods array.\"" }, { "commit": "a9894d24088ed066aa534ba7c157ab2f1e11cd71", "tree": "6d72affd2c3fba3d9713f34d11e13aceddd77d91", "parents": [ "2f1d924e9cd34d081d6c37332e4e8f0f0d191b85", "e01b6f674a865a3aef7d66cd91a2d2e226587b50" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 20 18:31:23 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jul 20 18:31:23 2017 +0000" }, "message": "Merge \"Move IsVeryLarge check before we create verification results\"" }, { "commit": "e01b6f674a865a3aef7d66cd91a2d2e226587b50", "tree": "1d99c6889746d829a86b375b3d88552f29461b7e", "parents": [ "e8f48da635c4d07bbe431e5819da8e1fad91a8ef" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 19 16:55:04 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 20 09:36:26 2017 -0700" }, "message": "Move IsVeryLarge check before we create verification results\n\nOtherwise we can end up creating verification results when they are\nnot actually needed (if the compiler filter was \u003e\u003d quicken).\n\nBug: 63467744\nTest: test-art-host\nChange-Id: Ied2a12e0e4c2010f3f660e278c3a5111545ba251\n" }, { "commit": "07bfbace6f835e6c748fd68ec7624992478b16c1", "tree": "5d094a00fbc90455bd9b53e042cf8b4fe8433462", "parents": [ "ba118827465d12177f3996e50133960087b1c916" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 06 14:55:02 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 20 16:33:00 2017 +0100" }, "message": "Hash-based DexCache methods array.\n\nTotal boot*.art size for aosp_angler-userdebug:\n - arm64:\n - before: 11603968\n - after: 10129408 (-1.4MiB, -12.7%)\n - arm:\n - before: 8626176\n - after: 7888896 (-0.7MiB, -8.5%)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Nexus 6P boots.\nTest: testrunner.py --target\nTest: Build aosp_mips64-eng\nBug: 30627598\nChange-Id: I7f858605de5f074cbd7f0d9c4c072fbd44aee28f\n" }, { "commit": "ba118827465d12177f3996e50133960087b1c916", "tree": "f39728cdafc7810004d51c0bef2728b98993daa9", "parents": [ "64a102dde8c5daad83b991710decb418ce43aac5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 12 15:41:56 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 20 13:35:06 2017 +0100" }, "message": "ART: Change method lookup to be more consistent to JLS and the RI.\n\nThe method lookup for different invoke types was previously\nwidely different and didn\u0027t work well with the dex cache\nmethod array where we have only a single slot for each\nMethodId. The new behavior is to perform the same lookup for\nall cases, distinguishing only between interface and\nnon-interface referencing class, and to further align the\nbehavior with the JLS and the RI. Where the JLS conflicts\nwith the RI, we follow the JLS semantics.\n\nThe new lookup for class methods first searches the methods\ndeclared in the superclass chain (ignoring \"copied\" methods)\nand only then looks in the \"copied\" methods. If the search\nin the superclass chain finds a method that has not been\ninherited (i.e. either a private method or a package-access\nmethod where one of the classes in the chain does not belong\nto the same package, see JLS 8.4.8), we still search the\n\"copied\" methods as there may actually be a method inherited\nfrom an interface. This follows the JLS semantics where\ninherited methods are included in the search (JLS 15.12.2.1)\nbut conflicts with the RI where the private or\npackage-access method takes precedence over methods\ninherited from interfaces.\n\nNote that this search can find an accessible method that is\nnot inherited by the qualifying type, either for a package\naccess method when the referrer is in the same package but\nthe qualifying type is in another package, or for a private\nmethod where the referrer is in the same class but the\nqualifying type is actually a subclass. For the moment we\nallow such calls and we shall consider whether to throw\nan IncompatibleClassChangeError in this situation in future\nto comply with JLS 15.12.4.3.\n\nThe new lookup for interface methods searches the interface\nclass, then all the superinterfaces and then the\njava.lang.Object class, see implicitly declared methods in\ninterfaces, JLS 9.2. The search for the maximally-specific\nnon-abstract superinterface method is not yet implemented,\nbut the difference should be difficult to observe as the\nusual subsequent call to FindVirtualMethodForInterface()\nshould yield the same result for any matching method.\n\nThe new test 162-method-idx-clash exposes several cases\nwhere we previously completely messed up due to the effects\nof the DexCache, or where we were out of line with the RI.\nIt also tests a case where the JLS and the RI disagree and\nwe follow the JLS.\n\nTest: art/test/run-test --host --jvm 162-method-resolution\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --interp-ac\nTest: Nexus 6P boots.\nTest: testrunner.py --target\nBug: 62855082\nBug: 30627598\nChange-Id: If450c8cff2751369011d649c25d28a482a2c61a3\n" }, { "commit": "0d32f4eb356b7823ee39a09e62dfcb496a6cc049", "tree": "28f669c9e993ca22477690f415a9a553e27a68a2", "parents": [ "1847704d0422dcc75ac30ae0d3caaf210c05a755", "93764b8ee58d54118904b8f4473628451e568893" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Jul 18 03:23:31 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jul 18 03:23:31 2017 +0000" }, "message": "Merge \"Generalize atomic_method_ref_map to support dex references\"" }, { "commit": "93764b8ee58d54118904b8f4473628451e568893", "tree": "729758b4420920b7bb7070dbdac1ecd86810b2a8", "parents": [ "d317295ed07384c69d5890d6b17b80d57139a082" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 17 14:51:53 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 17 18:01:17 2017 -0700" }, "message": "Generalize atomic_method_ref_map to support dex references\n\nGeneralize atomic method ref map to support dex references instead\nof only method references.\n\nThe goal is to use this in a future CL to replace compiled_classes_.\n\nTest: test-art-host\n\nChange-Id: Ic6d1e619584f790eea68f5160fa0fcd664524cd7\n" }, { "commit": "0733dc87518d2c8fc1ba2196c9f5cc9729de7c20", "tree": "5dfbd7beba81527b31634fa6920b8f0c1f996007", "parents": [ "71a8e5b25f0be5ab5bf0e1c73a9e5aabc3a23488" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 17 14:05:28 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 17 16:54:33 2017 -0700" }, "message": "Avoid creating verification_results_ unnecessarily\n\nFor compiler filters that don\u0027t quicken or compile, avoid creating\nthe verification results. This avoids creating some arrays that\nwere using a few MB of RAM in some cases.\n\nFor a large app verify compile:\nMaximum resident set size (kbytes): 258948 -\u003e 254300\n\nBug: 63467744\nTest: test-art-host\n\nChange-Id: I1d0536b2a6a5c301396641371915394cf4c0e5f3\n" }, { "commit": "2848a5f8df6a82ff436c67f6b92c8f0d49ae6788", "tree": "af3b0a19e61831bdda8be04b4859a19ca9117d76", "parents": [ "65d793bfa91085db5f84b6ee90a3dcdafcafed1b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Jul 15 15:18:00 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 17 10:34:33 2017 -0700" }, "message": "Avoid creating verified methods for non quickening filters\n\nFilters that don\u0027t do either quickening or compiling don\u0027t need\nverified methods. Avoiding allocating these saves a non-trivial\namount of RAM during compilation.\n\nBefore (PSS compiling a very large app):\nPeak PSS: 215014K, native RAM 59378392B\n\nAfter:\nPeak PSS: 207815K, native RAM 52917928B\n\nBug: 63467744\nTest: Compile an app with compiler-filter\u003dverify\nTest: test-art-host\n\nChange-Id: I493a1c4a8a152b835d5e950192974c4da5b96ae3\n" }, { "commit": "de4b08ff24c330d5b36b5c4dc8664ed4848eeca6", "tree": "79835478b8b631bbf006b5e023704f3cf53bda7c", "parents": [ "c9267c48979698a9217760c914aba13ea20b5990" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 10 14:13:41 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 12 17:54:49 2017 -0700" }, "message": "Reduce quicken info size\n\nMove the quicken info from using a map of \u003cdex pc, index\u003e to an array\nof indices. Removed leb encoding since it is harmful for 16 bit\nindices. The map is indexed by the dequickenable instruction index\nfrom the start of the code item.\n\nNumbers for a certain large app compiled with quicken filter:\ndex2oat native alloc: 85345936B -\u003e 81527072B\noat file size: 9068968B -\u003e 8659368B\nvdex file size: 90479120B -\u003e 86321184B\n\nBug: 63467744\nBug: 36457259\nTest: test-art-host\n\n(cherry picked from commit 959f348acabc48efbb18c547dad6300c0f610c1c)\n\nChange-Id: I85546d8cd409cbf96140cbdddabd7e228797b9e3\n" }, { "commit": "e17cf243978ca7f5356e746ee460f0fcf04e04a6", "tree": "e8ad423bf1dee5756fec451ba22db749ed4f5472", "parents": [ "2bc159ebd1115f71d80639e47fc38663aa84ba4a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 19 11:05:51 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 19 11:11:12 2017 -0700" }, "message": "Add field/method skipping helper functions to DexFile\n\nSpecifically added SkipStaticFields, SkipInstanceFields,\nSkipAllFields, SkipStaticMethods, and SkipVirtualMethods.\n\nAlso applied the helpers to the code base.\n\nTest: test-art-host\nChange-Id: Idda77f9a6e2564c2e588d2bbe11cc320063fdb32\n" }, { "commit": "1cfea7af6f38cd06393fed3e466701869ce8b2c3", "tree": "3e3b185eeb4ce0c6a2cc3184e0305f37151261c2", "parents": [ "d38b67c9892b603f57a6b51a1b9d7f4e610158aa" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed May 24 14:44:38 2017 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 14 10:53:48 2017 +0100" }, "message": "Code cleanup around vdex.\n\n1) Handle the vdex in dex2oat instead of compiler_driver\n2) CHECK instead of DCHECK that we don\u0027t dexlayout with vdex.\n\nTest: test.py\nChange-Id: Idf7be59bb25708181e391d17128480659ac697e5\n" }, { "commit": "f45d61c0866461c9476f17644b27dc0664d507c5", "tree": "95d2837a03d451cccd82cad61924980beb5fd0d4", "parents": [ "83b140474aa1759739c8ee4464bf226c4fa0f6d7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 07 10:29:33 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 17:19:51 2017 -0700" }, "message": "ART: Fix or disable some tidy warnings.\n\nAdd a strlcpy shim for the host, so we can use strlcpy instead of\nstrcpy everywhere.\n\nFixed warnings include unused-decls, (some) unreachable code, use\nafter std::move, string char append, leaks, (some) excessive padding.\n\nDisable some warnings we cannot or do not want to avoid.\n\nBug: 32619234\nTest: m\nTest: m test-art-host\nChange-Id: Ie191985eebb160d94b988b41735d4f0a1fa1b54e\n" }, { "commit": "5d08fcc21a14190c4dba3028a3e35d281afdd016", "tree": "c42de65ced190778342d9b022e400f4a7f9d346b", "parents": [ "57cf00bde719ddc84a6015b107b90a20169e3099" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 05 17:56:46 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 05 20:28:16 2017 -0700" }, "message": "ART: More header cleanups\n\nPull out more dependencies through forward declarations.\n\nTest: m test-art-host\nChange-Id: I7d86726928937f788b956ec9eac91532d66d57ae\n" }, { "commit": "b486a98aadc95d80548953410cf23edba62259fa", "tree": "b113b7d50a4a015502873b7742c9ece00d293e84", "parents": [ "1656ca9e6996cb555b4463e5efd4bd7e3f4fb816" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 13:45:54 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jun 02 08:24:02 2017 -0700" }, "message": "ART: Introduce thread-current-inl.h\n\nFactor out Thread::Current() code into its own -inl file to remove\ntransitive includes.\n\nThis requires at the same time correcting mutex.h, i.e., moving\nsome functions into mutex-inl.h.\n\nTest: m test-art-host\nChange-Id: I88f888b604e0897368d9b483edce6ce4332dd9c9\n" }, { "commit": "26699c6b66546dad072ee3c5b1401fdf6a7503aa", "tree": "a1e37d2de86d623bc7cb4d4ab828b254eb17c5d8", "parents": [ "30148eefec1bb45f152172833afde82af0866b9f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri May 12 08:19:28 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri May 12 09:15:44 2017 -0700" }, "message": "ART: Refactor VerifiedMethod\n\nOnly a small percentage of methods have a non-empty safe-cast set.\nChange VerifiedMethod to use a pointer to a set.\n\nReduces native allocations at compile time. For a large well-known\napplication, VerifiedMethod memory drops from 12.7MB to 6.3MB.\n\nBug: 38250868\nTest: m test-art-host\nChange-Id: I6f0128a2cf09a8afb29027b24975aec12054ce2f\n" }, { "commit": "4e868fa7b8c47600695ff92deeb373674956a67d", "tree": "acdb92a2b765cc87a08459267e430a8866e608cf", "parents": [ "4dc06e2ef900132d8395539842c35533da8b912a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 21 17:16:44 2017 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Apr 27 16:04:13 2017 +0100" }, "message": "Make vdex and dexlayout compatible.\n\nUnquicken the vdex before dexlayout, to keep the dex integrity.\n\nbug: 37558732\nTest: run-test with speed-profile\n\nChange-Id: Ifcd5c2e4378ccb0df0a66d07f68df31d94b83220\n" }, { "commit": "4dc06e2ef900132d8395539842c35533da8b912a", "tree": "2114165e7cb3fe775537d2ebc728bbd5ed696479", "parents": [ "8e2252df6fbd1313ca17724be36199d32e8e44cc", "49cda06d5bf003f588ba7839bbf89d606237dfa7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Apr 27 11:40:05 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Apr 27 11:40:07 2017 +0000" }, "message": "Merge \"Rename and obsolete compiler filter names.\"" }, { "commit": "6b8b07521125e7744327d00e64f897b4dd5d1db9", "tree": "1a8d6cd6c50fdcb5edc388588e36eb41c78e1324", "parents": [ "e0ffd22714fd4bc4edf81000966b98eae59788dd", "a1d2f957a21319d1110bebb9a52f46fd1c67ffaf" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Apr 21 18:57:25 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Apr 21 18:57:27 2017 +0000" }, "message": "Merge changes I6ff2d6f8,I8f60f116\n\n* changes:\n ART: Clean up art_field.h\n ART: Clean up art_method.h\n" } ], "next": "6b040570b5f71bdb6a0aacf51a7613edf35785b7" }