)]}' { "log": [ { "commit": "2cd21b20345c2733bda1366830ffd767f0682b9f", "tree": "d0608ef42e7be046bf6134cd9e5994db3310d389", "parents": [ "7c5acbb122485b6215dc34defc1f19e07390bb95" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Apr 25 12:58:10 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Apr 26 03:25:04 2019 +0000" }, "message": "ART: Make bad_mutexes abort message legible\n\nRemember the actual violation and use it as the abort message.\n\nBug: 131324618\nTest: m test-art-host\nChange-Id: I4c3edb328501917b838ec1b3443e454c6ac1a13f\n" }, { "commit": "81dc7ab1df59021463757e06a95b2abc937a73db", "tree": "3ae773ed2d58546cfd0bfd8c07f659985d75bdd6", "parents": [ "fe9181db92a778c4ef3c4d25e0302553bf970e26" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Fri Apr 19 17:34:31 2019 -0700" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Thu Apr 25 16:06:24 2019 +0000" }, "message": "Speed up and slightly simplify Mutex\n\nEliminate the separate seqentially consistent contention counter load\nin Mutex::ExclusiveUnlock by putting the contenion counter in the\nMutex\u0027s state word.\n\nReplace some CHECK_GE checks with CHECK_GT. We were checking quantities\nintended to be non-negative against \u003e\u003d 0 just before decrementing them.\n\nRemove a pointless volatile declaration.\n\nIntroduce constants for the first FUTEX_WAKE argument. Remove all uses\nof -1 as that argument, everywhere in ART. It appears to work, but the\ndocumentation says it\u0027s wrong.\n\nThis does not yet address the ReaderWriterMutex issue, which is handled\nin a different way in a separate CL.\n\nBenchmark runs with and without this CL weakly suggest a tiny, not\nstatistically significant, improvement in both time and space with this\nCL.\n\nBug: 111835365\nTest: Build and boot AOSP. TreeHugger.\nChange-Id: Ie53c65f2ce774a8cb4d224e2c1b3a110eb880f0c\n" }, { "commit": "467b692bfa088098d57947ed3d764fbf1a072974", "tree": "88ab3ab12a8ca1f539cabed92f067cec5d00f8ea", "parents": [ "1973687350e8431d316655c00fc0701c0e1c4597" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Mon Apr 22 16:15:53 2019 -0700" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Wed Apr 24 17:04:44 2019 +0000" }, "message": "Use single contention counter for rw mutexes\n\nThis halves the number of sequentially consistent contention counter\nloads when we release a mutex.\n\nThis is more expensive than keeping the contention counter as part\nof the state word. But schemes to do that either risk overflow, or\nseem more subtle than we we would like at this stage. This gets us\nhalf-way to where we would like to be. And, since we were previously\nalways looking at both counters anyway, it seems like low risk\nchange.\n\nBug: 111835365\nTest: Build and boot AOSP, TreeHugger\nChange-Id: I752859f6c51283de3ba5078233d2873a733ad4a1\n" }, { "commit": "66834468e9106e264a74766c17a0c047a3448921", "tree": "be827201de65b3dc888182c949ac580e084a0fb4", "parents": [ "11d5a2507adf5a6d06adca5f18c399b826883182" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Apr 08 16:28:29 2019 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Apr 10 22:42:02 2019 +0000" }, "message": "Revert^2 \"Perform SetEvent under the user_code_suspend_count_lock_\"\n\nIf we needed to condition-wait for a gc to finish we would trigger an\noverly restrictive deadlock check. This passed testing because\nnormally the Wait will not be executed. To prevent this type of issue\nfrom occuring in the future we added a way for code to assert that\ncondition-waiting is allowed without actually going to sleep.\n\nThis reverts commit eaa4831142fa58f176ddad52c0d5e9c288e26b81.\n\nReason for revert: Relaxed too-strict check in CheckSafeToWait.\n\nTest: ./test.py --host\nBug: 130150240\n\nChange-Id: I8359e595cdd73f49cb68c8c70d755cab0e563ac7\n" }, { "commit": "119733d87242414100df7b9eedb6d1672a03ead6", "tree": "19ba75bd42d3c94a4de0684ae66f4078da1546a6", "parents": [ "8a64e773d4d1221166c6a8206315b450e448705a" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 15:14:41 2019 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jan 31 15:39:55 2019 +0000" }, "message": "Revert \"Revert \"ART: introduce PALette abstraction layer\"\"\n\nThis reverts commit e6e01a0a00de80704ccb21c48d5d8bdee4470b77.\n\nBug: 122824298\nTest: art/test/testrunner/run_build_test_target.py -j50 art-test-javac\nTest: m out/target/common/obj/PACKAGING/hiddenapi-stub-flags.txt\nTest: frameworks/rs/build_rs.py\nChange-Id: If7b9ddca3daa80b75b3541abd283bf47d5b81118\n" }, { "commit": "e6e01a0a00de80704ccb21c48d5d8bdee4470b77", "tree": "8f9cc651764686140accaadcfb8f77bf7572c24b", "parents": [ "4b9d00aca9b025b545c9633b4605334c22fc4d2d" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 14:02:30 2019 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 14:02:30 2019 +0000" }, "message": "Revert \"ART: introduce PALette abstraction layer\"\n\nThis reverts commit 4b9d00aca9b025b545c9633b4605334c22fc4d2d.\n\nReason for revert: breaks renderscript mac and run_host_tests in master.\n\nChange-Id: I6024894a384c65f3e7d81b9c5bba8ebe8ce1b420\n" }, { "commit": "4b9d00aca9b025b545c9633b4605334c22fc4d2d", "tree": "7984bf247f908d145b7c6b48df99f3f0a80ae148", "parents": [ "4ee4561f2153f3b0bc3be2e781488a97c73ca58e" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jan 03 17:04:02 2019 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 09:00:27 2019 +0000" }, "message": "ART: introduce PALette abstraction layer\n\nThis change decouples direct dependencies on system libraries.\n\nBug: 122824298\nTest: art/test.py --host --64\nTest: art/test.py --target -j8\nTest: m -j100 \u0026 flashall -w \u0026 device boots\nTest: art/build/apex/runtests.sh\nChange-Id: Iae927ed9aaa228a941cd444cef04e6ec53955299\n" }, { "commit": "7cc45fd1dbcf5704e442d0443e437aa2ae3fe21b", "tree": "76e582afd0580be21497787c584cab61f7599997", "parents": [ "03eb36c6940060f82f887b3e8860a91c1f97224c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 21 16:03:08 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 06 11:37:19 2018 -0800" }, "message": "ART: Factor out lock order and holder from mutexes\n\nIsolate the order and holder class from the mutex definitions.\nThe locks header requires significantly fewer includes, and\nwill be used in a follow-up change to remove mutex.h dependencies\nin headers just for the sake of annotation lock requirements.\n\nThis is itself an NFC commit, only pulling the code apart.\n\nBug: 119869270\nTest: m test-art-host\nChange-Id: I11ca161ac3118725c79313a82f58595699b590bf\n" }, { "commit": "7530bae4f286d828d6394303ee2622c1b01b7e43", "tree": "6232fa29b6ce0dd2d4ac4cc47615ee08d9da59a9", "parents": [ "97d40f9c7b1157783d09861ce76d3a0b3da73cbe" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Mon Oct 29 20:03:51 2018 -0700" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Wed Oct 31 18:40:21 2018 +0000" }, "message": "Use _PRIVATE versions of futex ops.\n\nThis flag allows some performance optimizations in the kernel for futex\nwords that are only used in one process.\n\nTested: art$ grep FUTEX_ **/*.cc **/*.h\n\nChange-Id: I490b9592ca0f0ab5ab5431682e8b2104f5c917ca\n" }, { "commit": "2947ba6f1a14d7ea30aa60c3032fa07585cce1b4", "tree": "f73195582a9e59b190367b5de19b4c1e8fa2a0f4", "parents": [ "41ae033a4214208b589d8e1df423084728e08716", "bcd16eef679c4a11f20e6534b245a52443b6d521" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Oct 31 14:31:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Oct 31 14:31:30 2018 +0000" }, "message": "Merge \"Requeue rather than wake when notifying.\"" }, { "commit": "bcd16eef679c4a11f20e6534b245a52443b6d521", "tree": "218339ad91bfca357553ba33b89a215ff8db348c", "parents": [ "f4fd65e393fe60f17e22ee7823f8dce4594c053d" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Mon Oct 22 13:03:23 2018 -0700" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Thu Oct 25 09:09:09 2018 -0700" }, "message": "Requeue rather than wake when notifying.\n\nRequeueing avoids contention when the newly-awoken waiter attempts to\nacquire the lock held by the notifier.\n\nBug: 117842465\nChange-Id: I78646245b538022012d546df12514f5d43d9f234\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "2d899c41ac389ab881a56a82380e7bdb91fbbcc8", "tree": "cc0a13d666ad7b767f76261e1917a1f7039d8cd6", "parents": [ "6e82b7e6726d2c2ed0d6754ce1557d00e051b52c" ], "author": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Wed Oct 17 16:03:42 2018 -0700" }, "committer": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Wed Oct 17 16:03:42 2018 -0700" }, "message": "Fix usages of TEMP_FAILURE_RETRY(pthread_foo(...)).\n\npthread functions don\u0027t return -1 and set errno on failure, they return\na positive errno value instead.\n\nTest: treehugger\nChange-Id: I0097660e44c86c4c49d642e1169a30e43f9662bf\n" }, { "commit": "c55bb390d88b8eb62a50932f7f9b47c2a3733f16", "tree": "ec2e74f3f8404dffcb9bfde4e7ffa3416a35543d", "parents": [ "89468aeaa6a67ae4025b30d427391186306d6522" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 21 00:02:02 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 18:37:12 2018 -0700" }, "message": "Revert^2 \"ART: Refactor typedef to using\"\n\nThis reverts commit ee07743e03042c2ca36e0c9513847a9e7d2509f1.\n\nReason for revert: fixed attributes.\n\nBug: 32619234\nTest: m test-art-host\nTest: m test-art-target-gtest-unstarted_runtime_test\nChange-Id: I6f0a775adfdf6ecd132b470f7c5446e949872e20\n" }, { "commit": "ee07743e03042c2ca36e0c9513847a9e7d2509f1", "tree": "66867d7443a3798f6d882ef2715ddeb7baf3e771", "parents": [ "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "message": "Revert \"ART: Refactor typedef to using\"\n\nThis reverts commit 9a20ff06f7ccee08a742c315ec6d351ab56ba1cd.\n\nReason for revert: Attributes on the wrong side.\n\nBug: 32619234\nChange-Id: I8fd2abef619b22c02ccfbf5ae629339f1a60918b\n" }, { "commit": "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd", "tree": "7e55557e118eb5fffe03ad3456e00d8469a36232", "parents": [ "70dfb6983492aff1c52cc1b52044258aef51f47f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 10:58:18 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 21:56:32 2018 -0700" }, "message": "ART: Refactor typedef to using\n\nAdd clang-tidy\u0027s modernize-use-using.\n\nBug: 32619234\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: If50d37b5152af4270784e3cde7951292a9e19033\n" }, { "commit": "bbc6e7edb5fca4a61ac53dd9bce79cb4f0bb3403", "tree": "0fbce767bc383358cf4cd65aafc74140e1850982", "parents": [ "19379b58bd433da91230e4fe6cd96e7416d16adc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 24 16:58:47 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Aug 28 11:06:07 2018 +0100" }, "message": "Use \u0027final\u0027 and \u0027override\u0027 specifiers directly in ART.\n\nRemove all uses of macros \u0027FINAL\u0027 and \u0027OVERRIDE\u0027 and replace them with\n\u0027final\u0027 and \u0027override\u0027 specifiers. Remove all definitions of these\nmacros as well, which were located in these files:\n- libartbase/base/macros.h\n- test/913-heaps/heaps.cc\n- test/ti-agent/ti_macros.h\n\nART is now using C++14; the \u0027final\u0027 and \u0027override\u0027 specifiers have\nbeen introduced in C++11.\n\nTest: mmma art\nChange-Id: I256c7758155a71a2940ef2574925a44076feeebf\n" }, { "commit": "33b7b5da331e0a10fc615c8df72ba2aefad4e3fb", "tree": "4894623ad71bf957c25009e35e1b57ba501bb9c3", "parents": [ "134380d7c70d95962ed818458185e608ad17ff08" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:13:51 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Aug 17 14:40:51 2018 -0700" }, "message": "Revert^2 \"Fix race in CommitCodeInternal and cleanup\"\n\nThis reverts commit 8dde74eb7bec8e989f34d86a01c26b0f5c7e6443.\n\nWe were failing to do a null check in cha.cc. Due to compiler\noptimizations this would actually run without error on non-asan\nbuilds, causing the error to pass testing.\n\nReason for revert: Fixed issue causing asan issue.\nTest: run asan tests\n\nChange-Id: Ic5492c69b7735555108d8b18c8e687ce510c4549\n" }, { "commit": "8dde74eb7bec8e989f34d86a01c26b0f5c7e6443", "tree": "e94f5e620f27b3d6dcb3b634bc25bf0274b1143b", "parents": [ "a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:11:05 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:11:05 2018 +0000" }, "message": "Revert \"Fix race in CommitCodeInternal and cleanup\"\n\nThis reverts commit a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c.\n\nReason for revert: Seems to cause the asan gtests to fail.\n\nChange-Id: I0c7b4720de16f9b2b4e1e27c3c4e57a018c59a0c\nTest: none\n" }, { "commit": "a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c", "tree": "6c84decdf15db52cf8c20074f55b6f4fc89f9520", "parents": [ "d0c6ec392756fd038ebb8aeaad19aed94c5fd1a5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jul 19 14:39:24 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 01 09:15:23 2018 -0700" }, "message": "Fix race in CommitCodeInternal and cleanup\n\nJitCodeCache::CommitCodeInternal had a race where it gained the\ncode-cache lock to allocate memory, then drops it and potentially\nsuspends. It relied on the time for a code-collect being strictly more\nthan the time this function took, creating a race. This CL Changes the\nlock ordering of CHA to allow us to cleanup the CommitCodeInternal\nfunction and remove the race.\n\nTest: ./test.py --host --jit\nChange-Id: I13c7ec6c56f07660778009ad8ce9c8c10bc2d57d\n" }, { "commit": "240a564a2bb3bc70c5983300037a199d751c7727", "tree": "132585fa41a9580f0abd4820abfa7c43dfb41d42", "parents": [ "be272b93ffcec3ccfd2311a58fd28c3927561ed1" ], "author": { "name": "Hyangseok Chae", "email": "neo.chae@lge.com", "time": "Wed Jul 25 16:45:08 2018 +0900" }, "committer": { "name": "Hyangseok Chae", "email": "neo.chae@lge.com", "time": "Fri Jul 27 09:16:02 2018 +0900" }, "message": "Ensure seq_cst memory ordering for num_contenders\n\nProblem.\nMutexes and ReaderWriterMutexes can lose wakeups due to\nweak memory ordering. An unlocking thread may overlook waiters.\n\nThread A\n0. ExclusiveLock\n1. increase num_contenders as default ordering.\n (fetch_add, std::memory_order_seq_cst)\n2. futex waiting\n...permently waiting\n3. wakeup\n4. decrease num_contenders\n5. running\n\nThread B\n0. Reset lock state to unlocked using seq_cst CAS.\n1. load num_contenders with LoadRelaxed\n (std::memory_order_relaxed)\n2. if num_contenders is bigger than 0, wakeup waiters.\n\nThread B\u0027s load of num_contenders may be reordered with the store\nin the preceding CAS (step 0).\n\nWe can then get the following interleaving:\nA.0 (fails: lock held.)\nB.0a (CAS load acquire sees lock as held)\nB.1 (sees num_contenders \u003d 0)\nA.1 num_contenders++;\nA.2 futex starts waiting (state unchanged)\nB.0b (CAS store release sets state to unlocked)\nB.2 (does nothing since num_contenders was 0)\n\nWe observed this hang with state_ \u003d 0,\nexclusive_owner_ \u003d 0, num_contenders_ \u003d 1\nIndeed, the preceding comment strongly suggests that the num_contenders\nload should not be relaxed.\n\nTest: test-art-host, test-art-target\n\nChange-Id: I912bcd3a186d9c36fb3da8a41c1f9aa1f7b39be5\nSigned-off-by: Hyangseok Chae \u003cneo.chae@lge.com\u003e\n" }, { "commit": "184f0759ef700b1412c7df412c4ebb297427d9fc", "tree": "beef751010816fbbee70494422fd48d46559a4ac", "parents": [ "ec1f1a91328f44d93cfc16e39160dbdfce2f7b9a" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Jul 13 11:18:22 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Jul 16 16:20:01 2018 -0700" }, "message": "Rewrite thread CustomTLS to support keyed TLS entries\n\nOur Thread struct allowed plugins or other parts of the runtime to use\na single custom_tls_ void* pointer to store additional data in the\nThread struct. Unfortunately it was limited to a single value. This CL\nchanges the API to allow one to pass in a const char* key that is used\nto address the TLS data. This lets multiple plugins or parts of the\nruntime set their own independent TLS entries. This also adds support\nfor TLS entries actually being deallocated automatically.\n\nTest: ./test.py --host\nChange-Id: I40fa767b9c61a755b2ed910e4ad1e6327705e941\n" }, { "commit": "5db8b7b821d0b77cb3b041de7861b7d635050cc2", "tree": "04550e7131d527186e34b4c2d1b3be1a1d357bf7", "parents": [ "a6ce173839a1bca1811fca7d9a0a39efd720611d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 08 16:10:59 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 08 16:12:41 2018 -0700" }, "message": "ART: Relayout BaseMutex and Mutex\n\nReduce size of BaseMutex (and thus all derived mutex classes) by changing\nthe field layout. Reduction from 24B to 16B on 64-bit systems.\n\nBug: 79365543\nTest: m test-art-host\nChange-Id: Id7b50aa9af1ae5d249e62573ab67257c12922bfa\n" }, { "commit": "88591fe82f499de10591f5b77efac71f8954eae2", "tree": "bfa126ad55ee091e3b615bd3bb60d5f8cfb6e37a", "parents": [ "e8a4e378c5a928d5de07bee6db99150a57dabcd8" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Mar 06 13:35:43 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Mar 23 15:01:15 2018 +0000" }, "message": "ART: Simplify atomic.h\n\nPrefer std::atomic operations over wrappers in atomic.h. Exceptions\nare cases that relate to the Java data memory operations and CAS\noperations.\n\nBug: 71621075\nTest: art/test.py --host -j32\nTest: art/test.py --target --64 -j4\nChange-Id: I9a157e9dede852c1b2aa67d22e3e604a68a9ef1c\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "cd72dc997ffd88ae92867332d2833c6b5d48fe36", "tree": "a48165e3c59673b755993c960e0cca4db6f859fb", "parents": [ "0bdc1fc702b5c9e45df93f92a052f0c0b1c26733" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 27 19:15:31 2018 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 27 19:20:50 2018 +0000" }, "message": "Fix an incorrect use of ScopedContentionRecorder in ReaderWriterMutex.\n\nThe TID the blocked (current) thread and the TID of the mutex\u0027s\nexclusive owner thread should be respectively passed as second\nand third arguments to ScopedContentionRecorder\u0027s constructor.\n\nTest: art/test.py\nChange-Id: Ica37dfb1c15e25cd48fa46f499192de58e8a7e0e\n" }, { "commit": "440a9b3b3e6aa60c14e73a97dd85c9ada0898569", "tree": "26dcc48d91e3eec18ab1e4dd987962a0939f6531", "parents": [ "d1652d14fbf477b3091eec3764b9890f2c072055" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 15 17:47:29 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Feb 21 12:57:12 2018 +0000" }, "message": "Add timestamps to JIT/DEX native debug info.\n\nThis a forward-looking change intended to allow simpleperf to\nreliably correlate samples and native debug information.\n\nI have added the timestamps to both JIT and DEX, and refactored\nthe code in the process to avoid code duplication.\n\nTest: testrunner.py -t 137\nChange-Id: I45fa4310305aff540e036db9af15a86c5b8b7aff\n" }, { "commit": "fb3de3d72832177e4a8d1f322ed11cbe58e45c9f", "tree": "de8cded0436b54b2e5b1142b07fa75f0ed9791b0", "parents": [ "2827ff64c7a385cfb9d6e01e6385708461eb65fc" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jan 29 16:11:49 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Feb 02 14:14:08 2018 +0000" }, "message": "Create list of open dex files for libbacktrace.\n\nThis fixes unwinds after recent changes (oob apks; cdex data sharing).\n\nBug: 72520014\nTest: m test-art-host-gtest\nChange-Id: Ie2a02657b2afbe899acd2e61f0a57d207e688b99\n" }, { "commit": "4557b3858a66aa20e42bce937e1f0620aad880a2", "tree": "8f34d8f014b11f17c6351bb955fcc74c940b8d16", "parents": [ "90f20973356900e340998e8e2b34230e5c4c8fb0" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 11:47:54 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 12:45:40 2018 +0000" }, "message": "ART: Rename Atomic::CompareExchange methods\n\nRenames Atomic::CompareExchange methods to Atomic::CompareAndSet\nequivalents. These methods return a boolean and do not get the witness\nvalue. This makes space for Atomic::CompareAndExchange methods in a\nlater commit that will return a boolean and get the witness value.\n\nThis is pre-work for VarHandle accessors which require both forms.\n\nBug: 65872996\nTest: art/test.py --host -j32\nChange-Id: I9c691250e5556cbfde7811381b06d2920247f1a1\n" }, { "commit": "55256cb60e11d4fac71affb4b9760a2931a3598d", "tree": "fc1ed6885b013e0aa2bcfd9ef4dd94fec29bd382", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Dec 21 17:07:11 2017 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Dec 22 10:11:39 2017 -0800" }, "message": "Extensions to check JNI.\n\nEnsure critical lock isn\u0027t held when returning from a down-call.\nLog a warning if the critical lock is held for a significant period of\ntime.\nRefactor JNIEnvExt to be a class rather than a struct.\n\nTest: mma test-art-host\n\nChange-Id: I4d149cb04d3a7308a22b92b196e51e2f1ae17ede\n" }, { "commit": "ae915a0182db98769ed4851fab440e79e012babd", "tree": "05d9411ed11fe95ccbcc73f4300c819563bbbf3d", "parents": [ "9e73b32fed15d262b0393f114b9602ac7ef88917" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Tue Dec 12 11:05:32 2017 -0800" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Fri Dec 15 10:53:19 2017 -0800" }, "message": "Improve scoped spinlock implementations\n\nBoth ScopedAllMutexesLock and ScopedExpectedMutexesOnWeakRefAccessLock\nreally implement simple spinlocks. But they did it in an unorthodox\nway, with a CAS on unlock. I see no reason for that. Use the standard\n(and faster) idiom instead.\n\nThe NanoSleep(100) waiting logic was probably suboptimal and definitely\nmisleading. I timed NanoSleep(100) on Linux4.4 host, and it takes about\n60 usecs, i.e. 60,000 nsecs. By comparison a no-op sched_yield takes\nabout 1 usec. This replaces it with waiting logic that should be\ngenerically usable. This is no doubt overkill, but the hope is that\nwe can eventually reuse this where it matters more.\n\nTest: Built and booted AOSP.\n\nChange-Id: I6e47508ecb8d5e5d0b4f08c8e8f073ad7b1d192e\n" }, { "commit": "5573c37e795668eca81a8488078f798d977685c3", "tree": "5e7675d6c1ca9ed1c31834e52282bfb9f73dc2a4", "parents": [ "1598a77ca3559c8a59902f26ee887504b8159859" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Nov 16 13:34:30 2017 -0800" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Nov 16 14:42:49 2017 -0800" }, "message": "cpplint: Remove many unnecessary NOLINT\n\nNow that we updated to upstream cpplint, a lot of these NOLINTs are no\nlonger necessary.\n\nBug: 68951293\nChange-Id: If8ed5ffe89727f313f907a214b6d8fd2a2eddbad\n" }, { "commit": "39cfa34828620220e3bdba181b36712fdbcd2639", "tree": "17b27a3885143a0a6508a4e546f2b6c0cb56f1b1", "parents": [ "b3dfd1b23eb2c064797163b99d2e4ce8463c1312", "495e783c9180c3fc033ce459ee0a783e633f7754" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Nov 07 00:03:02 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Nov 07 00:03:02 2017 +0000" }, "message": "Merge \"runtime: Bitstring implementation for subtype checking (3/4).\"" }, { "commit": "495e783c9180c3fc033ce459ee0a783e633f7754", "tree": "556835bfecf521afbfd701307ccd39f3c0a447e6", "parents": [ "f31a00c9e341f55eb352c3713d6dc47bd2df453b" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Oct 27 10:56:20 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Mon Nov 06 13:44:43 2017 -0800" }, "message": "runtime: Bitstring implementation for subtype checking (3/4).\n\nImplement the subtype check manipulation of the class hierarchy.\nThis walks the class hierarchy tree and allocates bitstring values\nto each class by encoding the path from the class to the root as a\nbitstring.\n\nUsed to implement O(1) subtype checking in the subsequent CL.\n\nTest: art/test.py -b -j32 --host --target\nBug: 64692057\nChange-Id: I484940bbb3901b56236245cdd4f8f4a8d859f919\n" }, { "commit": "33bff25bcd7a02d35c54f63740eadb1a4833fc92", "tree": "553db4f60878acf2a0fa7036a739d406df9a29b7", "parents": [ "321b3ca9a36d769283c64d4bdee0798db80af524" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 01 14:35:42 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 02 10:11:02 2017 +0000" }, "message": "ART: Make InstructionSet an enum class and add kLast.\n\nAdding InstructionSet::kLast shall make it easier to encode\nthe InstructionSet in fewer bits using BitField\u003c\u003e. However,\nintroducing `kLast` into the `art` namespace is not a good\nidea, so we change the InstructionSet to an enum class.\nThis also uncovered a case of InstructionSet::kNone being\nerroneously used instead of vixl32::Condition::None(), so\nit\u0027s good to remove `kNone` from the `art` namespace.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I6fa6168dfba4ed6da86d021a69c80224f09997a6\n" }, { "commit": "04bb35a12cd6ebf4049b0509998f1f166eb59c6b", "tree": "a544cf1168902cb88135277a65fe13dd8794b636", "parents": [ "0882af2e3ca253184b6ab56a8966a2f37407144e" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Tue Sep 19 11:01:40 2017 -0700" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Tue Sep 19 11:07:02 2017 -0700" }, "message": "Fix exclusive_owner_ spelling\n\n... to fix Mac build breakage.\n\nTest: Grep for exclusive_owner_ misspellings + TreeHugger\n\nBug: 65171052\nChange-Id: I15eec0651b2d6d8ce20a8a906c5943c0f1aaa7fe\n" }, { "commit": "0882af2e3ca253184b6ab56a8966a2f37407144e", "tree": "dc61cf0d66ec576c6b2e3b78b5fb304afd6994c9", "parents": [ "6b411fc9fd94da3c552d8b96cee14f6414e7b734" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Thu Aug 31 15:21:57 2017 -0700" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Wed Sep 13 13:15:12 2017 -0700" }, "message": "Shrink ART Mutex exclusive_owner_ field to Atomic\u003cpid_t\u003e\n\nThe old volatile uint64_t version had a data race, and was thus\ntechnically incorrect. Since it\u0027s unclear whether volatile uint64_t\nupdates are actually atomic on 32-bit platforms, even the informal\ncorrectness argument here already effectively assumed that the upper\n32 bits were zero. Don\u0027t store them. Explicitly complain if a pid_t\nmight be too big to support lock-free atomic operations.\n\nRemove many explicit references to exclusive_owner to avoid\nlittering the code with LoadRelaxed calls.\n\nThe return convention for GetExclusiveOwnerTid() was unclear\nfor the shared ownership case. It was previously treated\ninconsistently as 0 (pthread locks), (uint64_t)(-1U) and\n(uint64_t)(-1). Make it as consistent as easily possible, and\ndocument remaining weirdness.\n\nBug: 65171052\n\nTest: AOSP builds. Host tests pass.\n\nChange-Id: Ia99aca268952597a90b3c798b714cddbdc2c365e\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "79400aa5124f89daec47d3cf7c6c38030547a770", "tree": "280b6f2c77ce4a76bd8f196579499064fc19d711", "parents": [ "527f18fcebb8f5799bad483b8164fe35ce3688f2" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 18 15:34:21 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jul 19 08:35:34 2017 -0700" }, "message": "Whitelist user_code_suspension_lock_ for ConditionVariable wait\n\nConditionVariable::Wait checks to make sure the current lock status is\nsane. We need to whitelist the user_code_suspension_lock_ for being\nheld through the wait when it is a threads resume_cond_ since this\nlock needs to be held through the entirety of user-code suspension.\n\nWe also add a check to make sure the thread will not deadlock.\n\nBug: 63813338\nTest: stress --cpu 64 \u0026 \\\n while ./test/run-test --host --jit 1904; do; done\n\nChange-Id: I24577b66629279106de328aad1afd191725c94fb\n" }, { "commit": "88fd720b6799184c8ad61e766a6d37af33ed30ef", "tree": "80e49456eafd44b0ad8790be456ae06949fcc506", "parents": [ "1cba8d219331e4d6994359e8f9104e5db2c8f8a9" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Jun 30 08:31:59 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jul 13 09:11:03 2017 -0700" }, "message": "Add Jvmti Suspend/ResumeThread functions\n\nEnable the can_suspend jvmti capability and implement all required\nfunctionality associated with it.\n\nTest: ./test.py --host -j40\nBug: 34415266\nBug: 62821960\nBug: 63579748\n\nChange-Id: I83b92de7f81622e1658114b034918e8295805b6e\n" }, { "commit": "8a433246d0f26f1f8519925ee6fc5cee8fbd0788", "tree": "cc16e3892780e6d6262a9ea2ebc74d29e978f6a0", "parents": [ "b139b6d3833cd6a90f345204202ec57ff277c088" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Mar 07 14:39:22 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Mar 07 14:39:22 2017 -0800" }, "message": "Add two locks to expected_mutexes_on_weak_ref_access_.\n\nThe ObjectRegistry lock and the jdwp event list lock to avoid DCHECK\nfailures.\n\nSome cleanup.\n\nBug: 35360959\nBug: 35745310\nTest: test-art-host\nTest: jdwp test.\nTest: angler boot.\nChange-Id: I16000c0c7624b1271d40c4c1a01a4e249271b67e\n" }, { "commit": "b139b6d3833cd6a90f345204202ec57ff277c088", "tree": "b7e264fc3c10c6f040d6d887177ab58a82201e88", "parents": [ "7ba6ed786aa21257cfeefb917157d7d4768b9501" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Feb 28 15:01:23 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Mar 07 14:38:30 2017 -0800" }, "message": "Revert \"Add jdwp event_list_lock_ to expected_mutexes_on_weak_ref_access_.\"\n\nThis reverts commit 35b456a05af864da6580dd01c033efb0ed3e3e44.\n\nWill be superceded by aog/346324.\n\nBug: 35360959\nTest: test-art-host.\nTest: jdwp test.\n\nChange-Id: I325003cb85b29c0245de6ba86b719b51201a840c\n" }, { "commit": "35b456a05af864da6580dd01c033efb0ed3e3e44", "tree": "8b84cac89a86ca3eb015a697ce6e42efed541899", "parents": [ "fbf7dd9f86cdea46e10e018e73292d5cd9a984d9" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 22 18:06:55 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 22 18:06:55 2017 -0800" }, "message": "Add jdwp event_list_lock_ to expected_mutexes_on_weak_ref_access_.\n\nTo avoid a DCHECK failure where event_list_lock_ is unexpectedly held\nduring a weak ref access.\n\nAlso move event_list_lock to Locks.\n\nBug: 35360959\nTest: test-art-host.\nTest: jdwp test.\nChange-Id: I6315e1f7152058656f2479ad7b4e4f3defd15555\n" }, { "commit": "df56931343fc925aa33c93ca9120dddf41f0cf5a", "tree": "ae402e56213ad1abb9321c6d6e4e37fcf6ddde7d", "parents": [ "a6dfa573fa951747a09a5fb8b5e1f276e569e934" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 15 14:41:26 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 15 14:41:26 2017 -0800" }, "message": "Add jni_libraries_lock_ to expected_mutexes_on_weak_ref_access_.\n\nFix a DCHECK failure where jni_libraries_lock_ is unexpectedly held\nduring a weak ref access.\n\nBug: 35360959\nTest: test-art-host\nChange-Id: Ief9e97c03cdff7f350e739f1004925a3689ecaf2\n" }, { "commit": "a222404a5832ab16786931576d52825d08eed3ca", "tree": "7350e5efbb6ef72c33e82753d79f7f4bed92d9d4", "parents": [ "1561de49b382627ddd277b8ad7e5e8f4cec32f0b" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 08 16:35:45 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Feb 10 16:15:01 2017 -0800" }, "message": "Fix the empty checkpoint timeout.\n\nThe problem happens when a thread is indirectly blocked on a mutex\nthat another thread holds and is blocked on a weak ref access.\n\nAdd a way to do a dummy wakeup on a thread that\u0027s blocked on a mutex\nso that the thread will respond to the empty checkpoint request. Do\nthis for the mutexes that are expected to be held when a weak ref is\naccessed. Add a check that detects an unexpected case.\n\nBug: 33006388\nBug: 12687968\nTest: test-art-host.\nChange-Id: Iefec69b9a21aa25a928cb31fcf4fb872f867a8c2\n" }, { "commit": "1b14fb8bc459c3f91ed9fc1ff2e6c011c3d0a0f9", "tree": "ac561b61e2bc75adbc3aaa6ea8154946f55bbaf1", "parents": [ "7b220d60e3cb58c384a0d245106406080c6f3e37" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 01 10:42:11 2017 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 06 11:54:10 2017 -0800" }, "message": "Remove Mutex dependency from MemMap\n\nUse std::mutex to remove the dependency between MemMap and Mutex/Thread,\nwhich depend upon Runtime. Next step towards making dexdump2 build and\nrun on Windows.\n\nBug: 22322814\nTest: test-art\nChange-Id: Ia6f4ef882dcef516ee83a81e965b3d744ce325b0\n" }, { "commit": "44751efea1d5457f8eaf1b685ac9a09be1fd7c3e", "tree": "920e59513f690dd13f8a5edf7e043d418d95b192", "parents": [ "b0355130e38034db6b904783a00f74a3524e1881", "bf6331a45f730e1f1044af2ce43bceda660ae6fc" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 19 09:03:12 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jan 19 09:03:13 2017 +0000" }, "message": "Merge \"Revert \"ART: Start RuntimeCallbacks\"\"" }, { "commit": "bf6331a45f730e1f1044af2ce43bceda660ae6fc", "tree": "66013474dc85b2a868d5fad2506c8674a086fa1a", "parents": [ "13093d455b8266338fd713b04261c58e9dc2b164" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 19 09:02:50 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 19 09:02:50 2017 +0000" }, "message": "Revert \"ART: Start RuntimeCallbacks\"\n\njdwp tests failing with:\n STDERR\u003e dalvikvm32 E 01-18 23:14:50 12180 12198 thread-inl.h:137] holding \"runtime callbacks lock\" at point where thread suspension is expected\n\nBug: 31684920\n\nThis reverts commit 13093d455b8266338fd713b04261c58e9dc2b164.\n\nChange-Id: I94e4154e273d006eecdd485607dcfd96392d6a00\n" }, { "commit": "a7e64f00df89dfd984a8798548af46c7d0657511", "tree": "fc87511672825a99a034c2955efd7cd38d16f283", "parents": [ "5d61614eda1ec69d46584605b439c56b6f3fd5e0", "13093d455b8266338fd713b04261c58e9dc2b164" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Jan 18 22:52:26 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jan 18 22:52:26 2017 +0000" }, "message": "Merge \"ART: Start RuntimeCallbacks\"" }, { "commit": "13093d455b8266338fd713b04261c58e9dc2b164", "tree": "b4c5e54ce8a74af2f8929df089133967ea7f7274", "parents": [ "3a5e34b65727d2c9e7e6ebe45c337dae0d0398a4" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jan 17 21:40:35 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 18 19:48:37 2017 +0000" }, "message": "ART: Start RuntimeCallbacks\n\nAdd a central RuntimeCallbacks structure to handle certain interesting\nruntime events.\n\nIn a first iteration, add ThreadLifecycleCallback with ThreadStart and\nThreadStop. Move Dbg over to ThreadLifecycleCallback.\n\nAdd a test.\n\nBug: 31684920\nTest: m test-art-host-gtest-runtime_callbacks_test\nTest: art/tools/run-jdwp-tests.sh --mode\u003dhost\nChange-Id: Ie0f77739a563207bfb4f04374e72dc6935c40b4f\n" }, { "commit": "c8089540ccf0f1c43d8db3828f21d489b28a4013", "tree": "dd1d7038adfd2474ba5648e8c5312ca1f8c098e7", "parents": [ "d4a282789669b27ce0352c99c26469b07a86d871" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jan 16 12:41:12 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 18 09:24:52 2017 -0800" }, "message": "ART: Add JNI function table manipulation\n\nAdd support for a function table override. This will override the\ndecision between the regular and the CheckJNI function tables, if\nset.\n\nBug: 34343708\nTest: m test-art-host-gtest-jni_internal_test\nChange-Id: I0e95b0cbd21f4efdcd8c3d312781d9aeeff54a1e\n" }, { "commit": "46ee31b67d7ee1bd085fbc240502053caa3cf8fa", "tree": "83e870f293cd60d533207e389d7b094acd87b31f", "parents": [ "9538f9e2a5d03f1b1bc07ebfbd93b61dcf8ad604" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 14 10:11:49 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 15 09:50:39 2016 -0800" }, "message": "ART: Move to libbase StringPrintf\n\nRemove ART\u0027s StringPrintf implementation. Fix up clients. Add\nmissing includes where necessary.\n\nTest: m test-art-host\nChange-Id: I564038d5868595ac3bb88d641af1000cea940e5a\n" }, { "commit": "cc1b5357f83f0b787d51fbfde3fe870c8a2fa050", "tree": "253d23dba63e1003dc8e953002b994d01c97f181", "parents": [ "5d0c3009fc56afdb4aeae5ee6dd98c3d1d2e7711" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 01 16:58:38 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 02 14:00:22 2016 -0800" }, "message": "ART: Clean up ClassLinker\n\nTry to clean up and simplify ClassLinker.\n\nMove dex_lock to Locks. Remove dead code. Move single-use\ncode to user. Hide implementation details from header.\n\nTest: m test-art-host\nChange-Id: I58150fa9c2a9524f8304370270c2197d655cb3a8\n" }, { "commit": "063fc772b5b8aed7d769cd7cccb6ddc7619326ee", "tree": "bc165781989087a998721991504e589a7d5b0926", "parents": [ "48d08a4233ee4450b0d5073d41445f9dd1f17191" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Tue Aug 02 11:02:54 2016 -0700" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Thu Dec 01 11:15:47 2016 -0800" }, "message": "Class Hierarchy Analysis (CHA)\n\nThe class linker now tracks whether a method has a single implementation\nand if so, the JIT compiler will try to devirtualize a virtual call for\nthe method into a direct call. If the single-implementation assumption\nis violated due to additional class linking, compiled code that makes the\nassumption is invalidated. Deoptimization is triggered for compiled code\nlive on stack. Instead of patching return pc\u0027s on stack, a CHA guard is\nadded which checks a hidden should_deoptimize flag for deoptimization.\nThis approach limits the number of deoptimization points.\n\nThis CL does not devirtualize abstract/interface method invocation.\n\nSlides on CHA:\nhttps://docs.google.com/a/google.com/presentation/d/1Ax6cabP1vM44aLOaJU3B26n5fTE9w5YU-1CRevIDsBc/edit?usp\u003dsharing\n\nChange-Id: I18bf716a601b6413b46312e925a6ad9e4008efa4\nTest: ART_TEST_JIT\u003dtrue m test-art-host/target-run-test test-art-host-gtest\n" }, { "commit": "f05ccaf2cc9882e8b2d0add30072fd2648bea88d", "tree": "c92854218ee522a99c298d6f32a45327c14626dc", "parents": [ "c394d0558de9afff6ab8b87ae9706497e01f37ff", "6f4d102e0c3029b3c74af13d3846a14e1c878a12" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 22 19:26:09 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Nov 22 19:26:10 2016 +0000" }, "message": "Merge \"Correctly handle EINTR return from futex\"" }, { "commit": "340dafabc8e88378e395cda9027cf17726910e91", "tree": "f742cfc9b9eb3fdf0245a66491d39fb841da7c01", "parents": [ "71d15102b52af67e8fe1193192aa2b4cd1956ae0" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 18 16:03:10 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 22 13:08:29 2016 +0000" }, "message": "Use a per-thread VerifierDeps.\n\nAvoid lock contention on a singleton VerifierDeps by allocating\ntemporary per-thread VerifierDeps that get merged after verification.\n\nThis saves around ~35% compile-times on interpret-only.\n\nOnly the creation of extra strings is guarded by a lock, for simplicity.\n\nTest: test-art-host, test-art-target\nbug: 32641252\nbug: 30937355\n\nChange-Id: I11a2367da882b58e39afa7b42cba2e74a209b75d\n" }, { "commit": "6f4d102e0c3029b3c74af13d3846a14e1c878a12", "tree": "18ad351a86cabf94c2bb7f4f8b9dff9d0ec7c59a", "parents": [ "da2d78ba97d177b80e0e9528362bcebc1fd31f0f" ], "author": { "name": "Daniel Colascione", "email": "dancol@google.com", "time": "Mon Nov 21 14:35:42 2016 -0800" }, "committer": { "name": "Daniel Colascione", "email": "dancol@google.com", "time": "Mon Nov 21 15:44:06 2016 -0800" }, "message": "Correctly handle EINTR return from futex\n\nWe should handle EINTR the same way we do EAGAIN: they\u0027re both\ntransient failures. Either way, higher-level code (see\nReaderWriterMutex::SharedLock) will do the right thing, loop around,\nand try again.\n\nTest: code inspection\nChange-Id: I1eb7fb6851cc1a65acc9a0cf7cbeef787b6b28b6\n" }, { "commit": "ca47a17f90bb0be9b98685fbf46e4e4f53ea18c6", "tree": "2f0c28349de25f3e1feb5d31c70ae61f857cfc82", "parents": [ "6adc5a8cac4eab3b847f81c422def4b4ae510332" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Nov 04 16:39:27 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Nov 04 16:39:27 2016 -0700" }, "message": "ART: Clean up old mutex\n\nRemove obsolete mutex.\n\nTest: m test-art-host\nChange-Id: I476792cac4d5d680192e35055abed66772cf8081\n" }, { "commit": "f42eb2c7801dbb45a6ba20a372d5ba4712ebefba", "tree": "62939df36e0d113aab0307f75ab728de72b80953", "parents": [ "fc5fbfc13fd6873d42fe82c308ee68a685258b4c" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Oct 19 13:20:45 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 20 13:40:56 2016 -0700" }, "message": "Remove mutex dependency on art::Runtime\n\nBreaks the cyclic dependency between mutex and the runtime. This allows\nthe use of mutexes without instantiating a runtime.\n\nBug: 22322814\nTest: test-art\nChange-Id: Ia642e515937068d385e5bb1e10bbd3e50a6e36d2\n" }, { "commit": "05a364c8d8271ceeca307d04736f53e92d03de9d", "tree": "70e166900c99564c0ab3596ef3c8d5d85f14e767", "parents": [ "4aed412037e6e7bad2cf589645449df960b88200" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 14 13:27:12 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 14 14:48:26 2016 -0700" }, "message": "ART: Make JNI global and weak global locks global\n\nAdd them to Locks. Give the JNI global table lock\na lock level, close to the weak global JNI references.\n\nBug: 31684578\nTest: m test-art-host\nChange-Id: I3857a3b0be69b16811d9999096b2c42e7a25d227\n" }, { "commit": "0795f23920ee9aabf28e45c63cd592dcccf00216", "tree": "ff3f880c5e84f3316532b47d0e9a7729ade848ac", "parents": [ "d1224dce59eb0019507e41da5e10f12dda66bee4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 27 18:43:30 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 29 17:31:09 2016 -0700" }, "message": "Clean up ScopedThreadStateChange to use ObjPtr\n\nAlso fixed inclusion of -inl.h files in .h files by adding\nscoped_object_access-inl.h and scoped_fast_natvie_object_access-inl.h\n\nChanged AddLocalReference / Decode to use ObjPtr.\n\nChanged libartbenchmark to be debug to avoid linkage errors.\n\nBug: 31113334\n\nTest: test-art-host\n\nChange-Id: I4d2e160483a29d21e1e0e440585ed328b9811483\n" }, { "commit": "3fec9ac0d5af1358d216eb2fdc2000ec0205f3f0", "tree": "f38d8d8aae51f53e7ee6b474f47597b784fc2316", "parents": [ "0cfe19af3b7395658210ea6044a65c9811962a7a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 13 10:47:28 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 26 10:59:22 2016 -0700" }, "message": "ART: Use libbase logging\n\nMove most of our logging infrastructure over to system/core/base.\nRetain VLOG.\n\nUsing unified Android infrastructure has two main advantages. First,\nit reduces the complexity/maintenance burden in ART. Second, it\nallows to detach logging for the cases where we do not want or need\na runtime, e.g., dexdump, the disassembler, etc. As a part of the\nlatter, libbase is also supported for all hosts (including Windows).\n\nFrom a developer viewpoint, there are minor behavior changes for the\nLOG statements (see above), but otherwise usage is the same. Explicit\nseverity enum items are in the android::base namespace now.\n\nBug: 31338270\nTest: m test-art-host\nChange-Id: I5abcb2f45f5b03d49951874c48544f72a283a91b\n" }, { "commit": "ca3c8c33501bf199d6fd0a5db30a27d8e010cb23", "tree": "12a6c3a4266bd17c6b9fe7066fd0b25cb8d9b2d6", "parents": [ "0764877e21f1230e718923d5b84b048cd4346afa" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Sep 06 14:04:48 2016 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Fri Sep 16 10:08:18 2016 +0100" }, "message": "Collect verifier dependencies\n\nMethodVerifier tests whether a DEX method is valid w.r.t. the classes\nin class path. Since the APK does not change across OTA updates, it\nis not necessary to analyze the bytecode again with MethodVerifier,\nas long as its dependencies on the class path (which may have changed)\nare satisfied.\n\nThis patch introduces VerifierDeps, a class path dependency collector,\nand adds hooks into MethodVerifier where classes/methods/fields are\nresolved and where assignability of types is tested.\n\nTest: m test-art-host-gtest-verifier_deps_test\nBug: 30937355\nChange-Id: Iee0b321d772a5c7d1cb471aaa6e13918310b7e2f\n" }, { "commit": "9231f4e55d6e79e37880071e222c28141bf65f49", "tree": "929c75752d7dd5d667b5f2cdaa044ad83d0522eb", "parents": [ "e99331f7a430b0b72142dd0b8b0689421489dcf6" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 23 17:35:19 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 23 18:20:12 2016 -0700" }, "message": "ART: Remove vestiges of GCC\n\nWe no longer support GCC.\n\nChange-Id: I869ac6e5dcb166747e45236a0d313c7672bbf2de\nTest: m test-art-host\n" }, { "commit": "14832efeb92334c562ebedef34e920d30e3cee69", "tree": "57d10c24966a46ae1c01861ee579ac6000326c45", "parents": [ "c984725d0035e1925371757c38fed339b409e525" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Fri Aug 05 11:44:32 2016 +0100" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Aug 09 13:47:49 2016 +0100" }, "message": "Revert experimental lambda feature.\n\nThis is a revert of the following changes :\n\n30c475a2046951a81769c2db0b2dad66cd71e189.\nlambda: Minor capture-variable/liberate-variable clean-up after post-merge reviews.\n\n6918bf13eb855b3aa8ccdddda2d27ae8c60cec56.\nlambda: Experimental support for capture-variable and liberate-variable\n\nfc1ccd740b7c8e96dfac675cfc580122cd1b40a6.\nlambda: Infrastructure to support capture/liberate-variable dex opcodes\n\ne2facc5b18cd756a8b5500fb3d90da69c9ee0fb7.\nruntime: Add lambda box/unbox object equality\n\n2ee54e249ad21c74f29a161e248bebe7d22fddf1.\nruntime: Partially implement box-lambda and unbox-lambda experimental opcodes\n\n158f35c98e2ec0d40d2c032b8cdce5fb60944a7f.\ninterpreter: Add experimental lambda opcodes for invoke/create-lambda\n\na3bb72036f5454e410467f7151dc89f725ae1151.\nAdded format 25x to dexdump(2).\n\nPlus surrounding cleanups.\n\nTest: make test-art\nChange-Id: Ic6f999ad17385ef933f763641049cf721510b202\n" }, { "commit": "a206c745dbb64b14f05c87891d425475c2f6d63a", "tree": "b73c6dfa1f78d6605e71fab8a3e43fb484715647", "parents": [ "d53208c8e7ca4b2e2d4070d8e67ec1ee078cee74" ], "author": { "name": "Richard Uhler", "email": "ruhler@google.com", "time": "Tue May 24 15:04:22 2016 -0700" }, "committer": { "name": "Richard Uhler", "email": "ruhler@google.com", "time": "Wed May 25 11:26:43 2016 -0700" }, "message": "Don\u0027t use dlopen on host for already loaded oat files.\n\nBecause the behavior of dlopen on the host is different then the\ntarget in that case, and it causes tests to fail.\n\nBug: 28826195\n\nChange-Id: Id202bbac3318bade89a4133a9bcb1ee01e8b6182\n" }, { "commit": "fba39972d99701c80bf3beb7451aca508d67593c", "tree": "0d80ecb6997290140503926b08a72e7418915526", "parents": [ "718d4e269810c17d03df909c84b2f7bbd4f61fb9" ], "author": { "name": "Chih-Hung Hsieh", "email": "chh@google.com", "time": "Wed May 11 11:26:48 2016 -0700" }, "committer": { "name": "Chih-Hung Hsieh", "email": "chh@google.com", "time": "Fri May 13 10:38:56 2016 -0700" }, "message": "Fix misc-macro-parentheses warnings.\n\n* Add parentheses to fix warnings.\n* Use NOLINT to suppress wrong clang-tidy warnings.\n\nBug: 28705665\nChange-Id: Icc8bc9b59583dee0ea17ab83e0ff0383b8599c3e\n" }, { "commit": "32ce2adefb8a3d0eda59a29f5e87c1eb43eef796", "tree": "50aaa40b31ede355359765259edc7989485cc7d5", "parents": [ "c71dc3852edfa8e0cd2083d12845ff8607e189ff" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 04 14:58:03 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 04 18:37:19 2016 -0800" }, "message": "Add more systracing everywhere\n\nAdded to:\nJIT\nDexFile functions\nOat file manager\n\nAdded helper ScopedTrace to prevent errors and reduce excess code.\n\nBug: 27502458\n\n(cherry picked from commit dabdc0fe183d4684f3cf4d70cb09d318cff81b42)\n\nChange-Id: Ifaeff8913d79eefc797380987d13cc00456266f8\n" }, { "commit": "98e6ce44c700abd9375fe17f0aa31fea1e1e938b", "tree": "aa15b4398290918e5eb5227781b5aef5ecff9e0b", "parents": [ "a1f65135cd2315159ac302f904ba0c5ba0d7fd0e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Feb 16 18:42:15 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 18 09:51:40 2016 +0000" }, "message": "Remove string init map.\n\nPartial revert of the String init change.\n\n- Make Quick bailout in the presence of String allocation.\n- Rely on the compiler for knowing when dex registers alias.\n\nbug:27173201\n\nChange-Id: I0bf58ba3825c71cef110b53f3a0a6f567cb2ef9a\n" }, { "commit": "4d87df607a0b86cdf4b2c04f61d72a60d8975ce0", "tree": "922e882c15633e6c700091c99864868d69822d7d", "parents": [ "97f2ca08c3d9a2b1694419aea07cd64f477c0af2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 07 15:14:19 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 08 15:46:52 2016 -0800" }, "message": "Improve handling of daemon threads after runtime shutdown\n\nThe main issue comes from the fact that user daemon threads are\nallowed to continue running after the runtime has shutdown. They may\nstill have a JNI env pointer. To prevent crashing if they call into\nthe env, we replace the function pointers with functions that sleep\nforever.\n\nThe other issue is that user daemon threads that are blocked in an\nART condition variable may get woken up by another user daemon inside\nof Monitor::Notify or by a spurious wakeup (i.e. SIGQUIT). To deal\nwith this issue, we check the JNI env for shutdown runtime when we\nare woken up from a condition variable wait. This check fixes test\n132 with --host --gdb --interpreter. Previously this test crashed\nsince dlclose was somehow causing a spurious futex wakeup.\n\nTODO: Investigate adding a unit test.\n\nBug: 18577101\nChange-Id: I479b38968ee9fbc4ee4b252ee2528787279972cc\n" }, { "commit": "3a0909248e04b22c3981cbf617bc2502ed5b6380", "tree": "b0b7013ea78b10f23fae75ef145e53a696ff797c", "parents": [ "457e874459ae638145cab6d572e34d48480e39d2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "message": "Revert \"lambda: Add support for invoke-interface for boxed innate lambdas\"\n\n955-lambda is flaky\n\nBug: 24618608\nBug: 25107649\n\nThis reverts commit 457e874459ae638145cab6d572e34d48480e39d2.\n\nChange-Id: I24884344d21d7a4262e53e3f5dba57032687ddb7\n" }, { "commit": "457e874459ae638145cab6d572e34d48480e39d2", "tree": "b192c4698c4889ae90db6abe2652199802213fe6", "parents": [ "3944f7175dcf60316ba58a42698ccf23c65ac57c" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Oct 22 17:37:50 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Nov 20 16:33:06 2015 -0800" }, "message": "lambda: Add support for invoke-interface for boxed innate lambdas\n\nLambda closures created with the \u0027create-lambda\u0027 instruction\n(termed \"innate lambdas\") can be turned into an object with \u0027box-lambda\u0027.\n\nThis CL enables support for those kinds of lambdas to work with\n\u0027invoke-interface\u0027 by generating a proxy class for the lambda.\n\nNote: MIPS32/64 support not included.\n\nBug: 24618608\nBug: 25107649\nChange-Id: Ic8f1bb66ebeaed4097e758a50becf1cff6ccaefb\n" }, { "commit": "e58991b3b2282b5761f1a6023a16c803e1c4eb45", "tree": "5a6fac6c5d3cb6a463463b83b8a34a53b07a8ede", "parents": [ "fb11bab9bc96ff05dcb12f43abf58df256b7c7aa" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 13 07:59:34 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 13 13:17:50 2015 -0700" }, "message": "Revert \"Revert \"Unload oat files\"\"\n\nFixed a race where two threads calling OatFile::Open could both use\ndlopen on the host.\n\nBug: 22720414\n\nThis reverts commit 72da5e7461fec3b1e116050f2e6f233efb9c54f3.\n\nChange-Id: I1636045b724944d2a09417527280784967957095\n" }, { "commit": "f9c6fc610b27887f832e453a0da1789187293408", "tree": "3f45a15327e5bc7cb71e6c238ba75e87ae2e6058", "parents": [ "793e6fbdefb092d1dab50bca5618aed110c7e037" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 07 11:44:05 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Oct 09 12:57:53 2015 -0700" }, "message": "Add OatFileManager\n\nTakes over a large amount of functionality from the class linker.\n\nChanged OatFile to loading the same OatFile multiple times. This is\nrequired for unloading OatFiles and moving dex caches to BSS since\nthese require a different OatFile for each dex cache and class\nloader.\n\nBug: 22720414\n\nChange-Id: I0321096723a294dc72949f21e66da82727b512fc\n" }, { "commit": "a2c38644d96cbad4106c0165811d0f670d6cec8f", "tree": "4ad15bed693ced09d99bb034175bdfe8cc3bb1c2", "parents": [ "6766eae2d91e894b4ceab9f29cc983900e7bc0c7" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Thu Sep 17 17:29:01 2015 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Thu Sep 17 18:33:16 2015 -0700" }, "message": "Add lock around interpreter string init reg map.\n\nFixes intermittent test failures. Note that locks can\u0027t be held\nwhile the verifier is generating the map.\n\nChange-Id: Ie38d6bf0d9c5e81d66b8c167fde0e75a0565cea5\n" }, { "commit": "5bdb6550ab0341e3c9fc633866e51e08786bd589", "tree": "7cd631f9ebfb5fa2e4c1fc26155222172e0b8b48", "parents": [ "f64914d7392b7d35c7f35bc917b0797b9c4605ac" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 22 23:44:55 2015 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 22 23:44:55 2015 -0700" }, "message": "ART: Fix missing role definition\n\nAdd missing static member definition. Follow-up to\n4e2cb098017bf073335ebb02b1bc0a36828cd720\n\nBug: 20072211\nChange-Id: I392da3724ded7c455b9b57add6fceb70191f9ff6\n" }, { "commit": "e2facc5b18cd756a8b5500fb3d90da69c9ee0fb7", "tree": "595a3c807e1cbaa4b8c22b93685d70faa4ff0f5a", "parents": [ "e07300b712f44397ecbfed1ef7f880686e46274a" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Jul 10 13:49:08 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Mon Jul 20 15:11:59 2015 -0700" }, "message": "runtime: Add lambda box/unbox object equality\n\nA lambda that is boxed with box-lambda is now stored as a weak reference\nin a global runtime table (lambda::BoxTable). Repeatedly boxing the same\nlambda closure value will always return the same java.lang.Object back.\n\nSince there is no way to observe the address of an object, a GC can\nhappen and clean up the table of any dead boxed lambdas, which can also\nshrink the table to prevent the memory use from growing too much.\n\n(Note that a lambda closure is immutable, so hashing over it is\nguaranteed safe.)\n\nChange-Id: I786c1323ff14eed937936b303d511875f9642524\n" }, { "commit": "eac4424b3420c280f97ff2f815b5dedd8dac9801", "tree": "4e7c31b4312aa000bd3d2250df6a05daf61523d7", "parents": [ "ec97825f8553b3a99b6dfbbb90a50fe65301ea94" ], "author": { "name": "Yu Li", "email": "yu.l.li@intel.com", "time": "Mon Jun 29 10:50:03 2015 +0800" }, "committer": { "name": "Man Cao", "email": "manc@google.com", "time": "Mon Jul 13 15:56:19 2015 -0700" }, "message": "ART: JNI thread state transition optimization\n\nThis patch improves the JNI performance by removing the explicit acquiring and\nreleasing the mutator lock when a thread state transits between suspended and\nrunnable states.\n\nThe functions responsible for changing the state were found to be the costliest\npart of the JNI. Originally, a thread needs to acquire a shared mutator lock by\na CAS instruction when entering the runnable state and also needs to release\nthe lock by a CAS when entering the native state from runnable. This patch\nremoves these CAS operations when a thread state transits between suspended and\nrunnable. A thread in the runnable state is considered to have shared ownership\nof the mutator lock and therefore transitions in and out of the runnable state\nhave associated implication on the mutator lock ownership. Meanwhile, a barrier\nis added to control suspending all threads from running.\n\nJNI transition overhead was reduced by 25% on IA platform and by 17% on ARM\nplatform by this patch, while it has little impact on GC pause time (measured\nwith \"suspend all histogram\").\n\nChange-Id: Icee95d8ffff1bbfc95309a41cc48836536fec689\nSigned-off-by: Yu, Li \u003cyu.l.li@intel.com\u003e\nSigned-off-by: Haitao, Feng \u003chaitao.feng@intel.com\u003e\nSigned-off-by: Lei, Li \u003clei.l.li@intel.com\u003e\n" }, { "commit": "80afd02024d20e60b197d3adfbb43cc303cf29e0", "tree": "ef054c7b4f2a739f7cf063e0bc4c501c2c7e41b5", "parents": [ "559b178e34c5d92e7932f92e5d8a981ac334606f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 19 18:08:00 2015 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 26 15:59:02 2015 +0100" }, "message": "ART: Clean up arm64 kNumberOfXRegisters usage.\n\nAvoid undefined behavior for arm64 stemming from 1u \u003c\u003c 32 in\nloops with upper bound kNumberOfXRegisters.\n\nCreate iterators for enumerating bits in an integer either\nfrom high to low or from low to high and use them for\n\u003carch\u003eContext::FillCalleeSaves() on all architectures.\n\nRefactor runtime/utils.{h,cc} by moving all bit-fiddling\nfunctions to runtime/base/bit_utils.{h,cc} (together with\nthe new bit iterators) and all time-related functions to\nruntime/base/time_utils.{h,cc}. Improve test coverage and\nfix some corner cases for the bit-fiddling functions.\n\nBug: 13925192\nChange-Id: I704884dab15b41ecf7a1c47d397ab1c3fc7ee0f7\n" }, { "commit": "2cebb24bfc3247d3e9be138a3350106737455918", "tree": "d04d27d21b3c7733d784e303f01f873bb99e7770", "parents": [ "1f02f1a7b3073b8fef07770a67fbf94afad317f0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 21 16:50:40 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 12:44:27 2015 -0700" }, "message": "Replace NULL with nullptr\n\nAlso fixed some lines that were too long, and a few other minor\ndetails.\n\nChange-Id: I6efba5fb6e03eb5d0a300fddb2a75bf8e2f175cb\n" }, { "commit": "12d625f87bcd6c4059a205bb39007a255f57f382", "tree": "b69f6f80f56977c176e0c441869d2f1de06ede70", "parents": [ "b871a15f1f662c8efe10d41199180bd00b6decd1" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 13 11:33:37 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 13 16:38:25 2015 -0700" }, "message": "Change method verifiers to be thread local roots\n\nBug: 10921004\n\nChange-Id: I3a1425d76cd380587ba67ef6d5ec1227564e55bf\n" }, { "commit": "2435a43f6c851c23922d8508fb17c6079248201c", "tree": "a0eea938dfbafc8f8e1546528295005d3a55ecee", "parents": [ "c685bce4e6cfec075cb5b468d06b2fcdeeda2005" ], "author": { "name": "bowen_lai", "email": "bowen_lai@htc.com", "time": "Fri Mar 13 14:34:40 2015 +0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 13 10:20:40 2015 -0700" }, "message": "ART: Add entries_ lock for race condition\n\nGCDaemon thread would visit incorrect RegType content when there is\nanother thread initializing classes.\nAdd a lock to protect entries_.\n\nhttps://code.google.com/p/android/issues/detail?id\u003d159849\n\nChange-Id: Iabaa1c7f5cc5106b60a6e3856152e0797e8a5d6d\n" }, { "commit": "91e56692c6bd9fa1d41951ee7dc311f19461f4be", "tree": "8e7600204eed1509b7ec436ae789f3d8195a8755", "parents": [ "dc47e986941b1a3754447fabea272485f3f0f382" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 03 13:51:04 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 03 16:31:49 2015 -0800" }, "message": "Wait for threads to finish unregistering\n\nThere was a race where Thread::join would return before the thread was\nunregistered. This caused a problem with Daemons.stop since the thread\nlist could get deleted before the daemon thread was removed from list_.\nThis caused occasional \"Request to unregister unattached thread\"\nerrors and warnings.\n\nThe fix is to wait until threads finish registering before destroying\nthe thread list. The only threads which can be unregistering at this\npoint are the daemons we stopped earlier during the runtime shutdown\nprocess. The issue is that thread join finishes before we remove the\nthread from the thread list.\n\nAlso some cleanup.\n\nBug: 18713034\nChange-Id: I8921122fe8462643a6b814b5f00632481e3831fb\n" }, { "commit": "4c10110b144eafa47333dc9d30da9220a03e7c08", "tree": "e373871d3b56a161eacd7a1d25846c2a39b0ad62", "parents": [ "763abfd0d803f8169e97d3da944043c2464aac0a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 27 17:14:16 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 27 18:20:41 2015 -0800" }, "message": "Print lock level in ExclusiveUnlock\n\nBug: 18713034\nChange-Id: I83e1bf1e2023b595d8ddf20008935c75b2b0aa0c\n" }, { "commit": "8f1fa100ee037131976c616ec72a6608dccb51e2", "tree": "4df001bf5f7bc441b81c750b5b858f5c912cd6eb", "parents": [ "604e2828896fbb8663897d1e75112da7305ead4c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jan 22 19:48:51 2015 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jan 23 15:16:33 2015 -0800" }, "message": "ART: On shutdown, only warn on mutex contention\n\nDo not abort, as daemon threads may still be active.\n\nBug: 17894429\n\n(cherry picked from commit c0440f69ebf051ff2ffdc00de51005a040014462)\n\nChange-Id: I7c1d50ff8d4a5e150279e703a69c8f2f1d423e6b\n" }, { "commit": "071e48ecfc95b1c67b07c975190d51f646ac4276", "tree": "c873eaedf521aebaabe92d61720b81b12343f9bb", "parents": [ "c40a4350daac81ddbfc5f6ceab934f2180dc4ec6" ], "author": { "name": "tony.ys_liu", "email": "tony.ys_liu@htc.com", "time": "Wed Jan 14 18:28:03 2015 +0800" }, "committer": { "name": "tony.ys_liu", "email": "tony.ys_liu@htc.com", "time": "Wed Jan 14 18:28:03 2015 +0800" }, "message": "Fix false alarm on thread suspend timeout\n\nRoot cause:\n CLOCK_REALTIME will jump backward/forward when system time-of-day clock is changed.\n It implies now_abs_ts will jump a lot across end_abs_ts.\n Then, it makes a false alarm (process crash) on thread suspend timeout when doing ComputeRelativeTimeSpec.\n\n if (ComputeRelativeTimeSpec(\u0026rel_ts, end_abs_ts, now_abs_ts)) {\n return false; // Timed out.\n }\n\nSolution:\n Use CLOCK_MONOTONIC instead\n\nChange-Id: I768af52b05ee1548bb291f7d5e2f389ec85e0e71\n" }, { "commit": "eb0a179508f3c0533dd7db86ec7ab9dfa3773256", "tree": "51f4f2a694627cace4b65c7018a47c994db44bfd", "parents": [ "5b6912e455da798a79a4bb3235e276351b38ab58" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 15 17:23:45 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 15 17:31:17 2014 -0800" }, "message": "Add more logging to Mutex::ExclusiveUnlock\n\nBug: 18713034\nChange-Id: I9db5ca0a25592714ac9e292a2b8d46ef73779c8b\n" }, { "commit": "cef50f0487929f72183623bc2a5819cf3a63bff6", "tree": "b37c68730d982b1bff28d0faa8072df0354b5dd9", "parents": [ "b1a38e246cfbfb21100d9c9e57f33970e824f075" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Dec 09 17:38:52 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 10 09:43:29 2014 -0800" }, "message": "Stop daemon threads in runtime shutdown\n\nEnsure that daemons are stopped and joins before bringing down the\nruntime. This fixes bugs related to native code still running when\nwe shutdown the runtime.\n\nAlso changed the mutex destructor to allow contenders if we are\ndeleting a monitor lock level mutex.\n\nBug: 18577101\nChange-Id: I6457b35fd69c6997b9003b5f15f39861749843a9\n" }, { "commit": "db978719dbcb73fc6acfd193561445c4462786b8", "tree": "be75911bfbe29a50fff685217c8ee155fb99ac10", "parents": [ "015b137efb434528173779bc3ec8d72494456254" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 09 13:33:38 2014 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 09 13:33:38 2014 +0000" }, "message": "Revert \"Tidy gAborting.\"\n\nCreates infinite loop: b/18674776.\n\nThis reverts commit 015b137efb434528173779bc3ec8d72494456254.\n\nChange-Id: I67fe310d2e95ee2ec37bec842be06fb1123b6f4e\n" }, { "commit": "015b137efb434528173779bc3ec8d72494456254", "tree": "2ccaba9d7465bd9995082a7251d34cf76b1ab1ea", "parents": [ "a21fdd0432aa38b63d144ee4b92b6a567aab61d2" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Dec 04 19:53:52 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Dec 04 20:04:45 2014 -0800" }, "message": "Tidy gAborting.\n\nReduce scope to Runtime::Abort and short-cut recursive case earlier. gAborting\nremains global to avoid two fatal errors in thread and the verifier.\n\nChange-Id: Ibc893f891ffee9a763c65cde9507d99083d47b3f\n" }, { "commit": "90675a77fa03850ebd46280e60b0ff54b8d5eb79", "tree": "9a891b47e6b7e4e5f1c123a477ec2876b8183b52", "parents": [ "4a9ac63ba407edc09e13b4e095e2105cf13f603b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 24 00:21:06 2014 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 24 00:21:06 2014 -0800" }, "message": "ART: Avoid recursive abort\n\nBug: 18469797\nChange-Id: Ided50bec3377034dd9a995f9f0700a795adb3940\n" }, { "commit": "4ad5cd3e7d519484559ef778d96fb3f0be8919fa", "tree": "9870938a0552b4fe472d9994a55a3bf761fc69d5", "parents": [ "741e287b60136db49ecf8da72f2b5ca48b0a39bd" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Nov 11 23:08:07 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Nov 12 15:29:12 2014 -0800" }, "message": "Modify the behavior of thread suspend shootouts.\n\nThe thread doing the suspension doesn\u0027t attempt to suspend the other thread\nunless it knows another thread isn\u0027t trying to suspend it. Use the suspend\ncount, and its lock, for this purpose.\nRe-enable ThreadStress test.\nBug: 15446488\n\nChange-Id: Idd34410c7b89d8abd6973e5699a15ca699472c78\n" }, { "commit": "51d212ef31945743abe8a469707aaa25bab95357", "tree": "a93e362ca61c7d5a6dc8521551241106ff1248b2", "parents": [ "e8bd8ac7fb41545ef342c8120c2e83d2fef20a50" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 23 17:48:20 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 23 17:49:51 2014 -0700" }, "message": "Make out-of-line mutex contention dependent on ART_USE_FUTEXES.\n\nFix Mac build. Also fix Linux compilation if ART_USE_FUTEXES is disabled.\n\nChange-Id: I51cb1d70b5548ea6121ff7567b9546bad0894e01\n" }, { "commit": "cf7f19135f0e273f7b0136315633c2abfc715343", "tree": "ffa4d9efd9c45f4b6789acc1f534bb9327052b7e", "parents": [ "aea6888b056be21adf762e066c7f33b8939b8a06" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 22 22:06:39 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 22 22:21:57 2014 -0700" }, "message": "C++11 related clean-up of DISALLOW_..\n\nMove DISALLOW_COPY_AND_ASSIGN to delete functions. By no having declarations\nwith no definitions this prompts better warning messages so deal with these\nby correcting the code.\nAdd a DISALLOW_ALLOCATION and use for ValueObject and mirror::Object.\nMake X86 assembly operand types ValueObjects to fix compilation errors.\nTidy the use of iostream and ostream.\nAvoid making cutils a dependency via mutex-inl.h for tests that link against\nlibart. Push tracing dependencies into appropriate files and mutex.cc.\nx86 32-bit host symbols size is increased for libarttest, avoid copying this\nin run-test 115 by using symlinks and remove this test\u0027s higher than normal\nulimit.\nFix the RunningOnValgrind test in RosAllocSpace to not use GetHeap as it\nreturns NULL when the heap is under construction by Runtime.\n\nChange-Id: Ia246f7ac0c11f73072b30d70566a196e9b78472b\n" }, { "commit": "c7dd295a4e0cc1d15c0c96088e55a85389bade74", "tree": "0c08a2236bc9ba5d9a4dc75d4dd0ed2d76f8f1c6", "parents": [ "94e5af8602150efa95bde35cc9be9891ddf30135" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 21 23:31:19 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 22 12:06:23 2014 -0700" }, "message": "Tidy up logging.\n\nMove gVerboseMethods to CompilerOptions. Now \"--verbose-methods\u003d\" option to\ndex2oat rather than runtime argument \"-verbose-methods:\".\nMove ToStr and Dumpable out of logging.h, move LogMessageData into logging.cc\nexcept for a forward declaration.\nRemove ConstDumpable as Dump methods are all const (and make this so if not\ncurrently true).\nMake LogSeverity an enum and improve compile time assertions and type checking.\nRemove log_severity.h that\u0027s only used in logging.h.\nWith system headers gone from logging.h, go add to .cc files missing system\nheader includes.\nAlso, make operator new in ValueObject private for compile time instantiation\nchecking.\n\nChange-Id: I3228f614500ccc9b14b49c72b9821c8b0db3d641\n" }, { "commit": "6f3dbbadf4ce66982eb3d400e0a74cb73eb034f3", "tree": "f7a20779e4d665f948c5fbcd26dac0071dafb8d4", "parents": [ "2df6840f68dd18d7dd8dbf53f8b6181bbfdc4fc4" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 14 17:41:57 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 16 19:27:28 2014 -0700" }, "message": "Make ART compile with GCC -O0 again.\n\nTidy up InstructionSetFeatures so that it has a type hierarchy dependent on\narchitecture.\nAdd to instruction_set_test to warn when InstructionSetFeatures don\u0027t agree\nwith ones from system properties, AT_HWCAP and /proc/cpuinfo.\nClean-up class linker entry point logic to not return entry points but to\ntest whether the passed code is the particular entrypoint. This works around\nimage trampolines that replicate entrypoints.\nBug: 17993736\n\nChange-Id: I5f4b49e88c3b02a79f9bee04f83395146ed7be23\n" }, { "commit": "5869a2c27ee0dbd7b420614c76ff14a706f0c5fb", "tree": "39bb17a7ae4a4d6c1db99d1a5e07ede899da0aec", "parents": [ "f1f05d303988a5c071c87b760056be8358276c94" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 08 14:26:23 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 08 14:26:23 2014 -0700" }, "message": "Dump mutator lock for thread suspend timeout\n\nShould help us see if thread suspend timeouts are due to someone\nholding on the mutator lock for too long or if it is a missed\nfutex wake.\n\n(cherry picked from commit f924d2381a5ea53967ba1e279766d601b9be05ea)\n\nBug: 17837911\nChange-Id: I3417156a78f574076d5da17c86836c5a7c76084a\n" }, { "commit": "9ef78b59da51080882e47505896b420977fd79ae", "tree": "6c568756e4e16e68d5d3346261009350969d5b77", "parents": [ "95f03e6a4737f90685fab86e98709f1c4393d5ef" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 25 17:03:12 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 26 16:04:56 2014 -0700" }, "message": "Fix broken runtime SetStatsEnabled logic\n\nPreviously, Runtime::SetStatsEnabled wouldn\u0027t take stats_enabled_\ninto account when deciding whether or not to increment / decrement\nteh stats enabled counter. This resulted in counter underflows and\nother errors which caused some CTS tests to fail.\n\nAlso added some locking to prevent race conditions.\n\nBug: 17360878\n\n(cherry picked from commit a98ffd745bbecb2e84a492194950c0b94966546b)\n\nChange-Id: I21d241a58d35bd6a607aa2305c6da81720bd0886\n" }, { "commit": "69dbec6d9d55eeb2867949c2791d01dc9aa916c8", "tree": "be4eca8161eafb4a8466f5adf28a2c8f27cd37d1", "parents": [ "926d8e99aa69151a271180299df68963688010d8" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Mon Sep 15 18:03:41 2014 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Wed Sep 17 14:31:55 2014 -0700" }, "message": "Avoid suspending for alloc trace enabling when already suspended.\n\nBug: 17499772\n\n(cherry picked from commit 1d6ee090fddd4bfd35c304d6ceb929d5c529dfcc)\n\nChange-Id: Id09809c476c685f0a197ee75bb08638931364efd\n" }, { "commit": "a5a53efea976af505f4f849b5925d5e14c4f8e5c", "tree": "455a536a9394908c17ec1ede04ab7ec49f9d3420", "parents": [ "91bbd5347b391278b56440b2dbb0b77526bae4e8" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 12 12:58:05 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Sep 14 14:48:24 2014 -0700" }, "message": "Add native support for FinalizerList.makeCircularListIfUnenqueued\n\nCalled from FinalizerReference.enqueueSentinelReference to prevent\na race where the GC updates pendingNext of the sentinel reference\nbefore enqueueSentinelReference.\n\nBug: 17462553\n\n(cherry picked from commit 3256166df40981f1f1997a5f00303712277c963f)\n\nChange-Id: I7ad2fd250c2715d1aeb919bd548ef9aab24f30a2\n" } ], "next": "7b078e8c04f3e1451dbdd18543c8b9692b5b067e" }