)]}' { "log": [ { "commit": "8311489bcaa94a4527d8e010df6a78d457273b53", "tree": "d73fe83d0433605116648dab8e08339e4ffc83ab", "parents": [ "d76e1238fddfd6eed608d97929c333e921e4826f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Apr 11 13:05:50 2019 +0100" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed May 08 10:18:50 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify debugger/jdwp.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64\nTest: run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64 --debug\nBug: 31113334\nChange-Id: I76889e7c64d7d57ca34236d1b424f00e8e2dda90\n" }, { "commit": "7c5acbb122485b6215dc34defc1f19e07390bb95", "tree": "af0889bb17ef622b8c51d9f110991ca025caef16", "parents": [ "51c655847f2f7d2a9127574d3aeda12755014608" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 13:54:52 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Apr 25 20:41:37 2019 +0000" }, "message": "ART: Fix some types\n\nUse better types and fix some typing issues exposed by clang-tidy\u0027s\nreadability-implicit-bool-conversion.\n\nBug: 32619234\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: I787d291a4843a3192a84853d105d57377b774b23\n" }, { "commit": "91f1032505cfaec3aef51fc0a3085b213813f0ed", "tree": "6469e772d9fb562d26dc1d22dd0b71844bbb743f", "parents": [ "573b3877fac3c5a4a9703301502694fe7219b21c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 07 18:04:10 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 07 18:13:55 2018 +0000" }, "message": "Revert^2 \"Pass boot class path to ImageSpace::LoadBootImage.\"\n\nThis reverts commit db4b1deebf425be5f1d0f597d1ef540f19908324.\n\nFixed JDWP tests, see \"Test:\" stanzas below.\n\nChange-Id: I6fb56ac990b78164cbd3f93c9f6df66e0dd9a813\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nTest: run-libcore-tests.sh --mode\u003ddevice --variant\u003dX64\nTest: run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64\nTest: run-jdwp-tests.sh --mode\u003ddevice --variant\u003dX64\nBug: 119868597\n" }, { "commit": "db4b1deebf425be5f1d0f597d1ef540f19908324", "tree": "5851aab8a4d71b49dbd272b822bfd1ae2cbd08df", "parents": [ "e3c6dfe2009d2fad6f8e4401cb17935bdd09ab9e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 07 17:18:07 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 07 17:23:26 2018 +0000" }, "message": "Revert \"Pass boot class path to ImageSpace::LoadBootImage.\"\n\nThis reverts commit d19085141ad9c71eae1b0ff585999ac8e27dadd4.\n\nAlso squash a revert of\n Fix oatdump tests on target.\n (commit 77eea0898aca2881a87afd177a0422870c39a318)\n\nReason for revert: Broke JDWP tests.\nBug: 119868597\nChange-Id: I005097d2d96014c961e5a4c0b089e7675004febc\n" }, { "commit": "d19085141ad9c71eae1b0ff585999ac8e27dadd4", "tree": "24284e84f5df4601bacc2a97c56af1bc5950c253", "parents": [ "523940b40f9701504d6e007dd2af48f315038dc1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 22 14:57:28 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Dec 06 14:43:07 2018 +0000" }, "message": "Pass boot class path to ImageSpace::LoadBootImage.\n\nWhen loading the boot image by ImageSpace, do not rely on\nthe boot class path (BCP) recorded in the primary boot image\noat file. Instead, check the BCP from image against the BCP\nprovided by the Runtime, i.e. from -Xbootclasspath:_ or the\nenvironment variable BOOTCLASSPATH. For now, allow Runtime\nto extract the BCP from the primary boot image oat file when\nwe have -Ximage:_ but no BCP.\n\nAlso pass the boot class path components down to the OatFile\nso that we can open and use the original dex files when we\ndo not have copies in the vdex files. This allows compiling\napp prebuilts when the boot dex files are uncompressed and\naligned in the original jars.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nTest: run-libcore-tests.sh --mode\u003ddevice --variant\u003dX64\nTest: Manually create boot image jars with uncompressed and\n aligned dex files, compile a boot image with dex files\n not copied into vdex files and use this boot image for\n compiling a prebuilt services.{art,vdex,odex}.\nBug: 119868597\nChange-Id: If9411ddbecf6bb90bfa9233040931c5e833f6aee\n" }, { "commit": "c1896c9a0e15df3a1b9a3a19bcd2a933b654fe06", "tree": "b68a5f5163f8da0da87d671a225addaa2a13095f", "parents": [ "f2970cd870948a6ee1c8ecd30c9c3147d05aa0be" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 29 11:33:18 2018 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 29 11:33:18 2018 -0800" }, "message": "C++17 compatibility: make WITH_TIDY\u003d1 happy again.\n\nBug: http://b/111067277\nTest: builds\nChange-Id: I8b69ea3815e14bb6eb27f40c0dd01a85b340a355\n" }, { "commit": "7d1c0491d076943c6972d242e03f16f70e0e7d36", "tree": "5f7eafa49ef67364ab520785e29036d2afd69eff", "parents": [ "c2099b0b0c052dd61137b9cf5f9f8b30bab1a7a8", "f049a0b3cff914299d14afa454594f47733b7e53" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Oct 26 15:37:55 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Oct 26 15:37:55 2018 +0000" }, "message": "Merge changes from topic \"socket_peer_is_trusted\"\n\n* changes:\n Remove libcutils property_get dependency.\n Remove libcutils socket_peer_is_trusted dependency.\n" }, { "commit": "c2efd4da88c1eeeb51af1ebc4a1321918c3243e5", "tree": "211521ea526432bb4da3c5f83efafae1d3f1ec27", "parents": [ "f4fd65e393fe60f17e22ee7823f8dce4594c053d" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Oct 25 13:14:55 2018 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Oct 25 13:15:33 2018 -0700" }, "message": "Remove libcutils socket_peer_is_trusted dependency.\n\nART is the only caller of this code, and it\u0027s trivially rewritten to\njust use NDK API.\n\nBug: N/A\nTest: boots\nChange-Id: I679a0f7e7ba48c6660c69629af180f04c4532c62\n" }, { "commit": "afaf7f8198fe5ffc054278da6800f81dd83f272c", "tree": "3ebdec9fca813351d178709743121fa66815a7a0", "parents": [ "6ca8ec7809f87ccac8d9d66d267f2379bdfdfe66" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 16 11:32:38 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 18 08:20:09 2018 -0700" }, "message": "ART: Enable bugprone-unused-return-value\n\nEnable bugprone-unused-return-value as an error. This is on top of\nthe compiler warning for attribute((warn_unused)).\n\nMark the current occurrences (all unique_ptr.release()) with NOLINT\nto signal that we know what we\u0027re doing.\n\nBug: 32619234\nBug: 117926937\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: I36659722335eef36acfa5845289104257a393874\n" }, { "commit": "c55bb390d88b8eb62a50932f7f9b47c2a3733f16", "tree": "ec2e74f3f8404dffcb9bfde4e7ffa3416a35543d", "parents": [ "89468aeaa6a67ae4025b30d427391186306d6522" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 21 00:02:02 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 18:37:12 2018 -0700" }, "message": "Revert^2 \"ART: Refactor typedef to using\"\n\nThis reverts commit ee07743e03042c2ca36e0c9513847a9e7d2509f1.\n\nReason for revert: fixed attributes.\n\nBug: 32619234\nTest: m test-art-host\nTest: m test-art-target-gtest-unstarted_runtime_test\nChange-Id: I6f0a775adfdf6ecd132b470f7c5446e949872e20\n" }, { "commit": "ee07743e03042c2ca36e0c9513847a9e7d2509f1", "tree": "66867d7443a3798f6d882ef2715ddeb7baf3e771", "parents": [ "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "message": "Revert \"ART: Refactor typedef to using\"\n\nThis reverts commit 9a20ff06f7ccee08a742c315ec6d351ab56ba1cd.\n\nReason for revert: Attributes on the wrong side.\n\nBug: 32619234\nChange-Id: I8fd2abef619b22c02ccfbf5ae629339f1a60918b\n" }, { "commit": "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd", "tree": "7e55557e118eb5fffe03ad3456e00d8469a36232", "parents": [ "70dfb6983492aff1c52cc1b52044258aef51f47f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 10:58:18 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 21:56:32 2018 -0700" }, "message": "ART: Refactor typedef to using\n\nAdd clang-tidy\u0027s modernize-use-using.\n\nBug: 32619234\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: If50d37b5152af4270784e3cde7951292a9e19033\n" }, { "commit": "8351aac7bc2153cd2ad7247d467303019a76eac3", "tree": "0bcd742215805b88f08b71f8418e0de68dea1379", "parents": [ "322c0891ebc1cf3e3b28d4cbb003b0e40506bc32" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 10 12:37:49 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 18 16:02:41 2018 -0700" }, "message": "ART: Refactor for bool literals\n\nApply modernize-use-bool-literals.\n\nBug: 32619234\nTest: mmma art\nChange-Id: Ib9b36ca360af0f68ce89517a24b5d9fb49f23e58\n" }, { "commit": "fa6a1b0a1d9d186a0ad9bb413a4e49f1ffd187d8", "tree": "6d3bef945030868d7e78162dc3f4f35a07ce410a", "parents": [ "a0878aa9f4f4102e56a6381b28a8d7c38dec80b9" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 07 08:11:55 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 07 09:13:50 2018 -0700" }, "message": "ART: Continue adding override annotations\n\nUse Clang-tidy\u0027s modernize-use-override to add more annotations. Ignore\ninferred annotations on destructors.\n\nBug: 32619234\nTest: mmma art\nChange-Id: Ic432c928e398d44df9171e42db04ee19946e6887\n" }, { "commit": "4b22b34c698db8aa59343d0a5af89fc737532bce", "tree": "985c0e28dcdf5a497737690b50d31c4eb7bbda85", "parents": [ "9e53f5f19167848d043f91e6d20436e9b568b55a" ], "author": { "name": "Yi Kong", "email": "yikong@google.com", "time": "Thu Aug 02 14:43:21 2018 -0700" }, "committer": { "name": "Yi Kong", "email": "yikong@google.com", "time": "Thu Aug 02 14:43:21 2018 -0700" }, "message": "Modernize codebase by replacing NULL with nullptr\n\nFixes -Wzero-as-null-pointer-constant warning.\n\nTest: m\nBug: 68236239\nChange-Id: Id869744db54b5b366454a5e13b467ac1f4df2845\n" }, { "commit": "a3ad0cdd711857f04f477e2cdc5b56a2c74a3018", "tree": "7e0e4c7888c2497d86ce96c9574d7c9886721ccf", "parents": [ "abd9e1515bc6be88372c61071971c5432a51553d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 04 10:06:38 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 09 11:11:09 2018 +0100" }, "message": "ART: Move JNI files to runtime/jni/ .\n\nTest: Rely on TreeHugger.\nChange-Id: I9cae11191ef1567ae9453be498882a7767285140\n" }, { "commit": "88591fe82f499de10591f5b77efac71f8954eae2", "tree": "bfa126ad55ee091e3b615bd3bb60d5f8cfb6e37a", "parents": [ "e8a4e378c5a928d5de07bee6db99150a57dabcd8" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Mar 06 13:35:43 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Mar 23 15:01:15 2018 +0000" }, "message": "ART: Simplify atomic.h\n\nPrefer std::atomic operations over wrappers in atomic.h. Exceptions\nare cases that relate to the Java data memory operations and CAS\noperations.\n\nBug: 71621075\nTest: art/test.py --host -j32\nTest: art/test.py --target --64 -j4\nChange-Id: I9a157e9dede852c1b2aa67d22e3e604a68a9ef1c\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "67bf42e89592c3a1c648f927f2ce3ccb189a1161", "tree": "054d5b7adf7cc62d4d2a2118a70c0fbdd1751610", "parents": [ "d961043ff1dd6fddb68aa90c1f939cfafec24219" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 26 16:43:04 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 28 15:08:21 2018 -0800" }, "message": "Header library to remove dependence on runtime/\n\nAdd a new header library to remove libdexfile and others\u0027 dependence on\nruntime (typically runtime/base) includes in libdexfile. Also a small step\nto tease dexlayout and profman away from relying on these as well.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n\nChange-Id: I38e2fe399a75f4bc6318c77a71954c00ea73ec2b\n" }, { "commit": "4b49bb7e02c6dd70ce6c3f2036a5bce902ff233a", "tree": "113f67f30f0e212d8712014f8a4dc29aa7bd167e", "parents": [ "abee76ef780877132cf82c84f42e8ab50e6cc1d1" ], "author": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Mon Feb 12 15:06:42 2018 -0800" }, "committer": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Mon Feb 12 15:06:42 2018 -0800" }, "message": "jdwp: send pids to adbd as raw integers.\n\nBug: http://b/17661822\nTest: `adb jdwp`\nChange-Id: I2520366f885c3cb62b507e9ba6934633a199ac53\n" }, { "commit": "0225f8e2939a9340cb7dcebfcfe7996a2bd9bce9", "tree": "fd32362dff4ecdc8ff8b0d800a1b46fb0d9d0104", "parents": [ "c7e546ff3963a1d51b1f100d308db735bd19f736" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 08:52:24 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 01:24:53 2018 -0800" }, "message": "Revert \"Revert \"Make libdexfile build independent of runtime dir\"\"\n\nThis reverts commit 787784f9effb126b5d0d3dc97d544c4a477b5daf.\n\nReason for revert: Bot configuration issue.\n\nChange-Id: I6a10bb4a9571f89c7e4dd095f9157e830a44e2de\nBug: 22322814\nTest: make -j 50 checkbuild\n" }, { "commit": "787784f9effb126b5d0d3dc97d544c4a477b5daf", "tree": "1ff6d9fd284a4dd2a337165dff20e71137997c9d", "parents": [ "b40b7e73469339a6b667b4a2e2b8690112a74dc9" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "message": "Revert \"Make libdexfile build independent of runtime dir\"\n\nThis reverts commit b40b7e73469339a6b667b4a2e2b8690112a74dc9.\n\nReason for revert: on device libdexfile.so missing\n\nChange-Id: I9bd61a98bef870400580e8c991cb061d3f57fa72\n" }, { "commit": "b40b7e73469339a6b667b4a2e2b8690112a74dc9", "tree": "7e8a34d9c7894c4c946f674f19f0a0a512b95184", "parents": [ "9690ad794b324ba54e936608881ac0f62538b97a" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 25 17:11:07 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 01:17:58 2018 -0800" }, "message": "Make libdexfile build independent of runtime dir\n\nRemove libdexfile\u0027s dependency on utils.cc and move utf.cc into\n/dex. Remove libdexfile\u0027s constituent sources from libart and\nuse libdexfile wherever libart is. Also remove some ART-specific\ninterfaces. Libdexfile\u0027s tests remain to be converted, plus\nmoving the files to a new directory peer to runtime/.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Ifaf695216e4a0e43d3aa377984d933f7a2a243c2\n" }, { "commit": "403207107da7f11525c4d305184c56b35ec1c17a", "tree": "f97f080fcfa8051df18536e97a33582ee4bbbc6a", "parents": [ "ba3a790338725a37ecd4cb314c4a6147e29aef38" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Dec 14 11:52:04 2017 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Dec 19 09:26:11 2017 -0800" }, "message": "Add support for selecting alternate JDWP implementations\n\nChange JDWP options parsing to take place later and add a\n-XjdwpProvider:_ option that can be used by the runtime to select an\nappropriate JDWP provider. The argument is a string.\n\nIf \u0027none\u0027 is given JDWP will be totally disabled.\n\nIf \u0027internal\u0027 is given the current internal JDWP implementation is\nused.\n\nIf \u0027default\u0027 is given the \u0027internal\u0027 JDWP implementation will\ncurrently be used.\n\nOther values will be added in the future.\n\nAlso adds a runtime callback that will be invoked when the runtime\nwants to start or stop the debugger (namely at the post-zygote fork\nand just before exit) and check if a debugger is availible.\n\nAlso add \u0027-XjdwpOptions:_\u0027 in preparation for the eventual removal of\nthe existing -Xrunjdwp\u003d_ and -Xagentlib:jdwp\u003d_ as top-level options.\nAll of these options now store their arguments as a std::string to be\ninterpreted by the JDWP implementation as it sees fit. Also change the\njdwpOptions to default to transport\u003ddt_android_adb if there is not one\nspecified and it is available. This will make changing the default\ntransport based on the JDWP provider easier.\n\nThese new options are needed to allow us to support both the old,\ninternal, JDWP implementation as its replacement is tested and\nverified. This lets us switch between them with little difficulty.\n\nWe will probably remove one or both of these options once we have\nconfidence that the new jdwp implementation has stuck.\n\nTest: ./test.py --host -j50\nTest: ./test/run-test --host --debug 001-HelloWorld\nTest: Manual, flash walleye, debug app\n\nBug: 62821960\n\nChange-Id: Ie31db6b6f7d76a03d4ab8e178fcf298ed0eec203\n" }, { "commit": "57943810cfc789da890d73621741729da5feaaf8", "tree": "367677a982a45af98ffe3e79543615875e8550b4", "parents": [ "d5153627778e71ef68b510ce03c77467fa4d85bd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 21:39:13 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 16:26:11 2017 -0800" }, "message": "ART: Replace base/logging with android-base/logging\n\nReplace wherever possible. ART\u0027s base/logging is now mainly VLOG\nand initialization code that is unnecessary to pull in and makes\nchanges to verbose logging more painful than they have to be.\n\nTest: m test-art-host\nChange-Id: I3e3a4672ba5b621e57590a526c7d1c8b749e4f6e\n" }, { "commit": "2ffb703bf431d74326c88266b4ddaf225eb3c6ad", "tree": "0552c3c76a42b18f9e7460d501fb71a6dc2e7f33", "parents": [ "c4b6f3116f15c8e4fdf2e4f604ababdee12d8923" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Nov 08 13:35:21 2017 -0800" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Nov 08 15:15:52 2017 -0800" }, "message": "cpplint: Cleanup errors\n\nCleanup errors from upstream cpplint in preparation\nfor moving art\u0027s cpplint fork to upstream tip-of-tree cpplint.\n\nTest: cd art \u0026\u0026 mm\nBug: 68951293\nChange-Id: I15faed4594cbcb8399850f8bdee39d42c0c5b956\n" }, { "commit": "6e1607e247d979a1671a1fd5a98de3f1031fe719", "tree": "1174cdcce601419dcd5d1563777f721477d5cb6a", "parents": [ "2ee17e69110a9ef98ea8c94219c7da23b918ef3f" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 23 10:06:18 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 23 13:15:17 2017 -0700" }, "message": "Rename instrumentation ExceptionCaught to ExceptionThrown\n\nThe instrumentation ExceptionCaught event was badly named since it is\nactually sent at the time the exception is thrown and is sent even if\nthe exception is never actually caught. Rename it and associated\nmethods/fields to ExceptionThrown to more accurately reflect the\nevent\u0027s semantics.\n\nTest: ./test.py --host -j50\nChange-Id: I1e9c401ab619259b25928dbf19f62d3fa9573d47\n" }, { "commit": "f45d61c0866461c9476f17644b27dc0664d507c5", "tree": "95d2837a03d451cccd82cad61924980beb5fd0d4", "parents": [ "83b140474aa1759739c8ee4464bf226c4fa0f6d7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 07 10:29:33 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 17:19:51 2017 -0700" }, "message": "ART: Fix or disable some tidy warnings.\n\nAdd a strlcpy shim for the host, so we can use strlcpy instead of\nstrcpy everywhere.\n\nFixed warnings include unused-decls, (some) unreachable code, use\nafter std::move, string char append, leaks, (some) excessive padding.\n\nDisable some warnings we cannot or do not want to avoid.\n\nBug: 32619234\nTest: m\nTest: m test-art-host\nChange-Id: Ie191985eebb160d94b988b41735d4f0a1fa1b54e\n" }, { "commit": "b486a98aadc95d80548953410cf23edba62259fa", "tree": "b113b7d50a4a015502873b7742c9ece00d293e84", "parents": [ "1656ca9e6996cb555b4463e5efd4bd7e3f4fb816" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 13:45:54 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jun 02 08:24:02 2017 -0700" }, "message": "ART: Introduce thread-current-inl.h\n\nFactor out Thread::Current() code into its own -inl file to remove\ntransitive includes.\n\nThis requires at the same time correcting mutex.h, i.e., moving\nsome functions into mutex-inl.h.\n\nTest: m test-art-host\nChange-Id: I88f888b604e0897368d9b483edce6ce4332dd9c9\n" }, { "commit": "77d8a1c3572afb38542cb5a2b3516674a182ce48", "tree": "cc8d5d0bdc7b656a73beb5d65ca660e36a0fe22e", "parents": [ "6b90142986f76436503bcdca37ace6537ba8f0d4" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Apr 24 14:53:19 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Apr 26 10:07:39 2017 +0000" }, "message": "Revert^2 \"ART: Support for SourceDebugExtension\"\n\nThis reverts commit 6530cab77a36d6d284c9d61084e39cd2c7fb91f8.\n\nBug: 30109642\nBug: 37560145\nTest: art/tools/run-jdwp-tests.sh --mode\u003ddevice --test org.apache.harmony.jpda.tests.jdwp.ReferenceType.SourceDebugExtensionTest\nChange-Id: I74cacb351fb7b181c5a17e004914d6d8bdcaaa48\n" }, { "commit": "6530cab77a36d6d284c9d61084e39cd2c7fb91f8", "tree": "d04da8c615716cabac429319a124b013ff0a39e4", "parents": [ "40dc110da3d951465bd2e1ea80ccec8bf99bddaa" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Apr 24 14:32:00 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Apr 24 14:41:31 2017 +0100" }, "message": "Revert \"ART: Support for SourceDebugExtension\"\n\nThis reverts commit 70a45017d6371521c251d67a9aac7d1c86fb6a06.\n\nPending fix for run-jdwp-tests.sh --mode\u003ddevice.\n\nBug: 30109642\nTest: art/tools/run-jdwp-tests.sh\n\nChange-Id: I62f84e0fb09b6fe280ca6b518fbd2bc431318a56\n" }, { "commit": "70a45017d6371521c251d67a9aac7d1c86fb6a06", "tree": "f9352ab3e446094013fd986fcfa10e6ed5ea26ea", "parents": [ "1cae72e6cfc0b4cd4ad20467dfea243139296998" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Mar 30 16:30:31 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Apr 18 14:05:55 2017 +0100" }, "message": "ART: Support for SourceDebugExtension\n\nAdds support for reading SourceDebugExtension class annotation from\nDEX files.\n\nBug: 30109642\nTest: art/tools/run-jdwp-tests.sh --mode\u003dhost --test org.apache.harmony.jpda.tests.jdwp.ReferenceType.SourceDebugExtensionTest\nChange-Id: I2187a2776953a21d36f8b2d165bef6733c02811e\n" }, { "commit": "7337631929812fb8a60b5182eba076a32d1cb851", "tree": "5831355a92d0a0cfc7bc4f8507899ec59623b16e", "parents": [ "c48266eb44296fa086868b82d8a3c2b57ce186ae" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Apr 06 10:10:51 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Apr 06 10:23:14 2017 -0700" }, "message": "Fixup JDWP for obsolete methods\n\nWe needed to implement some additional methods and behaviors in JDWP\nin order to support JVMTI obsolete methods.\n\nTest: Manual (using art/test/915-obsolete-2 \u0026 jdb debugger)\nTest: Manual (using art/test/915-obsolete-2 \u0026 Android Studio/IntelliJ debugger)\n\nBug: 31455788\n\nChange-Id: I20c2fa27a2dd002e37526b126f23ce552f19e623\n" }, { "commit": "cbb65ae216a47a080c2ff301b593f86d7ac2c1a2", "tree": "7ceeafe366776d5c63d9978c188e4a8efcd33ca2", "parents": [ "46ef4a6f7f59f65c77ef99d4a8d9fcd6d6d3ef0b" ], "author": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Mon Mar 20 11:33:34 2017 -0700" }, "committer": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Mon Mar 20 14:01:02 2017 -0700" }, "message": "jdwp: switch to SOCK_SEQPACKET.\n\nWhen sending the process\u0027s PID to adbd, we use\nTEMP_FAILURE_RETRY(send(...)), and check if the result is non-negative.\nHowever, this could theoretically return short, leaving adbd waiting\nfor the rest of the PID. Switch the socket to a SOCK_SEQPACKET to\nsidestep all of this.\n\nBug: http://b/36411868\nTest: adb jdwp\nChange-Id: I0ec75912ac579868f77554e3c6db23c7ab95a34c\n" }, { "commit": "8a433246d0f26f1f8519925ee6fc5cee8fbd0788", "tree": "cc16e3892780e6d6262a9ea2ebc74d29e978f6a0", "parents": [ "b139b6d3833cd6a90f345204202ec57ff277c088" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Mar 07 14:39:22 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Mar 07 14:39:22 2017 -0800" }, "message": "Add two locks to expected_mutexes_on_weak_ref_access_.\n\nThe ObjectRegistry lock and the jdwp event list lock to avoid DCHECK\nfailures.\n\nSome cleanup.\n\nBug: 35360959\nBug: 35745310\nTest: test-art-host\nTest: jdwp test.\nTest: angler boot.\nChange-Id: I16000c0c7624b1271d40c4c1a01a4e249271b67e\n" }, { "commit": "b139b6d3833cd6a90f345204202ec57ff277c088", "tree": "b7e264fc3c10c6f040d6d887177ab58a82201e88", "parents": [ "7ba6ed786aa21257cfeefb917157d7d4768b9501" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Feb 28 15:01:23 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Mar 07 14:38:30 2017 -0800" }, "message": "Revert \"Add jdwp event_list_lock_ to expected_mutexes_on_weak_ref_access_.\"\n\nThis reverts commit 35b456a05af864da6580dd01c033efb0ed3e3e44.\n\nWill be superceded by aog/346324.\n\nBug: 35360959\nTest: test-art-host.\nTest: jdwp test.\n\nChange-Id: I325003cb85b29c0245de6ba86b719b51201a840c\n" }, { "commit": "35b456a05af864da6580dd01c033efb0ed3e3e44", "tree": "8b84cac89a86ca3eb015a697ce6e42efed541899", "parents": [ "fbf7dd9f86cdea46e10e018e73292d5cd9a984d9" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 22 18:06:55 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 22 18:06:55 2017 -0800" }, "message": "Add jdwp event_list_lock_ to expected_mutexes_on_weak_ref_access_.\n\nTo avoid a DCHECK failure where event_list_lock_ is unexpectedly held\nduring a weak ref access.\n\nAlso move event_list_lock to Locks.\n\nBug: 35360959\nTest: test-art-host.\nTest: jdwp test.\nChange-Id: I6315e1f7152058656f2479ad7b4e4f3defd15555\n" }, { "commit": "fa4333dcb481e564f54726b4e6f8153612df835e", "tree": "ae597c7587dc214434a180962c4373d3748f51ab", "parents": [ "2d98ba68f13dc219c088a12f369c5778bf398f14" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:10:34 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:44:48 2017 -0800" }, "message": "ART: Add operator \u003d\u003d and !\u003d with nullptr to Handle\n\nGet it in line with ObjPtr and prettify our code.\n\nTest: m\nChange-Id: I1322e2a9bc7a85d7f2441034a19bf4d807b81a0e\n" }, { "commit": "fb38266f9f766a857f5bec5ddfa69435892f1475", "tree": "a958301c9972f6ae2674a317ec3a443acadf35f2", "parents": [ "7a9510d68a42134f82d0c8d92458d203724b1311", "5643caf2eeded64fc8b4f2a43bdf6444bb3da77c" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Feb 10 23:45:29 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Feb 10 23:45:30 2017 +0000" }, "message": "Merge \"Remove breakpoints from redefined classes\"" }, { "commit": "5643caf2eeded64fc8b4f2a43bdf6444bb3da77c", "tree": "c0b36f02313d12feffd30787bd1f8ed3de1cbcef", "parents": [ "5bd09549b443659ddd81768c811dcb5c6850775c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Feb 08 11:39:07 2017 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Feb 10 13:17:20 2017 -0800" }, "message": "Remove breakpoints from redefined classes\n\nTest: Manual\nChange-Id: If8d9a38635bda7a0d69925b735b6f10055192b34\n" }, { "commit": "90b936ddda63139ff46a6755c3b83ad6e4ab4ac5", "tree": "c7ce2c3004eecc16ab41ed7cde105c3019638d4b", "parents": [ "b78a8af993e877d74c5938f65f95feaf2fa01321" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jan 31 08:58:55 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Feb 03 10:03:52 2017 -0800" }, "message": "ART: Refactor verify_object.h\n\nMove the actual VerifyObject check into a new cc file, as we\ncommonly don\u0027t enable the check at all. This allows to cut the\n-inl include from almost all current users.\n\nThis also exposes missing -inl includes. Also fix up some of our old\nmess where .h defined functions require -inl.h defined functions.\n\nTest: m\n\nChange-Id: I3dd821bbe2015564a29bf1ed9be00f7a7276ad61\n" }, { "commit": "48fe7948f235efc52a219a2724d9902b54d80dfa", "tree": "f1e17c9744d464e6a09499a4e12572a3ea30c6c2", "parents": [ "91db41f315f6c2366b7098c531224bee01170364" ], "author": { "name": "Tao Wu", "email": "lepton@google.com", "time": "Sun Jan 08 01:20:21 2017 -0800" }, "committer": { "name": "Tao Wu", "email": "lepton@google.com", "time": "Mon Jan 09 13:56:49 2017 -0800" }, "message": "Set timeout before connect to adb in jdwp.\n\nSometimes adb is in buggy status and just doesn\u0027t accept our\nconnection. Add a timeout in art side to make sure we aren\u0027t\nstuck there.\n\nBug: 34140694\nTest: mma -j40 test-art-host\nTest: ./art/tools/run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64\nChange-Id: Ia7756d5c03b57e87fe9642b0d32728aa6cead65c\nSigned-off-by: Tao Wu \u003clepton@google.com\u003e\n" }, { "commit": "ec107997ab237908d2910609b3e1f9f135b6179b", "tree": "3409ff1ee6f944d37ab8553898c6e35a0600679e", "parents": [ "16722603e0f0ef286085fbe9b2cbe9ccad86bfef", "d0a160d722e696b1a3ffb91dcfde61ee11bfb3e0" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jan 05 19:13:38 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jan 05 19:13:39 2017 +0000" }, "message": "Merge \"Fix unquitable apps when debug enabled.\"" }, { "commit": "d0a160d722e696b1a3ffb91dcfde61ee11bfb3e0", "tree": "fecf340a29cc23d8c0b84bd11d898b8b0917cca6", "parents": [ "d812f782978932f790b7e844cd992f116776b6e3" ], "author": { "name": "Tao Wu", "email": "lepton@google.com", "time": "Tue Dec 13 18:32:17 2016 -0800" }, "committer": { "name": "Tao Wu", "email": "lepton@google.com", "time": "Mon Dec 19 15:59:06 2016 -0800" }, "message": "Fix unquitable apps when debug enabled.\n\nThere is a race condition that we could read from control_sock_ after we are\nasked to shutdown. Then we are stuck at pthread_join and can\u0027t exit.\n\nBug: 33592362\n\nTest: manual - for detail, check bug description.\n\nChange-Id: Ia7ece00131803a55fc040323ec19665d9b0300f9\nSigned-off-by: Tao Wu \u003clepton@google.com\u003e\n" }, { "commit": "46ee31b67d7ee1bd085fbc240502053caa3cf8fa", "tree": "83e870f293cd60d533207e389d7b094acd87b31f", "parents": [ "9538f9e2a5d03f1b1bc07ebfbd93b61dcf8ad604" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 14 10:11:49 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 15 09:50:39 2016 -0800" }, "message": "ART: Move to libbase StringPrintf\n\nRemove ART\u0027s StringPrintf implementation. Fix up clients. Add\nmissing includes where necessary.\n\nTest: m test-art-host\nChange-Id: I564038d5868595ac3bb88d641af1000cea940e5a\n" }, { "commit": "af8bcf83535cd7bf5651ada2fb08a0ba9c5191d6", "tree": "f029668c26269484652e9432fab3a246be81d2e7", "parents": [ "da2d78ba97d177b80e0e9528362bcebc1fd31f0f" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Nov 22 14:55:04 2016 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Nov 29 11:51:03 2016 +0100" }, "message": "Fix event reporting from the debugger thread\n\nThe debugger thread may trigger events (like CLASS PREPARE after the\ninitalization of a class while processing a command).\n\nThis CL removes the incorrect CHECK that makes the runtime abort in\nthis case. However, we do check that only the debugger thread can\nreport an event while it is already processing a command.\n\nBug: 33032664\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX64\u0027\nChange-Id: I32a284cfb4df6eb44eac27bbdcabd3c426d726ce\n" }, { "commit": "5c657fe8e3afdce77dc610446f37a43865cff702", "tree": "1f9fe466058b7512036b27a5b22f7720eb00729d", "parents": [ "2ab98309c0fc7b3c7451205b2371db5c34b05d49" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 03 15:12:29 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 03 15:13:06 2016 +0000" }, "message": "Pass some arguments by const reference.\n\nTest: Rely on TreeHugger.\nBug: 32619234\nChange-Id: Ia26277893641dcb3562eaeacaec4e089a978d56a\n" }, { "commit": "709b070044354d9f47641f273edacaeeb0240ab7", "tree": "3a8ac051d7c35076303984d0d892cdd396b60427", "parents": [ "1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 13 09:12:37 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Oct 18 14:10:04 2016 -0700" }, "message": "Remove mirror:: and ArtMethod deps in utils.{h,cc}\n\nThe latest chapter in the ongoing saga of attempting to dump a DEX\nfile without having to start a whole runtime instance. This episode\nfinds us removing references to ArtMethod/ArtField/mirror.\n\nOne aspect of this change that I would like to call out specfically\nis that the utils versions of the \"Pretty*\" functions all were written\nto accept nullptr as an argument. I have split these functions up as\nfollows:\n1) an instance method, such as PrettyClass that obviously requires\nthis !\u003d nullptr.\n2) a static method, that behaves the same way as the util method, but\ncalls the instance method if p !\u003d nullptr.\nThis requires using a full class qualifier for the static methods,\nwhich isn\u0027t exactly beautiful. I have tried to remove as many cases\nas possible where it was clear p !\u003d nullptr.\n\nBug: 22322814\nTest: test-art-host\nChange-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24\n" }, { "commit": "c4f3925490a73da8dc74884a1deb965d4ecaf14e", "tree": "7fe566827f8ab903af1acb5697c86a6efe3187b3", "parents": [ "18f7de841fee3ca6f0c04e7caa57c3ce76b36231" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 05 18:32:08 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 06 13:55:58 2016 -0700" }, "message": "Move remaining jobject related functions to use ObjPtr\n\nAlso added ObjPtr::DownCast.\n\nBug: 31113334\n\nTest: test-art-host\n\nChange-Id: I59c253211dc435579ffdfd49f856861ab13d262c\n" }, { "commit": "3398c7874e002beaa6c2b2fadf183e7d1ddad23a", "tree": "7db754b5b0c3a6c68bc1f91d7cb2477f534d2ad3", "parents": [ "462e21cc8d28a4d48342cf0f634bd1ecc63647d7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 30 10:27:43 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 03 14:06:27 2016 -0700" }, "message": "Move ArtField to ObjPtr\n\nAdded EXPECT_OBJ_PTR_EQ and variants to gtests.\n\nFixed moving GC bugs in:\nClassLinker::CreatePathClassLoader\nClassLinkerTest: StaticFields\n\nObjPtr Decode call sites: 186 -\u003e 181.\n\nSome tests fail due to ResolvedFieldAccessTest, will fix in follow\nup CL.\n\nBug: 31113334\n\nTest: test-art-host CC baker\n\nChange-Id: I8b266ad00f3c20c8cbe7cfdf280d175083df0b88\n" }, { "commit": "0795f23920ee9aabf28e45c63cd592dcccf00216", "tree": "ff3f880c5e84f3316532b47d0e9a7729ade848ac", "parents": [ "d1224dce59eb0019507e41da5e10f12dda66bee4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 27 18:43:30 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 29 17:31:09 2016 -0700" }, "message": "Clean up ScopedThreadStateChange to use ObjPtr\n\nAlso fixed inclusion of -inl.h files in .h files by adding\nscoped_object_access-inl.h and scoped_fast_natvie_object_access-inl.h\n\nChanged AddLocalReference / Decode to use ObjPtr.\n\nChanged libartbenchmark to be debug to avoid linkage errors.\n\nBug: 31113334\n\nTest: test-art-host\n\nChange-Id: I4d2e160483a29d21e1e0e440585ed328b9811483\n" }, { "commit": "3fec9ac0d5af1358d216eb2fdc2000ec0205f3f0", "tree": "f38d8d8aae51f53e7ee6b474f47597b784fc2316", "parents": [ "0cfe19af3b7395658210ea6044a65c9811962a7a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 13 10:47:28 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 26 10:59:22 2016 -0700" }, "message": "ART: Use libbase logging\n\nMove most of our logging infrastructure over to system/core/base.\nRetain VLOG.\n\nUsing unified Android infrastructure has two main advantages. First,\nit reduces the complexity/maintenance burden in ART. Second, it\nallows to detach logging for the cases where we do not want or need\na runtime, e.g., dexdump, the disassembler, etc. As a part of the\nlatter, libbase is also supported for all hosts (including Windows).\n\nFrom a developer viewpoint, there are minor behavior changes for the\nLOG statements (see above), but otherwise usage is the same. Explicit\nseverity enum items are in the android::base namespace now.\n\nBug: 31338270\nTest: m test-art-host\nChange-Id: I5abcb2f45f5b03d49951874c48544f72a283a91b\n" }, { "commit": "bdf7f1c3ab65ccb70f62db5ab31dba060632d458", "tree": "25cc77adfeb05232d0ab00aa561a693f1d71745c", "parents": [ "d7eabc2cc1a88c1f7f927da61246ae65aab0626c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 16:38:47 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 17:02:53 2016 -0700" }, "message": "ART: SHARED_REQUIRES to REQUIRES_SHARED\n\nThis coincides with the actual attribute name and upstream usage.\nPreparation for deferring to libbase.\n\nTest: m\nTest: m test-art-host\nChange-Id: Ia8986b5dfd926ba772bf00b0a35eaf83596d8518\n" }, { "commit": "3aaa37bba53d6df0265793de48b4b0b57327e57a", "tree": "ce795803f0f10003eb3d96d9348da620937675b3", "parents": [ "792c98bb773c8c2390f9cbf774f85be9d9a75332" ], "author": { "name": "jessicahandojo", "email": "jessicahandojo@google.com", "time": "Fri Jul 29 14:46:37 2016 -0700" }, "committer": { "name": "jessicahandojo", "email": "jessicahandojo@google.com", "time": "Tue Aug 23 15:12:26 2016 -0700" }, "message": "creating workflow for mirror::String compression\n\nAll-ASCII String characters are stored in 8-bit blocks\ninstead of 16-bit. The compression has not taken place, but all\nworkflow are in the code already (changing kUseStringCompression in\nstring.h file to TRUE will enable the feature)\n\nNotes: Feature works on interpreter only without optimizing\n\nTest art: m ART_TEST_INTERPRETER\u003dtrue ART_TEST_OPTIMIZING\u003dfalse\n test-art-host\n\nAlso tested with String tests from libcore/:\n1. libcore.java.lang.StringTest\n2. libcore.java.lang.StringBufferTest\n3. libcore.java.lang.StringBuilderTest\n4. libcore.java.lang.OldStringTest\n5. libcore.java.lang.OldStringBufferTest\n\nMemory improvement is 33% (from 6.03% to 4.03%, total String memory\nfrom all apps per total memory of all apps) measured on Angler\nwith Hprof tools\n\nBug: 31040547\nChange-Id: I9cc92c265ebf1305fc06b5fc33efd83797660cce\n" }, { "commit": "bb661c0f0cb72d4bbfc2e251f6ded6949a713292", "tree": "4fe7e66f3385b1955934d3ec6f02e00bde6e13b8", "parents": [ "f7cda8088ec57ab1422f85f08df78e217a9f7094" ], "author": { "name": "Bilyan Borisov", "email": "bilyan.borisov@linaro.org", "time": "Mon Apr 04 16:27:32 2016 +0100" }, "committer": { "name": "Bilyan Borisov", "email": "bilyan.borisov@linaro.org", "time": "Fri Apr 22 13:33:30 2016 +0100" }, "message": "Refactor use of __ANDROID__ macro\n\nWe use the __ANDROID__ macro, which is provided by the toolchain, in\nnumerous places. This patch refactors the usage of this by defining a\nnew macro, ART_TARGET_ANDROID, that is being passed during build to\nART_TARGET_CFLAGS in Android.common_build.mk on the same line as\nART_TARGET. The codebase currently assumes that the existence of the\n__ANDROID__ macro implies that we are compiling art for an android\ntarget device. This is because, currently, target builds are compiled\nwith target toolchains that provide the macro, while host toolchains\ndo not. With this change this assumption is still preserved. However,\nin a future patch we will add the ability to compile art for a linux\ntarget, and in that case the ART_TARGET_ANDROID macro won\u0027t be passed\nanymore.\n\nChange-Id: I1f3a811aa735c87087d812da27fc6b08f01bad51\n" }, { "commit": "4a28e1e4e02aa44aa6fd20e22d50f9d73f6279cc", "tree": "a80ef1c63ed7340cdbcb1f802e0cb26f00d2317f", "parents": [ "8ff01690eb2796604b8927076fdde7452b4c8a60" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Feb 24 16:35:59 2016 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Feb 25 09:41:30 2016 -0800" }, "message": "Support new JDWP InterfaceType.InvokeMethod command\n\nThis command is used to invoke static methods in interfaces.\n\nBug: 27218415\n\nChange-Id: Ie4dc1876a20567240267f309dc18f1aec2c1b4c2\n" }, { "commit": "d817560c697508df0d941071c8e96152c9404def", "tree": "75c683f08cba17582e60ab81cc593a0727fff66f", "parents": [ "3cbad24f0ee3639ac2ce2d06d61e97386df6f94b" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Jan 26 10:22:14 2016 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Jan 26 10:22:14 2016 +0000" }, "message": "Fix non-Linux builds.\n\nDo no expose a constant only used in Linux builds in\nruntime/jdwp/jdwp_socket.cc.\n\nChange-Id: I0f1de4fd36a9013b46b1393ea0cded41bae2b751\n" }, { "commit": "3cbad24f0ee3639ac2ce2d06d61e97386df6f94b", "tree": "345a3fad81306e946708a3bbb68708a4c69fa3a6", "parents": [ "6a75b9e1f3d8f0703f29db12eed532867e210def" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jan 25 19:17:14 2016 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jan 25 19:17:14 2016 +0000" }, "message": "Improve gethostbyname_r use in art::JDWP::JdwpSocketState::Establish.\n\nTry a range of values for the work buffer size, instead of\nusing a fixed size.\n\nAlso, turn a couple of constants defined as macros into\nconstexprs.\n\nChange-Id: I2354bfb51935bb0cad775c13d6cae06902b4a934\n" }, { "commit": "15f9b27adf1e1eb64a42d872f88e95ba637ce775", "tree": "c0f174d67ce4c447194a5a057b30b32aae3d49d7", "parents": [ "8ae596fb0496d93b8d9bb5d5b162d7e6c32c39a2" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jan 21 14:01:10 2016 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jan 21 14:01:10 2016 +0000" }, "message": "Improves recent changes to art::JDWP::JdwpSocketState::Establish.\n\n(This is a follow-up CL to\nhttps://android-review.googlesource.com/#/c/197630.)\n\nCapture the size of the work buffer passed to\ngethostbyname_r in a constant and document it.\n\nAlso wrap long lines in runtime/jdwp/jdwp_socket.cc.\n\nChange-Id: Ieb0694c56611a491c5f949ce8ed22ab3795f1883\n" }, { "commit": "0502c4467fde37469daf24526dd5ff6fd1c71708", "tree": "7fd9ddb8d0df9c7c6c07e2dfd9757a432803618a", "parents": [ "c1d7861e511b8abcc9f3ad6fc54ff07e80dc383e" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jan 21 11:19:51 2016 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jan 21 11:27:43 2016 +0000" }, "message": "Fix JDWP host tests on Trusty.\n\nThe buffer passed by art::JDWP::JdwpSocketState::Establish\nto gethostbyname_r on Trusty was too small, leading to the\nfollowing error message during JDWP host testing:\n\nart/runtime/jdwp/jdwp_socket.cc:283] gethostbyname_r(\u0027localhost\u0027) failed: Resolver internal error\n\nThis CL doubles the size of this buffer to avoid this\nfailure.\n\nChange-Id: Ie7bb1ea8c755d869f2cc50cc2f6cc82828499706\n" }, { "commit": "b06e28e5b9fbabe3e69b18f31bf353eaff5d0c1f", "tree": "18ff419c6a3b80ecff3125f13b72a8851e848ab0", "parents": [ "f71b3ade9c99ce2fec2f5049ce9c5968721e1b81" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Dec 10 13:15:00 2015 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Dec 15 15:11:50 2015 +0000" }, "message": "Refactor DexFile::DecodeDebugInfo.\n\nSplit the method into two - one for locals and one for positions.\nAll uses of the method request only one of the two and it makes the\ncode slightly cleaner. The position variant requires fewer parameters.\n\nExpose additional line table information which was previously ignored\nby the decode method (prologue, epilogue, source file).\n\nChange-Id: Idf8ba98fa58ea0d2103932b5cc0af81365885107\n" }, { "commit": "0a97fc6613d525370d9300819a3579f706d6fc67", "tree": "0b1239d9d22782d59acc81defe92e08afaf7d6c4", "parents": [ "55a77ef5f99c2b056eb5f2820c1ff3b29c0ec270" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Nov 09 12:18:06 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Nov 09 12:18:06 2015 +0100" }, "message": "JDWP: default implementation of Method.IsObsolete\n\nTo please some IDEs sending this command, adds a default\nimplementation that a method is never obsolete.\n\nBug: 25552174\nBug: https://code.google.com/p/android/issues/detail?id\u003d192784\nChange-Id: I328522e6313f2ef5474897cad15a95edd33cd15c\n" }, { "commit": "358bcaf13ec288ee45be8fc53cb09170c1b8a8f1", "tree": "cee1b848ae498b4d59b88c4273b3c4544d6b430a", "parents": [ "66e33f1906be899f140d5fe2a657db4e3993106e" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Oct 21 16:18:58 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Oct 21 16:22:59 2015 +0200" }, "message": "JDWP: fix possible JdwpEvent memory leak\n\nFixes possible memory leak when registering new JdwpEvent but the\nCount modifier is invalid. This is done by using a std::unique_ptr\nwith a custom delete function. It also allows to easily introduce\nmore modifier checks in the future.\n\nBug: 14076832\nChange-Id: I339ffb1297165ff85ab924e5e7618d336df5612b\n" }, { "commit": "4b8f1ecd3aa5a29ec1463ff88fee9db365f257dc", "tree": "d113f8a5c6b61c078256cf15c7cbb9f7c8de0390", "parents": [ "114873103db3d4d6e0da42ca02bad1ea8826443b" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Aug 26 18:34:03 2015 +0100" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 15 12:22:39 2015 -0700" }, "message": "Use ATTRIBUTE_UNUSED more.\n\nUse it in lieu of UNUSED(), which had some incorrect uses.\n\nChange-Id: If247dce58b72056f6eea84968e7196f0b5bef4da\n" }, { "commit": "f1d666e1b48f8070ef1177fce156c08827f08eb8", "tree": "772cbbe6652b32ea2be31532156295db27579390", "parents": [ "897ce64153e4758663e464fb5fb339f9a7b496c8" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 03 16:13:34 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 03 17:33:19 2015 -0700" }, "message": "Add ScopedThreadSuspension\n\nFixes the TransitionFromRunnableToSuspended and\nTransitionFromSuspendedToRunnable pattern that was prone to errors.\n\nChange-Id: Ie6ae9c0357c83b4fc4899d05dfa0975553170267\n" }, { "commit": "738c4c909c7668bc80b0d12f9b818061115e5c6f", "tree": "a19155f7c07968448509fc3311dfc7ae29f42f1d", "parents": [ "c26b4512a01d46756683a4f5e186a0b7f397f251" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Sep 02 14:30:13 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Sep 02 16:30:08 2015 +0200" }, "message": "JDWP: attempt to fix failure on closed connection\n\nDon\u0027t send packet if JDWP connection has been closed while\nprocessing a JDWP command.\n\nWe used to DCHECK(IsConnected()) in JdwpNetStateBase::WritePacket\nbut this is wrong when the connection has been closed by the debugger\n(client) before we sent the packet. It seems to happen more during\nJDWP tests due to how debugger and debuggee are synchronizing with\neach other.\n\nBug: 22907762\nChange-Id: I1c886382268697b4c50755b6009cceac7b8d656e\n" }, { "commit": "aa50d3a01a4137cd89c152be5487fed23683d0ff", "tree": "a676638c9d43eb519214445173c1a66ba38355ac", "parents": [ "f0170ded84fbcd3d9152cdbcf9ffbf74c71b03ba" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Aug 25 15:25:41 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Aug 25 15:56:54 2015 +0200" }, "message": "Add missing field init in constructors\n\nAdds missing field initializations detected by Eclipse IDE.\n\nChange-Id: I5f2f32bcccb12545fc9f0b42fcec74a23dc81376\n" }, { "commit": "3901bbc170b73b13aa5092f5709a495a1847198f", "tree": "eeb30634318ff2d576870131d54d24b71ad2566a", "parents": [ "1f3f766d3b365d01f36b85dc19d40f754fa48533" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Aug 06 11:37:02 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Aug 06 11:38:32 2015 +0200" }, "message": "Fix DDM reply buffer deallocation\n\nReply buffer is an uint8_t* allocated with new uint8_t[...] so it\nmust be deallocated with delete[], not free.\n\nChange-Id: Ib5d6387aa63f1e0393113f82602f661bbada4aa2\n" }, { "commit": "90ef3db4bd1d4865f5f9cb95c8e7d9afb46994f9", "tree": "3c6f8989e0c6e027382a3c08d221ba97afd72291", "parents": [ "1cf85515600d298a2c9e4de137c0926949205097" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Aug 04 15:19:41 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Aug 04 18:56:54 2015 -0700" }, "message": "Address some comments and clean up\n\nChange-Id: I538cf204f1c89d5fc81f8fc5e5800fcf1cf87359\n" }, { "commit": "c60e1b755c5632dfeb04c333489ede52ee5c945f", "tree": "9582a0ffc99e4ad11dcd5d95dd97b09bc6acc5bf", "parents": [ "7b926cdacc2b67241bc9cb5f2d4b04b13ca79d0e" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jul 30 08:57:50 2015 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jul 30 08:57:50 2015 -0700" }, "message": "ART: Use __ANDROID__ instead of HAVE_ANDROID_OS\n\nUse the proper define.\n\nChange-Id: I71e291ac25f5d5f0187ac9b6ef2d6872f19e6085\n" }, { "commit": "90443477f9a0061581c420775ce3b7eeae7468bc", "tree": "8c74b81dfae162e0fd0ccf8d5ac50827ba815174", "parents": [ "6078aec213dfaf111c29969706e8e5967cfc9bea" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 16 20:32:27 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 22 15:13:56 2015 -0700" }, "message": "Move to newer clang annotations\n\nAlso enable -Wthread-safety-negative.\n\nChanges:\nSwitch to capabilities and negative capabilities.\n\nFuture work:\nUse capabilities to implement uninterruptible annotations to work\nwith AssertNoThreadSuspension.\n\nBug: 20072211\n\nChange-Id: I42fcbe0300d98a831c89d1eff3ecd5a7e99ebf33\n" }, { "commit": "cbc5064ff05179b97b416f00ca579c55e38cd7d9", "tree": "9ce221e6644ff770b8484ba8cb5581e538b88eef", "parents": [ "864a2d955aa85ab989c86d7f1eeacbe0b11f8b0f" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Jun 01 17:33:12 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jun 10 09:35:08 2015 +0200" }, "message": "JDWP: asynchronous invoke command handling\n\nThe JDWP thread used to wait for the result of a method invocation\nrunning in an event thread. But doing that prevents the JDWP thread\nfrom processing incoming commands from the debugger if the event\nthread gets suspended by a debug event occurring in another thread.\nIn Android Studio (or another IDE), this leads to the debugger being\nblocked (with the famous message \"Waiting until last debugger command\ncompletes\" of Android Studio / IntelliJ) because it is actually\nwaiting for the reply of its latest command while the JDWP thread\ncannot process it.\n\nThis CL changes the way invoke commands (ClassType.InvokeCommand,\nClassType.NewInstance and ObjectReference.InvokeCommand) are handled\nin the ART runtime.\nThe JDWP thread no longer waits for the event thread to complete the\nmethod invocation. It now simply waits for the next JDWP command to\nprocess. This means it does not send any reply for invoke commands,\nexcept if the information given by the debugger is wrong. In this\ncase, it still sends a reply with the appropriate error code.\nThe event thread is now responsible for sending the reply (containing\nthe result and the exception object of the invoked method) before\ngoing back to the suspended state.\n\nIn other words, we add special handling for invoke commands so they\nare handled asynchronously while other commands remained handled\nsynchronously. In the future, we may want to handle all commands\nasynchronously (using a queue of reply/event for instance) to remove\nthe special handling code this CL is adding.\n\nNow the JDWP thread can process commands while a thread is invoking\na method, it is possible for the debugger to detach (by sending a\nVirtualMachine.Dispose command) before the invocation completes. In\nthat situation, we must not suspend threads again (including the\nevent thread that executed the method) because they would all remain\nsuspended forever.\n\nAlso minor cleanup of the use of JDWP constants and update comments.\n\nBug: 21515842\nBug: 18899981\nChange-Id: I15e00fb068340f3d69dc9225d8d2065246e68c58\n" }, { "commit": "e401d146407d61eeb99f8d6176b2ac13c4df1e33", "tree": "17927f9bfe7d2041b5942c89832d55f9dedb24c5", "parents": [ "2006b7b9b8e32722bd0d640c62549d8a0ac624b6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 13:56:20 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 29 18:45:49 2015 -0700" }, "message": "Move mirror::ArtMethod to native\n\nOptimizing + quick tests are passing, devices boot.\n\nTODO: Test and fix bugs in mips64.\n\nSaves 16 bytes per most ArtMethod, 7.5MB reduction in system PSS.\nSome of the savings are from removal of virtual methods and direct\nmethods object arrays.\n\nBug: 19264997\nChange-Id: I622469a0cfa0e7082a2119f3d6a9491eb61e3f3d\n" }, { "commit": "80afd02024d20e60b197d3adfbb43cc303cf29e0", "tree": "ef054c7b4f2a739f7cf063e0bc4c501c2c7e41b5", "parents": [ "559b178e34c5d92e7932f92e5d8a981ac334606f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 19 18:08:00 2015 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 26 15:59:02 2015 +0100" }, "message": "ART: Clean up arm64 kNumberOfXRegisters usage.\n\nAvoid undefined behavior for arm64 stemming from 1u \u003c\u003c 32 in\nloops with upper bound kNumberOfXRegisters.\n\nCreate iterators for enumerating bits in an integer either\nfrom high to low or from low to high and use them for\n\u003carch\u003eContext::FillCalleeSaves() on all architectures.\n\nRefactor runtime/utils.{h,cc} by moving all bit-fiddling\nfunctions to runtime/base/bit_utils.{h,cc} (together with\nthe new bit iterators) and all time-related functions to\nruntime/base/time_utils.{h,cc}. Improve test coverage and\nfix some corner cases for the bit-fiddling functions.\n\nBug: 13925192\nChange-Id: I704884dab15b41ecf7a1c47d397ab1c3fc7ee0f7\n" }, { "commit": "261bc044a3575512869586593e99e97cd8b1c321", "tree": "055fbf2bd3d7f836d4a872550ebe3c508eec5668", "parents": [ "bdd9f2d870099e326a281ac90993b37b999c35ea" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 08 09:36:07 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed May 13 09:23:00 2015 +0200" }, "message": "JDWP: more GC safety\n\nEnsures GC safety when keeping references that may be moved by GC:\n- SingleStepControl: stores ArtMethod* in a GcRoot\n- ModBasket: stores references in a StackHandleScope\n\nBug: 18166750\nChange-Id: If2b6f9ecff4cf469b50487fd863319fdfa9b9f37\n" }, { "commit": "9d6bf69ad3012a9d843268fdd5325b6719b6d5f2", "tree": "a41fc22d2c89e41c86feb5ef07ebda89b1b83d90", "parents": [ "b6829c2ee05124d64a19c7a52ada4a23f624fb91" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 10 12:12:33 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 29 16:59:58 2015 +0200" }, "message": "JDWP: properly combine location events\n\nThis CL properly groups JDWP events at the same location: Breakpoint,\nSingle-step, Method Entry and Method Exit. This is necessary if the\ndebugger is not the only instrumentation listener. This matches the\nbehavior of Dalvik, especially for methods with a single return\ninstruction.\n\nThe interpreter was tuned so the instrumentation callbacks were\ncalled to satisfy the debugger with the idea the debugger was the\nonly instrumentation listener. This is not true when method tracing\nis enabled at the same time.\nWhen tracing is enabled, there is always a listener for MethodEntry\nand MethodExit events (art::Trace class). However, if the debugger\nis only listening to DexPcMoved event (to manage JDWP Breakpoint\nevent), it will not be notified of this event.\n\nWe now properly call all the instrumentation callbacks in the\ninterpreter and move the logic specific to debugging into the class\nDebugInstrumentationListener. This allows to properly group JDWP\nlocation events together depending on the sequence of instrumentation\ncallbacks.\n\nWe add Thread::tls_32bit_sized_values::debug_method_entry_ flag to\nremember we just entered a method. It replaces the local variable\nnotified_method_entry_event in the interpreter and simplifies the\ncode.\n\nBump oat version to force recompilation because the layout of the\nThread class is modified.\n\nBug: 19829329\nChange-Id: I204af9112e37d2eebc86661fb7c961a41c74e598\n" }, { "commit": "2cebb24bfc3247d3e9be138a3350106737455918", "tree": "d04d27d21b3c7733d784e303f01f873bb99e7770", "parents": [ "1f02f1a7b3073b8fef07770a67fbf94afad317f0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 21 16:50:40 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 12:44:27 2015 -0700" }, "message": "Replace NULL with nullptr\n\nAlso fixed some lines that were too long, and a few other minor\ndetails.\n\nChange-Id: I6efba5fb6e03eb5d0a300fddb2a75bf8e2f175cb\n" }, { "commit": "d3ed9a320a89cb9b91b2361892c043ab7e112717", "tree": "94d2b646e8ff9b28e0bef735804ce17a6a8be729", "parents": [ "4b5673b7387804947a1605a906deee132ab28f14" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 10 14:23:35 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Apr 13 16:15:22 2015 -0700" }, "message": "Fix DCHECK failures from Class::VisitFieldRoots\n\nWe now use GetDeclaringClassUnchecked when marking roots to fix\nflaky test failures. Fixed a race condition in root marking where\nwe could have non zero field array length with a null pointer.\nFixed a race condition where we could be marking roots before\nFixupTemporaryDeclaringClass had finished. The solution is to\nonly do the declaring class CHECK if we are at least resolved.\nFixed JDWP tests by changing FieldId / MethodId to be 64 bits.\n\nAlso some cleanup.\n\nChange-Id: Ibac09519860d93c3f68a5cc964bbc91dc10a279a\n" }, { "commit": "fac107bdddb5f2370f762e55a89847570e901245", "tree": "afde3114490d3deceee2be122f69a84528a5e972", "parents": [ "a4c7aa2ba0485c2c876107ca6e1ce1f835ae23be", "692063955ae845d8bd9fa2d22a50a1e06513bdcf" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Apr 13 17:04:58 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Apr 13 17:04:58 2015 +0000" }, "message": "Merge \"JDWP: fix thread_list deadlock\"" }, { "commit": "c785344b87221f5e4e6473e5b762e4e61fe65dcf", "tree": "cd32ad2c2604596a18926f04d4c313dab255ecfd", "parents": [ "a29d93b380c9aeb8270e281aefbdd0c77a430d43" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 27 14:35:38 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 10 12:57:27 2015 -0700" }, "message": "Move ArtField to native\n\nAdd linear alloc. Moved ArtField to be native object. Changed image\nwriter to put ArtFields after the mirror section.\n\nSavings:\n2MB on low ram devices\n4MB on normal devices\n\nTotal PSS measurements before (normal N5, 95s after shell start):\nImage size: 7729152 bytes\n23112 kB: .NonMoving\n23212 kB: .NonMoving\n22868 kB: .NonMoving\n23072 kB: .NonMoving\n22836 kB: .NonMoving\n19618 kB: .Zygote\n19850 kB: .Zygote\n19623 kB: .Zygote\n19924 kB: .Zygote\n19612 kB: .Zygote\nAvg: 42745.4 kB\n\nAfter:\nImage size: 7462912 bytes\n17440 kB: .NonMoving\n16776 kB: .NonMoving\n16804 kB: .NonMoving\n17812 kB: .NonMoving\n16820 kB: .NonMoving\n18788 kB: .Zygote\n18856 kB: .Zygote\n19064 kB: .Zygote\n18841 kB: .Zygote\n18629 kB: .Zygote\n3499 kB: .LinearAlloc\n3408 kB: .LinearAlloc\n3424 kB: .LinearAlloc\n3600 kB: .LinearAlloc\n3436 kB: .LinearAlloc\nAvg: 39439.4 kB\n\nNo reflection performance changes.\n\nBug: 19264997\nBug: 17643507\n\nChange-Id: I10c73a37913332080aeb978c7c94713bdfe4fe1c\n" }, { "commit": "a2d40be3e64b339c6c39d59655507c597251e506", "tree": "011137a2bb46a6bc56e9b47c0e5c9d7978aa8ace", "parents": [ "9d0ab6f0a2f08c3fa9a59e0b8742cf366d7d0feb", "4e5b20863898006ec6c9d120cda167d38dda6e60" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 08 16:42:38 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Apr 08 16:42:39 2015 +0000" }, "message": "Merge \"Fix JDWP race at runtime shutdown\"" }, { "commit": "692063955ae845d8bd9fa2d22a50a1e06513bdcf", "tree": "39771e7a445ec9ff5d6c79bb37ff268e44d8ef64", "parents": [ "1b8e8cac2c96f6d2af8e7217f997a30e11c098b5" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 07 15:54:25 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 08 12:13:28 2015 +0200" }, "message": "JDWP: fix thread_list deadlock\n\nLimits the scope of Locks::thread_list_lock_ locking in the debugger\nso we do not try to lock it twice when creating a JDWP id (because\ncalling Object::IdentityHashCode may need to take the lock).\n\nBug: 20048099\nChange-Id: I305dd72ccc4d2d007d1603b0d52bcfa94b6842a7\n" }, { "commit": "2c3e77a0b91b2225fcdd3b34d8a734b85eec0579", "tree": "e963fb08cd1072cb78e448334582c95d37e1f95c", "parents": [ "c6e949a6d93fae2351fc59ed825657adee8185dc" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Apr 02 16:26:48 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Apr 02 16:51:24 2015 +0200" }, "message": "JDWP: clear exception when allocation fails\n\nClears pending exception if an allocation (requested by the debugger)\nfails and logs an error message about the failure.\n\nChecks we never leave a pending exception after processing a JDWP\nrequest.\n\nBug: 20037531\nChange-Id: I63239034a3c1ab368b0e19c2f5f756d9e2ec6a29\n" }, { "commit": "4e5b20863898006ec6c9d120cda167d38dda6e60", "tree": "8cb7e98c87a4e48e6237fd2c172ae39f5b7f5a76", "parents": [ "04914da1385564fca1990863d9a2690af10e1946" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Mar 24 19:03:40 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 01 12:22:52 2015 +0200" }, "message": "Fix JDWP race at runtime shutdown\n\nWhen the runtime shuts down, it closes the JDWP connection with the\ndebugger. However, if a JDWP command is still being processed by the\nJDWP handler thread when we close the connection, we won\u0027t be able to\nsend its reply.\n\nBug: 19628620\nChange-Id: I20301325a347d66f3b9ef95ebe8f156abafb1f76\n" }, { "commit": "eb07669e9784ccb41d75df180727e57fc4520e28", "tree": "bc15da11ee0ce906252a33371f8f59138bc5a38f", "parents": [ "bce0855ca1dbb1fa226c5b6a81760272ce0b64ef" ], "author": { "name": "Daniel Mihalyi", "email": "daniel.mihalyi@mattakis.com", "time": "Fri Aug 22 17:33:31 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Mar 24 14:43:57 2015 +0100" }, "message": "JDWP: Optimized single step during debugging\n\nFor single stepping full deoptimization and undeoptimizations were\nperformed with significant overhead, because every code will be\nexecuted in interpreted mode during a single step, even if it is not\nstrictly required.\n\nFor example, if we have a computation heavy method call and we would\nlike to step over it, that method (and all the methods called from it)\nwill run in interpreter mode. This can take so long in some cases\n(e.g. multiple minutes) that it makes debugging process unusable.\n\nThe solution for this limitation is not using full deoptimizations for\nsingle steps and force interpreter only for those methods that we are\nabout to step into, and require stack deoptimization before step outs.\n\nBug: 17750566\nBug: 18094282\nBug: https://code.google.com/p/android/issues/detail?id\u003d77984\n\nChange-Id: I683c52465883146c4c84ec47bf96f8efd920527f\nSigned-off-by: Daniel Mihalyi \u003cdaniel.mihalyi@mattakis.com\u003e\n" }, { "commit": "1558b577907b613864e98f05862543557263e864", "tree": "5498d8d15f198341fe46a8badc7e7591611a09b5", "parents": [ "2cfdabd2bb4833d7092819d27ef08a9e1cdffead" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Feb 25 15:05:59 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Mar 09 15:19:49 2015 +0100" }, "message": "JDWP: allocate DebugInvokeReq only when requested\n\nOnly allocates thread-local DebugInvokeReq when the debugger requests\na thread to invoke a method. The JDWP thread allocates that structure\nthen attaches it to the target thread. When the thread is resumed, it\nexecutes the method. Once the invocation completes, the thread\ndetaches the DebugInvokeReq, signals the JDWP thread then suspends.\nFinally, the JDWP thread wakes up, prepares the reply with the invoke\nresult (or exception) and deallocates the DebugInvokeReq.\n\nAlso ensures GC safety for object returned by the invoke. We add the\nobject to the JDWP object registry right after the invoke. We now\nreference that object with a JDWP ObjectID instead of an Object* in\nthe DebugInvokeReq struct. This prevent from accessing a stale\nreference if the GC runs and moves the Object*.\n\nThis CL includes the following changes:\n- Move former DebugInvokeReq::ready flag to\n Thread::tls_32bit_sized_values::ready_for_debug_invoke. It\u0027s needed\n to know whether a thread has been suspended by an event, thus ready\n to invoke a method from the debugger.\n- Remove DebugInvokeReq::invoke_needed: we now test if we attached a\n DebugInvokeReq* to the thread.\n- Rename misleading FinishMethod function to RequestMethod.\n\nBug: 19142632\nBug: 18166750\nChange-Id: I351fb4eb94bfe69fcafb544d21d55ff35a033000\n" }, { "commit": "184c9dc3bfc500134fdb2fbea0a7fab290c0abb0", "tree": "753a040fa1ef43651dd36fc4dfeb9377dc88e481", "parents": [ "66b26662ad0c52c648c9b5ea4a99149091e842b4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 05 13:20:54 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 05 13:25:51 2015 -0800" }, "message": "Fix some incorrect IsCompiler instead of IsAotCompiler\n\nFixes jdwp related issues (DDMS) when JIT is enabled.\n\nBug: 19623297\nChange-Id: I36139c70a97b529135febcf01b227e7ab9affacc\n" }, { "commit": "ff9b747588e77f04b07dc76b2d39a82cbfc60441", "tree": "5daf6478955d0f3c38cb10a4864bb8564b20ee97", "parents": [ "f16fe893139345dad8b05b3db3e717c6f8d079d0", "813b9602dadeabf33439cb0592072744f6241ce5" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Feb 26 06:17:12 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Feb 26 06:17:13 2015 +0000" }, "message": "Merge \"JDWP: fix thread state on event suspension\"" }, { "commit": "813b9602dadeabf33439cb0592072744f6241ce5", "tree": "a92393ce95b3e28d7ef9190352842fe58083d4d2", "parents": [ "0b6daeb0f0014474b542cbba1f713eb0dbefb7f9" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Feb 24 14:56:59 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Feb 25 17:29:21 2015 +0100" }, "message": "JDWP: fix thread state on event suspension\n\nBefore suspending event thread, we ensure its state is kSuspended\nso the debugger sees it as RUNNING instead of WAIT.\n\nBug: 19103406\nChange-Id: I58b4141a958bf6a3c360f6994967fad0078ea373\n" }, { "commit": "e4266c511ffe6a1ed472292bea06881dcbf06f7a", "tree": "107bf68179b24919f284246cba181a0113119660", "parents": [ "0b6daeb0f0014474b542cbba1f713eb0dbefb7f9" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Oct 29 12:06:51 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Feb 24 18:00:29 2015 +0100" }, "message": "JDWP: assert no pending exception when using JNI\n\nChecks there is no pending exception when creating new JDWP ids using\nJNI routines. We can create JDWP ids when executing code and report\nan event like a breakpoint.\n\nBug: 17491155\nChange-Id: I4e5851bf2261510b7776a709a2388e7ff586a77c\n" }, { "commit": "2bf93f48bbb417b358c9e3c77911ea6ec7307c15", "tree": "4a3cbadecf70b370423418d80bd738fc326aa846", "parents": [ "b991d334e294cb9fb75bd1c36e2435171c084cd1" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Jan 09 18:44:05 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Feb 06 17:46:58 2015 +0100" }, "message": "JDWP: update thread synchronization\n\nThis CL ensures only one thread can do JDWP stuff at a time: either\nprocessing a command coming from the debugger (JDWP thread) or\nsending an event (breakpoint, class prepare, etc) to the debugger\nbefore suspending.\n\nThe JDWP thread now uses AcquireJdwpTokenForCommand and\nReleaseJdwpTokenForCommand, respectively acquiring and releasing the\ntoken used for synchronization. On the other hand, the event threads\nnow use AcquireJdwpTokenForEvent and ReleaseJdwpTokenForEvent.\n\nDuring an invoke, the target thread needs to take the JDWP token to\nexecute the method while it\u0027s already held by the JDWP handler thread\nwaiting for the invocation to complete. To avoid both threads from\nwaiting for each other (deadlock), the JDWP thread releases the token\nand acquires it again after the invocation is complete, so the target\nthread can run safely and prevents other threads from sending events.\n\nBug: 19120467\nChange-Id: Ie3208fb940a60573769d494128cf22f0fa30fa61\n" }, { "commit": "3be6e9d904baa13d7cf51dfc6742dea12e766b2e", "tree": "43ad5f3655d73243ab212eefb83169471a1d87b3", "parents": [ "24898d447640c3a45e6fc9f404b049eddc5a2709" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Feb 05 16:30:58 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Feb 05 18:28:54 2015 +0100" }, "message": "Read JDWP options from runtime\n\nAllocates JDWP::JdwpOptions on the heap and copies parsed options to\navoid the need to include jdwp/jdwp.h into runtime.h file.\n\nAlso does some minor cleanup and removes the old JDWP options parsing\ncode that became dead code after we move it to the new command-line\nparser.\n\nBug: 19275792\nChange-Id: I71901c89fbf2cc3c1901a089e2a98b4326c6ee70\n" }, { "commit": "aaebaa0121be3b9d9f13630585304482cbcaeb4b", "tree": "0f47257e497fdf920c8d703d2d00adab53934a76", "parents": [ "babecc483276b46d84cb83d4f01e577228827305" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Mon Jan 26 10:55:53 2015 -0800" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Feb 04 13:29:19 2015 -0800" }, "message": "art: Refactor RuntimeOptions/ParsedOptions\n\nRefactor the RuntimeOptions to be a\ntype-safe map (VariantMap, see runtime_options.h) and the ParsedOptions\nto delegate the parsing to CmdlineParser (see cmdline/cmdline_parser.h).\n\nThis is the start of a command line parsing refactor, and may include\nmore in the future (dex2oat, patchoat, etc).\n\nFor more details of the command line parsing generator usage see cmdline/README.md\n\nChange-Id: Ic67c6bca5e1f33bf2ec60e2e3ff8c366bab91563\n" }, { "commit": "b640deca3616a7a985d146a96407c1af3ffa1592", "tree": "19d4b1658222ec21ff5c352e9a683f43e90e038f", "parents": [ "7fd1c7eabc6c12a2ff67ef58860aae761c92136e", "55f6534f260ec82ef2d69a0667b1883f13d11399" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jan 14 08:37:47 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jan 14 08:37:49 2015 +0000" }, "message": "Merge \"JDWP: fix deadlock with GC\"" }, { "commit": "55f6534f260ec82ef2d69a0667b1883f13d11399", "tree": "6e00c7f32242baf3a1482db3656816a0b2f134a4", "parents": [ "8fccea249b1a6f1469eeea42c2b2cca06ce1c70d" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Jan 13 22:48:34 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Jan 13 23:11:06 2015 +0100" }, "message": "JDWP: fix deadlock with GC\n\nThis CL fixes a deadlock where JDWP thread and running GC thread are\nwaiting for each other. Here is the sequence of the deadlock:\n1. GC thread disables access to weak global references, then releases\n mutator lock.\n2. JDWP thread takes mutator lock exclusively after suspending all\n threads.\n3. GC thread waits for shared mutator lock which is held by JDWP\n thread.\n4. JDWP thread clears weak global references but need to wait for GC\n thread to re-enable access to them.\n\nTo avoid that situation, we ensure the JDWP thread does not attempt\nto delete weak global references while holding the mutator\nexclusively so GC thread is not blocked.\n\nBug: 18995321\nChange-Id: Ia7e82f463c27ffdcfd730c3117337a6a33d111e7\n" }, { "commit": "e6c143fae8ec487704b3d0d28914cda3d6d19e88", "tree": "270a0f83996e2abc15ab9d6b643f112afc89587e", "parents": [ "8fccea249b1a6f1469eeea42c2b2cca06ce1c70d" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Jan 13 10:10:40 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Jan 13 20:59:53 2015 +0100" }, "message": "Fix bootclasspath string initialization\n\nWhen running the runtime with an image without explicitly specifying\nthe bootclasspath (with the -Xbootclasspath option), we construct it\nfrom the location of DEX files loaded from the image.\n\nThis allows to fix the JDWP test ClassPathsTest#testClassPaths001 on\nthe host where the bootclasspath is not explicitly specified on the\ncommand line.\n\nBug: 18812378\nChange-Id: I726eafd8b9e59dc9513beeb7082cf086fe89c4b1\n" }, { "commit": "ad466adf38db74a9840659626858196091151a64", "tree": "feb296965a8a9659787a949e8e9aca0a7180774c", "parents": [ "46af48acf4221a7f819d58dfffb576d0523ae285" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 08 16:28:08 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 09 15:04:27 2015 -0800" }, "message": "Change hprof to use streaming\n\nPreviously, we compute the whole hprof dump in memory resulting in\n\u003e 50MB of memory usage for some apps (such as maps). This could\ncause the app to get killed by the low memory killer.\n\nThe solution works by doing the dump in 2 passes.\nThe first pass calculates the size of the dump.\nThe second pass starts by sending the DDMS header with the correct\nsize, then does the rest of the hprof dump by streaming and sending\ndata one HprofRecord at a time.\n\nBug: 18921793\nChange-Id: I7dd9f5cfe49799ba268095c994a8c2eb1fe493df\n" }, { "commit": "107e757bfd32cc27750955e6f392986414bebe75", "tree": "e75824f21bbd9c75b865608ccfe1c09c70ea50a7", "parents": [ "fcd3f33dde47ce13305a7dfb5a665bf832535ae4" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Dec 18 11:13:15 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Dec 18 11:29:28 2014 +0100" }, "message": "JDWP: do not report start/end events for thread without peer\n\nTo report start/end thread events, we need the JDWP id of the thread.\nTo create a JDWP id, we need its java.lang.Thread peer. In the case\nthere is no Java peer, we can\u0027t report the event.\n\nFollow-up https://android-review.googlesource.com/118548 where the\nruntime attaches the current thread without Java peer when shutting\ndown.\n\nChange-Id: Icc2d50f3d2eedd1e0e3c5a21affd2261aaf7a862\n" }, { "commit": "7d95565c84d91ae5dcec4b89728ada208633de0c", "tree": "3d45e97f3ca520a07c5005974b092e10fee0a433", "parents": [ "f610c0597e001cb1043aa4074afe25ae79a800e3" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Oct 22 10:57:10 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Dec 17 09:38:28 2014 +0100" }, "message": "Cleanup JDWP event matching\n\n* Use std::vector for the event match list.\n* Make event reporting methods void since result is never used.\n* Use nullptr keyword instead of NULL.\n\nChange-Id: Icd6f47e46cefc2cc63325df00037cd4b6a475259\n" }, { "commit": "6d7839e03348111a4237f0d47d0e70bc81b32e7a", "tree": "b499eff6e4bb4b57367a5acfbfd2deff58694e41", "parents": [ "c4925d4c02dc8f8d51cb2653b5e7a99f6c9fd7d7" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Dec 05 10:52:15 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Dec 09 11:40:13 2014 +0100" }, "message": "JDWP: avoid crash on unsupported modifier\n\nReturns NOT_IMPLEMENTED error if we receive an event request with an\nunsupported modifier.\n\nBug: https://code.google.com/p/android/issues/detail?id\u003d81037\nBug: 18617787\n(cherry picked from commit 0fb33e7b7b0b86fb9c7b556e4a052874ec269bb0)\nChange-Id: I97729e2f98af3a75d24604926a89860255d4acae\n" } ], "next": "f3928794a10516e2ac0ffe2686a10891788d4b9c" }