)]}' { "log": [ { "commit": "5c93af3cc8894deefbc9cba69ea69526c45842aa", "tree": "6f79a408832449163fcb2e320ad992393a2e8f32", "parents": [ "8f70b9672c13a5ca19cf2c54ace3cb2f342f743a" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Sep 09 10:51:16 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Sep 09 20:49:04 2019 +0000" }, "message": "Loosen verifier around interface-invoke-super\n\nWe were being overly strict with interface-invoke-super and not\nallowing an interface to invoke-super into its own methods without\ngoing to the interpreter. This causes some scala programs to run\nmostly in the interpreter. Our compiler is able to handle this\ncorrectly so we should allow it without any soft-verification\nfailures.\n\nTest: ./test.py --host\nBug: 140589303\nChange-Id: I40d9510add5bbfd41d2e38b68973fce77880f7e6\n" }, { "commit": "4ec4d48940696de077f88f9f8e9abdb178772301", "tree": "b43474eded81a67650795b1b0b0fc35e2a12afc7", "parents": [ "7263abc75f8d139f1efcae887870a2f537e45735" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 01 10:00:23 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Aug 27 17:09:27 2019 +0000" }, "message": "ART: Verifier cleanup\n\nStart making the method verifier more independent of externalities.\nThis will be implemented as incremental changes.\n\nIncorporate suggestions from previous changes: some C++ cleanup.\n\nTest: m test-art-host\nChange-Id: If903239bee58858427f0eb3e3e37a1ca767529c5\n" }, { "commit": "147a911636402f2658ce60bd3ad62eb197b00f74", "tree": "2fb507267d7bad2e906be49c4b18e709e4d706a2", "parents": [ "b90cad58077cd44411c2a1617aec7b6798e6a295" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 31 16:17:10 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 01 17:01:19 2019 +0000" }, "message": "ART: Remove FailOrAbort for unnecessary cases\n\nThe dex file verifier now correctly checks that the instruction array is\nnot empty. As such, index zero is always an instruction.\n\nSlightly refactor code for readability.\n\nTest: m test-art-host\nChange-Id: I3141944beef58a409c5ae52ba27fb5ce5945f9d1\n" }, { "commit": "b90cad58077cd44411c2a1617aec7b6798e6a295", "tree": "fdebb5c0c8e93d8680cb14bca5925483371ca153", "parents": [ "d1abab7110101d65774f9d090850d20aaa07b661" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 31 16:15:41 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 01 17:01:19 2019 +0000" }, "message": "ART: Move find-locks code up in the callchain\n\nMove the code into the caller and templatize the caller to save some\ninstructions and branches for the common case.\n\nTest: m test-art-host\nChange-Id: I6eee7b60e3f17db778ab98a49126b206c8547a2c\n" }, { "commit": "0134a28ec42f5c96a3dffcf496bf1af05d0942dc", "tree": "0b8857236fe1aab89718daee8219c4eb9408ad21", "parents": [ "86bf068459252f58686c71bd24dadd76aba45c8b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 29 11:34:55 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 01 17:01:19 2019 +0000" }, "message": "ART: Verifier cleanup\n\nStart making the method verifier more independent of externalities.\nThis will be implemented as incremental changes.\n\nReorder impl::MethodVerifier\u0027s constructor arguments to have all\nsuperclass arguments first. In an effort to simplify additions.\n\nTest: m test-art-host\nChange-Id: Iba119d74b0dd2dc8c4831efa823c191df6975d9d\n" }, { "commit": "86bf068459252f58686c71bd24dadd76aba45c8b", "tree": "837520d122851c85c2be2297ffe439735ebc00a4", "parents": [ "422a9ebc5b9d780a3201243f02b58652b44d9896" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 29 11:22:44 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 01 17:01:19 2019 +0000" }, "message": "ART: Verifier cleanup\n\nStart making the method verifier more independent of externalities.\nThis will be implemented as incremental changes.\n\nSome cleanup moving small function definitionss into their\ndeclaration.\n\nTest: m test-art-host\nChange-Id: I0b109572e0f892844966e0c25478d6306b2a5d6f\n" }, { "commit": "f1468b53d0427a45011fe6446d189babe0acd6e0", "tree": "d6be3e1ed2a56f30d8ae8593655db6d5e4826507", "parents": [ "fef91cc973f193d5b3a5a554b4910f0c548c08ad" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jul 26 09:22:39 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jul 29 20:10:20 2019 +0000" }, "message": "ART: Verifier cleanup\n\nStart making the method verifier more independent of externalities.\nThis will be implemented as incremental changes.\n\nIn this CL, require an ArenaPool in the constructor instead of\nexplicitly using the Runtime one.\n\nTest: m test-art-host\nChange-Id: I2a526d869532da732202198fdac68c426008b09a\n" }, { "commit": "fef91cc973f193d5b3a5a554b4910f0c548c08ad", "tree": "6aa735be1e7ff51073eeb15b70a67a2f1c4037d8", "parents": [ "e0bbab9fe1b073fecae78ca5d269bd0b2a177b4f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jul 25 14:13:23 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jul 29 20:10:20 2019 +0000" }, "message": "ART: Verifier cleanup\n\nStart making the method verifier more independent of externalities.\nThis will be implemented as incremental changes.\n\nIn this CL, replace querrying Runtime::Current() for AoT status\nwith a flag.\n\nTest: m test-art-host\nChange-Id: I91a3ad0208b544f47bb83db96edca6b4f86e5ce5\n" }, { "commit": "e0bbab9fe1b073fecae78ca5d269bd0b2a177b4f", "tree": "a6152ee32301ac78084be69fc73c8d54134da8b2", "parents": [ "52c468a765f0427dfb5a6627e8087e7b8acc3b8b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jul 25 12:28:22 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jul 29 20:10:20 2019 +0000" }, "message": "ART: Verifier cleanup\n\nStart making the method verifier more independent of externalities.\nThis will be implemented as incremental changes.\n\nIn this CL, replace querrying Runtime::Current() for the classlinker\nwith requiring the classlinker to use at construction time.\n\nTest: m test-art-host\nChange-Id: Id0a6a1f01c77bfe4cc9adfb490fc6ebc7bbf6392\n" }, { "commit": "d84794d235df588814533d96f6e459b72f3a19b1", "tree": "be63139f9d94678c6c1f01e2012545580b2d1078", "parents": [ "16a08f6d70e64a1c88ea4a6da1b0cfe1bd4196f2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jul 18 13:40:03 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jul 19 15:12:19 2019 +0000" }, "message": "ART: Add option to behave fatally on unmarked kThrow\n\nAdd a runtime option that makes the verifier abort when a runtime\nexception is signaled for an instruction that isn\u0027t marked as such.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: Id953fa25fbcc12c1e6a7d74b30b28b81df57e427\n" }, { "commit": "16a08f6d70e64a1c88ea4a6da1b0cfe1bd4196f2", "tree": "ab9ef002d1cffc3a589281047d5e1da232504994", "parents": [ "22940241f945710613c2657f9d6161302bed935d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jul 18 10:59:08 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jul 19 15:12:19 2019 +0000" }, "message": "ART: Factor out runtime-exception saved_line fallback\n\nDo the same for AoT and runtime. This is a minimal regression for\nthe compiler, but allows unified handling, including market scans.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: I82087935b1ad08280ab9da3f41d346b73314986a\n" }, { "commit": "c658278be744b3b6d1b964a826128f9f1f5662f7", "tree": "71f7dd393ebcf67518c03ff32f4209ba2110f4e5", "parents": [ "bfa8b1ea0f7edf84c4137d5a822cc8acaf90acda" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 15:06:18 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Jul 16 01:19:08 2019 +0000" }, "message": "ART: Introduce CompatThrow\n\nAdd an \"virtual\" instruction flag to signal a historical throw\nthat is not captured by kThrow. Both kinds of instructions need\nto capture the work line at the beginning of a verification step.\n\nLong-term, remove CompatThrow.\n\n\"Annotate\" return-object.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: I07e9f07da3ebcc9ccd1191ffc2c145b2c83a84f8\n" }, { "commit": "bc919af448aef9e8043e56ca83a2aa4ff90b9ad6", "tree": "904105c3bd20d6ee9af1fbfcda19f1eaa7ffc42d", "parents": [ "d78122b424c1be24f7e9ac7983af3f43e9d4e294" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 14:09:51 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jul 15 17:52:47 2019 +0000" }, "message": "ART: Disallow unresolved return types after Q\n\nFor apps targeting future releases, do not allow type mismatches\ninvolving unresolved types. The behavior complicates the verifier\nand the runtime and does not conform to regular expected behavior.\n\nHistorically this has been done for app compatibility when non-native\nmultidex was a thing. In that situation, even at runtime when an \"early\"\nclass is being verified a type might not be available because it is\nsupplied by a later injected dex file.\n\nClassloader manipulations in this way are no longer supported. Classes\nhave to be available at verification time to not fail the class.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: I9608c79183be7b85b76892498d6a7007a29f2434\n" }, { "commit": "d78122b424c1be24f7e9ac7983af3f43e9d4e294", "tree": "e3d89743ab77a860b45306530afbb519666aa68a", "parents": [ "d70a97c6d4a0954bed8991bd89a93bd3da9476f6" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 14:06:53 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jul 15 17:36:17 2019 +0000" }, "message": "ART: Do not access-check type on instanceof peephole\n\nWhen attempting the instanceof+branch peephole, do not retrieve\nthe cast type with an access check to avoid a posted failure. That\nfailure does not happen, it belongs with the instanceof.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: I87e2228bff9f3374e7141e600f24554846ecac32\n" }, { "commit": "0d87f99907f01ced713bf2dff97ee6655da077f3", "tree": "7e015521b706acdcedf5404f8e2f936e12b74cc4", "parents": [ "4146e064849cd566dfb5d9f851f95fb490ec0836" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 13:19:45 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jul 11 23:12:52 2019 +0000" }, "message": "ART: Remove VERIFY_ERROR_UNRESOLVED_CATCH\n\nReplace with a more generic SKIP_COMPILER, mark the Fail() calls as not\nthrowing, and replace the standard occurrence with NO_CLASS.\n\nBug: 121245951\nTest: m test-art-host\nTest: art/test/testrunner/testrunner.py -b --host -t 800 --jit-on-first-use\nChange-Id: I9f601702f27d815840538c04b332a52bf1c58c54\n" }, { "commit": "4146e064849cd566dfb5d9f851f95fb490ec0836", "tree": "fdf0e0cd034f93fb78b1ac59a656022eb8c76b76", "parents": [ "50037df21707c34beda776263536276fd9fbbe20" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 13:18:04 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jul 11 23:12:52 2019 +0000" }, "message": "ART: Prepare to remove VERIFY_ERROR_UNRESOLVED_CATCH\n\nAdd a parameter to Fail() that defines whether a runtime exception\nis expected at that point.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: Iff98ae24ef095df411804150d41c80493d42c09f\n" }, { "commit": "4a30f89d65efa9b85c34bbd7aa23ea4cd38b920d", "tree": "95ad8586ef841a3a5750c24a7780b58bf12cac3c", "parents": [ "7a82acc7ee79b198f7b4638a15cb1c3d1625ab6c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 04:57:58 2019 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 10 04:57:58 2019 +0000" }, "message": "Revert \"ART: Remove VERIFY_ERROR_UNRESOLVED_CATCH\"\n\nThis reverts commit 7a82acc7ee79b198f7b4638a15cb1c3d1625ab6c.\n\nReason for revert: NO_CLASS doesn\u0027t have the right semantics for the compiler\n\nBug: 121245951\nChange-Id: I8dbeb7fbd6a697fe536535f1c696187041d7fcab\nTest: m test-art-host\n" }, { "commit": "7a82acc7ee79b198f7b4638a15cb1c3d1625ab6c", "tree": "1b534443e584be4bcccddfa533d7d94305d37645", "parents": [ "11410de860d4e6bd6d3cc90aa604575430882302" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 01 13:54:21 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 08 14:52:45 2019 -0700" }, "message": "ART: Remove VERIFY_ERROR_UNRESOLVED_CATCH\n\nInstead add a parameter to Fail() that defines whether a runtime\nexception is expected at that point.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: Id9132eabc26b71a305ccb87f2182b4ae2e5b8c35\n" }, { "commit": "43884b23d61dd9c2754ef4e716458f8306b07b94", "tree": "5466067e89d3d3d81e069abb43b93118ca5a48bf", "parents": [ "f68b698e4774275e87bc73fa916faca4c6b11744" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 27 14:05:52 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Sat Jun 29 00:58:23 2019 +0000" }, "message": "ART: Coalesce verifier flags into bit struct\n\nMakes it easier to add flags without increasing size or changing\npadding.\n\nBug: 121245951\nTest: m test-art-host\nChange-Id: I26d0491fb7eb26e441874188a8db9f276ce1aaf8\n" }, { "commit": "1e52a07b4de0f000028e55c332aa46495f60879c", "tree": "1eb7dfdce749461c5a8997cbde49ed6d0fea2aa0", "parents": [ "e0ce8bf743b7fc5816bc4045716d75378ce3b654" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jun 25 09:12:04 2019 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jun 25 16:25:13 2019 +0000" }, "message": "Correct Indicies -\u003e Indices\n\nThis is a misspelling that is somewhat common in art/.\nFix up all the instances I could find.\n\nTest: ./test.py --host\nChange-Id: I0a5def6e4126cf4e61efb0619bd59eb45ba7f324\n" }, { "commit": "d91f84166ad642bbd135acb8aadd05919ff41d85", "tree": "3aeab5845897abbcab5827b2c27e684f6e157219", "parents": [ "90b3457f9c64efba370c51b216dabb164a40b1ff" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 13 10:11:14 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jun 17 15:21:00 2019 +0000" }, "message": "ART: Log approximate arena usage for slow verifier runs\n\nAdd ArenaStack::ApproximatePeakBytes and ScopedArenaAllocator::ApproximatePeakBytes\nto get an approximate use when arena tracking is not enabled.\n\nPrint the approximate use for slow verifications.\n\nBug: 110852609\nTest: m test-art-host\nTest: manual\nChange-Id: I529838410cdf4fe8247ddf4a6196a8186b0c4f3a\n" }, { "commit": "93adcb53c77f4f04dfebd30b94e8ea9936aa8abb", "tree": "bdf638b78c045eed106ace99fbdc64506712d8ea", "parents": [ "01f2e3a488fa06d98e2efbaf3ea8066d8457f216" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 06 20:16:07 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jun 07 23:05:24 2019 +0000" }, "message": "ART: Remove some compile-time info points\n\nRemove no longer needed compile-time info points in the verifier. Only\ncheck-casts are still reliant on support for elision.\n\nThis reduces the number of pre-populated register lines in a large\napp by 70%, and the number of instructions executed during verification\nby about 2%.\n\nBug: 110852609\nTest: m test-art-host\nChange-Id: Iefa8253749b1a2750f57360e08ddfb502d0478b1\n" }, { "commit": "0a7d0b10d2d2dd802f32c5df4026bafc12537625", "tree": "6746f6c13be8419e95ab959267a0b93dfadb1468", "parents": [ "6087bc210f5b246476045ca21568f446ad79222a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 04 10:42:29 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jun 06 20:43:26 2019 +0000" }, "message": "ART: Mark unreachable catch handler code in verifier\n\nArtificially block the method from being compiled as the compiler does not\ntrack unreachable code correctly.\n\nBug: 134061982\nBug: 134429168\nTest: art/test/testrunner/testrunner.py -b --host -t 800\nTest: art/test/testrunner/testrunner.py -b --host -t 800 --jit-on-first-use\nChange-Id: Iaa6abdd8b61e69a8feb74dcd8f47ded27fb4a353\n" }, { "commit": "6087bc210f5b246476045ca21568f446ad79222a", "tree": "f11b8e4ea6d6015290dceb52de126e39d2e4d76f", "parents": [ "9a45d01b40692d9b9568f5e80d21fc7f51bcac5c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 03 15:52:08 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jun 06 20:43:26 2019 +0000" }, "message": "ART: Handle unresolved catch handler types differently in the verifier\n\nThe move-exception should not trigger a synthetic throw, as that\nmay be caught by another catch handler, while the code is unreachable.\nUse a specific flag and failure instead.\n\nBug: 134061982\nTest: art/test/testrunner/testrunner.py -b --host -t 800\nChange-Id: Ie6859e3a1910171b34882889ebece6cadc9dd508\n" }, { "commit": "af52cbeb9b54cd3c3094cdb391041005e5796e77", "tree": "b8803696ddf0af29b5cecc6810bfdd3292b07c0c", "parents": [ "8e6bf106a5f6c26dfb7aa4fd0f8e9a4daabcbaee" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed May 22 15:05:09 2019 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri May 24 17:06:32 2019 +0000" }, "message": "Use TargetSdkLevel in CalculateVerificationInfo\n\nWe were using api_level\u003d0 (meaning most recent api) for calculating\nthe verification information of a single method dynamically. This\nmight in the future lead to problems if we condition more of\nverification on the API level. To prevent this future problem we will\ninstead use TargetSdkVersion as the API level.\n\nTest: ./test.py --host\n\nChange-Id: Ie87e0b1b6b07b43d2dc84101cb7764cc4087aca9\n" }, { "commit": "e2ddce3dec02cf7c9eb5efb2e29c250a5e909995", "tree": "df9ee07990149cceffe0496807c0e88f534211ec", "parents": [ "6045bc202f2c470b63c40a5a25db369b5a049c28" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed May 22 17:08:35 2019 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed May 22 17:29:29 2019 +0000" }, "message": "Revert^2 \"Add verifier fallback for JVMTI Get/SetLocalVariable\"\n\nThis reverts commit 99cbfb55fc7ac0f65b1ccdc7076219fcee383b92.\n\nThis unreverts commit e48fd0b4780efadc6b3433fe7a56aa5be2a84325.\n\nWe were incorrectly bounds-checking the register number. We were\ntreating it as unsigned when it was actual signed. Previously this\nwouldn\u0027t matter since normally the debug-info won\u0027t have any\ninformation for negative slots but by falling back to the verifier\nwe hit some check failures.\n\nReason for revert: Fixed underlying issue with bad bounds check.\nBug: 131711256\n\nChange-Id: I0b859ce322f3b23f937b72d735db8f6870c40602\n" }, { "commit": "99cbfb55fc7ac0f65b1ccdc7076219fcee383b92", "tree": "5420795d367de2d4fbf2f1a73ac2b3f275a5114a", "parents": [ "098e7a67588f39642567b91ecfab117dbaa84d31" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 22 11:39:45 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 22 12:23:46 2019 +0000" }, "message": "Revert \"Add verifier fallback for JVMTI Get/SetLocalVariable\"\n\nThis reverts commit e48fd0b4780efadc6b3433fe7a56aa5be2a84325.\n\nReason for revert: Fails libjdwp tests. In particular:\norg.apache.harmony.jpda.tests.jdwp.StackFrame_SetValuesTest\n\nBug: 131711256\nChange-Id: Id46da7c0d26769f8f4bd469cdfb8049f6812295a\n" }, { "commit": "e48fd0b4780efadc6b3433fe7a56aa5be2a84325", "tree": "5056001e02d8c4494b643c8d53fd32621e127c1c", "parents": [ "abdb4592fa28d6e75f1160f01cde58ad7c3fef37" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon May 20 10:04:44 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed May 22 00:29:38 2019 +0000" }, "message": "Add verifier fallback for JVMTI Get/SetLocalVariable\n\nThe JVMTI Get/SetLocalVariable functions used to rely entirely on the\nDex DebugInfo to determine the types of each of the registers. This\ncould lead to problems since, to prevent possible stack corruption, we\nwould not allow stack modification if the data was not present.\n\nIn order to remove this restriction we will instead make use of the\nmethod verifier to ensure the modification is sensible when the\nDebugInfo is not present. Since reconstructing this information using\nthe verifier is quite slow (compared to reading it from a table) we\nwill only do this when the table is missing.\n\nSince the verifier lacks some of the information available when\ncreating the DebugLocalInfo table some semantics will change depending\non if the table is present or not.\n\n - When the DebugLocalInfo table is not present we cannot always\n distinguish between floats, ints, and other single-register\n primitive types. For simplicity all single-register primitive\n types can be modified and read by both the Float and Int versions\n of the local variable functions.\n\n - Similarly we cannot always distinguish between long and double\n variables.\n\n - Reference types are checked against what the verifier thinks they\n need to be according to type unification. This might be more or\n less specific than the types recorded in the functions source code.\n\n - Constant int/float \u00270\u0027 values and \u0027null\u0027 cannot always be\n differentiated by the verifier. Therefore, one may not always be\n able to modify some null or constant 0 registers.\n\nTest: ./test.py --host\nBug: 131711256\n\nChange-Id: I1c9d857ccdec752bfd4ebad76cc9ad96e143866c\n" }, { "commit": "efdd1b0c818b9040b506c023d739e7ccd0714f47", "tree": "57842a878081a92be4e08a00ecfa1f6e25028b61", "parents": [ "d6d878ef7f452335e6642265605de10220f7809f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 07 12:30:10 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu May 09 15:08:17 2019 +0000" }, "message": "ART: Add throughput to verifier duration message\n\nAdd the throughput in bytecodes per second to the duration logging.\n\nBug: 110852609\nTest: m\nTest: manual (-Xverifier-logging-threshold\u003d0)\nChange-Id: I426aefd295e2a1ac190e66d0f12035e894f22080\n" }, { "commit": "b34981b0b7a16b084a4ab30ce509ee98bf171e63", "tree": "3f9b8aa799d7bd20ac1d40397026030746046599", "parents": [ "b9f1d3e5f109048de0055e9f19f1d5af13040e8f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 06 13:00:40 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed May 08 17:09:33 2019 +0000" }, "message": "ART: Fix hidden hard fail in instance field verification\n\nMove the reference type check for the given object upfront so that\nit isn\u0027t hidden by other soft-fail cases.\n\nBug: 122501785\nTest: m test-art-host\nTest: art/test/testrunner/testrunner.py -b --host -t 800\nChange-Id: I715a859665a9550bc23defa63ba6fbecd13d7531\n" }, { "commit": "bfcca58145d796fd05a68645b03229b0f3ce185e", "tree": "2456fb8180275a99eba9c45522543b9787991c9f", "parents": [ "99db7bb218e328f8a0a85f540f2c36aa66a23215" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 19 12:01:55 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 22 15:13:44 2019 -0700" }, "message": "ART: Add verifier-debug log for exception handler\n\nHelps tracking register state, in the case it is not a merge\nbut the initial setting of the target register line.\n\nBug: 130907607\nTest: m test-art-host\nChange-Id: Idebc230cd5a187b2ba986a25c536a8c2ca552d82\n" }, { "commit": "99db7bb218e328f8a0a85f540f2c36aa66a23215", "tree": "84143da3dc73a3f9edd2a5e8f2ba525614186396", "parents": [ "fc25ae90c7f2b93ce4cd7a920afaf893c17d08cb" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 19 23:05:47 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 22 15:13:41 2019 -0700" }, "message": "ART: Templatize internal method verifier class\n\nTemplatize over verifier-debug.\n\nBug: 130907607\nTest: mmma art\nTest: m test-art-host\nChange-Id: Iafde21602541aa3c878883cd793333ecc2121de9\n" }, { "commit": "fc25ae90c7f2b93ce4cd7a920afaf893c17d08cb", "tree": "0dbdd16fd1de3d2dfc26e49d27d98a18cfc306e8", "parents": [ "d09c0593fb9afc218dee39332e13097f1e95ee10" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 19 22:22:57 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 22 10:16:27 2019 -0700" }, "message": "ART: Refactor verifier\n\nMove implementation to internal class, only keep minimal interface\nthat other classes depend on public.\n\nAn internal impl::anonymous namespace and duplicate MethodVerifier\nname was chosen so as to minimize the patch.\n\nIn preparation for templatization.\n\nBug: 130904871\nTest: mmma art\nTest: m test-art-host\nChange-Id: I79de01139b8fbd8b4e828bb0e58faeb8666176d5\n" }, { "commit": "d09c0593fb9afc218dee39332e13097f1e95ee10", "tree": "472b61e72d6899b59b09b5c7faa30eefc42558f6", "parents": [ "51de69ecd20c1c9bad441359a07582d1bfa26905" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 19 15:44:05 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 22 10:15:57 2019 -0700" }, "message": "ART: Do not expose arena allocator from MethodVerifier\n\nBug: 130904871\nTest: mmma art\nTest: m test-art-host\nChange-Id: I807b713215fa948f2cbeab929abb0986ce573702\n" }, { "commit": "51de69ecd20c1c9bad441359a07582d1bfa26905", "tree": "b8431689598edd4daca2ebec6a53b306f0906b4c", "parents": [ "bb2467b398481a15ddb0b65cfcf3c15ff3cb0b8d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 19 15:14:14 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 22 10:15:48 2019 -0700" }, "message": "ART: Clean up MethodVerifier\n\nRemove unused methods. Move internal methods to be private.\n\nBug: 130904871\nTest: mmma art\nTest: m test-art-host\nChange-Id: I3b1a6a4495e3ddc4507881659d2c6d6d6049e8f6\n" }, { "commit": "7c887c57b1b32b9432c74582ab9a4be43a280ee9", "tree": "587e4f7ea18973c01dadbe79af9d46cb9c7b21ed", "parents": [ "a65859d5a1eacbba394f7f4f87a91b101445676d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 19 09:11:48 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Apr 19 20:49:52 2019 +0000" }, "message": "ART: Under verifier-debug, amend the hard-fail message\n\nWhen verifier-debug is enabled, include info messages and verifier\nstate dump in the hard-fail message, which will be included in\nthe VerifyError.\n\nBug: 124804473\nTest: m test-art-host\nTest: manual\nChange-Id: Ib34d7e1f620c120e64737cf7edfd1f99cf67b0f7\n" }, { "commit": "2ad6cceed5fd531c86e9da4ebdf2cb6c012382a0", "tree": "804103d4e5b34770168d4175cba9942efe6f2074", "parents": [ "b29ecc1a44f2741bd8287c659be1c0854d4f6365" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Apr 11 16:17:39 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 15 17:38:27 2019 +0000" }, "message": "ART: Make LogVerifyInfo newlines consistent\n\nUse an RAII helper to make logging to the verifier\u0027s info_messages_\nconsistent - no caller needs to add a final newline.\n\nTest: m\nTest: manual\nChange-Id: Ic830b816293078873160808fe275b862a672ff47\n" }, { "commit": "4a57d5f3c2bb4ce8290ca73f1130ff23b1b3ae5b", "tree": "4c21f0554a450e70107590cdb799d2d2fdd5a8c0", "parents": [ "527072e915c58b67005d5e687cf727bf89c7884a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Apr 03 12:31:18 2019 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Apr 03 12:31:18 2019 -0700" }, "message": "ART: Remove old cout usage in method_verifier\n\nLog to regular LOG.\n\nBug: 124804473\nTest: m test-art-host\nTest: manual\nChange-Id: I0ad352f9a20afa1dfd42f343fe1b247714279348\n" }, { "commit": "179b7c61ea6769b99f70c80a7a89cbb212423ec2", "tree": "06130898bfb2d8c3f71f4fe181277f20e1942726", "parents": [ "c8b7d445e02b752a68d824e2bc69658dfb76288a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 22 13:38:57 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 25 16:54:37 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify String allocations, fix stale refs.\n\nObjPtr\u003c\u003e-ify String allocation functions and related code\nand remove some unnecessary calls to ObjPtr\u003c\u003e::Ptr(). Fix\nstale reference uses in reference_table_test and stub_test.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I42927fb8b7240e5132188f73318b2ccb218748fd\n" }, { "commit": "a43ba3da86c046c545a988f3d40f53c24a525f83", "tree": "a66479561d9f14a9b19e31a9a6851f81ae50673c", "parents": [ "e37b7915908dba10e90c39a3a82cb0cd1dc05f5c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Mar 13 15:49:20 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Mar 15 16:11:36 2019 +0000" }, "message": "ART: Add ClassVerifier\n\nRemove class handling from MethodVerifier.\n\nTest: m test-art-host\nChange-Id: I0e125e0c8a852936ed7cff0f349a7fde97f62826\n" }, { "commit": "43e43251a011c05c21fe120ba791313b6ea53d5d", "tree": "29dc4d668d4887f807213fb5b5c69b2e9578a8a0", "parents": [ "b9b995738c8f53d68446d14553c1befd487877e7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jan 08 12:06:57 2019 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 09 12:03:16 2019 -0800" }, "message": "ART: Handle clobbering in verifier peephole\n\nBug: 121191566\nTest: art/test/testrunner/testrunner.py -b --host -t 800\nTest: m test-art-host\nChange-Id: I1c983fca5f92570f9dba4fb8ef3bcd3c7d3854f2\n" }, { "commit": "3f1dcd39e134d994ac88dcc4f30ec8cabcd8decf", "tree": "365d20ad6b68ff1dbd4903764b63880324136e4d", "parents": [ "0f0a4e40667c87fbd4ae5480eddbfd701bfabfa2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 28 09:39:56 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 02 10:32:25 2019 -0800" }, "message": "ART: Move dex structs into own header\n\nSeparating out the structs from DexFile allows them to be forward-\ndeclared, which reduces the need to include the dex_file header.\n\nBug: 119869270\nTest: m\nChange-Id: I32dde5a632884bca7435cd584b4a81883de2e7b4\n" }, { "commit": "2bb2fbd2879d0a6d9ebf7acff817079dde89b417", "tree": "d607aa6bfb2ea55fbfd875237b37c79f3cfed5f6", "parents": [ "85865697ff9fabede3d64ff64cde72727c3fc4c1" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Nov 13 18:24:26 2018 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Fri Nov 16 11:11:20 2018 +0000" }, "message": "Create SdkVersion enum, migrate users to it\n\nCreates a new SdkVersion enum with integer codes of known\nAndroid SDK versions, together with helper functions for common\npredicates. Also converts target_sdk_version_ in Runtime to\nuint32_t and cleans up its uses.\n\nTest: m test-art\nChange-Id: Idc6e518c8675068bf952d0256686c88bb0eb833e\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "dc39d32cc0c72af00b58c58077fb2cad6774df03", "tree": "ae3cce77bb8540717273fca4aad880e6b5a238bc", "parents": [ "ff71e663a08b4218fc9d08f8e65ad7da84a4ab99" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 04 09:26:03 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 04 09:31:03 2018 -0700" }, "message": "Revert^2: \"ART: Restrict some checks in the verifier to P+\"\n\nReinstate old behavior for apps targeting earlier releases.\n\nThis reverts commit 5ff2596da427351308992a1677348e460a398591.\n\nBug: 111969862\nBug: 113863780\nTest: m test-art-host\nTest: cts-tradefed run commandAndExit cts --m vm-tests-tf\nChange-Id: I4fd967271cf43e21af34739a08907a1a7953539a\n" }, { "commit": "ff71e663a08b4218fc9d08f8e65ad7da84a4ab99", "tree": "eac052f9eb2a23f395338bf08d6e526a45375b89", "parents": [ "77bb25b037d120ecbf5e7bbd90be6375b9e61957" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 04 09:25:12 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 04 09:27:43 2018 -0700" }, "message": "Revert \"ART: Restrict some checks in the verifier to P+\"\n\nThis reverts commit 2337d53846d9d2e7f82f8cf64ff25585ad010339.\n\nChangeset is incomplete and triggers debug errors.\n\nBug: 111969862\nTest: n/a\nChange-Id: I74b5feb054403696433be24147b5484f2c3d27e9\n" }, { "commit": "2337d53846d9d2e7f82f8cf64ff25585ad010339", "tree": "713afb905bc3da0d96bf4e2962b582474147ee17", "parents": [ "6cc23acba91d26d7afd6bc681004ac5865a8a163" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Aug 24 18:58:25 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Aug 24 18:58:25 2018 -0700" }, "message": "ART: Restrict some checks in the verifier to P+\n\nReinstate old behavior for apps targeting earlier releases.\n\nBug: 111969862\nTest: m test-art-host\nTest: cts-tradefed run commandAndExit cts --m vm-tests-tf\nChange-Id: I207718d65f906817d20d5b32b53011530b616fab\n" }, { "commit": "6cc23acba91d26d7afd6bc681004ac5865a8a163", "tree": "d5b6850d7ce511658a33ca417764eac92cafe2d1", "parents": [ "e9dce6a280057315a8a58ed46190c9a893c90fba" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Aug 24 15:22:43 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Aug 24 15:22:43 2018 -0700" }, "message": "ART: Add API level to verifier\n\nPass API level to verifier. In preparation for API-level dependent\nchecks.\n\nBug: 111969862\nTest: m test-art-host\nChange-Id: I700ef52e28436a7fda8b9d9ef29841110ed6d3bb\n" }, { "commit": "0b0ffc1429fde6fbf9bac20b8582e71ff1569451", "tree": "8da642e25c1e0dce946290389a9860092da184d1", "parents": [ "72fb8639a61e100dcc39645c35a5c3e394ab0eba" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 01 14:41:27 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 01 14:58:21 2018 -0700" }, "message": "ART: Add parameter for verifier timing log threshold\n\nMake the old 100ms timing threshold configurable.\n\nBug: 111857793\nTest: m test-art-host\nTest: manual\nChange-Id: I6c3d0c05acbe9d35d71999522077d5768c4e6c20\n" }, { "commit": "b07dcdba37e9a5652b7754a6bd9c3538880d6668", "tree": "15524fb0505323ec78bf4d8841245da6fe61d6ee", "parents": [ "6250dfa22577160b270f3f3165260739707cf7d3", "c945e0d410ca8d4e9ba09272e8727a3192f1e449" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 20 13:06:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jul 20 13:06:30 2018 +0000" }, "message": "Merge changes I87f2999f,I8af0e845\n\n* changes:\n Remove ArtMethod\u0027s declaring class state checks.\n ObjPtr\u003c\u003e-ify ArtMethod and mirror::Method.\n" }, { "commit": "d93e374e273dd45f5d829399da1d4201bf46057e", "tree": "280dc72b2aec4696bbc35ad39ca8d3479107380e", "parents": [ "7f7f9d3991f3a55da8934a3b72890d4776373598" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jul 18 10:58:13 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 19 16:04:38 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify ArtMethod and mirror::Method.\n\nAnd clean up some forgotten things after old CLs.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I8af0e845c24d674d0efab21d80c29949b1cc0593\n" }, { "commit": "ce75049c31e7064b00104ca7f65fe12faeabc391", "tree": "6f7bb5977a99db0d89c74238576956f0aa1d4dad", "parents": [ "0495fb053094181de232e3fa390806a9110ba208" ], "author": { "name": "Alexey Grebenkin", "email": "a.grebenkin@samsung.com", "time": "Thu May 31 23:42:20 2018 +0300" }, "committer": { "name": "Alexey Grebenkin", "email": "a.grebenkin@samsung.com", "time": "Fri Jul 13 17:07:25 2018 +0300" }, "message": "Revert \"Revert \"Handle a special case of lock aliasing during lock verification\"\"\n\nThis reverts commit 753a055b5398fcf00d2633565452679c8fb93e9d.\n\nReason for revert: Fixed failing tests\n\nTest: m test-art-host\n\nChange-Id: I4a8be656288199108c05c9d302393e1efa41a7a4\n" }, { "commit": "97c465ca6ee4c76766f8abaa3a98ee0329019c5c", "tree": "ea4236d021cfa3df45e27efe1556732a06c6737b", "parents": [ "91b6befbb0a323ccbdce5f0631e260346e04f045", "753a055b5398fcf00d2633565452679c8fb93e9d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 05 20:05:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jul 05 20:05:48 2018 +0000" }, "message": "Merge \"Revert \"Handle a special case of lock aliasing during lock verification\"\"" }, { "commit": "753a055b5398fcf00d2633565452679c8fb93e9d", "tree": "e334f68df51c6078fd51f293a38146c6fcb6c106", "parents": [ "82898ed01eedfb82a5b4adfe1327b827210af3ca" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 05 20:05:20 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 05 20:05:20 2018 +0000" }, "message": "Revert \"Handle a special case of lock aliasing during lock verification\"\n\nFails run-test with --tracing or --debuggable.\n\nThis reverts commit 82898ed01eedfb82a5b4adfe1327b827210af3ca.\n\nChange-Id: I8005a1fbe63c6508d9abd5bea77679201c71ab46\n" }, { "commit": "91b6befbb0a323ccbdce5f0631e260346e04f045", "tree": "ceb3c5608472a396f4f090c315c5cf16386fabd1", "parents": [ "4a72f8b1baec1fb93105e381edb1bad60e372540", "82898ed01eedfb82a5b4adfe1327b827210af3ca" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jul 05 16:32:16 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jul 05 16:32:16 2018 +0000" }, "message": "Merge \"Handle a special case of lock aliasing during lock verification\"" }, { "commit": "82898ed01eedfb82a5b4adfe1327b827210af3ca", "tree": "c801d41b2491271324a06343efc8618d5ea063a2", "parents": [ "dc53f1616d656a757fb26039f387b7ee44ff2f1d" ], "author": { "name": "Alexey Grebenkin", "email": "a.grebenkin@samsung.com", "time": "Thu May 31 23:42:20 2018 +0300" }, "committer": { "name": "Alexey Grebenkin", "email": "a.grebenkin@samsung.com", "time": "Thu Jul 05 12:41:54 2018 +0300" }, "message": "Handle a special case of lock aliasing during lock verification\n\nCheck whether the two instructions immediately before a monitor-enter\nare const-class, establishing previously untracked lock aliasing\nin a low-overhead manner.\n\nTest: m test-art-host\nChange-Id: I94c187cbc422f8f0c13b688b09a5d9579a735b56\n" }, { "commit": "e383d23918db4eede30c3d78589d4639de3ec446", "tree": "a103f54ec49fac8d5cd15661f5c2d0cb5dab32e5", "parents": [ "dbf540399a2aaddad00b1233b80808c80dc0d443" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 19 12:29:51 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 19 17:09:45 2018 -0700" }, "message": "ART: Mask garbage-memory warnings\n\nAdd invariants or NOLINT to let clang-analyzer understand that\nthere\u0027s no garbage involved.\n\n(The analysis itself is too expensive to force it on for all\n local builds.)\n\nTest: mmma art\nChange-Id: I6148d743321248195abb3a8f646e63941f11f9a9\n" }, { "commit": "4c8e12e66968929b36fac6a2237ca4b04160161e", "tree": "d8bbfd72a978c69ef2eef98c37e7869673c52295", "parents": [ "20c64f8d802cc575cc9a1a1f6c493a611b23e2ee" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri May 18 08:33:20 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jun 11 10:57:17 2018 +0100" }, "message": "ART: Adds an entrypoint for invoke-custom\n\nAdd support for the compiler to call into the runtime for\ninvoke-custom bytecodes.\n\nBug: 35337872\nTest: art/test.py --host -r -t 952\nTest: art/test.py --target --64 -r -t 952\nTest: art/test.py --target --32 -r -t 952\nChange-Id: I821432e7e5248c91b8e1d36c3112974c34171803\n" }, { "commit": "18e2687c4126d66870d61d6548abc2c7661a66cc", "tree": "06eff605df9259dde8170c8efb48b11df4108eb3", "parents": [ "2607d6c47114a18ccf4a532b20e1099d1dd8fcca" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 04 17:19:02 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jun 07 22:13:48 2018 -0700" }, "message": "Refactor ClassAccessor to use an index instead of ClassDef pointer\n\nRemoves a separate class_def_idx being required for getting the index\nof a ClassAccessor foreach loop.\n\nBug: 79758018\nTest: test-art-host-gtest\n\nChange-Id: Ie3010a17669f24cf492c678b55bdddba7ec62ea8\n" }, { "commit": "1f1cb9f2f0945dbcf6b79d0795b035233dfd9131", "tree": "fc5f72ef884e0eaa92f515a90cfd997b0938208a", "parents": [ "9ddef18ae95859a985e7a0de7e22999fcbc28e07" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 04 09:22:46 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 04 20:41:12 2018 +0000" }, "message": "Revert \"Revert \"Move runtime/ to ClassAccessor\"\"\n\nFixed misplaced UnhideAccessFlags to be outside of a conditional\nthat the code item is null / not deduped. This fixes an issue\nwhere these methods would not have had their access flags restored.\n\nBug: 77709234\nBug: 79758018\nBug: 91962648\n\nThis reverts commit cc7e20f9ec7b4a7a57f7196e5e8be67a727f21d3.\n\nTest: test-art-host\nTest: atest FrameworksUiServicesTests\nTest: atest CtsInlineMockingTestCases\n\nChange-Id: I7e5712cdcccef81e19ce81d26743c517b0b8a67d\n" }, { "commit": "bcf175247272d0e321c8d988c3c01c123b56e36e", "tree": "9f65ece5ce9474aa4fcf16fbfca6278109dc9a67", "parents": [ "09c5ca40635faee00f40f6ca0581dd475efd545e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 01 13:14:32 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 01 16:31:30 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify array allocations.\n\nAnd remove some unnecessary calls to ObjPtr\u003c\u003e::Ptr().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ie313980f7f23b33b0ccea4fa8d5131d643c59080\n" }, { "commit": "a8bba7d0853b372aea3ed3ea154fb2b2a23c2c9d", "tree": "973a89870e0cc8912401503ebab1b709a9df5ba0", "parents": [ "65e463cf7ea91003ef030c8a819ae4596c9b820f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 15:18:48 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 09:48:59 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify ClassLinker::FindClass(), fix 1 stale reference use.\n\nThread::CreateAnnotatedStackTrace() was using a stale\nreference `aste_array_class`.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I191907c0053456bb57de425aa6ccd9668df818a2\n" }, { "commit": "2cffc5d2807096c0b7a07b89f5dda6920c6429f5", "tree": "3949ab54fa34ba6297aa0074daeba43f560ca9bc", "parents": [ "adbceb73b19cfad3ff9011390415a680382a21ec" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 15:40:56 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 12:50:32 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify RegTypeCache, fix 1 stale reference use.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: If8674fc712d9bc4d7d2fef1d154192b31b153627\n" }, { "commit": "adbceb73b19cfad3ff9011390415a680382a21ec", "tree": "b7d4c12fb8cc8d4f9091d48d8e2c35a06b7a8e26", "parents": [ "aab8bc928a8eff425d5e5755fde75b1cb55998a9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 14:34:14 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 17:48:45 2018 +0100" }, "message": "Remove GcRoot\u003c\u003e static from Throwable and related classes.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I8115e6413a07419ec261af3ec5068833b72b5218\n" }, { "commit": "c7aa87e1666ac48ddf9149cfdfd64b026b3969e5", "tree": "32d5d74718cc558e13642873e55724782ac9df22", "parents": [ "0278be74269fcfe4f2517d449f2bd53472f9b2f9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 24 15:19:52 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 25 11:37:45 2018 +0100" }, "message": "Remove static_class_ from Method/VarHandle and CallSite.\n\nAnd add MethodHandle to the class roots to avoid extra\nindirection through MethodHandleImpl.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Iaf172f3732677f2b4509e8297e6e9af5fb81a89f\n" }, { "commit": "537a4fed85530ac29fe5ff173c4b77538d8bbd0b", "tree": "dc7a7e699145082827e17034a66260a10d1b9609", "parents": [ "00e15d651e705640d4fdf206faf8317d69b20758" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue May 15 13:57:58 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue May 15 16:35:59 2018 +0100" }, "message": "ART: Add VarHandle accessors to invoke-polymorphic entrypoint\n\nRemoves the need to interpret methods containing VarHandle accessor\nmethods. Whilst there are VarHandle accessors that the compiler does\nnot support, this will be the fallback path.\n\nBug: 71781600\nTest: art/test.py --host -r -t 712\nChange-Id: I40314b773882faed554c31b7f34c0e319dcf8d45\n" }, { "commit": "06d10a78506fae7e033795cda7b1d9d0e1f1fff5", "tree": "91f94a605395776710f3d14298613a803158f3aa", "parents": [ "93d301397c83b08f6fc165847a3d518e1031f392" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon May 14 08:53:38 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon May 14 16:49:55 2018 +0100" }, "message": "ART: Add dex::ProtoIndex\n\nTest: m -j32 test-art-host\nChange-Id: Ic2d2a7a43be1b8590b97cdf3729200b043ffc6a3\n" }, { "commit": "dbaa5c7ba8935cf87ceb40a4054f9842929e9a51", "tree": "5037625c80cb97a0e13026dc450db28e59ff72ca", "parents": [ "51dda39549033b3c50a7fce5522ffc81325db54b" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu May 10 08:22:46 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri May 11 11:55:30 2018 +0100" }, "message": "ART: Compiler support for const-method-handle\n\nImplemented as a runtime call.\n\nBug: 66890674\nTest: art/test.py --target -r -t 979\nTest: art/test.py --target --64 -r -t 979\nTest: art/test.py --host -r -t 979\nChange-Id: I67f461c819a7d528d7455afda8b4a59e9aed381c\n" }, { "commit": "18259d7fb7164a5e029df4f883b3a79ccc2403e8", "tree": "ba378bfdef4127bb0607215186e3b150fd38bcdf", "parents": [ "922501b4bbf724e4259477a27764291684eedffb" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Apr 12 11:18:23 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu May 10 15:04:09 2018 +0100" }, "message": "ART: Compiler support for const-method-type\n\nImplemented as a runtime call.\n\nBug: 66890674\nTest: art/test.py --target -r -t 979\nTest: art/test.py --target --64 -r -t 979\nTest: art/test.py --host -r -t 979\nChange-Id: I4b3d3969d455d0198cfe122eea8abd54e0ea20ee\n" }, { "commit": "4525e0b62cc808a49b4cd2c826bb52a768779e72", "tree": "aba9be998bb3684dff53b4b56c0568fb7187502e", "parents": [ "a8503d9696f37ff66b23016f3374ecbe59774dc6" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Apr 05 16:57:32 2018 +0100" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue May 08 10:30:45 2018 +0100" }, "message": "Fix verifier/linker IncompatibleClassChangeError with hidden API\n\nThe verifier and class linker will attempt to find a method with\nthe wrong type if it could not be found with the original type,\ni.e an interface method on a regular class and vice versa.\n\nThis logic did not previously take hidden API restrictions into\naccount and would result in bogus error messages to the user or\ndebug crashes.\n\nBug: 64382372\nBug: 77464273\nTest: art/test.py -r -t 674-hiddenapi\nMerged-In: If8327a70dd73b90249da3d9e505f0c6f89838f8e\nChange-Id: If8327a70dd73b90249da3d9e505f0c6f89838f8e\n(cherry picked from commit 54a99cfcf3d3463404fdf4152523dcc69b8648d7)\n" }, { "commit": "9c4a015cf01989597fd899011dba310b704dacaa", "tree": "17101dd177beb28c1d28c8eddab645bc7d1af984", "parents": [ "6485701497edf2fd4e5296c3715929ad44ea9752" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 05 12:23:54 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Apr 09 23:30:08 2018 +0000" }, "message": "Move more runtime code to libartbase, libdexfile\n\nMove some code that logically belongs to libartbase or libdexfile to\nthose places respectively.\n\nBug: 22322814\nTest: make -j 50 checkbuild\nChange-Id: Idfded5d24b40d8587011681e6235b6672846da19\n" }, { "commit": "69b1cf13e56a0f192fc40fa38382f072683e063c", "tree": "8e652f74729f0cdb166cf4d3ed0fdf799407e2a2", "parents": [ "ba1e9e73c07bffc046f651414db43aeee9953d15" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Mar 21 10:44:58 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Mar 22 13:14:15 2018 +0000" }, "message": "Don\u0027t HARD_FAIL when not able to resolve a quickened opcode.\n\nWe were failing to report locks being held due to this.\n\nThis means we can also share the code between the non-quickened\nand quickened instructions.\n\nbug: 74521989\nTest: 679-locks\n\nChange-Id: Ib87441b80f6ab7706c138600740b8bc7e448f1da\n" }, { "commit": "b041a406daf5213ac1d5c9bcdc197d34cba85bf3", "tree": "f32c9f97143d2df79940e070f2862cc7a5f6e807", "parents": [ "51038fc5f8be887ff86fe062e6a5af840e37726d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 13 15:16:22 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 19 09:25:09 2018 +0000" }, "message": "Use vdex\u0027s quickening info when decoding a quickened instruction.\n\nbug: 74521989\n\nTest: test.py, 678-quickening\nChange-Id: I3a85cc6014afcf11889941dcd15b90d4296b8408\n" }, { "commit": "c2a2bdab0e34a130c54a0fdcd77b6bf6fa5bf6df", "tree": "dec215b35af5cb3cc1f769d6d51cae9f4043f09f", "parents": [ "68f0680e83179cfe0127fda54a8e02a8552bf619" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Mar 12 11:21:52 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Mar 12 11:38:46 2018 -0700" }, "message": "Add more details to verifier dumping for gAborting\n\nPrint the method we are verifying.\n\nBug: 74521989\nTest: test-art-host\nChange-Id: I5a92d5ff56cb7319bc19c47acc3d66e363da0c66\n" }, { "commit": "a5dca524abcbf55c3cfa778e3b72aa1efd1e9813", "tree": "77f128dd2fcab181b6a81831ec350fc2d3cc1e62", "parents": [ "d395e73e9ed7c3fb5e8a48c3f3141a8997d4a82b" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Feb 27 12:42:11 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Mar 08 16:55:17 2018 +0000" }, "message": "ART: Update invoke-custom implementation\n\nAdds type checking for bootstrap arguments and support for variable\narity bootstrap arguments.\n\nAdds tests for malformed bootstrap arguments, variable arity bootstrap\narguments, and invocation arguments to passed to the CallSite\u0027s\nMethodHandle.\n\nRemoves unnecessary wrapping when j.l.Error\u0027s are raised during BSM\ninvocation.\n\nRemoves BSM argument type checking from verifier. This is now\nperformed during invocation.\n\nBug: 73927525\nTest: art/test/run-test --host 952-invoke-custom\nChange-Id: Id43226edad64ad9812e4ba1a069dfb70b8196dad\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "67bf42e89592c3a1c648f927f2ce3ccb189a1161", "tree": "054d5b7adf7cc62d4d2a2118a70c0fbdd1751610", "parents": [ "d961043ff1dd6fddb68aa90c1f939cfafec24219" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 26 16:43:04 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 28 15:08:21 2018 -0800" }, "message": "Header library to remove dependence on runtime/\n\nAdd a new header library to remove libdexfile and others\u0027 dependence on\nruntime (typically runtime/base) includes in libdexfile. Also a small step\nto tease dexlayout and profman away from relying on these as well.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n\nChange-Id: I38e2fe399a75f4bc6318c77a71954c00ea73ec2b\n" }, { "commit": "b2ec9f5c128673c43f776cbe12c8eeb0a6884ebb", "tree": "724022162a4f3de021cebab32ee5ac67ec860f32", "parents": [ "f13343eb8b2738e2812fd7bd9d5592f529e93c21" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:20:31 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:51:15 2018 -0800" }, "message": "Remove duplication, split tests\n\nThe code move to libdexfile/dex/descriptors_names.cc apparently did not\nremove the original code from runtime/utils.cc. Fix that duplication\nand all the header mentions needed. Also, split the test files to go\nalong with the new locations for the code to be tested.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n flash \u0026 boot marlin\n\nChange-Id: Ie734672c4bca2c647d8016291f910b5608674545\n" }, { "commit": "ea179f477465789605e0c8f57a3ec660c3d852e8", "tree": "bde254b238c9ed42a5c0ae3ff14ffacadeeddb34", "parents": [ "d991e5119a2bb61542899da9708f794dc60677c4" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 08 22:30:18 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 15 15:47:02 2018 +0000" }, "message": "Refactor method resolution in class linker.\n\nRewrite all runtime callers of DexCache::SetResolvedMethod\nto call a shared method that will do the dex cache update.\n\nbug: 64759619\nTest: test-art-host\nTest: device boots, runs\n\nChange-Id: Icc1aca121030e2864de09667bdbc793b502e3802\n" }, { "commit": "928033d81f63912f669acd27a72897694eb31db6", "tree": "4fa9d3e320f1fbb8f39d4128037f6a4b02c69fd7", "parents": [ "426ee26b3dcc2c6ff0e16096c57f62b98b91b71e" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Feb 07 05:30:54 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Feb 09 13:09:26 2018 +0000" }, "message": "Revert^2 \"ART: Interpreter support for VarHandle accessors\"\n\nThis reverts commit c4d3bf4eaff9720ed0bb7775db6fc24a1bd755dd.\n\nBug: 65872996\nTest: art/test/testrunner.py -b --host\nChange-Id: I2d1017c45cee5b2fd2dd05e5eeff0a72146663b1\n" }, { "commit": "c4d3bf4eaff9720ed0bb7775db6fc24a1bd755dd", "tree": "f84ebefc503e5cffb6df5989979492ae04f85cbb", "parents": [ "becc83b59ff703c02198f832dbc3216a0ab8a022" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Feb 06 16:02:49 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Feb 06 16:02:49 2018 +0000" }, "message": "Revert \"ART: Interpreter support for VarHandle accessors\"\n\nThis reverts commit becc83b59ff703c02198f832dbc3216a0ab8a022.\n\nReason for revert: breaks on the ART buildbots due to localized toolchain differences.\n\nChange-Id: Ieb1d93b0fc7116ddc542d8bbfee1975bcb30a8f7\n" }, { "commit": "becc83b59ff703c02198f832dbc3216a0ab8a022", "tree": "38a3061481f01e2dcdc955bd9e9ddb60e0fd5a6f", "parents": [ "1e5b3f39ff1776fd8b7d8d7d372347a08d98781b" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Dec 08 11:36:19 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Feb 06 12:51:42 2018 +0000" }, "message": "ART: Interpreter support for VarHandle accessors\n\nAdd support for invoking VarHandle accessors in the interpreter and\nforces code with VarHandles accessor invocations to use the interpreter.\n\nBug: 65872996\nTest: art/test/run-test --host 712\nChange-Id: I9ee3ad6aef6a3bc73d90cec0a8e023e5db42b7a2\n" }, { "commit": "077d9dbdf7c0965cb6ad9fb8c103bfcc03df738a", "tree": "e4ecd63348312b3d1b8c2eda5267c5ab17ed23f9", "parents": [ "ba94510917814f9e79233bc6de192e87078c6941" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jan 19 18:54:14 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jan 19 18:54:14 2018 -0800" }, "message": "ART: Fix verifier dumping\n\nIf the verifier stops early, the register line table won\u0027t have\nbeen initialized. This can lead to an out-of-bounds access when\ndumping the state.\n\nBug: 72237763\nTest: m test-art-host\nChange-Id: I179909f343e74ada8a65f060bbd4d97e9b0107ee\n" }, { "commit": "698ebbca3c54d17c696e87b9e5838df6a5ac9b08", "tree": "7887b2cd4662410114f205bbe1896ff094d51407", "parents": [ "4b9a11f1d43df69c50e93ba1793fce1c2216682b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 05 11:00:42 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jan 08 09:11:49 2018 -0800" }, "message": "Clean up CodeItemAccessors and Compact/StandardDexFile\n\nChange constructor to use a reference to a dex file.\n\nRemove duplicated logic for GetCodeItemSize.\n\nBug: 63756964\nTest: test-art-host\nChange-Id: I69af8b93abdf6bdfa4454e16db8f4e75883bca46\n" }, { "commit": "118c59cf6af50e128d29609c9046a4af15826976", "tree": "c0f82859babac12e3e000964a328ddc2498b74bb", "parents": [ "71a7b36894114d02860d2e64b9396dbd5e0b9b38", "fe92d1227f74a383172c0f339884c69e151fb404" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jan 08 08:11:23 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jan 08 08:11:23 2018 +0000" }, "message": "Merge \"ART: Verifier support for VarHandles\"" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "fe92d1227f74a383172c0f339884c69e151fb404", "tree": "c8cb4777ef1335e2ef1da22ca239524b6aa33214", "parents": [ "4131d1096ac57a29ba1939c1cf2cb74144c16c92" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jan 02 10:45:17 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Jan 05 10:38:26 2018 +0000" }, "message": "ART: Verifier support for VarHandles\n\nExtends checking of signature polymorphic methods to support VarHandle\naccessor methods.\n\nBug: 65872996\nTest: run-test --host 954\nChange-Id: I696bfdfbf1cd99f7cd6720cda5911dd4f5e66ada\n" }, { "commit": "f6e31474096a3c25b2d0c872fc120d7479b62367", "tree": "72d8cee843375af8b8c8c7919ae930c9e5df2bfd", "parents": [ "ce4982554648998abd0980bd06e738f4bcaa35d9" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Dec 28 13:32:08 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 02 11:41:47 2018 -0800" }, "message": "Fix default method verifier check for compact dex\n\nAdd a feature flag and mark if the compact dex file was\ngenerated from a dex file that supported default methods or not. This\nis done to maintain the existing verifier behavior differences for\ndex files that do and don\u0027t support default methods.\n\nFixed callers to use a virtual function instead of always checking\nthe dex file version.\n\nRe-enabled run-test 975.\n\nBug: 70930171\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I46ac5d3cde0d0c9f41cbc68cccaf954b531e0edf\n" }, { "commit": "dc578c7e47b2db623b382932bfe4dbc6dce41aa4", "tree": "409e6dc0c338bf75c1ce55acfae91fe86ef3028e", "parents": [ "1d32a16f93d8bb479523fd237277ecbbff5bf1f4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 27 11:51:45 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 27 13:24:11 2017 -0800" }, "message": "Move dex exception helpers to their own file and use dex accessor\n\nAlso change the input argument to be a code item accessor\ninstead of a code item pointer. This removes the dependency on\nthe code item layout.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: If75a168d0b5a77d08fa3c6ba38d00705158911db\n" }, { "commit": "808c7a57bb913b13c22884f57cdacd59bf1fdb3f", "tree": "d7f0d7cabaac5a7646c25bae584a82a9aa279cc0", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 15 11:19:33 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 22 09:41:17 2017 -0800" }, "message": "Make CodeItem fields private\n\nMake code item fields private and use accessors. Added a hand full of\nfriend classes to reduce the size of the change.\n\nChanged default to be nullable and removed CreateNullable.\nCreateNullable was a bad API since it defaulted to the unsafe, may\nadd a CreateNonNullable if it\u0027s important for performance.\n\nMotivation:\nHave a different layout for code items in cdex.\n\nBug: 63756964\nTest: test-art-host-gtest\nTest: test/testrunner/testrunner.py --host\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nChange-Id: I42bc7435e20358682075cb6de52713b595f95bf9\n" }, { "commit": "666ee3d7c6039c80e75287e311895bd6a9b01e9f", "tree": "5e65f39ff7cc83af4be3b691c247d7348052f854", "parents": [ "890111968fbd3f5ae528d97e42984c12a3dd27bd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 18:37:36 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 12 13:48:02 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveType().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nAlso refactor the code to avoid doing the DexCache lookup\ntwice and avoid unnecessary read barriers in the initial\nDexCache lookup (also for Lookup/ResolveField()).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Idea9aa42b6a5bade947e93e330b1abdb9d11b2da\n" }, { "commit": "890111968fbd3f5ae528d97e42984c12a3dd27bd", "tree": "edb4ed38332a817b7d3037ea260856cec839dca9", "parents": [ "0f13269734be07b5869005952a3cb91b0b34b73d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 13:45:05 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 15:43:45 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveMethod().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I2e47280e7cb8b84595130c4abfb5ece18d7f5c75\n" }, { "commit": "0f13269734be07b5869005952a3cb91b0b34b73d", "tree": "026115080385984050674455e54721f00cb5df10", "parents": [ "768bd97cede0a6de738936aad738f8bb0099322e", "a64b52deb0c792b8a0d47546edb8a2f8a7816c33" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 14:24:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Dec 11 14:24:43 2017 +0000" }, "message": "Merge changes I8c4cec43,I00634b89,I0579db64\n\n* changes:\n Do not pass DexFile to ClassLinker::Lookup/ResolveString().\n Do not pass DexFile to ClassLinker::ResolveMethodType().\n Do not pass DexFile to ClassLinker::ResolveField*().\n" }, { "commit": "c654816053ae07fb1f129d705e94b76e59f37454", "tree": "867d678ab3f6e0f4af70da98e935aafae0c6126c", "parents": [ "8f1a586fd4ac9796e75b2b18638e39b33ad6e9a2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:15:22 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:22:21 2017 -0800" }, "message": "ART: Change SCOPED_TRACE implementation\n\nMove to a LOG-like usage pattern. This improves usability in the\npresence of lock annotations.\n\nDemonstrate in the JIT compiler, where a lambda would require\na REQUIRES_SHARED annotation.\n\nTest: m\nTest: manual\nChange-Id: I9da2bfb29ed11660dbeb6f114a3d6c7ffef3a26d\n" }, { "commit": "8f1a586fd4ac9796e75b2b18638e39b33ad6e9a2", "tree": "f1970c938487dbd9e773619804612ac824b0721c", "parents": [ "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5", "170331f0e44a0e07fcfe0b5932517e0500f5cd1f" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Dec 08 19:28:07 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 19:28:07 2017 +0000" }, "message": "Merge changes I917df597,Ib2ca880e,Ib3733573,I3e3a4672\n\n* changes:\n ART: Remove base/logging from heap-inl.h\n ART: Factor out gAborting\n ART: Move runtime-debug flags to own files\n ART: Replace base/logging with android-base/logging\n" }, { "commit": "e11dd50ac2b5ccbf3b02213b7361f55b1f1a90da", "tree": "ea958df5f757369119cc84968f3b77210faf593f", "parents": [ "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 14:09:45 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:54:25 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::ResolveField*().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I0579db64c63afea789c7c9ad8db81e37c9248e97\n" }, { "commit": "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5", "tree": "5362f0306de9dfd47576b0988dc8b660ece0898b", "parents": [ "f56a1c0abde24065f02705004cdc245f850e064a", "208f67072283be64da231b51f9c195aff403dceb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:26:53 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 17:26:53 2017 +0000" }, "message": "Merge \"Change ArtField::ProxyFindSystemClass() to lookup the class.\"" }, { "commit": "f56a1c0abde24065f02705004cdc245f850e064a", "tree": "6b5debfcb663f76e6a5bcb3949eec1bce891989e", "parents": [ "f23779bc210ecbf448e61d7b18088b6afb46a476", "28e012a4af2d710e5e5f824709ffd6432e4f549f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:26:18 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 17:26:18 2017 +0000" }, "message": "Merge \"Determine HLoadClass/String load kind early.\"" }, { "commit": "208f67072283be64da231b51f9c195aff403dceb", "tree": "97748c71e6c16ae110ccdbb13f50a78e5a21cd33", "parents": [ "4388fb213ec746ee18a6bea38ee894f8c19990b9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 12:00:50 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 16:50:21 2017 +0000" }, "message": "Change ArtField::ProxyFindSystemClass() to lookup the class.\n\nAs the function is called from ArtField::LookupType(),\nwe should avoid calls that appear to allow type resolution\nrather than plain lookup. The lookup should always succeed.\n\nAlso rename ArtField::LookupType() to LookupResolvedType()\nto align with naming used in ClassLinker and ArtMethod.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I0a87347b5341575e47e0fdba6d58ade2543387c8\n" }, { "commit": "28e012a4af2d710e5e5f824709ffd6432e4f549f", "tree": "576ebdbff9d5f9f098cd29d652215b8f67b6b042", "parents": [ "4388fb213ec746ee18a6bea38ee894f8c19990b9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Dec 07 11:22:59 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 15:27:27 2017 +0000" }, "message": "Determine HLoadClass/String load kind early.\n\nThis helps save memory by avoiding the allocation of\nHEnvironment and related objects for AOT references to\nboot image strings and classes (kBootImage* load kinds)\nand also for JIT references (kJitTableAddress).\n\nCompiling aosp_taimen-userdebug boot image, the most memory\nhungry method BatteryStats.dumpLocked() needs\n - before:\n Used 55105384 bytes of arena memory...\n ...\n UseListNode 10009704\n Environment 423248\n EnvVRegs 20676560\n ...\n - after:\n Used 50559176 bytes of arena memory...\n ...\n UseListNode 8568936\n Environment 365680\n EnvVRegs 17628704\n ...\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nBug: 34053922\nChange-Id: I68e73a438e6ac8e8908e6fccf53bbeea8a64a077\n" } ], "next": "f223f76bdd360664a1e8068eeac6ce35f7392bc6" }