)]}' { "log": [ { "commit": "966b46fcba43764267069b6e19bcb2a092260418", "tree": "fe89667cbb09a981e67ebd1196d324038a6413ff", "parents": [ "98afa11c3cd8517bd28d1cad7aacaf0179c905f0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Aug 03 10:20:19 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Aug 03 12:35:34 2018 +0100" }, "message": "Revert^2 \"ARM/ARM64: Use introspection marking for JITted code.\"\n\nThis reverts commit 756e722c323c69a7c9891892602730e9c94b78f9.\n\nFix the introspection code to avoid avoid macro instructions\nfor unpoisoning references inside ExactAssemblyScope.\n\nChange-Id: I6effadb84de74aba0236ab84b52ca85770daf5be\nTest: m test-art-host-gtest\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing --jit\nTest: ART_HEAP_POISONING\u003dtrue m test-art-target-gtest\nTest: ART_HEAP_POISONING\u003dtrue testrunner.py --target --optimizing --jit\nBug: 36141117\n" }, { "commit": "756e722c323c69a7c9891892602730e9c94b78f9", "tree": "a2bf360d95f0aef84f3bce43f43871910a0b7ed9", "parents": [ "450f1d0fa0c40198e63c3e016f02e40ac854b0cb" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Aug 02 17:53:46 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Aug 02 17:53:46 2018 +0000" }, "message": "Revert \"ARM/ARM64: Use introspection marking for JITted code.\"\n\nThis reverts commit 450f1d0fa0c40198e63c3e016f02e40ac854b0cb.\n\nReason for revert: breaks poisoning configuration\n\nBug: 36141117\nChange-Id: I198c20ca1db6d7d7602aa5318616e2b149de8772\n" }, { "commit": "450f1d0fa0c40198e63c3e016f02e40ac854b0cb", "tree": "0606a5c722be0d706242c015cb1218021c5c1309", "parents": [ "da6220a29fae95f17edd5374dc6bc2d4870a84da" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 25 17:27:45 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jul 25 18:34:19 2018 +0100" }, "message": "ARM/ARM64: Use introspection marking for JITted code.\n\nImpact on Golem benchmarks is within noise.\n\nTest: m test-art-host-gtest\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nBug: 36141117\nChange-Id: Idf5177ee5cd34e2034d298a7907240b3e3e12d82\n" }, { "commit": "f58dc65c52f5e3f15eaaa1e25d7259e64649ade3", "tree": "4485299d9959a658909879b5a234fd807d7627ff", "parents": [ "0b4a439f808f4602c7b97364e49c5546f5100d51" ], "author": { "name": "Evgeny Astigeevich", "email": "evgeny.astigeevich@linaro.org", "time": "Mon Jun 25 17:54:07 2018 +0100" }, "committer": { "name": "Evgeny Astigeevich", "email": "evgeny.astigeevich@linaro.org", "time": "Fri Jul 13 16:30:32 2018 +0100" }, "message": "ART: Delete code optimizing a%1 and a%-1 from InstructionCodeGeneratorARM64\n\nIn InstructionWithAbsorbingInputSimplifier there is code optimizing a%1\nand a%-1. So the code in InstructionCodeGeneratorARM64 optimizing such\ncases can be deleted.\n\nThis patch deletes the code from InstructionCodeGeneratorARM64 and adds\nadditional tests.\n\nTest: 012-math, 014-math3, 411-optimizing-arith, 411-checker-hdiv-hrem-pow2\nTest: 701-easy-div-rem, 442-checker-constant-folding\nTest: test-art-host, test-art-target\nChange-Id: Ib80c0aa4c3e28b07fa79bb43783274c9d7fc456a\n" }, { "commit": "6fd1606a3f3fc2dd53ab4f8b371e420b3e33c74f", "tree": "9f944d267ce3616eb969c027665e4a451c2b3879", "parents": [ "bb089b6bf850c87e0e42917a383cc7298dcb09c5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 26 11:02:04 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 29 14:39:00 2018 +0100" }, "message": "Implement Integer.valueOf() intrinsic for boot image.\n\nAnd generate only one \"boot image live objects\" array rather\nthan one per boot*.art file.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 71526895\nChange-Id: I23af7f47fea5150805f801cd2512f2d152ee5b73\n" }, { "commit": "f07d5617770c37d87447c8bddf105eb0469ab093", "tree": "e6b15b904e591a3b805b292ce9afd9b0cecbf40d", "parents": [ "2dc252e37d4df0c4160cd20b6fc852f5f28b7b87", "a043111e3a2c09b549708a6227a1f54d91da76aa" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jun 27 12:23:54 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jun 27 12:23:54 2018 +0000" }, "message": "Merge \"Move instruction_set_ to CompilerOptions.\"" }, { "commit": "a043111e3a2c09b549708a6227a1f54d91da76aa", "tree": "393fe11cfceccebf474e4bdf36ff79b70b97f589", "parents": [ "213ee2da6a1c58d0fc12c937bbd9c9974ca00aca" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 25 09:32:54 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 25 18:43:19 2018 +0100" }, "message": "Move instruction_set_ to CompilerOptions.\n\nRemoves CompilerDriver dependency from ImageWriter and\nseveral other classes.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nChange-Id: I3c5b8ff73732128b9c4fad9405231a216ea72465\n" }, { "commit": "ccfc88af4ab94ff91f9b241d5113dfe7cb1f2b34", "tree": "68198426ee1a8ff1f4ee06f131be1e75fd961968", "parents": [ "ef3f32487a8a9a8b4272ea5ae372642c721ee41a", "eebb821b1adaf2db7662fc1c3ff4e9fcfe59a694" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 22 09:03:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 22 09:03:30 2018 +0000" }, "message": "Merge \"Implement Integer.valueOf() intrinsic for PIC.\"" }, { "commit": "bf711e388998c9233b9fc930bcf02511b6943706", "tree": "eeb66747dff7329516d85e29da22795ae51947b7", "parents": [ "5774f57afc997ffe765c32199bd0d5e55d23005a", "878f17d7737a91235013ed16ebe057a12367941b" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Jun 21 16:28:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jun 21 16:28:30 2018 +0000" }, "message": "Merge \"ARM64: Splitting GenerateDivRem* functions into GenerateIntDiv and GenerateIntRem functions\"" }, { "commit": "eebb821b1adaf2db7662fc1c3ff4e9fcfe59a694", "tree": "a3d3cf5f8c20d03fccdc0808537904da63e74938", "parents": [ "7e56bd41cde4e489a11050d9e340bf8b5692d9e8" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 05 14:57:24 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 21 16:12:28 2018 +0100" }, "message": "Implement Integer.valueOf() intrinsic for PIC.\n\nAnd fix the intrinsic for JIT even in case when someone\nmesses up the IntegerCache using reflection. Two cases are\nexposed with a regression test (one that previously failed\nrandomly and one that failed 100%) but other crashes were\npossible; for example, we would need a read barrier for\narray reads when elements are not guaranteed to be in the\nboot image.\n\nThe new approach loads references only from the boot image\nlive objects array which cannot be touched by reflection.\nThe referenced objects and IntegerCache.cache are exposed\nand can lead to weird behavior but not crashes.\n\nOn x86, the pc_relative_fixups_86 actually checks the cache\nan additional time but discrepancies between this check and\nthe location building at the beginning of codegen should be\nOK as the HIsX86ComputeBaseMethodAddress should be added\nfor PIC regardless of whether pc_relative_fixups_86 thinks\nthe method is intrinsified or not.\n\nTest: 717-integer-value-of\nTest: Pixel 2 XL boots.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --pictest --npictest\nTest: testrunner.py --host --jit\nTest: testrunner.py --target --optimizing --pictest --npictest\nTest: testrunner.py --target --jit\nBug: 71526895\nChange-Id: I89b3245a62aba22980c86a99e2af480bfa250af1\n" }, { "commit": "2227fe49558c5c5fc4820acb2cf357479e74b518", "tree": "bbfb6546c5da802132405569d2f06b459f12a0c3", "parents": [ "111b895dfaa271d8e9c32d1186615a0b73c106b5" ], "author": { "name": "Petre-Ionut Tudor", "email": "petre-ionut.tudor@linaro.org", "time": "Fri Apr 20 17:12:05 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 14 07:42:40 2018 +0000" }, "message": "Small refactor of MIN/MAX compiler code.\n\nIntegrate instruction code generation and location creation with\nHandleBinaryOp. Code generation has been improved for constant\ninputs 0, 1 and -1.\n\nTest: 679-checker-minmax\nTest: test-art-host, test-art-target.\n\nChange-Id: Ib34eb8a4b29d22a2491d21656e1f64011ef9f986\n" }, { "commit": "878f17d7737a91235013ed16ebe057a12367941b", "tree": "f18731e59850baf5d0535a1253643884237e889b", "parents": [ "32e83b36601e080b01712aeb6e9ebaa512eb0f33" ], "author": { "name": "Evgeny Astigeevich", "email": "evgeny.astigeevich@linaro.org", "time": "Fri Jun 01 16:53:58 2018 +0100" }, "committer": { "name": "Evgeny Astigeevich", "email": "evgeny.astigeevich@linaro.org", "time": "Wed Jun 13 21:47:36 2018 +0100" }, "message": "ARM64: Splitting GenerateDivRem* functions into GenerateIntDiv and GenerateIntRem functions\n\nVisitDiv and VisitRem call GenerateDivRemIntegral.\nGenerateDivRemIntegral does not know whether it is invoked for HDiv or\nHRem and has to check this. As a result all GenerateDivRem* functions\nhave such checks. Code for optimizing HRem and HDiv, e.g. a denominator is\npower of 2, can be specific for HRem or HDiv. So having it in\nGenerateDivRem would create issues with code maintenance.\n\nThis patch split GenerateDivRem* functions into GenerateIntDiv* and\nGenerateIntRem. BTW \u0027Integral\u0027 meaning is not \u0027Integer\u0027. So changed it\nas well. It also removes the case \u0027division by 1 or -1\u0027 because the case\nis handled in InstructionSimplifierVisitor. As there is a commonly used\nfunction Int64ConstantFrom(Location) it is used instead of\nInt64FromConstant(HConstant). This removes some code as well.\n\nTest: 012-math, 014-math3, 411-optimizing-arith\nTest: test-art-host, test-art-target\nChange-Id: I972129b24a206c8230d304be551cd2c18dbc7c9c\n" }, { "commit": "d3083dd15af1cb4ffc13d87a7d2c3be2edb9199d", "tree": "88dd2599ad89da5a4f2668a2c9debd0335669cd0", "parents": [ "6623bc389c43efc87668ce7465e19b195e765e22" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 17 08:43:47 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 22 14:38:14 2018 +0100" }, "message": "Refactor runtime callee save frame info.\n\nAnd avoid storing the info in Runtime.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nChange-Id: Ib14853fc06c420753993e1f9e82a1b01f5e35e8c\n" }, { "commit": "ca1e038eb94694f0f1f94ed3781572411c85d365", "tree": "90ad2c2494821c2f3d904eb42e61fbecd7acaf9d", "parents": [ "3f967b25650e44cd61f5a1112727a8218f2b0804" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 11 09:58:41 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 11 11:10:10 2018 +0100" }, "message": "Revert^2 \"Compile link-time thunks in codegen.\"\n\nThe linker crash (the reason for revert) is flaky and maybe\nwe shall not see it with this CL now that unrelated source\ncode has changed.\n\nTest: Rely on TreeHugger\nBug: 36141117\nBug: 77581732\n\nThis reverts commit 5806a9ec99b5494b511e84c74f494f0b3a8ebec5.\n\nChange-Id: I3a4a058847dff601681ba391abf45833424fa06d\n" }, { "commit": "5806a9ec99b5494b511e84c74f494f0b3a8ebec5", "tree": "bb50d00ff0890c2e10f351f462b47b56b01e78ea", "parents": [ "c9dd2207dfdab42586b1d6a5e7f11cf2fcea3a7a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 04 17:23:28 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 04 17:23:28 2018 +0000" }, "message": "Revert \"Compile link-time thunks in codegen.\"\n\nReason for revert: This caused clang linker crash\nin several branches.\n\nBug: 77581732\n\nThis reverts commit c9dd2207dfdab42586b1d6a5e7f11cf2fcea3a7a.\n\nChange-Id: I1923809083cf41c4f19e3e60df03ae80517aaedb\n" }, { "commit": "c9dd2207dfdab42586b1d6a5e7f11cf2fcea3a7a", "tree": "879df31fd10658093b8931117ee617064ce82519", "parents": [ "30a2d9c61da75359dee4ce90236d19fc6341b07a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 23 16:05:19 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 04 10:34:36 2018 +0100" }, "message": "Compile link-time thunks in codegen.\n\nPrepare for experimenting with Baker read barrier marking\nintrospection entrypoints for JIT.\n\nTest: m test-art-host-gtest\nTest: Compare compiled boot*.oat before and after (no diff).\nTest: Pixel 2 XL boots.\nBug: 36141117\nChange-Id: Idb413a31b158db4bf89a8707ea46dd167a06f110\n" }, { "commit": "175e7862dbdb44089ef327fc43ba00c791fd3838", "tree": "7b7ff4327b51b57e47e4b22af8d771edb9d462c1", "parents": [ "77c6fc7341143dd27c74cddd786398688d7b4c91" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 27 09:03:13 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 27 10:04:25 2018 +0100" }, "message": "Revert^4 \"Compiler changes for bitstring based type checks.\"\n\nDisabled the build time flag. (No image version bump needed.)\n\nBug: 26687569\nBug: 64692057\nBug: 76420366\n\nThis reverts commit 3fbd3ad99fad077e5c760e7238bcd55b07d4c06e.\n\nChange-Id: I5d83c4ce8a7331c435d5155ac6e0ce1c77d60004\n" }, { "commit": "3fbd3ad99fad077e5c760e7238bcd55b07d4c06e", "tree": "e8bc33fa60c38f7e1c85f8d4acf6a738df9b426a", "parents": [ "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:14:46 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:14:46 2018 +0000" }, "message": "Revert^3 \"Compiler changes for bitstring based type checks.\"\n\nThis reverts commit 3f41323cc9da335e9aa4f3fbad90a86caa82ee4d.\n\nReason for revert: Fails sporadically.\n\nBug: 26687569\nBug: 64692057\nBug: 76420366\nChange-Id: I84d1e9e46c58aeecf17591ff71fbac6a1e583909\n" }, { "commit": "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d", "tree": "ce41c620d2cd411da3c20aa95fb9a69328e77c42", "parents": [ "9ec1e24ebc683b15bb9c6db5554ac2ff9458adae" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 12 18:39:15 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 22 12:12:39 2018 +0000" }, "message": "Revert^2 \"Compiler changes for bitstring based type checks.\"\n\nAdd extra output for debugging failures and re-enable\nthe bitstring type checks.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: testrunner.py --host -t 670-bitstring-type-check\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --target -t 670-bitstring-type-check\nBug: 64692057\nBug: 26687569\n\nThis reverts commit bff7a52e2c6c9e988c3ed1f12a2da0fa5fd37cfb.\n\nChange-Id: I090e241983f3ac6ed8394d842e17716087d169ac\n" }, { "commit": "312f3b2fd0094c028a7d243b116947a35a745806", "tree": "3d7ec049ded98c489098c87250c75e3f711f8290", "parents": [ "0a3d5eb2ff9e70fa5785638da938439835d0337e" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 08:39:26 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 11:02:48 2018 -0700" }, "message": "Move some remaining dex utilities\n\nThere were several utilities related to building/walking/testing dex\nfiles that were not in libdexfile. This change consolidates these.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Id76e9179d03b8ec7d67f7e0f267121f54f0ec2e0\n" }, { "commit": "9992e095643f6746361df03c4c98e742d9ad5899", "tree": "8abf49af54ee57fc0acebf2a3d9cafd87d6ec48e", "parents": [ "a5867bfeb34529dad71220046e7327cef23af207", "e47f60c482648172334aaca59e6c1ab7a3d42610" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 09 10:17:11 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Mar 09 10:17:11 2018 +0000" }, "message": "Merge \"Retrieve String/Class references from .data.bimg.rel.ro.\"" }, { "commit": "8ba5641ddc43fc13cdb0158bd9f3237c4a90a356", "tree": "4dad508f24b675e87dd31ff26e597289a329c5cc", "parents": [ "66f40dbc3e56c7102820842ec49a55b70cf0e151", "b066d43b1d9184899aff32b1f243d092611ad9c6" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 08 17:45:59 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Mar 08 17:45:59 2018 +0000" }, "message": "Merge \"Load ArtMethod* from .data.bimg.rel.ro entries.\"" }, { "commit": "e47f60c482648172334aaca59e6c1ab7a3d42610", "tree": "ae0672b12a6ad200e1c38962c77bccfc3e5cb531", "parents": [ "b066d43b1d9184899aff32b1f243d092611ad9c6" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 21 13:43:28 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 08 10:40:12 2018 +0000" }, "message": "Retrieve String/Class references from .data.bimg.rel.ro.\n\nFor PIC AOT-compiled app, use the .data.bimg.rel.ro to load\nthe boot image String/Class references instead of using the\nmmapped boot image ClassTable and InternTable.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --pictest --npictest\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --pictest --npictest\nBug: 71526895\nChange-Id: Id5703229777aecb589a933a41f92e44d3ec02a3d\n" }, { "commit": "b066d43b1d9184899aff32b1f243d092611ad9c6", "tree": "5409177f52b1f1c648297913cb0e0b2808b9048d", "parents": [ "fe491c7b9cdd64ff4ccc10f6b212cb92a59fc765" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 03 13:14:37 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 08 10:40:10 2018 +0000" }, "message": "Load ArtMethod* from .data.bimg.rel.ro entries.\n\nIntroduce a new .data.bimg.rel.ro section in oat files where\nwe store offsets of boot image objects from the beginning of\nthe boot image. At runtime we relocate these entries using\nthe actual boot image address to turn offsets to pointers.\n\nUse the .data.bimg.rel.ro to prepare the boot image methods\nused by HInvokeStaticOrDirect for PIC AOT app compilation.\nLoading the ArtMethod* from .data.bimg.rel.ro instead of the\n.bss avoids the initial call to the resolution trampoline.\n\nTest: Additional test in 522-checker-sharpening\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --pictest --npictest\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --pictest --npictest\nBug: 71526895\nChange-Id: Ie5f5b1f622704877b36730377146e59092e46c0c\n" }, { "commit": "351df3e70521ebbe00ed6c7ac4ea25a0c26f4034", "tree": "8a22bf2eb06d2a5e57c6d6272ac070d368467118", "parents": [ "72efc159bf4e5cde85cd28e78316681effdceb5b" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Wed Mar 07 11:54:57 2018 -0800" }, "committer": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Wed Mar 07 12:00:42 2018 -0800" }, "message": "Minor cleanup of MIN/MAX code.\n\nRationale:\nShare the type dispatching code better.\n\nBug: b/65164101\n\nTest: test-art-host,target\nChange-Id: Ib06c915d570fd0a53f7734cdb316d2d16310db74\n" }, { "commit": "1f8d51bc03cbc607ae32fadf3a90f385adeffb95", "tree": "70e18902051ce47e0d524525b83709efbe6f250f", "parents": [ "7a02c66fd9ed174fc2e49ccc9f582dd661b7de9e" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Thu Feb 15 10:42:37 2018 -0800" }, "committer": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Wed Mar 07 09:22:09 2018 -0800" }, "message": "Introduce MIN/MAX/ABS as HIR nodes.\n\nRationale:\nHaving explicit MIN/MAX/ABS operations (in contrast\nwith intrinsics) simplifies recognition and optimization\nof these common operations (e.g. constant folding, hoisting,\ndetection of saturation arithmetic). Furthermore, mapping\nconditionals, selectors, intrinsics, etc. (some still TBD)\nonto these operations generalizes the way they are optimized\ndownstream substantially.\n\nBug: b/65164101\n\nTest: test-art-host,target\n\nChange-Id: I69240683339356e5a012802f179298f0b04c6726\n" }, { "commit": "59eb30f96d87e3e72a060099a292ae14dd5fe1c8", "tree": "49f9334a44a28eef8d0c35c6061c61743d4db4a8", "parents": [ "5919f737facdebbe8b738272e681ae33e085de98" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 20 11:52:34 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 20 14:27:43 2018 +0000" }, "message": "ART: Clean up patching data in codegens.\n\nReuse PatchInfo\u003c\u003e for additional architectures and make the\nnaming more consistent across architectures. Change the\nDexFile reference to pointer in preparation for patching\nreferences to the upcoming .data.bimg.rel.ro section.\n\nUpdate obsolete comments; instead of referencing dex cache\narrays which were used in the past, reference the .bss and\nthe .data.bimg.rel.ro which shall be used in upcoming CLs.\n\nTest: Rely on TreeHugger.\nChange-Id: I03be4c4118918189e55c62105bb594500c6a42c1\n" }, { "commit": "bff7a52e2c6c9e988c3ed1f12a2da0fa5fd37cfb", "tree": "e281a8dde61e396ed5f20c31d41086b1b1b18389", "parents": [ "83af48e9f4cdfcf3f0069c63561bab4c176bd2f1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 25 13:33:07 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 25 15:05:16 2018 +0000" }, "message": "Revert \"Compiler changes for bitstring based type checks.\"\n\nBug: 64692057\nBug: 71853552\nBug: 26687569\n\nThis reverts commit eb0ebed72432b3c6b8c7b38f8937d7ba736f4567.\n\nChange-Id: I7daeaa077960ba41b2ed42bc47f17501621be4be\n" }, { "commit": "eb0ebed72432b3c6b8c7b38f8937d7ba736f4567", "tree": "74d95eb4bfbf01ef6fd3a68695f5d7cec69338d7", "parents": [ "e57043081e6b091a9fd23a84043373148ae72f1f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 10 18:26:38 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jan 23 13:02:59 2018 +0000" }, "message": "Compiler changes for bitstring based type checks.\n\nWe guard the use of this feature with a compile-time flag,\nset to true in this CL.\n\nBoot image size for aosp_taimen-userdebug in AOSP master:\n - before:\n arm boot*.oat: 63604740\n arm64 boot*.oat: 74237864\n - after:\n arm boot*.oat: 63531172 (-72KiB, -0.1%)\n arm64 boot*.oat: 74135008 (-100KiB, -0.1%)\n\nThe new TypeCheckBenchmark yields the following changes\nusing the little cores of taimen fixed at 1.4016GHz:\n 32-bit 64-bit\n timeCheckCastLevel1ToLevel1 11.48-\u003e15.80 11.47-\u003e15.78\n timeCheckCastLevel2ToLevel1 15.08-\u003e15.79 15.08-\u003e15.79\n timeCheckCastLevel3ToLevel1 19.01-\u003e15.82 17.94-\u003e15.81\n timeCheckCastLevel9ToLevel1 42.55-\u003e15.79 42.63-\u003e15.81\n timeCheckCastLevel9ToLevel2 39.70-\u003e14.36 39.70-\u003e14.35\n timeInstanceOfLevel1ToLevel1 13.74-\u003e17.93 13.76-\u003e17.95\n timeInstanceOfLevel2ToLevel1 17.02-\u003e17.95 16.99-\u003e17.93\n timeInstanceOfLevel3ToLevel1 24.03-\u003e17.95 24.45-\u003e17.95\n timeInstanceOfLevel9ToLevel1 47.13-\u003e17.95 47.14-\u003e18.00\n timeInstanceOfLevel9ToLevel2 44.19-\u003e16.52 44.27-\u003e16.51\nThis suggests that the bitstring typecheck should not be\nused for exact type checks which would be equivalent to the\n\"Level1ToLevel1\" benchmark. Whether the implementation is\na beneficial replacement for the kClassHierarchyCheck and\nkAbstractClassCheck on average depends on how many levels\nfrom the target class (or Object for a negative result) is\na typical object\u0027s class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: testrunner.py --host -t 670-bitstring-type-check\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --target -t 670-bitstring-type-check\nBug: 64692057\nBug: 71853552\nBug: 26687569\nChange-Id: I538d7e036b5a8ae2cc3fe77662a5903d74854562\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "ca6fff898afcb62491458ae8bcd428bfb3043da1", "tree": "195a6b16d3a4b34acc2faf91ce56f448efb15e07", "parents": [ "aa7273e56fbafc2692c8d20a31b50d2f4bdd2aa1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 03 14:49:14 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 06 17:53:50 2017 +0100" }, "message": "ART: Use ScopedArenaAllocator for pass-local data.\n\nPasses using local ArenaAllocator were hiding their memory\nusage from the allocation counting, making it difficult to\ntrack down where memory was used. Using ScopedArenaAllocator\nreveals the memory usage.\n\nThis changes the HGraph constructor which requires a lot of\nchanges in tests. Refactor these tests to limit the amount\nof work needed the next time we change that constructor.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Build with kArenaAllocatorCountAllocations \u003d true.\nBug: 64312607\nChange-Id: I34939e4086b500d6e827ff3ef2211d1a421ac91a\n" }, { "commit": "0ebe0d83138bba1996e9c8007969b5381d972b32", "tree": "a5ee66ebc5b587ade97e56ac8fc7d832fbbed4af", "parents": [ "e1e347dace0ded83774999bb26c37527dcdb1d5a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 21 22:50:39 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 25 15:45:01 2017 +0100" }, "message": "ART: Introduce compiler data type.\n\nReplace most uses of the runtime\u0027s Primitive in compiler\nwith a new class DataType. This prepares for introducing\nnew types, such as Uint8, that the runtime does not need\nto know about.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 23964345\nChange-Id: Iec2ad82454eec678fffcd8279a9746b90feb9b0c\n" }, { "commit": "d8dbc8da0e5cc6b5c2176ce2d3877e6194d72c0c", "tree": "af6e9fb02471d75ebdea46190a0aa3e9dbdb892d", "parents": [ "93780a60090356921b844dbefdc13442c9f18b52" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 20 13:37:47 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 20 15:55:10 2017 +0100" }, "message": "Refactor compiled_method.h .\n\nMove LinkerPatch to compiler/linker/linker_patch.h .\nMove SrcMapElem to compiler/debug/src_map_elem.h .\nIntroduce compiled_method-inl.h to reduce the number\nof `#include`s in compiled_method.h .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: Id211cdf94a63ad265bf4709f1a5e06dffbe30f64\n" }, { "commit": "6cfbdbc359ec5414d3e49f70d28f8c0e65b98d63", "tree": "f92b309ddc43c2254b6067346a653170fbbf7316", "parents": [ "0f3c7003e08a42a4ed8c9f8dfffb1bee1118de59" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 25 13:26:39 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 07 17:52:35 2017 +0100" }, "message": "Use mmapped boot image intern table for PIC app HLoadString.\n\nImplement new HLoadString load kind for boot image strings\nreferenced by PIC-compiled apps (i.e. prebuilts) that uses\nPC-relative load from a boot image InternTable mmapped into\nthe apps .bss. This reduces the size of the PIC prebuilts\nthat reference boot image strings compared to the kBssEntry\nas we can completely avoid the slow path and stack map.\n\nWe separate the InternedStrings and ClassTable sections of\nthe boot image (.art) file from the rest, aligning the\nstart of the InternedStrings section to a page boundary.\nThis may actually increase the size of the boot image file\nby a page but it also allows mprotecting() these tables as\nread-only. The ClassTable section is included in\nanticipation of a similar load kind for HLoadClass.\n\nPrebuilt services.odex for aosp_angler-userdebug (arm64):\n - before: 20862776\n - after: 20308512 (-541KiB)\nNote that 92KiB savings could have been achieved by simply\navoiding the read barrier, similar to the HLoadClass flag\nIsInBootImage(). Such flag is now unnecessary.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --pictest\nTest: testrunner.py --target on Nexus 6P.\nTest: testrunner.py --target --pictest on Nexus 6P.\nTest: Nexus 6P boots.\nBug: 31951624\nChange-Id: I5f2bf1fc0bb36a8483244317cfdfa69e192ef6c5\n" }, { "commit": "2b03a1f24600c8c9558fb13d3f8bca1ef0f8ee40", "tree": "4d5fb728acd7f98f8949c84364375a804ff0ba63", "parents": [ "461ec567f16039374dff35e2f3b808986c100249" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Jun 06 16:09:59 2017 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Aug 10 18:17:47 2017 +0100" }, "message": "Instrument ARM64 generated code to check the Marking Register.\n\nGenerate run-time code in the Optimizing compiler checking that\nthe Marking Register\u0027s value matches `self.tls32_.is.gc_marking`\nin debug mode (on target; and on host with JIT, or with AOT when\ncompiling the core image). If a check fails, abort.\n\nTest: m test-art-target\nTest: m test-art-target with tree built with ART_USE_READ_BARRIER\u003dfalse\nTest: ARM64 device boot test with libartd.\nBug: 37707231\nChange-Id: Ie9b322b22b3d26654a06821e1db71dbda3c43061\n" }, { "commit": "97c46466aea25ab63a99b3d1afc558f0d9f55abb", "tree": "afd225f51d28a77329bc2590a025400e088f260c", "parents": [ "00cca3a275562d110a8b35094b9b12fac37f67ab" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 11 14:04:03 2017 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Jul 11 17:43:27 2017 +0100" }, "message": "Introduce a Marking Register in ARM64 code generation.\n\nWhen generating code for ARM64, maintain the status of\nThread::Current()-\u003eGetIsGcMarking() in register X20,\ndubbed MR (Marking Register), and check the value of that\nregister (instead of loading and checking a read barrier\nmarking entrypoint) in read barriers.\n\nTest: m test-art-target\nTest: m test-art-target with tree built with ART_USE_READ_BARRIER\u003dfalse\nTest: ARM64 device boot test\nBug: 37707231\nChange-Id: Ibe9bc5c99a2176b0a0476e9e9ad7fcc9f745017b\n" }, { "commit": "0eb882bfc5d260e8014c26adfda11602065aa5d8", "tree": "e66dbebfb1e9a254c20954a2f2f98541aebfd5af", "parents": [ "b5f5d746ac3f2c3088292395603cb1470e7749d2" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 15 13:39:18 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jun 07 15:39:24 2017 +0100" }, "message": "Use ArtMethod* .bss entries for HInvokeStaticOrDirect.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --target\nTest: Nexus 6P boots.\nTest: Build aosp_mips64-userdebug.\nBug: 30627598\nChange-Id: I0e54fdd2e91e983d475b7a04d40815ba89ae3d4f\n" }, { "commit": "e7197bf7d58c705a048e13e241d7ca320502cd40", "tree": "496032b40145660b40002b9d5b7a78f1c2eeb44f", "parents": [ "4ee8e291a7d5b7b98f35f495eb97705836910871" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 17:00:23 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 06 15:26:42 2017 +0100" }, "message": "Replace invoke kind kDexCacheViaMethod with kRuntimeCall.\n\nIn preparation for replacing the dex cache method array\nwith a hash-based array, get rid of one unnecessary use.\nThis method load kind is currently used only on mips for\nirreducible loops and OSR, so this should have no impact\non x86/x86-64/arm/arm64.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Repeat the above tests with manually changing\n kDexCachePcRelative to kRuntimeCall in sharpening.cc.\n (Ignore failures in 552-checker-sharpening.)\nBug: 30627598\nChange-Id: Ifce42645f2dcc350bbb88c2f4642e88fc5f98152\n" }, { "commit": "d254f5c0d7b43397e8b8885a56ec4d36e9b61602", "tree": "ef645025a42f88a2c9eb0ab9483ff519886f0a4c", "parents": [ "cff1b21b3e19c5d3a2d726fdb60dacd7de2a6f0d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 15:18:36 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 16:24:33 2017 +0100" }, "message": "Revert \"ART: Reference.getReferent intrinsic for arm and arm64\"\n\nReverting because GenerateCalleeMethodStaticOrDirectCall()\nprevents replacing kDexCacheViaMethod with kRuntimeCall\nwhere we would not retrieve the target method at all and\nleave the runtime to retrieve and call it just like for\nunresolved methods.\n\nThe intrinsic should be re-implemented by loading the\nflags through HLoadClass.\n\nNote that the intrinsic was unimplemented for CC and a bit\nbroken for non-CC, using LDR instead of LDRB for loading\nthe flags.\n\nTest: Rely on TreeHugger.\nBug: 32535355\nBug: 30627598\n\nThis reverts commit d8c052ac0aa3382c4807add33afa32580ffeecbb.\n\nChange-Id: I81fd14dac60c94ac543e336f4f3c888259fc8bd7\n" }, { "commit": "dbddc22f5dc2d1ff4d4783fbd66c27812f4980d1", "tree": "2a0a8efa1c2630e57ab48ab2de171f2847ff282f", "parents": [ "a559fa1b0d6c276dde2cdc707de1acd4950f7190" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed May 24 12:04:13 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu May 25 16:59:44 2017 -0700" }, "message": "Refactor profiles to use TypeReference instead of ClassReference\n\nRefactor type reference into runtime and use it for profiles.\nClassReference was just duplicated code since it wasn\u0027t even using\nthe class def indexes.\n\nTest: test-art-host\n\nBug: 62040831\nChange-Id: Ia92f21c0e85c00321f52c97bb7a90158d882849b\n" }, { "commit": "6597946d29be9108e2cc51223553d3db9290a3d9", "tree": "cea6647a45cc59fa1423751179e647124f269990", "parents": [ "a654e0378a8d0bb149362399917e4da2959e6991" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 19 17:25:12 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 22 18:35:05 2017 +0100" }, "message": "Use PC-relative pointer to boot image methods.\n\nIn preparation for adding ArtMethod entries to the .bss\nsection, add direct PC-relative pointers to methods so that\nthe number of needed .bss entries for boot image is small.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --target on Nexus 6P\nTest: Nexus 6P boots.\nTest: Build aosp_mips64-userdebug\nBug: 30627598\nChange-Id: Ia89f5f9975b741ddac2816e1570077ba4b4c020f\n" }, { "commit": "764d454d1d51448deb81f6e8d2d7d317c7f4d1b4", "tree": "029f9e65cfe7e953df55b7af45e099924ffdbbac", "parents": [ "7974468d32b817be1d49dfcf513605f646c481bc" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 16 10:31:41 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 16 15:08:55 2017 +0100" }, "message": "Remove LoadString/Class kind kBootImageLinkTimeAddress.\n\nWe no longer support non-PIC boot image compilation.\n\nAlso clean up some obsolete code for method patches\nand make JIT correctly report itself as non-PIC.\n\nTest: testrunner.py --host\nTest: testrunner.py --target\nBug: 33192586\nChange-Id: I593289c5c1b0e88b82b86a933038be97bbb15ad2\n" }, { "commit": "ff48700df9da9aa0c6a8c1f65c9d862f936e1a89", "tree": "932dd5749a82d9477d24200db6d747d6008a0a5d", "parents": [ "15cb9753075bcaa5b91a6497a2d35e8bd98af1f0" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Mar 07 16:50:01 2017 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri May 05 16:08:50 2017 +0100" }, "message": "Improve the implementation of UnsafeCASObject with Baker read barriers.\n\nOn ARM and ARM64, avoid loading the reference altogether when the\nGC is not marking.\n\nAlso, extract the code logic for updating a reference field from\nGenerateReferenceLoadWithBakerReadBarrier routines and move it to\nnew routines (UpdateReferenceFieldWithBakerReadBarrier), to make\nthe implementation more legible.\n\nTest: Run ART target tests in Baker read barrier configuration.\nBug: 29516974\nChange-Id: I11c53f0607e997cd02ec7911725e98ef3dc97d90\n" }, { "commit": "472821b210a7fc7a4d2e3d45762c7b5b9628a35b", "tree": "d3dad427cdfcf4ebe8d324bcd3b7618ed42d14dd", "parents": [ "70940dfe99df0084a3f3fed1a88255ec976a60e3" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Thu Apr 27 17:23:51 2017 -0700" }, "committer": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Fri Apr 28 09:49:26 2017 -0700" }, "message": "Enable string \"array get\" vectorization.\n\nRationale:\nLike its scalar counterpart, the SIMD implementation of array get from\na string needs to deal with compressed and uncompressed cases.\nMicro benchmarks shows 2x to 3x speedup for just copying data!\n\nTest: test-art-target, test-art-host\nChange-Id: I2fd714e50715b263123c215cd181f19194456d2b\n" }, { "commit": "0225b7712202d95ac7ba40ec96e95e14c4ce0895", "tree": "cb5fdd6a7b95322ce7fa95b77aba8021e287c7fb", "parents": [ "6d3c61d8c6d2f96dec8345263c948fae3caa4e1a" ], "author": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Wed Apr 19 15:43:53 2017 +0100" }, "committer": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Fri Apr 21 17:41:42 2017 +0100" }, "message": "ARM64: Improve SIMD LDR/STR.\n\nTest: 640-checker-*-simd\nTest: test-art-target, test-art-host\n\nChange-Id: I2bcdef3f5cb7c0e7d1b3d02910fbf89ac694d89a\n" }, { "commit": "7b331261c6bdb6316a649ab591813f4dd1a5892f", "tree": "22b60227265c73903428ea55cde3123ea992ac4e", "parents": [ "b1a52116a1ca418dcccad2ca2acd6cb36f8ca0e7", "f4f2daafb38c9c07ea74044a0fb89a2a19288b7a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Apr 13 12:54:22 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Apr 13 12:54:23 2017 +0000" }, "message": "Merge \"ARM64: Use link-time generated thunks for Baker CC read barrier.\"" }, { "commit": "f4f2daafb38c9c07ea74044a0fb89a2a19288b7a", "tree": "13fd63a65c12e60074bc2bc1e693fbb3b788ed8e", "parents": [ "26c25d5da32fe1bdd94dd1404197c14994ecab60" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 20 18:26:59 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 12 17:02:06 2017 +0100" }, "message": "ARM64: Use link-time generated thunks for Baker CC read barrier.\n\nRemaining work for follow-up CLs:\n - array loads,\n - volatile field loads,\n - use implicit null check in field thunk.\n\nTest: Added tests to relative_patcher_arm64\nTest: New run-test 160-read-barrier-stress\nTest: m test-art-target-gtest on Nexus 6P.\nTest: testrunner.py --target on Nexus 6P.\nBug: 29516974\nBug: 30126666\nBug: 36141117\nChange-Id: Id68ff171c55a3f1bf1ac1b657f480531aa7b3710\n" }, { "commit": "d4bccf1ece319a3a99e03ecbcbbf40bb82b9e331", "tree": "2890740d9cab3eee2be223666f528c6707b89f90", "parents": [ "903b8169074c01590ab3f5ad9190d9c7e3fe795b" ], "author": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Mon Apr 03 18:47:32 2017 +0100" }, "committer": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Mon Apr 10 11:43:33 2017 +0100" }, "message": "ARM64: Support 128-bit registers for SIMD.\n\nTest: test-art-host, test-art-target\n\nChange-Id: Ifb931a99d34ea77602a0e0781040ed092de9faaa\n" }, { "commit": "f8f5a16ed7bad1e18179e38453e59c96a944de10", "tree": "53369083a97103563467cc5910a439a1864dd0b1", "parents": [ "7298b1ae3e9af5fdb46d168302a26cfbf5d475f5" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Mon Feb 06 15:35:29 2017 -0800" }, "committer": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Fri Mar 31 10:58:11 2017 -0700" }, "message": "ART vectorizer.\n\nRationale:\nMake SIMD great again with a retargetable and easily extendable vectorizer.\n\nProvides a full x86/x86_64 and a proof-of-concept ARM implementation. Sample\nimprovement (without any perf tuning yet) for Linpack on x86 is about 20% to 50%.\n\nTest: test-art-host, test-art-target (angler)\nBug: 34083438, 30933338\n\nChange-Id: Ifb77a0f25f690a87cd65bf3d5e9f6be7ea71d6c1\n" }, { "commit": "5ed51e3176f3dc4ff2e50ba4bf52743d404b5b4f", "tree": "1638115757601e4d41d1dc3f3cb9045f5d3d6dd9", "parents": [ "079f5fd58799a23aa5d60a5f85008a4663a33f2a", "54f869ed3c7910e6eb7bade924d41570e9a4cb14" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Mar 09 13:02:12 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Mar 09 13:02:12 2017 +0000" }, "message": "Merge changes Ia26b07f0,Id3d2758c\n\n* changes:\n Revert \"Revert \"Use the holder\u0027s gray bit in Baker read barrier slow paths (ARM, ARM64).\"\"\n Revert \"Revert \"Use the \"GC is marking\" information in compiler read barriers (ARM, ARM64).\"\"\n" }, { "commit": "c52f3034b06c03632e937aff07d46c2bdcadfef5", "tree": "031e4d1b2ca0961014e57e4987d80d7aa2c435b0", "parents": [ "ef81e988d0eb4db390e576aac346701b2d820916" ], "author": { "name": "Richard Uhler", "email": "ruhler@google.com", "time": "Thu Mar 02 13:45:45 2017 +0000" }, "committer": { "name": "Richard Uhler", "email": "ruhler@google.com", "time": "Wed Mar 08 10:55:17 2017 +0000" }, "message": "Remove --include-patch-information option from dex2oat.\n\nBecause we no longer support running patchoat on npic oat files, which\nmeans the included patch information is unused .\n\nBug: 33192586\nTest: m test-art-host\n\nChange-Id: I9e100c4e47dc24d91cd74226c84025e961d30f67\n" }, { "commit": "ba650a4d5a0a82c6c88d6546b6111013c2ee8072", "tree": "cc3046a30aab382cc9c346391ca7cc22f3bf11ad", "parents": [ "ef81e988d0eb4db390e576aac346701b2d820916" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Mar 06 13:52:32 2017 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Mar 06 13:57:15 2017 +0000" }, "message": "Revert \"Revert \"Use the \"GC is marking\" information in compiler read barriers (ARM, ARM64).\"\"\n\nThis reverts commit 35345a555bd7928582a7ffa6369b374b3ddc379d.\n\nIn compiler-generated code, when deciding whether to mark\na heap reference or not in a read barrier, check whether\nthe GC is currently marking, instead of checking the gray\nbit in the reference\u0027s holder\u0027s lock word.\n\nThis change is only for ARM and ARM64, as it does not\nbenefit x86 nor x86-64.\n\nChange-Id: Id3d2758c600115b2f07d345442cfa87edfc2792c\nTest: Run ART tests in Baker read barrier configuration.\nTest: Boot a device in Baker read barrier configuration.\nBug: 35780827\nBug: 29516974\n" }, { "commit": "35345a555bd7928582a7ffa6369b374b3ddc379d", "tree": "ef5e6236203e04b59151b2e1b1529f9b389957b4", "parents": [ "e25fc07d3d3b31fe46cb02a3ed0933c7af3999fd" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Feb 27 14:32:08 2017 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Feb 27 14:33:37 2017 +0000" }, "message": "Revert \"Use the \"GC is marking\" information in compiler read barriers (ARM, ARM64).\"\n\nThis reverts commit 1372c9f40df1e47bf775f1466bbb96f472b6b9ed.\n\nThis change (along with https://android-review.googlesource.com/#/c/342429/)\ncreates null pointer dereferences.\n\nBug: 35780827\nBug: 29516974\nChange-Id: I2a9c4d0ad8d2ab870c2e0ddbff32152933c77abe\n" }, { "commit": "1372c9f40df1e47bf775f1466bbb96f472b6b9ed", "tree": "d00923d1045ab66c6aa07ed5a42a69899580d210", "parents": [ "6cc0250f1d1507957fc2fe1543179eab5a8b53f9" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jan 13 11:47:39 2017 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Feb 23 13:50:11 2017 +0000" }, "message": "Use the \"GC is marking\" information in compiler read barriers (ARM, ARM64).\n\nIn compiler-generated code, when deciding whether to mark\na heap reference or not in a read barrier, check whether\nthe GC is currently marking, instead of checking the gray\nbit in the reference\u0027s holder\u0027s lock word.\n\nThis change is only for ARM and ARM64, as it does not\nbenefit x86 nor x86-64.\n\nTest: Run ART tests in Baker read barrier configuration.\nTest: Boot a device in Baker read barrier configuration.\nBug: 29516974\nChange-Id: Ia5d90286bb9f753f3bbcb3a6254eb166523a2ff5\n" }, { "commit": "914d7a8fca1184837475016d186585d863e81830", "tree": "e0b2ea229d4071d3d1149aa3c60307b75e350d6c", "parents": [ "4e4b62e21672dbacf5d5abb688a126aabad29269" ], "author": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Tue Feb 07 14:33:49 2017 +0000" }, "committer": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Fri Feb 10 15:12:36 2017 +0000" }, "message": "ARM64: Remove all uses of BlockPoolsScope.\n\nBlockPoolsScope should not be used because it is a VIXL scope\nfor VIXL internal usage only. In arm64 backend the intent was to\nblock pools between a particular instruction (Ldr, Str, Blr, etc)\nand a subsequent MaybeRecordImplicitNullCheck or RecordPcInfo call.\nHowever pools should be emitted at the opening of a scope if this\nis required to satisfy branch/ldr ranges. This is not done by the\nBlockPoolsScope, so proper scopes are now used now:\nExactAssemblyScope and EmissionCheckScope.\n\nTest: test-art-host\nTest: test-art-target\n\nBug: 34850123\n\nChange-Id: I30365ad63c644cf9dd85d5a3c2118f9c57be9d20\n" }, { "commit": "8e0e7f78431d7c6fcdaa8e0f8de9ea130a265d53", "tree": "c156e098fd7a92e2c81d487b6e31a7b24e69eecd", "parents": [ "334b51132a2fd1a396822a3aa80129224c94e721", "5b3c6c0fcca76d82a4c9acb03f7714457ae53dd9" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 26 12:35:06 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jan 26 12:35:07 2017 +0000" }, "message": "Merge \"Refactor code for unresolved field entrypoint.\"" }, { "commit": "5b3c6c0fcca76d82a4c9acb03f7714457ae53dd9", "tree": "e1678dcd577abb63391a0cfcbb27a69a0ac4e769", "parents": [ "c9569731061e560cb56116255b00a49d6a5daeb8" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 19 14:22:26 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 26 10:37:58 2017 +0000" }, "message": "Refactor code for unresolved field entrypoint.\n\n- Do macro magic to avoid source code duplication.\n- Do not fetch the referrer from the assembly, but\n from the C entrypoint instead.\n\nTest: test-art-host test-art-target\n\nChange-Id: Ib139c94bc8f74686640cad538ba75dc56fa00e1d\n" }, { "commit": "c51842b8dd2ad57a1b05f31ab20ad01123443c50", "tree": "1f252e84d65dda9e301e2db3760adcbddb55bed6", "parents": [ "b0dde4397fa5b0756312b46bd18477a2c1f6a7da", "d8c052ac0aa3382c4807add33afa32580ffeecbb" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jan 23 16:48:50 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jan 23 16:48:51 2017 +0000" }, "message": "Merge \"ART: Reference.getReferent intrinsic for arm and arm64\"" }, { "commit": "d8c052ac0aa3382c4807add33afa32580ffeecbb", "tree": "97679692824fee4b12b03b4d71cb0763a8233e70", "parents": [ "4cd515521828b1f9ce0d5e2f545cb3376a94e9f3" ], "author": { "name": "TatWai Chong", "email": "tatwai.chong@linaro.org", "time": "Wed Nov 02 16:12:48 2016 +0800" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jan 23 14:20:35 2017 +0000" }, "message": "ART: Reference.getReferent intrinsic for arm and arm64\n\nTest: m test-art-host\nTest: m test-art-target\nTest: export ART_HEAP_POISONING\u003dtrue; m test-art-host\nTest: export ART_HEAP_POISONING\u003dtrue; m test-art-target\nBug: 32535355\nChange-Id: Ie63317689dd9e03a24e701c30411f8014970173a\n" }, { "commit": "5247c08fb186a5a2ac02226827cf6b994f41a681", "tree": "8b1305f9fb918024302382b8e8aa43962098e9fa", "parents": [ "0d478f289f0e33f19693d135f1d562b57427ed32" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 13 14:17:29 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 16 23:42:09 2017 +0000" }, "message": "Put the resolved class in HLoadClass.\n\nTo avoid repeated lookups in sharpening/rtp/inlining.\n\nTest: test-art-host test-art-target\nChange-Id: I08d0da36a4bb061cdaa490ea2af3a3217a875bbe\n" }, { "commit": "1998cd02603197f2acdc0734397a6d48b2f59b80", "tree": "aa639c7ec96f71d7aaf5d0c865a8a133dbc457c3", "parents": [ "6bec91c7d4670905cd67440991ec76fd54d0f000" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 13 13:02:58 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 16 13:39:24 2017 +0000" }, "message": "Implement HLoadClass/kBssEntry for boot image.\n\nTest: m test-art-host\nTest: m test-art-host with CC\nTest: m test-art-target on Nexus 9\nTest: Nexus 9 boots.\nTest: Build aosp_mips64-eng\nBug: 30627598\nChange-Id: I168f24dedd5fb54a1e4215ecafb947ffb0dc3280\n" }, { "commit": "6bec91c7d4670905cd67440991ec76fd54d0f000", "tree": "05f4ba288e629270773c65b34b71be7bae5e92ff", "parents": [ "4155998a2f5c7a252a6611e3926943e931ea280a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 09 15:03:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 16 12:09:53 2017 +0000" }, "message": "Store resolved types for AOT code in .bss.\n\nTest: m test-art-host\nTest: m test-art-target on Nexus 9.\nTest: Nexus 9 boots.\nTest: Build aosp_mips64-eng.\nBug: 30627598\nBug: 34193123\nChange-Id: I8ec60a98eb488cb46ae3ea56341f5709dad4f623\n" }, { "commit": "f0acfe7a812a332122011832074142718c278dae", "tree": "49c4fc481cebd03323aaf0109066859165508303", "parents": [ "91db41f315f6c2366b7098c531224bee01170364" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 09 20:54:52 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 10 21:26:23 2017 +0000" }, "message": "Keep resolved String in HLoadString.\n\nFor the following reasons:\n- Avoids needing to do a lookup again in CodeGenerator::EmitJitRoots.\n- Fixes races where we the string was GC\u0027ed before CodeGenerator::EmitJitRoots.\n- Makes it possible to do GVN on the same string but defined in different\n dex files.\n\nTest: test-art-host, test-art-target\nChange-Id: If2b5d3079f7555427b1b96ab04546b3373fcf921\n" }, { "commit": "c1a42cf3873be202c8c0ca3c4e67500b470ab075", "tree": "f2bffbd14e1f9d5429dd8514d19be4fa6dfa392f", "parents": [ "06ce6d4359ed897f1d1b39be4e748f0c4f3ca2ff" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Dec 18 15:52:36 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 20 13:29:45 2016 +0000" }, "message": "Remove soon to be obsolete call kinds for direct calls.\n\nAnd remove CompilerDriver::GetCodeAndMethodForDirectCall in\npreparation of removing non-PIC prebuild and non-PIC on-device\nboot image compilation.\n\nTest: test-art-host test-art-target\nbug:33192586\nChange-Id: Ic48e3e8b9d7605dd0e66f31d458a182198ba9578\n" }, { "commit": "0f0829ba15e4ed54472fb6ebac3a19b101d03db3", "tree": "d968014b299db7fd4eaf23dde82cad3572d8147a", "parents": [ "1e35a69a44bbf3999ec1829e501d7305bd9fc9d2" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 13 13:50:14 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 13 13:50:14 2016 +0000" }, "message": "Remove obsolete DeduplicateDexCacheAddressLiteral().\n\nTest: Rely on TreeHugger\nBug: 30627598\nChange-Id: Ia3c7a1d528f62b730d7ac1cc7b67f21d9ff06c9e\n" }, { "commit": "22384aeab988df7fa5ccdc48a668589c5f602c39", "tree": "daca06adfc92c93017618c3729af54ed40214ba4", "parents": [ "0ee6447c63e354131dec78743ccabcbc964129e3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 22:33:36 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 23:06:38 2016 +0000" }, "message": "Revert \"Revert \"Add kJitTableAddress for HLoadClass.\"\"\n\nThis reverts commit d2d5262c8370309e1f2a009f00aafc24f1cf00a0.\n\nChange-Id: I6149d5c7d5df0b0fc5cb646a802a2eea8d01ac08\n" }, { "commit": "d2d5262c8370309e1f2a009f00aafc24f1cf00a0", "tree": "15b542ac079f30043cd3654cf5d3c40ae3ea34d0", "parents": [ "5b12f7973636bfea29da3956a9baa7a6bbe2b666" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 16:28:54 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 16:28:54 2016 +0000" }, "message": "Revert \"Add kJitTableAddress for HLoadClass.\"\n\nOne test failure after merge.\n\nThis reverts commit 5b12f7973636bfea29da3956a9baa7a6bbe2b666.\n\nChange-Id: I120c49e53274471fc1c82a10d52e99c83f5f85cc\n" }, { "commit": "5b12f7973636bfea29da3956a9baa7a6bbe2b666", "tree": "a2cd41c1d3c09abc594a76af11b7bebc302a2870", "parents": [ "0dd27eb2b51d030866c25dbf8e7bb737eb35a888" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Dec 09 11:26:35 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 11:50:24 2016 +0000" }, "message": "Add kJitTableAddress for HLoadClass.\n\nThis new kind loads classes from the root table associated with\nJIT compiled code.\n\nAlso remove kDexCacheAddress, which is replaced by kJitTableAddress.\n\ntest: ART_TEST_JIT\u003dtrue test-art-host-jit test-art-target-jit\nChange-Id: Ia23029688d1a60c178bf2ffa7463927c5d5de4d0\n" }, { "commit": "8a0128a5ca0784f6d2b4ca27907e8967a74bc4c5", "tree": "0dec75200282ae5e49785395e97bd4e6459f1c09", "parents": [ "60438b46090d22bb9b978196f5aa53fab3b89759" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 28 07:38:35 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Nov 29 11:11:46 2016 -0800" }, "message": "ART: Add dex::StringIndex\n\nAdd abstraction for uint32_t string index.\n\nTest: m test-art-host\nChange-Id: I917c2881702fe3df112c713f06980f2278ced7ed\n" }, { "commit": "a5b09a67034e57a6e10231dd4bd92f4cb50b824c", "tree": "304be738f4fa528b7ad2676103eecc84c79eaeeb", "parents": [ "dac7ad17c78387d15d7aefae0f852dddf5f37e34" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Nov 17 15:21:22 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 21 10:57:00 2016 -0800" }, "message": "ART: Add dex::TypeIndex\n\nAdd abstraction for uint16_t type index.\n\nTest: m test-art-host\nChange-Id: I47708741c7c579cbbe59ab723c1e31c5fe71f83a\n" }, { "commit": "132d8363bf8cb043d910836672192ec8c36649b6", "tree": "42ee8b08f0323e9762675333b50a4c218ecdefc7", "parents": [ "e89667815b9d0a1eacb91678fed2a7518bb07cc2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 16 09:19:42 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 18 14:31:30 2016 +0000" }, "message": "Revert \"Revert \"Revert \"Revert \"JIT root tables.\"\"\"\"\n\nTest: 626-set-resolved-string, test-art-host, test-art-target\nTest: run-libcore-tests.sh\nTest: phone boots and runs\n\nThis reverts commit 3395fbc20bcd20948bec8958db91b304c17cacd8.\n\nChange-Id: I104b73d093e3eb6a271d564cfdb9ab09c1c8cf24\n" }, { "commit": "3395fbc20bcd20948bec8958db91b304c17cacd8", "tree": "e0d00b412961e2aaa0dff91317a9f4168189e5fb", "parents": [ "75afcdd3503a8a8518e5b23d21b6e73306ce39ce" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 14 12:40:52 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 14 12:40:52 2016 +0000" }, "message": "Revert \"Revert \"Revert \"JIT root tables.\"\"\"\n\nlibcore failures:\ndalvikvm32 F 11-14 03:04:06 14870 14870 jit_code_cache.cc:310] Check failed: new_string !\u003d nullptr\n\nThis reverts commit 75afcdd3503a8a8518e5b23d21b6e73306ce39ce.\n\nChange-Id: I5a6b6b48aa79a763d1ff1ba4d85d63811254787d\n" }, { "commit": "75afcdd3503a8a8518e5b23d21b6e73306ce39ce", "tree": "b49afc4772fa72319475f96ed66d744bb03e803c", "parents": [ "ee48b0f11df812d98de5c989e1f6d95a21515564" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 10 10:38:11 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 11 13:18:24 2016 +0000" }, "message": "Revert \"Revert \"JIT root tables.\"\"\n\nAlso contains Revert \"Support kJitTableAddress in x86/arm/arm64.\"\n\nThis reverts commit 4acd03638fcdb4e5d1666f8eec7eb3bf6d6be035.\nThis reverts commit 997d1217830c0a18b70faeabd53c04700a87d7d9.\n\nTest: ART_USE_READ_BARRIER\u003dtrue/false test-art-host test-art-target\n\nChange-Id: I77cb1e9bf8f1b4c58b72d3cf5ca31ced2aaa1ea3\n" }, { "commit": "3af00dc3918dfaacd51fb0ef604de51dd6dc9af4", "tree": "ec07882ae02d98bd9841646ce9e8bb1349e9c751", "parents": [ "977919fbcbfbf0c1c3fa97e51490bc678da646d2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Nov 10 11:25:57 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Nov 10 12:45:56 2016 -0800" }, "message": "Use enum for read barrier options in compiler\n\nEnums are just phenomenal. Also fixed a double load error in x86\ninterface check cast fast path.\n\nTest: test-art-host\n\nChange-Id: Iea403ce579145b6a294073f3900ad6921c1a0d53\n" }, { "commit": "aa474eb597056d21c0b21d353b9b6aa460351d0f", "tree": "738ba965a552ac0e4814cb1131ef0dd96ae14142", "parents": [ "334b5c3d0d5d84242b4528241c759789e532ce08" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 09 15:18:27 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 09 15:59:33 2016 -0800" }, "message": "Avoid read barriers for inlined check cast\n\nAvoiding read barriers improves speed and reduces code size.\n\nDoing this can never result in false positives, only false negatives.\nThese false negatives are handled correcly by rechecking in the\nentrypoint.\n\nRitzperf code size for CC:\narm32: 13439400-\u003e13300136 (-1.04%)\narm64: 16405120-\u003e16253568 (-0.92%)\n\nPerf: TODO\n\nBug: 29516974\nBug: 12687968\n\nTest: test-art-host, run ritzperf both with CC\n\nChange-Id: Ie024e0b1e8ee415781fb73e8029e87e8a5318f86\n" }, { "commit": "334b5c3d0d5d84242b4528241c759789e532ce08", "tree": "4925b11b74297e34c35eb17bb2f08b161b8893c7", "parents": [ "3b3daf35d3f3053ac5f645cc0b0e5527012c44d7", "5c44c1bb131e609d9aba6f97f933567bf77cb8ed" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 09 23:16:16 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Nov 09 23:16:16 2016 +0000" }, "message": "Merge \"Add interface check cast fast path to arm, arm64, x86\"" }, { "commit": "5c44c1bb131e609d9aba6f97f933567bf77cb8ed", "tree": "46792f774d0c4e0e096510cb1927768cc4b92a46", "parents": [ "b4e4c279a0d96c5c9bd6d038d97c3c9992ff8d09" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Nov 04 18:13:04 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 09 10:31:16 2016 -0800" }, "message": "Add interface check cast fast path to arm, arm64, x86\n\nBug: 12687968\nBug: 32577579\n\nTest: test-art-host, test-art-target CC\n\nChange-Id: Ia57099d499fa704803cc5f0135f0f53fefe39826\n" }, { "commit": "07c919feccdf47f997842a131a802aa6b891e34a", "tree": "56d9bb3097c51d5efbf67cd7516b0bc3c8e16616", "parents": [ "997d1217830c0a18b70faeabd53c04700a87d7d9" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 09 17:29:03 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 09 17:29:03 2016 +0000" }, "message": "Revert \"Support kJitTableAddress in x86/arm/arm64.\"\n\nRevert this in order to revert https://android-review.googlesource.com/#/c/285781/\n\nThis reverts commit 997d1217830c0a18b70faeabd53c04700a87d7d9.\n\nChange-Id: I1888fba1c6f712cae4aec4ea4719b74a46da156c\n" }, { "commit": "997d1217830c0a18b70faeabd53c04700a87d7d9", "tree": "1f892df0eb21ebd0139cd62aa9f46a7485f375da", "parents": [ "0864c98b10cb8ca306671cabaa9be2a4068a2711" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 09 10:36:29 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 09 14:43:27 2016 +0000" }, "message": "Support kJitTableAddress in x86/arm/arm64.\n\ntest: test-art-host test-art-target, angler boots and runs.\nChange-Id: I3654ae2809d4d759db76ee1ada1c17f3a9c3b392\n" }, { "commit": "5edd9510b5f39e2f6d758954ae2ac78e17f21735", "tree": "41233bf579429e3cc057eefdbd8ad35e091d8055", "parents": [ "270b6aeb11d973dc1b339ccf892468e0ad3989e3", "00468f3b4b4741be407169a4f21054ebdcccb2b1" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Oct 28 14:15:10 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Oct 28 14:15:10 2016 +0000" }, "message": "Merge \"Remove default argument values in GenerateGcRootFieldLoad.\"" }, { "commit": "00468f3b4b4741be407169a4f21054ebdcccb2b1", "tree": "ad095c39f477b4a55d7d306128dd1b68ca80ce93", "parents": [ "384cb6674b967a9c58da9ad70fd6f98caa1d8691" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Oct 27 18:02:48 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Oct 27 18:03:11 2016 +0100" }, "message": "Remove default argument values in GenerateGcRootFieldLoad.\n\nThese values were never or rarely used.\n\nTest: mmma art (with and without `ART_USE_READ_BARRIER\u003dtrue`)\nBug: 12687968\nBug: 29516974\nChange-Id: I5d15140ce501bf50d7a87871b1e492cee54913db\n" }, { "commit": "a1aa3b1f40e496d6f8b3b305a4f956ddf2e425fc", "tree": "efe3dd581dbe9fb33e615d1608f0571ec3984208", "parents": [ "188edb3a3ec36ad5fc42373b1e1bed3a85b4f112" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Oct 26 13:03:38 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Oct 26 13:03:38 2016 +0100" }, "message": "Add support for Baker read barriers in UnsafeCASObject intrinsics.\n\nPrior to doing the compare-and-swap operation, ensure the\nexpected reference stored in the holding object\u0027s field is\nin the to-space by loading it, emitting a read barrier and\nupdating that field with a strong compare-and-set operation\nwith relaxed memory synchronization ordering (if needed).\n\nTest: ART host and target tests and Nexus 5X boot test with Baker read barriers.\nBug: 29516905\nBug: 12687968\nChange-Id: I480f6a9b59547f11d0a04777406b9bfeb905bfd2\n" }, { "commit": "aad75c6d5bfab2dc8e30fc99fafe8cd2dc8b74d8", "tree": "c1b9e1eabcf35c5cbb5b4f46313a4e062f2d5d51", "parents": [ "82d4838d6bb3480cd25327cedc5179fb2d86881c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 03 08:46:48 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 04 17:51:46 2016 +0100" }, "message": "Revert \"Revert \"Store resolved Strings for AOT code in .bss.\"\"\n\nFixed oat_test to keep dex files alive. Fixed mips build.\nRewritten the .bss GC root visiting and added write barrier\nto the artResolveStringFromCode().\n\nTest: build aosp_mips-eng\nTest: m ART_DEFAULT_GC_TYPE\u003dSS test-art-target-host-gtest-oat_test\nTest: Run ART test suite on host and Nexus 9.\nBug: 20323084\nBug: 30627598\n\nThis reverts commit 5f926055cb88089d8ca27243f35a9dfd89d981f0.\n\nChange-Id: I07fa2278d82b8eb64964c9a4b66cb93726ccda6b\n" }, { "commit": "5f926055cb88089d8ca27243f35a9dfd89d981f0", "tree": "8d87d400e36301eb648e19bcd225f13c469648ad", "parents": [ "9e5739aaa690a8529c104f4c05035a657616c310" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Sep 30 17:04:49 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Sep 30 18:08:09 2016 +0100" }, "message": "Revert \"Store resolved Strings for AOT code in .bss.\"\n\nThere are some issues with oat_test64 on host and aosp_mips-eng.\n\nAlso reverts \"compiler_driver: Fix build.\"\n\nBug: 20323084\nBug: 30627598\n\nThis reverts commit 63dccbbefef3014c99c22748d18befcc7bcb3b41.\nThis reverts commit 04a44135ace10123f059373691594ae0f270a8a4.\n\nChange-Id: I568ba3e58cf103987fdd63c8a21521010a9f27c4\n" }, { "commit": "63dccbbefef3014c99c22748d18befcc7bcb3b41", "tree": "60a498041bebff43bc1f43d438e3bc34a30887f7", "parents": [ "6bee25976782a063d6b44f7718a6302761bf6403" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 21 13:51:10 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 29 15:58:43 2016 +0100" }, "message": "Store resolved Strings for AOT code in .bss.\n\nAnd do some related refactorings.\n\nBug: 20323084\nBug: 30627598\nTest: Run ART test suite including gcstress on host and Nexus 9.\nTest: Run ART test suite including gcstress with baker CC on host and Nexus 9.\nTest: Build aosp_mips64-eng.\nChange-Id: I1b12c1570fee8e5da490b47f231050142afcbd1e\n" }, { "commit": "5e4e11e171f90d9a3ea178fc8e72aac909de55d5", "tree": "53314d1139ac797d55258f39097ecfb5cef45920", "parents": [ "ca8bad9136d1389deeebc8652fb17063388de6b2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Sep 22 13:17:41 2016 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Sep 23 09:08:00 2016 +0100" }, "message": "Clean-up sharpening and compiler driver.\n\nRemove dependency on compiler driver for sharpening\nand dex2dex (the methods called on the compiler driver were\ndoing unnecessary work), and remove the now unused methods\nin compiler driver.\n\nAlso remove test that is now invalid, as sharpening always\nsucceeds.\n\ntest: m test-art-host m test-art-target\nChange-Id: I54e91c6839bd5b0b86182f2f43ba5d2c112ef908\n" }, { "commit": "f41f956558ceb5402d3b4499a44a15c42f1c0064", "tree": "50afd6f7509adca0c8ed8cbdc04398058b687b81", "parents": [ "8850c73572215669efc893763791f7ec7f0b0667" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Sep 14 19:26:48 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Sep 14 19:26:48 2016 +0100" }, "message": "Add missing OVERRIDE qualifiers in code generators.\n\nTest: mmma art\nChange-Id: I91d0a2dc23dc8d63a9bb3607eb1c1517eabaeb1f\n" }, { "commit": "31b12e32073f458950e96d0d1b44e48508cf67e4", "tree": "b6f818dfa6b45342d6b69283c10e1db9817b8b0e", "parents": [ "038cb84f792501ae01561fe5ea4e8144f1918b7e" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 02 17:11:57 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 07 10:13:48 2016 -0700" }, "message": "Avoid read barrier for image HLoadClass\n\nConcurrent copying baker:\n\nX86_64 core-optimizing-pic.oat: 28583112 -\u003e 27906824 (2.4% smaller)\n\nAround 0.4% of 2.4% is from re-enabling kBootImageLinkTimeAddress,\nkBootImageLinkTimePcRelative, and kBootImageAddress.\n\nN6P boot.oat 32: 73042140 -\u003e 71891956 (1.57% smaller)\nN6P boot.oat 64: 83831608 -\u003e 82531456 (1.55% smaller)\n\nEAAC: 1252 -\u003e 1245 (32 samples)\n\nBug: 29516974\n\nTest: test-art-host CC baker, N6P booting\n\nChange-Id: I9a196cf0157058836981c43c93872e9f0c4919aa\n" }, { "commit": "22f81d3b620581c98548dec3b0d6d575e012fed8", "tree": "7986c0bd60c9ee6a95fcfff489b20ffa62cf3ed8", "parents": [ "ce999e7c8af5f76a05ab0b2267ef7b74d25c75b5" ], "author": { "name": "Serban Constantinescu", "email": "serban.constantinescu@linaro.org", "time": "Thu Feb 18 16:06:31 2016 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Aug 25 15:38:23 2016 +0000" }, "message": "ARM64: Make runtime invokes use InvokeRuntime().\n\nThis patch refactors all of the ARM64 Optimizing compiler runtime\ninvokes to use InvokeRuntime(). It also fixes some misuses of\nRecordPcInfo().\n\nTest: m test-art-target + Nexus 6 boot test\nChange-Id: Ia3e477c42fb14c62b81e50daa5811185071bafa6\n" }, { "commit": "af4e42a0d210aa3aa5d52926536b2ca5c2952934", "tree": "b64d683ba6ac11c0b7730df9a579aead2905dfff", "parents": [ "dce74be0c49e8a540affc0b5649a9cf8756b809b" ], "author": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Mon Aug 08 15:11:24 2016 +0100" }, "committer": { "name": "Anton Kirilov", "email": "anton.kirilov@linaro.org", "time": "Fri Aug 12 13:22:34 2016 +0100" }, "message": "ARM64: VIXL: Support a newer version of VIXL.\n\nPlease note that compiling VIXL with -Wshadow is a known VIXL issue.\n\nThis will be resolved in a later version of VIXL, when we can drop\nthe deprecated API for getters and setters.\n\nFor more info take a look at VIXL_DEPRECATED in the VIXL source code.\n\nChange-Id: Iea30b1a7b065f9b16a92c6cc7ebdc50ef068b348\n" }, { "commit": "087930f2be5a628c65db280a73fecf468899d983", "tree": "d7fbf94ce260ddbb722a3731fe393bc9ef6e1bbc", "parents": [ "3d6094531e3790b25c43e59fd6cd0b6b99d3447c" ], "author": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Tue Aug 02 13:45:28 2016 +0100" }, "committer": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Tue Aug 02 15:47:28 2016 +0000" }, "message": "ARM64: Make the VIXL macro assembler part of ART ARM64\u0027s assembler.\n\nThis avoids a dynamic allocation of the VIXL macro assembler.\n\nChange-Id: I4cd62678d0978f1ad6f32ea0ce7279e09152be38\n" }, { "commit": "542451cc546779f5c67840e105c51205a1b0a8fd", "tree": "11e09bb5abaee12dddffefbe7e425291076dfa7a", "parents": [ "85c4a4b8c9eabfe16e4e49f9b4aa78c1bf4be023" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jul 26 09:02:02 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 01 18:54:48 2016 -0700" }, "message": "ART: Convert pointer size to enum\n\nMove away from size_t to dedicated enum (class).\n\nBug: 30373134\nBug: 30419309\nTest: m test-art-host\nChange-Id: Id453c330f1065012e7d4f9fc24ac477cc9bb9269\n" }, { "commit": "26de38bb7f2122417388809f4ff88a7cb5c4af5e", "tree": "878f432e2476f90201dd4695cfc8c3498c2c207f", "parents": [ "9755c262df1be7f5d5b98d038c8fd3734e974f9d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 27 17:53:11 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 27 17:56:08 2016 -0700" }, "message": "ART: Delete old compiler_enums.h\n\nHoldover from the Quick days. Move the two enums that are still\nused closer to the actual users (and prune no longer used cases).\n\nTest: m test-art-host\nChange-Id: I88aa49961a54635788cafac570ddc3125aa38262\n" }, { "commit": "dec8f63fdf50815f24efe1c03af64208da15f339", "tree": "36c8dec8c2c93312d17c6d9d1452d4b133212dbd", "parents": [ "41c7e2e6ac0a59da2f3e066e20630b295fbe4661" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jul 22 17:10:06 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jul 22 18:54:35 2016 +0100" }, "message": "Do not emit stack maps for runtime calls to ReadBarrierMarkRegX.\n\n* Boot image code size variation on Nexus 5X\n (aosp_bullhead-userdebug build):\n - total ARM64 framework Oat files size change:\n 115584120 bytes -\u003e 109124728 bytes (-5.59%)\n - total ARM framework Oat files size change:\n 97387728 bytes -\u003e 92517584 (-5.00%)\n\nTest: ART host and target (ARM, ARM64) tests.\nBug: 29506760\nBug: 12687968\nChange-Id: I979d9fb2b4e09f4c0c7bf33af2cd91750a67f989\n" }, { "commit": "71280fcc8c7edc244b8236cd67b32b87365b069f", "tree": "7f1576978ca0b6d660eced5a67f32d713c4700bf", "parents": [ "5668e58daf0f54d6cc8a6919033acc3506fc86ee" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jul 18 16:03:05 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jul 18 16:03:05 2016 +0100" }, "message": "Fix the build with respect to new VIXL.\n\nTest: Build ART for ARM64.\nChange-Id: I2a9ebf145c61db9f8ceec6616963bac3ad5a7eb9\n" }, { "commit": "5668e58daf0f54d6cc8a6919033acc3506fc86ee", "tree": "de19460ff3c2f940ce5b0f7036a4bf756b59ed4e", "parents": [ "24670a7aac24c7a9b661220ab76b36c75f1494c5", "97c72b76cf776228196c6abd33973ef751de61ad" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jul 18 14:28:05 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jul 18 14:28:06 2016 +0000" }, "message": "Merge \"Fixes to build against new VIXL interface.\"" }, { "commit": "68bd9b9b165ffca1a49b80bb437ce9f87b738264", "tree": "671bb60203157fdb34dd2e9cdf851cb79eb02a0e", "parents": [ "173f435e56acfd0501fc460747572a4796dcffe0" ], "author": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Fri Jul 15 17:41:13 2016 +0100" }, "committer": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Mon Jul 18 11:25:19 2016 +0100" }, "message": "ARM64: Improve code generated to spill/restore for slow paths.\n\nAligning the accesses allows generating better code.\n\nBefore:\n\n add x16, sp, #0x44 (68)\n stp x0, x1, [x16, #-16]\n\nAfter:\n\n stp x0, x1, [sp, #56]\n\nChange-Id: I3e20ad3fa59d00aee4b4d14ea9d59c7cd546509e\n" }, { "commit": "97c72b76cf776228196c6abd33973ef751de61ad", "tree": "7a78a2b19b0847281f8cf69af735b30b15732fa8", "parents": [ "1fd347303275a424d114c9833f954e8e27812554" ], "author": { "name": "Scott Wakeling", "email": "scott.wakeling@linaro.org", "time": "Fri Jun 24 16:19:36 2016 +0100" }, "committer": { "name": "Scott Wakeling", "email": "scott.wakeling@linaro.org", "time": "Fri Jul 15 09:48:07 2016 +0100" }, "message": "Fixes to build against new VIXL interface.\n\n- Fix namespace usage and use of deprecated functions.\n- Link all dependants to new libvixl-arm64 target for now.\n\nChange-Id: Iee6f299784fd663fc2a759f3ee816fdbc511e509\n" }, { "commit": "dc00f184b57086263587f1a1c1991336c07a8e4a", "tree": "3e4ad30844658b9ccc48f80def1b8de66e2e2622", "parents": [ "2c30a373428b8d19bf97866d5d323c4ca2fbca72" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 14 10:10:44 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 14 13:09:51 2016 -0700" }, "message": "Revert \"Revert \"Dump more dex file data in oatdump\"\"\n\nDelete runtime to fix leak before callin exit.\n\nBug: 29462018\n\nThis reverts commit 9c05578dd2306231437bd290c0f70abc2bb3b6d8.\n\nChange-Id: Ica23ba0f2d07496d0e4a3288329945f612ac3b20\n" }, { "commit": "9c05578dd2306231437bd290c0f70abc2bb3b6d8", "tree": "0f9983cabba29de867051ea990221603f0ff765a", "parents": [ "8e2c56252aa9527bd9a82bdd147fdc46cf5deb9c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 14 09:24:30 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 14 09:24:30 2016 +0000" }, "message": "Revert \"Dump more dex file data in oatdump\"\n\nBreaks valgrind.\n\nBug: 29462018\n\nThis reverts commit 8e2c56252aa9527bd9a82bdd147fdc46cf5deb9c.\n\nChange-Id: If58cedcee75dd0eda8571e90d63e080a4709d773\n" } ], "next": "8e2c56252aa9527bd9a82bdd147fdc46cf5deb9c" }