)]}' { "log": [ { "commit": "66934efcabd2b75fd84b3cc0a8665f4ecc136727", "tree": "b55d836b7df49dcc73126cbcded7a0e64451ba39", "parents": [ "cf74ae7eae39affc8886b4bce5294aceebb908c3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jul 07 14:56:23 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jul 15 14:26:13 2021 +0000" }, "message": "Clean up ClassLinker::VerifyClass.\n\nAnd drop kAccWasVerificationAttempted. It\u0027s not needed and duplicates\nlogic already present in the compiler and the class status.\n\nThis CL also enables nterp running methods with soft failures.\n\nTest: test.py\nBug: 28313047\nChange-Id: I853a6f00b9e0c38091d86fcd77167c92ff5b383c\n" }, { "commit": "8fddc7519d756d4de6c2c1a4b14af5584e9fecba", "tree": "b832d2032e9a337ed31804e895426206de971854", "parents": [ "85d6bf94dc0d3a9c648dc6d614a293c4e416b247" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jul 06 14:16:40 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jul 07 08:11:47 2021 +0000" }, "message": "Handle potential OOME after ResolveNameString.\n\nTest: test.py\nBug: 192658894\nChange-Id: I10110c00326fd6f6da383cda0287542a2f1b61c6\n" }, { "commit": "4dc6589f392d46800a3b64625245bdfe4bbbfc2f", "tree": "b159262fd300a650ab89277667641ebe7e13d357", "parents": [ "e0386f10d4591afa9823658099e4f2ac7a693255" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jul 05 17:43:35 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jul 07 07:13:01 2021 +0000" }, "message": "Don\u0027t wrap VerifyError into NoClassDefFoundError.\n\nFollow RI behavior by returning the VerifyError. NoClassDefFoundError\nonly wraps initializer errors.\n\nAlso rename the field in ClassExt from verifyError to\nerroneousStateError for better clarity.\n\nAnd remove now unused feature of storing a class in the verifyError\nfield.\n\nTest: test.py\nTest: 824-verification-rethrow\nBug: 28313047\nChange-Id: I19383f7b74f22a62ab1e0b8a13bea75a14c7b33f\n" }, { "commit": "70e126af8a14b68f08acc9acadcdf5b4b0510781", "tree": "2b976fe92777e272019405955698868d5690b0e4", "parents": [ "8048e2e34edc8c168d255ef11de2a8e994d5012c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 24 14:51:34 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 25 10:57:07 2021 +0100" }, "message": "Clean up search for field by name and type strings.\n\nReuse the search algorithm introduced for methods in\n https://android-review.googlesource.com/1744375\ninstead of a separate binary search implementation.\nThe performance difference should be within noise because\nwe\u0027re just replacing one binary search with another one and\nclasses usually contain just one field with a given name.\nTools like proguard can create a class with multiple fields\nwith the same name and different types, but the motivation\nfor this change is code reuse and consistency rather than\npeformance improvement for those edge cases.\n\nAlso call the `FindFieldByNameAndType()` helper directly\nfrom `FindFieldImpl()` to skip unnecessary proxy class\nchecks in `Class::FindDeclaredStaticField()`. This should\nprovide some minor performance improvement.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 181943478\nChange-Id: I436c73c3eb7872f5597bb7b7d3f657aaa0a1ec6d\n" }, { "commit": "1776947f896652b232ccec3fc00a04fd7baf1d96", "tree": "f6820a1b6702fe7b642427d2b3a7eb123511ede5", "parents": [ "e020b7f4afc4d99cddfd52b3587280be9e3afd5d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jun 23 10:40:29 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 24 16:03:06 2021 +0000" }, "message": "Binary search for method by name string and signature.\n\nStart with a binary search for the name string and when\nsuccessful, compare the signature. On mismatch, repeat the\nsearch with the found name index instead of the name string\nuntil we fail to find the name, have a signature match or\nend up with a method range with the same name index and\nfinish with a simple binary search for the signature.\n\nMake this search sufficiently generic so that the code can\nbe easily reused for fields in the future.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 181943478\nChange-Id: I19b4779c019e9991b6d02ace57e378c029ba1174\n" }, { "commit": "869746ef31936f09a93717ee1ef3960f8fb6dd69", "tree": "b7c534bc792b8128ee6d53089692e6b5477482c0", "parents": [ "f5690ca22446968e6c28ebb06b1d7451e02e203d" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Mon Jun 14 14:13:14 2021 -0700" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jun 17 08:22:41 2021 +0000" }, "message": "runtime: fix potential NULL dereferences\n\nif `found` or `ret` isn\u0027t found, one or both of them may be NULL. hence,\nwe shouldn\u0027t be unconditionally calling `-\u003ePrettyField()` here.\n\nBug: None\nTest: TreeHugger\nChange-Id: Ia40dd0e726d04945d3dedf5c2beb6dd2cff84c21\n" }, { "commit": "40261171630159bfd46043c996be8521c453fee1", "tree": "3cae9dfcfd5f745b61da630d031eff4f67fe9185", "parents": [ "af5d304844cd8e39fcc31ca4e07e3e887d2f0bd9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 14 10:59:51 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 14 17:55:51 2021 +0000" }, "message": "Rewrite static/instance field search by index.\n\nThe old search was looking for a field with the given field\nindex in the class as well as superclasses and, for static\nfields, all interfaces. This was useless as as a field index\ncan match only in the declaring class. So, if the field was\nnot found in the declaring class we would have unnecessarily\nsearched wrong classes before resorting to string search.\n\nReuse the optimized `Class::FindField` by turning it into\na template implementation that can skip unnecessary static\nor instance field searches. Implementing the static and\ninstance field search this way allows ClassLinker to call\nonly one overload of `Class::Find{Static,Instance}Field`\nand helps avoid string searches in more cases.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --interpreter\nBug: 181943478\nChange-Id: I23309c87c3702d98812adfec0279c483c9037f2c\n" }, { "commit": "b10668cb6a34398eb720f9a6305ff9a51b3ebfd4", "tree": "ab155a0ae3c2966c20a3de68dbf53e6fe2ced86a", "parents": [ "893e2edbd5aa14ab2ccb1800ccd3154f21a2d8a7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 10 09:52:53 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 14 12:51:59 2021 +0000" }, "message": "Clean up Class::GetDirectInterface().\n\nFetch array interfaces from the `IfTable`. This removes the\nonly use of the `Thread* self` argument, so we can remove\nthat argument. We also make the function non-static to avoid\nthe explicit `klass` argument. Similarly clean up arguments\nof `Class::FindClass()` and `Class::FindStaticClass()`.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 181943478\nChange-Id: Id639b675b4eb331a777cf318eb61bd19e05de4f0\n" }, { "commit": "e300c4e4eabe3388b730efe35561e54f1c306710", "tree": "1866d5772e2c3643f30aa32b7bf0c02cec2e4c18", "parents": [ "f761f5887918375b842e4cc62ed9cbe7521c8444" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 08 16:00:05 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 10 13:47:14 2021 +0000" }, "message": "Faster Class::FindField().\n\nChange `Class::FindField()` to take dex cache and type index\narguments instead of strings and optimize it similarly to\n`Class::FindClassMethod()`, namely search by indexes when\npossible (except when searching interfaces where we only add\na TODO comment for now) and avoid `strlen()` calls for ASCII\nnames and type descriptors.\n\nUpdate `ClassLinker::FindResolvedFieldJLS()` to pass the new\narguments and replace all other `Class::FindField()` calls\nwith more direct calls as we know the classes where those\nfields are defined.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 181943478\nChange-Id: Iba798819043eb1b53b0dbc41ef8d7fd1c5d2164d\n" }, { "commit": "4573be38b0fb938c1177b8aa474e980c64ab5587", "tree": "ac2a02e6e40c60c7b6bede1c863f376882deb594", "parents": [ "b89e731029b61d66aa8c44f188bce48ec59a733e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 07 11:07:05 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 08 14:34:40 2021 +0000" }, "message": "Faster Class::FindClassMethod().\n\nAvoid using `strlen()` on ASCII strings from DexFile.\nThis was a missed opportunity in\n https://android-review.googlesource.com/963405 .\n\nAlso optimize iteration over declared methods of a class.\nLoad the dex file before the loop and avoid the runtime\nmethod check in `ArtMethod::GetMethodNameView()` by using\nthe `DexFile` interface directly.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 181943478\nChange-Id: I1ce3659b7f1fbcfc11d52626f9feb9be666d1161\n" }, { "commit": "8f187c3326b30fc43bedb254351ea55185fbd51a", "tree": "8f51159f835f112dcd9ada2e17b234744aac3cca", "parents": [ "e0f5839ae6e8dd90ccb31e658e3c20a8db10c219" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Apr 20 14:29:00 2021 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Apr 23 22:56:43 2021 +0000" }, "message": "Add static asserts we have a full list of mirror classes\n\nWe need to know if a particular object is of a mirrored class type in\norder for structural class redefinition to work correctly. For\nsimplicity and to avoid making class objects larger we do this with a\nsimple list of mirror-class descriptors. This adds some basic\nstatic_assert checking and a documenting macro to all mirror classes.\nThis should help to ensure nobody in the future unintentionally breaks\nstructural class redefinition by adding a new mirror type.\n\nTest: treehugger\nBug: 144349987\nChange-Id: I47c7b256655e9ce9bcf21d9670e0511bcbac65c9\n" }, { "commit": "af61f50d54574070b9a5b6647822c608cc92a9b3", "tree": "70f0cfa7092bbef6e68ed82fde19529894db5b96", "parents": [ "efe9a3d20b49654cc70e7c15d9aec24d11e14c28" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Mar 31 16:03:50 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Apr 01 08:33:53 2021 +0000" }, "message": "Reland \"Change JNI behavior related to hiddenapi.\"\n\nThis reverts commit dbcf4a2a597309f33914fb60dc09e1056032794a.\n\nBug: 178680596\nBug: 122551864\nBug: 184067905\n\nReason for revert: Limit the lookup of an accessible interface to an\ninterface part of the SDK.\n\nChange-Id: If08269908044bc0f2abe1967b6d952b1e828179b\n" }, { "commit": "dbcf4a2a597309f33914fb60dc09e1056032794a", "tree": "b01cf79b4fdf1df81193a255fd4a3ec98a952713", "parents": [ "26095cda197448071fbbc6af126363de1b4e8b4c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Mar 31 09:13:32 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Mar 31 12:49:05 2021 +0000" }, "message": "Revert \"Change JNI behavior related to hiddenapi.\"\n\nThis reverts commit 579db19af4f718c1aac5ca95c180a70c5114c6bd.\n\nBug: 178680596\nBug: 122551864\nBug: 184067905\n\nReason for revert: b/184067905\n\nChange-Id: I1c989b6d937b818e4779d7dd9f35abd30be2aa58\n" }, { "commit": "579db19af4f718c1aac5ca95c180a70c5114c6bd", "tree": "6f01108583a4e8edf00b094d8f30d6348516d570", "parents": [ "26a759688bdd376db7ed429ae07e136ff21f2411" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 29 16:50:37 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 30 13:16:32 2021 +0000" }, "message": "Change JNI behavior related to hiddenapi.\n\nWhen resolving a method, if the found method is not accessible, check if\nthere are methods defined in interfaces which are.\n\nBug: 178680596\nBug: 122551864\nTest: 817-hiddenapi\nChange-Id: Ibca0960e93ee399718716395ff9ed1f1c4e246b2\n" }, { "commit": "346fd964a826cfb5626582452b7519c04aee2f8a", "tree": "49fb6cf2ab865391ba4027389b0049474df38c7b", "parents": [ "d3ee902ed06b635eedebc796543a67299eb6cd05" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jul 27 16:51:00 2020 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jul 28 11:13:37 2020 +0000" }, "message": "More inclusive language in the runtime\n\nTest: m\nBug: 161896447\nBug: 161850439\nBug: 161336379\nChange-Id: Iabc29fa43b4b5a403699d6bca95e9a2cb8945d77\n" }, { "commit": "1715efa0b46d57d587237829d1c0695aaca2c344", "tree": "61e7013808a8fa9c45384fa8d84bd7f3eb1eaf34", "parents": [ "9922f00cf68aac69209216a0726a45eb6338763c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jun 05 18:34:49 2020 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jun 09 12:28:42 2020 +0000" }, "message": "Add a new class status for verified with access checks.\n\nAt runtime, we won\u0027t run the verifier for those classes, but run with\naccess checks enabled in the interpreter.\n\nBug: 157265232\nTest: test.py\n\nChange-Id: Ia087c3b6f9fcbd295307333e524945d844ef54dc\n" }, { "commit": "5868adaefe72cc8bcdcd8325c40f712375a506d1", "tree": "a1d4328902c4e860fe69c4e4bb34052de2530df3", "parents": [ "5a62af5dc9e9bafeffcac7820e1a5b7586e58477" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 12 11:50:34 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 13 08:00:22 2020 +0000" }, "message": "Move implementations from class_root.h to -inl.h .\n\nMake it possible to include the definition of enum ClassRoot\nwithout pulling in a lot of other headers.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nChange-Id: Ic90fdd70bfe0c5428a5c9a0d7901ea7e15b03488\n" }, { "commit": "b6f4c79b06bb97651a7be1ac828d18ed18356603", "tree": "ef0bbb1281f6d4785e60f26cb420646c83eb6f6d", "parents": [ "3971661c74a9b4635d9744f72f3b053c820067c9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 04 15:37:29 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 05 08:05:24 2020 +0000" }, "message": "Clean up Constructor/Method/Field construction.\n\nSimplify the code by ignoring active transactions. Writing\nto fields of a newly allocated object does not need to be\nrecorded as aborting the transaction removes all references\nto the new object and it\u0027s unnecessary to roll back writes\nto unreachable object\u0027s fields.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nChange-Id: Ib5cd60c003d2ad3e6a246ff86d6b9288428c60ee\n" }, { "commit": "b68bb7a02ea795fa4defb18b3f9ce31879d66271", "tree": "2aa9d13f36a5ae1625f520c397fae62fbcb155e6", "parents": [ "dc9d6a0740982a6b1eab5f3c580d8825cc9ced9c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 17 10:55:25 2020 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Mar 18 09:59:29 2020 +0000" }, "message": "Fix compiling boot image extension with assume-verified.\n\nThe change https://android-review.googlesource.com/1246288\nenabled AOT initialization of classes for the compiler\nfilter \"assume-verified\". However, this was untested and\nbroken because aborted transactions would leave created\narray classes with partially rolled-back state on the heap.\nNote that for other compiler filters, the verification step\ncreates those array classes outside of a transaction.\n\nWe fix this problem by making sure that the initialization\nof an array class does not create any transaction records\nfor the class fields (we are keeping the defined class).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: adb root \u0026\u0026 \\\n adb shell stop \u0026\u0026 \\\n adb shell setprop dalvik.vm.boot-image \\\n \u0027boot.art:/nonx/boot-framework.art!/system/etc/boot-image.prof\u0027 \u0026\u0026 \\\n adb shell setprop dalvik.vm.image-dex2oat-filter \\\n assume-verified \u0026\u0026 \\\n adb shell start # Starts correctly.\nTest: Extract the boot image extension compilation command\n from the verbose log, change compiler filter to\n \"assume-verified\" and execute with no crashes.\nBug: 119800099\nChange-Id: Id57a01af0a015c75a16eea12fd19599ae76ce49a\n" }, { "commit": "270db1ce48377e3d9ca0c3dcec834ac807ca885b", "tree": "ffc553c6ff1ad37bdc3caca01ad686fa41ca0688", "parents": [ "42b9c19772542457701d5efea26aae4449dec8c7" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Dec 03 12:20:01 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Dec 11 18:46:44 2019 +0000" }, "message": "Revert^4 \"Allow structural redefinition on non-final classes.\"\n\nThis reverts commit 664999a12d6fc8a8ef5c0519b12ec1e8a51bb085.\n\nFixed issues with GC and quickened instructions in parent CLs.\n\nReason for revert: Fixed issues with GC CHECK fail and device SEGVs.\n\nTest: ./test.py --host\nTest: ./test.py --target\nBug: 134162467\nBug: 144168550\nChange-Id: Ibacddaf45beb72184f97d53d5d048bd442578658\n" }, { "commit": "664999a12d6fc8a8ef5c0519b12ec1e8a51bb085", "tree": "f4ae1b0844ac075807229db9695ead7dec07ff8a", "parents": [ "642af13b1b14794d8ab0db5cc82206213e648fa1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 03 08:47:26 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Dec 03 08:47:45 2019 +0000" }, "message": "Revert \"Revert^2 \"Allow structural redefinition on non-final classes.\"\"\n\nThis reverts commit f1b809ce611e943f926fff97cefe0930226ffcc2.\n\nReason for revert: Tests still fail\n\nBug: 134162467\nBug: 144168550\nChange-Id: Icdebc826b8630920b716afbfd6f338a29669fcc2\n" }, { "commit": "bc19b7559e887310664a4c86ad3eb3b47749b087", "tree": "820961050c6904f89d9bfe67f8b936f2a5ec9d9c", "parents": [ "0a19e212e56fc6fe2809b58072ddcf4acfdc568d" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Dec 02 18:54:13 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Dec 02 20:35:34 2019 +0000" }, "message": "Revert^2 \"Make opaque-jni-ids:swapable more efficient\"\n\nThis reverts commit 42c52f53b3c85b5e3c984bca8eaec2e03893dd2e.\nThis un-reverts commit 4e7dd70e3ee7a25089bed791df8865966cb4b837.\n\nWe were missing some null-checks that caused a null-pointer\ndereference to occur if one tried to get a jmethodID for an obsolete\nmethod when we start with index-ids.\n\nReason for revert: Fixes issue causing failure in art-jit config.\nTest: Manual\nTest: count-fields.py\nBug: 134162467\n\nChange-Id: Ie36c7a4edb70f96655b3b85e5f5eaa6bf47f5cc7\n" }, { "commit": "42c52f53b3c85b5e3c984bca8eaec2e03893dd2e", "tree": "1589dd3831503767b445734c02bf5e9e4abaaa0e", "parents": [ "f1b809ce611e943f926fff97cefe0930226ffcc2" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Dec 02 18:50:16 2019 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Dec 02 18:52:38 2019 +0000" }, "message": "Revert \"Make opaque-jni-ids:swapable more efficient\"\n\nThis reverts commit 4e7dd70e3ee7a25089bed791df8865966cb4b837.\n\nReason for revert: Breaks art-jit column\n\nChange-Id: If1ea54c45f340a06b4601c1c8494b7dd7e8f7bf8\nTest: Manual\nTest: count-fields.py\nBug: 134162467\n" }, { "commit": "f1b809ce611e943f926fff97cefe0930226ffcc2", "tree": "f75675383cf8018f9f333e608df35edbacf1c913", "parents": [ "20b7a9b8aeaf76fc8f3248f211489fd00af73170" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Nov 26 18:52:06 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Dec 02 18:34:20 2019 +0000" }, "message": "Revert^2 \"Allow structural redefinition on non-final classes.\"\n\nWe were incorrectly racing with the rest of the runtime in a couple of\nplaces. First we would return an ObjPtr of a newly defined class after\nholding it over a suspend point. This could lead to DefineClass\nreturning an obsolete class in some cases.\n\nWe also failed to ensure the class-status was synchronized between the\nold and new classes during structural redefinition. This could lead to\na class appearing to go backwards in status.\n\nThis reverts commit 88b1c83080afcb2bfb6f781ded1c90fe8f9eab4d.\n\nReason for revert: Fixed issues causing test failures.\n\nTest: ./test.py --host\nBug: 134162467\nBug: 144168550\n\nChange-Id: I4d0f7718490532f0ef14a9561b8e7000ef292b12\n" }, { "commit": "4e7dd70e3ee7a25089bed791df8865966cb4b837", "tree": "3cd2e8afc92262f0cdf474bcdbddde1723976575", "parents": [ "08d0984bfeaff1a1bc2db2d51ecf45f2867b3bc4" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Nov 25 13:47:01 2019 -0800" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Dec 02 16:57:13 2019 +0000" }, "message": "Make opaque-jni-ids:swapable more efficient\n\n-Xopaque-jni-ids:swapable was rather memory inefficient, allocating an\nentire PointerSizedArray to mark a method/field as having a\nPointer-id. Since normally these will not be used once the JNI id type\nmoves to kPointer this is rather wasteful. By changing to instead have\na single marker object which is used instead of the full PointerArray\nwe can use significantly less memory in common use-cases.\n\nTest: Manual\nTest: count-fields.py\nBug: 134162467\nChange-Id: I224f0810373afef2335fad092eb758f91455f9e5\n" }, { "commit": "88b1c83080afcb2bfb6f781ded1c90fe8f9eab4d", "tree": "e3ee63ccca83c60c5790e51610349889f44daacf", "parents": [ "8e895008a3e2f2813bb46cb0c6bc76884e46e9ac" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Nov 26 14:13:44 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Nov 26 15:55:26 2019 +0000" }, "message": "Revert \"Allow structural redefinition on non-final classes.\"\n\nThis reverts commit c47040d31cbcd8cddd5fadb552b4f0f6c94b5bd0.\n\nReason for revert: Breaks ART tests (see e.g. b/145197371).\n\nBug: 145197371\nBug: 134162467\nBug: 144168550\nChange-Id: Ia8e5788655057e380fc723a38900d26d69cda938\n" }, { "commit": "c47040d31cbcd8cddd5fadb552b4f0f6c94b5bd0", "tree": "50df569420cd6746daadf1487933719d1f86d66b", "parents": [ "dc540dfffb6863177143d024dd6f491775d77585" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Nov 13 09:33:52 2019 -0800" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Nov 26 02:11:19 2019 +0000" }, "message": "Allow structural redefinition on non-final classes.\n\nThis adds support for structurally redefining non-final,\nnon-finalizable classes. The only restriction is that one cannot\nredefine a class at the same time as any of its supertypes, if a\nstructural redefinition is occurring. The structural redefinition may\nnot remove any fields or methods, change the superclass or change the\nimplemented interfaces. Adding new methods or fields, both static or\nnon-static, public, private, protected, or package-private, is\nsupported.\n\nTest: ./test.py --host\nBug: 134162467\nBug: 144168550\nChange-Id: I32e9e854b3e56270170b10e8f5aba9de8f6bfdfa\n" }, { "commit": "f1b18facd1edd6c8652c42085c5432c878507c8e", "tree": "856465341f025debf8a526490c7f00cee06d3694", "parents": [ "2462789806df0281c52fa9bb60fa37fe3ff606b6" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Nov 11 14:22:00 2019 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Nov 11 14:33:19 2019 -0800" }, "message": "Use explicit list of mirrored class when checking CanRedefine\n\nWe were assuming that the ClassRoots contained all the mirror\u0027d\nclasses but this is not the case. Instead we should use an explicit\nlist of the mirror\u0027d classes.\n\nTest: ./test.py --host\nTest: m test-art-host-gtest-class_linker_test64\nBug: 134162467\n\nChange-Id: Idd4c258ee0134e42afd0175b948123ea052704e1\n" }, { "commit": "c2d0c9627b969ba988c8817d1b765b1cb61a61f3", "tree": "be3d4547d2a0a42d4085355383c509b0cb55f587", "parents": [ "0c262edd22824f4465e0cb08879b7eea89d3fac0" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Oct 23 14:14:25 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Oct 28 23:46:26 2019 +0000" }, "message": "Perform reverify with shared mutator-lock.\n\nDespite comments that seemed to indicate otherwise the verifier is not\ncapable of running with a strong mutator-lock in all circumstances.\nSpecifically it relies on being able to allocate exceptions in a\nnumber of situations (for example when a field could not be found but\nthe class could). This could lead to problems when trying to\nreverify a class. To fix this we changed the reverify step to happen\noutside of the strong mutator-lock and instead temporarily mark the\nredefined methods with every verifier fail flag. The new verification\nwill then be performed and the flags reset (after suspending\neverything).\n\nThis also fixes a related issue where performing the verification\nwith an exclusive mutator lock changed how elements in the dex-cache\nwere populated, causing the dex-cache to break invariants about\nmethods always having their classes be present. This could cause\ncrashes in some circumstances (for example test 1990).\n\nTest: ./test.py --host\nTest: go/lem\nBug: 142876078\n\nThis partially reverts commit b1eebde9469914ad634a6dc3746ddfb222595609\nThis partially reverts commit db55a1121b2437765e732c8bbedf914f8a52f624\n\nChange-Id: I0f1e8c47118cc84c8f23c4068944069ac74f5ea3\n" }, { "commit": "b1eebde9469914ad634a6dc3746ddfb222595609", "tree": "c34ad8df86b5c2f3b66e21ecd41352a02f3944d5", "parents": [ "2a21cc6849df474afc63eff21913637c313efdf5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 22 16:30:47 2019 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 22 17:00:09 2019 +0000" }, "message": "Revert^2 \"Class redefinition sometimes needs to update verification\"\n\nWe were incorrectly preventing dex2oat from suspending during\nverification. This caused a major regression in memory use and\ncompilation speed.\n\nThis reverts commit 2cf00ede148bd9d77c291d4c0cb23edd5a9c36b4.\n\nReason for revert: Fixed issue causing AOT slowdown.\nTest: go/lem\nTest: go/lem-allight-unrevert-verify-check\nTest: ./test.py --host\nBug: 142876078\n\nChange-Id: If699f71a06818856358859ed5e4e01e0ffc1c1a4\n" }, { "commit": "2cf00ede148bd9d77c291d4c0cb23edd5a9c36b4", "tree": "c59d055e9f611d1e9b7bdd36ce3756cc090b86c7", "parents": [ "776d0015730e1c00c86119a5db2fe606867ae3a7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Oct 22 08:10:44 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Oct 22 08:34:02 2019 +0000" }, "message": "Revert \"Class redefinition sometimes needs to update verification\"\n\nThis reverts commit db55a1121b2437765e732c8bbedf914f8a52f624.\n\nBug: 142876078\n\nReason for revert: up to 10x regressions on vdex-based compilation.\n\nChange-Id: Ib034c02617db2c8e4e15bc386631a612256f0ad4\n" }, { "commit": "db55a1121b2437765e732c8bbedf914f8a52f624", "tree": "9b1be00c3684703e6a062052a634daa859068333", "parents": [ "697fe5cc6ce0e9c72c3681152a99a5d5bab4253c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Oct 17 10:32:47 2019 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Oct 18 15:51:34 2019 +0000" }, "message": "Class redefinition sometimes needs to update verification\n\nIn cases where class redefinition moves a class from having no\nverification failures to having soft verification failures we need to\nupdate the methods with new verification class flags. For example if\na method is modified to have unbalanced monitors we need to make sure\nthat future invokes of that method count locks and use the\ninterpreter.\n\nPreviously we would simply keep the same verification state as the\noriginal implementation, causing us to try to compile in situations\nthe compiler cannot handle or leave monitors in inconsistent states.\n\nTest: ./test.py --host\nBug: 142876078\nChange-Id: I8adf59158639bdf237d691b20fad223f0a34db1f\n" }, { "commit": "4ac0e1571e015a01d75091c3daef065f9624ad77", "tree": "4d13edeab88bd6fd724388c48385b0c3cca4f3a8", "parents": [ "5a2301d897294ff4ee6de71f459dc2566dc3fa1a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:14:50 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:14:50 2019 +0000" }, "message": "Revert \"Revert \"Basic structural redefinition support\"\"\n\nThis reverts commit 5a2301d897294ff4ee6de71f459dc2566dc3fa1a.\n\nBug: 134162467\n\nReason for revert: Relanding as unclear if issue is due to topic.\n\nChange-Id: Ib1d1cf2e9132e30c9649b760ae9ae2d8ceacf843\n" }, { "commit": "5a2301d897294ff4ee6de71f459dc2566dc3fa1a", "tree": "2bd06ab3f463734994b3d251f6115514520dbb3f", "parents": [ "4eb6eb40e88214fcc874d93e75660cb580cb4d58" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:11:22 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:12:13 2019 +0000" }, "message": "Revert \"Basic structural redefinition support\"\n\nThis reverts commit c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c.\n\nBug: 134162467\n\nReason for revert: Breaks on redefine-stress\n\nChange-Id: I4e38da23d65b5b34b26b5ab537a3583328e078a4\n" }, { "commit": "c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c", "tree": "f8647487e7465712fd73118ceb89e13167a12648", "parents": [ "1ba7e8c10af4e270864a417044244d63db53ccf5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 13 10:50:38 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Sep 17 23:52:12 2019 +0000" }, "message": "Basic structural redefinition support\n\nThis adds basic support for adding methods and fields to already\nloaded classes using redefinition. This \u0027structural class\nredefinition\u0027 is currently limited to classes without any virtual\nmethods or instance fields. One cannot currently structurally redefine\nmultiple classes at once nor will structural redefinition trigger the\nstandard redefinition events.\n\nAfter structural redefinition all references to the old class, and its\nfields and methods are atomically updated. Any memory associated with\nthe static fields of the old class is zeroed. Offsets for field access\nmight change. If there are any active stack frames for methods from\nthe redefined class the original (obsolete method) code will continue\nto execute. The identity hash code of the redefined class will not\nchange. Any locks being held, waited or blocked on by the old class\nwill be transferred to the new class.\n\nTo use this feature the process must be debuggable and running with\n-Xopaque-jni-ids:true.\n\nFor device testing use a wrap.sh that adds the following flags:\n\n \u0027-Xopaque-jni-ids:true -Xcompiler-option --debuggable -XjdwpProvider:adbconnection\u0027\n\nStructural redefinition only available using the\n\"com.android.art.UNSAFE.class.structurally_redefine_class_direct\"\nextension. This will not trigger the normal class-redefinition events.\nOnly one class may be redefined at a time.\n\nNB There are still some holes in this potentially allowing obsolete\nmethods/fields to be visible. Most notably during jni-id, MethodHandle\nand VarHandle creation as well as potentially other places in the\nruntime. These holes will be closed by later CLs. Until then the\nextension to access structural class redefinition will remain tagged\nas UNSAFE.\n\nTest: ./test.py --host --all-compiler\nBug: 134162467\n\nChange-Id: I825d3a4bdb9594c0147223ae69f433ce9bbfc307\n" }, { "commit": "422a9ebc5b9d780a3201243f02b58652b44d9896", "tree": "4fcd6abe72d70358d7bf6235266ab685b61678a1", "parents": [ "9f18fbc433bba51a5b81249989a8726558135528" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 01 12:54:07 2019 +0100" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 01 16:54:29 2019 +0000" }, "message": "Do not hold lock when making class visibly initialized.\n\nDoing so can lead to deadlocks.\n\nBug: 138561860\nBug: 36692143\nTest: New test 177-visibly-initialized-deadlock\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nChange-Id: I6195a4a5a7d865f90c529da684697b9a3e23ff30\n" }, { "commit": "8e1106587f0273116302afe06956129b5d82784a", "tree": "e1869e8da9ab9a6bfdf89a34f4e8cedd44045005", "parents": [ "5a11036542fbd2c00de1896c0ae2477f655e8ed3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 30 10:14:41 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 01 08:35:08 2019 +0000" }, "message": "Use ClassStatus::kVisiblyInitialized for allocations.\n\nAnd move the \"intialized but not visibly initialized\" check\nto ClassLinker::EnsureIntialized().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nBug: 36692143\nChange-Id: Ib5e19326b1149b2aef586b905ce89470c3a8e405\n" }, { "commit": "f3677471a58c2738a3d9dd05f07f01c18a5e61be", "tree": "21b4279c1077e051b84aad12da29240672f54913", "parents": [ "f1468b53d0427a45011fe6446d189babe0acd6e0" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jun 26 16:31:53 2019 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Jul 29 22:22:53 2019 +0000" }, "message": "Add ability to switch to index ids late.\n\nIn order to support some debugging features we need to have JNI code\nmostly running with jmethodIDs and jfieldIDs as opaque indexes\ndisconnected from any underlying art data-structure pointers. For\nperformance though we want to continue to use data-structure pointers\nas these IDs when debugging is not needed. To support both\npossibilities this adds support for changing from a \u0027swapablePointer\u0027\nto either \u0027pointer\u0027 or \u0027indicies\u0027 regime at runtime.\n\nThe SwapablePointer regime still uses pointers as the ids but creates\nthe data-structures needed to ensure that we can (1) detect that the\nmethods have pointer-type IDs and (2) we can change some\nWellKnownClass internal IDs from one to the other.\n\nCurrently one must select this mode explicitly using\n\u0027-Xopaque-jni-ids:swapable\u0027. Depending on when the final jni-id-type\nis selected a small amount of extra memory is used. Currently manual\ntesting of turning the default id-type to swapable and changing to\npointer immediately after zygote-fork shows a additional 40-90 kb of\nshared zygote-heap memory.\n\nTest: ./test.py --host\nTest: m libfieldcounts; \\\n ./tools/jvmti-agents/field-counts/count-fields.py \u0027Ljava/lang/Class;.extData:Ldalvik/system/ClassExt;\u0027 \u0027Ldalvik/system/ClassExt;.jmethodIDs:Ljava/lang/Object;\u0027 \u0027Ldalvik/system/ClassExt;.staticJfieldIDs:Ljava/lang/Object;\u0027 \u0027Ldalvik/system/ClassExt;.instanceJfieldIDs:Ljava/lang/Object;\u0027 -p `adb shell pidof com.android.deskclock`;\n Examine output\nBug: 134162467\n\nChange-Id: I1885b10056d5dcc65dad5ae4f858ddc12ba79403\n" }, { "commit": "bf12191214c0d6215a98dfe846a51230d995dad9", "tree": "085c1059014ce66fdb7eceb6e8502d906f0eacbd", "parents": [ "78342419743cb6d0f17dc2d4c0cd99d18d9c83d6" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 04 13:49:05 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 26 11:10:26 2019 +0000" }, "message": "Implement ClassStatus::kVisiblyInitialized.\n\nPreviously all class initialization checks involved a memory\nbarrier to ensure appropriate memory visibility. We change\nthat by introducing the kVisiblyInitialized status which can\nbe checked without a memory barrier. Before we mark a class\nas visibly initialized, we run a checkpoint on all threads\nto ensure memory visibility. This is done in batches for up\nto 32 classes to reduce the overhead.\n\nAvoiding memory barriers in the compiled code reduces code\nsize and improves performance. This is also the first step\ntoward fixing a long-standing synchronization bug 18161648.\n\nPrebuilt sizes for aosp_taimen-userdebug:\n - before:\n arm/boot*.oat: 19150696\n arm64/boot*.oat: 22574336\n oat/arm64/services.odex: 21929800\n - after:\n arm/boot*.oat: 19134508 (-16KiB)\n arm64/boot*.oat: 22553664 (-20KiB)\n oat/arm64/services.odex: 21888760 (-40KiB)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots\nTest: run-gtests.sh -j4\nTest: testrunner.py --target --optimizing\nTest: Manually diff `m dump-oat-boot` output from before\n with output after this CL without codegen changes,\n with `sed` replacements for class status. Check that\n only checksums and the oatdump runtime values of\n DexCache.dexFile differ.\nBug: 18161648\nBug: 36692143\nChange-Id: Ida10439d347e680a0abf4674546923374ffaa957\n" }, { "commit": "70e2a7694b1d9aa926e1ff05c541574d1d89a28c", "tree": "aefc1b15d28cacd17f61d18a4bcbe341b043effa", "parents": [ "da40acad8760aacd4bc3b636fbdb5f8107d3e00f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 12 16:49:00 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 23 08:35:23 2019 +0000" }, "message": "Initialize array classes in pre-fence visitor.\n\nRewrite array class initialization to make it easier to\nreason about memory visibility. Initialize all members in\nthe pre-fence visitor for the normal use case. Refactor\ninitialization of core array classes without boot image to\navoid special-casing in ClassLinker::CreateArrayClass().\n\nNote that the Class::object_size_alloc_fast_path_ field\nof primitive classes (instances of which cannot be\nallocated) will be kept at numeric_limits\u003cuint32_t\u003e::max().\nThe boot image before and after is otherwise identical.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nTest: run-gtests.sh\nTest: testrunner.py --target --optimizing\nChange-Id: I570e3af011c8d3383ce46c81eb6f2fa60c5a4b0f\n" }, { "commit": "bb5b4f35e7d4cfddb9aedb4f2ea35b017650cd58", "tree": "c62934250a5e74f1d194eeefa9bc8c7c9ee03131", "parents": [ "4a30f89d65efa9b85c34bbd7aa23ea4cd38b920d" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 09 02:31:48 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Jul 10 15:54:45 2019 +0000" }, "message": "Revert \"Disable opaque JNI Ids for now.\"\n\nWe were incorrectly using a potentially out-of-date pointer to access\nclass object fields. This could cause segvs if the class object moves\nduring certain allocations relating to JNI id allocation.\n\nThis reverts commit 1be9c72dd49e7620dd76a8b9cef23d7cde0a6b01.\n\nReason for revert: Fixed issue with gcstress\nTest: ./test.py --host --debuggable --gcstress\nBug: 134162467\n\nChange-Id: I6ee7fc4485bbae6f0f1d4f4af0e8c2bc88bf4075\n" }, { "commit": "79d6c800cd8aa1da335ea0523c391852780ac02a", "tree": "a77faf41d7b658709113c72d7eaaaa1ce2ded6b5", "parents": [ "01fbfbebceb00b94cc54738ebf425b6c4a79211a" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jun 27 15:50:11 2019 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jun 28 14:58:17 2019 +0000" }, "message": "Revert^2 \"Support using opaque JNI ids\"\n\nWe weren\u0027t handing the fact that encoding jmethodIDs could cause OOM\nexceptions in some places in reflection.cc. This could lead to\nattempting to use a null jmethodID as if it were a real id. This issue\nis fixed by the parent CL.\n\nThis reverts commit b476a29a2c.\nThis reverts commit 3b2905366c.\nThis Unreverts commit d5d645ffec.\nThis Unreverts commit 21d5994583.\n\nReason for revert: Fixed issue causing 004 debuggable flakes\nTest: ./test.py --host --jit --debuggable\nBug: 134162467\n\nChange-Id: Iece08ab299cd8a20f8382be7be6c3796858e70eb\n" }, { "commit": "b476a29a2cda22b86fc1d96e4cc65ce36fb878af", "tree": "039eaee2edf5495275088d1c467e522977c6bcd6", "parents": [ "3b2905366c6ee1eaba2d6477078e505e377343ec" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 27 07:54:48 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 27 08:16:04 2019 +0000" }, "message": "Revert \"Support using opaque JNI ids\"\n\nThis reverts commit 21d5994583c679cd5d8573b5d35dbd659bdca2c7.\n\nBug: 134162467\n\nReason for revert: Breaks debuggable\n\nChange-Id: I9510a6ac208d392ff25ee196a1a519fecd151445\n" }, { "commit": "21d5994583c679cd5d8573b5d35dbd659bdca2c7", "tree": "521906398a2f04048cc51b4f409b6a3ebc0c6ffa", "parents": [ "5dfbe7ae9ed9a1a82446d32118190105a211a2d2" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jun 19 12:58:22 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Jun 26 20:22:39 2019 +0000" }, "message": "Support using opaque JNI ids\n\nCurrently JNI ids (jmethodID \u0026 jfieldID) are created by simply\ncasting the corresponding ART structure pointer. This is great for\nsimplicity but means we are prevented from performing operations that\ncould change these pointer values. To support these use-cases add\nsupport for loading the runtime with a layer of indirection between\nthese ids and the internal art data types.\n\nCurrently the JNI id type can be toggled only by passing the new\n\u0027-Xopaque-jni-ids:{true,false}\u0027 flag during startup.\n\nThis changes the --debuggable test configuration to pass\n\u0027-Xopaque-jni-ids:true\u0027 in order to get test coverage of this feature\nusing the \u0027art-jit\u0027 configuration.\n\nTest: ./test.py --host --debuggable\nTest: ./test.py --host --debuggable --jit-on-first-use\nTest: ./test/testrunnner/run_build_test_target.py art-jit\nBug: 134162467\nChange-Id: Id8c8cb9a5b8ff18dc2f40892fae2d344a7214f44\n" }, { "commit": "3068d582eff4552ff260d7966fcbdc93e17d0207", "tree": "bc894a414070a06ea2a231fb98607b57b8c3b0cb", "parents": [ "991cd5cc16267b74e390f640eb441102062babb6" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 28 16:39:29 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 31 14:15:59 2019 +0000" }, "message": "Clean up creating handles from `this`.\n\nMake these member functions static and take an additional\nparameter `Handle\u003c.\u003e h_this`. Callers mostly already have\na Handle\u003c\u003e to pass, so we avoid an extra StackHandleScope.\nThis pattern was already used for some functions.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --interpreter\nChange-Id: I4f4478b0526bcb2f3c23305d3b3cc4a65fff9ff5\n" }, { "commit": "991cd5cc16267b74e390f640eb441102062babb6", "tree": "d6112197d0bfec05d5a66da2b27578504385b9f5", "parents": [ "78da5e255d1281412e9f7e4f0c9b4e90ba7f02b5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 30 14:23:39 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 31 14:15:59 2019 +0000" }, "message": "Add default template args to Heap::Alloc*Object*().\n\nNamely kInstrumented\u003dtrue and kCheckLargeObject\u003dtrue.\n\nThis is a follow-up after\n https://android-review.googlesource.com/963693\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I6c23e76f90f1892382c3bb8c331d12437bc23f89\n" }, { "commit": "abdb4592fa28d6e75f1160f01cde58ad7c3fef37", "tree": "e887df0046489008f318fce65909ab0535aa386c", "parents": [ "639e73b5ad1d96a1e67743735a13f7a268b455aa" ], "author": { "name": "Eric Holk", "email": "eholk@google.com", "time": "Thu May 16 08:33:12 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon May 20 19:35:19 2019 +0000" }, "message": "Use string length from DEX instead of recomputing\n\nThis gives around a 2% improvement in startup time overall. Here are results from a selection of\napps:\n\ncom.android.gallery3d/.app.GalleryActivity: 203.2ms → 197.7ms (change: -5.4ms, -2.7%)\ncom.android.messaging/.ui.conversationlist.ConversationListActivity:\n 202.1ms → 199.1ms (change: -3.0ms, -1.5%)\ncom.android.contacts/.activities.PeopleActivity: 277.3ms → 270.7ms (change: -6.6ms, -2.4%)\ncom.android.camera2/com.android.camera.CameraLauncher:\n 351.7ms → 344.1ms (change: -7.7ms, -2.2%)\ncom.android.dialer/.main.impl.MainActivity: 259.5ms → 254.2ms (change: -5.3ms, -2.0%)\ncom.android.settings/.Settings: 189.0ms → 186.5ms (change: -2.4ms, -1.3%)\ncom.android.email/.activity.Welcome: 222.8ms → 219.3ms (change: -3.6ms, -1.6%)\norg.mozilla.firefox/.App: 370.2ms → 358.3ms (change: -11.9ms, -3.2%)\n\nThis is the average of 100 runs on a Pixel 2 XL.\n\nBug: 132691958\nTest: device boots, start app many times\nChange-Id: I93b6eb5105e32788cfc8159c6c21b400a161f86c\n" }, { "commit": "d355acfaf613d4020f1c2f4b526275c624fe887a", "tree": "c40094e3a866cdc27426c713108a67e5eda260b9", "parents": [ "df1a7d458e3f4b5410562e7d86a3343155a44ce0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 21 17:09:40 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Apr 03 08:07:46 2019 +0000" }, "message": "Clean up Object size related read barriers.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --interpreter\nTest: testrunner.py --host --interpreter --gcstress\nBug: 119486698\nChange-Id: I831838f230ebdd9e540462b2de56271895a01fad\n" }, { "commit": "58412b1f6c6c1fb1f212dd4e2cb442541fc91df5", "tree": "d0da00907ee46faec095c9f2bd62b83da3d99000", "parents": [ "dfc0de7696a50a9aeee95dcf74dac036e3334314" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Apr 01 13:26:34 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Apr 02 07:57:27 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify DexCache.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ic4747928255afca61aca6802e7fec0585c6c1226\n" }, { "commit": "d7e9bbf092b5a61048358fd54183526ef12284af", "tree": "620cee17c499bdb23217224b0b1332408d725a6e", "parents": [ "bb206de72135271e66e58576b1196f3e08d5b6fd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 28 13:18:57 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 29 09:50:00 2019 +0000" }, "message": "Clean up explicit conversions to ObjPtr\u003c\u003e.\n\nAdd an ObjPtr\u003c\u003e::DownCast() overload that takes a plain\npointer and remove unnecessary calls to MakeObjPtr(),\nusually preceding DownCast(). Move the MakeObjPtr() to\ncommon_art_test.h .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I2a243b6d8f3b2e773396dfc53b659c5f7d9ea44a\n" }, { "commit": "c524e9e7e767be0801cf110310039635698c1532", "tree": "cd11699dce8c175a0940a583f5ea02ce89f73a85", "parents": [ "2e1ec835d08ca0ab81b1c24436f659f952ace260" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 26 10:54:50 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 26 17:06:55 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify mirror::Class.\n\nAnd move function definitions that rely on obj_ptr-inl.h\nfrom class.h to class-inl.h .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I5ccc765d0a02b1d37cb39ed68c17b8456faf92ea\n" }, { "commit": "179b7c61ea6769b99f70c80a7a89cbb212423ec2", "tree": "06130898bfb2d8c3f71f4fe181277f20e1942726", "parents": [ "c8b7d445e02b752a68d824e2bc69658dfb76288a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 22 13:38:57 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 25 16:54:37 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify String allocations, fix stale refs.\n\nObjPtr\u003c\u003e-ify String allocation functions and related code\nand remove some unnecessary calls to ObjPtr\u003c\u003e::Ptr(). Fix\nstale reference uses in reference_table_test and stub_test.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I42927fb8b7240e5132188f73318b2ccb218748fd\n" }, { "commit": "3892e628ac617878251fa3c5e689ad661de0e289", "tree": "36268e3ce03b217728d16f85b78a4923adf5ea55", "parents": [ "bfaba288427e80e7941e49c4264ba8f6cd6d97d1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 15 15:22:18 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 18 09:51:37 2019 +0000" }, "message": "Clean up Class::GetDescriptor().\n\nPull in helper functions Class::GetArrayDescriptor() and\nClassLinker::GetDescriptorForProxy(), avoid deep recursion\nfor multidimensional arrays and avoid a read barrier for\nGetName() for proxy classes.\n\nAlso avoid recursion in Class::DescriptorEquals().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I04201294434a00eb2f91c66403af45f715941be4\n" }, { "commit": "eb37ba594146338bf7e7e2bf3769d08046fb263f", "tree": "7fac104aed3aec8d8390c8cbe1f7fbd85b4f998a", "parents": [ "e027d727b833930f1bd0029bc1b2cf750d8af5da" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 05 14:10:38 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 06 12:24:10 2019 +0000" }, "message": "Replace StringPiece with std::string_view in Signature.\n\nAnd also in Signature-related code. Remove the function\nDexFile::CreateSignature() which was used only in a test\nas the test can use method searching functions that take\nstd::string_view instead.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 123750182\nChange-Id: I3f24c8f4f677e2e40503dbab347df1eb031b4132\n" }, { "commit": "e027d727b833930f1bd0029bc1b2cf750d8af5da", "tree": "0bb05206b8c019798bd3ffede02fb9243d08e615", "parents": [ "ac52000e86077b3c45c192ec259d72413599ff11" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 05 10:13:49 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 06 11:56:16 2019 +0000" }, "message": "Replace StringPiece with std::string_view in class.h.\n\nTranslate the std::string_view to StringPiece where\nneeded for comparing with Signature until we change\nthe Signature::operator\u003d\u003d() to take std::string_view.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 123750182\nChange-Id: I9699f13882353d84dc69e6b8e30d12dac4bace24\n" }, { "commit": "4bcd65753c1e49ceba2c41983f26af81ae319670", "tree": "3fc7bd53d37448621726dc508f173490807af9c7", "parents": [ "2da3cbb4af20a64108e474c0bbbe0cc5d3af2aa2" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Sat Feb 02 20:08:44 2019 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Feb 04 15:00:20 2019 +0000" }, "message": "Take hidden API into account during getDeclaredMethod()\n\nGenerics make it possible for two methods to have the same name and list\nof parameters but differ in their return type. Class.getDeclaredMethod()\ndoes not allow callers to specify the type, so either of the matching\nmethods can be returned (ART will prefer the non-synthetic one).\n\nHowever, Class::GetDeclaredMethodInternal() did not use to take hidden API\ninto account and could return a hidden method, despite a non-hidden one\nbeing available. The reflective call would then reject the method and\nthrow NoSuchMethodException.\n\nThis patch modifies Class:GetDeclaredMethodInternal() to consider:\n(a) hidden/non-hidden\n(b) virtual/direct\n(c) synthetic/non-synthetic\nin that decreasing order of importance and pick the best matching\nmethod. The hiddenness checks are performed with AccessMethod::kNone\nso as to not trigger warnings. A hidden method may still be returned and\nthe caller should do the access check again with the appropriate\nAccessMethod.\n\nBug: 122291025\nTest: art/test.py -r -t 690-hiddenapi-same-name-methods\nChange-Id: Iaee780c1e87f5587f51e24b517b2b37101c729e3\n" }, { "commit": "ad1aa6340567c0660506069d760ff41483eb3821", "tree": "dbceabc90859e9353a8683d8be02a702205be9c9", "parents": [ "b8bca301eff0db87d37bc4ab898a4973d211019b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 02 10:30:54 2019 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jan 03 09:19:10 2019 -0800" }, "message": "ART: Move Signature to its own header\n\nReduce the dependencies on dex_file.h\n\nBug: 119869270\nTest: mmma art\nChange-Id: I1450fe2c3f4a7f5b535ed38cc19cb8a053228541\n" }, { "commit": "3f1dcd39e134d994ac88dcc4f30ec8cabcd8decf", "tree": "365d20ad6b68ff1dbd4903764b63880324136e4d", "parents": [ "0f0a4e40667c87fbd4ae5480eddbfd701bfabfa2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 28 09:39:56 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 02 10:32:25 2019 -0800" }, "message": "ART: Move dex structs into own header\n\nSeparating out the structs from DexFile allows them to be forward-\ndeclared, which reduces the need to include the dex_file header.\n\nBug: 119869270\nTest: m\nChange-Id: I32dde5a632884bca7435cd584b4a81883de2e7b4\n" }, { "commit": "5b20b358edb0c586ae2106a82be365717da82507", "tree": "3cda8d9774087f3f6b80681f18d03c271d113fbf", "parents": [ "62f6e9055363df6b6372d86960e8d987d6c439a1" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 11 19:03:20 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 13 10:52:08 2018 -0800" }, "message": "ART: Rewrite EnsureInitialized hit case\n\nWhen an initialized class is found during EnsureInitialized, do\nnot check whether verification was attempted and fix up bits.\nInstead, ensure that all class-loading paths have that done\nwhen eventually getting here.\n\nSpecial runtime-constructed classes (primitives, arrays, proxies)\nneed code to do this work. \"Normal\" classes have the work done\nduring VerifyClass.\n\nLeave a DCHECK in as a state check. Protect state transfers with\nadditional checks.\n\nThis reduces the overhead of the interpreter which cannot elide\ninitialization checks for static accesses.\n\nBug: 115834172\nTest: m test-art-host\nChange-Id: Iacd6652583364509c37eafe81fed1198abb1b71a\n" }, { "commit": "62f6e9055363df6b6372d86960e8d987d6c439a1", "tree": "189957252780e2d61aa0d5ef874db5794805d39b", "parents": [ "81c61bf0ef90c1fd79694aab49758e16cd0dd044" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Oct 11 18:58:50 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 13 10:52:08 2018 -0800" }, "message": "ART: Add integrity check\n\nAdd access-flags setter DCHECK code similar to the getter. For now,\ncheck that the verification-attempted flag is not removed.\n\nBug: 115834172\nTest: m test-art-host\nChange-Id: Ia1027126b2ff1a2a2e3c26f674a5f8dc8d2f0c0a\n" }, { "commit": "bc1e0fab934b7fb03545f08085b109d6508b17d0", "tree": "87048ec7cccd78f9819ba16d95539a8deae51659", "parents": [ "0bcbe9399dfc546db5c81b13979afc85da19d025" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 14 16:18:18 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 14 16:40:48 2018 -0800" }, "message": "Reduce class loader updating overhead.\n\nAvoid unnecessary read barrier for comparing class loader agianst\nnull. Avoid transaction check.\n\nDeleted the helper class to simplify the code.\n\nThe time goes from ~3.8ms to ~2.9ms on Maps.\n\nTest: test-art-host\nBug: 116052292\n\nChange-Id: I4a966a9bb39400ba58d7cf3e0b2c8ab4747d65ed\n" }, { "commit": "39d8c873645df7c956bf306693d95212d1d51906", "tree": "84bdfb98c931343b507c19a8149c84ba48a0c7b1", "parents": [ "1e152a6090c546f4a6184a5610c85cae7ac77068" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Nov 01 16:44:20 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Nov 01 19:28:17 2018 +0000" }, "message": "Optimize string comparisons in Class::FindClassMethod.\n\nThe method is relatively hot in non-quickend code.\n\nAvoid full string comparisons by comparing the unicode lengths first.\n\nTest: ./art/test.py -b -r --interpreter --host --64\nChange-Id: Ib0aa7008ca36e3916967fe082948d16823b93e02\n" }, { "commit": "e15b9b189a0898b5554002d9c86da7c17f2eb7ae", "tree": "b9d484bb6aed03f8d1435d52c6ae1cfbf3702368", "parents": [ "72d3493a6b9fde2fc3c1abb9ee6afff4451ec291" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 29 12:54:27 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Oct 29 13:05:18 2018 -0700" }, "message": "ART: Do some include-what-you-use\n\nHelp with transitive includes. In preparation for new\nspecialized headers reducing transitivity.\n\nBug: 118385392\nTest: mmma art\nChange-Id: Ie79afda4e09191428c2b4c2f20a7e3352c01c1e9\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "a9746b90635f26ebc2340f01e6d3da7700593dbc", "tree": "4d391782c8805a22500bd8306fe8a90d16d6702f", "parents": [ "cca7cb9ffa56d8ab8fd0c5997c8bfd965d7426c1" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jun 22 10:25:40 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 25 08:34:54 2018 -0700" }, "message": "Refactor Object CAS with and without write barrier\n\nRemoves duplicated logic.\n\nTest: test-art-host\n\nChange-Id: I1f5df417c59312f224e0a448c7bd6358912bba07\n" }, { "commit": "c13fbd8596988f1daf71197008007c2eaa380585", "tree": "4c02277989abc7ac1081698269504ab329ddab8f", "parents": [ "026105570d8fcd4b3cb60c3d6b7bb7141cd8146c" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 04 16:16:28 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 04 18:33:38 2018 +0100" }, "message": "Use pre-allocated Throwables from the boot image.\n\nThe pre-allocated OOMEs and NoClassDefFoundError were stored\nin the boot image but they were not used, we instead used to\nallocate and use new objects. This change adds references to\nthe image roots, so that these Throwables can be used when\nstarting the runtime using the boot image.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 77947463\nChange-Id: I2079344dee61242bf0bef5c32770c33ac8a6b7a4\n" }, { "commit": "18090d118bfb04620aeef719e2d7780c26298bf8", "tree": "040e5195f0278c9bc846d5543c0e36771ffc5b48", "parents": [ "9ddef18ae95859a985e7a0de7e22999fcbc28e07" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 01 16:53:12 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 04 17:52:35 2018 +0100" }, "message": "Refactor String resolution.\n\nUse the same pattern as type resolution and avoid some\nunnecessary read barriers in the fast path. Consolidate\nnaming between ArtField and ArtMethod.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: Iea69129085f61f04a4add09edd0eadbb7ac9ecb2\n" }, { "commit": "a5359a3bf47c4b086fe717ae35dfa6be779824bd", "tree": "08e786e30b2d1fbe886c688b5545cff9906b057f", "parents": [ "22bd3c969533986640e17e20f38975b22f30af1c", "317892b756cd2a87c01928b09e99e020c86dea10" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jun 01 09:55:34 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 01 09:55:34 2018 +0000" }, "message": "Merge \"Remove static GcRoot\u003c\u003es from Class and ClassExt.\"" }, { "commit": "ed7f95d6e9d3286c2a7691102732504ffb19c51e", "tree": "ee46343b9a11c50d669f7120865dcf6848c43fda", "parents": [ "1539a11150ca9c28fec353b38508267c41d7814b", "d32ead213f01c16c3ddd7c7a33c0f0d259e4c4dc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 31 13:47:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu May 31 13:47:48 2018 +0000" }, "message": "Merge \"Aesthetic changes in art::mirror::Object and art::mirror::Class.\"" }, { "commit": "317892b756cd2a87c01928b09e99e020c86dea10", "tree": "bb337ff8cd81c049e781afbd8c68b72ca30907fc", "parents": [ "1539a11150ca9c28fec353b38508267c41d7814b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 11:11:32 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 13:56:49 2018 +0100" }, "message": "Remove static GcRoot\u003c\u003es from Class and ClassExt.\n\nAnd clean up gc_root includes in runtime/mirror/.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ib5c42a3a892ced4440720350a63a94bcf3a1ca75\n" }, { "commit": "d32ead213f01c16c3ddd7c7a33c0f0d259e4c4dc", "tree": "bb68a6355872dadaa1e7f56a224cda40d77f0738", "parents": [ "08231f6cb3095a7dbde29299a7da5413a5f992e4" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed May 30 17:38:21 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 31 12:46:40 2018 +0100" }, "message": "Aesthetic changes in art::mirror::Object and art::mirror::Class.\n\nTest: mmma art\nChange-Id: I1c7bf2e3b0420238ee2ae249aca9b7fce492a3e6\n" }, { "commit": "acb906d7f907b79ef1e6038d7104a5569e81a1ac", "tree": "5004be84fa88b8829881efed9ebf2d578b21086f", "parents": [ "5924a4a73f1a2dcf83877062d67c297a9496b326" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 10:23:49 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 14:48:02 2018 +0100" }, "message": "Remove mirror::String::java_lang_String_.\n\nAnd simplify ClassLinker::InitWithoutImage().\nAnd finish ObjPtr\u003c\u003e-ification of annotation processing.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 31113334\nChange-Id: I882a6c2f2b2a88d6ba34e4759bac4a6caa54cafa\n" }, { "commit": "5924a4a73f1a2dcf83877062d67c297a9496b326", "tree": "3517a1809ecbdc85533e1a8c5a0a9610cdc36005", "parents": [ "2cffc5d2807096c0b7a07b89f5dda6920c6429f5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 29 17:40:41 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 30 12:50:37 2018 +0100" }, "message": "Move String::SizeOf\u003c\u003e to string.h .\n\nstring.h was already indirectly (through class.h) including\neverything needed for String::SizeOf\u003c\u003e, so move it to the\nstring.h and make those includes direct. Then we can change\nthe object-inl.h to include only string.h, reducing the\nnumber of indirectly included files.\n\nTest: m test-art-host-gtest\nTest: m testrunner.py --host --optimizing\nChange-Id: I51c462c034f205498c539abe6d888be9738d4a6e\n" }, { "commit": "b4eb1b19e1dd35d12a408358656c1421f507d231", "tree": "03ba65d206b5e6222dcca0f62a973bcbb1bf8a50", "parents": [ "ff7ff426e136aa8fd6e33d873f6259311982f6bb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 24 11:09:38 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 25 11:32:31 2018 +0100" }, "message": "Refactor ClassRoot/GetClassRoot().\n\nMove it outside the ClassLinker, into its own header file,\nand add retrieval based on a mirror class template argument.\nKeep the SetClassRoot() as a private member of ClassLinker.\n\nMake the new GetClassRoot()s return ObjPtr\u003c\u003e.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Icbc6b62b41f6ffd65b437297a21eadbb0454e2b7\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "b2ec9f5c128673c43f776cbe12c8eeb0a6884ebb", "tree": "724022162a4f3de021cebab32ee5ac67ec860f32", "parents": [ "f13343eb8b2738e2812fd7bd9d5592f529e93c21" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:20:31 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:51:15 2018 -0800" }, "message": "Remove duplication, split tests\n\nThe code move to libdexfile/dex/descriptors_names.cc apparently did not\nremove the original code from runtime/utils.cc. Fix that duplication\nand all the header mentions needed. Also, split the test files to go\nalong with the new locations for the code to be tested.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n flash \u0026 boot marlin\n\nChange-Id: Ie734672c4bca2c647d8016291f910b5608674545\n" }, { "commit": "7287c4d75e38e7a01c7ea3fdebb47d9cfe128a56", "tree": "2b43d1b334e05e1c5719fee3f2a16bebaff059d9", "parents": [ "1efa7cb8c415f4df8a248242cd773a1fc671878e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 15 10:41:07 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 15 15:36:21 2018 +0000" }, "message": "Add Class.getPrimitiveClass().\n\nImplement the native part in ART and remove the native parts\nof the previously needed workaround for java.lang.Void.TYPE.\n\nCompanion libcore/ change:\n https://android-review.googlesource.com/619326\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nBug: 73346078\nChange-Id: Icfb201a1f08d8ff2a65c58f7c0ec25aa2296db29\n" }, { "commit": "305c38b395eddff7ca001fa7bdb621397033184d", "tree": "809965b36e35d8b5a06229a4904c7943525ea54c", "parents": [ "3bffbe8a8288cf01b7248fffdd320bf688529bcb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 14 11:50:07 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 14 16:16:05 2018 +0000" }, "message": "Disable bitstring type check runtime hooks.\n\nIntroduce a build flag for the bitstring type check, put\nruntime hooks behind the flag and set the flag to false.\n\nAlso add bitstring initialization for proxy classes, a test\nand a benchmark for the type checks.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --interpreter\nTest: Repeat with kBitstringSubtypeCheckEnabled \u003d true.\nBug: 73299705\nChange-Id: Ibcd88a828c7addc0473d8c428818734f80226b19\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "2c64a837e62c2839521c89060b5bb0dcb237ddda", "tree": "65475ed2e313ff17354e741bac7e9c85739b8b95", "parents": [ "6cd0005698181e4cef2247b632d396e605d58fa3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jan 04 11:31:56 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 05 11:27:50 2018 +0000" }, "message": "Change ClassStatus to fit into 4 bits.\n\nIn preparation for extending the type check bit string from\n24 to 28 bits, rewrite ClassStatus to fit into 4 bits. Also\nperform a proper cleanup of the ClassStatus, i.e. change it\nto an enum class, remove the \"Status\" word from enumerator\nnames, replace \"Max\" with \"Last\" in line with other\nenumerations and remove aliases from mirror::Class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 64692057\nBug: 65318848\nChange-Id: Iec1610ba5dac2c527b36c12819f132e1a77f2d45\n" }, { "commit": "4557b3858a66aa20e42bce937e1f0620aad880a2", "tree": "8f34d8f014b11f17c6351bb955fcc74c940b8d16", "parents": [ "90f20973356900e340998e8e2b34230e5c4c8fb0" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 11:47:54 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 12:45:40 2018 +0000" }, "message": "ART: Rename Atomic::CompareExchange methods\n\nRenames Atomic::CompareExchange methods to Atomic::CompareAndSet\nequivalents. These methods return a boolean and do not get the witness\nvalue. This makes space for Atomic::CompareAndExchange methods in a\nlater commit that will return a boolean and get the witness value.\n\nThis is pre-work for VarHandle accessors which require both forms.\n\nBug: 65872996\nTest: art/test.py --host -j32\nChange-Id: I9c691250e5556cbfde7811381b06d2920247f1a1\n" }, { "commit": "666ee3d7c6039c80e75287e311895bd6a9b01e9f", "tree": "5e65f39ff7cc83af4be3b691c247d7348052f854", "parents": [ "890111968fbd3f5ae528d97e42984c12a3dd27bd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 18:37:36 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 12 13:48:02 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveType().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nAlso refactor the code to avoid doing the DexCache lookup\ntwice and avoid unnecessary read barriers in the initial\nDexCache lookup (also for Lookup/ResolveField()).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Idea9aa42b6a5bade947e93e330b1abdb9d11b2da\n" }, { "commit": "170331f0e44a0e07fcfe0b5932517e0500f5cd1f", "tree": "4bb837aa3b6e19c898df23894beb61957885e985", "parents": [ "39b378ca3b4b6dc6da1651b84ee4289cd9bff0f8" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 18:41:03 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 18:41:03 2017 -0800" }, "message": "ART: Remove base/logging from heap-inl.h\n\nHide the single uncommon VLOG and remove the include. Fix up\ntransitive includes.\n\nTest: m\nChange-Id: I917df597cb62c57040c1fb0e0079df4d95e5a658\n" }, { "commit": "b0a6aeee250945b1d156ebab94053380f2e5a3c5", "tree": "7ddb52bb20997b8f1c81be3df2250949a088e697", "parents": [ "0db16e00e3927445585a588499731c58c1ae1bef" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 27 10:34:04 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Nov 10 08:30:36 2017 +0000" }, "message": "Record @{Fast,Critical}Native in method\u0027s access flags.\n\nRepurpose the old kAccFastNative flag (which wasn\u0027t actually\nused for some time) and define a new kAccCriticalNative flag\nto record the native method\u0027s annotation-based kind. This\navoids repeated determination of the kind from GenericJNI.\nAnd making two transitions to runnable and back (using the\nScopedObjectAccess) from GenericJniMethodEnd() for normal\nnative methods just to determine that we need to transition\nto runnable was really weird.\n\nSince the IsFastNative() function now records the presence\nof the @FastNative annotation, synchronized @FastNative\nmethod calls now avoid thread state transitions.\n\nWhen initializing the Runtime without a boot image, the\nWellKnowClasses may not yet be initialized, so relax the\nDCheckNativeAnnotation() to take that into account.\n\nAlso revert\n https://android-review.googlesource.com/509715\nas the annotation checks are now much faster.\n\nBug: 65574695\nBug: 35644369\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: I2fc5ba192b9ce710a0e9202977b4f9543e387efe\n" }, { "commit": "86083f7cd118f3d6c757191e83b4e4abaabdc5d7", "tree": "8e5b81ae0d09d41bfd90284a1b6b16b2332435e5", "parents": [ "495e783c9180c3fc033ce459ee0a783e633f7754" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Oct 27 10:59:04 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Nov 07 14:47:51 2017 -0800" }, "message": "runtime: Bitstring implementation for subtype checking (4/4).\n\nIntegrate the previous CLs into ART Runtime. Subsequent CLs to add\noptimizing compiler support.\n\nUse spare 24-bits from \"Class#status_\" field to\nimplement faster subtype checking in the runtime. Does not incur any extra memory overhead,\nand (when in compiled code) this is always as fast or faster than the original check.\n\nThe new subtype checking is O(1) of the form:\n\n src \u003c: target :\u003d\n (*src).status \u003e\u003e #imm_target_mask \u003d\u003d #imm_target_shifted\n\nBased on the original prototype CL by Zhengkai Wu:\nhttps://android-review.googlesource.com/#/c/platform/art/+/440996/\n\nTest: art/test.py -b -j32 --host\nBug: 64692057\nChange-Id: Iec3c54af529055a7f6147eebe5611d9ecd46942b\n" }, { "commit": "ee5303f76ef167714a6a04d3abc502584ac5e103", "tree": "7f414df9d48dda94872421de4192daf6ec731681", "parents": [ "c101222c854a0c476f5b6ae64e20adbd38126a3c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 31 15:34:42 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Sep 05 10:46:07 2017 -0700" }, "message": "ART: Move Class::Status to ClassStatus\n\nMove the enum to its own file to lower include burden on others.\nThis is an intentionally small and localized change. Users will\nbe cleaned up in a follow-up.\n\nBug: 63467744\nBug: 65318848\nTest: m test-art-host\nChange-Id: If3bfe6953973e24623e78a2a8dcc69b50117aa3c\n" }, { "commit": "afb664701734c6edbea07431382ee33f1677d42b", "tree": "bd67954a08efb59e7bee75dfe46d1230abe4443b", "parents": [ "7f14c2ec37c70010d99cab6806d85018df56c555" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 01 09:54:49 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 02 14:58:10 2017 -0700" }, "message": "Fix verifier checks on interface methods.\n\nWe were disallowing interfaces in the IsInheritedMethod even though\nthe function can be called with them. This could cause some failing\nDCHECKS if the verifier cannot find methods in some situations.\n\nWe also fixed a small issue in the verifier where we allowed\nnon-public java.lang.Object methods to be considered valid for\ninterface dispatch.\n\nTest: ./test.py --host -j50\nTest: Compile an app with bad bytecodes (See bug)\nBug: 64158483\nBug: 64274113\nChange-Id: Ia79f25be0001efc4069a411a0b34476bd0871803\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "ba118827465d12177f3996e50133960087b1c916", "tree": "f39728cdafc7810004d51c0bef2728b98993daa9", "parents": [ "64a102dde8c5daad83b991710decb418ce43aac5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 12 15:41:56 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 20 13:35:06 2017 +0100" }, "message": "ART: Change method lookup to be more consistent to JLS and the RI.\n\nThe method lookup for different invoke types was previously\nwidely different and didn\u0027t work well with the dex cache\nmethod array where we have only a single slot for each\nMethodId. The new behavior is to perform the same lookup for\nall cases, distinguishing only between interface and\nnon-interface referencing class, and to further align the\nbehavior with the JLS and the RI. Where the JLS conflicts\nwith the RI, we follow the JLS semantics.\n\nThe new lookup for class methods first searches the methods\ndeclared in the superclass chain (ignoring \"copied\" methods)\nand only then looks in the \"copied\" methods. If the search\nin the superclass chain finds a method that has not been\ninherited (i.e. either a private method or a package-access\nmethod where one of the classes in the chain does not belong\nto the same package, see JLS 8.4.8), we still search the\n\"copied\" methods as there may actually be a method inherited\nfrom an interface. This follows the JLS semantics where\ninherited methods are included in the search (JLS 15.12.2.1)\nbut conflicts with the RI where the private or\npackage-access method takes precedence over methods\ninherited from interfaces.\n\nNote that this search can find an accessible method that is\nnot inherited by the qualifying type, either for a package\naccess method when the referrer is in the same package but\nthe qualifying type is in another package, or for a private\nmethod where the referrer is in the same class but the\nqualifying type is actually a subclass. For the moment we\nallow such calls and we shall consider whether to throw\nan IncompatibleClassChangeError in this situation in future\nto comply with JLS 15.12.4.3.\n\nThe new lookup for interface methods searches the interface\nclass, then all the superinterfaces and then the\njava.lang.Object class, see implicitly declared methods in\ninterfaces, JLS 9.2. The search for the maximally-specific\nnon-abstract superinterface method is not yet implemented,\nbut the difference should be difficult to observe as the\nusual subsequent call to FindVirtualMethodForInterface()\nshould yield the same result for any matching method.\n\nThe new test 162-method-idx-clash exposes several cases\nwhere we previously completely messed up due to the effects\nof the DexCache, or where we were out of line with the RI.\nIt also tests a case where the JLS and the RI disagree and\nwe follow the JLS.\n\nTest: art/test/run-test --host --jvm 162-method-resolution\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --interp-ac\nTest: Nexus 6P boots.\nTest: testrunner.py --target\nBug: 62855082\nBug: 30627598\nChange-Id: If450c8cff2751369011d649c25d28a482a2c61a3\n" }, { "commit": "6d3e76884710e639e79a46d505395bc83ad5ec7d", "tree": "3b51520701c740ccb69ce38483c47c25105dd40b", "parents": [ "00cca3a275562d110a8b35094b9b12fac37f67ab" ], "author": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Tue Jul 11 10:31:29 2017 -0700" }, "committer": { "name": "Chang Xing", "email": "chxing@google.com", "time": "Tue Jul 11 17:05:12 2017 -0700" }, "message": "Abstract SetField functions with Transaction check\n\nAbstracted several functions which set objects\u0027 fields with a check to\ntest whether transaction is active to determine one template argument,\nthis make more object modification operations support transaction.\n\nReplaced some function calls with transaction checking version to\nsupport clinit for app image to run under transaction.\n\nTests shows not breaking anything, testcase cover this situation will be\nadded shortly.\n\nTest: make test-art-host -j64\nChange-Id: Ic15a4428a7c7cce6832651e1894eb760354de009\n" }, { "commit": "2722f380d6430be83a1c899a94999690a8ab26df", "tree": "1ce8a54c47aefbb35a4cb18c3d3bbedcbfac9734", "parents": [ "d632b8b8a031cda163c6f9a6b4e33a192f123a0b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 18:03:25 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jun 09 08:45:13 2017 -0700" }, "message": "ART: Fix old warnings\n\nFix Wundefined-var-template warnings.\n\nPartially reverts commit df53be273509dd43725870fb20a2c7d71f7fbfd3.\n\nBug: 28149048\nBug: 29823425\nTest: m\nTest: m test-art-host\nChange-Id: Ib077312558f9e2f784859861c000fbac8375b3f5\n" }, { "commit": "c6ea7d00ad069a2736f603daa3d8eaa9a1f8ea11", "tree": "a6d3332a8592fb806841314d55b206b573d37d86", "parents": [ "d68677c5fde1ace16ea58d65733776c954e7acb4" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Feb 01 16:46:28 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 21 08:40:33 2017 -0700" }, "message": "ART: Clean up art_method.h\n\nClean up the header. Fix up other headers including the -inl file,\nin an effort to prune the include graph. Fix broken transitive\nincludes by making includes explicit. Introduce new -inl files\nfor method handles and reference visiting.\n\nTest: source build/envsetup.sh \u0026\u0026 lunch aosp_angler-userdebug \u0026\u0026 mmma art\nTest: source build/envsetup.sh \u0026\u0026 lunch aosp_mips64-userdebug \u0026\u0026 mmma art\nChange-Id: I8f60f1160c2a702fdf3598149dae38f6fa6bc851\n" }, { "commit": "8f2b925473cfdc7650cef407102957befe0c6bb5", "tree": "4af3395adaf03cb4a60cd40e7b3ee4196645eb9e", "parents": [ "de9b8d63ef548d56de9c9d4657a7b916050d81ad", "6b2dc3156a2140a5bfd9cbbf5d7dad332ab5f5bd" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Fri Mar 17 09:05:55 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Mar 17 09:05:56 2017 +0000" }, "message": "Merge \"ART: Get rid of most of java.lang.DexCache.\"" }, { "commit": "4f2e957b07c8b6e48bbd7593bb64f3c5214fa489", "tree": "efcfcaaa1efdc567449c406e7107da2e94c127c2", "parents": [ "ed883a11b8cd7f3712bd30fca1e2b0fb641bff63" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Mar 16 13:13:31 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Mar 16 14:23:46 2017 -0700" }, "message": "Ensure the GC visits Obsolete Methods\n\nWe were previously not visiting obsolete methods during GCs. This\ncould lead to the use of stale pointers.\n\nBug: 36335999\nTest: ./test/testrunner/testrunner.py --host --interp-ac --gcstress -j40\n\nChange-Id: I2b5c7c75b29f9037204a860501fcdb78104b5e7a\n" }, { "commit": "6b2dc3156a2140a5bfd9cbbf5d7dad332ab5f5bd", "tree": "a335cae93c0eabae63e39b8bc13ef3e15f4f7e50", "parents": [ "f83f3f6ecb1153d96cc8007e8a0d1e35af4d3f38" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Mar 14 13:26:12 2017 +0000" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Thu Mar 16 17:56:04 2017 +0000" }, "message": "ART: Get rid of most of java.lang.DexCache.\n\nAll remaining functionality is moved over to native. The DexCache\nobject itself is allocated in the Java heap, even though there\u0027s no\nlonger much of a reason to do so. It can be changed in a future change\nif needed.\n\nThis also renames mirror::Class:GetInterfaces to GetProxyInterfaces\nsince it\u0027s supposed to be called only for proxies.\n\nTest: test-art-host, cts -m CtsLibcoreTestCases\n\nChange-Id: Ie261f22a9f80c929f01d2b456f170c7a464ba21c\n" }, { "commit": "8d6768d47b66a688d35399d524ad5a5450e9d9d4", "tree": "0b8733baef378d9e060c8e74319a3846489590b2", "parents": [ "fbe1516b91f2117bb9c7282aaea5537572f62dd7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 10:13:21 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 13:55:13 2017 +0000" }, "message": "Revert^6 \"Hash-based dex cache type array.\"\n\nFixed ImageWriter to write class table also if it contains\nonly boot class loader classes. Added a regression test and\nadded extra checks for debug-build to verify that dex cache\ntypes from app image are also in the class table. Removed\nsome unnecessary debug output.\n\nTest: 158-app-image-class-table\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 0b66d6174bf1f6023f9d36dda8538490b79c2e9f.\n\nChange-Id: I6a747904940c6ebc297f4946feef99dc0adf930c\n" }, { "commit": "0b66d6174bf1f6023f9d36dda8538490b79c2e9f", "tree": "1cc4d2ae868745a65fd0489a6fb2f5f2fc9e880f", "parents": [ "6374c58f2ea403b3a05fb27376110fe4d0fc8e3f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 14:50:04 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 16:08:01 2017 +0000" }, "message": "Revert^5 \"Hash-based dex cache type array.\"\n\nFor app images, ImageWriter does not add boot image\nclasses to the app image class table even though it\nkeeps them in the dex caches. The reason for that is\nunknown, the code looks OK.\n\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nAlso reverts \"Improve debugging output for a crash.\"\n\nThis reverts commits\n bfb80d25eaeb7a604d5dd25a370e3869e96a33ab,\n 8dd56fcb3196f466ecaffd445397cb11ef85f89f.\n\nTest: testrunner.py --host\nChange-Id: Ic8db128207c07588c7f11563208ae1e85c8b0e84\n" }, { "commit": "bfb80d25eaeb7a604d5dd25a370e3869e96a33ab", "tree": "96068dd9b9b3bc2e1bcc25d38bbd2420d5b0f1bb", "parents": [ "7a49d93ee265b978ab29cae659e46d41da78459a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 14 14:08:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 20 14:13:14 2017 +0000" }, "message": "Revert^4 \"Hash-based dex cache type array.\"\n\nAdded extra output to the abort message to collect more data\nwhen we hit the crash. Added extra check when loading an app\nimage to verify that the class table isn\u0027t already broken.\n\nTest: testrunner.py --host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5.\n\nChange-Id: I9bb442a184c236dcb75b3e42a095f39cd6bee59d\n" }, { "commit": "fa4333dcb481e564f54726b4e6f8153612df835e", "tree": "ae597c7587dc214434a180962c4373d3748f51ab", "parents": [ "2d98ba68f13dc219c088a12f369c5778bf398f14" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:10:34 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:44:48 2017 -0800" }, "message": "ART: Add operator \u003d\u003d and !\u003d with nullptr to Handle\n\nGet it in line with ObjPtr and prettify our code.\n\nTest: m\nChange-Id: I1322e2a9bc7a85d7f2441034a19bf4d807b81a0e\n" }, { "commit": "5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5", "tree": "be0e9fdeb90bcbad76b17b3aae4e746d977d80ee", "parents": [ "518f373324f355f8e58440dfbc3f5a1f2244bde7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 18:32:04 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 19:34:54 2017 -0800" }, "message": "Revert^3 \"Hash-based dex cache type array.\"\n\nAssert failing for \"earchbox:search\":\nF zygote64: class_linker.cc:4612] Check failed: handle_scope_iface.Get() !\u003d nullptr\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 85c0f2ac03417f5125bc2ff1dab8109859c67d5c.\n\nChange-Id: I39846c20295af5875b0f945be7035c73ded23135\n" } ], "next": "85c0f2ac03417f5125bc2ff1dab8109859c67d5c" }