)]}' { "log": [ { "commit": "698ebbca3c54d17c696e87b9e5838df6a5ac9b08", "tree": "7887b2cd4662410114f205bbe1896ff094d51407", "parents": [ "4b9a11f1d43df69c50e93ba1793fce1c2216682b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 05 11:00:42 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jan 08 09:11:49 2018 -0800" }, "message": "Clean up CodeItemAccessors and Compact/StandardDexFile\n\nChange constructor to use a reference to a dex file.\n\nRemove duplicated logic for GetCodeItemSize.\n\nBug: 63756964\nTest: test-art-host\nChange-Id: I69af8b93abdf6bdfa4454e16db8f4e75883bca46\n" }, { "commit": "118c59cf6af50e128d29609c9046a4af15826976", "tree": "c0f82859babac12e3e000964a328ddc2498b74bb", "parents": [ "71a7b36894114d02860d2e64b9396dbd5e0b9b38", "fe92d1227f74a383172c0f339884c69e151fb404" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jan 08 08:11:23 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jan 08 08:11:23 2018 +0000" }, "message": "Merge \"ART: Verifier support for VarHandles\"" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "fe92d1227f74a383172c0f339884c69e151fb404", "tree": "c8cb4777ef1335e2ef1da22ca239524b6aa33214", "parents": [ "4131d1096ac57a29ba1939c1cf2cb74144c16c92" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jan 02 10:45:17 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Jan 05 10:38:26 2018 +0000" }, "message": "ART: Verifier support for VarHandles\n\nExtends checking of signature polymorphic methods to support VarHandle\naccessor methods.\n\nBug: 65872996\nTest: run-test --host 954\nChange-Id: I696bfdfbf1cd99f7cd6720cda5911dd4f5e66ada\n" }, { "commit": "f6e31474096a3c25b2d0c872fc120d7479b62367", "tree": "72d8cee843375af8b8c8c7919ae930c9e5df2bfd", "parents": [ "ce4982554648998abd0980bd06e738f4bcaa35d9" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Dec 28 13:32:08 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 02 11:41:47 2018 -0800" }, "message": "Fix default method verifier check for compact dex\n\nAdd a feature flag and mark if the compact dex file was\ngenerated from a dex file that supported default methods or not. This\nis done to maintain the existing verifier behavior differences for\ndex files that do and don\u0027t support default methods.\n\nFixed callers to use a virtual function instead of always checking\nthe dex file version.\n\nRe-enabled run-test 975.\n\nBug: 70930171\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I46ac5d3cde0d0c9f41cbc68cccaf954b531e0edf\n" }, { "commit": "dc578c7e47b2db623b382932bfe4dbc6dce41aa4", "tree": "409e6dc0c338bf75c1ce55acfae91fe86ef3028e", "parents": [ "1d32a16f93d8bb479523fd237277ecbbff5bf1f4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 27 11:51:45 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 27 13:24:11 2017 -0800" }, "message": "Move dex exception helpers to their own file and use dex accessor\n\nAlso change the input argument to be a code item accessor\ninstead of a code item pointer. This removes the dependency on\nthe code item layout.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: If75a168d0b5a77d08fa3c6ba38d00705158911db\n" }, { "commit": "808c7a57bb913b13c22884f57cdacd59bf1fdb3f", "tree": "d7f0d7cabaac5a7646c25bae584a82a9aa279cc0", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 15 11:19:33 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 22 09:41:17 2017 -0800" }, "message": "Make CodeItem fields private\n\nMake code item fields private and use accessors. Added a hand full of\nfriend classes to reduce the size of the change.\n\nChanged default to be nullable and removed CreateNullable.\nCreateNullable was a bad API since it defaulted to the unsafe, may\nadd a CreateNonNullable if it\u0027s important for performance.\n\nMotivation:\nHave a different layout for code items in cdex.\n\nBug: 63756964\nTest: test-art-host-gtest\nTest: test/testrunner/testrunner.py --host\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nChange-Id: I42bc7435e20358682075cb6de52713b595f95bf9\n" }, { "commit": "666ee3d7c6039c80e75287e311895bd6a9b01e9f", "tree": "5e65f39ff7cc83af4be3b691c247d7348052f854", "parents": [ "890111968fbd3f5ae528d97e42984c12a3dd27bd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 18:37:36 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 12 13:48:02 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveType().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nAlso refactor the code to avoid doing the DexCache lookup\ntwice and avoid unnecessary read barriers in the initial\nDexCache lookup (also for Lookup/ResolveField()).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Idea9aa42b6a5bade947e93e330b1abdb9d11b2da\n" }, { "commit": "890111968fbd3f5ae528d97e42984c12a3dd27bd", "tree": "edb4ed38332a817b7d3037ea260856cec839dca9", "parents": [ "0f13269734be07b5869005952a3cb91b0b34b73d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 13:45:05 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 15:43:45 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveMethod().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I2e47280e7cb8b84595130c4abfb5ece18d7f5c75\n" }, { "commit": "0f13269734be07b5869005952a3cb91b0b34b73d", "tree": "026115080385984050674455e54721f00cb5df10", "parents": [ "768bd97cede0a6de738936aad738f8bb0099322e", "a64b52deb0c792b8a0d47546edb8a2f8a7816c33" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 14:24:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Dec 11 14:24:43 2017 +0000" }, "message": "Merge changes I8c4cec43,I00634b89,I0579db64\n\n* changes:\n Do not pass DexFile to ClassLinker::Lookup/ResolveString().\n Do not pass DexFile to ClassLinker::ResolveMethodType().\n Do not pass DexFile to ClassLinker::ResolveField*().\n" }, { "commit": "c654816053ae07fb1f129d705e94b76e59f37454", "tree": "867d678ab3f6e0f4af70da98e935aafae0c6126c", "parents": [ "8f1a586fd4ac9796e75b2b18638e39b33ad6e9a2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:15:22 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:22:21 2017 -0800" }, "message": "ART: Change SCOPED_TRACE implementation\n\nMove to a LOG-like usage pattern. This improves usability in the\npresence of lock annotations.\n\nDemonstrate in the JIT compiler, where a lambda would require\na REQUIRES_SHARED annotation.\n\nTest: m\nTest: manual\nChange-Id: I9da2bfb29ed11660dbeb6f114a3d6c7ffef3a26d\n" }, { "commit": "8f1a586fd4ac9796e75b2b18638e39b33ad6e9a2", "tree": "f1970c938487dbd9e773619804612ac824b0721c", "parents": [ "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5", "170331f0e44a0e07fcfe0b5932517e0500f5cd1f" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Dec 08 19:28:07 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 19:28:07 2017 +0000" }, "message": "Merge changes I917df597,Ib2ca880e,Ib3733573,I3e3a4672\n\n* changes:\n ART: Remove base/logging from heap-inl.h\n ART: Factor out gAborting\n ART: Move runtime-debug flags to own files\n ART: Replace base/logging with android-base/logging\n" }, { "commit": "e11dd50ac2b5ccbf3b02213b7361f55b1f1a90da", "tree": "ea958df5f757369119cc84968f3b77210faf593f", "parents": [ "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 14:09:45 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:54:25 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::ResolveField*().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I0579db64c63afea789c7c9ad8db81e37c9248e97\n" }, { "commit": "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5", "tree": "5362f0306de9dfd47576b0988dc8b660ece0898b", "parents": [ "f56a1c0abde24065f02705004cdc245f850e064a", "208f67072283be64da231b51f9c195aff403dceb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:26:53 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 17:26:53 2017 +0000" }, "message": "Merge \"Change ArtField::ProxyFindSystemClass() to lookup the class.\"" }, { "commit": "f56a1c0abde24065f02705004cdc245f850e064a", "tree": "6b5debfcb663f76e6a5bcb3949eec1bce891989e", "parents": [ "f23779bc210ecbf448e61d7b18088b6afb46a476", "28e012a4af2d710e5e5f824709ffd6432e4f549f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:26:18 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 17:26:18 2017 +0000" }, "message": "Merge \"Determine HLoadClass/String load kind early.\"" }, { "commit": "208f67072283be64da231b51f9c195aff403dceb", "tree": "97748c71e6c16ae110ccdbb13f50a78e5a21cd33", "parents": [ "4388fb213ec746ee18a6bea38ee894f8c19990b9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 12:00:50 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 16:50:21 2017 +0000" }, "message": "Change ArtField::ProxyFindSystemClass() to lookup the class.\n\nAs the function is called from ArtField::LookupType(),\nwe should avoid calls that appear to allow type resolution\nrather than plain lookup. The lookup should always succeed.\n\nAlso rename ArtField::LookupType() to LookupResolvedType()\nto align with naming used in ClassLinker and ArtMethod.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I0a87347b5341575e47e0fdba6d58ade2543387c8\n" }, { "commit": "28e012a4af2d710e5e5f824709ffd6432e4f549f", "tree": "576ebdbff9d5f9f098cd29d652215b8f67b6b042", "parents": [ "4388fb213ec746ee18a6bea38ee894f8c19990b9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Dec 07 11:22:59 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 15:27:27 2017 +0000" }, "message": "Determine HLoadClass/String load kind early.\n\nThis helps save memory by avoiding the allocation of\nHEnvironment and related objects for AOT references to\nboot image strings and classes (kBootImage* load kinds)\nand also for JIT references (kJitTableAddress).\n\nCompiling aosp_taimen-userdebug boot image, the most memory\nhungry method BatteryStats.dumpLocked() needs\n - before:\n Used 55105384 bytes of arena memory...\n ...\n UseListNode 10009704\n Environment 423248\n EnvVRegs 20676560\n ...\n - after:\n Used 50559176 bytes of arena memory...\n ...\n UseListNode 8568936\n Environment 365680\n EnvVRegs 17628704\n ...\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nBug: 34053922\nChange-Id: I68e73a438e6ac8e8908e6fccf53bbeea8a64a077\n" }, { "commit": "f223f76bdd360664a1e8068eeac6ce35f7392bc6", "tree": "d3d0a8f6cb7841b0052301d22963e1978ff0563f", "parents": [ "d5153627778e71ef68b510ce03c77467fa4d85bd", "dfebbac8e30172169dbdaaf7e6a0be51433d57f1" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Dec 08 02:58:59 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 02:58:59 2017 +0000" }, "message": "Merge \"ART: Add ScopedTrace constructor with lambda\"" }, { "commit": "dfebbac8e30172169dbdaaf7e6a0be51433d57f1", "tree": "3c751ff6792aaf88706fd0b3e0ed77d2cc4f83c2", "parents": [ "92ab698e46dba3b6cff1457f47bfc344cb03f7ec" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 14:17:22 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 02:54:45 2017 +0000" }, "message": "ART: Add ScopedTrace constructor with lambda\n\nIn an effort to allow more complex and expensive atrace tagging,\nadd a ScopedTrace constructor that uses a passed-in lambda to\ncompute the string lazily.\n\nAdd a macro to simplify usage.\n\nTest: m\nChange-Id: I3b4576d786177042922fef0d05161e4cc11144d4\n" }, { "commit": "39b378ca3b4b6dc6da1651b84ee4289cd9bff0f8", "tree": "1da7bdc834fbc2f11243fa2b936f0d7a67d982c1", "parents": [ "dcc528d2c7d5ac2cc075d4c965fdf702421d0f43" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 15:44:13 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 16:26:11 2017 -0800" }, "message": "ART: Factor out gAborting\n\nCut dependencies on base/logging.h by moving gAborting to its\nown header. Leave the static storage in logging.cc.\n\nTest: m\nChange-Id: Ib2ca880e15f9cb50cb9aab803784826bb46efb5e\n" }, { "commit": "57943810cfc789da890d73621741729da5feaaf8", "tree": "367677a982a45af98ffe3e79543615875e8550b4", "parents": [ "d5153627778e71ef68b510ce03c77467fa4d85bd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 21:39:13 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 16:26:11 2017 -0800" }, "message": "ART: Replace base/logging with android-base/logging\n\nReplace wherever possible. ART\u0027s base/logging is now mainly VLOG\nand initialization code that is unnecessary to pull in and makes\nchanges to verbose logging more painful than they have to be.\n\nTest: m test-art-host\nChange-Id: I3e3a4672ba5b621e57590a526c7d1c8b749e4f6e\n" }, { "commit": "92d77208d7434f2c8c49aa368769165c4d33896f", "tree": "1146aa6d673b38c81b551687bede8c0aeffed8d5", "parents": [ "4388fb213ec746ee18a6bea38ee894f8c19990b9" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 20:49:00 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 21:48:47 2017 -0800" }, "message": "ART: Make kDebugVerifier a verbose flag\n\nTo aid in debugging efforts, finally introduce a verifier-debug\nverbose-logging flag that takes over the compile-time kDebugVerifier\nflag.\n\nCollecting verification times from a well-known large app during\ndex2oat via dump-timings shows a difference in the noise.\n\nLogging of the steps is restricted to failure cases, to avoid\nspam.\n\nTest: m\nTest: m test-art-host\nTest: manual: dex2oat --runtime-arg -verbose:verifier-debug APK with failures\nChange-Id: Icb998cc42a531b80f20f986625869505271b7c98\n" }, { "commit": "52f205a38bda70d5c63907ef354a1475b4237b21", "tree": "4e7ff8aa8daccf308fa4e0bd6e4dc001805d855b", "parents": [ "92ab698e46dba3b6cff1457f47bfc344cb03f7ec" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 01 12:16:07 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 14:13:21 2017 -0800" }, "message": "ART: Remove old aget on null workaround\n\nUse null for an aget-object of null. Ensure that other aget types\non null cannot be converted to or used as a reference type.\n\nLet the verifier continue scanning after an aget on a null register,\nto ensure that the dead code is type-safe.\n\nAdd test coverage for the new behavior.\n\nPartially reverts commit 4824c27988c8eeb302791624bb3ce1d557b0db6c\nPartially reverts commit 857f058d4b7bd07c5c99eda416ad91516a10b4da\n\nBug: 22059710\nBug: 64683522\nBug: 69669661\nTest: m test-art-host\nChange-Id: Ie0b554e8f880251d8e73ab6dfb6b41a5e63defc6\n" }, { "commit": "8ddb7f5c9a3fa2b31e87efcf785a1e427f042bbb", "tree": "d133e0d2a02643e2f554ebcd120e20e6521b8f7f", "parents": [ "d57fdd82fccfa15933033646c9436313b399d528" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Dec 04 10:14:08 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Dec 04 10:14:08 2017 -0800" }, "message": "ART: Reorder null check in verifier\n\nDo not execute DCHECK before null check.\n\nBug: 69606743\nTest: m test-art-host\nChange-Id: I63b49b003943d7e902adefd4763310e1541ce732\n" }, { "commit": "eed3a5d1a6560464b3a271c85b40b1cdf8a1bfd4", "tree": "2611ced1c62ad9e987202204fe083502a7165166", "parents": [ "38af096a2fe0f2c0edb22bfca74d05c1aeeedaee" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 29 14:58:34 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 01 17:11:45 2017 -0800" }, "message": "ART: Add null type to verifier\n\nAdd a null type to distinguish zero from null. This is an\ninfra-only change, as nothing will introduce null with this\ncommit, yet.\n\nBug: 22059710\nBug: 64683522\nBug: 69669661\nTest: m test-art-host\nChange-Id: Id2549a5aefefe9471d4bdbd2c8993395150947c6\n" }, { "commit": "aaf0d38d9e3bd35aaf5ea2be6409bf2f3575f0ad", "tree": "a1eb3414c972f866b606dd1d11b3203640f30880", "parents": [ "23f8f50ace964ed597261f19e87ac050f415957e" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 27 14:10:21 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Nov 28 12:01:32 2017 -0800" }, "message": "ART: Change lock dumping\n\nReturn dex registers as well as dex PCs from FindLocksAtDexPc.\n\nIt is necessary to return the registers as the register used for\na monitor-enter operation may be aliased and overwritten by the\ntime the requested dex PC is reached.\n\nIt is at this point necessary to return a set of registers as\noptimizations may have eliminated dead registers, and the verifier\nhas no notion of liveness.\n\nA client of FindLocksAtDexPc should not assume that all registers\ncan be successfully retrieved from a stack frame, with the possibility\nof none. Only a properly verified method (i.e., lock verification succeeded)\nimplies that at least one register should work for all locks held at\nany point in the program.\n\nBug: 68703210\nTest: art/test/testrunner/testrunner.py -b --host -t 167\nChange-Id: I9027787e395cf8df0e7699a606665edb2ecb5136\n" }, { "commit": "3da1d0f0881e130ebab95e2d06abe7d2beff57f0", "tree": "00b655e97955b317e995e4884ac726a1146b489d", "parents": [ "5552e535951f2feb10bfd492b8abb54bd41a9f4b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 06 20:02:24 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 13 09:18:38 2017 -0800" }, "message": "Use CodeItemAccessor helpers for method verifier\n\nCreate a code_item_accessor_ in the verifier and replace the existing\ncode_item field. Added some handling in DexFile to deal with\ntry/catch items.\n\nBug: 63756964\nTest: test-art-host\nChange-Id: I4e073c9cb29f94518f0016fccbe1628185884df4\n" }, { "commit": "2ffb703bf431d74326c88266b4ddaf225eb3c6ad", "tree": "0552c3c76a42b18f9e7460d501fb71a6dc2e7f33", "parents": [ "c4b6f3116f15c8e4fdf2e4f604ababdee12d8923" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Nov 08 13:35:21 2017 -0800" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Nov 08 15:15:52 2017 -0800" }, "message": "cpplint: Cleanup errors\n\nCleanup errors from upstream cpplint in preparation\nfor moving art\u0027s cpplint fork to upstream tip-of-tree cpplint.\n\nTest: cd art \u0026\u0026 mm\nBug: 68951293\nChange-Id: I15faed4594cbcb8399850f8bdee39d42c0c5b956\n" }, { "commit": "4098a7ad22535212c193f5c66eaf8a7387e1b7fc", "tree": "b6fbfef133515376185b769ea2c9625a6a637a04", "parents": [ "383684585824efa60350b208b92362efab3962eb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Nov 06 16:00:51 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Nov 06 16:24:06 2017 +0000" }, "message": "Refactor ArtField::GetType\u003c\u003e() as {Lookup,Resolve}Type().\n\nAnd add no thread suspension assertion to LookupType()\nas well as ArtMethod::LookupResolvedClassFromTypeIndex().\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: If1541ccb0aafeabb6d1dd5566f10afcac98a2ef1\n" }, { "commit": "5f317039d87d74f25d3b0a442072557086742d17", "tree": "6beae56f543d234b49a2f973dcbeb5f6f0bd2b90", "parents": [ "72627a5f675b1c664beb2ad33d60a1c8dca80826", "2b2bef245d5b2c6faa2d6f36da14866b2d8f5e4f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Nov 03 15:56:22 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Nov 03 15:56:22 2017 +0000" }, "message": "Merge \"Refactor DexInstructionIterator\"" }, { "commit": "2b2bef245d5b2c6faa2d6f36da14866b2d8f5e4f", "tree": "7948ee1d32e211198a595bb7ed35558d22838da8", "parents": [ "f199f1d3a9816edf9282766a8874d894d7bf87c3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 26 17:10:19 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 01 15:36:21 2017 -0700" }, "message": "Refactor DexInstructionIterator\n\nAdd a way to get the dex PC for the \"for each\" use case.\n\nBug: 67104794\nTest: test-art-host\nChange-Id: I144c459c9a2a03ec8d56842280338d1f7ce1caf0\n" }, { "commit": "d9aff1372e6a2f573b14d124f3d6f5305bdc6080", "tree": "2e0eaeb39c909167ecb5190b51f908e3622940cd", "parents": [ "df00a1ed1a0b633a1e66f1f650f53c22ea260e5b" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 31 22:30:05 2017 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Nov 01 18:49:04 2017 +0000" }, "message": "Revert \"Revert \"Prevent races with GC when transferring objects between threads\"\"\n\nThis reverts commit e5179ce0ca8becf34ba6e7b2f3988874fe647c26.\n\nReason for revert: Fixed issues with:\n Checkpoint flag set without pending checkpoint in parent CL.\n\nBug: 67838964\nTest: ./test.py --host -j50\n\nChange-Id: I7622f9c18866b58ee3cbd9f4fe38a29b2cf84a88\n" }, { "commit": "a2cbb2b0723a3fa05cc44e13cbe90543b3236883", "tree": "1db9efcd8bcece516b6f5cbb48cf5f00ba7c1796", "parents": [ "62540e3cc58abde95e147210d584614651d858b5", "e5179ce0ca8becf34ba6e7b2f3988874fe647c26" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 31 22:29:21 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Oct 31 22:29:21 2017 +0000" }, "message": "Merge \"Revert \"Prevent races with GC when transferring objects between threads\"\"" }, { "commit": "e5179ce0ca8becf34ba6e7b2f3988874fe647c26", "tree": "6d1bad18374493e2e85f715a575dea65f1725317", "parents": [ "7585b91bfc77b8e4b821ccfa716fa86e46455275" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 31 22:28:11 2017 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 31 22:28:11 2017 +0000" }, "message": "Revert \"Prevent races with GC when transferring objects between threads\"\n\nThis reverts commit 7585b91bfc77b8e4b821ccfa716fa86e46455275.\n\nReason for revert: Seems to be causing fatal error: \n Checkpoint flag set without pending checkpoint\n\nChange-Id: I98ea653e629d73e854907115583afed3ed5ac68e\nTest: None.\nBug: 67838964\n" }, { "commit": "62540e3cc58abde95e147210d584614651d858b5", "tree": "1ceacf74b8aa3980d8c0b03a757c9eb9d3b94330", "parents": [ "a877fa31eadeebb481122bbd444f9c3816a35369", "7585b91bfc77b8e4b821ccfa716fa86e46455275" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Oct 31 15:43:09 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Oct 31 15:43:09 2017 +0000" }, "message": "Merge \"Prevent races with GC when transferring objects between threads\"" }, { "commit": "7585b91bfc77b8e4b821ccfa716fa86e46455275", "tree": "b37517925ac9ab701cbae7f446dc8bb624ddd492", "parents": [ "0d2b2ad6cd9ca650d7a3f85a42afaf518cbfa4e0" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Oct 30 15:33:58 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Oct 30 16:16:41 2017 -0700" }, "message": "Prevent races with GC when transferring objects between threads\n\nWe could have races with the GC when JVMTI code transfers a local\nreference from one thread to another. This race would happen if a GC\nwas currently underway causing an unmoved reference to be transferred\nto a thread that has already fixed up all of its references. This\nmeant that the receiving thread would now have a reference belonging\nto the from-space on its stack.\n\nThis could cause memory errors and CHECK failures.\n\nTo fix this we make sure to run all checkpoints where local references\nmight be transferred in a GC-critical-section.\n\nWe also needed to fix a too-strict check in the method verifier where\nwe were incorrectly asserting that suspension be allowable when in\nfact it was not necessary in all cases.\n\nTest: ./test.py --host -j50\nBug: 67838964\n\nChange-Id: Ib9166cc233d3c1b488864c0aff33246a3f99e436\n" }, { "commit": "af7c9028905ccc0bb876e07dbe06921a80be9ebd", "tree": "53d7b80fb299e0a34b9951610740935f6f3ca802", "parents": [ "460e09c5a5a09937825fe101d260d5c917144369" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Oct 27 09:42:46 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 30 16:12:55 2017 -0700" }, "message": "Fix DexInstructionIterator overrun bug\n\nHandle cases where the dex instructions can go past the end of the\ncode item in dexlayout.\n\nSince dexlayout runs before method verification, we need to be\ncareful to not go past the end of the code item.\n\nAdded test.\n\nBug: 67104794\nTest: test-art-host\n\nChange-Id: Idf7d51344659b2c75207bdf444e39f271feb8d3a\n" }, { "commit": "69d310e0317e2fce97bf8c9c133c5c2c0332e61d", "tree": "fba05a1530e6fc4a2e6950303c1f7c6b0ffbb936", "parents": [ "e764d2e50c544c2cb98ee61a15d613161ac6bd17" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 09 14:12:23 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Oct 11 09:44:26 2017 +0100" }, "message": "Use ScopedArenaAllocator for building HGraph.\n\nMemory needed to compile the two most expensive methods for\naosp_angler-userdebug boot image:\n BatteryStats.dumpCheckinLocked() : 21.1MiB -\u003e 20.2MiB\n BatteryStats.dumpLocked(): 42.0MiB -\u003e 40.3MiB\nThis is because all the memory previously used by the graph\nbuilder is reused by later passes.\n\nAnd finish the \"arena\"-\u003e\"allocator\" renaming; make renamed\nallocator pointers that are members of classes const when\nappropriate (and make a few more members around them const).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 64312607\nChange-Id: Ia50aafc80c05941ae5b96984ba4f31ed4c78255e\n" }, { "commit": "2e59994c3c586d8b753e4b14a94c81bce3dba1a9", "tree": "ab749ce709732821c7c00c81eb76afef032fd888", "parents": [ "865a0503515f78611dce103bd04b7c66c051d304" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Sep 22 16:17:41 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Oct 02 16:08:18 2017 +0100" }, "message": "ART: support for const-method-{handle,type}\n\nAdds support for const-method-handle and const-method-type bytecodes.\n\nBug: 66562269\nTest: art/test/run-test --host 979\nTest: art/test/dexdump/run-all-tests\nChange-Id: I812eaf0f2439d6126b4287483fe2348366cacf90\n" }, { "commit": "cfcc9cfb44bab79f7381bcc4bfd9bf2d4435f734", "tree": "6637daf0cde4f14afd02793ad268f22f9257bd4c", "parents": [ "f67f115423c9ef5aa62a33c12670cd8f89457c9c" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Sep 29 15:07:27 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Sun Oct 01 12:08:08 2017 +0100" }, "message": "ART: Increase the number of potential instrinsics\n\nThe new limit is 256 intrinsics.\n\nAdds additional sanity checks.\n\nAvoids setting the kAccPreviouslyWarm bit for intrinics (defaults to\ntrue).\n\nBug: 65872996\nTest: art/test.py --host -j32\nChange-Id: I33ea67c9b6b8500b3ceb8a085358f075f6fcbb82\n" }, { "commit": "d7559b7b9da5ee839b8f21fc8d6e3e9ae5c573f7", "tree": "f8cabe1440bd9910932ea73a1df7a35be343f909", "parents": [ "6e7e0ddf1dda35570cd9ed23751d9306f7353d7f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 28 13:50:37 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 28 14:06:53 2017 +0100" }, "message": "Clean up DexInstuctionIterator.\n\nFollow-up to\n https://android-review.googlesource.com/493297 .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 63756964\nChange-Id: I454a748858e54f7ddfc54f631d7cd97d63557aff\n" }, { "commit": "1d2d4ff8570bb88d9d2d4633706fd7f6fb18d75e", "tree": "cbe67e8e9214828656314117121e8ce906a762ab", "parents": [ "e5b35ed787fbfb388d162361310bae5b0e7682a7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Sep 23 16:11:06 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 27 11:51:53 2017 -0700" }, "message": "Add DexInstructionIterator and use it a few places\n\nMotivation:\nWant to start abstracting away dex specific functionality to enable\nCompactDex. Adding an iterator will enable CompactDex iteration to\nwork differently than normal dex iteration.\n\nWill eventually replace CodeItemIterator.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I90e67c1a994b7698aaac0523a82816b0a003fbdc\n" }, { "commit": "3c683150bcf2f1cabbe2e5f9d10d8c670b67fb7e", "tree": "c895af9e725c3b20a195cf7009f5e3e52a09854a", "parents": [ "b92384853a8203b5936694c056515576e06fc435", "1cda7c2126d655cc9936c782f9dd33ec37b7f196" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Sep 20 08:59:24 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Sep 20 08:59:24 2017 +0000" }, "message": "Merge \"Revert^2 \"ART: Remove workaround in verifer after Jack update.\"\"" }, { "commit": "e2abbc604ce003c776c00ecf1293796bb4c4ac5a", "tree": "f7d124d1861cad2162c30dfe932bb4e1beaf41ef", "parents": [ "7090dfe84f78b1928fcbdfd664d0dd9ea52633ff" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 15 11:59:26 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 18 11:36:24 2017 -0700" }, "message": "ART: Move kDexNoIndex to dex_file_types.h\n\nDefine the constant with the types to allow lowering the dependency\non DexFile.\n\nTest: m\nChange-Id: I3c61421db45be96d2057e01b1a7825883d8bd178\n" }, { "commit": "dd309074fd4a6dc0dc275325b19670e24d64951d", "tree": "4d5c7222041fa52a99e6d43ecdb42cbcc83e6467", "parents": [ "82a63734d3067ea0c96f8ba15bc40caaf798c625" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 31 07:47:37 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 31 07:47:37 2017 -0700" }, "message": "ART: Enhance comment\n\nEnhance comment about ResolveClass instantation.\n\nAddresses comment for commit ae0b1f48ea9c65f946968cd99e34313cd2d43124.\n\nTest: m\nChange-Id: I6d2a2ad5eb938480b83a174a9f589e79ba6a0f52\n" }, { "commit": "ae0b1f48ea9c65f946968cd99e34313cd2d43124", "tree": "25ad4c1cd09e9a9abc7c04e787ef47f6cb960419", "parents": [ "fa830aa33e767420dcf705beb18c458df702502b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 30 17:36:26 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 30 17:39:16 2017 -0700" }, "message": "ART: Instantiate templated functions\n\nFollow-up to commit 98be1a9d7280f82e533bc02d2df564da4c8f73a0.\nHopefully fixes the Mac build.\n\nTest: m\nChange-Id: Id92ce77fa452bb7da1e84f9d7ef151702da86a23\n" }, { "commit": "629be51a9d4c2be648adb509af24091f314bbc33", "tree": "857f95a7d140e3eb7d8145e42935c29edec53b1f", "parents": [ "98be1a9d7280f82e533bc02d2df564da4c8f73a0" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Aug 25 17:09:32 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 30 11:37:16 2017 -0700" }, "message": "ART: Redo verification on class resolution failure\n\nDuring compile-time verification, when a class needs to be resolved\nand access to that class checked, if we can\u0027t resolve the class,\ndo a conservative access check and post an ACCESS_CLASS failure, if\nnecessary. This will trigger a re-verification at runtime, when the\nclass should be available.\n\nFix an invoke-polymorphic test to not trigger dead code. Fix method\nexpectations in verifier_deps_test.\n\nBug: 64681719\nTest: m test-art-host\nTest: cts-tradefed run commandAndExit cts --m vm-tests-tf\nChange-Id: I3639639476f6938e10df1b0dac4545fe841a6ad2\n" }, { "commit": "98be1a9d7280f82e533bc02d2df564da4c8f73a0", "tree": "5e9e0ad0e721023742fe3433e413023bee583953", "parents": [ "7da4c401614344e3274434a242b8231126b17981" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 28 08:25:45 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 30 11:37:16 2017 -0700" }, "message": "ART: Don\u0027t check access for method parameters\n\nRename ResolveClassAndCheckAccess to ResolveClass and add a CheckAccess\ntemplate parameter. Do not check access when checking the signature of\nthe method to be verified. A parameter itself is not an access and would\nnot trigger an IllegalAccessError. So only check on actual usage.\n\nBug: 64681719\nTest: m test-art-host\nChange-Id: I00aa37f5fb097b37e267bd4332638fa3092b4fe9\n" }, { "commit": "7da4c401614344e3274434a242b8231126b17981", "tree": "d06f9db0b42bb2d9f4886cf15f418af341dbe212", "parents": [ "8ef4b6121ea496d38c0b8aeebad3f1227f819b17" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Aug 25 11:30:48 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Aug 30 11:35:19 2017 -0700" }, "message": "ART: Redo verification on field resolution failure\n\nWhen compile-time verifying a field PUT and the field cannot be resolved,\nthe verification must be redone at runtime to ensure the field is not\nfinal. Post an ACCESS_FIELD error.\n\nAn example is\n\n dex file A:\n class A {\n {\n B b \u003d new B();\n B.final_field \u003d 12345; // illegally modify final-after-new\n }\n }\n\n dex file B:\n class B {\n final int final_field \u003d 0;\n }\n\nwhen A is compiled without B.\n\nBug: 34966607\nBug: 64681719\nTest: m test-art-host\nTest: cts-tradefed run commandAndExit cts --m vm-tests-tf\nChange-Id: Ibc14b003288f7acf3c865fcdef54a6d9ed4ac867\n" }, { "commit": "1cda7c2126d655cc9936c782f9dd33ec37b7f196", "tree": "24ed20c4687f3d92d3f990d688c70b781f18d706", "parents": [ "1d2d8b1b6b359f5f476ef78662baa4b8782be530" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Aug 10 13:06:45 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Aug 10 13:06:45 2017 +0100" }, "message": "Revert^2 \"ART: Remove workaround in verifer after Jack update.\"\n\nThis reverts commit 7f7a074875114d0376923460948eb94eabaffe29.\n\nBug: 33099829\nTest: art/test.py --host\n" }, { "commit": "afb664701734c6edbea07431382ee33f1677d42b", "tree": "bd67954a08efb59e7bee75dfe46d1230abe4443b", "parents": [ "7f14c2ec37c70010d99cab6806d85018df56c555" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 01 09:54:49 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 02 14:58:10 2017 -0700" }, "message": "Fix verifier checks on interface methods.\n\nWe were disallowing interfaces in the IsInheritedMethod even though\nthe function can be called with them. This could cause some failing\nDCHECKS if the verifier cannot find methods in some situations.\n\nWe also fixed a small issue in the verifier where we allowed\nnon-public java.lang.Object methods to be considered valid for\ninterface dispatch.\n\nTest: ./test.py --host -j50\nTest: Compile an app with bad bytecodes (See bug)\nBug: 64158483\nBug: 64274113\nChange-Id: Ia79f25be0001efc4069a411a0b34476bd0871803\n" }, { "commit": "b45528c1f1b83ca8c970f439b54fbfcfda6908ea", "tree": "e8f493a7b21064d353d112ea1378d7819db385aa", "parents": [ "2c2e13ec24bff70db6e49270b9d4d787add9925e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 27 14:14:28 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 27 15:30:47 2017 +0100" }, "message": "ART: Refactor retrieval of types through ArtMethod.\n\nSplit Get*() functions that take a \"bool resolve\"\nargument into Lookup*() and Resolve*() functions.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: I0b7eaa1fadc2ffa8c0168203790467f91a126963\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "ba118827465d12177f3996e50133960087b1c916", "tree": "f39728cdafc7810004d51c0bef2728b98993daa9", "parents": [ "64a102dde8c5daad83b991710decb418ce43aac5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 12 15:41:56 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 20 13:35:06 2017 +0100" }, "message": "ART: Change method lookup to be more consistent to JLS and the RI.\n\nThe method lookup for different invoke types was previously\nwidely different and didn\u0027t work well with the dex cache\nmethod array where we have only a single slot for each\nMethodId. The new behavior is to perform the same lookup for\nall cases, distinguishing only between interface and\nnon-interface referencing class, and to further align the\nbehavior with the JLS and the RI. Where the JLS conflicts\nwith the RI, we follow the JLS semantics.\n\nThe new lookup for class methods first searches the methods\ndeclared in the superclass chain (ignoring \"copied\" methods)\nand only then looks in the \"copied\" methods. If the search\nin the superclass chain finds a method that has not been\ninherited (i.e. either a private method or a package-access\nmethod where one of the classes in the chain does not belong\nto the same package, see JLS 8.4.8), we still search the\n\"copied\" methods as there may actually be a method inherited\nfrom an interface. This follows the JLS semantics where\ninherited methods are included in the search (JLS 15.12.2.1)\nbut conflicts with the RI where the private or\npackage-access method takes precedence over methods\ninherited from interfaces.\n\nNote that this search can find an accessible method that is\nnot inherited by the qualifying type, either for a package\naccess method when the referrer is in the same package but\nthe qualifying type is in another package, or for a private\nmethod where the referrer is in the same class but the\nqualifying type is actually a subclass. For the moment we\nallow such calls and we shall consider whether to throw\nan IncompatibleClassChangeError in this situation in future\nto comply with JLS 15.12.4.3.\n\nThe new lookup for interface methods searches the interface\nclass, then all the superinterfaces and then the\njava.lang.Object class, see implicitly declared methods in\ninterfaces, JLS 9.2. The search for the maximally-specific\nnon-abstract superinterface method is not yet implemented,\nbut the difference should be difficult to observe as the\nusual subsequent call to FindVirtualMethodForInterface()\nshould yield the same result for any matching method.\n\nThe new test 162-method-idx-clash exposes several cases\nwhere we previously completely messed up due to the effects\nof the DexCache, or where we were out of line with the RI.\nIt also tests a case where the JLS and the RI disagree and\nwe follow the JLS.\n\nTest: art/test/run-test --host --jvm 162-method-resolution\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --interp-ac\nTest: Nexus 6P boots.\nTest: testrunner.py --target\nBug: 62855082\nBug: 30627598\nChange-Id: If450c8cff2751369011d649c25d28a482a2c61a3\n" }, { "commit": "631827d9b200c93f24816c6869d72426f9fed8e3", "tree": "9d5d768df39e21a2678d4b9148c5ec4d1c016911", "parents": [ "d64fbfa3471c47d6628d6014bc4a3ac780abd26a" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Apr 10 14:53:47 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Jul 04 11:57:13 2017 +0100" }, "message": "Fixes for constant method handles\n\nAdd support for constant direct and interface method handles in the\nDEX file.\n\nAdd error handling for field and method resolution failures in\nClassLinker::ResolveMethodHandle().\n\nBug: 36957105\nTest: art/test/run-test --host 952-invoke-custom-kinds\nChange-Id: I91a2a23ba3365310eccb8cadd193b62f57e5811c\n" }, { "commit": "e17cf243978ca7f5356e746ee460f0fcf04e04a6", "tree": "e8ad423bf1dee5756fec451ba22db749ed4f5472", "parents": [ "2bc159ebd1115f71d80639e47fc38663aa84ba4a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 19 11:05:51 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 19 11:11:12 2017 -0700" }, "message": "Add field/method skipping helper functions to DexFile\n\nSpecifically added SkipStaticFields, SkipInstanceFields,\nSkipAllFields, SkipStaticMethods, and SkipVirtualMethods.\n\nAlso applied the helpers to the code base.\n\nTest: test-art-host\nChange-Id: Idda77f9a6e2564c2e588d2bbe11cc320063fdb32\n" }, { "commit": "542bbf760b4f0b94e1e93ddad3e4d8d318705ab6", "tree": "40db8c70268c6eb6cfcc10a0bc16a65e8d0b7b28", "parents": [ "0fd04a8b3ccde0c0bc17d8845a336207ec19c66e", "bf1cb77aa155d53808b4f65bac34deb3ce4bbf6d" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Jun 02 23:21:18 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 02 23:21:19 2017 +0000" }, "message": "Merge \"ART: Use templates for VerifyInstruction\"" }, { "commit": "513061a792b22c417c938d31c19581390709561c", "tree": "80b4fdce03711170626aa5640d07b07de4a326a1", "parents": [ "38c4ae5f4c5a033b7a7441032f39ea58f5772d4c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 09:17:34 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 12:59:13 2017 -0700" }, "message": "ART: Clean up thread.h and thread_list.h\n\nRemove dependency on stack.h and gc_root.h. Remove unused object\ncallbacks include. Factor out ManagedStack into its own set of files.\nFix up users of transitive includes.\n\nTest: m test-art-host\nChange-Id: I01286c43d8c7710948c161b1348faabb05922e59\n" }, { "commit": "bf1cb77aa155d53808b4f65bac34deb3ce4bbf6d", "tree": "bc134f3cc9117314ea87557d4e5c7ca44dc470da", "parents": [ "29e814295e363bebd155a51d5bfdc9281099bdff" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 15:39:00 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 30 14:29:54 2017 -0700" }, "message": "ART: Use templates for VerifyInstruction\n\nUse a template parameter instead of an explicit one.\n\nBug: 10921004\nTest: m test-art-host\nChange-Id: If0c21a8b902428456e445728afd443f0c88588df\n" }, { "commit": "29e814295e363bebd155a51d5bfdc9281099bdff", "tree": "b55b96e92a44fe75586fa01f536c9a06316aa376", "parents": [ "1171deea4cb2f2db67a310ea8797d06206b2bdea" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 16:29:32 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 30 14:29:54 2017 -0700" }, "message": "ART: Add some UNLIKELY in the verifier\n\nHint to the compiler that we assume that dex code is well-formed.\n\nBug: 10921004\nTest: m test-art-host\nChange-Id: If04a8392c7160747cd57da38ca785cdc18212d55\n" }, { "commit": "74979b1a78a6d66fbdcf0545f17004cced69f196", "tree": "59d2f91930470998f20021378da903587570217b", "parents": [ "b3937e31102538baf27a6e9088638c5e3ff1ca34" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 16 09:28:06 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 16 09:54:22 2017 -0700" }, "message": "ART: Add UNLIKELY in verifier\n\nINVOKE_POLYMORPHIC is unlikely, at this point. Perf shows compiler\noptimizations assuming the branch is taken.\n\nBug: 10921004\nTest: m test-art-host\nChange-Id: I161327d5c0399de75ff3fc79fa4d762cadbffe20\n" }, { "commit": "1189516011d310c3d1aed469dd592ad2535f4921", "tree": "d819e8e8565aff6702c749d9a80861f96f6d5d35", "parents": [ "ae08cc2c29f40d5028303390325d991b28a50d8a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 10:25:02 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 10:58:01 2017 -0700" }, "message": "ART: Cache AoT state in verifier\n\nCache the runtime-only-instruction flag instead of computing it for\nevery single instruction.\n\nBug: 10921004\nTest: m test-art-host\nChange-Id: I417260ddf73ac714083609b292f036c28227a0b2\n" }, { "commit": "e05cc662505e13f0c29e777bd99b7f49db9c670b", "tree": "fa094ed3b9e8340fc1bf48538b49be343e5c66c7", "parents": [ "6fb693a39b263af3e62b97f8d9f2c2289cab3c1a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 10:17:30 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 10:57:33 2017 -0700" }, "message": "ART: Add experimental constexpr\n\nAdd a constexpr flag to bypass a branch in the verifier when there\nare no experimental dex instructions. Guarantee the value with\nstatic_asserts.\n\nBug: 10921004\nTest: m test-art-host\nChange-Id: Ib77b6142c4d2debe4b4d4fec60c02d92b1e7349f\n" }, { "commit": "6fb693a39b263af3e62b97f8d9f2c2289cab3c1a", "tree": "59487355e5e81ae552c0f00ab36f8eb16bac25a6", "parents": [ "ed00ddb614d68559931d831cb74d3ba8f01599c9" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 08:49:45 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 15 10:25:32 2017 -0700" }, "message": "ART: Delete dex_instruction_visitor\n\nUnused visitor and test.\n\nTest: m test-art-host\nChange-Id: Idb9403a1d41b6b2142b1e10cd9172a1771d6c5be\n" }, { "commit": "4e868fa7b8c47600695ff92deeb373674956a67d", "tree": "acdb92a2b765cc87a08459267e430a8866e608cf", "parents": [ "4dc06e2ef900132d8395539842c35533da8b912a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 21 17:16:44 2017 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Apr 27 16:04:13 2017 +0100" }, "message": "Make vdex and dexlayout compatible.\n\nUnquicken the vdex before dexlayout, to keep the dex integrity.\n\nbug: 37558732\nTest: run-test with speed-profile\n\nChange-Id: Ifcd5c2e4378ccb0df0a66d07f68df31d94b83220\n" }, { "commit": "6d7abbd2324f544c6b6da42bb6b9b531df0ce3cd", "tree": "669705a042bbc77c7963c117a9bf6f7a2308f9c8", "parents": [ "0dfc315a096bf5678cb5182771e3fdcca8ea4433" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 24 13:19:09 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Apr 24 14:18:45 2017 -0700" }, "message": "ART: More header cleanup - method_verifier.h\n\nMove enumerations to own header. Move the compiler interface (of what\nthe compiler can tolerate) into its own header. Replace or remove\nmethod_verifier.h where possible.\n\nTest: mmma art\nChange-Id: I075fcb10b02b6c1c760daad31cb18eaa42067b6d\n" }, { "commit": "5a0336dd8926e1ddee517f7bf39fd6ed3c68f656", "tree": "d04da8c615716cabac429319a124b013ff0a39e4", "parents": [ "7b96e726420f56e489dc1da929737171cf008986", "3a842f5adcbdeb3fd3db4206006a784ccabfc865" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Apr 24 08:03:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Apr 24 08:03:44 2017 +0000" }, "message": "Merge \"ART: Add method verifier check for call site id\"" }, { "commit": "3a842f5adcbdeb3fd3db4206006a784ccabfc865", "tree": "3aaa5a0d63cd1c588c4a381db0b9c3ab7e0b68c5", "parents": [ "6d3c61d8c6d2f96dec8345263c948fae3caa4e1a" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Apr 21 15:24:10 2017 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Apr 21 15:24:10 2017 +0100" }, "message": "ART: Add method verifier check for call site id\n\nBug: 37248626\nTest: dex2oat on bug data\nChange-Id: Iaccd39ae9d4b3ab5134f7b5a9063a7efa2cab498\n" }, { "commit": "9cb0c46402117e5fa83680289c8c097041296fb6", "tree": "e315160be2ee9052e460d6b4b2f9b825057ff0f4", "parents": [ "38870a8a2717ccf1bcd3faddc53b1999985bb29f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Apr 21 13:31:41 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Apr 21 13:54:00 2017 +0100" }, "message": "Fix verifier crash on abstract final class.\n\nRemove a check for erroneous class. It should not matter to\nthe verifier whether the class is just resolved, initialized\nor resolved erroneous. The check was also inherently racy\nand could yield different behavior based on the timing of\nthe verification.\n\nTest: 161-final-abstract-class\nTest: testrunner.py --host\nBug: 37248840\nChange-Id: Ic4d964050bbe52e3de4438ada9e75676956cb6b4\n" }, { "commit": "8d6768d47b66a688d35399d524ad5a5450e9d9d4", "tree": "0b8733baef378d9e060c8e74319a3846489590b2", "parents": [ "fbe1516b91f2117bb9c7282aaea5537572f62dd7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 10:13:21 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 13:55:13 2017 +0000" }, "message": "Revert^6 \"Hash-based dex cache type array.\"\n\nFixed ImageWriter to write class table also if it contains\nonly boot class loader classes. Added a regression test and\nadded extra checks for debug-build to verify that dex cache\ntypes from app image are also in the class table. Removed\nsome unnecessary debug output.\n\nTest: 158-app-image-class-table\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 0b66d6174bf1f6023f9d36dda8538490b79c2e9f.\n\nChange-Id: I6a747904940c6ebc297f4946feef99dc0adf930c\n" }, { "commit": "0b66d6174bf1f6023f9d36dda8538490b79c2e9f", "tree": "1cc4d2ae868745a65fd0489a6fb2f5f2fc9e880f", "parents": [ "6374c58f2ea403b3a05fb27376110fe4d0fc8e3f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 14:50:04 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 16:08:01 2017 +0000" }, "message": "Revert^5 \"Hash-based dex cache type array.\"\n\nFor app images, ImageWriter does not add boot image\nclasses to the app image class table even though it\nkeeps them in the dex caches. The reason for that is\nunknown, the code looks OK.\n\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nAlso reverts \"Improve debugging output for a crash.\"\n\nThis reverts commits\n bfb80d25eaeb7a604d5dd25a370e3869e96a33ab,\n 8dd56fcb3196f466ecaffd445397cb11ef85f89f.\n\nTest: testrunner.py --host\nChange-Id: Ic8db128207c07588c7f11563208ae1e85c8b0e84\n" }, { "commit": "bfb80d25eaeb7a604d5dd25a370e3869e96a33ab", "tree": "96068dd9b9b3bc2e1bcc25d38bbd2420d5b0f1bb", "parents": [ "7a49d93ee265b978ab29cae659e46d41da78459a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 14 14:08:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 20 14:13:14 2017 +0000" }, "message": "Revert^4 \"Hash-based dex cache type array.\"\n\nAdded extra output to the abort message to collect more data\nwhen we hit the crash. Added extra check when loading an app\nimage to verify that the class table isn\u0027t already broken.\n\nTest: testrunner.py --host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5.\n\nChange-Id: I9bb442a184c236dcb75b3e42a095f39cd6bee59d\n" }, { "commit": "c069a30d42aefd902c20e8bc09dfad1683f07ded", "tree": "8bbf72bea7ea5d243b57f8e0ab64b687a9f60e4b", "parents": [ "3f38398380b80d1ded078ebed1211b7e4f51460f" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 18 09:23:12 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Feb 14 14:04:33 2017 +0000" }, "message": "ART: invoke-custom support\n\nAdds invoke-custom instruction to the interpreter.\n\nBug: 33191717,30550796\nTest: art/test/run-test --host 952\nChange-Id: I3b754128649a8b3a00ade79ba2518d0e377f3a1e\n" }, { "commit": "5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5", "tree": "be0e9fdeb90bcbad76b17b3aae4e746d977d80ee", "parents": [ "518f373324f355f8e58440dfbc3f5a1f2244bde7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 18:32:04 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 19:34:54 2017 -0800" }, "message": "Revert^3 \"Hash-based dex cache type array.\"\n\nAssert failing for \"earchbox:search\":\nF zygote64: class_linker.cc:4612] Check failed: handle_scope_iface.Get() !\u003d nullptr\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 85c0f2ac03417f5125bc2ff1dab8109859c67d5c.\n\nChange-Id: I39846c20295af5875b0f945be7035c73ded23135\n" }, { "commit": "85c0f2ac03417f5125bc2ff1dab8109859c67d5c", "tree": "844952d237e35faa5c5a2357ab037366c8397115", "parents": [ "8d4b1189639f0d8982bde681ccbdd7c03fe6ddbf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 02 16:42:38 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Feb 10 11:23:11 2017 +0000" }, "message": "Revert^2 \"Hash-based dex cache type array.\"\n\nThe reason for the revert was fixed by\n https://android-review.googlesource.com/332666 .\nWe now enable clearing dex cache types in test 155 from that\nCL. Also avoid an unnecessary store in LookupResolvedTypes()\nand prevent verifier from messing up the dex cache types.\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit d16363a93053de0f32252c7897d839a46aff14ae.\n\nChange-Id: Ie8603cfa772e78e648d005b0b6eae59062ae729d\n" }, { "commit": "fcbafb36eff1facdd4c2b60e5f56dd986c558901", "tree": "443a55d0ac3698e7eaf82395d6f3567b35d8474d", "parents": [ "406402baa4900c36b3fe27b03bf9e04e978e50be" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Feb 02 15:09:54 2017 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Feb 02 15:32:25 2017 -0800" }, "message": "Ensure we don\u0027t attempt to compile obsolete methods.\n\nWe would run into issues if we tried to compile an obsolete method\nsince some of the information needed to do so is lost as we redefine\nthe declaring class. Since compiling these methods is unlikely to have\na major effect on the performance of the program we simply tell the\nJIT not to bother with them.\n\nAlso update all places to use the new SetDontCompile helper.\n\nTest: mma -j40 test-art-host\nTest: stress --cpu 60 \u0026; \\\n while ./test/run-test --host --jit --gcstress --64 942; do ; done\n\nChange-Id: Ie70fee6f503818e7589571facf28ccc5e7ca79f8\n" }, { "commit": "d16363a93053de0f32252c7897d839a46aff14ae", "tree": "8823c6dd4641eae333aa7001203460757a515010", "parents": [ "ac240396125911b52437a460a400c8b38be43a96" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 01 14:09:13 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 01 15:27:37 2017 +0000" }, "message": "Revert \"Hash-based dex cache type array.\"\n\nReverting to work around some programs crashing with\n Check failed: handle_scope_iface.Get() !\u003d nullptr.\nthough the reason for the failure not yet understood.\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\nBug: 30419309\n\nThis reverts commit ec7862283dd49f5a58d0ac45960ce27c2f7671b8.\n\nChange-Id: Ifded663633082f1e59e5b6ff2e026dc559bd6b82\n" }, { "commit": "ec7862283dd49f5a58d0ac45960ce27c2f7671b8", "tree": "26d6dcc1d5ed4f0ba5ac15f17ef7377215684bf6", "parents": [ "c01d49091f4588777db5bf45345f388058caa99f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 20 16:24:13 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 30 10:21:16 2017 +0000" }, "message": "Hash-based dex cache type array.\n\nTest: m test-art-host (Interpreter, Optimizing, JIT)\nTest: m test-art-target on Nexus 6P (Interpreter, Optimizing, JIT)\nTest: Nexus 6P boots\nTest: m valgrind-test-art-host\nBug: 30627598\nBug: 34659969\nBug: 30419309\nChange-Id: Ic00eda89e58088a3573fc9ec0ad04c0e69e161d1\n" }, { "commit": "942fd3130254d8276cbfe8e6201825e9c49e9b2c", "tree": "62dbcd85ab150604e2d72a3c2d0c3639a28c9b7a", "parents": [ "8bd59a0fd46db83616785168231e09fb95ed2ead" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 16 20:52:19 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jan 17 16:12:15 2017 +0000" }, "message": "Reduce using ArtMethod\u0027s dex_cache_resolved_types_.\n\nAvoid using the ArtMethod\u0027s dex cache type array shortcut\nin runtime, preparing for its removal. We do not completely\nremove the shortcut yet because it is still used by array\nallocation entrypoints.\n\nFix ArgArray::BuildArgArrayFromObjectArray in reflection.cc\nto not ask for the parameter type to be resolved. It should\nhave been previously resolved when retrieving the Method.\n\nAlso partially revert\n https://android-review.googlesource.com/310717\nbecause it relied on the removed AIOOBE check in the removed\nArtMethod::GetDexCacheResolvedType(). The removed check was\nsimply defensive but it could not be triggered without some\nmemory corruption.\n\nTest: m test-art-host\nBug: 30627598\nChange-Id: Ic45a5ff8c66b79429e440cbc08d67bf22a083682\n" }, { "commit": "ac141397dc29189ad2b2df41f8d4312246beec60", "tree": "a2f481463a14695bf9327fd2f549878ecf30c77b", "parents": [ "5c9f90c5ecf2ff6f93ada0f7b18b46d866c59ea1" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Jan 13 11:53:47 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Sun Jan 15 15:18:07 2017 +0000" }, "message": "Revert \"Revert \"ART: Compiler support for invoke-polymorphic.\"\"\n\nThis reverts commit 0fb5af1c8287b1ec85c55c306a1c43820c38a337.\n\nThis takes us back to the original change and attempts to fix the\nissues encountered:\n\n- Adds transition record push/pop around artInvokePolymorphic.\n- Changes X86/X64 relocations for MacSDK.\n- Implements MIPS entrypoint for art_quick_invoke_polymorphic.\n- Corrects size of returned reference in art_quick_invoke_polymorphic\n on ARM.\n\nBug: 30550796,33191393\nTest: art/test/run-test 953\nTest: m test-art-run-test\n\nChange-Id: Ib6b93e00b37b9d4ab743a3470ab3d77fe857cda8\n" }, { "commit": "0fb5af1c8287b1ec85c55c306a1c43820c38a337", "tree": "66239e7f745fae54e1630e91fb44a859bff615d6", "parents": [ "02e3092f8d98f339588e48691db77f227b48ac1e" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 18:58:15 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 19:17:33 2017 +0000" }, "message": "Revert \"ART: Compiler support for invoke-polymorphic.\"\n\nThis reverts commit 02e3092f8d98f339588e48691db77f227b48ac1e.\n\nReasons for revert:\n\n- Breaks MIPS/MIPS64 build.\n- Fails under GCStress test on x64.\n- Different x64 build configuration doesn\u0027t like relocation.\n\nChange-Id: I512555b38165d05f8a07e8aed528f00302061001\n" }, { "commit": "02e3092f8d98f339588e48691db77f227b48ac1e", "tree": "127dd23346206b0547b7c6453a776253252b3c6e", "parents": [ "bc7d0deda4549f314e68ee3e0e6afd68c4a8fd06" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Dec 01 10:33:51 2016 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 16:26:43 2017 +0000" }, "message": "ART: Compiler support for invoke-polymorphic.\n\nAdds basic support to invoke method handles in compiled code.\n\nEnables method verification for methods containing invoke-polymorphic.\n\nAdds k45cc/k45rc output to Instruction::DumpString() which\nwas found to be missing when enabling verification.\n\nInclude stack traces in test 957-methodhandle-transforms for\nfailures so they can be easily identified.\n\nBug: 30550796,33191393\nTest: art/test/run-test 953\nTest: m test-art-run-test\nChange-Id: Ic9a96ea24906087597d96ad8159a5bc349d06950\n" }, { "commit": "857f058d4b7bd07c5c99eda416ad91516a10b4da", "tree": "aafff6fc7ac9578955661366e779c858945ae71c", "parents": [ "0966558b075b9b454e1a7864306eb206bf0c0094" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Tue Dec 20 14:36:59 2016 +0000" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Tue Dec 20 16:15:24 2016 +0000" }, "message": "Fix JIT crash due to unverified dead code\n\nThe JIT compiler assumes that it only gets completely verified code. To\nwork around potential unverified dead code it uses kAccDontBotherCompile\nflag set during runtime verification. However, if a class is verified\nduring a prior dex2oat the flag is not persisted and JIT happily things\nthat everything is ok.\n\nThe simplest fix is to mark classes with potential unverified dex code\nas verify at runtime. We only do this for apps and assume that\neverything in the boot image is well formed.\n\nTest: m test-art-host\nBug: 31000839\nChange-Id: I092d2e9553cd1c577036d78e8563a7a39d6cb7b9\n" }, { "commit": "ad0c8bdc2c2e4d2a469455bcde7aeb5fc7482875", "tree": "fe5fe711a574386472408bda17b13a2ca2668c7e", "parents": [ "132eb43396bdb0b9bdacf069289f019d85d358fc" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 19 19:31:26 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 19 19:31:26 2016 +0000" }, "message": "Revert \"Fix JIT crash due to unverified dead code\"\n\nBroke method_verifier_test and image_test.\n\nBug: 31000839\n\nThis reverts commit 132eb43396bdb0b9bdacf069289f019d85d358fc.\n\nChange-Id: I85923e6bdb3e76f54978658aad816d4c79fc339e\n" }, { "commit": "132eb43396bdb0b9bdacf069289f019d85d358fc", "tree": "097ad8979e90555fd46e49eda32fe4b0c579acfd", "parents": [ "71464a10a434e5b8aac75998d08b2cdcbce57bab" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Fri Oct 28 20:09:56 2016 +0100" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Mon Dec 19 15:36:41 2016 +0000" }, "message": "Fix JIT crash due to unverified dead code\n\nThe JIT compiler assumes that it only gets completely verified code. To\nwork around potential unverified dead code it uses kAccDontBotherCompile\nflag set during runtime verification. However, if a class is verified\nduring a prior dex2oat the flag is not persisted and JIT happily things\nthat everything is ok.\n\nThe simplest fix is to mark classes with potential unverified dex code\nas verify at runtime. We only do this for apps and assume that\neverything in the boot image is well formed.\n\nTest: m test-art-host-706-jit-skip-compilation\nBug: 31000839\n\nChange-Id: Ib73de1888581bb7202474cfd7aca70af4cc2cc00\n" }, { "commit": "46ee31b67d7ee1bd085fbc240502053caa3cf8fa", "tree": "83e870f293cd60d533207e389d7b094acd87b31f", "parents": [ "9538f9e2a5d03f1b1bc07ebfbd93b61dcf8ad604" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 14 10:11:49 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 15 09:50:39 2016 -0800" }, "message": "ART: Move to libbase StringPrintf\n\nRemove ART\u0027s StringPrintf implementation. Fix up clients. Add\nmissing includes where necessary.\n\nTest: m test-art-host\nChange-Id: I564038d5868595ac3bb88d641af1000cea940e5a\n" }, { "commit": "7f7a074875114d0376923460948eb94eabaffe29", "tree": "b14d2cda6829419fae548584d07d962968271d80", "parents": [ "1aab04df52529d3cabe28fd9f0cb008bf8180a56" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Dec 08 14:15:25 2016 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Dec 08 14:15:25 2016 +0000" }, "message": "Revert \"ART: Remove workaround in verifer after Jack update.\"\n\nThis reverts commit 1aab04df52529d3cabe28fd9f0cb008bf8180a56.\n\nChange-Id: Ifecad6a16f2c6dfeea99adcdca7da05fb71592a8\n" }, { "commit": "1aab04df52529d3cabe28fd9f0cb008bf8180a56", "tree": "ac1ac451752b8e22934877a1083919fd3e0c2051", "parents": [ "0bdba6c3017f2b3602b1e6fe5c9b8717d800791c" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Dec 08 10:29:53 2016 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Dec 08 10:29:53 2016 +0000" }, "message": "ART: Remove workaround in verifer after Jack update.\n\nBug: 33099829,30550796\nTest: m test-art-host\nChange-Id: I812809e7f043ec2a9651f22e970312e094b78966\n" }, { "commit": "c571e73e21202cff0a8ec3bcfecb7d326e8648ef", "tree": "905cb5252b8bc8c335f569c869dfb8529301f40c", "parents": [ "edcd7929e2bf521316fa5305109c330d563d87db", "cfa325e4ca65603fdb03a836a6cb394d23ed511f" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Dec 02 11:52:14 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 02 11:52:15 2016 +0000" }, "message": "Merge \"ART: Add verifier support for invoke-polymorphic.\"" }, { "commit": "cfa325e4ca65603fdb03a836a6cb394d23ed511f", "tree": "f14e628cc90f7b03f8f227a30361993f3f594f11", "parents": [ "35b6546b0a4fe423ed6f27d8c5b709d5191e99ef" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Oct 13 10:25:54 2016 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Dec 02 10:09:40 2016 +0000" }, "message": "ART: Add verifier support for invoke-polymorphic.\n\nChange-Id: I1e1860cad80db46320c3ef5a9eaceb7529ea68d7\nBug: 30550796,33099829,33191712\nTest: make test-art-host\n" }, { "commit": "063fc772b5b8aed7d769cd7cccb6ddc7619326ee", "tree": "bc165781989087a998721991504e589a7d5b0926", "parents": [ "48d08a4233ee4450b0d5073d41445f9dd1f17191" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Tue Aug 02 11:02:54 2016 -0700" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Thu Dec 01 11:15:47 2016 -0800" }, "message": "Class Hierarchy Analysis (CHA)\n\nThe class linker now tracks whether a method has a single implementation\nand if so, the JIT compiler will try to devirtualize a virtual call for\nthe method into a direct call. If the single-implementation assumption\nis violated due to additional class linking, compiled code that makes the\nassumption is invalidated. Deoptimization is triggered for compiled code\nlive on stack. Instead of patching return pc\u0027s on stack, a CHA guard is\nadded which checks a hidden should_deoptimize flag for deoptimization.\nThis approach limits the number of deoptimization points.\n\nThis CL does not devirtualize abstract/interface method invocation.\n\nSlides on CHA:\nhttps://docs.google.com/a/google.com/presentation/d/1Ax6cabP1vM44aLOaJU3B26n5fTE9w5YU-1CRevIDsBc/edit?usp\u003dsharing\n\nChange-Id: I18bf716a601b6413b46312e925a6ad9e4008efa4\nTest: ART_TEST_JIT\u003dtrue m test-art-host/target-run-test test-art-host-gtest\n" }, { "commit": "a5b09a67034e57a6e10231dd4bd92f4cb50b824c", "tree": "304be738f4fa528b7ad2676103eecc84c79eaeeb", "parents": [ "dac7ad17c78387d15d7aefae0f852dddf5f37e34" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Nov 17 15:21:22 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 21 10:57:00 2016 -0800" }, "message": "ART: Add dex::TypeIndex\n\nAdd abstraction for uint16_t type index.\n\nTest: m test-art-host\nChange-Id: I47708741c7c579cbbe59ab723c1e31c5fe71f83a\n" }, { "commit": "f8f36c246ee46522a7446e6f3a155e0fc5c7b859", "tree": "f202c1fe8aa1ae1a8b4f3d609ad4a011f7ffca4b", "parents": [ "320ba91911c840528893e07b0af43d317cd4c9aa" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Sat Nov 19 14:51:52 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Sat Nov 19 14:57:56 2016 -0800" }, "message": "ART: Do not DCHECK in verifier when already aborting\n\nOnly log an error in FailOrAbort in the debug build when the\nruntime is already aborting.\n\nTest: m test-art-host\nChange-Id: I240f8bb7695e42d60b5805ebae2ab9dc72e5fdb1\n" }, { "commit": "5c657fe8e3afdce77dc610446f37a43865cff702", "tree": "1f9fe466058b7512036b27a5b22f7720eb00729d", "parents": [ "2ab98309c0fc7b3c7451205b2371db5c34b05d49" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 03 15:12:29 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 03 15:13:06 2016 +0000" }, "message": "Pass some arguments by const reference.\n\nTest: Rely on TreeHugger.\nBug: 32619234\nChange-Id: Ia26277893641dcb3562eaeacaec4e089a978d56a\n" }, { "commit": "709b070044354d9f47641f273edacaeeb0240ab7", "tree": "3a8ac051d7c35076303984d0d892cdd396b60427", "parents": [ "1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 13 09:12:37 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Oct 18 14:10:04 2016 -0700" }, "message": "Remove mirror:: and ArtMethod deps in utils.{h,cc}\n\nThe latest chapter in the ongoing saga of attempting to dump a DEX\nfile without having to start a whole runtime instance. This episode\nfinds us removing references to ArtMethod/ArtField/mirror.\n\nOne aspect of this change that I would like to call out specfically\nis that the utils versions of the \"Pretty*\" functions all were written\nto accept nullptr as an argument. I have split these functions up as\nfollows:\n1) an instance method, such as PrettyClass that obviously requires\nthis !\u003d nullptr.\n2) a static method, that behaves the same way as the util method, but\ncalls the instance method if p !\u003d nullptr.\nThis requires using a full class qualifier for the static methods,\nwhich isn\u0027t exactly beautiful. I have tried to remove as many cases\nas possible where it was clear p !\u003d nullptr.\n\nBug: 22322814\nTest: test-art-host\nChange-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24\n" }, { "commit": "8ee0b085bed13105c2ecc9caeb025eb758bcb27d", "tree": "2e53573d42f50baa32fa63a23734ff4ed662023d", "parents": [ "d3a9ce9d30a59587413310e66ea51c8f7adb0a1d", "9823e788ed3368ecf826c44bfa16ccabfcbe32f8" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Oct 05 12:19:30 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Oct 05 12:19:30 2016 +0000" }, "message": "Merge \"Basic implementation of invoke / invoke-polymorphic.\"" }, { "commit": "9823e788ed3368ecf826c44bfa16ccabfcbe32f8", "tree": "59dee92dfd7518a98905c8313bdcb0a2ca2946cb", "parents": [ "82d4838d6bb3480cd25327cedc5179fb2d86881c" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Wed Aug 03 12:46:58 2016 +0100" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Wed Oct 05 10:34:59 2016 +0100" }, "message": "Basic implementation of invoke / invoke-polymorphic.\n\nBasic switch interpreter support for invoke-polymorphic. This change\nallows for virtual/interface and static invokes on method handles.\n\nSupport for direct invokes (including constructors) and field\ngetters and setters will be added in follow up changes.\n\nBug: 30550796\nTest: make test-art-host\n\nChange-Id: Ieb3a991d974060d930d56467908d5c7c11d0e38e\n" }, { "commit": "1cc62e4ea24828fdb3f3da0b8603f0b107d09a04", "tree": "718e322f3d05ac095770d4dc2a68b824bf3974a7", "parents": [ "82d4838d6bb3480cd25327cedc5179fb2d86881c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 03 18:01:28 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 04 10:46:16 2016 -0700" }, "message": "Rename ObjPtr::Decode to ObjPtr::Ptr\n\nDone to prevent ambiguity with ScopedObjectAccess::Decode.\n\nBug: 31113334\n\nTest: test-art-host\nChange-Id: I07a2497cc9cf66386311798933547471987fc316\n" }, { "commit": "3398c7874e002beaa6c2b2fadf183e7d1ddad23a", "tree": "7db754b5b0c3a6c68bc1f91d7cb2477f534d2ad3", "parents": [ "462e21cc8d28a4d48342cf0f634bd1ecc63647d7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 30 10:27:43 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 03 14:06:27 2016 -0700" }, "message": "Move ArtField to ObjPtr\n\nAdded EXPECT_OBJ_PTR_EQ and variants to gtests.\n\nFixed moving GC bugs in:\nClassLinker::CreatePathClassLoader\nClassLinkerTest: StaticFields\n\nObjPtr Decode call sites: 186 -\u003e 181.\n\nSome tests fail due to ResolvedFieldAccessTest, will fix in follow\nup CL.\n\nBug: 31113334\n\nTest: test-art-host CC baker\n\nChange-Id: I8b266ad00f3c20c8cbe7cfdf280d175083df0b88\n" }, { "commit": "0795f23920ee9aabf28e45c63cd592dcccf00216", "tree": "ff3f880c5e84f3316532b47d0e9a7729ade848ac", "parents": [ "d1224dce59eb0019507e41da5e10f12dda66bee4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 27 18:43:30 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 29 17:31:09 2016 -0700" }, "message": "Clean up ScopedThreadStateChange to use ObjPtr\n\nAlso fixed inclusion of -inl.h files in .h files by adding\nscoped_object_access-inl.h and scoped_fast_natvie_object_access-inl.h\n\nChanged AddLocalReference / Decode to use ObjPtr.\n\nChanged libartbenchmark to be debug to avoid linkage errors.\n\nBug: 31113334\n\nTest: test-art-host\n\nChange-Id: I4d2e160483a29d21e1e0e440585ed328b9811483\n" } ], "next": "3fec9ac0d5af1358d216eb2fdc2000ec0205f3f0" }