)]}' { "log": [ { "commit": "119733d87242414100df7b9eedb6d1672a03ead6", "tree": "19ba75bd42d3c94a4de0684ae66f4078da1546a6", "parents": [ "8a64e773d4d1221166c6a8206315b450e448705a" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 15:14:41 2019 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jan 31 15:39:55 2019 +0000" }, "message": "Revert \"Revert \"ART: introduce PALette abstraction layer\"\"\n\nThis reverts commit e6e01a0a00de80704ccb21c48d5d8bdee4470b77.\n\nBug: 122824298\nTest: art/test/testrunner/run_build_test_target.py -j50 art-test-javac\nTest: m out/target/common/obj/PACKAGING/hiddenapi-stub-flags.txt\nTest: frameworks/rs/build_rs.py\nChange-Id: If7b9ddca3daa80b75b3541abd283bf47d5b81118\n" }, { "commit": "e6e01a0a00de80704ccb21c48d5d8bdee4470b77", "tree": "8f9cc651764686140accaadcfb8f77bf7572c24b", "parents": [ "4b9d00aca9b025b545c9633b4605334c22fc4d2d" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 14:02:30 2019 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 14:02:30 2019 +0000" }, "message": "Revert \"ART: introduce PALette abstraction layer\"\n\nThis reverts commit 4b9d00aca9b025b545c9633b4605334c22fc4d2d.\n\nReason for revert: breaks renderscript mac and run_host_tests in master.\n\nChange-Id: I6024894a384c65f3e7d81b9c5bba8ebe8ce1b420\n" }, { "commit": "4b9d00aca9b025b545c9633b4605334c22fc4d2d", "tree": "7984bf247f908d145b7c6b48df99f3f0a80ae148", "parents": [ "4ee4561f2153f3b0bc3be2e781488a97c73ca58e" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Jan 03 17:04:02 2019 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 30 09:00:27 2019 +0000" }, "message": "ART: introduce PALette abstraction layer\n\nThis change decouples direct dependencies on system libraries.\n\nBug: 122824298\nTest: art/test.py --host --64\nTest: art/test.py --target -j8\nTest: m -j100 \u0026 flashall -w \u0026 device boots\nTest: art/build/apex/runtests.sh\nChange-Id: Iae927ed9aaa228a941cd444cef04e6ec53955299\n" }, { "commit": "ea34d46b421c8ad7a226f0c094e717464bb141eb", "tree": "110f287312d04570341d9823579fe34687dce072", "parents": [ "b8f88f33b5ad0a593e5c63beab45d05f4c791bf4" ], "author": { "name": "Lokesh Gidra", "email": "lokeshgidra@google.com", "time": "Mon Jan 28 17:23:04 2019 -0800" }, "committer": { "name": "Lokesh Gidra", "email": "lokeshgidra@google.com", "time": "Mon Jan 28 17:23:04 2019 -0800" }, "message": "Fix lock order issue with large-object space lock\n\nWe have a code-path where GC thread acquires large-object space lock (a\nhigher level lock) after acquire JNI global lock (a lower level lock).\nMoving AllocSpaceLock to be lower than JniGlobalsLock to fix this.\n\nBug: 120782890\nTest: art/test/testrunner/testrunner.py --host\nChange-Id: I4f169c779cb17f6c14f6e5278857845f9904e62c\n" }, { "commit": "8764dc3b3eda7f6f13ed7b584475503fe5bedd59", "tree": "e8f6e3a4a2596595ffdc8a517daaf37030482eae", "parents": [ "49b74a8c685acfe43dd33e3f51a24c486388bee1" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jan 07 15:20:12 2019 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 09 12:38:30 2019 -0800" }, "message": "ART: Use iosfwd more\n\nUse iosfwd where an include of ostream is unnecessary. Also move\ncallee_save_type.h to runtime.\n\nBug: 119869270\nTest: mmma art\nChange-Id: Id8995d6f524e4c491eb6f57fdffb940cf35d291f\n" }, { "commit": "5a0430d0239481f4efb252d60ec9641703b8d456", "tree": "cd7bdb45d94e7af3aa3e1bbb5958f930bcee29f6", "parents": [ "b9b995738c8f53d68446d14553c1befd487877e7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jan 04 14:33:57 2019 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 09 12:38:20 2019 -0800" }, "message": "ART: Introduce runtime_globals\n\nSplit libartbase\u0027s globals.h into actual globals, and runtime-\ndependent globals which should live in runtime.\n\nBlanket-convert all runtime/ inclusions.\n\nIn future CLs, the number of global constants should be reduced.\nFor example, GC types are only relevant to GC/alloc functionality.\n\nBug: 119869270\nTest: mmma art\nChange-Id: I2d8cd32e0e7ab4084d2f2e96864b5338a78da94e\n" }, { "commit": "ada33d754fdc987e2658a7bab38f5ca7c70f266c", "tree": "e588bba5ec19664e0b035a0d1cd43c96da6c05bd", "parents": [ "e29b950562bae79fe8eb22e13a9cb533c9d8c5d0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 17 13:17:30 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 19 16:54:23 2018 -0800" }, "message": "Move startup thread pool back into runtime\n\nAdded logic in heap trim to delete the thread pool, if there are no\nactive users.\n\nAdded a scoped accessor to prevent ref counting errors.\n\nMotivation, have workers already created when the app images are\nloaded.\n\nBug: 116052292\nTest: test-art-host\nChange-Id: I8ea776d74e88601222a9989e0c6dac34cf77c683\n" }, { "commit": "0bbac3089b5637103585b04774eea3d959c4f24d", "tree": "62685295f10f87548d4a14996f384e943645130d", "parents": [ "365a64b2085392f4d625725793f10f50f191853c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Nov 30 09:44:12 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 06 11:37:19 2018 -0800" }, "message": "ART: Hide mutex in TimingLogger\n\nEnsure that timing_logger.h does not pull in mutex.h.\n\nBug: 119869270\nTest: m test-art-host\nChange-Id: I84b92dbc435a3f273f3dc519bbf7948220636c2f\n" }, { "commit": "7fbc4a59ba2e60d869313d7961662430df83b2cb", "tree": "59520285df8d2075412ddc566a0d4d96d4c7e109", "parents": [ "7cc45fd1dbcf5704e442d0443e437aa2ae3fe21b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 28 08:26:47 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 06 11:37:19 2018 -0800" }, "message": "ART: Move to using locks.h instead of mutex.h\n\nWhen only annotating lock requirements, use locks.h.\n\nBug: 119869270\nTest: mmma art\nChange-Id: I1608b03254712feff0072ebad012c3af0cc3dda4\n" }, { "commit": "7cc45fd1dbcf5704e442d0443e437aa2ae3fe21b", "tree": "76e582afd0580be21497787c584cab61f7599997", "parents": [ "03eb36c6940060f82f887b3e8860a91c1f97224c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 21 16:03:08 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 06 11:37:19 2018 -0800" }, "message": "ART: Factor out lock order and holder from mutexes\n\nIsolate the order and holder class from the mutex definitions.\nThe locks header requires significantly fewer includes, and\nwill be used in a follow-up change to remove mutex.h dependencies\nin headers just for the sake of annotation lock requirements.\n\nThis is itself an NFC commit, only pulling the code apart.\n\nBug: 119869270\nTest: m test-art-host\nChange-Id: I11ca161ac3118725c79313a82f58595699b590bf\n" }, { "commit": "af77ad46543ec13d77a53634507901f580d90fb6", "tree": "8dd3f7f719836035cff40465533b56079a6a7004", "parents": [ "244470afafdb1c5aba17507ef793d316b9c4d038" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Tue Nov 20 11:04:05 2018 -0800" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Mon Nov 26 08:46:31 2018 -0800" }, "message": "Reorder kThreadWaitLock\n\nIn aosp/814976, a new lock level was created for thread wait locks,\nwhich were previously at kDefaultMutexLevel. I missed that another lock,\nkMarkSweepMarkStackLock, was acquired while holding the thread wait\nlock. This corrects the ordering.\n\nBug: 119755302\nChange-Id: Ib55228d2759e281dc0f3a2177a538fd9adfec163\n" }, { "commit": "c665d6368e85a5eb8055a58c535b41777c97d7c7", "tree": "712cc488031bbf89767676d3a651df1a94ada611", "parents": [ "4fc843c4fc9f33c4ba49c1303d526d0e0e6a3788" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Tue Nov 06 16:20:13 2018 +0000" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Fri Nov 09 07:52:11 2018 -0800" }, "message": "Revert^2 \"Notify waiters when releasing the monitor\"\n\nThis reverts commit 9cec9658ec0b7a6c715a154ec834faba853188e3.\n\nReason for revert: Changed lock ordering to not require reacquiring the\nmonitor lock while holding the wait lock.\n\nTested: 1000 iterations of ThreadStress\nBug: 117842465\nChange-Id: I7b54943052c5eba367eac86da9646bfc81bc1163\n" }, { "commit": "9cec9658ec0b7a6c715a154ec834faba853188e3", "tree": "84d926444e66b5c5f91a7ee68fa65d5efe3ba8c0", "parents": [ "1ebb52ca700b6d9f9c27c3ee3e688ed17a43d358" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Nov 06 10:50:20 2018 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Nov 06 10:50:20 2018 +0000" }, "message": "Revert \"Notify waiters when releasing the monitor\"\n\nThis reverts commit 1ebb52ca700b6d9f9c27c3ee3e688ed17a43d358.\n\nReason for revert: Break ART run-test ThreadStress by failing this\nassertion:\n\n dalvikvm32 E 11-06 09:43:27 27100 27851 mutex-inl.h:134] Lock level violation: holding \"a thread wait mutex\" (level ThreadWaitLock - 9) while locking \"a monitor lock\" (level MonitorLock - 54)\n dalvikvm32 F 11-06 09:43:27 27100 27851 mutex-inl.h:145] Check failed: !bad_mutexes_held\n\nBug: 117842465\nChange-Id: I888201bf5c252c8366618d9169a37e4a4cc29734\n" }, { "commit": "1ebb52ca700b6d9f9c27c3ee3e688ed17a43d358", "tree": "dbc70ca80226ea0abb7a404a122b81400b90f52d", "parents": [ "23d3ed8c124f239d26a583f9d096b22f7f6677d1" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Thu Oct 25 15:37:14 2018 -0700" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Fri Nov 02 18:06:46 2018 -0700" }, "message": "Notify waiters when releasing the monitor\n\nThis avoids a ping-pong thread scheduling issue, where a waiter\nimmediately tries to acquire the monitor held by the notifier.\n\nBug: 117842465\n\nChange-Id: I33b91b066c9412b031fd6432bcb61273fb8d8fea\n" }, { "commit": "7530bae4f286d828d6394303ee2622c1b01b7e43", "tree": "6232fa29b6ce0dd2d4ac4cc47615ee08d9da59a9", "parents": [ "97d40f9c7b1157783d09861ce76d3a0b3da73cbe" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Mon Oct 29 20:03:51 2018 -0700" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Wed Oct 31 18:40:21 2018 +0000" }, "message": "Use _PRIVATE versions of futex ops.\n\nThis flag allows some performance optimizations in the kernel for futex\nwords that are only used in one process.\n\nTested: art$ grep FUTEX_ **/*.cc **/*.h\n\nChange-Id: I490b9592ca0f0ab5ab5431682e8b2104f5c917ca\n" }, { "commit": "2947ba6f1a14d7ea30aa60c3032fa07585cce1b4", "tree": "f73195582a9e59b190367b5de19b4c1e8fa2a0f4", "parents": [ "41ae033a4214208b589d8e1df423084728e08716", "bcd16eef679c4a11f20e6534b245a52443b6d521" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Oct 31 14:31:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Oct 31 14:31:30 2018 +0000" }, "message": "Merge \"Requeue rather than wake when notifying.\"" }, { "commit": "1130659b0d948806e7ca974ead8ad2bcc1951d13", "tree": "9046a016fafc7f9bff4e34732aa8f89ed81ad46c", "parents": [ "1c1442a498fd3f9ddc5d2bb04baa7ccd2d3539c4" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 26 14:22:59 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 30 10:20:32 2018 +0000" }, "message": "Refactor MemMap::MapAnonymous().\n\nRemove the address argument from the shortcut overload and\nintroduce one more shortcut overload. This makes it easier\nto find all uses where we pass non-null address hint.\n\nRemove `requested_begin` parameter from some constructors\nwhere we were always passing null. Rewrite some tests to\nuse the reservation API.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 118408378\nChange-Id: Ibbbb96667e7cc11cf7fea119892463d8dbc9a8b5\n" }, { "commit": "bcd16eef679c4a11f20e6534b245a52443b6d521", "tree": "218339ad91bfca357553ba33b89a215ff8db348c", "parents": [ "f4fd65e393fe60f17e22ee7823f8dce4594c053d" ], "author": { "name": "Charles Munger", "email": "clm@google.com", "time": "Mon Oct 22 13:03:23 2018 -0700" }, "committer": { "name": "Charles Munger", "email": "clm@google.com", "time": "Thu Oct 25 09:09:09 2018 -0700" }, "message": "Requeue rather than wake when notifying.\n\nRequeueing avoids contention when the newly-awoken waiter attempts to\nacquire the lock held by the notifier.\n\nBug: 117842465\nChange-Id: I78646245b538022012d546df12514f5d43d9f234\n" }, { "commit": "98ea9d9d82ab078ca10fa7f8e02eddda94cf1d98", "tree": "a848b7e41ff227a2d3d4d6795ec11089f39cb6ca", "parents": [ "02338775e33b553be51d44ff60bb1ef8e527bd94" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 19 14:06:15 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Oct 23 15:19:55 2018 -0700" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles runtime.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: Ibc0d5086809d647f0ce4df5452eb84442d27ecf0\n" }, { "commit": "2d899c41ac389ab881a56a82380e7bdb91fbbcc8", "tree": "cc0a13d666ad7b767f76261e1917a1f7039d8cd6", "parents": [ "6e82b7e6726d2c2ed0d6754ce1557d00e051b52c" ], "author": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Wed Oct 17 16:03:42 2018 -0700" }, "committer": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Wed Oct 17 16:03:42 2018 -0700" }, "message": "Fix usages of TEMP_FAILURE_RETRY(pthread_foo(...)).\n\npthread functions don\u0027t return -1 and set errno on failure, they return\na positive errno value instead.\n\nTest: treehugger\nChange-Id: I0097660e44c86c4c49d642e1169a30e43f9662bf\n" }, { "commit": "c55bb390d88b8eb62a50932f7f9b47c2a3733f16", "tree": "ec2e74f3f8404dffcb9bfde4e7ffa3416a35543d", "parents": [ "89468aeaa6a67ae4025b30d427391186306d6522" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 21 00:02:02 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 18:37:12 2018 -0700" }, "message": "Revert^2 \"ART: Refactor typedef to using\"\n\nThis reverts commit ee07743e03042c2ca36e0c9513847a9e7d2509f1.\n\nReason for revert: fixed attributes.\n\nBug: 32619234\nTest: m test-art-host\nTest: m test-art-target-gtest-unstarted_runtime_test\nChange-Id: I6f0a775adfdf6ecd132b470f7c5446e949872e20\n" }, { "commit": "ee07743e03042c2ca36e0c9513847a9e7d2509f1", "tree": "66867d7443a3798f6d882ef2715ddeb7baf3e771", "parents": [ "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Sep 20 15:05:17 2018 +0000" }, "message": "Revert \"ART: Refactor typedef to using\"\n\nThis reverts commit 9a20ff06f7ccee08a742c315ec6d351ab56ba1cd.\n\nReason for revert: Attributes on the wrong side.\n\nBug: 32619234\nChange-Id: I8fd2abef619b22c02ccfbf5ae629339f1a60918b\n" }, { "commit": "9a20ff06f7ccee08a742c315ec6d351ab56ba1cd", "tree": "7e55557e118eb5fffe03ad3456e00d8469a36232", "parents": [ "70dfb6983492aff1c52cc1b52044258aef51f47f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 10:58:18 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Sep 19 21:56:32 2018 -0700" }, "message": "ART: Refactor typedef to using\n\nAdd clang-tidy\u0027s modernize-use-using.\n\nBug: 32619234\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: If50d37b5152af4270784e3cde7951292a9e19033\n" }, { "commit": "bbc6e7edb5fca4a61ac53dd9bce79cb4f0bb3403", "tree": "0fbce767bc383358cf4cd65aafc74140e1850982", "parents": [ "19379b58bd433da91230e4fe6cd96e7416d16adc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 24 16:58:47 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Aug 28 11:06:07 2018 +0100" }, "message": "Use \u0027final\u0027 and \u0027override\u0027 specifiers directly in ART.\n\nRemove all uses of macros \u0027FINAL\u0027 and \u0027OVERRIDE\u0027 and replace them with\n\u0027final\u0027 and \u0027override\u0027 specifiers. Remove all definitions of these\nmacros as well, which were located in these files:\n- libartbase/base/macros.h\n- test/913-heaps/heaps.cc\n- test/ti-agent/ti_macros.h\n\nART is now using C++14; the \u0027final\u0027 and \u0027override\u0027 specifiers have\nbeen introduced in C++11.\n\nTest: mmma art\nChange-Id: I256c7758155a71a2940ef2574925a44076feeebf\n" }, { "commit": "f6985bd84b27b25e2c2ae1b865a4f28a0ccd578b", "tree": "5ec94a773e2c7e19842b1f2de02baf4343aff6c9", "parents": [ "19759b28bc9dad1581c207d76227eb74fc8eebcb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Aug 24 09:02:28 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Aug 24 09:40:56 2018 +0100" }, "message": "Add an overload for MemMap::MapAnonymous().\n\nAdd an overload that does not take `reuse` or `use_ashmem`\nparameters but uses default values (`reuse \u003d false` and\n`use_ashmem \u003d true`) to simplify callers.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Iaa44f770dee7e043c3a1d6867dfb0416dec83b25\n" }, { "commit": "c34bebf39410f5571d3d5813157b61f274d435c3", "tree": "73909d3b34a2908e9de44cc60c4a2ff74eabefd7", "parents": [ "f345404c725330914b8313d2c1af17226c5b92ca" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 16 16:12:49 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Aug 21 13:51:00 2018 +0100" }, "message": "Remove unnecessary indirection from MemMap.\n\nAvoid plain MemMap pointers being passed around by changing\nthe MemMap to moveable and return MemMap objects by value.\nPreviously we could have a valid zero-size MemMap but this\nis now forbidden.\n\nMemMap::RemapAtEnd() is changed to avoid the explicit call\nto munmap(); mmap() with MAP_FIXED automatically removes\nold mappings for overlapping regions.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nChange-Id: I12bd453c26a396edc20eb141bfd4dad20923f170\n" }, { "commit": "33b7b5da331e0a10fc615c8df72ba2aefad4e3fb", "tree": "4894623ad71bf957c25009e35e1b57ba501bb9c3", "parents": [ "134380d7c70d95962ed818458185e608ad17ff08" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:13:51 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Aug 17 14:40:51 2018 -0700" }, "message": "Revert^2 \"Fix race in CommitCodeInternal and cleanup\"\n\nThis reverts commit 8dde74eb7bec8e989f34d86a01c26b0f5c7e6443.\n\nWe were failing to do a null check in cha.cc. Due to compiler\noptimizations this would actually run without error on non-asan\nbuilds, causing the error to pass testing.\n\nReason for revert: Fixed issue causing asan issue.\nTest: run asan tests\n\nChange-Id: Ic5492c69b7735555108d8b18c8e687ce510c4549\n" }, { "commit": "8dde74eb7bec8e989f34d86a01c26b0f5c7e6443", "tree": "e94f5e620f27b3d6dcb3b634bc25bf0274b1143b", "parents": [ "a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:11:05 2018 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 07 19:11:05 2018 +0000" }, "message": "Revert \"Fix race in CommitCodeInternal and cleanup\"\n\nThis reverts commit a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c.\n\nReason for revert: Seems to cause the asan gtests to fail.\n\nChange-Id: I0c7b4720de16f9b2b4e1e27c3c4e57a018c59a0c\nTest: none\n" }, { "commit": "a2af2b0c761a04d1e1ba4b1ccdc2efb4692e9c9c", "tree": "6c84decdf15db52cf8c20074f55b6f4fc89f9520", "parents": [ "d0c6ec392756fd038ebb8aeaad19aed94c5fd1a5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jul 19 14:39:24 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Aug 01 09:15:23 2018 -0700" }, "message": "Fix race in CommitCodeInternal and cleanup\n\nJitCodeCache::CommitCodeInternal had a race where it gained the\ncode-cache lock to allocate memory, then drops it and potentially\nsuspends. It relied on the time for a code-collect being strictly more\nthan the time this function took, creating a race. This CL Changes the\nlock ordering of CHA to allow us to cleanup the CommitCodeInternal\nfunction and remove the race.\n\nTest: ./test.py --host --jit\nChange-Id: I13c7ec6c56f07660778009ad8ce9c8c10bc2d57d\n" }, { "commit": "240a564a2bb3bc70c5983300037a199d751c7727", "tree": "132585fa41a9580f0abd4820abfa7c43dfb41d42", "parents": [ "be272b93ffcec3ccfd2311a58fd28c3927561ed1" ], "author": { "name": "Hyangseok Chae", "email": "neo.chae@lge.com", "time": "Wed Jul 25 16:45:08 2018 +0900" }, "committer": { "name": "Hyangseok Chae", "email": "neo.chae@lge.com", "time": "Fri Jul 27 09:16:02 2018 +0900" }, "message": "Ensure seq_cst memory ordering for num_contenders\n\nProblem.\nMutexes and ReaderWriterMutexes can lose wakeups due to\nweak memory ordering. An unlocking thread may overlook waiters.\n\nThread A\n0. ExclusiveLock\n1. increase num_contenders as default ordering.\n (fetch_add, std::memory_order_seq_cst)\n2. futex waiting\n...permently waiting\n3. wakeup\n4. decrease num_contenders\n5. running\n\nThread B\n0. Reset lock state to unlocked using seq_cst CAS.\n1. load num_contenders with LoadRelaxed\n (std::memory_order_relaxed)\n2. if num_contenders is bigger than 0, wakeup waiters.\n\nThread B\u0027s load of num_contenders may be reordered with the store\nin the preceding CAS (step 0).\n\nWe can then get the following interleaving:\nA.0 (fails: lock held.)\nB.0a (CAS load acquire sees lock as held)\nB.1 (sees num_contenders \u003d 0)\nA.1 num_contenders++;\nA.2 futex starts waiting (state unchanged)\nB.0b (CAS store release sets state to unlocked)\nB.2 (does nothing since num_contenders was 0)\n\nWe observed this hang with state_ \u003d 0,\nexclusive_owner_ \u003d 0, num_contenders_ \u003d 1\nIndeed, the preceding comment strongly suggests that the num_contenders\nload should not be relaxed.\n\nTest: test-art-host, test-art-target\n\nChange-Id: I912bcd3a186d9c36fb3da8a41c1f9aa1f7b39be5\nSigned-off-by: Hyangseok Chae \u003cneo.chae@lge.com\u003e\n" }, { "commit": "184f0759ef700b1412c7df412c4ebb297427d9fc", "tree": "beef751010816fbbee70494422fd48d46559a4ac", "parents": [ "ec1f1a91328f44d93cfc16e39160dbdfce2f7b9a" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Jul 13 11:18:22 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Jul 16 16:20:01 2018 -0700" }, "message": "Rewrite thread CustomTLS to support keyed TLS entries\n\nOur Thread struct allowed plugins or other parts of the runtime to use\na single custom_tls_ void* pointer to store additional data in the\nThread struct. Unfortunately it was limited to a single value. This CL\nchanges the API to allow one to pass in a const char* key that is used\nto address the TLS data. This lets multiple plugins or parts of the\nruntime set their own independent TLS entries. This also adds support\nfor TLS entries actually being deallocated automatically.\n\nTest: ./test.py --host\nChange-Id: I40fa767b9c61a755b2ed910e4ad1e6327705e941\n" }, { "commit": "3e36a9c24f591097b4403fe77b1d426c03aeb56a", "tree": "64f9c8896038ada2f7a17bd7cc62c488027dd548", "parents": [ "25bf44622d6359c1d49c2a8a8b45938ff099f811" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jun 19 09:45:05 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 10 08:44:52 2018 -0700" }, "message": "Move back to jit code on trace removal\n\nThis changes the lock hierarchy so the lock checker is able to\ncorrectly determine that we will not deadlock. This lets us replace\nthe jit code in the method when tracing is removed.\n\nTest: ./test.py --host\n\nChange-Id: I14dd4eb9814c73fa3639239bb56d91c8303cec60\n" }, { "commit": "896583ec8809497bb844c857dd042b0d2e7d1ba1", "tree": "1075075e9b9b9fdb8627d07eabf823776bdcf2e7", "parents": [ "cca7cb9ffa56d8ab8fd0c5997c8bfd965d7426c1" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jun 15 13:31:58 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 25 10:24:53 2018 -0700" }, "message": "ART: Use clang-tidy to warn on RAII issue\n\nRemove the macro hack to detect likely-incorrect usage of RAII wrappers.\nInstead make the clang-tidy pattern bugprone-unused-raii fatal.\n\nTest: mmma art\nChange-Id: I9d0eb1c5c3f469b2907111af9d38d947b36c4878\n" }, { "commit": "05e34f4cb8c9db165d1008721e874b9dd3db024b", "tree": "c41d397ef5cfb9d7918fceadcda3195a0d0d91de", "parents": [ "428d80e3a49f732b39bb0c71cfde26451e3fdf4d" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 24 13:19:05 2018 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jun 11 14:03:37 2018 +0100" }, "message": "Revert^2 \"Remove support for Valgrind in ART.\"\n\n- Disable test configuration art-gtest-valgrind64\n (art-gtest-valgrind32 was already disabled).\n- Remove Makefile logic regarding testing with Valgrind.\n- Remove occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_VALGRIND`.\n- Replace occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_ASAN` with\n `TEST_DISABLED_FOR_MEMORY_TOOL`.\n- Replace the potentially dynamically evaluated\n `RUNNING_ON_MEMORY_TOOL` expression with constant\n `kRunningOnMemoryTool`.\n- Simplify and fold the logic of\n `art::ArenaAllocatorMemoryToolCheckImpl` and\n `art::ArenaAllocatorMemoryToolCheck` into\n `art::ArenaAllocatorMemoryTool`.\n- Adjust comments regarding memory tools.\n- Remove Valgrind suppression files.\n- Remove `--callgrind` option from tools/art.\n\nThis reverts commit 8b362a87d52a6668ffd2283ef6ffc274315f41c8.\n\nChange-Id: I23c76845e6ccf766f19b22b58a0d5161f60842a9\nTest: art/test.py\nTest: art/test/testrunner/run_build_test_target.py art-asan\nBug: 77856586\nBug: 29282211\n" }, { "commit": "197f1ef6f4f2411d011d7e8f696775c3fbcffd86", "tree": "eacc720024479e75b03d12ac6764f2cd2ba945b3", "parents": [ "04f0eaffa70e0384c07bb3680aa0724144358330", "8b362a87d52a6668ffd2283ef6ffc274315f41c8" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue May 22 23:00:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 22 23:00:40 2018 +0000" }, "message": "Merge \"Revert \"Remove support for Valgrind in ART.\"\"" }, { "commit": "8b362a87d52a6668ffd2283ef6ffc274315f41c8", "tree": "14b187cd0b4afde501b9cc7a9dc82c997362e888", "parents": [ "8268cb677bd92bfbcfec7e803775c29687494e53" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 22 20:54:14 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 22 20:54:14 2018 +0000" }, "message": "Revert \"Remove support for Valgrind in ART.\"\n\nThis reverts commit 8268cb677bd92bfbcfec7e803775c29687494e53.\n\nReason for revert: ASAN failures\n\nChange-Id: I7e66d3f3fb461ae4f6dea6ec7d506b7dface3402\nTest: SANITIZE_HOST\u003daddress m test-art-host\nBug: 77856586\nBug: 29282211\n" }, { "commit": "f31343f1eab771010b3f293366149d2524f30902", "tree": "5187b2bceee4c7d5347750dc6ba0020172d5ef51", "parents": [ "e816389b61d17b9a82d8e61426ddfcce20e1238c", "8268cb677bd92bfbcfec7e803775c29687494e53" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue May 22 16:46:43 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 22 16:46:43 2018 +0000" }, "message": "Merge \"Remove support for Valgrind in ART.\"" }, { "commit": "8268cb677bd92bfbcfec7e803775c29687494e53", "tree": "b63ca42dcd440117187e3c859b4b311b11b8137e", "parents": [ "004b8875b291af5001d384fb1eb76ae0660ff056" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri May 11 15:06:17 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon May 14 18:40:49 2018 +0100" }, "message": "Remove support for Valgrind in ART.\n\n- Disable test configuration art-gtest-valgrind64\n (art-gtest-valgrind32 was already disabled).\n- Remove Makefile logic regarding testing with Valgrind.\n- Remove occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_VALGRIND`.\n- Replace occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_ASAN` with\n `TEST_DISABLED_FOR_MEMORY_TOOL`.\n- Replace the potentially dynamically evaluated\n `RUNNING_ON_MEMORY_TOOL` expression with constant\n `kRunningOnMemoryTool`.\n- Simplify and fold the logic of\n `art::ArenaAllocatorMemoryToolCheckImpl` and\n `art::ArenaAllocatorMemoryToolCheck` into\n `art::ArenaAllocatorMemoryTool`.\n- Adjust comments regarding memory tools.\n- Remove Valgrind suppression files.\n- Remove `--callgrind` option from tools/art.\n\nTest: art/test.py\nBug: 77856586\nBug: 29282211\nChange-Id: Ifdcbfccc1830104c455760457df66ede4a4cd135\n" }, { "commit": "c3e1895e7443c61b77f5c51cd2d18819cade57c1", "tree": "bc2705ee47091e37d683cafa020f53190708b089", "parents": [ "6623bc389c43efc87668ce7465e19b195e765e22" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri May 11 16:59:31 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri May 11 17:40:56 2018 -0700" }, "message": "Prepare to move ArtDexFileLoader to libdexfile\n\nMove file_utils and friends to libartbase so that ArtDexFileLoader can\nbe moved to libdexfile. This will clean up duplication and complexity\nwith zip file handling.\n\nBug: 78652467\nTest: make -j 40 test-art-host-gtest\nChange-Id: Ia5eac1f93caf3fa918b4b48803cbfd842035e29e\n" }, { "commit": "0d0f3164160e50ddb78022f662c5438fc167f50d", "tree": "13bfdad1117db0adfb8b434ff1b8e1589c0c43ea", "parents": [ "9d7905fffb9eca8f4fa6f3f3d7d3deb9718e3005" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu May 10 12:55:40 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu May 10 22:49:34 2018 +0100" }, "message": "Handle multidex in LocationIsOnSystemFramework.\n\nbug: 79111915\nTest: art_dex_file_loader_test.cc\nChange-Id: I507ad98c62b4c589196685d74abdeaf748502a61\n" }, { "commit": "5db8b7b821d0b77cb3b041de7861b7d635050cc2", "tree": "04550e7131d527186e34b4c2d1b3be1a1d357bf7", "parents": [ "a6ce173839a1bca1811fca7d9a0a39efd720611d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 08 16:10:59 2018 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 08 16:12:41 2018 -0700" }, "message": "ART: Relayout BaseMutex and Mutex\n\nReduce size of BaseMutex (and thus all derived mutex classes) by changing\nthe field layout. Reduction from 24B to 16B on 64-bit systems.\n\nBug: 79365543\nTest: m test-art-host\nChange-Id: Id7b50aa9af1ae5d249e62573ab67257c12922bfa\n" }, { "commit": "1979c64214bd505c013d573bc8729ee94f7bdea5", "tree": "9b4b2298b8b9d15cd6ca0a1e06e3771f3db2163f", "parents": [ "5a87e19e4bf1b6719c2aad3effde1b38d2c3085c" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 26 14:41:18 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 26 15:08:49 2018 -0700" }, "message": "Clean up include paths\n\nRemove runtime/globals.h and make clients point to the right globals.h\n(libartbase/base/globals.h). Also make within-libartbase includes\nrelative rather than using base/, etc.\n\nBug: 22322814\nTest: make -j 40 checkbuild\nChange-Id: I99de63fc851d48946ab401e2369de944419041c7\n" }, { "commit": "b4dfca56fbf5a2c3612732568dce4d200b626a3a", "tree": "e44a0ce7c93cbd0e4f6073a8d18c65d3808314a6", "parents": [ "c3d5b84592b6d9c529090cfd1e5e9fb72a00f80b" ], "author": { "name": "Daniel Colascione", "email": "dancol@google.com", "time": "Sun Apr 15 11:15:14 2018 -0700" }, "committer": { "name": "Daniel Colascione", "email": "dancol@google.com", "time": "Sun Apr 15 11:17:08 2018 -0700" }, "message": "The test for futex support should be a test for Linux\n\nTest: code inspection\nChange-Id: Ic07f1eff2704064cc4416fc58df81c471ff54f4e\n" }, { "commit": "79e2607ab50163bfdc283f4a49decec26a216df5", "tree": "0cdb2c65412b64a55ddf1a486ab3d961a0301a3e", "parents": [ "b4b91460b2d01d36ddcb7d55111ccd8faf390c2a" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Apr 06 17:58:50 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Apr 13 08:29:30 2018 -0700" }, "message": "Move profile dependent modules to libartbase\n\nMove mem_map and zip_archive to libartbase. This should be the last two\nremaining modules that profile_compilation_info is dependent upon.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make and boot a device\n\nChange-Id: I136ee23e426aa8ec7441e3d3f1978f1bebf4b562\n" }, { "commit": "1ce2b3b76d121a765212d69399241843951973ae", "tree": "6f2bb0191c869e79891df3151d6faba3a297b9a8", "parents": [ "281c99864f635ef4fd005dba4ba0c750cb9a6143" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 05 11:02:03 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Apr 05 11:07:59 2018 -0700" }, "message": "Move remaining runtime/base stuff to libartbase\n\nMove the remainder of the Arena stuff, plus dumpable and\nruntime/*memory_region* to libartbase. More preparation to build\nprofiling library.\n\nBug: 22322814\nTest: make -j 50 checkbuild\nChange-Id: Iaf26d310c89bc58846553281576c18102f5e4122\n" }, { "commit": "3215fff7ef8fa3c2250b91158560eacc613a4671", "tree": "50d6fe7aff3f8fae31dcf2ca020f5079f49a592f", "parents": [ "6371249ce05032db5d8c4c7ec96bf7fd7264c42f" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Apr 03 17:10:12 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Apr 04 14:47:57 2018 -0700" }, "message": "Separate Malloc and MemMap ArenaPools\n\nMake ArenaPool an abstract base class and leave MallocArenaPool\nimplementation with it. This enables arena_allocator to be free\nof MemMap, Mutex, etc., in preparation to move the remaining collections\nout of runtime/base to libartbase/base.\n\nBug: 22322814\nTest: make -j 50 test-art-host\n build and boot\n\nChange-Id: Ief84dcbfb749165d9bc82000c6b8f96f93052422\n" }, { "commit": "27b967611b48120bf0140995ae439700fe6cc139", "tree": "fb6a3ce8c7bb50cfd5e265533dab3894d52f4716", "parents": [ "ba6d632c0e7617a1a848551612d7cb9e60b450e6" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Mar 13 16:06:57 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Mar 29 12:44:43 2018 +0100" }, "message": "ART: Simplify quasi_atomic.h\n\nRemoves fences that duplicate std::atomic_thread_fence().\n\nBug: 71621075\nTest: art/test.py --host -j32\nTest: art/test.py --target --64 -j4\nChange-Id: I008de4d242d1a3cf4d3f50ce171abbbda647bdaa\n" }, { "commit": "b38988a227534ae17045dadedc24d2131d59b42d", "tree": "4aa18d4de72ef2e614d9459234a979bff69bc7ba", "parents": [ "981d6b58c81c20f7d5f7d5352c30c2d916c2e60b", "8e1a7cb303d7c8f763dfb99ae311b820996b1ab4" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Mar 28 10:26:07 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Mar 28 10:26:07 2018 +0000" }, "message": "Merge \"Revert \"Revert \"Allow hidden API access from system libraries\"\"\"" }, { "commit": "8e1a7cb303d7c8f763dfb99ae311b820996b1ab4", "tree": "ea952245e2b907c44d5c0fcadf90f00a1fe31913", "parents": [ "10c4390a7d63775b1c7e6f6a291e9aade388d733" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Mar 27 08:14:25 2018 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Mar 27 18:15:21 2018 +0100" }, "message": "Revert \"Revert \"Allow hidden API access from system libraries\"\"\n\nLibraries like RemoteDisplay provide an APK that an app loads into\nits process and which accesses internal APIs on the app\u0027s behalf,\nwithout exposing the internals to the app. These libraries are\nconsidered part of the platform, but were not exempt from hidden API\nchecks because they are not loaded with the boot strap class loader.\n\nThis patch adds a new flag to DexFile class which the constructor\nsets to true of the canonical location of the newly loaded dex file\nstarts with \"${ANDROID_ROOT}/framework/\". Hidden API enforcement\nthen checks this flag when determining whether the caller of\na hidden class member is allowed to access it or not.\n\nThis reverts commit 0127b71a2588efcd1a53c192c5c267157878b010.\n\nPrevious CL saw two issues:\n- buildbots would set non-existent ANDROID_ROOT for host-side builds\n- calling realpath on unquickened dex files would overflow the stack\n\nBug: 64382372\nBug: 76138670\nBug: 76165623\nBug: 76112393\nBug: 76452688\nBug: 76429651\nTest: art/test.py --target -r -b -t 674-hiddenapi\nTest: SystemUI APCT test\nChange-Id: Ie07a088509002593353965d3d24bf7362b643f40\n" }, { "commit": "175e7862dbdb44089ef327fc43ba00c791fd3838", "tree": "7b7ff4327b51b57e47e4b22af8d771edb9d462c1", "parents": [ "77c6fc7341143dd27c74cddd786398688d7b4c91" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 27 09:03:13 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 27 10:04:25 2018 +0100" }, "message": "Revert^4 \"Compiler changes for bitstring based type checks.\"\n\nDisabled the build time flag. (No image version bump needed.)\n\nBug: 26687569\nBug: 64692057\nBug: 76420366\n\nThis reverts commit 3fbd3ad99fad077e5c760e7238bcd55b07d4c06e.\n\nChange-Id: I5d83c4ce8a7331c435d5155ac6e0ce1c77d60004\n" }, { "commit": "d1ede32d56d2b6c95f94a8c67d8b9f309940d9de", "tree": "1aa42a51731533c9d554a913e655b8091fc6829d", "parents": [ "41a10575b319ca9549d7b3e8a9fe91c1cc602659", "3fbd3ad99fad077e5c760e7238bcd55b07d4c06e" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:16:37 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Mar 26 21:16:37 2018 +0000" }, "message": "Merge \"Revert^3 \"Compiler changes for bitstring based type checks.\"\"" }, { "commit": "3fbd3ad99fad077e5c760e7238bcd55b07d4c06e", "tree": "e8bc33fa60c38f7e1c85f8d4acf6a738df9b426a", "parents": [ "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:14:46 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:14:46 2018 +0000" }, "message": "Revert^3 \"Compiler changes for bitstring based type checks.\"\n\nThis reverts commit 3f41323cc9da335e9aa4f3fbad90a86caa82ee4d.\n\nReason for revert: Fails sporadically.\n\nBug: 26687569\nBug: 64692057\nBug: 76420366\nChange-Id: I84d1e9e46c58aeecf17591ff71fbac6a1e583909\n" }, { "commit": "41a10575b319ca9549d7b3e8a9fe91c1cc602659", "tree": "4e88a7791a1b88364e35365b558d53429d62e5b8", "parents": [ "a020472fe3f732a4523cf36f56a309089193648c", "0127b71a2588efcd1a53c192c5c267157878b010" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 26 19:33:03 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Mar 26 19:33:03 2018 +0000" }, "message": "Merge \"Revert \"Allow hidden API access from system libraries\"\"" }, { "commit": "0127b71a2588efcd1a53c192c5c267157878b010", "tree": "cfe89ca742bed927e67d9cf926937fe5e6f89347", "parents": [ "eefabd28c21e6ae02ca05e97bd22f9e23cbf98a5" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 26 19:31:41 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 26 19:31:41 2018 +0000" }, "message": "Revert \"Allow hidden API access from system libraries\"\n\nBug: 64382372\nBug: 76138670\nBug: 76165623\nBug: 76112393\n\nSeems to cause run-test issues.\n\nThis reverts commit eefabd28c21e6ae02ca05e97bd22f9e23cbf98a5.\n\nChange-Id: Ia9b3d946742dbfde4fb56cf14413fde0600c8252\n" }, { "commit": "de1ef6dbf9b6362621e9d0ddb2b106519d865246", "tree": "0095c5ff5ccc622fdfe0fdad10be42ce05be95d1", "parents": [ "4ac2f25f01eeb2879a8bb7e4c72754f32d0cb497", "eefabd28c21e6ae02ca05e97bd22f9e23cbf98a5" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Mar 26 12:28:19 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Mar 26 12:28:19 2018 +0000" }, "message": "Merge \"Allow hidden API access from system libraries\"" }, { "commit": "7075583146f52a754c6d7c91757a6333bf1b95da", "tree": "6e3c7a78d19c1b4f9d952d8143939c9caa5fa5b6", "parents": [ "90637419635837d3a30634eb827bd8aa052adcc7", "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 26 10:24:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Mar 26 10:24:30 2018 +0000" }, "message": "Merge \"Revert^2 \"Compiler changes for bitstring based type checks.\"\"" }, { "commit": "eefabd28c21e6ae02ca05e97bd22f9e23cbf98a5", "tree": "58e4c2635e0d5682c3385bed639664ccfdd44f6a", "parents": [ "e8a4e378c5a928d5de07bee6db99150a57dabcd8" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Mar 22 16:27:18 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 26 08:05:33 2018 +0000" }, "message": "Allow hidden API access from system libraries\n\nLibraries like RemoteDisplay provide an APK that an app loads into\nits process and which accesses internal APIs on the app\u0027s behalf,\nwithout exposing the internals to the app. These libraries are\nconsidered part of the platform, but were not exempt from hidden API\nchecks because they are not loaded with the boot strap class loader.\n\nThis patch adds a new flag to DexFile class which the constructor\nsets to true of the canonical location of the newly loaded dex file\nstarts with \"${ANDROID_ROOT}/framework/\". Hidden API enforcement\nthen checks this flag when determining whether the caller of\na hidden class member is allowed to access it or not.\n\nBug: 64382372\nBug: 76138670\nBug: 76165623\nBug: 76112393\nTest: art_dex_file_loader_test gtest\nTest: art/test.py --gtest\nChange-Id: If062bd668d7ba494bbb7b828e40932748d173b9a\n" }, { "commit": "88591fe82f499de10591f5b77efac71f8954eae2", "tree": "bfa126ad55ee091e3b615bd3bb60d5f8cfb6e37a", "parents": [ "e8a4e378c5a928d5de07bee6db99150a57dabcd8" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Tue Mar 06 13:35:43 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Mar 23 15:01:15 2018 +0000" }, "message": "ART: Simplify atomic.h\n\nPrefer std::atomic operations over wrappers in atomic.h. Exceptions\nare cases that relate to the Java data memory operations and CAS\noperations.\n\nBug: 71621075\nTest: art/test.py --host -j32\nTest: art/test.py --target --64 -j4\nChange-Id: I9a157e9dede852c1b2aa67d22e3e604a68a9ef1c\n" }, { "commit": "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d", "tree": "ce41c620d2cd411da3c20aa95fb9a69328e77c42", "parents": [ "9ec1e24ebc683b15bb9c6db5554ac2ff9458adae" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 12 18:39:15 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 22 12:12:39 2018 +0000" }, "message": "Revert^2 \"Compiler changes for bitstring based type checks.\"\n\nAdd extra output for debugging failures and re-enable\nthe bitstring type checks.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: testrunner.py --host -t 670-bitstring-type-check\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --target -t 670-bitstring-type-check\nBug: 64692057\nBug: 26687569\n\nThis reverts commit bff7a52e2c6c9e988c3ed1f12a2da0fa5fd37cfb.\n\nChange-Id: I090e241983f3ac6ed8394d842e17716087d169ac\n" }, { "commit": "62c2d71b583820685761519bbfe3ce1e79358e25", "tree": "a069c70f43bb0edd5472be2e4e114b47d55fefe7", "parents": [ "9992e095643f6746361df03c4c98e742d9ad5899" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 09 12:54:05 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Mar 09 12:59:46 2018 +0000" }, "message": "Fix ReplaceFileExtension() to stop looking for \u0027.\u0027 at \u0027/\u0027.\n\nTest: new test in file_utils_test.\nTest: m test-art-host-gtest\nChange-Id: Iaf9d16c8595f4f88a5920549c9cee51ecd4f9d13\n" }, { "commit": "c431b9dc4b23cc950eb313695258df5d89f53b22", "tree": "422273559c3ae52caff0c6b1cf1a62a8312f0e26", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Mar 02 12:01:51 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 05 13:58:20 2018 -0800" }, "message": "Move most of runtime/base to libartbase/base\n\nEnforce the layering that code in runtime/base should not depend on\nruntime by separating it into libartbase. Some of the code in\nruntime/base depends on the Runtime class, so it cannot be moved yet.\nAlso, some of the tests depend on CommonRuntimeTest, which itself needs\nto be factored (in a subsequent CL).\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host\n\nChange-Id: I8b096c1e2542f829eb456b4b057c71421b77d7e2\n" }, { "commit": "67bf42e89592c3a1c648f927f2ce3ccb189a1161", "tree": "054d5b7adf7cc62d4d2a2118a70c0fbdd1751610", "parents": [ "d961043ff1dd6fddb68aa90c1f939cfafec24219" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Feb 26 16:43:04 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 28 15:08:21 2018 -0800" }, "message": "Header library to remove dependence on runtime/\n\nAdd a new header library to remove libdexfile and others\u0027 dependence on\nruntime (typically runtime/base) includes in libdexfile. Also a small step\nto tease dexlayout and profman away from relying on these as well.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n\nChange-Id: I38e2fe399a75f4bc6318c77a71954c00ea73ec2b\n" }, { "commit": "cd72dc997ffd88ae92867332d2833c6b5d48fe36", "tree": "a48165e3c59673b755993c960e0cca4db6f859fb", "parents": [ "0bdc1fc702b5c9e45df93f92a052f0c0b1c26733" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 27 19:15:31 2018 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 27 19:20:50 2018 +0000" }, "message": "Fix an incorrect use of ScopedContentionRecorder in ReaderWriterMutex.\n\nThe TID the blocked (current) thread and the TID of the mutex\u0027s\nexclusive owner thread should be respectively passed as second\nand third arguments to ScopedContentionRecorder\u0027s constructor.\n\nTest: art/test.py\nChange-Id: Ica37dfb1c15e25cd48fa46f499192de58e8a7e0e\n" }, { "commit": "63e9e8700d0fe14a31d93e95efea603bab78a68e", "tree": "6a89ae90a962070ed559c9759232d429a5369507", "parents": [ "c7ac275a5f06b0e1140bf600ec1e654f629c54ab", "440a9b3b3e6aa60c14e73a97dd85c9ada0898569" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Feb 23 17:53:23 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Feb 23 17:53:23 2018 +0000" }, "message": "Merge \"Add timestamps to JIT/DEX native debug info.\"" }, { "commit": "2daa13448d5caeb7eb4f7fd3981c0d430264c7c3", "tree": "547222519fc7627a99eae914fbaa39eb294a82c6", "parents": [ "b2f1edc3d1f162bd9007f10bc66009eac5b2daab" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 20 16:19:28 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Feb 22 10:37:31 2018 -0800" }, "message": "Fix unquickening logic for quickened input dexes\n\nIn the case where an input dex is already quickened (i.e.\nobfuscation), do not attempt to unquicken it. This is done by\nswitching the quicken info table to the compact offset table (used by\ncdex debug infos).\n\nAdded test.\n\nPosssible to get a bit of extra savings by deleting the quicken info\nnum entries field.\n\nQuicken filter size regression average on golem: -0.14%.\n\nBug: 72608794\nBug: 63756964\nTest: test-art-host-gtest-dex2oat_test -j64\nChange-Id: I5534a7509b4c718a9b959fa43b82bde857e0b59e\n" }, { "commit": "b2ec9f5c128673c43f776cbe12c8eeb0a6884ebb", "tree": "724022162a4f3de021cebab32ee5ac67ec860f32", "parents": [ "f13343eb8b2738e2812fd7bd9d5592f529e93c21" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:20:31 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Feb 21 13:51:15 2018 -0800" }, "message": "Remove duplication, split tests\n\nThe code move to libdexfile/dex/descriptors_names.cc apparently did not\nremove the original code from runtime/utils.cc. Fix that duplication\nand all the header mentions needed. Also, split the test files to go\nalong with the new locations for the code to be tested.\n\nBug: 22322814\nTest: make -j 50 checkbuild\n make -j 50 test-art-host-gtest\n flash \u0026 boot marlin\n\nChange-Id: Ie734672c4bca2c647d8016291f910b5608674545\n" }, { "commit": "440a9b3b3e6aa60c14e73a97dd85c9ada0898569", "tree": "26dcc48d91e3eec18ab1e4dd987962a0939f6531", "parents": [ "d1652d14fbf477b3091eec3764b9890f2c072055" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 15 17:47:29 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Feb 21 12:57:12 2018 +0000" }, "message": "Add timestamps to JIT/DEX native debug info.\n\nThis a forward-looking change intended to allow simpleperf to\nreliably correlate samples and native debug information.\n\nI have added the timestamps to both JIT and DEX, and refactored\nthe code in the process to avoid code duplication.\n\nTest: testrunner.py -t 137\nChange-Id: I45fa4310305aff540e036db9af15a86c5b8b7aff\n" }, { "commit": "fcbe15ce26930c0c4bb33998fc2abbe4f8770dbe", "tree": "6513a2eaf1251e93578916b5171dc42984de7da3", "parents": [ "b40fa7c33075292beeb6840ac679ffd08fd1f719" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Feb 15 09:41:13 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Feb 15 15:15:13 2018 -0800" }, "message": "Build debug library libdexfiled\n\nAdd a debug version of libdexfile for use when CHECKs, etc., are\nenabled.\n\nBug: 22322814\nTest: make -j 50 checkbuild\nChange-Id: I263138611bcdde9dbc8f619bcb2a0a6d3a09fbf6\n" }, { "commit": "ef012225dcec8f736fc8fd848f5d8ee01c3c280f", "tree": "d5f65b05313a09e92055550f07f063537b9e6ca5", "parents": [ "cd4ddeea1c33d5f9b7758d116451bd06f1b81aff" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Jun 21 16:28:06 2017 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Feb 09 15:36:49 2018 +0000" }, "message": "Fix typos.\n\nTest: art/test/testrunner/testrunner.py\nChange-Id: I5f5e052c940650a3adb3a8717b84260e6b306500\n" }, { "commit": "5168173dd6e79341b4b1f0a349721a2c7aa2a846", "tree": "e04b77281d1e767322e63fefb2ecab2850adff1a", "parents": [ "90771c270b3b31dc608331027d7a83b192115138" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 30 10:12:00 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 06 17:48:51 2018 -0800" }, "message": "Use more ArrayRefs in quicken infos\n\nUse ArrayRef to get bound checks for debug builds.\n\nBug: 72608794\nBug: 63756964\nTest: test-art-host-gtest\n\nChange-Id: Ie423c969730c13b0cd936a64cbc7be07a716aa65\n" }, { "commit": "a927295aa29123fd85ac7a7f0e7c3763b5f7b974", "tree": "64e00ab597daea17274768c047ff0fab23cebb65", "parents": [ "e65948f7c78919083224c1cd2ca47e827ced6d3e", "ca97ada4ec14373242de2452a6d0c16804007d66" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Feb 02 21:17:42 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Feb 02 21:17:42 2018 +0000" }, "message": "Merge changes I39354837,Id8e47f45\n\n* changes:\n Change ClassFileLoadHook to lazily compute dex file\n Remove unneeded mutator_lock_ requires from fixed_up_dex_file\n" }, { "commit": "ca97ada4ec14373242de2452a6d0c16804007d66", "tree": "483cba96eb8cbc8e06a2ef8651f66d208626e30b", "parents": [ "2e40c1c2e9c8cfc2d41a8960247bfa48e2500889" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Feb 02 09:25:31 2018 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Feb 02 11:04:38 2018 -0800" }, "message": "Change ClassFileLoadHook to lazily compute dex file\n\nCreating a dex file from the quickened or compact-dex\u0027d internal\nformat for calling the JVMTI ClassFileLoadHook is quite expensive.\nThis meant that agents could not generally listen for this event\nwithout causing unacceptable performance problems.\n\nSince agents will generally not touch the buffer, needing to\ninstrument only a handful of classes we will fix this problem by doing\nthe de-quickening lazily. This is done by mmaping an empty buffer with\nPROT_NONE and then filling it in when the program has a SEGV in the\nappropriate address range. This should improve the performance of any\nagent that listens for the ClassFileLoadHook but does not commonly do\nanything to the buffer.\n\nThis does have the disadvantage that we can no longer ensure that the\nbuffer size we pass down in class_data_len might no longer be fully\naccurate. Some agents that assert that class_data_len is exactly the\nsame as the dex-file will need to be updated.\n\nBug: 72402467\nBug: 72064989\nTest: ./test.py --host -j50\nTest: ./test.py --host --redefine-stress -j50\n\nChange-Id: I39354837f1417ae10a57c5b42cbb4f38f8a563dc\n" }, { "commit": "fb3de3d72832177e4a8d1f322ed11cbe58e45c9f", "tree": "de8cded0436b54b2e5b1142b07fa75f0ed9791b0", "parents": [ "2827ff64c7a385cfb9d6e01e6385708461eb65fc" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jan 29 16:11:49 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Feb 02 14:14:08 2018 +0000" }, "message": "Create list of open dex files for libbacktrace.\n\nThis fixes unwinds after recent changes (oob apks; cdex data sharing).\n\nBug: 72520014\nTest: m test-art-host-gtest\nChange-Id: Ie2a02657b2afbe899acd2e61f0a57d207e688b99\n" }, { "commit": "0225f8e2939a9340cb7dcebfcfe7996a2bd9bce9", "tree": "fd32362dff4ecdc8ff8b0d800a1b46fb0d9d0104", "parents": [ "c7e546ff3963a1d51b1f100d308db735bd19f736" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 08:52:24 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 01:24:53 2018 -0800" }, "message": "Revert \"Revert \"Make libdexfile build independent of runtime dir\"\"\n\nThis reverts commit 787784f9effb126b5d0d3dc97d544c4a477b5daf.\n\nReason for revert: Bot configuration issue.\n\nChange-Id: I6a10bb4a9571f89c7e4dd095f9157e830a44e2de\nBug: 22322814\nTest: make -j 50 checkbuild\n" }, { "commit": "787784f9effb126b5d0d3dc97d544c4a477b5daf", "tree": "1ff6d9fd284a4dd2a337165dff20e71137997c9d", "parents": [ "b40b7e73469339a6b667b4a2e2b8690112a74dc9" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "message": "Revert \"Make libdexfile build independent of runtime dir\"\n\nThis reverts commit b40b7e73469339a6b667b4a2e2b8690112a74dc9.\n\nReason for revert: on device libdexfile.so missing\n\nChange-Id: I9bd61a98bef870400580e8c991cb061d3f57fa72\n" }, { "commit": "b40b7e73469339a6b667b4a2e2b8690112a74dc9", "tree": "7e8a34d9c7894c4c946f674f19f0a0a512b95184", "parents": [ "9690ad794b324ba54e936608881ac0f62538b97a" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 25 17:11:07 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 01:17:58 2018 -0800" }, "message": "Make libdexfile build independent of runtime dir\n\nRemove libdexfile\u0027s dependency on utils.cc and move utf.cc into\n/dex. Remove libdexfile\u0027s constituent sources from libart and\nuse libdexfile wherever libart is. Also remove some ART-specific\ninterfaces. Libdexfile\u0027s tests remain to be converted, plus\nmoving the files to a new directory peer to runtime/.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Ifaf695216e4a0e43d3aa377984d933f7a2a243c2\n" }, { "commit": "bff7a52e2c6c9e988c3ed1f12a2da0fa5fd37cfb", "tree": "e281a8dde61e396ed5f20c31d41086b1b1b18389", "parents": [ "83af48e9f4cdfcf3f0069c63561bab4c176bd2f1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 25 13:33:07 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 25 15:05:16 2018 +0000" }, "message": "Revert \"Compiler changes for bitstring based type checks.\"\n\nBug: 64692057\nBug: 71853552\nBug: 26687569\n\nThis reverts commit eb0ebed72432b3c6b8c7b38f8937d7ba736f4567.\n\nChange-Id: I7daeaa077960ba41b2ed42bc47f17501621be4be\n" }, { "commit": "2b1a21ed3581f77f34d582507177ebce33565534", "tree": "cd27b9f81588d3942d0fd7d61fceb5f3128484a1", "parents": [ "f450a37b16062980d93a8744408c9b710895c22d", "29742602424fe8a30884a00947120bd3407f4da6" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jan 24 15:47:20 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jan 24 15:47:20 2018 +0000" }, "message": "Merge \"Load /data oat/odex files non-executable when only_use_system_oat_files is set.\"" }, { "commit": "be2b613f5a30cdf2291b9f4f5d0acc2c1bb0b4ae", "tree": "0ff068df6465b52458ecca3de96d119234415def", "parents": [ "2e1791b74406fba9930bbe5dfa5358d2d2c07e1a", "eb0ebed72432b3c6b8c7b38f8937d7ba736f4567" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jan 23 14:59:45 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jan 23 14:59:45 2018 +0000" }, "message": "Merge \"Compiler changes for bitstring based type checks.\"" }, { "commit": "eb0ebed72432b3c6b8c7b38f8937d7ba736f4567", "tree": "74d95eb4bfbf01ef6fd3a68695f5d7cec69338d7", "parents": [ "e57043081e6b091a9fd23a84043373148ae72f1f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 10 18:26:38 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jan 23 13:02:59 2018 +0000" }, "message": "Compiler changes for bitstring based type checks.\n\nWe guard the use of this feature with a compile-time flag,\nset to true in this CL.\n\nBoot image size for aosp_taimen-userdebug in AOSP master:\n - before:\n arm boot*.oat: 63604740\n arm64 boot*.oat: 74237864\n - after:\n arm boot*.oat: 63531172 (-72KiB, -0.1%)\n arm64 boot*.oat: 74135008 (-100KiB, -0.1%)\n\nThe new TypeCheckBenchmark yields the following changes\nusing the little cores of taimen fixed at 1.4016GHz:\n 32-bit 64-bit\n timeCheckCastLevel1ToLevel1 11.48-\u003e15.80 11.47-\u003e15.78\n timeCheckCastLevel2ToLevel1 15.08-\u003e15.79 15.08-\u003e15.79\n timeCheckCastLevel3ToLevel1 19.01-\u003e15.82 17.94-\u003e15.81\n timeCheckCastLevel9ToLevel1 42.55-\u003e15.79 42.63-\u003e15.81\n timeCheckCastLevel9ToLevel2 39.70-\u003e14.36 39.70-\u003e14.35\n timeInstanceOfLevel1ToLevel1 13.74-\u003e17.93 13.76-\u003e17.95\n timeInstanceOfLevel2ToLevel1 17.02-\u003e17.95 16.99-\u003e17.93\n timeInstanceOfLevel3ToLevel1 24.03-\u003e17.95 24.45-\u003e17.95\n timeInstanceOfLevel9ToLevel1 47.13-\u003e17.95 47.14-\u003e18.00\n timeInstanceOfLevel9ToLevel2 44.19-\u003e16.52 44.27-\u003e16.51\nThis suggests that the bitstring typecheck should not be\nused for exact type checks which would be equivalent to the\n\"Level1ToLevel1\" benchmark. Whether the implementation is\na beneficial replacement for the kClassHierarchyCheck and\nkAbstractClassCheck on average depends on how many levels\nfrom the target class (or Object for a negative result) is\na typical object\u0027s class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: testrunner.py --host -t 670-bitstring-type-check\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --target -t 670-bitstring-type-check\nBug: 64692057\nBug: 71853552\nBug: 26687569\nChange-Id: I538d7e036b5a8ae2cc3fe77662a5903d74854562\n" }, { "commit": "7b4c09a39fd1b43995aa6d68958113463bc5b82b", "tree": "2fad44f5bbb1234bb0cc07312dac252deeca2edb", "parents": [ "c7ae623f113484f42facd560756b13f34f7eab68", "7f4aff6705f46f411874b5ca8c4856b8ed5bfb13" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Mon Jan 22 21:04:20 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jan 22 21:04:20 2018 +0000" }, "message": "Merge \"ART: Implement SuperblockCloner.\"" }, { "commit": "a79efdb69350fa66e1beabed4499ef4d0e809785", "tree": "0a7491e10f646075b2d535cf69e13145224bb2ca", "parents": [ "ccc5401bf082e4292a2cb75eeeb216a441189aef" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 18 16:31:01 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jan 22 08:46:37 2018 -0800" }, "message": "Fix quickening logic\n\nFix varius bugs in the quickening logic where related to shared code\nitems for different methods.\n\nFixed the case where two methods quicken differently on the same code\nitem by checking that the quicken info is the same for all methods\nthat quicken the same code item. This is accomplished by requickening\nand reverifying the contents of the quicken info.\n\nFixed the case where the dex to dex compiler would abort from a\nDCHECK that there was no already quickened instructions.\n\nFeature is tested by enabling deduping (aog/594315).\n\nTest: test-art-host\nBug: 63756964\n\nChange-Id: I52c2b89518f4e808594b450a5fcc373ab5a5863b\n" }, { "commit": "dc682aa9d0eae1a851af059434adb6f6cf8f06f8", "tree": "f93f00493ee5887b05b42a6a5dd99eb6794daad4", "parents": [ "d6b7e8c63f8eca25460f56f66dcae15eaa897ff0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jan 04 18:42:57 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 10 14:30:26 2018 +0000" }, "message": "Use 28 bits for type check bit string.\n\nAnd reverse the order of fields in the Class::status_. This\navoids generated code size increase:\n - ClassStatus in high bits allows class initialization\n check using \"status_high_byte \u003c (kInitialized \u003c\u003c 4)\"\n which is unaffected by the low 4 bits of LHS instead of\n needing to extract the status bits,\n - the type check bit string in the bottom bits instead of\n somewehere in the middle allows the comparison on ARM\n to be done using the same code size as with the old\n layout in most cases (except when the compared value is\n 9-16 bits and not a modified immediate: 2 bytes less for\n 9-12 bits and sometimes 2 bytes more for 13-16 bits; the\n latter could be worked around using LDRH if the second\n character\u0027s boundary is at 16 bits).\n\nAdd one of the extra bits to the 2nd character to push its\nboundary to 16 bits so that we can test an implementation\nusing 16-bit loads in a subsequent CL, arbitrarily add the\nother three bits to the 3rd character. This CL is only\nabout making those bits available and allowing testing, the\ndetermination of how to use the additonal bits for the best\nimpact (whether to have a 4th character or distribute them\ndifferently among the three characters) shall be done later.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 64692057\nChange-Id: I38c59837e3df3accb813fb1e04dc42e9afcd2d73\n" }, { "commit": "7f4aff6705f46f411874b5ca8c4856b8ed5bfb13", "tree": "59947502e43f04c23d212b6ea0e8dca3d91549e3", "parents": [ "30f54cc45bd338f9d9079786dae96ea13ab9f163" ], "author": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Wed Jun 21 17:02:18 2017 +0100" }, "committer": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Tue Jan 09 13:52:59 2018 +0000" }, "message": "ART: Implement SuperblockCloner.\n\nSuperblockCloner provides a feature of cloning subgraphs in a\nsmart, high level way without fine grain manipulation with IR;\ndata flow and graph properties are resolved/adjusted automatically.\nThe clone transformation is defined by specifying a set of basic\nblocks to copy and a set of rules how to treat edges, remap their\nsuccessors. By using this approach such optimizations as Branch\nTarget Expansion, Loop Peeling, Loop Unrolling can be implemented.\n\nTest: superblock_cloner_test.cc.\nChange-Id: Ibeede38195376ca35f44ba9015491e50b3a5b87e\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "2c64a837e62c2839521c89060b5bb0dcb237ddda", "tree": "65475ed2e313ff17354e741bac7e9c85739b8b95", "parents": [ "6cd0005698181e4cef2247b632d396e605d58fa3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jan 04 11:31:56 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 05 11:27:50 2018 +0000" }, "message": "Change ClassStatus to fit into 4 bits.\n\nIn preparation for extending the type check bit string from\n24 to 28 bits, rewrite ClassStatus to fit into 4 bits. Also\nperform a proper cleanup of the ClassStatus, i.e. change it\nto an enum class, remove the \"Status\" word from enumerator\nnames, replace \"Max\" with \"Last\" in line with other\nenumerations and remove aliases from mirror::Class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 64692057\nBug: 65318848\nChange-Id: Iec1610ba5dac2c527b36c12819f132e1a77f2d45\n" }, { "commit": "3165bb09dc04b61abd04bf8e263dd85d610694e4", "tree": "3a4e2d4b6001b2bc8e7a8860565943c285e61f63", "parents": [ "a3e50959997f5c3e3b2d7e200b3b022757845f20", "4557b3858a66aa20e42bce937e1f0620aad880a2" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Jan 04 09:02:46 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jan 04 09:02:46 2018 +0000" }, "message": "Merge \"ART: Rename Atomic::CompareExchange methods\"" }, { "commit": "ca420e49fc97983c2b49f42823bba68e3af26998", "tree": "caefec604b3e1dea7b4bd3dcb96fe473dab38b05", "parents": [ "ce4982554648998abd0980bd06e738f4bcaa35d9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 03 13:37:04 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 03 14:08:08 2018 +0000" }, "message": "Replace TypeStaticIf\u003c\u003e with std::conditional\u003c\u003e (C++11).\n\nTest: m\nChange-Id: I7052da55bfe4d69b2ac62965689b89e4f8548056\n" }, { "commit": "4557b3858a66aa20e42bce937e1f0620aad880a2", "tree": "8f34d8f014b11f17c6351bb955fcc74c940b8d16", "parents": [ "90f20973356900e340998e8e2b34230e5c4c8fb0" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 11:47:54 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 03 12:45:40 2018 +0000" }, "message": "ART: Rename Atomic::CompareExchange methods\n\nRenames Atomic::CompareExchange methods to Atomic::CompareAndSet\nequivalents. These methods return a boolean and do not get the witness\nvalue. This makes space for Atomic::CompareAndExchange methods in a\nlater commit that will return a boolean and get the witness value.\n\nThis is pre-work for VarHandle accessors which require both forms.\n\nBug: 65872996\nTest: art/test.py --host -j32\nChange-Id: I9c691250e5556cbfde7811381b06d2920247f1a1\n" }, { "commit": "55256cb60e11d4fac71affb4b9760a2931a3598d", "tree": "fc1ed6885b013e0aa2bcfd9ef4dd94fec29bd382", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Dec 21 17:07:11 2017 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Dec 22 10:11:39 2017 -0800" }, "message": "Extensions to check JNI.\n\nEnsure critical lock isn\u0027t held when returning from a down-call.\nLog a warning if the critical lock is held for a significant period of\ntime.\nRefactor JNIEnvExt to be a class rather than a struct.\n\nTest: mma test-art-host\n\nChange-Id: I4d149cb04d3a7308a22b92b196e51e2f1ae17ede\n" }, { "commit": "b91f9c154a816620f01206e119f036d9d28ce683", "tree": "a63aca252021ddcfa218dc768c6ebe59412cc4f7", "parents": [ "ffc3be6b4a58c1ed172a5c890f8b8583a416998f" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Tue Dec 19 15:01:28 2017 -0800" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Wed Dec 20 12:28:16 2017 -0800" }, "message": "Make GetState() handle overflowed state and 0 path to root\n\nFix GetState() so that it deals correctly with an overflowed state in\nwhich the path to root is entirely zero. We don\u0027t try to salvage\nthe DCHECK for now. Fix the stated invariants to be more consistent\nwith the code.\n\nBug: 69564627\nTest: AOSP builds \u0026 runs. Host tests pass.\nChange-Id: Idd975f03d4292e4fc52ad7714bbb2b1b98e17f96\n" }, { "commit": "29742602424fe8a30884a00947120bd3407f4da6", "tree": "11e72080858e75055eb350dd183b51e6daddffdb", "parents": [ "7eb4333d0b60a13f9d3126eadef9eb16c399662a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Dec 14 10:09:03 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 18 15:21:05 2017 +0000" }, "message": "Load /data oat/odex files non-executable when only_use_system_oat_files is set.\n\nMake it still ok to use the vdex and the class status in the oat file.\nThis means:\n- If dex code is uncompressed in APK we\u0027ll use that\n- If dex code is compressed in APK, we\u0027ll use the dex code in the vdex.\n\nThis is a temporary solution in order to almost mimic performance-wise what\nfull stack integrity wants to achieve (priv-apps running from verified,\nuncompressed dex code in APK).\n\nThis is to assess the impact of full stack integrity on privileged apps.\n\nThis CL doesn\u0027t ensure any integrity, and doesn\u0027t check whether the vdex has\nbeen \"tainted\".\n\nbug: 30972906\n\nChange-Id: If0a6ab26dd6211290db53b7f02d88d45aff68c0c\n" }, { "commit": "0bd8a870819def63054f32257fa2aa06c785cf39", "tree": "defc8bfe0d1f7bc9c219d79d98d2682784c94ce4", "parents": [ "9e8034535c774979a26b9ac35bd59876cb612926", "ae915a0182db98769ed4851fab440e79e012babd" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Fri Dec 15 20:51:33 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 15 20:51:33 2017 +0000" }, "message": "Merge \"Improve scoped spinlock implementations\"" }, { "commit": "ae915a0182db98769ed4851fab440e79e012babd", "tree": "05d9411ed11fe95ccbcc73f4300c819563bbbf3d", "parents": [ "9e73b32fed15d262b0393f114b9602ac7ef88917" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Tue Dec 12 11:05:32 2017 -0800" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Fri Dec 15 10:53:19 2017 -0800" }, "message": "Improve scoped spinlock implementations\n\nBoth ScopedAllMutexesLock and ScopedExpectedMutexesOnWeakRefAccessLock\nreally implement simple spinlocks. But they did it in an unorthodox\nway, with a CAS on unlock. I see no reason for that. Use the standard\n(and faster) idiom instead.\n\nThe NanoSleep(100) waiting logic was probably suboptimal and definitely\nmisleading. I timed NanoSleep(100) on Linux4.4 host, and it takes about\n60 usecs, i.e. 60,000 nsecs. By comparison a no-op sched_yield takes\nabout 1 usec. This replaces it with waiting logic that should be\ngenerically usable. This is no doubt overkill, but the hope is that\nwe can eventually reuse this where it matters more.\n\nTest: Built and booted AOSP.\n\nChange-Id: I6e47508ecb8d5e5d0b4f08c8e8f073ad7b1d192e\n" }, { "commit": "a7f6b8151ee8b8c16a11e148fea1c02ca33dc211", "tree": "f82167347158bd46e67cf0980af7131f2c7e5453", "parents": [ "078f96f743805d951cea8f71af768facd17eba78" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 11 13:34:29 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 11 17:54:15 2017 -0800" }, "message": "Add ART_DEFAULT_COMPACT_DEX_LEVEL\n\nIf specified, this option changes the default compact dex level used\nby dex2oat. Defaults to none currently.\n\nBug: 63756964\nTest: ART_DEFAULT_COMPACT_DEX_LEVEL\u003dfast mm test-art-host-gtest and verify it fails for now.\nTest: test/testrunner/testrunner.py --host -j64 and verify it passes\n\nChange-Id: Ib252f432b3545297725656a5cca40d1bb57b0ced\n" }, { "commit": "9b827ab7e63cf8b24987e75186434348d0dbf4e8", "tree": "7be2f4c9a19d809d8c77e2d516fbd2b62f41c672", "parents": [ "c654816053ae07fb1f129d705e94b76e59f37454" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 07 19:32:48 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:22:36 2017 -0800" }, "message": "ART: Clean up ATRACE use\n\nRemove old ATRACE_BEGIN \u0026 _END pairs, where possible. Remove\nATRACE_CALL and replace it with ScopedTrace.\n\nRemove utils/Trace.h include.\n\nTest: m\nChange-Id: I3a5123202f4e373074bfe0f7359ee6c60a70352a\n" }, { "commit": "c654816053ae07fb1f129d705e94b76e59f37454", "tree": "867d678ab3f6e0f4af70da98e935aafae0c6126c", "parents": [ "8f1a586fd4ac9796e75b2b18638e39b33ad6e9a2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:15:22 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 12:22:21 2017 -0800" }, "message": "ART: Change SCOPED_TRACE implementation\n\nMove to a LOG-like usage pattern. This improves usability in the\npresence of lock annotations.\n\nDemonstrate in the JIT compiler, where a lambda would require\na REQUIRES_SHARED annotation.\n\nTest: m\nTest: manual\nChange-Id: I9da2bfb29ed11660dbeb6f114a3d6c7ffef3a26d\n" }, { "commit": "8f1a586fd4ac9796e75b2b18638e39b33ad6e9a2", "tree": "f1970c938487dbd9e773619804612ac824b0721c", "parents": [ "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5", "170331f0e44a0e07fcfe0b5932517e0500f5cd1f" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Dec 08 19:28:07 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 19:28:07 2017 +0000" }, "message": "Merge changes I917df597,Ib2ca880e,Ib3733573,I3e3a4672\n\n* changes:\n ART: Remove base/logging from heap-inl.h\n ART: Factor out gAborting\n ART: Move runtime-debug flags to own files\n ART: Replace base/logging with android-base/logging\n" }, { "commit": "f223f76bdd360664a1e8068eeac6ce35f7392bc6", "tree": "d3d0a8f6cb7841b0052301d22963e1978ff0563f", "parents": [ "d5153627778e71ef68b510ce03c77467fa4d85bd", "dfebbac8e30172169dbdaaf7e6a0be51433d57f1" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Dec 08 02:58:59 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Dec 08 02:58:59 2017 +0000" }, "message": "Merge \"ART: Add ScopedTrace constructor with lambda\"" }, { "commit": "dfebbac8e30172169dbdaaf7e6a0be51433d57f1", "tree": "3c751ff6792aaf88706fd0b3e0ed77d2cc4f83c2", "parents": [ "92ab698e46dba3b6cff1457f47bfc344cb03f7ec" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 06 14:17:22 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 08 02:54:45 2017 +0000" }, "message": "ART: Add ScopedTrace constructor with lambda\n\nIn an effort to allow more complex and expensive atrace tagging,\nadd a ScopedTrace constructor that uses a passed-in lambda to\ncompute the string lazily.\n\nAdd a macro to simplify usage.\n\nTest: m\nChange-Id: I3b4576d786177042922fef0d05161e4cc11144d4\n" } ], "next": "39b378ca3b4b6dc6da1651b84ee4289cd9bff0f8" }