)]}' { "log": [ { "commit": "2259f1c008bee88902057ecc2ca1b91fe4e74bd7", "tree": "376098e43ea9cacbfd4aa5360f7cfd7c3df96c84", "parents": [ "4706ff08bd26dc958d3f162894b92036b02cdeb7" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jan 16 23:18:30 2019 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jan 17 16:26:14 2019 +0000" }, "message": "Extend lifetime of CodeInfo in StackVisitor.\n\nUsers of the visitor may use the API after WalkStack is finished.\n\nTest: test.py -b --host\nBug: 120844051\nChange-Id: Ia445d3b4c5c338402c92f1d29b522a33cd5baa14\n" }, { "commit": "226805d9b81ba442251d0e2c4baedc36fcda6592", "tree": "3a256b1d36894d8d43ec9650f2a3f55c90c4730c", "parents": [ "96453b7d6aa445c6609aa465df5d66ae0beb7956" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Dec 14 10:59:02 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 19 09:22:01 2018 +0000" }, "message": "Deoptimize zygote compiled methods in DeoptimizeBootImage.\n\nThose methods don\u0027t get compiled with the \"debuggable\" flag,\nso we need to deoptimize them.\n\nAlso fix a bug revealed by the new test where a concurrent\nJIT collection happens when trying to disable it.\n\nAlso make DeoptimizeBootImage truly mutator lock exclusive.\n\nTest: 689-zygote-jit-deopt\nChange-Id: I00607dbe100350c5328293c35c87946fa97924b8\n" }, { "commit": "4cbfadc29b4ba89b32fa6eb55a287db78d12a45c", "tree": "70cd681c4326ab8cf034da6c0fb0fef222cd67b1", "parents": [ "a48eb7e0690187618d2824a7d9b5601e7f5cdf80" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 10 16:09:43 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Oct 12 10:07:41 2018 +0100" }, "message": "Remove CHECK that GetThis() must always work.\n\nEnsures GetVReg of a reference on compiled code checks that the\nvalue is indeed a reference from the stack maps.\n\nbug: 116683601\nbug: 117452149\nTest: 686-get-this\nChange-Id: I3a370c45786a4892c7888491bec6d5ae64672f6c\n" }, { "commit": "bbc6e7edb5fca4a61ac53dd9bce79cb4f0bb3403", "tree": "0fbce767bc383358cf4cd65aafc74140e1850982", "parents": [ "19379b58bd433da91230e4fe6cd96e7416d16adc" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 24 16:58:47 2018 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Aug 28 11:06:07 2018 +0100" }, "message": "Use \u0027final\u0027 and \u0027override\u0027 specifiers directly in ART.\n\nRemove all uses of macros \u0027FINAL\u0027 and \u0027OVERRIDE\u0027 and replace them with\n\u0027final\u0027 and \u0027override\u0027 specifiers. Remove all definitions of these\nmacros as well, which were located in these files:\n- libartbase/base/macros.h\n- test/913-heaps/heaps.cc\n- test/ti-agent/ti_macros.h\n\nART is now using C++14; the \u0027final\u0027 and \u0027override\u0027 specifiers have\nbeen introduced in C++11.\n\nTest: mmma art\nChange-Id: I256c7758155a71a2940ef2574925a44076feeebf\n" }, { "commit": "8cd54547cec8a4537db5682c2da8be22843b1310", "tree": "fb1158993bab2e027984cedab59b402c051a45a7", "parents": [ "91f0fdb4372d3f2bcfcd9db67afcbe7ee1901048" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jul 15 23:58:44 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Aug 01 14:49:40 2018 +0100" }, "message": "Move MethodInfo to CodeInfo.\n\nThere is no need to treat it specially any more,\nbecause of the de-duplication at BitTable level.\n\nThis saves 0.6% of oat file size.\n\nTest: test-art-host-gtest\nChange-Id: Ife7927d736243879a41d6f325d49ebf6930a63f6\n" }, { "commit": "6ee06e97cef5ee92944deaeba0da4d10c4c33a2a", "tree": "77d69c85d37864b4d3ee970be4b7fd1246adee7b", "parents": [ "f5dcd31d89282b6c9324fdc960e6e7e2281c16f1" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 25 21:45:54 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 26 11:45:54 2018 +0100" }, "message": "Decode only the needed tables from CodeInfo.\n\nMost use cases need only the first two bit tables from CodeInfo.\nAdd flag to the decode method so that only those two are loaded.\nWe only touched the table header but that still made difference.\n\nThis speeds up pmd by over 10%.\n\nTest: test-art-host-gtest\nChange-Id: I7740081bf18205dd69864503b5bcec7de5e1a901\n" }, { "commit": "d93e374e273dd45f5d829399da1d4201bf46057e", "tree": "280dc72b2aec4696bbc35ad39ca8d3479107380e", "parents": [ "7f7f9d3991f3a55da8934a3b72890d4776373598" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jul 18 10:58:13 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 19 16:04:38 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify ArtMethod and mirror::Method.\n\nAnd clean up some forgotten things after old CLs.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: I8af0e845c24d674d0efab21d80c29949b1cc0593\n" }, { "commit": "b808ddca3d4816132f6f05bebcc6676144b1f6b6", "tree": "8806f6bab46a441fb9ea68d130abd31ba876518b", "parents": [ "97c465ca6ee4c76766f8abaa3a98ee0329019c5c", "afc97bca07c85d4c3b46801c557edd12d681fc96" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jul 06 13:57:41 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jul 06 13:57:41 2018 +0000" }, "message": "Merge \"Revert^2 \"Add CodeInfo to JNI methods.\"\"" }, { "commit": "afc97bca07c85d4c3b46801c557edd12d681fc96", "tree": "fd53094370a28aa4ba4b9d419e05ff7797cf51ae", "parents": [ "564fa8a1f3e3c39793c9b146ed5f21650617dc3f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 05 08:14:35 2018 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 05 13:04:43 2018 +0100" }, "message": "Revert^2 \"Add CodeInfo to JNI methods.\"\n\nIt has no stack maps. We only store the frame info there.\n\nAs a consequence of having CodeInfo, the JNI methods are\nnow classified as IsOptimized().\n\nThis does not have any real effect on .oat file size.\n\nThis reverts commit 564fa8a1f3e3c39793c9b146ed5f21650617dc3f.\n\nTest: test-art-host-gtest\nTest: test-art-target-gtest-jni_compiler_test32\nChange-Id: Ic7a1949027d89ba97cfedfc8ea453f041193b6a7\n" }, { "commit": "a296f908e186398ff413c78f2460cb3138e531ab", "tree": "04592d0bcf8afac399dc562efdcac491072366eb", "parents": [ "b275072ddfb1bfcacc914aff08cb0f5774000258", "93bd3619de4616040d672a4ed3825976bed4bfce" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jul 05 00:03:21 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jul 05 00:03:21 2018 +0000" }, "message": "Merge \"Use iterators to access stack map data.\"" }, { "commit": "93bd3619de4616040d672a4ed3825976bed4bfce", "tree": "2ab3424374ed3d316053ed8e9ec2d4b95ea2ef4d", "parents": [ "f07d5617770c37d87447c8bddf105eb0469ab093" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jul 02 19:30:18 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jul 04 14:23:12 2018 +0100" }, "message": "Use iterators to access stack map data.\n\nTry to simplify the code using the recently added iterators.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I0b9f54df01749ee6ec3a67cfb07ba636a2489c89\n" }, { "commit": "35d5b8a2c5d2fce03be59aa003c3bf3c1b481be0", "tree": "7665f6d1527be61af13c8ef53f10833dd4200cfd", "parents": [ "b28683f43231e65860ecf91c96a8c0234542c019" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 03 09:18:32 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jul 03 09:18:32 2018 +0100" }, "message": "ART: Do not use std::\u003ccontainer\u003e::at().\n\nThese functions are specified as throwing std::out_of_range\nand we do not use exceptions.\n\nTest: m\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I67c365ed6d779c101a18b9f386c751c48ca76e16\n" }, { "commit": "45b12e704e158f29877c78bd9a8406db7e361537", "tree": "1bfc21d88a173b4a751a37a223a39d7c12976f95", "parents": [ "c9633c80c2125814a8a7459079c1931a5c201011", "e1402125e8363b49e176c6072893d1c110a05d2f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 14 13:37:36 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jun 14 13:37:36 2018 +0000" }, "message": "Merge \"Move some helper methods to DexRegisterLocation.\"" }, { "commit": "e1402125e8363b49e176c6072893d1c110a05d2f", "tree": "44ec055be78cdcb8086a598cbf791f8c4627e157", "parents": [ "86decb6a3e3ebba8c3c67bfd25c12d9a85794f65" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Jun 13 18:20:45 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 14 12:31:44 2018 +0100" }, "message": "Move some helper methods to DexRegisterLocation.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I0abab008159db023d531df69214cd3bb8c0639bd\n" }, { "commit": "b32c6a914e7e7658c5ea64a00f2776e351adaa74", "tree": "6ee36dcafb68a5342c31f4e667a4c0c9202b8a18", "parents": [ "ff5d955306660a6f6515967659515717076c1d87" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jun 07 16:48:04 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jun 12 16:00:28 2018 -0700" }, "message": "Removing instrumentation trampolines doesn\u0027t remove exit stubs\n\nIt is possible for tracing to be turned off (and instrumentation\ntrampolines removed) at any time so long as all threads are\nsuspended. Our stack walking code assumed that once the trampolines\nhave been removed from the method entrypoints there will be no more\nexit stubs on the stack. This is not true and can cause crashes.\n\nNB Test requires several other patches to actually run far enough to\nhit this issue.\n\nTest: ./test/testrunner/testrunner.py --host --runtime-option\u003d-Xplugin:libtracefast-trampolined.so\nChange-Id: I1bc55bc180bf4605028cae4f070e6c8e2c65f034\n" }, { "commit": "fd89b0739d4000ea70f28bf53dea531027024f5a", "tree": "1c9f3e1b046d60df405fb63f04cf83d3be4ff0f5", "parents": [ "6de8833fb64e59301eada4005ed04da995796170" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:22 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 07 12:00:18 2018 +0100" }, "message": "Remove unused GetDexRegisterMap arguments.\n\nThey are no longer needed in the new encoding.\n\nI reuse the local variables in most places to DCHECK the size\nof the decoded register map. This has one catch though:\nWe sometimes omit all dex registers, so the DCHECK should be\ndone only after checking if the map is empty (if applicable).\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I94b67029842374bc8eb7c9e5eac76fc93a651f24\n" }, { "commit": "6de8833fb64e59301eada4005ed04da995796170", "tree": "9f5b731ae1c0428cf5dcae4105936a7a165a43c9", "parents": [ "d97e0828958fd14a962e37af2865bc2e628547ce" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:11 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Jun 07 12:00:18 2018 +0100" }, "message": "Delta-compress register maps in stack maps.\n\nThe register maps tend to be similar from stack map to stack map,\nso instead of encoding them again, store only the modified ones.\n\nThe dex register bitmap stores the delta now - if register has\nbeen modified since the previous stack map, the bit will be set.\n\nThe decoding logic scans backwards through stack maps until it\neventfully finds the most recent value of each register.\n\nThis CL saves ~2.5% of .oat file size (~10% of stackmap size).\n\nDue to the scan, this makes dex register decoding slower by factor\nof 2.5, but that still beats the old algorithm before refactoring.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Id5217a329eb757954e0c9447f38b05ec34118f84\n" }, { "commit": "6e69e52a12883386f91d014324bebee867ca7877", "tree": "7d1850f0a59e4ea2d013d6d479cd616b66922970", "parents": [ "6eb4d5e4bc2ce068004c1d7c85dbfff0c5efd11d" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Sun Jun 03 12:00:14 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Jun 05 16:50:38 2018 +0100" }, "message": "Remove depth argument from InlineInfo accessors in stack maps.\n\nThe InlineInfo class actually represented a list of inlining\ninformation for a given stack map, and the depth argument was\nused everywhere to select to desired element from the list.\nThis was verbose and inconsistent with the other classes.\n\nChange the InlineInfo class to represent a single inlining,\nand select the desired depth when getting it from CodeInfo.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: I35b73e6704854f0203f51d4dbdbed5b1d1cd5a3b\n" }, { "commit": "21d45b4f4ef3661ac33d622aaac5dd6d2ce7deb8", "tree": "121e046a949025bca4d766fdfdc5ea58e4ea4a10", "parents": [ "d02b23f7ee9664213216a82bfdcb0ee83824de04" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 06:35:05 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed May 30 17:59:24 2018 +0100" }, "message": "Simplify DexRegisterMap API.\n\nStore some of the needed decoding state explicitly to avoid passing it\naround all the time. The DexRegisterMap class is rewritten in next CL.\n\nTest: test-art-host-gtest-stack_map_test\nChange-Id: Ie268dff2a1c1da2e08f0e6799ae51c30e11f350b\n" }, { "commit": "aaebb1468cc95838aa58ed537d03de000c9cfe28", "tree": "80f325dab976dccd846e3bd5d1b86266be24e3dc", "parents": [ "79866c1f089672eca1fb7776c669c2cef3d6ad3e", "6ec2a1bf1cbecf17546df780dd0ad769042e1874" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 23 14:58:19 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed May 23 14:58:19 2018 +0000" }, "message": "Merge \"ObjPtr\u003c\u003e-ify UnstartedRuntime, fix 2 stale reference uses.\"" }, { "commit": "6ec2a1bf1cbecf17546df780dd0ad769042e1874", "tree": "09f7430f020e04dc892ff2c2152bb773cd45c0dd", "parents": [ "2d3065e6ca0bd707bc998b7d260bb8e8ec07cf87" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 22 15:33:48 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 23 13:48:31 2018 +0100" }, "message": "ObjPtr\u003c\u003e-ify UnstartedRuntime, fix 2 stale reference uses.\n\nTest: Rely on TreeHugger.\nBug: 31113334\nChange-Id: I35f76c3e3b94dfca18dbe67aba065a1270f4e5ee\n" }, { "commit": "d352156dfeadc72fda186ef8dcbeea4d06eee509", "tree": "64ff7c025cacac290e21beea27ef6533e4f04d79", "parents": [ "cbe50e965be5bcc7e9e0bba8b52a9b1adb7c291f", "d3083dd15af1cb4ffc13d87a7d2c3be2edb9199d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 22 15:33:35 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 22 15:33:35 2018 +0000" }, "message": "Merge \"Refactor runtime callee save frame info.\"" }, { "commit": "d3083dd15af1cb4ffc13d87a7d2c3be2edb9199d", "tree": "88dd2599ad89da5a4f2668a2c9debd0335669cd0", "parents": [ "6623bc389c43efc87668ce7465e19b195e765e22" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 17 08:43:47 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 22 14:38:14 2018 +0100" }, "message": "Refactor runtime callee save frame info.\n\nAnd avoid storing the info in Runtime.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nChange-Id: Ib14853fc06c420753993e1f9e82a1b01f5e35e8c\n" }, { "commit": "052f8ca1776ed7deb4f036498edd69eb6a1b942f", "tree": "ae993f1a634b258e124df12663a1d24859917b05", "parents": [ "1c515f0b9d621869a2e67ce5e0f5532d0f2f323a" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Apr 26 15:42:54 2018 +0100" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon May 21 20:28:41 2018 +0100" }, "message": "Rewrite stackmap encoding code.\n\nRemove most of the code related to handling of bit encodings.\nThe design is still same; the encodings are just more implicit.\nMost of the complexity is replaced with a single BitTable class,\nwhich is a generic purpose table of tightly bit-packed integers.\nIt has its own header which stores the bit-encoding of columns,\nand that removes the need to handle the encodings explicitly.\n\nOther classes, like StackMap, are accessors into the BitTable,\nwith named getter methods for the individual columns.\n\nThis CL saves ~1% of .oat file size (~4% of stackmap size).\n\nTest: test-art-host-gtest\nChange-Id: I7e92683753b0cc376300e3b23d892feac3670890\n" }, { "commit": "0225f8e2939a9340cb7dcebfcfe7996a2bd9bce9", "tree": "fd32362dff4ecdc8ff8b0d800a1b46fb0d9d0104", "parents": [ "c7e546ff3963a1d51b1f100d308db735bd19f736" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 08:52:24 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Wed Jan 31 01:24:53 2018 -0800" }, "message": "Revert \"Revert \"Make libdexfile build independent of runtime dir\"\"\n\nThis reverts commit 787784f9effb126b5d0d3dc97d544c4a477b5daf.\n\nReason for revert: Bot configuration issue.\n\nChange-Id: I6a10bb4a9571f89c7e4dd095f9157e830a44e2de\nBug: 22322814\nTest: make -j 50 checkbuild\n" }, { "commit": "787784f9effb126b5d0d3dc97d544c4a477b5daf", "tree": "1ff6d9fd284a4dd2a337165dff20e71137997c9d", "parents": [ "b40b7e73469339a6b667b4a2e2b8690112a74dc9" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 18:48:51 2018 +0000" }, "message": "Revert \"Make libdexfile build independent of runtime dir\"\n\nThis reverts commit b40b7e73469339a6b667b4a2e2b8690112a74dc9.\n\nReason for revert: on device libdexfile.so missing\n\nChange-Id: I9bd61a98bef870400580e8c991cb061d3f57fa72\n" }, { "commit": "b40b7e73469339a6b667b4a2e2b8690112a74dc9", "tree": "7e8a34d9c7894c4c946f674f19f0a0a512b95184", "parents": [ "9690ad794b324ba54e936608881ac0f62538b97a" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 25 17:11:07 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Jan 30 01:17:58 2018 -0800" }, "message": "Make libdexfile build independent of runtime dir\n\nRemove libdexfile\u0027s dependency on utils.cc and move utf.cc into\n/dex. Remove libdexfile\u0027s constituent sources from libart and\nuse libdexfile wherever libart is. Also remove some ART-specific\ninterfaces. Libdexfile\u0027s tests remain to be converted, plus\nmoving the files to a new directory peer to runtime/.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Ifaf695216e4a0e43d3aa377984d933f7a2a243c2\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "808c7a57bb913b13c22884f57cdacd59bf1fdb3f", "tree": "d7f0d7cabaac5a7646c25bae584a82a9aa279cc0", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 15 11:19:33 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 22 09:41:17 2017 -0800" }, "message": "Make CodeItem fields private\n\nMake code item fields private and use accessors. Added a hand full of\nfriend classes to reduce the size of the change.\n\nChanged default to be nullable and removed CreateNullable.\nCreateNullable was a bad API since it defaulted to the unsafe, may\nadd a CreateNonNullable if it\u0027s important for performance.\n\nMotivation:\nHave a different layout for code items in cdex.\n\nBug: 63756964\nTest: test-art-host-gtest\nTest: test/testrunner/testrunner.py --host\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nChange-Id: I42bc7435e20358682075cb6de52713b595f95bf9\n" }, { "commit": "2196c651ecc77e49992c6c329dfce45f78ff46cb", "tree": "4eb151632fc7b851101b4264286ce5e900fa06b5", "parents": [ "dc93cac66f1db225474cec5bf0350fd7a148085e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 30 16:16:07 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 30 16:20:39 2017 +0000" }, "message": "Revert^4 \"JIT JNI stubs.\"\n\nThe original CL,\n https://android-review.googlesource.com/513417 ,\nhas a bug fixed in the Revert^2,\n https://android-review.googlesource.com/550579 ,\nand this Revert^4 adds two more fixes:\n - fix obsolete native method getting interpreter\n entrypoint in 980-redefine-object,\n - fix random JIT GC flakiness in 667-jit-jni-stub.\n\nTest: testrunner.py --host --prebuild --no-relocate \\\n --no-image --jit -t 980-redefine-object\nBug: 65574695\nBug: 69843562\n\nThis reverts commit 056d7756152bb3ced81dd57781be5028428ce2bd.\n\nChange-Id: Ic778686168b90e29816fd526e23141dcbe5ea880\n" }, { "commit": "056d7756152bb3ced81dd57781be5028428ce2bd", "tree": "154ae8968a450a2e02d88207fa09e380fd380553", "parents": [ "e7441631a11e2e07ce863255a59ee4de29c6a56f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 30 09:12:13 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 30 09:12:13 2017 +0000" }, "message": "Revert \"Revert \"Revert \"JIT JNI stubs.\"\"\"\n\nStill seeing occasional failures on 667-jit-jni-stub\n\nBug: 65574695\nBug: 69843562\n\nThis reverts commit e7441631a11e2e07ce863255a59ee4de29c6a56f.\n\nChange-Id: I3db751679ef7bdf31c933208aaffe4fac749a14b\n" }, { "commit": "e7441631a11e2e07ce863255a59ee4de29c6a56f", "tree": "a0488fac018ea391d01b751b7254719937bdee8f", "parents": [ "aa25db7d2a6f7f507c27ce49c99a33daf3059f8f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 29 13:00:56 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 29 14:04:26 2017 +0000" }, "message": "Revert \"Revert \"JIT JNI stubs.\"\"\n\nThe original CL,\n https://android-review.googlesource.com/513417 ,\nhad a bug for class unloading where a read barrier was\nexecuted at the wrong time from\n ConcurrentCopying::MarkingPhase() -\u003e\n ClassLinker::CleanupClassLoaders() -\u003e\n ClassLinker::DeleteClassLoader() -\u003e\n JitCodeCache::RemoveMethodsIn() -\u003e\n JitCodeCache::JniStubKey::UpdateShorty() -\u003e\n ArtMethod::GetShorty().\nThis has been fixed by removing sources of the read barrier\nfrom ArtMethod::GetShorty().\n\nTest: testrunner.py --host --prebuild --jit --no-relocate \\\n --no-image -t 998-redefine-use-after-free\nBug: 65574695\nBug: 69843562\n\nThis reverts commit 47d31853e16a95393d760e6be2ffeeb0193f94a1.\n\nChange-Id: I06e7a15b09d9ff11cde15a7d1529644bfeca15e0\n" }, { "commit": "47d31853e16a95393d760e6be2ffeeb0193f94a1", "tree": "344b0fddbbcc9a64bed2ba20dbe73fb227c2bdf4", "parents": [ "3417eaefe4e714c489a6fb0cb89b4810d81bdf4d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 28 18:36:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 28 18:36:12 2017 +0000" }, "message": "Revert \"JIT JNI stubs.\"\n\nSeems to break 998-redefine-use-after-free in\nsome --no-image configuration.\n\nBug: 65574695\nBug: 69843562\n\nThis reverts commit 3417eaefe4e714c489a6fb0cb89b4810d81bdf4d.\n\nChange-Id: I2dd157b931c17c791522ea2544c1982ed3519b86\n" }, { "commit": "3417eaefe4e714c489a6fb0cb89b4810d81bdf4d", "tree": "fe97f5191d25d26ef4250280f4c599b3a50f2059", "parents": [ "7bdc6e73fd97eb75f30b77f183e4fe6c2c599a09" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 21 18:14:28 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 28 13:00:09 2017 +0000" }, "message": "JIT JNI stubs.\n\nAllow the JIT compiler to compile JNI stubs and make sure\nthey can be collected once they are not in use anymore.\n\nTest: 667-jit-jni-stub\nTest: Pixel 2 XL boots.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --jit\nTest: testrunner.py --target --jit\nBug: 65574695\nChange-Id: Idf81f50bcfa68c0c403ad2b49058be62b21b7b1f\n" }, { "commit": "e2abbc604ce003c776c00ecf1293796bb4c4ac5a", "tree": "f7d124d1861cad2162c30dfe932bb4e1beaf41ef", "parents": [ "7090dfe84f78b1928fcbdfd664d0dd9ea52633ff" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Sep 15 11:59:26 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 18 11:36:24 2017 -0700" }, "message": "ART: Move kDexNoIndex to dex_file_types.h\n\nDefine the constant with the types to allow lowering the dependency\non DexFile.\n\nTest: m\nChange-Id: I3c61421db45be96d2057e01b1a7825883d8bd178\n" }, { "commit": "48b40cc97377fe67657b9936ad19395c4218b489", "tree": "6998d031e17120b8165e1f9202f433bcdda8dca1", "parents": [ "c7c25d5b4cf243cbbf06f2e4302a0faa5eccb42a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 07 16:52:40 2017 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Aug 07 18:01:57 2017 +0100" }, "message": "Use the right class loader allocator in ReallocMethods.\n\nOtherwise we would leak memory.\n\nAlso complies with the JitCodeCache assumption that ArtMethods\nare allocated with the classloader that loaded the class where\nthose ArtMethods hang.\n\nbug: 64241268\nTest: 661-classloader-allocator\nChange-Id: I9e4ddbf8f40547084a1a4983459db48f68743cc7\n" }, { "commit": "36a296ff674e0aea16b29db965f84f81866b1375", "tree": "9d940463852089016a0d0932368923d04da2c3fe", "parents": [ "77c7d1093281bec76d3055541fe41145cdc5f807" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 13 14:11:11 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 19 16:21:58 2017 -0700" }, "message": "ART: Refactor stack.h\n\nFactor out LockCountData, ShadowFrame and JavaFrameRootInfo and leave\nstack.h for the StackVisitor. Move single-use function to user to remove\nDexFile dependency.\n\nTest: m test-art-host\nChange-Id: I53d2880917bdf6782856fd2b16f38a0293f3aefc\n" }, { "commit": "8228cdf4ad6322ec8133564aaa51f966d36c0f17", "tree": "6d2f5cf4e742ad644ad30eb96a9f943c9ebcb34b", "parents": [ "83b140474aa1759739c8ee4464bf226c4fa0f6d7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 30 15:03:54 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 13:13:15 2017 -0700" }, "message": "ART: Move CalleeSaveType to callee_save_type.h\n\nMove the type out of runtime to decrease dependencies. Make it\na proper enum class. Fix up usage.\n\nTest: m test-art-host\nChange-Id: Id84c44bf3c59f37c8a43548e720c5fb65707b198\n" }, { "commit": "82c6933a59b7d9fcc211ed8ef56a6c7eefa61dfc", "tree": "dc4e163316591ea1ff3984bcd119b4de73a2e33f", "parents": [ "81c769436a89b25c781eb2da882f11fd8d11f84d", "88ca8ba34bbf9d355035330572cc1c3624de022c" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Mon Jun 05 20:15:51 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jun 05 20:15:53 2017 +0000" }, "message": "Merge \"Relax an assert in AssertPcIsWithinQuickCode()\"" }, { "commit": "513061a792b22c417c938d31c19581390709561c", "tree": "80b4fdce03711170626aa5640d07b07de4a326a1", "parents": [ "38c4ae5f4c5a033b7a7441032f39ea58f5772d4c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 09:17:34 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 12:59:13 2017 -0700" }, "message": "ART: Clean up thread.h and thread_list.h\n\nRemove dependency on stack.h and gc_root.h. Remove unused object\ncallbacks include. Factor out ManagedStack into its own set of files.\nFix up users of transitive includes.\n\nTest: m test-art-host\nChange-Id: I01286c43d8c7710948c161b1348faabb05922e59\n" }, { "commit": "88ca8ba34bbf9d355035330572cc1c3624de022c", "tree": "a1447c5290ac05342077913605c48cb076e6c10c", "parents": [ "14538fb50832ac20445af5a92003bc250f486c22" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Tue May 23 14:21:07 2017 -0700" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Tue May 30 17:04:03 2017 -0700" }, "message": "Relax an assert in AssertPcIsWithinQuickCode()\n\nSkip the case when pc is jitted code.\n\nBug: 36467228\nTest: m -j20 test-art-host-run-test\nTest: test/run-test --host --prebuild --jit --no-relocate --runtime-option -Xcheck:jni --no-image --64 597-deopt-new-string\n\nChange-Id: Ie9c325e2eaf7c81f1769abacc2d2615b1c1c97cb\n" }, { "commit": "f040be6668b6566066fc4bf7c447569b5b46d670", "tree": "1d0ab31a540a33947d44a2f06d1224a387506d3f", "parents": [ "39d562895ab3ff835003fe3df6c13a93db492aa8" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 14 21:49:33 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 14 21:52:45 2017 -0700" }, "message": "ART: Tentative fix for stack count issue in test 913\n\nUse kCountTransition \u003d\u003d kNo to also skip runtime methods in the\ncur_depth_ count of a StackVisitor.\n\nCurrently this is only used in the VisitRoots function of Thread.\nIf the additional load is too expensive, we can make this dependent\non the requested precision (and thus revert \"regular\" visits to\nthe old scheme of also counting transitions between managed stack\nframes and shadow frames, which is only an increment of a field).\n\nBug: 31385354\nBug: 32072923\nTest: m test-art-host\nChange-Id: Ief951585407dd6e03f8050774fe612e7b204247e\n" }, { "commit": "db01a091aefbd78b56777f4c2e8c5e3f2d8c2712", "tree": "62dbbd082c5a4cfc122830a4df0a2ced219d8d6d", "parents": [ "432fccc4c001fcd822f401aea1a4214b713bd896" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Apr 03 15:39:55 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Apr 04 11:44:35 2017 -0700" }, "message": "Ensure invoking obsolete methods throws errors.\n\nThis sets the entrypoint for obsolete methods to a special stub that\nwill ensure that calling them results in an Error being thrown.\nPreviously we were allowing obsolete methods to be run if they could\nreach the appropriate places in the runtime.\n\nGetting into the state where this is possible is extremely difficult\nsince one can only get an jmethodID to an obsolete method by snatching\nit off the stack (or by inspecting internal runtime data). From there\nnormally invoking it will do lookup on the receiver which will get you\nthe original version.\n\nBug: 36867251\nBug: 31455788\n\nTest: ./test.py --host -j40\nTest: (with aosp_marlin-userdebug device) ./test.py --target -j4\n\nChange-Id: I2ca0503966a4e3de18dd89cb7ff224eba1459b49\n" }, { "commit": "cbcedbf9382bc773713cd3552ed96f417bf1daeb", "tree": "58eed766a69ddddbc41d21624244e14547fa1dff", "parents": [ "ef62210a1466c133056c4bfdae9f8f5417065eff" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Mar 12 22:24:50 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 16 10:20:34 2017 -0700" }, "message": "Add method info to oat files\n\nThe method info data is stored separately from the code info to\nreduce oat size by improving deduplication of stack maps.\n\nTo reduce code size, this moves the invoke info and inline info\nmethod indices to this table.\n\nOat size for a large app (arm64): 77746816 -\u003e 74023552 (-4.8%)\nAverage oat size reduction for golem (arm64): 2%\n\nRepurposed unused SrcMapElem deduping to be for MethodInfo.\nTODO: Delete SrcMapElem in a follow up CL.\n\nBug: 36124906\n\nTest: clean-oat-host \u0026\u0026 test-art-host-run-test\n\nChange-Id: I2241362e728389030b959f42161ce817cf6e2009\n" }, { "commit": "eee0bd448ec057d3f224895ddb868786758eeb5b", "tree": "32283e1b1ccb97bced2999a364cf21361c8d07ac", "parents": [ "02b2349b1cd2a78e86b1a7542f8330e6c3aaeb35" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Feb 14 15:31:45 2017 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Feb 14 09:28:19 2017 -0800" }, "message": "Revert^6 \"Make class redefinition work with native methods on stack.\"\n\nWe were incorrectly trying to obtain the profiling information of a\nnative method.\n\nThis reverts commit 02b2349b1cd2a78e86b1a7542f8330e6c3aaeb35.\n\nReason for revert: Fixed test failure with jit configurations\n\nTest: ART_TEST_JIT\u003dtrue mma -j40 test-art-host\n\nChange-Id: Ic7112104aec64e597d2df80db5dc2a505d2cc2dd\n" }, { "commit": "02b2349b1cd2a78e86b1a7542f8330e6c3aaeb35", "tree": "f5981b3ef21e41a4df6edc203615f15f23e93ad5", "parents": [ "724f77e2fed038d57a3d08fdcf656d703e3473ea" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 14 10:49:09 2017 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 14 10:49:09 2017 +0000" }, "message": "Revert \"Revert^4 \"Make class redefinition work with native methods on stack.\"\"\n\nART run-test 945-obsolete-native is failing in automated\ntesting.\n\nThis reverts commit 724f77e2fed038d57a3d08fdcf656d703e3473ea.\n\nChange-Id: I4eceb45765826ca442ee8f4800b2bed51f98e662\n" }, { "commit": "724f77e2fed038d57a3d08fdcf656d703e3473ea", "tree": "a9ce49e4e345defa257df168f354710159a818ff", "parents": [ "38c20d4a694eea44a1bd3af32a6a99512c139358" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Sat Feb 11 00:43:10 2017 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Feb 13 16:52:07 2017 -0800" }, "message": "Revert^4 \"Make class redefinition work with native methods on stack.\"\n\nWe had a problem where there was a brief period of time where the dex\nfile for an obsolete method could not be obtained. This meant that not\nall functions of ArtMethod could safely be called, causing some\nproblems.\n\nThis reverts commit 38c20d4a694eea44a1bd3af32a6a99512c139358.\n\nReason for revert: Fixed issues with interp-ac and relocate-npatchoat\n\nTest: ART_TEST_RUN_TEST_RELOCATE_NO_PATCHOAT\u003dtrue \\\n ART_TEST_INTERPRETER_ACCESS_CHECKS\u003dtrue \\\n mma -j40 test-art-host\n\nChange-Id: I04991f3e76813831b6446f97636b6fa404397f36\n" }, { "commit": "38c20d4a694eea44a1bd3af32a6a99512c139358", "tree": "f5981b3ef21e41a4df6edc203615f15f23e93ad5", "parents": [ "4493f92dfc70e01d95ad57bc4c0c38f59a616f70" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Sat Feb 11 00:38:35 2017 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Sat Feb 11 00:38:35 2017 +0000" }, "message": "Revert \"Revert \"Revert \"Make class redefinition work with native methods on stack.\"\"\"\n\nThis reverts commit 4493f92dfc70e01d95ad57bc4c0c38f59a616f70.\n\nReason for revert: Fails interpreter-ac and relocate-npatchoat\n\nChange-Id: I15eb4964c9101fa04e34b52acf9ffe25e6d4e60d\nTest: revert\n" }, { "commit": "4493f92dfc70e01d95ad57bc4c0c38f59a616f70", "tree": "8762ba0636b735e43cdd714755cd622ef718580b", "parents": [ "806ac631e53f12061cb0ae7640aa9cd0dd79243d" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Feb 10 16:33:26 2017 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Feb 10 11:46:56 2017 -0800" }, "message": "Revert \"Revert \"Make class redefinition work with native methods on stack.\"\"\n\nWhen we were scanning the stack for tracing we were getting the wrong\nstack-frame size for obsolete native methods. This fixes it by\ncreating real obsolete native methods so we can recognize them and\nthen doing the (rather long) calculation to find their real\nstack-frame size.\n\nThis reverts commit 7558d27ccd0837fef7c4bfbff7fc82f07a787316.\n\nReason for revert: Fixed tracing failures.\n\nTest: mma -j40 test-art-host\nTest: ART_TEST_TRACE\u003dtrue ART_TEST_INTERPRETER\u003dtrue mma -j40 test-art-host\n\nChange-Id: Ic65da1b51a43733ff60131832753afa0c4ce66b1\n" }, { "commit": "575d3e60c68b5cf481b615dde4a16283507b19ed", "tree": "4718f2747233e74268de21d804df9bfe0b7e4362", "parents": [ "857acf51fbc5a931939c20e9e299c69676baf654" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 06 11:00:40 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 08 09:51:27 2017 -0800" }, "message": "Clean up code info table layout\n\nPreviously:\nTable layout was computed multiple places like stack_map_stream,\nand getters. This made it difficult to add new stack map tables and\nmade the code hard to understand.\n\nThis change makes the table layout specified all inside of the code\ninfo. Updating the layout only requires changing ComputeTableOffsets.\n\nChanged the stack map inline info offset to be an index, so that it is\nnot require the inline infos are directly after the dex register table.\n\nOat file size for a large app: 94459576 -\u003e 93882040 (-0.61%)\n\nUpdated oatdump and fixed a bug that was incorrectly computing the\nregister mask bytes.\n\nBug: 34621054\n\nTest: test-art-host\n\nChange-Id: I3a7f141e09d5a18bce2bc6c9439835244a22016e\n" }, { "commit": "02f365f0fb74acf09ffb8f04a80d32ca1152ed8b", "tree": "7658baab9ac5c3c86b974d8dd5238f3cf2d9f2f0", "parents": [ "7b220d60e3cb58c384a0d245106406080c6f3e37" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Feb 03 15:06:00 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Mon Feb 06 16:06:58 2017 -0800" }, "message": "Force stack dump to diagnose empty checkpoint timeout (2).\n\nBug: 33006388\nBug: 12687968\nTest: test-art-host\nTest: Thread dumping in a simulated empty checkpoint timeout.\n\nChange-Id: I06641396b8f3d7a1a98366a01807aab2e6f31bd5\n" }, { "commit": "90b936ddda63139ff46a6755c3b83ad6e4ab4ac5", "tree": "c7ce2c3004eecc16ab41ed7cde105c3019638d4b", "parents": [ "b78a8af993e877d74c5938f65f95feaf2fa01321" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jan 31 08:58:55 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Feb 03 10:03:52 2017 -0800" }, "message": "ART: Refactor verify_object.h\n\nMove the actual VerifyObject check into a new cc file, as we\ncommonly don\u0027t enable the check at all. This allows to cut the\n-inl include from almost all current users.\n\nThis also exposes missing -inl includes. Also fix up some of our old\nmess where .h defined functions require -inl.h defined functions.\n\nTest: m\n\nChange-Id: I3dd821bbe2015564a29bf1ed9be00f7a7276ad61\n" }, { "commit": "1ebe4fe1a6cb0835197ee3a848d554b79ca9d367", "tree": "69e01b73d1b5eccc37cf19a1daea89052de06a94", "parents": [ "44790fe8b33c7a80da2e77787d5f8d4d4549114b" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Jan 30 14:57:11 2017 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Feb 01 15:39:49 2017 -0800" }, "message": "Fix creating self-recursive obsolete methods.\n\nWe were using recursive loading of the current art method which was\nmaking us miss obsolete methods in some cases.\n\nWe could also end up checking the wrong method when walking the stack.\n\nWe also add tests for recursive obsolete methods in general.\n\nBug: 34815470\n\nTest: mma -j40 test-art-host\nTest: ART_TEST_JIT\u003dtrue mma -j40 test-art-host\nChange-Id: I522fd4cac4e3f9d35d03b128bad6d6971cfe6c4a\n" }, { "commit": "dba61481035b7944173181ec9ee02aea41dd0e29", "tree": "8629775e657cc8968e2f8fa2af6256c7a58c7dd4", "parents": [ "cb2ce333ee2d1053919fe0acc390369bea3ad77e" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Dec 21 08:20:29 2016 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Dec 21 11:43:14 2016 -0800" }, "message": "Revert \"Revert \"Revert \"Revert \"Basic obsolete methods support\"\"\"\"\n\nA GetDeclaringClass()-\u003eGetDexCache() got inserted during the\nmerge/review process meaning that we would try to access incorrect\ndex-cache in obsolete methods in some situations.\n\nAlso when using tracing we would loop forever (or at least until an\nOOM error) in test 916 due to tracing forcing InterpretOnly mode\nmeaning methods would never be jitted.\n\nBug: 32369913\nBug: 33630159\n\nTest: ART_TEST_TRACE\u003dtrue \\\n ART_TEST_JIT\u003dtrue \\\n ART_TEST_INTERPRETER\u003dtrue mma -j40 test-art-host\n\nThis reverts commit f6abcda293b115a9d7d8a26376ea2dcf2d1dc510.\n\nChange-Id: I0773bfcba52e3cd51a83be815c6a50c189558f48\n" }, { "commit": "f6abcda293b115a9d7d8a26376ea2dcf2d1dc510", "tree": "a30ce596848d14c95a73449dbf2bfccf26a510b9", "parents": [ "ce77fc0e7f60a15354bb20c356537cbf8b53b722" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 21 09:26:18 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Dec 21 09:26:18 2016 +0000" }, "message": "Revert \"Revert \"Revert \"Basic obsolete methods support\"\"\"\n\nFails in tracing mode\n\nBug: 32369913\nBug: 33630159\n\nThis reverts commit ce77fc0e7f60a15354bb20c356537cbf8b53b722.\n\nChange-Id: I1bdcf6ad467f2e31f9c5d0c3c987b90a4f5efc69\n" }, { "commit": "ce77fc0e7f60a15354bb20c356537cbf8b53b722", "tree": "b4301967c423ab190a4274409d99a3d6e23f0e8a", "parents": [ "d54f43ca39dfa92f08c2d760123f185f0f65fb86" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Dec 15 01:05:52 2016 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Dec 19 14:26:18 2016 -0800" }, "message": "Revert \"Revert \"Basic obsolete methods support\"\"\n\nThis reverts commit b81a9840b44480bfeacd74b8d9f51e06f295411d.\n\nThere were 2 issues with the original CL\u0027s test 916-obsolete-jit that\ncaused it to sporadically fail.\n\nFirst, when checking if we had jitted the function under test in\n916-obsolete-jit we failed to check to see if the function \u0027doCall\u0027,\nwhich is used to work-around bugs in our deoptimization \u0026 compilation\nsystems, had also been jitted.\n\nIn the case where the \u0027sayHi\u0027 function had been jitted but the\n\u0027doCall\u0027 function had not we would (correctly) fail to redefine the\n\u0027Transform\u0027 class since we would not be able to deoptimize the \u0027sayHi\u0027\nfunction since it is under a quick_to_interpreter_bridge (runtime)\nframe.\n\nSecondly, the function Main.isInterpretedFunction was incorrect and\nwould always return false, regardless of the actual state of the\nfunction. This would cause the test to fail as the\nquick_to_interpreter_bridge frame prevented deoptimization of the\nobsoleted function. Usually the warm-up period was enough to make sure\nthe methods were jitted anyway but this was not guaranteed.\n\nBoth of these problems become more likely to occur on systems with\nmore cpu contention such as the buildbots.\n\nTest: stress --cpu 60 \u0026; while ./test/run-test --host --jit 916; do ; done\n\nReason for revert: Fixed bug in test that was causing failures.\n\nOriginal Tests:\n\nTest: ./test/run-test --host 914\nTest: ./test/run-test --host 915\nTest: ./test/run-test --host 916\nTest: mma -j40 test-art-host\nTest: ART_TEST_JIT\u003dtrue \\\n ART_TEST_INTERPRETER\u003dtrue mma -j40 test-art-host\nTest: ./art/tools/run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64\nTest: ./art/tools/run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64 --no-jit\n\nBug: 32369913\nBug: 33630159\n\nChange-Id: If1a92e47b90965a7dc21c5826185debe62bd1554\n" }, { "commit": "46ee31b67d7ee1bd085fbc240502053caa3cf8fa", "tree": "83e870f293cd60d533207e389d7b094acd87b31f", "parents": [ "9538f9e2a5d03f1b1bc07ebfbd93b61dcf8ad604" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 14 10:11:49 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 15 09:50:39 2016 -0800" }, "message": "ART: Move to libbase StringPrintf\n\nRemove ART\u0027s StringPrintf implementation. Fix up clients. Add\nmissing includes where necessary.\n\nTest: m test-art-host\nChange-Id: I564038d5868595ac3bb88d641af1000cea940e5a\n" }, { "commit": "b81a9840b44480bfeacd74b8d9f51e06f295411d", "tree": "d79a3567b272b6eb4fb94d66a537cf92bef455db", "parents": [ "d8936da27b792d1ca02e59c92456a1a53c7b9905" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Dec 15 00:59:05 2016 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Dec 15 00:59:05 2016 +0000" }, "message": "Revert \"Basic obsolete methods support\"\n\nThis reverts commit d8936da27b792d1ca02e59c92456a1a53c7b9905.\n\nReason for revert: Some sort of race in JIT\n\nChange-Id: Ibb4e520bb0721d6d7aa2c841a52eb5baff07740e\n" }, { "commit": "d8936da27b792d1ca02e59c92456a1a53c7b9905", "tree": "6a593dd426e7f4a15c651dd3b872f22fb64f09ce", "parents": [ "7c73bf3518eea7544406eadfed6946411c54a267" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Nov 28 16:24:32 2016 -0800" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Dec 14 13:01:27 2016 -0800" }, "message": "Basic obsolete methods support\n\nAdd support for executing obsolete methods following redefinitions.\nThis support includes methods that have been jitted. This does not add\nany additional validity checks to our redefinition functions.\n\nNote using work-arounds to ensure 916 works pending some fixes to the\ncompiler, deoptimizer, or both.\n\nTest: ./test/run-test --host 914\nTest: ./test/run-test --host 915\nTest: ./test/run-test --host 916\nTest: mma -j40 test-art-host\nTest: ART_TEST_JIT\u003dtrue \\\n ART_TEST_INTERPRETER\u003dtrue mma -j40 test-art-host\nTest: ./art/tools/run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64\nTest: ./art/tools/run-jdwp-tests.sh --mode\u003dhost --variant\u003dX64 --no-jit\n\nBug: 32369913\nBug: 33630159\n\nChange-Id: I78ef95f484146f1fb93c37fc50f56575bdab2432\n" }, { "commit": "585da955bc8e5040705dcfd941b2131025ebcef8", "tree": "d22555ab3b33b446271fcbbd1676177d21d7221f", "parents": [ "ce29d1813914ee9a9e9b04b034968f09694dd557" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 02 14:52:29 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Dec 12 11:47:02 2016 -0800" }, "message": "ART: Add precise root visiting\n\nAdd VisitRootFlags::kVisitRootFlagPrecise to signal a\nrequest for precise RootInfo objects.\n\nMove VisitRootFlags to gc_root.h. Refactor VisitRoot\nfunctions to pass flags. Add code in Thread visiting\nto decode vregs in compiled code.\n\nBug: 31385354\nTest: m test-art-host\nChange-Id: I8e7280f0ab682871f729f2a1c6b18670cf2dbf82\n" }, { "commit": "063fc772b5b8aed7d769cd7cccb6ddc7619326ee", "tree": "bc165781989087a998721991504e589a7d5b0926", "parents": [ "48d08a4233ee4450b0d5073d41445f9dd1f17191" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Tue Aug 02 11:02:54 2016 -0700" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Thu Dec 01 11:15:47 2016 -0800" }, "message": "Class Hierarchy Analysis (CHA)\n\nThe class linker now tracks whether a method has a single implementation\nand if so, the JIT compiler will try to devirtualize a virtual call for\nthe method into a direct call. If the single-implementation assumption\nis violated due to additional class linking, compiled code that makes the\nassumption is invalidated. Deoptimization is triggered for compiled code\nlive on stack. Instead of patching return pc\u0027s on stack, a CHA guard is\nadded which checks a hidden should_deoptimize flag for deoptimization.\nThis approach limits the number of deoptimization points.\n\nThis CL does not devirtualize abstract/interface method invocation.\n\nSlides on CHA:\nhttps://docs.google.com/a/google.com/presentation/d/1Ax6cabP1vM44aLOaJU3B26n5fTE9w5YU-1CRevIDsBc/edit?usp\u003dsharing\n\nChange-Id: I18bf716a601b6413b46312e925a6ad9e4008efa4\nTest: ART_TEST_JIT\u003dtrue m test-art-host/target-run-test test-art-host-gtest\n" }, { "commit": "709b070044354d9f47641f273edacaeeb0240ab7", "tree": "3a8ac051d7c35076303984d0d892cdd396b60427", "parents": [ "1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 13 09:12:37 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Oct 18 14:10:04 2016 -0700" }, "message": "Remove mirror:: and ArtMethod deps in utils.{h,cc}\n\nThe latest chapter in the ongoing saga of attempting to dump a DEX\nfile without having to start a whole runtime instance. This episode\nfinds us removing references to ArtMethod/ArtField/mirror.\n\nOne aspect of this change that I would like to call out specfically\nis that the utils versions of the \"Pretty*\" functions all were written\nto accept nullptr as an argument. I have split these functions up as\nfollows:\n1) an instance method, such as PrettyClass that obviously requires\nthis !\u003d nullptr.\n2) a static method, that behaves the same way as the util method, but\ncalls the instance method if p !\u003d nullptr.\nThis requires using a full class qualifier for the static methods,\nwhich isn\u0027t exactly beautiful. I have tried to remove as many cases\nas possible where it was clear p !\u003d nullptr.\n\nBug: 22322814\nTest: test-art-host\nChange-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24\n" }, { "commit": "986660c7175b3a99268a7bc38f283a2b1161781b", "tree": "f0ac68f80d63045c47d2f4dbf227a3f548747391", "parents": [ "e22a8cb3767bd59605a4ca5e9e53d4fe5081a48c" ], "author": { "name": "Goran Jakovljevic", "email": "Goran.Jakovljevic@imgtec.com", "time": "Thu Dec 10 11:44:50 2015 +0100" }, "committer": { "name": "Goran Jakovljevic", "email": "Goran.Jakovljevic@imgtec.com", "time": "Fri Sep 09 12:54:36 2016 +0200" }, "message": "MIPS32: Properly handle doubles in GetRegisterIfAccessible\n\nThere was a problem with floating point registers and exception\nhandler. In optimizing compiler fpu registers are treated as 64-bit.\nThis is problematic since logic in GetRegisterIfAccessible doesn\u0027t\nsupport 64-bit floating point registers.\n\nThis fixes tests:\n 510-checker-try-catch\n 534-checker-bce-deoptimization\n\nTest: mma test-art-target on CI20 (mips32r2) and emulator (mips32r6)\n\nChange-Id: I0f49c1c30f97077b82ad08fcc3cdb86a4877af23\n" }, { "commit": "239d6eaff0cbb5c4c0139f7053a012758799f186", "tree": "8de26b30a2dfd94f849a38c8901437facbbc53b3", "parents": [ "9d185da3bef8caf015d3dbf4ad79c520af7ce3b1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 05 10:44:04 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Sep 06 17:37:41 2016 +0100" }, "message": "Change deoptimize entrypoint to save everything.\n\nAnd implement FPU register retrieval from stack on x86.\n\nOn Nexus 9, AOSP ToT, the boot.oat size reduction is\n prebuilt multi-part boot image:\n - 32-bit boot.oat: -20KiB (-0.03%)\n - 64-bit boot.oat: -45KiB (-0.06%)\n on-device built single boot image:\n - 32-bit boot.oat: -24KiB (-0.04%)\n - 64-bit boot.oat: -36KiB (-0.05%)\n\nTest: Run ART test suite on host and Nexus 9.\nBug: 30212852\nChange-Id: I5d98e2a24363136d73dfec6100ab02f8eb101911\n" }, { "commit": "bdf7f1c3ab65ccb70f62db5ab31dba060632d458", "tree": "25cc77adfeb05232d0ab00aa561a693f1d71745c", "parents": [ "d7eabc2cc1a88c1f7f927da61246ae65aab0626c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 16:38:47 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 17:02:53 2016 -0700" }, "message": "ART: SHARED_REQUIRES to REQUIRES_SHARED\n\nThis coincides with the actual attribute name and upstream usage.\nPreparation for deferring to libbase.\n\nTest: m\nTest: m test-art-host\nChange-Id: Ia8986b5dfd926ba772bf00b0a35eaf83596d8518\n" }, { "commit": "fd36f1f927c138575184a1f4c7ea4e7abb3e2dbf", "tree": "2debb35c9193ac019071e0625986698ccbcaabb8", "parents": [ "c218427ab96e521e0c4e9a3ffeb87e6c57eea0a5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Aug 03 18:49:58 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Aug 10 14:19:49 2016 +0100" }, "message": "Rename callee save enumerators.\n\nAnd related image method enumerators, macros, etc.\nClean up some entrypoint assembly comments.\n\nThis is a follow-up to\n https://android-review.googlesource.com/252348\n\nTest: Run ART test suite on host and Nexus 9.\nBug: 30212852\nChange-Id: I2707342d4255c88c547655be83ed97a67e12ae9e\n" }, { "commit": "542451cc546779f5c67840e105c51205a1b0a8fd", "tree": "11e09bb5abaee12dddffefbe7e425291076dfa7a", "parents": [ "85c4a4b8c9eabfe16e4e49f9b4aa78c1bf4be023" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jul 26 09:02:02 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 01 18:54:48 2016 -0700" }, "message": "ART: Convert pointer size to enum\n\nMove away from size_t to dedicated enum (class).\n\nBug: 30373134\nBug: 30419309\nTest: m test-art-host\nChange-Id: Id453c330f1065012e7d4f9fc24ac477cc9bb9269\n" }, { "commit": "c6df1e3cbfa7313007ee5fd4a5a6657a28627313", "tree": "13042081c7e5a784a90422c759e9b73e5cc9b013", "parents": [ "19c10147cd5f3270c8604d06c4a0e05cbc49e2f1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jul 04 10:15:47 2016 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jul 04 16:40:51 2016 +0100" }, "message": "Never go to resolution while inspecting inlined frames.\n\nInstead, do a manual inspection and decoding of the invoke\nwith the dex cache.\n\nAlso update oatdump to dump types in the dex cache.\n\nbug:27858645\nChange-Id: I7c0b612ee96e6865fa438c3a1d253686231337bd\ntest:run-test\n" }, { "commit": "56fdd0e63812764bbeb8cc52e376d3fd1f270052", "tree": "6988e995bf02f788066fb6e748cd3049fe87d31a", "parents": [ "9d05b59a8595cf7eeece1795eb65b6b8706aad45" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Apr 28 14:56:54 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 29 17:33:22 2016 -0700" }, "message": "ART: Disambiguate access-checks mode from lock-counting\n\nLock-counting (when structural locking verification failed) is a\nspecial sub-mode of access-checks and must be disambiguated, because\nwe currently use access-checks mode class-wide when at least one\nmethod soft-fails, but do not stop the compiler/JIT to compile\nthe \"working\" methods. So we may end up in the access-checks\ninterpreter for a working method through deopt without knowing\nwhich locks are already held.\n\nBug: 28351535\n\n(cherry picked from commit f517e283d477dd2ae229ee3f054120c6953895db)\n\nChange-Id: I083032f064d88df8f8f0611ad8b57d1b39cd09fb\n" }, { "commit": "ffc87076dda9878cb2cc098149bae441d38b9268", "tree": "e587208d6a8e62532792add3e1ace6b4e6d73e0f", "parents": [ "97cbc9206e9adc473a90650ebdb5d620f517ff04" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed Apr 20 14:22:09 2016 +0100" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Thu Apr 28 16:15:04 2016 +0100" }, "message": "Split profile recording from jit compilation\n\nWe still use ProfileInfo objects to record profile information. That\ngives us the flexibility to add the inline caches in the future and the\nconvenience of the already implemented GC.\n\nIf UseJIT is false and SaveProfilingInfo true, we will only record the\nProfileInfo and never launch compilation tasks.\n\nBug: 27916886\n\n(cherry picked from commit e5de54cfab5f14ba0b8ff25d8d60901c7021943f)\n\nChange-Id: I68afc181d71447895fb12346c1806e99bcab1de2\n" }, { "commit": "e42888f9df4163303244070c65d5229d3e201742", "tree": "c3c3e380ed16676186040f1da6042fc2cd58e041", "parents": [ "7f98c9a6babe3a21d84ce1f1e1273c99975a47f5" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 14 10:49:19 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 27 12:45:30 2016 -0700" }, "message": "Write conflict tables in image\n\nAdd image sections for runtime methods and conflict tables. This\nmakes it that we do not need to fake up a length prefixed array\nfor runtime methods.\n\nReduces .art private dirty and PSS.\n\nSystem wide .art PSS goes from 32.5MB to 30.5MB after system boot.\n\nBusiness card .art private dirty goes from 588K to 504K.\n\nIncreases image size by ~100K.\n\nBug: 27906566\n\n(cherry picked from commit cda9386add68d94697449c6cb08b356747e55c21)\n\nChange-Id: I38cbe3150c3eeb385b8cad7cf93614e3980f4162\n" }, { "commit": "9d07e3d128ccfa0ef7670feadd424a825e447d1d", "tree": "dfb677fd75f0f297fef9bc49311cf1d22c770f56", "parents": [ "eb98c0ded592cfca8187c744393c82efd1020b2a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 31 12:02:28 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Apr 04 17:50:20 2016 +0100" }, "message": "Clean up OatQuickMethodHeader after Quick removal.\n\nThis reduces the size of the pre-header by 8 bytes, reducing\noat file size and mmapped .text section size. The memory\nneeded to store a CompiledMethod by dex2oat is also reduced,\nfor 32-bit dex2oat by 8B and for 64-bit dex2oat by 16B. The\naosp_flounder-userdebug 32-bit and 64-bit boot.oat are each\nabout 1.1MiB smaller.\n\nDisable the broken StubTest.IMT, b/27991555 .\n\nChange-Id: I05fe45c28c8ffb7a0fa8b1117b969786748b1039\n" }, { "commit": "61b28a17d9b6e8e998103646e98e4a9772e11927", "tree": "438c4a73f72423ddc71e6dca9f082d9e1d533996", "parents": [ "cf0f8560f41467331427418584687830932e66ed" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 25 21:55:03 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Apr 01 17:01:55 2016 +0100" }, "message": "Use bit-level packing for InlineInfo in stackmaps as well.\n\nUse the same approach as we do for stackmaps to reduce the size.\n\nIt saves 4.0 MB from non-debuggable boot.oat (AOSP).\nIt does not affect debuggable boot.oat.\n\nIt saves 3.6 MB (of 96.6 MB) from /system/framework/arm/ (GOOG).\nIt saves 0.6 MB (of 26.7 MB) from /system/framework/oat/arm/ (GOOG).\n\nField loads from inline-info get around 5% slower.\n(based on the time it takes to load all inline-infos from boot.oat)\n\nChange-Id: I67b0fa5eef74c1fdb013680d0231fd44ea696176\n" }, { "commit": "fe2b13717879abae993603534a145372e3110aae", "tree": "5b499eb28af5e91e00ff86683f51df029a2b86b4", "parents": [ "5c26e430fbeaf56e3a5da4e3f167ff35fbb71ef9", "09ed09866da6d8c7448ef297c148bfa577a247c2" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Fri Apr 01 12:28:51 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Apr 01 12:28:51 2016 +0000" }, "message": "Merge \"Pack stack map entries on bit level to save space.\"" }, { "commit": "45bf250d61de433c18ded824348e87bd4ffd7678", "tree": "1b79913ff99218dcfe1fc124d05ec403c871418f", "parents": [ "68724122b444e531d65413b1d9039f6e5fca52b3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 31 11:07:09 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 31 14:51:09 2016 -0700" }, "message": "Add way to disable resolving for stack walk\n\nOnly occurs for walking the inlined frames case.\n\nBug: 27857910\n\n(cherry picked from commit be2892bf771435eb451c74297b553f7dc9fea4ca)\n\nChange-Id: Ied92be96f2f74ba02c02168f704443b95e7a4b04\n" }, { "commit": "09ed09866da6d8c7448ef297c148bfa577a247c2", "tree": "dad6a5dae6ca6131f1eba201eaa371edc6d9929d", "parents": [ "e28ad4b91591c226ed404a2b01104bb99bfeb28f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Feb 12 21:58:43 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Mar 31 22:12:07 2016 +0100" }, "message": "Pack stack map entries on bit level to save space.\n\nUse only the minimum number of bits required to store stack map data.\nFor example, if native_pc needs 5 bits and dex_pc needs 3 bits, they\nwill share the first byte of the stack map entry.\n\nThe header is changed to store bit offsets of the fields rather than\nbyte sizes. Offsets also make it easier to access later fields without\ncalculating sum of all previous sizes.\n\nAll of the header fields are byte sized or encoded as ULEB128 instead\nof the previous fixed size encoding. This shrinks it by about half.\n\nIt saves 3.6 MB from non-debuggable boot.oat (AOSP).\nIt saves 3.1 MB from debuggable boot.oat (AOSP).\n\nIt saves 2.8 MB (of 99.4 MB) from /system/framework/arm/ (GOOG).\nIt saves 1.0 MB (of 27.8 MB) from /system/framework/oat/arm/ (GOOG).\n\nField loads from stackmaps seem to get around 10% faster.\n(based on the time it takes to load all stackmap entries from boot.oat)\n\nBug: 27640410\nChange-Id: I8bf0996b4eb24300c1b0dfc6e9d99fe85d04a1b7\n" }, { "commit": "5b83050affa6a3b1d3863c0b903f9d48fe4aefb2", "tree": "6ffce3adefced9b6ab9f019327e542e0535e225e", "parents": [ "a71ec6419d9e80b354de721003c8b7929d224a49" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Mar 02 10:30:23 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Mar 02 10:47:20 2016 -0800" }, "message": "Fix potential linear alloc memory leak\n\nPreviously, if we created a linear alloc for a class loader but\nnever created the class table, the linear alloc would never get\nfreed since it would have no corresponding ClassLoaderData.\n\nFixes valgrind-test-art-host-gtest-oat_test\n\nBug: 27384882\nChange-Id: Ic8f35b58c3117127a39521b6b9d25ef12c72040c\n" }, { "commit": "7dc11782ff0a5dffcd8108f256f8975f0b3e8076", "tree": "c3f6463fb378775d9b348f8fcfccfcdb410cfcc2", "parents": [ "99da8cd8818e015b21d1c2af73ac40749698c930" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 25 13:23:56 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Feb 25 14:07:27 2016 +0000" }, "message": "Implement \u003c\u003c operator for DexRegisterLocation::Kind.\n\nThis makes it comparable in DCHECK_EQ and similar methods.\n\nChange-Id: I6b5b237be89325850ae6860d011fd6741189ab01\n" }, { "commit": "8405bfda04edd21156d4f8b88684f5c2ecbe8544", "tree": "07b8aae314aaecbe7bea64844ad051d1df6d3733", "parents": [ "0adb678252bacf861dbaca0d9b5edf1a32ac7cd9" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 05 12:00:49 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 05 12:01:59 2016 -0800" }, "message": "Disable kDebugStackWalk\n\nSomeone left it enabled.\n\nBug: 27039049\n\nChange-Id: I2bec610a3f20e1214dc34b4e06227609da2a2ab8\n" }, { "commit": "b331febbab8e916680faba722cc84b66b84218a3", "tree": "35f985b021e476914bfe91492da23fee218014a7", "parents": [ "586996afc905518ed926e4680aab67bedabec9b7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 16:51:53 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 17:11:54 2016 +0000" }, "message": "Revert \"Revert \"Implement on-stack replacement for arm/arm64/x86/x86_64.\"\"\n\nThis reverts commit bd89a5c556324062b7d841843b039392e84cfaf4.\n\nChange-Id: I08d190431520baa7fcec8fbdb444519f25ac8d44\n" }, { "commit": "012fc4e9d9b66b3ffb7838b0e29dadbb4863ee69", "tree": "abba308e56a3d81e5c3fceebc95fb37a0ffe9c7c", "parents": [ "5ee288c9dd99614e3a238f5efceeec6456e3499d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 08 15:58:19 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 08 17:14:17 2016 +0000" }, "message": "Don\u0027t encode a DexRegisterMap if there is no live register.\n\nChange-Id: I76a291e6a0ac37f0590d16c7f5b866115588bc55\n" }, { "commit": "3a0909248e04b22c3981cbf617bc2502ed5b6380", "tree": "b0b7013ea78b10f23fae75ef145e53a696ff797c", "parents": [ "457e874459ae638145cab6d572e34d48480e39d2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "message": "Revert \"lambda: Add support for invoke-interface for boxed innate lambdas\"\n\n955-lambda is flaky\n\nBug: 24618608\nBug: 25107649\n\nThis reverts commit 457e874459ae638145cab6d572e34d48480e39d2.\n\nChange-Id: I24884344d21d7a4262e53e3f5dba57032687ddb7\n" }, { "commit": "457e874459ae638145cab6d572e34d48480e39d2", "tree": "b192c4698c4889ae90db6abe2652199802213fe6", "parents": [ "3944f7175dcf60316ba58a42698ccf23c65ac57c" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Oct 22 17:37:50 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Nov 20 16:33:06 2015 -0800" }, "message": "lambda: Add support for invoke-interface for boxed innate lambdas\n\nLambda closures created with the \u0027create-lambda\u0027 instruction\n(termed \"innate lambdas\") can be turned into an object with \u0027box-lambda\u0027.\n\nThis CL enables support for those kinds of lambdas to work with\n\u0027invoke-interface\u0027 by generating a proxy class for the lambda.\n\nNote: MIPS32/64 support not included.\n\nBug: 24618608\nBug: 25107649\nChange-Id: Ic8f1bb66ebeaed4097e758a50becf1cff6ccaefb\n" }, { "commit": "a7a3ba792d608535e4d53ccc3b7a89d110609f12", "tree": "2c9910ecd7ea709ed02f65878b3ada9b06e97be1", "parents": [ "3e1ff83fb210818df66b7a0a7bc70dca6c7b9d47", "636b9252af8d8848dbf8f30b7e9638867b62c791" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Nov 18 10:29:22 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Nov 18 10:29:22 2015 +0000" }, "message": "Merge \"Support deoptimization only to set vreg\"" }, { "commit": "3e1ff83fb210818df66b7a0a7bc70dca6c7b9d47", "tree": "ae736f4da42bd2d44514dffdffdc6bd3e6d32721", "parents": [ "cb6638ff664e3136ccfee3cffb9307e0d43ffbc1", "09687447764a4d5d810df3d02532e4b141e7f2cd" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Nov 18 10:17:46 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Nov 18 10:17:46 2015 +0000" }, "message": "Merge \"Fix StackVisitor::GetVReg for reference in shadow frame\"" }, { "commit": "636b9252af8d8848dbf8f30b7e9638867b62c791", "tree": "ef2d3080fab4c51e320114e012bcde49aaa089e4", "parents": [ "6bf6e438cd4746effce0b26d504c54100191c988" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Fri Jul 31 16:40:24 2015 -0700" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Nov 17 11:57:12 2015 +0100" }, "message": "Support deoptimization only to set vreg\n\nThis CL removes the old API that was used to update vreg. We now rely\nexclusively on deoptimization to change the value of a vreg (mainly\nfrom the debugger). This allows to have only one mechanism working\nwith both Quick and Optimizing compilers. It also remove run-test\n455-set-vreg which was the only user of the old API.\n\nThis CL also renames StackVisitor::SetVReg[Pair]FromDebugger to\nStackVisitor::SetVReg[Pair] to reflect that change.\n\nBug: 25428216\nChange-Id: Ib09510185280dbd0f6d02c52549ae9671c187e32\n" }, { "commit": "09687447764a4d5d810df3d02532e4b141e7f2cd", "tree": "4bd0305123a148911e15ca13fbaeb5380356de60", "parents": [ "55a77ef5f99c2b056eb5f2820c1ff3b29c0ec270" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Nov 17 10:35:39 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Nov 17 11:04:45 2015 +0100" }, "message": "Fix StackVisitor::GetVReg for reference in shadow frame\n\nAlso fixes 457-regs run-test that used to pass an incorrect\nvreg kind.\n\nBug: 25428216\nChange-Id: Ic31b51ca0f72350db6325f23087b06e93055d750\n" }, { "commit": "0d5a281c671444bfa75d63caf1427a8c0e6e1177", "tree": "fd9bbe0f1c581bcc7c05bbfb2643ffe0b1fb014e", "parents": [ "dd4cbcc924c8ba2a578914a4a366996693bdcd74" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Nov 13 10:07:31 2015 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Sun Nov 15 12:16:41 2015 +0000" }, "message": "x86/x86-64 read barrier support for concurrent GC in Optimizing.\n\nThis first implementation uses slow paths to instrument heap\nreference loads and GC root loads for the concurrent copying\ncollector, respectively calling the artReadBarrierSlow and\nartReadBarrierForRootSlow (new) runtime entry points.\n\nNotes:\n- This implementation does not instrument HInvokeVirtual\n nor HInvokeInterface instructions (for class reference\n loads), as the corresponding read barriers are not stricly\n required with the current concurrent copying collector.\n- Intrinsics which may eventually call (on slow path) are\n disabled when read barriers are enabled, as the current\n slow path infrastructure does not support this case.\n- When read barriers are enabled, the code generated for a\n HArraySet instruction always go into the array set slow\n path for object arrays (delegating the operation to the\n runtime), as we are lacking a mechanism to keep a\n temporary register live accross a runtime call (needed for\n the instrumentation of type checking code, which requires\n two successive read barriers).\n\nBug: 12687968\nChange-Id: I14cd6107233c326389120336f93955b28ffbb329\n" }, { "commit": "22cf3d361695ff1d585a8a412ebeade69749811f", "tree": "bff30bc41f6f85d0758934a9eeeb3511c2a0fc44", "parents": [ "43c6d31c43c05d97511bb9658964fd3d2f32b915" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 02 11:57:11 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 02 15:21:41 2015 +0000" }, "message": "Fix tests flakiness with jit when using Proxy classes.\n\nWe cannot copy the entry point between ArtMethod when\nthe entry point has been JITted. We put the interpreter\nbridge instead.\n\nbug:25334878\n\nChange-Id: I65a50cc1f10a5a152733807f8c85fb3ed81c5829\n" }, { "commit": "1dad3f68b7f5a4a4cb2b281413357adc2309a8fd", "tree": "df482d1f65e55a9a228c925e96532942fb25eb47", "parents": [ "fe97bfeabcf99d470e7d974a68ec6b6641648396" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Oct 23 14:59:54 2015 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Oct 26 19:10:55 2015 +0000" }, "message": "Support garbage collection of JITted code.\n\nChange-Id: I9afc544460ae4fb31149644b6196ac7f5182c784\n" }, { "commit": "524e7ea8cd17bad17bd9f3e0ccbb19ad0d4d9c02", "tree": "ad07cc96f633bdae839ff2f1553d84b9c864a930", "parents": [ "b697c447eb61c2e14315166ec3b0d16375ae403c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Oct 16 17:13:34 2015 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Oct 20 11:52:11 2015 +0100" }, "message": "Remove ArtCode.\n\n- Instead use OatQuickMethodHeader.\n- Various cleanups now that we don\u0027t have all those\n ArtMethod -\u003e ArtCode -\u003e OatQuickMethodHeader indirections.\n\nAs a consequence of this cleanup, exception handling got a bit\nfaster.\n\nParserCombinators benchmark (exception intensive) on x64: (lower is better)\nBefore:\nParserCombinators(RunTime): 1062500.0 us.\nAfter:\nParserCombinators(RunTime): 833000.0 us.\n\nChange-Id: Idac917b6f1b0dc254ad68fb3781cd61bccadb0f3\n" }, { "commit": "46bf13350316475ce4b787e9cbd8774e87d3dde6", "tree": "796b9bea3ee6549b70acec3fccf176ddd843edfc", "parents": [ "7edef7441d28db1403fbc5641b56a26ecf355879", "6bc4374e3fa00e3ee5e832e1761c43e0b8a71558" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Oct 13 12:33:02 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Oct 13 12:33:02 2015 +0000" }, "message": "Merge \"Add an abstraction over a compiled code.\"" }, { "commit": "6bc4374e3fa00e3ee5e832e1761c43e0b8a71558", "tree": "38118523aa6b9a92fbdcd7bf1d32ca6185a3d3f0", "parents": [ "16065ce56394c73c87dcb78ead4164ddc80fddb3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Oct 12 18:11:10 2015 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Oct 13 12:05:27 2015 +0100" }, "message": "Add an abstraction over a compiled code.\n\nThat\u0027s just step 1, moving code-related functions of ArtMethod to\nanother class. That class is only a wrapper on an ArtMethod, but will\nbe changed to be a wrapper around compiled code.\n\nChange-Id: I6f35fc06d37220558dff61691e51ae20066b0dd6\n" }, { "commit": "7edef7441d28db1403fbc5641b56a26ecf355879", "tree": "8dd65db0eb70e7a0524a3ea0a326db3c7e52f586", "parents": [ "c1b4a1efcfb249651bc9ae34c9285a693ede2550", "b2feaafd89813af69c65da95e0b51b1a4cecaf0b" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 13 09:58:38 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Oct 13 09:58:38 2015 +0000" }, "message": "Merge \"Revert \"Revert \"Fix instrumentation frame check with inlining\"\"\"" }, { "commit": "b2feaafd89813af69c65da95e0b51b1a4cecaf0b", "tree": "fafb1cc4b764aface48448f0ccd906ffdff0afdc", "parents": [ "34ce73a962379b7b844c605f1c4c80cf133009e3" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Oct 12 13:40:10 2015 +0000" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Oct 12 18:12:23 2015 +0200" }, "message": "Revert \"Revert \"Fix instrumentation frame check with inlining\"\"\n\nThis reverts commit e3e2fe5ecc16184ba91018adb3bfbec1c5880c29.\n\nFixes an incorrect CHECK_GT into CHECK_GE in method\nInstrumentation::ComputeFrameId.\n\nBug: 22519499\nChange-Id: I0a11d378f3baa728b9176ff086fe4b835b30bb46\n" }, { "commit": "e3e2fe5ecc16184ba91018adb3bfbec1c5880c29", "tree": "eebc82d0ab39506f48f2149e312fcd7065dab3f0", "parents": [ "3079e28b00accd19aa1153929fb00497d00956d9" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Oct 12 11:20:24 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Oct 12 11:20:24 2015 +0000" }, "message": "Revert \"Fix instrumentation frame check with inlining\"\n\nTimes out on some run-tests.\n\nBug: 22519499\n\nThis reverts commit 3079e28b00accd19aa1153929fb00497d00956d9.\n\nChange-Id: I4c612a5af20e4481eb9865f90abd429f4a40ce57\n" }, { "commit": "03ec930faded5bbfa096533ce60b6893847922db", "tree": "085ec76235f72647cd2e083801f15d82394e038b", "parents": [ "14412079e6eba4d16f40c0bdc5e94812e1c7f5bc" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 27 17:41:47 2015 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 09 16:32:13 2015 -0700" }, "message": "ART: Lock counting in the interpreter\n\nTo support structured locking when balanced-locking verification\nfailed, count lock and unlock operations in the verifier.\n\nBug: 23502994\nChange-Id: I2bb915da6e3d43c49723a943b42d4d5a7c939aa1\n" }, { "commit": "3079e28b00accd19aa1153929fb00497d00956d9", "tree": "73e5b45d3e242b9b6515ce7ecbb69e17993cfe07", "parents": [ "35ef974da353b13938fb0f3272c03070ad728431" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 06 15:28:44 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Oct 08 08:42:58 2015 +0200" }, "message": "Fix instrumentation frame check with inlining\n\nWhen instrumenting code compiled with inlining, we must compute\nframe IDs like instrumentation did for pushing instrumentation\nstack frames.\n\nBug: 22519499\nChange-Id: I4a72dbe9e4d2fd4985e49f8261b54c96df7c4a81\n" }, { "commit": "ccc61972ca31bbb3bf82cdc30656c13bebfbe6a9", "tree": "2d04de6996ec6273a36ac485f0297a3a2771152e", "parents": [ "6387821209a03c5d873cf9dc6fd11434918bbdf4" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Oct 01 14:34:20 2015 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Oct 02 09:58:48 2015 +0100" }, "message": "Do more inlining when JITting.\n\nWe now check the verification status of the class.\n\nThis triggered a bug when an inlined method was not compiled\n(typically in a JIT configuration), and the path for deopting in\nStackVisitor was using the wrong ArtMethod in order to know the\ncompiler that compiled the current frame.\n\nChange-Id: I81d3ca0cf5cd3864b83b63dd954c58e1f2adaad4\n" }, { "commit": "951ec2c93c79c5539cbcc669566f0808d4460338", "tree": "ce3505be2fc526afafaf6135e9d15d831860502d", "parents": [ "6a6916b378c413c2692782e901393607c47f0005" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 22 08:50:05 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 22 16:25:09 2015 +0000" }, "message": "Revert \"Revert \"Add one LinearAlloc per ClassLoader\"\"\n\nIssue was fixed by:\nhttps://android-review.googlesource.com/#/c/171945/\n\nBug: 22720414\n\nThis reverts commit 7de5dfe37f3cf24e1166412b589f6f67dcd1f1c0.\n" } ], "next": "7de5dfe37f3cf24e1166412b589f6f67dcd1f1c0" }