)]}' { "log": [ { "commit": "6ee497188b0e8c7bcf5126cefad04090f956616a", "tree": "db2d06b01d255811726ea748db8eb6f62cd7b71c", "parents": [ "642e9d8249be5aff68022cabdc8ba576a57ff8d6" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Mar 30 14:39:05 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Mar 30 14:39:05 2018 +0000" }, "message": "Revert^4 \"Add an option to disable native stack dumping on SIGQUIT.\"\n\nBug: 74121887\n\nStill failing :(\n\nThis reverts commit 642e9d8249be5aff68022cabdc8ba576a57ff8d6.\n\nChange-Id: I603ca9fdd2d8f2f759527130b3288efe5b23b5c3\n" }, { "commit": "642e9d8249be5aff68022cabdc8ba576a57ff8d6", "tree": "1fa53cee639241bd3968997e55e38ed282235569", "parents": [ "b939805d9d4b0957274c562fb8053512d04138b2" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Mar 27 20:30:55 2018 +0000" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Mar 27 22:36:09 2018 +0000" }, "message": "Revert \"Revert \"Revert \"Add an option to disable native stack dumping on SIGQUIT.\"\"\"\n\nThis reverts commit 74d25c9040dfd1e0985987eb38817e526878a3db.\n\nReason for revert: The original failing condition appears to be gone.\n\nBug: 74121887\n\nTest: Ran 004-ThreadStress many times against the target.\nChange-Id: Ie5bd050112e654a99bdfea7d6dd673882ca35567\n" }, { "commit": "74d25c9040dfd1e0985987eb38817e526878a3db", "tree": "e63323329298a7cc67799324a6edc2378cfb6822", "parents": [ "8b089742252e827d863218413e8855e1bae75af5" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 12 19:26:44 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 12 19:26:44 2018 +0000" }, "message": "Revert \"Revert \"Add an option to disable native stack dumping on SIGQUIT.\"\"\n\nBug: 27185632\nBug: 74121887\n\n\nGot flakes on device for 004-ThreadStress and 141-static-field-sigquit\n\nThis reverts commit 8b089742252e827d863218413e8855e1bae75af5.\n\nChange-Id: Ie76c84a1889e85b885d5f4123d60e8a760cf186d\n" }, { "commit": "8b089742252e827d863218413e8855e1bae75af5", "tree": "bbfe333fced26fbc42f87a4469c59822611acd9f", "parents": [ "f46f46cf5bd32788d5252b7107628a66594a5e98" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 05 11:47:30 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 05 13:43:15 2018 -0800" }, "message": "Revert \"Add an option to disable native stack dumping on SIGQUIT.\"\n\nThis reverts commit a73280df8cac1279b6dea0424722f42ef0048613.\n\nBug: 27185632\nBug: 74121887\nTest: m test-art-host\nChange-Id: I24af48619577a78371c93cbad24d307d4d7a217d\n" }, { "commit": "af290318c31180148bab64038d66a6059a1a89d5", "tree": "f5369e0be49f4599ada2a1d70cd564dbe5ba5ff5", "parents": [ "cc4e7b7c7b37d9f7bd6e2bfe22e36308150dddad" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 27 20:02:17 2018 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Feb 27 20:02:17 2018 +0000" }, "message": "Small documentation and stylistic changes.\n\nTest: art/test.py\nChange-Id: Ibc74ee4783314266bf1d027811715058626c57c8\n" }, { "commit": "2ffb703bf431d74326c88266b4ddaf225eb3c6ad", "tree": "0552c3c76a42b18f9e7460d501fb71a6dc2e7f33", "parents": [ "c4b6f3116f15c8e4fdf2e4f604ababdee12d8923" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Nov 08 13:35:21 2017 -0800" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Nov 08 15:15:52 2017 -0800" }, "message": "cpplint: Cleanup errors\n\nCleanup errors from upstream cpplint in preparation\nfor moving art\u0027s cpplint fork to upstream tip-of-tree cpplint.\n\nTest: cd art \u0026\u0026 mm\nBug: 68951293\nChange-Id: I15faed4594cbcb8399850f8bdee39d42c0c5b956\n" }, { "commit": "88fd720b6799184c8ad61e766a6d37af33ed30ef", "tree": "80e49456eafd44b0ad8790be456ae06949fcc506", "parents": [ "1cba8d219331e4d6994359e8f9104e5db2c8f8a9" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Jun 30 08:31:59 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jul 13 09:11:03 2017 -0700" }, "message": "Add Jvmti Suspend/ResumeThread functions\n\nEnable the can_suspend jvmti capability and implement all required\nfunctionality associated with it.\n\nTest: ./test.py --host -j40\nBug: 34415266\nBug: 62821960\nBug: 63579748\n\nChange-Id: I83b92de7f81622e1658114b034918e8295805b6e\n" }, { "commit": "46f9340f2a055a8fdfebbfbb739c697c20d83e7c", "tree": "acb172f74723e4ea9ac7ded73b94c661217ec90d", "parents": [ "fe9a4f061841a3c597aac6817a47c799c54fcad7" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jun 29 11:59:50 2017 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Fri Jun 30 14:24:56 2017 +0000" }, "message": "Add SuspendReason enum and change Suspension functions.\n\nMore self-documenting and more type safe.\n\nBug: 62821960\nTest: ./test.py\nChange-Id: Ic7a1ae6a25e687d65f5aa10c1aad54a7b80dd086\n" }, { "commit": "513061a792b22c417c938d31c19581390709561c", "tree": "80b4fdce03711170626aa5640d07b07de4a326a1", "parents": [ "38c4ae5f4c5a033b7a7441032f39ea58f5772d4c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 09:17:34 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 12:59:13 2017 -0700" }, "message": "ART: Clean up thread.h and thread_list.h\n\nRemove dependency on stack.h and gc_root.h. Remove unused object\ncallbacks include. Factor out ManagedStack into its own set of files.\nFix up users of transitive includes.\n\nTest: m test-art-host\nChange-Id: I01286c43d8c7710948c161b1348faabb05922e59\n" }, { "commit": "deae7db5864fa50c5a1cd6c232a17aeb986b36e1", "tree": "cdedad3d0f921e4f82fa7b65d55820455b7ac0ea", "parents": [ "8d01c3708c4becb186979ed9377aed0fc2954d06" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 30 09:56:41 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 30 14:15:50 2017 -0700" }, "message": "ART: Add missing namespace comments\n\nAdd closing namespace comments.\n\nBug: 32619234\nTest: m\nChange-Id: I1f50e09dcd1038c4b540b87e5c19e319c1f592e4\n" }, { "commit": "6e6444508de1afaeaf612970fad608b58b89b009", "tree": "ea42cbed1450be598869ef406bb1a6c31a7e4f77", "parents": [ "270970e660d3c99e62a88b18144d159dd8699c55" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 09 16:30:27 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed May 10 10:07:32 2017 -0700" }, "message": "ART: Make GC Pause Listener more precise\n\nRefactor code to call the listener in FlipThreadRoots, after all\nthreads have been suspended.\n\nBug: 37283268\nTest: m test-art-host\nChange-Id: I313db07e014e65a997d0b58c8a70e4505425def0\n" }, { "commit": "c4bed16daa6689eaa2148261b19662291417ced6", "tree": "56d03d48010091acb6f2551e1381097b6148d106", "parents": [ "7113885fcd983b33ee1e350865d21517d6297843" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon May 01 13:46:24 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue May 02 14:01:41 2017 -0700" }, "message": "ART: Change shutdown order\n\nAdd explicit Shutdown method to ThreadList, doing the work that\nwas previously in the destructor. Call sid method before unloading\nplugins and stopping the debugger.\n\nModulo daemon threads, this ensures that thread events will have\nquiesced when plugins stop.\n\nBug: 37763974\nTest: m test-art-host\nChange-Id: I11d22f2c89a68e9f6720d61967b8e5aea41188dc\n" }, { "commit": "a222404a5832ab16786931576d52825d08eed3ca", "tree": "7350e5efbb6ef72c33e82753d79f7f4bed92d9d4", "parents": [ "1561de49b382627ddd277b8ad7e5e8f4cec32f0b" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Feb 08 16:35:45 2017 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Feb 10 16:15:01 2017 -0800" }, "message": "Fix the empty checkpoint timeout.\n\nThe problem happens when a thread is indirectly blocked on a mutex\nthat another thread holds and is blocked on a weak ref access.\n\nAdd a way to do a dummy wakeup on a thread that\u0027s blocked on a mutex\nso that the thread will respond to the empty checkpoint request. Do\nthis for the mutexes that are expected to be held when a weak ref is\naccessed. Add a check that detects an unexpected case.\n\nBug: 33006388\nBug: 12687968\nTest: test-art-host.\nChange-Id: Iefec69b9a21aa25a928cb31fcf4fb872f867a8c2\n" }, { "commit": "3fceaf500d570722122f2d092f302d27769e3a51", "tree": "1c38d3a72559cb2f9454e445e3d5ddc7168170df", "parents": [ "388df9e0943fd4c858b99f268d9655336df17062" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Jan 22 13:33:40 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Jan 22 13:45:44 2017 -0800" }, "message": "Use higher default thread suspend timeout for run tests\n\nIncrease the default for tests from 10s-50s to 500s. This is done\nby adding a run-test option \"--suspend-timeout\" that defaults to\n500000.\n\nExample when passing a low value of 100:\ntest/run-test --host --suspend-timeout 100 --dev 004-ThreadStress\n\nResults in:\ndalvikvm32 F 01-22 13:33:31 12067 12118 thread_list.cc:669] Timed\nout waiting for threads to suspend, waited for 100.114ms\n\nThis should fix some of the recent test flakiness.\n\nTest: test-art-host\n\nChange-Id: I303c4f198e560e9f38ec375e9d7a80a5e61f776e\n" }, { "commit": "585da955bc8e5040705dcfd941b2131025ebcef8", "tree": "d22555ab3b33b446271fcbbd1676177d21d7221f", "parents": [ "ce29d1813914ee9a9e9b04b034968f09694dd557" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 02 14:52:29 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Dec 12 11:47:02 2016 -0800" }, "message": "ART: Add precise root visiting\n\nAdd VisitRootFlags::kVisitRootFlagPrecise to signal a\nrequest for precise RootInfo objects.\n\nMove VisitRootFlags to gc_root.h. Refactor VisitRoot\nfunctions to pass flags. Add code in Thread visiting\nto decode vregs in compiled code.\n\nBug: 31385354\nTest: m test-art-host\nChange-Id: I8e7280f0ab682871f729f2a1c6b18670cf2dbf82\n" }, { "commit": "a82769c1168d38fb4d36eaecfc186aecb17d4b16", "tree": "ae5056ff9a92f17b54e40f3410626198772b1612", "parents": [ "5eb1e1e7341f4e7febf77c04f8649a9566b31c03" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Dec 02 17:01:51 2016 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Dec 02 18:15:10 2016 -0800" }, "message": "Dump more debug info for b/33006388.\n\nBug: 33006388\nBug: 12687968\nTest: test-art-host with CC.\nChange-Id: Id9d67bc603c6ff7bc8e346e181e3e09ffbda43b3\n" }, { "commit": "3049324f4ef71b5d7a3de49bd77c75f07dbf8f3a", "tree": "19e2d9d5e8476bf526dd5924ef05b1d727b75f8b", "parents": [ "e7b46e22c7f4f6f503501b3b2ad99113289d142b" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Nov 03 13:06:52 2016 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Nov 09 18:14:08 2016 -0800" }, "message": "Make empty checkpoint work while weak ref access is disabled.\n\nFix a potential race on PushOntoMarkStack for CC by running an empty\ncheckpoint (while weak ref access is disabled).\n\nBug: 32508093\nBug: 12687968\nTest: test-art-host with CC/CMS, libartd boot with N9, Ritz EAAC.\nChange-Id: I3749bb525e7734804307ee16262355f3fc730312\n" }, { "commit": "be3a3ee02f148345ba6e1a0361532a3f7e8c0002", "tree": "b8235dcb24ceffe2c77ebb38c73486ad6a368094", "parents": [ "c6eced06a8592e2077cf7c894c8e05702571bf4d", "febd0cf9b5070ecc54ba433b951b65e14a54ccde" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Sep 16 17:59:09 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Sep 16 17:59:10 2016 +0000" }, "message": "Merge \"Fix a deadlock in the CC collector.\"" }, { "commit": "febd0cf9b5070ecc54ba433b951b65e14a54ccde", "tree": "75d96af58e255b442a45e2fa611e62851a1dc0ce", "parents": [ "26ead4975e1752e8ae2f5ed6fda73876c4f9ff59" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Sep 14 19:31:25 2016 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Sep 15 18:00:09 2016 -0700" }, "message": "Fix a deadlock in the CC collector.\n\nFix a deadlock between CC GC disabling system weaks and thread attach.\n\nSee 31500969#2 for more details.\n\nBug: 31500969\nBug: 12687968\nTest: test-art-host with CC. N9 libartd boot. Ritz EAAC.\nChange-Id: Ic9a8bfb1c636643a03f4580b811fe890273576b6\n" }, { "commit": "a5931185c97c7b17981a9fc5016834a0bdd9480b", "tree": "22f1a57647d7113c7c5aa5e0f0db5937380f2739", "parents": [ "fce42f486d9a607fb4fb472ec142a82ceccb6b5f" ], "author": { "name": "Chih-Hung Hsieh", "email": "chh@google.com", "time": "Thu Sep 01 15:08:13 2016 -0700" }, "committer": { "name": "Chih-Hung Hsieh", "email": "chh@google.com", "time": "Thu Sep 15 09:09:35 2016 -0700" }, "message": "Fix google-explicit-constructor warnings in art.\n\n* Add explicit keyword to conversion constructors,\n or NOLINT for implicit converters.\nBug: 28341362\nTest: build with WITH_TIDY\u003d1\n\nChange-Id: I1e1ee2661812944904fedadeff97b620506db47d\n" }, { "commit": "bdf7f1c3ab65ccb70f62db5ab31dba060632d458", "tree": "25cc77adfeb05232d0ab00aa561a693f1d71745c", "parents": [ "d7eabc2cc1a88c1f7f927da61246ae65aab0626c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 16:38:47 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 30 17:02:53 2016 -0700" }, "message": "ART: SHARED_REQUIRES to REQUIRES_SHARED\n\nThis coincides with the actual attribute name and upstream usage.\nPreparation for deferring to libbase.\n\nTest: m\nTest: m test-art-host\nChange-Id: Ia8986b5dfd926ba772bf00b0a35eaf83596d8518\n" }, { "commit": "f8a86b9ecefecae8bc0e456d540dae115249fdb6", "tree": "a0621285655b30bba6e13cbd6d3b65d85f1d20cc", "parents": [ "336f697941f2efd1d9ab9f5d45cc31e24e79b1b9" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jun 14 17:08:47 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jun 14 17:58:29 2016 -0700" }, "message": "Visit invalid roots of only suspended threads\n\nSince this always happens with suspended threads or self, you can\njust visit these threads and do not require a suspend all. This\nwill not miss any roots if the caller was marking a thread root.\n\nFixes issues like transitioning to suspended and back blocking on a\nthread suspension request from another thread. This could cause\ndeadlocks previously.\n\nBug: 29062271\n\nChange-Id: I2fef149387aacf0cdc9a773d4f172c42fa53e4dc\n" }, { "commit": "61b3cd45c5e3a5c24f7ccce94843a718375f9b7a", "tree": "fc71e27e0ddf6be1f672b69524b7ee978fd9d29c", "parents": [ "74b3c8f3850c2e4a7b17e9821ad78b59e6f8e047" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Apr 18 11:43:29 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Apr 18 15:29:53 2016 -0700" }, "message": "Prevent holding stale Thread pointers\n\nIt is only really safe to hold non-self Thread* if you hold the\nthread list lock. Changed a few places to use thread ids instead\nof Thread.\n\nBug: 28223501\n\n(cherry picked from commit 81c170fede9af9174aba71428334ac8f366a4b4f)\n\nChange-Id: I15e50b699303a5c3739e4d19c153dd306e2ee504\n" }, { "commit": "d3c59658faf9aaeb49cf63d928cead324f14bd8a", "tree": "be4d1b19e228bf2dcaacc1b3adea220d1831e981", "parents": [ "f808e8a0cc218c2b98023ef0e91f3c5b74ad2962" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Mar 17 09:35:04 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Mar 17 10:48:33 2016 +0000" }, "message": "Check GetDumpNativeStackOnSigQuit() for daemons.\n\nThe flag is passed by run-test to avoid libunwind crash flakiness,\nso we should check it when dumping threads.\n\nChange-Id: I3a3fcfd80ab254a315d58d629c81161fea9900dc\n" }, { "commit": "a73280df8cac1279b6dea0424722f42ef0048613", "tree": "22adc28cc88bc440b8e28a13a389c3a3c2b22341", "parents": [ "47a2a45a6673ddf3322115ff5058763f82a9368f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 15 13:05:16 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 15 16:24:56 2016 +0000" }, "message": "Add an option to disable native stack dumping on SIGQUIT.\n\nSome of our (stress) run-tests do ANR dumping, which end up\nstressing libunwind, that has known problems. To avoid getting\nflakes due to libunwind, disable native stack dumping on SIGQUIT\nfor our run-tests.\n\nbug:27185632\nbug:24664297\nChange-Id: I69085e48db903d6240448d71666ae2dcd091922e\n" }, { "commit": "4d87df607a0b86cdf4b2c04f61d72a60d8975ce0", "tree": "922e882c15633e6c700091c99864868d69822d7d", "parents": [ "97f2ca08c3d9a2b1694419aea07cd64f477c0af2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 07 15:14:19 2016 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 08 15:46:52 2016 -0800" }, "message": "Improve handling of daemon threads after runtime shutdown\n\nThe main issue comes from the fact that user daemon threads are\nallowed to continue running after the runtime has shutdown. They may\nstill have a JNI env pointer. To prevent crashing if they call into\nthe env, we replace the function pointers with functions that sleep\nforever.\n\nThe other issue is that user daemon threads that are blocked in an\nART condition variable may get woken up by another user daemon inside\nof Monitor::Notify or by a spurious wakeup (i.e. SIGQUIT). To deal\nwith this issue, we check the JNI env for shutdown runtime when we\nare woken up from a condition variable wait. This check fixes test\n132 with --host --gdb --interpreter. Previously this test crashed\nsince dlclose was somehow causing a spurious futex wakeup.\n\nTODO: Investigate adding a unit test.\n\nBug: 18577101\nChange-Id: I479b38968ee9fbc4ee4b252ee2528787279972cc\n" }, { "commit": "b56200b014d6bcfb962dc7afdd8b5f7168043ae7", "tree": "bca1d7a9d88f8f847ddaccb3f95da6c5f1ca7f84", "parents": [ "0b654bce0f8d7c596d4115848b7e4c4dbeadafd5" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 29 10:41:51 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 29 12:00:01 2015 -0700" }, "message": "Add comment for RunCheckpoint and clean up ThreadList a bit\n\nChange-Id: Id512bfd15fee9a7359c77f094e16d64634943619\n" }, { "commit": "10d2508b105427ef1bcaf0c222873bae7acc66d3", "tree": "8aa018dd07a1d84daf9f44ea7bb1c02442c44097", "parents": [ "5f2e628b280dfc5f8385e489d44cc0960fcea484" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 28 18:36:09 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 28 19:24:54 2015 -0700" }, "message": "Change Checkpoint API to return total number of checkpoints\n\nFixes a race condition with SetStateUnsafe that caused some\nwarnings in the Barrier::~Barrier.\n\nThe race was:\nRunCheckpoint sees suspended thread, runs the checkpoint. Inside the\ncheckpoint, the thread state had changed to runnable by\nSetStateUnsafe. This occasionally caused more Barrier::Pass than\nexpected.\n\nThe fix is to return the total number of checkpoints instead of just\nthe runnable ones.\n\nBug: 24191051\nChange-Id: If15a933ed4c8efa66a5f27cd5feaa2e5957ae804\n" }, { "commit": "4f55e22630d99ca0edd9e951e5ee96b57bb9b980", "tree": "84b7d55a6a7c31c09ed2865cc1bc2f4393476533", "parents": [ "2d06e08d25bbf8eff1de945736a60810009e59ad" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 04 13:26:21 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 11 13:14:20 2015 -0700" }, "message": "Add and use ScopedSuspendAll\n\nUsage replaces most SuspendAll and ResumeAll calls.\n\nChange-Id: I355683a5365876242cea85a656dcb58455f7a294\n" }, { "commit": "90443477f9a0061581c420775ce3b7eeae7468bc", "tree": "8c74b81dfae162e0fd0ccf8d5ac50827ba815174", "parents": [ "6078aec213dfaf111c29969706e8e5967cfc9bea" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 16 20:32:27 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 22 15:13:56 2015 -0700" }, "message": "Move to newer clang annotations\n\nAlso enable -Wthread-safety-negative.\n\nChanges:\nSwitch to capabilities and negative capabilities.\n\nFuture work:\nUse capabilities to implement uninterruptible annotations to work\nwith AssertNoThreadSuspension.\n\nBug: 20072211\n\nChange-Id: I42fcbe0300d98a831c89d1eff3ecd5a7e99ebf33\n" }, { "commit": "eac4424b3420c280f97ff2f815b5dedd8dac9801", "tree": "4e7c31b4312aa000bd3d2250df6a05daf61523d7", "parents": [ "ec97825f8553b3a99b6dfbbb90a50fe65301ea94" ], "author": { "name": "Yu Li", "email": "yu.l.li@intel.com", "time": "Mon Jun 29 10:50:03 2015 +0800" }, "committer": { "name": "Man Cao", "email": "manc@google.com", "time": "Mon Jul 13 15:56:19 2015 -0700" }, "message": "ART: JNI thread state transition optimization\n\nThis patch improves the JNI performance by removing the explicit acquiring and\nreleasing the mutator lock when a thread state transits between suspended and\nrunnable states.\n\nThe functions responsible for changing the state were found to be the costliest\npart of the JNI. Originally, a thread needs to acquire a shared mutator lock by\na CAS instruction when entering the runnable state and also needs to release\nthe lock by a CAS when entering the native state from runnable. This patch\nremoves these CAS operations when a thread state transits between suspended and\nrunnable. A thread in the runnable state is considered to have shared ownership\nof the mutator lock and therefore transitions in and out of the runnable state\nhave associated implication on the mutator lock ownership. Meanwhile, a barrier\nis added to control suspending all threads from running.\n\nJNI transition overhead was reduced by 25% on IA platform and by 17% on ARM\nplatform by this patch, while it has little impact on GC pause time (measured\nwith \"suspend all histogram\").\n\nChange-Id: Icee95d8ffff1bbfc95309a41cc48836536fec689\nSigned-off-by: Yu, Li \u003cyu.l.li@intel.com\u003e\nSigned-off-by: Haitao, Feng \u003chaitao.feng@intel.com\u003e\nSigned-off-by: Lei, Li \u003clei.l.li@intel.com\u003e\n" }, { "commit": "bf44d42d978861f33fd5978f49392db3321ae414", "tree": "9026c1e27e713bebc3d23139dfb0263ca3435ba1", "parents": [ "35d62ce1801aad45233ae72c1bd665f8709e4a6d" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jun 02 11:42:18 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jun 02 17:51:53 2015 -0700" }, "message": "Add a way to SuspendAll for a long duration\n\nHprof uses this mode to not cause thread suspend timeouts if GC tries\nwhile the hprof dump is running.\n\n(cherry picked from commit 77be6635f9b07a8a794924c5fb9b071949776a6d)\n\nBug: 21063989\nChange-Id: Ic6304620afd1489719a7e0e4299f829c90fe27cc\n" }, { "commit": "2cebb24bfc3247d3e9be138a3350106737455918", "tree": "d04d27d21b3c7733d784e303f01f873bb99e7770", "parents": [ "1f02f1a7b3073b8fef07770a67fbf94afad317f0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 21 16:50:40 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 12:44:27 2015 -0700" }, "message": "Replace NULL with nullptr\n\nAlso fixed some lines that were too long, and a few other minor\ndetails.\n\nChange-Id: I6efba5fb6e03eb5d0a300fddb2a75bf8e2f175cb\n" }, { "commit": "bb87e0f1a52de656bc77cb01cb887e51a0e5198b", "tree": "113f014c6e20fab3e936a3ac05f9f738639541f6", "parents": [ "e57fc0f0260fcb1d08cbb720ec95c04c0f394b91" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 03 11:21:55 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Apr 06 10:44:37 2015 -0700" }, "message": "Refactor and improve GC root handling\n\nChanged GcRoot to use compressed references. Changed root visiting to\nuse virtual functions instead of function pointers. Changed root visting\ninterface to be an array of roots instead of a single root at a time.\nAdded buffered root marking helper to avoid dispatch overhead.\n\nRoot marking seems a bit faster on EvaluateAndApplyChanges due to batch\nmarking. Pause times unaffected.\n\nMips64 is untested but might work, maybe.\n\nBefore:\nMarkConcurrentRoots: Sum: 67.678ms 99% C.I. 2us-664.999us Avg: 161.138us Max: 671us\n\nAfter:\nMarkConcurrentRoots: Sum: 54.806ms 99% C.I. 2us-499.986us Avg: 136.333us Max: 602us\n\nBug: 19264997\n\nChange-Id: I0a71ebb5928f205b9b3f7945b25db6489d5657ca\n" }, { "commit": "bf9fc581e8870faddbd320a935f9a627da724c48", "tree": "0a4a6c21fbd4c771b06fac186d32efa6722605b2", "parents": [ "3d96846b6adedf57be64eb3873de0ca58ec4b827" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 13 17:21:25 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 13 17:32:48 2015 -0700" }, "message": "Add more info to who called SuspendAll\n\nHelps diagnose related jank.\n\nChange-Id: I38191cdda723c6f0355d0197c494a3dff2b6653c\n" }, { "commit": "91e56692c6bd9fa1d41951ee7dc311f19461f4be", "tree": "8e7600204eed1509b7ec436ae789f3d8195a8755", "parents": [ "dc47e986941b1a3754447fabea272485f3f0f382" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 03 13:51:04 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 03 16:31:49 2015 -0800" }, "message": "Wait for threads to finish unregistering\n\nThere was a race where Thread::join would return before the thread was\nunregistered. This caused a problem with Daemons.stop since the thread\nlist could get deleted before the daemon thread was removed from list_.\nThis caused occasional \"Request to unregister unattached thread\"\nerrors and warnings.\n\nThe fix is to wait until threads finish registering before destroying\nthe thread list. The only threads which can be unregistering at this\npoint are the daemons we stopped earlier during the runtime shutdown\nprocess. The issue is that thread join finishes before we remove the\nthread from the thread list.\n\nAlso some cleanup.\n\nBug: 18713034\nChange-Id: I8921122fe8462643a6b814b5f00632481e3831fb\n" }, { "commit": "2cd334ae2d4287216523882f0d298cf3901b7ab1", "tree": "b72d3d07e5a04151caca96cae345075b6e4452b0", "parents": [ "604e2828896fbb8663897d1e75112da7305ead4c" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Jan 09 14:03:35 2015 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Jan 23 14:07:32 2015 -0800" }, "message": "More of the concurrent copying collector.\n\nBug: 12687968\nChange-Id: I62f70274d47df6d6cab714df95c518b750ce3105\n" }, { "commit": "e34fa1df67fbe0173b4ea9abddcc3ae3d0537037", "tree": "a5148f079b5671a95f60910c41981ebf91db3a02", "parents": [ "9f06b1946ae3ef1d2fd75bbf7f0a288bc611fe58" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jan 14 14:55:47 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 15 12:23:28 2015 -0800" }, "message": "Print more info in MarkSweep::VerifyRoot\n\nRefactored old root callback to use a new class called RootInfo.\nRootInfo contains all the relevant info related to the root\nassociated with the callback. The MarkSweep::VerifyRoot function\nnow uses this info to print the StackVisitor\u0027s described location\nif the GC root is of the type kRootJavaFrame.\n\nSome other cleanup.\n\nExample output:\nE/art (12167): Tried to mark 0x123 not contained by any spaces\nE/art (12167): Attempting see if it\u0027s a bad root\nE/art (12167): Found invalid root: 0x123 with type RootJavaFrame\nE/art (12167): Location\u003dVisiting method\n\u0027void java.lang.Runtime.gc()\u0027 at dex PC 0xffffffff (native PC 0x0)\nvreg\u003d0\n\n(cherry picked from commit 12f7423a2bb4bfab76700d84eb6d4338d211983a)\n\nBug: 18588862\nChange-Id: Ic5a2781f704e931265ffb3621c2eab4b2e25f60f\n" }, { "commit": "70a596d61f8cf5b6447326c46c3386e0fbd5bfb5", "tree": "f7affe0a976165eb9ff789270d314463f6e36660", "parents": [ "e9231c0aecc013c61b6cf7f88a228204651d4d41" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 17 14:56:47 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 17 16:03:58 2014 -0800" }, "message": "Add thread suspend histogram\n\nHelps measure time to suspend.\nExample output (maps after a few seconds):\nsuspend all histogram: Sum: 2.806ms 99% C.I. 2us-1090.560us Avg: 43.843us Max: 1126us\n\nChange-Id: I7bd9dd3b401fb3e3059e8718556d60910e541611\n" }, { "commit": "4ad5cd3e7d519484559ef778d96fb3f0be8919fa", "tree": "9870938a0552b4fe472d9994a55a3bf761fc69d5", "parents": [ "741e287b60136db49ecf8da72f2b5ca48b0a39bd" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Nov 11 23:08:07 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Nov 12 15:29:12 2014 -0800" }, "message": "Modify the behavior of thread suspend shootouts.\n\nThe thread doing the suspension doesn\u0027t attempt to suspend the other thread\nunless it knows another thread isn\u0027t trying to suspend it. Use the suspend\ncount, and its lock, for this purpose.\nRe-enable ThreadStress test.\nBug: 15446488\n\nChange-Id: Idd34410c7b89d8abd6973e5699a15ca699472c78\n" }, { "commit": "253fa555d9424a56c52879449eabe73d5c96cf61", "tree": "15ad96b41587b1b03aefb401da02f7c26c03ba5e", "parents": [ "3f5b8a1e7dfdf010591e17396d1d126740c5706c" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 14 17:27:15 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 21 19:21:41 2014 +0200" }, "message": "Fix JDWP Virtualmachine.Resume command\n\nWe used to call ThreadList::UndoDebuggerSuspensions but this is not\ncorrect. Indeed Virtualmachine.Resume command should be performed\nas many times as all threads have been suspended (either by the\nVirtualmachine.Suspend command or the application of suspend policy\nALL for event).\n\nThis CL fixes this issue by adding ThreadList::ResumeAllForDebugger.\nIt decrements suspend count and debug suspend count by 1 (globally\nand for each thread).\n\nIt also handles the case where Virtualmachine.Resume is called while\nthreads have not been suspended (global debug suspend count is 0). In\nthis case we just print a warning and do nothing.\n\nBug: 17974047\nChange-Id: I25af22b1936760292d2a8c286e0867f2ae864108\n" }, { "commit": "7b078e8c04f3e1451dbdd18543c8b9692b5b067e", "tree": "414229c6b87eb20ea24c40780752da5a3999a49a", "parents": [ "f79ba17defbd9342e44ab9f3de0807054673d3c9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 10 14:44:24 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 12 14:57:53 2014 -0700" }, "message": "Compile time performance improvements focusing on interpret-only.\n\nReduce virtual method dispatch in the method verifier and make more code\ninline-able.\nAdd a StringPiece with const char* equality operator to avoid redundant\nStringPieces and strlens.\nRemove back link from register line to verifier and pass as argument to reduce\nsize of RegisterLine.\nRemove instruction length from instruction flags and compute from the\ninstruction, again to reduce size.\nAdd suspend checks to resolve and verify to allow for more easy monitor\ninflation and reduce contention on Locks::thread_list_suspend_thread_lock_.\nChange ThrowEarlierClassFailure to throw pre-allocated exception.\nAvoid calls to Thread::Current() by passing self.\nTemplate specialize IsValidClassName.\nMake ANR reporting with SIGQUIT run using checkpoints rather than suspending\nall threads. This makes the stack/lock analysis less lock error prone.\nExtra Barrier assertions and condition variable time out is now returned as a\nboolean both from Barrier and ConditionVariable::Wait.\n\n2 threaded host x86-64 interpret-only numbers from 341 samples:\nBefore change: Avg 176.137ms 99% CI 3.468ms to 1060.770ms\nAfter change: Avg 139.163% 99% CI 3.027ms to 838.257ms\nReduction in average compile time after change is 20.9%.\nSlow-down without change is 26.5%.\n\nBug: 17471626 - Fix bug where RegTypeCache::JavaLangObject/String/Class/Throwable\ncould return unresolved type when class loading is disabled.\nBug: 17398101\n\nChange-Id: Id59ce3cc520701c6ecf612f7152498107bc40684\n" }, { "commit": "ba32de47e32f436d7c11cb4a2e78bdd4ad4dc5d2", "tree": "1b56397dfce317d2034feebfb2191bcb09b78823", "parents": [ "14515d738dadf88e3e00b7dd1bd69899c4df4b91" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Aug 27 23:43:46 2014 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu Aug 28 15:37:27 2014 -0700" }, "message": "Fix issue with Thread.setName hanging after Thread.start\n\nWhen suspending a thread by peer the invariant that only attached threads are\nsuspended must be maintained. Add a ThreadList::Contains check which requires\nmaking this method non-static.\nAdd some extra thread logging.\n\nBug: 17302037\n\n(cherry picked from commit 37c16453a92bbf1a47f042000318a1b60381017d)\n\nChange-Id: I51832785d4b4b431e035318e75635f442e89a1fb\n" }, { "commit": "f3d874c60ee3ada19ce26a5c4e532312b6f3a9e9", "tree": "de14ab8b610f43a2c2c4c02f4ac67d614919fde2", "parents": [ "031ddea20cb311dfdb3bd16a13750f9cb426b299" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 17 18:52:42 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 17 18:59:40 2014 -0700" }, "message": "Avoid race in single thread suspension.\n\nDon\u0027t allow more than one concurrent single thread suspension to avoid\npotential cycles and deadlocks where threads try to suspend each other.\nBug: 16364458, 16354227\n\nChange-Id: I907f1d5591a6aa5c241d37d6b4a34f968f98df77\n" }, { "commit": "9e36931cc79ca665908db9575126881d1cfdea5a", "tree": "69099016576581e3e4d6c44ee01a7a6cc7db4b2c", "parents": [ "5da6e2b88258733dd3856543af27ca73b395ef60" ], "author": { "name": "Chao-ying Fu", "email": "chao-ying.fu@intel.com", "time": "Wed May 21 11:20:52 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu May 22 10:25:57 2014 -0700" }, "message": "Move modify_ldt_lock into global lock order.\n\nMutex modify_ldt_lock was being removed during runtime shutdown while\ndaemons thread may still detach. Avoid this by placing in global lock\norder.\nThis fixes cts dalvik vm-tests-tf that hang on some x86 devices.\n\nBy irogers: also, tidy global locks to agree with enum constants and\nadd extra verification that the global annotalysis order agrees with\nthe LockLevel order. Bumped the oat version and moved the locks as\nLockLevel additions previously caused entrypoints to be moved. Make\nunattached lock not handle the default mutex level case by moving the\nallocated thread ids lock into the global order.\n\nChange-Id: I9d03f19d44ea254accf0ceae8022563c77f7a02f\nSigned-off-by: Chao-ying Fu \u003cchao-ying.fu@intel.com\u003e\n" }, { "commit": "a03de6dbabbe857deae5b0f1e388fbd3a2420dc2", "tree": "2828105f52e2830842d4d62477bd1a613ae6b93f", "parents": [ "d54f3a6219bca6ae018f4395fa0f1254bd4459be" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Mar 08 23:37:07 2014 +0000" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Mar 08 23:37:07 2014 +0000" }, "message": "Revert \"Revert \"Make clang the default compiler on host.\"\"\n\nThis reverts commit d54f3a6219bca6ae018f4395fa0f1254bd4459be.\n\nChange-Id: Id96bb52a0d599f8848010d1589bdf0f70fc7124b\n" }, { "commit": "d54f3a6219bca6ae018f4395fa0f1254bd4459be", "tree": "6d9e7470f3143917c932671edc5896ea5b354f57", "parents": [ "87f8b4cf0c1d6aab3eb5d1e99cc4e7cf175ef772" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Mar 08 07:50:13 2014 +0000" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Mar 08 07:50:13 2014 +0000" }, "message": "Revert \"Make clang the default compiler on host.\"\n\nThis reverts commit 87f8b4cf0c1d6aab3eb5d1e99cc4e7cf175ef772.\n\nChange-Id: I91a513042f0f9cf66288a296ad4a3b5da7830c7b\n" }, { "commit": "87f8b4cf0c1d6aab3eb5d1e99cc4e7cf175ef772", "tree": "2828105f52e2830842d4d62477bd1a613ae6b93f", "parents": [ "a54ece27b9bfd651fc3173bf43ca030652306b6e" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 07 14:49:39 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 07 22:30:41 2014 -0800" }, "message": "Make clang the default compiler on host.\n\nMotivation, GCC\u0027s compiler warnings are inferior to clang\u0027s. -Wthread-safety is\nnot supported by GCC starting with version 4.7. As this change only effects the\nhost, performance issues are an impact on host building and testing alone.\nFix clang gtest building on host with BUILD_HOST_64bit.\nFix clang build regressions caused by unused fields.\nFix x86-64 regression caused by requirement to fire-up quick compiler even in an\ninterpret-only environment. Long-term this code doesn\u0027t belong in the quick\ncompiler.\n\nChange-Id: Ifc2b10177f40d0724cbbf8dab9653ac03cdd1cee\n" }, { "commit": "39c3bfbd03d85c63cfbe69f17ce5800ccc7d6c13", "tree": "fa777039b3f7c34f3dd322d04307766246526080", "parents": [ "0918614b7434783477e8668df7850a7aaf8d5611" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Tue Jan 28 18:33:52 2014 -0800" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Fri Mar 07 13:42:48 2014 -0800" }, "message": "Make use of profiling information for dex2oat\n\nIf the profile file exists, the compiler driver will read it\nand store the data in an internal map. Then, when we want to work\nout whether to compile a method or not, the map is consulted and if\nthe method shows up with a high enough percentage of use we compile it.\n\nThe profile file itself is created by installd and is writeable by the\napp. The file is in /data/dalvik-cache/profiles and is named by\nthe package name.\n\nThis also modifies the profiler itself to:\n\n1. Only count runnable threads (not suspended threads) in the profile\n2. Use system properties to allow tuning of the profile parameters\n3. Merge profiles from multiple processes using file locking.\n\nBug: 12877748\nChange-Id: Iab2f3a327a2860db2a80d5724277d6c626227f2b\n\nConflicts:\n\tcompiler/dex/frontend.cc\n\tcompiler/dex/mir_analysis.cc\n\tcompiler/dex/verification_results.cc\n\tcompiler/driver/compiler_driver.cc\n\tdex2oat/dex2oat.cc\n\truntime/class_linker.cc\n\truntime/runtime.cc\n\truntime/runtime.h\n" }, { "commit": "719d1a33f6569864f529e5a3fff59e7bca97aad0", "tree": "fcd84efd7b9806b93ec1a44e2317e6f882e7fe0e", "parents": [ "5365eea9940269b662cfbe103caa348816ff1558" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 06 12:13:39 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 06 19:16:01 2014 -0800" }, "message": "Enable annotalysis on clang ART builds.\n\nFix clang build errors aswell as restructure locking/mutex code for correct\nthread safety analysis support.\nReorder make dependencies so that host builds build first as they should\nprovide better compilation errors than target.\nRemove host\u0027s use of -fno-omit-frame-pointer as it has no value with correct\nuse of CFI, which we should have.\n\nChange-Id: I72cea8da9a3757b1a0b3acb4081feccb7c6cef90\n" }, { "commit": "83c8ee000d525017ead8753fce6bc1020249b96a", "tree": "d5167ed15dee2629905ac3640b6ea0578d4ae312", "parents": [ "7cba217ab0661d74deccbb97160cdf60b74d4ea3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 28 14:50:23 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 11 10:40:10 2014 -0800" }, "message": "Add root types and thread id to root visiting.\n\nEnables us to pass the root type and thread id to hprof.\n\nBug: 12680863\nChange-Id: I6a0f1f9e3aa8f9b4033d695818ae7ca3460d67cb\n" }, { "commit": "590fee9e8972f872301c2d16a575d579ee564bee", "tree": "b02db45c72f1911ec896b93379ada0276aea3199", "parents": [ "5b70680b8df6d8fa95bb8e1070d0107f3d388940" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 13 13:46:47 2013 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 11 15:34:27 2013 -0800" }, "message": "Compacting collector.\n\nThe compacting collector is currently similar to semispace. It works by\ncopying objects back and forth between two bump pointer spaces. There\nare types of objects which are \"non-movable\" due to current runtime\nlimitations. These are Classes, Methods, and Fields.\n\nBump pointer spaces are a new type of continuous alloc space which have\nno lock in the allocation code path. When you allocate from these it uses\natomic operations to increase an index. Traversing the objects in the bump\npointer space relies on Object::SizeOf matching the allocated size exactly.\n\nRuntime changes:\nJNI::GetArrayElements returns copies objects if you attempt to get the\nbacking data of a movable array. For GetArrayElementsCritical, we return\ndirect backing storage for any types of arrays, but temporarily disable\nthe GC until the critical region is completed.\n\nAdded a new runtime call called VisitObjects, this is used in place of\nthe old pattern which was flushing the allocation stack and walking\nthe bitmaps.\n\nChanged image writer to be compaction safe and use object monitor word\nfor forwarding addresses.\n\nAdded a bunch of added SIRTs to ClassLinker, MethodLinker, etc..\n\nTODO: Enable switching allocators, compacting on background, etc..\n\nBug: 8981901\n\nChange-Id: I3c886fd322a6eef2b99388d19a765042ec26ab99\n" }, { "commit": "d9c4fc94fa618617f94e1de9af5f034549100753", "tree": "1305efbbc3d4bc306c0947bb6d4b01553667f98e", "parents": [ "7ef126ce0593929bcf8fb73d8b1119ce3b95b3f2" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 01 19:45:43 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 02 09:31:55 2013 -0700" }, "message": "Inflate contended lock word by suspending owner.\n\nBug 6961405.\nDon\u0027t inflate monitors for Notify and NotifyAll.\nTidy lock word, handle recursive lock case alongside unlocked case and move\nassembly out of line (except for ARM quick). Also handle null in out-of-line\nassembly as the test is quick and the enter/exit code is already a safepoint.\nTo gain ownership of a monitor on behalf of another thread, monitor contenders\nmust not hold the monitor_lock_, so they wait on a condition variable.\nReduce size of per mutex contention log.\nBe consistent in calling thin lock thread ids just thread ids.\nFix potential thread death races caused by the use of FindThreadByThreadId,\nmake it invariant that returned threads are either self or suspended now.\n\nCode size reduction on ARM boot.oat 0.2%.\nOld nexus 7 speedup 0.25%, new nexus 7 speedup 1.4%, nexus 10 speedup 2.24%,\nnexus 4 speedup 2.09% on DeltaBlue.\n\nChange-Id: Id52558b914f160d9c8578fdd7fc8199a9598576a\n" }, { "commit": "02e25119b15a6f619f17db99f5d05124a5807ff3", "tree": "7be4cbbf28033e5ee0621565b410fe5d8170a8fb", "parents": [ "7d70a7932f0ba09eb01a93caab060aef1403d4e6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 14 16:14:24 2013 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Aug 16 13:15:37 2013 -0700" }, "message": "Fix up TODO: c++0x, update cpplint.\n\nNeeded to update cpplint to handle const auto.\n\nFixed a few cpplint errors that were being missed before.\n\nReplaced most of the TODO c++0x with ranged based loops. Loops which\ndo not have a descriptive container name have a concrete type instead\nof auto.\n\nChange-Id: Id7cc0f27030f56057c544e94277300b3f298c9c5\n" }, { "commit": "7934ac288acfb2552bb0b06ec1f61e5820d924a4", "tree": "43f3acd8af7fd34d4ae7b64f6e06bb8429d74bb8", "parents": [ "fb331d7ca004f39608fcfdae49d38df90c702ea9" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 10:54:15 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 11:55:10 2013 -0700" }, "message": "Fix cpplint whitespace/comments issues\n\nChange-Id: Iae286862c85fb8fd8901eae1204cd6d271d69496\n" }, { "commit": "fc0e3219edc9a5bf81b166e82fd5db2796eb6a0d", "tree": "5fc7f5b941724a62f8e3411df09fae431ff5e3cf", "parents": [ "56d947fbc9bc2992e2f93112fafb73e50d2aaa7a" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 14:40:12 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 16:49:05 2013 -0700" }, "message": "Fix multiple inclusion guards to match new pathnames\n\nChange-Id: Id7735be1d75bc315733b1773fba45c1deb8ace43\n" }, { "commit": "7940e44f4517de5e2634a7e07d58d0fb26160513", "tree": "ac90242d96229a6942f6e24ab137bc1f8f2e0025", "parents": [ "5cd9e3b122f276f610980cbaf0d2ad6ed4cd9088" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 13:46:57 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 17:49:01 2013 -0700" }, "message": "Create separate Android.mk for main build targets\n\nThe runtime, compiler, dex2oat, and oatdump now are in seperate trees\nto prevent dependency creep. They can now be individually built\nwithout rebuilding the rest of the art projects. dalvikvm and jdwpspy\nwere already this way. Builds in the art directory should behave as\nbefore, building everything including tests.\n\nChange-Id: Ic6b1151e5ed0f823c3dd301afd2b13eb2d8feb81\n" }, { "commit": "2dd0e2cea360bc9206eb88ecc40d259e796c239d", "tree": "9d619dc9508cbe73e4793bf6f08cbc761abfb48a", "parents": [ "ac21b797b3a425975d656d6b84a7b24401d35f42" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jan 24 12:42:14 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jan 30 16:48:31 2013 -0800" }, "message": "Directory restructuring of object.h\n\nBreak object.h into constituent files.\nReduce number of #includes in other GC header files.\nIntroduce -inl.h files to avoid mirror files #include-ing each other.\nCheck invariants of verifier RegTypes for all constructors.\n\nChange-Id: Iecf1171c02910ac152d52947330ef456df4043bc\n" }, { "commit": "f327e07b37e349b1ec5eaad6dc294a9b7a081d20", "tree": "2c64b1f6212045a529c18d1dbe04b3da8fd1d6e9", "parents": [ "9e0c175a0cea5c8c88a6927e6375554118f74a82" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 16:01:26 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 18:07:12 2013 -0800" }, "message": "Implement ObjectReference.MonitorInfo.\n\nChange-Id: Iefc276939b9e569f4ea4d7a5af9a28276a3fb632\n" }, { "commit": "76b6167407c2b6f5d40ad895b2793a6b037f54b2", "tree": "5c433a0907ddf401f4078b6703253b1ae75e723e", "parents": [ "f66330a747eff155eb571b634fc9d901c55a78a7" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Dec 12 17:47:30 2012 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Dec 12 18:11:44 2012 -0800" }, "message": "Move mutex.h into base/mutex.h.\n\nWe don\u0027t actually need any hackery to get the right mutex.h any\nmore, but since we planned on having the google3-like stuff\nin google3-like locations, this is an easy one to fix.\n\nChange-Id: Ie27464ebbc208a6f4e694a97cf26b1cee0737009\n" }, { "commit": "cfaa455374aae0a08c8cb28b5bb306b17866d652", "tree": "ca8f25a06f234385b6e62bb774085f1324e5d519", "parents": [ "3676aeb03d5f70933891bb3b21abb8e31a81e36c" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Nov 26 21:00:08 2012 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Nov 30 16:38:21 2012 -0800" }, "message": "Turn the thread peer_ into a Object*.\n\nDon\u0027t use a JNI global ref for the thread peer_ so that we can\nsupport more threads than we can global refs. This fixes run-test 51.\nFix a race in thread destruction where a thread may be requested to\nsuspend while deleting itself.\n\nChange-Id: Id8756a575becf80d2a0be0a213325034556927f1\n" }, { "commit": "0e4627e593bc39f8e3d89c31f8977d55054c07cc", "tree": "1d69558732c0c916e51a530985a26d4235ef0e6c", "parents": [ "9281f004db3f194930ef34d31e5d80c98341f38f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 23 16:13:36 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Oct 26 12:00:03 2012 -0700" }, "message": "Add thread pool class\n\nAdded a thread pool class loosely based on google3 code.\n\nModified the compiler to have a single thread pool instead of creating new threads in ForAll.\n\nMoved barrier to be in top level directory as it is not GC specific code.\n\nPerformance Timings:\n\nReference:\nboot.oat: 14.306596s\ntime mm oat-target:\nreal 2m33.748s\nuser 10m23.190s\nsys 5m54.140s\n\nThread pool:\nboot.oat: 13.111049s\ntime mm oat-target:\nreal 2m29.372s\nuser 10m3.130s\nsys 5m46.290s\n\nThe speed increase is probably just noise.\n\nChange-Id: If3c1280cbaa4c7e4361127d064ac744ea12cdf49\n" }, { "commit": "858f1c5fd5e528d0b16040ced74d4636046a42d8", "tree": "3cfe50b75962353cdd62ec68112f3f148f026506", "parents": [ "ef851d3058abfc56ed544f25d387dc7ff9c32e0b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 17 17:45:55 2012 -0700" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Tue Oct 23 10:38:45 2012 -0700" }, "message": "Check point root marking.\n\nAdded thread list checkpoint function, this goes through every thread and runs\nthe checkpoint on each thread. Threads that are runnable run the checkpoint\ncallback themselves in the next suspend check, while suspended threads are\nleft suspended but have the callback called on them.\n\nAdded a checkpoint visitor member to each thread, this visitor called when the\ncheckpoint request flag is set during transitions to suspended from runnable.\n\nUsing the checkpoint to mark the roots reduces the first pause of partial /\nfull gc to around 1 ms.\n\nChange-Id: I97239cc72ee0e4a3397e9138a62ee559268dce0a\n" }, { "commit": "6f1c94968ada57da433debf8e2d1b38a80ceb510", "tree": "3628c7d9f5273d2c83dd7c6f9e816816eed8b70a", "parents": [ "0051be6d118c511308ed7764ef41e0d594292c49" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 15 12:08:41 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 15 12:37:33 2012 -0700" }, "message": "Add root verification when we try to mark an invalid object.\n\nNow when we try to mark an object not contained by any spaces, We call verify\nroots. This prints the root\u0027s vreg and method when it finds an invalid root.\n\nFixed a error in the total paused time statistic.\n\nChange-Id: Id10e4097cce56bc54ee488de32183c18ba3f3780\n" }, { "commit": "50b35e2fd1a68cd1240e4a9d9f363e11764957d1", "tree": "4f3c58b7b293380f19e4f33357cb352e3330772e", "parents": [ "8e9a1497f0d7da4d55f6e7ed8a7d96ba6db7222d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 04 10:09:15 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 05 11:07:39 2012 -0700" }, "message": "Explicitly pass Thread::Current to MutexLock and Alloc.\n\nChange-Id: I8b75bc0617915465f102815b32306aa7760dcae4\n" }, { "commit": "120f1c74a9768e958377b6c97897511b27ae58c8", "tree": "fa1f90d88ea34d8ef9eec729d27c7a70956a6a09", "parents": [ "cabc60e71a65fa17e5a99fba94fc61523fbeb478" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 17:17:10 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 03 17:29:26 2012 -0700" }, "message": "Fail threads attaching during runtime shutdown.\n\nIntroduce counters to indicate that threads are being born. Don\u0027t allow\nthread birth to occur during runtime shutdown.\n\nBug: 7000936\n\nChange-Id: Ib0d78f78c0ff126a4b5d3b5a6f1a2ff8f5061ae9\n" }, { "commit": "01ae5808367e641a983e3f8bb82b3e0d364cd03e", "tree": "34ce5f4f5a9405f8270d623571a058dcd993fd39", "parents": [ "a75a01313e801c53145df00bad1842d9f643c0a1" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 16:14:01 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 16:14:01 2012 -0700" }, "message": "Fix race in thread attaching during GC.\n\nForgot to mask in suspend request if thread is attaching during GC.\nLots of extra assertions and debugging.\n\nChange-Id: Id4d2ab659284acace51b37b86831a968c1945ae8\n" }, { "commit": "b726dcb581bf72da46527378ccb6889020f0e6e9", "tree": "c0383ed788652926e93147e50d659ed226519548", "parents": [ "fd678beb171a4686a4f2d53ca4188a4ade8fa54e" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 08:57:23 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 09:06:19 2012 -0700" }, "message": "Rename GlobalSynchronization to Locks\n\nAlso address some review comments in common_throws relating to\nToStr\u003cInvokeType\u003e and exception detail messages.\n\nChange-Id: Ibf2c0f147689fa236d349bd7f01eed3c2522552b\n" }, { "commit": "00f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abac", "tree": "6a2172ece15c4699e6c2a67ce76f019db0a9a21d", "parents": [ "634ea28f78c4a138e6a1de54eae8696095422415" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 19 15:28:27 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 14 10:45:52 2012 -0700" }, "message": "Global lock levels.\n\nIntroduce the notion of the mutators/GC being a shared-exclusive (aka\nreader-writer) lock. Introduce globally ordered locks, analysable by\nannotalysis, statically at compile time. Add locking attributes to\nmethods.\n\nMore subtly, remove the heap_lock_ and split between various locks that\nare held for smaller periods (where work doesn\u0027t get blocked). Remove\nbuggy Dalvik style thread transitions. Make GC use CMS in all cases when\nconcurrent is enabled. Fix bug where suspend counts rather than debug\nsuspend counts were sent to JDWP. Move the PathClassLoader to\nWellKnownClasses. In debugger refactor calls to send request and\npossibly suspend. Break apart different VmWait thread states. Move\nidentity hash code to a shared method.\n\nChange-Id: Icdbfc3ce3fcccd14341860ac7305d8e97b51f5c6\n" }, { "commit": "06f7987f1013638a172715986e8fce3fe884e47a", "tree": "e9bcc1797951616428aba51e1ce472342435657c", "parents": [ "5937e047bd15b3ce48c95e0457e501ab6feb7234" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jun 21 13:51:52 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jun 21 15:10:27 2012 -0700" }, "message": "Fix \"holding ThreadListLock while doing condition variable wait on HeapLock\"\n\nNow we release the ThreadListLock if we are going to wait on the heap condition variable in WaitForConcurrentGC.\n\nChange-Id: I506c8ff93f4b79ee74c98b7936a7d155be833b90\n" }, { "commit": "f8349361a16a4e2796efe9f3586b994e8d4834e4", "tree": "0a3474cde4028e1915c59393f49c147dd76ad766", "parents": [ "44335e189951a863607049a33571932fb6a2a841" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Jun 18 15:00:06 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Jun 18 15:16:21 2012 -0700" }, "message": "Use static thread safety analysis when available, and fix the bugs GCC finds.\n\nIt\u0027s impossible to express the Heap locking and the ThreadList locking with\nGCC, but Clang is supposed to be able to do it. This patch does what\u0027s possible\nfor now.\n\nChange-Id: Ib64a890c9d27c6ce255d5003cb755c2ef1beba95\n" }, { "commit": "7664f5cd118b355a5fe0c7536cb48ac991ed2b62", "tree": "0564c36316e2aa0a892ff9914258433f14641a07", "parents": [ "9eb5f03e0dd90ac25e01fcf81f832c50a1f09d2c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jun 08 18:15:32 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 11 11:17:13 2012 -0700" }, "message": "Fix GC performance regression\n\nEnable CMS and fix performance regression due to recursive marking image spaces. Dependent on my java change list.\n\nChange-Id: I4765792aa8226e811ac158f04ab88217db755573\n" }, { "commit": "abbe07d095547ded03c2e9d0d53943d43471278d", "tree": "f63555369a0e40574ee30ff634904e5eb3a467b5", "parents": [ "2ab7f486ba73b2846bdbdde65cc2d41f62a26015" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jun 05 17:42:23 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jun 05 17:42:23 2012 -0700" }, "message": "Include non-attached native threads in the SIGQUIT output.\n\nThese threads look something like this:\n\n \"droid.phasebeam\u0027 prio\u003d5 tid\u003d? (not attached)\n | sysTid\u003d5369 nice\u003d-4 sched\u003d0/0 cgrp\u003ddefault\n | schedstat\u003d( 0 0 0 ) utm\u003d1 stm\u003d8 core\u003d0 HZ\u003d100\n native: __futex_syscall3+8 [0x40074678] (libc.so)\n native: __pthread_cond_timedwait_relative+48 [0x40079474] (libc.so)\n native: __pthread_cond_timedwait+72 [0x40079528] (libc.so)\n native: android::renderscript::Signal::wait(unsigned long long)+58 [0x418bf117] (libRS.so)\n native: android::renderscript::LocklessCommandFifo::wait(unsigned long long)+38 [0x418bab97] (libRS.so)\n native: android::renderscript::LocklessCommandFifo::get(unsigned int*, unsigned int*, unsigned long long)+22 [0x418babbb] (libRS.so)\n native: android::renderscript::ThreadIO::playCoreCommands(android::renderscript::Context*, bool, unsigned long long)+126 [0x418bf84b] (libRS.so)\n native: android::renderscript::Context::threadProc(void*)+382 [0x418b7347] (libRS.so)\n native: __thread_entry+48 [0x40079d30] (libc.so)\n native: pthread_create+180 [0x40079884] (libc.so)\n\nAlso fix running tests on Mac OS, which has no /proc/self/cmdline.\n\nChange-Id: Ib5e6f7e23dd45aecdf814e84f573361a5d91bac6\n" }, { "commit": "c967f78cd29b6019f7cfca40a02e9b677112da70", "tree": "60458d56fc398c9fb7b67b6d834b85f626ac2b31", "parents": [ "fd8ea97f64fb6d32cbfe35729b816a22dfa18224" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 16 10:23:15 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 16 10:23:15 2012 -0700" }, "message": "Include a new heap summary line in the SIGQUIT output.\n\nLooks like this:\n\n Heap: 87% free, 4MB/32MB; 6327 objects\n\nWhile I\u0027m here, fix another long-standing TODO to make PrettySize have the\nusual google3 behavior. (I took the specific thresholds from Chromium.)\n\nAlso distinguish between the more general \"Dump\" member functions and the\nspecific SIGQUIT-related ones by consistently calling the latter DumpForSigQuit.\n\nChange-Id: I76e783adc18dd089bac9b348f53dc9860a0fe4b9\n" }, { "commit": "e52e49b32f5cf862a414da63e5dbd2eb04ad758e", "tree": "582296bc89fcb3ca475260abba8e9b3d6fc2f39d", "parents": [ "2d62a0e4ae6b528648c585aa804569aaefc4c517" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 02 16:05:44 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 02 16:05:44 2012 -0700" }, "message": "Fix the mutex diagnostics, and other targets of opportunity.\n\nThree changes for the price of one:\n\n1. Fix the mutex diagnostics so they work right during startup and shutdown.\n\n2. Fix a memory leak in common_test.\n\n3. Fix memory corruption in the compiler; we were calling memset(3) on a struct\nwith non-POD members.\n\nThanks, as usual, to valgrind(1) for the latter two (and several bugs in\nearlier attempts at the former).\n\nChange-Id: I15e1ffb01e73e4c56a5bbdcaa7233a4b5221e08a\n" }, { "commit": "398f64b5805246765b699839b439e18c0dfbf2ee", "tree": "de3f86de82289b1734b12cdc7c4292f4aff16f55", "parents": [ "ee0fa76b2e5d39ad36d1ff144b2d0270df81e606" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 18:05:48 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 18:05:48 2012 -0700" }, "message": "Remove more lint, mostly C-style casts.\n\nChange-Id: Iaf1f23290e35ed48e5795fb20690953a9a834457\n" }, { "commit": "88c5c355fc3d881f905564911d746b2313d5fc89", "tree": "d5b11b85131064cb6200465e674060933f48ebd7", "parents": [ "141b0c75986949da0adbf9c07ad92bc675f1bfed" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 15 18:49:48 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 15 21:14:57 2012 -0700" }, "message": "Make CheckJNI and JNI workarounds mutually exclusive...\n\n...in the opposite direction; needing workarounds turns off CheckJNI.\nThis isn\u0027t necessarily a good idea, but I like the cleanup parts of\nthis change.\n\nChange-Id: I708235ea3e5cc35ef90b01dd810e097e3ff9dd26\n" }, { "commit": "ffb465f23d9549dd591e6aa62e9250523cb00233", "tree": "2108ba79a4ec8031faa56ef0806f93bc2217c237", "parents": [ "71ac99485e79ad7eb1ba3ea2d404d53bb5784c13" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 01 18:46:05 2012 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 01 21:15:36 2012 -0800" }, "message": "libcorkscrew native stacks, mutex ranking, and better ScopedThreadListLock.\n\nThis change uses libcorkscrew to show native stacks for threads in kNative or,\nunlike dalvikvm, kVmWait --- working on the runtime directly I\u0027ve found it\nsomewhat useful to be able to see _which_ internal resource we\u0027re waiting on.\nWe can always take that back out (or make it oatexecd-only) if it turns out to\nbe too noisy/confusing for app developers.\n\nThis change also lets us rank mutexes and enforce -- in oatexecd -- that you\ntake locks in a specific order.\n\nBoth of these helped me test the third novelty: removing the heap locking from\nScopedThreadListLock. I\u0027ve manually inspected all the callers and added a\nScopedHeapLock where I think one is necessary. In manual testing, this makes\njdb a lot less prone to locking us up. There still seems to be a problem with\nthe JDWP VirtualMachine.Resume command, but I\u0027ll look at that separately. This\nis a big enough and potentially disruptive enough change already.\n\nChange-Id: Iad974358919d0e00674662dc8a69cc65878cfb5c\n" }, { "commit": "ff7380681c50129ff689a11ac0f49512b4be7295", "tree": "79704a4b85026aae58c17780cd88377e8d5a3c08", "parents": [ "9ada79cbe875dbcf7229b3f563303d21b0537d5f" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Feb 03 15:00:42 2012 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Feb 03 15:07:35 2012 -0800" }, "message": "Fix a thread suspend timeout, and improve the diagnostics for thread suspend timeouts.\n\nI still needed gdb to understand this, but when we dump _native_ stacks, the\nadditional diagnostics here will be more helpful. (They\u0027re somewhat helpful\nanyway, in that they let you see the state all threads are in. Also, in a\nstarted runtime rather than the compiler, threads will have informative managed\nstacks.)\n\nAlso make the apparent duplication in the dex2oat timings clearer, and only\ninclude time spent on resolving strings if we resolved any strings.\n\nChange-Id: Icd469d9b085171ebb2dede2afb5140387cd3240c\n" }, { "commit": "cd74c4b3a6893c876c6e03fd99a1264249653d80", "tree": "fd59dad11cb63ab6ff40be13e1572e1c2becab67", "parents": [ "844f9a072454eb9dca1022299b6bf99ef4294008" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Mon Jan 23 13:21:00 2012 -0800" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jan 25 11:07:15 2012 -0800" }, "message": "Fix thread hang\n\n- Primary problem was ScopedThreadListLock was releasing heap lock in constructor instead of destructor\n- Secondary problem was ScopedThreadListLock should not be used with Mutex::Wait\n- Added Thread.getStackTrace case to ThreadStress that reproduces YouTube problem\n- Added Mutex::GetDepth and related methods that were useful in diagnoising this issue\n\nChange-Id: I1bdc7245e9b411378b98f4dcf498ad66eb96366d\n" }, { "commit": "4dd9b4d95eec9db5338fb9bf132f9bb8facf6cf4", "tree": "f9dc6f6e6a55acea3a08f1f568ae6900c1dd7dd1", "parents": [ "20a409c99a649a01cb7c65bd1089988445d8cdfd" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Dec 12 18:29:24 2011 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Dec 13 08:23:08 2011 -0800" }, "message": "Clean up verbose logging.\n\nChange-Id: I6b01980e7145c4f8d25a5b50f620903f61a1b427\n" }, { "commit": "4e235316b4ada4d865c544d9b4ba397139333fa6", "tree": "bb9296420fe8ff9e44f1ddf4e95c8b5be08a1e9f", "parents": [ "1bba14f20039b6e706b719fdd5754eb30088d014" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Dec 02 11:34:15 2011 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Dec 02 11:34:15 2011 -0800" }, "message": "Implement \"GetThreadGroupParent\", \"Suspend\", and \"Resume\".\n\nThis is enough to get the GUI jswat working for poking around\nthreads, stacks, and locals.\n\nChange-Id: Ib02d9666cee8d39c09e4a09cf3961cebff1768ac\n" }, { "commit": "bbd9d830fe0eb8ce44405d7504dcf9a6fe91ffa1", "tree": "211747a79d87a2412c156e42713eea4638bbc340", "parents": [ "c2f8006ede3d07ca53467fa73573bdbfb864a65e" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Nov 07 14:40:00 2011 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Nov 07 14:40:00 2011 -0800" }, "message": "Fix at least two deadlocks.\n\nPretty much every caller that takes the thread list lock can then go on to\ncause allocation, which requires the heap lock. The GC always takes the heap\nlock first and the thread list lock second (to suspend/resume other threads).\nCue deadlocks.\n\nThis patch is a pretty degenerate fix that basically makes the thread list\nlock irrelevant; we now always take the heap lock first.\n\nChange-Id: I0537cffb0b841bfb5033789817793734d75dfb31\n" }, { "commit": "bfe487be25652c5456236661b9d9c3579d2296c1", "tree": "03e98cfc794946a85a5dfcc3170ae138f78da9b1", "parents": [ "234ab15b00f8120282d1833e5d7480eca2e35a29" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 26 15:48:55 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 26 16:52:02 2011 -0700" }, "message": "Makes objects known to the debugger GC roots, implements the THST message, and lets DDMS request stack traces.\n\nThis fills out correct data in all columns of the \"Threads\" table, and\ndouble-clicking on a thread shows that thread\u0027s stack.\n\nChange-Id: I48f63c3612e12d35269158dc3a283f07db28c8e7\n" }, { "commit": "234ab15b00f8120282d1833e5d7480eca2e35a29", "tree": "80f30c5cc581a1522369ebbae3e81182aad89dfd", "parents": [ "c37e9a5c68724d09539f0b6bc3e4877faa597b39" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 26 14:02:26 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 26 14:24:38 2011 -0700" }, "message": "Implement Dbg::Disconnected and Dbg::UndoDebuggerSuspensions.\n\nYou can now start and stop oatexec-based apps with DDMS running, with\nno UNIMPLEMENTEDs.\n\nChange-Id: Ic53e7bdd4ddd3ed93f9d807499d991ea30f48810\n" }, { "commit": "47fce01c0f27dba716fa6b97242562fbc5c26eea", "tree": "4a95d4bbc2a53ec765000e73cf026d404a667f73", "parents": [ "ed6d78ed93c9b5b1988af6ca502a7e2eee0f2aaf" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 25 18:37:19 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 25 18:37:19 2011 -0700" }, "message": "Basic DDMS thread support.\n\nDDMS can now see our running threads...\n\nChange-Id: I42d2fce4db9eb846fa0b4aac46ca6bb3443a6c9f\n" }, { "commit": "475fc23a4a7f35d1be87ea0b06c80df317a720ac", "tree": "91954099b3f4168a4bb97613219d1f5e329c1597", "parents": [ "6ba581a6711c4fed24828c9a294b1b49ac6bbb30" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 25 15:00:35 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 25 15:00:35 2011 -0700" }, "message": "More debugger support.\n\nThis gets us as far as the first DDMS-specific message, which means\nit\u0027s time to bring in a bunch more code.\n\nChange-Id: I3f9d75706d5ddde0aa21fcca558132282b94eff4\n" }, { "commit": "4f20aef512500525b2255d4b0e6984fe3e4b5229", "tree": "bb11000101a82e839f093b35259c494981a95be3", "parents": [ "6fbb516c44bc5a99dbfc52678d51ea5da507dbf5" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Oct 21 00:16:18 2011 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Oct 21 00:18:03 2011 -0700" }, "message": "Generalizing TryLock pattern to ThreadListLocker\n\nChange-Id: Icfe05fac35f72e59bc8d6ec5805020fff3c082d2\n" }, { "commit": "24a3c2e9924e8765c4a9b4d383cb8f3b922f9c9f", "tree": "1f61ecb377be4abcba4838651bc9d98b548a3f81", "parents": [ "3535c22d05bb4600255db90b490e625eda874b53" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Mon Oct 17 18:07:52 2011 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Mon Oct 17 18:17:36 2011 -0700" }, "message": "ClassLinker changes\n\n- Add ClassLinker::LockOwner for SignalCatcher\n- ClassLinker::ResolveMethod now sets CodeAndDirectMethod when code is available\n\nChange-Id: I404b80d1994808e018d00e0b30e8ba4f9d08fecc\n" }, { "commit": "a51a3dd5603daf3d368b7735067e1d9eb54c4c40", "tree": "2b2acdfa4743b5f28fa2c40364d5b029ebac1ede", "parents": [ "6a21982c960c8fb92ece0483c5b5b6047b0a7f77" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Oct 17 15:19:26 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Oct 17 15:28:15 2011 -0700" }, "message": "Add missing \u0027explicit\u0027s on single-argument constructors.\n\nChange-Id: I1494df6e74ec16238971fb4346ba184eb61c37ab\n" }, { "commit": "accd83d1523545ac69bafd38e72a7d5cff8e2fac", "tree": "1bad139a9b741483e34adc23b249e9f7fd1b6913", "parents": [ "6f7c958469d9b5a44ca2472058961a13d437b7bf" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Oct 17 14:25:58 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Oct 17 14:25:58 2011 -0700" }, "message": "Fix a heap lock/thread list lock deadlock.\n\nWe had an uncaught OOME whose uncaught exception handler -- running\nwith the thread lock held -- was trying to cause a GC while some\nother thread had the heap lock and was waiting for the thread list\nlock.\n\nChange-Id: I22177129562268837127d9edcc63ef5e93054bdf\n" }, { "commit": "8e4aac52962d54cb4be2078b9cd95685e067133a", "tree": "bb85a52e0326bef05acf9abe5e3d3b396c1d3795", "parents": [ "03f034949fa7b44aa49e6603d8d5e7a55bf07795" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Sep 26 17:03:36 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Sep 26 17:03:36 2011 -0700" }, "message": "Add the \"- waiting on\"/\"- waiting to lock\" lines to the SIGQUIT output.\n\nChange-Id: I0a8ab2e9e54c390e0d499ef464d82c2f2c628cbe\n" }, { "commit": "14357e842b611279d467b64d450c569af33a6936", "tree": "1160c2071afdde8cbf3d9eee2ea3b12a0bc98d03", "parents": [ "c0dd312b4ae5d11c59145f86a327c799877fbf53" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Sep 26 10:42:15 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Sep 26 10:42:15 2011 -0700" }, "message": "Add a -verbose:thread option.\n\nChange-Id: Ie9bbe2195d7c427379e4a27d3fe51f1a71e58597\n" }, { "commit": "7a3aeb4d7580164c6a6905c63b96823b77ff5a64", "tree": "be2ab3919e39b1a96c36ca138bfc9af63005107c", "parents": [ "15fdb8cfb5b2e3fc882113ec0648d492cebf852c" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Sun Sep 25 17:39:47 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Sun Sep 25 17:39:47 2011 -0700" }, "message": "Thread state fixes.\n\nAttaching a native thread should give you a thread in the kNative state.\nTo be able to run managed code when a thread detaches, we need to be in\nthe kRunnable state.\n\nChange-Id: I9c8048469d0e2d2a53e8fd85261975bbffe16b4f\n" }, { "commit": "01158d7a57c8321370667a6045220237d16e0da8", "tree": "f62e0bef39f7f04c969327f6a8540d7cff6e373d", "parents": [ "6699709cf27b706b5221527d9815dd9365911710" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Sep 19 19:47:10 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Sep 20 11:48:27 2011 -0700" }, "message": "Implement most of VMStack and some of Zygote.\n\nChange-Id: I07e18259a0452a2a9b077148f4f1ca67d3f63427\n" }, { "commit": "038a806df72f884d22283a84a31c9a1d35ba1fdf", "tree": "c980ef0f8dbfb35dfedcd9faa0804df3f3e03f84", "parents": [ "3101efb8f0e02fcfa70229c15631755cad758536" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Sun Sep 18 14:12:41 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Sun Sep 18 14:12:41 2011 -0700" }, "message": "Thread.join, GC daemons, suspend daemons on shutdown, and wait for non-daemon threads to exit.\n\n(I\u0027ve been testing with a modified SystemMethods test that does various thread\noperations.)\n\nChange-Id: I3087087546f90c43da7a0e63fae918ff0a6e7005\n" }, { "commit": "5f79133a435ebcb20000370d56046fe01201dd80", "tree": "974c4610e30e8cc950e6e461e66b939361cb2bbe", "parents": [ "78128a63b2615744760b7f8ab83df9764a5d4a95" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Sep 15 17:45:30 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Sep 16 10:56:44 2011 -0700" }, "message": "Implement monitors.\n\nChange-Id: Ifc7a801f9cbcdfbc1e1af5c905261dfadaa60f45\n" }, { "commit": "8d768a954b101a9532f980253ac46be2c53aba11", "tree": "ba6fa0be68a2289d5de3eb6c4de6fe93f6cd858a", "parents": [ "43a364291dcdfe08e530e9568748359735dd7442" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Sep 14 16:35:25 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Sep 14 16:35:25 2011 -0700" }, "message": "Thread suspension.\n\nIncludes SuspendAll/ResumeAll, and uses them in Heap and SignalCatcher.\n\nChange-Id: Ie39b868ca5961f5016f367acade5071392bb723e\n" }, { "commit": "93e74e8d879270071c3aa163f8495ada8d21f42f", "tree": "6efbb3203ab055168a613df128f7742edb3c0e29", "parents": [ "c74255fffb035001304c9a058a2e730a5a1a9604" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Sep 13 11:07:03 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Sep 13 11:34:52 2011 -0700" }, "message": "More of the thread infrastructure.\n\nWe can now run managed code on multiple threads.\n\nChange-Id: Ia4ce9c94602773db238c967c15194a6db780d12f\n" }, { "commit": "8daa0929f08a3080ea64dbd4e997e72f411e6fc9", "tree": "cecee23131d5e0357c17c44bcccc7ddcfb31b925", "parents": [ "4b620ffb1b4d0c96a94bb3afe314f35d53990ec6" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Sun Sep 11 13:46:25 2011 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Sun Sep 11 14:01:57 2011 -0700" }, "message": "More threads work.\n\nAdds stubs (and sometimes implementations) for dalvik.system.VMStack and\njava.lang.Thread native methods. There was a bug in the dalvik\nthread priority setting code, where the current thread and the passed-in\nthread were confused.\n\nI\u0027ve also pulled Mutex and ThreadList out into their own files, and\nmoved some functionality around (with the aim of having more stuff\nprivate, especially locks).\n\nChange-Id: Ieb0f22669cac3df44ca34f7868f8e7d4dfa09ab6\n" } ] }