)]}' { "log": [ { "commit": "4ad5cd3e7d519484559ef778d96fb3f0be8919fa", "tree": "9870938a0552b4fe472d9994a55a3bf761fc69d5", "parents": [ "741e287b60136db49ecf8da72f2b5ca48b0a39bd" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Nov 11 23:08:07 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Nov 12 15:29:12 2014 -0800" }, "message": "Modify the behavior of thread suspend shootouts.\n\nThe thread doing the suspension doesn\u0027t attempt to suspend the other thread\nunless it knows another thread isn\u0027t trying to suspend it. Use the suspend\ncount, and its lock, for this purpose.\nRe-enable ThreadStress test.\nBug: 15446488\n\nChange-Id: Idd34410c7b89d8abd6973e5699a15ca699472c78\n" }, { "commit": "4d5d62f404b164b697490d650ad8e82ad79a25f9", "tree": "801631d5d76c31fcc2f6836a7b3f4c3b65822b5f", "parents": [ "78a3233313260665fe82ba56257855e043bca3d4", "8409ec440079020bbe4ad066cf18a5fadfba67d2" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Nov 05 03:32:56 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Nov 05 03:32:56 2014 +0000" }, "message": "Merge \"Make thread dumping more tolerant of broken invariants during abort.\"" }, { "commit": "277ccbd200ea43590dfc06a93ae184a765327ad0", "tree": "d89712e93da5fb2748989353c9ee071102cf3f33", "parents": [ "ad17d41841ba1fb177fb0bf175ec0e9f5e1412b3" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 03 21:36:10 2014 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Nov 04 18:40:08 2014 -0800" }, "message": "ART: More warnings\n\nEnable -Wno-conversion-null, -Wredundant-decls and -Wshadow in general,\nand -Wunused-but-set-parameter for GCC builds.\n\nChange-Id: I81bbdd762213444673c65d85edae594a523836e5\n" }, { "commit": "8409ec440079020bbe4ad066cf18a5fadfba67d2", "tree": "20a5876198e3292b309b00d88345978f1f194a0e", "parents": [ "b5331ef9bb2ae68c392e5da3da13816bd43e5b1d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Nov 04 17:57:02 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Nov 04 17:57:02 2014 -0800" }, "message": "Make thread dumping more tolerant of broken invariants during abort.\n\nChange-Id: Ie1bc20debe72f2ea2bf4c1be50cd9877c823670a\n" }, { "commit": "6a3c1fcb4ba42ad4d5d142c17a3712a6ddd3866f", "tree": "9df58b57af13240a93a6da4eefcf03f70cce9ad9", "parents": [ "c6e0955737e15f7c0c3575d4e13789b3411f4993" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 31 00:33:20 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Nov 03 20:01:04 2014 -0800" }, "message": "Remove -Wno-unused-parameter and -Wno-sign-promo from base cflags.\n\nFix associated errors about unused paramenters and implict sign conversions.\nFor sign conversion this was largely in the area of enums, so add ostream\noperators for the effected enums and fix tools/generate-operator-out.py.\nTidy arena allocation code and arena allocated data types, rather than fixing\nnew and delete operators.\nRemove dead code.\n\nChange-Id: I5b433e722d2f75baacfacae4d32aef4a828bfe1b\n" }, { "commit": "02567379e7099682345fd59d45a23e17711c9ddd", "tree": "afab6024db00d1efb6236fadef9886aefe470973", "parents": [ "a1e50cab308af9f9a94e8bd370111eeff5634914", "253fa555d9424a56c52879449eabe73d5c96cf61" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Oct 24 07:49:38 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Oct 24 07:49:38 2014 +0000" }, "message": "Merge \"Fix JDWP Virtualmachine.Resume command\"" }, { "commit": "c7dd295a4e0cc1d15c0c96088e55a85389bade74", "tree": "0c08a2236bc9ba5d9a4dc75d4dd0ed2d76f8f1c6", "parents": [ "94e5af8602150efa95bde35cc9be9891ddf30135" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 21 23:31:19 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 22 12:06:23 2014 -0700" }, "message": "Tidy up logging.\n\nMove gVerboseMethods to CompilerOptions. Now \"--verbose-methods\u003d\" option to\ndex2oat rather than runtime argument \"-verbose-methods:\".\nMove ToStr and Dumpable out of logging.h, move LogMessageData into logging.cc\nexcept for a forward declaration.\nRemove ConstDumpable as Dump methods are all const (and make this so if not\ncurrently true).\nMake LogSeverity an enum and improve compile time assertions and type checking.\nRemove log_severity.h that\u0027s only used in logging.h.\nWith system headers gone from logging.h, go add to .cc files missing system\nheader includes.\nAlso, make operator new in ValueObject private for compile time instantiation\nchecking.\n\nChange-Id: I3228f614500ccc9b14b49c72b9821c8b0db3d641\n" }, { "commit": "253fa555d9424a56c52879449eabe73d5c96cf61", "tree": "15ad96b41587b1b03aefb401da02f7c26c03ba5e", "parents": [ "3f5b8a1e7dfdf010591e17396d1d126740c5706c" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 14 17:27:15 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 21 19:21:41 2014 +0200" }, "message": "Fix JDWP Virtualmachine.Resume command\n\nWe used to call ThreadList::UndoDebuggerSuspensions but this is not\ncorrect. Indeed Virtualmachine.Resume command should be performed\nas many times as all threads have been suspended (either by the\nVirtualmachine.Suspend command or the application of suspend policy\nALL for event).\n\nThis CL fixes this issue by adding ThreadList::ResumeAllForDebugger.\nIt decrements suspend count and debug suspend count by 1 (globally\nand for each thread).\n\nIt also handles the case where Virtualmachine.Resume is called while\nthreads have not been suspended (global debug suspend count is 0). In\nthis case we just print a warning and do nothing.\n\nBug: 17974047\nChange-Id: I25af22b1936760292d2a8c286e0867f2ae864108\n" }, { "commit": "e094b87c6f6ea9ebf83aa56a3114ac59556aaf9f", "tree": "d6db16b54affbe5304a8155bee3536b982acafd7", "parents": [ "cfd8adec84701752a56ddccf556b8c40142a9e0f" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Oct 14 13:12:01 2014 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Oct 14 18:12:09 2014 -0700" }, "message": "Store exiting thread ids and names while tracing to output later.\n\nBug: 17909204\n\n(cherry picked from commit fdcbc5c4c7c67bba06e038ac96a2e8bc49b91f84)\n\nChange-Id: Iea087560ba8b983412a6dde2ec166c9e7214f3a1\n" }, { "commit": "fec72f4a625122ab9972708b1f44f24b53a8b734", "tree": "f996f32dbfc823a7f129208e9deb24263d03c5c1", "parents": [ "a9b097443f26a6df1a322a8fef50fdd1f26a410b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 09 12:57:58 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 09 13:43:46 2014 -0700" }, "message": "Fix race in thread list destructor\n\nThe ThreadList::Contains wasn\u0027t being guarded by the thread list\nlock, which could cause a corrupted thread list if another thread\nunregistered itself while std::find was searching the thread list.\n\nBug: 17896374\n\n(cherry picked from commit b90132cb5132eaeb4dbfca1e63d79b4005dacec5)\n\nChange-Id: I8f6f979f365ca00ac0655e04eb26020d2ad7d6ee\n" }, { "commit": "5869a2c27ee0dbd7b420614c76ff14a706f0c5fb", "tree": "39bb17a7ae4a4d6c1db99d1a5e07ede899da0aec", "parents": [ "f1f05d303988a5c071c87b760056be8358276c94" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 08 14:26:23 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 08 14:26:23 2014 -0700" }, "message": "Dump mutator lock for thread suspend timeout\n\nShould help us see if thread suspend timeouts are due to someone\nholding on the mutator lock for too long or if it is a missed\nfutex wake.\n\n(cherry picked from commit f924d2381a5ea53967ba1e279766d601b9be05ea)\n\nBug: 17837911\nChange-Id: I3417156a78f574076d5da17c86836c5a7c76084a\n" }, { "commit": "f272af4b9dcd39cdd50fa6655601a26e837eaea9", "tree": "31e57bb86fadf00aeb05de3f4211320d7a281bf4", "parents": [ "d41491adb23764f28a80cbb7f2bd7af6491cd892" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Sep 18 10:20:42 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Sep 18 11:49:59 2014 +0200" }, "message": "Move spammy logs to JDWP verbose mode\n\nWe are spammed by warning messages when debugging, especially each time we\nsuspend/resume all threads (to update instrumentation or collect monitor info).\nIt\u0027s common to get into the cases where these warnings are logged so they\nshouldn\u0027t be warning but debug messages.\n\nThis CL moves these LOG(WARNING) to VLOG(jdwp) to not disturb developers when\ndebugging their app (especially when looking for specific messages in logcat).\nWe keep them in JDWP verbose mode because they help knowing when we initiate\nthese sequences of \"suspend/resume all threads\".\n\nAlso adds debug suspend count in the log message for more context.\n\nBug: 17524544\nBug: 17170697\nChange-Id: Ic87985ac6913151d15fd89849e41bde61092c3dd\n" }, { "commit": "a2af5c7e3262bb7165e9320426bd6925f1a3c90d", "tree": "e435735391dd903305fc00862c933354d6acff3d", "parents": [ "bace0378d720a1d2938ec7f6be17e2814671d20a" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Sep 15 15:17:07 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Sep 16 15:49:27 2014 -0700" }, "message": "Only log an error if an unattached thread is unregistered.\n\nTurn a fatal check into a diagnostic error. It looks like this issue arises\nwhen a runtime shutsdown without properly being started.\nBug: 17011539\n\nChange-Id: I2983c8332e83769e9480e8f30a46ca3b80a2e90e\n(cherry picked from commit e2bcf579b0bc2f53db68c38755d69543198c7b00)\n" }, { "commit": "2156ff1ff09166ad8270f27d758e913f120c3640", "tree": "c00f2c13d5ce557423bb8bf6b02b2e7cf0b1f18d", "parents": [ "0785b90a38f5f2f0d5a9e3890fd16dc63a3bca10" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Sep 13 19:20:54 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Sep 13 19:20:54 2014 -0700" }, "message": "Add time out to dump check point.\n\nChange-Id: I2263c092c9957585ae90cf846e77dc8861f8a14b\n" }, { "commit": "7b078e8c04f3e1451dbdd18543c8b9692b5b067e", "tree": "414229c6b87eb20ea24c40780752da5a3999a49a", "parents": [ "f79ba17defbd9342e44ab9f3de0807054673d3c9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 10 14:44:24 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 12 14:57:53 2014 -0700" }, "message": "Compile time performance improvements focusing on interpret-only.\n\nReduce virtual method dispatch in the method verifier and make more code\ninline-able.\nAdd a StringPiece with const char* equality operator to avoid redundant\nStringPieces and strlens.\nRemove back link from register line to verifier and pass as argument to reduce\nsize of RegisterLine.\nRemove instruction length from instruction flags and compute from the\ninstruction, again to reduce size.\nAdd suspend checks to resolve and verify to allow for more easy monitor\ninflation and reduce contention on Locks::thread_list_suspend_thread_lock_.\nChange ThrowEarlierClassFailure to throw pre-allocated exception.\nAvoid calls to Thread::Current() by passing self.\nTemplate specialize IsValidClassName.\nMake ANR reporting with SIGQUIT run using checkpoints rather than suspending\nall threads. This makes the stack/lock analysis less lock error prone.\nExtra Barrier assertions and condition variable time out is now returned as a\nboolean both from Barrier and ConditionVariable::Wait.\n\n2 threaded host x86-64 interpret-only numbers from 341 samples:\nBefore change: Avg 176.137ms 99% CI 3.468ms to 1060.770ms\nAfter change: Avg 139.163% 99% CI 3.027ms to 838.257ms\nReduction in average compile time after change is 20.9%.\nSlow-down without change is 26.5%.\n\nBug: 17471626 - Fix bug where RegTypeCache::JavaLangObject/String/Class/Throwable\ncould return unresolved type when class loading is disabled.\nBug: 17398101\n\nChange-Id: Id59ce3cc520701c6ecf612f7152498107bc40684\n" }, { "commit": "ed2be1725fb79075892b1a9103487c9d9a95b350", "tree": "8adf1d95f401c2c7e7df1c659c0dfcd4dd27a68f", "parents": [ "645f9871115e82ff836397f6470cca825befd245" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Aug 19 15:33:43 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 02 19:28:34 2014 +0200" }, "message": "Reduce lock contention when debugging\n\nUses a ReaderWriterMutex for the breakpoint lock to reduce contention during\ndebugging session.\n\nAlso adds missing thread safety annotations on fields and methods related to\ninstrumentation and debugging.\n\nBug: 16814665\nBug: 11667502\n\n(cherry picked from commit 59d9d668d4f4286813afe2b4e7c6db839222ce96)\n\nChange-Id: I5f1156da8c6cc8316d6db16e6cfb2470fe289ad3\n" }, { "commit": "ba32de47e32f436d7c11cb4a2e78bdd4ad4dc5d2", "tree": "1b56397dfce317d2034feebfb2191bcb09b78823", "parents": [ "14515d738dadf88e3e00b7dd1bd69899c4df4b91" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Aug 27 23:43:46 2014 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu Aug 28 15:37:27 2014 -0700" }, "message": "Fix issue with Thread.setName hanging after Thread.start\n\nWhen suspending a thread by peer the invariant that only attached threads are\nsuspended must be maintained. Add a ThreadList::Contains check which requires\nmaking this method non-static.\nAdd some extra thread logging.\n\nBug: 17302037\n\n(cherry picked from commit 37c16453a92bbf1a47f042000318a1b60381017d)\n\nChange-Id: I51832785d4b4b431e035318e75635f442e89a1fb\n" }, { "commit": "68d8b42ddec39ec0174162d90d4abaa004d1983e", "tree": "0bb6ccf3b996bb8363c10d07aa39cde221980602", "parents": [ "9c522c2cbbf50dc687728747b37ad59985750b65" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 17 11:09:10 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Aug 08 08:29:53 2014 -0700" }, "message": "Wire up check JNI force copy mode.\n\nIncrease check JNI checks.\nBreak apart jni_internal.h in to jni_env_ext.h and java_vm_ext.h.\nFix the abuse of ScopedObjectAccess/annotalysis by ScopedCheck in the case\nof VM routines.\nMake class loader override and shared library class loader JNI global\nreferences rather than mirror pointers.\nClean-ups to native bridge.\n\nChange-Id: If7c6110b5aade7a402bfb67534af86a7b2cdeb55\n" }, { "commit": "c5d824a20c225763761a6dff43294b229ff35469", "tree": "d3fcf29c2e7359bdb135931c0f4558644e1ca9fb", "parents": [ "8df73882c60451e7f789bf9b1f3db2d7dc228640" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Mon Jul 28 18:35:38 2014 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Jul 29 13:34:57 2014 -0700" }, "message": "Stop thread from reattaching during runtime shutdown while tracing.\n\nBug: 16024763\nChange-Id: Iad5ba180241ff74b15baf5c3a15ed2d2ed60fcf0\n" }, { "commit": "f3d874c60ee3ada19ce26a5c4e532312b6f3a9e9", "tree": "de14ab8b610f43a2c2c4c02f4ac67d614919fde2", "parents": [ "031ddea20cb311dfdb3bd16a13750f9cb426b299" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 17 18:52:42 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 17 18:59:40 2014 -0700" }, "message": "Avoid race in single thread suspension.\n\nDon\u0027t allow more than one concurrent single thread suspension to avoid\npotential cycles and deadlocks where threads try to suspend each other.\nBug: 16364458, 16354227\n\nChange-Id: I907f1d5591a6aa5c241d37d6b4a34f968f98df77\n" }, { "commit": "251755cd511463260e60be98bf138b6aa1c14bf3", "tree": "03c0e714efa3c9b54c2218cd4d5e64b27be01811", "parents": [ "76e6773dfed9e9bf382bbb8d6c8654525fa44b0c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jul 15 18:10:25 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jul 15 18:32:02 2014 -0700" }, "message": "Use sched_yield in Monitor::MonitorEnter.\n\nPreviously we used NanoSleep(1000), but this was unreliable. It could\nresult in waiting for \u003e\u003d 40ms instead of 1us. Since this was in a loop\nit was especially bad if the GC was trying to suspend all the\nthreads when we were sleeping. This resulted in thread suspension\noccasionally taking longer than a second.\nResults on the provided picasso-sample app on Nexus 5:\nLongest GC pause before: ~1.5s.\nLongest GC pause after: \u003c5ms.\n\nAlso added a warning if thread suspension takes longer than a\nthreshold (currently 5ms).\n\nBug: 16307460\nExternal bug: https://code.google.com/p/android-developer-preview/issues/detail?id\u003d367\n\nChange-Id: I3c2a9636357e255f38634615101eff8ca84e632f\n" }, { "commit": "bae182cbc6adc8796154162a87fc54ae804e0469", "tree": "d5c1fdb048edab194e948e4e90bff66703c5f55e", "parents": [ "0c1734665c38b3116e38a90ad06c3f152d9316c5" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Dec 17 10:42:03 2013 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jul 09 16:10:45 2014 +0200" }, "message": "Fix method tracing from command-line\n\nTransitions current thread to the new kWaitingForMethodTracingStart thread\nstate when starting method tracing.\n\nEnsures there is a current thread when method tracing is stopped due to runtime\nshutdown. If the current thread has been detached, we now re-attach it.\nNote: we only do this if method tracing has been activated from command-line.\n\nFixes instrumentation when forcing interpreter mode (-Xint) with method tracing\nenabled.\n\nRemoves unused parameter from UnsafeLogFatalForThreadSuspendAllTimeout.\n\nBug: https://code.google.com/p/android/issues/detail?id\u003d72094\nBug: 11683397\nChange-Id: I70f000fb46ddd95d6ad51ea0a8eee77697a045e9\n" }, { "commit": "9db911eb76976fc1c73c8e563beb3620f1cadf99", "tree": "0d9fa7344f7d356fedbbfeeff3cd8eb289e0435f", "parents": [ "4eef72bdf5fd83e7361fb11feaf5a40121ede03f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jun 04 11:23:58 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jun 04 12:03:48 2014 -0700" }, "message": "Print mutexes held in Thread::Dump.\n\nShould help finding and fixing thread suspend timeout issues.\n\nBug: 15328839\nChange-Id: I30a10529cec0716c7571a0318e9f66be54734fd8\n" }, { "commit": "9e36931cc79ca665908db9575126881d1cfdea5a", "tree": "69099016576581e3e4d6c44ee01a7a6cc7db4b2c", "parents": [ "5da6e2b88258733dd3856543af27ca73b395ef60" ], "author": { "name": "Chao-ying Fu", "email": "chao-ying.fu@intel.com", "time": "Wed May 21 11:20:52 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu May 22 10:25:57 2014 -0700" }, "message": "Move modify_ldt_lock into global lock order.\n\nMutex modify_ldt_lock was being removed during runtime shutdown while\ndaemons thread may still detach. Avoid this by placing in global lock\norder.\nThis fixes cts dalvik vm-tests-tf that hang on some x86 devices.\n\nBy irogers: also, tidy global locks to agree with enum constants and\nadd extra verification that the global annotalysis order agrees with\nthe LockLevel order. Bumped the oat version and moved the locks as\nLockLevel additions previously caused entrypoints to be moved. Make\nunattached lock not handle the default mutex level case by moving the\nallocated thread ids lock into the global order.\n\nChange-Id: I9d03f19d44ea254accf0ceae8022563c77f7a02f\nSigned-off-by: Chao-ying Fu \u003cchao-ying.fu@intel.com\u003e\n" }, { "commit": "5a9ba014516fcdeab617d1c006fdf2936865f178", "tree": "602819f9d2f0fcd9876054f8601355362665f23a", "parents": [ "394584556dac07794a092cf0098089ebdb5b81d0" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon May 19 13:28:52 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon May 19 13:28:52 2014 -0700" }, "message": "Build fix.\n\nChange-Id: Ie5a3abb9a729a4a724e247b127c200a7be4d900d\n" }, { "commit": "4d466a8e4587422c989705dce3b2a19e7f0137f5", "tree": "bd8f0f45db9a7d5888b14a070690f59fb599bd68", "parents": [ "f1c036fc8fa97617cc42bda44a0adbc7b856d6cd" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu May 08 19:05:29 2014 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri May 09 12:23:00 2014 -0700" }, "message": "Remove all LOG(DEBUG) which is not intended to be checked in\n\nBug: 14632493\nChange-Id: Id9da8b87798af0a1b2bd2c178133e5f1ba47d43d\n" }, { "commit": "6f365cc033654a5a3b45eaa1379d4b5f156b0cee", "tree": "959754c43ebd2b01e366ac06f21d833340a7fee5", "parents": [ "cb905718826da268d8d8e09296806256f202c9f4" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 23 12:42:27 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 29 12:58:08 2014 -0700" }, "message": "Enable concurrent sweeping for non-concurrent GC.\n\nRefactored the GarbageCollector to let all of the phases be run by\nthe collector\u0027s RunPhases virtual method. This lets the GC decide\nwhich phases should be concurrent and reduces how much baked in GC\nlogic resides in GarbageCollector.\n\nEnabled concurrent sweeping in the semi space and non concurrent\nmark sweep GCs. Changed the semi-space collector to have a swap semi\nspaces boolean which can be changed with a setter.\n\nFixed tests to pass with GSS collector, there was an error related to\nthe large object space limit.\n\nBefore (EvaluateAndApplyChanges):\nGSS paused GC time 7.81s/7.81s, score: 3920\n\nAfter (EvaluateAndApplyChanges):\nGSS paused GC time 6.94s/7.71s, score: 3900\n\nBenchmark score doesn\u0027t go up since the GC happens in the allocating\nthread. There is a slight reduction in pause times experienced by\nother threads (0.8s total).\n\nAdded options for pre sweeping GC heap verification and pre sweeping\nrosalloc verification.\n\nBug: 14226004\nBug: 14250892\nBug: 14386356\n\nChange-Id: Ib557d0590c1ed82a639d0f0281ba67cf8cae938c\n" }, { "commit": "a2cee18799d7e61adb037a4219adb23fef7d022b", "tree": "214a6d6d4682196aa0e2ebcb5a0cc7bcf3eec2d3", "parents": [ "ed0bc0bbf26f6751f31213d24ccdac49766e93ff" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Apr 16 19:13:59 2014 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Apr 18 15:32:15 2014 -0700" }, "message": "Modify unwind to comply with stack parser tools.\n\nBug: 14081592\n\nChange-Id: I6906b2575c74d64f1c3ba7602779b3a789de1c69\n" }, { "commit": "bb43b433c845e253a11346f0f03706d58a44f23c", "tree": "406fda2973407461cbadd7d0bf45afc109bfedad", "parents": [ "9b417e4f0f87da6bfe8dc5f02c987acfcb6dca31" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Apr 14 11:59:08 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Apr 14 12:01:15 2014 +0200" }, "message": "Clear unused roots from debugger\n\nSingleStepControl and DebugInvokeReq hold roots which are only used during a\nlimited amount of time. Clear these roots once we finish using them.\n\nAlso cleans some code around single-step.\n\nChange-Id: Ica2f65e04a4d60272199490cd40ad1803d3b9f02\n" }, { "commit": "7bf9f190cd33a7e2f8584299eb889e9df66e0323", "tree": "1817368ef167a6340129d2a59b0c423f5c87d604", "parents": [ "34df691e64a6491e7312a850a1ad255e4cf02702" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 04 11:09:41 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 04 11:22:27 2014 -0700" }, "message": "Improve invalid root dumping.\n\nThe invalid root dumping now attempts to print the root type.\n\nChange-Id: Ie821296d569f34909ba6e2705f5c347cd2143a3a\n" }, { "commit": "2966e13d504a72d55c62bf864e183ec80703c699", "tree": "ce13371288e4a08e8b627eeafd18a5b9746ecec4", "parents": [ "161f71ab4449047157ad3d967a3ed4f7c6e17249" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Apr 02 08:34:36 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Apr 02 08:36:46 2014 -0700" }, "message": "Avoid debug check violation in thread registration.\n\nBug: 13757855\nChange-Id: Ied83a7fc43e2b9a89a8b99aa4f74069ef8a369b1\n" }, { "commit": "dd7624d2b9e599d57762d12031b10b89defc9807", "tree": "c972296737f992a84b1552561f823991d28403f0", "parents": [ "8464a64a50190c06e95015a932eda9511fa6473d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 14 17:43:00 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 01 08:24:16 2014 -0700" }, "message": "Allow mixing of thread offsets between 32 and 64bit architectures.\n\nBegin a more full implementation x86-64 REX prefixes.\nDoesn\u0027t implement 64bit thread offset support for the JNI compiler.\n\nChange-Id: If9af2f08a1833c21ddb4b4077f9b03add1a05147\n" }, { "commit": "b373e091eac39b1a79c11f2dcbd610af01e9e8a9", "tree": "034d820c4829e0dcf6161473cc39f7250123bfaa", "parents": [ "9545a446e99b22248099fe66f5f9431530c20851" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Feb 20 16:06:36 2014 -0800" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Mar 13 12:21:15 2014 -0700" }, "message": "Implicit null/suspend checks (oat version bump)\n\nThis adds the ability to use SEGV signals\nto throw NullPointerException exceptions from Java code rather\nthan having the compiler generate explicit comparisons and\nbranches. It does this by using sigaction to trap SIGSEGV and when triggered\nmakes sure it\u0027s in compiled code and if so, sets the return\naddress to the entry point to throw the exception.\n\nIt also uses this signal mechanism to determine whether to check\nfor thread suspension. Instead of the compiler generating calls\nto a function to check for threads being suspended, the compiler\nwill now load indirect via an address in the TLS area. To trigger\na suspend, the contents of this address are changed from something\nvalid to 0. A SIGSEGV will occur and the handler will check\nfor a valid instruction pattern before invoking the thread\nsuspension check code.\n\nIf a user program taps SIGSEGV it will prevent our signal handler\nworking. This will cause a failure in the runtime.\n\nThere are two signal handlers at present. You can control them\nindividually using the flags -implicit-checks: on the runtime\ncommand line. This takes a string parameter, a comma\nseparated set of strings. Each can be one of:\n\nnone switch off\nnull null pointer checks\nsuspend suspend checks\nall all checks\n\nSo to switch only suspend checks on, pass:\n-implicit-checks:suspend\n\nThere is also -explicit-checks to provide the reverse once\nwe change the default.\n\nFor dalvikvm, pass --runtime-arg -implicit-checks:foo,bar\n\nThe default is -implicit-checks:none\n\nThere is also a property \u0027dalvik.vm.implicit_checks\u0027 whose value is the same\nstring as the command option. The default is \u0027none\u0027. For example to switch on\nnull checks using the option:\n\nsetprop dalvik.vm.implicit_checks null\n\nIt only works for ARM right now.\n\nBumps OAT version number due to change to Thread offsets.\n\nBug: 13121132\nChange-Id: If743849138162f3c7c44a523247e413785677370\n" }, { "commit": "39c3bfbd03d85c63cfbe69f17ce5800ccc7d6c13", "tree": "fa777039b3f7c34f3dd322d04307766246526080", "parents": [ "0918614b7434783477e8668df7850a7aaf8d5611" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Tue Jan 28 18:33:52 2014 -0800" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Fri Mar 07 13:42:48 2014 -0800" }, "message": "Make use of profiling information for dex2oat\n\nIf the profile file exists, the compiler driver will read it\nand store the data in an internal map. Then, when we want to work\nout whether to compile a method or not, the map is consulted and if\nthe method shows up with a high enough percentage of use we compile it.\n\nThe profile file itself is created by installd and is writeable by the\napp. The file is in /data/dalvik-cache/profiles and is named by\nthe package name.\n\nThis also modifies the profiler itself to:\n\n1. Only count runnable threads (not suspended threads) in the profile\n2. Use system properties to allow tuning of the profile parameters\n3. Merge profiles from multiple processes using file locking.\n\nBug: 12877748\nChange-Id: Iab2f3a327a2860db2a80d5724277d6c626227f2b\n\nConflicts:\n\tcompiler/dex/frontend.cc\n\tcompiler/dex/mir_analysis.cc\n\tcompiler/dex/verification_results.cc\n\tcompiler/driver/compiler_driver.cc\n\tdex2oat/dex2oat.cc\n\truntime/class_linker.cc\n\truntime/runtime.cc\n\truntime/runtime.h\n" }, { "commit": "719d1a33f6569864f529e5a3fff59e7bca97aad0", "tree": "fcd84efd7b9806b93ec1a44e2317e6f882e7fe0e", "parents": [ "5365eea9940269b662cfbe103caa348816ff1558" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 06 12:13:39 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 06 19:16:01 2014 -0800" }, "message": "Enable annotalysis on clang ART builds.\n\nFix clang build errors aswell as restructure locking/mutex code for correct\nthread safety analysis support.\nReorder make dependencies so that host builds build first as they should\nprovide better compilation errors than target.\nRemove host\u0027s use of -fno-omit-frame-pointer as it has no value with correct\nuse of CFI, which we should have.\n\nChange-Id: I72cea8da9a3757b1a0b3acb4081feccb7c6cef90\n" }, { "commit": "6dda898d47b3e8931e4404330e81b7110108e34f", "tree": "d8a0a20b8ac1ce3cd44273cf5c748d09980bd800", "parents": [ "8785d615122d4abbd22db702139584e8c472f502" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 06 11:11:48 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 06 11:43:06 2014 -0800" }, "message": "Disable compaction for jni workarounds.\n\nCompaction can\u0027t work when jni workarounds is enabled. Also some\nother refactoring.\n\nChange-Id: Ia7b0f2b39c79f5a0a5f50874d823b950ab02a0c3\n" }, { "commit": "6449c62e40ef3a9bb75f664f922555affb532ee4", "tree": "2f1b2120bd648c95dea32b68c8e168e42c8e24fd", "parents": [ "3fcf18e25241253f23efbeebe77b2a4c4a7c54d3" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Mon Feb 10 23:48:36 2014 -0800" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Mon Feb 24 14:24:12 2014 -0800" }, "message": "Create CompilerOptions\n\nPackage up most compiler related options in CompilerOptions. Details include:\n- Includes compiler filter, method thresholds, SEA IR mode.\n- Excludes those needed during Runtime::Init such as CompilerCallbacks and VerificationResults.\n- Pass CompilerOptions to CompilerDriver.\n- Remove CompilerOptions from Runtime.\n- Add ability to pass options for app and image dex2oat to runtime via\n -Xcompiler-option and -Ximage-compiler-option respectively.\n\nOther\n- Replace 2x CompilerCallbacks implementations with one.\n- Factor out execv code for use by both image and oat generation.\n- More OatFile error_msg reporting.\n- DCHECK for SuspendAll found trying to run valgrind.\n\nChange-Id: Iecb57da907be0c856d00c3cd634b5042a229e620\n" }, { "commit": "c06fec227cd8da8b0a8be64f7268322f6b563377", "tree": "bc3a6e3002e79d7e374205207eb8d0bfa6b58098", "parents": [ "a2a5354cd95faf242a70b99b7b11f8fdb7cb7c1b", "815873ecc312b1d231acce71e1a16f42cdaf09f2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 19 18:55:42 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Feb 19 18:55:42 2014 +0000" }, "message": "Merge \"Change root visitor to use Object**.\"" }, { "commit": "21e729c7859ce7909e85d135f6c9e32bbba38860", "tree": "6cb11d1db4e19d4e68a55960e862d7304a41f05a", "parents": [ "2c3458dbda97b70158ee7ef22d13ce473a2a2147" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Feb 18 14:16:00 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Feb 19 09:10:40 2014 +0000" }, "message": "Fix failing check during JDWP invoke.\n\nFixes a race where the JDWP thread expects the invoke thread can be suspended\n(suspend_count !\u003d 0) before invoke thread actually updates its suspend count.\n\nIt happens after the invoke thread signals the JDWP thread to notify invoke is\ncompleted but before incrementing its suspend count. In the meantime, the JDWP\nthread wakes up and checks whether invoke thread has updated its supend count.\nBut there is no way to prevent the JDWP thread to do so before the invoke\nthread updates its suspend count.\n\nWe now move the invoke completion code after the suspend count update. Then the\nJDWP thread wakes up at the right time.\n\nBug: 11247837\nBug: 12578041\nChange-Id: Ib6079c6e330671b34217838e26b1e758706d3da6" }, { "commit": "815873ecc312b1d231acce71e1a16f42cdaf09f2", "tree": "18ba2fa951775e60b240271bfe975e6e2cfc654c", "parents": [ "2befd09cf4fe89a18a655f3e1dd310831bfa769f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Feb 13 18:02:13 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 18 10:45:12 2014 -0800" }, "message": "Change root visitor to use Object**.\n\nSimplifies code and improves the performance of root visiting since\nwe usually don\u0027t need to check to see if the object moved.\n\nChange-Id: Iba998f5a15ae1fa1b53ca5226dd2168a411196cf\n" }, { "commit": "83c8ee000d525017ead8753fce6bc1020249b96a", "tree": "d5167ed15dee2629905ac3640b6ea0578d4ae312", "parents": [ "7cba217ab0661d74deccbb97160cdf60b74d4ea3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 28 14:50:23 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 11 10:40:10 2014 -0800" }, "message": "Add root types and thread id to root visiting.\n\nEnables us to pass the root type and thread id to hprof.\n\nBug: 12680863\nChange-Id: I6a0f1f9e3aa8f9b4033d695818ae7ca3460d67cb\n" }, { "commit": "0aded089f565008ba5908e395e5914ca4f91f2de", "tree": "3b1238d956e0181d00243604c83c3a0be368437d", "parents": [ "98ba6cebd22489c959d845884ee045dcbd958d41" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Nov 07 13:15:11 2013 -0800" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Tue Jan 07 10:58:07 2014 -0800" }, "message": "Add sampling profiler\n\nThis adds a sampling profiler thread that runs every so often, gathering\nprofiling data and writing the results to a file in /data/data (specific to\napp running). The intention is to use these files as input to the compiler\nso that it can determine the best methods to compile.\n\nBug: 11539952\nChange-Id: I0bfbb4146fb7966673c792f017ffac8107b6272d\n" }, { "commit": "5f51d4b80058236759fea1d932470a57f348c199", "tree": "096ce11ba8dc096fd27d2fbed84459080c7d3b1e", "parents": [ "d83d4c86c89357a74e94963994ad0c42ea7299c3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Dec 03 14:24:05 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Dec 05 12:57:43 2013 -0800" }, "message": "Fix races in thread list Unregister.\n\nFirst race:\nWe were releasing the thin_lock_id in Unregister before the thread\nwas not suspended. This could cause problems in\nSuspendThreadByThreadId since there was a small window of time where\ntwo threads could share the same thread id. This race caused an\noccasional check failure in SuspendThreadByThreadId.\n\nSecond race:\nWe were setting the thin_lock_thread_id_ to 0 in Unregister before\nwaiting to not be suspended. This caused another race in\nSuspendThreadByThreadId where we modified the thread suspend count,\nbusy waited, but didn\u0027t find the thread the next iteration. This\nmeant that we were returning null even though we had modified the\nsuspend count. This caused the suspend count to not get decremented\nsince the caller didn\u0027t know that the suspend count had been\nincreased. Removing the self-\u003ethin_lock_thread_id_ \u003d 0 in\nThreadList::UnRegister fixes this race.\n\nAdded a bit of additional checks and logging to prevent these issues\nfrom resurfacing, other misc cleanup.\n\nAdded thread names to threads in ThreadStress.\n\nBug: 11319866\n\nChange-Id: I48e3a0700193b72079e450be1e924a2f88cf52e2\n" }, { "commit": "590fee9e8972f872301c2d16a575d579ee564bee", "tree": "b02db45c72f1911ec896b93379ada0276aea3199", "parents": [ "5b70680b8df6d8fa95bb8e1070d0107f3d388940" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 13 13:46:47 2013 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 11 15:34:27 2013 -0800" }, "message": "Compacting collector.\n\nThe compacting collector is currently similar to semispace. It works by\ncopying objects back and forth between two bump pointer spaces. There\nare types of objects which are \"non-movable\" due to current runtime\nlimitations. These are Classes, Methods, and Fields.\n\nBump pointer spaces are a new type of continuous alloc space which have\nno lock in the allocation code path. When you allocate from these it uses\natomic operations to increase an index. Traversing the objects in the bump\npointer space relies on Object::SizeOf matching the allocated size exactly.\n\nRuntime changes:\nJNI::GetArrayElements returns copies objects if you attempt to get the\nbacking data of a movable array. For GetArrayElementsCritical, we return\ndirect backing storage for any types of arrays, but temporarily disable\nthe GC until the critical region is completed.\n\nAdded a new runtime call called VisitObjects, this is used in place of\nthe old pattern which was flushing the allocation stack and walking\nthe bitmaps.\n\nChanged image writer to be compaction safe and use object monitor word\nfor forwarding addresses.\n\nAdded a bunch of added SIRTs to ClassLinker, MethodLinker, etc..\n\nTODO: Enable switching allocators, compacting on background, etc..\n\nBug: 8981901\n\nChange-Id: I3c886fd322a6eef2b99388d19a765042ec26ab99\n" }, { "commit": "d9c4fc94fa618617f94e1de9af5f034549100753", "tree": "1305efbbc3d4bc306c0947bb6d4b01553667f98e", "parents": [ "7ef126ce0593929bcf8fb73d8b1119ce3b95b3f2" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 01 19:45:43 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 02 09:31:55 2013 -0700" }, "message": "Inflate contended lock word by suspending owner.\n\nBug 6961405.\nDon\u0027t inflate monitors for Notify and NotifyAll.\nTidy lock word, handle recursive lock case alongside unlocked case and move\nassembly out of line (except for ARM quick). Also handle null in out-of-line\nassembly as the test is quick and the enter/exit code is already a safepoint.\nTo gain ownership of a monitor on behalf of another thread, monitor contenders\nmust not hold the monitor_lock_, so they wait on a condition variable.\nReduce size of per mutex contention log.\nBe consistent in calling thin lock thread ids just thread ids.\nFix potential thread death races caused by the use of FindThreadByThreadId,\nmake it invariant that returned threads are either self or suspended now.\n\nCode size reduction on ARM boot.oat 0.2%.\nOld nexus 7 speedup 0.25%, new nexus 7 speedup 1.4%, nexus 10 speedup 2.24%,\nnexus 4 speedup 2.09% on DeltaBlue.\n\nChange-Id: Id52558b914f160d9c8578fdd7fc8199a9598576a\n" }, { "commit": "423d2a3dcbb260b020efb5da59f784c9f02accbf", "tree": "79ed739e6072f8308c1cd880f9420a1c63539c95", "parents": [ "b048dd2b662c19644361f4396a1e8d6213445ee8" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Sep 12 17:33:56 2013 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 13 10:30:24 2013 -0700" }, "message": "Add support for changing roots through the root visitor callback.\n\nNeeded for copying collectors.\n\nChange-Id: Icc4a342a57e0cfb79587edb02ef8c85e08808877\n" }, { "commit": "967a0adf8b93a23d2a8fef82e06bd913db94ac19", "tree": "35b7fbf6eb1899736213e57e11c85d16c1b4853e", "parents": [ "af3994db1b42929666b6a50c3c4b237a25c99951" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Sep 10 16:24:21 2013 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Sep 11 15:38:23 2013 -0700" }, "message": "More allocation code optimizations.\n\n- Inline Class::AllocObject() and Array::Alloc().\n- Inline some short Mutex functions and add LIKELY/UNLIKELY to some\n Mutex functions.\n- This change improves the Ritz MemAllocTest by ~6% on Nexus 4 and\n ~10% on host.\n\nBug: 9986565\nChange-Id: I1606c74ddb21676cbc1de1a40e9b076fc23eaea4\n" }, { "commit": "02e25119b15a6f619f17db99f5d05124a5807ff3", "tree": "7be4cbbf28033e5ee0621565b410fe5d8170a8fb", "parents": [ "7d70a7932f0ba09eb01a93caab060aef1403d4e6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Aug 14 16:14:24 2013 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Aug 16 13:15:37 2013 -0700" }, "message": "Fix up TODO: c++0x, update cpplint.\n\nNeeded to update cpplint to handle const auto.\n\nFixed a few cpplint errors that were being missed before.\n\nReplaced most of the TODO c++0x with ranged based loops. Loops which\ndo not have a descriptive container name have a concrete type instead\nof auto.\n\nChange-Id: Id7cc0f27030f56057c544e94277300b3f298c9c5\n" }, { "commit": "7934ac288acfb2552bb0b06ec1f61e5820d924a4", "tree": "43f3acd8af7fd34d4ae7b64f6e06bb8429d74bb8", "parents": [ "fb331d7ca004f39608fcfdae49d38df90c702ea9" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 10:54:15 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 11:55:10 2013 -0700" }, "message": "Fix cpplint whitespace/comments issues\n\nChange-Id: Iae286862c85fb8fd8901eae1204cd6d271d69496\n" }, { "commit": "df62950e7a32031b82360c407d46a37b94188fbb", "tree": "038bf95a2ce296ae3e0c30a131ac22c0986f0f52", "parents": [ "0cd7ec2dcd8d7ba30bf3ca420b40dac52849876c" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 22:39:56 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu Jul 18 00:13:18 2013 -0700" }, "message": "Fix cpplint whitespace/parens issues\n\nChange-Id: Ifc678d59a8bed24ffddde5a0e543620b17b0aba9\n" }, { "commit": "7940e44f4517de5e2634a7e07d58d0fb26160513", "tree": "ac90242d96229a6942f6e24ab137bc1f8f2e0025", "parents": [ "5cd9e3b122f276f610980cbaf0d2ad6ed4cd9088" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 13:46:57 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 17:49:01 2013 -0700" }, "message": "Create separate Android.mk for main build targets\n\nThe runtime, compiler, dex2oat, and oatdump now are in seperate trees\nto prevent dependency creep. They can now be individually built\nwithout rebuilding the rest of the art projects. dalvikvm and jdwpspy\nwere already this way. Builds in the art directory should behave as\nbefore, building everything including tests.\n\nChange-Id: Ic6b1151e5ed0f823c3dd301afd2b13eb2d8feb81\n" }, { "commit": "9a916d3c0d0574d106c764e737c67b52988d6139", "tree": "759e3f6152e80ad08ba220692d30252c1f10bf7e", "parents": [ "0b4e3ef67508a0b8c121b6b26ab5ea0a1d8e7141" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Thu Jun 27 18:45:37 2013 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Jul 02 14:12:36 2013 -0700" }, "message": "Add marks for instrumentation frames that get interpreted.\n\nDuring instrumentation, if a method goes to the interpreter, a special callee-\nsave ref and args method frame is pushed onto the stack, instead of a frame for\nthe method being called. This change adds a bool to mark methods that end up\ninterpreted, so things that walk the stack know to look for the callee-save\nmethod instead.\n\nAlso included is a change to UnsafeLogFatalForThreadSuspendAllTimeout to prevent\nit from grabbing locks before dumping. This was breaking DumpLocked, which\neventually gets a ScopedObjectAccessUnchecked requiring those locks not be held.\n\nChange-Id: I7e68cf195c77f40df6f497551c94b0926d3c5065\n" }, { "commit": "9754368bff3103f47df0c31fd389af7bcca0c54c", "tree": "183584ca545820825044f200be7001ff39ce88e4", "parents": [ "d457d8a5542aacfb497790a0c648c7e34f1e4f69" ], "author": { "name": "Anwar Ghuloum", "email": "anwarg@google.com", "time": "Fri Jun 14 12:58:16 2013 -0700" }, "committer": { "name": "Anwar Ghuloum", "email": "anwarg@google.com", "time": "Fri Jun 14 13:23:28 2013 -0700" }, "message": "Removed haspeer check and changed small method default limit\n\nThis check appears unecessary and is causing monkey failures. The race condition\nthis is supposed to work around doesn\u0027t appear to exist in this instance as the\nthread_list_lock_ is held. This might be related to b/8050919. Tested on a Nexus\n4: phone booted, multiple apps tested.\n\nAlso, updated the small method limit size to a value determined by shmooing a well\nknown benchmark.\n\nBug: 8050919\nChange-Id: I0d98624926b830953af7136f43f0e2b57d930a99\n" }, { "commit": "0878d654e7be8c9666579e22522704d8887415cc", "tree": "0e57c50e7f47a01900e540c0b5e509df4297afed", "parents": [ "f8adc60455b90c95a6a3c8f87830e4e88b2644e1" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Apr 18 17:38:35 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Apr 18 17:42:02 2013 -0700" }, "message": "Thread tidying.\n\nAdd is_started_ boolean to Thread so that we don\u0027t read an uncreated\npthread_key_self_, don\u0027t start twice or call shutdown when not started.\nDon\u0027t use a MutexLock in ThreadList::Unregister, as the MutexLock will\nhold a copy of self for the thread that\u0027s deleted.\nDon\u0027t memory leak the resume condition variable.\n\nChange-Id: I767968a9f785e560fc9e356a339e684de5ce2ffc\n" }, { "commit": "a84395489098e4531619b1cffd1afc282b14510e", "tree": "f326a29ddb0c1b2f211484c6192f185a2698260e", "parents": [ "addf1a8da2ece5ee9d6747a176f960ab7291f718" ], "author": { "name": "Sameer Abu Asal", "email": "sasal@google.com", "time": "Thu Feb 14 16:06:42 2013 -0800" }, "committer": { "name": "Sameer Abu Asal", "email": "sasal@google.com", "time": "Tue Feb 19 15:13:46 2013 -0800" }, "message": "Using histograms for timing statistics.\n\n Histogram class and test cases added.\n Modified make file to add test cases and class file.\n Added a guard to avoid race condition in Cumulative logger that\n was possible race between Addlogger and Dump() functions.\n\nChange-Id: I060a0d65648c7120963856624e7008c0aa681eb7\n" }, { "commit": "2dd0e2cea360bc9206eb88ecc40d259e796c239d", "tree": "9d619dc9508cbe73e4793bf6f08cbc761abfb48a", "parents": [ "ac21b797b3a425975d656d6b84a7b24401d35f42" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jan 24 12:42:14 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jan 30 16:48:31 2013 -0800" }, "message": "Directory restructuring of object.h\n\nBreak object.h into constituent files.\nReduce number of #includes in other GC header files.\nIntroduce -inl.h files to avoid mirror files #include-ing each other.\nCheck invariants of verifier RegTypes for all constructors.\n\nChange-Id: Iecf1171c02910ac152d52947330ef456df4043bc\n" }, { "commit": "f327e07b37e349b1ec5eaad6dc294a9b7a081d20", "tree": "2c64b1f6212045a529c18d1dbe04b3da8fd1d6e9", "parents": [ "9e0c175a0cea5c8c88a6927e6375554118f74a82" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 16:01:26 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 18:07:12 2013 -0800" }, "message": "Implement ObjectReference.MonitorInfo.\n\nChange-Id: Iefc276939b9e569f4ea4d7a5af9a28276a3fb632\n" }, { "commit": "76b6167407c2b6f5d40ad895b2793a6b037f54b2", "tree": "5c433a0907ddf401f4078b6703253b1ae75e723e", "parents": [ "f66330a747eff155eb571b634fc9d901c55a78a7" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Dec 12 17:47:30 2012 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Dec 12 18:11:44 2012 -0800" }, "message": "Move mutex.h into base/mutex.h.\n\nWe don\u0027t actually need any hackery to get the right mutex.h any\nmore, but since we planned on having the google3-like stuff\nin google3-like locations, this is an easy one to fix.\n\nChange-Id: Ie27464ebbc208a6f4e694a97cf26b1cee0737009\n" }, { "commit": "a77f0f68a59870ff027dad654fe31eb3fdaf3d5d", "tree": "c041a68efb55db65ab8f195938097a887f5fcc01", "parents": [ "a169e1d8d968800380245cda450505d969ebff76" ], "author": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Wed Dec 05 17:19:31 2012 -0800" }, "committer": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Thu Dec 06 10:14:46 2012 -0800" }, "message": "Various fixes for JDWP.\n\n- Moved lock of thread list lock into DecodeThread from its callers\n- Fixed scope of various locks to prevent locking violations\n- Added transition for current thread from runnable to suspended before\n suspending vm, and then a transition back\n- Reworked lock ordering to allow JDWP locks to be held while grabbing\n the thread list lock\n- Moved debugger PostException until after suspension is re-allowed\n\nChange-Id: Ie53e47ff1538e6cd3125c48ddb4c13758b29be63\n" }, { "commit": "cfaa455374aae0a08c8cb28b5bb306b17866d652", "tree": "ca8f25a06f234385b6e62bb774085f1324e5d519", "parents": [ "3676aeb03d5f70933891bb3b21abb8e31a81e36c" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Nov 26 21:00:08 2012 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Nov 30 16:38:21 2012 -0800" }, "message": "Turn the thread peer_ into a Object*.\n\nDon\u0027t use a JNI global ref for the thread peer_ so that we can\nsupport more threads than we can global refs. This fixes run-test 51.\nFix a race in thread destruction where a thread may be requested to\nsuspend while deleting itself.\n\nChange-Id: Id8756a575becf80d2a0be0a213325034556927f1\n" }, { "commit": "2b82db45c09450022199376c3a5420eacf2aa81e", "tree": "b9561fc19d2826a2b08997fcaef84eadbbeb252c", "parents": [ "2eb840353822092d542361c8d6c4938acfddee8e" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 14 17:29:05 2012 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 20 11:58:23 2012 -0800" }, "message": "Refactor GC to have a class for each different type of GC.\n\nAdded a seperate files for mark sweep, partial mark sweep,\nsticky mark sweep.\n\nAdded a common superclass for GC.\n\nAdded additional statistics for each GC.\n\nMoved main garbage collection code away from Heap.cc.\n\nChange-Id: Ida0021ab2f740fc8228bbbf4d43cd9bc56b4ba46\n" }, { "commit": "725a957985171d712d5c048cc3d00ff14968784b", "tree": "3bd4b161268ecd477aa471665316fb27a3dda145", "parents": [ "35883cc623fdf475a4ead1dafcba9e9becc1ed11" ], "author": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Tue Nov 13 18:20:12 2012 -0800" }, "committer": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Wed Nov 14 11:42:33 2012 -0800" }, "message": "Pulled out instrumentation into its own class separate from trace.\n\nThis is in preparation for Ian\u0027s debugger changes. The instrumentation\nstill needs support for debugging, which I\u0027ll add later.\n\nChange-Id: I29ce0af1ff2eaec8f6d2f54963263381363ebf72\n" }, { "commit": "664bebf92eb2151b9b570ccd42ac4b6056c3ea9c", "tree": "783a4492b398078e8d5747f19f6019e91939c986", "parents": [ "d22d54849c96760aa1efa259d6dcfbace54da2af" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 12 16:54:11 2012 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Nov 12 17:37:38 2012 -0800" }, "message": "Fix occasional deadlock caused by checkpoint root marking.\n\nThere was a race where a new worker thread would attach during the\ncheckpoint. This caused the thread to wait since suspend count !\u003d 0.\nBut when we decremented the suspend count, we did not broadcast to\nthe resume condition.\n\nAdded a create peer parameter to Thread::Attach and\nAttachCurrentThread. This is used by the threadpool since we don\u0027t\nneed a java peer for worker threads.\n\nChange-Id: I632926b5a6b52eeb0684b6e1dcbf3db42ba3d35c\n" }, { "commit": "bcc2926b9721f94c17ed98fae5264cc98f0e066f", "tree": "ebc059463499b973804d52e0bba593a12cd0326e", "parents": [ "af6eaca5034a602f459a6eca9fb185f3abe8a882" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Nov 02 11:36:03 2012 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Nov 02 17:00:27 2012 -0700" }, "message": "Add dex2oat watch dog thread for host builds\n\nChange-Id: I90b4b6b3a1aebb82955b4aa84d3f2d599af1d13b\n" }, { "commit": "4696b5b20be2f51f4ada5f3771a205d90bff351d", "tree": "bd7997a797ce91bf3ebb53ca8df35a0e7040bf51", "parents": [ "6e30145f1ed992be8d4e5a9973410c19f3de59f9" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 30 10:35:10 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 30 10:39:55 2012 -0700" }, "message": "Fix art usage of readdir_r(3).\n\nChange-Id: Ieb8c90c8bd9b9b9cf075519992d4156b0ca6273b\n" }, { "commit": "0e4627e593bc39f8e3d89c31f8977d55054c07cc", "tree": "1d69558732c0c916e51a530985a26d4235ef0e6c", "parents": [ "9281f004db3f194930ef34d31e5d80c98341f38f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 23 16:13:36 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Oct 26 12:00:03 2012 -0700" }, "message": "Add thread pool class\n\nAdded a thread pool class loosely based on google3 code.\n\nModified the compiler to have a single thread pool instead of creating new threads in ForAll.\n\nMoved barrier to be in top level directory as it is not GC specific code.\n\nPerformance Timings:\n\nReference:\nboot.oat: 14.306596s\ntime mm oat-target:\nreal 2m33.748s\nuser 10m23.190s\nsys 5m54.140s\n\nThread pool:\nboot.oat: 13.111049s\ntime mm oat-target:\nreal 2m29.372s\nuser 10m3.130s\nsys 5m46.290s\n\nThe speed increase is probably just noise.\n\nChange-Id: If3c1280cbaa4c7e4361127d064ac744ea12cdf49\n" }, { "commit": "858f1c5fd5e528d0b16040ced74d4636046a42d8", "tree": "3cfe50b75962353cdd62ec68112f3f148f026506", "parents": [ "ef851d3058abfc56ed544f25d387dc7ff9c32e0b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 17 17:45:55 2012 -0700" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Tue Oct 23 10:38:45 2012 -0700" }, "message": "Check point root marking.\n\nAdded thread list checkpoint function, this goes through every thread and runs\nthe checkpoint on each thread. Threads that are runnable run the checkpoint\ncallback themselves in the next suspend check, while suspended threads are\nleft suspended but have the callback called on them.\n\nAdded a checkpoint visitor member to each thread, this visitor called when the\ncheckpoint request flag is set during transitions to suspended from runnable.\n\nUsing the checkpoint to mark the roots reduces the first pause of partial /\nfull gc to around 1 ms.\n\nChange-Id: I97239cc72ee0e4a3397e9138a62ee559268dce0a\n" }, { "commit": "7e762861d644c1554f42b49bc4f8668c3b3c3eaa", "tree": "f605d68f8ef144238af6a096c421842bd4db257a", "parents": [ "63af6361337cc9b5c75ae55405b45d770c5a3b08" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Oct 22 15:45:08 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Oct 22 15:45:08 2012 -0700" }, "message": "Dump failing thread if IsDaemon check fails.\n\nChange-Id: I93b5ba426c086343533e3ef022498e47d50503c8\n" }, { "commit": "fbd229147c62d8e8787e27e7c9db3b387ffe39ef", "tree": "f19776e3edde3c635a7343ca942722a87ba46b62", "parents": [ "c604d731730b43231f63040c8db1d58304da0cf3" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 12 14:21:10 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Oct 15 16:36:07 2012 -0700" }, "message": "Attempt to always dump all threads when aborting.\n\nFurther pursuit of Bug: 7250540\n\nChange-Id: I99628aa4f5666339b372ab8948d3303ad9687eae\n" }, { "commit": "c604d731730b43231f63040c8db1d58304da0cf3", "tree": "bb9cd6aa56eb3ba88ff27967efc3cc08da150b87", "parents": [ "0b0b515934b83385e1cea448113783e0b22849ed" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sun Oct 14 16:09:54 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Oct 15 15:36:32 2012 -0700" }, "message": "Implement mutex requeueing for cv broadcasts.\n\nMake the mutex guarding a condition variable part of its state. On a\nbroadcast requeue waiters on the mutex so they are awoken as the mutex\nis unlocked (thereby avoiding thundering herds). Explicit futex use\nstill guarded behind ART_USE_FUTEXES which remains disabled as I\u0027m\nunhappy with some of the warts of mutex usage. Uploading so that the API\nchanges can stabilize.\n\nChange-Id: Iedb601856ccd8bbc3a64da4ba0cee82246e7bcbf\n" }, { "commit": "6f1c94968ada57da433debf8e2d1b38a80ceb510", "tree": "3628c7d9f5273d2c83dd7c6f9e816816eed8b70a", "parents": [ "0051be6d118c511308ed7764ef41e0d594292c49" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 15 12:08:41 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Oct 15 12:37:33 2012 -0700" }, "message": "Add root verification when we try to mark an invalid object.\n\nNow when we try to mark an object not contained by any spaces, We call verify\nroots. This prints the root\u0027s vreg and method when it finds an invalid root.\n\nFixed a error in the total paused time statistic.\n\nChange-Id: Id10e4097cce56bc54ee488de32183c18ba3f3780\n" }, { "commit": "50b35e2fd1a68cd1240e4a9d9f363e11764957d1", "tree": "4f3c58b7b293380f19e4f33357cb352e3330772e", "parents": [ "8e9a1497f0d7da4d55f6e7ed8a7d96ba6db7222d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 04 10:09:15 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 05 11:07:39 2012 -0700" }, "message": "Explicitly pass Thread::Current to MutexLock and Alloc.\n\nChange-Id: I8b75bc0617915465f102815b32306aa7760dcae4\n" }, { "commit": "120f1c74a9768e958377b6c97897511b27ae58c8", "tree": "fa1f90d88ea34d8ef9eec729d27c7a70956a6a09", "parents": [ "cabc60e71a65fa17e5a99fba94fc61523fbeb478" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 17:17:10 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 03 17:29:26 2012 -0700" }, "message": "Fail threads attaching during runtime shutdown.\n\nIntroduce counters to indicate that threads are being born. Don\u0027t allow\nthread birth to occur during runtime shutdown.\n\nBug: 7000936\n\nChange-Id: Ib0d78f78c0ff126a4b5d3b5a6f1a2ff8f5061ae9\n" }, { "commit": "01ae5808367e641a983e3f8bb82b3e0d364cd03e", "tree": "34ce5f4f5a9405f8270d623571a058dcd993fd39", "parents": [ "a75a01313e801c53145df00bad1842d9f643c0a1" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 16:14:01 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 28 16:14:01 2012 -0700" }, "message": "Fix race in thread attaching during GC.\n\nForgot to mask in suspend request if thread is attaching during GC.\nLots of extra assertions and debugging.\n\nChange-Id: Id4d2ab659284acace51b37b86831a968c1945ae8\n" }, { "commit": "81d425b0b232962441616f8b14f73620bffef5e5", "tree": "cd1e46656269acf20e78817d675e56d9b9133e6c", "parents": [ "bfaf917edbb1de8d158c3615e0da8ac3143d10c8" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Sep 27 16:03:43 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Sep 27 17:19:25 2012 -0700" }, "message": "Pass self to lock methods.\n\nThis avoids frequent recomputation of\nThread::Current/pthread_getspecific.\n\nAlso add a futex based reader/writer mutex that is disabled.\n\nChange-Id: I118fdb99ef1d1c4bfda6446ba3a0d8b6ab31eaee\n" }, { "commit": "474b6da273c7ce6df50a4e51eb9929a77e1611c3", "tree": "b67074e7e4c16e01384c2f7d416f4e4ad3b3bd61", "parents": [ "de1ef40bd5f344dbb0bdb68f555f45868f502ae6" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Sep 25 00:20:38 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Sep 25 17:01:42 2012 -0700" }, "message": "Move thread flags and state into 32bits.\n\nWe need to ensure that transitions to Runnable are atomic wrt to a\nthread modifying the suspend count. Currently this is achieved by\nholding the thread_suspend_count_lock_. This change creates a set of bit\nflags that summarize that the suspend_count_ is raised and also others\nflags that signify the managed code should go into a slow path.\n\nThe effect of this change are two-fold:\n1) transitions from suspended to runnable can CAS the thread state\nrather than holding the suspend_count_lock_. This will make JNI\ntransitions cheaper.\n2) the exception/suspend/interpreter poll needed for shadow frames can\nbe rolled into a single compare of the bit fields against 0.\n\nChange-Id: I589f84e3dca396c3db448bf32d814565acf3d11f\n" }, { "commit": "b726dcb581bf72da46527378ccb6889020f0e6e9", "tree": "c0383ed788652926e93147e50d659ed226519548", "parents": [ "fd678beb171a4686a4f2d53ca4188a4ade8fa54e" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 08:57:23 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 09:06:19 2012 -0700" }, "message": "Rename GlobalSynchronization to Locks\n\nAlso address some review comments in common_throws relating to\nToStr\u003cInvokeType\u003e and exception detail messages.\n\nChange-Id: Ibf2c0f147689fa236d349bd7f01eed3c2522552b\n" }, { "commit": "66aee5cd571cf4739d2735769304202ea5051fb8", "tree": "0fd162020be916dc358550ff376fd3706d0a14dd", "parents": [ "a5acfd318d46c4720bb9b25181021ee7471b6be9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Aug 15 17:17:47 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Aug 15 17:17:47 2012 -0700" }, "message": "Mac build fix. Macs don\u0027t support timeouts on locks.\n\nChange-Id: I75665300d9b99420972865109026c8c090748cef\n" }, { "commit": "00f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abac", "tree": "6a2172ece15c4699e6c2a67ce76f019db0a9a21d", "parents": [ "634ea28f78c4a138e6a1de54eae8696095422415" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 19 15:28:27 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 14 10:45:52 2012 -0700" }, "message": "Global lock levels.\n\nIntroduce the notion of the mutators/GC being a shared-exclusive (aka\nreader-writer) lock. Introduce globally ordered locks, analysable by\nannotalysis, statically at compile time. Add locking attributes to\nmethods.\n\nMore subtly, remove the heap_lock_ and split between various locks that\nare held for smaller periods (where work doesn\u0027t get blocked). Remove\nbuggy Dalvik style thread transitions. Make GC use CMS in all cases when\nconcurrent is enabled. Fix bug where suspend counts rather than debug\nsuspend counts were sent to JDWP. Move the PathClassLoader to\nWellKnownClasses. In debugger refactor calls to send request and\npossibly suspend. Break apart different VmWait thread states. Move\nidentity hash code to a shared method.\n\nChange-Id: Icdbfc3ce3fcccd14341860ac7305d8e97b51f5c6\n" }, { "commit": "ed8b723c5f3989d2593ec21c65c96d6d8bf25579", "tree": "4fd6fbbb708c66765a9209f5b3053be11bf787c9", "parents": [ "afe25515c358617321d69ab4f25003e3d905d613" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jun 27 17:54:47 2012 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jun 27 17:56:07 2012 -0700" }, "message": "Disable dumping native stacks of unattached threads\n\nChange-Id: I2023da6ff06faad8cf70b5acd614af3388d5ec06\n" }, { "commit": "c61a267e98ed1038b74c33c7740414ced4a27d89", "tree": "48db3cf7fba36f71964f21755f38ebe35c4c21fa", "parents": [ "a21039c3ae2b20e44ceb2735251c04d0aac89afd" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 21 14:52:29 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 21 14:52:29 2012 -0700" }, "message": "Use UndoDebuggerSuspensions for JDWP ResumeVM rather than weakening ResumeAll\u0027s checking.\n\nChange-Id: I3ba71fb9e84664f130dd29ba8c13a8e1b6c18e46\n" }, { "commit": "546b986ecd09c2a498740bd8bf7127e612d94755", "tree": "ce2dfd24317d27929ae549202bc3bbe6ec282245", "parents": [ "4d999fe696d43de5872f7be293e8a749cb69beaf" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 20 16:06:13 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 20 16:06:13 2012 -0700" }, "message": "Fix a couple of JDWP bugs.\n\nA couple of JDWP tests started failing when we made \"thread suspend\ncount is already zero\" into a fatal error. This patch makes the debugger\na bit more careful about doing silly things (the JDWP protocol defines\nthese silly things as no-ops, and it\u0027s surprisingly easy for an end\nuser to get us into this state; just sit typing \"resume\" at the jdb(1)\nprompt, for example).\n\nI\u0027ve also tidied up GetObjectTag to return an error on failure, but\nthat isn\u0027t the fix to any bug the tests find. (The only remaining JDWP\nbugs are all caused by an inability to cope with register promotion,\nand we\u0027re already working on the proper fix for that.)\n\nChange-Id: I671f62234b5cb41aa9d86c6b947c518d7c068800\n" }, { "commit": "f8349361a16a4e2796efe9f3586b994e8d4834e4", "tree": "0a3474cde4028e1915c59393f49c147dd76ad766", "parents": [ "44335e189951a863607049a33571932fb6a2a841" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Jun 18 15:00:06 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Jun 18 15:16:21 2012 -0700" }, "message": "Use static thread safety analysis when available, and fix the bugs GCC finds.\n\nIt\u0027s impossible to express the Heap locking and the ThreadList locking with\nGCC, but Clang is supposed to be able to do it. This patch does what\u0027s possible\nfor now.\n\nChange-Id: Ib64a890c9d27c6ce255d5003cb755c2ef1beba95\n" }, { "commit": "6cf23884730574ca364b357e823259f4993e6908", "tree": "50ad618096847b2dfe423ece38246891870c84ce", "parents": [ "cee4d0c1c2faacf0eae748a24cc7e455e067d977" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jun 15 15:42:07 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jun 15 15:42:07 2012 -0700" }, "message": "Simplify the default stack size handling.\n\nThe extra 16KB was just silly. We only need a notion of \"default stack size\"\nif there\u0027s an explicit command-line override.\n\nChange-Id: Ia63e00047a420546656ac8d2dad46789994157a3\n" }, { "commit": "7664f5cd118b355a5fe0c7536cb48ac991ed2b62", "tree": "0564c36316e2aa0a892ff9914258433f14641a07", "parents": [ "9eb5f03e0dd90ac25e01fcf81f832c50a1f09d2c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jun 08 18:15:32 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 11 11:17:13 2012 -0700" }, "message": "Fix GC performance regression\n\nEnable CMS and fix performance regression due to recursive marking image spaces. Dependent on my java change list.\n\nChange-Id: I4765792aa8226e811ac158f04ab88217db755573\n" }, { "commit": "0d39c12238499ca9ccc34d1532c443335e7c1044", "tree": "78a6befc07c5f24691234759eb2a8ddb488d0ef1", "parents": [ "ebe2e0f2e5145ef8433c1459b9cd60ecd853ee76" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 06 16:41:17 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 06 17:31:26 2012 -0700" }, "message": "\"InitGoogle\"-style argv stashing.\n\nThis lets us give the command line in crash dumps when dex2oat dies in the\ncontinuous build on the Mac. I\u0027ve also taken the opportunity to use the\nbasename of argv[0] as the default log tag, so dex2oat will now show up in\nlogcat as \"dex2oat\" instead of \"art\" (and we can probably stop manually\nprefixing dex2oat log output).\n\nAlso stash pthread_self() so we can _correctly_ report \"handle\u003d\" in the\nSIGQUIT output.\n\nChange-Id: Ia8249cd19bab5b816cb94a531a65becdfacaa98b\n" }, { "commit": "abbe07d095547ded03c2e9d0d53943d43471278d", "tree": "f63555369a0e40574ee30ff634904e5eb3a467b5", "parents": [ "2ab7f486ba73b2846bdbdde65cc2d41f62a26015" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jun 05 17:42:23 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jun 05 17:42:23 2012 -0700" }, "message": "Include non-attached native threads in the SIGQUIT output.\n\nThese threads look something like this:\n\n \"droid.phasebeam\u0027 prio\u003d5 tid\u003d? (not attached)\n | sysTid\u003d5369 nice\u003d-4 sched\u003d0/0 cgrp\u003ddefault\n | schedstat\u003d( 0 0 0 ) utm\u003d1 stm\u003d8 core\u003d0 HZ\u003d100\n native: __futex_syscall3+8 [0x40074678] (libc.so)\n native: __pthread_cond_timedwait_relative+48 [0x40079474] (libc.so)\n native: __pthread_cond_timedwait+72 [0x40079528] (libc.so)\n native: android::renderscript::Signal::wait(unsigned long long)+58 [0x418bf117] (libRS.so)\n native: android::renderscript::LocklessCommandFifo::wait(unsigned long long)+38 [0x418bab97] (libRS.so)\n native: android::renderscript::LocklessCommandFifo::get(unsigned int*, unsigned int*, unsigned long long)+22 [0x418babbb] (libRS.so)\n native: android::renderscript::ThreadIO::playCoreCommands(android::renderscript::Context*, bool, unsigned long long)+126 [0x418bf84b] (libRS.so)\n native: android::renderscript::Context::threadProc(void*)+382 [0x418b7347] (libRS.so)\n native: __thread_entry+48 [0x40079d30] (libc.so)\n native: pthread_create+180 [0x40079884] (libc.so)\n\nAlso fix running tests on Mac OS, which has no /proc/self/cmdline.\n\nChange-Id: Ib5e6f7e23dd45aecdf814e84f573361a5d91bac6\n" }, { "commit": "d237a3865c8c0c623fa5902b4927d95c77f85c38", "tree": "0f600df8563c06a7b225591d97e62b67e1bd75dd", "parents": [ "9af209c9dcc6763fae2976981570a90aa41fd86b" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Jun 01 08:53:29 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sun Jun 03 20:59:16 2012 -0700" }, "message": "Extra suspend count modification failure logging.\n\nChange-Id: I18738c94f8abe7afec588f7b91685e2cbdf7eefc\n" }, { "commit": "7dc5166ea740359d381097a7ab382c1dd404055f", "tree": "8b429913befc8ad0bf8e7e2247e0ec8ef684aaa6", "parents": [ "0aac50652ef961ba3aafa44d43871190d23be1ce" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed May 16 14:48:43 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed May 16 14:52:35 2012 -0700" }, "message": "Improve our check for whether a thread is still starting up.\n\nIt turns out that there was a race in Thread::Create that could confuse our\nsuspend-count sanity checking. Tested by manually inserting a sleep(3) there.\nI could have added an extra field to Thread, but since we only need to check\nthis once if we do a GC while a thread is still starting up, a simple string\ncomparison will be fine.\n\n thread_list.cc:79] Thread[10,tid\u003d7447,VmWait,Thread*\u003d0x00d23060,peer\u003d0x60f1b350,\"\u003cnative thread without managed peer\u003e\"] suspend count already zero\n\nI\u0027ve also added some logging so we\u0027ll be nagged to remove a work-around for\na bionic bug when we\u0027re in a tree where the bionic bug is fixed.\n\nChange-Id: I78ac3c58245c1ecff3e86dcf297b94ae0085f7a2\n" }, { "commit": "c967f78cd29b6019f7cfca40a02e9b677112da70", "tree": "60458d56fc398c9fb7b67b6d834b85f626ac2b31", "parents": [ "fd8ea97f64fb6d32cbfe35729b816a22dfa18224" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 16 10:23:15 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 16 10:23:15 2012 -0700" }, "message": "Include a new heap summary line in the SIGQUIT output.\n\nLooks like this:\n\n Heap: 87% free, 4MB/32MB; 6327 objects\n\nWhile I\u0027m here, fix another long-standing TODO to make PrettySize have the\nusual google3 behavior. (I took the specific thresholds from Chromium.)\n\nAlso distinguish between the more general \"Dump\" member functions and the\nspecific SIGQUIT-related ones by consistently calling the latter DumpForSigQuit.\n\nChange-Id: I76e783adc18dd089bac9b348f53dc9860a0fe4b9\n" }, { "commit": "05c87bea99bbabc36d0db569af735f9459ad8f1a", "tree": "44de8f5a2ceae2f2195465184d7eee4605c65f7f", "parents": [ "460af054a1a90d0d948081ba3d3d82f675a6f7a3" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Apr 10 11:58:17 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Apr 10 11:58:17 2012 -0700" }, "message": "We might try to suspend a thread even before it\u0027s hit kStarting.\n\nNot (yet) having a peer is also an indication we don\u0027t care and shouldn\u0027t FATAL.\n\nChange-Id: I8a401a9ee99c513ac61b0fdab086db340b89239b\n" }, { "commit": "34e069606d6f1698cd3c33b39e72b79ae27e1c7b", "tree": "0feb7e9bde6cfe01c0df3ef2d8de3210570f7ce2", "parents": [ "e62934d85fbc2d935afdad57eeade39ecbd7440a" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 09 13:55:55 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 09 13:55:55 2012 -0700" }, "message": "Remove the useless \"suspend count already zero\" message for new threads.\n\nWe can actually detect the expected case of this warning ourselves, and\nnot emit it. Then we can upgrade the WARNING to a FATAL.\n\nI also tripped over the fact that the operator\u003c\u003c for Thread::State was out\nof date, so I\u0027ve moved the Thread enums up to namespace scope so the script\ncan automatically generate correct operator\u003c\u003c implementations for us. (All\nthe high-numbered thread states have been off by one for a couple of weeks.)\n\nChange-Id: I5de573d33d641e5a3cba87b370e9620c8c66e633\n" }, { "commit": "e62934d85fbc2d935afdad57eeade39ecbd7440a", "tree": "4792b15a3e58728d85adeed068d08d7e0dbfb67f", "parents": [ "b0aa9d313b2cc36a0b6420266131631bee2da807" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 09 11:24:29 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 09 11:26:39 2012 -0700" }, "message": "Like Mutex, failure to destroy a ConditionVariable on shutdown is a special case.\n\nChange-Id: Id9b710a4676169abab5eabb0603947e599012be3\n" }, { "commit": "409d273a3a57158faaa520ff5f33508367f759f1", "tree": "6f57ebaf4c92669dcc60d95c8c28688d6041efb6", "parents": [ "6a144338023bdc0ca6954fc71a1f9b4d94088ee4" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Apr 03 13:34:44 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Apr 03 13:34:44 2012 -0700" }, "message": "Be consistent about \"kilo\" versus \"kibi\".\n\nI\u0027m a binary man myself, but we\u0027ve mostly used decimal so far, and wider\nAndroid is mostly decimal, so...\n\nChange-Id: Ibef78f61176569e0023a7f43196a3969c7fe794b\n" }, { "commit": "6a144338023bdc0ca6954fc71a1f9b4d94088ee4", "tree": "51efa8edbf277f2fa73f7e21b36fec4cb1a3339d", "parents": [ "cb67388650ac7cedfc80b524adebd595147d4d3f" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Apr 03 13:07:11 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Apr 03 13:07:11 2012 -0700" }, "message": "Switch to Thread::WalkStack rather than manual Frame::Next.\n\nAlso fix test 039.\n\nChange-Id: I07d0559bb86d67a7f7947768bd8370fb4cf06c26\n" }, { "commit": "e52e49b32f5cf862a414da63e5dbd2eb04ad758e", "tree": "582296bc89fcb3ca475260abba8e9b3d6fc2f39d", "parents": [ "2d62a0e4ae6b528648c585aa804569aaefc4c517" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 02 16:05:44 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Apr 02 16:05:44 2012 -0700" }, "message": "Fix the mutex diagnostics, and other targets of opportunity.\n\nThree changes for the price of one:\n\n1. Fix the mutex diagnostics so they work right during startup and shutdown.\n\n2. Fix a memory leak in common_test.\n\n3. Fix memory corruption in the compiler; we were calling memset(3) on a struct\nwith non-POD members.\n\nThanks, as usual, to valgrind(1) for the latter two (and several bugs in\nearlier attempts at the former).\n\nChange-Id: I15e1ffb01e73e4c56a5bbdcaa7233a4b5221e08a\n" }, { "commit": "398f64b5805246765b699839b439e18c0dfbf2ee", "tree": "de3f86de82289b1734b12cdc7c4292f4aff16f55", "parents": [ "ee0fa76b2e5d39ad36d1ff144b2d0270df81e606" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 18:05:48 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 18:05:48 2012 -0700" }, "message": "Remove more lint, mostly C-style casts.\n\nChange-Id: Iaf1f23290e35ed48e5795fb20690953a9a834457\n" }, { "commit": "c0f0933249cf516b37717faa766e1e9808f7c1f8", "tree": "04aedbf3e8502637673b82cf181dfab1b5aca1a6", "parents": [ "942df41c03ddb9f7b47a34fcfc4414d8b8ca8ce1" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 13:27:06 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 13:27:06 2012 -0700" }, "message": "Add the missing link between compiled code and the debugger.\n\nWhen a debugger connects and disconnects, we now let compiled code know that we\nneed to be kept informed about what\u0027s going on.\n\nAlso fix a threading bug when threads exit with a debugger attached.\n\nAlso some minor tidying, mostly involving naming.\n\nChange-Id: Iba0e8b9d192ac76ba1cd29a8b1e6d94f6f20dea8\n" }, { "commit": "88c5c355fc3d881f905564911d746b2313d5fc89", "tree": "d5b11b85131064cb6200465e674060933f48ebd7", "parents": [ "141b0c75986949da0adbf9c07ad92bc675f1bfed" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 15 18:49:48 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 15 21:14:57 2012 -0700" }, "message": "Make CheckJNI and JNI workarounds mutually exclusive...\n\n...in the opposite direction; needing workarounds turns off CheckJNI.\nThis isn\u0027t necessarily a good idea, but I like the cleanup parts of\nthis change.\n\nChange-Id: I708235ea3e5cc35ef90b01dd810e097e3ff9dd26\n" }, { "commit": "b3bd5f07884f5a1f2b84224363b1372d7c28d447", "tree": "6e2997ab64b4a4f32d7ef539a4649adc736ea553", "parents": [ "ddbd01ac1660d57416879d5a576482f1048dde64" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Mar 08 21:05:27 2012 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Mar 09 15:37:46 2012 -0800" }, "message": "Refactor the compilers out of libart.\n\nThis builds three separate compilers and dynamically links with the right one\nat runtime.\n\nChange-Id: I59d22b9884f41de733c09f97e29ee290236d5f4b\n" } ], "next": "a4060e5fe4729fa30bde965efc35779690478fa4" }