)]}' { "log": [ { "commit": "0a51605ddd81635135463dab08b6f7c21b58ffb0", "tree": "820f338333010f4d6e4b543ffea47e9ff7d2dd3f", "parents": [ "e2727154f25e0db9a5bb92af494d8e47b181dfcf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 14 13:00:44 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 14 13:00:44 2019 +0000" }, "message": "Revert \"Make compiler/optimizing/ symbols hidden.\"\n\nThis reverts commit e2727154f25e0db9a5bb92af494d8e47b181dfcf.\n\nReason for revert: Breaks ASAN tests (ODR violation).\nBug: 142365358\n\nChange-Id: I38103d74a1297256c81d90872b6902ff1e9ef7a4\n" }, { "commit": "e2727154f25e0db9a5bb92af494d8e47b181dfcf", "tree": "0ddc6eec3ad9508d7eb1f2b941786dd0ed7d2cd8", "parents": [ "c78860b91ae07eed92f86876e7a03132adea6fcd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Oct 10 10:46:42 2019 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 14 08:22:00 2019 +0000" }, "message": "Make compiler/optimizing/ symbols hidden.\n\nMake symbols in compiler/optimizing hidden by a namespace\nattribute. The unit intrinsic_objects.{h,cc} is excluded as\nit is needed by dex2oat.\n\nAs the symbols are no longer exported, gtests are now linked\nwith the static version of the libartd-compiler library.\n\nlibart-compiler.so size:\n - before:\n arm: 2396152\n arm64: 3345280\n - after:\n arm: 2016176 (-371KiB, -15.9%)\n arm64: 2874480 (-460KiB, -14.1%)\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nBug: 142365358\nChange-Id: I1fb04a33351f53f00b389a1642e81a68e40912a8\n" }, { "commit": "2808be84a8f86542450670acdb5e6b55498ff5f0", "tree": "f41b63e3109a6a6a9bd534f32b8d92f20eb9ef35", "parents": [ "460f05480379d5c75555d06c4938bc990ce6ff83" ], "author": { "name": "Artem Serov", "email": "artem.serov@linaro.org", "time": "Thu Dec 20 19:15:11 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jul 15 09:30:36 2019 +0000" }, "message": "ART: Introduce stackmap with no DexRegInfo.\n\nSome of safepoints don\u0027t need to have DexRegisterMap info;\nthis will decrease the stackmap size.\n\n.oat file size reduction:\n - boot.oat: -233 kb (-5.4%)\n - boot-framework.oat: -704 kb (-4.9%)\n\nTest: 461-get-reference-vreg, 466-get-live-vreg.\nTest: 543-env-long-ref, 616-cha*.\nTest: test-art-target, +gc-stress.\n\nChange-Id: Idbad355770e30a30dcf14127642e03ee666878b8\n" }, { "commit": "a48c3dfcebece7ee4b893757b715319f0b5b1fa7", "tree": "eb846bcf242f7e9f4243196b5f4546b0a222cfa0", "parents": [ "1459929a7e9ea96932b6c24597e1692b9b05606c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jun 27 13:11:12 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jun 28 06:37:34 2019 +0000" }, "message": "Revert \"Revert \"Make the JIT zygote memory shared.\"\"\n\nThis reverts commit 2fef66b294417d447630f9d98de68227eef476d3.\n\nBug: 119800099\nBug: 136110523\n\nReason for revert: Fixed webview_zygote case.\n\nChange-Id: Iaae8c999463d77b7b1e62b55458493bdbc97a104\n" }, { "commit": "2fef66b294417d447630f9d98de68227eef476d3", "tree": "59fc4ea6cf13217eb92fbdd4e39561b5ad518cf0", "parents": [ "21d5994583c679cd5d8573b5d35dbd659bdca2c7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 26 22:00:02 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 26 22:00:38 2019 +0000" }, "message": "Revert \"Make the JIT zygote memory shared.\"\n\nThis reverts commit 05f87217ddc9b4b9186710c0135b918f456c5aef.\n\nBug: 119800099\nBug: 136110523\n\nReason for revert: testWebview flaking\n\nChange-Id: I96afa6bc9c56c4aaf5ed72ae370f6f69c096c559\n" }, { "commit": "05f87217ddc9b4b9186710c0135b918f456c5aef", "tree": "6e7bc0d2a3d8faa94c303d7d753319f3850fadcd", "parents": [ "8d335b61d637fa9b040eb9d559dbac98067467f1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 19 10:00:00 2019 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jun 26 12:24:15 2019 +0000" }, "message": "Make the JIT zygote memory shared.\n\nTest: boots\nBug: 119800099\nChange-Id: I75ff8a58eea4de5cb833139641b4e15b8394d9b1\n" }, { "commit": "3f1dcd39e134d994ac88dcc4f30ec8cabcd8decf", "tree": "365d20ad6b68ff1dbd4903764b63880324136e4d", "parents": [ "0f0a4e40667c87fbd4ae5480eddbfd701bfabfa2" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Dec 28 09:39:56 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jan 02 10:32:25 2019 -0800" }, "message": "ART: Move dex structs into own header\n\nSeparating out the structs from DexFile allows them to be forward-\ndeclared, which reduces the need to include the dex_file header.\n\nBug: 119869270\nTest: m\nChange-Id: I32dde5a632884bca7435cd584b4a81883de2e7b4\n" }, { "commit": "3db70689e3e1c92344d436a8ea4265046bdef449", "tree": "3db08743e968062ed5bdc143233cdb3c4564696b", "parents": [ "1650dafad62578a1766bd617d78458a4cf1e2a9a" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 26 15:12:03 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Dec 27 12:56:39 2018 -0800" }, "message": "ART: Refactor for bugprone-argument-comment\n\nHandles compiler.\n\nBug: 116054210\nTest: WITH_TIDY\u003d1 mmma art\nChange-Id: I5cdfe73c31ac39144838a2736146b71de037425e\n" }, { "commit": "85f1c576d228c2c43e9a0dc37f0cbb91fad59c45", "tree": "67d17ea5a7eb6021dabb335730402bd28d72694a", "parents": [ "79c693b3133da397cec7eaff19de631b65a0cf70" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 21 13:52:48 2018 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Nov 21 15:22:07 2018 -0800" }, "message": "ART: Some iwyu for logging.h\n\nRemove over-broad use in headers. Fix up transitive includes.\n\nBug: 119869270\nTest: mmma art\nChange-Id: I518fa7c8bee014b260818fca1fbde6ec47d126da\n" }, { "commit": "c1c3452e465e473df499196b387330a793b89680", "tree": "1b144182126bfc73c5d82d1941e1673826d39343", "parents": [ "3b5062083d3e203d1c72b066150b4fe441588a25" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Oct 31 13:56:49 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 01 17:01:31 2018 +0000" }, "message": "Do not cache RequiresConstructorBarrier() results.\n\nAvoid caching the results. Caching was broken for JIT in the\npresence of class unloading; entries for unloaded dex files\nwere leaked and potentially used erroneously with a newly\nloaded dex file.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target\nBug: 118808764\nChange-Id: Ic1163601170364e060c2e3009752f543c9bb37b7\n" }, { "commit": "3b5062083d3e203d1c72b066150b4fe441588a25", "tree": "aefb004034b634fe6a608cbd63f2c984f44752a5", "parents": [ "a2c211ca97cce4d900a6b2047049ffbe46fd5890" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Oct 31 14:33:58 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 01 12:22:49 2018 +0000" }, "message": "ART: Cache resolved types in InstructionBuilder.\n\nAnd avoid using the CompilerDriver for class resolution\nand retrieving CompilerOptions.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Icec3de58456cfeaf3f2be6e57e037fdf45e8b851\n" }, { "commit": "a2c211ca97cce4d900a6b2047049ffbe46fd5890", "tree": "4fc383d217f9de000f11b99d2d5e9c834c5c8c70", "parents": [ "0708fc0c096fb4126c2029d0172830cf0c8e159b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 01 09:50:52 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Nov 01 12:17:35 2018 +0000" }, "message": "Add compiling class to the DexCompilationUnit.\n\nUse it to simplify HInstructionBuilder and reduce the\nnumber of class resolution calls.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nChange-Id: Ib4f9b4ea61235841e653a03a40755a39c7de7504\n" }, { "commit": "7f260d43e9b440f934270873c1e03eb867fa2873", "tree": "3285c18d7b29bb818bedabae6120baae8b444321", "parents": [ "91ddef31f229e6d116cc8988b71aa77bc5083bcb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 30 18:09:55 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Oct 31 11:13:04 2018 +0000" }, "message": "Fix and improve ClinitCheck elimination.\n\nFix erroneous usage of the inner method\u0027s access flags\nwhile checking the class of the outer method. This allowed\nerroneous elimination of a needed ClinitCheck when inlining.\n\nTreat constructors the same way as static methods as the\ninstance allocation necessarily preceding the constructor\ncall performs the class initialization check.\n\nThe size of the aosp_taimen-userdebug prebuilts:\n - before:\n arm/boot*.oat: 20252196\n arm64/boot*.oat: 24030776\n oat/arm64/services.odex: 22406664\n - after:\n arm/boot*.oat: 20252092 (-0.1KiB)\n arm64/boot*.oat: 24027024 (-3.7KiB)\n oat/arm64/services.odex: 22402528 (-4.0KiB)\n(Insignificant changes.)\n\nTest: Add regression test to 174-escaping-instance-of-bad-class.\nTest: Add optimization test to 551-checker-clinit.\nTest: testrunner.py --jvm -t 174\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing\nBug: 62478025\nChange-Id: I591aca2c538d10cf6df1d38d59270af1de380b3e\n" }, { "commit": "b546163926889130354ccdbcccb80c0331c13f3c", "tree": "b4a3fb30e11e2abc671fb0b4b8098acd8fc49ce2", "parents": [ "8db807252e1d4d0bab7785be231e20a1e5fd8e74" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 15 14:24:21 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 16 10:47:24 2018 +0100" }, "message": "Fix HNewArray with unresolved primitive array type.\n\nAnd enable test 920-objects that was crashing because\nof this bug.\n\nTest: testrunner.py --host --jit-on-first-use -t 920\nTest: testrunner.py --host --optimizing\nTest: m test-art-host-gtest\nBug: 117638896\nChange-Id: I47dc893b121c82de537b3147c86d37a6eecf2d62\n" }, { "commit": "0846a8ffafffdf4c18d52f9896b13f40a1c9828d", "tree": "299636dbde6772b4d11ce9ae3a3cd5675f3d0feb", "parents": [ "9ec8559bc2e18075cdcd9a2f09206b698d3c1993" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 12 15:21:07 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 03 10:21:24 2018 +0000" }, "message": "Fix ReplaceUninitializedStringPhis.\n\nMove the analysis after redundant phi and dead phi elimination,\nknowing that only graphs with irreducible loops may still have\na phi as input of the invoke. In such a case, we bail.\n\nbug: 112537407\nTest: 563-checker-fake-string\nChange-Id: Ib9eefa4ce905b7fb418ca9b2a3c26ea4df74ce8f\n" }, { "commit": "bdb2ecc8cfd0d6fc2f3f4fa4c65cca84b358cd61", "tree": "a7660c98c22d28bf508fe208845957418e0dee40", "parents": [ "4bd4d2c199c9e0e522526c40303652e29bc7c631" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Sep 18 14:33:55 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 19 14:46:04 2018 +0100" }, "message": "Remove sharpening as an optimization pass.\n\nMake the last sharpening helper (methods) like the other\nhelpers: being invoked by the instruction builder.\n\nTest: test.py\nChange-Id: Ic80a454f9b59b0b4ef7825590b24402500ba851c\n" }, { "commit": "3e2e123239952c80e1b37431bf2efbbe07a41940", "tree": "153be0dafdbce55b5e5432cb10025b802a637402", "parents": [ "68851b53e4152d3edaea977573af8bdc0bd23313" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 11 12:35:30 2018 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 12 11:32:40 2018 -0700" }, "message": "Refactor debug info position visiting\n\nMove logic to CodeItemDebugInfoAccessor, makes it easier to modify\nthe debug info format.\n\nTest: test-art-host\nBug: 112311591\nBug: 77709234\nChange-Id: Ice56a88951efa54dc07d88f2c228c01be4670e73\n" }, { "commit": "2ab1bdd1ed06ff2cbcfbed946fb58778be23ad4f", "tree": "ce63864f7f62b433ca863866406bee2e7af73065", "parents": [ "fca0b491a34144acf6769ab9c5fb528ac81bd325" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 12 09:59:56 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jul 23 18:39:09 2018 +0100" }, "message": "Elide ClinitCheck for superclasses with trivial init.\n\nWe cannot generally elide ClinitCheck for superclasses\nbecause of escaping instances of erroneous classes and\nbecause a subclass can be successfully initialized while\nthe superclass is initializing and the subclass remains\ninitialized even when the superclass initializer throws.\n\nHowever, for those superclasses that have trivial init,\ni.e. that class and its superclasses (and superinterfaces\nwith default methods) initialize only their own static\nfields using constant values, there is no chance to end\nup in one of these weird situations and we can safely\neliminate the ClinitCheck.\n\nThe size of the aosp_taimen-userdebug prebuilts:\n - before:\n arm/boot*.oat: 16856928\n arm64/boot*.oat: 19846592\n oat/arm64/services.odex: 24662880\n - after:\n arm/boot*.oat: 16848696 (-8.0KiB, -0.05%)\n arm64/boot*.oat: 19842320 (-4.2KiB, -0.02%)\n oat/arm64/services.odex: 24629952 (-32.2KiB, -0.13%)\nwith minor changes to other app prebuilts.\n\nTest: Improved 478-checker-clinit-check-pruning.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 62478025\nChange-Id: I865f567443f1b7f172e5e6559d8eb3232adb7833\n" }, { "commit": "fca0b491a34144acf6769ab9c5fb528ac81bd325", "tree": "3896bc10455308ed675886d8d8037d5358c1556d", "parents": [ "fb9c672577ae9772557f72f9cecb77d4d24af585" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jul 23 15:30:52 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jul 23 18:30:45 2018 +0100" }, "message": "Fix a stale reference use.\n\nIt is unsafe to use an expression like\n klass.Get() \u003d\u003d ResolveType()\nwhere the `ResolveType()` call can invalidate the plain\npointer already retrieved from a Handle\u003c\u003e.\n\nWe fix this in HInstructionBuilder::BuildLoadClass() by\nreordering the code and we change the prefix of related\nfunctions from \"Get\" to \"Resolve\" to better express their\nsemantics. We also pass the ScopedObjectAccess helper all\nthe way to the `ResolveClassFrom()` to avoid constructing\na new one.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 31113334\nChange-Id: I13c1ea356386f28fdc9548da781982f9774080f1\n" }, { "commit": "bbd2cc2e23691515def685fc3dcea6cd792a2f4e", "tree": "45d84f370b70b9aaee23aaa514dd3073d78893ba", "parents": [ "c06bfc9b18e6421ac60e7b27f8f1e90b45772f52", "51b8aafd3beb8855a258383a9eb876a783375629" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 12 10:43:28 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jul 12 10:43:28 2018 +0000" }, "message": "Merge \"Fix HClinitCheck elimination in instruction builder.\"" }, { "commit": "51b8aafd3beb8855a258383a9eb876a783375629", "tree": "002f77eb0308dbb11b6e5e5a88ce4bc19c6ff836", "parents": [ "e824cfdcfd41d400237a806ff93caca7f2e51878" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 09 15:17:05 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 12 09:23:17 2018 +0100" }, "message": "Fix HClinitCheck elimination in instruction builder.\n\nTo handle escaping instances of erroneous classes correctly,\nwe can omit the HClinitCheck only when using a class in the\nstatic method of the very same class. Even for superclasses\nwe need to do the check. The new test exposes the cases\nwhere we were previously diverging from the RI.\n\nAlso clean up the CompilerDriver by inlining one function\ndirectly to the HInstructionBuild::IsInitialized(.) and\nremoving some related functions that are no longer used.\n\nThe size of the aosp_taimen-userdebug prebuilts:\n - before:\n arm/boot*.oat: 16891788\n arm64/boot*.oat: 19815520\n oat/arm64/services.odex: 20071624\n - after:\n arm/boot*.oat: 16949532 (+56.4KiB, +0.34%)\n arm64/boot*.oat: 19889752 (+72.5KiB, +0.37%)\n oat/arm64/services.odex: 20224328 (+149.1KiB, +0.76%)\nwith minor changes to other app prebuilts.\n\nNote: Some of that could be reclaimed by reinstating the old\noptimization for classes where no bytecode can be executed\nduring initialization (no \u003cclinit\u003e to execute in that class\nor superclasses).\n\nTest: 174-escaping-instance-of-bad-class\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: testrunner.py --jvm -t 174\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing\nBug: 62478025\nChange-Id: I41f026ea7fecc615c06e87f3b6cb847de0ede8a6\n" }, { "commit": "d109e30eab8ba25f8d89be2a83d9036e2d541af2", "tree": "24df91603efe9ce8c4a2efd09ac402aceb10df4e", "parents": [ "c916736ca1e375c276df251446baf2ac8ff3eb13" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Jun 27 10:25:41 2018 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Jul 10 08:44:51 2018 -0700" }, "message": "Don\u0027t use StringFactory.newEmptyString in compiled code\n\nWhen compiling debuggable code we would compile a new-instance String\ninstruction into a StringFactory.newEmptyString invoke. This\nadditional invoke could be observed using tracing and is inconsistent\nwith the interpreter, where the string is simply allocated directly.\nIn order to bring these two modes into alignment we added a new\nAllocStringObject quick entrypoint that will be used instead of the\nnormal AllocObject\u003c...\u003e entrypoints when allocating a string. This\nentrypoint directly allocates a new string in the same manner the\ninterpreter does.\n\nNeeds next CL for test to work.\n\nBug: 110884646\nTest: ./test/testrunner/testrunner.py --host --runtime-option\u003d-Xjitthreshold:0 --jit\nTest: Manual inspection of compiled code.\nChange-Id: I7b4b084bcf7dd9a23485c0e3cd2cd04a04b43d3d\n" }, { "commit": "a8d5a5f709cc7611352d58fb6f2fb50411563653", "tree": "be3f0cf1d59e5797100cae0d859e12605ac0b378", "parents": [ "7583d915800ad330da0232dfdb0a4d1bda2d074c", "8a62a4c9570b345b715a022d33d443413a634392" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jul 04 07:50:56 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jul 04 07:50:56 2018 +0000" }, "message": "Merge \"Handle String.\u003cinit\u003e with a phi input.\"" }, { "commit": "8a62a4c9570b345b715a022d33d443413a634392", "tree": "4b34426f14301f230e9d6b5f23486a038cf6e548", "parents": [ "b5271dd44a30f498689e503340d3c8d01bf31f07" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jul 03 09:39:07 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jul 03 11:22:34 2018 +0100" }, "message": "Handle String.\u003cinit\u003e with a phi input.\n\nWe wrongly assumed only irreducible loops could lead\nto this situation, but any loop can actually be in between\na String NewInstance and a String.\u003cinit\u003e.\n\nbug: 109666561\nTest: 563-checker-fakestring\nChange-Id: I018a22f7e22c15e140252544415f51d544f7cc13\n" }, { "commit": "bb089b6bf850c87e0e42917a383cc7298dcb09c5", "tree": "9076775ab1a00bf7321a6b4a457ddd81f20c10c1", "parents": [ "b5271dd44a30f498689e503340d3c8d01bf31f07" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 28 17:30:16 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 28 17:55:01 2018 +0100" }, "message": "Remove CompilerDriver::support_boot_image_fixup_.\n\nCheck for non-PIC boot image as a testing config instead.\nHonor the config for HInvokeStaticOrDirect sharpening.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I3645f4fefe322f1fd64ea88a2b41a35ceccea688\n" }, { "commit": "dc4bccef0ded1c261bf9838def2ef329765a8682", "tree": "f007ff3f747ae2d1e6a20d9bd9c017b2ce191f1e", "parents": [ "eebb821b1adaf2db7662fc1c3ff4e9fcfe59a694" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 21 16:15:42 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 25 11:30:07 2018 +0100" }, "message": "Move image_classes_ to CompilerOptions.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Ifb30e071d7b39ae939fc3f83d7eba82fd077c7e8\n" }, { "commit": "b42042e6aca41ae2f23cb5cc8f5bc864595f1ac9", "tree": "31ade7262edb31e57e407b2aab9ab57e26546f0e", "parents": [ "7643e41206279d1c22fdddff450c2d7bdd585b54", "4c8e12e66968929b36fac6a2237ca4b04160161e" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Jun 11 11:52:17 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jun 11 11:52:17 2018 +0000" }, "message": "Merge \"ART: Adds an entrypoint for invoke-custom\"" }, { "commit": "4c8e12e66968929b36fac6a2237ca4b04160161e", "tree": "d8bbfd72a978c69ef2eef98c37e7869673c52295", "parents": [ "20c64f8d802cc575cc9a1a1f6c493a611b23e2ee" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri May 18 08:33:20 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Jun 11 10:57:17 2018 +0100" }, "message": "ART: Adds an entrypoint for invoke-custom\n\nAdd support for the compiler to call into the runtime for\ninvoke-custom bytecodes.\n\nBug: 35337872\nTest: art/test.py --host -r -t 952\nTest: art/test.py --target --64 -r -t 952\nTest: art/test.py --target --32 -r -t 952\nChange-Id: I821432e7e5248c91b8e1d36c3112974c34171803\n" }, { "commit": "96f0ec14ba78e4d869065fdcf69b33008927505c", "tree": "7c2db50c9b598bf5da9c275dee2486cc0a50acb1", "parents": [ "408bdc604e4fe230bf90ffa6816bfbbb3786806e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jun 08 15:30:20 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jun 08 15:30:20 2018 +0100" }, "message": "Remove DCHECK while investigating.\n\nbug: 109666561\nTest: m\nChange-Id: Ia10990d7caeb37d23d3096b087541aac9eea0c3d\n" }, { "commit": "2c5827a67a7f3d307384e98757f91c8b5d49f94f", "tree": "12d13e0e5c321639ca21d53eae61cfcaf3231c2d", "parents": [ "80a7c29b29c50c1c6cf40093a4552dacd4c5d638" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu May 17 22:26:08 2018 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon May 21 11:31:43 2018 +0100" }, "message": "ART: Simplify operands in InstructionBuilder\n\nTest: art/test.py --host --optimizing --jit -r\nChange-Id: Ia408ae00637aa6a05a3ba54e1144ea00c6b335b5\n" }, { "commit": "cb2187c626828f5cefc0082a4df392ed7e1214e3", "tree": "9325c92f0520f3ecc8652335ff545d6ab800da8e", "parents": [ "bb071ee44ddc1751c79d2a8c31afe4ea3d72b5f4", "d147e2fb824a92acb9cd86bd92d3f1c137d488c5" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu May 17 08:14:11 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu May 17 08:14:11 2018 +0000" }, "message": "Merge \"Don\u0027t compile methods with irreducible loops and String.\u003cinit\u003e.\"" }, { "commit": "d147e2fb824a92acb9cd86bd92d3f1c137d488c5", "tree": "ff228859971532ed6cc8f49baf387fa957fa923f", "parents": [ "4972754f2327dc9c443f2c0c70e5a6528973c435" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed May 16 11:37:41 2018 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed May 16 13:50:29 2018 +0100" }, "message": "Don\u0027t compile methods with irreducible loops and String.\u003cinit\u003e.\n\nThe current code doesn\u0027t work when dex register aliases.\n\nbug: 78493232\nTest: m\nChange-Id: I1c296f6dc914388844ae5eb7d84f3bd7d81e1f87\n" }, { "commit": "06d10a78506fae7e033795cda7b1d9d0e1f1fff5", "tree": "91f94a605395776710f3d14298613a803158f3aa", "parents": [ "93d301397c83b08f6fc165847a3d518e1031f392" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon May 14 08:53:38 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon May 14 16:49:55 2018 +0100" }, "message": "ART: Add dex::ProtoIndex\n\nTest: m -j32 test-art-host\nChange-Id: Ic2d2a7a43be1b8590b97cdf3729200b043ffc6a3\n" }, { "commit": "dbaa5c7ba8935cf87ceb40a4054f9842929e9a51", "tree": "5037625c80cb97a0e13026dc450db28e59ff72ca", "parents": [ "51dda39549033b3c50a7fce5522ffc81325db54b" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu May 10 08:22:46 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri May 11 11:55:30 2018 +0100" }, "message": "ART: Compiler support for const-method-handle\n\nImplemented as a runtime call.\n\nBug: 66890674\nTest: art/test.py --target -r -t 979\nTest: art/test.py --target --64 -r -t 979\nTest: art/test.py --host -r -t 979\nChange-Id: I67f461c819a7d528d7455afda8b4a59e9aed381c\n" }, { "commit": "18259d7fb7164a5e029df4f883b3a79ccc2403e8", "tree": "ba378bfdef4127bb0607215186e3b150fd38bcdf", "parents": [ "922501b4bbf724e4259477a27764291684eedffb" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Apr 12 11:18:23 2018 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu May 10 15:04:09 2018 +0100" }, "message": "ART: Compiler support for const-method-type\n\nImplemented as a runtime call.\n\nBug: 66890674\nTest: art/test.py --target -r -t 979\nTest: art/test.py --target --64 -r -t 979\nTest: art/test.py --host -r -t 979\nChange-Id: I4b3d3969d455d0198cfe122eea8abd54e0ea20ee\n" }, { "commit": "175e7862dbdb44089ef327fc43ba00c791fd3838", "tree": "7b7ff4327b51b57e47e4b22af8d771edb9d462c1", "parents": [ "77c6fc7341143dd27c74cddd786398688d7b4c91" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 27 09:03:13 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 27 10:04:25 2018 +0100" }, "message": "Revert^4 \"Compiler changes for bitstring based type checks.\"\n\nDisabled the build time flag. (No image version bump needed.)\n\nBug: 26687569\nBug: 64692057\nBug: 76420366\n\nThis reverts commit 3fbd3ad99fad077e5c760e7238bcd55b07d4c06e.\n\nChange-Id: I5d83c4ce8a7331c435d5155ac6e0ce1c77d60004\n" }, { "commit": "3fbd3ad99fad077e5c760e7238bcd55b07d4c06e", "tree": "e8bc33fa60c38f7e1c85f8d4acf6a738df9b426a", "parents": [ "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:14:46 2018 +0000" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 26 21:14:46 2018 +0000" }, "message": "Revert^3 \"Compiler changes for bitstring based type checks.\"\n\nThis reverts commit 3f41323cc9da335e9aa4f3fbad90a86caa82ee4d.\n\nReason for revert: Fails sporadically.\n\nBug: 26687569\nBug: 64692057\nBug: 76420366\nChange-Id: I84d1e9e46c58aeecf17591ff71fbac6a1e583909\n" }, { "commit": "3f41323cc9da335e9aa4f3fbad90a86caa82ee4d", "tree": "ce41c620d2cd411da3c20aa95fb9a69328e77c42", "parents": [ "9ec1e24ebc683b15bb9c6db5554ac2ff9458adae" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 12 18:39:15 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 22 12:12:39 2018 +0000" }, "message": "Revert^2 \"Compiler changes for bitstring based type checks.\"\n\nAdd extra output for debugging failures and re-enable\nthe bitstring type checks.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: testrunner.py --host -t 670-bitstring-type-check\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --target -t 670-bitstring-type-check\nBug: 64692057\nBug: 26687569\n\nThis reverts commit bff7a52e2c6c9e988c3ed1f12a2da0fa5fd37cfb.\n\nChange-Id: I090e241983f3ac6ed8394d842e17716087d169ac\n" }, { "commit": "312f3b2fd0094c028a7d243b116947a35a745806", "tree": "3d7ec049ded98c489098c87250c75e3f711f8290", "parents": [ "0a3d5eb2ff9e70fa5785638da938439835d0337e" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 08:39:26 2018 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Mon Mar 19 11:02:48 2018 -0700" }, "message": "Move some remaining dex utilities\n\nThere were several utilities related to building/walking/testing dex\nfiles that were not in libdexfile. This change consolidates these.\n\nBug: 22322814\nTest: make -j 50 test-art-host\nChange-Id: Id76e9179d03b8ec7d67f7e0f267121f54f0ec2e0\n" }, { "commit": "f665f847744aef65f8d4ad46cbf410f911dbfb25", "tree": "85dbb3ea7f3f4b1d0c2464e705710b3d081e4124", "parents": [ "6177ead17f46ec15ef024e50887ab12feafd7d6e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 15 12:29:06 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Feb 15 12:29:06 2018 +0000" }, "message": "Pass the right dex_file/method_index for String.\u003cinit\u003e.\n\nPassing the dex file of the caller in instruction_builder.cc\nwas problematic as this information get lost at the point of RTP.\n\ntest: test.py\nChange-Id: I3f620b931544a538386d23c2456b182b3ed41091\n" }, { "commit": "bff7a52e2c6c9e988c3ed1f12a2da0fa5fd37cfb", "tree": "e281a8dde61e396ed5f20c31d41086b1b1b18389", "parents": [ "83af48e9f4cdfcf3f0069c63561bab4c176bd2f1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 25 13:33:07 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 25 15:05:16 2018 +0000" }, "message": "Revert \"Compiler changes for bitstring based type checks.\"\n\nBug: 64692057\nBug: 71853552\nBug: 26687569\n\nThis reverts commit eb0ebed72432b3c6b8c7b38f8937d7ba736f4567.\n\nChange-Id: I7daeaa077960ba41b2ed42bc47f17501621be4be\n" }, { "commit": "eb0ebed72432b3c6b8c7b38f8937d7ba736f4567", "tree": "74d95eb4bfbf01ef6fd3a68695f5d7cec69338d7", "parents": [ "e57043081e6b091a9fd23a84043373148ae72f1f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 10 18:26:38 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jan 23 13:02:59 2018 +0000" }, "message": "Compiler changes for bitstring based type checks.\n\nWe guard the use of this feature with a compile-time flag,\nset to true in this CL.\n\nBoot image size for aosp_taimen-userdebug in AOSP master:\n - before:\n arm boot*.oat: 63604740\n arm64 boot*.oat: 74237864\n - after:\n arm boot*.oat: 63531172 (-72KiB, -0.1%)\n arm64 boot*.oat: 74135008 (-100KiB, -0.1%)\n\nThe new TypeCheckBenchmark yields the following changes\nusing the little cores of taimen fixed at 1.4016GHz:\n 32-bit 64-bit\n timeCheckCastLevel1ToLevel1 11.48-\u003e15.80 11.47-\u003e15.78\n timeCheckCastLevel2ToLevel1 15.08-\u003e15.79 15.08-\u003e15.79\n timeCheckCastLevel3ToLevel1 19.01-\u003e15.82 17.94-\u003e15.81\n timeCheckCastLevel9ToLevel1 42.55-\u003e15.79 42.63-\u003e15.81\n timeCheckCastLevel9ToLevel2 39.70-\u003e14.36 39.70-\u003e14.35\n timeInstanceOfLevel1ToLevel1 13.74-\u003e17.93 13.76-\u003e17.95\n timeInstanceOfLevel2ToLevel1 17.02-\u003e17.95 16.99-\u003e17.93\n timeInstanceOfLevel3ToLevel1 24.03-\u003e17.95 24.45-\u003e17.95\n timeInstanceOfLevel9ToLevel1 47.13-\u003e17.95 47.14-\u003e18.00\n timeInstanceOfLevel9ToLevel2 44.19-\u003e16.52 44.27-\u003e16.51\nThis suggests that the bitstring typecheck should not be\nused for exact type checks which would be equivalent to the\n\"Level1ToLevel1\" benchmark. Whether the implementation is\na beneficial replacement for the kClassHierarchyCheck and\nkAbstractClassCheck on average depends on how many levels\nfrom the target class (or Object for a negative result) is\na typical object\u0027s class.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nTest: testrunner.py --host -t 670-bitstring-type-check\nTest: Pixel 2 XL boots.\nTest: testrunner.py --target --optimizing --jit\nTest: testrunner.py --target -t 670-bitstring-type-check\nBug: 64692057\nBug: 71853552\nBug: 26687569\nChange-Id: I538d7e036b5a8ae2cc3fe77662a5903d74854562\n" }, { "commit": "210531f8775c89feb90d430cd5b6026b4cf8ef89", "tree": "3c23fffcc0d1d7876f15f64672e0de98b1f051ca", "parents": [ "3c9e0f69b04b614c44448e66e15c6f8a78da4b2c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 12 10:15:51 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Jan 13 01:40:03 2018 +0000" }, "message": "Revert \"Revert \"Move quickening info logic to its own table\"\"\n\nBug: 71605148\nBug: 63756964\n\nTest: test-art-target on angler\n\nThis reverts commit 6716941120ae9f47ba1b8ef8e79820c4b5640350.\n\nChange-Id: Ic01ea4e8bb2c1de761fab354c5bbe27290538631\n" }, { "commit": "6716941120ae9f47ba1b8ef8e79820c4b5640350", "tree": "76dd7d32703505d4ab44c0b55a7ecaf3ff66a94e", "parents": [ "7a26f948204377130be7b738d70d7365c86a804b" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 12 09:06:14 2018 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 12 09:06:14 2018 +0000" }, "message": "Revert \"Move quickening info logic to its own table\"\n\nBug: 71605148\nBug: 63756964\n\nSeems to fail on armv7.\n\nThis reverts commit f5245188d9c61f6b90eb30cca0875fbdcc493b15.\n\nChange-Id: I37786c04a8260ae3ec4a2cd73710126783c3ae7e\n" }, { "commit": "7a26f948204377130be7b738d70d7365c86a804b", "tree": "dd3ab45b73127fdcbcdca64bbac484bfe2c0a8cd", "parents": [ "29504326da13831fa3060ac507927c4d76aa556a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 04 18:23:55 2018 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 11 10:58:22 2018 -0800" }, "message": "Move quickening info logic to its own table\n\nAdded a table that is indexed by dex method index. To prevent size\noverhead, there is only one slot for each 16 method indices. This\nmeans there is up to 15 loop iterations to get the quickening info\nfor a method. The quickening infos are now prefixed by a leb\nencoded length. This allows methods that aren\u0027t quickened to only\nhave 1.25 bytes of space overhead.\n\nThe value was picked arbitrarily, there is little advantage to\nincreasing the value since the table only takes 1 byte per 4 method\nindices currently. JIT benchmarks do not regress with the change.\n\nThere is a net space saving from removing 8 bytes from each\nquickening info since most scenarios have more quickened methods than\ncompiled methods.\n\nFor getting quick access to the table, a 4 byte preheader was added\nto each dex in the vdex file\n\nRemoved logic that stored the quickening info in the CodeItem\ndebug_info_offset field.\n\nThe change adds a small quicken table for each method index, this\nmeans that filters that don\u0027t quicken will have a slight increase in\nsize. The worst case scenario is compiling all the methods, this\nresults in 0.3% larger vdex for this case. The change also disables\ndeduping since the quicken infos need to be in dex method index\norder.\n\nFor filters that don\u0027t compile most methods like quicken and\nspeed-profile, there is space savings. For quicken, the vdex is 2%\nsmaller.\n\nBug: 71605148\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I89cb679538811369c36b6ac8c40ea93135f813cd\n" }, { "commit": "9e734c7ab4599d7747a05db0dc73c7b668cb6683", "tree": "dce1d1993734a947fb2e6f626eb1b425cb72143b", "parents": [ "b496af808eaf3af5ebac50aef4fbec33323b5016" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Jan 04 17:56:19 2018 -0800" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Fri Jan 05 11:07:19 2018 -0800" }, "message": "Create dex subdirectory\n\nMove all the DexFile related source to a common subdirectory dex/ of\nruntime.\n\nBug: 71361973\nTest: make -j 50 test-art-host\nChange-Id: I59e984ed660b93e0776556308be3d653722f5223\n" }, { "commit": "808c7a57bb913b13c22884f57cdacd59bf1fdb3f", "tree": "d7f0d7cabaac5a7646c25bae584a82a9aa279cc0", "parents": [ "64bae9fb677aa0e2406d13ea9f8ebaa92e16f978" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 15 11:19:33 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 22 09:41:17 2017 -0800" }, "message": "Make CodeItem fields private\n\nMake code item fields private and use accessors. Added a hand full of\nfriend classes to reduce the size of the change.\n\nChanged default to be nullable and removed CreateNullable.\nCreateNullable was a bad API since it defaulted to the unsafe, may\nadd a CreateNonNullable if it\u0027s important for performance.\n\nMotivation:\nHave a different layout for code items in cdex.\n\nBug: 63756964\nTest: test-art-host-gtest\nTest: test/testrunner/testrunner.py --host\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nChange-Id: I42bc7435e20358682075cb6de52713b595f95bf9\n" }, { "commit": "702f6f276d2b81ae27bce51c2e78b04aa45a5796", "tree": "84e1e493074878447cf1fe01ece97b9eff8b5f52", "parents": [ "6f05cca7f37eba9f831c811af044bfe735acb8cd", "31f4c9f86522061d682fd0e2c6003043cec496dc" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Dec 12 21:37:59 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Dec 12 21:37:59 2017 +0000" }, "message": "Merge \"Add CodeItemDebugInfoAccessor\"" }, { "commit": "666ee3d7c6039c80e75287e311895bd6a9b01e9f", "tree": "5e65f39ff7cc83af4be3b691c247d7348052f854", "parents": [ "890111968fbd3f5ae528d97e42984c12a3dd27bd" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 18:37:36 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 12 13:48:02 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveType().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nAlso refactor the code to avoid doing the DexCache lookup\ntwice and avoid unnecessary read barriers in the initial\nDexCache lookup (also for Lookup/ResolveField()).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: Idea9aa42b6a5bade947e93e330b1abdb9d11b2da\n" }, { "commit": "31f4c9f86522061d682fd0e2c6003043cec496dc", "tree": "fc7192bc634811bdc8176afc4b5e60a049d56ae0", "parents": [ "f23779bc210ecbf448e61d7b18088b6afb46a476" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Dec 08 15:46:11 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 11 19:55:46 2017 -0800" }, "message": "Add CodeItemDebugInfoAccessor\n\nUse it in places where DecodeDebugPositionInfo is called.\n\nMotivation: Abstract away calls to GetDebugInfoOffset.\n\nBug: 63756964\nTest: test-art-host\nTest: art/tools/run-jdwp-tests.sh \u0027--mode\u003dhost\u0027 --debug\n\nChange-Id: I3ab2eff56c472cc717f49d17fd17eb0b8fde4062\n" }, { "commit": "890111968fbd3f5ae528d97e42984c12a3dd27bd", "tree": "edb4ed38332a817b7d3037ea260856cec839dca9", "parents": [ "0f13269734be07b5869005952a3cb91b0b34b73d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 13:45:05 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Dec 11 15:43:45 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::Lookup/ResolveMethod().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I2e47280e7cb8b84595130c4abfb5ece18d7f5c75\n" }, { "commit": "e11dd50ac2b5ccbf3b02213b7361f55b1f1a90da", "tree": "ea958df5f757369119cc84968f3b77210faf593f", "parents": [ "2ba3557b6d2ea65956f7a98e6f0fd921f35792a5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 14:09:45 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 17:54:25 2017 +0000" }, "message": "Do not pass DexFile to ClassLinker::ResolveField*().\n\nThe DexFile can be easily retrieved from the DexCache,\nso reduce the number of arguments that need to be passed.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nChange-Id: I0579db64c63afea789c7c9ad8db81e37c9248e97\n" }, { "commit": "28e012a4af2d710e5e5f824709ffd6432e4f549f", "tree": "576ebdbff9d5f9f098cd29d652215b8f67b6b042", "parents": [ "4388fb213ec746ee18a6bea38ee894f8c19990b9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Dec 07 11:22:59 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Dec 08 15:27:27 2017 +0000" }, "message": "Determine HLoadClass/String load kind early.\n\nThis helps save memory by avoiding the allocation of\nHEnvironment and related objects for AOT references to\nboot image strings and classes (kBootImage* load kinds)\nand also for JIT references (kJitTableAddress).\n\nCompiling aosp_taimen-userdebug boot image, the most memory\nhungry method BatteryStats.dumpLocked() needs\n - before:\n Used 55105384 bytes of arena memory...\n ...\n UseListNode 10009704\n Environment 423248\n EnvVRegs 20676560\n ...\n - after:\n Used 50559176 bytes of arena memory...\n ...\n UseListNode 8568936\n Environment 365680\n EnvVRegs 17628704\n ...\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --jit\nBug: 34053922\nChange-Id: I68e73a438e6ac8e8908e6fccf53bbeea8a64a077\n" }, { "commit": "d57fdd82fccfa15933033646c9436313b399d528", "tree": "20446e27ec69fa1f2588ac166a85b4e25f9cf861", "parents": [ "6f2960c633d6928fe8491a4bbb1e1eae82f25188", "dbb9aef046301940d0b253c918a5c78b277330ba" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 04 17:52:28 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Dec 04 17:52:28 2017 +0000" }, "message": "Merge \"Log at places we fail to compile.\"" }, { "commit": "dbb9aef046301940d0b253c918a5c78b277330ba", "tree": "8803fa971c0200d56aa8eba7386374eecda01c17", "parents": [ "65e0432cdaf3ee170045b21943c24eae5d6a0357" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 23 10:44:11 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Dec 01 13:03:29 2017 +0000" }, "message": "Log at places we fail to compile.\n\nUseful when diagnosing some compiler issues / limitations.\n\nTest: test.py\n\nChange-Id: I8759d0e78b0682b300ddcadfe02793432cab2036\n" }, { "commit": "58cc1cb66c1a96ffba4a314edb2c5b4e8b235d5b", "tree": "ed00c90ab564c54ae4f09a4acbc5f3ffa65b9e71", "parents": [ "65e0432cdaf3ee170045b21943c24eae5d6a0357" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 20 13:27:29 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 23 10:44:47 2017 +0000" }, "message": "Pass the debug_info_offset explicitly.\n\nIn order to use debug_info_offset for encoding implementation details,\nrewrite all indirect users of it to fetch it before calling DexFile\nmethods.\n\nThis allows keeping the DexFile interface clean of runtime\nconsiderations.\n\nTest: test.py\nChange-Id: I4591e0039b5f822f4409aae411071ecbe97082b1\n" }, { "commit": "92f7f3ce3b01f7c7df1c15b81c900e087248093f", "tree": "37647ac824e450f80d752539cabbe631ba795c75", "parents": [ "5dcb0d2cabe9d67987a6a7477fb124cef92abefb" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 31 11:38:30 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Nov 15 14:29:52 2017 +0000" }, "message": "Use intrinsic codegen for compiling intrinsic methods.\n\nWhen compiling an intrinsic method, generate a graph that\ninvokes the same method and try to compile it. If the call\nis actually intrinsified (or simplified to other HIR) and\nyields a leaf method, use the result of this compilation\nattempt, otherwise compile the actual code or JNI stub.\n\nNote that CodeGenerator::CreateThrowingSlowPathLocations()\nactually marks the locations as kNoCall if the throw is not\nin a catch block, thus considering some throwing methods\n(for example, String.charAt()) as leaf methods.\n\nWe would ideally want to use the intrinsic codegen for all\nintrinsics that do not generate a slow-path call to the\ndefault implementation. Relying on the leaf method is\nsuboptimal as we\u0027re missing out on methods that do other\ntypes of calls, for example runtime calls. This shall be\nfixed in a subsequent CL.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 67717501\nChange-Id: I640fda7c22d4ff494b5ff77ebec3b7f5f75af652\n" }, { "commit": "0021feb36ca7021e2c255e6eaf16b967180290c6", "tree": "43f1ce8f6d91630a831d03b51a465d57c2a47119", "parents": [ "550c0aee52bf8981dfe1d22d3b661d61e80cc7ee" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 07 00:08:52 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 07 13:15:41 2017 -0800" }, "message": "Delete CodeItemIterator\n\nReplace uses with DexInstructionIterator.\n\nBug: 63756964\nTest: test-art-host-gtest\n\nChange-Id: I28c839c372edcb60583867355d46b14f8752d41b\n" }, { "commit": "2b2bef245d5b2c6faa2d6f36da14866b2d8f5e4f", "tree": "7948ee1d32e211198a595bb7ed35558d22838da8", "parents": [ "f199f1d3a9816edf9282766a8874d894d7bf87c3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 26 17:10:19 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 01 15:36:21 2017 -0700" }, "message": "Refactor DexInstructionIterator\n\nAdd a way to get the dex PC for the \"for each\" use case.\n\nBug: 67104794\nTest: test-art-host\nChange-Id: I144c459c9a2a03ec8d56842280338d1f7ce1caf0\n" }, { "commit": "69d310e0317e2fce97bf8c9c133c5c2c0332e61d", "tree": "fba05a1530e6fc4a2e6950303c1f7c6b0ffbb936", "parents": [ "e764d2e50c544c2cb98ee61a15d613161ac6bd17" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Oct 09 14:12:23 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Oct 11 09:44:26 2017 +0100" }, "message": "Use ScopedArenaAllocator for building HGraph.\n\nMemory needed to compile the two most expensive methods for\naosp_angler-userdebug boot image:\n BatteryStats.dumpCheckinLocked() : 21.1MiB -\u003e 20.2MiB\n BatteryStats.dumpLocked(): 42.0MiB -\u003e 40.3MiB\nThis is because all the memory previously used by the graph\nbuilder is reused by later passes.\n\nAnd finish the \"arena\"-\u003e\"allocator\" renaming; make renamed\nallocator pointers that are members of classes const when\nappropriate (and make a few more members around them const).\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 64312607\nChange-Id: Ia50aafc80c05941ae5b96984ba4f31ed4c78255e\n" }, { "commit": "ca6fff898afcb62491458ae8bcd428bfb3043da1", "tree": "195a6b16d3a4b34acc2faf91ce56f448efb15e07", "parents": [ "aa7273e56fbafc2692c8d20a31b50d2f4bdd2aa1" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 03 14:49:14 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Oct 06 17:53:50 2017 +0100" }, "message": "ART: Use ScopedArenaAllocator for pass-local data.\n\nPasses using local ArenaAllocator were hiding their memory\nusage from the allocation counting, making it difficult to\ntrack down where memory was used. Using ScopedArenaAllocator\nreveals the memory usage.\n\nThis changes the HGraph constructor which requires a lot of\nchanges in tests. Refactor these tests to limit the amount\nof work needed the next time we change that constructor.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Build with kArenaAllocatorCountAllocations \u003d true.\nBug: 64312607\nChange-Id: I34939e4086b500d6e827ff3ef2211d1a421ac91a\n" }, { "commit": "1d2d4ff8570bb88d9d2d4633706fd7f6fb18d75e", "tree": "cbe67e8e9214828656314117121e8ce906a762ab", "parents": [ "e5b35ed787fbfb388d162361310bae5b0e7682a7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Sep 23 16:11:06 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Sep 27 11:51:53 2017 -0700" }, "message": "Add DexInstructionIterator and use it a few places\n\nMotivation:\nWant to start abstracting away dex specific functionality to enable\nCompactDex. Adding an iterator will enable CompactDex iteration to\nwork differently than normal dex iteration.\n\nWill eventually replace CodeItemIterator.\n\nBug: 63756964\nTest: test-art-host\n\nChange-Id: I90e67c1a994b7698aaac0523a82816b0a003fbdc\n" }, { "commit": "0ebe0d83138bba1996e9c8007969b5381d972b32", "tree": "a5ee66ebc5b587ade97e56ac8fc7d832fbbed4af", "parents": [ "e1e347dace0ded83774999bb26c37527dcdb1d5a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 21 22:50:39 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 25 15:45:01 2017 +0100" }, "message": "ART: Introduce compiler data type.\n\nReplace most uses of the runtime\u0027s Primitive in compiler\nwith a new class DataType. This prepares for introducing\nnew types, such as Uint8, that the runtime does not need\nto know about.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nBug: 23964345\nChange-Id: Iec2ad82454eec678fffcd8279a9746b90feb9b0c\n" }, { "commit": "a7c83ac563a8f25174ac8826f7fb87bd0a9da9fb", "tree": "23ca6d02cd6fd7054bc4511a3f5ec346c4f9173d", "parents": [ "db48a79e49a900e255c1a472d6436a655016125f" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 11 08:14:23 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Sep 11 08:14:23 2017 -0700" }, "message": "ART: Clean up WellKnownClasses include.\n\nDelete an unnecessary include propagating the WellKnownClasses\nfar to widely, and instead fix some transitive users.\n\nTest: m\nChange-Id: I88fd49057afe4ddcc548b979baafb8b8682d78ae\n" }, { "commit": "6ef45677305048c2bf0600f1c4b98a11b2cfaffb", "tree": "9a8df6a3bebe4a6120403562c21817d775a6ef36", "parents": [ "1e065a54845da12541572f4f149e6ab0dcd20180" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Aug 08 13:59:55 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Aug 11 10:23:30 2017 -0700" }, "message": "optimizing: Add statistics for # of constructor fences added/removed\n\nStatistics are attributed as follows:\n\nAdded because:\n* HNewInstances requires a HConstructorFence following it.\n* HReturn requires a HConstructorFence (for final fields) preceding it.\n\nRemoved because:\n* Optimized in Load-Store-Elimination.\n* Optimized in Prepare-For-Register-Allocation.\n\nTest: art/test.py\nBug: 36656456\nChange-Id: Ic119441c5151a5a840fc6532b411340e2d68e5eb\n" }, { "commit": "1e065a54845da12541572f4f149e6ab0dcd20180", "tree": "061d28c8905c7bc8ac50c8c86f4073034afb5ba2", "parents": [ "f573972a087b798f74bf5404e271355a2805e100" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Aug 09 13:20:34 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Aug 11 10:23:07 2017 -0700" }, "message": "optimizing: Refactor statistics to use OptimizingCompilerStats helper\n\nRemove all copies of \u0027MaybeRecordStat\u0027, replacing them with a single\nOptimizingCompilerStats::MaybeRecordStat helper.\n\nChange-Id: I83b96b41439dccece3eee2e159b18c95336ea933\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "ba118827465d12177f3996e50133960087b1c916", "tree": "f39728cdafc7810004d51c0bef2728b98993daa9", "parents": [ "64a102dde8c5daad83b991710decb418ce43aac5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 12 15:41:56 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 20 13:35:06 2017 +0100" }, "message": "ART: Change method lookup to be more consistent to JLS and the RI.\n\nThe method lookup for different invoke types was previously\nwidely different and didn\u0027t work well with the dex cache\nmethod array where we have only a single slot for each\nMethodId. The new behavior is to perform the same lookup for\nall cases, distinguishing only between interface and\nnon-interface referencing class, and to further align the\nbehavior with the JLS and the RI. Where the JLS conflicts\nwith the RI, we follow the JLS semantics.\n\nThe new lookup for class methods first searches the methods\ndeclared in the superclass chain (ignoring \"copied\" methods)\nand only then looks in the \"copied\" methods. If the search\nin the superclass chain finds a method that has not been\ninherited (i.e. either a private method or a package-access\nmethod where one of the classes in the chain does not belong\nto the same package, see JLS 8.4.8), we still search the\n\"copied\" methods as there may actually be a method inherited\nfrom an interface. This follows the JLS semantics where\ninherited methods are included in the search (JLS 15.12.2.1)\nbut conflicts with the RI where the private or\npackage-access method takes precedence over methods\ninherited from interfaces.\n\nNote that this search can find an accessible method that is\nnot inherited by the qualifying type, either for a package\naccess method when the referrer is in the same package but\nthe qualifying type is in another package, or for a private\nmethod where the referrer is in the same class but the\nqualifying type is actually a subclass. For the moment we\nallow such calls and we shall consider whether to throw\nan IncompatibleClassChangeError in this situation in future\nto comply with JLS 15.12.4.3.\n\nThe new lookup for interface methods searches the interface\nclass, then all the superinterfaces and then the\njava.lang.Object class, see implicitly declared methods in\ninterfaces, JLS 9.2. The search for the maximally-specific\nnon-abstract superinterface method is not yet implemented,\nbut the difference should be difficult to observe as the\nusual subsequent call to FindVirtualMethodForInterface()\nshould yield the same result for any matching method.\n\nThe new test 162-method-idx-clash exposes several cases\nwhere we previously completely messed up due to the effects\nof the DexCache, or where we were out of line with the RI.\nIt also tests a case where the JLS and the RI disagree and\nwe follow the JLS.\n\nTest: art/test/run-test --host --jvm 162-method-resolution\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: testrunner.py --host --interp-ac\nTest: Nexus 6P boots.\nTest: testrunner.py --target\nBug: 62855082\nBug: 30627598\nChange-Id: If450c8cff2751369011d649c25d28a482a2c61a3\n" }, { "commit": "de4b08ff24c330d5b36b5c4dc8664ed4848eeca6", "tree": "79835478b8b631bbf006b5e023704f3cf53bda7c", "parents": [ "c9267c48979698a9217760c914aba13ea20b5990" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jul 10 14:13:41 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 12 17:54:49 2017 -0700" }, "message": "Reduce quicken info size\n\nMove the quicken info from using a map of \u003cdex pc, index\u003e to an array\nof indices. Removed leb encoding since it is harmful for 16 bit\nindices. The map is indexed by the dequickenable instruction index\nfrom the start of the code item.\n\nNumbers for a certain large app compiled with quicken filter:\ndex2oat native alloc: 85345936B -\u003e 81527072B\noat file size: 9068968B -\u003e 8659368B\nvdex file size: 90479120B -\u003e 86321184B\n\nBug: 63467744\nBug: 36457259\nTest: test-art-host\n\n(cherry picked from commit 959f348acabc48efbb18c547dad6300c0f610c1c)\n\nChange-Id: I85546d8cd409cbf96140cbdddabd7e228797b9e3\n" }, { "commit": "e7197bf7d58c705a048e13e241d7ca320502cd40", "tree": "496032b40145660b40002b9d5b7a78f1c2eeb44f", "parents": [ "4ee8e291a7d5b7b98f35f495eb97705836910871" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 17:00:23 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 06 15:26:42 2017 +0100" }, "message": "Replace invoke kind kDexCacheViaMethod with kRuntimeCall.\n\nIn preparation for replacing the dex cache method array\nwith a hash-based array, get rid of one unnecessary use.\nThis method load kind is currently used only on mips for\nirreducible loops and OSR, so this should have no impact\non x86/x86-64/arm/arm64.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Repeat the above tests with manually changing\n kDexCachePcRelative to kRuntimeCall in sharpening.cc.\n (Ignore failures in 552-checker-sharpening.)\nBug: 30627598\nChange-Id: Ifce42645f2dcc350bbb88c2f4642e88fc5f98152\n" }, { "commit": "f20729914d87ab30e6c96420720d8718affd587f", "tree": "d86efb150d9493c97cee50c2c2e9137ec7e4b309", "parents": [ "14538fb50832ac20445af5a92003bc250f486c22" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Tue May 23 15:36:41 2017 -0700" }, "committer": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Tue May 23 15:42:07 2017 -0700" }, "message": "optimizing: Fix a potential nullptr dereference\n\nOperator precedence in C++ means the DCHECK was parsed as\nDCHECK((allocation !\u003d nullptr \u0026\u0026 allocation-\u003eIsNewInstance()) ||\n allocation-\u003eIsNewArray())\n\nCaught by the static analyzer:\nart/compiler/optimizing/instruction_builder.cc:1004:14: warning: Called\nC++ object pointer is null [clang-analyzer-core.CallAndMessage]\n\nBug: None\nTest: Reran the static analyzer. No more nullptr complaints. m builds\nthe file fine, as well.\nChange-Id: Iad94719fc013f1883746128e066452994740f171\n" }, { "commit": "79d8fa7c52c1810d4618c9bd1d43994be5abb53d", "tree": "411a76dec2adf4139328d5e607b498b72c9aa2af", "parents": [ "acac09dad3d5aa3922e6cdf54ff2e4fa6f176484" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue Apr 18 09:37:23 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu May 18 14:14:13 2017 +0000" }, "message": "optimizing: Build HConstructorFence for HNewArray/HNewInstance nodes\n\nAlso fixes:\n* LSE, code_sinking to keep optimizing new-instance if it did so before\n* Various tests to expect constructor fences after new-instance\n\nSidenote: new-instance String does not get a ConstructorFence; the\nspecial StringFactory calls are assumed to be self-fencing.\n\nMetric changes on go/lem:\n* CodeSize -0.262% in ART-Compile (ARMv8)\n* RunTime -0.747% for all (linux-armv8)\n\n(No changes expected to x86, constructor fences are no-op).\n\nThe RunTime regression is temporary until art_quick_alloc_* entrypoints have their\nDMBs removed in a follow up CL.\n\nTest: art/test.py\nBug: 36656456\nChange-Id: I6a936a6e51c623e1c6b5b22eee5c3c72bebbed35\n" }, { "commit": "d01745ef88bfd25df574a885d90a1a7785db5f5b", "tree": "058eb1593dbb0fe8a8e26b901909bec8aa01d474", "parents": [ "a57c334075b193de9690fff97acf6c1b1d1283fc" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Apr 05 16:40:31 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Tue May 02 09:45:45 2017 -0700" }, "message": "optimizing: constructor fence redundancy elimination - remove dmb after LSE\n\nPart one of a few upcoming CLs to optimize constructor fences.\n\nThis improves load-store-elimination; all singleton objects that are not\nreturned will have their associated constructor fence removed.\n\nIf the allocation is removed, so is the fence. Even if allocation is not\nremoved, fences can sometimes be removed.\n\nThis change is enabled by tracking the \"this\" object associated with the\nconstructor fence as an input. Fence inputs are considered weak; they do not keep\nthe \"this\" object alive; if the instructions for \"this\" are all deleted,\nthe fence can also be deleted.\n\nBug: 36656456\nTest: art/test.py --host \u0026\u0026 art/test.py --target\nChange-Id: I05659ab07e20d6e2ecd4be051b722726776f4ab1\n" }, { "commit": "032cacdbf32c50d3c43590600ed1e171a35fa93c", "tree": "c3e3eb480f46de2224fe58e8c30d8d5698238998", "parents": [ "8827cec4193238c2261d83c4d2c0404cc20641f0" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Apr 06 14:40:08 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Mon Apr 10 14:59:19 2017 -0700" }, "message": "optimizing: do not illegally remove constructor barriers after inlining\n\nRemove the illegal optimization that destroyed constructor barriers\nafter inlining invoke-super constructor calls.\n\n---\n\nAccording to JLS 7.5.1,\n\n\"Note that if one constructor invokes another constructor, and the\ninvoked constructor sets a final field, the freeze for the final field\ntakes place at the end of the invoked constructor.\"\n\nThis means if an object is published (stored to a location potentially\nvisible to another thread) inside of an outer constructor, all final\nfield stores from any inner constructors must be visible to other\nthreads.\n\nTest: art/test.py\nBug: 37001605\nChange-Id: I3b55f6c628ff1773dab88022a6475d50a1a6f906\n" }, { "commit": "8d6768d47b66a688d35399d524ad5a5450e9d9d4", "tree": "0b8733baef378d9e060c8e74319a3846489590b2", "parents": [ "fbe1516b91f2117bb9c7282aaea5537572f62dd7" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 10:13:21 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Mar 14 13:55:13 2017 +0000" }, "message": "Revert^6 \"Hash-based dex cache type array.\"\n\nFixed ImageWriter to write class table also if it contains\nonly boot class loader classes. Added a regression test and\nadded extra checks for debug-build to verify that dex cache\ntypes from app image are also in the class table. Removed\nsome unnecessary debug output.\n\nTest: 158-app-image-class-table\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 0b66d6174bf1f6023f9d36dda8538490b79c2e9f.\n\nChange-Id: I6a747904940c6ebc297f4946feef99dc0adf930c\n" }, { "commit": "0b66d6174bf1f6023f9d36dda8538490b79c2e9f", "tree": "1cc4d2ae868745a65fd0489a6fb2f5f2fc9e880f", "parents": [ "6374c58f2ea403b3a05fb27376110fe4d0fc8e3f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 14:50:04 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 13 16:08:01 2017 +0000" }, "message": "Revert^5 \"Hash-based dex cache type array.\"\n\nFor app images, ImageWriter does not add boot image\nclasses to the app image class table even though it\nkeeps them in the dex caches. The reason for that is\nunknown, the code looks OK.\n\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nAlso reverts \"Improve debugging output for a crash.\"\n\nThis reverts commits\n bfb80d25eaeb7a604d5dd25a370e3869e96a33ab,\n 8dd56fcb3196f466ecaffd445397cb11ef85f89f.\n\nTest: testrunner.py --host\nChange-Id: Ic8db128207c07588c7f11563208ae1e85c8b0e84\n" }, { "commit": "caa348cee1312150a957bd308ce77ad406f3eb64", "tree": "575f0b062f8adb1b8fc7ebc5f6ef18bea5ae1db7", "parents": [ "c02fe5f31d487765a8c59922c46d459ba6ebf939", "01b47b046b01ec68696f8ff61b5326cdd3af348e" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Wed Mar 08 20:29:49 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Mar 08 20:29:51 2017 +0000" }, "message": "Merge \"Inlining a few small methods based on profiling dex2oat with perf.\"" }, { "commit": "01b47b046b01ec68696f8ff61b5326cdd3af348e", "tree": "e526306fc89bf6fb04ff914e24343dde0369e98c", "parents": [ "dcab11d06860ae1e23d03926adb6c31f75404032" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Fri Feb 03 12:09:57 2017 -0800" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Wed Mar 08 10:15:06 2017 -0800" }, "message": "Inlining a few small methods based on profiling dex2oat with perf.\n\nTest: m test-art-host\nChange-Id: I6313158e59592d8d132154523be9c82dda3c7eb8\n" }, { "commit": "c4aa82c5b0aa921c51eaf6f6bbaff36501ea2cee", "tree": "0da77f4e4a0fca7577f4c4c709353465d46c8581", "parents": [ "3a791cee90451dc32d46f1b0a85fecc6f22f62bf" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 06 14:38:52 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 07 14:32:54 2017 +0000" }, "message": "Invoke typed arraycopy for primitive arrays.\n\nApps will always call the Object version of arraycopy. When\nwe can infer the types of the passed arrays, replace the method\nbeing called to be the typed System.arraycopy one.\n\n10% improvement on ExoPlayerBench.\n\nTest: 641-checker-arraycopy\nbug: 7103825\nChange-Id: I872d7a6e163a4614510ef04ae582eb90ec48b5fa\n" }, { "commit": "bfb80d25eaeb7a604d5dd25a370e3869e96a33ab", "tree": "96068dd9b9b3bc2e1bcc25d38bbd2420d5b0f1bb", "parents": [ "7a49d93ee265b978ab29cae659e46d41da78459a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Feb 14 14:08:12 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Feb 20 14:13:14 2017 +0000" }, "message": "Revert^4 \"Hash-based dex cache type array.\"\n\nAdded extra output to the abort message to collect more data\nwhen we hit the crash. Added extra check when loading an app\nimage to verify that the class table isn\u0027t already broken.\n\nTest: testrunner.py --host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5.\n\nChange-Id: I9bb442a184c236dcb75b3e42a095f39cd6bee59d\n" }, { "commit": "fa4333dcb481e564f54726b4e6f8153612df835e", "tree": "ae597c7587dc214434a180962c4373d3748f51ab", "parents": [ "2d98ba68f13dc219c088a12f369c5778bf398f14" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:10:34 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:44:48 2017 -0800" }, "message": "ART: Add operator \u003d\u003d and !\u003d with nullptr to Handle\n\nGet it in line with ObjPtr and prettify our code.\n\nTest: m\nChange-Id: I1322e2a9bc7a85d7f2441034a19bf4d807b81a0e\n" }, { "commit": "5812e20ff7cbc8efa0b8d7486ada2f58840a6ad5", "tree": "be0e9fdeb90bcbad76b17b3aae4e746d977d80ee", "parents": [ "518f373324f355f8e58440dfbc3f5a1f2244bde7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 18:32:04 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Feb 13 19:34:54 2017 -0800" }, "message": "Revert^3 \"Hash-based dex cache type array.\"\n\nAssert failing for \"earchbox:search\":\nF zygote64: class_linker.cc:4612] Check failed: handle_scope_iface.Get() !\u003d nullptr\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit 85c0f2ac03417f5125bc2ff1dab8109859c67d5c.\n\nChange-Id: I39846c20295af5875b0f945be7035c73ded23135\n" }, { "commit": "85c0f2ac03417f5125bc2ff1dab8109859c67d5c", "tree": "844952d237e35faa5c5a2357ab037366c8397115", "parents": [ "8d4b1189639f0d8982bde681ccbdd7c03fe6ddbf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Feb 02 16:42:38 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Feb 10 11:23:11 2017 +0000" }, "message": "Revert^2 \"Hash-based dex cache type array.\"\n\nThe reason for the revert was fixed by\n https://android-review.googlesource.com/332666 .\nWe now enable clearing dex cache types in test 155 from that\nCL. Also avoid an unnecessary store in LookupResolvedTypes()\nand prevent verifier from messing up the dex cache types.\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\n\nThis reverts commit d16363a93053de0f32252c7897d839a46aff14ae.\n\nChange-Id: Ie8603cfa772e78e648d005b0b6eae59062ae729d\n" }, { "commit": "d56a6a32547dfa354697430f89a0038895baac8e", "tree": "ef1468adfa615eecfefb012ca205325153e1993c", "parents": [ "23d953942fe54bccbb3378af44aee6cd5ee6deaa" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 06 16:36:24 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Feb 06 16:36:24 2017 +0000" }, "message": "Remove obsolete restriction with allocations and dex cache.\n\nWe used to rely on being in the same dex file for doing allocations,\nbut not anymore.\n\nTest: ART_TEST_JIT\u003dtrue test-art-host\nChange-Id: Iabc27469dadea6bfe39054e4be305e620818ac99\n" }, { "commit": "83c8e27a292e6e002fb3b3def75cf6d8653378e8", "tree": "f49ff5c239f318a0290a0d1e0a5b4d9a1ee1d2ba", "parents": [ "357dcb73934356239292c46d6fbedba734da5e00" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 31 14:36:37 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 03 15:12:46 2017 +0000" }, "message": "Code refactoring around sharpening HLoadClass.\n\nEven if the class is not accessible through the dex cache, we\ncan access it by other means (eg boot class, jit table). So rewrite\nstatic field access instruction builder to not bail out if a class\ncannot be accessed through the dex cache.\n\nbug:34966607\n\ntest: test-art-host test-art-target\nChange-Id: I88e4e09951a002b480eb8f271726b56f981291bd\n" }, { "commit": "d16363a93053de0f32252c7897d839a46aff14ae", "tree": "8823c6dd4641eae333aa7001203460757a515010", "parents": [ "ac240396125911b52437a460a400c8b38be43a96" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 01 14:09:13 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Feb 01 15:27:37 2017 +0000" }, "message": "Revert \"Hash-based dex cache type array.\"\n\nReverting to work around some programs crashing with\n Check failed: handle_scope_iface.Get() !\u003d nullptr.\nthough the reason for the failure not yet understood.\n\nTest: m test-art-host\nBug: 34839984\nBug: 30627598\nBug: 34659969\nBug: 30419309\n\nThis reverts commit ec7862283dd49f5a58d0ac45960ce27c2f7671b8.\n\nChange-Id: Ifded663633082f1e59e5b6ff2e026dc559bd6b82\n" }, { "commit": "ec7862283dd49f5a58d0ac45960ce27c2f7671b8", "tree": "26d6dcc1d5ed4f0ba5ac15f17ef7377215684bf6", "parents": [ "c01d49091f4588777db5bf45345f388058caa99f" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 20 16:24:13 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 30 10:21:16 2017 +0000" }, "message": "Hash-based dex cache type array.\n\nTest: m test-art-host (Interpreter, Optimizing, JIT)\nTest: m test-art-target on Nexus 6P (Interpreter, Optimizing, JIT)\nTest: Nexus 6P boots\nTest: m valgrind-test-art-host\nBug: 30627598\nBug: 34659969\nBug: 30419309\nChange-Id: Ic00eda89e58088a3573fc9ec0ad04c0e69e161d1\n" }, { "commit": "5e8d5f01b0fe87a6c649bd3a9f1534228b93423d", "tree": "a1441acc0021d170f412542ae2a1ae62794e7846", "parents": [ "b0dde4397fa5b0756312b46bd18477a2c1f6a7da" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Oct 18 18:03:43 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jan 23 15:50:01 2017 +0000" }, "message": "Fix some typos in ART.\n\nTest: m build-art-host\nTest: m cpplint-art\nChange-Id: Ifc6ce3d0d645c4a8dca72dd483fc03fc05077130\n" }, { "commit": "e761bccf9f0d884cc4d4ec104568cef968296492", "tree": "05a2d20d61c0e91270df2747f0c242433b5ce62b", "parents": [ "b0355130e38034db6b904783a00f74a3524e1881" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 19 08:59:37 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 19 09:32:17 2017 +0000" }, "message": "Revert \"Revert \"Load the array class in the compiler for allocations.\"\"\n\nThis reverts commit fee255039e30c1c3dfc70c426c3d176221c3cdf9.\n\nChange-Id: I02b45f9a659d872feeb35df40b42c1be9878413a\n" }, { "commit": "fee255039e30c1c3dfc70c426c3d176221c3cdf9", "tree": "8207b72cc76513fed9f7b3c01aaa32cd54a87f1c", "parents": [ "cc99df230feb46ba717252f002d0cc2da6828421" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Jan 19 02:11:15 2017 +0000" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Jan 19 02:11:15 2017 +0000" }, "message": "Revert \"Load the array class in the compiler for allocations.\"\n\nlibcore test fails.\n\nThis reverts commit cc99df230feb46ba717252f002d0cc2da6828421.\n\nChange-Id: I5bac595acd2b240886062e8c1f11f9095ff6a9ed\n" }, { "commit": "cc99df230feb46ba717252f002d0cc2da6828421", "tree": "73ac045673e150fa367a8da4d46874f28e928491", "parents": [ "4507fdcb70bd570d5f3968061bf991f0a1233a93" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 17 23:00:24 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jan 18 15:16:32 2017 +0000" }, "message": "Load the array class in the compiler for allocations.\n\nRemoving one other dependency for needing to pass\nthe current method, and having dex_cache_resolved_types_\nin ArtMethod.\n\noat file increase:\n- x64: 0.25%\n- arm32: 0.30%\n- x86: 0.28%\n\ntest: test-art-host, test-art-target\nChange-Id: Ibca4fa00d3e31954db2ccb1f65a584b8c67cb230\n" }, { "commit": "dcc7ab628c9d59bfab203ab752ff7e11bfd60181", "tree": "b37f3f978c06d4205145eab948d51f86560f64b0", "parents": [ "9748d3d2094c1d3c443a350cf12b9d77b4c4d1e3", "5247c08fb186a5a2ac02226827cf6b994f41a681" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 17 10:25:57 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jan 17 10:25:57 2017 +0000" }, "message": "Merge \"Put the resolved class in HLoadClass.\"" }, { "commit": "e037a736be43c1e8ba9340dcbf1d17722356a37b", "tree": "f0bc7b4a78d04376b042046afbfd0677d766b523", "parents": [ "db54cc42859a8cc24ed1cda7f9b2f64b27dcb34a", "5d37c152f21a0807459c6f53bc25e2d84f56d259" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 17 09:16:31 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jan 17 09:16:31 2017 +0000" }, "message": "Merge \"Put inlined ArtMethod pointer in stack maps.\"" }, { "commit": "5247c08fb186a5a2ac02226827cf6b994f41a681", "tree": "8b1305f9fb918024302382b8e8aa43962098e9fa", "parents": [ "0d478f289f0e33f19693d135f1d562b57427ed32" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 13 14:17:29 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 16 23:42:09 2017 +0000" }, "message": "Put the resolved class in HLoadClass.\n\nTo avoid repeated lookups in sharpening/rtp/inlining.\n\nTest: test-art-host test-art-target\nChange-Id: I08d0da36a4bb061cdaa490ea2af3a3217a875bbe\n" }, { "commit": "5d37c152f21a0807459c6f53bc25e2d84f56d259", "tree": "7d8cbce0a55f258150a047def70244f79afc866d", "parents": [ "aa89a4c6fca095904521842c018399f1e3501a45" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 12 13:25:19 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 16 22:56:56 2017 +0000" }, "message": "Put inlined ArtMethod pointer in stack maps.\n\nCurrently done for JIT. Can be extended for AOT and inlined boot\nimage methods.\n\nAlso refactor the lookup of a inlined method at runtime to not\nrely on the dex cache, but look at the class loader tables.\n\nbug: 30933338\ntest: test-art-host, test-art-target\nChange-Id: I58bd4d763b82ab8ca3023742835ac388671d1794\n" }, { "commit": "ac141397dc29189ad2b2df41f8d4312246beec60", "tree": "a2f481463a14695bf9327fd2f549878ecf30c77b", "parents": [ "5c9f90c5ecf2ff6f93ada0f7b18b46d866c59ea1" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Jan 13 11:53:47 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Sun Jan 15 15:18:07 2017 +0000" }, "message": "Revert \"Revert \"ART: Compiler support for invoke-polymorphic.\"\"\n\nThis reverts commit 0fb5af1c8287b1ec85c55c306a1c43820c38a337.\n\nThis takes us back to the original change and attempts to fix the\nissues encountered:\n\n- Adds transition record push/pop around artInvokePolymorphic.\n- Changes X86/X64 relocations for MacSDK.\n- Implements MIPS entrypoint for art_quick_invoke_polymorphic.\n- Corrects size of returned reference in art_quick_invoke_polymorphic\n on ARM.\n\nBug: 30550796,33191393\nTest: art/test/run-test 953\nTest: m test-art-run-test\n\nChange-Id: Ib6b93e00b37b9d4ab743a3470ab3d77fe857cda8\n" }, { "commit": "0d3998b5ff619364acf47bec0b541e7a49bd6fe7", "tree": "a4763c0660372f6311b612c09267cbbc2fe71e89", "parents": [ "aa89a4c6fca095904521842c018399f1e3501a45" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 12 15:35:12 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 12 16:51:12 2017 +0000" }, "message": "Revert \"Revert \"Make object allocation entrypoints only take a class.\"\"\n\nThis reverts commit f7aaacd97881c6924b8212c7f8fe4a4c8721ef53.\n\nChange-Id: I6756cd1e6110bb45231f62f5e388f16c044cb145\n" }, { "commit": "f7aaacd97881c6924b8212c7f8fe4a4c8721ef53", "tree": "780209ac8e992fa63307062977f672aa5bb55d9e", "parents": [ "2b615ba29c4dfcf54aaf44955f2eac60f5080b2e" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Jan 12 02:58:38 2017 +0000" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Jan 12 02:58:38 2017 +0000" }, "message": "Revert \"Make object allocation entrypoints only take a class.\"\n\n960-default-smali64 is failing.\n\nThis reverts commit 2b615ba29c4dfcf54aaf44955f2eac60f5080b2e.\n\nChange-Id: Iebb8ee5a917fa84c5f01660ce432798524d078ef\n" }, { "commit": "2b615ba29c4dfcf54aaf44955f2eac60f5080b2e", "tree": "0a2fe5f9243645a054d4aa094bff5a69cc1abb88", "parents": [ "c9a060f2688599d4a402ee6234db46c2e9b7463f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jan 06 14:40:07 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jan 11 10:34:10 2017 +0000" }, "message": "Make object allocation entrypoints only take a class.\n\nChange motivated by:\n- Dex cache compression: having the allocation fast path do a\n dex cache lookup will be too expensive. So instead, rely on the\n compiler having direct access to the class (either through BSS for\n AOT, or JIT tables for JIT).\n- Inlining: the entrypoints relied on the caller of the allocation to\n have the same dex cache as the outer method (stored at the bottom of\n the stack). This meant we could not inline methods from a different\n dex file that do allocations. By avoiding the dex cache lookup in\n the entrypoint, we can now remove this restriction.\n\nCode expansion on average for Docs/Gms/FB/Framework (go/lem numbers):\n- Around 0.8% on arm64\n- Around 1% for x64, arm\n- Around 1.5% on x86\n\nTest: test-art-host, test-art-target, ART_USE_READ_BARRIER\u003dtrue/false\nTest: test-art-host, test-art-target, ART_DEFAULT_GC_TYPE\u003dSS ART_USE_TLAB\u003dtrue\n\nChange-Id: I41f3748bb4d251996aaf6a90fae4c50176f9295f\n" }, { "commit": "c52b26d4fb5b1ca91f34ce4b535b764853e538f6", "tree": "9b734310200bb70cb42696082a55db70bed51b3c", "parents": [ "b28c8749a52f4f3252fbfe8bfb5f9d7c7f980adf" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 19 09:18:07 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 10 14:11:32 2017 +0000" }, "message": "Recognize getClass() in RTP.\n\nAlso always keep around the resolved field\nin related HInstructions to avoid resolving it again\nand again.\n\nTest: test-art-host, 631-checker-get-class\n\nChange-Id: I3bc6be11f3eb175c635e746006f39865947e0669\n" } ], "next": "c1a42cf3873be202c8c0ca3c4e67500b470ab075" }