)]}' { "log": [ { "commit": "96dadefd24331f6808cb287048269ba772423c33", "tree": "5780533c94b5d46f86fb372fc1516f35f78d2048", "parents": [ "12dd6fc8d125e594376fdca306da315d01f12069" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Aug 29 16:51:55 2021 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Aug 31 12:53:59 2021 +0000" }, "message": "Partial LSE: handle all kinds of infinite loops.\n\nA subgraph could also have an infinite loop.\n\nTest: 826-inifinite-loop\nBug: 196246395\nChange-Id: Ifd1e1ae0f42dfe2cc156386fc166101c20748fc9\n" }, { "commit": "5c824937bb82adbde857bc99cb03c769c9f68f7b", "tree": "7aaa6cc94120e39ed93e3c0e127318f41e7bb456", "parents": [ "95313c5d14447ff5d75f51263bfd82fc6352dd72" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jun 02 15:54:17 2021 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 03 08:09:43 2021 +0000" }, "message": "Reduce Partial LSE memory usage.\n\nInstantiate ExecutionSubgraph only for partial singleton\ncandidates (currently NewInstance, possibly NewArray in the\nfuture). This reduces \"LSA\" allocations.\n\nReserve memory for PartialLoadStoreEliminationHelper members\nbased on the number of partial singletons instead of the\nnumber of reference infos. This reduces \"LSE\" allocations.\n\nThe peak scoped arena allocation for one compiled method\nis reduced from\n MEM: used: 97424004, allocated: 99006568, lost: 1115968\n LSA 46015104\n LSE 51408900\ndown to\n MEM: used: 17000744, allocated: 26713880, lost: 3332496\n GVN 17000744\nwhere the LSA+LSE memory use is lower than GVN use.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 33650849\nChange-Id: I323b9f144b258f0fab034794770971547ce94b59\n" }, { "commit": "86fe9b85c5243debe5f695c1625bae03bf738452", "tree": "5de78b8292a0225b617e1825817cbd12b46b6fa3", "parents": [ "cc9df4fa1e666b90c5dd8eac94773763f8421f1e" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Nov 16 16:54:01 2020 +0000" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Wed Nov 18 20:26:53 2020 +0000" }, "message": "Revert^4 \"Partial LSE analysis \u0026 store removal\"\n\nWe incorrectly handled merging unknowns in some situations.\nSpecifically in cases where we are unable to materialize loop-phis we\ncould end up with PureUnknowns which could end up hiding stores that\nneed to be kept.\n\nIn an unrelated issue we were incorrectly considering some values as\nescapes when live at the point of an invoke. Since\nSearchPhiPlaceholdersForKeptStores used a more precise notion of\nescapes we could end up removing stores without being able to replace\nthe values.\n\nThis reverts commit 2316b3a0779f3721a78681f5c70ed6624ecaebef.\nThis unreverts commit b6837f0350ff66c13582b0e94178dd5ca283ff0a\nThis reverts commit fe270426c8a2a69a8f669339e83b86fbf40e25a1.\nThis unreverts commit bb6cda60e4418c0ab557ea4090e046bed8206763.\n\nBug: 67037140\nBug: 173120044\n\nReason for revert: Fixed issue causing incorrect store elimination\nTest: ./test.py --host\nTest: Boot cuttlefish\n atest FrameworksServicesTests:com.android.server.job.BackgroundRestrictionsTest#testPowerWhiteList\n\nChange-Id: I2ebae9ccfaf5169d551c5019b547589d0fce1dc9\n" }, { "commit": "2316b3a0779f3721a78681f5c70ed6624ecaebef", "tree": "8aa4682729b839a97b2578e6cbe05ee5d35be923", "parents": [ "aeb7f9f8fe718219cfb04e0da5df62683250477d" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Sat Nov 14 01:28:22 2020 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Sat Nov 14 02:54:26 2020 +0000" }, "message": "Revert^3 \"Partial LSE analysis \u0026 store removal\"\n\nThis reverts commit b6837f0350ff66c13582b0e94178dd5ca283ff0a\nThis unreverts commit fe270426c8a2a69a8f669339e83b86fbf40e25a1.\nThis rereverts commit bb6cda60e4418c0ab557ea4090e046bed8206763.\n\nBug: 67037140\nBug: 173120044\n\nReason for revert: Git-blame seems to point to the CL as cause of\nb/173120044. Revert during investigation.\n\nChange-Id: I46f557ce79c15f07f4e77aacded1926b192754c3\n" }, { "commit": "b6837f0350ff66c13582b0e94178dd5ca283ff0a", "tree": "f79fff81352545efe967850e3d17e32255dcfecd", "parents": [ "32c2eb81320f24b5bab24754204b8be95faa08b0" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Nov 12 17:05:28 2020 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Nov 13 10:07:21 2020 +0000" }, "message": "Revert^2 \"Partial LSE analysis \u0026 store removal\"\n\nA ScopedArenaAllocator in a single test was accidentally loaded using\noperator new which is not supported. This caused a memory leak.\n\nThis reverts commit fe270426c8a2a69a8f669339e83b86fbf40e25a1.\nThis unreverts commit bb6cda60e4418c0ab557ea4090e046bed8206763.\n\nBug: 67037140\n\nReason for revert: Fixed memory leak in\nLoadStoreAnalysisTest.PartialEscape test case\n\nTest: SANITIZE_HOST\u003daddress ASAN_OPTIONS\u003ddetect_leaks\u003d0 m test-art-host-gtest-dependencies\n Run art_compiler_tests\n\nChange-Id: I34fa2079df946ae54b8c91fa771a44d56438a719\n" }, { "commit": "fe270426c8a2a69a8f669339e83b86fbf40e25a1", "tree": "c048fdec8e37cefb7238218a087709c01d5d3923", "parents": [ "e17530a19a717879c8dd8e70073de6aaf4ee455f" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 12 14:12:52 2020 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 12 16:33:50 2020 +0000" }, "message": "Revert \"Partial LSE analysis \u0026 store removal\"\n\nThis reverts commit bb6cda60e4418c0ab557ea4090e046bed8206763.\n\nBug: 67037140\n\nReason for revert: memory leak detected in the test.\n\nChange-Id: I81cc2f61494e96964d8be40389eddcd7c66c9266\n" }, { "commit": "bb6cda60e4418c0ab557ea4090e046bed8206763", "tree": "f6b94510108cb653a80e0ea14d50ad6616c9f44a", "parents": [ "670ff8854cf075617e0abee77b2259903757d86e" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Thu Jul 09 13:24:56 2020 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Nov 12 02:08:44 2020 +0000" }, "message": "Partial LSE analysis \u0026 store removal\n\nThis is the first piece of partial LSE for art. This CL adds analysis\ntools needed to implement partial LSE. More immediately, it improves\nLSE so that it will remove stores that are provably non-observable\nbased on the location they occur. For example:\n\n```\nFoo o \u003d new Foo();\nif (xyz) {\n check(foo);\n foo.x++;\n} else {\n foo.x \u003d 12;\n}\nreturn foo.x;\n```\n\nThe store of 12 can be removed because the only escape in this method\nis unreachable and was not executed by the point we reach the store.\n\nThe main purpose of this CL is to add the analysis tools needed to\nimplement partial Load-Store elimination. Namely it includes tracking\nof which blocks are escaping and the groups of blocks that we cannot\nremove allocations from.\n\nThe actual impact of this change is incredibly minor, being triggered\nonly once in a AOSP code. go/lem shows only minor effects to\ncompile-time and no effect on the compiled code. See\ngo/lem-allight-partial-lse-2 for numbers. Compile time shows an\naverage of 1.4% regression (max regression is 7% with 0.2 noise).\n\nThis CL adds a new \u0027reachability\u0027 concept to the HGraph. If this has\nbeen calculated it allows one to quickly query whether there is any\nexecution path containing two blocks in a given order. This is used to\ndefine a notion of sections of graph from which the escape of some\nallocation is inevitable.\n\nTest: art_compiler_tests\nTest: treehugger\nBug: 67037140\nChange-Id: I0edc8d6b73f7dd329cb1ea7923080a0abe913ea6\n" } ] }