)]}' { "log": [ { "commit": "99170c636dfae4908b102347cfe9f92bad1881cc", "tree": "1ecff5dd69ea20b09e622cb88e7835a55dfa4be8", "parents": [ "5836f8465ddd0a7f5cbeec9c30d739bd0619867f" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Mon Jul 06 11:10:37 2015 -0700" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Sep 17 17:07:22 2015 +0200" }, "message": "Deoptimization support in optimizing compiler for setting local values\n\nDue to compiler optimizations, we may not always be able to update\nthe value of a local variable in a compiled frame (like a variable\nseen as constant by the compiler). To avoid that situation, we simply\ndeoptimize compiled frames updated by the debugger so they are\nexecuted by the interpreter with the updated value.\n\nWhen the debugger attempts to set a local variable (actually a DEX\nregister or a pair of registers) in a compiled frame, we allocate a\nShadowFrame associated to that frame (using its frame id) and set the\nnew value in that ShadowFrame. When we know we are about to continue\nthe execution of the compiled frame, we deoptimize the stack using\nthe preallocated ShadowFrame (instead of creating a new one). We\ninitialize it with the current value of all DEX registers except\nthe ones that have been set by the debugger. Therefore, the\nShadowFrame represent the runtime context modified by the debugger.\n\nBumps oat version to force recompilation.\n\nBug: 19944235\nChange-Id: I0ebe6241264f7a3be0f14ee4516c1f7436e04da6\n" }, { "commit": "520633bebd2bf4d70884d30f179dbde9f275aac6", "tree": "0006fb9db71545d9aaa88df3952a7488b30b2ae6", "parents": [ "e0a49e3a93aa54b9e603d797d9e925a98742753a" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 08 17:03:36 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Sep 10 17:39:56 2015 +0200" }, "message": "Support deoptimization on exception\n\nAllows to deoptimize when an exception is being thrown. We only\ndeoptimize if an executable frame (starting from the catch handler)\nneeds to be executed with the interpreter.\n\nBefore executing deoptimized frames, the exception is restored. The\ninterpreter starts by handling this exception at the point of the\nthrowing instruction.\n\nBug: 23714835\nChange-Id: I0c5f7d4b257644acf12210aae8e5b6bb0f4af1f7\n" }, { "commit": "90443477f9a0061581c420775ce3b7eeae7468bc", "tree": "8c74b81dfae162e0fd0ccf8d5ac50827ba815174", "parents": [ "6078aec213dfaf111c29969706e8e5967cfc9bea" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 16 20:32:27 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 22 15:13:56 2015 -0700" }, "message": "Move to newer clang annotations\n\nAlso enable -Wthread-safety-negative.\n\nChanges:\nSwitch to capabilities and negative capabilities.\n\nFuture work:\nUse capabilities to implement uninterruptible annotations to work\nwith AssertNoThreadSuspension.\n\nBug: 20072211\n\nChange-Id: I42fcbe0300d98a831c89d1eff3ecd5a7e99ebf33\n" }, { "commit": "42361f2e8b3601813dc40d12e14c679df99a864b", "tree": "f5a89acb10d76edc7b7d288e934b60f3c1fc6b9a", "parents": [ "995f6e23418a1b4058167e64bbe50fd9e5dc7f02", "cbc5064ff05179b97b416f00ca579c55e38cd7d9" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Jun 12 10:40:56 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 12 10:40:58 2015 +0000" }, "message": "Merge \"JDWP: asynchronous invoke command handling\"" }, { "commit": "f80ebf2f23f5b8124587ed250f9d95bbeb6612c2", "tree": "2a0284f9a8f871d366bb8ee913e760b4ca1abe75", "parents": [ "e257ee4397e0ca45ff627486ccaeecbf26245c86" ], "author": { "name": "Man Cao", "email": "manc@google.com", "time": "Wed Jun 10 20:02:42 2015 -0700" }, "committer": { "name": "Man Cao", "email": "manc@google.com", "time": "Wed Jun 10 20:19:17 2015 -0700" }, "message": "Fix buildbot failure for 098-ddmc test\n\nThe test only failed on buildbot but not on my local machine. It is\npossibly caused by GC reclaiming dead objects and associated allocation\nrecords.\n\nMore importantly, the CL 153435 changes the behavior of recent allocation\ntracking for DDMS, so that it now reports allocation records of not-yet-\ngarbaged-collected objects. They are a superset of live objects, but not\na precise set of the most recent allocations.\n\nBug: 20037135\nChange-Id: I200a6c8baaeb98207845049902d59efa2f4ea11e\n" }, { "commit": "8c2ff641294715864013737fdec57cdfd410270c", "tree": "2dd302323b4711d1a9391b8c1a8dce3de3e76e91", "parents": [ "6dbf5a5a075a371cb2ff3659058e93a985485baa" ], "author": { "name": "Man Cao", "email": "manc@google.com", "time": "Wed May 27 17:25:30 2015 -0700" }, "committer": { "name": "Man Cao", "email": "manc@google.com", "time": "Wed Jun 10 15:03:01 2015 -0700" }, "message": "Add allocation stack traces for HPROF dump.\n\nThis feature is currently only enabled when DDMS\u0027s allocation tracking\nis enabled. In the future there should be a way to enable this feature\nbefore an application starts.\n\nAlso updates DDMS\u0027s recent allocation tracking to use a new backend\ndata structure that is shared with this feature.\n\nThe following system properties controls customizable parameters:\ndalvik.vm.allocTrackerMax: max number of objects that have allocation\n records, default 512K;\n\ndalvik.vm.recentAllocMax: max number of records that are sent to DDMS\n when clicking \"Get allocation\" button,\n default 64K-1 (limit of the protocol);\n\ndalvik.vm.allocStackDepth: max number of stack frames in an allocation\n record, default 4.\n\nBug: 20037135\nChange-Id: I26ed378a5613678bd3c43e846025f90470a8e059\n" }, { "commit": "cbc5064ff05179b97b416f00ca579c55e38cd7d9", "tree": "9ce221e6644ff770b8484ba8cb5581e538b88eef", "parents": [ "864a2d955aa85ab989c86d7f1eeacbe0b11f8b0f" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Jun 01 17:33:12 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jun 10 09:35:08 2015 +0200" }, "message": "JDWP: asynchronous invoke command handling\n\nThe JDWP thread used to wait for the result of a method invocation\nrunning in an event thread. But doing that prevents the JDWP thread\nfrom processing incoming commands from the debugger if the event\nthread gets suspended by a debug event occurring in another thread.\nIn Android Studio (or another IDE), this leads to the debugger being\nblocked (with the famous message \"Waiting until last debugger command\ncompletes\" of Android Studio / IntelliJ) because it is actually\nwaiting for the reply of its latest command while the JDWP thread\ncannot process it.\n\nThis CL changes the way invoke commands (ClassType.InvokeCommand,\nClassType.NewInstance and ObjectReference.InvokeCommand) are handled\nin the ART runtime.\nThe JDWP thread no longer waits for the event thread to complete the\nmethod invocation. It now simply waits for the next JDWP command to\nprocess. This means it does not send any reply for invoke commands,\nexcept if the information given by the debugger is wrong. In this\ncase, it still sends a reply with the appropriate error code.\nThe event thread is now responsible for sending the reply (containing\nthe result and the exception object of the invoked method) before\ngoing back to the suspended state.\n\nIn other words, we add special handling for invoke commands so they\nare handled asynchronously while other commands remained handled\nsynchronously. In the future, we may want to handle all commands\nasynchronously (using a queue of reply/event for instance) to remove\nthe special handling code this CL is adding.\n\nNow the JDWP thread can process commands while a thread is invoking\na method, it is possible for the debugger to detach (by sending a\nVirtualMachine.Dispose command) before the invocation completes. In\nthat situation, we must not suspend threads again (including the\nevent thread that executed the method) because they would all remain\nsuspended forever.\n\nAlso minor cleanup of the use of JDWP constants and update comments.\n\nBug: 21515842\nBug: 18899981\nChange-Id: I15e00fb068340f3d69dc9225d8d2065246e68c58\n" }, { "commit": "e401d146407d61eeb99f8d6176b2ac13c4df1e33", "tree": "17927f9bfe7d2041b5942c89832d55f9dedb24c5", "parents": [ "2006b7b9b8e32722bd0d640c62549d8a0ac624b6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 13:56:20 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 29 18:45:49 2015 -0700" }, "message": "Move mirror::ArtMethod to native\n\nOptimizing + quick tests are passing, devices boot.\n\nTODO: Test and fix bugs in mips64.\n\nSaves 16 bytes per most ArtMethod, 7.5MB reduction in system PSS.\nSome of the savings are from removal of virtual methods and direct\nmethods object arrays.\n\nBug: 19264997\nChange-Id: I622469a0cfa0e7082a2119f3d6a9491eb61e3f3d\n" }, { "commit": "261bc044a3575512869586593e99e97cd8b1c321", "tree": "055fbf2bd3d7f836d4a872550ebe3c508eec5668", "parents": [ "bdd9f2d870099e326a281ac90993b37b999c35ea" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 08 09:36:07 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed May 13 09:23:00 2015 +0200" }, "message": "JDWP: more GC safety\n\nEnsures GC safety when keeping references that may be moved by GC:\n- SingleStepControl: stores ArtMethod* in a GcRoot\n- ModBasket: stores references in a StackHandleScope\n\nBug: 18166750\nChange-Id: If2b6f9ecff4cf469b50487fd863319fdfa9b9f37\n" }, { "commit": "9d6bf69ad3012a9d843268fdd5325b6719b6d5f2", "tree": "a41fc22d2c89e41c86feb5ef07ebda89b1b83d90", "parents": [ "b6829c2ee05124d64a19c7a52ada4a23f624fb91" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 10 12:12:33 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 29 16:59:58 2015 +0200" }, "message": "JDWP: properly combine location events\n\nThis CL properly groups JDWP events at the same location: Breakpoint,\nSingle-step, Method Entry and Method Exit. This is necessary if the\ndebugger is not the only instrumentation listener. This matches the\nbehavior of Dalvik, especially for methods with a single return\ninstruction.\n\nThe interpreter was tuned so the instrumentation callbacks were\ncalled to satisfy the debugger with the idea the debugger was the\nonly instrumentation listener. This is not true when method tracing\nis enabled at the same time.\nWhen tracing is enabled, there is always a listener for MethodEntry\nand MethodExit events (art::Trace class). However, if the debugger\nis only listening to DexPcMoved event (to manage JDWP Breakpoint\nevent), it will not be notified of this event.\n\nWe now properly call all the instrumentation callbacks in the\ninterpreter and move the logic specific to debugging into the class\nDebugInstrumentationListener. This allows to properly group JDWP\nlocation events together depending on the sequence of instrumentation\ncallbacks.\n\nWe add Thread::tls_32bit_sized_values::debug_method_entry_ flag to\nremember we just entered a method. It replaces the local variable\nnotified_method_entry_event in the interpreter and simplifies the\ncode.\n\nBump oat version to force recompilation because the layout of the\nThread class is modified.\n\nBug: 19829329\nChange-Id: I204af9112e37d2eebc86661fb7c961a41c74e598\n" }, { "commit": "2cebb24bfc3247d3e9be138a3350106737455918", "tree": "d04d27d21b3c7733d784e303f01f873bb99e7770", "parents": [ "1f02f1a7b3073b8fef07770a67fbf94afad317f0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 21 16:50:40 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 12:44:27 2015 -0700" }, "message": "Replace NULL with nullptr\n\nAlso fixed some lines that were too long, and a few other minor\ndetails.\n\nChange-Id: I6efba5fb6e03eb5d0a300fddb2a75bf8e2f175cb\n" }, { "commit": "c785344b87221f5e4e6473e5b762e4e61fe65dcf", "tree": "cd32ad2c2604596a18926f04d4c313dab255ecfd", "parents": [ "a29d93b380c9aeb8270e281aefbdd0c77a430d43" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 27 14:35:38 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 10 12:57:27 2015 -0700" }, "message": "Move ArtField to native\n\nAdd linear alloc. Moved ArtField to be native object. Changed image\nwriter to put ArtFields after the mirror section.\n\nSavings:\n2MB on low ram devices\n4MB on normal devices\n\nTotal PSS measurements before (normal N5, 95s after shell start):\nImage size: 7729152 bytes\n23112 kB: .NonMoving\n23212 kB: .NonMoving\n22868 kB: .NonMoving\n23072 kB: .NonMoving\n22836 kB: .NonMoving\n19618 kB: .Zygote\n19850 kB: .Zygote\n19623 kB: .Zygote\n19924 kB: .Zygote\n19612 kB: .Zygote\nAvg: 42745.4 kB\n\nAfter:\nImage size: 7462912 bytes\n17440 kB: .NonMoving\n16776 kB: .NonMoving\n16804 kB: .NonMoving\n17812 kB: .NonMoving\n16820 kB: .NonMoving\n18788 kB: .Zygote\n18856 kB: .Zygote\n19064 kB: .Zygote\n18841 kB: .Zygote\n18629 kB: .Zygote\n3499 kB: .LinearAlloc\n3408 kB: .LinearAlloc\n3424 kB: .LinearAlloc\n3600 kB: .LinearAlloc\n3436 kB: .LinearAlloc\nAvg: 39439.4 kB\n\nNo reflection performance changes.\n\nBug: 19264997\nBug: 17643507\n\nChange-Id: I10c73a37913332080aeb978c7c94713bdfe4fe1c\n" }, { "commit": "a2d40be3e64b339c6c39d59655507c597251e506", "tree": "011137a2bb46a6bc56e9b47c0e5c9d7978aa8ace", "parents": [ "9d0ab6f0a2f08c3fa9a59e0b8742cf366d7d0feb", "4e5b20863898006ec6c9d120cda167d38dda6e60" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 08 16:42:38 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Apr 08 16:42:39 2015 +0000" }, "message": "Merge \"Fix JDWP race at runtime shutdown\"" }, { "commit": "9b87d4a2f96bf935640f67b66d7d4cce867ceece", "tree": "305b448ca47d180c8c63e580a574d7cb70af126f", "parents": [ "caff30245889729f102af87e79705893401251ef", "2c3e77a0b91b2225fcdd3b34d8a734b85eec0579" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 07 15:16:13 2015 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Apr 07 15:16:13 2015 +0000" }, "message": "Merge \"JDWP: clear exception when allocation fails\"" }, { "commit": "bb87e0f1a52de656bc77cb01cb887e51a0e5198b", "tree": "113f014c6e20fab3e936a3ac05f9f738639541f6", "parents": [ "e57fc0f0260fcb1d08cbb720ec95c04c0f394b91" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 03 11:21:55 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Apr 06 10:44:37 2015 -0700" }, "message": "Refactor and improve GC root handling\n\nChanged GcRoot to use compressed references. Changed root visiting to\nuse virtual functions instead of function pointers. Changed root visting\ninterface to be an array of roots instead of a single root at a time.\nAdded buffered root marking helper to avoid dispatch overhead.\n\nRoot marking seems a bit faster on EvaluateAndApplyChanges due to batch\nmarking. Pause times unaffected.\n\nMips64 is untested but might work, maybe.\n\nBefore:\nMarkConcurrentRoots: Sum: 67.678ms 99% C.I. 2us-664.999us Avg: 161.138us Max: 671us\n\nAfter:\nMarkConcurrentRoots: Sum: 54.806ms 99% C.I. 2us-499.986us Avg: 136.333us Max: 602us\n\nBug: 19264997\n\nChange-Id: I0a71ebb5928f205b9b3f7945b25db6489d5657ca\n" }, { "commit": "2c3e77a0b91b2225fcdd3b34d8a734b85eec0579", "tree": "e963fb08cd1072cb78e448334582c95d37e1f95c", "parents": [ "c6e949a6d93fae2351fc59ed825657adee8185dc" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Apr 02 16:26:48 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Apr 02 16:51:24 2015 +0200" }, "message": "JDWP: clear exception when allocation fails\n\nClears pending exception if an allocation (requested by the debugger)\nfails and logs an error message about the failure.\n\nChecks we never leave a pending exception after processing a JDWP\nrequest.\n\nBug: 20037531\nChange-Id: I63239034a3c1ab368b0e19c2f5f756d9e2ec6a29\n" }, { "commit": "4e5b20863898006ec6c9d120cda167d38dda6e60", "tree": "8cb7e98c87a4e48e6237fd2c172ae39f5b7f5a76", "parents": [ "04914da1385564fca1990863d9a2690af10e1946" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Mar 24 19:03:40 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 01 12:22:52 2015 +0200" }, "message": "Fix JDWP race at runtime shutdown\n\nWhen the runtime shuts down, it closes the JDWP connection with the\ndebugger. However, if a JDWP command is still being processed by the\nJDWP handler thread when we close the connection, we won\u0027t be able to\nsend its reply.\n\nBug: 19628620\nChange-Id: I20301325a347d66f3b9ef95ebe8f156abafb1f76\n" }, { "commit": "d8565456d29f4ad05f11cf84d2d2dac488508e06", "tree": "8c5eca4c2604e0edc1606ea151d78538098dc040", "parents": [ "81adb4f8fd261be11d399d210029189e94888a9e" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 26 09:41:50 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 26 13:34:27 2015 -0700" }, "message": "Fix ClassLinker::MayBeCalledWithDirectCodePointer for JIT\n\nCurrently, we don\u0027t know if another method has a direct code\npointer or not. This should fix the case where breakpoints\noccasionally don\u0027t work with JIT.\n\nThe JIT now also checks that a method doesn\u0027t have any breakpoints\nbefore starting to compile it.\n\nBug: 17950037\n\nChange-Id: I17cfe874fe4825beba23903a5053d5cb27e106cb\n" }, { "commit": "eb07669e9784ccb41d75df180727e57fc4520e28", "tree": "bc15da11ee0ce906252a33371f8f59138bc5a38f", "parents": [ "bce0855ca1dbb1fa226c5b6a81760272ce0b64ef" ], "author": { "name": "Daniel Mihalyi", "email": "daniel.mihalyi@mattakis.com", "time": "Fri Aug 22 17:33:31 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Mar 24 14:43:57 2015 +0100" }, "message": "JDWP: Optimized single step during debugging\n\nFor single stepping full deoptimization and undeoptimizations were\nperformed with significant overhead, because every code will be\nexecuted in interpreted mode during a single step, even if it is not\nstrictly required.\n\nFor example, if we have a computation heavy method call and we would\nlike to step over it, that method (and all the methods called from it)\nwill run in interpreter mode. This can take so long in some cases\n(e.g. multiple minutes) that it makes debugging process unusable.\n\nThe solution for this limitation is not using full deoptimizations for\nsingle steps and force interpreter only for those methods that we are\nabout to step into, and require stack deoptimization before step outs.\n\nBug: 17750566\nBug: 18094282\nBug: https://code.google.com/p/android/issues/detail?id\u003d77984\n\nChange-Id: I683c52465883146c4c84ec47bf96f8efd920527f\nSigned-off-by: Daniel Mihalyi \u003cdaniel.mihalyi@mattakis.com\u003e\n" }, { "commit": "0aa50ce2fb75bfc2e815a0c33adf9b049561923b", "tree": "9a3f9603ab30d5cbc7fc21aee0ceb48bbb0dd25a", "parents": [ "e8e42f3548fd894f860912bb1b71ce6fa2d7daf3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 10 11:03:29 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 10 14:51:11 2015 +0000" }, "message": "Remove ThrowLocation.\n\nNote that this is a cleanup change, and has no functionality change.\nThe ThrowLocation had no use anymore.\n\nChange-Id: I3d2126af1dc673cec3a0453ff3d56a172663a5f6\n" }, { "commit": "1558b577907b613864e98f05862543557263e864", "tree": "5498d8d15f198341fe46a8badc7e7591611a09b5", "parents": [ "2cfdabd2bb4833d7092819d27ef08a9e1cdffead" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Feb 25 15:05:59 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Mar 09 15:19:49 2015 +0100" }, "message": "JDWP: allocate DebugInvokeReq only when requested\n\nOnly allocates thread-local DebugInvokeReq when the debugger requests\na thread to invoke a method. The JDWP thread allocates that structure\nthen attaches it to the target thread. When the thread is resumed, it\nexecutes the method. Once the invocation completes, the thread\ndetaches the DebugInvokeReq, signals the JDWP thread then suspends.\nFinally, the JDWP thread wakes up, prepares the reply with the invoke\nresult (or exception) and deallocates the DebugInvokeReq.\n\nAlso ensures GC safety for object returned by the invoke. We add the\nobject to the JDWP object registry right after the invoke. We now\nreference that object with a JDWP ObjectID instead of an Object* in\nthe DebugInvokeReq struct. This prevent from accessing a stale\nreference if the GC runs and moves the Object*.\n\nThis CL includes the following changes:\n- Move former DebugInvokeReq::ready flag to\n Thread::tls_32bit_sized_values::ready_for_debug_invoke. It\u0027s needed\n to know whether a thread has been suspended by an event, thus ready\n to invoke a method from the debugger.\n- Remove DebugInvokeReq::invoke_needed: we now test if we attached a\n DebugInvokeReq* to the thread.\n- Rename misleading FinishMethod function to RequestMethod.\n\nBug: 19142632\nBug: 18166750\nChange-Id: I351fb4eb94bfe69fcafb544d21d55ff35a033000\n" }, { "commit": "14691c5e786e8c2c5734f687e4c96217340771be", "tree": "7c2156671b323c70ffdd1d48d5e2f1d1de79c5fc", "parents": [ "3d7d2af4c6502b771b032ee9bf3ab30e78f9c60d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Mar 05 10:40:17 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 09 10:09:33 2015 +0000" }, "message": "Compute the right catch location for the debugger.\n\nAlso remove tls ThrowLocation, it is not needed anymore.\n\nChange-Id: I78fddf09ce968ca475e39c17fa76d699c589c8d9\n" }, { "commit": "b3b173bbbd1d1cbad555de13c3fa6765f5078bce", "tree": "89d380f42aed1a4c60db40f8be7d22501eaafa32", "parents": [ "e5f5953e744060fde3b4489cea4d934d529e3e32" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Feb 06 09:16:32 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Feb 17 22:42:43 2015 +0100" }, "message": "Follow up 129144\n\nPasses JDWP options to debugger on runtime init so we no longer need\nto keep them on the heap.\n\nUpdates ParseJdwpOption to return Result for consistency.\n\nBug: 19275792\nChange-Id: I68b7e58908164d3e4cf9e3fbcc3dfab6ce0579a5\n" }, { "commit": "3be6e9d904baa13d7cf51dfc6742dea12e766b2e", "tree": "43ad5f3655d73243ab212eefb83169471a1d87b3", "parents": [ "24898d447640c3a45e6fc9f404b049eddc5a2709" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Feb 05 16:30:58 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Feb 05 18:28:54 2015 +0100" }, "message": "Read JDWP options from runtime\n\nAllocates JDWP::JdwpOptions on the heap and copies parsed options to\navoid the need to include jdwp/jdwp.h into runtime.h file.\n\nAlso does some minor cleanup and removes the old JDWP options parsing\ncode that became dead code after we move it to the new command-line\nparser.\n\nBug: 19275792\nChange-Id: I71901c89fbf2cc3c1901a089e2a98b4326c6ee70\n" }, { "commit": "597c4f0aeafed2b6fa69e53ece4be4f53115d707", "tree": "71e374bcc1600810fcf0b25b3194bb65ef2dbf2a", "parents": [ "081d27817608c2ea035f2473c4ea1062a79bccef" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Jan 26 17:37:14 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Jan 26 20:15:02 2015 +0100" }, "message": "JDWP: allocate single step control only when active\n\nOnly allocates SingleStepControl when a single step is requested in\na thread.\n\nBug: 19142632\nChange-Id: I830b7eaea86b516d3fac80ce14d41c66b4bd5415\n" }, { "commit": "e34fa1df67fbe0173b4ea9abddcc3ae3d0537037", "tree": "a5148f079b5671a95f60910c41981ebf91db3a02", "parents": [ "9f06b1946ae3ef1d2fd75bbf7f0a288bc611fe58" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jan 14 14:55:47 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 15 12:23:28 2015 -0800" }, "message": "Print more info in MarkSweep::VerifyRoot\n\nRefactored old root callback to use a new class called RootInfo.\nRootInfo contains all the relevant info related to the root\nassociated with the callback. The MarkSweep::VerifyRoot function\nnow uses this info to print the StackVisitor\u0027s described location\nif the GC root is of the type kRootJavaFrame.\n\nSome other cleanup.\n\nExample output:\nE/art (12167): Tried to mark 0x123 not contained by any spaces\nE/art (12167): Attempting see if it\u0027s a bad root\nE/art (12167): Found invalid root: 0x123 with type RootJavaFrame\nE/art (12167): Location\u003dVisiting method\n\u0027void java.lang.Runtime.gc()\u0027 at dex PC 0xffffffff (native PC 0x0)\nvreg\u003d0\n\n(cherry picked from commit 12f7423a2bb4bfab76700d84eb6d4338d211983a)\n\nBug: 18588862\nChange-Id: Ic5a2781f704e931265ffb3621c2eab4b2e25f60f\n" }, { "commit": "ad466adf38db74a9840659626858196091151a64", "tree": "feb296965a8a9659787a949e8e9aca0a7180774c", "parents": [ "46af48acf4221a7f819d58dfffb576d0523ae285" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 08 16:28:08 2015 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 09 15:04:27 2015 -0800" }, "message": "Change hprof to use streaming\n\nPreviously, we compute the whole hprof dump in memory resulting in\n\u003e 50MB of memory usage for some apps (such as maps). This could\ncause the app to get killed by the low memory killer.\n\nThe solution works by doing the dump in 2 passes.\nThe first pass calculates the size of the dump.\nThe second pass starts by sending the DDMS header with the correct\nsize, then does the rest of the hprof dump by streaming and sending\ndata one HprofRecord at a time.\n\nBug: 18921793\nChange-Id: I7dd9f5cfe49799ba268095c994a8c2eb1fe493df\n" }, { "commit": "f3928794a10516e2ac0ffe2686a10891788d4b9c", "tree": "31648cbd1b6aa6bd7552c4d2664214626b702004", "parents": [ "bf75c5cf32a47eecadcc5e4a324237c1f1d09cde" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Nov 17 19:00:37 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Nov 19 14:35:28 2014 +0100" }, "message": "JDWP: only deoptimize when it is required\n\nWe don\u0027t need to deoptimize anything when we forced the use of the\ninterpreter (-Xint). In this case, no compiled code is executed\n(except native methods which are not concerned by deoptimization).\nTherefore we even don\u0027t need to enable/disable deoptimization support\nin instrumentation.\n\nWe also don\u0027t need to deoptimize a method that hasn\u0027t been compiled.\nSince it will run with interpreter, there is no point deoptimizing\nit. However this method may be inlined in a compiled caller method\nso we still need to deoptimize everything in this case.\n\nThis CL updates breakpoint support by storing the required kind of\ndeoptimization for a particular method. There are 3 cases:\n- kNothing: the method does not require deoptimization.\n- kSelectiveDeoptimization: the method needs to be deoptimized.\n- kFullDeoptimization: we must deoptimize everythinig.\nWhen uninstalling a breakpoint, we need to do the reverse operation.\n\nAlso fixes the SanityCheckExistingBreakpoints function to control\nbreakpoints related to the given method only and adds extra verbose\nlogs when choosing the appropriate deoptimization kind.\n\nBug: 18407046\nChange-Id: I5212c1fd2f72e06c79e7871db15696824d37dc0b\n" }, { "commit": "6a3c1fcb4ba42ad4d5d142c17a3712a6ddd3866f", "tree": "9df58b57af13240a93a6da4eefcf03f70cce9ad9", "parents": [ "c6e0955737e15f7c0c3575d4e13789b3411f4993" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 31 00:33:20 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Nov 03 20:01:04 2014 -0800" }, "message": "Remove -Wno-unused-parameter and -Wno-sign-promo from base cflags.\n\nFix associated errors about unused paramenters and implict sign conversions.\nFor sign conversion this was largely in the area of enums, so add ostream\noperators for the effected enums and fix tools/generate-operator-out.py.\nTidy arena allocation code and arena allocated data types, rather than fixing\nnew and delete operators.\nRemove dead code.\n\nChange-Id: I5b433e722d2f75baacfacae4d32aef4a828bfe1b\n" }, { "commit": "253fa555d9424a56c52879449eabe73d5c96cf61", "tree": "15ad96b41587b1b03aefb401da02f7c26c03ba5e", "parents": [ "3f5b8a1e7dfdf010591e17396d1d126740c5706c" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 14 17:27:15 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Oct 21 19:21:41 2014 +0200" }, "message": "Fix JDWP Virtualmachine.Resume command\n\nWe used to call ThreadList::UndoDebuggerSuspensions but this is not\ncorrect. Indeed Virtualmachine.Resume command should be performed\nas many times as all threads have been suspended (either by the\nVirtualmachine.Suspend command or the application of suspend policy\nALL for event).\n\nThis CL fixes this issue by adding ThreadList::ResumeAllForDebugger.\nIt decrements suspend count and debug suspend count by 1 (globally\nand for each thread).\n\nIt also handles the case where Virtualmachine.Resume is called while\nthreads have not been suspended (global debug suspend count is 0). In\nthis case we just print a warning and do nothing.\n\nBug: 17974047\nChange-Id: I25af22b1936760292d2a8c286e0867f2ae864108\n" }, { "commit": "8009f39c6d63181a6cd0e348ce732997dbdf3d20", "tree": "ff02473e6b0951364234a6038ae19a0875b7bdd7", "parents": [ "5cdd0734d2f79eedc530f5f1e876cd2110e29c86" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 01 17:07:11 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 22 11:29:36 2014 +0200" }, "message": "Optimize JDWP stack local values access\n\nThe StackFrame.GetValues and StackFrame.SetValues JDWP commands can refer to\nmultiple variables at the same time in a given frame. However we used to walk\nthe stack until getting to the requested frame for each variable.\n\nNow, we walk the stack only once until getting to the frame so the context is\ninitialized. Then we read/write value for each variable from this context.\n\nBug: 17343501\nBug: 15680615\n\nChange-Id: I2a4128f29a3c5856b994e280037c0a09eb48c5c8\n" }, { "commit": "6995c60cd6657c10811055c42661a55b10b47cef", "tree": "6fc528bca6f0c6fb989f88cb6af6c4829e1da172", "parents": [ "d41491adb23764f28a80cbb7f2bd7af6491cd892" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 09 12:10:13 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Sep 18 14:31:54 2014 +0200" }, "message": "Update JDWP event filtering to avoid useless ids\n\nTo reduce the number of JDWP ids in the debugger, we update the event filtering\nsupport to work with runtime objects (Thread, Class, Object, ...) instead of\nJDWP ids (ThreadId, RefTypeId, ObjectId, ...).\n\nWe used to create useless JDWP ids for events even if they were not reported\nbecause of event filtering (thread only, class only, instance only, ...). Now\nwe only create JDWP ids when we know we\u0027re going to report an event.\n\nBug: 17343664\n(cherry picked from commit d539167b7f11136fe570a77aff2ee4935842007a)\n\nChange-Id: I8619e219733fc2fa3569f473b7bd8d9af4181f2b\n" }, { "commit": "b0b0b496125c16620e99ea4e4a05693c281eccf1", "tree": "a73507873a28411f843b98701bcd0535d1dc361a", "parents": [ "97ca64b01e14de77ba14067b26069405d0dba0bf" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 15 11:27:27 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Sep 17 11:52:24 2014 +0200" }, "message": "Avoid crash in StringReference.Value JDWP command\n\nChecks for null or invalid object id. Also checks whether the corresponding\nobject is a java.lang.String.\n\nBug: 17492221\nBug: 15005460\n\n(cherry picked from commit 29259fa6b0514866d2d4bf57d58c1557b26abbb7)\n\nChange-Id: I52673bdef6912a4cccf5a6eeecb6e1e817b9dd6b\n" }, { "commit": "a06430c76981d545b5f2b64a7ef53c44c030cf73", "tree": "731fcb8361f9a3c1a4d08362ba50cf6e8a3736db", "parents": [ "0785b90a38f5f2f0d5a9e3890fd16dc63a3bca10" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 15 19:21:30 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 16 17:12:36 2014 +0200" }, "message": "Check for errors in ThreadGroupReference JDWP commands\n\nReturns INVALID_OBJECT error for null or invalid object. Also returns\nINVALID_THREAD_GROUP error when the object is not a java.lang.ThreadGroup.\n\nRemoves unused Dbg::GetMainThreadGroupId method.\n\nBug: 17503230\nChange-Id: Ifae39b0280633836655b22fc212018cb06b65c6c\n" }, { "commit": "844506b3f75b4643de8b326855daf03c2fbcc99c", "tree": "fe0804c1424e5c45314c260e019dabc592d0ba45", "parents": [ "ebab3bbcaa09b644acd50ec18d79cb0d239bf347" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 12 19:59:33 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 12 19:59:33 2014 -0700" }, "message": "Pass current thread as argument to alloc instrumentation.\n\nAvoids recomputation in the hot allocation path when instrumentation is\nenabled.\n\nChange-Id: Ic6e7d7d0744f4756787f75d21fddd3c50280b588\n" }, { "commit": "306db81aba41eb244a4e8299cf58ac18ae9999c7", "tree": "a069a9dda1b246466cbeee2736f46f18ef56714e", "parents": [ "b14339904c9cacc4af74260c7325e4eb32947f95" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Sep 05 13:01:41 2014 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Sep 05 13:24:24 2014 -0700" }, "message": "Fix numerous issues with DdmVmInternal allocation tracking\n\nIssues addressed:\n- Using without JDWP attached caused native crash.\n- When buffer is full (64k entries), number of entries reported was 0.\n- Disabling tracking after disabling tracking caused native crash.\n- Asking for allocations after disabled caused native crash.\n- Lock ordering issues between mutator lock and alloc tracker lock.\n\nAdding 098-ddmc test to cover these cases.\n\nBug: 17392248\n\n(cherry picked from commit a5815065ac0877add9c0db3605d27b4d6c426e61)\n\nChange-Id: Ib0bc18dfcdafcc050ab9dceed3d167dd878d1d7a\n" }, { "commit": "c0542af3e2170143ba40d89136e284997e16bf64", "tree": "a61e3b9cd297a4c52a0c0488a502cb77c47f0690", "parents": [ "d3c9358544bbab15093614c5c2b6a9de86e11f7b" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 03 16:16:56 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 03 17:15:54 2014 -0700" }, "message": "Remove abuse of mirror::Object* to reference special values.\n\nRemove kInvalidIndirectRefObject, kClearedJniWeakGlobal and\nObjectRegistry::kInvalidObject. Handle error conditions by passing in or\nreturning an error value.\nGetObjectRefType is simplified to be faster and not return invalid references\nthat are not expected according to the spec. Adjust check JNI and\njni_internal_test appropriately.\nFix cases in the debugger/JDWP of out arguments being passed by reference.\nBug: 17376993\n\nChange-Id: I3ce8a28c01827e163f4dc288449959464da788b1\n" }, { "commit": "0ec17d2ddb69d3f5c46ccad62e82c0ffd6219428", "tree": "a90ae1adaf549f474cc9d269f6ef5fe0062128d6", "parents": [ "e8a30f37bf1530a80a7df17692dbe7a68764ac30" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Mon Jul 07 13:07:08 2014 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Jul 08 11:23:34 2014 -0700" }, "message": "Remove Dbg::VisitRoots().\n\nWe replace the GC strong roots with JNI.\n\njdwp_test passes.\n\nBug: 12687968\nChange-Id: I841f1aaa5dffa784ca25953a251600f70df273b2\n" }, { "commit": "4345c46b8a927cf13d9bbe38f8cf0593f5de181b", "tree": "f89b8edfa245d16c6ceffa512233140f53cfd0c2", "parents": [ "f55159c145e8b07be1dcafc949afda7e6a2f41c5" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jun 27 10:20:14 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jul 08 09:42:03 2014 -0700" }, "message": "Fix local reference leaks in debugger and use a cache.\n\nChanged alloc record stack trace element to use jmethodID instead of\nJNI weak global references. Added code to delete the local ref\ncreated in AllocRecord::SetType.\n\nBug: 15886342\nExternal bug: https://code.google.com/p/android/issues/detail?id\u003d72330\n\nChange-Id: Id18e765820baad02246768dc9d633aada60f4fed\n" }, { "commit": "b5a9e3d1cc1fd66683e43e365afc8c900e2800c4", "tree": "5b259807b4c5c67c532050939458a8390234a7a0", "parents": [ "3b95d23f44485d207aa6ef298dc744fa2355578b" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Mon Jun 09 12:11:20 2014 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Jun 11 14:46:13 2014 -0700" }, "message": "Remove Object* weak roots from the debugger.\n\nThe weak roots were converted to JNI weak refs.\n\nSince the weak roots are now normal JNI weak refs, we eliminate the\nneed to insert read barriers for those weak roots in the debugger and\nthe need for the GC to have a separate step to update them as part of\nthe system weak sweeping.\n\nBug: 12687968\nChange-Id: If16396d4713457b8af4f1ea6a0c6ec6799cb615e\n" }, { "commit": "cdf05ab175c64adb49eb97d6dd35e885bbcad072", "tree": "8ff69a58a36eead9f4b6479c49e5309c0128e518", "parents": [ "3b9097d502fbe47ec897db3ab64f70b5e0d309c9", "42cd43fa593e8f0427eb0ec158bef08814a6180b" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu May 15 08:10:45 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu May 15 08:10:45 2014 +0000" }, "message": "Merge \"Register debugger for interesting instrumentation events only\"" }, { "commit": "42cd43fa593e8f0427eb0ec158bef08814a6180b", "tree": "ad4231ee8a812e7702ddefdf6c9b9061a178d674", "parents": [ "e1910f1d802dff79bba5ef61e1c4fd0b95f6e5b0" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue May 13 14:15:41 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu May 15 09:25:48 2014 +0200" }, "message": "Register debugger for interesting instrumentation events only\n\nThis avoids the overhead of notifying events (like method entry/exit, field\nread/write, ...) from the interpreter when they are not requested on the JDWP\nside. It also avoids burning JDWP ids for objects and classes before we find\nout we do not need to report the event.\n\nWhen we register a JDWP event (like a breakpoint), we add the debugger as\na listener for the corresponding instrumentation event (like kDexPcChanged).\nOn the other hand, when a JDWP event is cleared, we remove the debugger as a\nlistener for the corresponding instrumentation event. To control we add/remove\nthe debugger as listener only once per instrumentation event, we use reference\ncounting.\n\nLike deoptimization, we can update instrumentation listeners only when when all\nmutator threads are suspended. To add or remove the debugger as listener, we\nextend the support of deoptimization requests to a more general support dealing\nwith instrumentation requests.\nWe add kRegisterForEvent and kUnregisterForEvent request kinds, respectively to\nadd or remove the debugger as a listener for a given instrumentation event.\nNote: we will rename the related classes, methods, ... to avoid pollution in\nthe code review.\n\nThis CL also fixes Instrumentation::IsActive to take field read/write events\ninto account.\n\nBug: 14401699\nBug: 14826953\nChange-Id: Ic896469e82a8589de419ebea4b9dc3116925f3ab\n" }, { "commit": "8379b2256be5d2be4ad083a76e9f8ec403c4d405", "tree": "23a6cc143b59feaa2f6876dad1260b7c07e0f40d", "parents": [ "e1910f1d802dff79bba5ef61e1c4fd0b95f6e5b0" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Feb 24 17:38:15 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon May 12 16:15:48 2014 +0200" }, "message": "Combine JDWP location events\n\nThe runtime now sends location events BREAKPOINT, SINGLE_STEP, METHOD_ENTRY,\nMETHOD_EXIT and METHOD_EXIT_WITH_RETURN_VALUE in the same JDWP event packet\nwhen they relate to the same location.\n\nWe update the Dbg::UpdateDebugger method to take initial event flags and\nreturned value. It allows to call this method from DebugInstrumentationListener\nso we can treat method entry/exit events with breakpoint and single-step.\n\nIn the interpreter, we ensure we do not call Instrumentation::DexPcMovedEvent\nwhen Instrumentation::MethodEnterEvent has just been called or when we\u0027re about\nto call Instrumentation::MethodExitEvent. This prevents from sending duplicated\nevents.\n\nI measured the average performance impact on some benchmarks with a Nexus 4\nwithout a debugger attached:\n* 1%-2% for the computed-goto-based interpreter (default interpreter)\n* 5%-10% for the switch-based interpreter.\nThis is mostly due to the test of the boolean flag for the method entry event.\n\nBug: https://code.google.com/p/android/issues/detail?id\u003d68427\nBug: 11874828\nChange-Id: Ic4ff61375ff6b4ed5825adeac09f61f97b4be619\n" }, { "commit": "ea8106321c7c05f8b135d7b4cdb34f5d1e6ed0e3", "tree": "db61c57b6c15aa8927758025b7ebd4ce278f8ace", "parents": [ "6123d94cddf34f3fdb8ece55476e414e34662394", "7ec2f1ca3cbd021848da75d5566f7239ce29676f" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 22 07:05:52 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Apr 22 07:05:54 2014 +0000" }, "message": "Merge \"Speed up single-stepping\"" }, { "commit": "c311d0c85e17773042daaa7a4abc58b3e3c0a0c1", "tree": "12103a18b43dd863ab7f3fd51ce9600ef4754d95", "parents": [ "0a01b38244053e72f33339e733b3ae5e15a5966b", "3f52eafe5577b8489f90dc8ed5981b3455206147" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 15 06:43:14 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Apr 15 06:43:14 2014 +0000" }, "message": "Merge \"Prepare field watchpoint support\"" }, { "commit": "3f52eafe5577b8489f90dc8ed5981b3455206147", "tree": "7155df948d345c8a5a2d801c23b396af76527ba0", "parents": [ "9b417e4f0f87da6bfe8dc5f02c987acfcb6dca31" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 04 17:50:18 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 15 08:39:18 2014 +0200" }, "message": "Prepare field watchpoint support\n\nAdds field read/write events in the instrumentation. The debugger now registers\nas a listener for these events so JDWP field access and field modification\nevents can be reported.\n\nThis CL will be followed by another one to report these events from the\ninterpreter. Therefore no JDWP field access and field modification events\ncan be sent for now.\n\nBug: 8267708\nChange-Id: If2a93eb590805567d69015c83cce9cd2ab712cbd\n" }, { "commit": "bb43b433c845e253a11346f0f03706d58a44f23c", "tree": "406fda2973407461cbadd7d0bf45afc109bfedad", "parents": [ "9b417e4f0f87da6bfe8dc5f02c987acfcb6dca31" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Apr 14 11:59:08 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Apr 14 12:01:15 2014 +0200" }, "message": "Clear unused roots from debugger\n\nSingleStepControl and DebugInvokeReq hold roots which are only used during a\nlimited amount of time. Clear these roots once we finish using them.\n\nAlso cleans some code around single-step.\n\nChange-Id: Ica2f65e04a4d60272199490cd40ad1803d3b9f02\n" }, { "commit": "7ec2f1ca3cbd021848da75d5566f7239ce29676f", "tree": "fd2f221e9598fc7fa5066b2a9c746b228ef53faf", "parents": [ "2be6fc74bce10ac68d3d1b39a5019f520ad170ea" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Mar 27 20:06:47 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 09 18:23:28 2014 +0200" }, "message": "Speed up single-stepping\n\nDuring single-stepping sequence, we need to deoptimize everything when we\nregister a single-step event and undeoptimize everything when it is done. This\ncauses a slow pattern where we continuously deoptimize-undeoptimize everything\nfor each single-step.\n\nThis CL introduces a special handling of single-step undeoptimization. We now\ndelay the undeoptimization to the next resume (one thread or all threads) or\nthe end of the debugging session. Indeed, a single-step event registration is\nalways followed by a resume command.\nAt the \"resume\" point, we know if a single-step event is registered and if we\nreally need to undeoptimize. At the \"registration\" point, we know we did not\nundeoptimized everything so we don\u0027t need to deoptimize everything again.\nTherefore, in a sequence of single-steps, we only do a full deoptimization for\nthe first single-step and a full undeoptimization for the last single-step.\n\nWe update logs at deoptimization points so we can track more precisely. Note\nthey are verbose logs that still must be enabled with -verbose:jdwp option.\n\nWe also make some improvement inside instrumentation:\n* updates Instrumentation::ShouldNotifyMethodEnterExitEvents to comply with its\nname.\n* compute frame id only once when looking for the corresponding instrumentation\nframe.\n* compute the OatMethod once in ClassLinker::GetPortableOatCodeFor to avoid\nlooking for it again.\n\nBug: 13577964\nChange-Id: If6fa198a676b515cd474b8c4d7bf7ef3626f2dc7\n" }, { "commit": "4d25df3f76f864b7629ac8c0046d46997f293d8d", "tree": "31840831d8c81d06ffd575fdb0adc8403cd8dbb1", "parents": [ "909f133bc938928a2403baccc983701cb9ebb17f" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Mar 21 17:44:46 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Mar 26 11:46:43 2014 +0100" }, "message": "Refactor deoptimization support in debugger\n\nThis CL prepares breakpoint support for inlined methods where we\u0027ll have to\ndeoptimize everything.\n\nWe move deoptimization-related information to Dbg class only (deoptimization\nrequest queue, full deoptimization event count and deoptimization lock). We\nreplace MethodInstrumentionRequest by DeoptimizationRequest. This is used to\nknow which kind of deoptimization is required for a particular event.\n\nIt also simplifies lock ordering a bit during event setup: we no longer need to\nhold the deoptimization lock while holding the breakpoint lock. Moreover, the\ndeoptimization lock should be held only after the event list lock.\n\nBug: 12187616\nChange-Id: Iff13f004adaeb25e5d609238bacce0b9720510e6\n" }, { "commit": "3b05e9ba874449dbff65b01b8781001f7d93eea6", "tree": "f341766bff83ebea510344c4857af493725d3f58", "parents": [ "027f7fa539514d2a50b448de1de39ac307087483" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 25 09:29:43 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 25 13:56:58 2014 -0700" }, "message": "Add missing debugger root visiting.\n\nBug: 13634574\nChange-Id: I2a76f6c43f1d0ad1922f06deb40a71ff651129fd\n" }, { "commit": "cb19ebf7609f74b223bd86c94f721498795f9bba", "tree": "0db31e4f83046b3d8159d4ba28d9298ff94e06c3", "parents": [ "f17ce4c5e3b6882aa8849d1ed82df4238c436da2" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Mar 11 15:26:35 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Mar 17 09:15:31 2014 +0100" }, "message": "Fix debugger crash in native method frames.\n\nThe main crash happens when we try to read (StackFrame::GetValues) or write\n(StackFrame::SetValues) values in native frames. We use the method\u0027s vmap to\nknow where Dalvik registers live but native methods don\u0027t have vmap. The fix\nis to reply with the OPAQUE_FRAME error which indicates local values are not\naccessible in the frame.\n\nWe prevent from dereferencing null code item which causes some crashes too.\nThis happens when we compute the line table (Method::LineTable) and variable\ntable (Method::VariableTable) of methods without code: native, proxy and\nabstract methods. We do not expect to encounter abstract methods though. We\ntake care of these kinds of method when mangling/demangling local value slots.\n\nWe also fix the location\u0027s pc of native and proxy frames where it must be -1\n(as 8-byte value). We\u0027ll use this property to detect such frames in the JDWP\ntests.\n\nBug: 13366758\nChange-Id: I78e3263fbf2681b5573571c846390d52b9193849\n" }, { "commit": "52d131d8e71ae9ea915ea84a3f95d49547e8e661", "tree": "4a723664a9634747d273e12c87a396db160f50f6", "parents": [ "37d4c1db4d705f5a28001f65afdd68d0527948d8" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Mar 13 16:17:40 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Mar 13 17:03:50 2014 +0100" }, "message": "Fix thread suspension assertion in debugger.\n\nUpdates Dbg::GetThreadGroup to ensure we do call EndAssertNoThreadSuspension\nafter StartAssertNoThreadSuspension and not returning in the middle. Note this\nonly happens in debug mode where this assertion is enabled.\n\nAlso add missing thread safety annotations.\n\nBug: 13425576\nChange-Id: Idb9f32d289038b77771369c1283774676ff433c7\n" }, { "commit": "719d1a33f6569864f529e5a3fff59e7bca97aad0", "tree": "fcd84efd7b9806b93ec1a44e2317e6f882e7fe0e", "parents": [ "5365eea9940269b662cfbe103caa348816ff1558" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 06 12:13:39 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 06 19:16:01 2014 -0800" }, "message": "Enable annotalysis on clang ART builds.\n\nFix clang build errors aswell as restructure locking/mutex code for correct\nthread safety analysis support.\nReorder make dependencies so that host builds build first as they should\nprovide better compilation errors than target.\nRemove host\u0027s use of -fno-omit-frame-pointer as it has no value with correct\nuse of CFI, which we should have.\n\nChange-Id: I72cea8da9a3757b1a0b3acb4081feccb7c6cef90\n" }, { "commit": "83c8ee000d525017ead8753fce6bc1020249b96a", "tree": "d5167ed15dee2629905ac3640b6ea0578d4ae312", "parents": [ "7cba217ab0661d74deccbb97160cdf60b74d4ea3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 28 14:50:23 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 11 10:40:10 2014 -0800" }, "message": "Add root types and thread id to root visiting.\n\nEnables us to pass the root type and thread id to hprof.\n\nBug: 12680863\nChange-Id: I6a0f1f9e3aa8f9b4033d695818ae7ca3460d67cb\n" }, { "commit": "412c7fced915fc8d4d5e4166e977d55c809168a6", "tree": "b8efee7f46a440f3e89765b1e9b2aa6454839c87", "parents": [ "109e2b34799a377a0407781fc32ec1ec607d6c41" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 07 12:18:39 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sat Feb 08 15:23:36 2014 -0800" }, "message": "Make debugger / jdwp compaction safe.\n\nFixed GetInstances, GetReferringObjects, CountInstances to use\nVisitObjects instead of the live bitmap.\n\nWe now treat the object registry as system weaks and update the\nobjects when/if they move. Also added the recent_allocation_records_\nas roots.\n\nBug: 12936165\n\nChange-Id: I615c289efbf2977ceab5c4ffa73d216d799e6e33\n" }, { "commit": "ef7d42fca18c16fbaf103822ad16f23246e2905d", "tree": "c67eea52a349c2ea7f2c3bdda8e73933c05531a8", "parents": [ "822115a225185d2896607eb08d70ce5c7099adef" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jan 06 12:55:46 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Feb 06 23:20:27 2014 -0800" }, "message": "Object model changes to support 64bit.\n\nModify mirror objects so that references between them use an ObjectReference\nvalue type rather than an Object* so that functionality to compress larger\nreferences can be captured in the ObjectRefererence implementation.\nObjectReferences are 32bit and all other aspects of object layout remain as\nthey are currently.\n\nExpand fields in objects holding pointers so they can hold 64bit pointers. Its\nexpected the size of these will come down by improving where we hold compiler\nmeta-data.\nStub out x86_64 architecture specific runtime implementation.\nModify OutputStream so that reads and writes are of unsigned quantities.\nMake the use of portable or quick code more explicit.\nTemplatize AtomicInteger to support more than just int32_t as a type.\nAdd missing, and fix issues relating to, missing annotalysis information on the\nmutator lock.\nRefactor and share implementations for array copy between System and uses\nelsewhere in the runtime.\nFix numerous 64bit build issues.\n\nChange-Id: I1a5694c251a42c9eff71084dfdd4b51fff716822\n" }, { "commit": "138dbfc3336e379d74d157086f69a0fbe830089b", "tree": "f5fa88466e6ab339d2a6faf9c9105bafcaee3ea7", "parents": [ "62e45483db4aa1be096d3ce91903e01ef52fb901" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Dec 04 18:15:25 2013 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Jan 13 15:08:24 2014 +0100" }, "message": "Selective deoptimization.\n\nUpdate the instrumentation to allow selective deoptimization.\n\nSeparate instrumentation listener registration from stubs configuration. A\nlistener is now responsible for configuring the appropriate stubs.\n- The method tracing listener installs instrumentation entry/exit stubs or\nthe interpreter depending on the accuracy of events we want (controlled by\nkDeoptimizeForAccurateMethodEntryExitListeners).\n- The debugger registers itself as an instrumentation listener but does not\nmodify methods entrypoints. It only does this on demand when deoptimizing one\nmethod or all the methods.\n\nThe selective deoptimization is used for breakpoint only. When a breakpoint is\nrequested, the debugger deoptimizes this method by setting its entrypoint to\nthe interpreter stub. As several breakpoints can be set on the same method, we\ndeoptimize only once. When the last breakpoint on a method is removed, we\nreoptimize it by restoring the original entrypoints.\n\nThe full deoptimization is used for method entry, method exit and single-step\nevents. When one of these events is requested, we force eveything to run with\nthe interpreter (except native and proxy methods). When the last of these\nevents is removed, we restore all methods entrypoints except those which are\ncurrently deoptimized.\n\nDeoptimizing a method requires all mutator threads be suspended in order to\nwalk each thread\u0027s stack and ensure no code is actually executing while we\nmodify methods entrypoints. Suspending all the threads requires to not hold\nany lock.\nIn the debugger, we deoptimize/undeoptimize when the JDWP event list changes\n(add or remove a breakpoint for instance). During the update, we need to hold\nthe JDWP event list lock. This means we cannot suspend all the threads at this\ntime.\nIn order to deal with these constraints, we support a queue of deoptimization\nrequests. When an event needs selective/full deoptimization/undeoptimization,\nwe save its request in the queue. Once we release the JDWP event list lock, we\nsuspend all the threads, process this queue and finally resume all the threads.\nThis is done in Dbg::ManageDeoptimization. Note: threads already suspended\nbefore doing this remain suspended so we don\u0027t \"break\" debugger suspensions.\n\nWhen we deoptimize one method or every method, we need to browse each thread\u0027s\nstack to install instrumentation exit PC as return PC and save information in\nthe instrumentation stack frame. Now we can deoptimize multiple times during\nthe execution of an application, we need to preserve exisiting instrumentation\nframes (which is the result of a previous deoptimization). This require to push\nnew instrumentation frames before existing ones so we don\u0027t corrupt the\ninstrumentation stack frame while walking the stack.\n\nBug: 11538162\nChange-Id: I477142df17edf2dab8ac5d879daacc5c08a67c39\n" }, { "commit": "d38667a055d507492fd05f78519a7e1f0b85ea03", "tree": "d71f7695f0ec3f4fa5beae55a81789592b295502", "parents": [ "2054553237998043f0cd3d6b9fef799a4e6d95c0" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Nov 25 15:43:54 2013 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Nov 25 17:02:54 2013 +0100" }, "message": "Minor field name cleanup in debugger.\n\nUse the same naming convention for all fields of DebugInvokeReq structure.\n\nChange-Id: Ieaf65eef592f96efa47975eef15334279ed4fc8a\n" }, { "commit": "2054553237998043f0cd3d6b9fef799a4e6d95c0", "tree": "417ccbc5f75eaf36cfd0b62c8eb169b29975dddc", "parents": [ "212d2ab3f5b92095e90008f27293531fc311e96d", "61b7f1b05d1fe12d4009316263bf990903e4edff" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Nov 20 08:47:55 2013 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Wed Nov 20 08:47:56 2013 +0000" }, "message": "Merge \"Move single-step control into thread.\" into dalvik-dev" }, { "commit": "61b7f1b05d1fe12d4009316263bf990903e4edff", "tree": "7929d410750a8099ef254d3858d1da87d595bac8", "parents": [ "03aca12cc4b15a4d2fe1c6acbcb1d62b2baa9eb4" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Nov 15 15:59:30 2013 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Nov 19 21:13:27 2013 +0100" }, "message": "Move single-step control into thread.\n\nThis CL moves single-step control into the Thread structure. This is stored in\nThread::single_step_control_ member. This allows to support single-stepping of\nmultiple threads at the same time.\n\nSince each thread holds its single-step information, we no longer need to use\nthe breakpoint lock to support single-stepping. It helps reduce lock contention\non this lock while debugging.\n\nAll JDWP tests passed on the host and on the target with this CL.\n\nBug: 11667502\nChange-Id: I886d5c8c625ca5a072803e296c32eec5f7e9e82d\n" }, { "commit": "579b02416e05e32e535126e1ed61613a2cdb030e", "tree": "4431587a30c1d5a3e7c0435decbd7ac21104bf7a", "parents": [ "e4a50ee34695a9d90cf03fbb1e8afd1e434f6ee1" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Mon Nov 18 13:16:49 2013 -0800" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Nov 19 11:16:44 2013 -0800" }, "message": "Add support for JDWP METHOD_EXIT_WITH_RETURN_VALUE events.\n\nBug: 11569539\nChange-Id: Ibc7a80df83470ffd726d73695a05f4938248f292\n" }, { "commit": "fc0e94bed3f88ed7e50854fd8dfaf5dcb345250f", "tree": "5cfbe05084351576e9659cb8f7b66dcb6163a37b", "parents": [ "576fe9d4181c749aa510e32d2521ed4192bdfda0" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Sep 23 23:51:32 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Sep 24 17:07:24 2013 -0700" }, "message": "StringPiece clean up.\n\nProfile guided clean up.\nTry to avoid creating StringPieces with the contents of a dex file where\nthe length is known.\nTry to avoid RegTypeCache::FromDescriptor when there\u0027s a class available.\nMake ConstantType::ConstantValue inlinable.\nSaving of about 50ms from a 2 threaded ThinkFree compile on host.\n\nChange-Id: I47a12c3c76f46e2c9805be1c3a3e3870fe1f5d85\n" }, { "commit": "920af3e556c730a5fbdab90a6d0ec1a2dbe8940b", "tree": "29d7aa78d4a4fec87a403c8e2c93214d19b7cc99", "parents": [ "10cc81056261625902a8a073bafb9f499eec4ff7" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Wed Aug 28 15:46:38 2013 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Thu Aug 29 10:03:52 2013 -0700" }, "message": "Fix thread status in THST chunk to use JDWP thread state.\n\nBug: 10492287\n\nChange-Id: I830a2ce71d02c5b09c7040583be98d818eef9385\n" }, { "commit": "ea46f950e7a51585db293cd7f047de190a482414", "tree": "9dddc8073547a2dcb58a19e1728932a89cb149c3", "parents": [ "5e3572709b5a5d59957f835db4f73760ecef08da" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Tue Jul 30 01:26:50 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 13 18:09:46 2013 -0700" }, "message": "Refactor java.lang.reflect implementation\n\nCherry-picked from commit ed41d5c44299ec5d44b8514f6e17f802f48094d1.\n\nMove to ArtMethod/Field instead of AbstractMethod/Field and have\njava.lang.reflect APIs delegate to ArtMethod/ArtField.\n\nBug: 10014286.\n\nChange-Id: Iafc1d8c5b62562c9af8fb9fd8c5e1d61270536e7\n" }, { "commit": "7934ac288acfb2552bb0b06ec1f61e5820d924a4", "tree": "43f3acd8af7fd34d4ae7b64f6e06bb8429d74bb8", "parents": [ "fb331d7ca004f39608fcfdae49d38df90c702ea9" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 10:54:15 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 26 11:55:10 2013 -0700" }, "message": "Fix cpplint whitespace/comments issues\n\nChange-Id: Iae286862c85fb8fd8901eae1204cd6d271d69496\n" }, { "commit": "2d88862f0752a7a0e65145b088f49dabd49d4284", "tree": "3fac6bbd9a0ff3836f361e46579151c8a93420b6", "parents": [ "751d4ed43e8118f145edf18db4d987daf7dabbae" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu Jul 18 17:02:00 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu Jul 18 17:02:52 2013 -0700" }, "message": "Fixing cpplint readability/casting issues\n\nChange-Id: I6821da0e23737995a9b884a04e9b63fac640cd05\n" }, { "commit": "f69863b3039fc621ff4250e262d2a024d5e79ec8", "tree": "b6d40c4019de2155f8753f83b4750bd3a3514d7a", "parents": [ "93ba893c20532990a430741e0a97212900094e8c" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 21:53:13 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 23:23:12 2013 -0700" }, "message": "Fix cpplint whitespace/newline issues\n\nChange-Id: Ie2049d9f667339e41f36c4f5d09f0d10d8d2c762\n" }, { "commit": "fc0e3219edc9a5bf81b166e82fd5db2796eb6a0d", "tree": "5fc7f5b941724a62f8e3411df09fae431ff5e3cf", "parents": [ "56d947fbc9bc2992e2f93112fafb73e50d2aaa7a" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 14:40:12 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jul 17 16:49:05 2013 -0700" }, "message": "Fix multiple inclusion guards to match new pathnames\n\nChange-Id: Id7735be1d75bc315733b1773fba45c1deb8ace43\n" }, { "commit": "7940e44f4517de5e2634a7e07d58d0fb26160513", "tree": "ac90242d96229a6942f6e24ab137bc1f8f2e0025", "parents": [ "5cd9e3b122f276f610980cbaf0d2ad6ed4cd9088" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 13:46:57 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jul 12 17:49:01 2013 -0700" }, "message": "Create separate Android.mk for main build targets\n\nThe runtime, compiler, dex2oat, and oatdump now are in seperate trees\nto prevent dependency creep. They can now be individually built\nwithout rebuilding the rest of the art projects. dalvikvm and jdwpspy\nwere already this way. Builds in the art directory should behave as\nbefore, building everything including tests.\n\nChange-Id: Ic6b1151e5ed0f823c3dd301afd2b13eb2d8feb81\n" }, { "commit": "62d6c772205b8859f0ebf7ad105402ec4c3e2e01", "tree": "e2f2ba6d71ed5a39c9f6909e3f7c08e998053315", "parents": [ "c9b17c7ee96cd04fac9048aab624ed554fe260bf" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Feb 27 08:32:07 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Apr 08 14:24:13 2013 -0700" }, "message": "Interpreter entries and instrumentation as a listener.\n\nMake the instrumentation responsible for whether we want method entry/exit\nstubs, and allow it to use interpreter entry stubs when instruction by\ninstruction instrumentation is required. Improve deoptimization so more JDWP\ntest cases are passing.\n\nRefactor exception debug posting, in particular improve reporting in the\ninterpreter. Improve class linker exception throwing so that broken dex files\nare more likely to be reported. Fixes the performance issue Bug: 8410519.\n\nFix some error reporting lock level errors for the large object space. Make\nfast object verification faster.\n\nAdd some debug mode robustness to finding dex PCs in GC maps.\n\nAdd printf attributes to JniAbortF and fix errors.\n\nExpand run-test 044 to test return behaviors and fix issues with not throwing\nappropriate exceptions for proxies.\n\nEnsure causes are reported with a class linker NoClassDefFoundError and JNI\nNoSuchFieldError.\n\nRemove unused debugMe and updateDebuggerFromCode.\n\nThere\u0027s a minor sizing tweak to the arg array builder, and an extra reference\narray check in the interpreter.\n\nSome clean-up of trace code.\n\nFix reg type cache destructor if it is called after the reg type cache is\nshutdown (as is the case in oatdump).\n\nChange-Id: I6519c7b35df77f978d011999354c864f4918e8ce\n" }, { "commit": "0f827169742aad6209d830db773a101849c32a83", "tree": "df06bd3d9fa91757d2c87fbe891007184f823e9d", "parents": [ "eb5cb608fcb0d636961653ad561b2c7ee40de1ad" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 26 12:12:58 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 26 12:12:58 2013 -0800" }, "message": "Fix JDWP ObjectRegistry lock ordering.\n\nAlso make debugging lock ordering violations nicer by using our\nLockLevel operator\u003c\u003c.\n\nChange-Id: Ic15ebe70363a90a09f6491bd5c336a604e9d6c48\n" }, { "commit": "4b9702c6912c6f8745a77f5b5af56e7fe196e7c2", "tree": "02fee3631b7f3b60eb15f791b5dd004b27d6a571", "parents": [ "64f574f474aa77c72778640ab21f8cfa72546812" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Feb 20 18:13:24 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Feb 21 07:41:59 2013 -0800" }, "message": "Add a JDWP::Request type to replace the old uint8_t* and int.\n\nThis also lets us check that all the data in a (successful) request\nis actually read, though doing so caught two bugs in the tests, and\nmay well catch bugs in the actual debuggers.\n\nChange-Id: Ibed402e6f1c0c7a1d19d61f0be9bddd0c2f5a388\n" }, { "commit": "64f574f474aa77c72778640ab21f8cfa72546812", "tree": "c90d3ef8f56144e61a4a043138a5118c3c9e7b9a", "parents": [ "492899e445c21f09db458c76d773d571cc6cc0ac" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Feb 20 14:57:12 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Feb 20 15:46:06 2013 -0800" }, "message": "Implement EnableCollection, DisableCollection, IsCollected, and fix Exit.\n\nRewrites the object registry to not just be one big leak. We use jweaks\nby default, which means (a) the GC doesn\u0027t need to know anything about us\nand (b) we don\u0027t cause unnecessary heap retention. We promote to regular\nJNI global references if the debugger asks us to.\n\nThe problem with VirtualMachine.Exit turned out to be that you\u0027re supposed\nto send a success reply to the command before exiting. This is a bit awkward\nwith our current division of responsibilities, but it lets us pass another\ntest.\n\nAlso log a summary of our replies when -verbose:jdwp is in effect, not\njust the requests.\n\nChange-Id: Idb33e99fe7d8bee7a79152d81fee42e2af00852b\n" }, { "commit": "2dd0e2cea360bc9206eb88ecc40d259e796c239d", "tree": "9d619dc9508cbe73e4793bf6f08cbc761abfb48a", "parents": [ "ac21b797b3a425975d656d6b84a7b24401d35f42" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jan 24 12:42:14 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jan 30 16:48:31 2013 -0800" }, "message": "Directory restructuring of object.h\n\nBreak object.h into constituent files.\nReduce number of #includes in other GC header files.\nIntroduce -inl.h files to avoid mirror files #include-ing each other.\nCheck invariants of verifier RegTypes for all constructors.\n\nChange-Id: Iecf1171c02910ac152d52947330ef456df4043bc\n" }, { "commit": "a96836a4115ad08762567c10bd4d198c5b644985", "tree": "ae523d318a1936108b9f137af3681de930628aa1", "parents": [ "fa011c82efce92a8e0e739ae9732b4c6f3903294" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 17 12:27:49 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 17 12:27:49 2013 -0800" }, "message": "Improve -verbose:jdwp.\n\nMove toward automated logging instead of ad hoc logging in every command.\n\nChange-Id: I55427022374390745209677bae4e0b3146a9d126\n" }, { "commit": "9777ba230c83a0edcbda2cf7b208339e77bf171b", "tree": "253559eb1e962c3b21cf55cd59addc10823d65c4", "parents": [ "ff7ae7adf223b3485f4153442e4841189601af1e" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 17 09:04:19 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 17 09:04:19 2013 -0800" }, "message": "Implement Method.Bytecodes.\n\nChange-Id: Ib24c1244818c1d5aa10606a4998c0e52fa2b70bd\n" }, { "commit": "0cbaff584244ee767027aff35cd3c625aaee2994", "tree": "6209981f3814b9d43f8152f261455eb3f1fab15d", "parents": [ "f9a52cd81ad39aacd1a5c41478d5ee0cb6dff1bf" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 16 15:28:01 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 16 16:42:41 2013 -0800" }, "message": "Implement ObjectReference.ReferringObjects.\n\nBug: 4159882\nChange-Id: Iac145715bec80b5900256d3f6bdb18e283eb9a12\n" }, { "commit": "3b78c949ab839d21454bc6f18c7640d2ae8c22f3", "tree": "0a12766007b742f208f2ec8617c8d2a6d6d955a9", "parents": [ "ec0f83d95e2174c97e93279ffa71642be7e12b60" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 15 17:35:41 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 15 17:35:41 2013 -0800" }, "message": "Implement ReferenceType.Instances.\n\nChange-Id: I6a72fc4c748e7041fedcb615eca2b86b1f28bb63\n" }, { "commit": "ec0f83d95e2174c97e93279ffa71642be7e12b60", "tree": "b8ac0c238f6dddff2e49fb2002834a369594abb1", "parents": [ "4028312f6f4b49fd69992daf28cd37dd32e79a47" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 15 16:54:08 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 15 16:54:08 2013 -0800" }, "message": "Implement JDWP VirtualMachine.InstanceCounts.\n\nChange-Id: I6df66787dee8af67f65460023bcf223eec1ec7da\n" }, { "commit": "734b8c62cc637c25f4c2481ca6a48adbd7209c6c", "tree": "1e3176c62b1155f58b157dd965d8b64e26ccaaf2", "parents": [ "d2ece2e84931dbfaddb1f77c9dba4bd1a8762b5f" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 11 15:32:45 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 11 15:32:45 2013 -0800" }, "message": "Implement ThreadReference.OwnedMonitorsStackDepthInfo.\n\nChange-Id: I5e1ac7b2aeef7b1eac9518eba14a8f6555acd712\n" }, { "commit": "f9501700f51586cb6ba7cc0ffcb5a920bd64adf1", "tree": "e619fc67e4197452b45e5382af4247629da5387c", "parents": [ "67efe8cb257d3f687fe46b68f4fc8aca352b2f0a" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 11 11:22:27 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 11 11:40:18 2013 -0800" }, "message": "Implement ThreadReference.CurrentContendedMonitor and ThreadReference.Interrupt.\n\nThe JDWP test for CurrentContendedMonitor also uses Interrupt.\n\nChange-Id: Id1f6add29b578a0494da672d21dd54f23e866475\n" }, { "commit": "4993bbc8eda377804e585efd918f8ab9d9eab7d4", "tree": "bc49a14ce0c2718155444ac67152382e8c313326", "parents": [ "16848f6c5c4d8394d491e887d7d805beddf173ad" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 10 15:41:25 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 10 16:05:44 2013 -0800" }, "message": "Implement ThreadReference.OwnedMonitors.\n\nFix the method verifier so it can cope with not being able to resolve\ntypes in the application class loader, so we can find monitors held in\napplication code (this will improve SIGQUIT too).\n\nAlso remove the sort|uniq of dex pcs by just recording the last work\nline we see.\n\nChange-Id: I86ff27b42800a858489d112931c9aed2fb85ebdc\n" }, { "commit": "f327e07b37e349b1ec5eaad6dc294a9b7a081d20", "tree": "2c64b1f6212045a529c18d1dbe04b3da8fd1d6e9", "parents": [ "9e0c175a0cea5c8c88a6927e6375554118f74a82" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 16:01:26 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 18:07:12 2013 -0800" }, "message": "Implement ObjectReference.MonitorInfo.\n\nChange-Id: Iefc276939b9e569f4ea4d7a5af9a28276a3fb632\n" }, { "commit": "f15f4a0136a7b797117355768851bc421b3afc93", "tree": "160e0a242b91520ddd005af35680a40fab400449", "parents": [ "88d630950cb5c6a1cb6457ce03a17c074ae13628" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 10:09:38 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 10:28:56 2013 -0800" }, "message": "Remove Dbg::IsSuspended, which was checking the wrong thing.\n\nIt was also unnecessarily racy.\n\nChange-Id: I9d59ac81ffb5b178ca9d2a00d895a272321adec9\n" }, { "commit": "88d630950cb5c6a1cb6457ce03a17c074ae13628", "tree": "1d6b9741bc621d1f2ea5894cbc2ac4c56293d8dc", "parents": [ "8b64424860a5625782c363adba41825e5af6357f" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 09:55:54 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jan 09 09:55:54 2013 -0800" }, "message": "Clean up debugger orthography.\n\nMainly just for ids, and not in the JDWP code. Fixing everything at\nonce is just not practical.\n\nChange-Id: I06464d5765b33dca65eb3c24bdd8aaf84b9631a5\n" }, { "commit": "221229cb523f849f165fdafbf9785010963715da", "tree": "87f4b27cd85b40dad97d87780440a8b4225d7dda", "parents": [ "162fd33474038f0de0388338ca007ecf400bb3df" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 08 18:17:50 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 08 18:17:50 2013 -0800" }, "message": "Handle zombie threads in JDWP.\n\nMostly a matter of making DecodeThread more robust and passing JDWP::JdwpError\nstatuses around, but enough work that I feel justified in having left this as a\nTODO for so long.\n\nChange-Id: I779b6fcc6355dc6288355742f4b7babc531b8e38\n" }, { "commit": "9b5aa6f2029d3dae305009ac72e44ca97ca7b638", "tree": "9e33e741ecd850304394b952e55e8ae809a1ba54", "parents": [ "3235d00248f7b183b4f226a4f0de63673df0ac00" ], "author": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Tue Dec 18 11:47:11 2012 -0800" }, "committer": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Tue Dec 18 11:47:11 2012 -0800" }, "message": "Locking and exception handling fixes for debugger/interpreter.\n\nChange-Id: I20223113355a2d7b5deb4658035be2f788765fc1\n" }, { "commit": "09bfc6a50bdc9366b13ac3ab479d9278c853d90a", "tree": "f3d528939b038e5f0a6d16cbb83934ddc2b6ffc0", "parents": [ "89c41e5f2fa10e7b97698b9714bd4883a73132f0" ], "author": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Tue Dec 11 18:11:43 2012 -0800" }, "committer": { "name": "jeffhao", "email": "jeffhao@google.com", "time": "Wed Dec 12 13:25:25 2012 -0800" }, "message": "Some fixes for JDWP with the interpreter.\n\n- GetStackDepth checks if the thread is suspended, unless the thread is\n itself.\n- Scoped the breakpoints lock during UpdateDebugger to prevent it being\n held during PostLocationEvent.\n- Removed locking of breakpoints lock in DebugCallbackContext since it\u0027s\n already holding it.\n- Added level for breakpoints lock to prevent lock level violations.\n\nChange-Id: I3588c9696bb57ada3c8c64dc1d95ae23cdf2b107\n" }, { "commit": "c604d731730b43231f63040c8db1d58304da0cf3", "tree": "bb9cd6aa56eb3ba88ff27967efc3cc08da150b87", "parents": [ "0b0b515934b83385e1cea448113783e0b22849ed" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sun Oct 14 16:09:54 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Oct 15 15:36:32 2012 -0700" }, "message": "Implement mutex requeueing for cv broadcasts.\n\nMake the mutex guarding a condition variable part of its state. On a\nbroadcast requeue waiters on the mutex so they are awoken as the mutex\nis unlocked (thereby avoiding thundering herds). Explicit futex use\nstill guarded behind ART_USE_FUTEXES which remains disabled as I\u0027m\nunhappy with some of the warts of mutex usage. Uploading so that the API\nchanges can stabilize.\n\nChange-Id: Iedb601856ccd8bbc3a64da4ba0cee82246e7bcbf\n" }, { "commit": "66f19258f9728d4ffe026074d8fd429d639802fa", "tree": "fd94009774c6cbbb1528ea096e606133bd35f104", "parents": [ "a5e1e3d153990845d80cb8d013157210f11a473c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Sep 18 08:57:04 2012 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Sep 21 17:32:56 2012 -0700" }, "message": "Change dex cache to be java object instead of array, add pointer to dex file in dex cache.\n\nGeneric clean up to facilitate having GDB macros for Pretty* helper functions.\n\nImproved cleanliness of DexCache since having it as an object array was not the best solution.\n\nFixed a bug in InOrderWalk caused by ResolveType sometimes allocating classes.\n\nRename C++ Method to AbstractMethod and add two new classes Constructor, Method which both inherit from AbstractMethod.\n\nRename done to have the C++ code be closer to the java code.\n\nChange-Id: I4995b4c5e47a3822192b08afa24a639d3b1f4da9\n" }, { "commit": "b726dcb581bf72da46527378ccb6889020f0e6e9", "tree": "c0383ed788652926e93147e50d659ed226519548", "parents": [ "fd678beb171a4686a4f2d53ca4188a4ade8fa54e" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 08:57:23 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 05 09:06:19 2012 -0700" }, "message": "Rename GlobalSynchronization to Locks\n\nAlso address some review comments in common_throws relating to\nToStr\u003cInvokeType\u003e and exception detail messages.\n\nChange-Id: Ibf2c0f147689fa236d349bd7f01eed3c2522552b\n" }, { "commit": "1b09b094a85e03f6ef5f687f58bb91c433273ba1", "tree": "6b039e520ee3b73e6ba5fb23954b9e01ecc68fc9", "parents": [ "931c278aed62d7a97b87cf1bb9cfdd189e77eb24" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Aug 20 15:35:52 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Aug 20 15:35:52 2012 -0700" }, "message": "Syntax clean up to make clang happy.\n\nChange-Id: I0984c395bbd1ee4b206eafd19915b6f68781dd16\n" }, { "commit": "00f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abac", "tree": "6a2172ece15c4699e6c2a67ce76f019db0a9a21d", "parents": [ "634ea28f78c4a138e6a1de54eae8696095422415" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jul 19 15:28:27 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 14 10:45:52 2012 -0700" }, "message": "Global lock levels.\n\nIntroduce the notion of the mutators/GC being a shared-exclusive (aka\nreader-writer) lock. Introduce globally ordered locks, analysable by\nannotalysis, statically at compile time. Add locking attributes to\nmethods.\n\nMore subtly, remove the heap_lock_ and split between various locks that\nare held for smaller periods (where work doesn\u0027t get blocked). Remove\nbuggy Dalvik style thread transitions. Make GC use CMS in all cases when\nconcurrent is enabled. Fix bug where suspend counts rather than debug\nsuspend counts were sent to JDWP. Move the PathClassLoader to\nWellKnownClasses. In debugger refactor calls to send request and\npossibly suspend. Break apart different VmWait thread states. Move\nidentity hash code to a shared method.\n\nChange-Id: Icdbfc3ce3fcccd14341860ac7305d8e97b51f5c6\n" }, { "commit": "026b14660723c2b25a4f3ef6394f43a4fe64ba92", "tree": "c896d6abf1e1c2bce7607ad41f491fe613da0e5e", "parents": [ "bc2c29126c898a83eb0b90a51a8409fcffd899d8" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 28 20:43:49 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 28 20:43:49 2012 -0700" }, "message": "Fix build; JDWP::ObjectId feels like a pointer but is actually an int.\n\nChange-Id: I23460f0540115f5cc875f2da178bb99660de1262\n" }, { "commit": "caf7654a0e6c76c7489970b1a246fccf220f9982", "tree": "bdf74befb18407a3cb5ec4bd406059314b0434a7", "parents": [ "5d96a7168dd3e2a4acf1a947ef12efa8f82b95c0" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 28 16:08:22 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 28 18:53:55 2012 -0700" }, "message": "Fix posting exceptions when a debugger is attached, fix UpdateDebugger, fully implement ThreadGroupReference.Children.\n\nPosting exceptions and UpdateDebugger were broken by the recent stack-walking\nrewrite.\n\ndalvikvm never did ThreadGroupReference.Children correctly; it only admitted\nthat \"system\" is the parent of \"main\".\n\nChange-Id: I386f2fa5e01fba56cb2a1af4f136dbf31da0ff07\n" }, { "commit": "6e9d22c78c1016e70f8c2a9e6bc66c94ec36f728", "tree": "eb9c2987d89c3217447dc5029725b20711a42f55", "parents": [ "9c54f613f43bfb76ecb12006177b37222bdedc63" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jun 22 15:02:37 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jun 22 15:02:37 2012 -0700" }, "message": "Fix JDWP stack frame regressions.\n\nThe bug was that Dbg::GetThisObject didn\u0027t take a thread argument, so\nalways used the calling thread, which is never the thread whose frames\nyou actually care about.\n\nI\u0027ve also made the JDWP ThreadReference.Frames get all the frames at once\nnow, since we no longer have fast random access to individual frames.\n\nChange-Id: I0ce2bd2088e11d5ea14f9785d7ca0e3890b3cb9b\n" }, { "commit": "0399dde18753aa9bd2bd0d7cf60beef154d164a4", "tree": "ea88327c01ca321074aaa59b97e4c54348802937", "parents": [ "de5705dcf4ab5f92d48e144bcd7b59f7bcd18e16" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jun 06 17:09:28 2012 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jun 21 22:11:24 2012 -0700" }, "message": "Remove Frame, merge shadow and quick representations.\n\nChange-Id: I5ae03a5e52111792d2df7e83cbd89ab25777844b\n" }, { "commit": "546b986ecd09c2a498740bd8bf7127e612d94755", "tree": "ce2dfd24317d27929ae549202bc3bbe6ec282245", "parents": [ "4d999fe696d43de5872f7be293e8a749cb69beaf" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 20 16:06:13 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 20 16:06:13 2012 -0700" }, "message": "Fix a couple of JDWP bugs.\n\nA couple of JDWP tests started failing when we made \"thread suspend\ncount is already zero\" into a fatal error. This patch makes the debugger\na bit more careful about doing silly things (the JDWP protocol defines\nthese silly things as no-ops, and it\u0027s surprisingly easy for an end\nuser to get us into this state; just sit typing \"resume\" at the jdb(1)\nprompt, for example).\n\nI\u0027ve also tidied up GetObjectTag to return an error on failure, but\nthat isn\u0027t the fix to any bug the tests find. (The only remaining JDWP\nbugs are all caused by an inability to cope with register promotion,\nand we\u0027re already working on the proper fix for that.)\n\nChange-Id: I671f62234b5cb41aa9d86c6b947c518d7c068800\n" }, { "commit": "7b9d996e4cd7d154bb1a244d67139aff0c363cf2", "tree": "a9dabe8f910b4b8bf29c2f4285d860995e25f58d", "parents": [ "934100aea5a0f498c17e2c4a1fd0193af1557b42" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Apr 20 18:48:18 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Apr 20 18:57:19 2012 -0700" }, "message": "Tidy up some C-isms.\n\nChange-Id: I53b457cab9067369320457549071fc3e4c23c81b\n" }, { "commit": "c0f0933249cf516b37717faa766e1e9808f7c1f8", "tree": "04aedbf3e8502637673b82cf181dfab1b5aca1a6", "parents": [ "942df41c03ddb9f7b47a34fcfc4414d8b8ca8ce1" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 13:27:06 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 26 13:27:06 2012 -0700" }, "message": "Add the missing link between compiled code and the debugger.\n\nWhen a debugger connects and disconnects, we now let compiled code know that we\nneed to be kept informed about what\u0027s going on.\n\nAlso fix a threading bug when threads exit with a debugger attached.\n\nAlso some minor tidying, mostly involving naming.\n\nChange-Id: Iba0e8b9d192ac76ba1cd29a8b1e6d94f6f20dea8\n" } ], "next": "81ff3184e7eb8de4605c7646674ea4f9fa29b5f3" }