)]}' { "log": [ { "commit": "0025a86411145eb7cd4971f9234fc21c7b4aced1", "tree": "933b8b96ea970c23a7b3ce313c7c6d46f807dadd", "parents": [ "7fb36ded9cd5b1d254b63b3091f35c1e6471b90e" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jul 11 08:26:40 2014 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Jul 11 08:26:40 2014 +0000" }, "message": "Revert \"Revert \"Revert \"Add implicit null and stack checks for x86\"\"\"\n\nBroke the build.\n\nThis reverts commit 7fb36ded9cd5b1d254b63b3091f35c1e6471b90e.\n\nChange-Id: I9df0e7446ff0913a0e1276a558b2ccf6c8f4c949\n" }, { "commit": "7fb36ded9cd5b1d254b63b3091f35c1e6471b90e", "tree": "eb1e3b96efd67cc6b84a6f7e35522f33973ca8db", "parents": [ "93279da4a8475d187a0a2e75d50c88def5b4b8a5" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Jul 10 02:05:10 2014 +0000" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Jul 10 21:24:47 2014 +0000" }, "message": "Revert \"Revert \"Add implicit null and stack checks for x86\"\"\n\nFixes x86_64 cross compile issue. Removes command line options\nand property to set implicit checks - this is hard coded now.\n\nThis reverts commit 3d14eb620716e92c21c4d2c2d11a95be53319791.\n\nChange-Id: I5404473b5aaf1a9c68b7181f5952cb174d93a90d\n" }, { "commit": "8c1b5f71a8005743756206120624121d7678381f", "tree": "8cc8f170ac94ca2018d2e6e3e24eeeb3ee7f97f3", "parents": [ "070dfc4cebb9772a646382be9751d8f4c6b7d69a" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jul 09 22:02:36 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jul 09 23:46:42 2014 -0700" }, "message": "Missed use of android_atomic and thread state_.\n\nMove to using art::Atomic, add necessary FetchAnd... operations to art::Atomic.\n\nChange-Id: I32f1cdc4e0a2037b73f459bf4bb4d544f357f41b\n" }, { "commit": "b8e087e0dfd619df90cbb56534478a60bc859ebf", "tree": "f6f4e896935b02c68a40ae1410edb08f7296cad9", "parents": [ "43b6fe0270477cd47f8dd8b064d006961a44be54" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jul 09 21:12:06 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jul 09 21:24:04 2014 -0700" }, "message": "Move thread state to art::Atomic.\n\nLeaves the CAS operations as relaxed although art::Atomic treats relaxed CAS\nas a strong CAS when not compiling with clang.\n\nChange-Id: I6d37c22173540d166b624385e52e4ad05e592adc\n" }, { "commit": "3d14eb620716e92c21c4d2c2d11a95be53319791", "tree": "aadce4d6bb70e549b74b537c6f75617cf533576a", "parents": [ "34e826ccc80dc1cf7c4c045de6b7f8360d504ccf" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Jul 10 01:54:57 2014 +0000" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Jul 10 01:54:57 2014 +0000" }, "message": "Revert \"Add implicit null and stack checks for x86\"\n\nIt breaks cross compilation with x86_64.\n\nThis reverts commit 34e826ccc80dc1cf7c4c045de6b7f8360d504ccf.\n\nChange-Id: I34ba07821fc0a022fda33a7ae21850957bbec5e7\n" }, { "commit": "34e826ccc80dc1cf7c4c045de6b7f8360d504ccf", "tree": "76901cff2cddd6d30cb7a4e83ad4e0c9bb673fe1", "parents": [ "c21dc06adc8c8447561208a3fb72ccf6d0443613" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu May 29 08:20:04 2014 -0700" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Wed Jul 09 16:19:59 2014 -0700" }, "message": "Add implicit null and stack checks for x86\n\nThis adds compiler and runtime changes for x86\nimplicit checks. 32 bit only.\n\nBoth host and target are supported.\nBy default, on the host, the implicit checks are null pointer and\nstack overflow. Suspend is implemented but not switched on.\n\nChange-Id: I88a609e98d6bf32f283eaa4e6ec8bbf8dc1df78a\n" }, { "commit": "a9d8c4ce62fff49580fa70d3fcb3aee45344d8ca", "tree": "763c504dcac3f1b68ed5b8a148643fb3030bfaef", "parents": [ "0da09a026fb6c612e659dc782312987b4515f472" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jul 07 21:38:36 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jul 07 21:51:56 2014 -0700" }, "message": "BaseMutex::IsExclusiveHeld should only be called on self.\n\nFix issue in Thread::DumpState of lock dumping calling IsExclusiveHeld on a\nthread that isn\u0027t self causing intermittent crashes of ThreadStress oat test.\n\nBug: 15446488\nChange-Id: I86924397a4e21ce10a95ea2a737d7bfbcb8ffe28\n" }, { "commit": "86797a791d692f81def5c1b5f0918992c49ed122", "tree": "09cb46c5aa56e39a6399e3f3620dc2047948b872", "parents": [ "29978887552542e3b7e7792070dad06392377648" ], "author": { "name": "Serban Constantinescu", "email": "serban.constantinescu@arm.com", "time": "Thu Jun 19 16:17:56 2014 +0100" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 30 14:00:23 2014 -0700" }, "message": "AArch64: Add memcmp16() for Arm64; ensure xSELF not clobbered\n\nThis patch modifies memcmp() to memcmp16(). Please note that this\nimplementation of memcmp16() is based on the bionic\u0027s memcmp().\n\nHowever, to reflect a recent specification change, the file has been\nmodified to respect the new String.compareTo() behavior.\n\nA test for memcmp16() has been added. The string_compareto test in\nstub_test has been changed to invoke __memcmp16 in assembly stubs.\n\nAdd artIsAssignableFromCode to the list of native downcalls to\nstore and reload x18. Remove CheckSuspendFromCode, as it is unused.\n\nSigned-off-by: Serban Constantinescu \u003cserban.constantinescu@arm.com\u003e\nChange-Id: Ie0b5425ecfb62906d29a5d02e84c7e07ffb34a11\n" }, { "commit": "eef2e54113ba10cd76ddc368b928a2864401700e", "tree": "ede11956791865e30fe45fbf24eb87e8c1212ba5", "parents": [ "b9d11f7e2f60bdebfd2ece34e01ecc789921837d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Jun 24 22:48:01 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Jun 24 22:48:01 2014 -0700" }, "message": "Weaken condition to dump a thread\u0027s stack in a debug build.\n\nIf the current thread isn\u0027t suspended its also ok to dump the stack.\nBug: 14229281\n\nChange-Id: I2810ea79bc4330bb6e9616436d74076b5997c20b\n" }, { "commit": "8d16f203d40ab4018986baa018e52185ad05dae6", "tree": "a70a734448245abc4138eddea84d14e7dfbb286d", "parents": [ "2d2d6bb1ff8692efdddf104dabfb4a2d39877ff6", "ea2e1bd713ca8295ba4fcd01e77a3ce532ea61e4" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Jun 20 19:30:53 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Jun 20 02:09:57 2014 +0000" }, "message": "Merge \"Add more read barriers for JNI roots.\"" }, { "commit": "ea2e1bd713ca8295ba4fcd01e77a3ce532ea61e4", "tree": "d41be4b08041c5a2b1af626d8cdf6b69280723d5", "parents": [ "241fd1192dfc0f7322660343179f9fc0591ed9ff" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Jun 18 13:47:35 2014 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Jun 20 11:23:58 2014 -0700" }, "message": "Add more read barriers for JNI roots.\n\nTo make it possible to concurrently scan the JNI global roots (that\nis, the roots visited by JavaVMExt::VisitRoots()), add read barriers\nto the indirect reference table and the reference table.\n\nAlso, add read barriers to the jmethodID/jfieldID decode routines\n(ScopedObjectAccessAlreadyRunnable::DecodeField/DecodeMethod) so that\nwe can concurrently handle (encoded) fields and methods.\n\nBug: 12687968\nChange-Id: I3df4e4e622a572ff0ea8d44b2dc70a4d6b3ba058\n" }, { "commit": "7cd26f355ba83be75b72ed628ed5ee84a3245c4f", "tree": "94152cdd06143bec8c5491dba354cb78214b48c3", "parents": [ "0c29909cbde112bc9c04da4ce81421e1a0b39f36" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 18 17:01:15 2014 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 18 17:11:51 2014 -0700" }, "message": "ART: Target-dependent stack overflow, less check elision\n\nRefactor the separate stack overflow reserved sizes from thread.h\ninto instruction_set.h and make sure they\u0027re used in the compiler.\n\nRefactor the decision on when to elide stack overflow checks:\nespecially with large interpreter stack frames, it is not a good\nidea to elide checks when the frame size is even close to the\nreserved size. Currently enforce checks when the frame size is\n\u003e\u003d 2KB, but make sure that frame sizes 1KB and below will elide\nthe checks (number from experience).\n\nBug: 15728765\nChange-Id: I016bfd3d8218170cbccbd123ed5e2203db167c06\n" }, { "commit": "9ae7672073c588f6fc85052260533b7839775ee3", "tree": "ef2a59c0f7b9d2feed893fd39215604fff05a852", "parents": [ "3283ade469f515f89d70cf47b6ac6fe1814147f2", "c5f17732d8144491c642776b6b48c85dfadf4b52" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Jun 11 17:29:23 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jun 10 22:15:14 2014 +0000" }, "message": "Merge \"Remove deprecated WITH_HOST_DALVIK.\"" }, { "commit": "c5f17732d8144491c642776b6b48c85dfadf4b52", "tree": "811daa488ae5ee5dfd9b3b73bd210bc1506e5ca1", "parents": [ "08654d40cdd256f6a6c8619bf06d04d4c819714a" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Jun 05 20:48:42 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Jun 10 23:19:29 2014 -0700" }, "message": "Remove deprecated WITH_HOST_DALVIK.\n\nBug: 13751317\nFix the Mac build:\n - disable x86 selector removal that causes OS/X 10.9 kernel panics,\n - madvise don\u0027t need does zero memory on the Mac, factor into MemMap\n routine,\n - switch to the elf.h in elfutils to avoid Linux kernel dependencies,\n - we can\u0027t rely on exclusive_owner_ being available from other pthread\n libraries so maintain our own when futexes aren\u0027t available (we\n can\u0027t rely on the OS/X 10.8 hack any more),\n - fix symbol naming in assembly code,\n - work around C library differences,\n - disable backtrace in DumpNativeStack to avoid a broken libbacktrace\n dependency,\n - disable main thread signal handling logic,\n - align the stack in stub_test,\n - use $(HOST_SHLIB_SUFFIX) rather than .so in host make file variables.\n\nNot all host tests are passing on the Mac with this change. dex2oat\nworks as does running HelloWorld.\nChange-Id: I5a232aedfb2028524d49daa6397a8e60f3ee40d3\n" }, { "commit": "9f1020305292a21fd14a402b189c765a125226ab", "tree": "6b730cbe56ded370d1b4293629826ad2c7b06f7f", "parents": [ "bc72903b909f5147b8cb207f3e5d02a8ef85e4e7" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri May 23 08:59:42 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jun 11 14:29:00 2014 +0200" }, "message": "Fix exception reporting from interpreter\n\nTo comply with JDWP exception report rules, we must report an exception at the\nlocation of the throw (or the first instruction encountered after a native\ncall). To do this, we use the CatchLocationFinder visitor to look for a catch\nhandler until we reach a native frame or the top frame.\n\nBecause interpreter handles pending exception on a method-by-method basis, we\nneed a flag to remember we already reported the exception and avoid reporting\nit multiple times when unwinding methods. The drawback is we need to maintain\nthe state of this flag. We clear it when the exception is cleared. In the case\nwe temporarily clear the exception (when finding a catch handler for instance),\nwe restore the flag to its previous value at the same time we restore the\npending exception.\n\nBump oat version to force recompilation because we modify Thread offsets.\n\nBug: 14402770\nChange-Id: Ic059c58f80b2023b118038301f8f0a24f1e18241\n" }, { "commit": "4d0589c90971e19c25894414ae7da579269e1fe2", "tree": "0bb8a8bea051cfee85e26719eaf4045da9fb2132", "parents": [ "69d57a89595c7c0fba7b7f7b7c6b431a92137215" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 10 16:10:56 2014 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jun 10 16:21:33 2014 -0700" }, "message": "ART: Move __memcmp16 from Bionic to ART\n\nHandle __memcmp16 / MemCmp16 in ART. Import assembly implementations\nfor arm and mips from Bionic. Use a generic C version for all other\nplatforms.\n\nRemoves the memcmp16 quick entrypoint, as it is never used. Bump\nthe oat version and update thread.cc and checks to reflect the\nstructural change.\n\nChange-Id: I54a5a1da2a0a43ef271c8aeda0bf2276b8b11ac6\n" }, { "commit": "bfd9a4378eacaf2dc2bbe05ad48c5164fc93c9fe", "tree": "3d3f667c8232a9c1bb6fe9daea0d364f9ae01d8c", "parents": [ "2e1ca953c7fb165da36cc26ea74d3045d7e272c8" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed May 21 17:43:44 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 09 12:46:32 2014 -0700" }, "message": "Change MethodHelper to use a Handle.\n\nAdded ConstHandle to help prevent errors where you modify the value\nstored in the handle of the caller. Also fixed compaction bugs\nrelated to not knowing MethodHelper::GetReturnType can resolve types.\nThis bug was present in interpreter RETURN_OBJECT.\n\nBug: 13077697\n\nChange-Id: I71f964d4d810ab4debda1a09bc968af8f3c874a3\n" }, { "commit": "9db911eb76976fc1c73c8e563beb3620f1cadf99", "tree": "0d9fa7344f7d356fedbbfeeff3cd8eb289e0435f", "parents": [ "4eef72bdf5fd83e7361fb11feaf5a40121ede03f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jun 04 11:23:58 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jun 04 12:03:48 2014 -0700" }, "message": "Print mutexes held in Thread::Dump.\n\nShould help finding and fixing thread suspend timeout issues.\n\nBug: 15328839\nChange-Id: I30a10529cec0716c7571a0318e9f66be54734fd8\n" }, { "commit": "2a0d4ec9532a89abe722e5babdfbb846ffaad721", "tree": "1ec8b9aaf86ad227e9f1cbbed52cb3bf86ee0973", "parents": [ "fa5fda3ca52678b6fa739aad46e5c6ea08ae301e" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 02 22:05:22 2014 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jun 04 10:54:12 2014 -0700" }, "message": "ART: Fix forbidden thread state change in interpreter\n\nWhile loading a type for assignability, it might happen that it\u0027s\nnot available yet locally and must be resolved. Formerly, we\ndisallowed a state change to ensure no GC taking place while a new\nshadow frame has not been pushed on the stack yet.\n\nAs a fix, allow a \"shadow frame under construction\" in the thread,\nwhich is visited during GC.\n\nChange-Id: I973487a46b0e9e21fd6d49099d713b58f06d3b45\n" }, { "commit": "5cf98196d488437acd1e989c08a554ef697fded1", "tree": "dd44bc0120562169b701e80dbec413a179862beb", "parents": [ "b7f02280f7f56ae94fe7f01e161be0b725b6e4a9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu May 29 21:31:50 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri May 30 12:46:10 2014 -0700" }, "message": "Don\u0027t report down-calls as unhandled exceptions.\n\nBug: 15310540\nAlso, narrow scope of catch/deoptimize stack visitors that are specific to\nquick exception delivery.\n\nChange-Id: Ib13a006ce1347acb93a36b0186550d4c3ec2034b\n" }, { "commit": "cf4035a4c41ccfcc3e89a0cee25f5218a11b0705", "tree": "323d9e98e6129c67e464a3e6857ee02593a2f2c2", "parents": [ "29b53d3d715b1ec19349e8cbf7c5e4ff529bd5fe" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed May 28 22:43:01 2014 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu May 29 20:50:49 2014 -0700" }, "message": "ART: Use StackReference in Quick Stack Frame\n\nThe method reference at the bottom of a quick frame is a stack\nreference and not a native pointer. This is important for 64b\narchitectures, where the notions do not coincide.\n\nChange key methods to have StackReference\u003cmirror::ArtMethod\u003e*\nparameter instead of mirror::ArtMethod**. Make changes to\ninvoke stubs for 64b archs, change the frame setup for JNI code\n(both generic JNI and compilers), tie up loose ends.\n\nTested on x86 and x86-64 with host tests. On x86-64, tests succeed\nwith jni compiler activated. x86-64 QCG was not tested.\n\nTested on ARM32 with device tests.\n\nFix ARM64 not saving x19 (used for wSUSPEND) on upcalls.\n\nTested on ARM64 in interpreter-only + generic-jni mode.\n\nFix ARM64 JNI Compiler to work with the CL.\n\nTested on ARM64 in interpreter-only + jni compiler.\n\nChange-Id: I77931a0cbadd04d163b3eb8d6f6a6f8740578f13\n" }, { "commit": "196851b634a5bfdd8ab3fb59a320e550b21b0f4d", "tree": "f9fca2858b6213163d358c2eb2b2f88aa88a027b", "parents": [ "ea0b6e284cab12eed88eebf6aa19e6292af57389" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu May 29 12:16:04 2014 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu May 29 12:37:49 2014 -0700" }, "message": "Add read barriers for the weak roots in the JNI weak globals.\n\nBug: 12687968\nChange-Id: Ic265a0e162e8cc9edc4ab7fa34f8afd5ce968d08\n" }, { "commit": "055c29fd0f752328981f1b7ccadb1862eecedd40", "tree": "4eda9505576549f94e5810a4a45d8356395cf400", "parents": [ "ab5b370e44629332e73ffd66bfe8b8a924236c5c" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Tue May 27 13:59:04 2014 -0700" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Tue May 27 13:59:04 2014 -0700" }, "message": "Art compiler: remove unnecessary sqrt call\n\nFor reasons lost in the mists of time, the Dalvik JIT tested\nthe results of an inlined sqrt for NaN on Arm targets, and then\ncalled an out-of-line routine to recompute if true. The Quick\ncompiler inherited this behavior. It is not necessary, and the CL\npurges it (along with the out-of-line sqrt entrypoint).\n\nChange-Id: I8c8fa6feacf9b7c3b9e190dfc6f728932fd948c6\n" }, { "commit": "4c1c510bea6f20f4d8b09e15547cd2967ad51c88", "tree": "f3d15233294e46db0f43e83997e71a8bb990745e", "parents": [ "fdfe733d8fad10fb8370f468fbd5905416f338fa" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 14 16:51:16 2014 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 20 14:48:56 2014 +0100" }, "message": "Improve stack walk performance.\n\nMove a few functions from art_method.cc to art_method-inl.h\nand introduce new overloads that take already known partial\nresults; do not rely on the compiler to magically merge the\nidentical but non-trivial paths. The partial results are\nDCHECKed to be correct.\n\nChange-Id: I342c3001bbff08a2bbbb9a7b62ae67188ad8cffc\n" }, { "commit": "607fa7b07233a7233ebe21bba8f3e7c1925ae0f2", "tree": "a04f1074331ac82ad077044e3f373312f61e5901", "parents": [ "1dc387152a84193937bd1f88e9e10fff6449d695", "700a402244a1a423da4f3ba8032459f4b65fa18f" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue May 20 05:29:04 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue May 20 05:29:04 2014 +0000" }, "message": "Merge \"Now we have a proper C++ library, use std::unique_ptr.\"" }, { "commit": "700a402244a1a423da4f3ba8032459f4b65fa18f", "tree": "4c22fcda04d271bd55a37aff30650214af17a90c", "parents": [ "047c11adcbcbc0bcf210defdfcbada763961ffee" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon May 19 16:49:03 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon May 19 22:27:39 2014 -0700" }, "message": "Now we have a proper C++ library, use std::unique_ptr.\n\nAlso remove the Android.libcxx.mk and other bits of stlport compatibility\nmechanics.\n\nChange-Id: Icdf7188ba3c79cdf5617672c1cfd0a68ae596a61\n" }, { "commit": "2b7c4d196c8abe32f4ca633534917da9de53c359", "tree": "f14dc45f53d5681a5c0e57b8a8cc6b35eee6e896", "parents": [ "84e524207b23d58a1b1e5f4443000ccac97c4184" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon May 19 10:52:16 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon May 19 15:19:28 2014 -0700" }, "message": "Don\u0027t get and restore thread state for ScopedFastNativeObjectAccess.\n\nBefore we would ensure that we were runnable for fast native object\naccess. However, these are done when you are already runnable.\n\nChange-Id: Ia4c6e4c83d146fe2a988b37b3133ca46b0f0fa42\n" }, { "commit": "229dd50d041917970045595e022ed98862b7d464", "tree": "4c6d0b2dc5f6dea79a0f3e3789df30c00b1e13c5", "parents": [ "de1129a26e0474ea8bb9112938ebb867163969fd", "92d1a666534aa98b173bb33dc5dba86b2d48aedb" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Sat May 17 00:08:37 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Sat May 17 00:08:37 2014 +0000" }, "message": "Merge \"Visit methods in stack frames during root visits.\"" }, { "commit": "92d1a666534aa98b173bb33dc5dba86b2d48aedb", "tree": "864887bc5e1220152998874d3be861b31a49b0fa", "parents": [ "3b2bcbf9daf39f4cece7fde1186f3fa494000ed9" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu May 15 21:43:59 2014 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri May 16 13:37:45 2014 -0700" }, "message": "Visit methods in stack frames during root visits.\n\nThis is necessary for a Baker-style read barrier to-space invariant to\nhold. That is, an object either needs to be marked/forwarded as root\nor it must be accessed only through a read barrier by mutators. Since\nstack frames have direct pointers to methods that a mutator can access\nwithout a read barrier, stack frame methods have to be visited as\nroot, which makes sense as stack frames are thread roots. This is the\ncase even if methods do not move as they have to be marked \u0027gray\u0027 for\nthe objects pointed to by them, which can move, to be recursively\nmarked/forwarded.\n\nThis also puts us in the right direction toward moving methods (and\nfields) in the future.\n\nBug: 12687968\nChange-Id: Id32b913c021a140073deea9149a8782e8f308303\n" }, { "commit": "db2633ce0358c704f97130a94b582602cb01d14a", "tree": "ab941b728fe4343eb9872abc85755640bf059800", "parents": [ "f59c6dda4928cfb05d32a56fd161e3f86a9ca560" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 16 09:59:29 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 16 10:36:37 2014 -0700" }, "message": "Change ObjectLock to take Handle instead of Handle pointer.\n\nChange-Id: I9abdcdc5c9c9174634336b9250ab24c6aee434ec\n" }, { "commit": "eb8167a4f4d27fce0530f6724ab8032610cd146b", "tree": "bcfeaf13ad78f2dd68466bbd0e20c71944f7e854", "parents": [ "6fb66a2bc4e1c0b7931101153e58714991237af7" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed May 07 15:43:14 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue May 13 14:45:54 2014 -0700" }, "message": "Add Handle/HandleScope and delete SirtRef.\n\nDelete SirtRef and replaced it with Handle. Handles are value types\nwhich wrap around StackReference*.\n\nRenamed StackIndirectReferenceTable to HandleScope.\n\nAdded a scoped handle wrapper which wraps around an Object** and\nrestores it in its destructor.\n\nRenamed Handle::get -\u003e Get.\n\nBug: 8473721\n\nChange-Id: Idbfebd4f35af629f0f43931b7c5184b334822c7a\n" }, { "commit": "7624d25dad2d1ba25969ae704fccf68649103ae5", "tree": "de72194b76a4e23e0b15ec4085447ae7e4425815", "parents": [ "e1910f1d802dff79bba5ef61e1c4fd0b95f6e5b0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri May 02 14:40:15 2014 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 13 11:43:22 2014 +0100" }, "message": "Move quick frame info to OatQuickMethodHeader.\n\nRename OatMethodHeader to OatQuickMethodHeader, move frame\ninfo from OatMethodOffsets to OatQuickMethodHeader. Retrieve\nthe info from other places for non-quick methods (portable\ncompiled bytecode or jni stub, generic jni, runtime,\nabstract and proxy).\n\nThis change has a libcore/ companion CL\n \"Remove ArtMethod\u0027s quick fields for frame size and spills.\"\n https://android-review.googlesource.com/94164\n\nBug: 11767815\nChange-Id: I0e31a7875d76732e1ec479c86b9b5ca01203507f\n" }, { "commit": "f92a45609352fb1dc3460a07d83284b353270221", "tree": "0f740b02b473726d02fe92813f229ae5d29e5c4a", "parents": [ "ad1a8377a2cf97c9043c6158e4d080105f5e0d61", "c56057e40938c587a74984651a510e320a8cb4fd" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 09 23:47:08 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri May 09 23:47:08 2014 +0000" }, "message": "Merge \"Add lockless SynchronizedGet for indirect reference table.\"" }, { "commit": "c56057e40938c587a74984651a510e320a8cb4fd", "tree": "6595bb7aa27ecf91dc9121d25722b40dec803ee6", "parents": [ "0b8027003514c4fa6a850e5087076e991daaf4c3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun May 04 13:18:58 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon May 05 15:46:09 2014 -0700" }, "message": "Add lockless SynchronizedGet for indirect reference table.\n\nUsed for decoding global references without holding locks.\n\nResults on JniCallback:\nBefore: 615ms (3 samples).\nAfter: 585ms (3 samples).\n\nChange-Id: Ifcac8d0359cf658d87f695c6eb869d148af002e5\n" }, { "commit": "5cd33753b96d92c03e3cb10cb802e68fb6ef2f21", "tree": "b2217cb48e1f1db1aae7a92f8d5dbac5f2d95603", "parents": [ "8ea5baa10b04e9dbd0f0cf14b0358fe8b956bb2e" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Tue Apr 15 15:57:58 2014 -0700" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Mon May 05 12:44:15 2014 -0700" }, "message": "Handle implicit stack overflow without affecting stack walks\n\nThis changes the way in which implicit stack overflows are handled\nto satisfy concerns about changes to the stack walk code.\n\nInstead of creating a gap in the stack and checking for it in\nthe stack walker, use the ManagedStack infrastructure to concoct\nan invisible gap that will never be seen by a stack walk.\n\nAlso, this uses madvise to tell the kernel that the main stack\u0027s\nprotected region will probably never be accessed, and instead\nof using memset to map the pages in, use memcpy to read from\nthem. This will save 32K on the main stack.\n\nAlso adds a \u0027signals\u0027 verbosity level as per a review request.\n\nBug: 14066862\nChange-Id: I5257305feeaea241d11e6aa6f021d2a81da20b81\n" }, { "commit": "c45b8b582be5c98941ca3869fcdc9a08d520da41", "tree": "c84c980418c224dd317f2962fcfbd18d9785c3b0", "parents": [ "eafef7db77cfbe6bc05d9b07221c198bc8ceaa8a" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat May 03 01:39:59 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat May 03 22:52:59 2014 -0700" }, "message": "Create stack traces in unstarted runtimes.\n\nUse to diagnose failed initialization in dex2oat of boot (-verbose:compiler).\nFix identity hashCode, ArtMethod.getMethodName, IntegralToString.convertInt and\nuse of Void when called from a unstarted runtime.\n\nChange-Id: I2d536174b59e2e5f19519f93fc6b5916652fb6cd\n" }, { "commit": "0651d41e41341fb2e9ef3ee41dc1f1bfc832dbbb", "tree": "ad060fe7f37f4958d15d15d868e0cf6fb074d2cb", "parents": [ "adcfc69aa94cc1d406ef78e194b1ac36e389ad95" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 29 14:37:57 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 30 15:23:36 2014 -0700" }, "message": "Add thread unsafe allocation methods to spaces.\n\nUsed by SS/GSS collectors since these run with mutators suspended and\nonly allocate from a single thread. Added AllocThreadUnsafe to\nBumpPointerSpace and RosAllocSpace. Added AllocThreadUnsafe which uses\ncurrent runs as thread local runs for a thread unsafe allocation.\nAdded code to revoke current runs which are the same idx as thread\nlocal runs.\n\nChanged:\nThe number of thread local runs in each thread is now the the number\nof thread local runs in RosAlloc instead of the number of size\nbrackets.\n\nTotal GC time / time on EvaluateAndApplyChanges.\nTLAB SS:\nBefore: 36.7s / 7254\nAfter: 16.1s / 4837\n\nTLAB GSS:\nBefore: 6.9s / 3973\nAfter: 5.7s / 3778\n\nBug: 8981901\n\nChange-Id: Id1d264ade3799f431bf7ebbdcca6146aefbeb632\n" }, { "commit": "b0fa5dc7769c1e054032f39de0a3f6d6dd06f8cf", "tree": "839d13ebfa7170967dd9b4abd434b7abda53da99", "parents": [ "948740c1938860df055ddc801f20fd1707331e38" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Apr 28 16:47:08 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 29 14:36:28 2014 -0700" }, "message": "Force inlining on trivial accessors.\n\nMake volatility for GetFieldObject a template parameter.\nMove some trivial mirror::String routines to a -inl.h.\n\nBug: 14285442\n\nChange-Id: Ie23b11d4f18cb15a62c3bbb42837a8aaf6b68f92\n" }, { "commit": "deeb21bbe114193477755074a1e31595abafd5c2", "tree": "631e3ec8591392057b4bf831e28487b39f8e0d20", "parents": [ "cb905718826da268d8d8e09296806256f202c9f4", "714f175bd66d03225927a84f3d5dbc923c5a3e7e" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 29 07:25:00 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Apr 29 07:25:00 2014 +0000" }, "message": "Merge \"Visit deoptimized shadow frames as roots\"" }, { "commit": "714f175bd66d03225927a84f3d5dbc923c5a3e7e", "tree": "093c8564827484af598bd116c7560b1893910e3d", "parents": [ "d55e9b1a9f45c19cd7b376a8839ce37f86c66a64" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Apr 28 15:03:08 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Apr 29 09:04:18 2014 +0200" }, "message": "Visit deoptimized shadow frames as roots\n\nDuring deoptimization, we create shadow frames but do not attach them to the\nstack until we transition to interpreter mode. If a GC happens before that,\nthese shadow frames are not visited by GC so they may contain stale references.\n\nThis CL addresses this issue by visiting the shadow frames \"under contruction\"\nin Thread::VisitRoots so we correctly update all references they hold.\n\nTo make them visible, we now save the top shadow frame (the first one created)\nin the field Thread::tls_ptr_sized_values::deoptimization_shadow_frame. This\nfield will then be cleared when transitioning to interpreter mode.\n\nBug: 14324885\nChange-Id: Ib213ddc80f19cfcdfcec6f20acaa7f1a0e9ce2c1\n" }, { "commit": "73d1e17b3afc7d5e56184f90bf819dc64956448a", "tree": "6fee546dcebc0c8979a62be7e75c337f79b2ac2e", "parents": [ "e8256e7773a230337c3d137cbf0365f737820405" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 11 17:53:48 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Apr 25 14:08:49 2014 -0700" }, "message": "Enable reading page map without lock in RosAlloc::BulkFree\n\nEnabling this flag greatly reduces how much time was spent in the GC.\nIt was not done previously since it was regressing MemAllocTest. With\nthese RosAlloc changes, the benchmark score no longer regresses after\nwe enable the flag.\n\nChanged Run::AllocSlot to only have one mode of allocation. The new\nmode is finding the first free bit in the bitmap. This was\npreviously the slow path but is now the fast path. Some optimizations\nwhich enabled this include always having the alloc bitmap bits which\ncorrespond to invalid slots be set to 1. This prevents us from needing\na bound check since we will never end up allocating there.\n\nChanged revoking thread local buffer to point to an invalid run. The\ninvalid run is just a run which always has all the allocation bits set\nto 1. When a thread attempts to do a thread local allocation from here\nit will always fail and go slow path. This eliminates the need for a\nnull check for revoked runs.\n\nChanged zeroing of memory to happen during free, AllocPages should\nalways return zeroed memory. Added prefetching which happens when we\nallocate a run.\n\nSome refactoring to reduce duplicated code.\n\nErgonomics changes: Changed kStickyGcThroughputAdjustment to 1.0,\nthis helps reduce GC time.\n\nMeasurements (3 samples per benchmark):\nBefore: MemAllocTest scores: 3463, 3445, 3431\nEvaluateAndApplyChanges score | total GC time\nIter 1: 3485, 23.602436s\nIter 2: 3434, 22.499882s\nIter 3: 3483, 23.253274s\n\nAfter: MemAllocTest scores: 3495, 3417, 3409\nEvaluateAndApplyChanges score | total GC time:\nIter 1: 3375, 17.463462s\nIter 2: 3358, 16.185188s\nIter 3: 3367, 15.822312s\n\nBug: 8788501\nBug: 11790317\nBug: 9986565\nChange-Id: Ifd273a054824028dabed27c07c081dde1816f93c\n" }, { "commit": "fd3077e4b9ebadd281777310d26e64443858f653", "tree": "c63911af29580ab8c0fc8dd29171e626871449aa", "parents": [ "a08ec9b372d4f5e918b3d68499fbd1731180cd98" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 23 10:32:43 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 25 10:36:05 2014 +0200" }, "message": "Refactor exception handling for deoptimization\n\nThis CL refactors the exception handling (on the quick side) by isolating the\nsearch of catch handler and the preparation of deoptimization.\n\nWe rename the CatchFinder class to QuickExceptionHandler so it\u0027s less specific\nto catch handler search.\n\nFinding catch handler happens in QuickExceptionHandler::FindCatch. Since the\nCatchBlockStackVisitor resolves exception types, it may cause thread suspension\nand breaks the assertion current thread can\u0027t be suspended. Therefore, we place\nthe exception in a SirtRef (while it is detached from the current thread) and\nremove the thread suspension assertion.\n\nDeoptimization now happens in QuickExceptionHandler::DeoptimizeStack. It uses\nthe new DeoptimizeStackVisitor class to create shadow frames.\n\nWe also add the Thread::GetDeoptimizationException method to get the definition\nof the fake exception in only one place.\n\nChange-Id: I01b19fa72af64329b5c3b6c7f0c3339d2d724978\n" }, { "commit": "4af159bfcc66c6e90a2aee4a2035a996a399e7ed", "tree": "9bc7f4ac4f6ce93be0e9f2bc8db6ccdb9d972c36", "parents": [ "d299898a55f41ccf78b865e153ae91321229353b", "987560fee798e48fb725c44b796d8ca7a5872ad6" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 22 23:03:01 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Apr 22 23:03:01 2014 +0000" }, "message": "Merge \"Remove support for app JNI workarounds.\"" }, { "commit": "987560fee798e48fb725c44b796d8ca7a5872ad6", "tree": "d61f35a129847f3f5fbed1436649e75acd940b3f", "parents": [ "44b0053fdb7ad8a30138d29f714172a7dc69efb8" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 22 11:42:59 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 22 14:52:19 2014 -0700" }, "message": "Remove support for app JNI workarounds.\n\nChange-Id: I4396df7e93fcace4b5b19c2c387e5c30089182a6\n" }, { "commit": "a2cee18799d7e61adb037a4219adb23fef7d022b", "tree": "214a6d6d4682196aa0e2ebcb5a0cc7bcf3eec2d3", "parents": [ "ed0bc0bbf26f6751f31213d24ccdac49766e93ff" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Apr 16 19:13:59 2014 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Apr 18 15:32:15 2014 -0700" }, "message": "Modify unwind to comply with stack parser tools.\n\nBug: 14081592\n\nChange-Id: I6906b2575c74d64f1c3ba7602779b3a789de1c69\n" }, { "commit": "4d7f61d44a732cfbc8573e5d93364983fd746888", "tree": "0ad34f9316227531696c01ba9b25a2175a5c5f65", "parents": [ "425640d6fac3432a44e236a002e8401a7cd59c5c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 17 14:43:39 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 17 15:56:47 2014 -0700" }, "message": "Use non volatile lock words in semispace collector.\n\nGSS FormulaEvaluationActions.EvaluateAndApplyChanges:\nBefore GC time: 9.1s\nAfter GC time: 7.98s\n\nFixed timing logger errors.\n\nChange-Id: I4193c6ccbbbe7a7220dfaabbf3472a5dcebae616\n" }, { "commit": "63e8a68c9a2cdbbe9bfd8d200610119dd359ee59", "tree": "144c911b7d8da5b0047a5ce3f340de73cdc8b56d", "parents": [ "a3eaf66b968270b938a2795fe55e778c55f1c24b" ], "author": { "name": "Yevgeny Rouban", "email": "yevgeny.y.rouban@intel.com", "time": "Wed Apr 16 18:26:09 2014 +0700" }, "committer": { "name": "Yevgeny Rouban", "email": "yevgeny.y.rouban@intel.com", "time": "Wed Apr 16 18:26:09 2014 +0700" }, "message": "Fix thread join hangs\n\nCurrent implementation notifies only one of joining threads on thread exit.\nThis causes the other joining threads to hang.\n\nThis patch notifies all joining threads: just call NotifyAll() instead of Notify().\n\nChange-Id: If75f101d3d3d876f1aa7dcf537e56a37cc347803\nSigned-off-by: Yevgeny Rouban \u003cyevgeny.y.rouban@intel.com\u003e\n" }, { "commit": "c7a966dbba6902618ff0959d604c05d7570df8c8", "tree": "9c29dc008ad24e97ba26d5734fc7db4a41f7ca52", "parents": [ "22839a631bb3591a1c0037c388d51a4f18b5fb5e" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 10 18:06:32 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 10 18:07:46 2014 -0700" }, "message": "Prevent deadlocks in Runtime::Abort.\n\nIf we have the threads suspended, attempting to use a\nScopedObjectAccess causes a deadlock. We now specifically avoid this\nto prevent deadlocks.\n\nBug: 13747880\nChange-Id: I45fd3fff917da98b22970e5351a9e25b143a4eed\n" }, { "commit": "43d8bb870fadd4775a8513a1df955cdf66ad4b92", "tree": "81aa7f1a154d7c318cbd9e2f17bdffa6f3d81404", "parents": [ "a7b2826fa469c626ff2c3ff26fd848c28bccc092" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 03 09:57:36 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Apr 03 10:30:44 2014 -0700" }, "message": "Add monitor_enter_object as root.\n\nThe monitor enter object was not a root, this caused issues with\ncompactions since the object could move and then verify object would\nfail.\n\nBug: 13769139\nChange-Id: Ia732376fb9d1de8bf137ef9894cb2bb3241d8bb2\n" }, { "commit": "2966e13d504a72d55c62bf864e183ec80703c699", "tree": "ce13371288e4a08e8b627eeafd18a5b9746ecec4", "parents": [ "161f71ab4449047157ad3d967a3ed4f7c6e17249" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Apr 02 08:34:36 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Apr 02 08:36:46 2014 -0700" }, "message": "Avoid debug check violation in thread registration.\n\nBug: 13757855\nChange-Id: Ied83a7fc43e2b9a89a8b99aa4f74069ef8a369b1\n" }, { "commit": "1246d689dc3150bbee6c5e5628747a94fba5081e", "tree": "24fb2b8271cdc524855f52bbc94361dbf5f8c2f0", "parents": [ "f689b93e904e062d83a7ae7e8cacce0b52af3323", "ee1d79a603c77c0667b27c075a983579d5c51f7e" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 02 07:45:51 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Apr 02 07:45:52 2014 +0000" }, "message": "Merge \"Cleanup transaction support\"" }, { "commit": "ee1d79a603c77c0667b27c075a983579d5c51f7e", "tree": "7b23516402105319ab4736cd179a1de9101eeb46", "parents": [ "78bd9b2198f0ccc48036c1517b2d9a9023157dfb" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Feb 21 15:46:30 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 02 09:21:12 2014 +0200" }, "message": "Cleanup transaction support\n\nUpdates Thread::CreateInternalStackTrace to support both transactional and\nnon-transactional modes using template.\n\nGeneralizes non-transactional mode for invariant fields (which are set only\nonce).\n\nRemoves ArrayLog::VisitRoots as we never create Array logs of ObjectArray. As\nObjectArray elements are set using Object::SetFieldObject, they are already\nrecorded in the object logs: the object is the array itself and the offset\ncorresponds to the element index in this array. And also checks we never log\nObjectArray in array logs.\n\nFixes location of thrown exception when calling native method during class\ninitialization.\n\nChange-Id: Idbc368d3b8292b85ff40bc8a7c559e085477bf89\n" }, { "commit": "d803bc7ce255be6c16eaf6a8a58a742515e9da9f", "tree": "9d996494ae037ba99bb149927adfe961be68926b", "parents": [ "8ce67ac16abcd25b376be622cbd20a34aec4a59d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 01 15:33:03 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 01 15:33:03 2014 -0700" }, "message": "Fix ThreadStress, unify ANR lock descriptions.\n\nBug: 13323656\nChange-Id: I902825a847af9aa570ed79701409298e3532bebf\n" }, { "commit": "c751fdcc9491c1b60c3db517fbc41bb98e92441f", "tree": "a59258cf4b9c46e928e547216554149635e6d4f2", "parents": [ "e0309ad355e778fe692beb8968bf8aa7edbd3302" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Mar 30 15:25:44 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 01 10:58:22 2014 -0700" }, "message": "Add handler for printing java stack traces for compiled code SIGSEGV.\n\nAdded a new FaultHandler which attempts to print a java stack trace\nwhen a SIGSEGV occurse in generated code. This should help debugging\ncompiler and GC related heap corruption.\n\nBug: 13725693\nBug: 12934910\n\nChange-Id: Id54d83ea180c222eb86d449c61926e83f0b026ad\n" }, { "commit": "dd7624d2b9e599d57762d12031b10b89defc9807", "tree": "c972296737f992a84b1552561f823991d28403f0", "parents": [ "8464a64a50190c06e95015a932eda9511fa6473d" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 14 17:43:00 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 01 08:24:16 2014 -0700" }, "message": "Allow mixing of thread offsets between 32 and 64bit architectures.\n\nBegin a more full implementation x86-64 REX prefixes.\nDoesn\u0027t implement 64bit thread offset support for the JNI compiler.\n\nChange-Id: If9af2f08a1833c21ddb4b4077f9b03add1a05147\n" }, { "commit": "f943914730db8ad2ff03d49a2cacd31885d08fd7", "tree": "885a781e5f8bd852e2c1615108ae7b17576a6567", "parents": [ "cfd5acf281b0c509f86b13d73c6a8dfa3ea9922c" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Mar 27 15:10:22 2014 -0700" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Mon Mar 31 18:04:08 2014 -0700" }, "message": "Implement implicit stack overflow checks\n\nThis also fixes some failing run tests due to missing\nnull pointer markers.\n\nThe implementation of the implicit stack overflow checks introduces\nthe ability to have a gap in the stack that is skipped during\nstack walk backs. This gap is protected against read/write and\nis used to trigger a SIGSEGV at function entry if the stack\nwill overflow.\n\nChange-Id: I0c3e214c8b87dc250cf886472c6d327b5d58653e\n" }, { "commit": "3b05e9ba874449dbff65b01b8781001f7d93eea6", "tree": "f341766bff83ebea510344c4857af493725d3f58", "parents": [ "027f7fa539514d2a50b448de1de39ac307087483" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 25 09:29:43 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Mar 25 13:56:58 2014 -0700" }, "message": "Add missing debugger root visiting.\n\nBug: 13634574\nChange-Id: I2a76f6c43f1d0ad1922f06deb40a71ff651129fd\n" }, { "commit": "c93c530efc175954160c3834c93961a1a946a35a", "tree": "32a389e2b4cfc3296075aed23f353b8d3042c9a5", "parents": [ "faa93b3ab455492dad1a9d3fb630e3936d389c85" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Mar 20 16:15:37 2014 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Mar 21 12:17:56 2014 -0700" }, "message": "Revoke rosalloc thread-local buffers at the checkpoint.\n\nIn the mark sweep collector, rosalloc thread-local buffers were\nrevoked during the pause. Now, they are revoked at the thread\ncheckpoint, as opposed to during the pause, which appears to help\nreduce the pause time.\n\nIn Ritz MemAllocTest, the average sticky pause time went down ~20%\n(925 us -\u003e 724 us).\n\nBug: 13394464\nBug: 9986565\nChange-Id: I104992a11b46d59264c0b9aa2db82b1ccf2826bc\n" }, { "commit": "88e46a35b4b898ec2032348a185d2b0b812b6ad9", "tree": "94a172b2ba723a8996db0de0dec7d85f46d99c61", "parents": [ "4e81ffbf3bb8cd2851cd0a393682d514ab143c49" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 14 14:37:59 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 14 14:37:59 2014 -0700" }, "message": "Remove unused variable and tidy test #includes.\n\nChange-Id: I0eaeea0d50f66302d632aab400cfa48dc301ef69\n" }, { "commit": "53b8b09fc80329539585dcf43657bc5f4ecefdff", "tree": "cac0f82fbb89bd907104e3fed6c36203e11a3de0", "parents": [ "0dea9872082bc3e576ed6cefed86b0d6c0c45ffd" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Mar 13 23:45:53 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Mar 14 11:28:10 2014 -0700" }, "message": "Refactor reflective method invocation.\n\nMove invocation code out of JNI internal into reflection, including ArgArray\ncode. Make reflective invocation use the ArgArray to build arguments rather\nthan allocating a jvalue[] and unboxing arguments into that.\nMove reflection part of jni_internal_test into reflection_test.\nMake greater use of fast JNI.\n\nChange-Id: Ib381372df5f9a83679e30e7275de24fa0e6b1057\n" }, { "commit": "b373e091eac39b1a79c11f2dcbd610af01e9e8a9", "tree": "034d820c4829e0dcf6161473cc39f7250123bfaa", "parents": [ "9545a446e99b22248099fe66f5f9431530c20851" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Feb 20 16:06:36 2014 -0800" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Mar 13 12:21:15 2014 -0700" }, "message": "Implicit null/suspend checks (oat version bump)\n\nThis adds the ability to use SEGV signals\nto throw NullPointerException exceptions from Java code rather\nthan having the compiler generate explicit comparisons and\nbranches. It does this by using sigaction to trap SIGSEGV and when triggered\nmakes sure it\u0027s in compiled code and if so, sets the return\naddress to the entry point to throw the exception.\n\nIt also uses this signal mechanism to determine whether to check\nfor thread suspension. Instead of the compiler generating calls\nto a function to check for threads being suspended, the compiler\nwill now load indirect via an address in the TLS area. To trigger\na suspend, the contents of this address are changed from something\nvalid to 0. A SIGSEGV will occur and the handler will check\nfor a valid instruction pattern before invoking the thread\nsuspension check code.\n\nIf a user program taps SIGSEGV it will prevent our signal handler\nworking. This will cause a failure in the runtime.\n\nThere are two signal handlers at present. You can control them\nindividually using the flags -implicit-checks: on the runtime\ncommand line. This takes a string parameter, a comma\nseparated set of strings. Each can be one of:\n\nnone switch off\nnull null pointer checks\nsuspend suspend checks\nall all checks\n\nSo to switch only suspend checks on, pass:\n-implicit-checks:suspend\n\nThere is also -explicit-checks to provide the reverse once\nwe change the default.\n\nFor dalvikvm, pass --runtime-arg -implicit-checks:foo,bar\n\nThe default is -implicit-checks:none\n\nThere is also a property \u0027dalvik.vm.implicit_checks\u0027 whose value is the same\nstring as the command option. The default is \u0027none\u0027. For example to switch on\nnull checks using the option:\n\nsetprop dalvik.vm.implicit_checks null\n\nIt only works for ARM right now.\n\nBumps OAT version number due to change to Thread offsets.\n\nBug: 13121132\nChange-Id: If743849138162f3c7c44a523247e413785677370\n" }, { "commit": "0f6784737882199197796b67b99e5f1ded383bee", "tree": "139888bdfad743c50e800ad46b9aec97ae3415d3", "parents": [ "73a471336a9515fa7fdc5859e3c481ec451237a5" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Mar 10 16:18:37 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Mar 10 18:02:07 2014 -0700" }, "message": "Unify 64bit int constant definitions.\n\nLL and ULL prefixes are word size dependent, use the INT64_C and UINT64_C\nmacros instead.\n\nChange-Id: I5b70027651898814fc0b3e9e22a18a1047e76cb9\n" }, { "commit": "e0dcd46314d07eeb332edea292f5110178e4e3d2", "tree": "d1060bc54e1ad26bad69a6e06662e643e75ce484", "parents": [ "80a250f8862096b72e7357c12b40dc9d5310a475" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Sat Mar 08 15:21:04 2014 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Sun Mar 09 02:17:46 2014 +0000" }, "message": "JNI down call fixes.\n\nEnsure SIRT isn\u0027t accessed via quick callee save frame.\nSome tidying of code.\n\nChange-Id: I8fec3e89aa6d2e86789c60a07550db2e92478ca7\n" }, { "commit": "aa00fe010eb7b61c2de82611ce3f6fc0918a4f9e", "tree": "53a1769024151ecd756b20ec4fec5d2733d59c9f", "parents": [ "de46ed1ceb8272e65f780f041b52e7bbc03421d8", "c645f1ddb7c40bea6a38eda4b3f83f6b6dec405b" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 07 20:09:48 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Mar 07 20:09:49 2014 +0000" }, "message": "Merge \"Add more VerifyObject calls.\"" }, { "commit": "c645f1ddb7c40bea6a38eda4b3f83f6b6dec405b", "tree": "de6141864c1c011216c19dd99a2c1e2bc442dd6d", "parents": [ "a9d7be62735e3356cef7e8ed797c519134a17061" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 06 18:11:53 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Mar 07 12:09:04 2014 -0800" }, "message": "Add more VerifyObject calls.\n\nAdded verify object calls to SirtRef, IndirectReferenceTable,\nReferenceTable.\n\nRemoved un-needed verify object in ScopedObjectAccess / DecodeJObject\nsince object sources are handled.\n\nBug: 12934910\nChange-Id: I55a46a8ea61fed2a77526eda27fd2cce97a9b125\n" }, { "commit": "b166d8407622e842eb0dc9302ede01cdea182149", "tree": "7401b7eab80c72e977e305896e90ee4ce4c32a6d", "parents": [ "3c0c1791d4b5efe59d2a659b6925b908d9d44b56", "067d20fd2fddd947ce3a014d023e9de249082ebe" ], "author": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Fri Mar 07 18:47:22 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Mar 07 18:47:22 2014 +0000" }, "message": "Merge \"backtrace: use Java stack to help decode native\"" }, { "commit": "067d20fd2fddd947ce3a014d023e9de249082ebe", "tree": "22ebe9335ce783d6b4cfaa311281e001d578ac12", "parents": [ "8785d615122d4abbd22db702139584e8c472f502" ], "author": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Wed Mar 05 14:57:21 2014 -0800" }, "committer": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Thu Mar 06 13:38:41 2014 -0800" }, "message": "backtrace: use Java stack to help decode native\n\nBefore change:\n\n native: usb_host_run+16 [0x400a43f9] (/libusbhost.so)\n native: android::Vector\u003cint\u003e::do_move_forward(void*, void const*, unsigned int) const+54 [0x501b1c5b] (/libandroid_servers.so)\n native: ??? [0x624de480] (/system@framework@boot.oat)\n at com.android.server.usb.UsbHostManager.monitorUsbHostBus(Native method)\n at com.android.server.usb.UsbHostManager.access$000(UsbHostManager.java:38)\n\nAfter change:\n\n native: usb_host_run+16 [0x400933f9] (libusbhost.so)\n native: android::Vector\u003cint\u003e::do_move_forward(void*, void const*, unsigned int) const+54 [0x4e984c5b] (libandroid_servers.so)\n native: Java_com_android_server_usb_UsbHostManager_monitorUsbHostBus__+92 [0x624de480] (system@framework@boot.oat)\n at com.android.server.usb.UsbHostManager.monitorUsbHostBus(Native method)\n at com.android.server.usb.UsbHostManager.access$000(UsbHostManager.java:38)\n\nChange-Id: Iea550a251a12e9ba7df9582fd454093bfa4e90e0\n" }, { "commit": "6dda898d47b3e8931e4404330e81b7110108e34f", "tree": "d8a0a20b8ac1ce3cd44273cf5c748d09980bd800", "parents": [ "8785d615122d4abbd22db702139584e8c472f502" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 06 11:11:48 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 06 11:43:06 2014 -0800" }, "message": "Disable compaction for jni workarounds.\n\nCompaction can\u0027t work when jni workarounds is enabled. Also some\nother refactoring.\n\nChange-Id: Ia7b0f2b39c79f5a0a5f50874d823b950ab02a0c3\n" }, { "commit": "6cbd271d061707dfe70e29c16bb97b6acbd3c533", "tree": "2a4dc81b46b7f29b6dec85ec9f5c375d50ba7c6f", "parents": [ "6f2083d3f909bce3988e71cd80374cee038ecba6" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Mar 04 16:06:50 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Mar 04 16:06:50 2014 -0800" }, "message": "Oatdump fix.\n\nChange-Id: Idd4fe294a628efb2a3bd39061a61bab3017784a2\n" }, { "commit": "d889178ec78930538d9d6a66c3df9ee9afaffbb4", "tree": "6fa250bdadcdfc1702f57500e618b51df6d46828", "parents": [ "06c09f6d79e037ee00113d6289ef98226680797d" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Mar 02 13:28:37 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Mar 03 17:08:30 2014 -0800" }, "message": "Guard entrypoint changing by runtime shutdown lock.\n\nThere was a race when we changed the allocation entrypoints where a\nnew thread would be starting (Thread::Init) and initialize to the\nwrong entrypoints. Guarding allocation entrypoint changing\nwith the runtime shutdown lock fixes this race condition since\nThread::Init is only called with the runtime shutdown lock held.\n\nBug: 13250963\n\nChange-Id: I8eb209c124b6bf17020de874e1b0083f158b8200\n" }, { "commit": "2da882315a61072664f7ce3c212307342e907207", "tree": "67d777be044f5b60e2f13ab7968b63c581904ea9", "parents": [ "762d4e5b9e777ae64c4ba581af9c84b78a5e96a6" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Feb 27 12:26:20 2014 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 03 23:27:12 2014 +0000" }, "message": "Initial changes towards Generic JNI option\n\nSome initial changes that lead to an UNIMPLEMENTED. Works\nby not compiling for JNI right now and tracking native methods\nwhich have neither quick nor portable code. Uses new trampoline.\n\nChange-Id: I5448654044eb2717752fd7359f4ef8bd5c17be6e\n" }, { "commit": "8d7672e476a526aa6205a008b5a06c8216342ac6", "tree": "44881b68a2a05b7dae78beb30c7589627781c0f0", "parents": [ "661425e1f90d4f4ed44c66f5e74f48b92a3798df" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 25 10:57:16 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 25 11:01:01 2014 -0800" }, "message": "Print message when throwing new exception with pending exception.\n\nUseful to see what the new exception is.\n\nBug: 12957138\nChange-Id: I751b3a9b0b5d57d72f15d3ed7fa746a1991b181c\n" }, { "commit": "9837939678bb5dcba178e5fb00ed59b5d14c8d9b", "tree": "00f0e6b54d7c4cac78a02752e268724157e50b6e", "parents": [ "3fcf18e25241253f23efbeebe77b2a4c4a7c54d3" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Feb 24 16:53:16 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Feb 24 18:47:23 2014 -0800" }, "message": "Avoid std::string allocations for finding an array class.\n\nIntroduce ClassLinker::FindArrayClass which performs an array class lookup\ngiven the element/component class. This has a 16 element cache of recently\nlooked up arrays.\nPass the current thread to ClassLinker Find .. Class routines to avoid calls\nto Thread::Current().\nAvoid some uses of FindClass in the debugger where WellKnownClasses is a\nfaster and more compacting GC friendly alternative.\n\nChange-Id: I60e231820b349543a7edb3ceb9cf1ce92db3c843\n" }, { "commit": "4e30541a92381fb280cd0be9a1763b713ee4d64c", "tree": "84093651bbf0ad95b66b846c4f4cf4101994037b", "parents": [ "e266ba9935bd12d685d83f73cd8d759e46c3014d" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 19 10:54:44 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Feb 21 15:24:04 2014 -0800" }, "message": "Fix and optimize verify object.\n\nVerifyObject no longer resides in heap. You can now enable\nVerifyObject for non-debug builds. VerifyStack is still slow, so it\nis now guarded by its own flag.\n\nFixed the image writer to not use verification at places where\nverification fails due to invalid reads.\n\nFixed RosAlloc to use SizeOf which doesn\u0027t call verify object.\n\nAdded a flag paremeter to some of the mirror getters / setters to\nbe able to selectively disable VerifyObject on certain calls.\n\nOptimized the GC to not verify each object multiple times during\nobject scanning if verify object is enabled.\n\nAdded 3 verification options: verify reads, verify this, and verify\nwrites so that you can select how much verification you want for\nmirror getters and setters.\n\nRemoved some useless DCHECKs which would slow debug builds without\nproviding any benefits.\n\nTODO: RosAlloc verification doesn\u0027t currently work with verify\nobjects.\n\nBug: 12934910\nBug: 12879358\n\nChange-Id: Ic61033104dfc334543f89b0fc0ad8cd4f4015d69\n" }, { "commit": "815873ecc312b1d231acce71e1a16f42cdaf09f2", "tree": "18ba2fa951775e60b240271bfe975e6e2cfc654c", "parents": [ "2befd09cf4fe89a18a655f3e1dd310831bfa769f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Feb 13 18:02:13 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 18 10:45:12 2014 -0800" }, "message": "Change root visitor to use Object**.\n\nSimplifies code and improves the performance of root visiting since\nwe usually don\u0027t need to check to see if the object moved.\n\nChange-Id: Iba998f5a15ae1fa1b53ca5226dd2168a411196cf\n" }, { "commit": "d2fe10a3a34af171bf1631219cd2d6ff6b7778b5", "tree": "b6b7eb8eba23a5c2723518da99c03bf47b97f58a", "parents": [ "5a3f55ad9519e87c0d3bbddaf3d8a186a887a79b" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jan 15 10:20:56 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Feb 17 11:32:15 2014 +0100" }, "message": "Remove blacklist\n\nRemoves the class initialization blacklist and use transaction to detect and\nrevert class initialization attempting to invoke native method. This only\nconcerns class initialization happening at compilation time when generating an\nimage (like boot.art for the system).\n\nIn transactional mode, we log every object\u0027s field assignment and array update.\nTherefore we\u0027re able to abort a transaction to restore values of fields and\narray as they were before the transaction starts. We also log changes to the\nintern string table so we can restore its state prior to transaction start.\n\nSince transactional mode only happens at compilation time, we don\u0027t need to log\nall these changes at runtime. In order to reduce the overhead of testing if\ntransactional mode is on/off, we templatize interfaces of mirror::Object and\nmirror::Array, respectively responsible for setting a field and setting an\narray element.\n\nFor various reasons, we skip some specific fields from transaction:\n- Object\u0027s class and array\u0027s length must remain unchanged so garbage collector\ncan compute object\u0027s size.\n- Immutable fields only set during class loading: list of fields, method,\ndex caches, vtables, ... as all classes have been loaded and verified before a\ntransaction occurs.\n- Object\u0027s monitor for performance reason.\n\nBefore generating the image, we browse the heap to collect objects that need to\nbe written into it. Since the heap may still holds references to unreachable\nobjects due to aborted transactions, we trigger one collection at the end of\nthe class preinitialization phase.\n\nSince the transaction is held by the runtime and all compilation threads share\nthe same runtime, we need to ensure only one compilation thread has exclusive\naccess to the runtime. To workaround this issue, we force class initialization\nphase to run with only one thread. Note this is only done when generating image\nso application compilation is not impacted. This issue will be addressed in a\nseparate CL.\n\nBug: 9676614\nChange-Id: I221910a9183a5ba6c2b99a277f5a5a68bc69b5f9\n" }, { "commit": "f5b0e20b5b31f5f5465784adcf2a204dcd69c7fd", "tree": "9e1b211414c1dcb34f19a7b509e72aee2153a3cf", "parents": [ "68bb649b128cd8760732524bd7ba58b49780d9d3" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Tue Feb 11 17:02:22 2014 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Feb 13 13:43:43 2014 -0800" }, "message": "Thread-local allocation stack.\n\nWith this change, Ritz MemAllocTest gets ~14% faster on N4.\n\nBug: 9986565\nChange-Id: I2fb7d6f7c5daa63dd4fc73ba739e6ae4ed820617\n" }, { "commit": "2300790c868f70862f1d1c2578a07c8d0f29d53d", "tree": "c7f45cdd8bc190f1679a9f84eef8593d49d42d88", "parents": [ "b422d3fed381d93451ffcf96cbf928d7a13d3701", "89bb1449bbef1863b12dfa3813ab7c78be94316f" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 12 18:42:12 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Feb 12 18:42:13 2014 +0000" }, "message": "Merge \"Fix wrong thread id being passed to SIRT roots.\"" }, { "commit": "89bb1449bbef1863b12dfa3813ab7c78be94316f", "tree": "57e4d0325144cd01d73af8b2fe475b9f72b6bad0", "parents": [ "3c976a8f82007285316dd9d1bbccb659b0668a06" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 12 10:06:23 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 12 10:18:24 2014 -0800" }, "message": "Fix wrong thread id being passed to SIRT roots.\n\nFixes jhat on hprof dumps.\n\nChange-Id: I1a71eb3370606129fb5cf791ab582f34052a9f35\n" }, { "commit": "fd14755c09ada4769b5b6658e484441ca3f628b5", "tree": "c70c10b6e319f44dadb56c78acaf7ce89b502d82", "parents": [ "3c976a8f82007285316dd9d1bbccb659b0668a06", "0177e53ea521ad58b70c305700dab32f1ac773b7" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Feb 12 01:16:29 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Feb 12 01:16:30 2014 +0000" }, "message": "Merge \"Work in the direction of hard float quick ABIs.\"" }, { "commit": "0177e53ea521ad58b70c305700dab32f1ac773b7", "tree": "db15627a19a04634cf84cecd15b813319d80d225", "parents": [ "abaf927f29f6feceb3df3e6ced7d01970ba0dbe9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Feb 11 16:30:46 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Feb 11 17:02:21 2014 -0800" }, "message": "Work in the direction of hard float quick ABIs.\n\nPass a shorty to ArtMethod::Invoke so that register setup can use it.\nDocument x86-64 ABI.\nAdd extra debug output for one JNI native method registration fails, namely a\ndump of the Class and its dex file\u0027s location.\nAdd hack to get testing of OatMethod\u0027s without GC maps working in 64bit.\n\nChange-Id: Ic06b68e18eac33637df2caf5e7e775ff95ae70f3\n" }, { "commit": "83c8ee000d525017ead8753fce6bc1020249b96a", "tree": "d5167ed15dee2629905ac3640b6ea0578d4ae312", "parents": [ "7cba217ab0661d74deccbb97160cdf60b74d4ea3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 28 14:50:23 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Feb 11 10:40:10 2014 -0800" }, "message": "Add root types and thread id to root visiting.\n\nEnables us to pass the root type and thread id to hprof.\n\nBug: 12680863\nChange-Id: I6a0f1f9e3aa8f9b4033d695818ae7ca3460d67cb\n" }, { "commit": "ef7d42fca18c16fbaf103822ad16f23246e2905d", "tree": "c67eea52a349c2ea7f2c3bdda8e73933c05531a8", "parents": [ "822115a225185d2896607eb08d70ce5c7099adef" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jan 06 12:55:46 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Feb 06 23:20:27 2014 -0800" }, "message": "Object model changes to support 64bit.\n\nModify mirror objects so that references between them use an ObjectReference\nvalue type rather than an Object* so that functionality to compress larger\nreferences can be captured in the ObjectRefererence implementation.\nObjectReferences are 32bit and all other aspects of object layout remain as\nthey are currently.\n\nExpand fields in objects holding pointers so they can hold 64bit pointers. Its\nexpected the size of these will come down by improving where we hold compiler\nmeta-data.\nStub out x86_64 architecture specific runtime implementation.\nModify OutputStream so that reads and writes are of unsigned quantities.\nMake the use of portable or quick code more explicit.\nTemplatize AtomicInteger to support more than just int32_t as a type.\nAdd missing, and fix issues relating to, missing annotalysis information on the\nmutator lock.\nRefactor and share implementations for array copy between System and uses\nelsewhere in the runtime.\nFix numerous 64bit build issues.\n\nChange-Id: I1a5694c251a42c9eff71084dfdd4b51fff716822\n" }, { "commit": "1efa0a9d6cd5f5b40b8a21d39f1103a3610250ee", "tree": "a7e8d43e657c6af0ff5e25ee029938b75bde6117", "parents": [ "7c84c44f389e3f707eefafab35d4f838dbf7fe26" ], "author": { "name": "Alexei Zavjalov", "email": "alexei.zavjalov@intel.com", "time": "Tue Feb 04 02:08:31 2014 +0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Feb 06 16:41:30 2014 -0800" }, "message": "ART can\u0027t create more than 8k threads during the worktime\n\nART uses LDT to point to the Java Thread structure. This structure\ncan holds up to 8k pointers, so we can have 8k threads simultaneously.\nBut the current implementation does not free slots for the finished threads.\nThis means there cannot be more than 8k threads created during the whole\nlife cycle.\nThis patch implements the LDT slots freeing mechanism.\n\nChange-Id: Ifcf8fe1f4434a13f940146fff39b9c7bf91ee17b\nSigned-off-by: Alexei Zavjalov \u003calexei.zavjalov@intel.com\u003e\n" }, { "commit": "7c6aca27dd2df58ac3d83a93ec5848e2b7d3159a", "tree": "4fa6a6f1c2c8116667a5c848154591c87873eeae", "parents": [ "81c414a90067d6eb6e03f1657e0d121a5f967e13" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jan 31 18:44:56 2014 -0800" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Jan 31 18:45:30 2014 -0800" }, "message": "Properly tolerate missing declaring source files\n\nBroken in 228d6b8a4f0a21c1e9b2372c3104ce4ee19f65b4\n\nBug: 12802375\nChange-Id: I60eeefeb3aff3e0a9f143791cf772e531a68d16a\n" }, { "commit": "bb8f0ab736b61db8f543e433859272e83f96ee9b", "tree": "7b7bac5c0e7d0ac9aba91a40e0fbf761cfacb412", "parents": [ "6e65720d99bd3387b72d528a46291f1ed8184ede" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Mon Jan 27 16:50:29 2014 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Mon Jan 27 16:50:29 2014 -0800" }, "message": "Embed array class pointers at array allocation sites.\n\nFollowing https://android-review.googlesource.com/#/c/79302, embed\narray class pointers at array allocation sites in the compiled code.\n\nChange-Id: I67a1292466dfbb7f48e746e5060e992dd93525c5\n" }, { "commit": "be1ca55db3362f5b100c4c65da5342fd299520bb", "tree": "b9df6f5562d884698ed15f21764a704bb51e359e", "parents": [ "9d8918fe97c235fdc6eb2c7f2d50a6673ab50329" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Jan 15 11:46:48 2014 -0800" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Thu Jan 23 15:29:12 2014 -0800" }, "message": "Use direct class pointers at allocation sites in the compiled code.\n\n- Rather than looking up a class from its type ID (and checking if\n it\u0027s resolved/initialized, resolving/initializing if not), use\n direct class pointers, if possible (boot-code-to-boot-class pointers\n and app-code-to-boot-class pointers.)\n- This results in a 1-2% speedup in Ritz MemAllocTest on Nexus 4.\n- Embedding the object size (along with class pointers) caused a 1-2%\n slowdown in MemAllocTest and isn\u0027t implemented in this change.\n- TODO: do the same for array allocations.\n- TODO: when/if an application gets its own image, implement\n app-code-to-app-class pointers.\n- Fix a -XX:gc bug.\n cf. https://android-review.googlesource.com/79460/\n- Add /tmp/android-data/dalvik-cache to the list of locations to\n remove oat files in clean-oat-host.\n cf. https://android-review.googlesource.com/79550\n- Add back a dropped UNLIKELY in FindMethodFromCode().\n cf. https://android-review.googlesource.com/74205\n\nBug: 9986565\nChange-Id: I590b96bd21f7a7472f88e36752e675547559a5b1\n" }, { "commit": "d45a1f5d1dd5bc9badfab3a8aee90c934d9f2227", "tree": "c4e92844452b5eabfbd936b8d83c54f58397475d", "parents": [ "0adc680c388913a63666797e907f87c4c6b0b4ea" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Jan 09 14:56:54 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Jan 10 09:42:09 2014 +0100" }, "message": "Avoid instrumentation stack corruption.\n\nWhile debugging a throwing exception, we may end up updating instrumentation\nstack frame after having already walked the native stack. This leads to not pop\ninstrumentation frames prior to catch handler (or upcall if exception is not\ncaught) and get it desynchronized with the native stack.\n\nTo solve this issue, we need to walk the stack again after having reporting the\nexception to the instrumentation listener (for example: the debugger) which\nmay push new instrumentation stack frames. However we do it only when we know\ninstrumentation is enabled to not slow down exception delivery when executing\ncode without instrumentation.\n\nHere are the main changes:\n- Creates InstrumentationStackVisitor to compute the number of instrumentation\nframes to pop (previously done in CatchBlockStackVisitor). We only count frames\nprior to catch handler (or upcall). Popping instrumentation frames is done\nafter having reported the exception to the instrumentation listener.\n- Updates the CatchBlockStackVisitor to remove instrumentation frame handling\nand focus only on finding the catch handler and prepare deoptimization.\n- Creates CatchFinder class to control both visitors and do the long jump.\n\nChange-Id: I29b3871403f297bfb8c087e27f1330b002f5d56d\n" }, { "commit": "e6da9af8dfe0a3e3fbc2be700554f6478380e7b9", "tree": "127a0565fce79f05d82d0ff242fbbffa6e2bc6b3", "parents": [ "977d409b959497eecc44a35cff16115d0f04ccab" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 16 11:54:42 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jan 08 14:16:12 2014 -0800" }, "message": "Background compaction support.\n\nWhen the process state changes to a state which does not perceives\njank, we copy from the main free-list backed allocation space to\nthe bump pointer space and enable the semispace allocator.\n\nWhen we transition back to foreground, we copy back to a free-list\nbacked space.\n\nCreate a seperate non-moving space which only holds non-movable\nobjects. This enables us to quickly wipe the current alloc space\n(DlMalloc / RosAlloc) when we transition to background.\n\nAdded multiple alloc space support to the sticky mark sweep GC.\n\nAdded a -XX:BackgroundGC option which lets you specify\nwhich GC to use for background apps. Passing in\n-XX:BackgroundGC\u003dSS makes the heap compact the heap for apps which\ndo not perceive jank.\n\nResults:\nSimple background foreground test:\n0. Reboot phone, unlock.\n1. Open browser, click on home.\n2. Open calculator, click on home.\n3. Open calendar, click on home.\n4. Open camera, click on home.\n5. Open clock, click on home.\n6. adb shell dumpsys meminfo\n\nPSS Normal ART:\nSample 1:\n 88468 kB: Dalvik\n 3188 kB: Dalvik Other\nSample 2:\n 81125 kB: Dalvik\n 3080 kB: Dalvik Other\n\nPSS Dalvik:\nTotal PSS by category:\nSample 1:\n 81033 kB: Dalvik\n 27787 kB: Dalvik Other\nSample 2:\n 81901 kB: Dalvik\n 28869 kB: Dalvik Other\n\nPSS ART + Background Compaction:\nSample 1:\n 71014 kB: Dalvik\n 1412 kB: Dalvik Other\nSample 2:\n 73859 kB: Dalvik\n 1400 kB: Dalvik Other\n\nDalvik other reduction can be explained by less deep allocation\nstacks / less live bitmaps / less dirty cards.\n\nTODO improvements: Recycle mem-maps which are unused in the current\nstate. Not hardcode 64 MB capacity of non movable space (avoid\nreturning linear alloc nightmares). Figure out ways to deal with low\nvirtual address memory problems.\n\nBug: 8981901\n\nChange-Id: Ib235d03f45548ffc08a06b8ae57bf5bada49d6f3\n" }, { "commit": "0aded089f565008ba5908e395e5914ca4f91f2de", "tree": "3b1238d956e0181d00243604c83c3a0be368437d", "parents": [ "98ba6cebd22489c959d845884ee045dcbd958d41" ], "author": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Thu Nov 07 13:15:11 2013 -0800" }, "committer": { "name": "Dave Allison", "email": "dallison@google.com", "time": "Tue Jan 07 10:58:07 2014 -0800" }, "message": "Add sampling profiler\n\nThis adds a sampling profiler thread that runs every so often, gathering\nprofiling data and writing the results to a file in /data/data (specific to\napp running). The intention is to use these files as input to the compiler\nso that it can determine the best methods to compile.\n\nBug: 11539952\nChange-Id: I0bfbb4146fb7966673c792f017ffac8107b6272d\n" }, { "commit": "e8c48db6bb507d7fa20c78481c58c23be0045f67", "tree": "ceac197a9d9f32609f845377e9fe87949bff5527", "parents": [ "e40687d053b89c495b6fbeb7a766b01c9c7e039c" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Dec 19 14:59:00 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Dec 19 15:14:42 2013 -0800" }, "message": "Fix NewLocalRef, NewGlobalRef to handle cleared weak globals.\n\nWe were not checking for null after decoding the reference, this\nmeant that we incorrectly created null weak global references instead\nof returning null.\n\nIssue: 63929\nChange-Id: I9159682e6edad8f415ef8144fc13b9aedd2cceb4\n" }, { "commit": "692fafd9778141fa6ef0048c9569abd7ee0253bf", "tree": "63ce2c7d4be6af2524a5f442195c8c8b6f5cc955", "parents": [ "07dc96d370c4844c7a279c01cedf24a272b9f4f3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Nov 29 17:24:40 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Dec 16 16:57:37 2013 -0800" }, "message": "Thread local bump pointer allocator.\n\nAdded a thread local allocator to the heap, each thread has three\npointers which specify the thread local buffer: start, cur, and\nend. When the remaining space in the thread local buffer isn\u0027t large\nenough for the allocation, the allocator allocates a new thread\nlocal buffer using the bump pointer allocator.\n\nThe bump pointer space had to be modified to accomodate thread\nlocal buffers. These buffers are called \"blocks\", where a block\nis a buffer which contains a set of adjacent objects. Blocks\naren\u0027t necessarily full and may have wasted memory towards the\nend. Blocks have an 8 byte header which specifies their size and is\nrequired for traversing bump pointer spaces.\n\nMemory usage is in between full bump pointer and ROSAlloc since\nmadvised memory limits wasted ram to an average of 1/2 page per\nblock.\n\nAdded a runtime option -XX:UseTLAB which specifies whether or\nnot to use the thread local allocator. Its a NOP if the garbage\ncollector is not the semispace collector.\n\nTODO: Smarter block accounting to prevent us reading objects until\nwe either hit the end of the block or GetClass() \u003d\u003d null which\nsignifies that the block isn\u0027t 100% full. This would provide a\nslight speedup to BumpPointerSpace::Walk.\n\nTimings: -XX:HeapMinFree\u003d4m -XX:HeapMaxFree\u003d8m -Xmx48m\nritzperf memalloc:\nDalvik -Xgc:concurrent: 11678\nDalvik -Xgc:noconcurrent: 6697\n-Xgc:MS: 5978\n-Xgc:SS: 4271\n-Xgc:CMS: 4150\n-Xgc:SS -XX:UseTLAB: 3255\n\nBug: 9986565\nBug: 12042213\n\nChange-Id: Ib7e1d4b199a8199f3b1de94b0a7b6e1730689cad\n" }, { "commit": "8755359a35a4aa915fe3753633015263c7e97b74", "tree": "57c0b62f7e9b6cacfbd18d1e33f437b69621fa48", "parents": [ "0b5a3fe08213dff52b73b2388b50a87d09b7da4f", "c528dba35b5faece51ca658fc008b688f8b690ad" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 11 20:25:08 2013 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Dec 11 20:25:09 2013 +0000" }, "message": "Merge \"Enable moving classes.\"" }, { "commit": "543154a81625e2c724b6f794afc664cf9eddf65e", "tree": "8117bf96c65d3716a4b371b63cf60a4b3036154c", "parents": [ "ed61d742acea70a06d992eb037c7343c2ad74333", "123756a041baf8421ed933312605daa5ef082f6f" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Dec 11 08:48:09 2013 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Dec 11 08:48:10 2013 +0000" }, "message": "Merge \"Fix JDWP class-only modifier.\"" }, { "commit": "c528dba35b5faece51ca658fc008b688f8b690ad", "tree": "d95c113a639d07f7e3b88e8a6caa9b5f6e044801", "parents": [ "76f552307ee980221626d1dff0ada56c989d24ca" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Nov 26 12:00:11 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Dec 10 16:00:58 2013 -0800" }, "message": "Enable moving classes.\n\nSlight reduction in Zygote size, memory savings are in the noise.\nBefore: Zygote size: 8739224\nAfter: Zygote size: 8733568\n\nFixed a bug where we didn\u0027t set the concurrent start bytes after\nswitching the allocator from bump pointer to ROSAlloc in the\nzygote. This caused excessive memory usage.\n\nAdded the method verifiers as roots to fix an issue caused by\nRegTypes holding a Class*.\n\nAdded logic to clear card table in the SemiSpace collector, this\nreduces DalvikOther from ~2400k -\u003e ~1760k when using the SemiSpace\ncollector.\n\nAdded a missing lock to the timing loggers which caused a rare\none time crash in std::set.\n\nBug: 11771255\nBug: 8499494\nBug: 10802951\n\nChange-Id: I99d2b528cd51c1c5ed7012e3220b3aefded680ae\n" }, { "commit": "8171fc34bf74ed0df02385787d916bc13eb7f160", "tree": "9c2b15d421bbf7483dd042a4b9985517c3cc86ee", "parents": [ "fa365d2fa097810f31d6cb1b1ef415636bc63af8" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Nov 26 17:05:58 2013 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Dec 10 10:02:58 2013 +0000" }, "message": "Don\u0027t prefix GC map by length.\n\nBug: 11767815\nChange-Id: I063917aefdf7674ee1a77736db059c9ee95ea075\n" }, { "commit": "59cde534aa295bad7de29472b3cce9576d7996a8", "tree": "acb79971feefac450a56bca758524614012c30e4", "parents": [ "93461f9b0b1304b94eee0ef33ef5679406e84dd8" ], "author": { "name": "Chris Dearman", "email": "chris.dearman@imgtec.com", "time": "Wed Dec 04 18:53:49 2013 -0800" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Thu Dec 05 15:52:08 2013 -0800" }, "message": "Workaround for gcc volatile struct member bug\n\ngcc does not handle struct with volatile member assignments correctly.\nSee http://gcc.gnu.org/bugzilla/show_bug.cgi?id\u003d47409\n\nUsing structure assignments for the StateAndFlag union can cause gcc\nto optimise the code incorrectly. Doing the assignment using the\nas_int member forces the correct behaviour.\n\nChange-Id: I6379d36add16c321b2e4d1dcd6fd8c959f3f92d6\n" }, { "commit": "5f51d4b80058236759fea1d932470a57f348c199", "tree": "096ce11ba8dc096fd27d2fbed84459080c7d3b1e", "parents": [ "d83d4c86c89357a74e94963994ad0c42ea7299c3" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Dec 03 14:24:05 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Dec 05 12:57:43 2013 -0800" }, "message": "Fix races in thread list Unregister.\n\nFirst race:\nWe were releasing the thin_lock_id in Unregister before the thread\nwas not suspended. This could cause problems in\nSuspendThreadByThreadId since there was a small window of time where\ntwo threads could share the same thread id. This race caused an\noccasional check failure in SuspendThreadByThreadId.\n\nSecond race:\nWe were setting the thin_lock_thread_id_ to 0 in Unregister before\nwaiting to not be suspended. This caused another race in\nSuspendThreadByThreadId where we modified the thread suspend count,\nbusy waited, but didn\u0027t find the thread the next iteration. This\nmeant that we were returning null even though we had modified the\nsuspend count. This caused the suspend count to not get decremented\nsince the caller didn\u0027t know that the suspend count had been\nincreased. Removing the self-\u003ethin_lock_thread_id_ \u003d 0 in\nThreadList::UnRegister fixes this race.\n\nAdded a bit of additional checks and logging to prevent these issues\nfrom resurfacing, other misc cleanup.\n\nAdded thread names to threads in ThreadStress.\n\nBug: 11319866\n\nChange-Id: I48e3a0700193b72079e450be1e924a2f88cf52e2\n" }, { "commit": "123756a041baf8421ed933312605daa5ef082f6f", "tree": "0b9524660399b9e42adcc178027c9ddd8a61bd38", "parents": [ "315ab6c077c4db2031f1ffa40b78722d8269dc9b" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Nov 27 15:49:42 2013 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Dec 05 15:02:35 2013 +0100" }, "message": "Fix JDWP class-only modifier.\n\nFix Dbg::MatchType which is used for class-only and exception-only modifiers.\n\nAlso fix crash happening when notifying an exception. A debugger may walk the\nstack of the current thread so we need to keep the instrumentation stack frame\nsynced with the native stack.\n\nBug: 11856587\nChange-Id: Ibf95f8a83ce9ee640abf945e498b42cc88ea92a0\n" }, { "commit": "228d6b8a4f0a21c1e9b2372c3104ce4ee19f65b4", "tree": "3354f44c78ee2597244e8f2bf1d984f34b1eee3c", "parents": [ "0f6615fe052a499ff7d6e6583a2f66aeb6146f1e" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Dec 03 15:00:05 2013 -0800" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Wed Dec 04 00:29:12 2013 +0000" }, "message": "Fix stack trace for proxy methods and added test case.\n\nBug: 11861564\n\nChange-Id: I9513359ff9e5d345ee71d84388afed02bd114ecf\n" } ], "next": "2054553237998043f0cd3d6b9fef799a4e6d95c0" }