)]}' { "log": [ { "commit": "8f187c3326b30fc43bedb254351ea55185fbd51a", "tree": "8f51159f835f112dcd9ada2e17b234744aac3cca", "parents": [ "e0f5839ae6e8dd90ccb31e658e3c20a8db10c219" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Apr 20 14:29:00 2021 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Apr 23 22:56:43 2021 +0000" }, "message": "Add static asserts we have a full list of mirror classes\n\nWe need to know if a particular object is of a mirrored class type in\norder for structural class redefinition to work correctly. For\nsimplicity and to avoid making class objects larger we do this with a\nsimple list of mirror-class descriptors. This adds some basic\nstatic_assert checking and a documenting macro to all mirror classes.\nThis should help to ensure nobody in the future unintentionally breaks\nstructural class redefinition by adding a new mirror type.\n\nTest: treehugger\nBug: 144349987\nChange-Id: I47c7b256655e9ce9bcf21d9670e0511bcbac65c9\n" }, { "commit": "c7993d55b2912532c1b0917e6b0ca43097bed21d", "tree": "1145ce1c0ffbbd729d0a6c1b53c608bf7adb3d6a", "parents": [ "22538e4672348c56d4d44d6113bedd6b47d0abd0" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jan 27 15:20:56 2021 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jan 28 14:14:16 2021 +0000" }, "message": "Rewrite ClassLinker::LinkFields().\n\nRewrite field offset assignment to avoid heap allocations in\nmost cases. We do one allocation if there are many fields.\n\nRewrite gap filling to prefer small gaps over big ones. This\ncreates more natural field ordering. For example,\n class A { byte unalign; }\n class B extends A {\n long l;\n\tbyte a, b, c, d, e, f;\n }\nwould have previously had offsets\n 12, 10, 14, 9, 11, 13, 15\nfor fields a, b, c, d, e, f, respectively. Now these are\n 9, 10, 11, 12, 13, 14, 15\nin line with their lexicographical order.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: boots.\nBug: 175869411\nChange-Id: I558635ac59c959dd85e8a3b015c26a6d90033853\n" }, { "commit": "b6f4c79b06bb97651a7be1ac828d18ed18356603", "tree": "ef0bbb1281f6d4785e60f26cb420646c83eb6f6d", "parents": [ "3971661c74a9b4635d9744f72f3b053c820067c9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 04 15:37:29 2020 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 05 08:05:24 2020 +0000" }, "message": "Clean up Constructor/Method/Field construction.\n\nSimplify the code by ignoring active transactions. Writing\nto fields of a newly allocated object does not need to be\nrecorded as aborting the transaction removes all references\nto the new object and it\u0027s unnecessary to roll back writes\nto unreachable object\u0027s fields.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nTest: aosp_taimen-userdebug boots.\nChange-Id: Ib5cd60c003d2ad3e6a246ff86d6b9288428c60ee\n" }, { "commit": "c18eba327c4e207ff7b38817f097ee2220b44b39", "tree": "1978e64abd3e9fd3df99179f4a2110a724a9565f", "parents": [ "371390f775c90b8b3df11a9890585598a2a39da9" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Sep 24 14:36:27 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Sep 27 17:08:33 2019 +0000" }, "message": "Consolidate updating of reflective Field/Method references\n\nPreviously we used several different visitors to update Field \u0026\nMethod references for structural redefinition. We also did not visit\nor update JVMTI based references.\n\nThis consolidates all the visitors to a single\nRuntime::VisitReflectiveTargets function with a single\nReflectiveTargetVisitor type. This simplifies the code around\nstructural redefinition and ensures that the reflective value holders\nare in charge of the actual replacement.\n\nSupport was also added for walking internal openjdkjvmti references\nfor things like field-read/modification events.\n\nTest: ./test.py --host\nBug: 134162467\n\nChange-Id: Ic5fc1db7db0a30f947a1a67259dc024e149ebd57\n" }, { "commit": "4ac0e1571e015a01d75091c3daef065f9624ad77", "tree": "4d13edeab88bd6fd724388c48385b0c3cca4f3a8", "parents": [ "5a2301d897294ff4ee6de71f459dc2566dc3fa1a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:14:50 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:14:50 2019 +0000" }, "message": "Revert \"Revert \"Basic structural redefinition support\"\"\n\nThis reverts commit 5a2301d897294ff4ee6de71f459dc2566dc3fa1a.\n\nBug: 134162467\n\nReason for revert: Relanding as unclear if issue is due to topic.\n\nChange-Id: Ib1d1cf2e9132e30c9649b760ae9ae2d8ceacf843\n" }, { "commit": "5a2301d897294ff4ee6de71f459dc2566dc3fa1a", "tree": "2bd06ab3f463734994b3d251f6115514520dbb3f", "parents": [ "4eb6eb40e88214fcc874d93e75660cb580cb4d58" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:11:22 2019 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 18 06:12:13 2019 +0000" }, "message": "Revert \"Basic structural redefinition support\"\n\nThis reverts commit c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c.\n\nBug: 134162467\n\nReason for revert: Breaks on redefine-stress\n\nChange-Id: I4e38da23d65b5b34b26b5ab537a3583328e078a4\n" }, { "commit": "c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c", "tree": "f8647487e7465712fd73118ceb89e13167a12648", "parents": [ "1ba7e8c10af4e270864a417044244d63db53ccf5" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Aug 13 10:50:38 2019 -0700" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Tue Sep 17 23:52:12 2019 +0000" }, "message": "Basic structural redefinition support\n\nThis adds basic support for adding methods and fields to already\nloaded classes using redefinition. This \u0027structural class\nredefinition\u0027 is currently limited to classes without any virtual\nmethods or instance fields. One cannot currently structurally redefine\nmultiple classes at once nor will structural redefinition trigger the\nstandard redefinition events.\n\nAfter structural redefinition all references to the old class, and its\nfields and methods are atomically updated. Any memory associated with\nthe static fields of the old class is zeroed. Offsets for field access\nmight change. If there are any active stack frames for methods from\nthe redefined class the original (obsolete method) code will continue\nto execute. The identity hash code of the redefined class will not\nchange. Any locks being held, waited or blocked on by the old class\nwill be transferred to the new class.\n\nTo use this feature the process must be debuggable and running with\n-Xopaque-jni-ids:true.\n\nFor device testing use a wrap.sh that adds the following flags:\n\n \u0027-Xopaque-jni-ids:true -Xcompiler-option --debuggable -XjdwpProvider:adbconnection\u0027\n\nStructural redefinition only available using the\n\"com.android.art.UNSAFE.class.structurally_redefine_class_direct\"\nextension. This will not trigger the normal class-redefinition events.\nOnly one class may be redefined at a time.\n\nNB There are still some holes in this potentially allowing obsolete\nmethods/fields to be visible. Most notably during jni-id, MethodHandle\nand VarHandle creation as well as potentially other places in the\nruntime. These holes will be closed by later CLs. Until then the\nextension to access structural class redefinition will remain tagged\nas UNSAFE.\n\nTest: ./test.py --host --all-compiler\nBug: 134162467\n\nChange-Id: I825d3a4bdb9594c0147223ae69f433ce9bbfc307\n" }, { "commit": "0eefb9bad0b098e892f977694ad1207f3ef42c90", "tree": "9c1abc5959eaf2d6a3a420369ba642381febca04", "parents": [ "5aead700219d9c9fc05524d5d72dc32cb1807c61" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Mar 27 15:04:31 2019 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 28 09:22:07 2019 +0000" }, "message": "ObjPtr\u003c\u003e-ify mirror::Field and mirror::Executable.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ib536df95543cb7240a5816bef019391bb90e6369\n" }, { "commit": "4df2d8041f5dcc7af8c3b3b60b0ea87a1e0d3b94", "tree": "0273072a2b65d6c0cf692a3e7f8eab9814d9d23d", "parents": [ "233b572a940431a94a1790750afdceab2d6f4fde" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:42:44 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Sep 28 09:12:06 2018 +0100" }, "message": "Revert^2 \"Load boot image at a random address.\"\n\nThis reverts commit f3d077373536c54824e4449759dff2f18369eab3.\n\nFixed Heap constructor to reserve extra space for GSS.\n\nChange-Id: I6a65be35f4aa183304db5491da4a4810d8e3b266\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --relocate --no-relocate\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing --relocate --no-relocate\nTest: art/test/testrunner/run_build_test_target.py -j48 art-gtest-gss-gc-tlab\nBug: 77856493\n" }, { "commit": "f3d077373536c54824e4449759dff2f18369eab3", "tree": "e00d19a342ff429fc514bf70bf52ff005a00911c", "parents": [ "5ad79d85d77a42456728897ac3e2e7d4530e618e" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:24:17 2018 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 27 16:24:17 2018 +0000" }, "message": "Revert \"Load boot image at a random address.\"\n\nThis reverts commit 5ad79d85d77a42456728897ac3e2e7d4530e618e.\n\nReason for revert: Breaks GSS garbage collection config.\n\nBug: 77856493\nChange-Id: Ifa39966ac2470154f8ba093de4804689d545219b\n" }, { "commit": "5ad79d85d77a42456728897ac3e2e7d4530e618e", "tree": "ff70d1f12904c718f2f3f721d3846f4305eae53d", "parents": [ "5d7015cd64085068b1685d44339b4b705ef3f065" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 03 09:54:09 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 26 13:08:36 2018 +0100" }, "message": "Load boot image at a random address.\n\nAnd perform in-place fixup of references and pointers. This\ndirties all the boot image memory loaded by zygote, so there\nshall be no \"shared clean\" boot image pages anymore, these\nshall change to \"shared dirty\". However, as we\u0027re using a\nprofile-based boot image, these pages are presumably used\noften enough and unlikely to be paged out anyway.\n\nThe in-place fixup takes around 60-120ms when starting the\nzygote on aosp_taimen-userdebug. However, an experiment with\nMAP_POPULATE pushes the raw fixup down to around 12-15ms.\nIf we used compressed images, this would be the actual time\nfor fixup as the data would be already present in memory.\nIf we keep using uncompressed images, we shall need to tune\nthe loading with MAP_POPULATE or MADV_WILLNEED.\n\nThe -Xrelocate/-Xno-relocate option is re-interpreted from\n\"use patchoat if needed\" to \"relocate the boot image in\nmemory if possible\". We do not allow relocation for the AOT\ncompilation to speed up dex2oat execution and help producing\ndeterministic output.\n\nThe patchoat tool shall be removed in a follow-up CL.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing --relocate --no-relocate\nTest: Pixel 2 XL boots.\nTest: m test-art-target-gtest\nTest: testrunner.py --target --optimizing --relocate --no-relocate\nBug: 77856493\nChange-Id: I2db1fabefb5d4b85c798cd51e04c78cb232bff4a\n" }, { "commit": "ca8de0a70eab62707f3c71a211093f340fdcd5f4", "tree": "a391c1307e87edad399418236a2a1842a8f06f34", "parents": [ "7f7f9d3991f3a55da8934a3b72890d4776373598" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jul 04 11:56:08 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 19 13:42:20 2018 +0100" }, "message": "Move .art.rel data to a section in .art, part 1.\n\nRefactor the code so that we can collect all relocation\noffsets while writing the image.\n\nTest: Manually verify that the aosp_taimen-userdebug boot\n image is identical before and after this change;\n using WIP follow-up code, check that we record the\n same locations as the patchoat-generated .rel files.\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 77856493\nChange-Id: Id8c78e417e77e859a82a680504253f41e84560d6\n" }, { "commit": "317892b756cd2a87c01928b09e99e020c86dea10", "tree": "bb337ff8cd81c049e781afbd8c68b72ca30907fc", "parents": [ "1539a11150ca9c28fec353b38508267c41d7814b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 11:11:32 2018 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 31 13:56:49 2018 +0100" }, "message": "Remove static GcRoot\u003c\u003es from Class and ClassExt.\n\nAnd clean up gc_root includes in runtime/mirror/.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host --optimizing\nBug: 31113334\nChange-Id: Ib5c42a3a892ced4440720350a63a94bcf3a1ca75\n" }, { "commit": "57cf00bde719ddc84a6015b107b90a20169e3099", "tree": "1522952470490e6b107d07649f511ef09f9abd32", "parents": [ "40c6710dfa0d10d34dcca8ed92c214faba36c833" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 05 17:15:32 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jun 05 18:29:04 2017 -0700" }, "message": "ART: Remove old object_callbacks.h includes\n\nRemove unused includes.\n\nTest: m\nChange-Id: I70c227d32c6900904e186b975d1f2131b718d93d\n" }, { "commit": "0e8443995af602bcc2e70dcef1d20ee48acec934", "tree": "2d81b8db23bea139e40e33e4e9b8c69027fb1e56", "parents": [ "c4cb3d532db8a500c1a15e8a0052895960259209" ], "author": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Thu Sep 08 13:43:31 2016 +0100" }, "committer": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Wed Sep 21 11:42:21 2016 +0100" }, "message": "Collapse ART\u0027s AbstractMethod class into Executable\n\nAfter the OpenJDK 8 pull there is now a common base class\nfor Method and Constructor that can be used instead.\n\nMethods that are abstract on Executable but on Android\nwere implemented in AbstractMethod are now consistently\nrenamed to \"{method}Internal\", declared final and\ngiven package-protected access.\n\nFor consistency with all other private, natively\nimplemented methods, the method getDeclaredAnnotations()\nhas been renamed getDeclaredAnnotationsNative().\n\nBug: 28666126\nBug: 31052885\nTest: make test-art-host and cts run of CtsLibcoreTestCases\nChange-Id: Ibfe6af6a47fe0cfffd0859ffbe58980aeb84e053\n" }, { "commit": "60458a072c4f0b24038420b0f1bed0fe94c72965", "tree": "e1e10a29c99f99538695c12da1af914d84ddd4c3", "parents": [ "9d185da3bef8caf015d3dbf4ad79c520af7ce3b1" ], "author": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Thu Sep 01 15:32:44 2016 +0100" }, "committer": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Wed Sep 07 11:12:02 2016 +0100" }, "message": "Track libcore Executable.getParameter() changes\n\nExecutable.getParameter() has been added which added\ntwo new fields to java.lang.reflect.Executable,\nimpacting class arrangements and padding.\n\nThe java.lang.reflect.Parameter class has been added\nwhich has some associated native code and support\nmethods in DexFile.\n\nTest: make test-art-host\nBug: 28666126\nChange-Id: I4ff6469388879651a6c9e568eca0b1cd716f0c0d\n" }, { "commit": "16b21cd4874be8550f43987b0bd2e4ba8ba3ca42", "tree": "475aeec7476e039442009ca36c1ddde1c9cdbd47", "parents": [ "ca11dc008457e1596554eb9b1b77c823ae9dcf54" ], "author": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Fri Aug 12 09:37:02 2016 +0100" }, "committer": { "name": "Neil Fuller", "email": "nfuller@google.com", "time": "Fri Aug 26 14:31:26 2016 +0100" }, "message": "Tracking java.lang.reflect.Executable changes\n\nAdded a method to Class: total vtable entries increases\nby one.\n\nHandling knock-ons of introducing Executable into the\nclass hierarchy above AbstractMethod.\n\nRearranging java_lang_reflect_*.cc code to track libcore\nchanges that reduce duplication between Constructor / Method\n/ Executable and AbstractMethod and track the OpenJDK 8\nmore closely.\n\nBug: 28666126\nChange-Id: I6b5c476a14b8ea25556c35448431de744519b6c2\n" } ] }