)]}' { "log": [ { "commit": "8a0128a5ca0784f6d2b4ca27907e8967a74bc4c5", "tree": "0dec75200282ae5e49785395e97bd4e6459f1c09", "parents": [ "60438b46090d22bb9b978196f5aa53fab3b89759" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 28 07:38:35 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Nov 29 11:11:46 2016 -0800" }, "message": "ART: Add dex::StringIndex\n\nAdd abstraction for uint32_t string index.\n\nTest: m test-art-host\nChange-Id: I917c2881702fe3df112c713f06980f2278ced7ed\n" }, { "commit": "fef0664fa7b480032f17c60f767bcca43a659d8a", "tree": "5b1f812aef3e300b7bef0bd5ad5a2fa5a8d5c38a", "parents": [ "5ee771615a7e7752abb8b0d53122ca44137c4286" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Nov 25 16:07:11 2016 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Nov 25 16:07:11 2016 +0000" }, "message": "ART: Throw InternalError rather than VirtualMachineError\n\nInstantiate InternalError instead of VirtualMachineError as the latter\nis abstract and not instantiable.\n\nChange-Id: I3e90b28a34bef02dd1c200c02cb832aa8dce10b3\n" }, { "commit": "a5b09a67034e57a6e10231dd4bd92f4cb50b824c", "tree": "304be738f4fa528b7ad2676103eecc84c79eaeeb", "parents": [ "dac7ad17c78387d15d7aefae0f852dddf5f37e34" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Nov 17 15:21:22 2016 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Nov 21 10:57:00 2016 -0800" }, "message": "ART: Add dex::TypeIndex\n\nAdd abstraction for uint16_t type index.\n\nTest: m test-art-host\nChange-Id: I47708741c7c579cbbe59ab723c1e31c5fe71f83a\n" }, { "commit": "3d617ac3d87f7fa98793406818e54b057bd701a1", "tree": "5230ceedfaf2928da0404fd71b64fa7f08439f21", "parents": [ "b5cc1d1321e36d38cd48ae079438a8758b82edc1" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Oct 19 14:00:46 2016 +0100" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Mon Oct 31 09:16:19 2016 +0000" }, "message": "Getter/Setter support for invoke-polymorphic of invokeExact().\n\nTest: make test-art-host\nBug: 30550796\n\nChange-Id: I427a6e0afba88b223655ad1ba30843aaf255182b\n" }, { "commit": "269cb43d6df76b52a42c1c7a9436c92bd0dcdad6", "tree": "6fb3dec2763ffdacdf1b31e4ed04c3f0c6cc5f81", "parents": [ "d6435da102851e155acd12adc420e7df3db47903" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Fri Oct 28 10:19:54 2016 +0100" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Fri Oct 28 11:48:49 2016 +0000" }, "message": "class_linker: Change allocation of MethodType dex_cache entries.\n\nWe allocate them regardless of the value of the runtime flag to\navoid needing changes to the compiler etc. The memory hit can be\nmitigated in production systems that don\u0027t use MethodHandles by\nsetting kDexCacheMethodTypeCacheSize to 0.\n\nAlso, add DCHECKS in the interpreter to make sure the runtime\nnever executes an invoke-polymorphic instruction when method handles\nare disabled.\n\nTest: make test-art-host\nBug: 30550796\nChange-Id: Id4b2065d99dc13625a51037b7d1a9f0ac5ff6121\n" }, { "commit": "ef41db7a3f322a1feb305fdb457410c4cea94d00", "tree": "c03152c091ef62ab70f5be0a2fe3a965b189132c", "parents": [ "1458e0c09fe0a3b9fa5fd7beb9b6077d1fc46b1d" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 25 15:08:01 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 26 15:25:40 2016 -0700" }, "message": "Move interpreter to ObjPtr\n\nMoved most of interpreter, interpreter_common,\ninterpreter_switch_impl, and some of mterp to ObjPtr.\n\nBug: 31113334\n\nTest: test-art-host ART_TEST_INTERPRETER\u003dtrue\nTest: art/tools/run-libcore-tests.sh \u0027--mode\u003dhost\u0027 \u0027--variant\u003dX32\u0027 --debug\n\nChange-Id: I0935d18287e1332205c17c5a018aa167788ab897\n" }, { "commit": "709b070044354d9f47641f273edacaeeb0240ab7", "tree": "3a8ac051d7c35076303984d0d892cdd396b60427", "parents": [ "1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1" ], "author": { "name": "David Sehr", "email": "sehr@google.com", "time": "Thu Oct 13 09:12:37 2016 -0700" }, "committer": { "name": "David Sehr", "email": "sehr@google.com", "time": "Tue Oct 18 14:10:04 2016 -0700" }, "message": "Remove mirror:: and ArtMethod deps in utils.{h,cc}\n\nThe latest chapter in the ongoing saga of attempting to dump a DEX\nfile without having to start a whole runtime instance. This episode\nfinds us removing references to ArtMethod/ArtField/mirror.\n\nOne aspect of this change that I would like to call out specfically\nis that the utils versions of the \"Pretty*\" functions all were written\nto accept nullptr as an argument. I have split these functions up as\nfollows:\n1) an instance method, such as PrettyClass that obviously requires\nthis !\u003d nullptr.\n2) a static method, that behaves the same way as the util method, but\ncalls the instance method if p !\u003d nullptr.\nThis requires using a full class qualifier for the static methods,\nwhich isn\u0027t exactly beautiful. I have tried to remove as many cases\nas possible where it was clear p !\u003d nullptr.\n\nBug: 22322814\nTest: test-art-host\nChange-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24\n" }, { "commit": "28bd2e4f151267b34b8e1eb19c489d8d547bbf5c", "tree": "d99ae3fe74ea63b83091898d830d3efe68cd479d", "parents": [ "6e5fa09510c7280168e040382d27dd8b55760d9a" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Oct 04 13:54:57 2016 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Oct 13 10:59:28 2016 -0700" }, "message": "Move mirror::Class to use ObjPtr\n\nLeave the return types as non ObjPtr for now. Fixed moving GC bugs\nin tests.\n\nTest: test-art-host\n\nBug: 31113334\n\nChange-Id: I5da1b5ac55dfbc5cc97a64be2c870ba9f512d9b0\n" }, { "commit": "9823e788ed3368ecf826c44bfa16ccabfcbe32f8", "tree": "59dee92dfd7518a98905c8313bdcb0a2ca2946cb", "parents": [ "82d4838d6bb3480cd25327cedc5179fb2d86881c" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Wed Aug 03 12:46:58 2016 +0100" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Wed Oct 05 10:34:59 2016 +0100" }, "message": "Basic implementation of invoke / invoke-polymorphic.\n\nBasic switch interpreter support for invoke-polymorphic. This change\nallows for virtual/interface and static invokes on method handles.\n\nSupport for direct invokes (including constructors) and field\ngetters and setters will be added in follow up changes.\n\nBug: 30550796\nTest: make test-art-host\n\nChange-Id: Ieb3a991d974060d930d56467908d5c7c11d0e38e\n" }, { "commit": "8aea8dbca646074cc02d839be28ba3fd9863b0b8", "tree": "3cffbb3f1913302afeee21d6c45577073fb774e9", "parents": [ "7c95b4e22897a6f14ef79ec6e547e2eed686814a", "9231f4e55d6e79e37880071e222c28141bf65f49" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Aug 24 17:09:42 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Aug 24 17:09:43 2016 +0000" }, "message": "Merge \"ART: Remove vestiges of GCC\"" }, { "commit": "9231f4e55d6e79e37880071e222c28141bf65f49", "tree": "929c75752d7dd5d667b5f2cdaa044ad83d0522eb", "parents": [ "e99331f7a430b0b72142dd0b8b0689421489dcf6" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 23 17:35:19 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Aug 23 18:20:12 2016 -0700" }, "message": "ART: Remove vestiges of GCC\n\nWe no longer support GCC.\n\nChange-Id: I869ac6e5dcb166747e45236a0d313c7672bbf2de\nTest: m test-art-host\n" }, { "commit": "51a0c4fe2dabeb21525d377047b68031b6fe0186", "tree": "83a02e40cd106e6decbf100870b2e931232820db", "parents": [ "e99331f7a430b0b72142dd0b8b0689421489dcf6", "3aaa37bba53d6df0265793de48b4b0b57327e57a" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Aug 24 00:50:38 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Aug 24 00:50:39 2016 +0000" }, "message": "Merge \"creating workflow for mirror::String compression\"" }, { "commit": "3aaa37bba53d6df0265793de48b4b0b57327e57a", "tree": "ce795803f0f10003eb3d96d9348da620937675b3", "parents": [ "792c98bb773c8c2390f9cbf774f85be9d9a75332" ], "author": { "name": "jessicahandojo", "email": "jessicahandojo@google.com", "time": "Fri Jul 29 14:46:37 2016 -0700" }, "committer": { "name": "jessicahandojo", "email": "jessicahandojo@google.com", "time": "Tue Aug 23 15:12:26 2016 -0700" }, "message": "creating workflow for mirror::String compression\n\nAll-ASCII String characters are stored in 8-bit blocks\ninstead of 16-bit. The compression has not taken place, but all\nworkflow are in the code already (changing kUseStringCompression in\nstring.h file to TRUE will enable the feature)\n\nNotes: Feature works on interpreter only without optimizing\n\nTest art: m ART_TEST_INTERPRETER\u003dtrue ART_TEST_OPTIMIZING\u003dfalse\n test-art-host\n\nAlso tested with String tests from libcore/:\n1. libcore.java.lang.StringTest\n2. libcore.java.lang.StringBufferTest\n3. libcore.java.lang.StringBuilderTest\n4. libcore.java.lang.OldStringTest\n5. libcore.java.lang.OldStringBufferTest\n\nMemory improvement is 33% (from 6.03% to 4.03%, total String memory\nfrom all apps per total memory of all apps) measured on Angler\nwith Hprof tools\n\nBug: 31040547\nChange-Id: I9cc92c265ebf1305fc06b5fc33efd83797660cce\n" }, { "commit": "5e26eb1dc8ea89b2ebf4ce4b40cbe18542758fbd", "tree": "ac8eaad8db47f667e3290e63f52f6e1c06f9fbad", "parents": [ "cf834d00de838272cf28f2382ffc26fe716aae5c" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 22 17:54:17 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 22 21:30:40 2016 -0700" }, "message": "ART: Clean up interpreter includes\n\nMove goto-interpreter special-cased Clang declarations to goto\nimplementation file. Separate out declarations into their own\nheaders. Tag the declarations with thread safety annotations.\n\nMinor compile-time impact when running with -j1.\n\nChange-Id: I03664d4e7dc6361b2510a8c9beb693d23a657c9d\nTest: m test-art-host\nTest: m ART_TEST_INTERPRETER\u003dtrue test-art-host\n" }, { "commit": "8ec3bd2b31ccbc9027b8e9b1949dd1804bb6d30f", "tree": "6cc457a060c7faade49229010bfe3119e55b254d", "parents": [ "c218427ab96e521e0c4e9a3ffeb87e6c57eea0a5" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Wed Aug 03 12:46:23 2016 +0100" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Wed Aug 10 14:00:16 2016 +0100" }, "message": "Instruction: Add new formats 45cc and 4rcc.\n\nThese are new 4 byte formats with the following properties.\n\n- The first three (16 bit) words of these instructions have the same\n format as 35c and 3rc respectively.\n- The fourth 16 bit word encodes an additional constant index reference.\n\nThis change includes placeholder opcodes for invoke-polymorphic and\ninvoke-polymorphic/range which will be the first dex instructions that\nuse this new format. In addition to a method_idx that gives the invoked\nmethod, these instructions also provide a proto_idx which gives the\n(static) type signature of the call site.\n\nThe only reason these are included in this change is because we need\nan instruction with a given format to write a unit_test using the Instruction\nAPI.\n\nbug: 30550796\ntest: make test-art-host\n\nChange-Id: I02612ddee47169757175a8079d82f811f6545945\n" }, { "commit": "14832efeb92334c562ebedef34e920d30e3cee69", "tree": "57d10c24966a46ae1c01861ee579ac6000326c45", "parents": [ "c984725d0035e1925371757c38fed339b409e525" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Fri Aug 05 11:44:32 2016 +0100" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Aug 09 13:47:49 2016 +0100" }, "message": "Revert experimental lambda feature.\n\nThis is a revert of the following changes :\n\n30c475a2046951a81769c2db0b2dad66cd71e189.\nlambda: Minor capture-variable/liberate-variable clean-up after post-merge reviews.\n\n6918bf13eb855b3aa8ccdddda2d27ae8c60cec56.\nlambda: Experimental support for capture-variable and liberate-variable\n\nfc1ccd740b7c8e96dfac675cfc580122cd1b40a6.\nlambda: Infrastructure to support capture/liberate-variable dex opcodes\n\ne2facc5b18cd756a8b5500fb3d90da69c9ee0fb7.\nruntime: Add lambda box/unbox object equality\n\n2ee54e249ad21c74f29a161e248bebe7d22fddf1.\nruntime: Partially implement box-lambda and unbox-lambda experimental opcodes\n\n158f35c98e2ec0d40d2c032b8cdce5fb60944a7f.\ninterpreter: Add experimental lambda opcodes for invoke/create-lambda\n\na3bb72036f5454e410467f7151dc89f725ae1151.\nAdded format 25x to dexdump(2).\n\nPlus surrounding cleanups.\n\nTest: make test-art\nChange-Id: Ic6f999ad17385ef933f763641049cf721510b202\n" }, { "commit": "542451cc546779f5c67840e105c51205a1b0a8fd", "tree": "11e09bb5abaee12dddffefbe7e425291076dfa7a", "parents": [ "85c4a4b8c9eabfe16e4e49f9b4aa78c1bf4be023" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jul 26 09:02:02 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 01 18:54:48 2016 -0700" }, "message": "ART: Convert pointer size to enum\n\nMove away from size_t to dedicated enum (class).\n\nBug: 30373134\nBug: 30419309\nTest: m test-art-host\nChange-Id: Id453c330f1065012e7d4f9fc24ac477cc9bb9269\n" }, { "commit": "56fdd0e63812764bbeb8cc52e376d3fd1f270052", "tree": "6988e995bf02f788066fb6e748cd3049fe87d31a", "parents": [ "9d05b59a8595cf7eeece1795eb65b6b8706aad45" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Apr 28 14:56:54 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 29 17:33:22 2016 -0700" }, "message": "ART: Disambiguate access-checks mode from lock-counting\n\nLock-counting (when structural locking verification failed) is a\nspecial sub-mode of access-checks and must be disambiguated, because\nwe currently use access-checks mode class-wide when at least one\nmethod soft-fails, but do not stop the compiler/JIT to compile\nthe \"working\" methods. So we may end up in the access-checks\ninterpreter for a working method through deopt without knowing\nwhich locks are already held.\n\nBug: 28351535\n\n(cherry picked from commit f517e283d477dd2ae229ee3f054120c6953895db)\n\nChange-Id: I083032f064d88df8f8f0611ad8b57d1b39cd09fb\n" }, { "commit": "71cd50fb67fa48667b0ab59aa436a582c04ba43d", "tree": "9f99f187060b0ef3a118120db367555d8f757f0c", "parents": [ "9b863613454ee139370d24e65adb41fabe75d482" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Apr 14 15:00:33 2016 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Apr 15 15:42:31 2016 +0100" }, "message": "Add weight to compiled/interpreter transitions.\n\nAlso:\n- Cleanup logging.\n- Check ArtMethod status before adding compilation requests.\n- Don\u0027t request osr compilation if we know AddSamples does not come\n from a back edge.\n\nBug: 27865109\n\nChange-Id: I84512f7d957b61ce2458360ed430adb151830278\n" }, { "commit": "274fe4adcb0610a9920be7814d9beb9cac6417ce", "tree": "4a5c41dd2568869ceaf0a510e37065a606f512fb", "parents": [ "6990775e323cd9164d6cc10955a047b9d9f15f32" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Apr 12 16:33:24 2016 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Apr 13 17:34:53 2016 +0100" }, "message": "Remove the JIT from the instrumentation framework.\n\nThis was slowing down the interpreter for no reason.\nAlso, call AddSamples for invoke-static and invoke-direct.\n\nChange-Id: I7b5641097f7741dd32feb1ce6af739fd27fb37c2\n" }, { "commit": "1d011d9306fd4ff57d72411775d415a86f5ed398", "tree": "fadba83b9fb32840ff777948ace3bd8eb477e38f", "parents": [ "82a0229e949eb3ea209c2bd33fe2d60908f5dbc7" ], "author": { "name": "Bill Buzbee", "email": "buzbee@google.com", "time": "Mon Apr 04 16:59:29 2016 +0000" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Fri Apr 08 09:04:10 2016 -0700" }, "message": "Revert \"Revert \"Revert \"Revert \"ART: Improve JitProfile perf in arm/arm64 mterp\"\"\"\"\n\nBug: 28081559\n\nThis reverts commit 961ea9fe42edcc2c57469bf451d1ca421da5cd59.\n\nChange-Id: I98a5bb8112646706ae7bd73bf6393cb956466be3\n" }, { "commit": "93e94f228f7a9ec5c2a29553010e585d583ac530", "tree": "4f01e0f8bd8c4256b8a2f061f7d9502a8bb946ab", "parents": [ "f2197e43f42499be852a0fce2d755f25e2007be8" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Apr 07 13:52:48 2016 -0700" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Apr 07 15:27:01 2016 -0700" }, "message": "ART: Fix interpreter single-step when doing OSR\n\nRecords an interpreter exit when in single-step mode and we\u0027ve\nfinished processing the method via on-stack replacement.\n\nChange-Id: I7a7d9ee9e4f3fbf7f829d9f54eca0e7c64395003\n" }, { "commit": "961ea9fe42edcc2c57469bf451d1ca421da5cd59", "tree": "eb1930308f9f64a108e3f2387faca90cff869509", "parents": [ "6b7d2c09b4710503a72ff5de31bff5cb23a3a921" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Apr 01 12:02:58 2016 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Fri Apr 01 12:02:58 2016 -0700" }, "message": "Revert \"Revert \"Revert \"ART: Improve JitProfile perf in arm/arm64 mterp\"\"\"\n\nThis reverts commit 4a8ac9cee4312ac910fabf31c64d28d4c8362836.\n\n570-checker-osr intermittently failing.\n\nBug: 27939339\n" }, { "commit": "4a8ac9cee4312ac910fabf31c64d28d4c8362836", "tree": "a9d662cb43a3fe1c071618ef78f772655bfc4442", "parents": [ "ec898396658bc6a36e2b3c32569fbcb034d60e22" ], "author": { "name": "Bill Buzbee", "email": "buzbee@google.com", "time": "Fri Mar 25 13:16:55 2016 +0000" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Tue Mar 29 15:48:45 2016 -0700" }, "message": "Revert \"Revert \"ART: Improve JitProfile perf in arm/arm64 mterp\"\"\n\nReady for review.\n\nThis reverts commit 6aef867f4d1a98a12bcdd65e9bf2ff894f0f2d7e.\n\nChange-Id: I5d53ed2bedc7e429ce7d3cdf80b6696a9628740e\n" }, { "commit": "6aef867f4d1a98a12bcdd65e9bf2ff894f0f2d7e", "tree": "cda140806a091805213edca2708e69337f6869ef", "parents": [ "1cb8689ccc23fd513c5472911dd07e44b55e9c8d" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Fri Mar 25 11:27:48 2016 +0000" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Fri Mar 25 11:27:48 2016 +0000" }, "message": "Revert \"ART: Improve JitProfile perf in arm/arm64 mterp\"\n\nThis reverts commit c1d6b341eed646e5adafc6c4fd4e3748f0292368.\n" }, { "commit": "c1d6b341eed646e5adafc6c4fd4e3748f0292368", "tree": "ddee928954b03a919ce601f12876f1fe161d577a", "parents": [ "eecf60d51b481647c8508f22b3d6ce437773ea0c" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Tue Mar 01 15:03:16 2016 -0800" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Wed Mar 23 11:11:26 2016 -0700" }, "message": "ART: Improve JitProfile perf in arm/arm64 mterp\n\nART currently requires two profiling-related things from the\ninterpreters: hotness updates and OSR switch checks. The hotness\nupdates previously used the existing instrumentation framework - which\nis flexible, but quite heavyweight. For most things, the\ninstrumentation framework overhead is acceptable, but because we do a\nhotness update on every backwards branch the overhead is unacceptable.\nPrior to this CL, branch profiling dominates interpreter cost.\n\nHere, we bypass the instrumentation framework for hotness updates\nand deliver a significant performance improvement. Running\ninterpreter-only (dalvikvm -Xint) on a Nexus 6, we see the logic\nsubtest of Caffeinemark improving from 2600 to 9200, and the\noverall score going from 1979 to over 3000. Compared to the\nC++ switch interpreter, we see a 6x improvement on the branchy logic\nsubtest and a 2.6x improvement overall.\n\nCompared with the previous mterp which did not have support for\njit profiling, we see a few (1% to 5%) performance loss on the\nstandard command-line benchmarks. I consider this acceptable\n(we could create an alternate non-profiling mterp which would\nhave no penalty, but I don\u0027t consider this overhead big enough to\njustify that).\n\nChange-Id: I50b5b8c5ed8ebda3c8b4e65d27ba7393c3feae04\n" }, { "commit": "f1dcaccfac4a9e022ea49752a774552b2f791489", "tree": "2e11cbb0bead0b24dd527f307a58a0588e707901", "parents": [ "db11e7ecc9c902ffde6336c261fe236299a81944" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Wed Feb 24 14:24:24 2016 -0800" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Feb 25 05:47:09 2016 -0800" }, "message": "ART: Profile all branches for on-stack replacement\n\nChange the switch, goto and mterp interpreters to profile\nnot-taken as well as taken branches. This allows for on-stack\nreplacement when the cfg has been rearranged such that the loop\nheader was originally the fallthrough of a Dalvik byte-code branch.\n\nNote that this increases the already-heavy cost of branch profiling.\nMeasuring on a Nexus 6 using a very branchy benchmark (logic subtest\nfrom Caffeinemark), we see:\n\n No profiling Taken only Taken \u0026 not-taken\nmterp 9728 3434 2384\nC++ goto 3914 2422 2037\nC++ switch 2986 2411 2112\n\nAs measured, the cost of branch profiling is dominating execution\ntime. This will be addressed in follow-up CLs.\n\nChange-Id: Ibc858f317398dd991ed8e4f3c3d72bd4c9a60594\n" }, { "commit": "b331febbab8e916680faba722cc84b66b84218a3", "tree": "35f985b021e476914bfe91492da23fee218014a7", "parents": [ "586996afc905518ed926e4680aab67bedabec9b7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 16:51:53 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 17:11:54 2016 +0000" }, "message": "Revert \"Revert \"Implement on-stack replacement for arm/arm64/x86/x86_64.\"\"\n\nThis reverts commit bd89a5c556324062b7d841843b039392e84cfaf4.\n\nChange-Id: I08d190431520baa7fcec8fbdb444519f25ac8d44\n" }, { "commit": "d6b48dbe715fbf1431394d2b6ef75cb19a4012dd", "tree": "f736903d0504a0198dca09cfb27913b6d806da22", "parents": [ "1d81df8ff1e5bc820d021fa02c552f2b53182b36" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Jan 28 15:48:55 2016 -0800" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Jan 28 16:11:04 2016 -0800" }, "message": "ART: Fix single-step interpretation for mterp\n\nFor bring-up (and failover) purposes, mterp can bail out to the\nswitch interpreter to handle a single opcode. This CL fixes the\nhandoff of the result register (a bug that was masked by an earlier\nrevision which passed it around by reference, rather than by value.\n\nChange-Id: Iba9e1576f52b3660348c89466438bdc0526227d0\n" }, { "commit": "734f3aa9f758236b6f1ace6347895af90b0d813d", "tree": "5982ad1d7df2062e0bd5deb023b39997a3a66a98", "parents": [ "de31ca62015e94016155a99a268ea798ab1ef75c" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Jan 28 14:20:06 2016 -0800" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Thu Jan 28 15:58:45 2016 -0800" }, "message": "Fix \"Never Interpret\" option for all interpreters\n\nCL 196596 added support for an option to bypass interpretation.\nHowever, it only covers 2 our of 3 interpreters (missing mterp).\nThis change moves the control up a level to the common interpreter\nentry where it will take effect before we select which interpreter\nto use.\n\nAlso, it corrects a somewhat academic bug in that the existing\ncode that assumes that (dex_pc \u003d\u003d 0) means that we just entered a\nmethod. If a method\u0027s dex code internally branched to address 0,\nwe could issue bogus method entry events. By moving this test up\na level, we should avoid this situation. Note, though, that dx\nwould never generate this pattern, and it\u0027s hard to imagine even\nhand-generated dex code that would trigger a deoptimization in this\nsituation.\n\nChange-Id: I6684bbf63570e02f5b01ce423c656889a890de7d\n" }, { "commit": "05d241565f36df825cf56a4f1b61bfb7e4dcb056", "tree": "4b74483b1c26640c6ca150fbf4d070c7a3a518f0", "parents": [ "f032f3afe513093c508434b17ff1921a114c4424" ], "author": { "name": "Siva Chandra", "email": "sivachandra@google.com", "time": "Tue Jan 05 17:43:17 2016 -0800" }, "committer": { "name": "Tamas Berghammer", "email": "tberghammer@google.com", "time": "Wed Jan 27 15:09:41 2016 +0000" }, "message": "Add option to never interpret.\n\nChange-Id: Ib6d6170fa60c77c2e6a8844964f14fa0de4c9e7b\n" }, { "commit": "81f0f953c4bb159997046c962d44cb1898b1778d", "tree": "dffd9e7cdd53da2771770a59832e76769b696c0b", "parents": [ "a27d59b2b98a02b2e9e5dbe40623e7a97aa1e8d8" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jan 20 16:25:19 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 21 14:19:55 2016 +0000" }, "message": "Move backward branch instrumentation to all branch.\n\nThis is in preparation for osr, and later dead branch profiling.\n\nChange-Id: I4597c0784c894c310f295dd534967d67dcefa419\n" }, { "commit": "1452bee8f06b9f76a333ddf4760e4beaa82f8099", "tree": "8ffb80498cd8fdff66a4ab272723cf4d4e69e57b", "parents": [ "7f9ea1451bb74055ee5d51ae04fc869faa06cbdd" ], "author": { "name": "buzbee", "email": "buzbee@google.com", "time": "Fri Mar 06 14:43:04 2015 -0800" }, "committer": { "name": "buzbee", "email": "buzbee@google.com", "time": "Mon Jan 11 13:04:49 2016 -0800" }, "message": "Fast Art interpreter\n\nAdd a Dalvik-style fast interpreter to Art.\nThree primary deficiencies in the existing Art interpreter\nwill be addressed:\n\n1. Structural inefficiencies (primarily the bloated\n fetch/decode/execute overhead of the C++ interpreter\n implementation).\n2. Stack memory wastage. Each managed-language invoke\n adds a full copy of the interpreter\u0027s compiler-generated\n locals on the shared stack. We\u0027re at the mercy of\n the compiler now in how much memory is wasted here. An\n assembly based interpreter can manage memory usage more\n effectively.\n3. Shadow frame model, which not only spends twice the memory\n to store the Dalvik virtual registers, but causes vreg stores\n to happen twice.\n\nThis CL mostly deals with #1 (but does provide some stack memory\nsavings). Subsequent CLs will address the other issues.\n\nCurrent status:\n Passes all run-tests.\n Phone boots interpret-only.\n 2.5x faster than Clang-compiled Art goto interpreter on fetch/decode/execute\n microbenchmark, 5x faster than gcc-compiled goto interpreter.\n 1.6x faster than Clang goto on Caffeinemark overall\n 2.0x faster than Clang switch on Caffeinemark overall\n 68% of Dalvik interpreter performance on Caffeinemark (still much slower,\n primarily because of poor invoke performance and lack of execute-inline)\n Still nearly an order of magnitude slower than Dalvik on invokes\n (but slightly better than Art Clang goto interpreter.\n Importantly, saves ~200 bytes of stack memory per invoke (but still\n wastes ~400 relative to Dalvik).\n\nWhat\u0027s needed:\n Remove the (large quantity of) bring-up hackery in place.\n Integrate into the build mechanism. I\u0027m still using the old Dalvik manual\n build step to generate assembly code from the stub files.\n Remove the suspend check hack. For bring-up purposes, I\u0027m using an explicit\n suspend check (like the other Art interpreters). However, we should be\n doing a Dalvik style suspend check via the table base switch mechanism.\n This should be done during the alternative interpreter activation.\n General cleanup.\n Add CFI info.\n Update the new target bring-up README documentation.\n Add other targets.\n\nIn later CLs:\n Consolidate mterp handlers for expensive operations (such as new-instance) with\n the code used by the switch interpreter. No need to duplicate the code for\n heavyweight operations (but will need some refactoring to align).\n Tuning - some fast paths needs to be moved down to the assembly handlers,\n rather than being dealt with in the out-of-line code.\n JIT profiling. Currently, the fast interpreter is used only in the fast\n case - no instrumentation, no transactions and no access checks. We\n will want to implement fast + JIT-profiling as the alternate fast\n interpreter. All other cases can still fall back to the reference\n interpreter.\n Improve invoke performance. We\u0027re nearly an order of magnitude slower than\n Dalvik here. Some of that is unavoidable, but I suspect we can do\n better.\n Add support for our other targets.\n\nChange-Id: I43e25dc3d786fb87245705ac74a87274ad34fedc\n" }, { "commit": "3108daf19ab1e8e9a5ebf980df1db84cef54770b", "tree": "14c4a80c5426819c50275d91ce3f889e93721b87", "parents": [ "95f7bbcd991fbfaead438a2866354714eb32af38" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 16:32:33 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 16:32:33 2015 +0000" }, "message": "Add backward branch instumentation to the switch interpreter.\n\nChange-Id: I0328daa86d5f19311ab3bd6246a1c3e4b40b0ba9\n" }, { "commit": "3a0909248e04b22c3981cbf617bc2502ed5b6380", "tree": "b0b7013ea78b10f23fae75ef145e53a696ff797c", "parents": [ "457e874459ae638145cab6d572e34d48480e39d2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 24 09:17:30 2015 +0000" }, "message": "Revert \"lambda: Add support for invoke-interface for boxed innate lambdas\"\n\n955-lambda is flaky\n\nBug: 24618608\nBug: 25107649\n\nThis reverts commit 457e874459ae638145cab6d572e34d48480e39d2.\n\nChange-Id: I24884344d21d7a4262e53e3f5dba57032687ddb7\n" }, { "commit": "457e874459ae638145cab6d572e34d48480e39d2", "tree": "b192c4698c4889ae90db6abe2652199802213fe6", "parents": [ "3944f7175dcf60316ba58a42698ccf23c65ac57c" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Oct 22 17:37:50 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Nov 20 16:33:06 2015 -0800" }, "message": "lambda: Add support for invoke-interface for boxed innate lambdas\n\nLambda closures created with the \u0027create-lambda\u0027 instruction\n(termed \"innate lambdas\") can be turned into an object with \u0027box-lambda\u0027.\n\nThis CL enables support for those kinds of lambdas to work with\n\u0027invoke-interface\u0027 by generating a proxy class for the lambda.\n\nNote: MIPS32/64 support not included.\n\nBug: 24618608\nBug: 25107649\nChange-Id: Ic8f1bb66ebeaed4097e758a50becf1cff6ccaefb\n" }, { "commit": "eb7c144a6aff7da673ba53d501c46f00311d4d7f", "tree": "feec33dd2e711800305477b092970500991a3993", "parents": [ "98ae42010a6e6a0e4c5bcc4d6a357805eef3f4ff" ], "author": { "name": "Alex Light", "email": "allight@google.com", "time": "Mon Aug 31 13:17:42 2015 -0700" }, "committer": { "name": "Alex Light", "email": "allight@google.com", "time": "Tue Oct 13 13:09:37 2015 -0700" }, "message": "Add initial default method support to Art\n\nThis commit starts the process of adding default methods and their\nassociated pieces to ART.\n\nThis adds full support for calling default methods using\ninvoke-interface and invoke-virtual on objects implementing the\ninterfaces. Verifier is changed to allow this when the runtime is\nstarted with -Xexperimental:default-methods.\n\nThis also adds support for defining and calling static methods on\ninterface classes with invoke-static.\n\nDirectly calling overridden default methods using invoke-super is not\nyet supported.\n\nThis adds 5 new run-tests for this functionality.\n\nBug: 24618811\n\nChange-Id: I35ca800d99d3329348b277789b70ceeeba6e7f03\n" }, { "commit": "03ec930faded5bbfa096533ce60b6893847922db", "tree": "085ec76235f72647cd2e083801f15d82394e038b", "parents": [ "14412079e6eba4d16f40c0bdc5e94812e1c7f5bc" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Aug 27 17:41:47 2015 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Oct 09 16:32:13 2015 -0700" }, "message": "ART: Lock counting in the interpreter\n\nTo support structured locking when balanced-locking verification\nfailed, count lock and unlock operations in the verifier.\n\nBug: 23502994\nChange-Id: I2bb915da6e3d43c49723a943b42d4d5a7c939aa1\n" }, { "commit": "6918bf13eb855b3aa8ccdddda2d27ae8c60cec56", "tree": "907f504a4d004ac1e44b73c3984e365e889407e8", "parents": [ "446ca43e8f876dcc1ee90fcf432d6392c44a3f60" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Sun Sep 27 19:19:06 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Sun Sep 27 19:19:23 2015 -0700" }, "message": "Revert \"Revert \"lambda: Experimental support for capture-variable and liberate-variable\"\"\n\nThis reverts commit 7bbb80ab52c203e44d2ded2c947b3b03b4b31ec4.\n\nChange-Id: If806ce5c6c5e96fdb2c3761dee096f74e7e5b001\n" }, { "commit": "7bbb80ab52c203e44d2ded2c947b3b03b4b31ec4", "tree": "eb54c557467f1401c4bd5729fa2b9e8ae91e8ffd", "parents": [ "b72123440d8541362ebdb131436f9dbdda5fd329" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Sep 27 19:50:40 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Sun Sep 27 19:50:40 2015 +0000" }, "message": "Revert \"lambda: Experimental support for capture-variable and liberate-variable\"\n\nTest fails.\n\nThis reverts commit b72123440d8541362ebdb131436f9dbdda5fd329.\n\nChange-Id: Ic9ed92f8c826d8465eb36b746dc44af05caf041c\n" }, { "commit": "b72123440d8541362ebdb131436f9dbdda5fd329", "tree": "41e3d21496a270edc06879f084a504a39af9469b", "parents": [ "9f3b8d38de615efef6d2536817f19ad2ccaa313a" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Sep 25 14:22:08 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Sep 25 15:53:00 2015 -0700" }, "message": "lambda: Experimental support for capture-variable and liberate-variable\n\nSupports capturing/liberating any primitive variables.\nNo support for capturing objects/lambdas yet since they would both\nneed GC changes to track roots through closures.\n\nChange-Id: Ibfb68bfe4c579dbf93823aac4c0e6ac8f6360c5d\n" }, { "commit": "05792b98980741111b4d0a24d68cff2a8e070a3a", "tree": "bad79a387bcbdaefc87c07b388099960ca9caff3", "parents": [ "c26b4512a01d46756683a4f5e186a0b7f397f251" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Aug 03 11:56:49 2015 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Sep 03 17:30:57 2015 +0100" }, "message": "ART: Move DexCache arrays to native.\n\nThis CL has a companion CL in libcore/\n https://android-review.googlesource.com/162985\n\nChange-Id: Icbc9e20ad1b565e603195b12714762bb446515fa\n" }, { "commit": "90443477f9a0061581c420775ce3b7eeae7468bc", "tree": "8c74b81dfae162e0fd0ccf8d5ac50827ba815174", "parents": [ "6078aec213dfaf111c29969706e8e5967cfc9bea" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jul 16 20:32:27 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Jul 22 15:13:56 2015 -0700" }, "message": "Move to newer clang annotations\n\nAlso enable -Wthread-safety-negative.\n\nChanges:\nSwitch to capabilities and negative capabilities.\n\nFuture work:\nUse capabilities to implement uninterruptible annotations to work\nwith AssertNoThreadSuspension.\n\nBug: 20072211\n\nChange-Id: I42fcbe0300d98a831c89d1eff3ecd5a7e99ebf33\n" }, { "commit": "2ee54e249ad21c74f29a161e248bebe7d22fddf1", "tree": "125465dd7a6d23f83ecbf2d3454f21471868422c", "parents": [ "158f35c98e2ec0d40d2c032b8cdce5fb60944a7f" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Jun 18 10:05:11 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Mon Jun 22 14:13:30 2015 -0700" }, "message": "runtime: Partially implement box-lambda and unbox-lambda experimental opcodes\n\nThese opcodes are not yet fully specified, and *will* change before they become shippable.\nDo not write production code against experimental opcodes.\n\n--\n\nImplement partial interpreter support for new dex instructions box/unbox-lambda.\n* box-lambda will take a closure and convert it into an Object\n* unbox-lambda will take an Object and convert it to a closure\n\n(Currently does not implement object identity or variable capture).\n\nAll new opcodes are disabled by default, use runtime option -Xexperimental-lambdas to enable them.\n\nChange-Id: I3c15ccf8a26ccecd1d35808a8c1b4149220f6019\n" }, { "commit": "158f35c98e2ec0d40d2c032b8cdce5fb60944a7f", "tree": "63bb3bbed85b0add42c7fdc714cd611424d8af2e", "parents": [ "c449e8b79aaaf156ce055524c41474cc1200ed5a" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Jun 10 15:55:30 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Jun 18 10:22:27 2015 -0700" }, "message": "interpreter: Add experimental lambda opcodes for invoke/create-lambda\n\nThese opcodes are not yet fully specified, and *will* change before they become shippable.\nDo not write production code against experimental opcodes.\n\n--\n\nImplement partial interpreter support for new dex instructions invoke/create-lambda, and a\nnew opcode format 25x.\n\n* Does not verify, in fact verification will soft fail when we see those opcodes.\n* Compilers will punt to interpreter since they don\u0027t support new opcodes.\n* As there is no way to capture/liberate variables yet, the \"closure\" is just\n an ArtMethod for the time being.\n\nAll new opcodes are disabled by default, use runtime option -Xexperimental-lambdas to enable them.\n\nFor example:\n dalvikvm ... -Xexperimental-lambdas ...\n dex2oat --runtime-arg -Xexperimental-lambdas ...\n\nChange-Id: I6c996ca32a9b54ec45ec21d7a959b84dfb8a24eb\n" }, { "commit": "c449e8b79aaaf156ce055524c41474cc1200ed5a", "tree": "8e36a6ce3a1172891760e8dbc12cd73916c7264c", "parents": [ "26b97f87dcd86934f8b75e018c80bb4e8d501b03" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Jun 10 15:56:42 2015 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Thu Jun 11 11:13:30 2015 -0700" }, "message": "runtime: Minor cleanup and extra comments around interpreter\n\nChange-Id: I24c0b261de8cf737babd9d01bf679482d48c8bc9\n" }, { "commit": "e401d146407d61eeb99f8d6176b2ac13c4df1e33", "tree": "17927f9bfe7d2041b5942c89832d55f9dedb24c5", "parents": [ "2006b7b9b8e32722bd0d640c62549d8a0ac624b6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 13:56:20 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 29 18:45:49 2015 -0700" }, "message": "Move mirror::ArtMethod to native\n\nOptimizing + quick tests are passing, devices boot.\n\nTODO: Test and fix bugs in mips64.\n\nSaves 16 bytes per most ArtMethod, 7.5MB reduction in system PSS.\nSome of the savings are from removal of virtual methods and direct\nmethods object arrays.\n\nBug: 19264997\nChange-Id: I622469a0cfa0e7082a2119f3d6a9491eb61e3f3d\n" }, { "commit": "9d6bf69ad3012a9d843268fdd5325b6719b6d5f2", "tree": "a41fc22d2c89e41c86feb5ef07ebda89b1b83d90", "parents": [ "b6829c2ee05124d64a19c7a52ada4a23f624fb91" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 10 12:12:33 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Apr 29 16:59:58 2015 +0200" }, "message": "JDWP: properly combine location events\n\nThis CL properly groups JDWP events at the same location: Breakpoint,\nSingle-step, Method Entry and Method Exit. This is necessary if the\ndebugger is not the only instrumentation listener. This matches the\nbehavior of Dalvik, especially for methods with a single return\ninstruction.\n\nThe interpreter was tuned so the instrumentation callbacks were\ncalled to satisfy the debugger with the idea the debugger was the\nonly instrumentation listener. This is not true when method tracing\nis enabled at the same time.\nWhen tracing is enabled, there is always a listener for MethodEntry\nand MethodExit events (art::Trace class). However, if the debugger\nis only listening to DexPcMoved event (to manage JDWP Breakpoint\nevent), it will not be notified of this event.\n\nWe now properly call all the instrumentation callbacks in the\ninterpreter and move the logic specific to debugging into the class\nDebugInstrumentationListener. This allows to properly group JDWP\nlocation events together depending on the sequence of instrumentation\ncallbacks.\n\nWe add Thread::tls_32bit_sized_values::debug_method_entry_ flag to\nremember we just entered a method. It replaces the local variable\nnotified_method_entry_event in the interpreter and simplifies the\ncode.\n\nBump oat version to force recompilation because the layout of the\nThread class is modified.\n\nBug: 19829329\nChange-Id: I204af9112e37d2eebc86661fb7c961a41c74e598\n" }, { "commit": "848f70a3d73833fc1bf3032a9ff6812e429661d9", "tree": "b0349b3a40aab5a915af491b100659a5ca9fbbf6", "parents": [ "d14438f0c5071962be7fab572b54687d32d9d087" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Wed Jan 15 13:49:50 2014 -0800" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Mon Apr 27 18:54:52 2015 -0700" }, "message": "Replace String CharArray with internal uint16_t array.\n\nSummary of high level changes:\n - Adds compiler inliner support to identify string init methods\n - Adds compiler support (quick \u0026 optimizing) with new invoke code path\n that calls method off the thread pointer\n - Adds thread entrypoints for all string init methods\n - Adds map to verifier to log when receiver of string init has been\n copied to other registers. used by compiler and interpreter\n\nChange-Id: I797b992a8feb566f9ad73060011ab6f51eb7ce01\n" }, { "commit": "2cebb24bfc3247d3e9be138a3350106737455918", "tree": "d04d27d21b3c7733d784e303f01f873bb99e7770", "parents": [ "1f02f1a7b3073b8fef07770a67fbf94afad317f0" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 21 16:50:40 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 22 12:44:27 2015 -0700" }, "message": "Replace NULL with nullptr\n\nAlso fixed some lines that were too long, and a few other minor\ndetails.\n\nChange-Id: I6efba5fb6e03eb5d0a300fddb2a75bf8e2f175cb\n" }, { "commit": "45b1597c152af90f6d5792d02b64fd4e7c81ac9d", "tree": "3cbb498c91067657169e4ee2aaba9cbf286e3788", "parents": [ "d43f160dc294655885a2c273307d34585c4ce97b" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 03 16:07:05 2015 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Apr 03 16:27:19 2015 +0200" }, "message": "Use va_list argument to abort transaction\n\nCreates AbortTransactionV taking a va_list argument and renames\nAbortTransaction to AbortTransactionF which calls AbortTransactionV.\n\nThis fixes the compiler_driver_test under valgrind.\n\nChange-Id: Ia1c57330091c055ae9e46585a944ce0b78864920\n" }, { "commit": "d7cbf8a6629942e7bd315ffae7e1c77b082f3e11", "tree": "fc8c3371ed4ddac96bbe90a2f94ef5fb5c5472ee", "parents": [ "f5988cf0c47ff935bb19c89ed0398be5fbe44bb6" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 19 12:43:20 2015 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 19 20:00:50 2015 -0700" }, "message": "Change RETURN_VOID_BARRIER to RETURN_VOID_NO_BARRIER\n\nWe want to default to having a barrier for the case where we don\u0027t\ndex to dex.\n\nBug: 19762303\nChange-Id: I60348d89eaf0b9e1e480298afcecbb5f52e8661b\n" }, { "commit": "0aa50ce2fb75bfc2e815a0c33adf9b049561923b", "tree": "9a3f9603ab30d5cbc7fc21aee0ceb48bbb0dd25a", "parents": [ "e8e42f3548fd894f860912bb1b71ce6fa2d7daf3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 10 11:03:29 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Mar 10 14:51:11 2015 +0000" }, "message": "Remove ThrowLocation.\n\nNote that this is a cleanup change, and has no functionality change.\nThe ThrowLocation had no use anymore.\n\nChange-Id: I3d2126af1dc673cec3a0453ff3d56a172663a5f6\n" }, { "commit": "14691c5e786e8c2c5734f687e4c96217340771be", "tree": "7c2156671b323c70ffdd1d48d5e2f1d1de79c5fc", "parents": [ "3d7d2af4c6502b771b032ee9bf3ab30e78f9c60d" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Mar 05 10:40:17 2015 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Mar 09 10:09:33 2015 +0000" }, "message": "Compute the right catch location for the debugger.\n\nAlso remove tls ThrowLocation, it is not needed anymore.\n\nChange-Id: I78fddf09ce968ca475e39c17fa76d699c589c8d9\n" }, { "commit": "270a0e16c3b8e5b95cbfdbd8996ac137c7c6322b", "tree": "2800649d19ffcdc891118a458f6b0169022d93e0", "parents": [ "951d70b42400453f9d1746d155b8337c07c86acc" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Jan 16 19:49:09 2015 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri Jan 23 17:26:45 2015 +0100" }, "message": "Fix exception handling during deoptimization\n\nWhen interpreting a deoptimized shadow frame, we may start with a\npending exception thrown by a previous deoptimized shadow frame (from\na previous invoke). Therefore, we need to handle it before executing\nany instruction, otherwise we execute incorrect code.\n\nBecause we need the DEX pc of the throwing instruction to find a\nmatching catch handler, we initialize deoptimized shadow frames with\nthe current DEX pc at the time the stack is deoptimized.\nWhen we are about to interpret a deoptimized shadow frame, we need to\nupdate the shadow frame with the DEX pc of the next instruction to\ninterpret. There are three cases:\n- if there is no pending exception, this is the instruction following\nthe current one.\n- if there is a pending exception and we found a matching catch\nhandler, this is the first instruction of this handler.\n- if there is a pending exception but there is no matching catch\nhandler, we do not execute the deoptimized shadow frame and continue\nto its caller.\n\nThe verifier now fails when a method starts with a move-exception\ninstruction. Indeed we cannot start executing a method with a pending\nexception.\n\nBug: 19057915\nBug: 19041195\nBug: 18607595\nChange-Id: I355ac81e6ac098edc7e3cc8c13dbfa24a2969ab2\n" }, { "commit": "1cc7dbabd03e0a6c09d68161417a21bd6f9df371", "tree": "8557bdff971e366909351af95a7c8ead82792986", "parents": [ "5e0a9849d4e353c3726095b65ab07cefce40a636" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Dec 17 18:43:01 2014 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Dec 29 10:52:02 2014 -0800" }, "message": "ART: Reorder entrypoint argument order\n\nShuffle the ArtMethod* referrer backwards for easier removal.\n\nClean up ARM \u0026 MIPS assembly code.\n\nChange some macros to make future changes easier.\n\nChange-Id: Ie2862b68bd6e519438e83eecd9e1611df51d7945\n" }, { "commit": "ffc605cd817e79d6c7602a87543bb31f24d3a99f", "tree": "84e4e68b11fe2d9c8c2e901b858026c1ebe88973", "parents": [ "b1a38e246cfbfb21100d9c9e57f33970e824f075" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 10 10:35:44 2014 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Dec 10 11:45:44 2014 -0800" }, "message": "Add missing iget quick for bool, byte, char, short\n\nBug: 17791557\nBug: 17671806\nChange-Id: Ifac4fbfba6c3a3f97131e85914b24756fb7f9722\n" }, { "commit": "e94652f1e321b2c8b71acbe5b07d2ebf69fbdb99", "tree": "b4c2a4435800222fa740a5ae57fa217b6aed0875", "parents": [ "f25c2ec6b63e116f24f359a10b59c78768fde67a" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Dec 02 11:13:19 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Dec 02 11:13:49 2014 -0800" }, "message": "Remove MethodHelper from the interpreter.\n\nUse ShadowFrame to get the executing method to avoid a handle for the current\nmethod.\nVarious associated bits of header file clean-up and removal of an unnecessary\nuse of MethodHelper in CompilerDriver.\n\nChange-Id: I3b6f4413701e8fc6b0c58b0041a0dd15472bedaa\n" }, { "commit": "f72a11dd4b0dd86bc4b1baa37bfa47fc8d5572b5", "tree": "bf2f2842a7bbe44057bc1e8c0e176b51baa173ac", "parents": [ "2a4e71ca268f8a5b3d8424116a7a8650265d8774" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 30 15:41:08 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Oct 30 16:17:21 2014 -0700" }, "message": "Add math routines with defined wrapping behavior for the interpreter.\n\nAdd a RSUB_INT_LIT16 instruction alias to make instruction opcode switch\nstatements easier to read.\n\nChange-Id: I3bac07c9518665abf0b05b5c3105a90be22f780a\n" }, { "commit": "ded66a01f81812e0129d17c3d08d5eda18433062", "tree": "74a3f7bad1c020b0136d6c173633a361a479f5cb", "parents": [ "e0205d519dd417f749243b42b8711dfa313e5390" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 28 18:12:55 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 28 18:36:32 2014 -0700" }, "message": "Move MethodHelper::GetReturnType to mirror::ArtMethod.\n\nAlso, fix missing handle in HasSameSignatureWithDifferentClassLoaders.\n\nChange-Id: I9e1ffd09be950ecc8346fc3c485760d82d9ecab3\n" }, { "commit": "6786a58659420c0631a1ebe1f2fde434b8bcd1e4", "tree": "e16ea4abe8dc115955a63828d682e5910e277c5e", "parents": [ "e1e084034ed1dd0e3928f0d10dc0cebf80171c07" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 28 12:49:06 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Oct 28 12:49:06 2014 -0700" }, "message": "Remove ResolveString from MethodHelper.\n\nChange-Id: Ice0fff0680f876285539f78cd79d520d424e2f5e\n" }, { "commit": "647b1a86f518d8db0331b3d52a96392b7a62504b", "tree": "7370f795ef3c7fbdd2695d23bc6f8171f40f43f1", "parents": [ "acfbbd4df2fc1c79a7102587bebf398f95b5e5de" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 10 11:02:11 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Oct 10 12:26:02 2014 -0700" }, "message": "Fix 2 new sets of clang compiler warnings.\n\nFix issues that are flagged by -Wfloat-equal and -Wmissing-noreturn.\nIn the case of -Wfloat-equal the current cases in regular code are deliberate,\nso the change is to silence the warning. For gtest code the appropriate fix is\nto switch from EXPECT_EQ to EXPECT_(FLOAT|DOUBLE)_EQ.\nThe -Wmissing-noreturn warning isn\u0027t enabled due to a missing noreturn in\ngtest. This issue has been reported to gtest.\n\nChange-Id: Id84c70c21c542716c9ee0c41492e8ff8788c4ef8\n" }, { "commit": "832336b3c9eb892045a8de1bb12c9361112ca3c5", "tree": "0e8696869a28ee0dee34d130b586b1bf6f072d6e", "parents": [ "f1f05d303988a5c071c87b760056be8358276c94" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 08 15:35:22 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Oct 08 16:00:31 2014 -0700" }, "message": "Don\u0027t copy fill array data to quick literal pool.\n\nCurrently quick copies the fill array data from the dex file to the literal\npool. It then has to go through hoops to pass this PC relative address down\nto out-of-line code. Instead, pass the offset of the table to the out-of-line\ncode and use the CodeItem data associated with the ArtMethod. This reduces\nthe size of oat code while greatly simplifying it.\nUnify the FillArrayData implementation in quick, portable and the interpreters.\n\nChange-Id: I9c6971cf46285fbf197856627368c0185fdc98ca\n" }, { "commit": "7b078e8c04f3e1451dbdd18543c8b9692b5b067e", "tree": "414229c6b87eb20ea24c40780752da5a3999a49a", "parents": [ "f79ba17defbd9342e44ab9f3de0807054673d3c9" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Wed Sep 10 14:44:24 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 12 14:57:53 2014 -0700" }, "message": "Compile time performance improvements focusing on interpret-only.\n\nReduce virtual method dispatch in the method verifier and make more code\ninline-able.\nAdd a StringPiece with const char* equality operator to avoid redundant\nStringPieces and strlens.\nRemove back link from register line to verifier and pass as argument to reduce\nsize of RegisterLine.\nRemove instruction length from instruction flags and compute from the\ninstruction, again to reduce size.\nAdd suspend checks to resolve and verify to allow for more easy monitor\ninflation and reduce contention on Locks::thread_list_suspend_thread_lock_.\nChange ThrowEarlierClassFailure to throw pre-allocated exception.\nAvoid calls to Thread::Current() by passing self.\nTemplate specialize IsValidClassName.\nMake ANR reporting with SIGQUIT run using checkpoints rather than suspending\nall threads. This makes the stack/lock analysis less lock error prone.\nExtra Barrier assertions and condition variable time out is now returned as a\nboolean both from Barrier and ConditionVariable::Wait.\n\n2 threaded host x86-64 interpret-only numbers from 341 samples:\nBefore change: Avg 176.137ms 99% CI 3.468ms to 1060.770ms\nAfter change: Avg 139.163% 99% CI 3.027ms to 838.257ms\nReduction in average compile time after change is 20.9%.\nSlow-down without change is 26.5%.\n\nBug: 17471626 - Fix bug where RegTypeCache::JavaLangObject/String/Class/Throwable\ncould return unresolved type when class loading is disabled.\nBug: 17398101\n\nChange-Id: Id59ce3cc520701c6ecf612f7152498107bc40684\n" }, { "commit": "37f05ef45e0393de812d51261dc293240c17294d", "tree": "7c7793862efa52e1deb42babbdcb652c245ab941", "parents": [ "e25826e28ea65d9c1aa23f84788a091c677b20c7" ], "author": { "name": "Fred Shih", "email": "ffred@google.com", "time": "Wed Jul 16 18:38:08 2014 -0700" }, "committer": { "name": "Fred Shih", "email": "ffred@google.com", "time": "Mon Aug 25 11:16:53 2014 -0700" }, "message": "Reduced memory usage of primitive fields smaller than 4-bytes\n\nReduced memory used by byte and boolean fields from 4 bytes down to a\nsingle byte and shorts and chars down to two bytes. Fields are now\narranged as Reference followed by decreasing component sizes, with\nfields shuffled forward as needed.\n\nBug: 8135266\nChange-Id: I65eaf31ed27e5bd5ba0c7d4606454b720b074752\n" }, { "commit": "1ff3c98775a4577cf053dba9a0c2d5c21c07b298", "tree": "2d09c27c69678b53b4c9dc486024f3547efd4bca", "parents": [ "99c251bbd225dd97d0deece29559a430b12a0b66" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 12 02:30:58 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Aug 12 16:08:05 2014 -0700" }, "message": "Avoid use of std::string where we have const char*.\n\nRemoving the ClassHelper caused std::string creation for all calls to\nClass::GetDescriptor and a significant performance regression. Make the\nstd::string an out argument so the caller can maintain it and its life time\nwhile allowing GetDescriptor to return the common const char* case.\n\nDon\u0027t generate GC maps when compilation is disabled.\n\nRemove other uses of std::string that are occuring on critical paths.\nUse the cheaper SkipClass in CompileMethod in CompilerDriver.\nSpecialize the utf8 as utf16 comparison code for the common shorter byte\nencoding.\nForce a bit of inlining, remove some UNLIKELYs (they are prone to pessimizing\ncode), add some LIKELYs.\n\nx86-64 host 1-thread interpret-only of 57 apks:\nBefore: 29.539s\nAfter: 23.467s\n\nRegular compile:\nBefore: 1m35.347s\nAfter: 1m20.056s\n\nBug: 16853450\nChange-Id: Ic705ea24784bee24ab80084d06174cbf87d557ad\n" }, { "commit": "4e99b3d8955131f3fc71aa113f0fa71f0092cb6f", "tree": "bcaf4e5119a74c836d8598e064a20cdead757efb", "parents": [ "5fa647d5f663033e4ed3d398aece1f8211d7f460" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Jun 24 14:35:40 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu Jul 10 17:03:15 2014 +0200" }, "message": "Add missing class initialization during compilation and tests\n\nAdds missing class initialization during compilation and tests, especially\njava.lang.Class. Otherwise, we\u0027d be able to execute code while the referring\nclass is not initialized or initializing.\n\nAlso adds mirror::Class::AssertInitializedOrInitializingInThread method to\ncheck class initialization when entering the interpreter: the called method\u0027s\ndeclaring class must either be initialized or be initializing by the current\nthread (other threads must be waiting for the class initialization to complete\nholding its lock). Note we only do this check in debug build.\n\nBump oat version to force compilation.\n\nBug: 15899971\nChange-Id: I9a4edd3739a3ca4cf1c4929dcbb44cdf7a1ca1fe\n" }, { "commit": "9f1020305292a21fd14a402b189c765a125226ab", "tree": "6b730cbe56ded370d1b4293629826ad2c7b06f7f", "parents": [ "bc72903b909f5147b8cb207f3e5d02a8ef85e4e7" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Fri May 23 08:59:42 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jun 11 14:29:00 2014 +0200" }, "message": "Fix exception reporting from interpreter\n\nTo comply with JDWP exception report rules, we must report an exception at the\nlocation of the throw (or the first instruction encountered after a native\ncall). To do this, we use the CatchLocationFinder visitor to look for a catch\nhandler until we reach a native frame or the top frame.\n\nBecause interpreter handles pending exception on a method-by-method basis, we\nneed a flag to remember we already reported the exception and avoid reporting\nit multiple times when unwinding methods. The drawback is we need to maintain\nthe state of this flag. We clear it when the exception is cleared. In the case\nwe temporarily clear the exception (when finding a catch handler for instance),\nwe restore the flag to its previous value at the same time we restore the\npending exception.\n\nBump oat version to force recompilation because we modify Thread offsets.\n\nBug: 14402770\nChange-Id: Ic059c58f80b2023b118038301f8f0a24f1e18241\n" }, { "commit": "bfd9a4378eacaf2dc2bbe05ad48c5164fc93c9fe", "tree": "3d3f667c8232a9c1bb6fe9daea0d364f9ae01d8c", "parents": [ "2e1ca953c7fb165da36cc26ea74d3045d7e272c8" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed May 21 17:43:44 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Mon Jun 09 12:46:32 2014 -0700" }, "message": "Change MethodHelper to use a Handle.\n\nAdded ConstHandle to help prevent errors where you modify the value\nstored in the handle of the caller. Also fixed compaction bugs\nrelated to not knowing MethodHelper::GetReturnType can resolve types.\nThis bug was present in interpreter RETURN_OBJECT.\n\nBug: 13077697\n\nChange-Id: I71f964d4d810ab4debda1a09bc968af8f3c874a3\n" }, { "commit": "3035961cb41865b80b927546be0c708b6389cec6", "tree": "27ed39f92c013381d08c7ad51d311cb29be230dc", "parents": [ "e21bf0099117b82963cdf7f95a1b8dabfcf29397" ], "author": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Wed May 21 17:46:23 2014 -0700" }, "committer": { "name": "Hans Boehm", "email": "hboehm@google.com", "time": "Fri Jun 06 16:13:42 2014 -0700" }, "message": "Clean up and augment Atomic class. Replace QuasiAtomic MemBars.\n\nAdd a number of missing C++11 operations to Atomic class.\nInvoke the 64 bit routines in QuasiAtomic when necessary.\nReplace QuasiAtomic membars with fences that correspond to C++11 fences.\n\nQuasiAtomic was moved to the top of the file. Only fence implementations\nactually changed.\n\nThis replaces some buggy uses of MembarStoreStore, as reported\nin b/14685856 .\n\nAvoid some redundant fences for long volatile operations.\n\nIncompletely converts low-level memory access operations to Atomic.\n\nChange-Id: Iea828431a0cea46540eb74fcaa02071cab6fdcda\n" }, { "commit": "3c5aec1da27d8068e6bb97202d12efad6b4331df", "tree": "d3a0dda8ab64456aabba18143eaf123e34e1d238", "parents": [ "fbc3e0baa16f265a5dbc99a38383b4dbc41b04a8" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jun 04 09:41:21 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jun 04 09:41:21 2014 +0200" }, "message": "Add missing preamble in switch-based interpreter\n\nAdds missing preamble for CONST_WIDE_HIGH16 instruction.\n\nChange-Id: I80371d6f5e5d1b60c88837706dc139782776eefa\n" }, { "commit": "da843e11bd5f2177a776c37de033228a7ea230af", "tree": "1d63ac9fdf4c9574571c8321f113d6beb29e0fe9", "parents": [ "8b5b1e5593ffa77c393e4172b71a3d5a821d2ed8" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed May 28 19:28:31 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed May 28 19:28:53 2014 +0200" }, "message": "Another workaround for stack overflow issue with clang\n\nBug: 14882674\nChange-Id: I465fda533714021b39b847afe89e454758646b47\n" }, { "commit": "1526c30fff72b6c600b63aebe05d5c4f65c8a29b", "tree": "51768c2694d1153593721907304f51b6a6c0a434", "parents": [ "4996f1191cd3d5edf85981d6412aa129da2dcd06", "5c0049067a953d7a2383d3064a84a32d1efa3a24" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu May 22 06:52:00 2014 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu May 22 06:52:01 2014 +0000" }, "message": "Merge \"Secure move-exception in intepreter\"" }, { "commit": "5c0049067a953d7a2383d3064a84a32d1efa3a24", "tree": "be0377c1348c8aea84a7308fd5977657b8f3622d", "parents": [ "bf17a08fb48fa296acb09904d4c10ba42f63f55d" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed May 21 10:07:42 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed May 21 10:08:31 2014 +0200" }, "message": "Secure move-exception in intepreter\n\nCopies exception into the shadow frame before clearing it from its thread so\nit\u0027s always reachable.\n\nChange-Id: Ifdc68280424f5099aacf0724da94889881a99551\n" }, { "commit": "82aeddb83c58db5fe1e227de574eb8ced4fc6130", "tree": "7eba89c01108035999fcbd8df7bbba62472814c6", "parents": [ "da69b35b1cf63d01f337ebc36aad1edee1bcc06a" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue May 20 20:09:45 2014 +0200" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Tue May 20 14:04:33 2014 -0700" }, "message": "Workaround stack overflow issue with clang\n\nBug: 14882674\nChange-Id: I633251eb5229f0a65c27c6d771a7ff21f616a0f3\n" }, { "commit": "f832284dd847ff077577bb5712225430bbbb3b67", "tree": "44f6b91098639c6ebc438b4ec998d0dc128cef9a", "parents": [ "8f0776768712b2021aa8fb649b51017b9f0fc7a9" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri May 16 10:59:25 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun May 18 12:50:33 2014 -0700" }, "message": "Delete ClassHelper and fix compaction bug in GetDirectInterface\n\nCleanup helps to prevent compaction bugs. Fixed a fairly serious\ncompaction error caused by calling ClassHelper::GetDirectInterface\nwithout handling the case where it causes thread suspension due to\nResolveType.\n\nBug: 8981901\n\nChange-Id: I82b3bb6dd48d21eb6ece7aae0733c4a23c2bc408\n" }, { "commit": "e713d9338ad122d6b8c7997387d0c9fc464eea3e", "tree": "17b3ef199c2cf4b23bb5df4084e95594cac94dab", "parents": [ "4c6491ff7b37d984622c2380300f2c244b26e7d7" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu May 15 10:48:53 2014 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Thu May 15 17:20:06 2014 +0200" }, "message": "Fix JDWP location event report on return instructions\n\nAfter change https://android-review.googlesource.com/94334, the debugger may\nlisten to kDexPcChange event without listening for kMethodExit event. In this\ncase, we need to report kDexPcChange event on RETURN instructions.\n\nBug: 11874828\nChange-Id: Ic61f4eec71e7ece494bee628d7f3358a616d31d3\n" }, { "commit": "8379b2256be5d2be4ad083a76e9f8ec403c4d405", "tree": "23a6cc143b59feaa2f6876dad1260b7c07e0f40d", "parents": [ "e1910f1d802dff79bba5ef61e1c4fd0b95f6e5b0" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Feb 24 17:38:15 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon May 12 16:15:48 2014 +0200" }, "message": "Combine JDWP location events\n\nThe runtime now sends location events BREAKPOINT, SINGLE_STEP, METHOD_ENTRY,\nMETHOD_EXIT and METHOD_EXIT_WITH_RETURN_VALUE in the same JDWP event packet\nwhen they relate to the same location.\n\nWe update the Dbg::UpdateDebugger method to take initial event flags and\nreturned value. It allows to call this method from DebugInstrumentationListener\nso we can treat method entry/exit events with breakpoint and single-step.\n\nIn the interpreter, we ensure we do not call Instrumentation::DexPcMovedEvent\nwhen Instrumentation::MethodEnterEvent has just been called or when we\u0027re about\nto call Instrumentation::MethodExitEvent. This prevents from sending duplicated\nevents.\n\nI measured the average performance impact on some benchmarks with a Nexus 4\nwithout a debugger attached:\n* 1%-2% for the computed-goto-based interpreter (default interpreter)\n* 5%-10% for the switch-based interpreter.\nThis is mostly due to the test of the boolean flag for the method entry event.\n\nBug: https://code.google.com/p/android/issues/detail?id\u003d68427\nBug: 11874828\nChange-Id: Ic4ff61375ff6b4ed5825adeac09f61f97b4be619\n" }, { "commit": "2fa98e26ddd71ca147869b84fc117751ae6ca92a", "tree": "543eb93b8e903cf199078e827129728898b6172d", "parents": [ "47ebd77a6d249403a34d242908749b7446da2a82" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue May 06 15:26:39 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue May 06 15:26:39 2014 -0700" }, "message": "Fix typo.\n\nChange-Id: I733f83bf8577d3fb41534faaf241f1f120870bec\n" }, { "commit": "b2c7ead6bb5c98282cdfbc89db8984a004bea030", "tree": "8c7ca6ea7d57863b60e3f3afac88cb186396aea3", "parents": [ "be4706907e226959623c0fb4937cf3979f440a97" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Apr 29 11:13:16 2014 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Apr 30 11:55:39 2014 -0700" }, "message": "Don\u0027t allow allocating finalizable objects during transactions.\n\nIt doesn\u0027t make sense to allocate finalizable objects during a\ntranscation since they will never get finalized without a started\nruntime.\n\nBefore StatusInitialized in core.host.oatdump.txt: 3564\nAfter StatusInitialized in core.host.oatdump.txt: 3564\n\nBug: 14078487\n\nChange-Id: I7070536f7bb87bfc691d4268bd39a3eca492f48e\n" }, { "commit": "b0fa5dc7769c1e054032f39de0a3f6d6dd06f8cf", "tree": "839d13ebfa7170967dd9b4abd434b7abda53da99", "parents": [ "948740c1938860df055ddc801f20fd1707331e38" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Apr 28 16:47:08 2014 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Apr 29 14:36:28 2014 -0700" }, "message": "Force inlining on trivial accessors.\n\nMake volatility for GetFieldObject a template parameter.\nMove some trivial mirror::String routines to a -inl.h.\n\nBug: 14285442\n\nChange-Id: Ie23b11d4f18cb15a62c3bbb42837a8aaf6b68f92\n" }, { "commit": "d2fe10a3a34af171bf1631219cd2d6ff6b7778b5", "tree": "b6b7eb8eba23a5c2723518da99c03bf47b97f58a", "parents": [ "5a3f55ad9519e87c0d3bbddaf3d8a186a887a79b" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Jan 15 10:20:56 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Feb 17 11:32:15 2014 +0100" }, "message": "Remove blacklist\n\nRemoves the class initialization blacklist and use transaction to detect and\nrevert class initialization attempting to invoke native method. This only\nconcerns class initialization happening at compilation time when generating an\nimage (like boot.art for the system).\n\nIn transactional mode, we log every object\u0027s field assignment and array update.\nTherefore we\u0027re able to abort a transaction to restore values of fields and\narray as they were before the transaction starts. We also log changes to the\nintern string table so we can restore its state prior to transaction start.\n\nSince transactional mode only happens at compilation time, we don\u0027t need to log\nall these changes at runtime. In order to reduce the overhead of testing if\ntransactional mode is on/off, we templatize interfaces of mirror::Object and\nmirror::Array, respectively responsible for setting a field and setting an\narray element.\n\nFor various reasons, we skip some specific fields from transaction:\n- Object\u0027s class and array\u0027s length must remain unchanged so garbage collector\ncan compute object\u0027s size.\n- Immutable fields only set during class loading: list of fields, method,\ndex caches, vtables, ... as all classes have been loaded and verified before a\ntransaction occurs.\n- Object\u0027s monitor for performance reason.\n\nBefore generating the image, we browse the heap to collect objects that need to\nbe written into it. Since the heap may still holds references to unreachable\nobjects due to aborted transactions, we trigger one collection at the end of\nthe class preinitialization phase.\n\nSince the transaction is held by the runtime and all compilation threads share\nthe same runtime, we need to ensure only one compilation thread has exclusive\naccess to the runtime. To workaround this issue, we force class initialization\nphase to run with only one thread. Note this is only done when generating image\nso application compilation is not impacted. This issue will be addressed in a\nseparate CL.\n\nBug: 9676614\nChange-Id: I221910a9183a5ba6c2b99a277f5a5a68bc69b5f9\n" }, { "commit": "ef7d42fca18c16fbaf103822ad16f23246e2905d", "tree": "c67eea52a349c2ea7f2c3bdda8e73933c05531a8", "parents": [ "822115a225185d2896607eb08d70ce5c7099adef" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Mon Jan 06 12:55:46 2014 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Thu Feb 06 23:20:27 2014 -0800" }, "message": "Object model changes to support 64bit.\n\nModify mirror objects so that references between them use an ObjectReference\nvalue type rather than an Object* so that functionality to compress larger\nreferences can be captured in the ObjectRefererence implementation.\nObjectReferences are 32bit and all other aspects of object layout remain as\nthey are currently.\n\nExpand fields in objects holding pointers so they can hold 64bit pointers. Its\nexpected the size of these will come down by improving where we hold compiler\nmeta-data.\nStub out x86_64 architecture specific runtime implementation.\nModify OutputStream so that reads and writes are of unsigned quantities.\nMake the use of portable or quick code more explicit.\nTemplatize AtomicInteger to support more than just int32_t as a type.\nAdd missing, and fix issues relating to, missing annotalysis information on the\nmutator lock.\nRefactor and share implementations for array copy between System and uses\nelsewhere in the runtime.\nFix numerous 64bit build issues.\n\nChange-Id: I1a5694c251a42c9eff71084dfdd4b51fff716822\n" }, { "commit": "abff6439db28fbbed95490bfff7e24d1fdf5b771", "tree": "6ed749056b1d2e29f2bdf81c13e80e15849e9836", "parents": [ "7ea5dafc81b2bba7cabad26130bb75dc8f709803" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Jan 27 18:01:39 2014 +0100" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Jan 28 18:18:14 2014 +0100" }, "message": "Refactor array access for the interpreter.\n\nAdds GetWithoutChecks and SetWithoutChecks methods in PrimitiveArray and use\nthem in the interpreter. Updates Get and Set methods to rely on them and adds\nsome DCHECK to control exception flow.\n\nRenames IsValidIndex into CheckIsValidIndex to reflect it can throw an\nexception. It\u0027s also more consistent with ObjectArray::CheckIsAssignable.\n\nMake ThrowArrayIndexOutOfBoundsException private in Array since it\u0027s only used\nby Array::CheckIsValidIndex.\n\nUpdates DoFilledNewArray to use SetWithoutChecks rather than Set.\n\nChange-Id: I2fd314d77a67cf969843d499b86d04ca7b7a43e6\n" }, { "commit": "b122a4bbed34ab22b4c1541ee25e5cf22f12a926", "tree": "624f16271f4481a8fd5aa2f607385f490dc7b3ae", "parents": [ "e40687d053b89c495b6fbeb7a766b01c9c7e039c" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Tue Nov 19 18:00:50 2013 -0800" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Dec 20 08:01:57 2013 -0800" }, "message": "Tidy up memory barriers.\n\nChange-Id: I937ea93e6df1835ecfe2d4bb7d84c24fe7fc097b\n" }, { "commit": "cbb2d20bea2861f244da2e2318d8c088300a3710", "tree": "9735d496716cf165ea0ee2d7e2f62d723ffc7734", "parents": [ "d31fb9718a6180304cd951619dc36be8e090a641" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Nov 14 17:45:16 2013 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Nov 20 11:14:11 2013 -0800" }, "message": "Refactor allocation entrypoints.\n\nAdds support for switching entrypoints during runtime. Enables\naddition of new allocators with out requiring significant copy\npaste. Slight speedup on ritzperf probably due to more inlining.\n\nTODO: Ensuring that the entire allocation path is inlined so\nthat the switch statement in the allocation code is optimized\nout.\n\nRosalloc measurements:\n4583\n4453\n4439\n4434\n4751\n\nAfter change:\n4184\n4287\n4131\n4335\n4097\n\nChange-Id: I1352a3cbcdf6dae93921582726324d91312df5c9\n" }, { "commit": "e861ebd5d9490cc86200f3859f3d36fadad4588c", "tree": "be9ad31a9175198758491e6bcd3eef5c252c2c38", "parents": [ "d50f8c8e4456263e169c9998d3a1c3a6c5c51435" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 09 15:01:21 2013 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Oct 09 15:17:12 2013 -0700" }, "message": "Fix interpreter bugs.\n\nThese showed up in compaction work.\n\nChange-Id: Iac8eb0a1395c25aabba9f2e0ff6b01fc6180bdca\n" }, { "commit": "253ea073ec03a0be1e22df98957257594e316a39", "tree": "804fbc5b00ef7d0b399aa70960793ce5b50eb2ae", "parents": [ "7ef126ce0593929bcf8fb73d8b1119ce3b95b3f2" ], "author": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Oct 02 12:44:17 2013 -0700" }, "committer": { "name": "Hiroshi Yamauchi", "email": "yamauchi@google.com", "time": "Wed Oct 02 13:34:17 2013 -0700" }, "message": "Fix an Art debug build boot failure.\n\n(The original change is 3b4c18933c24b8a33f38573c2ebcdb9aa16efeb5.)\n\nBug: 11003273\nBug: 9986565\nChange-Id: Iaaf6395f171eb6e6b8c99386c20c4970c53ee00d\n" }, { "commit": "c67148594b1580c278ae71e3ce5c6fd59bfa6bd3", "tree": "4413606a3c8d0d8426c891574047c9256a43abda", "parents": [ "a95be97148b2b2c5095cf80edbebaa771202290e" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 30 16:42:32 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 30 18:17:05 2013 +0200" }, "message": "Enable thread analysis on template functions.\n\nAll template functions using thread analysis must be explicitly instantiated\nwith the thread analysis attributes to enable thread analysis. We use macros\nto do this since there are many variants of a same function depending the\nnumber of template arguments.\n\nAlso add documentation of these functions.\n\nChange-Id: I3c79acc2f0a6a8dfb5c42924439145292dd68812\n" }, { "commit": "c61124bdeaae94f977ffc36ac69535e792c226f2", "tree": "41ba8619a6dea88a8c607836db21531b05a3787a", "parents": [ "7541c745e00b49983f277d6b6b18bc4c174c7e39" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 10 11:44:19 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 30 08:57:33 2013 +0200" }, "message": "Cleanup invoke in interpreter.\n\nSome cleanup in invocation stuff:\n- Get the number of invoke arguments from instruction (vA) rather than get it\nfrom its code item. This benefits to native invoke since we no longer need to\nparse the method\u0027s shorty. Also pass the low 16 bits of instructions to avoid\nfetching it twice when reading vA.\n- Remove \"is_static\" tests by taking advantage of invoke type template argument\nrather than testing method\u0027s access flags.\n- Ensure Instruction::GetArgs is inlined.\n- Check exception when initializing method\u0027s class when transitioning from\ninterpreter to compiled code (artInterpreterToCompiledCodeBridge).\n- Move UnstartedRuntimeInvoke function to interpreter_common.cc and make it\nstatic as it\u0027s only used by DoInvoke and DoInvokeVirtualQuick functions.\n- Avoid duplicating code in ShadowFrame::Create.\n\nPerformance remains the same according to benchmarks. Hopefully, this should be\naddressed in next CLs, especially by improving new shadow frame initialization.\n\nBug: 10668955\nChange-Id: I514b8f098d0ef3e35921ceb770383aac1a9c7902\n" }, { "commit": "a3faaf4bece7f42529c013fe87bd41de59798656", "tree": "933e312a4aa4d69b2d7da7eda4d592419cec4729", "parents": [ "a9a624b2be2180e6bd33f02c89fb8521376a2e8c" ], "author": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Sep 03 19:07:00 2013 -0700" }, "committer": { "name": "Jeff Hao", "email": "jeffhao@google.com", "time": "Tue Sep 24 15:18:36 2013 -0700" }, "message": "Fix handling of unresolved references in verifier.\n\nThe verifier should not treat use of unresolved references as a reason to reject\nthe entire class. Instead, the verifier treats the instruction as a throw. If\nthat class is run, the interpreter with extra checks will throw an exception.\n\nBug: 10457426\n\nChange-Id: I3799da843a7ffb3519bbf6dc13a6276519d9cb95\n" }, { "commit": "450dcb56ecbf6f729401e753f0a27e4170177ddd", "tree": "f596d57c5f6fbdc90b3dc68a2008e38ee48e2882", "parents": [ "810b1d704f2db0d935bf5dddae3545f79cabd435" ], "author": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 20 17:36:02 2013 -0700" }, "committer": { "name": "Ian Rogers", "email": "irogers@google.com", "time": "Fri Sep 20 18:47:39 2013 -0700" }, "message": "Improve float to integral conversion.\n\nChange-Id: I1597083cb2c04084ce825fe2e3c753fde8309cd8\n" }, { "commit": "3b588e09eac6fb2aff64595e2232e479703850fc", "tree": "6a6608e3fa027631715e3da671859daed222c6f2", "parents": [ "3523909c99a27729d9a0d6fe3624f09dfadf351c" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Sep 11 14:33:18 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Sep 18 09:24:45 2013 +0200" }, "message": "Optimize instruction data fetch in interpreter.\n\nThe computed goto implementation prevents the compiler from detecting we are\nloading the first 16 bits of instruction twice: first one to get the opcode and\nsecond one to fetch first instruction\u0027s operand(s) like vA and vB.\n\nWe now load the 16 bits into a local variable and decode opcode and operands\nfrom this variable. And do the same in the switch-based implementation for\nconsistency.\n\nThe performance improvement is 5% in average on benchmark applications suite.\n\nAlso remove unused \"Thread* self\" parameter from DoIGetQuick and DoIPutQuick.\n\nBug: 10703860\nChange-Id: I83026ed6e78f642ac3dcdc6edbb6056fe012005f\n" }, { "commit": "947ff080753c786a74f1cd7aeb09f717bb7074bd", "tree": "ae8d4ceb42602b19b62b61205a5bcb70e6ef6ab3", "parents": [ "ad5f8731448f03c59d5fc8d9b5b25ee91d351ba9" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 17 14:10:13 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Tue Sep 17 15:28:37 2013 +0200" }, "message": "Load shadow frame\u0027s this object only upon instrumentation.\n\nWe used to load the shadow frame\u0027s this object when entering the interpreter\nand push it into thread\u0027s SIRT to make it visible to garbage collector. But\nit is only used by instrumentation listeners.\n\nWe now move this load at each place an instrumentation listener is called. This\navoids loading it when instrumentation is disabled. This also allows to remove\nthe SIRT reference and the push/pop management it implies when entering/exiting\nthe interpreter.\n\nThe performance improvement is 6% in average on our benchmarks suite.\n\nThis CL also makes method Instrumentation::ExceptionCaughtEvent const so we can\nuse a \"const instrumentation::Instrumentation*\" object in interpreter.\n\nChange-Id: I2caccba9a906f244c8057b24031250f9824cc711\n" }, { "commit": "043036f67fa37b3cfa3b05c41e5a824058730378", "tree": "c3969fac77984ae17f11c284c757ef929693509b", "parents": [ "1eda2268e84d384256814cb6c2ba2440a848f9ed" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 09 18:26:48 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 09 20:42:21 2013 +0200" }, "message": "Add missing memory barrier.\n\nWhen DEX-to-DEX compiler is not run onto a method (because it\u0027s not preverified\nat the time of compilation), we do not replace RETURN where a barrier is needed\ninto RETURN_VOID_BARRIER.\nThis CL fixes this by placing a barrier on RETURN instruction only when the\nchecks are enabled (non-preverified method).\n\nChange-Id: I4eb4cf79bb4a74684579c578318e27f62f4d9e8a\n" }, { "commit": "1eda2268e84d384256814cb6c2ba2440a848f9ed", "tree": "b005fcb72a3ce69784ac43e176464ca1b8f49d8a", "parents": [ "7095c6546e03eba2076edcf628b947179c975cb3" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 09 16:53:14 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 09 18:11:15 2013 +0200" }, "message": "Move thread suspend check at safepoints.\n\nMove CheckSuspend on backward branch, return and exception handling.\n\nBug: 10603072\nChange-Id: Ic6c2c5066f133a345323d46edca7afde350849d8\n" }, { "commit": "8ece050d85fc244c72610244e440b0e00aa618fa", "tree": "6f9c9a909fc5c2cdf9cd4ba5c285381be39cc370", "parents": [ "28c2300d9a85f4e7288fb5d94280332f923b4df3" ], "author": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Wed Aug 07 11:26:41 2013 +0200" }, "committer": { "name": "Sebastien Hertz", "email": "shertz@google.com", "time": "Mon Sep 09 17:40:11 2013 +0200" }, "message": "Add an interpreter using computed goto table.\n\nThis CL adds a new implementation of the interpreter using computed goto table.\nIn order to keep the switch-based implementation, it reorders things as the\nfollowing:\n- Keep interpreter entrypoints into interpreter.h/.cc files.\n- Move common interpreter parts to interpreter_common.h/.cc files.\n- Separate both implementations to their own modules.\n\nThe interpreter implementation can be selected by changing the value of the\nkInterpreterImplKind global variable (see interpreter.cc file). The default one\nremains the switch-based implementation.\n\nAlso updates the exception handling (FindNextInstructionFollowingException) and\nSPARSE_SWITCH switch handling (DoSparseSwitch) routines to share code between both\nimplementations.\n\nFinally, adds a PACKED_SWITCH handling routine (DoPackedSwitch) so we are\nconsistent with SPARSE_SWITCH handling.\n\nThe computed goto implementation use two handlers table: one for normal\ninstruction handling and one for instrumentation handling. The current handlers\ntable to be used is updated on backward branch depending on whether there is\nlistener to DEX pc change.\n\nBug: 10602809\nChange-Id: Ibb53bcc68be75c473fe5440835e78fc9a74381b3\n" } ] }