)]}' { "log": [ { "commit": "d8dbc8da0e5cc6b5c2176ce2d3877e6194d72c0c", "tree": "af6e9fb02471d75ebdea46190a0aa3e9dbdb892d", "parents": [ "93780a60090356921b844dbefdc13442c9f18b52" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 20 13:37:47 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 20 15:55:10 2017 +0100" }, "message": "Refactor compiled_method.h .\n\nMove LinkerPatch to compiler/linker/linker_patch.h .\nMove SrcMapElem to compiler/debug/src_map_elem.h .\nIntroduce compiled_method-inl.h to reduce the number\nof `#include`s in compiled_method.h .\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nChange-Id: Id211cdf94a63ad265bf4709f1a5e06dffbe30f64\n" }, { "commit": "1e065a54845da12541572f4f149e6ab0dcd20180", "tree": "061d28c8905c7bc8ac50c8c86f4073034afb5ba2", "parents": [ "f573972a087b798f74bf5404e271355a2805e100" ], "author": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Wed Aug 09 13:20:34 2017 -0700" }, "committer": { "name": "Igor Murashkin", "email": "iam@google.com", "time": "Fri Aug 11 10:23:07 2017 -0700" }, "message": "optimizing: Refactor statistics to use OptimizingCompilerStats helper\n\nRemove all copies of \u0027MaybeRecordStat\u0027, replacing them with a single\nOptimizingCompilerStats::MaybeRecordStat helper.\n\nChange-Id: I83b96b41439dccece3eee2e159b18c95336ea933\n" }, { "commit": "8cf9cb386cd9286d67e879f1ee501ec00d72a4e1", "tree": "88e86e214b425e444760fe4e0ffeee677e1558a2", "parents": [ "914b7b6a6c9f399b26b41e9160e9871ef749e0db" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Jul 19 09:28:38 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Jul 24 16:07:10 2017 -0700" }, "message": "ART: Include cleanup\n\nLet clang-format reorder the header includes.\n\nDerived with:\n\n* .clang-format:\n BasedOnStyle: Google\n IncludeIsMainRegex: \u0027(_test|-inl)?$\u0027\n\n* Steps:\n find . -name \u0027*.cc\u0027 -o -name \u0027*.h\u0027 | xargs sed -i.bak -e \u0027s/^#include/ #include/\u0027 ; git commit -a -m \u0027ART: Include cleanup\u0027\n git-clang-format -style\u003dfile HEAD^\n manual inspection\n git commit -a --amend\n\nTest: mmma art\nChange-Id: Ia963a8ce3ce5f96b5e78acd587e26908c7a70d02\n" }, { "commit": "9983e302384c12a975c8d2d5ae239f79fd8e1996", "tree": "4e4d269fe1a3d4f0f1b93cd972adab9f17aab8e0", "parents": [ "bac2bd1c2fbdd94f4d4dfe83d8451f655e875e36" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jul 14 14:34:22 2017 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jul 14 17:25:39 2017 +0100" }, "message": "Remove the old ARM code generator from ART\u0027s Optimizing compiler.\n\nThe AArch32 VIXL-based code generator has been the default\nARM code generator in ART for some time now. The old ARM\ncode generator does not compile anymore; retiring it.\n\nTest: test.py\nBug: 63316036\nChange-Id: Iab8fbc4ac73eac2c1a809cd7b22fec6b619755db\n" }, { "commit": "5678db5b3a0275d04bc610236f89fac9f76b5b1e", "tree": "efc4ffe5d59a0c6c5f4c15a886459962d24de4aa", "parents": [ "83b140474aa1759739c8ee4464bf226c4fa0f6d7" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 14:11:18 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 08 14:11:18 2017 -0700" }, "message": "ART: Refactor bit_utils and stl_util\n\nMove iterator code from bit_utils.h into bit_utils_iterator.h. Move\nIdentity into stl_util_identity.h. Remove now unnecessary includes,\nand fix up transitive users.\n\nTest: m\nChange-Id: Id1ce9cda66827c5d00584f39ed310b6b37629906\n" }, { "commit": "3c8a91250b3e4e87548ec16bf1ab1ea46dbb84a4", "tree": "b5da100b358d1335eab403372e4f616c5c2d607c", "parents": [ "0a87f31513e5f9da27856af054d2241452898b22", "e7197bf7d58c705a048e13e241d7ca320502cd40" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Jun 07 10:38:10 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jun 07 10:38:11 2017 +0000" }, "message": "Merge \"Replace invoke kind kDexCacheViaMethod with kRuntimeCall.\"" }, { "commit": "e7197bf7d58c705a048e13e241d7ca320502cd40", "tree": "496032b40145660b40002b9d5b7a78f1c2eeb44f", "parents": [ "4ee8e291a7d5b7b98f35f495eb97705836910871" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 17:00:23 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 06 15:26:42 2017 +0100" }, "message": "Replace invoke kind kDexCacheViaMethod with kRuntimeCall.\n\nIn preparation for replacing the dex cache method array\nwith a hash-based array, get rid of one unnecessary use.\nThis method load kind is currently used only on mips for\nirreducible loops and OSR, so this should have no impact\non x86/x86-64/arm/arm64.\n\nTest: m test-art-host-gtest\nTest: testrunner.py --host\nTest: Repeat the above tests with manually changing\n kDexCachePcRelative to kRuntimeCall in sharpening.cc.\n (Ignore failures in 552-checker-sharpening.)\nBug: 30627598\nChange-Id: Ifce42645f2dcc350bbb88c2f4642e88fc5f98152\n" }, { "commit": "0a50965275df2da590c49a7a955e6ff5a7c7d2ae", "tree": "7c4b3f2ebab0abb1c13239878450dc2bf7aaca08", "parents": [ "ab6393400f0dd213d335092c6e83f6a8743f00c2", "4ee8e291a7d5b7b98f35f495eb97705836910871" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 05 14:40:23 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jun 05 14:40:25 2017 +0000" }, "message": "Merge \"Revert^3 \"ART: Reference.getReferent intrinsic for x86 and x86_64\"\"" }, { "commit": "2c97600c1107931825bf9f7f25517e89b7210ab4", "tree": "1951ed02eaf1abac7257d22c5881366c3fe493ba", "parents": [ "af8d813133af6e2988296c9cc19719a9186f4cc8", "847e6ce98b4b822fd94c631975763845978ebaa3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jun 05 09:04:20 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Jun 05 09:04:21 2017 +0000" }, "message": "Merge \"Rename kDexCacheViaMethod to kRuntimeCall for HLoadClass/String.\"" }, { "commit": "4ee8e291a7d5b7b98f35f495eb97705836910871", "tree": "90aa3ea4a0674905b0f6fdb313cab129ca112a56", "parents": [ "d254f5c0d7b43397e8b8885a56ec4d36e9b61602" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 15:39:30 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 16:48:23 2017 +0100" }, "message": "Revert^3 \"ART: Reference.getReferent intrinsic for x86 and x86_64\"\n\nReverting because GenerateCalleeMethodStaticOrDirectCall()\nprevents replacing kDexCacheViaMethod with kRuntimeCall\nwhere we would not retrieve the target method at all and\nleave the runtime to retrieve and call it just like for\nunresolved methods.\n\nThe intrinsic should be re-implemented by loading the\nflags through HLoadClass.\n\nNote that the intrinsic was unimplemented for CC.\n\nTest: Rely on TreeHugger.\nBug: 32535355\nBug: 30627598\n\nThis reverts commit 288c7a8664e516d7486ab85267050e676e84cc39.\n\nChange-Id: Ia22864553ff55562897571e180b11926ccd51588\n" }, { "commit": "b486a98aadc95d80548953410cf23edba62259fa", "tree": "b113b7d50a4a015502873b7742c9ece00d293e84", "parents": [ "1656ca9e6996cb555b4463e5efd4bd7e3f4fb816" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Thu Jun 01 13:45:54 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Jun 02 08:24:02 2017 -0700" }, "message": "ART: Introduce thread-current-inl.h\n\nFactor out Thread::Current() code into its own -inl file to remove\ntransitive includes.\n\nThis requires at the same time correcting mutex.h, i.e., moving\nsome functions into mutex-inl.h.\n\nTest: m test-art-host\nChange-Id: I88f888b604e0897368d9b483edce6ce4332dd9c9\n" }, { "commit": "847e6ce98b4b822fd94c631975763845978ebaa3", "tree": "760e26dea1597d8219d8c515317d978b0213cdc1", "parents": [ "cff1b21b3e19c5d3a2d726fdb60dacd7de2a6f0d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 13:55:07 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 14:03:28 2017 +0100" }, "message": "Rename kDexCacheViaMethod to kRuntimeCall for HLoadClass/String.\n\nThe old name does not reflect the actual code anymore.\n\nTest: testrunner.py --host\nChange-Id: I2e13cf727bba9d901c4d3fc821bb526d38a775b8\n" }, { "commit": "ec32f6402382303608544fdac5a88067781bdec5", "tree": "5a8cddd783a86d3ecb9c3565e65f8fad91e93ada", "parents": [ "8144b1ebea42feaa798419eaf53a6bbbf37822a9" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 10:51:55 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jun 02 11:00:59 2017 +0100" }, "message": "Delay allocating environment locations.\n\nMany environments are killed before we get to the register\nallocation, so the early allocation of their locations was\nsimply wasting memory. For the most expensive method of a\ncertain app, this reduces EnvLocations with 64-bit dex2oat\nfrom 8657200 to 5339712 (-3.16MiB).\n\nTest: m test-art-host\nTest: testrunner.py --host\nBug: 33650849\nChange-Id: I70a02fc3c7ec87b54a87e989e1239dc4acfcf18b\n" }, { "commit": "7d157fcaaae137cc98dbfb872aa1bdc0105a898f", "tree": "2b7d8affda23908e5bfbfaad446079db2ef1ee09", "parents": [ "58d7ddc678e5bcd2364c24c4bdc8a3cfbcfc5358" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed May 10 16:29:23 2017 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu May 11 11:14:54 2017 +0100" }, "message": "Clean up some uses of \"auto\".\n\nMake actual types more explicit, either by replacing \"auto\"\nwith actual type or by assigning std::pair\u003c\u003e elements of\nan \"auto\" variable to typed variables. Avoid binding const\nreferences to temporaries. Avoid copying a container.\n\nTest: m test-art-host-gtest\nChange-Id: I1a59f9ba1ee15950cacfc5853bd010c1726de603\n" }, { "commit": "c15a2f4f45661a7f5f542e406282c146ea1a968d", "tree": "50ad6104b0b8739f272782c35a7022cca64d2601", "parents": [ "9ae527f615f61aec4aaca310c52f373e8c3d8d58" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 21 12:09:39 2017 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 21 16:48:00 2017 -0700" }, "message": "ART: Add object-readbarrier-inl.h\n\nMove some read-barrier code into a new header. This prunes the\ninclude tree for the concurrent-copying collector. Clean up other\nrelated includes.\n\nTest: mmma art\nChange-Id: I40ce4e74f2e5d4c692529ffb4df933230b6fd73e\n" }, { "commit": "c6ea7d00ad069a2736f603daa3d8eaa9a1f8ea11", "tree": "a6d3332a8592fb806841314d55b206b573d37d86", "parents": [ "d68677c5fde1ace16ea58d65733776c954e7acb4" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Wed Feb 01 16:46:28 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Apr 21 08:40:33 2017 -0700" }, "message": "ART: Clean up art_method.h\n\nClean up the header. Fix up other headers including the -inl file,\nin an effort to prune the include graph. Fix broken transitive\nincludes by making includes explicit. Introduce new -inl files\nfor method handles and reference visiting.\n\nTest: source build/envsetup.sh \u0026\u0026 lunch aosp_angler-userdebug \u0026\u0026 mmma art\nTest: source build/envsetup.sh \u0026\u0026 lunch aosp_mips64-userdebug \u0026\u0026 mmma art\nChange-Id: I8f60f1160c2a702fdf3598149dae38f6fa6bc851\n" }, { "commit": "cbcedbf9382bc773713cd3552ed96f417bf1daeb", "tree": "58eed766a69ddddbc41d21624244e14547fa1dff", "parents": [ "ef62210a1466c133056c4bfdae9f8f5417065eff" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Sun Mar 12 22:24:50 2017 -0700" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Mar 16 10:20:34 2017 -0700" }, "message": "Add method info to oat files\n\nThe method info data is stored separately from the code info to\nreduce oat size by improving deduplication of stack maps.\n\nTo reduce code size, this moves the invoke info and inline info\nmethod indices to this table.\n\nOat size for a large app (arm64): 77746816 -\u003e 74023552 (-4.8%)\nAverage oat size reduction for golem (arm64): 2%\n\nRepurposed unused SrcMapElem deduping to be for MethodInfo.\nTODO: Delete SrcMapElem in a follow up CL.\n\nBug: 36124906\n\nTest: clean-oat-host \u0026\u0026 test-art-host-run-test\n\nChange-Id: I2241362e728389030b959f42161ce817cf6e2009\n" }, { "commit": "0c95c12a102cb8c1514410be6e264f9730d847a7", "tree": "30c5f581ee7dd3186a9498f9fdc527aa0c31edc7", "parents": [ "5e2227b961980c69361050a4396763937285af9b" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Sun Feb 26 14:10:28 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Sun Feb 26 14:12:02 2017 -0800" }, "message": "ART: Fix underflow in codegen\n\nCheck for count \u003d\u003d 0 first before accessing non-existent stack map.\n\nTest: m ART_TEST_JIT\u003dtrue test-art-host\nTest: m ART_TEST_JIT\u003dtrue test-art-host-run-test-913-heaps\nChange-Id: Id4cad8e791d731147860b8a9a0d90cc893cc6972\n" }, { "commit": "d776ff08e07494327716f0d2ea1a774b2ebfbca9", "tree": "cedf874dd494d881adc572a10a9d14bca852add6", "parents": [ "3fb852a88d2a8ffaa87089752f4b1d5f9d6ce3c1" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Tue Jan 17 09:32:18 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Wed Feb 15 14:46:15 2017 -0800" }, "message": "Add invoke infos to stack maps\n\nInvoke info records the invoke type and dex method index for invokes\nthat may reach artQuickResolutionTrampoline. Having this information\nrecorded allows the runtime to avoid reading the dex code and pulling\nin extra pages.\n\nCode size increase for a large app:\n93886360 -\u003e 95811480 (2.05% increase)\n\n1/2 of the code size increase is from making less stack maps deduped.\nI suspect there is less deduping because of the invoke info method\nindex.\n\nMerged disabled until we measure the RAM savings.\n\nTest: test-art-host, N6P boots\n\nBug: 34109702\n\nChange-Id: I6c5e4a60675a1d7c76dee0561a12909e4ab6d5d9\n" }, { "commit": "fa4333dcb481e564f54726b4e6f8153612df835e", "tree": "ae597c7587dc214434a180962c4373d3748f51ab", "parents": [ "2d98ba68f13dc219c088a12f369c5778bf398f14" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:10:34 2017 -0800" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Feb 14 11:44:48 2017 -0800" }, "message": "ART: Add operator \u003d\u003d and !\u003d with nullptr to Handle\n\nGet it in line with ObjPtr and prettify our code.\n\nTest: m\nChange-Id: I1322e2a9bc7a85d7f2441034a19bf4d807b81a0e\n" }, { "commit": "b048cb74b742b03eb6dd5f1d6dd49e559f730b36", "tree": "b1f663cbb343488a548cce4db352dbc4af720a89", "parents": [ "f34077c96af3389e8eae65252d4c5d51cf630039" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 23 22:50:24 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 26 09:56:36 2017 +0000" }, "message": "Add per array size allocation entrypoints.\n\n- Update architectures that have fast paths for\n array allocation to use it.\n- Will add more fast paths in follow-up CLs.\n\nTest: test-art-target test-art-host.\nChange-Id: I138cccd16464a85de22a8ed31c915f876e78fb04\n" }, { "commit": "a2f526f889be06f96ea59624c9dfb1223b3839f3", "tree": "769f517e6664de0e89abeadf07a39d5410fcee42", "parents": [ "64e50021845b1ad9d8851596e8aaddf18be217c2" ], "author": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Thu Jan 19 14:48:48 2017 -0800" }, "committer": { "name": "Mathieu Chartier", "email": "mathieuc@google.com", "time": "Fri Jan 20 15:47:06 2017 -0800" }, "message": "Compressed native PC for stack maps\n\nCompress native PC based on instruction alignment. This reduces the\nsize of stack maps, boot.oat is 0.4% smaller for arm64.\n\nTest: test-art-host, test-art-target, N6P booting\n\nChange-Id: I2b70eecabda88b06fa80a85688fd992070d54278\n" }, { "commit": "e037a736be43c1e8ba9340dcbf1d17722356a37b", "tree": "f0bc7b4a78d04376b042046afbfd0677d766b523", "parents": [ "db54cc42859a8cc24ed1cda7f9b2f64b27dcb34a", "5d37c152f21a0807459c6f53bc25e2d84f56d259" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 17 09:16:31 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jan 17 09:16:31 2017 +0000" }, "message": "Merge \"Put inlined ArtMethod pointer in stack maps.\"" }, { "commit": "5d37c152f21a0807459c6f53bc25e2d84f56d259", "tree": "7d8cbce0a55f258150a047def70244f79afc866d", "parents": [ "aa89a4c6fca095904521842c018399f1e3501a45" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Jan 12 13:25:19 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 16 22:56:56 2017 +0000" }, "message": "Put inlined ArtMethod pointer in stack maps.\n\nCurrently done for JIT. Can be extended for AOT and inlined boot\nimage methods.\n\nAlso refactor the lookup of a inlined method at runtime to not\nrely on the dex cache, but look at the class loader tables.\n\nbug: 30933338\ntest: test-art-host, test-art-target\nChange-Id: I58bd4d763b82ab8ca3023742835ac388671d1794\n" }, { "commit": "4155998a2f5c7a252a6611e3926943e931ea280a", "tree": "3495370417d54a9bf7d0acedeefe89bd511062e0", "parents": [ "48886c2ee655a16224870fee52dc8721a52babcf" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jan 06 14:04:23 2017 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Jan 16 12:09:53 2017 +0000" }, "message": "Make runtime call on main for HLoadClass/kDexCacheViaMethod.\n\nRemove dependency of the compiled code on types dex cache\narray in preparation for changing to a hash-based array.\n\nTest: m test-art-host\nTest: m test-art-target on Nexus 9\nBug: 30627598\nChange-Id: I3c426ed762c12eb9eb4bb61ea9a23a0659abf0a2\n" }, { "commit": "ac141397dc29189ad2b2df41f8d4312246beec60", "tree": "a2f481463a14695bf9327fd2f549878ecf30c77b", "parents": [ "5c9f90c5ecf2ff6f93ada0f7b18b46d866c59ea1" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Fri Jan 13 11:53:47 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Sun Jan 15 15:18:07 2017 +0000" }, "message": "Revert \"Revert \"ART: Compiler support for invoke-polymorphic.\"\"\n\nThis reverts commit 0fb5af1c8287b1ec85c55c306a1c43820c38a337.\n\nThis takes us back to the original change and attempts to fix the\nissues encountered:\n\n- Adds transition record push/pop around artInvokePolymorphic.\n- Changes X86/X64 relocations for MacSDK.\n- Implements MIPS entrypoint for art_quick_invoke_polymorphic.\n- Corrects size of returned reference in art_quick_invoke_polymorphic\n on ARM.\n\nBug: 30550796,33191393\nTest: art/test/run-test 953\nTest: m test-art-run-test\n\nChange-Id: Ib6b93e00b37b9d4ab743a3470ab3d77fe857cda8\n" }, { "commit": "dcf52765ab5886abdd85a4436fa0358b2a31341d", "tree": "b68ee975792a5bf488ed93cfbe09a37f80008288", "parents": [ "a28ddf5140cd1f4a2ae93dbf8be2f200b1552003", "0fb5af1c8287b1ec85c55c306a1c43820c38a337" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 19:18:51 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jan 11 19:18:51 2017 +0000" }, "message": "Merge \"Revert \"ART: Compiler support for invoke-polymorphic.\"\"" }, { "commit": "0fb5af1c8287b1ec85c55c306a1c43820c38a337", "tree": "66239e7f745fae54e1630e91fb44a859bff615d6", "parents": [ "02e3092f8d98f339588e48691db77f227b48ac1e" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 18:58:15 2017 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 19:17:33 2017 +0000" }, "message": "Revert \"ART: Compiler support for invoke-polymorphic.\"\n\nThis reverts commit 02e3092f8d98f339588e48691db77f227b48ac1e.\n\nReasons for revert:\n\n- Breaks MIPS/MIPS64 build.\n- Fails under GCStress test on x64.\n- Different x64 build configuration doesn\u0027t like relocation.\n\nChange-Id: I512555b38165d05f8a07e8aed528f00302061001\n" }, { "commit": "79f9928fc9e0a88430f3329069bfb2f9a0d37f0c", "tree": "e3142e4829c808c3df1059f3b05c0b3a37193ce9", "parents": [ "716eb25353390f699778a79d69006a5b8d8289c2", "02e3092f8d98f339588e48691db77f227b48ac1e" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Jan 11 18:08:03 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Jan 11 18:08:04 2017 +0000" }, "message": "Merge \"ART: Compiler support for invoke-polymorphic.\"" }, { "commit": "02e3092f8d98f339588e48691db77f227b48ac1e", "tree": "127dd23346206b0547b7c6453a776253252b3c6e", "parents": [ "bc7d0deda4549f314e68ee3e0e6afd68c4a8fd06" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Dec 01 10:33:51 2016 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Jan 11 16:26:43 2017 +0000" }, "message": "ART: Compiler support for invoke-polymorphic.\n\nAdds basic support to invoke method handles in compiled code.\n\nEnables method verification for methods containing invoke-polymorphic.\n\nAdds k45cc/k45rc output to Instruction::DumpString() which\nwas found to be missing when enabling verification.\n\nInclude stack traces in test 957-methodhandle-transforms for\nfailures so they can be easily identified.\n\nBug: 30550796,33191393\nTest: art/test/run-test 953\nTest: m test-art-run-test\nChange-Id: Ic9a96ea24906087597d96ad8159a5bc349d06950\n" }, { "commit": "f0acfe7a812a332122011832074142718c278dae", "tree": "49c4fc481cebd03323aaf0109066859165508303", "parents": [ "91db41f315f6c2366b7098c531224bee01170364" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Jan 09 20:54:52 2017 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Jan 10 21:26:23 2017 +0000" }, "message": "Keep resolved String in HLoadString.\n\nFor the following reasons:\n- Avoids needing to do a lookup again in CodeGenerator::EmitJitRoots.\n- Fixes races where we the string was GC\u0027ed before CodeGenerator::EmitJitRoots.\n- Makes it possible to do GVN on the same string but defined in different\n dex files.\n\nTest: test-art-host, test-art-target\nChange-Id: If2b5d3079f7555427b1b96ab04546b3373fcf921\n" }, { "commit": "22384aeab988df7fa5ccdc48a668589c5f602c39", "tree": "daca06adfc92c93017618c3729af54ed40214ba4", "parents": [ "0ee6447c63e354131dec78743ccabcbc964129e3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 22:33:36 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 23:06:38 2016 +0000" }, "message": "Revert \"Revert \"Add kJitTableAddress for HLoadClass.\"\"\n\nThis reverts commit d2d5262c8370309e1f2a009f00aafc24f1cf00a0.\n\nChange-Id: I6149d5c7d5df0b0fc5cb646a802a2eea8d01ac08\n" }, { "commit": "d2d5262c8370309e1f2a009f00aafc24f1cf00a0", "tree": "15b542ac079f30043cd3654cf5d3c40ae3ea34d0", "parents": [ "5b12f7973636bfea29da3956a9baa7a6bbe2b666" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 16:28:54 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 16:28:54 2016 +0000" }, "message": "Revert \"Add kJitTableAddress for HLoadClass.\"\n\nOne test failure after merge.\n\nThis reverts commit 5b12f7973636bfea29da3956a9baa7a6bbe2b666.\n\nChange-Id: I120c49e53274471fc1c82a10d52e99c83f5f85cc\n" }, { "commit": "5b12f7973636bfea29da3956a9baa7a6bbe2b666", "tree": "a2cd41c1d3c09abc594a76af11b7bebc302a2870", "parents": [ "0dd27eb2b51d030866c25dbf8e7bb737eb35a888" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Dec 09 11:26:35 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Dec 12 11:50:24 2016 +0000" }, "message": "Add kJitTableAddress for HLoadClass.\n\nThis new kind loads classes from the root table associated with\nJIT compiled code.\n\nAlso remove kDexCacheAddress, which is replaced by kJitTableAddress.\n\ntest: ART_TEST_JIT\u003dtrue test-art-host-jit test-art-target-jit\nChange-Id: Ia23029688d1a60c178bf2ffa7463927c5d5de4d0\n" }, { "commit": "063fc772b5b8aed7d769cd7cccb6ddc7619326ee", "tree": "bc165781989087a998721991504e589a7d5b0926", "parents": [ "48d08a4233ee4450b0d5073d41445f9dd1f17191" ], "author": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Tue Aug 02 11:02:54 2016 -0700" }, "committer": { "name": "Mingyao Yang", "email": "mingyao@google.com", "time": "Thu Dec 01 11:15:47 2016 -0800" }, "message": "Class Hierarchy Analysis (CHA)\n\nThe class linker now tracks whether a method has a single implementation\nand if so, the JIT compiler will try to devirtualize a virtual call for\nthe method into a direct call. If the single-implementation assumption\nis violated due to additional class linking, compiled code that makes the\nassumption is invalidated. Deoptimization is triggered for compiled code\nlive on stack. Instead of patching return pc\u0027s on stack, a CHA guard is\nadded which checks a hidden should_deoptimize flag for deoptimization.\nThis approach limits the number of deoptimization points.\n\nThis CL does not devirtualize abstract/interface method invocation.\n\nSlides on CHA:\nhttps://docs.google.com/a/google.com/presentation/d/1Ax6cabP1vM44aLOaJU3B26n5fTE9w5YU-1CRevIDsBc/edit?usp\u003dsharing\n\nChange-Id: I18bf716a601b6413b46312e925a6ad9e4008efa4\nTest: ART_TEST_JIT\u003dtrue m test-art-host/target-run-test test-art-host-gtest\n" }, { "commit": "132d8363bf8cb043d910836672192ec8c36649b6", "tree": "42ee8b08f0323e9762675333b50a4c218ecdefc7", "parents": [ "e89667815b9d0a1eacb91678fed2a7518bb07cc2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 16 09:19:42 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 18 14:31:30 2016 +0000" }, "message": "Revert \"Revert \"Revert \"Revert \"JIT root tables.\"\"\"\"\n\nTest: 626-set-resolved-string, test-art-host, test-art-target\nTest: run-libcore-tests.sh\nTest: phone boots and runs\n\nThis reverts commit 3395fbc20bcd20948bec8958db91b304c17cacd8.\n\nChange-Id: I104b73d093e3eb6a271d564cfdb9ab09c1c8cf24\n" }, { "commit": "3395fbc20bcd20948bec8958db91b304c17cacd8", "tree": "e0d00b412961e2aaa0dff91317a9f4168189e5fb", "parents": [ "75afcdd3503a8a8518e5b23d21b6e73306ce39ce" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 14 12:40:52 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Nov 14 12:40:52 2016 +0000" }, "message": "Revert \"Revert \"Revert \"JIT root tables.\"\"\"\n\nlibcore failures:\ndalvikvm32 F 11-14 03:04:06 14870 14870 jit_code_cache.cc:310] Check failed: new_string !\u003d nullptr\n\nThis reverts commit 75afcdd3503a8a8518e5b23d21b6e73306ce39ce.\n\nChange-Id: I5a6b6b48aa79a763d1ff1ba4d85d63811254787d\n" }, { "commit": "75afcdd3503a8a8518e5b23d21b6e73306ce39ce", "tree": "b49afc4772fa72319475f96ed66d744bb03e803c", "parents": [ "ee48b0f11df812d98de5c989e1f6d95a21515564" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Nov 10 10:38:11 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Nov 11 13:18:24 2016 +0000" }, "message": "Revert \"Revert \"JIT root tables.\"\"\n\nAlso contains Revert \"Support kJitTableAddress in x86/arm/arm64.\"\n\nThis reverts commit 4acd03638fcdb4e5d1666f8eec7eb3bf6d6be035.\nThis reverts commit 997d1217830c0a18b70faeabd53c04700a87d7d9.\n\nTest: ART_USE_READ_BARRIER\u003dtrue/false test-art-host test-art-target\n\nChange-Id: I77cb1e9bf8f1b4c58b72d3cf5ca31ced2aaa1ea3\n" }, { "commit": "4acd03638fcdb4e5d1666f8eec7eb3bf6d6be035", "tree": "1220262d0ed22d91777c68a8a568348cddf820cb", "parents": [ "ac3ebc3150760425ed00abd56da48f9a6e0666bc" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 09 17:30:31 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Nov 09 17:30:31 2016 +0000" }, "message": "Revert \"JIT root tables.\"\n\nMay be the offender for jit-gcstress failure of 902.\n\nThis reverts commit ac3ebc3150760425ed00abd56da48f9a6e0666bc.\n\nChange-Id: I9ea6c9236fd1729fed7d1868dd8a111172932308\n" }, { "commit": "ac3ebc3150760425ed00abd56da48f9a6e0666bc", "tree": "3c5c923bb00a898e035c0e7c4b8a6a684a578419", "parents": [ "76ad2405b40547e0ab4fc401fb8303189ff783eb" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Oct 05 13:13:50 2016 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Tue Nov 08 17:21:30 2016 +0000" }, "message": "JIT root tables.\n\nImplement root tables for the JIT. Each JIT compiled method\ngets a table allocated before the stack maps.\n\nThe table gets visited through Runtime::SweepSystemWeaks.\n\nImplement String roots for x86_64 as an example.\n\nTest: test-art-host test-art-target\n\nChange-Id: Id3d5bc67479e08b52dd4b253e970201203a0f0d2\n" }, { "commit": "2c45bc9137c29f886e69923535aff31a74d90829", "tree": "90c7762c2dcb1105bf5907d6a1d068f172ea6155", "parents": [ "168c58ce18b139d313cbc6131e3bb43539952c55" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Oct 25 16:54:12 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Oct 27 14:30:29 2016 +0100" }, "message": "Remove H[Reverse]PostOrderIterator and HInsertionOrderIterator.\n\nUse range-based loops instead, introducing helper functions\nReverseRange() for iteration in reverse order in containers.\nWhen the contents of the underlying container change inside\nthe loop, use an index-based loop that better exposes the\ncontainer data modifications, compared to the old iterator\ninterface that\u0027s hiding it which may lead to subtle bugs.\n\nTest: m test-art-host\nChange-Id: I2a4e6c508b854c37a697fc4b1e8423a8c92c5ea0\n" }, { "commit": "5e4e11e171f90d9a3ea178fc8e72aac909de55d5", "tree": "53314d1139ac797d55258f39097ecfb5cef45920", "parents": [ "ca8bad9136d1389deeebc8652fb17063388de6b2" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Thu Sep 22 13:17:41 2016 +0100" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Sep 23 09:08:00 2016 +0100" }, "message": "Clean-up sharpening and compiler driver.\n\nRemove dependency on compiler driver for sharpening\nand dex2dex (the methods called on the compiler driver were\ndoing unnecessary work), and remove the now unused methods\nin compiler driver.\n\nAlso remove test that is now invalid, as sharpening always\nsucceeds.\n\ntest: m test-art-host m test-art-target\nChange-Id: I54e91c6839bd5b0b86182f2f43ba5d2c112ef908\n" }, { "commit": "fe8854609898b5a148d2c4094aa9970af1a4ec59", "tree": "702e576ecfedb88f84b47f6b112d227161709520", "parents": [ "45026e4548641b1c0da0a030d563adb894bc5dd5" ], "author": { "name": "Scott Wakeling", "email": "scott.wakeling@linaro.org", "time": "Thu Sep 22 10:24:38 2016 +0100" }, "committer": { "name": "Scott Wakeling", "email": "scott.wakeling@linaro.org", "time": "Thu Sep 22 10:44:29 2016 +0100" }, "message": "Revert \"Revert \"ARM: VIXL32: Add an initial code generator that passes codegen_tests.\"\"\n\nThis VIXL32-based code generator is not enabled in the optimizing\ncompiler by default. Changes in codegen_test.cc test it in parallel with\nthe existing ARM backend.\n\nThis patch provides a base for further work, the new backend will not\nbe enabled in the optimizing compiler until parity is proven with the\ncurrent ARM backend and assembler.\n\nTest: gtest-codegen_test on host and target\n\nThis reverts commit 7863a2152865a12ad9593d8caad32698264153c1.\n\nChange-Id: Ia09627bac22e78732ca982d207dc0b00bda435bb\n" }, { "commit": "be0f728348139a9185b08d4d5c5adfa806bee00b", "tree": "64e30afc9e2951679c372f1e14f23b10002dabfe", "parents": [ "ce092d0e374107fc7416416848d3f232233f84ee", "7863a2152865a12ad9593d8caad32698264153c1" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 21 16:53:31 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Sep 21 16:53:32 2016 +0000" }, "message": "Merge \"Revert \"ARM: VIXL32: Add an initial code generator that passes codegen_tests.\"\"" }, { "commit": "7863a2152865a12ad9593d8caad32698264153c1", "tree": "69c31579f4440d9e8cffbe63b9975bff8a8c8ea2", "parents": [ "b138dfbd76f9d8b64fb9dbaf1a7c25e2549b2a8c" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 21 16:53:03 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Sep 21 16:53:03 2016 +0000" }, "message": "Revert \"ARM: VIXL32: Add an initial code generator that passes codegen_tests.\"\n\nFailing with:\nart/compiler/optimizing/code_generator_arm_vixl.cc:396:47: error: too few arguments to function call, expected 3, have 2\n ValidateInvokeRuntime(instruction, slow_path);\n\nThis reverts commit b138dfbd76f9d8b64fb9dbaf1a7c25e2549b2a8c.\n\nChange-Id: Idccfe076f5905ea92ecbe3afbc7c8c64ecda94be\n" }, { "commit": "d26a0a64d0e68746be74859aed520a590d79995f", "tree": "74f2932a4975b99d6173a74ccc97ebaa6f038fff", "parents": [ "7b0d9228e9fe77f73bfb6f8b8e74942b23873c0a", "b138dfbd76f9d8b64fb9dbaf1a7c25e2549b2a8c" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Wed Sep 21 16:32:59 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Sep 21 16:32:59 2016 +0000" }, "message": "Merge \"ARM: VIXL32: Add an initial code generator that passes codegen_tests.\"" }, { "commit": "804b03ffb9b9dc6cc3153e004c2cd38667508b13", "tree": "91c7fd54b5000e041bf9d3d5b233dabce1fad614", "parents": [ "80eb0bc2757274816a014a2997848d288c9ee553" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 14 16:26:36 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Sep 20 14:55:44 2016 +0100" }, "message": "Change remaining slow path throw entrypoints to save everything.\n\nChange DivZeroCheck, BoundsCheck and explicit NullCheck\nslow path entrypoints to conform to kSaveEverything.\n\nOn Nexus 9, AOSP ToT, the boot.oat size reduction is\n prebuilt multi-part boot image:\n - 32-bit boot.oat: -12KiB (-0.04%)\n - 64-bit boot.oat: -24KiB (-0.06%)\n on-device built single boot image:\n - 32-bit boot.oat: -8KiB (-0.03%)\n - 64-bit boot.oat: -16KiB (-0.04%)\n\nTest: Run ART test suite including gcstress on host and Nexus 9.\nTest: Manually disable implicit null checks and test as above.\nChange-Id: If82a8082ea9ae571c5d03b5e545e67fcefafb163\n" }, { "commit": "91a6516103b8bf8bb75c3a2840cbdec7521e74a7", "tree": "d93043f578bfa5b8d76e8c175e6441b378c4a7b2", "parents": [ "6a4abc633fa8580b06056ec6f80ced8ce7511277" ], "author": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Mon Sep 19 13:54:30 2016 +0100" }, "committer": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Mon Sep 19 13:54:30 2016 +0100" }, "message": "Remove the `CanTriggerGC` side-effects on a few instructions.\n\nThe side-effect was specified for these instructions as they call\nruntime. We now have a list of entrypoints that we know cannot trigger\nGC. We can avoid requiring the side-effect for those.\n\nTest: Run ART test suite on Nexus 5X and host.\n\nChange-Id: I0e0e6a4d701ce6c75aff486cb0d1bc7fe2e8dda4\n" }, { "commit": "b138dfbd76f9d8b64fb9dbaf1a7c25e2549b2a8c", "tree": "a3765fd2bd7e5ddd7ec81adab1ec36859f193d94", "parents": [ "5cfaafbda5d2de57e311cfc9051f8d817091e950" ], "author": { "name": "Scott Wakeling", "email": "scott.wakeling@linaro.org", "time": "Tue Jul 26 10:33:29 2016 +0100" }, "committer": { "name": "Scott Wakeling", "email": "scott.wakeling@linaro.org", "time": "Thu Sep 15 16:17:01 2016 +0100" }, "message": "ARM: VIXL32: Add an initial code generator that passes codegen_tests.\n\nThis VIXL32-based code generator is not enabled in the optimizing\ncompiler by default. Changes in codegen_test.cc test it in parallel\nwith the existing ARM backend.\n\nThis patch provides a base for further work, the new backend will not\nbe enabled in the optimizing compiler until parity is proven with the\ncurrent ARM backend and assembler.\n\nTest: gtest-codegen_test on host and target\n\nChange-Id: Id556a975b2645bf1d98ab2984650e8435b2312c2\n" }, { "commit": "3b7537bfc5a6b7ccb18b3970d8edf14b72464af7", "tree": "49996e22e36a64ea862e7b173e9626d862a4d595", "parents": [ "c11d1b42828475ea1e7319fc3eb9402edc5b1c13" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Sep 13 11:56:01 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 14 10:42:08 2016 +0100" }, "message": "Revert \"Revert \"Use implicit null checks inside try blocks.\"\"\n\nFix implicit checks in try blocks to emit stack maps.\nFix arm64 null expection from signal entrypoint to call\nthe runtime handler instead or simply jumping there.\n\nOn Nexus 9, AOSP ToT, the boot.oat size reduction is\n prebuilt multi-part boot image:\n - 32-bit boot.oat: -448KiB (-1.3%)\n - 64-bit boot.oat: -528KiB (-1.2%)\n on-device built single boot image:\n - 32-bit boot.oat: -448KiB (-1.4%)\n - 64-bit boot.oat: -528KiB (-1.3%)\nNote that the oat files no longer contain dex files which\nhave been moved to vdex, so the percentages are not directly\ncomparable with the those reported in the original commit.\n\nTest: Run ART test suite including gc-stress on host and Nexus 9.\nBug: 30212852\nBug: 31468464\n\nThis reverts commit 0719b5b9b458cb3eb9f0823f0dacdfe1a71214dd.\n\nChange-Id: If8a9da8c11adf2aad203e93b6684ce16ed776285\n" }, { "commit": "0719b5b9b458cb3eb9f0823f0dacdfe1a71214dd", "tree": "cf0844758239b6ec41fa070e4fb4b4fbcbb9e506", "parents": [ "7aa7560683626c7893011271c241b3265ded1dc3" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 12 22:05:33 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Mon Sep 12 22:05:33 2016 +0000" }, "message": "Revert \"Use implicit null checks inside try blocks.\"\n\nFails gcstress tests.\n\nThis reverts commit 7aa7560683626c7893011271c241b3265ded1dc3.\n\nChange-Id: I4f5c89048b9ffddbafa02f3001e329ff87058ca2\n" }, { "commit": "7aa7560683626c7893011271c241b3265ded1dc3", "tree": "8c9839456149d2320995764ebab5d227a6dea8e7", "parents": [ "ae6ba1fd36ef6cd6520354fa874cf9cc2fc5877b" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Wed Sep 07 15:09:21 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 12 14:52:17 2016 +0100" }, "message": "Use implicit null checks inside try blocks.\n\nMake implicit null check entrypoint save all registers, use\nplatform-specific approach to still pass the fault address.\nAllow implicit null checks in try blocks.\n\nOn Nexus 9, AOSP ToT, the boot.oat size reduction is\n prebuilt multi-part boot image:\n - 32-bit boot.oat: -452KiB (-0.7%)\n - 64-bit boot.oat: -482KiB (-0.7%)\n on-device built single boot image:\n - 32-bit boot.oat: -444KiB (-0.7%)\n - 64-bit boot.oat: -488KiB (-0.7%)\n\nTest: Run ART test suite on host and Nexus 9.\nTest: Build aosp_mips64-eng.\nChange-Id: I279f3ab57e2e2f338131c5cac45c51b673bdca19\n" }, { "commit": "86dc59ebe25cfe36d4edb39c2b7b2653f079448b", "tree": "446d80551ab72701914ed08ac18fcaeffd6555b1", "parents": [ "b0f443217306b8a307f73d35cb27c1cac2e1c360", "70e97462116a47ef2e582ea29a037847debcc029" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Sep 05 18:12:13 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Sep 05 18:12:13 2016 +0000" }, "message": "Merge \"Avoid excessive spill slots for slow paths.\"" }, { "commit": "70e97462116a47ef2e582ea29a037847debcc029", "tree": "ee587e35b9b9483c35875ccc8ddea139978ca823", "parents": [ "521691ae4dfad47cf6b46858347fa5fa32fd7bcc" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Aug 09 11:04:26 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Sep 05 17:27:41 2016 +0100" }, "message": "Avoid excessive spill slots for slow paths.\n\nReducing the frame size makes stack maps smaller as we need\nfewer bits for stack masks and some dex register locations\nmay use short location kind rather than long. On Nexus 9,\nAOSP ToT, the boot.oat size reduction is\n prebuilt multi-part boot image:\n - 32-bit boot.oat: -416KiB (-0.6%)\n - 64-bit boot.oat: -635KiB (-0.9%)\n prebuilt multi-part boot image with read barrier:\n - 32-bit boot.oat: -483KiB (-0.7%)\n - 64-bit boot.oat: -703KiB (-0.9%)\n on-device built single boot image:\n - 32-bit boot.oat: -380KiB (-0.6%)\n - 64-bit boot.oat: -632KiB (-0.9%)\n on-device built single boot image with read barrier:\n - 32-bit boot.oat: -448KiB (-0.6%)\n - 64-bit boot.oat: -692KiB (-0.9%)\n\nThe other benefit is that at runtime, threads may need fewer\npages for their stacks, reducing overall memory usage.\n\nWe defer the calculation of the maximum spill size from\nthe main register allocator (linear scan or graph coloring)\nto the RegisterAllocationResolver and do it based on the\nlive registers at slow path safepoints. The old notion of\nan artificial slow path safepoint interval is removed as\nit is no longer needed.\n\nTest: Run ART test suite on host and Nexus 9.\nBug: 30212852\nChange-Id: I40b3d114e278e2c5807982904fa49bf6642c6275\n" }, { "commit": "57eb0f58419e0e6773f69cf6e0c78e5fed0464cd", "tree": "5104bb1c1ad04f9f6a04fcac5d497d54ed0c97ab", "parents": [ "d7eabc2cc1a88c1f7f927da61246ae65aab0626c" ], "author": { "name": "Alexey Frunze", "email": "Alexey.Frunze@imgtec.com", "time": "Fri Jul 29 22:04:46 2016 -0700" }, "committer": { "name": "Alexey Frunze", "email": "Alexey.Frunze@imgtec.com", "time": "Tue Aug 30 16:50:28 2016 -0700" }, "message": "MIPS32: Fill branch delay slots\n\nTest: booted MIPS32 in QEMU\nTest: test-art-host-gtest\nTest: test-art-target-gtest\nTest: test-art-target-run-test-optimizing on CI20\n\nChange-Id: I727e80753395ab99fff004cb5d2e0a06409150d7\n" }, { "commit": "16d9f949698faed28435af7aa9c9ebacbfd5d1a8", "tree": "870fbd499c10f70cecc5f62246b26e1332b600da", "parents": [ "7c95b4e22897a6f14ef79ec6e547e2eed686814a" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Aug 25 17:27:56 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu Aug 25 17:27:56 2016 +0100" }, "message": "Re-enable the ArraySet fast path with Baker read barriers.\n\nBenchmarks (ARM64) score variations on Nexus 5X with CPU\ncores clamped at 960000 Hz (aosp_bullhead-userdebug build):\n- Ritzperf - average (lower is better): -0.95% (virtually unchanged)\n- CaffeineMark - average (higher is better): +2.50% (slightly better)\n- DeltaBlue (lower is better): -0.55% (virtually unchanged)\n- Richards - average (lower is better): +0.67% (virtually unchanged)\n- SciMark2 - average (higher is better): -0.10% (virtually unchanged)\n\nDetails about Ritzperf benchmarks with meaningful variations\n(lower is better):\n- GenericCalcActions.MemAllocTest: -5.05% (better)\n\nDetails about CaffeineMark benchmarks with meaningful variations\n(higher is better):\n- Method: +16.88% (better)\n\nDetails about Richards benchmarks with meaningful variations\n(lower is better):\n- deutsch_acc_interface: +9.86% (worse)\n\nBoot image code size variation on Nexus 5X\n(aosp_bullhead-userdebug build):\n- total ARM64 framework Oat files size change:\n 105933472 bytes -\u003e 106027680 bytes (+0.09%)\n- total ARM framework Oat files size change:\n 89157936 bytes -\u003e 89239856 bytes (+0.09%)\n\nTest: ART host and target (ARM, ARM64) tests.\nBug: 29516974\nBug: 29506760\nBug: 12687968\nChange-Id: Ib9e9709712295e17804b8888ac10e3d518ff2e70\n" }, { "commit": "0b671c0408e98824e1f92b1ee951b210c090fe7a", "tree": "0bc58c031cd899aa856677fe8c9ffa376228806f", "parents": [ "36bf3a2d281892e7906d3eaf9d7455b0656c9a25" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 19 12:02:34 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Aug 19 16:00:09 2016 +0100" }, "message": "Add support for Baker read barriers in SystemArrayCopy intrinsics.\n\nBenchmarks (ARM64) score variations on Nexus 5X with CPU\ncores clamped at 960000 Hz (aosp_bullhead-userdebug build):\n- Ritzperf - average (lower is better): -3.03% (slightly better)\n- CaffeineMark - average (higher is better): +1.26% (slightly better)\n- DeltaBlue (lower is better): -10.50% (better)\n- Richards - average (lower is better): -3.36% (slightly better)\n- SciMark2 - average (higher is better): +0.26% (virtually unchanged)\n\nDetails about Ritzperf benchmarks with meaningful variations\n(lower is better):\n- FormulaEvaluationActions.EvaluateAndApplyChanges: -13.26% (better)\n- FormulaEvaluationActions.EvaluateCascadingSums: -10.94% (better)\n- FormulaEvaluationActions.EvaluateComplexFormulas: -15.50% (better)\n- FormulaEvaluationActions.EvaluateFibonacci: -10.41% (better)\n- FormulaEvaluationActions.EvaluateLargeSums: +6.02% (worse)\n\nBoot image code size variation on Nexus 5X\n(aosp_bullhead-userdebug build):\n- total ARM64 framework Oat files size change:\n 107047632 bytes -\u003e 107154128 bytes (+0.10%)\n- total ARM framework Oat files size change:\n 90932028 bytes -\u003e 91009852 bytes (+0.09%)\n\nTest: ART host and target (ARM, ARM64) tests + Nexus 5X boot.\nBug: 29516905\nBug: 29506760\nBug: 12687968\nChange-Id: I85431368d09965687a0301ae2eb3c991f276ce5d\n" }, { "commit": "ac152079c6ec514a4c0c03d2d0246fd4dec82d11", "tree": "bda2a4f773b0c96f11eff9e97d74865bb33522eb", "parents": [ "20b975cc5c5a1f4e6f0a8e525b5d2e63abc413df", "806f0122e923581f559043e82cf958bab5defc87" ], "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Thu Aug 04 22:05:54 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Aug 04 22:05:54 2016 +0000" }, "message": "Merge \"Add support for CallKind::kCallOnMainAndSlowPath\"" }, { "commit": "965c0b9f98a4acbec7be148291196e30784bba2d", "tree": "c9b53c36226535f2941d47a1ea222da114266680", "parents": [ "2e98023165349ab91855555f63fed8dad3c471fe", "952dbb19cd094b8bfb01dbb33e0878db429e499a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 04 14:44:10 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Aug 04 14:44:10 2016 +0000" }, "message": "Merge \"Change suspend entrypoint to save all registers.\"" }, { "commit": "952dbb19cd094b8bfb01dbb33e0878db429e499a", "tree": "82932c2b00245042e2c129f3d4133f6431657da3", "parents": [ "df638c66d1f385d4e217b2ab22c5e48a7eefdef4" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jul 28 12:01:51 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Aug 04 14:51:52 2016 +0100" }, "message": "Change suspend entrypoint to save all registers.\n\nWe avoid the need to save/restore registers in slow paths\nand get significant code size savings. On Nexus 9, AOSP:\n - 32-bit boot.oat: -1.4MiB (-1.9%)\n - 64-bit boot.oat: -2.0MiB (-2.3%)\n - other 32-bit oat files in dalvik-cache: -200KiB (-1.7%)\n - other 64-bit oat files in dalvik-cache: -2.3MiB (-2.1%)\n\nTest: Run ART test suite on host and Nexus 9 with gc stress.\nBug: 30212852\nChange-Id: I7015afc1e7d30341618c9200a3dc9ae277afd134\n" }, { "commit": "542451cc546779f5c67840e105c51205a1b0a8fd", "tree": "11e09bb5abaee12dddffefbe7e425291076dfa7a", "parents": [ "85c4a4b8c9eabfe16e4e49f9b4aa78c1bf4be023" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Tue Jul 26 09:02:02 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Aug 01 18:54:48 2016 -0700" }, "message": "ART: Convert pointer size to enum\n\nMove away from size_t to dedicated enum (class).\n\nBug: 30373134\nBug: 30419309\nTest: m test-art-host\nChange-Id: Id453c330f1065012e7d4f9fc24ac477cc9bb9269\n" }, { "commit": "806f0122e923581f559043e82cf958bab5defc87", "tree": "c297dd93b213ce174558f7b63ead3f174ff1a90c", "parents": [ "c4aa8961819c78a0fb2ed342ed374d4aaeb4255c" ], "author": { "name": "Serban Constantinescu", "email": "serban.constantinescu@linaro.org", "time": "Wed Mar 09 11:10:16 2016 +0000" }, "committer": { "name": "Serban Constantinescu", "email": "serban.constantinescu@linaro.org", "time": "Mon Jul 25 14:10:37 2016 +0100" }, "message": "Add support for CallKind::kCallOnMainAndSlowPath\n\nSome of the intrinsics call on both the main and slowpath. This patch\nadds support for such a CallKind and marks the intrinsics accordingly.\n\nThis will be exercised by a later patch that refactors all the runtime\ncalls to use InvokeRuntime().\n\nPlease note that without this patch, the calls to ValidateInvokeRuntime()\nexercised by the following patches would fail.\n\nChange-Id: I450571b8b47280a004b714996189ba6db13fb57d\n" }, { "commit": "dec8f63fdf50815f24efe1c03af64208da15f339", "tree": "36c8dec8c2c93312d17c6d9d1452d4b133212dbd", "parents": [ "41c7e2e6ac0a59da2f3e066e20630b295fbe4661" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jul 22 17:10:06 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Fri Jul 22 18:54:35 2016 +0100" }, "message": "Do not emit stack maps for runtime calls to ReadBarrierMarkRegX.\n\n* Boot image code size variation on Nexus 5X\n (aosp_bullhead-userdebug build):\n - total ARM64 framework Oat files size change:\n 115584120 bytes -\u003e 109124728 bytes (-5.59%)\n - total ARM framework Oat files size change:\n 97387728 bytes -\u003e 92517584 (-5.00%)\n\nTest: ART host and target (ARM, ARM64) tests.\nBug: 29506760\nBug: 12687968\nChange-Id: I979d9fb2b4e09f4c0c7bf33af2cd91750a67f989\n" }, { "commit": "68bd9b9b165ffca1a49b80bb437ce9f87b738264", "tree": "671bb60203157fdb34dd2e9cdf851cb79eb02a0e", "parents": [ "173f435e56acfd0501fc460747572a4796dcffe0" ], "author": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Fri Jul 15 17:41:13 2016 +0100" }, "committer": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Mon Jul 18 11:25:19 2016 +0100" }, "message": "ARM64: Improve code generated to spill/restore for slow paths.\n\nAligning the accesses allows generating better code.\n\nBefore:\n\n add x16, sp, #0x44 (68)\n stp x0, x1, [x16, #-16]\n\nAfter:\n\n stp x0, x1, [sp, #56]\n\nChange-Id: I3e20ad3fa59d00aee4b4d14ea9d59c7cd546509e\n" }, { "commit": "54ff482710910929900f8348a19c5b875e519237", "tree": "82667795ef43a33a87a585f9bc841c88ff3460f1", "parents": [ "2e7acaffda05db1df6e0631468f10726e898a20a" ], "author": { "name": "Serban Constantinescu", "email": "serban.constantinescu@linaro.org", "time": "Thu Jul 07 18:03:19 2016 +0100" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Mon Jul 11 17:59:29 2016 +0000" }, "message": "Rename kCall to kCallOnMainOnly\n\nThis patch renames kCall to kCallOnMainOnly in preparation for\nthe next patch in this series which will be adding kCallOnMainAndSlowPath.\n\nNote: With this patch there will be places where we use kCallOnMainOnly\neven though we call on the slow path too. The next patch in this series\nwill fix that.\n\nTest: ART host tests.\nChange-Id: Iabfdb0901990d163be5d780f3bdd2fab6fa17b32\n" }, { "commit": "e90049140fdfb89080e5cc9b000b0c9be8c18bcd", "tree": "66b45c052b6778fabd7847a44af5e610808fa867", "parents": [ "a77ceae14a7be2494874d9256327efa8c522e234" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 16 16:50:52 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Fri Jul 01 13:26:24 2016 +0100" }, "message": "Create a typedef for HInstruction::GetInputs() return type.\n\nAnd some other cleanup after\n https://android-review.googlesource.com/230742\n\nTest: No new tests. ART test suite passed (tested on host).\nChange-Id: I4743bf17544d0234c6ccb46dd0c1b9aae5c93e17\n" }, { "commit": "87f3fcbd0db352157fc59148e94647ef21b73bce", "tree": "5bdeabb246f5de86704333b3fcbccc6e9146d246", "parents": [ "b94b5706f0b8e2e1c7e1db22274f9f4bae0c4b5a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Apr 28 15:52:11 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Jun 21 15:17:38 2016 +0100" }, "message": "Replace String.charAt() with HIR.\n\nReplace String.charAt() with HArrayLength, HBoundsCheck and\nHArrayGet. This allows GVN on the HArrayLength and BCE on\nthe HBoundsCheck as well as using the infrastructure for\nHArrayGet, i.e. better handling of constant indexes than\nthe old intrinsic and using the HArm64IntermediateAddress.\n\nBug: 28330359\nChange-Id: I32bf1da7eeafe82537a60416abf6ac412baa80dc\n" }, { "commit": "372f10e5b0b34e2bb6e2b79aeba6c441e14afd1f", "tree": "1f29c2467c8909ef0e0147f37f176caa1bcd2ccc", "parents": [ "1b66fdf3f33c72dfdda4d31f6f17b6a0d8607402" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue May 17 16:30:10 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Jun 02 19:04:20 2016 +0100" }, "message": "Refactor handling of input records.\n\nIntroduce HInstruction::GetInputRecords(), a new virtual\nfunction that returns an ArrayRef\u003c\u003e to all input records.\nImplement all other functions dealing with input records as\nwrappers around GetInputRecords(). Rewrite functions that\npreviously used multiple virtual calls to deal with input\nrecords, especially in loops, to prefetch the ArrayRef\u003c\u003e\nonly once for each instruction. Besides avoiding all the\nextra calls, this also allows the compiler (clang++) to\nperform additional optimizations.\n\nThis speeds up the Nexus 5 boot image compilation by ~0.5s\n(4% of \"Compile Dex File\", 2% of dex2oat time) on AOSP ToT.\n\nChange-Id: Id8ebe0fb9405e38d918972a11bd724146e4ca578\n" }, { "commit": "288c7a8664e516d7486ab85267050e676e84cc39", "tree": "8c117fcb348daf29477e1eb1338de9bc3c1dc706", "parents": [ "fbb0323d801cd14fb04eb4af7e88792d7cca8de3" ], "author": { "name": "Serguei Katkov", "email": "serguei.i.katkov@intel.com", "time": "Mon May 16 11:53:15 2016 +0600" }, "committer": { "name": "Serguei Katkov", "email": "serguei.i.katkov@intel.com", "time": "Mon May 16 13:32:43 2016 +0600" }, "message": "Revert \"Revert \"ART: Reference.getReferent intrinsic for x86 and x86_64\"\"\n\nThis reverts commit 0997d24e67d78f2146ebae2888eda0d7d254789a.\n\nART_HEAP_POISONING\u003dtrue mode is fixed.\n\nChange-Id: I83f6d5c101ea6a86802753f81b3e4348a263fb21\nSigned-off-by: Serguei Katkov \u003cserguei.i.katkov@intel.com\u003e\n" }, { "commit": "628f2017fcc64352a2297a802c10ea7100fbd74b", "tree": "982bf345d7b937755bd9f82ff66d139c1cce79ba", "parents": [ "893a1d36aec93fabb85ea4a6d4f45019046a6b74", "0997d24e67d78f2146ebae2888eda0d7d254789a" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri May 13 09:30:18 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri May 13 09:30:18 2016 +0000" }, "message": "Merge \"Revert \"ART: Reference.getReferent intrinsic for x86 and x86_64\"\"" }, { "commit": "0997d24e67d78f2146ebae2888eda0d7d254789a", "tree": "8b521397c856259c9049b52d86e40bfd2c84f0f4", "parents": [ "afdc97ebcb4e58afb7cf54d846d30314e6499d83" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri May 13 09:29:01 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri May 13 09:29:01 2016 +0000" }, "message": "Revert \"ART: Reference.getReferent intrinsic for x86 and x86_64\"\n\nFails heap poisoning configuration.\n\nThis reverts commit afdc97ebcb4e58afb7cf54d846d30314e6499d83.\n\nChange-Id: I50e53756a2b85059b89cfb8950f8c9e2b032743c\n" }, { "commit": "4478ae4fcb3337f094815d40273ec0ba32a2d7af", "tree": "0ace818ca85307a33e439b42e362ed180b54178f", "parents": [ "af4bcdf49e014ededa9e71e425dac761697dac8d", "afdc97ebcb4e58afb7cf54d846d30314e6499d83" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Thu May 12 15:28:38 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu May 12 15:28:38 2016 +0000" }, "message": "Merge \"ART: Reference.getReferent intrinsic for x86 and x86_64\"" }, { "commit": "afdc97ebcb4e58afb7cf54d846d30314e6499d83", "tree": "bd7db3f73405d3d302f9f5021ffe2d424a7e8153", "parents": [ "3b62593ba55f6bdb37ca84f64930654ff4f09464" ], "author": { "name": "Serguei Katkov", "email": "serguei.i.katkov@intel.com", "time": "Thu May 05 13:42:59 2016 +0600" }, "committer": { "name": "Serguei Katkov", "email": "serguei.i.katkov@intel.com", "time": "Tue May 10 11:35:08 2016 +0600" }, "message": "ART: Reference.getReferent intrinsic for x86 and x86_64\n\nChange-Id: I7a7ac9244847dd80d9fa4e4b5ebc5bf451c628ff\nSigned-off-by: Serguei Katkov \u003cserguei.i.katkov@intel.com\u003e\n" }, { "commit": "dce016eab87302f02b0bd903dd2cd86ae512df2d", "tree": "3af3c0e6b9d845e611b560484882e6b438ef439a", "parents": [ "a246510965fc57ec51d1b202649304535adfe9f3" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Apr 28 13:10:02 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon May 09 20:40:32 2016 +0100" }, "message": "Intrinsify String.length() and String.isEmpty() as HIR.\n\nUse HArrayLength for String.length() in anticipation of\nchanging the String.charAt() to HBoundsCheck+HArrayGet to\nallow the existing BCE to seamlessly work for strings.\nUse HArrayLength+HEqual for String.isEmpty().\n\nWe previously relied on inlining but we now want to apply\nthe new intrinsics even when we do not inline, i.e. when\ncompiling debuggable (as is currently the case for boot\nimage) or when we hit inlining limits, i.e. depth, size,\nor the number of accumulated dex registers.\n\nBug: 28330359\nChange-Id: Iab9d2f6d2967bdd930a72eb461f27efe8f37c103\n" }, { "commit": "c01a66465a398ad15da90ab2bdc35b7f4a609b17", "tree": "e85cb2aa05be5c1491814fa83b94748439b8394b", "parents": [ "dad35b0762f97ce79ce3b9a35c9df5021b7dbd17" ], "author": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Fri Apr 15 11:54:06 2016 +0100" }, "committer": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Fri Apr 15 11:54:06 2016 +0100" }, "message": "Fix: correctly destruct VIXL labels.\n\nBug: 27505766\nChange-Id: I077465e3d308f4331e7a861902e05865f9d99835" }, { "commit": "d58b837ae41c6d8ce010c362e8f85bd938715900", "tree": "a7c8e90ff825838bb27707d14487c0333f2cc5f6", "parents": [ "ec9a828fa4a4638d2d17124c4fa835f15c7c5589" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Apr 12 18:51:43 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Apr 12 21:04:13 2016 +0100" }, "message": "Allocate code generators on the arena.\n\nChange-Id: If8cf0ee43711f6e13171443e3c057ff370ccfbaa\n" }, { "commit": "dee58d6bb6d567fcd0c4f39d8d690c3acaf0e432", "tree": "5a2f20546ca3c1544c44bee560062580e22dc79c", "parents": [ "391e155a6936a05bd39b171031ec21d2dee62133" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Apr 07 09:54:26 2016 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Apr 07 16:03:16 2016 +0000" }, "message": "Revert \"Revert \"Refactor HGraphBuilder and SsaBuilder to remove HLocals\"\"\n\nThis patch merges the instruction-building phases from HGraphBuilder\nand SsaBuilder into a single HInstructionBuilder class. As a result,\nit is not necessary to generate HLocal, HLoadLocal and HStoreLocal\ninstructions any more, as the builder produces SSA form directly.\n\nSaves 5-15% of arena-allocated memory (see bug for more data):\n GMS 20.46MB \u003d\u003e 19.26MB (-5.86%)\n Maps 24.12MB \u003d\u003e 21.47MB (-10.98%)\n YouTube 28.60MB \u003d\u003e 26.01MB (-9.05%)\n\nThis CL fixed an issue with parsing quickened instructions.\n\nBug: 27894376\nBug: 27998571\nBug: 27995065\n\nChange-Id: I20dbe1bf2d0fe296377478db98cb86cba695e694\n" }, { "commit": "75563e34a4e64a8e805e6810b13e07f1cafec137", "tree": "30bc7341b8b2c49e0fc56f783de86777abada138", "parents": [ "a07be75830af60ce50aba357e8de066e849aa21c", "9d07e3d128ccfa0ef7670feadd424a825e447d1d" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Tue Apr 05 09:23:52 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Apr 05 09:23:53 2016 +0000" }, "message": "Merge \"Clean up OatQuickMethodHeader after Quick removal.\"" }, { "commit": "60328910cad396589474f8513391ba733d19390b", "tree": "01702f6df5c39925b354a3152dd04289e7d97062", "parents": [ "e3ff7b293be2a6791fe9d135d660c0cffe4bd73f" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Apr 04 17:47:42 2016 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Apr 04 17:47:42 2016 +0000" }, "message": "Revert \"Refactor HGraphBuilder and SsaBuilder to remove HLocals\"\n\nBug: 27995065\nThis reverts commit e3ff7b293be2a6791fe9d135d660c0cffe4bd73f.\n\nChange-Id: I5363c7ce18f47fd422c15eed5423a345a57249d8\n" }, { "commit": "9d07e3d128ccfa0ef7670feadd424a825e447d1d", "tree": "dfb677fd75f0f297fef9bc49311cf1d22c770f56", "parents": [ "eb98c0ded592cfca8187c744393c82efd1020b2a" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Thu Mar 31 12:02:28 2016 +0100" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Apr 04 17:50:20 2016 +0100" }, "message": "Clean up OatQuickMethodHeader after Quick removal.\n\nThis reduces the size of the pre-header by 8 bytes, reducing\noat file size and mmapped .text section size. The memory\nneeded to store a CompiledMethod by dex2oat is also reduced,\nfor 32-bit dex2oat by 8B and for 64-bit dex2oat by 16B. The\naosp_flounder-userdebug 32-bit and 64-bit boot.oat are each\nabout 1.1MiB smaller.\n\nDisable the broken StubTest.IMT, b/27991555 .\n\nChange-Id: I05fe45c28c8ffb7a0fa8b1117b969786748b1039\n" }, { "commit": "e3ff7b293be2a6791fe9d135d660c0cffe4bd73f", "tree": "d578d27cb78e6d2caef683cd8ac94c9a9752b192", "parents": [ "86ea7eeabe30c98bbe1651a51d03cb89776724e7" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Wed Mar 02 16:48:20 2016 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Apr 04 11:21:30 2016 +0100" }, "message": "Refactor HGraphBuilder and SsaBuilder to remove HLocals\n\nThis patch merges the instruction-building phases from HGraphBuilder\nand SsaBuilder into a single HInstructionBuilder class. As a result,\nit is not necessary to generate HLocal, HLoadLocal and HStoreLocal\ninstructions any more, as the builder produces SSA form directly.\n\nSaves 5-15% of arena-allocated memory (see bug for more data):\n GMS 20.46MB \u003d\u003e 19.26MB (-5.86%)\n Maps 24.12MB \u003d\u003e 21.47MB (-10.98%)\n YouTube 28.60MB \u003d\u003e 26.01MB (-9.05%)\n\nBug: 27894376\nChange-Id: Iefe28d40600c169c5d306fd2c77034ae19476d90\n" }, { "commit": "86ea7eeabe30c98bbe1651a51d03cb89776724e7", "tree": "01702f6df5c39925b354a3152dd04289e7d97062", "parents": [ "0cb5c86b7021e70cbf584c1455aad1ef383af786" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Feb 16 09:26:07 2016 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Apr 04 11:21:20 2016 +0100" }, "message": "Build dominator tree before generating HInstructions\n\nSecond CL in the series of merging HGraphBuilder and SsaBuilder. This\npatch refactors the builders so that dominator tree can be built\nbefore any HInstructions are generated. This puts the SsaBuilder\nremoval of HLoadLocals/HStoreLocals straight after HGraphBuilder\u0027s\nHInstruction generation phase. Next CL will therefore be able to\nmerge them.\n\nThis patch also adds util classes for iterating bytecode and switch\ntables which allowed to simplify the code.\n\nBug: 27894376\nChange-Id: Ic425d298b2e6e7980481ed697230b1a0b7904526\n" }, { "commit": "fe2b13717879abae993603534a145372e3110aae", "tree": "5b499eb28af5e91e00ff86683f51df029a2b86b4", "parents": [ "5c26e430fbeaf56e3a5da4e3f167ff35fbb71ef9", "09ed09866da6d8c7448ef297c148bfa577a247c2" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Fri Apr 01 12:28:51 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Apr 01 12:28:51 2016 +0000" }, "message": "Merge \"Pack stack map entries on bit level to save space.\"" }, { "commit": "09ed09866da6d8c7448ef297c148bfa577a247c2", "tree": "dad6a5dae6ca6131f1eba201eaa371edc6d9929d", "parents": [ "e28ad4b91591c226ed404a2b01104bb99bfeb28f" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Feb 12 21:58:43 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Mar 31 22:12:07 2016 +0100" }, "message": "Pack stack map entries on bit level to save space.\n\nUse only the minimum number of bits required to store stack map data.\nFor example, if native_pc needs 5 bits and dex_pc needs 3 bits, they\nwill share the first byte of the stack map entry.\n\nThe header is changed to store bit offsets of the fields rather than\nbyte sizes. Offsets also make it easier to access later fields without\ncalculating sum of all previous sizes.\n\nAll of the header fields are byte sized or encoded as ULEB128 instead\nof the previous fixed size encoding. This shrinks it by about half.\n\nIt saves 3.6 MB from non-debuggable boot.oat (AOSP).\nIt saves 3.1 MB from debuggable boot.oat (AOSP).\n\nIt saves 2.8 MB (of 99.4 MB) from /system/framework/arm/ (GOOG).\nIt saves 1.0 MB (of 27.8 MB) from /system/framework/oat/arm/ (GOOG).\n\nField loads from stackmaps seem to get around 10% faster.\n(based on the time it takes to load all stackmap entries from boot.oat)\n\nBug: 27640410\nChange-Id: I8bf0996b4eb24300c1b0dfc6e9d99fe85d04a1b7\n" }, { "commit": "bf9611f821697b14bf9e170f503c3f47613b046b", "tree": "c5d6de40e988c1d92f51639243443b225e45808f", "parents": [ "782d0464ddc92fd5d55a330068d2d255336c16ba" ], "author": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Fri Mar 25 16:58:00 2016 -0700" }, "committer": { "name": "Andreas Gampe", "email": "agampe@google.com", "time": "Mon Mar 28 15:51:07 2016 -0700" }, "message": "ART: Clean up verifier\n\nClean up verifier post-Quick.\n\nChange-Id: I0b05e10dd06edd228fe2068c8afffc4b7d7fdffa\n" }, { "commit": "f6a35de9eeefb20f6446f1b4815b4dcb0161d09c", "tree": "cf484acbd6889b92a7fe3e8615611129088c3894", "parents": [ "459898dc4470559ba1e1d578bc52a914d1f573f5" ], "author": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 21 12:01:50 2016 +0000" }, "committer": { "name": "Vladimir Marko", "email": "vmarko@google.com", "time": "Mon Mar 21 16:50:08 2016 +0000" }, "message": "Optimizing: Fix register allocator validation memory usage.\n\nAlso attribute ArenaBitVector allocations to appropriate\npasses. This was used to track down the source of the\nexcessive memory alloactions.\n\nBug: 27690481\n\nChange-Id: Ib895984cb7c04e24cbc7abbd8322079bab8ab100\n" }, { "commit": "e943c3b831dc0da4a6b09e940ae25c3285850e96", "tree": "b4756bbc16f49d50087a881b40722657451e6eac", "parents": [ "7c06aef061fa176331b77a88c1ff2c6ae401a5f0", "d28f4a00933a4a3b8d5e9db73b8532924d0f989d" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Mar 18 12:37:03 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Mar 18 12:37:03 2016 +0000" }, "message": "Merge \"Generate native debug stackmaps before calls as well.\"" }, { "commit": "d28f4a00933a4a3b8d5e9db73b8532924d0f989d", "tree": "1205844a68ee9e2c502f8ecbfd2d5cf96acd4190", "parents": [ "fbc61e19578d281d05728bcd120e1ace57c2fbd8" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Mar 14 17:14:24 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Mar 17 16:58:55 2016 +0000" }, "message": "Generate native debug stackmaps before calls as well.\n\nThe debugger looks up PC of the call instruction, so the runtime\u0027s\nstackmap is not sufficient since it is at PC after the instruction.\n\nChange-Id: I0dd06c0b52e8079ea5d064ea10beb12c93584092\n" }, { "commit": "914d71ead70bb6f2084b2ed39a9fd58fd014f67d", "tree": "50f30d6e47d18aa6c3ccec9f05727b4898268b20", "parents": [ "1583e624d4c970d8e571b265b9a8f08402d91f82", "2ae48182573da7087bffc2873730bc758ec29696" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed Mar 16 14:40:08 2016 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Wed Mar 16 14:40:08 2016 +0000" }, "message": "Merge \"Clean up NullCheck generation and record stats about it.\"" }, { "commit": "2ae48182573da7087bffc2873730bc758ec29696", "tree": "d6955329ad876aefd477f7ef8905b070b9ab95dd", "parents": [ "6915898b28cea6c9836ca1be6814d87e89cc6d76" ], "author": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed Mar 16 14:05:09 2016 +0000" }, "committer": { "name": "Calin Juravle", "email": "calin@google.com", "time": "Wed Mar 16 14:10:27 2016 +0000" }, "message": "Clean up NullCheck generation and record stats about it.\n\nThis removes redundant code from the generators and allows for easier\nstat recording.\n\nChange-Id: Iccd4368f9e9d87a6fecb863dee4e2145c97851c4\n" }, { "commit": "1693a1f9c83a0bf5a29fa18ddc2d87e04e049233", "tree": "ab8d99220352e3f6ce2501963ba81943089f0df5", "parents": [ "51b7e2d08f2bcf528eeec48b42c178b5550f6635" ], "author": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Mar 15 14:57:31 2016 +0000" }, "committer": { "name": "Roland Levillain", "email": "rpl@google.com", "time": "Tue Mar 15 14:57:31 2016 +0000" }, "message": "Make art::HCompare side effect free.\n\nAll our back ends implement all comparisons without making a\nruntime call, so we can mark art::HCompare as a side effect\nfree instruction unconditionally.\n\nChange-Id: I9a9e7c09156c642edb6af1fe84408f887e762f2e\n" }, { "commit": "d1c4045fb4d4703642f3f79985727b9a12cf5c49", "tree": "5fda881ed412b71013e1f2445ed5ddd1a7b37470", "parents": [ "2048b01dfec8877d672a4da41a158f68b12b5337" ], "author": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Wed Mar 02 16:06:13 2016 -0800" }, "committer": { "name": "Aart Bik", "email": "ajcbik@google.com", "time": "Thu Mar 10 09:22:49 2016 -0800" }, "message": "Avoid generating dead code on frame enter/exit.\nThis includes stack operations and, on x86, call/pop to read PC.\n\nbug\u003d26997690\n\nRationale:\n(1) If method is fully intrinsified, and makes no calls in slow\n path or uses special input, no need to require current method.\n(2) Invoke instructions with HasPcRelativeDexCache() generate code\n that reads the PC (call/pop) on x86. However, if the invoke is\n an intrinsic that is later replaced with actual code, this PC\n reading code may be dead.\n\nExample X86 (before/after):\n\n0x0000108c: 83EC0C sub esp, 12\n0x0000108f: 890424 mov [esp], eax \u003c-- not needed\n0x00001092: E800000000 call +0 (0x00001097)\n0x00001097: 58 pop eax \u003c-- dead code to read PC\n0x00001098: F30FB8C1 popcnt eax, ecx\n0x0000109c: F30FB8DA popcnt ebx, edx\n0x000010a0: 03D8 add ebx, eax\n0x000010a2: 89D8 mov eax, ebx\n0x000010a4: 83C40C add esp, 12 \u003c-- not needed\n0x000010a7: C3 ret\n\n0x0000103c: F30FB8C1 popcnt eax, ecx\n0x00001040: F30FB8DA popcnt ebx, edx\n0x00001044: 03D8 add ebx, eax\n0x00001046: 89D8 mov eax, ebx\n0x00001048: C3 ret\n\nExample ARM64 (before/after):\n\n0x0000103c: f81e0fe0 str x0, [sp, #-32]!\n0x00001040: f9000ffe str lr, [sp, #24]\n0x00001044: dac01020 clz x0, x1\n0x00001048: f9400ffe ldr lr, [sp, #24]\n0x0000104c: 910083ff add sp, sp, #0x20 (32)\n0x00001050: d65f03c0 ret\n\n0x0000103c: dac01020 clz x0, x1\n0x00001040: d65f03c0 ret\n\nChange-Id: I8377db80c9a901a08fff4624927cf4a6e585da0c\n" }, { "commit": "9cd6d378bd573cdc14d049d32bdd22a97fa4d84a", "tree": "be293c89806b919143b7dcd203bae14f5f4eaf04", "parents": [ "0e02ee9efbf1dbdde05d2b10f7307bbe191c52f5" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Feb 09 15:24:47 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Feb 24 10:25:29 2016 +0000" }, "message": "Associate slow paths with the instruction that they belong to.\n\nAlmost all slow paths already know the instruction they belong to,\nthis CL just moves the knowledge to the base class as well.\n\nThis is needed to be be able to get the corresponding dex pc for\nslow path, which allows us generate better native line numbers,\nwhich in turn fixes some native debugging stepping issues.\n\nChange-Id: I568dbe78a7cea6a43a4a71a014b3ad135782c270\n" }, { "commit": "c7098ff991bb4e00a800d315d1c36f52a9cb0149", "tree": "3a150e927bc7f4894f5b148ec6f5a2b796cdd80d", "parents": [ "5322e55ab9a15996a197456ca39d9c77488cd5c1" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Feb 09 14:30:11 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Wed Feb 24 10:21:57 2016 +0000" }, "message": "Remove HNativeDebugInfo from start of basic blocks.\n\nWe do not require full environment at the start of basic block.\nThe dex pc contained in basic block is sufficient for line mapping.\n\nChange-Id: I5ba9e5f5acbc4a783ad544769f9a73bb33e2bafa\n" }, { "commit": "6e332529c33be4d7dae5dad3609a839f4c0d3bfc", "tree": "cedd2e1beb170fd5821136fe974e3f34adfcddc2", "parents": [ "d3caabd4f85f86dd744da432993e12935d843a83" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Tue Feb 02 16:15:27 2016 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Fri Feb 12 15:17:50 2016 +0000" }, "message": "ART: Remove HTemporary\n\nChange-Id: I21b984224370a9ce7a4a13a9652503cfb03c5f03\n" }, { "commit": "b331febbab8e916680faba722cc84b66b84218a3", "tree": "35f985b021e476914bfe91492da23fee218014a7", "parents": [ "586996afc905518ed926e4680aab67bedabec9b7" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 16:51:53 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Feb 05 17:11:54 2016 +0000" }, "message": "Revert \"Revert \"Implement on-stack replacement for arm/arm64/x86/x86_64.\"\"\n\nThis reverts commit bd89a5c556324062b7d841843b039392e84cfaf4.\n\nChange-Id: I08d190431520baa7fcec8fbdb444519f25ac8d44\n" }, { "commit": "58282f4510961317b8d5a364a6f740a78926716f", "tree": "5d97c0db9fe01dd6e8df2357ef11f614abb853e8", "parents": [ "b8bb9f6d0b59be125066f604f134155f8998f5ae" ], "author": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Thu Jan 14 12:45:10 2016 +0000" }, "committer": { "name": "David Brazdil", "email": "dbrazdil@google.com", "time": "Mon Jan 18 16:39:30 2016 +0000" }, "message": "ART: Remove Baseline compiler\n\nWe don\u0027t need Baseline any more and it hasn\u0027t been maintained for\na while anyway. Let\u0027s remove it.\n\nChange-Id: I442ed26855527be2df3c79935403a25b1ee55df6\n" }, { "commit": "780aeced2a8ef918901d8f450864de934f79c555", "tree": "0e91880137f2a5cffad2ead46d1b917bd523ae47", "parents": [ "a38e418fb2d9b817309c54b54ca85039907c2bbb" ], "author": { "name": "Alexandre Rames", "email": "alexandre.rames@linaro.org", "time": "Wed Jan 13 14:34:39 2016 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Wed Jan 13 15:00:44 2016 +0000" }, "message": "Update `ValidateInvokeRuntime()` and HDivZeroCheck.\n\nChange-Id: I35beab2777a8c83bd508d56966afa1ceff9ee24f\n" }, { "commit": "b7070a2db8b0b7eca14f01f932be305be64ded57", "tree": "06ba87d56a708712fb206e23d3abd55f21934373", "parents": [ "ae6f23c83e1c8dcfbc4f74186ea1a37f1044414b" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Fri Jan 08 18:13:53 2016 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Mon Jan 11 12:22:17 2016 +0000" }, "message": "Generate Nops to ensure that debug stack maps have distinct PC.\n\nChange-Id: I5740ec958a20d236634b66df0e675382ed5c16fc\n" }, { "commit": "f71b3ade9c99ce2fec2f5049ce9c5968721e1b81", "tree": "fcda284846a6a468e39aec2783812d2d1129a35e", "parents": [ "d48015603a54b820d287d92709825765159615f0" ], "author": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Tue Dec 08 15:05:08 2015 +0000" }, "committer": { "name": "David Srbecky", "email": "dsrbecky@google.com", "time": "Thu Dec 10 16:18:54 2015 +0000" }, "message": "Get source mapping table from stack maps.\n\nStack maps contain pc to dex mapping.\nReuse them instead of maintaining separate map.\n\nChange-Id: Iaaec9a6bd2603eace1dfc8f4344087883d88cce3\n" } ], "next": "c53c0797a78a89d637e4230503cc1feb27e855a8" }