)]}' { "log": [ { "commit": "73c4f79b14492a930903f15553969a4e7ecbefed", "tree": "72ca8780c8d2584d344d1c01a0205a706f262338", "parents": [ "507cf9052116f8052c45a08586a356d00daba563" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Oct 01 18:13:52 2021 +0000" }, "committer": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Oct 08 17:38:21 2021 +0000" }, "message": "Reland^2: Create an abstraction for dexopt tasks\n\nCause of the revert / broken test:\n\nbuildbot-build.sh does not build libbinder_ndk.so. Add the missing\ndependency to copy to the chroot.\n\nOriginal message:\n\nInstead of letting odrefresh building dex2oat cmdline arguments, hide\nthe specifics of cmdline flags behind an API abstraction. The API\ndefines the only necessary parameters for the actual dexopt task (e.g.\ncompiling BCP extension, system server) to proceed. The introduced API\nis private within ART.\n\nlibdexopt.so is created to contain the API and implementation. It is put\nunder art/artd/ in the sense that the future ART services can reuse and\nevolve the code.\n\nThis change should not have any effective change to the compilation\nresults. Given the large size of the change, the dex2oat cmdline is\npurposely ordered in the same way as before. The compiled artifacts\nshould not change at all.\n\nAlso, art_odrefresh_test is no longer built for the \"second\" ABI. This\nis to make it consistent to odrefresh, so that we won\u0027t need to test\nunused variation and build \"second\" for the dependencies.\n\nBug: 193668901\nTest: 1. Revert this change, run `odrefresh --force-compile`, capture\n\t the checksum of all output files.\n 2. Apply this change, repeat the same step.\n 3. Saw all the file hashes remain the same (except for\n\t cache-info.xml where the timestamp changed).\nTest: atest ComposHostTestCases\nTest: atest odsign_e2e_tests\nTest: atest art_standalone_odrefresh_tests\nTest: art/build/apex/runtests.sh\nTest: lunch full-eng; m; art/build/apex/runtests.sh\nTest: with master-art, art/tools/run-gtests.sh \\\n /apex/com.android.art/bin/art/arm64/art_odrefresh_tests\nTest: TH\n\nChange-Id: I3bf805fba925c197ec10508a67f0a16e74d64c62\n" }, { "commit": "4aaf6958e95a869d6677e0a07ebdd79bb77de507", "tree": "ea3a94705c3bc5dbacd60ed52ca8302755e8c7f9", "parents": [ "139a5b991f0b4825829cccd21dc666fb9f386728" ], "author": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Oct 01 07:21:12 2021 +0000" }, "committer": { "name": "Nicolas Geoffray", "email": "ngeoffray@google.com", "time": "Fri Oct 01 08:44:44 2021 +0000" }, "message": "Revert \"Create an abstraction for dexopt tasks\"\n\nThis reverts commit 6221e67f136c5d766273029b0175f42de80eaaf3.\n\nBug: 193668901\n\nReason for revert: Still failing art_odrefresh_tests\n\nChange-Id: Ia521b4e4b560004186fdd46d8291ebc51cc526ed\n" }, { "commit": "6221e67f136c5d766273029b0175f42de80eaaf3", "tree": "cff79c4e30d22acd0d6caeb60f2da2f94ca5e65a", "parents": [ "52f7f63d8deb64a4d24530c9ce8d53ddf67c637c" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Sep 10 11:17:55 2021 -0700" }, "committer": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Thu Sep 30 15:26:00 2021 -0700" }, "message": "Create an abstraction for dexopt tasks\n\nInstead of letting odrefresh building dex2oat cmdline arguments, hide\nthe specifics of cmdline flags behind an API abstraction. The API\ndefines the only necessary parameters for the actual dexopt task (e.g.\ncompiling BCP extension, system server) to proceed. The introduced API\nis private within ART.\n\nlibdexopt.so is created to contain the API and implementation. It is put\nunder art/artd/ in the sense that the future ART services can reuse and\nevolve the code.\n\nThis change should not have any effective change to the compilation\nresults. Given the large size of the change, the dex2oat cmdline is\npurposely ordered in the same way as before. The compiled artifacts\nshould not change at all.\n\nAlso, art_odrefresh_test is no longer built for the \"second\" ABI. This\nis to make it consistent to odrefresh, so that we won\u0027t need to test\nunused variation and build \"second\" for the dependencies.\n\nBug: 193668901\nTest: 1. Revert this change, run `odrefresh --force-compile`, capture\n the checksum of all output files.\n 2. Apply this change, repeat the same step.\n 3. Saw all the file hashes remain the same (except for\n cache-info.xml where the timestamp changed).\nTest: atest ComposHostTestCases\nTest: atest odsign_e2e_tests\nTest: atest art_standalone_odrefresh_tests\nTest: art/build/apex/runtests.sh\nTest: lunch full-eng; m; art/build/apex/runtests.sh\nTest: TH\nChange-Id: Id418ebd142e0610a307956a846586e9c0659ae93\n" }, { "commit": "617c6abeff925b55808df8c8f01888545cd3908c", "tree": "82dadd94a743e8631e3dec52e33212ccde43c676", "parents": [ "9c00c65380580506e6990eae9479165f148928b1" ], "author": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Fri Sep 24 05:06:07 2021 +0000" }, "committer": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Mon Sep 27 11:38:22 2021 +0000" }, "message": "Loosen the SDK requirement of a test case in OdRefreshTest.\n\nOdRefreshTest.CompileSetsCompilerFilterForSystemServer has a check that\nskips the test case when the SDK version is lower then 31. However,\nAndroid S (SDK level 31) has not been pushed to AOSP, causing the test\nto be skipped on AOSP. This change lowers the min SDK version to 30.\n\nBug: 196188549\nTest: atest art_standalone_odrefresh_tests\nChange-Id: If268782e147091bf9c4613b57811d63154618484\n" }, { "commit": "d7506309377250d7eb3202c2b01711a94b4aa989", "tree": "804c2a605a0aed384f10ff809d3967afaca568ec", "parents": [ "c8878164931624a8f602551994e52a59183b4bc0" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Sep 24 17:08:23 2021 +0000" }, "committer": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Sep 24 17:08:23 2021 +0000" }, "message": "Revert \"Create an abstraction for dexopt tasks\"\n\nThis reverts commit c8878164931624a8f602551994e52a59183b4bc0.\n\nReason for revert: broken build\n\nBug: 193668901\nChange-Id: Ib48e3681a4fa5d5858538030871a8bbb21f98840\n" }, { "commit": "c8878164931624a8f602551994e52a59183b4bc0", "tree": "08cbf7eb301069b68631ad58b58965fee5affbc1", "parents": [ "2f01e8ed55663b73787e079955d890e1ffd2983e" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Sep 10 11:17:55 2021 -0700" }, "committer": { "name": "Victor Hsieh", "email": "victorhsieh@google.com", "time": "Fri Sep 24 15:46:34 2021 +0000" }, "message": "Create an abstraction for dexopt tasks\n\nInstead of letting odrefresh building dex2oat cmdline arguments, hide\nthe specifics of cmdline flags behind an API abstraction. The API\ndefines the only necessary parameters for the actual dexopt task (e.g.\ncompiling BCP extension, system server) to proceed. The introduced API\nis private within ART.\n\nlibdexopt.so is created to contain the API and implementation. It is put\nunder art/artd/ in the sense that the future ART services can reuse and\nevolve the code.\n\nThis change should not have any effective change to the compilation\nresults. Given the large size of the change, the dex2oat cmdline is\npurposely ordered in the same way as before. The compiled artifacts\nshould not change at all.\n\nAlso, art_odrefresh_test is no longer built for the \"second\" ABI. This\nis to make it consistent to odrefresh, so that we won\u0027t need to test\nunused variation and build \"second\" for the dependencies.\n\nBug: 193668901\nTest: 1. Revert this change, run `odrefresh --force-compile`, capture\n the checksum of all output files.\n 2. Apply this change, repeat the same step.\n 3. Saw all the file hashes remain the same (except for\n cache-info.xml where the timestamp changed).\nTest: atest ComposHostTestCases\nTest: atest odsign_e2e_tests\nTest: atest art_standalone_odrefresh_tests\nTest: art/build/apex/runtests.sh\nTest: TH\nChange-Id: I3404057050bc1ce6fce4f99cc5c9998e3d67808a\n" }, { "commit": "b1d903587248775b526adf379478575f0713ac76", "tree": "2edfc75984742297ea29e372b83fa5e5a990efd1", "parents": [ "8f0887be865e685efc3b61d0dda88206630cf617" ], "author": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Wed Sep 22 09:08:26 2021 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Wed Sep 22 10:45:23 2021 +0000" }, "message": "Fix lint error in odrefresh_test.\n\nThis CL changes the C-style cast in the code to `static_cast`.\n\nBug: 197176583\nTest: atest art_standalone_odrefresh_tests\nChange-Id: I7686c2fb8a17ca9b41cee7ed475eceba8174de1c\n" }, { "commit": "4e6cc7384f7c52d2fd9e13414696338c289d63f9", "tree": "712dfdfe9bec86f0ed98474f23b43c2fdaad3a4c", "parents": [ "075567130f9353a0d0899c97910552f92529c038" ], "author": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Fri Sep 17 04:46:24 2021 +0000" }, "committer": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Wed Sep 22 05:30:53 2021 +0000" }, "message": "Support using boot image on system when compiling system server.\n\nWhen compiling system server, odrefresh assumes that boot classpath\nartifacts are on data, which is not necessarily true now because we\ndon\u0027t re-compile boot classpath jars unless there is an ART update.\n\nBug: 197176583\nTest: atest art_standalone_odrefresh_tests\nChange-Id: I613e8ce8a97ff5ec6e8dcb6fc7975363220a021c\n" }, { "commit": "ccbcfb17c9eabee791d674b794e696da10b1b28b", "tree": "75393520dd83f976246d5152ae4f97613691b56d", "parents": [ "a7e7426a89bb5d1255a0a6f90cc3efb0a83d9195" ], "author": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Mon Aug 23 15:10:35 2021 +0000" }, "committer": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Tue Aug 24 03:31:06 2021 +0000" }, "message": "Revert^2 \"Add unit tests for odrefresh - step 2\"\n\nThis reverts commit b89649bd95cffec48f6f6746054553f71ab3e807.\n\nReason for revert: Fixed the fugu build breakage\n\nThe test failed on fugu because fugu is running Android O, while the\ntest depends on a system property introduced in S. Since the whole\nodrefresh program is for S and later, we don\u0027t need to run the test on\nolder platforms. This failure is fixed by adding a check on the API\nlevel and skipping the test if the API level is below S.\n\nBug: 196188549\nTest: atest art_standalone_odrefresh_tests\n\nChange-Id: I484696d065d715da65ae262a5aa8b3e1b30ffdcf\n" }, { "commit": "b89649bd95cffec48f6f6746054553f71ab3e807", "tree": "faaff2611b018e4864b29d1f5df47b2d0187b8d2", "parents": [ "054c8008272861c4c2a845424a3be6705f884d93" ], "author": { "name": "Ulyana Trafimovich", "email": "skvadrik@google.com", "time": "Mon Aug 23 10:48:17 2021 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Mon Aug 23 12:26:31 2021 +0000" }, "message": "Revert \"Add unit tests for odrefresh - step 2\"\n\nThis reverts commit b91dad2b98e8c562aed7c4471615d7c325756c08.\n\nReason for revert: breaks builds on fugu.\n\nBug: 196188549\nChange-Id: Iec08674c2ed53b8e6048c044d5e72fdd26518a83\n" }, { "commit": "b91dad2b98e8c562aed7c4471615d7c325756c08", "tree": "85f1d6092a86116555f785a4f906b5f852aa1fca", "parents": [ "3bc03531d1ae5cbe5b0a7ac34c10d5c51f20f233" ], "author": { "name": "Jiakai Zhang", "email": "jiakaiz@google.com", "time": "Mon Aug 16 03:20:07 2021 +0000" }, "committer": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com", "time": "Fri Aug 20 12:59:57 2021 +0000" }, "message": "Add unit tests for odrefresh - step 2\n\n- Define MockableExecUtils, which is a wrapper class to make exec_utils\nmockable.\n- Add another constructor to the OnDeviceRefresh class to support\ninjections.\n- Update OdrConfig to support overriding the staging directory.\n- Add a unit test to verify that odrefresh sets compiler filter based on\n\"dalvik.vm.systemservercompilerfilter\".\n\nBug: 196188549\nTest: atest art_standalone_odrefresh_tests\nTest: atest odsign_e2e_tests\nChange-Id: Ia7b4347bba6873878490a513b8a5ff6642122d71\n" }, { "commit": "4c3ade67c470543562a0029e39b576954a807321", "tree": "21f56e9c9dae7868ee5d68c18457fd0ea3a271fe", "parents": [ "3a8d7c2de4392ff4c40858803447efe14c3c9fa8" ], "author": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Wed Feb 10 14:07:10 2021 +0000" }, "committer": { "name": "Orion Hodson", "email": "oth@google.com", "time": "Thu Feb 25 08:44:32 2021 +0000" }, "message": "odrefresh: regenerate artifacts after ART APEX update\n\nReplaces compile_bcp.sh to check and compile boot class path\nextensions and system server jars.\n\nEnable ART to load those artifacts when present in the ART APEX data\ndirectory.\n\nBug: 160683548\nTest: art_libartbase_tests\nTest: adb root \u0026\u0026 adb odrefresh {--force-check,--force-compile}\nTest: adb install com.android.art \u0026\u0026 adb reboot \u0026\u0026 adb root \u0026\u0026 \\\n adb shell odrefresh {--check,--compile} \u0026\u0026 adb reboot \u0026\u0026 \\\n adb shell cat /proc/\u003czygote\u003e/maps | grep apexdata\nChange-Id: I81bf520d38f9dc0109c91f192bc6e728099049fd\n" } ] }