Gitiles
Code Review Sign In
gerrit.witaqua.org / external_htop / 94c78224015bfb461a124b994a78c37f8c2a3e34
commit94c78224015bfb461a124b994a78c37f8c2a3e34[log] [tgz]
authorChristian Göttsche <cgzones@googlemail.com>Sat Jan 20 11:51:20 2024 +0100
committerBenBE <BenBE@geshi.org>Thu Jan 25 10:03:26 2024 +0100
tree56bec236e69248302b79a9548cf1aa4aaf323775
parent207db2e8f8874de7b8cfe43fa5ce7cb7c06b5097 [diff]
Explicitly check sscanf(3) and fscanf(3) return values

Compare the return value of sscanf(3) and fscanf(3) explicitly against
the expected number of parsed items and avoid implicit boolean
conversion.  Such an implicit conversion would treat EOF (-1) the same
as at least one item parsed successfully.

Reported by CodeQL.
5 files changed
tree: 56bec236e69248302b79a9548cf1aa4aaf323775
  1. .github/
  2. darwin/
  3. docs/
  4. dragonflybsd/
  5. freebsd/
  6. generic/
  7. iwyu/
  8. linux/
  9. netbsd/
  10. openbsd/
  11. pcp/
  12. scripts/
  13. solaris/
  14. unsupported/
  15. zfs/
  16. README.md ⇨ README
  17. .editorconfig
  18. .gitignore
  19. .travis.yml
  20. Action.c
  21. Action.h
  22. Affinity.c
  23. Affinity.h
  24. AffinityPanel.c
  25. AffinityPanel.h
  26. AUTHORS
  27. autogen.sh
  28. AvailableColumnsPanel.c
  29. AvailableColumnsPanel.h
  30. AvailableMetersPanel.c
  31. AvailableMetersPanel.h
  32. BatteryMeter.c
  33. BatteryMeter.h
  34. CategoriesPanel.c
  35. CategoriesPanel.h
  36. ChangeLog
  37. ClockMeter.c
  38. ClockMeter.h
  39. ColorsPanel.c
  40. ColorsPanel.h
  41. ColumnsPanel.c
  42. ColumnsPanel.h
  43. CommandLine.c
  44. CommandLine.h
  45. CommandScreen.c
  46. CommandScreen.h
  47. Compat.c
  48. Compat.h
  49. configure.ac
  50. CONTRIBUTING.md
  51. COPYING
  52. CPUMeter.c
  53. CPUMeter.h
  54. CRT.c
  55. CRT.h
  56. DateMeter.c
  57. DateMeter.h
  58. DateTimeMeter.c
  59. DateTimeMeter.h
  60. DiskIOMeter.c
  61. DiskIOMeter.h
  62. DisplayOptionsPanel.c
  63. DisplayOptionsPanel.h
  64. DynamicColumn.c
  65. DynamicColumn.h
  66. DynamicMeter.c
  67. DynamicMeter.h
  68. DynamicScreen.c
  69. DynamicScreen.h
  70. EnvScreen.c
  71. EnvScreen.h
  72. FileDescriptorMeter.c
  73. FileDescriptorMeter.h
  74. FunctionBar.c
  75. FunctionBar.h
  76. Hashtable.c
  77. Hashtable.h
  78. Header.c
  79. Header.h
  80. HeaderLayout.h
  81. HeaderOptionsPanel.c
  82. HeaderOptionsPanel.h
  83. HostnameMeter.c
  84. HostnameMeter.h
  85. htop.1.in
  86. htop.c
  87. htop.desktop
  88. htop.png
  89. htop.svg
  90. IncSet.c
  91. IncSet.h
  92. InfoScreen.c
  93. InfoScreen.h
  94. ListItem.c
  95. ListItem.h
  96. LoadAverageMeter.c
  97. LoadAverageMeter.h
  98. Machine.c
  99. Machine.h
  100. Macros.h
  101. MainPanel.c
  102. MainPanel.h
  103. Makefile.am
  104. MemoryMeter.c
  105. MemoryMeter.h
  106. MemorySwapMeter.c
  107. MemorySwapMeter.h
  108. Meter.c
  109. Meter.h
  110. MetersPanel.c
  111. MetersPanel.h
  112. NetworkIOMeter.c
  113. NetworkIOMeter.h
  114. NEWS
  115. Object.c
  116. Object.h
  117. OpenFilesScreen.c
  118. OpenFilesScreen.h
  119. OptionItem.c
  120. OptionItem.h
  121. Panel.c
  122. Panel.h
  123. pcp-htop.5.in
  124. pcp-htop.c
  125. Process.c
  126. Process.h
  127. ProcessLocksScreen.c
  128. ProcessLocksScreen.h
  129. ProcessTable.c
  130. ProcessTable.h
  131. ProvideCurses.h
  132. ProvideTerm.h
  133. README
  134. RichString.c
  135. RichString.h
  136. Row.c
  137. Row.h
  138. RowField.h
  139. Scheduling.c
  140. Scheduling.h
  141. ScreenManager.c
  142. ScreenManager.h
  143. ScreensPanel.c
  144. ScreensPanel.h
  145. ScreenTabsPanel.c
  146. ScreenTabsPanel.h
  147. Settings.c
  148. Settings.h
  149. SignalsPanel.c
  150. SignalsPanel.h
  151. SwapMeter.c
  152. SwapMeter.h
  153. SysArchMeter.c
  154. SysArchMeter.h
  155. Table.c
  156. Table.h
  157. TasksMeter.c
  158. TasksMeter.h
  159. test_spec.lua
  160. TESTPLAN
  161. TraceScreen.c
  162. TraceScreen.h
  163. UptimeMeter.c
  164. UptimeMeter.h
  165. UsersTable.c
  166. UsersTable.h
  167. Vector.c
  168. Vector.h
  169. XUtils.c
  170. XUtils.h