)]}' { "commit": "5cfee3fabb3482c6a6df1c8b6f21e843cf214527", "tree": "c4190f1fa809eb1e5e7d028f21be510b2a5b3980", "parents": [ "9b4157935af9e44571187a9533c2cc9b413383bf" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Tue May 31 01:00:15 2011 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Wed Jun 01 14:29:59 2011 -0700" }, "message": "Integrating keystore with keyguard (Part 1 of 4)\n\nSummary:\n\nframeworks/base\n keystore rewrite\n keyguard integration with keystore on keyguard entry or keyguard change\n KeyStore API simplification\n\npackages/apps/Settings\n Removed com.android.credentials.SET_PASSWORD intent support\n Added keyguard requirement for keystore use\n\npackages/apps/CertInstaller\n Tracking KeyStore API changes\n Fix for NPE in CertInstaller when certificate lacks basic constraints\n\npackages/apps/KeyChain\n Tracking KeyStore API changes\n\nDetails:\n\nframeworks/base\n\n Move keystore from C to C++ while rewriting password\n implementation. Removed global variables. Added many comments.\n\n\tcmds/keystore/Android.mk\n\tcmds/keystore/keystore.h\n\tcmds/keystore/keystore.c \u003d\u003e cmds/keystore/keystore.cpp\n\tcmds/keystore/keystore_cli.c \u003d\u003e cmds/keystore/keystore_cli.cpp\n\n Changed saveLockPattern and saveLockPassword to notify the keystore\n on changes so that the keystore master key can be reencrypted when\n the keyguard changes.\n\n\tcore/java/com/android/internal/widget/LockPatternUtils.java\n\n Changed unlock screens to pass values for keystore unlock or initialization\n\n\tpolicy/src/com/android/internal/policy/impl/PasswordUnlockScreen.java\n\tpolicy/src/com/android/internal/policy/impl/PatternUnlockScreen.java\n\n KeyStore API changes\n - renamed test() to state(), which now return a State enum\n - made APIs with byte[] key arguments private\n - added new KeyStore.isEmpty used to determine if a keyguard is required\n\n\tkeystore/java/android/security/KeyStore.java\n\n In addition to tracking KeyStore API changes, added new testIsEmpty\n and improved some existing tests to validate expect values.\n\n\tkeystore/tests/src/android/security/KeyStoreTest.java\n\npackages/apps/Settings\n\n Removing com.android.credentials.SET_PASSWORD intent with the\n removal of the ability to set an explicit keystore password now\n that the keyguard value is used. Changed to ensure keyguard is\n enabled for keystore install or unlock. Cleaned up interwoven\n dialog handing into discrete dialog helper classes.\n\n\tAndroidManifest.xml\n\tsrc/com/android/settings/CredentialStorage.java\n\n Remove layout for entering new password\n\n\tres/layout/credentials_dialog.xml\n\n Remove enable credentials checkbox\n\n\tres/xml/security_settings_misc.xml\n\tsrc/com/android/settings/SecuritySettings.java\n\n Added ability to specify minimum quality key to ChooseLockGeneric\n Activity. Used by CredentialStorage, but could also be used by\n CryptKeeperSettings. Changed ChooseLockGeneric to understand\n minimum quality for keystore in addition to DPM and device\n encryption.\n\n\tsrc/com/android/settings/ChooseLockGeneric.java\n\n Changed to use getActivePasswordQuality from\n getKeyguardStoredPasswordQuality based on experience in\n CredentialStorage. Removed bogus class javadoc.\n\n\tsrc/com/android/settings/CryptKeeperSettings.java\n\n Tracking KeyStore API changes\n\n\tsrc/com/android/settings/vpn/VpnSettings.java\n\tsrc/com/android/settings/wifi/WifiSettings.java\n\n Removing now unused string resources\n\n\tres/values-af/strings.xml\n\tres/values-am/strings.xml\n\tres/values-ar/strings.xml\n\tres/values-bg/strings.xml\n\tres/values-ca/strings.xml\n\tres/values-cs/strings.xml\n\tres/values-da/strings.xml\n\tres/values-de/strings.xml\n\tres/values-el/strings.xml\n\tres/values-en-rGB/strings.xml\n\tres/values-es-rUS/strings.xml\n\tres/values-es/strings.xml\n\tres/values-fa/strings.xml\n\tres/values-fi/strings.xml\n\tres/values-fr/strings.xml\n\tres/values-hr/strings.xml\n\tres/values-hu/strings.xml\n\tres/values-in/strings.xml\n\tres/values-it/strings.xml\n\tres/values-iw/strings.xml\n\tres/values-ja/strings.xml\n\tres/values-ko/strings.xml\n\tres/values-lt/strings.xml\n\tres/values-lv/strings.xml\n\tres/values-ms/strings.xml\n\tres/values-nb/strings.xml\n\tres/values-nl/strings.xml\n\tres/values-pl/strings.xml\n\tres/values-pt-rPT/strings.xml\n\tres/values-pt/strings.xml\n\tres/values-rm/strings.xml\n\tres/values-ro/strings.xml\n\tres/values-ru/strings.xml\n\tres/values-sk/strings.xml\n\tres/values-sl/strings.xml\n\tres/values-sr/strings.xml\n\tres/values-sv/strings.xml\n\tres/values-sw/strings.xml\n\tres/values-th/strings.xml\n\tres/values-tl/strings.xml\n\tres/values-tr/strings.xml\n\tres/values-uk/strings.xml\n\tres/values-vi/strings.xml\n\tres/values-zh-rCN/strings.xml\n\tres/values-zh-rTW/strings.xml\n\tres/values-zu/strings.xml\n\tres/values/strings.xml\n\npackages/apps/CertInstaller\n\n Tracking KeyStore API changes\n\tsrc/com/android/certinstaller/CertInstaller.java\n\n Fix for NPE in CertInstaller when certificate lacks basic constraints\n\tsrc/com/android/certinstaller/CredentialHelper.java\n\npackages/apps/KeyChain\n\n Tracking KeyStore API changes\n\tsrc/com/android/keychain/KeyChainActivity.java\n\tsrc/com/android/keychain/KeyChainService.java\n\tsupport/src/com/android/keychain/tests/support/IKeyChainServiceTestSupport.aidl\n\tsupport/src/com/android/keychain/tests/support/KeyChainServiceTestSupport.java\n\ttests/src/com/android/keychain/tests/KeyChainServiceTest.java\n\nChange-Id: Ic141fb5d4b43d12fe62cb1e29c7cbd891b4be35d\n", "tree_diff": [ { "type": "modify", "old_id": "15a199f30c46fa914837bf35397a89378722ffe7", "old_mode": 33188, "old_path": "cmds/keystore/Android.mk", "new_id": "67dd9f8679ea097ee56702c7620f16535b45b011", "new_mode": 33188, "new_path": "cmds/keystore/Android.mk" }, { "type": "delete", "old_id": "e34053be2c512306a49a7dc8a565d197f00487db", "old_mode": 33188, "old_path": "cmds/keystore/keystore.c", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "31db9fdc1c8f7a980c66d7c7948368da826393be", "new_mode": 33188, "new_path": "cmds/keystore/keystore.cpp" }, { "type": "modify", "old_id": "5ef51e9cd7d00f85a97c00fd0bb5ab47f7afa2bc", "old_mode": 33188, "old_path": "cmds/keystore/keystore.h", "new_id": "5ae3d24acee0bb1eb7373e8d33558c0d28633ee5", "new_mode": 33188, "new_path": "cmds/keystore/keystore.h" }, { "type": "rename", "old_id": "e8afb5a945b2657620cc4cb9c68ddd5141f22929", "old_mode": 33188, "old_path": "cmds/keystore/keystore_cli.c", "new_id": "dcd3bcb8fc0161acdf6671c2c97f5a4a15935f95", "new_mode": 33188, "new_path": "cmds/keystore/keystore_cli.cpp", "score": 67 }, { "type": "modify", "old_id": "0dc0422967afc21800bbec3c697a7a7df7f6045b", "old_mode": 33188, "old_path": "core/java/com/android/internal/widget/LockPatternUtils.java", "new_id": "b3666cbaad6d3ac040b4cfea62faa80113a86433", "new_mode": 33188, "new_path": "core/java/com/android/internal/widget/LockPatternUtils.java" }, { "type": "modify", "old_id": "7183688bd356c98f12b54c98e9bc43b76341f673", "old_mode": 33188, "old_path": "keystore/java/android/security/KeyStore.java", "new_id": "2a48834f993fd43bb6bdffd155304d01a91aca0f", "new_mode": 33188, "new_path": "keystore/java/android/security/KeyStore.java" }, { "type": "modify", "old_id": "6630a4f1c148e369bb317b0e6069f77433e6d8af", "old_mode": 33261, "old_path": "keystore/tests/src/android/security/KeyStoreTest.java", "new_id": "4582aa0ccfe8afedb025fd3d62a9ef89a91b7946", "new_mode": 33261, "new_path": "keystore/tests/src/android/security/KeyStoreTest.java" }, { "type": "modify", "old_id": "ca56c4fb53c4f72366a36fa3c51fbae245cdb911", "old_mode": 33188, "old_path": "policy/src/com/android/internal/policy/impl/PasswordUnlockScreen.java", "new_id": "57b6b5e9418e40f6b117e482779018428b504dd0", "new_mode": 33188, "new_path": "policy/src/com/android/internal/policy/impl/PasswordUnlockScreen.java" }, { "type": "modify", "old_id": "018fe0cddc8bce842765b8f25a41c00fe96be737", "old_mode": 33188, "old_path": "policy/src/com/android/internal/policy/impl/PatternUnlockScreen.java", "new_id": "a6854973bab1ae0344035873ebfe3bddfa74c1ca", "new_mode": 33188, "new_path": "policy/src/com/android/internal/policy/impl/PatternUnlockScreen.java" } ] }