commit bf6ef8d78fffbce6c1849a4a28fb3f4401ad039e
author Jason Sams <rjsams@android.com> Mon Dec 06 15:59:59 2010 -0800
committer Jason Sams <rjsams@android.com> Mon Dec 06 17:46:20 2010 -0800
tree 7bbf2a1d7b8034834e49fa6b636deafcf874d277
parent 11a8af5ea1e5a760e6d40f025f9cbc356edf1894

API review cleanup.

Change-Id: Ieae7d450308b5637ed4253fe9baed3634c6ed141

graphics/java/android/renderscript/RSSurfaceView.java

diff --git a/graphics/java/android/renderscript/RSSurfaceView.java b/graphics/java/android/renderscript/RSSurfaceView.java
index 2540d01..0211a4a 100644
--- a/graphics/java/android/renderscript/RSSurfaceView.java
+++ b/graphics/java/android/renderscript/RSSurfaceView.java
@@ -69,7 +69,6 @@
      * not normally called or subclassed by clients of RSSurfaceView.
      */
     public void surfaceCreated(SurfaceHolder holder) {
-        Log.v(RenderScript.LOG_TAG, "surfaceCreated");
         mSurfaceHolder = holder;
     }
 
@@ -79,9 +78,8 @@
      */
     public void surfaceDestroyed(SurfaceHolder holder) {
         // Surface will be destroyed when we return
-        Log.v(RenderScript.LOG_TAG, "surfaceDestroyed");
         if (mRS != null) {
-            mRS.contextSetSurface(0, 0, null);
+            mRS.setSurface(null, 0, 0);
         }
     }
 
@@ -90,23 +88,21 @@
      * not normally called or subclassed by clients of RSSurfaceView.
      */
     public void surfaceChanged(SurfaceHolder holder, int format, int w, int h) {
-        Log.v(RenderScript.LOG_TAG, "surfaceChanged");
         if (mRS != null) {
-            mRS.contextSetSurface(w, h, holder.getSurface());
+            mRS.setSurface(holder, w, h);
         }
     }
 
-    /**
+   /**
      * Inform the view that the activity is paused. The owner of this view must
      * call this method when the activity is paused. Calling this method will
      * pause the rendering thread.
      * Must not be called before a renderer has been set.
      */
-    public void onPause() {
+    public void pause() {
         if(mRS != null) {
             mRS.pause();
         }
-        //Log.v(RenderScript.LOG_TAG, "onPause");
     }
 
     /**
@@ -116,49 +112,29 @@
      * thread.
      * Must not be called before a renderer has been set.
      */
-    public void onResume() {
+    public void resume() {
         if(mRS != null) {
             mRS.resume();
         }
-        //Log.v(RenderScript.LOG_TAG, "onResume");
     }
 
-    /**
-     * Queue a runnable to be run on the GL rendering thread. This can be used
-     * to communicate with the Renderer on the rendering thread.
-     * Must not be called before a renderer has been set.
-     * @param r the runnable to be run on the GL rendering thread.
-     */
-    public void queueEvent(Runnable r) {
-        //Log.v(RenderScript.LOG_TAG, "queueEvent");
+    public RenderScriptGL createRenderScriptGL(RenderScriptGL.SurfaceConfig sc) {
+        RenderScriptGL rs = new RenderScriptGL(sc);
+        setRenderScriptGL(rs);
+        return rs;
     }
 
-    /**
-     * This method is used as part of the View class and is not normally
-     * called or subclassed by clients of RSSurfaceView.
-     * Must not be called before a renderer has been set.
-     */
-    @Override
-    protected void onDetachedFromWindow() {
-        super.onDetachedFromWindow();
-    }
-
-    // ----------------------------------------------------------------------
-
-    public RenderScriptGL createRenderScript(RenderScriptGL.SurfaceConfig sc) {
-        Log.v(RenderScript.LOG_TAG, "createRenderScript");
-        mRS = new RenderScriptGL(sc);
-        return mRS;
-    }
-
-    public void destroyRenderScript() {
-        Log.v(RenderScript.LOG_TAG, "destroyRenderScript");
+    public void destroyRenderScriptGL() {
         mRS.destroy();
         mRS = null;
     }
 
-    public void createRenderScript(RenderScriptGL rs) {
+    public void setRenderScriptGL(RenderScriptGL rs) {
         mRS = rs;
     }
+
+    public RenderScriptGL getRenderScriptGL() {
+        return mRS;
+    }
 }