)]}' { "log": [ { "commit": "b866307f99c35252dcb76e9269bb57d97c3c4b86", "tree": "ce8d4edc1cf2edbc48029214dfbde2213a3d9466", "parents": [ "9d25218985ba8ea944b4a51d194744b5a85a1105" ], "author": { "name": "Paul Duffin", "email": "paulduffin@google.com", "time": "Fri Dec 08 00:02:42 2017 +0000" }, "committer": { "name": "Paul Duffin", "email": "paulduffin@google.com", "time": "Fri Dec 08 00:07:17 2017 +0000" }, "message": "Stop statically including legacy-android-test\n\nStatically including legacy-android-test leads to duplicate classes\nwhich causes build time problems (with Proguard) and runtime problems on\nolder SDK versions. This change:\n* Stops statically including legacy-android-test.\n* Adds compile time dependencies on andoid.test.base, android.test.mock\n and android.test.runner where necessary.\n* Adds \u003cuses-library android:name\u003d\"android.test.runner\"/\u003e to any\n affected package to ensure that the classes that were included by\n legacy-android-test are still available at runtime. That also adds a\n dependency on android.test.base and android.test.mock.\n\nThe following change descriptions were generated automatically and so\nmay be a little repetitive. They are provided to give the reviewer\nenough information to check the comments match what has actually been\nchanged and check the reasoning behind the changes.\n\n* apct-tests/perftests/core/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in CorePerfTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n CorePerfTests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n* core/tests/ConnectivityManagerTest/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n ConnectivityManagerTest\u0027s source depends on its classes and because\n of these changes they are no longer present on the compilation\n path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in ConnectivityManagerTest\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* core/tests/bandwidthtests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n BandwidthTests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in BandwidthTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* core/tests/bluetoothtests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n BluetoothTests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in BluetoothTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* core/tests/hosttests/test-apps/DownloadManagerTestApp/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in DownloadManagerTestApp\n results in duplicate classes which leads to build time and compile\n time issues.\n\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n DownloadManagerTestApp\u0027s source depends on its classes and because\n of these changes they are no longer present on the compilation\n path.\n\n* core/tests/hosttests/test-apps/ExternalSharedPerms/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n ExternalSharedPermsTestApp results in duplicate classes which leads\n to build time and compile time issues.\n\n* core/tests/hosttests/test-apps/ExternalSharedPermsBT/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n ExternalSharedPermsBTTestApp results in duplicate classes which\n leads to build time and compile time issues.\n\n* core/tests/hosttests/test-apps/ExternalSharedPermsDiffKey/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n ExternalSharedPermsDiffKeyTestApp results in duplicate classes\n which leads to build time and compile time issues.\n\n* core/tests/hosttests/test-apps/ExternalSharedPermsFL/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n ExternalSharedPermsFLTestApp results in duplicate classes which\n leads to build time and compile time issues.\n\n* core/tests/notificationtests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n NotificationStressTests\u0027s source depends on its classes and because\n of these changes they are no longer present on the compilation\n path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in NotificationStressTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* keystore/tests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in KeystoreTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* media/mca/tests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n CameraEffectsTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in CameraEffectsTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* media/tests/MediaFrameworkTest/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n mediaframeworktest\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in mediaframeworktest\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* nfc-extras/tests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in NfcExtrasTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* packages/CarrierDefaultApp/tests/unit/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n CarrierDefaultAppUnitTests\u0027s source depends on its classes and\n because of these changes they are no longer present on the\n compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n CarrierDefaultAppUnitTests results in duplicate classes which leads\n to build time and compile time issues.\n\n* packages/ExtServices/tests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n ExtServicesUnitTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in ExtServicesUnitTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* packages/MtpDocumentsProvider/tests/Android.mk\n Added \u0027android.test.base\u0027 and \u0027android.test.mock\u0027 to\n LOCAL_JAVA_LIBRARIES because MtpDocumentsProviderTests\u0027s source\n depends on their classes and because of these changes they are no\n longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n MtpDocumentsProviderTests results in duplicate classes which leads\n to build time and compile time issues.\n\n* packages/SettingsLib/tests/integ/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n SettingsLibTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in SettingsLibTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* packages/SettingsProvider/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in SettingsProvider\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* packages/SettingsProvider/AndroidManifest.xml\n Add uses-library for android.test.runner because otherwise this\n change would change the set of files available to SettingsProvider\n at runtime.\n\n* packages/Shell/tests/Android.mk\n Added \u0027android.test.base\u0027 and \u0027android.test.mock\u0027 to\n LOCAL_JAVA_LIBRARIES because ShellTests\u0027s source depends on their\n classes and because of these changes they are no longer present on\n the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in ShellTests results in\n duplicate classes which leads to build time and compile time\n issues.\n\n* packages/SystemUI/shared/tests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in SystemUISharedLibTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* packages/SystemUI/tests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in SystemUITests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n SystemUITests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n* packages/WAPPushManager/tests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n WAPPushManagerTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in WAPPushManagerTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* sax/tests/saxtests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n FrameworksSaxTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in FrameworksSaxTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* tests/BrowserPowerTest/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n BrowserPowerTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in BrowserPowerTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* tests/CanvasCompare/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n CanvasCompare\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in CanvasCompare results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* tests/CoreTests/android/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n CoreTests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in CoreTests results in\n duplicate classes which leads to build time and compile time\n issues.\n\n* tests/DataIdleTest/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n DataIdleTest\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in DataIdleTest results in\n duplicate classes which leads to build time and compile time\n issues.\n\n* tests/FrameworkPerf/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n FrameworkPerf\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in FrameworkPerf results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* tests/HierarchyViewerTest/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n HierarchyViewerTest\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in HierarchyViewerTest\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* tests/ImfTest/tests/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n ImfTestTests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in ImfTestTests results in\n duplicate classes which leads to build time and compile time\n issues.\n\n* tests/Internal/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in InternalTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n* tests/MemoryUsage/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n MemoryUsage\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in MemoryUsage results in\n duplicate classes which leads to build time and compile time\n issues.\n\n* tests/NetworkSecurityConfigTest/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n NetworkSecurityConfigTests\u0027s source depends on its classes and\n because of these changes they are no longer present on the\n compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n NetworkSecurityConfigTests results in duplicate classes which leads\n to build time and compile time issues.\n\n* tests/SoundTriggerTests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in SoundTriggerTests\n results in duplicate classes which leads to build time and compile\n time issues.\n\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n SoundTriggerTests\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n* tests/SurfaceComposition/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in SurfaceComposition\n results in duplicate classes which leads to build time and compile\n time issues.\n\n Added \u0027android.test.runner.stubs\u0027 to LOCAL_JAVA_LIBRARIES because\n SurfaceComposition\u0027s source depends on its classes and because of\n these changes they are no longer present on the compilation path.\n\n* tests/TtsTests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in TtsTests results in\n duplicate classes which leads to build time and compile time\n issues.\n\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n TtsTests\u0027s source depends on its classes and because of these\n changes they are no longer present on the compilation path.\n\n* tests/WindowAnimationJank/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in WindowAnimationJank\n results in duplicate classes which leads to build time and compile\n time issues.\n\n* tests/permission/Android.mk\n Added \u0027android.test.base\u0027 to LOCAL_JAVA_LIBRARIES because\n FrameworkPermissionTests\u0027s source depends on its classes and\n because of these changes they are no longer present on the\n compilation path.\n\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in\n FrameworkPermissionTests results in duplicate classes which leads\n to build time and compile time issues.\n\n* tests/testables/tests/Android.mk\n Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES\n because statically including the classes in TestablesTests results\n in duplicate classes which leads to build time and compile time\n issues.\n\n Added \u0027android.test.base\u0027 and \u0027android.test.mock\u0027 to\n LOCAL_JAVA_LIBRARIES because TestablesTests\u0027s source depends on\n their classes and because of these changes they are no longer\n present on the compilation path.\n\nBug: 30188076\nTest: make checkbuild\nChange-Id: Iacfc939c97415314366ed61c5f3b7aa1a40f0ec9\n" }, { "commit": "852c8f121f2e502e1e8503bfc230dccb81b681d4", "tree": "27c90a754791b77990afbcb369cac3fad401a3bf", "parents": [ "d52efa56adaca0bc70fb72082c7c663adcb669cc" ], "author": { "name": "Eran Messeri", "email": "eranm@google.com", "time": "Wed Nov 15 05:55:52 2017 +0000" }, "committer": { "name": "Eran Messeri", "email": "eranm@google.com", "time": "Thu Dec 07 15:12:30 2017 +0000" }, "message": "DevicePolicyManager: Add key generation functionality.\n\nThis is the crux of the Verified Access feature implementation:\nAdding the ability to generate KeyChain keys directly by the\nsecure hardware, rather than installing software-generated keys\ninto KeyChain.\n\nAdd generateKeyPair to the DevicePolicyManager, which delegates key\ngeneration (via the DevicePolicyManagerService) to the KeyChainService.\n\nDesign highlights:\n* The key generation is delegated via the DevicePolicyManagerService to\n check that only authorized callers request key generation in KeyChain.\n* KeyChainService performs the actual key generation so it owns the key\n in Keystore outright.\n* DevicePolicyManagerService then grants the calling app access to the\n Keystore key, so it can actually be used.\n* Loading the public/private key pair, as well as attestation\n certificate chain, is done in the client code (DevicePolicyManager)\n to save parceling / unparceling those objects across process\n boundaries twice (for no good reason).\n\nNOTE: The key attestation functionality (that includes Device ID) is\nmissing/untested. Will be added in a follow-up CL as this one is quite\nbig already.\n\nHIGHLIGHT FOR REVIEWERS:\n* API: New API in DevicePolicyManager.\n\nBug: 63388672\nTest: cts-tradefed run commandAndExit cts-dev -a armeabi-v7a -m CtsDevicePolicyManagerTestCases -t com.android.cts.devicepolicy.DeviceOwnerTest#testKeyManagement -l DEBUG; adb shell am instrument \u0027android.security.tests/android.support.test.runner.AndroidJUnitRunner\u0027 (After building the KeystoreTests target and installing the apk)\nChange-Id: I73762c9123f32a94d454ba4f8b533883b55c44cc\n" }, { "commit": "91abf9f6e2c60b05377b2b82ea2a09fc25476e56", "tree": "24739cefc13f9d57fa8c8e3574c7d6eb5efbe865", "parents": [ "7fdce769c3ef3885ec8f1716bdeedfc8b056a1d7" ], "author": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Mon May 01 16:38:45 2017 -0700" }, "committer": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Mon May 01 16:39:20 2017 -0700" }, "message": "Delete obsolete and unused KeyStoreTests\n\nThese depended on internal implementation details of Conscrypt that are\nchanging. Delete these tests since they\u0027re not included in builds any\nmore.\n\nTest: make checkbuild\nChange-Id: I6ddf832c30bcf49e940c55aa81534c3d987393fb\n" }, { "commit": "ccb04450279c53eda250ac3e20b75cd07bcd1f7e", "tree": "b7465ccb8c71931bcc64f3fa19c90be70d6baf54", "parents": [ "0ac7232b7cd55806b4fd231899a57a20c7f7bdd8" ], "author": { "name": "Paul Duffin", "email": "paulduffin@google.com", "time": "Tue Jan 10 12:08:23 2017 +0000" }, "committer": { "name": "Paul Duffin", "email": "paulduffin@google.com", "time": "Thu Jan 19 09:43:05 2017 +0000" }, "message": "Prepare for removal of legacy-test from default targets\n\nIn preparation for removing junit classes from the Android API\nthe legacy-test target will be removed from the\nTARGET_DEFAULT_JAVA_LIBRARIES. This change adds explicit\ndependencies on junit and/or legacy-android-test to ensure that\nmodules will compile properly once it is removed.\n\n(cherry picked from 6387604f9e672ece85e07c4bcbd7be396867f06f)\n\nBug: 30188076\nTest: make checkbuild\nMerged-In: I13e88297731253420e4e5f5291d503f13a39a156\nChange-Id: I58446eb8c45d8ac2bcdbc9fa40d1321e811bdd4b\n" }, { "commit": "12e752225aa96888358294be0d725d499a1c9f03", "tree": "d716c7eedc50ccdf146aaca9b55fae969cf753ec", "parents": [ "28b1f0ee02e14241ffb81f431fc54053771c1c90" ], "author": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Tue Apr 23 22:34:24 2013 -0700" }, "committer": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Mon Apr 29 15:15:27 2013 -0700" }, "message": "Track change to JSSE provider\n\nChange-Id: I35e824e47ad758ab6408e91e2ba5dcda053a82f5\n" }, { "commit": "802768dd86c4e8a933dbfbac2e9f1a1daa5f93fa", "tree": "a90458054c943c102152dbc0c061a83d52c1c70c", "parents": [ "6479ecd1b24e9d5a5636130cb4b0c353b396ff0e" ], "author": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Tue Aug 21 15:23:35 2012 -0700" }, "committer": { "name": "Kenny Root", "email": "kroot@google.com", "time": "Wed Aug 22 13:03:30 2012 -0700" }, "message": "Add ability to replace chain for PrivateKeyEntry\n\nFor the AndroidKeyStore API, allow entries to have their certificate\nchain replaced without destroying the underlying PrivateKey. Since\nentries are backed by unexportable private keys, requiring them to be\nsupplied again doesn\u0027t make sense and is impossible.\n\nChange-Id: I629ce2a625315c8d8020a082892650ac5eba22ae\n" }, { "commit": "f35e9663d7bdae523953185b4ad6b6f9e8e7d6ca", "tree": "ea3c0019085dceed51740c940a2b33b14c5e6f3a", "parents": [ "1a3c8950394b98f6f354456830208d70e87b8bb6" ], "author": { "name": "Chung-yih Wang", "email": "cywang@google.com", "time": "Tue Sep 29 11:20:28 2009 +0800" }, "committer": { "name": "Chung-yih Wang", "email": "cywang@google.com", "time": "Tue Sep 29 15:20:24 2009 +0800" }, "message": "Add unit test for the new keystore.\n\nSince we need to test the keystore with user system in order to test\nthe reset(), password(), lock() and unlock(), we have to take advantage\nof the ActivityUnitTestCase to run the test with the user \u0027system\u0027.\n" } ] }