commit 1559299072f15a0a4592477bb6fb4c63967fc8d7
author William Escande <wescande@google.com> Wed Feb 26 17:43:01 2025 -0800
committer William Escande <wescande@google.com> Thu Mar 06 15:48:23 2025 -0800
tree db9a1ae22d8f29c94b3275077eaad9f24e02fb7a
parent 0bbbac4b68b37c6f2a47ff6e3ab62258a877e8a0

Errorprone enforce multiples

I did my shopping list of errorprone that only appear as warning and are
note enforced yet. I am promoting them to error to make sure this will
never happen

Bug: 344658662
Test: m .
Flag: Exempt refactor
Change-Id: I7a4e73c92a094d14fc12c1a801d6fb5fb386ae6c

Android.bp

diff --git a/Android.bp b/Android.bp
index 89fa45b..34d17b7 100644
--- a/Android.bp
+++ b/Android.bp
@@ -121,8 +121,11 @@
         javacflags: [
             "-Xep:AlmostJavadoc:ERROR",
             "-Xep:AlreadyChecked:ERROR",
+            "-Xep:AmbiguousMethodReference:ERROR",
             "-Xep:ArrayRecordComponent:ERROR",
+            "-Xep:AttemptedNegativeZero:ERROR",
             "-Xep:BadImport:ERROR",
+            "-Xep:BadInstanceof:ERROR",
             "-Xep:CatchAndPrintStackTrace:ERROR",
             "-Xep:CatchFail:ERROR",
             "-Xep:CheckReturnValue:ERROR",
@@ -146,11 +149,14 @@
             "-Xep:GuardedBy:ERROR",
             "-Xep:HidingField:ERROR",
             "-Xep:InconsistentHashCode:ERROR",
+            "-Xep:IncrementInForLoopAndHeader:ERROR",
             "-Xep:InlineFormatString:ERROR",
             "-Xep:InlineMeInliner:ERROR",
             "-Xep:InvalidBlockTag:ERROR",
             "-Xep:InvalidInlineTag:ERROR",
+            "-Xep:InvalidLink:ERROR",
             "-Xep:InvalidParam:ERROR",
+            "-Xep:JavaLangClash:ERROR",
             "-Xep:JavaUtilDate:ERROR",
             "-Xep:JdkObsolete:ERROR",
             "-Xep:LockOnNonEnclosingClassLiteral:ERROR",
@@ -168,9 +174,12 @@
             "-Xep:NonAtomicVolatileUpdate:ERROR",
             "-Xep:NonCanonicalType:ERROR",
             "-Xep:NotJavadoc:ERROR",
+            "-Xep:NullOptional:ERROR",
+            "-Xep:NullableOptional:ERROR",
             "-Xep:NullablePrimitive:ERROR",
             "-Xep:NullableVoid:ERROR",
             "-Xep:ObjectEqualsForPrimitives:ERROR",
+            // "-Xep:ObjectToString:ERROR", // Wrongfully reporting errors
             "-Xep:OperatorPrecedence:ERROR",
             "-Xep:RedundantControlFlow:ERROR",
             "-Xep:ReferenceEquality:ERROR",
@@ -181,10 +190,13 @@
             "-Xep:StaticGuardedByInstance:ERROR",
             "-Xep:StringCaseLocaleUsage:ERROR",
             "-Xep:StringCharset:ERROR",
+            // "-Xep:StringSplitter:ERROR", // Not enabled in android platform
             "-Xep:SynchronizeOnNonFinalField:ERROR",
             "-Xep:ThreadJoinLoop:ERROR",
             "-Xep:ToStringReturnsNull:ERROR",
+            "-Xep:TruthAssertExpected:ERROR",
             "-Xep:TruthConstantAsserts:ERROR",
+            "-Xep:TruthGetOrDefault:ERROR",
             "-Xep:TruthIncompatibleType:ERROR",
             "-Xep:UndefinedEquals:ERROR",
             "-Xep:UnnecessaryAssignment:ERROR",
@@ -193,6 +205,7 @@
             "-Xep:UnrecognisedJavadocTag:ERROR",
             "-Xep:UnusedMethod:ERROR",
             "-Xep:UnusedNestedClass:ERROR",
+            "-Xep:UnusedTypeParameter:ERROR",
             "-Xep:UnusedVariable:ERROR",
             "-Xep:VariableNameSameAsType:ERROR",
             "-Xep:WaitNotInLoop:ERROR",