commit e2f32340d2d852c7d43a2ef07c74faac0d0f7ee5
author Greg Kaiser <gkaiser@google.com> Tue Mar 26 11:58:53 2019 -0700
committer Greg Kaiser <gkaiser@google.com> Tue Mar 26 12:00:19 2019 -0700
tree ccd9752029e49e7ae441264e3f9f4e63c0331ba6
parent c7a409036e606a1d0cace8b066ef9a87e61c5b48

adb: Avoid extra std::string copies

When a function argument takes a std::string, it's inefficient to
pass std::string::c_str(), since that creates an additional copy.
So we change these calling sites.

Test: TreeHugger
Change-Id: I1c0fde7275eb3ebd3baf05ec62581b0243655608

bugreport_test.cpp

diff --git a/bugreport_test.cpp b/bugreport_test.cpp
index 72ca59a..a6be203 100644
--- a/bugreport_test.cpp
+++ b/bugreport_test.cpp
@@ -136,7 +136,7 @@
 
     void ExpectBugreportzVersion(const std::string& version) {
         EXPECT_CALL(br_, SendShellCommand("bugreportz -v", false, _))
-            .WillOnce(DoAll(WithArg<2>(WriteOnStderr(version.c_str())),
+            .WillOnce(DoAll(WithArg<2>(WriteOnStderr(version)),
                             WithArg<2>(ReturnCallbackDone(0))));
     }