| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "register_allocator.h" |
| 18 | |
| Ian Rogers | c7dd295 | 2014-10-21 23:31:19 -0700 | [diff] [blame] | 19 | #include <sstream> |
| 20 | |
| Ian Rogers | e77493c | 2014-08-20 15:08:45 -0700 | [diff] [blame] | 21 | #include "base/bit_vector-inl.h" |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 22 | #include "code_generator.h" |
| 23 | #include "ssa_liveness_analysis.h" |
| 24 | |
| 25 | namespace art { |
| 26 | |
| 27 | static constexpr size_t kMaxLifetimePosition = -1; |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 28 | static constexpr size_t kDefaultNumberOfSpillSlots = 4; |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 29 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 30 | RegisterAllocator::RegisterAllocator(ArenaAllocator* allocator, |
| 31 | CodeGenerator* codegen, |
| 32 | const SsaLivenessAnalysis& liveness) |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 33 | : allocator_(allocator), |
| 34 | codegen_(codegen), |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 35 | liveness_(liveness), |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 36 | unhandled_core_intervals_(allocator, 0), |
| 37 | unhandled_fp_intervals_(allocator, 0), |
| 38 | unhandled_(nullptr), |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 39 | handled_(allocator, 0), |
| 40 | active_(allocator, 0), |
| 41 | inactive_(allocator, 0), |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 42 | physical_core_register_intervals_(allocator, codegen->GetNumberOfCoreRegisters()), |
| 43 | physical_fp_register_intervals_(allocator, codegen->GetNumberOfFloatingPointRegisters()), |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 44 | temp_intervals_(allocator, 4), |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 45 | spill_slots_(allocator, kDefaultNumberOfSpillSlots), |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 46 | safepoints_(allocator, 0), |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 47 | processing_core_registers_(false), |
| 48 | number_of_registers_(-1), |
| 49 | registers_array_(nullptr), |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 50 | blocked_core_registers_(codegen->GetBlockedCoreRegisters()), |
| 51 | blocked_fp_registers_(codegen->GetBlockedFloatingPointRegisters()), |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 52 | reserved_out_slots_(0), |
| 53 | maximum_number_of_live_registers_(0) { |
| Nicolas Geoffray | 71175b7 | 2014-10-09 22:13:55 +0100 | [diff] [blame] | 54 | codegen->SetupBlockedRegisters(); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 55 | physical_core_register_intervals_.SetSize(codegen->GetNumberOfCoreRegisters()); |
| 56 | physical_fp_register_intervals_.SetSize(codegen->GetNumberOfFloatingPointRegisters()); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 57 | // Always reserve for the current method and the graph's max out registers. |
| 58 | // TODO: compute it instead. |
| 59 | reserved_out_slots_ = 1 + codegen->GetGraph()->GetMaximumNumberOfOutVRegs(); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 60 | } |
| 61 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 62 | bool RegisterAllocator::CanAllocateRegistersFor(const HGraph& graph, |
| 63 | InstructionSet instruction_set) { |
| 64 | if (!Supports(instruction_set)) { |
| 65 | return false; |
| 66 | } |
| 67 | for (size_t i = 0, e = graph.GetBlocks().Size(); i < e; ++i) { |
| 68 | for (HInstructionIterator it(graph.GetBlocks().Get(i)->GetInstructions()); |
| 69 | !it.Done(); |
| 70 | it.Advance()) { |
| 71 | HInstruction* current = it.Current(); |
| Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 72 | if (current->GetType() == Primitive::kPrimLong && instruction_set != kX86_64) return false; |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 73 | if ((current->GetType() == Primitive::kPrimFloat || current->GetType() == Primitive::kPrimDouble) |
| 74 | && instruction_set != kX86_64) { |
| 75 | return false; |
| 76 | } |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 77 | } |
| 78 | } |
| 79 | return true; |
| 80 | } |
| 81 | |
| 82 | static bool ShouldProcess(bool processing_core_registers, LiveInterval* interval) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 83 | if (interval == nullptr) return false; |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 84 | bool is_core_register = (interval->GetType() != Primitive::kPrimDouble) |
| 85 | && (interval->GetType() != Primitive::kPrimFloat); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 86 | return processing_core_registers == is_core_register; |
| 87 | } |
| 88 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 89 | void RegisterAllocator::AllocateRegisters() { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 90 | AllocateRegistersInternal(); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 91 | Resolve(); |
| 92 | |
| 93 | if (kIsDebugBuild) { |
| 94 | processing_core_registers_ = true; |
| 95 | ValidateInternal(true); |
| 96 | processing_core_registers_ = false; |
| 97 | ValidateInternal(true); |
| 98 | } |
| 99 | } |
| 100 | |
| 101 | void RegisterAllocator::BlockRegister(Location location, |
| 102 | size_t start, |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 103 | size_t end) { |
| Nicolas Geoffray | 56b9ee6 | 2014-10-09 11:47:51 +0100 | [diff] [blame] | 104 | int reg = location.reg(); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 105 | DCHECK(location.IsRegister() || location.IsFpuRegister()); |
| 106 | LiveInterval* interval = location.IsRegister() |
| 107 | ? physical_core_register_intervals_.Get(reg) |
| 108 | : physical_fp_register_intervals_.Get(reg); |
| 109 | Primitive::Type type = location.IsRegister() |
| 110 | ? Primitive::kPrimInt |
| 111 | : Primitive::kPrimDouble; |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 112 | if (interval == nullptr) { |
| 113 | interval = LiveInterval::MakeFixedInterval(allocator_, reg, type); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 114 | if (location.IsRegister()) { |
| 115 | physical_core_register_intervals_.Put(reg, interval); |
| 116 | } else { |
| 117 | physical_fp_register_intervals_.Put(reg, interval); |
| 118 | } |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 119 | } |
| 120 | DCHECK(interval->GetRegister() == reg); |
| 121 | interval->AddRange(start, end); |
| 122 | } |
| 123 | |
| 124 | void RegisterAllocator::AllocateRegistersInternal() { |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 125 | // Iterate post-order, to ensure the list is sorted, and the last added interval |
| 126 | // is the one with the lowest start position. |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 127 | for (HLinearPostOrderIterator it(liveness_); !it.Done(); it.Advance()) { |
| 128 | HBasicBlock* block = it.Current(); |
| Andreas Gampe | 277ccbd | 2014-11-03 21:36:10 -0800 | [diff] [blame^] | 129 | for (HBackwardInstructionIterator back_it(block->GetInstructions()); !back_it.Done(); |
| 130 | back_it.Advance()) { |
| 131 | ProcessInstruction(back_it.Current()); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 132 | } |
| Andreas Gampe | 277ccbd | 2014-11-03 21:36:10 -0800 | [diff] [blame^] | 133 | for (HInstructionIterator inst_it(block->GetPhis()); !inst_it.Done(); inst_it.Advance()) { |
| 134 | ProcessInstruction(inst_it.Current()); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 135 | } |
| 136 | } |
| 137 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 138 | number_of_registers_ = codegen_->GetNumberOfCoreRegisters(); |
| 139 | registers_array_ = allocator_->AllocArray<size_t>(number_of_registers_); |
| 140 | processing_core_registers_ = true; |
| 141 | unhandled_ = &unhandled_core_intervals_; |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 142 | for (size_t i = 0, e = physical_core_register_intervals_.Size(); i < e; ++i) { |
| 143 | LiveInterval* fixed = physical_core_register_intervals_.Get(i); |
| 144 | if (fixed != nullptr) { |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 145 | // Fixed interval is added to inactive_ instead of unhandled_. |
| 146 | // It's also the only type of inactive interval whose start position |
| 147 | // can be after the current interval during linear scan. |
| 148 | // Fixed interval is never split and never moves to unhandled_. |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 149 | inactive_.Add(fixed); |
| 150 | } |
| 151 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 152 | LinearScan(); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 153 | |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 154 | size_t saved_maximum_number_of_live_registers = maximum_number_of_live_registers_; |
| 155 | maximum_number_of_live_registers_ = 0; |
| 156 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 157 | inactive_.Reset(); |
| 158 | active_.Reset(); |
| 159 | handled_.Reset(); |
| 160 | |
| 161 | number_of_registers_ = codegen_->GetNumberOfFloatingPointRegisters(); |
| 162 | registers_array_ = allocator_->AllocArray<size_t>(number_of_registers_); |
| 163 | processing_core_registers_ = false; |
| 164 | unhandled_ = &unhandled_fp_intervals_; |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 165 | for (size_t i = 0, e = physical_fp_register_intervals_.Size(); i < e; ++i) { |
| 166 | LiveInterval* fixed = physical_fp_register_intervals_.Get(i); |
| 167 | if (fixed != nullptr) { |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 168 | // Fixed interval is added to inactive_ instead of unhandled_. |
| 169 | // It's also the only type of inactive interval whose start position |
| 170 | // can be after the current interval during linear scan. |
| 171 | // Fixed interval is never split and never moves to unhandled_. |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 172 | inactive_.Add(fixed); |
| 173 | } |
| 174 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 175 | LinearScan(); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 176 | maximum_number_of_live_registers_ += saved_maximum_number_of_live_registers; |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 177 | } |
| 178 | |
| 179 | void RegisterAllocator::ProcessInstruction(HInstruction* instruction) { |
| 180 | LocationSummary* locations = instruction->GetLocations(); |
| 181 | size_t position = instruction->GetLifetimePosition(); |
| 182 | |
| 183 | if (locations == nullptr) return; |
| 184 | |
| 185 | // Create synthesized intervals for temporaries. |
| 186 | for (size_t i = 0; i < locations->GetTempCount(); ++i) { |
| 187 | Location temp = locations->GetTemp(i); |
| 188 | if (temp.IsRegister()) { |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 189 | BlockRegister(temp, position, position + 1); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 190 | } else { |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 191 | DCHECK(temp.IsUnallocated()); |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 192 | LiveInterval* interval = LiveInterval::MakeTempInterval(allocator_, Primitive::kPrimInt); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 193 | temp_intervals_.Add(interval); |
| 194 | interval->AddRange(position, position + 1); |
| 195 | unhandled_core_intervals_.Add(interval); |
| 196 | } |
| 197 | } |
| 198 | |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 199 | bool core_register = (instruction->GetType() != Primitive::kPrimDouble) |
| 200 | && (instruction->GetType() != Primitive::kPrimFloat); |
| 201 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 202 | if (locations->CanCall()) { |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 203 | if (!instruction->IsSuspendCheck()) { |
| 204 | codegen_->MarkNotLeaf(); |
| 205 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 206 | safepoints_.Add(instruction); |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 207 | if (locations->OnlyCallsOnSlowPath()) { |
| 208 | // We add a synthesized range at this position to record the live registers |
| 209 | // at this position. Ideally, we could just update the safepoints when locations |
| 210 | // are updated, but we currently need to know the full stack size before updating |
| 211 | // locations (because of parameters and the fact that we don't have a frame pointer). |
| 212 | // And knowing the full stack size requires to know the maximum number of live |
| 213 | // registers at calls in slow paths. |
| 214 | // By adding the following interval in the algorithm, we can compute this |
| 215 | // maximum before updating locations. |
| 216 | LiveInterval* interval = LiveInterval::MakeSlowPathInterval(allocator_, instruction); |
| 217 | interval->AddRange(position, position + 1); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 218 | unhandled_core_intervals_.Add(interval); |
| 219 | unhandled_fp_intervals_.Add(interval); |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 220 | } |
| 221 | } |
| 222 | |
| 223 | if (locations->WillCall()) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 224 | // Block all registers. |
| 225 | for (size_t i = 0; i < codegen_->GetNumberOfCoreRegisters(); ++i) { |
| Nicolas Geoffray | 56b9ee6 | 2014-10-09 11:47:51 +0100 | [diff] [blame] | 226 | BlockRegister(Location::RegisterLocation(i), |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 227 | position, |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 228 | position + 1); |
| 229 | } |
| 230 | for (size_t i = 0; i < codegen_->GetNumberOfFloatingPointRegisters(); ++i) { |
| 231 | BlockRegister(Location::FpuRegisterLocation(i), |
| 232 | position, |
| 233 | position + 1); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 234 | } |
| 235 | } |
| 236 | |
| 237 | for (size_t i = 0; i < instruction->InputCount(); ++i) { |
| 238 | Location input = locations->InAt(i); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 239 | if (input.IsRegister() || input.IsFpuRegister()) { |
| 240 | BlockRegister(input, position, position + 1); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 241 | } |
| 242 | } |
| 243 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 244 | LiveInterval* current = instruction->GetLiveInterval(); |
| 245 | if (current == nullptr) return; |
| 246 | |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 247 | GrowableArray<LiveInterval*>& unhandled = core_register |
| 248 | ? unhandled_core_intervals_ |
| 249 | : unhandled_fp_intervals_; |
| 250 | |
| Nicolas Geoffray | 7690562 | 2014-09-25 14:39:26 +0100 | [diff] [blame] | 251 | DCHECK(unhandled.IsEmpty() || current->StartsBeforeOrAt(unhandled.Peek())); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 252 | // Some instructions define their output in fixed register/stack slot. We need |
| 253 | // to ensure we know these locations before doing register allocation. For a |
| 254 | // given register, we create an interval that covers these locations. The register |
| 255 | // will be unavailable at these locations when trying to allocate one for an |
| 256 | // interval. |
| 257 | // |
| 258 | // The backwards walking ensures the ranges are ordered on increasing start positions. |
| 259 | Location output = locations->Out(); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 260 | if (output.IsRegister() || output.IsFpuRegister()) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 261 | // Shift the interval's start by one to account for the blocked register. |
| 262 | current->SetFrom(position + 1); |
| Nicolas Geoffray | 56b9ee6 | 2014-10-09 11:47:51 +0100 | [diff] [blame] | 263 | current->SetRegister(output.reg()); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 264 | BlockRegister(output, position, position + 1); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 265 | } else if (output.IsStackSlot() || output.IsDoubleStackSlot()) { |
| 266 | current->SetSpillSlot(output.GetStackIndex()); |
| 267 | } |
| 268 | |
| 269 | // If needed, add interval to the list of unhandled intervals. |
| 270 | if (current->HasSpillSlot() || instruction->IsConstant()) { |
| Nicolas Geoffray | c8147a7 | 2014-10-21 16:06:20 +0100 | [diff] [blame] | 271 | // Split just before first register use. |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 272 | size_t first_register_use = current->FirstRegisterUse(); |
| 273 | if (first_register_use != kNoLifetime) { |
| Nicolas Geoffray | c8147a7 | 2014-10-21 16:06:20 +0100 | [diff] [blame] | 274 | LiveInterval* split = Split(current, first_register_use - 1); |
| Nicolas Geoffray | b5f62b3 | 2014-10-30 10:58:41 +0000 | [diff] [blame] | 275 | // Don't add directly to `unhandled`, it needs to be sorted and the start |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 276 | // of this new interval might be after intervals already in the list. |
| 277 | AddSorted(&unhandled, split); |
| 278 | } else { |
| 279 | // Nothing to do, we won't allocate a register for this value. |
| 280 | } |
| 281 | } else { |
| Nicolas Geoffray | b5f62b3 | 2014-10-30 10:58:41 +0000 | [diff] [blame] | 282 | // Don't add directly to `unhandled`, temp or safepoint intervals |
| 283 | // for this instruction may have been added, and those can be |
| 284 | // processed first. |
| 285 | AddSorted(&unhandled, current); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 286 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 287 | } |
| 288 | |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 289 | class AllRangesIterator : public ValueObject { |
| 290 | public: |
| 291 | explicit AllRangesIterator(LiveInterval* interval) |
| 292 | : current_interval_(interval), |
| 293 | current_range_(interval->GetFirstRange()) {} |
| 294 | |
| 295 | bool Done() const { return current_interval_ == nullptr; } |
| 296 | LiveRange* CurrentRange() const { return current_range_; } |
| 297 | LiveInterval* CurrentInterval() const { return current_interval_; } |
| 298 | |
| 299 | void Advance() { |
| 300 | current_range_ = current_range_->GetNext(); |
| 301 | if (current_range_ == nullptr) { |
| 302 | current_interval_ = current_interval_->GetNextSibling(); |
| 303 | if (current_interval_ != nullptr) { |
| 304 | current_range_ = current_interval_->GetFirstRange(); |
| 305 | } |
| 306 | } |
| 307 | } |
| 308 | |
| 309 | private: |
| 310 | LiveInterval* current_interval_; |
| 311 | LiveRange* current_range_; |
| 312 | |
| 313 | DISALLOW_COPY_AND_ASSIGN(AllRangesIterator); |
| 314 | }; |
| 315 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 316 | bool RegisterAllocator::ValidateInternal(bool log_fatal_on_failure) const { |
| 317 | // To simplify unit testing, we eagerly create the array of intervals, and |
| 318 | // call the helper method. |
| 319 | GrowableArray<LiveInterval*> intervals(allocator_, 0); |
| 320 | for (size_t i = 0; i < liveness_.GetNumberOfSsaValues(); ++i) { |
| 321 | HInstruction* instruction = liveness_.GetInstructionFromSsaIndex(i); |
| 322 | if (ShouldProcess(processing_core_registers_, instruction->GetLiveInterval())) { |
| 323 | intervals.Add(instruction->GetLiveInterval()); |
| 324 | } |
| 325 | } |
| 326 | |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 327 | if (processing_core_registers_) { |
| 328 | for (size_t i = 0, e = physical_core_register_intervals_.Size(); i < e; ++i) { |
| 329 | LiveInterval* fixed = physical_core_register_intervals_.Get(i); |
| 330 | if (fixed != nullptr) { |
| 331 | intervals.Add(fixed); |
| 332 | } |
| 333 | } |
| 334 | } else { |
| 335 | for (size_t i = 0, e = physical_fp_register_intervals_.Size(); i < e; ++i) { |
| 336 | LiveInterval* fixed = physical_fp_register_intervals_.Get(i); |
| 337 | if (fixed != nullptr) { |
| 338 | intervals.Add(fixed); |
| 339 | } |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 340 | } |
| 341 | } |
| 342 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 343 | for (size_t i = 0, e = temp_intervals_.Size(); i < e; ++i) { |
| 344 | LiveInterval* temp = temp_intervals_.Get(i); |
| 345 | if (ShouldProcess(processing_core_registers_, temp)) { |
| 346 | intervals.Add(temp); |
| 347 | } |
| 348 | } |
| 349 | |
| 350 | return ValidateIntervals(intervals, spill_slots_.Size(), reserved_out_slots_, *codegen_, |
| 351 | allocator_, processing_core_registers_, log_fatal_on_failure); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 352 | } |
| 353 | |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 354 | bool RegisterAllocator::ValidateIntervals(const GrowableArray<LiveInterval*>& intervals, |
| 355 | size_t number_of_spill_slots, |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 356 | size_t number_of_out_slots, |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 357 | const CodeGenerator& codegen, |
| 358 | ArenaAllocator* allocator, |
| 359 | bool processing_core_registers, |
| 360 | bool log_fatal_on_failure) { |
| 361 | size_t number_of_registers = processing_core_registers |
| 362 | ? codegen.GetNumberOfCoreRegisters() |
| 363 | : codegen.GetNumberOfFloatingPointRegisters(); |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 364 | GrowableArray<ArenaBitVector*> liveness_of_values( |
| 365 | allocator, number_of_registers + number_of_spill_slots); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 366 | |
| 367 | // Allocate a bit vector per register. A live interval that has a register |
| 368 | // allocated will populate the associated bit vector based on its live ranges. |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 369 | for (size_t i = 0; i < number_of_registers + number_of_spill_slots; ++i) { |
| 370 | liveness_of_values.Add(new (allocator) ArenaBitVector(allocator, 0, true)); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 371 | } |
| 372 | |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 373 | for (size_t i = 0, e = intervals.Size(); i < e; ++i) { |
| 374 | for (AllRangesIterator it(intervals.Get(i)); !it.Done(); it.Advance()) { |
| 375 | LiveInterval* current = it.CurrentInterval(); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 376 | HInstruction* defined_by = current->GetParent()->GetDefinedBy(); |
| 377 | if (current->GetParent()->HasSpillSlot() |
| 378 | // Parameters have their own stack slot. |
| 379 | && !(defined_by != nullptr && defined_by->IsParameterValue())) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 380 | BitVector* liveness_of_spill_slot = liveness_of_values.Get(number_of_registers |
| 381 | + current->GetParent()->GetSpillSlot() / kVRegSize |
| 382 | - number_of_out_slots); |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 383 | for (size_t j = it.CurrentRange()->GetStart(); j < it.CurrentRange()->GetEnd(); ++j) { |
| 384 | if (liveness_of_spill_slot->IsBitSet(j)) { |
| 385 | if (log_fatal_on_failure) { |
| 386 | std::ostringstream message; |
| 387 | message << "Spill slot conflict at " << j; |
| 388 | LOG(FATAL) << message.str(); |
| 389 | } else { |
| 390 | return false; |
| 391 | } |
| 392 | } else { |
| 393 | liveness_of_spill_slot->SetBit(j); |
| 394 | } |
| 395 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 396 | } |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 397 | |
| 398 | if (current->HasRegister()) { |
| 399 | BitVector* liveness_of_register = liveness_of_values.Get(current->GetRegister()); |
| 400 | for (size_t j = it.CurrentRange()->GetStart(); j < it.CurrentRange()->GetEnd(); ++j) { |
| 401 | if (liveness_of_register->IsBitSet(j)) { |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 402 | if (log_fatal_on_failure) { |
| 403 | std::ostringstream message; |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 404 | message << "Register conflict at " << j << " "; |
| 405 | if (defined_by != nullptr) { |
| 406 | message << "(" << defined_by->DebugName() << ")"; |
| 407 | } |
| 408 | message << "for "; |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 409 | if (processing_core_registers) { |
| 410 | codegen.DumpCoreRegister(message, current->GetRegister()); |
| 411 | } else { |
| 412 | codegen.DumpFloatingPointRegister(message, current->GetRegister()); |
| 413 | } |
| 414 | LOG(FATAL) << message.str(); |
| 415 | } else { |
| 416 | return false; |
| 417 | } |
| 418 | } else { |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 419 | liveness_of_register->SetBit(j); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 420 | } |
| 421 | } |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 422 | } |
| 423 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 424 | } |
| 425 | return true; |
| 426 | } |
| 427 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 428 | void RegisterAllocator::DumpInterval(std::ostream& stream, LiveInterval* interval) const { |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 429 | interval->Dump(stream); |
| 430 | stream << ": "; |
| 431 | if (interval->HasRegister()) { |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 432 | if (interval->IsFloatingPoint()) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 433 | codegen_->DumpFloatingPointRegister(stream, interval->GetRegister()); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 434 | } else { |
| 435 | codegen_->DumpCoreRegister(stream, interval->GetRegister()); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 436 | } |
| 437 | } else { |
| 438 | stream << "spilled"; |
| 439 | } |
| 440 | stream << std::endl; |
| 441 | } |
| 442 | |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 443 | void RegisterAllocator::DumpAllIntervals(std::ostream& stream) const { |
| 444 | stream << "inactive: " << std::endl; |
| 445 | for (size_t i = 0; i < inactive_.Size(); i ++) { |
| 446 | DumpInterval(stream, inactive_.Get(i)); |
| 447 | } |
| 448 | stream << "active: " << std::endl; |
| 449 | for (size_t i = 0; i < active_.Size(); i ++) { |
| 450 | DumpInterval(stream, active_.Get(i)); |
| 451 | } |
| 452 | stream << "unhandled: " << std::endl; |
| 453 | auto unhandled = (unhandled_ != nullptr) ? |
| 454 | unhandled_ : &unhandled_core_intervals_; |
| 455 | for (size_t i = 0; i < unhandled->Size(); i ++) { |
| 456 | DumpInterval(stream, unhandled->Get(i)); |
| 457 | } |
| 458 | stream << "handled: " << std::endl; |
| 459 | for (size_t i = 0; i < handled_.Size(); i ++) { |
| 460 | DumpInterval(stream, handled_.Get(i)); |
| 461 | } |
| 462 | } |
| 463 | |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 464 | // By the book implementation of a linear scan register allocator. |
| 465 | void RegisterAllocator::LinearScan() { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 466 | while (!unhandled_->IsEmpty()) { |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 467 | // (1) Remove interval with the lowest start position from unhandled. |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 468 | LiveInterval* current = unhandled_->Pop(); |
| 469 | DCHECK(!current->IsFixed() && !current->HasSpillSlot()); |
| Nicolas Geoffray | c8147a7 | 2014-10-21 16:06:20 +0100 | [diff] [blame] | 470 | DCHECK(unhandled_->IsEmpty() || unhandled_->Peek()->GetStart() >= current->GetStart()); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 471 | size_t position = current->GetStart(); |
| 472 | |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 473 | // Remember the inactive_ size here since the ones moved to inactive_ from |
| 474 | // active_ below shouldn't need to be re-checked. |
| 475 | size_t inactive_intervals_to_handle = inactive_.Size(); |
| 476 | |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 477 | // (2) Remove currently active intervals that are dead at this position. |
| 478 | // Move active intervals that have a lifetime hole at this position |
| 479 | // to inactive. |
| 480 | for (size_t i = 0; i < active_.Size(); ++i) { |
| 481 | LiveInterval* interval = active_.Get(i); |
| 482 | if (interval->IsDeadAt(position)) { |
| 483 | active_.Delete(interval); |
| 484 | --i; |
| 485 | handled_.Add(interval); |
| 486 | } else if (!interval->Covers(position)) { |
| 487 | active_.Delete(interval); |
| 488 | --i; |
| 489 | inactive_.Add(interval); |
| 490 | } |
| 491 | } |
| 492 | |
| 493 | // (3) Remove currently inactive intervals that are dead at this position. |
| 494 | // Move inactive intervals that cover this position to active. |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 495 | for (size_t i = 0; i < inactive_intervals_to_handle; ++i) { |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 496 | LiveInterval* interval = inactive_.Get(i); |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 497 | DCHECK(interval->GetStart() < position || interval->IsFixed()); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 498 | if (interval->IsDeadAt(position)) { |
| 499 | inactive_.Delete(interval); |
| 500 | --i; |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 501 | --inactive_intervals_to_handle; |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 502 | handled_.Add(interval); |
| 503 | } else if (interval->Covers(position)) { |
| 504 | inactive_.Delete(interval); |
| 505 | --i; |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 506 | --inactive_intervals_to_handle; |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 507 | active_.Add(interval); |
| 508 | } |
| 509 | } |
| 510 | |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 511 | if (current->IsSlowPathSafepoint()) { |
| 512 | // Synthesized interval to record the maximum number of live registers |
| 513 | // at safepoints. No need to allocate a register for it. |
| 514 | maximum_number_of_live_registers_ = |
| 515 | std::max(maximum_number_of_live_registers_, active_.Size()); |
| 516 | continue; |
| 517 | } |
| 518 | |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 519 | // (4) Try to find an available register. |
| 520 | bool success = TryAllocateFreeReg(current); |
| 521 | |
| 522 | // (5) If no register could be found, we need to spill. |
| 523 | if (!success) { |
| 524 | success = AllocateBlockedReg(current); |
| 525 | } |
| 526 | |
| 527 | // (6) If the interval had a register allocated, add it to the list of active |
| 528 | // intervals. |
| 529 | if (success) { |
| 530 | active_.Add(current); |
| 531 | } |
| 532 | } |
| 533 | } |
| 534 | |
| 535 | // Find a free register. If multiple are found, pick the register that |
| 536 | // is free the longest. |
| 537 | bool RegisterAllocator::TryAllocateFreeReg(LiveInterval* current) { |
| 538 | size_t* free_until = registers_array_; |
| 539 | |
| 540 | // First set all registers to be free. |
| 541 | for (size_t i = 0; i < number_of_registers_; ++i) { |
| 542 | free_until[i] = kMaxLifetimePosition; |
| 543 | } |
| 544 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 545 | // For each active interval, set its register to not free. |
| 546 | for (size_t i = 0, e = active_.Size(); i < e; ++i) { |
| 547 | LiveInterval* interval = active_.Get(i); |
| 548 | DCHECK(interval->HasRegister()); |
| 549 | free_until[interval->GetRegister()] = 0; |
| 550 | } |
| 551 | |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 552 | // For each inactive interval, set its register to be free until |
| 553 | // the next intersection with `current`. |
| 554 | for (size_t i = 0, e = inactive_.Size(); i < e; ++i) { |
| 555 | LiveInterval* inactive = inactive_.Get(i); |
| 556 | // Temp/Slow-path-safepoint interval has no holes. |
| 557 | DCHECK(!inactive->IsTemp() && !inactive->IsSlowPathSafepoint()); |
| 558 | if (!current->IsSplit() && !inactive->IsFixed()) { |
| 559 | // Neither current nor inactive are fixed. |
| 560 | // Thanks to SSA, a non-split interval starting in a hole of an |
| 561 | // inactive interval should never intersect with that inactive interval. |
| 562 | // Only if it's not fixed though, because fixed intervals don't come from SSA. |
| 563 | DCHECK_EQ(inactive->FirstIntersectionWith(current), kNoLifetime); |
| 564 | continue; |
| 565 | } |
| 566 | |
| 567 | DCHECK(inactive->HasRegister()); |
| 568 | if (free_until[inactive->GetRegister()] == 0) { |
| 569 | // Already used by some active interval. No need to intersect. |
| 570 | continue; |
| 571 | } |
| 572 | size_t next_intersection = inactive->FirstIntersectionWith(current); |
| 573 | if (next_intersection != kNoLifetime) { |
| 574 | free_until[inactive->GetRegister()] = |
| 575 | std::min(free_until[inactive->GetRegister()], next_intersection); |
| 576 | } |
| 577 | } |
| 578 | |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 579 | int reg = -1; |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 580 | if (current->HasRegister()) { |
| 581 | // Some instructions have a fixed register output. |
| 582 | reg = current->GetRegister(); |
| 583 | DCHECK_NE(free_until[reg], 0u); |
| 584 | } else { |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 585 | int hint = current->FindFirstRegisterHint(free_until); |
| 586 | if (hint != kNoRegister) { |
| 587 | DCHECK(!IsBlocked(hint)); |
| 588 | reg = hint; |
| 589 | } else { |
| 590 | // Pick the register that is free the longest. |
| 591 | for (size_t i = 0; i < number_of_registers_; ++i) { |
| 592 | if (IsBlocked(i)) continue; |
| 593 | if (reg == -1 || free_until[i] > free_until[reg]) { |
| 594 | reg = i; |
| 595 | if (free_until[i] == kMaxLifetimePosition) break; |
| 596 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 597 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 598 | } |
| 599 | } |
| 600 | |
| 601 | // If we could not find a register, we need to spill. |
| 602 | if (reg == -1 || free_until[reg] == 0) { |
| 603 | return false; |
| 604 | } |
| 605 | |
| 606 | current->SetRegister(reg); |
| 607 | if (!current->IsDeadAt(free_until[reg])) { |
| 608 | // If the register is only available for a subset of live ranges |
| 609 | // covered by `current`, split `current` at the position where |
| 610 | // the register is not available anymore. |
| 611 | LiveInterval* split = Split(current, free_until[reg]); |
| 612 | DCHECK(split != nullptr); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 613 | AddSorted(unhandled_, split); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 614 | } |
| 615 | return true; |
| 616 | } |
| 617 | |
| 618 | bool RegisterAllocator::IsBlocked(int reg) const { |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 619 | return processing_core_registers_ |
| 620 | ? blocked_core_registers_[reg] |
| 621 | : blocked_fp_registers_[reg]; |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 622 | } |
| 623 | |
| 624 | // Find the register that is used the last, and spill the interval |
| 625 | // that holds it. If the first use of `current` is after that register |
| 626 | // we spill `current` instead. |
| 627 | bool RegisterAllocator::AllocateBlockedReg(LiveInterval* current) { |
| 628 | size_t first_register_use = current->FirstRegisterUse(); |
| Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 629 | if (first_register_use == kNoLifetime) { |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 630 | AllocateSpillSlotFor(current); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 631 | return false; |
| 632 | } |
| 633 | |
| 634 | // First set all registers as not being used. |
| 635 | size_t* next_use = registers_array_; |
| 636 | for (size_t i = 0; i < number_of_registers_; ++i) { |
| 637 | next_use[i] = kMaxLifetimePosition; |
| 638 | } |
| 639 | |
| 640 | // For each active interval, find the next use of its register after the |
| 641 | // start of current. |
| 642 | for (size_t i = 0, e = active_.Size(); i < e; ++i) { |
| 643 | LiveInterval* active = active_.Get(i); |
| 644 | DCHECK(active->HasRegister()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 645 | if (active->IsFixed()) { |
| 646 | next_use[active->GetRegister()] = current->GetStart(); |
| 647 | } else { |
| 648 | size_t use = active->FirstRegisterUseAfter(current->GetStart()); |
| 649 | if (use != kNoLifetime) { |
| 650 | next_use[active->GetRegister()] = use; |
| 651 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 652 | } |
| 653 | } |
| 654 | |
| 655 | // For each inactive interval, find the next use of its register after the |
| 656 | // start of current. |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 657 | for (size_t i = 0, e = inactive_.Size(); i < e; ++i) { |
| 658 | LiveInterval* inactive = inactive_.Get(i); |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 659 | // Temp/Slow-path-safepoint interval has no holes. |
| 660 | DCHECK(!inactive->IsTemp() && !inactive->IsSlowPathSafepoint()); |
| 661 | if (!current->IsSplit() && !inactive->IsFixed()) { |
| 662 | // Neither current nor inactive are fixed. |
| 663 | // Thanks to SSA, a non-split interval starting in a hole of an |
| 664 | // inactive interval should never intersect with that inactive interval. |
| 665 | // Only if it's not fixed though, because fixed intervals don't come from SSA. |
| 666 | DCHECK_EQ(inactive->FirstIntersectionWith(current), kNoLifetime); |
| 667 | continue; |
| 668 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 669 | DCHECK(inactive->HasRegister()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 670 | size_t next_intersection = inactive->FirstIntersectionWith(current); |
| 671 | if (next_intersection != kNoLifetime) { |
| 672 | if (inactive->IsFixed()) { |
| 673 | next_use[inactive->GetRegister()] = |
| 674 | std::min(next_intersection, next_use[inactive->GetRegister()]); |
| 675 | } else { |
| 676 | size_t use = inactive->FirstRegisterUseAfter(current->GetStart()); |
| 677 | if (use != kNoLifetime) { |
| 678 | next_use[inactive->GetRegister()] = std::min(use, next_use[inactive->GetRegister()]); |
| 679 | } |
| 680 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 681 | } |
| 682 | } |
| 683 | |
| 684 | // Pick the register that is used the last. |
| 685 | int reg = -1; |
| 686 | for (size_t i = 0; i < number_of_registers_; ++i) { |
| 687 | if (IsBlocked(i)) continue; |
| 688 | if (reg == -1 || next_use[i] > next_use[reg]) { |
| 689 | reg = i; |
| 690 | if (next_use[i] == kMaxLifetimePosition) break; |
| 691 | } |
| 692 | } |
| 693 | |
| 694 | if (first_register_use >= next_use[reg]) { |
| 695 | // If the first use of that instruction is after the last use of the found |
| 696 | // register, we split this interval just before its first register use. |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 697 | AllocateSpillSlotFor(current); |
| Nicolas Geoffray | c8147a7 | 2014-10-21 16:06:20 +0100 | [diff] [blame] | 698 | LiveInterval* split = Split(current, first_register_use - 1); |
| 699 | DCHECK_NE(current, split) << "There is not enough registers available for " |
| 700 | << split->GetParent()->GetDefinedBy()->DebugName(); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 701 | AddSorted(unhandled_, split); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 702 | return false; |
| 703 | } else { |
| 704 | // Use this register and spill the active and inactives interval that |
| 705 | // have that register. |
| 706 | current->SetRegister(reg); |
| 707 | |
| 708 | for (size_t i = 0, e = active_.Size(); i < e; ++i) { |
| 709 | LiveInterval* active = active_.Get(i); |
| 710 | if (active->GetRegister() == reg) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 711 | DCHECK(!active->IsFixed()); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 712 | LiveInterval* split = Split(active, current->GetStart()); |
| 713 | active_.DeleteAt(i); |
| 714 | handled_.Add(active); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 715 | AddSorted(unhandled_, split); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 716 | break; |
| 717 | } |
| 718 | } |
| 719 | |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 720 | for (size_t i = 0, e = inactive_.Size(); i < e; ++i) { |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 721 | LiveInterval* inactive = inactive_.Get(i); |
| 722 | if (inactive->GetRegister() == reg) { |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 723 | if (!current->IsSplit() && !inactive->IsFixed()) { |
| 724 | // Neither current nor inactive are fixed. |
| 725 | // Thanks to SSA, a non-split interval starting in a hole of an |
| 726 | // inactive interval should never intersect with that inactive interval. |
| 727 | // Only if it's not fixed though, because fixed intervals don't come from SSA. |
| 728 | DCHECK_EQ(inactive->FirstIntersectionWith(current), kNoLifetime); |
| 729 | continue; |
| 730 | } |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 731 | size_t next_intersection = inactive->FirstIntersectionWith(current); |
| 732 | if (next_intersection != kNoLifetime) { |
| 733 | if (inactive->IsFixed()) { |
| 734 | LiveInterval* split = Split(current, next_intersection); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 735 | AddSorted(unhandled_, split); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 736 | } else { |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 737 | LiveInterval* split = Split(inactive, next_intersection); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 738 | inactive_.DeleteAt(i); |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 739 | --i; |
| 740 | --e; |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 741 | handled_.Add(inactive); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 742 | AddSorted(unhandled_, split); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 743 | } |
| 744 | } |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 745 | } |
| 746 | } |
| 747 | |
| 748 | return true; |
| 749 | } |
| 750 | } |
| 751 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 752 | void RegisterAllocator::AddSorted(GrowableArray<LiveInterval*>* array, LiveInterval* interval) { |
| Nicolas Geoffray | c8147a7 | 2014-10-21 16:06:20 +0100 | [diff] [blame] | 753 | DCHECK(!interval->IsFixed() && !interval->HasSpillSlot()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 754 | size_t insert_at = 0; |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 755 | for (size_t i = array->Size(); i > 0; --i) { |
| 756 | LiveInterval* current = array->Get(i - 1); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 757 | if (current->StartsAfter(interval)) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 758 | insert_at = i; |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 759 | break; |
| 760 | } |
| 761 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 762 | array->InsertAt(insert_at, interval); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 763 | } |
| 764 | |
| 765 | LiveInterval* RegisterAllocator::Split(LiveInterval* interval, size_t position) { |
| 766 | DCHECK(position >= interval->GetStart()); |
| 767 | DCHECK(!interval->IsDeadAt(position)); |
| 768 | if (position == interval->GetStart()) { |
| 769 | // Spill slot will be allocated when handling `interval` again. |
| 770 | interval->ClearRegister(); |
| 771 | return interval; |
| 772 | } else { |
| 773 | LiveInterval* new_interval = interval->SplitAt(position); |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 774 | return new_interval; |
| 775 | } |
| 776 | } |
| 777 | |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 778 | void RegisterAllocator::AllocateSpillSlotFor(LiveInterval* interval) { |
| 779 | LiveInterval* parent = interval->GetParent(); |
| 780 | |
| 781 | // An instruction gets a spill slot for its entire lifetime. If the parent |
| 782 | // of this interval already has a spill slot, there is nothing to do. |
| 783 | if (parent->HasSpillSlot()) { |
| 784 | return; |
| 785 | } |
| 786 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 787 | HInstruction* defined_by = parent->GetDefinedBy(); |
| 788 | if (defined_by->IsParameterValue()) { |
| 789 | // Parameters have their own stack slot. |
| 790 | parent->SetSpillSlot(codegen_->GetStackSlotOfParameter(defined_by->AsParameterValue())); |
| 791 | return; |
| 792 | } |
| 793 | |
| Nicolas Geoffray | 96f89a2 | 2014-07-11 10:57:49 +0100 | [diff] [blame] | 794 | if (defined_by->IsConstant()) { |
| 795 | // Constants don't need a spill slot. |
| 796 | return; |
| 797 | } |
| 798 | |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 799 | LiveInterval* last_sibling = interval; |
| 800 | while (last_sibling->GetNextSibling() != nullptr) { |
| 801 | last_sibling = last_sibling->GetNextSibling(); |
| 802 | } |
| 803 | size_t end = last_sibling->GetEnd(); |
| 804 | |
| Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 805 | // Find an available spill slot. |
| 806 | size_t slot = 0; |
| 807 | for (size_t e = spill_slots_.Size(); slot < e; ++slot) { |
| 808 | // We check if it is less rather than less or equal because the parallel move |
| 809 | // resolver does not work when a single spill slot needs to be exchanged with |
| 810 | // a double spill slot. The strict comparison avoids needing to exchange these |
| 811 | // locations at the same lifetime position. |
| 812 | if (spill_slots_.Get(slot) < parent->GetStart() |
| 813 | && (slot == (e - 1) || spill_slots_.Get(slot + 1) < parent->GetStart())) { |
| 814 | break; |
| 815 | } |
| 816 | } |
| 817 | |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 818 | if (parent->NeedsTwoSpillSlots()) { |
| Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 819 | if (slot == spill_slots_.Size()) { |
| 820 | // We need a new spill slot. |
| 821 | spill_slots_.Add(end); |
| 822 | spill_slots_.Add(end); |
| 823 | } else if (slot == spill_slots_.Size() - 1) { |
| 824 | spill_slots_.Put(slot, end); |
| 825 | spill_slots_.Add(end); |
| 826 | } else { |
| 827 | spill_slots_.Put(slot, end); |
| 828 | spill_slots_.Put(slot + 1, end); |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 829 | } |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 830 | } else { |
| Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 831 | if (slot == spill_slots_.Size()) { |
| 832 | // We need a new spill slot. |
| 833 | spill_slots_.Add(end); |
| 834 | } else { |
| 835 | spill_slots_.Put(slot, end); |
| 836 | } |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 837 | } |
| 838 | |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 839 | parent->SetSpillSlot((slot + reserved_out_slots_) * kVRegSize); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 840 | } |
| 841 | |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 842 | static bool IsValidDestination(Location destination) { |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 843 | return destination.IsRegister() |
| 844 | || destination.IsFpuRegister() |
| 845 | || destination.IsStackSlot() |
| 846 | || destination.IsDoubleStackSlot(); |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 847 | } |
| 848 | |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 849 | void RegisterAllocator::AddInputMoveFor(HInstruction* user, |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 850 | Location source, |
| 851 | Location destination) const { |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 852 | DCHECK(IsValidDestination(destination)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 853 | if (source.Equals(destination)) return; |
| 854 | |
| Roland Levillain | 476df55 | 2014-10-09 17:51:36 +0100 | [diff] [blame] | 855 | DCHECK(!user->IsPhi()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 856 | |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 857 | HInstruction* previous = user->GetPrevious(); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 858 | HParallelMove* move = nullptr; |
| 859 | if (previous == nullptr |
| Roland Levillain | 476df55 | 2014-10-09 17:51:36 +0100 | [diff] [blame] | 860 | || !previous->IsParallelMove() |
| Nicolas Geoffray | 8e3964b | 2014-10-17 11:06:38 +0100 | [diff] [blame] | 861 | || previous->GetLifetimePosition() < user->GetLifetimePosition()) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 862 | move = new (allocator_) HParallelMove(allocator_); |
| Nicolas Geoffray | 8e3964b | 2014-10-17 11:06:38 +0100 | [diff] [blame] | 863 | move->SetLifetimePosition(user->GetLifetimePosition()); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 864 | user->GetBlock()->InsertInstructionBefore(move, user); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 865 | } else { |
| 866 | move = previous->AsParallelMove(); |
| 867 | } |
| Nicolas Geoffray | 8e3964b | 2014-10-17 11:06:38 +0100 | [diff] [blame] | 868 | DCHECK_EQ(move->GetLifetimePosition(), user->GetLifetimePosition()); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 869 | move->AddMove(new (allocator_) MoveOperands(source, destination, nullptr)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 870 | } |
| 871 | |
| 872 | void RegisterAllocator::InsertParallelMoveAt(size_t position, |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 873 | HInstruction* instruction, |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 874 | Location source, |
| 875 | Location destination) const { |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 876 | DCHECK(IsValidDestination(destination)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 877 | if (source.Equals(destination)) return; |
| 878 | |
| 879 | HInstruction* at = liveness_.GetInstructionFromPosition(position / 2); |
| 880 | if (at == nullptr) { |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 881 | // Block boundary, don't do anything the connection of split siblings will handle it. |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 882 | return; |
| 883 | } |
| 884 | HParallelMove* move; |
| 885 | if ((position & 1) == 1) { |
| 886 | // Move must happen after the instruction. |
| 887 | DCHECK(!at->IsControlFlow()); |
| 888 | move = at->GetNext()->AsParallelMove(); |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 889 | // This is a parallel move for connecting siblings in a same block. We need to |
| 890 | // differentiate it with moves for connecting blocks, and input moves. |
| Nicolas Geoffray | 8e3964b | 2014-10-17 11:06:38 +0100 | [diff] [blame] | 891 | if (move == nullptr || move->GetLifetimePosition() > position) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 892 | move = new (allocator_) HParallelMove(allocator_); |
| 893 | move->SetLifetimePosition(position); |
| 894 | at->GetBlock()->InsertInstructionBefore(move, at->GetNext()); |
| 895 | } |
| 896 | } else { |
| 897 | // Move must happen before the instruction. |
| 898 | HInstruction* previous = at->GetPrevious(); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 899 | if (previous == nullptr |
| 900 | || !previous->IsParallelMove() |
| 901 | || previous->GetLifetimePosition() != position) { |
| 902 | // If the previous is a parallel move, then its position must be lower |
| 903 | // than the given `position`: it was added just after the non-parallel |
| 904 | // move instruction that precedes `instruction`. |
| 905 | DCHECK(previous == nullptr |
| 906 | || !previous->IsParallelMove() |
| 907 | || previous->GetLifetimePosition() < position); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 908 | move = new (allocator_) HParallelMove(allocator_); |
| 909 | move->SetLifetimePosition(position); |
| 910 | at->GetBlock()->InsertInstructionBefore(move, at); |
| 911 | } else { |
| 912 | move = previous->AsParallelMove(); |
| 913 | } |
| 914 | } |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 915 | DCHECK_EQ(move->GetLifetimePosition(), position); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 916 | move->AddMove(new (allocator_) MoveOperands(source, destination, instruction)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 917 | } |
| 918 | |
| 919 | void RegisterAllocator::InsertParallelMoveAtExitOf(HBasicBlock* block, |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 920 | HInstruction* instruction, |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 921 | Location source, |
| 922 | Location destination) const { |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 923 | DCHECK(IsValidDestination(destination)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 924 | if (source.Equals(destination)) return; |
| 925 | |
| 926 | DCHECK_EQ(block->GetSuccessors().Size(), 1u); |
| 927 | HInstruction* last = block->GetLastInstruction(); |
| Nicolas Geoffray | 360231a | 2014-10-08 21:07:48 +0100 | [diff] [blame] | 928 | // We insert moves at exit for phi predecessors and connecting blocks. |
| 929 | // A block ending with an if cannot branch to a block with phis because |
| 930 | // we do not allow critical edges. It can also not connect |
| 931 | // a split interval between two blocks: the move has to happen in the successor. |
| 932 | DCHECK(!last->IsIf()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 933 | HInstruction* previous = last->GetPrevious(); |
| 934 | HParallelMove* move; |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 935 | // This is a parallel move for connecting blocks. We need to differentiate |
| 936 | // it with moves for connecting siblings in a same block, and output moves. |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 937 | if (previous == nullptr || !previous->IsParallelMove() |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 938 | || previous->AsParallelMove()->GetLifetimePosition() != block->GetLifetimeEnd()) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 939 | move = new (allocator_) HParallelMove(allocator_); |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 940 | move->SetLifetimePosition(block->GetLifetimeEnd()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 941 | block->InsertInstructionBefore(move, last); |
| 942 | } else { |
| 943 | move = previous->AsParallelMove(); |
| 944 | } |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 945 | move->AddMove(new (allocator_) MoveOperands(source, destination, instruction)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 946 | } |
| 947 | |
| 948 | void RegisterAllocator::InsertParallelMoveAtEntryOf(HBasicBlock* block, |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 949 | HInstruction* instruction, |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 950 | Location source, |
| 951 | Location destination) const { |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 952 | DCHECK(IsValidDestination(destination)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 953 | if (source.Equals(destination)) return; |
| 954 | |
| 955 | HInstruction* first = block->GetFirstInstruction(); |
| 956 | HParallelMove* move = first->AsParallelMove(); |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 957 | // This is a parallel move for connecting blocks. We need to differentiate |
| 958 | // it with moves for connecting siblings in a same block, and input moves. |
| 959 | if (move == nullptr || move->GetLifetimePosition() != block->GetLifetimeStart()) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 960 | move = new (allocator_) HParallelMove(allocator_); |
| 961 | move->SetLifetimePosition(block->GetLifetimeStart()); |
| 962 | block->InsertInstructionBefore(move, first); |
| 963 | } |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 964 | move->AddMove(new (allocator_) MoveOperands(source, destination, instruction)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 965 | } |
| 966 | |
| 967 | void RegisterAllocator::InsertMoveAfter(HInstruction* instruction, |
| 968 | Location source, |
| 969 | Location destination) const { |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 970 | DCHECK(IsValidDestination(destination)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 971 | if (source.Equals(destination)) return; |
| 972 | |
| Roland Levillain | 476df55 | 2014-10-09 17:51:36 +0100 | [diff] [blame] | 973 | if (instruction->IsPhi()) { |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 974 | InsertParallelMoveAtEntryOf(instruction->GetBlock(), instruction, source, destination); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 975 | return; |
| 976 | } |
| 977 | |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 978 | size_t position = instruction->GetLifetimePosition() + 1; |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 979 | HParallelMove* move = instruction->GetNext()->AsParallelMove(); |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 980 | // This is a parallel move for moving the output of an instruction. We need |
| 981 | // to differentiate with input moves, moves for connecting siblings in a |
| 982 | // and moves for connecting blocks. |
| 983 | if (move == nullptr || move->GetLifetimePosition() != position) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 984 | move = new (allocator_) HParallelMove(allocator_); |
| Nicolas Geoffray | e27f31a | 2014-06-12 17:53:14 +0100 | [diff] [blame] | 985 | move->SetLifetimePosition(position); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 986 | instruction->GetBlock()->InsertInstructionBefore(move, instruction->GetNext()); |
| 987 | } |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 988 | move->AddMove(new (allocator_) MoveOperands(source, destination, instruction)); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 989 | } |
| 990 | |
| 991 | void RegisterAllocator::ConnectSiblings(LiveInterval* interval) { |
| 992 | LiveInterval* current = interval; |
| 993 | if (current->HasSpillSlot() && current->HasRegister()) { |
| 994 | // We spill eagerly, so move must be at definition. |
| 995 | InsertMoveAfter(interval->GetDefinedBy(), |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 996 | interval->IsFloatingPoint() |
| 997 | ? Location::FpuRegisterLocation(interval->GetRegister()) |
| 998 | : Location::RegisterLocation(interval->GetRegister()), |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 999 | interval->NeedsTwoSpillSlots() |
| Nicolas Geoffray | 412f10c | 2014-06-19 10:00:34 +0100 | [diff] [blame] | 1000 | ? Location::DoubleStackSlot(interval->GetParent()->GetSpillSlot()) |
| 1001 | : Location::StackSlot(interval->GetParent()->GetSpillSlot())); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1002 | } |
| 1003 | UsePosition* use = current->GetFirstUse(); |
| 1004 | |
| 1005 | // Walk over all siblings, updating locations of use positions, and |
| 1006 | // connecting them when they are adjacent. |
| 1007 | do { |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1008 | Location source = current->ToLocation(); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1009 | |
| 1010 | // Walk over all uses covered by this interval, and update the location |
| 1011 | // information. |
| 1012 | while (use != nullptr && use->GetPosition() <= current->GetEnd()) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1013 | LocationSummary* locations = use->GetUser()->GetLocations(); |
| 1014 | if (use->GetIsEnvironment()) { |
| 1015 | locations->SetEnvironmentAt(use->GetInputIndex(), source); |
| 1016 | } else { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1017 | Location expected_location = locations->InAt(use->GetInputIndex()); |
| 1018 | if (expected_location.IsUnallocated()) { |
| 1019 | locations->SetInAt(use->GetInputIndex(), source); |
| Nicolas Geoffray | 2a877f3 | 2014-09-10 10:49:34 +0100 | [diff] [blame] | 1020 | } else if (!expected_location.IsConstant()) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1021 | AddInputMoveFor(use->GetUser(), source, expected_location); |
| 1022 | } |
| 1023 | } |
| 1024 | use = use->GetNext(); |
| 1025 | } |
| 1026 | |
| 1027 | // If the next interval starts just after this one, and has a register, |
| 1028 | // insert a move. |
| 1029 | LiveInterval* next_sibling = current->GetNextSibling(); |
| 1030 | if (next_sibling != nullptr |
| 1031 | && next_sibling->HasRegister() |
| 1032 | && current->GetEnd() == next_sibling->GetStart()) { |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1033 | Location destination = next_sibling->ToLocation(); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 1034 | InsertParallelMoveAt(current->GetEnd(), interval->GetDefinedBy(), source, destination); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1035 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1036 | |
| 1037 | // At each safepoint, we record stack and register information. |
| 1038 | for (size_t i = 0, e = safepoints_.Size(); i < e; ++i) { |
| 1039 | HInstruction* safepoint = safepoints_.Get(i); |
| 1040 | size_t position = safepoint->GetLifetimePosition(); |
| 1041 | LocationSummary* locations = safepoint->GetLocations(); |
| Nicolas Geoffray | b5f62b3 | 2014-10-30 10:58:41 +0000 | [diff] [blame] | 1042 | if (!current->Covers(position)) { |
| 1043 | continue; |
| 1044 | } |
| 1045 | if (interval->GetStart() == position) { |
| 1046 | // The safepoint is for this instruction, so the location of the instruction |
| 1047 | // does not need to be saved. |
| 1048 | continue; |
| 1049 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1050 | |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 1051 | if ((current->GetType() == Primitive::kPrimNot) && current->GetParent()->HasSpillSlot()) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1052 | locations->SetStackBit(current->GetParent()->GetSpillSlot() / kVRegSize); |
| 1053 | } |
| 1054 | |
| 1055 | switch (source.GetKind()) { |
| 1056 | case Location::kRegister: { |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 1057 | locations->AddLiveRegister(source); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1058 | if (current->GetType() == Primitive::kPrimNot) { |
| Nicolas Geoffray | 56b9ee6 | 2014-10-09 11:47:51 +0100 | [diff] [blame] | 1059 | locations->SetRegisterBit(source.reg()); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1060 | } |
| 1061 | break; |
| 1062 | } |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 1063 | case Location::kFpuRegister: { |
| 1064 | locations->AddLiveRegister(source); |
| 1065 | break; |
| 1066 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1067 | case Location::kStackSlot: // Fall-through |
| 1068 | case Location::kDoubleStackSlot: // Fall-through |
| 1069 | case Location::kConstant: { |
| 1070 | // Nothing to do. |
| 1071 | break; |
| 1072 | } |
| 1073 | default: { |
| 1074 | LOG(FATAL) << "Unexpected location for object"; |
| 1075 | } |
| 1076 | } |
| 1077 | } |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1078 | current = next_sibling; |
| 1079 | } while (current != nullptr); |
| 1080 | DCHECK(use == nullptr); |
| 1081 | } |
| 1082 | |
| 1083 | void RegisterAllocator::ConnectSplitSiblings(LiveInterval* interval, |
| 1084 | HBasicBlock* from, |
| 1085 | HBasicBlock* to) const { |
| 1086 | if (interval->GetNextSibling() == nullptr) { |
| 1087 | // Nothing to connect. The whole range was allocated to the same location. |
| 1088 | return; |
| 1089 | } |
| 1090 | |
| 1091 | size_t from_position = from->GetLifetimeEnd() - 1; |
| Mingyao Yang | 296bd60 | 2014-10-06 16:47:28 -0700 | [diff] [blame] | 1092 | // When an instruction dies at entry of another, and the latter is the beginning |
| Nicolas Geoffray | 7690562 | 2014-09-25 14:39:26 +0100 | [diff] [blame] | 1093 | // of a block, the register allocator ensures the former has a register |
| 1094 | // at block->GetLifetimeStart() + 1. Since this is at a block boundary, it must |
| 1095 | // must be handled in this method. |
| 1096 | size_t to_position = to->GetLifetimeStart() + 1; |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1097 | |
| 1098 | LiveInterval* destination = nullptr; |
| 1099 | LiveInterval* source = nullptr; |
| 1100 | |
| 1101 | LiveInterval* current = interval; |
| 1102 | |
| 1103 | // Check the intervals that cover `from` and `to`. |
| 1104 | while ((current != nullptr) && (source == nullptr || destination == nullptr)) { |
| 1105 | if (current->Covers(from_position)) { |
| 1106 | DCHECK(source == nullptr); |
| 1107 | source = current; |
| 1108 | } |
| 1109 | if (current->Covers(to_position)) { |
| 1110 | DCHECK(destination == nullptr); |
| 1111 | destination = current; |
| 1112 | } |
| 1113 | |
| 1114 | current = current->GetNextSibling(); |
| 1115 | } |
| 1116 | |
| 1117 | if (destination == source) { |
| 1118 | // Interval was not split. |
| 1119 | return; |
| 1120 | } |
| 1121 | |
| Nicolas Geoffray | 8ddb00c | 2014-09-29 12:00:40 +0100 | [diff] [blame] | 1122 | DCHECK(destination != nullptr && source != nullptr); |
| 1123 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1124 | if (!destination->HasRegister()) { |
| 1125 | // Values are eagerly spilled. Spill slot already contains appropriate value. |
| 1126 | return; |
| 1127 | } |
| 1128 | |
| 1129 | // If `from` has only one successor, we can put the moves at the exit of it. Otherwise |
| 1130 | // we need to put the moves at the entry of `to`. |
| 1131 | if (from->GetSuccessors().Size() == 1) { |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 1132 | InsertParallelMoveAtExitOf(from, |
| 1133 | interval->GetParent()->GetDefinedBy(), |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1134 | source->ToLocation(), |
| 1135 | destination->ToLocation()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1136 | } else { |
| 1137 | DCHECK_EQ(to->GetPredecessors().Size(), 1u); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 1138 | InsertParallelMoveAtEntryOf(to, |
| 1139 | interval->GetParent()->GetDefinedBy(), |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1140 | source->ToLocation(), |
| 1141 | destination->ToLocation()); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1142 | } |
| 1143 | } |
| 1144 | |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1145 | void RegisterAllocator::Resolve() { |
| Nicolas Geoffray | 3bca0df | 2014-09-19 11:01:00 +0100 | [diff] [blame] | 1146 | codegen_->ComputeFrameSize( |
| 1147 | spill_slots_.Size(), maximum_number_of_live_registers_, reserved_out_slots_); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1148 | |
| 1149 | // Adjust the Out Location of instructions. |
| 1150 | // TODO: Use pointers of Location inside LiveInterval to avoid doing another iteration. |
| 1151 | for (size_t i = 0, e = liveness_.GetNumberOfSsaValues(); i < e; ++i) { |
| 1152 | HInstruction* instruction = liveness_.GetInstructionFromSsaIndex(i); |
| 1153 | LiveInterval* current = instruction->GetLiveInterval(); |
| 1154 | LocationSummary* locations = instruction->GetLocations(); |
| 1155 | Location location = locations->Out(); |
| Roland Levillain | 476df55 | 2014-10-09 17:51:36 +0100 | [diff] [blame] | 1156 | if (instruction->IsParameterValue()) { |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1157 | // Now that we know the frame size, adjust the parameter's location. |
| 1158 | if (location.IsStackSlot()) { |
| 1159 | location = Location::StackSlot(location.GetStackIndex() + codegen_->GetFrameSize()); |
| 1160 | current->SetSpillSlot(location.GetStackIndex()); |
| 1161 | locations->SetOut(location); |
| 1162 | } else if (location.IsDoubleStackSlot()) { |
| 1163 | location = Location::DoubleStackSlot(location.GetStackIndex() + codegen_->GetFrameSize()); |
| 1164 | current->SetSpillSlot(location.GetStackIndex()); |
| 1165 | locations->SetOut(location); |
| 1166 | } else if (current->HasSpillSlot()) { |
| 1167 | current->SetSpillSlot(current->GetSpillSlot() + codegen_->GetFrameSize()); |
| 1168 | } |
| 1169 | } |
| 1170 | |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1171 | Location source = current->ToLocation(); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1172 | |
| 1173 | if (location.IsUnallocated()) { |
| 1174 | if (location.GetPolicy() == Location::kSameAsFirstInput) { |
| 1175 | locations->SetInAt(0, source); |
| 1176 | } |
| 1177 | locations->SetOut(source); |
| 1178 | } else { |
| 1179 | DCHECK(source.Equals(location)); |
| 1180 | } |
| 1181 | } |
| 1182 | |
| 1183 | // Connect siblings. |
| 1184 | for (size_t i = 0, e = liveness_.GetNumberOfSsaValues(); i < e; ++i) { |
| 1185 | HInstruction* instruction = liveness_.GetInstructionFromSsaIndex(i); |
| 1186 | ConnectSiblings(instruction->GetLiveInterval()); |
| 1187 | } |
| 1188 | |
| 1189 | // Resolve non-linear control flow across branches. Order does not matter. |
| 1190 | for (HLinearOrderIterator it(liveness_); !it.Done(); it.Advance()) { |
| 1191 | HBasicBlock* block = it.Current(); |
| 1192 | BitVector* live = liveness_.GetLiveInSet(*block); |
| 1193 | for (uint32_t idx : live->Indexes()) { |
| 1194 | HInstruction* current = liveness_.GetInstructionFromSsaIndex(idx); |
| 1195 | LiveInterval* interval = current->GetLiveInterval(); |
| 1196 | for (size_t i = 0, e = block->GetPredecessors().Size(); i < e; ++i) { |
| 1197 | ConnectSplitSiblings(interval, block->GetPredecessors().Get(i), block); |
| 1198 | } |
| 1199 | } |
| 1200 | } |
| 1201 | |
| 1202 | // Resolve phi inputs. Order does not matter. |
| 1203 | for (HLinearOrderIterator it(liveness_); !it.Done(); it.Advance()) { |
| 1204 | HBasicBlock* current = it.Current(); |
| Andreas Gampe | 277ccbd | 2014-11-03 21:36:10 -0800 | [diff] [blame^] | 1205 | for (HInstructionIterator inst_it(current->GetPhis()); !inst_it.Done(); inst_it.Advance()) { |
| 1206 | HInstruction* phi = inst_it.Current(); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1207 | for (size_t i = 0, e = current->GetPredecessors().Size(); i < e; ++i) { |
| 1208 | HBasicBlock* predecessor = current->GetPredecessors().Get(i); |
| 1209 | DCHECK_EQ(predecessor->GetSuccessors().Size(), 1u); |
| 1210 | HInstruction* input = phi->InputAt(i); |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1211 | Location source = input->GetLiveInterval()->GetLocationAt( |
| 1212 | predecessor->GetLifetimeEnd() - 1); |
| 1213 | Location destination = phi->GetLiveInterval()->ToLocation(); |
| Nicolas Geoffray | 740475d | 2014-09-29 10:33:25 +0100 | [diff] [blame] | 1214 | InsertParallelMoveAtExitOf(predecessor, nullptr, source, destination); |
| Nicolas Geoffray | 86dbb9a | 2014-06-04 11:12:39 +0100 | [diff] [blame] | 1215 | } |
| 1216 | } |
| 1217 | } |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1218 | |
| 1219 | // Assign temp locations. |
| 1220 | HInstruction* current = nullptr; |
| 1221 | size_t temp_index = 0; |
| 1222 | for (size_t i = 0; i < temp_intervals_.Size(); ++i) { |
| 1223 | LiveInterval* temp = temp_intervals_.Get(i); |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1224 | HInstruction* at = liveness_.GetTempUser(temp); |
| 1225 | if (at != current) { |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1226 | temp_index = 0; |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1227 | current = at; |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1228 | } |
| Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 1229 | LocationSummary* locations = at->GetLocations(); |
| Nicolas Geoffray | 102cbed | 2014-10-15 18:31:05 +0100 | [diff] [blame] | 1230 | DCHECK(temp->GetType() == Primitive::kPrimInt); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1231 | locations->SetTempAt( |
| Nicolas Geoffray | 56b9ee6 | 2014-10-09 11:47:51 +0100 | [diff] [blame] | 1232 | temp_index++, Location::RegisterLocation(temp->GetRegister())); |
| Nicolas Geoffray | 3946844 | 2014-09-02 15:17:15 +0100 | [diff] [blame] | 1233 | } |
| Nicolas Geoffray | 31d76b4 | 2014-06-09 15:02:22 +0100 | [diff] [blame] | 1234 | } |
| 1235 | |
| Nicolas Geoffray | a7062e0 | 2014-05-22 12:50:17 +0100 | [diff] [blame] | 1236 | } // namespace art |